ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
line unused | public TYPE_4 ( TYPE_1 config , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { this . VAR_3 = VAR_3 ; <START> String s = config . getString ( STRING_1 , null , STRING_2 ) ; <END> VAR_4 = VAR_2 . METHOD_1 ( config . getString ( STRING_1 , null , STRING_2 ) ) ; } | public TYPE_4 ( TYPE_1 config , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { this . VAR_3 = VAR_3 ; VAR_4 = VAR_2 . METHOD_1 ( config . getString ( STRING_1 , null , STRING_2 ) ) ; } |
public | <START> TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 n ) { <END> VAR_3 = VAR_2 ; VAR_4 = n ; } | public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 n ) { VAR_3 = VAR_2 ; VAR_4 = n ; } |
public | <START> TYPE_3 ( TYPE_1 VAR_2 , TYPE_1 VAR_3 , TYPE_1 VAR_4 , TYPE_2 n ) { <END> super ( VAR_2 , VAR_3 , VAR_4 , n ) ; } | public TYPE_3 ( TYPE_1 VAR_2 , TYPE_1 VAR_3 , TYPE_1 VAR_4 , TYPE_2 n ) { super ( VAR_2 , VAR_3 , VAR_4 , n ) ; } |
public | <START> TYPE_3 ( TYPE_1 VAR_2 , TYPE_1 VAR_3 , TYPE_1 VAR_4 , TYPE_1 VAR_5 , TYPE_2 n ) { <END> VAR_6 = VAR_2 ; VAR_7 = VAR_3 ; VAR_8 = VAR_4 ; VAR_9 = VAR_5 ; VAR_10 = n ; } | public TYPE_3 ( TYPE_1 VAR_2 , TYPE_1 VAR_3 , TYPE_1 VAR_4 , TYPE_1 VAR_5 , TYPE_2 n ) { VAR_6 = VAR_2 ; VAR_7 = VAR_3 ; VAR_8 = VAR_4 ; VAR_9 = VAR_5 ; VAR_10 = n ; } |
VAR_1 list - empty copy elements new VAR_1 list simply discard leak | public void METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> this . VAR_1 = VAR_1 ; <END> } | public void METHOD_1 ( List < TYPE_1 > VAR_1 ) { if ( ! this . VAR_1 . isEmpty ( ) ) { VAR_1 . addAll ( this . VAR_1 ) ; } this . VAR_1 = VAR_1 ; } |
VAR_1 | public static String METHOD_1 ( final TYPE_1 . Status status ) { if ( status == null ) { return "" ; } switch ( status ) { case VAR_1 : return TYPE_2 . METHOD_2 ( ) ; case VAR_2 : return TYPE_2 . METHOD_3 ( ) ; case VAR_3 : return TYPE_2 . METHOD_4 ( ) ; case VAR_4 : return TYPE_2 . METHOD_5 ( ) ; <START> case VAR_5 : <END> return TYPE_2 . METHOD_6 ( ) ; default : return status . name ( ) ; } } | public static String METHOD_1 ( final TYPE_1 . Status status ) { if ( status == null ) { return "" ; } switch ( status ) { case VAR_5 : return TYPE_2 . METHOD_6 ( ) ; case VAR_1 : return TYPE_2 . METHOD_2 ( ) ; case VAR_2 : return TYPE_2 . METHOD_3 ( ) ; case VAR_3 : return TYPE_2 . METHOD_4 ( ) ; case VAR_4 : return TYPE_2 . METHOD_5 ( ) ; default : return status . name ( ) ; } } |
wrong place : ) unordered retrieval line 216 | <START> public List < TYPE_1 > METHOD_1 ( TYPE_2 < TYPE_3 > db ) <END> throws TYPE_4 { if ( VAR_1 == null ) { VAR_1 = db . get ( ) . METHOD_2 ( ) . METHOD_3 ( VAR_2 ) . METHOD_4 ( ) ; } return VAR_1 ; } | public Collection < TYPE_1 > METHOD_1 ( TYPE_2 < TYPE_3 > db ) throws TYPE_4 { if ( VAR_1 == null ) { VAR_1 = db . get ( ) . METHOD_2 ( ) . METHOD_3 ( VAR_2 ) . METHOD_4 ( ) ; } return VAR_1 ; } |
style : brackets single statement ifs | private boolean METHOD_1 ( TYPE_1 req , TYPE_2 VAR_1 ) throws IOException { <START> if ( ! VAR_2 . METHOD_2 ( ) ) <END> return true ; final String VAR_3 = req . VAR_4 ( ) ; final TYPE_3 VAR_5 = VAR_6 . METHOD_3 ( VAR_3 ) ; if ( VAR_5 == null || ! VAR_5 . METHOD_4 ( ) . METHOD_5 ( ) ) { VAR_1 . METHOD_6 ( VAR_7 ) ; return false ; } session . get ( ) . METHOD_7 ( VAR_5 . METHOD_4 ( ) . getId ( ) ) ; return true ; } | private boolean METHOD_1 ( TYPE_1 req , TYPE_2 VAR_1 ) throws IOException { final String VAR_3 = req . VAR_4 ( ) ; final TYPE_3 VAR_5 = ( VAR_3 == null ) ? null : VAR_6 . METHOD_3 ( VAR_3 ) ; if ( VAR_5 == null || ! VAR_5 . METHOD_4 ( ) . METHOD_5 ( ) ) { VAR_1 . METHOD_6 ( VAR_7 ) ; return false ; } session . get ( ) . METHOD_7 ( VAR_5 . METHOD_4 ( ) . getId ( ) ) ; return true ; } |
I don t need ! VAR_1 METHOD_2 ( STRING_2 ) I a hack bug eclipse create change ids groupids aren t I fine hack ( wanna check shawn ) | private static boolean METHOD_1 ( String VAR_1 ) { <START> return VAR_1 . METHOD_2 ( STRING_1 ) && ! VAR_1 . METHOD_2 ( STRING_2 ) ; <END> } | private static boolean METHOD_1 ( String VAR_1 ) { return VAR_1 . METHOD_2 ( STRING_1 ) ; } |
VAR_1 = VAR_1 * INT_1 + ( VAR_5 ? 1 : 0 ) | public int METHOD_1 ( ) { int VAR_1 = 0 ; if ( VAR_2 != null ) { VAR_1 = VAR_1 * INT_1 + VAR_2 . METHOD_1 ( ) ; } VAR_1 = VAR_1 * INT_1 + VAR_3 . METHOD_1 ( ) ; VAR_1 = VAR_1 * INT_1 + VAR_4 . name ( ) . METHOD_1 ( ) ; <START> VAR_1 = VAR_1 * INT_1 + VAR_5 . METHOD_1 ( ) ; <END> return VAR_1 ; } | public int METHOD_1 ( ) { int VAR_1 = 0 ; if ( VAR_2 != null ) { VAR_1 = VAR_1 * INT_1 + VAR_2 . METHOD_1 ( ) ; } VAR_1 = VAR_1 * INT_1 + VAR_3 . METHOD_1 ( ) ; VAR_1 = VAR_1 * INT_1 + VAR_4 . name ( ) . METHOD_1 ( ) ; VAR_1 = VAR_1 * INT_1 + ( VAR_5 ? 1 : 0 ) ; return VAR_1 ; } |
autoboxed dont need call constructor explicitly | private TYPE_1 METHOD_1 ( TYPE_2 c , TYPE_3 VAR_1 ) { TYPE_1 d = METHOD_2 ( c , VAR_1 ) ; <START> d . VAR_2 = new Boolean ( c . VAR_3 ( ) . equals ( VAR_1 . getId ( ) ) ) ; <END> return d ; } | private TYPE_1 METHOD_1 ( TYPE_2 c , TYPE_3 VAR_1 ) { TYPE_1 d = METHOD_2 ( c , VAR_1 ) ; d . VAR_2 = c . VAR_3 ( ) . equals ( VAR_1 . getId ( ) ) ; return d ; } |
style - : wrap block curly braces | private Collection < File > METHOD_1 ( ) throws IOException { <START> if ( VAR_1 == null || ! VAR_1 . exists ( ) ) <END> return Collections . VAR_2 ( ) ; return TYPE_1 . METHOD_2 ( VAR_1 , new String [ ] { STRING_1 } , false ) ; } | private Collection < File > METHOD_1 ( ) throws IOException { if ( VAR_1 == null || ! VAR_1 . exists ( ) ) { return Collections . VAR_2 ( ) ; } return TYPE_1 . METHOD_2 ( VAR_1 , new String [ ] { STRING_1 } , false ) ; } |
public package visible | <START> public void METHOD_1 ( Status VAR_1 ) { <END> this . status = VAR_1 ; } | void METHOD_1 ( Status VAR_1 ) { this . status = VAR_1 ; } |
future calls _CODE_ unexpectedly NPE handle _CODE_ fail harder static block a thrown runtime exception error prevent class initializing server running | } catch ( Exception e ) { LOG . error ( STRING_1 ) ; <START> VAR_1 = null ; <END> } | } catch ( Exception e ) { log . error ( STRING_1 ) ; } |
need replacement STRING_1 STRING_2 | public static String METHOD_1 ( final String VAR_1 ) { <START> String user = TYPE_1 . METHOD_2 ( VAR_1 ) . METHOD_3 ( STRING_1 , STRING_2 ) ; <END> return STRING_3 + user + STRING_4 + VAR_2 ; } | public static String METHOD_1 ( final String VAR_1 ) { return STRING_3 + TYPE_1 . METHOD_2 ( VAR_1 ) + STRING_4 + VAR_2 ; } |
simplify : TYPE_1 TYPE_3 VAR_5 = group VAR_4 ( ) drop _CODE_ | public boolean METHOD_1 ( ) { if ( VAR_1 == null ) { TYPE_1 VAR_2 = VAR_3 . get ( group . VAR_4 ( ) ) ; <START> TYPE_1 . TYPE_3 VAR_5 = VAR_2 != null ? VAR_2 . METHOD_2 ( ) : null ; <END> VAR_1 = METHOD_3 ( ) . METHOD_4 ( ) . contains ( VAR_5 ) || METHOD_3 ( ) . METHOD_5 ( ) . METHOD_6 ( ) ; } return VAR_1 ; } | public boolean METHOD_1 ( ) { if ( VAR_1 == null ) { TYPE_1 . TYPE_3 VAR_5 = group . VAR_4 ( ) ; VAR_1 = METHOD_3 ( ) . METHOD_4 ( ) . contains ( VAR_5 ) || METHOD_3 ( ) . METHOD_5 ( ) . METHOD_6 ( ) ; } return VAR_1 ; } |
2 TimeUnit HOURS more readable tied a listener sense expire default ? other caches don t expire days rely invalidation messages | public static TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( ) { @Override protected void METHOD_2 ( ) { cache ( VAR_1 , TYPE_7 . TYPE_8 . class , new TYPE_4 < List < TYPE_5 > > ( ) { } ) . METHOD_3 ( INT_1 ) <START> . METHOD_4 ( INT_2 , TimeUnit . VAR_2 ) <END> . METHOD_5 ( TYPE_6 . class ) ; } } ; } | public static TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( ) { @Override protected void METHOD_2 ( ) { cache ( VAR_1 , TYPE_7 . TYPE_8 . class , new TYPE_4 < List < TYPE_5 > > ( ) { } ) . METHOD_3 ( INT_1 ) . METHOD_5 ( TYPE_6 . class ) ; } } ; } |
new line appended VAR_3 empty VAR_1 | private TYPE_1 METHOD_1 ( String VAR_1 , TYPE_2 VAR_2 ) throws TYPE_3 , IOException { String VAR_3 = VAR_1 != null ? VAR_1 : "" ; <START> if ( ! VAR_3 . METHOD_2 ( STRING_1 ) ) { <END> VAR_3 = VAR_3 + STRING_1 ; } return VAR_2 . METHOD_3 ( Constants . VAR_4 , VAR_3 . METHOD_4 ( STRING_2 ) ) ; } | private TYPE_1 METHOD_1 ( String VAR_1 , TYPE_2 VAR_2 ) throws TYPE_3 , IOException { String VAR_3 = VAR_1 != null ? VAR_1 : "" ; if ( VAR_3 . length ( ) > 0 && ! VAR_3 . METHOD_2 ( STRING_1 ) ) { VAR_3 = VAR_3 + STRING_1 ; } return VAR_2 . METHOD_3 ( Constants . VAR_4 , VAR_3 . METHOD_4 ( STRING_2 ) ) ; } |
consider making protected plugins subclass want | <START> TYPE_1 ( boolean VAR_2 , String VAR_3 ) { <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } | protected TYPE_1 ( boolean VAR_2 , String VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } |
method isn t necessary super implementation | public void METHOD_1 ( TYPE_1 VAR_1 , final String token ) { TYPE_5 . TYPE_6 . METHOD_2 ( VAR_2 , VAR_1 , false , token , new TYPE_3 < TYPE_4 > ( ) { public void METHOD_3 ( final TYPE_4 result ) { METHOD_4 ( result ) ; } @Override public void METHOD_5 ( final Throwable VAR_3 ) { <START> super . METHOD_5 ( VAR_3 ) ; <END> } } ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 , final String token ) { TYPE_5 . TYPE_6 . METHOD_2 ( VAR_2 , VAR_1 , false , token , new TYPE_3 < TYPE_4 > ( ) { public void METHOD_3 ( final TYPE_4 result ) { METHOD_4 ( result ) ; } } ) ; } |
exception thrown constructor | TYPE_6 ( TYPE_1 < TYPE_2 > session , TYPE_3 VAR_2 , TYPE_4 VAR_3 ) <START> throws TYPE_5 { <END> this . session = session ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } | TYPE_6 ( TYPE_1 < TYPE_2 > session , TYPE_3 VAR_2 , TYPE_4 VAR_3 ) { this . session = session ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } |
need check VAR_2 instanceof TYPE_3 | private boolean METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = VAR_3 . get ( ) ; if ( VAR_1 . METHOD_2 ( ) . equals ( METHOD_3 ( VAR_1 ) ) ) { <START> return VAR_2 instanceof TYPE_3 && VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) ; <END> } return true ; } | private boolean METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = VAR_3 . get ( ) ; if ( VAR_1 . METHOD_2 ( ) . equals ( METHOD_3 ( VAR_1 ) ) ) { return VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) ; } return true ; } |
done | static String METHOD_1 ( String VAR_1 ) { if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { VAR_1 = STRING_1 ; <START> <END> } else if ( VAR_1 . contains ( STRING_2 ) && ! VAR_1 . startsWith ( STRING_3 ) ) { VAR_1 = STRING_3 + VAR_1 + STRING_4 ; } return VAR_1 ; } | static String METHOD_1 ( String VAR_1 ) { if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { return STRING_1 ; } else if ( VAR_1 . contains ( STRING_2 ) && ! VAR_1 . startsWith ( STRING_3 ) ) { return STRING_3 + VAR_1 + STRING_4 ; } return VAR_1 ; } |
multimap returns empty collection key simplify code removing ! = null test | protected Class < ? > METHOD_1 ( final String VAR_1 ) throws TYPE_1 { final Set < TYPE_2 > VAR_2 = VAR_3 . get ( METHOD_2 ( VAR_1 ) ) ; <START> if ( VAR_2 != null ) { <END> for ( final TYPE_2 VAR_4 : VAR_2 ) { try { return Class . VAR_5 ( VAR_1 , true , VAR_4 ) ; } catch ( TYPE_1 e ) { } } } throw new TYPE_1 ( VAR_1 ) ; } | protected Class < ? > METHOD_1 ( final String VAR_1 ) throws TYPE_1 { final Collection < TYPE_2 > VAR_2 = VAR_3 . get ( METHOD_2 ( VAR_1 ) ) ; for ( final TYPE_2 VAR_4 : VAR_2 ) { try { return Class . VAR_5 ( VAR_1 , true , VAR_4 ) ; } catch ( TYPE_1 e ) { } } throw new TYPE_1 ( VAR_1 ) ; } |
shorter inline variable scope : - ) | private void METHOD_1 ( ) throws Exception { <START> Collection < ? extends TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( ) ; <END> for ( TYPE_1 VAR_3 : VAR_1 ) { VAR_3 . run ( ) ; } } | private void METHOD_1 ( ) throws Exception { for ( TYPE_1 VAR_3 : VAR_2 . METHOD_2 ( ) ) { VAR_3 . run ( ) ; } } |
VAR_1 = VAR_1 * INT_1 + ( VAR_4 ? 1 : 0 ) | public int METHOD_1 ( ) { int VAR_1 = 0 ; VAR_1 = VAR_1 * INT_1 + VAR_2 . METHOD_1 ( ) ; VAR_1 = VAR_1 * INT_1 + VAR_3 . METHOD_1 ( ) ; <START> VAR_1 = VAR_1 * INT_1 + VAR_4 . METHOD_1 ( ) ; <END> return VAR_1 ; } | public int METHOD_1 ( ) { int VAR_1 = 0 ; VAR_1 = VAR_1 * INT_1 + VAR_2 . METHOD_1 ( ) ; VAR_1 = VAR_1 * INT_1 + VAR_3 . METHOD_1 ( ) ; VAR_1 = VAR_1 * INT_1 + ( VAR_4 ? 1 : 0 ) ; return VAR_1 ; } |
&& VAR_4 = = VAR_1 VAR_4 | public boolean equals ( final Object o ) { if ( o instanceof TYPE_1 ) { final TYPE_1 VAR_1 = ( TYPE_1 ) o ; return VAR_2 . equals ( VAR_1 . VAR_2 ) && VAR_3 . equals ( VAR_1 . VAR_3 ) <START> && VAR_4 . equals ( VAR_1 . VAR_4 ) ; <END> } return false ; } | public boolean equals ( final Object o ) { if ( o instanceof TYPE_1 ) { final TYPE_1 VAR_1 = ( TYPE_1 ) o ; return VAR_2 . equals ( VAR_1 . VAR_2 ) && VAR_3 . equals ( VAR_1 . VAR_3 ) && VAR_4 == VAR_1 . VAR_4 ; } return false ; } |
necessary remove | public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; VAR_1 = null ; VAR_2 = null ; VAR_3 = null ; VAR_4 = null ; if ( VAR_5 != null ) { try { <START> TYPE_1 . METHOD_2 ( VAR_5 , TYPE_1 . VAR_6 ) ; <END> } catch ( IOException e ) { } } } } | public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; VAR_1 = null ; VAR_2 = null ; VAR_3 = null ; VAR_4 = null ; } } |
show problem user give calling code ( i e : _CODE_ ) a chance detect interrupted rethrowing returning a boolean success copying error _CODE_ option ? - - - - - - - - - - - - - : Double semi - colon | public void METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( ) ; } catch ( InterruptedException e ) { <START> log . error ( STRING_1 ) ; ; <END> } } | public void METHOD_1 ( ) throws InterruptedException { VAR_1 . METHOD_2 ( ) ; } |
TYPE_3 TYPE_4 VAR_5 ( underscore ) line 47 VAR_8 ( underscore ) I a preference I d prefer stay consistent other | public void start ( ) { VAR_1 . start ( ) ; if ( VAR_2 . METHOD_1 ( ) == TYPE_3 . TYPE_4 . VAR_5 && VAR_1 . VAR_6 ) { TYPE_1 state = <START> new TYPE_1 ( TYPE_2 . VAR_8 ) ; <END> VAR_9 . set ( VAR_10 . create ( null , state ) . METHOD_2 ( INT_1 , TimeUnit . VAR_11 ) ) ; } } | public void start ( ) { VAR_1 . start ( ) ; if ( VAR_2 . METHOD_1 ( ) == TYPE_3 . TYPE_4 . VAR_5 && VAR_1 . VAR_6 ) { TYPE_1 state = new TYPE_1 ( TYPE_2 . VAR_5 ) ; VAR_9 . set ( VAR_10 . create ( null , state ) . METHOD_2 ( INT_1 , TimeUnit . VAR_11 ) ) ; } } |
currying parameter unusual currying other parameters typically hints wrong parameter order other method sense reverse order parameters constructor line 43 | <START> public TYPE_2 ( TYPE_1 type ) { <END> this ( null , type ) ; } | public TYPE_2 ( TYPE_1 type ) { this ( type , null ) ; } |
reading a single field need METHOD_2 | public boolean METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ) ; <END> try { if ( VAR_2 == 0 ) { return false ; } } finally { VAR_1 . METHOD_3 ( ) ; } return true ; } | public boolean METHOD_1 ( ) { return VAR_2 != 0 ; } |
VAR_1 null ? checked _CODE_ ( TYPE_1 ) | private static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 val ) { <START> if ( VAR_1 != null ) { <END> for ( int i = 0 ; i < VAR_1 . METHOD_2 ( ) ; i ++ ) { if ( val . name ( ) . equals ( VAR_1 . getValue ( i ) ) ) { VAR_1 . METHOD_3 ( i ) ; break ; } } } } | private static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 val ) { for ( int i = 0 ; i < VAR_1 . METHOD_2 ( ) ; i ++ ) { if ( val . name ( ) . equals ( VAR_1 . getValue ( i ) ) ) { VAR_1 . METHOD_3 ( i ) ; break ; } } } |
done | public TYPE_1 METHOD_1 ( String VAR_1 , String entity , TYPE_2 err ) { switch ( err . VAR_2 ( ) ) { <START> case 1 : <END> case INT_1 : return new TYPE_3 ( entity , err ) ; default : return super . METHOD_1 ( VAR_1 , entity , err ) ; } } | public TYPE_1 METHOD_1 ( String VAR_1 , String entity , TYPE_2 err ) { switch ( err . VAR_2 ( ) ) { case 1 : return new TYPE_3 ( entity , err ) ; default : return super . METHOD_1 ( VAR_1 , entity , err ) ; } } |
unnecessary TYPE_3 world start stop | public void start ( TYPE_1 VAR_1 ) throws Exception { <START> VAR_2 = new TYPE_2 ( ) ; <END> String VAR_3 = METHOD_1 ( ) . getName ( ) ; VAR_4 = TYPE_3 . METHOD_2 ( new TYPE_4 ( getName ( ) , VAR_3 ) ) ; VAR_2 . add ( VAR_4 ) ; VAR_2 . start ( ) ; } | public void start ( TYPE_1 VAR_1 ) throws Exception { String VAR_3 = METHOD_1 ( ) . getName ( ) ; VAR_4 = TYPE_3 . METHOD_2 ( new TYPE_4 ( getName ( ) , VAR_3 ) ) ; } |
package private access acceptable class private | <START> public TYPE_1 ( String <END> VAR_2 , String VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } | TYPE_1 ( String VAR_2 , String VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } |
done | public boolean METHOD_1 ( String VAR_1 , TYPE_1 key , TYPE_2 session ) { final TYPE_3 VAR_2 = session . VAR_3 ( TYPE_3 . VAR_4 ) ; TYPE_4 VAR_5 = new TYPE_4 ( VAR_1 , VAR_2 . METHOD_2 ( ) ) ; <START> VAR_5 . METHOD_3 ( key ) ; <END> return METHOD_1 ( VAR_2 , VAR_5 , session ) ; } | public boolean METHOD_1 ( String VAR_1 , TYPE_1 key , TYPE_2 session ) { final TYPE_3 VAR_2 = session . VAR_3 ( TYPE_3 . VAR_4 ) ; TYPE_4 VAR_5 = new TYPE_4 ( VAR_1 , key , VAR_2 . METHOD_2 ( ) ) ; return METHOD_1 ( VAR_2 , VAR_5 , session ) ; } |
done added new constructors public key password public key | <START> public TYPE_2 ( String VAR_2 , TYPE_1 VAR_3 ) { <END> this ( VAR_2 , null , VAR_3 ) ; } | public TYPE_2 ( String VAR_2 , TYPE_1 VAR_3 ) { this ( VAR_2 , null , null , VAR_3 ) ; } |
need @Override METHOD_2 | public List < TYPE_2 . TYPE_3 > METHOD_1 ( ) { TYPE_2 . TYPE_3 update = new TYPE_2 . TYPE_3 ( ) { public String METHOD_2 ( ) { return VAR_1 ; } <START> @Override <END> public String METHOD_3 ( ) { return VAR_2 ; } @Override public String METHOD_4 ( ) { return VAR_3 ; } } ; return ImmutableList . of ( update ) ; } | public List < TYPE_2 . TYPE_3 > METHOD_1 ( ) { TYPE_2 . TYPE_3 update = new TYPE_2 . TYPE_3 ( ) { @Override public String METHOD_2 ( ) { return VAR_1 ; } @Override public String METHOD_3 ( ) { return VAR_2 ; } @Override public String METHOD_4 ( ) { return VAR_3 ; } } ; return ImmutableList . of ( update ) ; } |
a branch deleted VAR_3 null case TYPE_2 METHOD_2 ( ) new _CODE_ | public void METHOD_1 ( TYPE_5 . TYPE_6 project , String VAR_1 , TYPE_2 VAR_2 , TYPE_2 VAR_3 ) { <START> TYPE_2 VAR_4 = VAR_2 != null ? VAR_2 : TYPE_2 . METHOD_2 ( ) ; <END> TYPE_3 event = new TYPE_3 ( project , VAR_1 , VAR_4 . name ( ) , VAR_3 . name ( ) ) ; for ( TYPE_4 VAR_5 : VAR_6 ) { VAR_5 . METHOD_3 ( event ) ; } } | public void METHOD_1 ( TYPE_5 . TYPE_6 project , String VAR_1 , TYPE_2 VAR_2 , TYPE_2 VAR_3 ) { TYPE_2 o = VAR_2 != null ? VAR_2 : TYPE_2 . METHOD_2 ( ) ; TYPE_2 n = VAR_3 != null ? VAR_3 : TYPE_2 . METHOD_2 ( ) ; TYPE_3 event = new TYPE_3 ( project , VAR_1 , o . name ( ) , n . name ( ) ) ; for ( TYPE_4 VAR_5 : VAR_6 ) { VAR_5 . METHOD_3 ( event ) ; } } |
unnecessary | <START> static void METHOD_1 ( TYPE_1 res , int VAR_1 , <END> String msg ) throws IOException { res . VAR_2 ( VAR_1 ) ; TYPE_2 . METHOD_2 ( res ) ; METHOD_3 ( null , res , msg ) ; } | public static void METHOD_1 ( TYPE_1 res , int VAR_1 , String msg ) throws IOException { res . VAR_2 ( VAR_1 ) ; TYPE_2 . METHOD_2 ( res ) ; METHOD_3 ( null , res , msg ) ; } |
a single item allowed reason annotations kind drop METHOD_1 drop method altogether | public static < T > TYPE_1 < T > bind ( TYPE_2 binder , TYPE_3 < T > type ) { <START> return binder . bind ( type ) . METHOD_1 ( TYPE_4 . create ( ) ) ; <END> } | public static < T > TYPE_1 < T > bind ( TYPE_2 binder , TYPE_3 < T > type ) { return binder . bind ( type ) ; } |
id toString ( ) valid : - ) | public static void METHOD_1 ( TYPE_9 . TYPE_10 VAR_1 , Set < TYPE_7 . TYPE_8 > VAR_2 , TYPE_3 < TYPE_4 > VAR_3 ) { TYPE_5 call = new TYPE_5 ( METHOD_2 ( VAR_1 ) ) ; TYPE_6 input = TYPE_6 . create ( ) ; for ( TYPE_7 . TYPE_8 id : VAR_2 ) { <START> input . VAR_4 ( Integer . toString ( id . get ( ) ) ) ; <END> } call . data ( input ) . METHOD_3 ( VAR_3 ) ; } | public static void METHOD_1 ( TYPE_9 . TYPE_10 VAR_1 , Set < TYPE_7 . TYPE_8 > VAR_2 , TYPE_3 < TYPE_4 > VAR_3 ) { TYPE_5 call = new TYPE_5 ( METHOD_2 ( VAR_1 ) ) ; TYPE_6 input = TYPE_6 . create ( ) ; for ( TYPE_7 . TYPE_8 id : VAR_2 ) { input . VAR_4 ( id . toString ( ) ) ; } call . data ( input ) . METHOD_3 ( VAR_3 ) ; } |
inline loop avoid METHOD_4 ( ) I don t improves readability doesn t runtime performance | private Map < TYPE_7 . TYPE_8 , TYPE_2 > METHOD_1 ( final TYPE_9 . TYPE_8 VAR_1 ) throws TYPE_4 , TYPE_5 { final Map < TYPE_7 . TYPE_8 , TYPE_2 > VAR_2 = TYPE_6 . METHOD_2 ( ) ; final List < TYPE_2 > VAR_3 = <START> db . VAR_4 ( ) . METHOD_3 ( VAR_1 ) . METHOD_4 ( ) ; <END> for ( final TYPE_2 m : VAR_3 ) { VAR_2 . put ( m . VAR_5 ( ) , m ) ; } return VAR_2 ; } | private Map < TYPE_7 . TYPE_8 , TYPE_2 > METHOD_1 ( final TYPE_9 . TYPE_8 VAR_1 ) throws TYPE_4 , TYPE_5 { final Map < TYPE_7 . TYPE_8 , TYPE_2 > VAR_3 = TYPE_6 . METHOD_2 ( ) ; for ( final TYPE_2 m : db . VAR_4 ( ) . METHOD_3 ( VAR_1 ) ) { VAR_3 . put ( m . VAR_5 ( ) , m ) ; } return VAR_3 ; } |
IIRC METHOD_1 include query parameters quote docs returns part request s URL protocol query string line HTTP request | public String METHOD_1 ( ) { String uri = VAR_1 + VAR_2 + path ; <START> if ( ! parameters . isEmpty ( ) ) { <END> uri += STRING_1 + TYPE_1 . METHOD_2 ( parameters ) ; } return uri ; } | public String METHOD_1 ( ) { return VAR_1 + VAR_2 + path ; } |
shouldn t necessary write bytes VAR_2 | public synchronized TYPE_1 METHOD_1 ( ) { METHOD_2 ( writer == null , STRING_1 ) ; if ( outputStream == null ) { <START> final TYPE_2 VAR_1 = new TYPE_2 ( VAR_2 ) ; <END> outputStream = new TYPE_1 ( ) { @Override public void write ( int c ) throws IOException { VAR_1 . write ( c ) ; VAR_1 . METHOD_3 ( ) ; } } ; } return outputStream ; } | public synchronized TYPE_1 METHOD_1 ( ) { METHOD_2 ( writer == null , STRING_1 ) ; if ( outputStream == null ) { outputStream = new TYPE_1 ( ) { @Override public void write ( int b ) throws IOException { VAR_2 . write ( b ) ; } } ; } return outputStream ; } |
new ArrayList < TYPE_1 > ( VAR_1 length ) | public void METHOD_1 ( String [ ] VAR_1 ) { <START> VAR_2 = new ArrayList < TYPE_1 > ( ) ; <END> for ( String n : VAR_1 ) VAR_2 . add ( new TYPE_1 ( n ) ) ; } | public void METHOD_1 ( String [ ] VAR_1 ) { VAR_2 = new ArrayList < TYPE_1 > ( VAR_1 . length ) ; for ( String n : VAR_1 ) { VAR_2 . add ( new TYPE_1 ( n ) ) ; } } |
shouldn t return 204 content return 200 a description member PUT / groups / { id } / members returns a description new members | public Object apply ( TYPE_1 resource , TYPE_7 . TYPE_8 input ) throws TYPE_3 , TYPE_4 , TYPE_5 , TYPE_6 { <START> return Response . VAR_1 ( ) ; <END> } | public Object apply ( TYPE_1 resource , TYPE_7 . TYPE_8 input ) { return get . get ( ) . apply ( resource ) ; } |
variable : put inline METHOD_3 ( VAR_1 ) | private String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 , String VAR_4 ) { <START> String name = METHOD_2 ( VAR_3 ) ; <END> return METHOD_3 ( VAR_1 ) + STRING_1 + VAR_4 + STRING_2 + name + STRING_3 ; } | private String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 , String VAR_4 ) { return METHOD_3 ( VAR_1 ) + STRING_1 + VAR_4 + STRING_2 + METHOD_2 ( VAR_3 ) + STRING_3 ; } |
done temporary variable ( VAR_1 ! = null && VAR_1 ! = null ) { return VAR_1 ; } return VAR_2 ; | private String METHOD_1 ( TYPE_1 VAR_1 ) { String name = VAR_2 ; <START> if ( VAR_1 != null && VAR_1 . name != null ) { <END> name = VAR_1 . name ; } return name ; } | private String METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null && VAR_1 . name != null ) { return VAR_1 . name ; } return VAR_2 ; } |
put a local variable ? inline | protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; <START> TYPE_6 . TYPE_7 . VAR_1 . VAR_2 . TYPE_10 < TYPE_2 > VAR_4 = <END> new TYPE_3 < TYPE_2 > ( this ) { @Override protected void METHOD_2 ( final TYPE_2 result ) { VAR_5 . METHOD_3 ( true ) ; METHOD_4 ( result ) ; } @Override protected void METHOD_5 ( ) { message . VAR_6 ( true ) ; } } ; TYPE_4 VAR_7 = new TYPE_4 ( ) ; TYPE_8 . TYPE_9 . METHOD_6 ( VAR_8 , VAR_7 . add ( VAR_4 ) ) ; } | protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; TYPE_4 VAR_7 = new TYPE_4 ( ) ; TYPE_8 . TYPE_9 . METHOD_6 ( VAR_8 , VAR_7 . add ( ( TYPE_6 . TYPE_7 . VAR_1 . VAR_2 . TYPE_10 < TYPE_2 > ) new TYPE_3 < TYPE_2 > ( this ) { @Override protected void METHOD_2 ( final TYPE_2 result ) { VAR_5 . METHOD_3 ( true ) ; METHOD_4 ( result ) ; } @Override protected void METHOD_5 ( ) { message . VAR_6 ( true ) ; } } ) ) ; } |
unnecessary delta | public Object apply ( TYPE_1 VAR_1 ) throws TYPE_2 , <START> TYPE_3 { <END> return VAR_2 . format ( VAR_1 ) ; } | public Object apply ( TYPE_1 VAR_1 ) throws TYPE_2 { return VAR_2 . format ( VAR_1 ) ; } |
remove | private void METHOD_1 ( Map < String , TYPE_1 > VAR_1 , TYPE_1 type ) { TYPE_1 VAR_2 = VAR_1 . get ( type . getName ( ) ) ; <START> if ( VAR_2 == null || ! VAR_2 . METHOD_2 ( ) ) { <END> VAR_1 . put ( type . getName ( ) , type ) ; } } | private void METHOD_1 ( Map < String , TYPE_1 > VAR_1 , TYPE_1 type ) { TYPE_1 VAR_2 = VAR_1 . get ( type . getName ( ) ) ; if ( VAR_2 == null || VAR_2 . METHOD_2 ( ) ) { VAR_1 . put ( type . getName ( ) , type ) ; } } |
a VAR_1 VAR_2 doesn t a vote I VAR_3 simply set method | public void METHOD_1 ( String VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = new HashSet < String > ( ) ; } VAR_2 . add ( VAR_1 ) ; <START> VAR_3 = 1 ; <END> } | public void METHOD_1 ( String VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = new HashSet < String > ( ) ; } VAR_2 . add ( VAR_1 ) ; } |
type a variable pointless | public static TYPE_1 METHOD_1 ( String name ) { METHOD_2 ( name ) ; List < TYPE_2 > values = new ArrayList < TYPE_2 > ( 2 ) ; values . add ( new TYPE_2 ( ( short ) 0 , STRING_1 ) ) ; values . add ( new TYPE_2 ( ( short ) 1 , STRING_2 ) ) ; <START> TYPE_1 type = new TYPE_1 ( name , values ) ; <END> return type ; } | public static TYPE_1 METHOD_1 ( String name ) { METHOD_2 ( name ) ; List < TYPE_2 > values = new ArrayList < TYPE_2 > ( 2 ) ; values . add ( new TYPE_2 ( ( short ) 0 , STRING_1 ) ) ; values . add ( new TYPE_2 ( ( short ) 1 , STRING_2 ) ) ; return new TYPE_1 ( name , values ) ; } |
NPE check _CODE_ ( ) supplied id ! = null | private TYPE_2 ( String name , List < TYPE_1 > values ) { super ( name , values ) ; <START> METHOD_1 ( id . length ( ) <= 4 , STRING_1 , id ) ; <END> } | private TYPE_2 ( String name , List < TYPE_1 > values ) { super ( name , values ) ; } |
clearer returned false checked cancel failed call prevent reschedule I don t check cancelled success case anymore simplifying a bit potentially | boolean METHOD_1 ( TYPE_1 VAR_1 ) { synchronized ( VAR_2 ) { if ( VAR_1 . METHOD_2 ( ) ) { <START> return true ; <END> } if ( VAR_3 . containsKey ( VAR_1 . METHOD_3 ( ) ) ) { return false ; } VAR_4 . remove ( VAR_1 . METHOD_3 ( ) ) ; VAR_3 . put ( VAR_1 . METHOD_3 ( ) , VAR_1 ) ; } return true ; } | boolean METHOD_1 ( TYPE_1 VAR_1 ) { synchronized ( VAR_2 ) { if ( VAR_1 . METHOD_2 ( ) ) { return true ; } VAR_4 . remove ( VAR_1 . METHOD_3 ( ) ) ; if ( VAR_3 . containsKey ( VAR_1 . METHOD_3 ( ) ) ) { return false ; } VAR_3 . put ( VAR_1 . METHOD_3 ( ) , VAR_1 ) ; } return true ; } |
wrong place perform parsing I belongs dispatcher change ( line 459 ) _CODE_ _CODE_ ( line 158 ) | public static TYPE_1 parse ( final String VAR_1 ) { final TYPE_1 r = new TYPE_1 ( ) ; String VAR_2 = VAR_1 ; <START> if ( VAR_2 . METHOD_1 ( STRING_1 ) ) { <END> VAR_2 = VAR_2 . substring ( 0 , VAR_2 . length ( ) - 1 ) ; } r . VAR_3 ( VAR_2 ) ; return r ; } | public static TYPE_1 parse ( final String VAR_1 ) { final TYPE_1 r = new TYPE_1 ( ) ; r . VAR_3 ( VAR_1 ) ; return r ; } |
I false default false existing users defaulting true new users default consistent users | public void METHOD_1 ( ) { VAR_1 = VAR_2 ; VAR_3 = true ; VAR_4 = true ; VAR_5 = false ; VAR_6 = false ; VAR_7 = false ; VAR_8 = null ; VAR_9 = null ; VAR_10 = null ; VAR_11 = null ; <START> VAR_12 = true ; <END> } | public void METHOD_1 ( ) { VAR_1 = VAR_2 ; VAR_3 = true ; VAR_4 = true ; VAR_5 = false ; VAR_6 = false ; VAR_7 = false ; VAR_8 = null ; VAR_9 = null ; VAR_10 = null ; VAR_11 = null ; VAR_12 = false ; } |
bad double checked locking idiom TYPE_1 VAR_1 = VAR_1 ; ( VAR_1 = = null ) { synchronized ( ) { VAR_1 = VAR_1 ; / / missedif ( VAR_1 = = null ) { VAR_1 = METHOD_2 ( ) ; VAR_1 = VAR_1 ; } } } | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = this . VAR_1 ; if ( VAR_1 == null ) { synchronized ( this ) { <START> if ( this . VAR_1 == null ) { <END> VAR_1 = METHOD_2 ( ) ; this . VAR_1 = VAR_1 ; } } } if ( VAR_1 == TYPE_1 . VAR_2 ) { TYPE_2 parent = TYPE_3 . METHOD_3 ( METHOD_4 ( ) , null ) ; return parent != null ? parent . VAR_3 ( ) : null ; } return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = this . VAR_1 ; if ( VAR_1 == null ) { synchronized ( this ) { VAR_1 = this . VAR_1 ; if ( VAR_1 == null ) { VAR_1 = METHOD_2 ( ) ; this . VAR_1 = VAR_1 ; } } } if ( VAR_1 == TYPE_1 . VAR_2 ) { TYPE_2 parent = TYPE_3 . METHOD_3 ( METHOD_4 ( ) , null ) ; return parent != null ? parent . VAR_3 ( ) : null ; } return VAR_1 ; } |
early return : ( VAR_3 equals ( ) { return - 1 ; } else ( ) { return 0 ; } return VAR_1 METHOD_2 ( ) ; a lines shorter matches other cases gerrit style works | private int METHOD_1 ( TYPE_1 VAR_1 ) { final int VAR_2 ; final String VAR_3 = VAR_1 . toString ( ) ; if ( VAR_3 . equals ( STRING_1 ) ) { <START> VAR_2 = - 1 ; <END> } else if ( VAR_3 . equals ( STRING_2 ) ) { VAR_2 = 0 ; } else { VAR_2 = VAR_1 . METHOD_2 ( ) ; } return VAR_2 ; } | private int METHOD_1 ( TYPE_1 VAR_1 ) { final String VAR_3 = VAR_1 . toString ( ) ; if ( VAR_3 . equals ( STRING_1 ) ) { return - 1 ; } if ( VAR_3 . equals ( STRING_2 ) ) { return 0 ; } return VAR_1 . METHOD_2 ( ) ; } |
TYPE_3 prefix unnecessary class | static TYPE_1 config ( TYPE_4 . TYPE_5 name ) { <START> return TYPE_3 . project ( name ) . view ( STRING_1 ) ; <END> } | static TYPE_1 config ( TYPE_4 . TYPE_5 name ) { return project ( name ) . view ( STRING_1 ) ; } |
host especially extracted a TYPE_1 object a trailing slash | private static String METHOD_1 ( String VAR_1 ) { String host = null ; if ( VAR_1 != null ) { try { host = new TYPE_1 ( VAR_1 ) . METHOD_2 ( ) ; } catch ( TYPE_2 e ) { } } if ( host == null ) { host = TYPE_3 . getInstance ( ) . METHOD_3 ( ) ; } <START> return METHOD_4 ( host ) ; <END> } | private static String METHOD_1 ( String VAR_1 ) { String host ; if ( VAR_1 != null ) { try { host = new TYPE_1 ( VAR_1 ) . METHOD_2 ( ) ; } catch ( TYPE_2 e ) { host = TYPE_3 . getInstance ( ) . METHOD_3 ( ) ; } } else { host = TYPE_3 . getInstance ( ) . METHOD_3 ( ) ; } return host ; } |
move constructor TYPE_1 reused _CODE_ | public TYPE_1 apply ( TYPE_2 VAR_1 ) { TYPE_1 info = new TYPE_1 ( ) ; <START> TYPE_3 VAR_2 = VAR_1 . METHOD_1 ( ) ; <END> info . id = VAR_2 . getKey ( ) . get ( ) ; info . VAR_3 = VAR_2 . METHOD_2 ( ) ; info . VAR_4 = VAR_2 . METHOD_3 ( ) ; info . VAR_5 = VAR_2 . METHOD_4 ( ) ; info . VAR_6 = TYPE_4 . METHOD_5 ( VAR_2 . METHOD_6 ( ) ) ; info . VAR_7 = VAR_2 . METHOD_7 ( ) ; return info ; } | public TYPE_1 apply ( TYPE_2 VAR_1 ) { return new TYPE_1 ( VAR_1 . METHOD_1 ( ) ) ; } |
TYPE_3 ? _CODE_ released r close ( ) I don t { } finally block needed | private void METHOD_1 ( TYPE_5 . TYPE_6 project , String VAR_1 , String VAR_2 ) throws IOException { TYPE_2 r = VAR_3 . METHOD_2 ( project ) ; try { <START> TYPE_3 VAR_4 = new TYPE_3 ( r ) ; <END> try { TYPE_4 VAR_5 = r . VAR_6 ( VAR_1 ) . METHOD_3 ( ) ; TYPE_4 VAR_7 = r . VAR_6 ( VAR_2 ) . METHOD_3 ( ) ; assertEquals ( VAR_5 , VAR_7 ) ; } finally { VAR_4 . METHOD_4 ( ) ; } } finally { r . close ( ) ; } } | private void METHOD_1 ( TYPE_5 . TYPE_6 project , String VAR_1 , String VAR_2 ) throws IOException { TYPE_2 r = VAR_3 . METHOD_2 ( project ) ; try { TYPE_4 VAR_5 = r . VAR_6 ( VAR_1 ) . METHOD_3 ( ) ; TYPE_4 VAR_7 = r . VAR_6 ( VAR_2 ) . METHOD_3 ( ) ; assertEquals ( VAR_5 , VAR_7 ) ; } finally { r . close ( ) ; } } |
a loop : int count = VAR_1 METHOD_2 ( ) ; return count > 0 && VAR_1 METHOD_3 ( count - 1 ) = = ; | private boolean METHOD_1 ( ) { int count = VAR_1 . METHOD_2 ( ) ; int VAR_2 = count - 1 ; <START> for ( int i = 0 ; i < count ; i ++ ) { <END> if ( this == VAR_1 . METHOD_3 ( i ) ) { return i == VAR_2 ; } } return false ; } | private boolean METHOD_1 ( ) { int count = VAR_1 . METHOD_2 ( ) ; return count > 0 && VAR_1 . METHOD_3 ( count - 1 ) == this ; } |
don t return null throw instead | public TYPE_1 parse ( TYPE_2 parent , TYPE_3 id ) throws TYPE_4 , Exception { <START> return null ; <END> } | public TYPE_1 parse ( TYPE_2 parent , TYPE_3 id ) throws TYPE_4 { throw new TYPE_4 ( id ) ; } |
write id equals ( STRING_1 ) | public TYPE_1 parse ( TYPE_2 VAR_1 , TYPE_3 id ) throws TYPE_4 { <START> if ( ! STRING_1 . equals ( id . get ( ) ) ) { <END> throw new TYPE_4 ( id ) ; } return new TYPE_1 ( ) ; } | public TYPE_1 parse ( TYPE_2 VAR_1 , TYPE_3 id ) throws TYPE_4 { if ( id . equals ( STRING_1 ) ) { return new TYPE_1 ( ) ; } throw new TYPE_4 ( id ) ; } |
enough coffee world convince delta necessary | public boolean METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( group ) ; if ( VAR_1 != null && VAR_1 . METHOD_3 ( ) ) { <START> return true ; <END> } return user instanceof TYPE_3 || user . VAR_2 ( ) . contains ( group . VAR_3 ( ) ) || METHOD_4 ( ) ; } | public boolean METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( group ) ; return ( VAR_1 != null && VAR_1 . METHOD_3 ( ) ) || user instanceof TYPE_3 || user . VAR_2 ( ) . contains ( group . VAR_3 ( ) ) || METHOD_4 ( ) ; } |
sort binding _CODE_ line 244 current master | protected void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( binder ( ) , VAR_1 ) ; TYPE_1 . METHOD_2 ( binder ( ) , VAR_2 ) ; <START> TYPE_1 . METHOD_2 ( binder ( ) , TYPE_2 . class ) ; <END> child ( VAR_1 , STRING_1 ) . to ( TYPE_3 . class ) ; } | protected void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( binder ( ) , VAR_1 ) ; TYPE_1 . METHOD_2 ( binder ( ) , VAR_2 ) ; child ( VAR_1 , STRING_1 ) . to ( TYPE_3 . class ) ; } |
return method | public Builder METHOD_1 ( TYPE_1 VAR_1 ) { switch ( type ) { case VAR_2 : case LOG : this . VAR_3 = VAR_1 ; break ; default : METHOD_2 ( VAR_1 == null , STRING_1 , type ) ; <START> this . VAR_3 = VAR_1 ; <END> break ; } return this ; } | public Builder METHOD_1 ( TYPE_1 VAR_1 ) { switch ( type ) { case VAR_2 : case LOG : this . VAR_3 = VAR_1 ; return this ; default : throw new IllegalStateException ( String . format ( STRING_1 , type ) ) ; } } |
leave checks switch assignment : path = path ! = null ? METHOD_2 ( path ) : null ; | public Builder METHOD_1 ( String path ) { switch ( type ) { case VAR_1 : case VAR_2 : this . path = METHOD_2 ( METHOD_3 ( path ) ) ; break ; case VAR_3 : case VAR_4 : case LOG : this . path = path != null ? METHOD_2 ( path ) : null ; break ; default : METHOD_4 ( path == null , STRING_1 , type ) ; this . path = path ; break ; } <START> return this ; <END> } | public Builder METHOD_1 ( String path ) { switch ( type ) { case VAR_1 : case VAR_2 : this . path = METHOD_2 ( METHOD_3 ( path ) ) ; return this ; case VAR_3 : case VAR_4 : case LOG : this . path = path != null ? METHOD_2 ( path ) : null ; return this ; default : throw new IllegalStateException ( String . format ( STRING_1 , type ) ) ; } } |
( ! startsWith ( TYPE_1 VAR_2 ) ) | private static String METHOD_1 ( String name ) { <START> if ( name . startsWith ( TYPE_1 . VAR_2 ) ) <END> return TYPE_1 . VAR_2 + name ; return name ; } | private static String METHOD_1 ( String name ) { if ( ! name . startsWith ( TYPE_1 . VAR_2 ) ) return TYPE_1 . VAR_2 + name ; return name ; } |
id ( ) | TYPE_4 ( TYPE_1 < TYPE_2 > VAR_2 , TYPE_3 id ) { <START> super ( TYPE_5 . VAR_4 , id . toString ( ) ) ; <END> this . VAR_2 = VAR_2 ; this . VAR_5 = id ; } | TYPE_4 ( TYPE_1 < TYPE_2 > VAR_2 , TYPE_3 id ) { super ( TYPE_5 . VAR_4 , id . name ( ) ) ; this . VAR_2 = VAR_2 ; this . VAR_5 = id ; } |
write close ( ) ; | public void METHOD_1 ( ) { TYPE_1 read = VAR_1 . get ( ) ; if ( read != null ) { read . close ( ) ; } for ( TYPE_1 write : VAR_2 ) { if ( write != read ) { <START> read . close ( ) ; <END> } } } | public void METHOD_1 ( ) { TYPE_1 read = VAR_1 . get ( ) ; if ( read != null ) { read . close ( ) ; } for ( TYPE_1 write : VAR_2 ) { if ( write != read ) { write . close ( ) ; } } } |
static | <START> private boolean METHOD_1 ( List < ? > list ) { <END> return list == null || list . isEmpty ( ) ; } | private static boolean METHOD_1 ( List < ? > list ) { return list == null || list . isEmpty ( ) ; } |
method return void | <START> private List < TYPE_1 > METHOD_1 ( List < TYPE_1 > list , <END> TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) > 1 ) { list . add ( VAR_1 ) ; } return list ; } | private void METHOD_1 ( List < TYPE_1 > list , TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) > 1 ) { list . add ( VAR_1 ) ; } } |
whoops careless yeah I remove link s complicating a lot | <START> void METHOD_1 ( boolean VAR_1 ) { <END> if ( VAR_1 || ( VAR_2 . METHOD_2 ( ) == 0 && VAR_3 . METHOD_2 ( ) == 0 ) ) { TYPE_1 . METHOD_3 ( VAR_4 , false ) ; TYPE_1 . METHOD_3 ( VAR_5 , false ) ; } else if ( VAR_6 . METHOD_4 ( ) ) { TYPE_1 . METHOD_3 ( VAR_4 , true ) ; TYPE_1 . METHOD_3 ( VAR_5 , true ) ; } host . VAR_7 ( ) ; } | void METHOD_1 ( boolean VAR_1 ) { if ( VAR_1 ) { TYPE_1 . METHOD_3 ( VAR_4 , false ) ; } if ( VAR_1 || ( VAR_2 . METHOD_2 ( ) == 0 && VAR_3 . METHOD_2 ( ) == 0 ) ) { TYPE_1 . METHOD_3 ( VAR_5 , false ) ; } else { TYPE_1 . METHOD_3 ( VAR_4 , true ) ; TYPE_1 . METHOD_3 ( VAR_5 , true ) ; } host . VAR_7 ( ) ; } |
add VAR_4 calling table VAR_3 ( ) | void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . add ( VAR_1 ) ; table . VAR_3 ( false ) ; <START> VAR_4 . add ( VAR_1 ) ; <END> } | void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . add ( VAR_1 ) ; VAR_4 . add ( VAR_1 ) ; table . VAR_3 ( false ) ; } |
straight : VAR_5 = Arrays asList ( config VAR_6 ( STRING_7 null STRING_8 ) ; | public TYPE_2 ( TYPE_1 config ) { VAR_2 = config . getString ( STRING_1 , null , STRING_2 ) ; VAR_3 = config . getString ( STRING_3 , null , STRING_4 ) ; VAR_4 = config . getString ( STRING_5 , null , STRING_6 ) ; <START> VAR_5 = config . VAR_6 ( STRING_7 , null , STRING_8 ) ; <END> } | public TYPE_2 ( TYPE_1 config ) { VAR_2 = config . getString ( STRING_1 , null , STRING_2 ) ; VAR_3 = config . getString ( STRING_3 , null , STRING_4 ) ; VAR_4 = config . getString ( STRING_5 , null , STRING_6 ) ; VAR_5 = Arrays . asList ( config . VAR_6 ( STRING_7 , null , STRING_8 ) ) ; } |
sense continue else branch TYPE_4 TYPE_5 equals ( VAR_1 ) VAR_2 false ? I code : } else ( TYPE_4 TYPE_5 equals ( VAR_1 ) ) { return VAR_2 ; } else { | boolean METHOD_1 ( TYPE_4 . TYPE_7 VAR_1 , boolean VAR_2 ) { if ( TYPE_4 . TYPE_6 . equals ( VAR_1 ) ) { return METHOD_2 ( ) ; } else if ( TYPE_4 . TYPE_5 . equals ( VAR_1 ) && VAR_2 ) { <START> return true ; <END> } else { return user . VAR_3 ( ) . contains ( VAR_1 ) ; } } | boolean METHOD_1 ( TYPE_4 . TYPE_7 VAR_1 , boolean VAR_2 ) { if ( TYPE_4 . TYPE_6 . equals ( VAR_1 ) ) { return METHOD_2 ( ) ; } else if ( TYPE_4 . TYPE_5 . equals ( VAR_1 ) ) { return VAR_2 ; } else { return user . VAR_3 ( ) . contains ( VAR_1 ) ; } } |
VAR_2 ! = null VAR_3 = = null store VAR_2 VAR_3 | private void METHOD_1 ( TYPE_1 < TYPE_2 > in , boolean VAR_1 ) { if ( VAR_1 && VAR_2 == null ) { VAR_2 = in ; <START> } else if ( VAR_3 == null ) { <END> VAR_3 = in ; } else { TYPE_1 < TYPE_2 > VAR_4 = VAR_1 ? VAR_2 : VAR_3 ; for ( int i = 0 ; i < in . length ( ) ; i ++ ) { VAR_4 . METHOD_2 ( in . get ( i ) ) ; } } } | private void METHOD_1 ( TYPE_1 < TYPE_2 > in , boolean VAR_1 ) { if ( VAR_1 && VAR_2 == null ) { VAR_2 = in ; } else if ( ! VAR_1 && VAR_3 == null ) { VAR_3 = in ; } else { TYPE_1 < TYPE_2 > VAR_4 = VAR_1 ? VAR_2 : VAR_3 ; for ( int i = 0 ; i < in . length ( ) ; i ++ ) { VAR_4 . METHOD_2 ( in . get ( i ) ) ; } } } |
bindings | protected void METHOD_1 ( ) { METHOD_2 ( STRING_1 ) . METHOD_3 ( TYPE_1 . class ) ; <START> METHOD_2 ( STRING_2 ) . METHOD_3 ( TYPE_1 . class ) ; <END> } | protected void METHOD_1 ( ) { METHOD_2 ( STRING_2 ) . METHOD_3 ( TYPE_1 . class ) ; } |
check necessary | public Object apply ( TYPE_1 VAR_1 , TYPE_2 input ) throws TYPE_3 , InterruptedException , TYPE_4 { <START> TYPE_5 VAR_2 = VAR_1 . METHOD_1 ( ) . METHOD_2 ( ) ; if ( ! VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ) { throw new TYPE_3 ( STRING_1 ) ; } <END> VAR_3 . index ( VAR_1 . METHOD_5 ( ) ) . get ( ) ; return Response . VAR_4 ( ) ; } | public Object apply ( TYPE_1 VAR_1 , TYPE_2 input ) throws TYPE_3 , InterruptedException , TYPE_4 { VAR_3 . index ( VAR_1 . METHOD_5 ( ) ) . get ( ) ; return Response . VAR_4 ( ) ; } |
written a loop : ( ; VAR_1 ! = null ; VAR_1 = VAR_1 METHOD_3 ( ) ) { T t = VAR_1 METHOD_2 ( VAR_2 ) ; ( t ! = null ) { return t ; } } return null ; | private static < T extends TYPE_1 > T METHOD_1 ( Class < ? > VAR_1 , Class < T > VAR_2 ) { <START> if ( VAR_1 == null ) { return null ; } T VAR_3 = VAR_1 . METHOD_2 ( VAR_2 ) ; if ( VAR_3 == null ) { VAR_3 = METHOD_1 ( VAR_1 . METHOD_3 ( ) , VAR_2 ) ; if ( VAR_3 != null ) { return VAR_3 ; } } return VAR_3 ; <END> } | private static < T extends TYPE_1 > T METHOD_1 ( Class < ? > VAR_1 , Class < T > VAR_2 ) { for ( ; VAR_1 != null ; VAR_1 = VAR_1 . METHOD_3 ( ) ) { T t = VAR_1 . METHOD_2 ( VAR_2 ) ; if ( t != null ) { return t ; } } return null ; } |
e getMessage ( ) | private void METHOD_1 ( TYPE_1 cmd ) throws TYPE_2 { String VAR_1 = null ; if ( cmd instanceof TYPE_3 ) { VAR_1 = ( ( TYPE_3 ) cmd ) . METHOD_2 ( ) ; } try { TYPE_4 . METHOD_1 ( VAR_2 , VAR_1 , cmd . getClass ( ) ) ; } catch ( TYPE_5 e ) { throw new TYPE_2 ( TYPE_3 . VAR_3 , <START> STRING_1 ) ; <END> } } | private void METHOD_1 ( TYPE_1 cmd ) throws TYPE_2 { String VAR_1 = null ; if ( cmd instanceof TYPE_3 ) { VAR_1 = ( ( TYPE_3 ) cmd ) . METHOD_2 ( ) ; } try { TYPE_4 . METHOD_1 ( VAR_2 , VAR_1 , cmd . getClass ( ) ) ; } catch ( TYPE_5 e ) { throw new TYPE_2 ( TYPE_3 . VAR_3 , e . getMessage ( ) ) ; } } |
shorter line | private static TYPE_1 < TYPE_2 > METHOD_1 ( ) { return new TYPE_3 < TYPE_2 > ( ) { public void METHOD_2 ( TYPE_2 result ) { METHOD_3 ( ) ; } public void METHOD_4 ( Throwable err ) { if ( TYPE_4 . METHOD_5 ( err ) ) { new TYPE_4 ( err . getMessage ( ) ) . METHOD_6 ( ) ; METHOD_3 ( ) ; } else { super . METHOD_4 ( err ) ; } } <START> private void METHOD_3 ( ) { TYPE_5 . METHOD_7 ( TYPE_6 . VAR_2 ) ; } <END> } ; } | private static TYPE_1 < TYPE_2 > METHOD_1 ( ) { return new TYPE_3 < TYPE_2 > ( ) { public void METHOD_2 ( TYPE_2 result ) { TYPE_5 . METHOD_7 ( TYPE_6 . VAR_2 ) ; } public void METHOD_4 ( Throwable err ) { if ( TYPE_4 . METHOD_5 ( err ) ) { new TYPE_4 ( err . getMessage ( ) ) . METHOD_6 ( ) ; TYPE_5 . METHOD_7 ( TYPE_6 . VAR_2 ) ; } else { super . METHOD_4 ( err ) ; } } } ; } |
UI widgets passed init ( ) set ( ) passing init ( ) matches pattern TYPE_2 init ( ) _CODE_ gain access additional _CODE_ set ( ) controls | void set ( TYPE_1 info , String VAR_1 , <START> TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { <END> this . VAR_4 = info . VAR_5 ( ) ; this . info = info ; this . VAR_1 = VAR_1 ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; VAR_6 . METHOD_1 ( VAR_4 ) ; METHOD_2 ( info ) ; } | void set ( TYPE_1 info , String VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { this . info = info ; this . VAR_1 = VAR_1 ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; VAR_6 . METHOD_1 ( info . VAR_5 ( ) ) ; METHOD_2 ( info ) ; } |
return void result | private <START> String METHOD_1 ( TYPE_1 <END> options , String VAR_1 ) { TYPE_2 VAR_2 = TYPE_3 . create ( ) ; return VAR_2 . METHOD_2 ( new File ( VAR_1 ) , options ) ; } | private void METHOD_1 ( TYPE_1 options , String VAR_1 ) { TYPE_2 VAR_2 = TYPE_3 . create ( ) ; VAR_2 . METHOD_2 ( new File ( VAR_1 ) , options ) ; } |
check | public TYPE_1 < ? > index ( TYPE_2 VAR_1 ) { <START> return VAR_2 . METHOD_1 ( METHOD_2 ( VAR_1 ) ) ; <END> } | public TYPE_1 < ? > index ( TYPE_2 VAR_1 ) { return VAR_2 != null ? VAR_2 . METHOD_1 ( METHOD_2 ( VAR_1 ) ) : null ; } |
protected | <START> String METHOD_1 ( ) { <END> return VAR_1 ; } | protected String METHOD_1 ( ) { return VAR_1 ; } |
VAR_1 | <START> void METHOD_1 ( int VAR_1 ) { <END> if ( VAR_2 == 0 ) { return ; } TYPE_1 event = new TYPE_1 ( VAR_3 , VAR_4 , VAR_2 ) ; METHOD_2 ( VAR_3 , VAR_4 , event ) ; } | void METHOD_1 ( int VAR_1 ) { if ( VAR_1 == 0 ) { return ; } TYPE_1 event = new TYPE_1 ( VAR_3 , VAR_4 , VAR_1 ) ; METHOD_2 ( VAR_3 , VAR_4 , event ) ; } |
shouldn t true ? ; - ) | public static List < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) throws IOException { <START> return METHOD_2 ( VAR_1 , false ) ; <END> } | public static List < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) throws IOException { return METHOD_2 ( VAR_1 , true ) ; } |
return ! TYPE_2 METHOD_2 ( req VAR_1 ( ) &&req VAR_1 ( ) startsWith ( VAR_2 ) ; | private boolean METHOD_1 ( TYPE_1 req ) { <START> if ( TYPE_2 . METHOD_2 ( req . VAR_1 ( ) ) ) { return false ; } if ( req . VAR_1 ( ) . startsWith ( VAR_2 ) ) { return true ; } return false ; <END> } | private boolean METHOD_1 ( TYPE_1 req ) { return ! TYPE_2 . METHOD_2 ( req . VAR_1 ( ) ) && req . VAR_1 ( ) . startsWith ( VAR_2 ) ; } |
/ METHOD_1 another API commonly called input | public void METHOD_1 ( ) throws TYPE_1 , IOException , TYPE_2 { TYPE_6 . TYPE_7 r = METHOD_2 ( ) ; TYPE_4 VAR_1 = VAR_2 . METHOD_3 ( ) . id ( STRING_1 + r . VAR_3 ( ) ) . METHOD_4 ( r . VAR_4 ( ) . name ( ) ) ; VAR_1 . METHOD_5 ( METHOD_6 ( ) ) ; <START> VAR_1 . METHOD_1 ( new TYPE_5 ( ) ) ; <END> } | public void METHOD_1 ( ) throws TYPE_1 , IOException , TYPE_2 { TYPE_6 . TYPE_7 r = METHOD_2 ( ) ; TYPE_4 VAR_1 = VAR_2 . METHOD_3 ( ) . id ( STRING_1 + r . VAR_3 ( ) ) . METHOD_4 ( r . VAR_4 ( ) . name ( ) ) ; VAR_1 . METHOD_5 ( METHOD_6 ( ) ) ; VAR_1 . METHOD_1 ( new TYPE_5 ( true ) ) ; } |
unnecessary cast | protected void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { <START> assertEquals ( VAR_1 . getId ( ) . get ( ) , ( int ) VAR_2 . VAR_3 ) ; <END> } | protected void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { assertEquals ( VAR_1 . getId ( ) . get ( ) , VAR_2 . VAR_3 ) ; } |
unnecessary cast | protected void METHOD_1 ( String message , TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { <START> assertEquals ( message , VAR_1 . getId ( ) . get ( ) , ( int ) VAR_2 . VAR_3 ) ; <END> } | protected void METHOD_1 ( String message , TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { assertEquals ( message , VAR_1 . getId ( ) . get ( ) , VAR_2 . VAR_3 ) ; } |
default access | <START> public TYPE_3 ( TYPE_1 < TYPE_2 > <END> VAR_2 ) { super ( TYPE_4 . VAR_4 , STRING_1 ) ; this . VAR_2 = VAR_2 ; } | TYPE_3 ( TYPE_1 < TYPE_2 > VAR_2 ) { super ( TYPE_4 . VAR_4 , STRING_1 ) ; this . VAR_2 = VAR_2 ; } |
return c ! = null && c VAR_3 ( ) ; | public boolean METHOD_1 ( TYPE_1 object ) throws TYPE_2 { TYPE_3 c = object . VAR_1 ( VAR_2 ) ; <START> if ( c == null ) { return false ; } return c . VAR_3 ( ) ; <END> } | public boolean METHOD_1 ( TYPE_1 object ) throws TYPE_2 { TYPE_3 c = object . VAR_1 ( VAR_2 ) ; return c != null && c . VAR_3 ( ) ; } |
longer needs public _CODE_ | <START> public TYPE_2 ( TYPE_1 <END> db ) { this . db = db ; } | TYPE_2 ( TYPE_1 db ) { this . db = db ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.