Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
check necessary
private static List < TYPE_1 > METHOD_1 ( TYPE_2 model ) { List < TYPE_1 > result = new ArrayList < > ( ) ; if ( model . VAR_1 ( ) ) { result . add ( from ( model , false ) ) ; } for ( TYPE_2 child : model . VAR_2 ( ) ) { List < TYPE_1 > VAR_3 = METHOD_1 ( child ) ; <START> if ( ! VAR_3 . isEmpty ( ) ) { <END> result . addAll ( VAR_3 ) ; } } return result ; }
private static List < TYPE_1 > METHOD_1 ( TYPE_2 model ) { List < TYPE_1 > result = new ArrayList < > ( ) ; if ( model . VAR_1 ( ) ) { result . add ( from ( model , false ) ) ; } for ( TYPE_2 child : model . VAR_2 ( ) ) { result . addAll ( METHOD_1 ( child ) ) ; } return result ; }
another override VAR_1 TYPE_2 - op ( allow rid instanceof check )
private void METHOD_1 ( ) { for ( TYPE_1 m : METHOD_2 ( ) ) { if ( ! ( m instanceof TYPE_2 ) ) { <START> m . VAR_1 ( false ) ; <END> } } }
private void METHOD_1 ( ) { for ( TYPE_1 m : METHOD_2 ( ) ) { m . VAR_1 ( false ) ; } }
please wait s done I don t remove trycatch
protected void METHOD_1 ( ) { VAR_1 . METHOD_2 ( METHOD_3 ( ) ) . METHOD_4 ( ) . METHOD_5 ( 0 ) ; try { METHOD_6 ( METHOD_7 ( ) && METHOD_8 ( ) ) ; } catch ( Exception e ) { METHOD_6 ( false ) ; } <START> <END> if ( ! METHOD_9 ( ) ) { METHOD_10 ( METHOD_11 ( ) ) ; } }
protected void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_4 ( ) . METHOD_5 ( 0 ) ; try { METHOD_6 ( METHOD_7 ( ) && METHOD_8 ( ) ) ; } catch ( Exception e ) { METHOD_6 ( false ) ; } if ( ! METHOD_9 ( ) ) { METHOD_10 ( METHOD_11 ( ) ) ; } }
please move check METHOD_5 ( ) validates domain exists ll need move METHOD_3 ( ) a separate patch
protected boolean METHOD_1 ( ) { return METHOD_2 ( ) && METHOD_3 ( METHOD_4 ( ) ) && METHOD_5 ( getParameters ( ) . METHOD_6 ( ) , <START> getParameters ( ) . METHOD_7 ( ) ) ; <END> }
protected boolean METHOD_1 ( ) { return METHOD_3 ( METHOD_4 ( ) ) && METHOD_5 ( getParameters ( ) . METHOD_6 ( ) , getParameters ( ) . METHOD_7 ( ) ) && METHOD_2 ( ) ; }
extract field ; need N creations lets sorting collection
public int METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { final String VAR_3 = VAR_1 . getName ( ) ; final String VAR_4 = VAR_2 . getName ( ) ; final TYPE_2 <START> VAR_5 = <END> new TYPE_2 ( ) ; final List < String > VAR_6 = VAR_5 . METHOD_2 ( VAR_3 , VAR_4 ) ; return TYPE_3 . METHOD_1 ( VAR_6 . get ( 0 ) , VAR_6 . get ( 1 ) ) ; }
public int METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { final String VAR_3 = VAR_1 . getName ( ) ; final String VAR_4 = VAR_2 . getName ( ) ; final List < String > VAR_6 = VAR_5 . METHOD_2 ( VAR_3 , VAR_4 ) ; return TYPE_3 . METHOD_1 ( VAR_6 . get ( 0 ) , VAR_6 . get ( 1 ) ) ; }
I don t s place I options : 1 validate custom - compatibility version _CODE_ instead 2 validate point set incorrect rely validation te validate method I #2 - s point validating put another ( incorrect - I asked a VM CCV 5 7 I expect compatibility error s invalid )
protected void METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . getInstance ( ) . METHOD_2 ( ) . contains ( getParameters ( ) . METHOD_3 ( ) . METHOD_4 ( ) ) ? TYPE_3 . METHOD_5 ( getParameters ( ) . METHOD_3 ( ) , this : : METHOD_6 ) : TYPE_3 . METHOD_5 ( this : : METHOD_6 ) ; <START> METHOD_7 ( VAR_1 ) ; <END> }
protected void METHOD_1 ( ) { METHOD_7 ( TYPE_3 . METHOD_5 ( getParameters ( ) . METHOD_3 ( ) , this : : METHOD_6 ) ) ; }
consider change toreturn METHOD_4 ( VAR_4 METHOD_5 ( ) ) && METHOD_4 ( VAR_4 METHOD_6 ( ) )
protected boolean METHOD_1 ( Guid VAR_1 ) { TYPE_1 VAR_2 = VAR_3 . METHOD_2 ( VAR_1 , METHOD_3 ( ) ) ; TYPE_2 VAR_4 = new TYPE_2 ( VAR_2 ) ; if ( ! METHOD_4 ( VAR_4 . METHOD_5 ( ) ) || ! METHOD_4 ( VAR_4 . METHOD_6 ( ) ) ) { return false ; } <START> return true ; <END> }
protected boolean METHOD_1 ( Guid VAR_1 ) { TYPE_1 VAR_2 = VAR_3 . METHOD_2 ( VAR_1 , METHOD_3 ( ) ) ; TYPE_2 VAR_4 = new TYPE_2 ( VAR_2 ) ; return ( METHOD_4 ( VAR_4 . METHOD_5 ( ) ) && METHOD_4 ( VAR_4 . METHOD_6 ( ) ) ) ; }
protected
<START> public List < TYPE_1 > <END> METHOD_1 ( ) { return VAR_1 ; }
protected List < TYPE_1 > METHOD_1 ( ) { return VAR_1 ; }
TYPE_1 enough docatch ( Exception ) { / / ignore } I TYPE_1
private String METHOD_1 ( String field ) { if ( field . equals ( STRING_1 ) ) { String VAR_1 = VAR_2 . METHOD_2 ( ) ; try { VAR_1 = VAR_2 . getString ( STRING_1 ) ; <START> } catch ( TYPE_1 e ) { <END> } return VAR_1 ; } return field ; }
private String METHOD_1 ( String field ) { try { return VAR_2 . getString ( field ) ; } catch ( TYPE_1 e ) { } return field ; }
I d suggest explicit / else : ( VAR_2 ! = null ) { VAR_2 = VAR_2 ; } else { VAR_2 = new TYPE_1 ( ) ; VAR_2 METHOD_1 ( false ) ; }
public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { this . VAR_2 = VAR_2 ; <START> if ( this . VAR_2 == null ) { <END> this . VAR_2 = new TYPE_1 ( ) ; this . VAR_2 . METHOD_1 ( false ) ; } this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; VAR_5 = new TYPE_4 ( TYPE_6 . VAR_7 ) ; METHOD_2 ( TYPE_7 . VAR_9 . METHOD_3 ( this ) ) ; }
public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { if ( this . VAR_2 != null ) { this . VAR_2 = VAR_2 ; } else { this . VAR_2 = new TYPE_1 ( ) ; this . VAR_2 . METHOD_1 ( false ) ; } this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; VAR_5 = new TYPE_4 ( TYPE_6 . VAR_7 ) ; METHOD_2 ( TYPE_7 . VAR_9 . METHOD_3 ( this ) ) ; }
needed ? redundant i91dbedee38d893302f1006c9ce1e58d146ce7cce
public int METHOD_1 ( int VAR_1 ) { <START> VAR_1 ++ ; <END> VAR_2 . METHOD_2 ( VAR_1 ++ ) ; VAR_3 . METHOD_2 ( VAR_1 ++ ) ; VAR_4 . METHOD_2 ( VAR_1 ++ ) ; VAR_5 . METHOD_2 ( VAR_1 ++ ) ; return VAR_6 . METHOD_1 ( VAR_1 ) ; }
public int METHOD_1 ( int VAR_1 ) { VAR_2 . METHOD_2 ( VAR_1 ++ ) ; VAR_3 . METHOD_2 ( VAR_1 ++ ) ; VAR_4 . METHOD_2 ( VAR_1 ++ ) ; VAR_5 . METHOD_2 ( VAR_1 ++ ) ; return VAR_6 . METHOD_1 ( VAR_1 ) ; }
please management network highest number displayed
private int METHOD_1 ( TYPE_1 VAR_1 ) { int res = 0 ; if ( VAR_1 != null ) { if ( VAR_1 . METHOD_2 ( ) ) { res += INT_1 ; } if ( VAR_1 . METHOD_3 ( ) ) { <START> res += INT_2 ; <END> } if ( VAR_1 . METHOD_4 ( ) ) { res += 4 ; } if ( VAR_1 . METHOD_5 ( ) ) { res += 2 ; } if ( VAR_1 . METHOD_6 ( ) ) { res += 1 ; } } return res ; }
private int METHOD_1 ( TYPE_1 VAR_1 ) { int res = 0 ; if ( VAR_1 != null ) { if ( VAR_1 . METHOD_3 ( ) ) { res += INT_1 ; } if ( VAR_1 . METHOD_2 ( ) ) { res += INT_2 ; } if ( VAR_1 . METHOD_4 ( ) ) { res += 4 ; } if ( VAR_1 . METHOD_5 ( ) ) { res += 2 ; } if ( VAR_1 . METHOD_6 ( ) ) { res += 1 ; } } return res ; }
I agree I m leaving - patch stuff : 1 worth note a comment2 I formatter remove spaces case keyword ( switch ) please check
boolean METHOD_1 ( TYPE_1 status ) { switch ( status ) { case TYPE_4 : case TYPE_5 : case TYPE_3 : case TYPE_2 : case TYPE_6 : <START> case TYPE_8 : <END> case TYPE_7 : return true ; default : return false ; } }
boolean METHOD_1 ( TYPE_1 status ) { switch ( status ) { default : return false ; case TYPE_4 : case TYPE_3 : case TYPE_2 : case TYPE_6 : case TYPE_5 : case TYPE_8 : case TYPE_7 : return true ; } }
reduced a single boolean expression more more clear understand : return TYPE_4 METHOD_3 ( VAR_2 ) || METHOD_4 ( VAR_3 TYPE_6 TYPE_7 ( ) ) ;
public boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , Guid VAR_3 ) { TYPE_3 VAR_4 = VAR_1 . METHOD_2 ( ) . get ( 0 ) ; if ( VAR_4 == TYPE_3 . VAR_5 ) { <START> if ( TYPE_4 . METHOD_3 ( VAR_2 ) ) { return true ; } return METHOD_4 ( VAR_3 , TYPE_6 . TYPE_7 . name ( ) ) ; <END> } return false ; }
public boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , Guid VAR_3 ) { TYPE_3 VAR_4 = VAR_1 . METHOD_2 ( ) . get ( 0 ) ; if ( VAR_4 == TYPE_3 . VAR_5 ) { return TYPE_4 . METHOD_3 ( VAR_2 ) || METHOD_4 ( VAR_3 , TYPE_6 . TYPE_7 . name ( ) ) ; } return false ; }
hmm I locally s general _CODE_ ( null ) hide dialog ( bound model s window property ) dialog s model ( e g TYPE_1 ) anymore s cleaned ( a model cleaned handlers / listeners removed references shared objects nullified needed )
private void METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) ; <START> METHOD_3 ( null ) ; <END> TYPE_2 < TYPE_1 > VAR_2 = VAR_1 . METHOD_4 ( ) ; TYPE_1 VAR_3 = VAR_1 . METHOD_5 ( ) . METHOD_6 ( ) ; METHOD_7 ( VAR_3 . METHOD_8 ( ) ) ; Collection < TYPE_1 > VAR_4 = VAR_2 . METHOD_9 ( ) ; VAR_2 . METHOD_10 ( null ) ; VAR_2 . METHOD_10 ( VAR_4 ) ; }
private void METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) ; TYPE_2 < TYPE_1 > VAR_2 = VAR_1 . METHOD_4 ( ) ; TYPE_1 VAR_3 = VAR_1 . METHOD_5 ( ) . METHOD_6 ( ) ; METHOD_7 ( VAR_3 . METHOD_8 ( ) ) ; Collection < TYPE_1 > VAR_4 = VAR_2 . METHOD_9 ( ) ; VAR_2 . METHOD_10 ( null ) ; VAR_2 . METHOD_10 ( VAR_4 ) ; METHOD_3 ( null ) ; }
instead VAR_2 pass null
public void METHOD_1 ( ) { <START> METHOD_2 ( true , false , VAR_1 , VAR_2 ) ; <END> assertThat ( VAR_3 . METHOD_3 ( true ) , METHOD_4 ( TYPE_1 . VAR_5 ) ) ; }
public void METHOD_1 ( ) { METHOD_2 ( true , false , VAR_1 , null ) ; assertThat ( VAR_3 . METHOD_3 ( true ) , METHOD_4 ( TYPE_1 . VAR_5 ) ) ; }
I remove removed line 87
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; <START> VAR_1 . METHOD_2 ( Guid . VAR_2 ( ) ) ; <END> when ( METHOD_3 ( ) . getId ( ) ) . METHOD_4 ( VAR_3 ) ; METHOD_5 ( ) . METHOD_6 ( ) ; TYPE_1 result = METHOD_5 ( ) . METHOD_7 ( ) . METHOD_8 ( ) ; METHOD_9 ( result ) ; }
public void METHOD_1 ( ) { when ( METHOD_3 ( ) . getId ( ) ) . METHOD_4 ( VAR_3 ) ; METHOD_5 ( ) . METHOD_6 ( ) ; TYPE_1 result = METHOD_5 ( ) . METHOD_7 ( ) . METHOD_8 ( ) ; METHOD_9 ( result ) ; }
ipv4 code - _CODE_ = = null ) ? _CODE_ : _CODE_ ; didn t adopted code
<START> public void METHOD_1 ( TYPE_1 VAR_1 ) { <END> this . VAR_1 = VAR_1 ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = ( VAR_1 == null ) ? TYPE_1 . NONE : VAR_1 ; }
switch / case
private boolean METHOD_1 ( TYPE_2 . TYPE_3 status ) { <START> if ( status == TYPE_2 . TYPE_3 . TYPE_5 || status == TYPE_2 . TYPE_3 . TYPE_4 || status == TYPE_2 . TYPE_3 . TYPE_6 ) { <END> return true ; } return false ; }
private boolean METHOD_1 ( TYPE_2 . TYPE_3 status ) { switch ( status ) { case TYPE_5 : case TYPE_4 : case TYPE_6 : return true ; default : return false ; } }
pair Pair < Boolean Guid > don t need entire domain object
protected Pair < Boolean , TYPE_1 > METHOD_1 ( TYPE_1 VAR_1 ) { return new Pair < > ( TYPE_2 . getInstance ( ) . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( VAR_1 , null ) , <START> VAR_1 ) ; <END> }
protected Pair < Boolean , Guid > METHOD_1 ( TYPE_1 VAR_1 ) { return new Pair < > ( TYPE_2 . getInstance ( ) . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( VAR_1 , null ) , VAR_1 . getId ( ) ) ; }
I underlying _CODE_ reader a VAR_4 method receives namespace attribute pass null attribute return attribute
public String METHOD_1 ( String name ) { for ( int i = 0 ; i < reader . VAR_1 ( ) ; i ++ ) { String VAR_2 = reader . VAR_3 ( i ) ; if ( VAR_2 . equals ( name ) ) { return reader . VAR_4 ( i ) ; } } <START> return null ; <END> }
public String METHOD_1 ( String name ) { return reader . VAR_4 ( null , name ) ; }
I understand correctly purpose patch fix a specific problem - failure migration _CODE_ failure a lock enough a waiting lock _CODE_ calling refresh instead locking host migration period pass _CODE_ _CODE_ ( scope execution ) _CODE_ ( true ) _CODE_ parameters pass _CODE_ ( _CODE_ pass _CODE_ )
protected boolean METHOD_1 ( ) { try { getParameters ( ) . METHOD_2 ( new Date ( ) ) ; VAR_1 = new TYPE_1 ( VAR_2 . METHOD_3 ( METHOD_4 ( ) ) ) ; <START> VAR_3 . METHOD_5 ( VAR_1 ) ; <END> if ( METHOD_6 ( ) && METHOD_7 ( METHOD_4 ( ) ) && METHOD_8 ( ) ) { TYPE_2 . METHOD_9 ( METHOD_10 ( ) , true ) ; return true ; } METHOD_11 ( ) ; return false ; } catch ( Exception e ) { METHOD_11 ( ) ; throw e ; } }
protected boolean METHOD_1 ( ) { try { getParameters ( ) . METHOD_2 ( new Date ( ) ) ; if ( METHOD_6 ( ) && METHOD_7 ( METHOD_4 ( ) ) && METHOD_8 ( ) ) { TYPE_2 . METHOD_9 ( METHOD_10 ( ) , true ) ; return true ; } METHOD_11 ( ) ; return false ; } catch ( Exception e ) { METHOD_11 ( ) ; throw e ; } }
redundant - false explicitly set true
public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> METHOD_2 ( false ) ; <END> final TYPE_2 VAR_2 = new TYPE_2 ( ) ; VAR_2 . METHOD_3 ( VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ) ; VAR_2 . METHOD_6 ( VAR_1 . METHOD_4 ( ) . getMessage ( ) ) ; METHOD_7 ( ) . METHOD_8 ( VAR_2 ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_2 VAR_2 = new TYPE_2 ( ) ; VAR_2 . METHOD_3 ( VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ) ; VAR_2 . METHOD_6 ( VAR_1 . METHOD_4 ( ) . getMessage ( ) ) ; METHOD_7 ( ) . METHOD_8 ( VAR_2 ) ; }
lambda lambda point view readable
private void METHOD_1 ( List < TYPE_1 > VAR_1 ) { TYPE_4 < Set < TYPE_2 > > getValue ( TYPE_5 . TYPE_6 ) . stream ( ) . max ( TYPE_3 . METHOD_2 ( ) ) <START> . METHOD_3 ( VAR_5 - > VAR_1 . forEach ( VAR_6 - > VAR_6 . METHOD_4 ( <END> VAR_5 . METHOD_5 ( VAR_6 . METHOD_6 ( ) ) > 0 ) ) ) ; }
private void METHOD_1 ( List < TYPE_1 > VAR_1 ) { TYPE_4 < Set < TYPE_2 > > getValue ( TYPE_5 . TYPE_6 ) . stream ( ) . max ( TYPE_3 . METHOD_2 ( ) ) . METHOD_3 ( VAR_5 - > METHOD_1 ( VAR_1 , VAR_5 ) ) ; }
unneeded brackets
protected boolean METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) == TYPE_4 . VAR_2 ) { TYPE_1 VAR_3 = ( TYPE_1 ) METHOD_2 ( ) ; return <START> ( VAR_3 . METHOD_4 ( ) <END> == TYPE_3 . VAR_5 ) && ! TYPE_2 . equals ( VAR_3 . METHOD_5 ( ) . METHOD_6 ( ) , ( ( TYPE_1 ) METHOD_7 ( ) ) . METHOD_5 ( ) . METHOD_6 ( ) ) ; } return false ; }
protected boolean METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) == TYPE_4 . VAR_2 ) { TYPE_1 VAR_3 = ( TYPE_1 ) METHOD_2 ( ) ; return VAR_3 . METHOD_4 ( ) == TYPE_3 . VAR_5 && ! TYPE_2 . equals ( VAR_3 . METHOD_5 ( ) . METHOD_6 ( ) , ( ( TYPE_1 ) METHOD_7 ( ) ) . METHOD_5 ( ) . METHOD_6 ( ) ) ; } return false ; }
^ lines aren t needed
public void METHOD_1 ( ) { Map < String , String > VAR_1 = new HashMap < > ( ) ; <START> VAR_1 . put ( STRING_1 , STRING_2 ) ; <END> METHOD_2 ( STRING_3 , INT_1 , STRING_4 ) ; METHOD_2 ( STRING_5 , INT_1 , STRING_6 ) ; METHOD_3 ( ) ; connection = ( TYPE_1 ) METHOD_4 ( ) . METHOD_5 ( STRING_1 , STRING_2 ) . build ( ) ; VAR_2 = connection . VAR_3 ( ) . METHOD_6 ( ) ; VAR_4 = VAR_2 . METHOD_7 ( STRING_7 ) ; }
public void METHOD_1 ( ) { METHOD_2 ( STRING_3 , INT_1 , STRING_4 ) ; METHOD_2 ( STRING_5 , INT_1 , STRING_6 ) ; METHOD_3 ( ) ; connection = ( TYPE_1 ) METHOD_4 ( ) . METHOD_5 ( STRING_1 , STRING_2 ) . build ( ) ; VAR_2 = connection . VAR_3 ( ) . METHOD_6 ( ) ; VAR_4 = VAR_2 . METHOD_7 ( STRING_7 ) ; }
moving previous line I solve tool - tip issue
private void METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) && METHOD_2 ( ) . METHOD_4 ( ) ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_5 ( ) ; Collection < TYPE_2 > VAR_2 = VAR_1 . METHOD_6 ( ) ; if ( VAR_2 != null && ! METHOD_7 ( VAR_2 ) ) { METHOD_2 ( ) . METHOD_8 ( false ) ; <START> METHOD_2 ( ) . METHOD_9 ( ) . add ( <END> VAR_3 . METHOD_10 ( ) ) ; return ; } } METHOD_2 ( ) . METHOD_8 ( true ) ; }
private void METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) && METHOD_2 ( ) . METHOD_4 ( ) ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_5 ( ) ; Collection < TYPE_2 > VAR_2 = VAR_1 . METHOD_6 ( ) ; if ( VAR_2 != null && ! METHOD_7 ( VAR_2 ) ) { METHOD_2 ( ) . METHOD_9 ( ) . add ( VAR_3 . METHOD_10 ( ) ) ; METHOD_2 ( ) . METHOD_8 ( false ) ; return ; } } METHOD_2 ( ) . METHOD_8 ( true ) ; }
a code smell path super instead call ( VAR_2 null )
public TYPE_1 ( Guid VAR_2 ) { <START> super ( VAR_2 ) ; <END> }
public TYPE_1 ( Guid VAR_2 ) { this ( VAR_2 , null ) ; }
2 2 2 rewritten : case STRING_1 : case STRING_2 : case STRING_3 : return 2 ; default : return - 1 ;
public static int METHOD_1 ( String VAR_1 ) { switch ( VAR_1 ) { case STRING_1 : <START> return 2 ; <END> case STRING_2 : return 2 ; case STRING_3 : return 2 ; default : return - 1 ; } }
public static int METHOD_1 ( String VAR_1 ) { switch ( VAR_1 ) { case STRING_1 : case STRING_2 : case STRING_3 : return 2 ; default : return - 1 ; } }
shouldn t = = null
private void METHOD_1 ( ) { if ( getParameters ( ) . METHOD_2 ( ) != null <START> || METHOD_3 ( ) . METHOD_4 ( ) . equals ( getParameters ( ) . METHOD_2 ( ) ) ) { <END> return ; } TYPE_1 params = new TYPE_1 ( getParameters ( ) . METHOD_2 ( ) , METHOD_5 ( ) , METHOD_3 ( ) . METHOD_6 ( ) ) ; METHOD_7 ( METHOD_8 ( ) . METHOD_9 ( TYPE_2 . TYPE_3 , params ) . METHOD_10 ( ) ) ; }
private void METHOD_1 ( ) { if ( getParameters ( ) . METHOD_2 ( ) == null || METHOD_3 ( ) . METHOD_4 ( ) . equals ( getParameters ( ) . METHOD_2 ( ) ) ) { return ; } TYPE_1 params = new TYPE_1 ( getParameters ( ) . METHOD_2 ( ) , METHOD_5 ( ) , METHOD_3 ( ) . METHOD_6 ( ) ) ; METHOD_7 ( METHOD_8 ( ) . METHOD_9 ( TYPE_2 . TYPE_3 , params ) . METHOD_10 ( ) ) ; }
method useless send a patch remove code needs uuid simply TYPE_1 class
<START> public String METHOD_1 ( ) { <END> return TYPE_1 . METHOD_2 ( ) . toString ( ) ; }
public static String METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( ) . toString ( ) ; }
replicates logic production code t create _CODE_ TYPE_1 symetrically
private List < TYPE_1 > METHOD_1 ( List < TYPE_2 > VAR_1 , TYPE_3 version ) { METHOD_2 ( version ) ; VAR_2 . METHOD_3 ( TYPE_4 . TYPE_5 , version ) ; List < TYPE_2 > VAR_5 = METHOD_4 ( VAR_1 ) ; when ( VAR_6 . METHOD_5 ( <START> VAR_1 . stream ( ) . map ( TYPE_2 : : METHOD_6 ) . collect ( Collectors . VAR_7 ( ) ) <END> ) ) . METHOD_7 ( VAR_5 ) ; return cmd . VAR_8 ( VAR_1 ) ; }
private List < TYPE_1 > METHOD_1 ( List < TYPE_2 > VAR_1 , TYPE_3 version ) { METHOD_2 ( version ) ; VAR_2 . METHOD_3 ( TYPE_4 . TYPE_5 , version ) ; List < TYPE_2 > VAR_5 = METHOD_4 ( VAR_1 ) ; when ( VAR_6 . METHOD_5 ( VAR_1 . stream ( ) . map ( TYPE_2 : : METHOD_6 ) . collect ( Collectors . VAR_7 ( ) ) ) ) . METHOD_7 ( new HashSet < > ( VAR_5 ) ) ; return cmd . VAR_8 ( VAR_1 ) ; }
please note doesn t handle templates _CODE_ ( original bug opened handle templates ) - worth adding a remark BZ won t remove spicevmc channels templates
public void METHOD_1 ( TYPE_1 VAR_1 ) { List < TYPE_2 > VAR_2 = VAR_3 . METHOD_2 ( VAR_1 . getId ( ) , TYPE_7 . VAR_5 , TYPE_4 . TYPE_5 . getName ( ) ) ; if ( ! METHOD_3 ( VAR_1 . getId ( ) , TYPE_6 . VAR_7 ) ) { METHOD_4 ( VAR_2 ) ; } <START> } <END>
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! METHOD_3 ( VAR_1 . getId ( ) , TYPE_6 . VAR_7 ) ) { List < TYPE_2 > VAR_2 = VAR_3 . METHOD_2 ( VAR_1 . getId ( ) , TYPE_7 . VAR_5 , TYPE_4 . TYPE_5 . getName ( ) ) ; METHOD_4 ( VAR_2 ) ; } }
: METHOD_3
private void METHOD_1 ( ) { if ( TYPE_2 < Boolean > getValue ( TYPE_3 . TYPE_4 ) ) { log . info ( STRING_1 ) ; <START> VAR_4 . METHOD_2 ( ( ) - > METHOD_3 ( ) , <END> TYPE_2 < Integer > getValue ( TYPE_3 . TYPE_1 ) , TYPE_2 < Integer > getValue ( TYPE_3 . TYPE_1 ) , TimeUnit . VAR_6 ) ; log . info ( STRING_2 ) ; } }
private void METHOD_1 ( ) { if ( TYPE_2 < Boolean > getValue ( TYPE_3 . TYPE_4 ) ) { log . info ( STRING_1 ) ; VAR_4 . METHOD_2 ( this : : METHOD_3 , TYPE_2 < Integer > getValue ( TYPE_3 . TYPE_1 ) , TYPE_2 < Integer > getValue ( TYPE_3 . TYPE_1 ) , TimeUnit . VAR_6 ) ; log . info ( STRING_2 ) ; } }
method reference
private void METHOD_1 ( ) { if ( TYPE_1 < Boolean > getValue ( TYPE_2 . TYPE_4 ) ) { log . info ( STRING_1 ) ; Integer VAR_4 = TYPE_1 < Integer > getValue ( TYPE_2 . TYPE_3 ) ; <START> VAR_6 . METHOD_2 ( ( ) - > METHOD_3 ( ) , <END> VAR_4 , VAR_4 , TimeUnit . VAR_7 ) ; log . info ( STRING_2 ) ; } }
private void METHOD_1 ( ) { if ( TYPE_1 < Boolean > getValue ( TYPE_2 . TYPE_4 ) ) { log . info ( STRING_1 ) ; Integer VAR_4 = TYPE_1 < Integer > getValue ( TYPE_2 . TYPE_3 ) ; VAR_6 . METHOD_2 ( this : : METHOD_3 , VAR_4 , VAR_4 , TimeUnit . VAR_7 ) ; log . info ( STRING_2 ) ; } }
private
<START> public void <END> METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( ) ) { try { log . info ( STRING_1 ) ; METHOD_3 ( ) ; log . info ( STRING_2 ) ; } finally { VAR_1 . METHOD_4 ( ) ; } } }
private void METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( ) ) { try { log . info ( STRING_1 ) ; METHOD_3 ( ) ; log . info ( STRING_2 ) ; } finally { VAR_1 . METHOD_4 ( ) ; } } }
private
<START> public void <END> METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) . stream ( ) . filter ( VAR_2 - > VAR_2 . getStatus ( ) . METHOD_3 ( ) ) . forEach ( this : : METHOD_4 ) ; }
private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) . stream ( ) . filter ( VAR_2 - > VAR_2 . getStatus ( ) . METHOD_3 ( ) ) . forEach ( this : : METHOD_4 ) ; }
private
<START> public void <END> METHOD_1 ( ) { Date VAR_1 = new Date ( System . currentTimeMillis ( ) - TimeUnit . VAR_2 . METHOD_2 ( VAR_3 , TimeUnit . VAR_4 ) ) ; Date VAR_5 = new Date ( System . currentTimeMillis ( ) - TimeUnit . VAR_2 . METHOD_2 ( VAR_6 , TimeUnit . VAR_4 ) ) ; try { VAR_7 . METHOD_3 ( VAR_1 , VAR_5 ) ; } catch ( RuntimeException e ) { log . error ( STRING_1 , e . getMessage ( ) ) ; log . debug ( STRING_2 , e ) ; } }
private void METHOD_1 ( ) { Date VAR_1 = new Date ( System . currentTimeMillis ( ) - TimeUnit . VAR_2 . METHOD_2 ( VAR_3 , TimeUnit . VAR_4 ) ) ; Date VAR_5 = new Date ( System . currentTimeMillis ( ) - TimeUnit . VAR_2 . METHOD_2 ( VAR_6 , TimeUnit . VAR_4 ) ) ; try { VAR_7 . METHOD_3 ( VAR_1 , VAR_5 ) ; } catch ( RuntimeException e ) { log . error ( STRING_1 , e . getMessage ( ) ) ; log . debug ( STRING_2 , e ) ; } }
a good idea making TYPE_1 final I s worth small cleanup a separate patch
void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( true ) ; VAR_1 . METHOD_3 ( VAR_2 ) ; <END> when ( VAR_3 . METHOD_4 ( METHOD_5 ( TYPE_3 . TYPE_4 ) , METHOD_6 ( TYPE_2 . class ) ) ) . METHOD_7 ( VAR_1 ) ; }
void METHOD_1 ( ) { when ( VAR_3 . METHOD_4 ( METHOD_5 ( TYPE_3 . TYPE_4 ) , METHOD_6 ( TYPE_2 . class ) ) ) . METHOD_7 ( new TYPE_1 ( ) { { METHOD_2 ( true ) ; METHOD_3 ( VAR_2 ) ; } } ) ; }
throw RuntimeException static block
} catch ( TYPE_1 e ) { <START> new RuntimeException ( STRING_1 , e ) ; <END> }
} catch ( TYPE_1 e ) { throw new RuntimeException ( e ) ; }
protected ? subclass ? private else required more accessible future other harder
<START> protected void <END> METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { String [ ] VAR_3 = VAR_2 . split ( STRING_1 ) ; for ( String VAR_4 : VAR_3 ) { VAR_1 = METHOD_2 ( VAR_1 , VAR_4 ) ; } }
private void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { String [ ] VAR_3 = VAR_2 . split ( STRING_1 ) ; for ( String VAR_4 : VAR_3 ) { VAR_1 = METHOD_2 ( VAR_1 , VAR_4 ) ; } }
related
<START> private static <END> String METHOD_1 ( TYPE_1 VAR_1 ) { final String key = VAR_1 . name ( ) ; try { return VAR_2 . getString ( key ) ; } catch ( Exception e ) { log . error ( STRING_1 , key , METHOD_2 ( ) ) ; return null ; } }
protected static String METHOD_1 ( TYPE_1 VAR_1 ) { final String key = VAR_1 . name ( ) ; try { return VAR_2 . getString ( key ) ; } catch ( Exception e ) { log . error ( STRING_1 , key , METHOD_2 ( ) ) ; return null ; } }
method invocation line more readable
public TYPE_1 ( String VAR_2 ) { super ( ) ; String [ ] VAR_3 = VAR_2 . split ( STRING_1 ) ; <START> METHOD_1 ( VAR_3 [ 0 ] ) . METHOD_2 ( VAR_3 [ 1 ] ) . METHOD_3 ( VAR_3 [ 2 ] ) . METHOD_4 ( VAR_3 [ 3 ] ) . METHOD_5 ( VAR_3 [ 4 ] ) . METHOD_6 ( VAR_3 [ 5 ] ) ; <END> if ( VAR_3 . length >= INT_1 ) { METHOD_7 ( VAR_3 [ INT_2 ] ) ; } }
public TYPE_1 ( String VAR_2 ) { String [ ] VAR_3 = VAR_2 . split ( STRING_1 ) ; METHOD_1 ( VAR_3 [ 0 ] ) . METHOD_2 ( VAR_3 [ 1 ] ) . METHOD_3 ( VAR_3 [ 2 ] ) . METHOD_4 ( VAR_3 [ 3 ] ) . METHOD_5 ( VAR_3 [ 4 ] ) . METHOD_6 ( VAR_3 [ 5 ] ) ; if ( VAR_3 . length >= INT_1 ) { METHOD_7 ( VAR_3 [ INT_2 ] ) ; } }
move debug patch ( remove ) I INFO level
private void METHOD_1 ( ) { try { <START> log . info ( STRING_1 ) ; <END> TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 < Integer > getValue ( TYPE_4 . TYPE_5 ) * - 1 ) ; VAR_5 . METHOD_4 ( VAR_1 ) ; log . info ( STRING_2 ) ; } catch ( Throwable t ) { log . error ( STRING_3 , TYPE_2 . METHOD_5 ( t ) ) ; log . debug ( STRING_4 , t ) ; } }
private void METHOD_1 ( ) { try { log . debug ( STRING_1 ) ; TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 < Integer > getValue ( TYPE_4 . TYPE_5 ) * - 1 ) ; VAR_5 . METHOD_4 ( VAR_1 ) ; log . debug ( STRING_2 ) ; } catch ( Throwable t ) { log . error ( STRING_3 , TYPE_2 . METHOD_5 ( t ) ) ; log . debug ( STRING_4 , t ) ; } }
t avoid setting parent command / parent parameters ? preferred delete lines 34 - 35
protected void METHOD_1 ( ) { TYPE_1 VAR_1 = getParameters ( ) . METHOD_2 ( ) ; TYPE_2 VAR_2 = getParameters ( ) . METHOD_3 ( ) ; <START> VAR_2 . METHOD_4 ( TYPE_2 . TYPE_5 . VAR_4 ) ; <END> VAR_2 . METHOD_5 ( TYPE_1 . TYPE_4 ) ; VAR_2 . METHOD_6 ( getParameters ( ) ) ; TYPE_3 . METHOD_7 ( VAR_1 , VAR_2 , METHOD_8 ( ) ) ; METHOD_9 ( true ) ; }
protected void METHOD_1 ( ) { TYPE_3 . METHOD_7 ( getParameters ( ) . METHOD_2 ( ) , getParameters ( ) . METHOD_3 ( ) , METHOD_8 ( ) ) ; METHOD_9 ( true ) ; }
new command allowed need line
private void METHOD_1 ( ) { <START> METHOD_2 ( ) . METHOD_3 ( true ) ; <END> boolean VAR_1 = METHOD_4 ( ) != null && METHOD_4 ( ) . size ( ) > 0 ; METHOD_5 ( ) . METHOD_3 ( VAR_1 && METHOD_4 ( ) . size ( ) == 1 ) ; METHOD_6 ( ) . METHOD_3 ( VAR_1 ) ; }
private void METHOD_1 ( ) { boolean VAR_1 = METHOD_4 ( ) != null && METHOD_4 ( ) . size ( ) > 0 ; METHOD_5 ( ) . METHOD_3 ( VAR_1 && METHOD_4 ( ) . size ( ) == 1 ) ; METHOD_6 ( ) . METHOD_3 ( VAR_1 ) ; }
I ve other list models _CODE_ ( null ) need
private void METHOD_1 ( ) { <START> METHOD_2 ( null ) ; <END> }
private void METHOD_1 ( ) { }
inline local variable
protected void METHOD_1 ( ) { TYPE_1 <START> command = <END> TYPE_1 . METHOD_2 ( STRING_1 , this ) ; METHOD_3 ( ) . add ( command ) ; METHOD_3 ( ) . add ( TYPE_1 . METHOD_4 ( STRING_2 , this ) ) ; }
protected void METHOD_1 ( ) { METHOD_3 ( ) . add ( TYPE_1 . METHOD_2 ( STRING_1 , this ) ) ; METHOD_3 ( ) . add ( TYPE_1 . METHOD_4 ( STRING_2 , this ) ) ; }
private
<START> public boolean <END> METHOD_1 ( Guid id ) { return VAR_1 . exists ( id ) ; }
private boolean METHOD_1 ( Guid id ) { return VAR_1 . exists ( id ) ; }
done
public void METHOD_1 ( final TYPE_1 server , final TYPE_2 VAR_1 ) { <START> METHOD_2 ( server == null ? <END> Guid . TYPE_3 : server . VAR_3 ( ) , server == null ? null : server . VAR_4 ( ) , null , server , VAR_1 , Collections . VAR_5 ( ) ) ; }
public void METHOD_1 ( final TYPE_1 server , final TYPE_2 VAR_1 ) { METHOD_2 ( server . VAR_3 ( ) , server . VAR_4 ( ) , null , server , VAR_1 , Collections . VAR_5 ( ) ) ; }
doesn t sense validation update case
protected boolean METHOD_1 ( ) { if ( ! METHOD_2 ( ) ) return false ; final TYPE_1 VAR_1 = METHOD_3 ( ) ; <START> return METHOD_4 ( VAR_1 . METHOD_5 ( METHOD_6 ( ) , VAR_2 ) ) <END> && METHOD_4 ( VAR_1 . METHOD_7 ( VAR_2 ) ) && METHOD_4 ( VAR_1 . METHOD_8 ( VAR_2 ) ) ; }
protected boolean METHOD_1 ( ) { if ( ! METHOD_2 ( ) ) { return false ; } final TYPE_1 VAR_1 = METHOD_3 ( ) ; return METHOD_4 ( VAR_1 . METHOD_5 ( METHOD_6 ( ) , VAR_2 ) ) && METHOD_4 ( VAR_1 . METHOD_7 ( VAR_2 ) ) && METHOD_4 ( VAR_1 . METHOD_8 ( VAR_2 ) ) ; }
wouldn t more readable TYPE_2 _CODE_ ( ) instead code
protected void log ( ) { <START> final TYPE_1 VAR_1 = TYPE_2 . METHOD_1 ( ) ; <END> try { try { VAR_2 . log ( this , METHOD_2 ( ) ) ; } catch ( final RuntimeException ex ) { log . error ( STRING_1 , getClass ( ) . getName ( ) , ex . getMessage ( ) ) ; log . debug ( STRING_2 , ex ) ; } } finally { TYPE_2 . METHOD_3 ( VAR_1 ) ; } }
protected void log ( ) { final TYPE_1 VAR_1 = TYPE_2 . METHOD_1 ( ) ; try { VAR_2 . log ( this , METHOD_2 ( ) ) ; } catch ( final RuntimeException ex ) { log . error ( STRING_1 , getClass ( ) . getName ( ) , ex . getMessage ( ) ) ; log . debug ( STRING_2 , ex ) ; } finally { TYPE_2 . METHOD_3 ( VAR_1 ) ; } }
redundant mockito 2
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; Guid VAR_2 = Guid . VAR_3 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; <START> when ( VAR_4 . METHOD_3 ( METHOD_4 ( Guid . VAR_5 ) ) ) . METHOD_5 ( Collections . VAR_6 ( VAR_1 ) ) ; <END> when ( VAR_7 . get ( VAR_2 ) ) . METHOD_5 ( new TYPE_2 ( ) ) ; assertTrue ( cmd . VAR_8 ( ) ) ; }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; Guid VAR_2 = Guid . VAR_3 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; when ( VAR_4 . METHOD_3 ( METHOD_4 ( ) ) ) . METHOD_5 ( Collections . VAR_6 ( VAR_1 ) ) ; when ( VAR_7 . get ( VAR_2 ) ) . METHOD_5 ( new TYPE_2 ( ) ) ; assertTrue ( cmd . VAR_8 ( ) ) ; }
redundant mockito 2
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; Guid VAR_2 = Guid . VAR_3 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; <START> when ( VAR_4 . METHOD_3 ( METHOD_4 ( Guid . VAR_5 ) ) ) . METHOD_5 ( Collections . VAR_6 ( VAR_1 ) ) ; <END> when ( VAR_7 . get ( VAR_2 ) ) . METHOD_5 ( null ) ; METHOD_6 ( cmd . VAR_8 ( ) ) ; }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; Guid VAR_2 = Guid . VAR_3 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; when ( VAR_4 . METHOD_3 ( METHOD_4 ( ) ) ) . METHOD_5 ( Collections . VAR_6 ( VAR_1 ) ) ; METHOD_6 ( cmd . VAR_8 ( ) ) ; }
_CODE_ ? returning Boolean object attribute defined primitive boolean type
<START> public Boolean METHOD_1 ( ) { <END> return VAR_1 ; }
public boolean METHOD_1 ( ) { return VAR_1 ; }
pick : need call super [ 1 ] s effectively a - op call simply skip line [ 1 ] _CODE_ ( View extended some other View override METHOD_1 method super called case )
public int METHOD_1 ( int VAR_1 ) { <START> VAR_1 = super . METHOD_1 ( VAR_1 ) ; <END> VAR_1 = VAR_2 . METHOD_1 ( VAR_1 ) ; VAR_1 = this . VAR_3 . METHOD_1 ( VAR_1 ) ; return VAR_1 ; }
public int METHOD_1 ( int VAR_1 ) { VAR_1 = VAR_2 . METHOD_1 ( VAR_1 ) ; VAR_1 = this . VAR_3 . METHOD_1 ( VAR_1 ) ; return VAR_1 ; }
don t raw types - new Pair < > ( vm VAR_4 )
public void METHOD_1 ( ) { TYPE_1 vm = new TYPE_1 ( ) ; vm . VAR_1 ( TYPE_5 . TYPE_4 ) ; TYPE_2 VAR_4 = new TYPE_2 ( ) ; VAR_4 . METHOD_2 ( true ) ; List < Pair < TYPE_1 , TYPE_2 > > VAR_5 = <START> Collections . VAR_6 ( new Pair ( vm , <END> VAR_4 ) ) ; METHOD_3 ( VAR_5 ) . when ( VAR_7 ) . METHOD_4 ( VAR_8 ) ; TYPE_3 . METHOD_5 ( command , TYPE_6 . VAR_10 ) ; }
public void METHOD_1 ( ) { TYPE_1 vm = new TYPE_1 ( ) ; vm . VAR_1 ( TYPE_5 . TYPE_4 ) ; TYPE_2 VAR_4 = new TYPE_2 ( ) ; VAR_4 . METHOD_2 ( true ) ; List < Pair < TYPE_1 , TYPE_2 > > VAR_5 = Collections . VAR_6 ( new Pair < > ( vm , VAR_4 ) ) ; METHOD_3 ( VAR_5 ) . when ( VAR_7 ) . METHOD_4 ( VAR_8 ) ; TYPE_3 . METHOD_5 ( command , TYPE_6 . VAR_10 ) ; }
equals TYPE_2 = = TYPE_3
private void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . get ( METHOD_2 ( ) . METHOD_3 ( ) ) ; if ( METHOD_2 ( ) . METHOD_4 ( ) == TYPE_3 . VAR_4 && <START> METHOD_2 ( ) . METHOD_5 ( ) . equals ( TYPE_2 . VAR_6 ) ) <END> { VAR_1 . METHOD_6 ( METHOD_2 ( ) . METHOD_7 ( ) ) ; VAR_2 . update ( VAR_1 ) ; } }
private void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . get ( METHOD_2 ( ) . METHOD_3 ( ) ) ; if ( METHOD_2 ( ) . METHOD_4 ( ) == TYPE_3 . VAR_4 && METHOD_2 ( ) . METHOD_5 ( ) == TYPE_2 . VAR_6 ) { VAR_1 . METHOD_6 ( METHOD_2 ( ) . METHOD_7 ( ) ) ; VAR_2 . update ( VAR_1 ) ; } }
calling super ? intentional don t call ? -
<START> public void METHOD_1 ( ) { <END> METHOD_2 ( ) ; if ( getParameters ( ) . METHOD_3 ( ) ) { Guid VAR_1 = METHOD_4 ( ) ; if ( VAR_1 != null ) { METHOD_5 ( VAR_1 ) ; } } METHOD_6 ( TYPE_1 . VAR_3 ) ; METHOD_7 ( true ) ; }
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; METHOD_2 ( ) ; if ( getParameters ( ) . METHOD_3 ( ) ) { Guid VAR_1 = METHOD_4 ( ) ; if ( VAR_1 != null ) { METHOD_5 ( VAR_1 ) ; } } METHOD_6 ( TYPE_1 . VAR_3 ) ; METHOD_7 ( true ) ; }
enable _CODE_
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 request = new TYPE_4 ( STRING_1 ) . build ( ) ; Map < String , Object > response = new TYPE_5 ( this . client , request , TYPE_6 . getInstance ( ) . METHOD_2 ( ) , VAR_1 ) . METHOD_3 ( STRING_2 ) ; <START> return new TYPE_1 ( response ) ; <END> }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 request = new TYPE_4 ( STRING_1 ) . build ( ) ; Map < String , Object > response = new TYPE_5 ( this . client , request , VAR_1 ) . METHOD_3 ( STRING_2 ) ; return new TYPE_1 ( response , true ) ; }
validation
protected boolean METHOD_1 ( ) { if ( ! getParameters ( ) . METHOD_2 ( ) . METHOD_3 ( ) ) { return METHOD_4 ( TYPE_2 . VAR_2 ) ; } <START> if ( ! TYPE_1 . METHOD_5 ( METHOD_6 ( ) ) ) { return METHOD_4 ( TYPE_2 . VAR_3 ) ; } <END> return METHOD_7 ( getParameters ( ) . METHOD_2 ( ) . METHOD_8 ( ) ) ; }
protected boolean METHOD_1 ( ) { if ( ! TYPE_1 . METHOD_5 ( METHOD_6 ( ) ) ) { return METHOD_4 ( TYPE_2 . VAR_3 ) ; } if ( ! getParameters ( ) . METHOD_2 ( ) . METHOD_3 ( ) ) { return METHOD_4 ( TYPE_2 . VAR_2 ) ; } return METHOD_7 ( getParameters ( ) . METHOD_2 ( ) . METHOD_8 ( ) ) ; }
need = = true
protected boolean METHOD_1 ( ) { for ( TYPE_1 VAR_1 : METHOD_2 ( ) . METHOD_3 ( ) . values ( ) ) { TYPE_2 VAR_2 = VAR_3 . get ( VAR_1 . getId ( ) ) ; <START> if ( VAR_2 . METHOD_4 ( ) == true ) { <END> return false ; } } return true ; }
protected boolean METHOD_1 ( ) { for ( TYPE_1 VAR_1 : METHOD_2 ( ) . METHOD_3 ( ) . values ( ) ) { TYPE_2 VAR_2 = VAR_3 . get ( VAR_1 . getId ( ) ) ; if ( VAR_2 . METHOD_4 ( ) ) { return false ; } } return true ; }
executor class s field instead passing part call object
public TYPE_1 < TYPE_2 > call ( TYPE_3 req , TYPE_4 VAR_1 ) throws TYPE_5 { final TYPE_6 call = new TYPE_6 ( req , <START> VAR_2 , VAR_1 ) ; <END> this . VAR_3 . METHOD_1 ( req , call ) ; METHOD_2 ( req , call ) ; try { this . METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( req . VAR_4 ( ) ) ) ; } finally { METHOD_2 ( req , call ) ; } return call ; }
public TYPE_1 < TYPE_2 > call ( TYPE_3 req , TYPE_4 VAR_1 ) throws TYPE_5 { final TYPE_6 call = new TYPE_6 ( req , VAR_1 ) ; this . VAR_3 . METHOD_1 ( req , call ) ; METHOD_2 ( req , call ) ; try { this . METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( req . VAR_4 ( ) ) ) ; } finally { METHOD_2 ( req , call ) ; } return call ; }
I m work import storage domain process import done host calling _CODE_ done host
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) == null || METHOD_2 ( ) . METHOD_4 ( ) == null ) { VAR_1 . METHOD_5 ( METHOD_2 ( ) . METHOD_6 ( ) , <START> METHOD_7 ( ) . METHOD_8 ( ) ) ; <END> VAR_2 . update ( METHOD_2 ( ) . METHOD_6 ( ) ) ; } }
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) == null || METHOD_2 ( ) . METHOD_4 ( ) == null ) { VAR_1 . METHOD_5 ( METHOD_2 ( ) . METHOD_6 ( ) , METHOD_7 ( ) . getId ( ) ) ; VAR_2 . update ( METHOD_2 ( ) . METHOD_6 ( ) ) ; } }
shouldn t verify mac null avoid NPE ? _CODE_ check
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return ! VAR_2 . METHOD_2 ( ) <END> && ! METHOD_3 ( VAR_1 ) && VAR_2 . METHOD_4 ( VAR_1 . METHOD_5 ( ) ) ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 . METHOD_5 ( ) != null && ! VAR_2 . METHOD_2 ( ) && ! METHOD_3 ( VAR_1 ) && VAR_2 . METHOD_4 ( VAR_1 . METHOD_5 ( ) ) ; }
wouldn t a top - levelif ( VAR_2 ) guard condition instead checking loop
private void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 , boolean VAR_2 ) { for ( TYPE_1 < TYPE_2 > VAR_3 : VAR_4 ) { if ( VAR_3 != null <START> && VAR_2 ) { <END> VAR_3 . METHOD_2 ( null ) ; if ( VAR_3 instanceof TYPE_3 ) { ( ( TYPE_3 ) VAR_3 ) . METHOD_3 ( ) ; } } } if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( METHOD_4 ( METHOD_5 ( ) ) ) ; } }
private void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 , boolean VAR_2 ) { if ( VAR_2 ) { for ( TYPE_1 < TYPE_2 > VAR_3 : VAR_4 ) { if ( VAR_3 != null ) { VAR_3 . METHOD_2 ( null ) ; if ( VAR_3 instanceof TYPE_3 ) { ( ( TYPE_3 ) VAR_3 ) . METHOD_3 ( ) ; } } } } if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( METHOD_4 ( METHOD_5 ( ) ) ) ; } }
needed test emptiness s contained condition
public static boolean METHOD_1 ( String VAR_1 ) throws IOException { final Map < String , String > map = METHOD_2 ( VAR_1 ) ; if ( map . isEmpty ( ) ) { return false ; <START> } <END> return TYPE_1 . equals ( map . get ( VAR_2 ) ) && TYPE_2 . equals ( map . get ( VAR_3 ) ) ; }
public static boolean METHOD_1 ( String VAR_1 ) throws IOException { final Map < String , String > map = METHOD_2 ( VAR_1 ) ; return TYPE_1 . equals ( map . get ( VAR_2 ) ) && TYPE_2 . equals ( map . get ( VAR_3 ) ) ; }
pick : typecast inlined avoiding explicit VAR_2 variable declaration s needed
public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; if ( VAR_1 instanceof TYPE_3 ) { TYPE_3 VAR_2 = ( TYPE_3 ) VAR_1 ; <START> METHOD_2 ( VAR_2 . METHOD_3 ( ) ) ; <END> } }
public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; if ( VAR_1 instanceof TYPE_3 ) { METHOD_2 ( ( ( TYPE_3 ) VAR_1 ) . METHOD_3 ( ) ) ; } }
pick : _CODE_ java typecast inlined
public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { if ( VAR_1 instanceof TYPE_3 ) { TYPE_3 VAR_2 = ( TYPE_3 ) VAR_1 ; <START> METHOD_2 ( VAR_2 . METHOD_3 ( ) ) ; <END> } }
public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { if ( VAR_1 instanceof TYPE_3 ) { METHOD_2 ( ( ( TYPE_3 ) VAR_1 ) . METHOD_3 ( ) ) ; } }
I remove boolean put _CODE_ ( ) need call
public void METHOD_1 ( Object VAR_1 , TYPE_1 content ) { if ( VAR_1 == TYPE_4 . TYPE_2 ) { METHOD_2 ( VAR_4 , content ) ; } else if ( VAR_1 == TYPE_4 . TYPE_3 ) { <START> if ( ! VAR_6 ) { <END> METHOD_3 ( ) ; VAR_6 = true ; } METHOD_2 ( VAR_7 , content ) ; } else { super . METHOD_1 ( VAR_1 , content ) ; } }
public void METHOD_1 ( Object VAR_1 , TYPE_1 content ) { if ( VAR_1 == TYPE_4 . TYPE_2 ) { METHOD_2 ( VAR_4 , content ) ; } else if ( VAR_1 == TYPE_4 . TYPE_3 ) { METHOD_2 ( VAR_7 , content ) ; } else { super . METHOD_1 ( VAR_1 , content ) ; } }
huh
private void METHOD_1 ( ) { for ( TYPE_1 VAR_1 : METHOD_2 ( ) . METHOD_3 ( ) . values ( ) ) { <START> if ( VAR_1 . METHOD_4 ( ) == TYPE_3 . VAR_3 ) { } <END> if ( ! VAR_1 . METHOD_5 ( ) ) { VAR_4 . log ( this , TYPE_2 . VAR_6 ) ; break ; } } }
private void METHOD_1 ( ) { for ( TYPE_1 VAR_1 : METHOD_2 ( ) . METHOD_3 ( ) . values ( ) ) { if ( ! VAR_1 . METHOD_5 ( ) ) { VAR_4 . log ( this , TYPE_2 . VAR_6 ) ; break ; } } }
validation _CODE_ command move disks _CODE_ ( METHOD_12 verify ) _CODE_ command responsible move disks a running VM
protected boolean METHOD_1 ( ) { return super . METHOD_1 ( ) && METHOD_2 ( ) && METHOD_3 ( ) && METHOD_4 ( ) && METHOD_5 ( ) && METHOD_6 ( ) && METHOD_7 ( ) && METHOD_8 ( ) && METHOD_9 ( ) && METHOD_10 ( ) && METHOD_11 ( ) && METHOD_12 ( ) && METHOD_13 ( ) && METHOD_14 ( ) && METHOD_15 ( ) <START> && METHOD_16 ( ) ; <END> }
protected boolean METHOD_1 ( ) { return super . METHOD_1 ( ) && METHOD_2 ( ) && METHOD_3 ( ) && METHOD_4 ( ) && METHOD_5 ( ) && METHOD_6 ( ) && METHOD_7 ( ) && METHOD_8 ( ) && METHOD_9 ( ) && METHOD_10 ( ) && METHOD_11 ( ) && METHOD_12 ( ) && METHOD_13 ( ) && METHOD_14 ( ) && METHOD_15 ( ) ; }
appears change reverted
<START> protected void <END> METHOD_1 ( RuntimeException ex ) { if ( ex . getMessage ( ) == null || ! ex . getMessage ( ) . contains ( STRING_1 ) ) { log . error ( STRING_2 , this , ex . getMessage ( ) ) ; log . debug ( STRING_3 , ex ) ; } }
private void METHOD_1 ( RuntimeException ex ) { if ( ex . getMessage ( ) == null || ! ex . getMessage ( ) . contains ( STRING_1 ) ) { log . error ( STRING_2 , this , ex . getMessage ( ) ) ; log . debug ( STRING_3 , ex ) ; } }
needs called properly done
private void METHOD_1 ( ) { TYPE_1 VAR_1 = model . VAR_2 ( ) . METHOD_2 ( TYPE_1 . class ) ; if ( VAR_1 == null ) { return ; } <START> VAR_1 . METHOD_3 ( ) ; VAR_1 . METHOD_3 ( ) ; <END> }
private void METHOD_1 ( ) { TYPE_1 VAR_1 = model . VAR_2 ( ) . METHOD_2 ( TYPE_1 . class ) ; if ( VAR_1 == null ) { return ; } VAR_1 . METHOD_3 ( ) ; }
I 2 _CODE_ takes tab takes TYPE_2 convert TYPE_2 a tab passing Object wrong
private String METHOD_1 ( Object VAR_1 ) { String VAR_2 = STRING_1 ; if ( VAR_1 instanceof TYPE_1 ) { VAR_2 = ( ( TYPE_1 ) VAR_1 ) . METHOD_2 ( ) ; } <START> else if ( VAR_1 instanceof TYPE_2 ) { <END> VAR_2 = ( ( TYPE_2 ) VAR_1 ) . METHOD_3 ( ) ; } return VAR_2 ; }
private String METHOD_1 ( Object VAR_1 ) { String VAR_2 = STRING_1 ; if ( VAR_1 instanceof TYPE_1 ) { VAR_2 = ( ( TYPE_1 ) VAR_1 ) . METHOD_2 ( ) ; } return VAR_2 ; }
I change ( VAR_2 ! = null && VAR_2 METHOD_3 ( ) ! = null ) more explicit
protected void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ) ; <START> if ( VAR_2 != null ) { <END> TYPE_1 VAR_3 = VAR_1 . stream ( ) . filter ( VAR_4 - > TYPE_3 . equals ( VAR_2 . METHOD_3 ( ) , VAR_4 . getId ( ) ) ) . METHOD_4 ( ) . get ( ) ; METHOD_5 ( ) . METHOD_6 ( VAR_3 ) ; METHOD_5 ( ) . METHOD_7 ( false ) ; } }
protected void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ) ; if ( VAR_2 != null && VAR_2 . METHOD_3 ( ) != null ) { TYPE_1 VAR_3 = VAR_1 . stream ( ) . filter ( VAR_4 - > TYPE_3 . equals ( VAR_2 . METHOD_3 ( ) , VAR_4 . getId ( ) ) ) . METHOD_4 ( ) . get ( ) ; METHOD_5 ( ) . METHOD_6 ( VAR_3 ) ; METHOD_5 ( ) . METHOD_7 ( false ) ; } }
need ( ) a single parameter VAR_4 METHOD_3 ( e - > METHOD_4 ( ) ) ; work
public TYPE_3 ( ) { METHOD_1 ( TYPE_2 . VAR_3 . METHOD_2 ( this ) ) ; <START> VAR_4 . METHOD_3 ( ( e ) - > { METHOD_4 ( ) ; } ) ; <END> TYPE_1 . METHOD_5 ( ( e ) - > { METHOD_4 ( ) ; } ) ; }
public TYPE_3 ( ) { METHOD_1 ( TYPE_2 . VAR_3 . METHOD_2 ( this ) ) ; VAR_4 . METHOD_3 ( e - > { METHOD_4 ( ) ; } ) ; TYPE_1 . METHOD_5 ( e - > { METHOD_4 ( ) ; } ) ; }
I d lose notation shouldn t annotated s serialized
<START> public boolean METHOD_1 ( ) { return this . VAR_1 . equals ( this . VAR_2 ) ; } <END>
public boolean METHOD_1 ( ) { return VAR_1 . equals ( this . VAR_2 ) ; }
I m alright case task running simultaneously threads
public void METHOD_1 ( ) { if ( VAR_1 != null ) { try { VAR_1 . METHOD_2 ( true ) ; } catch ( Throwable t ) { <START> log . debug ( STRING_1 , TYPE_1 . METHOD_3 ( t ) ) ; <END> } } VAR_1 = VAR_2 . METHOD_4 ( this : : METHOD_5 , 0 , TYPE_2 < Integer > getValue ( TYPE_3 . TYPE_4 ) , TimeUnit . VAR_6 ) ; }
public void METHOD_1 ( ) { if ( VAR_1 != null ) { try { VAR_1 . METHOD_2 ( false ) ; } catch ( Throwable t ) { log . debug ( STRING_1 , TYPE_1 . METHOD_3 ( t ) ) ; } } VAR_1 = VAR_2 . METHOD_4 ( this : : METHOD_5 , 0 , TYPE_2 < Integer > getValue ( TYPE_3 . TYPE_4 ) , TimeUnit . VAR_6 ) ; }
map
public TYPE_1 list ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; Set < TYPE_2 > VAR_2 = METHOD_1 ( Set . VAR_3 , TYPE_5 . TYPE_6 , new TYPE_3 ( METHOD_2 ( VAR_6 ) ) , VAR_6 , false ) ; if ( VAR_2 != null ) { for ( TYPE_2 entity : VAR_2 ) { if ( entity . VAR_7 ( ) ) { <START> VAR_1 . METHOD_3 ( ) . add ( METHOD_4 ( TYPE_4 . map ( entity . VAR_8 ( ) , <END> null ) ) ) ; } } } return VAR_1 ; }
public TYPE_1 list ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; Set < TYPE_2 > VAR_2 = METHOD_1 ( Set . VAR_3 , TYPE_5 . TYPE_6 , new TYPE_3 ( METHOD_2 ( VAR_6 ) ) , VAR_6 , false ) ; if ( VAR_2 != null ) { for ( TYPE_2 entity : VAR_2 ) { if ( entity . VAR_7 ( ) ) { VAR_1 . METHOD_3 ( ) . add ( METHOD_4 ( map ( entity . VAR_8 ( ) , null ) ) ) ; } } } return VAR_1 ; }
line
private TYPE_1 METHOD_1 ( String VAR_1 , String id ) { TYPE_1 VAR_2 ; <START> VAR_2 = VAR_3 ; <END> TYPE_2 VAR_4 = new TYPE_2 ( ) ; VAR_4 . METHOD_2 ( TYPE_3 . VAR_6 ) ; VAR_4 . setText ( VAR_1 ) ; VAR_2 . add ( VAR_4 ) ; VAR_2 . METHOD_3 ( id ) ; VAR_2 . METHOD_4 ( e - > { e . VAR_7 ( ) ; } ) ; return VAR_2 ; }
private TYPE_1 METHOD_1 ( String VAR_1 , String id ) { TYPE_1 VAR_2 = VAR_3 ; TYPE_2 VAR_4 = new TYPE_2 ( ) ; VAR_4 . METHOD_2 ( TYPE_3 . VAR_6 ) ; VAR_4 . setText ( VAR_1 ) ; VAR_2 . add ( VAR_4 ) ; VAR_2 . METHOD_3 ( id ) ; VAR_2 . METHOD_4 ( e - > { e . VAR_7 ( ) ; } ) ; return VAR_2 ; }
VAR_3 METHOD_2 ( VAR_5 - > METHOD_3 ( VAR_5 ) ) ;
public TYPE_9 ( TYPE_1 < TYPE_2 < TYPE_3 , TYPE_4 > , TYPE_5 , TYPE_6 > VAR_2 ) { super ( VAR_2 ) ; VAR_3 = new TYPE_7 < > ( Arrays . asList ( TYPE_8 . values ( ) ) ) ; VAR_3 . METHOD_1 ( TYPE_8 . VAR_4 ) ; <START> VAR_3 . METHOD_2 ( VAR_5 - > { <END> METHOD_3 ( VAR_5 ) ; } ) ; METHOD_4 ( ) ; METHOD_5 ( METHOD_6 ( ) ) ; }
public TYPE_9 ( TYPE_1 < TYPE_2 < TYPE_3 , TYPE_4 > , TYPE_5 , TYPE_6 > VAR_2 ) { super ( VAR_2 ) ; VAR_3 = new TYPE_7 < > ( Arrays . asList ( TYPE_8 . values ( ) ) ) ; VAR_3 . METHOD_1 ( TYPE_8 . VAR_4 ) ; VAR_3 . METHOD_2 ( VAR_5 - > METHOD_3 ( VAR_5 ) ) ; METHOD_4 ( ) ; METHOD_5 ( METHOD_6 ( ) ) ; }
add ctor please
public Response remove ( ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_1 ( this , id ) ; TYPE_3 parameters = new TYPE_3 ( VAR_1 ) ; <START> parameters . VAR_2 ( METHOD_2 ( ) ) ; <END> return METHOD_3 ( TYPE_4 . TYPE_5 , parameters ) ; }
public Response remove ( ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_1 ( this , id ) ; TYPE_3 parameters = new TYPE_3 ( VAR_1 , METHOD_2 ( ) ) ; return METHOD_3 ( TYPE_4 . TYPE_5 , parameters ) ; }
move METHOD_3 return TYPE_1 I explained _CODE_ extend TYPE_1 simplify a bunch stuff
public TYPE_3 ( ) { TYPE_1 VAR_2 = new TYPE_1 ( ) ; TYPE_2 VAR_3 = new TYPE_2 ( ) ; VAR_3 . setText ( VAR_4 . METHOD_1 ( ) + STRING_1 ) ; VAR_3 . METHOD_2 ( STRING_2 ) ; <START> VAR_2 . add ( VAR_3 ) ; <END> VAR_2 . add ( METHOD_3 ( ) ) ; METHOD_4 ( VAR_2 ) ; }
public TYPE_3 ( ) { TYPE_2 VAR_3 = new TYPE_2 ( ) ; VAR_3 . setText ( VAR_4 . METHOD_1 ( ) + STRING_1 ) ; VAR_3 . METHOD_2 ( STRING_2 ) ; add ( VAR_3 ) ; add ( METHOD_3 ( ) ) ; }
call METHOD_1 ( i e line 83 ) ? conflict
protected void METHOD_1 ( ) { TYPE_1 < TYPE_2 > VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; VAR_1 . METHOD_5 ( METHOD_6 ( ) . METHOD_7 ( ) ) ; TYPE_1 < TYPE_2 > VAR_2 = METHOD_2 ( ) . METHOD_8 ( ) . METHOD_4 ( ) ; VAR_2 . METHOD_5 ( METHOD_6 ( ) . METHOD_9 ( ) ) ; <START> super . METHOD_1 ( ) ; <END> }
protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; TYPE_1 < TYPE_2 > VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; VAR_1 . METHOD_5 ( METHOD_6 ( ) . METHOD_7 ( ) ) ; TYPE_1 < TYPE_2 > VAR_2 = METHOD_2 ( ) . METHOD_8 ( ) . METHOD_4 ( ) ; VAR_2 . METHOD_5 ( METHOD_6 ( ) . METHOD_9 ( ) ) ; }
please rebase patch top ? null check redundant
public static TYPE_1 map ( TYPE_2 entity , TYPE_1 VAR_1 ) { TYPE_1 model = VAR_1 != null ? VAR_1 : new TYPE_1 ( ) ; model . VAR_2 ( entity . VAR_3 ( ) ) ; model . VAR_4 ( entity . VAR_5 ( ) ) ; <START> if ( entity . VAR_6 ( ) != null ) { <END> model . VAR_7 ( entity . VAR_6 ( ) ) ; } model . VAR_8 ( map ( entity . VAR_9 ( ) , null ) ) ; return model ; }
public static TYPE_1 map ( TYPE_2 entity , TYPE_1 VAR_1 ) { TYPE_1 model = VAR_1 != null ? VAR_1 : new TYPE_1 ( ) ; model . VAR_2 ( entity . VAR_3 ( ) ) ; model . VAR_4 ( entity . VAR_5 ( ) ) ; model . VAR_7 ( entity . VAR_6 ( ) ) ; model . VAR_8 ( map ( entity . VAR_9 ( ) , null ) ) ; return model ; }
I doesn t more sense default TYPE_4
public static TYPE_1 map ( org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . VAR_6 . TYPE_1 VAR_8 , TYPE_1 VAR_9 ) { switch ( VAR_8 ) { case TYPE_4 : return TYPE_1 . VAR_11 ; case VAR_12 : return TYPE_1 . VAR_12 ; case TYPE_3 : return TYPE_1 . VAR_14 ; case TYPE_5 : return TYPE_1 . VAR_16 ; case TYPE_2 : return TYPE_1 . VAR_18 ; <START> default : return null ; <END> } }
public static TYPE_1 map ( org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . VAR_6 . TYPE_1 VAR_8 , TYPE_1 VAR_9 ) { switch ( VAR_8 ) { case VAR_12 : return TYPE_1 . VAR_12 ; case TYPE_3 : return TYPE_1 . VAR_14 ; case TYPE_5 : return TYPE_1 . VAR_16 ; case TYPE_2 : return TYPE_1 . VAR_18 ; default : return TYPE_1 . VAR_11 ; } }
pick : consistency please movethis xx = xx ; declarations top actual logic METHOD_1 ( ) call
public TYPE_5 ( TYPE_1 < T , TYPE_2 > VAR_2 , TYPE_3 VAR_3 ) { this . VAR_3 = VAR_3 ; <START> METHOD_1 ( TYPE_4 . VAR_5 . METHOD_2 ( this ) ) ; <END> this . VAR_2 = VAR_2 ; }
public TYPE_5 ( TYPE_1 < T , TYPE_2 > VAR_2 , TYPE_3 VAR_3 ) { this . VAR_3 = VAR_3 ; this . VAR_2 = VAR_2 ; METHOD_1 ( TYPE_4 . VAR_5 . METHOD_2 ( this ) ) ; }
need
private List < TYPE_1 > METHOD_1 ( ) { <START> TYPE_1 VAR_1 = VAR_2 ; <END> VAR_1 . METHOD_2 ( ) . addAll ( VAR_3 ) ; return Arrays . asList ( VAR_2 , VAR_4 , VAR_5 , VAR_6 ) ; }
private List < TYPE_1 > METHOD_1 ( ) { VAR_2 . METHOD_2 ( ) . addAll ( VAR_3 ) ; return Arrays . asList ( VAR_2 , VAR_4 , VAR_5 , VAR_6 ) ; }
METHOD_3 exposed TYPE_1 interface lose METHOD_2
private void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 ) { if ( VAR_2 instanceof TYPE_2 ) { continue ; } TYPE_3 VAR_3 = TYPE_3 . class . METHOD_2 ( VAR_2 ) ; assertTrue ( STRING_1 , <START> VAR_3 . METHOD_3 ( ) ) ; <END> } }
private void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 ) { if ( VAR_2 instanceof TYPE_2 ) { continue ; } TYPE_3 VAR_3 = ( TYPE_3 ) VAR_2 ; assertTrue ( STRING_1 , VAR_3 . METHOD_3 ( ) ) ; } }
don t need don t provided = true
<START> private void METHOD_1 ( ) { <END> VAR_1 = new TYPE_1 ( TYPE_2 . VAR_3 , VAR_4 . METHOD_2 ( ) , TYPE_3 . VAR_6 ) ; }
private void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( TYPE_2 . VAR_3 ) ; }
VAR_4 consistency
public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 < T , ? > column , TYPE_3 < T > table ) { this . VAR_2 = VAR_2 ; this . column = column ; this . table = table ; this . VAR_3 = TYPE_4 . METHOD_1 ( this ) ; <START> VAR_4 = <END> VAR_2 . METHOD_2 ( ) ; table . VAR_5 ( column , VAR_2 ) ; }
public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 < T , ? > column , TYPE_3 < T > table ) { this . VAR_2 = VAR_2 ; this . column = column ; this . table = table ; this . VAR_3 = TYPE_4 . METHOD_1 ( this ) ; this . VAR_4 = VAR_2 . METHOD_2 ( ) ; table . VAR_5 ( column , VAR_2 ) ; }
need filtering
public void METHOD_1 ( ) { List < TYPE_1 > result = VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 , null , false ) ; <START> List < TYPE_1 > VAR_4 = result . stream ( ) . filter ( VAR_5 - > VAR_5 . getId ( ) . equals ( TYPE_2 . VAR_3 ) ) . collect ( Collectors . VAR_6 ( ) ) ; assertEquals ( STRING_1 , 4 , VAR_4 . size ( ) ) ; <END> }
public void METHOD_1 ( ) { List < TYPE_1 > result = VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 , null , false ) ; assertEquals ( STRING_1 , 4 , result . size ( ) ) ; }
I drop else
public int METHOD_1 ( TYPE_1 o ) { int VAR_1 = VAR_2 . METHOD_1 ( o . VAR_2 ) ; if ( VAR_1 == 0 ) { return VAR_3 . METHOD_1 ( o . VAR_3 ) ; } <START> else { <END> return VAR_1 ; } }
public int METHOD_1 ( TYPE_1 o ) { int VAR_1 = VAR_2 . METHOD_1 ( o . VAR_2 ) ; if ( VAR_1 == 0 ) { return VAR_3 . METHOD_1 ( o . VAR_3 ) ; } return VAR_1 ; }
need
public TYPE_1 ( Map < String , Object > VAR_2 ) { super ( VAR_2 ) ; <START> this . VAR_3 <END> = ( Map < String , Object > ) VAR_2 . get ( VAR_4 ) ; }
public TYPE_1 ( Map < String , Object > VAR_2 ) { super ( VAR_2 ) ; VAR_3 = ( Map < String , Object > ) VAR_2 . get ( VAR_4 ) ; }
return METHOD_2 ( VAR_1 METHOD_3 ( ) ) ;
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( ! METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ) { return false ; } return true ; <END> }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; }
please remove unnecessary brackets : String VAR_3 = ( VAR_2 ! = null ) ? VAR_2 getValue ( ) : TYPE_1 METHOD_2 ( ) getValue ( ) ;
public int METHOD_1 ( Integer VAR_1 , TYPE_1 VAR_2 ) { <START> String VAR_3 = ( VAR_2 != null ) ? VAR_2 . getValue ( ) : TYPE_1 . METHOD_2 ( ) . getValue ( ) ; <END> if ( VAR_1 == null ) { return METHOD_3 ( VAR_3 ) ; } final TYPE_2 VAR_4 = METHOD_4 ( VAR_1 ) ; return ( Integer ) METHOD_5 ( VAR_4 , VAR_3 ) ; }
public int METHOD_1 ( Integer VAR_1 , TYPE_1 VAR_2 ) { String VAR_3 = VAR_2 != null ? VAR_2 . getValue ( ) : TYPE_1 . METHOD_2 ( ) . getValue ( ) ; if ( VAR_1 == null ) { return METHOD_3 ( VAR_3 ) ; } final TYPE_2 VAR_4 = METHOD_4 ( VAR_1 ) ; return ( Integer ) METHOD_5 ( VAR_4 , VAR_3 ) ; }
please remove unneeded parenthesis : ( VAR_9 ! = null&& VAR_9 METHOD_5 ( ) equals ( VAR_4 getId ( ) ) ) {
public String METHOD_1 ( Guid VAR_1 ) { List < TYPE_1 > VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; for ( TYPE_2 VAR_4 : VAR_5 . METHOD_3 ( TYPE_5 . VAR_7 ) ) { for ( TYPE_1 VAR_8 : VAR_2 ) { TYPE_3 VAR_9 = VAR_8 . METHOD_4 ( ) ; if ( ( VAR_9 != null ) <START> && ( VAR_9 . METHOD_5 ( ) . equals ( VAR_4 . getId ( ) ) ) ) { <END> return TYPE_4 . METHOD_6 ( VAR_4 . METHOD_7 ( ) ) ; } } } return null ; }
public String METHOD_1 ( Guid VAR_1 ) { List < TYPE_1 > VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; for ( TYPE_2 VAR_4 : VAR_5 . METHOD_3 ( TYPE_5 . VAR_7 ) ) { for ( TYPE_1 VAR_8 : VAR_2 ) { TYPE_3 VAR_9 = VAR_8 . METHOD_4 ( ) ; if ( VAR_9 != null && ( VAR_9 . METHOD_5 ( ) . equals ( VAR_4 . getId ( ) ) ) ) { return TYPE_4 . METHOD_6 ( VAR_4 . METHOD_7 ( ) ) ; } } } return null ; }
unnecessary : - ) ( VAR_9 ! = null&& VAR_9 METHOD_5 ( ) equals ( VAR_4 getId ( ) ) ) {
public String METHOD_1 ( Guid VAR_1 ) { List < TYPE_1 > VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; for ( TYPE_2 VAR_4 : VAR_5 . METHOD_3 ( TYPE_5 . VAR_7 ) ) { for ( TYPE_1 VAR_8 : VAR_2 ) { TYPE_3 VAR_9 = VAR_8 . METHOD_4 ( ) ; if ( VAR_9 != null <START> && ( VAR_9 . METHOD_5 ( ) . equals ( VAR_4 . getId ( ) ) ) ) { <END> return TYPE_4 . METHOD_6 ( VAR_4 . METHOD_7 ( ) ) ; } } } return null ; }
public String METHOD_1 ( Guid VAR_1 ) { List < TYPE_1 > VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; for ( TYPE_2 VAR_4 : VAR_5 . METHOD_3 ( TYPE_5 . VAR_7 ) ) { for ( TYPE_1 VAR_8 : VAR_2 ) { TYPE_3 VAR_9 = VAR_8 . METHOD_4 ( ) ; if ( VAR_9 != null && VAR_9 . METHOD_5 ( ) . equals ( VAR_4 . getId ( ) ) ) { return TYPE_4 . METHOD_6 ( VAR_4 . METHOD_7 ( ) ) ; } } } return null ; }
openstack metadata supported ? I m concerned a scenario customers templates installed version cloud init doesn t support
public TYPE_2 ( TYPE_1 VAR_2 ) { this . VAR_2 = VAR_2 ; VAR_3 = new HashMap < > ( ) ; VAR_4 = new HashMap < > ( ) ; VAR_5 = new HashMap < > ( ) ; VAR_6 = 0 ; <START> this . VAR_7 = TYPE_3 . VAR_9 ; <END> }
public TYPE_2 ( TYPE_1 VAR_2 ) { this ( VAR_2 , TYPE_3 . VAR_9 ) ; }