Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
errata : I beg pardon ; declarative programming phrase I meant imperative programming
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return TYPE_1 . METHOD_2 ( TYPE_4 . VAR_3 , TYPE_3 . METHOD_3 ( STRING_1 , host . getStatus ( ) . name ( ) ) ) <START> . METHOD_4 ( VAR_1 == host . getStatus ( ) ) ; <END> }
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return TYPE_1 . METHOD_2 ( TYPE_4 . VAR_3 , TYPE_3 . METHOD_3 ( STRING_1 , VAR_1 . name ( ) ) ) . METHOD_4 ( VAR_1 == host . getStatus ( ) ) ; }
albeit related patch - shouldn t called explicitly getter
private void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; <START> List < Guid > VAR_2 = TYPE_2 . METHOD_3 ( VAR_1 ) ; <END> if ( ! VAR_1 . isEmpty ( ) ) { VAR_3 . METHOD_4 ( VAR_2 ) ; VAR_3 . METHOD_5 ( METHOD_6 ( ) ) ; } }
private void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_6 ( ) ; List < Guid > VAR_2 = TYPE_2 . METHOD_3 ( VAR_1 ) ; if ( ! VAR_1 . isEmpty ( ) ) { VAR_3 . METHOD_4 ( VAR_2 ) ; VAR_3 . METHOD_5 ( VAR_1 ) ; } }
I guess need thread safety wouldn t simpler eagerly set VAR_1 ? _CODE_ a singleton a
public TYPE_1 METHOD_1 ( ) throws TYPE_2 , TYPE_3 , IOException { <START> if ( VAR_1 == null ) { <END> String url = String . format ( STRING_1 , VAR_2 , server , VAR_3 ) ; log . debug ( String . format ( STRING_2 , url , VAR_4 ) ) ; VAR_1 = new TYPE_1 ( url , VAR_4 , VAR_5 , true ) ; } return VAR_1 ; }
public synchronized TYPE_1 METHOD_1 ( ) throws TYPE_2 , TYPE_3 , IOException { if ( VAR_1 == null ) { String url = String . format ( STRING_1 , VAR_2 , server , VAR_3 ) ; log . debug ( String . format ( STRING_2 , url , VAR_4 ) ) ; VAR_1 = new TYPE_1 ( url , VAR_4 , VAR_5 , true ) ; } return VAR_1 ; }
typically write annotations separate line
<START> @Override public void METHOD_1 ( boolean VAR_1 ) { <END> VAR_2 . METHOD_1 ( VAR_1 ) ; if ( VAR_3 instanceof TYPE_1 ) { TYPE_1 VAR_4 = ( TYPE_1 ) this . VAR_3 ; VAR_4 . METHOD_1 ( VAR_1 ) ; } }
public void METHOD_1 ( boolean VAR_1 ) { VAR_2 . METHOD_1 ( VAR_1 ) ; if ( VAR_3 instanceof TYPE_1 ) { TYPE_1 VAR_4 = ( TYPE_1 ) this . VAR_3 ; VAR_4 . METHOD_1 ( VAR_1 ) ; } }
please static import
public void METHOD_1 ( ) { <START> TYPE_1 . when ( VAR_1 . METHOD_2 ( VAR_2 ) ) . METHOD_3 ( true ) ; <END> METHOD_4 ( VAR_3 . METHOD_2 ( VAR_2 ) ) ; }
public void METHOD_1 ( ) { when ( VAR_1 . METHOD_2 ( VAR_2 ) ) . METHOD_3 ( true ) ; METHOD_4 ( VAR_3 . METHOD_2 ( VAR_2 ) ) ; }
logger debug trace
protected void METHOD_1 ( ) { <START> logger . info ( this . getClass ( ) . toString ( ) + STRING_1 ) ; <END> if ( METHOD_2 ( ) != null ) { return ; } TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_3 ( VAR_2 . METHOD_4 ( getName ( ) ) ) ; VAR_1 . METHOD_5 ( METHOD_6 ( ) ) ; VAR_1 . METHOD_7 ( getName ( ) ) ; METHOD_8 ( VAR_1 ) ; METHOD_9 ( VAR_1 ) ; }
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) != null ) { return ; } TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_3 ( VAR_2 . METHOD_4 ( getName ( ) ) ) ; VAR_1 . METHOD_5 ( METHOD_6 ( ) ) ; VAR_1 . METHOD_7 ( getName ( ) ) ; METHOD_8 ( VAR_1 ) ; METHOD_9 ( VAR_1 ) ; }
debug / trace
protected TYPE_1 METHOD_1 ( ) { <START> logger . info ( this . getClass ( ) . toString ( ) + STRING_1 ) ; <END> return TYPE_2 . get ( TYPE_3 . VAR_2 ) ; }
protected TYPE_1 METHOD_1 ( ) { return TYPE_2 . get ( TYPE_3 . VAR_2 ) ; }
debug / trace / remove
protected void METHOD_1 ( ) { <START> logger . info ( this . getClass ( ) . toString ( ) + STRING_1 ) ; <END> TYPE_1 . METHOD_2 ( this , METHOD_3 ( ) ) ; }
protected void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( this , METHOD_3 ( ) ) ; }
debug / trace / remove
public void METHOD_1 ( TYPE_1 event ) { <START> logger . info ( this . getClass ( ) . toString ( ) + STRING_1 ) ; <END> METHOD_2 ( event . VAR_1 ( ) ) ; }
public void METHOD_1 ( TYPE_1 event ) { METHOD_2 ( event . VAR_1 ( ) ) ; }
debug / trace / remove
public TYPE_9 ( TYPE_1 VAR_2 , TYPE_2 view , TYPE_3 VAR_3 , TYPE_4 VAR_4 , TYPE_5 < TYPE_6 < TYPE_7 > , TYPE_8 > VAR_5 ) { super ( VAR_2 , view , VAR_3 , VAR_4 , VAR_5 , TYPE_10 . TYPE_11 ) ; VAR_8 = METHOD_1 ( ) . METHOD_2 ( ) ; <START> logger . info ( STRING_1 + this . toString ( ) ) ; <END> }
public TYPE_9 ( TYPE_1 VAR_2 , TYPE_2 view , TYPE_3 VAR_3 , TYPE_4 VAR_4 , TYPE_5 < TYPE_6 < TYPE_7 > , TYPE_8 > VAR_5 ) { super ( VAR_2 , view , VAR_3 , VAR_4 , VAR_5 , TYPE_10 . TYPE_11 ) ; VAR_8 = METHOD_1 ( ) . METHOD_2 ( ) ; }
debug / trace / remove
protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; <START> logger . info ( this . getClass ( ) . toString ( ) + STRING_1 ) ; <END> METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ; METHOD_3 ( ) . METHOD_7 ( ) . METHOD_5 ( VAR_1 . METHOD_8 ( ) ) ; METHOD_3 ( ) . METHOD_9 ( ) . METHOD_5 ( VAR_1 . METHOD_10 ( ) ) ; }
protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ; METHOD_3 ( ) . METHOD_7 ( ) . METHOD_5 ( VAR_1 . METHOD_8 ( ) ) ; METHOD_3 ( ) . METHOD_9 ( ) . METHOD_5 ( VAR_1 . METHOD_10 ( ) ) ; }
I guessing VAR_4 else ? especially VAR_4 defined
private void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( ) ; VAR_2 = new TYPE_2 ( ) ; VAR_3 = new TYPE_3 ( ) ; VAR_3 . METHOD_2 ( VAR_4 . METHOD_3 ( ) ) ; TYPE_1 VAR_5 = new TYPE_1 ( ) ; VAR_5 . METHOD_2 ( VAR_4 . METHOD_4 ( ) ) ; VAR_5 . add ( VAR_3 ) ; VAR_1 . add ( VAR_5 ) ; <START> VAR_1 . METHOD_2 ( STRING_1 ) ; <END> VAR_1 . add ( VAR_2 ) ; }
private void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( ) ; VAR_2 = new TYPE_2 ( ) ; VAR_3 = new TYPE_3 ( ) ; VAR_3 . METHOD_2 ( VAR_4 . METHOD_3 ( ) ) ; TYPE_1 VAR_5 = new TYPE_1 ( ) ; VAR_5 . METHOD_2 ( VAR_4 . METHOD_4 ( ) ) ; VAR_5 . add ( VAR_3 ) ; VAR_1 . add ( VAR_5 ) ; VAR_1 . add ( VAR_2 ) ; }
debug / trace / remove
public void METHOD_1 ( boolean VAR_1 ) { <START> logger . info ( STRING_1 ) ; <END> VAR_2 . clear ( ) ; if ( VAR_1 ) { VAR_2 . METHOD_2 ( VAR_3 , VAR_4 ) ; } VAR_2 . add ( VAR_5 ) ; }
public void METHOD_1 ( boolean VAR_1 ) { VAR_2 . clear ( ) ; if ( VAR_1 ) { VAR_2 . METHOD_2 ( VAR_3 , VAR_4 ) ; } VAR_2 . add ( VAR_5 ) ; }
pass VAR_1 METHOD_2 ( ) called method handling null pool id please change rebase patch other good
protected Pair < Boolean , TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 , Guid VAR_2 , int type ) { Guid VAR_3 = Guid . TYPE_3 ; if ( VAR_1 . METHOD_2 ( ) != null ) { VAR_3 = VAR_1 . METHOD_2 ( ) ; <START> } <END> return METHOD_1 ( VAR_1 , VAR_2 , type , null , VAR_3 ) ; }
protected Pair < Boolean , TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 , Guid VAR_2 , int type ) { return METHOD_1 ( VAR_1 , VAR_2 , type , null , VAR_1 . METHOD_2 ( ) ) ; }
_CODE_
protected void METHOD_1 ( boolean VAR_1 ) { Set < TYPE_1 > VAR_2 ; VAR_2 = VAR_1 ? TYPE_2 . of ( TYPE_1 . TYPE_4 , TYPE_1 . TYPE_5 , TYPE_1 . TYPE_6 ) : TYPE_2 . of ( TYPE_1 . TYPE_4 , TYPE_1 . TYPE_5 ) ; VAR_6 = TYPE_3 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . getId ( ) , null , VAR_2 ) ; METHOD_5 ( ) ; <START> METHOD_6 ( ) ; <END> }
protected void METHOD_1 ( boolean VAR_1 ) { Set < TYPE_1 > VAR_2 ; VAR_2 = VAR_1 ? TYPE_2 . of ( TYPE_1 . TYPE_4 , TYPE_1 . TYPE_5 , TYPE_1 . TYPE_6 ) : TYPE_2 . of ( TYPE_1 . TYPE_4 , TYPE_1 . TYPE_5 ) ; VAR_6 = TYPE_3 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . getId ( ) , null , VAR_2 ) ; METHOD_5 ( ) ; METHOD_6 ( VAR_2 ) ; }
VAR_1 null ? ( check line 112 implies )
<START> private Map < String , Object > METHOD_1 ( Map < TYPE_1 , TYPE_2 > VAR_1 ) { <END> Map < String , Object > VAR_2 = null ; if ( VAR_1 . containsKey ( TYPE_1 . VAR_3 ) ) { VAR_2 = new HashMap ( ) ; VAR_2 . put ( TYPE_3 . VAR_5 , Boolean . toString ( vm . VAR_6 ( ) ) ) ; VAR_2 . put ( TYPE_3 . VAR_7 , Boolean . toString ( vm . VAR_8 ( ) ) ) ; } return VAR_2 ; }
private Map < String , Object > METHOD_1 ( Map < TYPE_1 , TYPE_2 > VAR_1 ) { Map < String , Object > VAR_2 = null ; if ( VAR_1 != null && VAR_1 . containsKey ( TYPE_1 . VAR_3 ) ) { VAR_2 = new HashMap ( ) ; VAR_2 . put ( TYPE_3 . VAR_5 , Boolean . toString ( vm . VAR_6 ( ) ) ) ; VAR_2 . put ( TYPE_3 . VAR_7 , Boolean . toString ( vm . VAR_8 ( ) ) ) ; } return VAR_2 ; }
consider rephrasing return ! ( condition ) return ( cond1 && cond2 && )
public static boolean METHOD_1 ( TYPE_1 vds ) { if ( TYPE_2 . METHOD_2 ( METHOD_3 ( vds . getId ( ) ) . METHOD_4 ( ) ) ) { TYPE_3 VAR_1 = vds . VAR_2 ( ) ; <START> if ( VAR_1 == null || <END> VAR_1 . METHOD_5 ( ) == null || VAR_1 . METHOD_5 ( ) . isEmpty ( ) ) { return false ; } return true ; } return true ; }
public static boolean METHOD_1 ( TYPE_1 vds ) { if ( TYPE_2 . METHOD_2 ( METHOD_3 ( vds . getId ( ) ) . METHOD_4 ( ) ) ) { TYPE_3 VAR_1 = vds . VAR_2 ( ) ; return VAR_1 == null || VAR_1 . METHOD_5 ( ) == null || VAR_1 . METHOD_5 ( ) . isEmpty ( ) ; } return true ; }
error line 179 shown simply replace line 221 - 226 return VAR_3 METHOD_4 ;
private boolean METHOD_1 ( TYPE_1 vds , List < TYPE_2 > VAR_1 , boolean VAR_2 ) { TYPE_3 VAR_3 = TYPE_4 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_7 . TYPE_6 , new TYPE_5 ( vds . getId ( ) , VAR_1 , VAR_2 ) ) ; if ( ! VAR_3 . METHOD_4 ( ) ) { <START> log . error ( STRING_1 , vds . getName ( ) ) ; <END> return false ; } return true ; }
private boolean METHOD_1 ( TYPE_1 vds , List < TYPE_2 > VAR_1 , boolean VAR_2 ) { TYPE_3 VAR_3 = TYPE_4 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_7 . TYPE_6 , new TYPE_5 ( vds . getId ( ) , VAR_1 , VAR_2 ) ) ; return VAR_3 . METHOD_4 ( ) ; }
please consistent _CODE_ default case fallthrough TYPE_3
private String METHOD_1 ( TYPE_1 VAR_1 ) { switch ( VAR_1 ) { case TYPE_2 : return VAR_3 . METHOD_2 ( ) ; case TYPE_3 : return VAR_3 . METHOD_3 ( ) ; default : <START> return "" ; <END> } }
private String METHOD_1 ( TYPE_1 VAR_1 ) { switch ( VAR_1 ) { case TYPE_2 : return VAR_3 . METHOD_2 ( ) ; case TYPE_3 : return VAR_3 . METHOD_3 ( ) ; default : return VAR_3 . METHOD_3 ( ) ; } }
view display model data shouldn t logic showing data doesn t represent model values root problem resides - TYPE_1 public TYPE_1 ( network network ) - > ( network _CODE_ ( ) = = null ) - > _CODE_ ( ) _CODE_ ( new _CODE_ ( / * METHOD_2 * / ! network _CODE_ ( ) ) ) ; means case detached network required true default ( case internal network ) changed false ( matter network internal external )
public Boolean getValue ( TYPE_1 VAR_1 ) { <START> return VAR_1 . METHOD_1 ( ) && VAR_1 . METHOD_2 ( ) ; <END> }
public Boolean getValue ( TYPE_1 VAR_1 ) { return VAR_1 . METHOD_2 ( ) ; }
empty return isn t needed
public void execute ( T t ) { <START> return ; <END> }
public void execute ( T t ) { }
static - please fix rebase
<START> private void METHOD_1 ( String VAR_1 , String VAR_2 ) throws IOException { <END> assertEquals ( STRING_1 , String . format ( STRING_2 + STRING_3 , VAR_1 , StringUtils . VAR_3 ( VAR_2 ) ) , TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 ) ) ; }
private static void METHOD_1 ( String VAR_1 , String VAR_2 ) throws IOException { assertEquals ( STRING_1 , String . format ( STRING_2 + STRING_3 , VAR_1 , StringUtils . VAR_3 ( VAR_2 ) ) , TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 ) ) ; }
assumes json helper parses values strings s play safe toString ( ) instead a cast
public static void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) throws IOException { Map < String , Object > VAR_3 = TYPE_2 . METHOD_2 ( VAR_1 ) ; VAR_2 . METHOD_3 ( ( String ) VAR_3 . get ( VAR_4 ) ) ; <START> VAR_2 . METHOD_4 ( ( String ) VAR_3 . get ( VAR_5 ) ) ; <END> }
public static void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) throws IOException { Map < String , Object > VAR_3 = TYPE_2 . METHOD_2 ( VAR_1 ) ; VAR_2 . METHOD_3 ( VAR_3 . get ( VAR_4 ) . toString ( ) ) ; VAR_2 . METHOD_4 ( VAR_3 . get ( VAR_5 ) . toString ( ) ) ; }
VAR_2 isEmpty instead
private int METHOD_1 ( String VAR_1 , Map < String , Object > VAR_2 ) { return String . format ( STRING_1 , VAR_1 ) . length ( ) + <START> ( VAR_2 . size ( ) >= 1 ? 1 : 0 ) ; <END> }
private int METHOD_1 ( String VAR_1 , Map < String , Object > VAR_2 ) { return String . format ( STRING_1 , VAR_1 ) . length ( ) + ( VAR_2 . isEmpty ( ) ? 0 : 1 ) ; }
return METHOD_1 ( VAR_2 METHOD_4 ( VAR_1 ) ) && METHOD_1 ( VAR_2 METHOD_6 ( METHOD_7 ( ) ) ) ;
protected boolean METHOD_1 ( ) { Guid VAR_1 = getParameters ( ) . METHOD_2 ( ) ; TYPE_1 VAR_2 = new TYPE_1 ( METHOD_3 ( ) ) ; TYPE_2 VAR_3 = VAR_2 . METHOD_4 ( VAR_1 ) ; if ( ! VAR_3 . METHOD_5 ( ) ) { return METHOD_1 ( VAR_3 ) ; } <START> return METHOD_1 ( VAR_2 . METHOD_6 ( METHOD_7 ( ) ) ) ; <END> }
protected boolean METHOD_1 ( ) { Guid VAR_1 = getParameters ( ) . METHOD_2 ( ) ; TYPE_1 VAR_2 = new TYPE_1 ( METHOD_3 ( ) ) ; return METHOD_1 ( VAR_2 . METHOD_4 ( VAR_1 ) ) && METHOD_1 ( VAR_2 . METHOD_6 ( METHOD_7 ( ) ) ) ; }
a bit clunk - call ( )
public TYPE_2 ( Guid VAR_2 , TYPE_1 VAR_3 ) { super ( VAR_2 ) ; METHOD_1 ( VAR_3 ) ; <START> METHOD_2 ( false ) ; <END> }
public TYPE_2 ( Guid VAR_2 , TYPE_1 VAR_3 ) { this ( VAR_2 , VAR_3 , false , null ) ; }
static fields TYPE_2 more related real scenario testing
private void METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { assertEquals ( STRING_1 , String . format ( STRING_2 + <START> STRING_3 , <END> VAR_1 . METHOD_2 ( ) , StringUtils . VAR_2 ( VAR_1 . METHOD_3 ( ) ) ) , TYPE_2 . METHOD_4 ( VAR_1 ) ) ; }
private static void METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { assertEquals ( STRING_1 , String . format ( STRING_2 + STRING_3 , VAR_1 . METHOD_2 ( ) , StringUtils . VAR_2 ( VAR_1 . METHOD_3 ( ) ) ) , TYPE_2 . METHOD_4 ( VAR_1 ) ) ; }
chance approach
<START> private static Set < String > METHOD_1 ( TYPE_1 vds ) { <END> return new HashSet < > ( Arrays . asList ( vds . VAR_1 ( ) . split ( STRING_1 ) ) ) ; }
private static Set < String > METHOD_1 ( TYPE_1 vds ) { if ( vds . VAR_1 ( ) == null ) { return new HashSet < > ( ) ; } else { return new HashSet < > ( Arrays . asList ( vds . VAR_1 ( ) . split ( STRING_1 ) ) ) ; } }
extract method primary address lines shorter
private boolean METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( VAR_1 . METHOD_3 ( ) , <START> METHOD_4 ( ) ? VAR_2 . METHOD_5 ( ) . METHOD_6 ( ) <END> : null ) ; }
private boolean METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( VAR_1 . METHOD_3 ( ) , METHOD_4 ( ) ? METHOD_5 ( ) . METHOD_6 ( ) : null ) ; }
need check METHOD_5 null - done _CODE_
private void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( METHOD_3 ( ) . METHOD_4 ( ) , <START> METHOD_5 ( ) != null ? METHOD_5 ( ) . METHOD_6 ( ) : null ) ; <END> }
private void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( METHOD_3 ( ) . METHOD_4 ( ) , METHOD_5 ( ) . METHOD_6 ( ) ) ; }
pls formatter
public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( this ) ; if ( TYPE_2 . METHOD_3 ( ) == null ) { TYPE_2 . METHOD_4 ( METHOD_5 ( TYPE_3 . class ) ) ; } <START> when ( TYPE_2 . METHOD_3 ( ) . getValue ( TYPE_5 . TYPE_4 , TYPE_6 . VAR_4 ) ) . METHOD_6 ( INT_1 ) ; <END> }
public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( this ) ; }
formatter
public void METHOD_1 ( ) { when ( model . VAR_1 ( ) ) . METHOD_2 ( null , VAR_2 ) ; TYPE_1 . METHOD_3 ( METHOD_4 ( TYPE_2 . class ) ) ; <START> when ( TYPE_1 . METHOD_5 ( ) . getValue ( TYPE_4 . TYPE_3 , TYPE_5 . VAR_6 ) ) . METHOD_2 ( INT_1 ) ; <END> }
public void METHOD_1 ( ) { when ( model . VAR_1 ( ) ) . METHOD_2 ( null , VAR_2 ) ; }
change modifier ? want change list _CODE_ isn t enough - _CODE_ ( ) _CODE_ ( _CODE_ )
<START> protected void METHOD_1 ( TYPE_1 < Map . Entry < String , TYPE_2 < String > > > value ) { <END> VAR_1 = value ; }
private void METHOD_1 ( TYPE_1 < Map . Entry < String , TYPE_2 < String > > > value ) { VAR_1 = value ; }
a more defensive put call super ( ) call want treat _CODE_ ancestor ( )
public void METHOD_1 ( TYPE_1 < ? extends TYPE_2 > VAR_1 , Object VAR_2 , TYPE_2 args ) { super . METHOD_1 ( VAR_1 , VAR_2 , args ) ; if ( VAR_1 . METHOD_2 ( TYPE_5 . TYPE_4 ) ) { METHOD_3 ( ) ; } if ( VAR_1 . METHOD_2 ( TYPE_3 . VAR_6 ) ) { METHOD_4 ( ) ; } <START> VAR_7 . METHOD_1 ( VAR_1 , VAR_2 , args ) ; <END> }
public void METHOD_1 ( TYPE_1 < ? extends TYPE_2 > VAR_1 , Object VAR_2 , TYPE_2 args ) { super . METHOD_1 ( VAR_1 , VAR_2 , args ) ; VAR_7 . METHOD_1 ( VAR_1 , VAR_2 , args ) ; if ( VAR_1 . METHOD_2 ( TYPE_5 . TYPE_4 ) ) { METHOD_3 ( ) ; } if ( VAR_1 . METHOD_2 ( TYPE_3 . VAR_6 ) ) { METHOD_4 ( ) ; } }
code valid - protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 getId ( ) = = null ; }
<START> protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { <END> return true ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 . getId ( ) == null ; }
I d previous patch
protected boolean METHOD_1 ( ) { TYPE_1 VAR_1 = getParameters ( ) . METHOD_2 ( ) ; <START> return METHOD_3 ( METHOD_4 ( ) . METHOD_5 ( VAR_1 . METHOD_6 ( ) , <END> VAR_1 . METHOD_7 ( ) ) ) ; }
protected boolean METHOD_1 ( ) { TYPE_1 VAR_1 = getParameters ( ) . METHOD_2 ( ) ; return METHOD_3 ( METHOD_4 ( ) . METHOD_5 ( VAR_1 ) ) ; }
METHOD_3 ( ) METHOD_4 ( ! METHOD_2 ( ) ) ;
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) ) { METHOD_3 ( ) . METHOD_4 ( false ) ; } else { <START> METHOD_3 ( ) . METHOD_4 ( true ) ; <END> } }
protected void METHOD_1 ( ) { METHOD_3 ( ) . METHOD_4 ( ! METHOD_2 ( ) ) ; }
METHOD_2 interrested host VAR_5 method static — s easy ugly CDI move method class please notice class requires VAR_5 s usage fake change simplify method heal TYPE_3 simplify class constructor descendants
public List < TYPE_1 > METHOD_1 ( Guid VAR_1 ) { if ( ! VAR_2 . containsKey ( VAR_1 ) ) { TYPE_2 host = new TYPE_2 ( ) ; host . VAR_3 ( VAR_1 ) ; TYPE_3 VAR_4 = new TYPE_3 ( host , VAR_5 ) ; <START> VAR_2 . put ( VAR_1 , VAR_4 . METHOD_2 ( VAR_6 . METHOD_3 ( VAR_1 ) ) ) ; <END> } return VAR_2 . get ( VAR_1 ) ; }
public List < TYPE_1 > METHOD_1 ( Guid VAR_1 ) { if ( ! VAR_2 . containsKey ( VAR_1 ) ) { TYPE_2 host = new TYPE_2 ( ) ; host . VAR_3 ( VAR_1 ) ; TYPE_3 VAR_4 = new TYPE_3 ( host , null ) ; VAR_2 . put ( VAR_1 , VAR_4 . METHOD_2 ( VAR_6 . METHOD_3 ( VAR_1 ) ) ) ; } return VAR_2 . get ( VAR_1 ) ; }
need check METHOD_2 ( ) METHOD_3 ( )
protected void METHOD_1 ( ) { <START> if ( ! METHOD_2 ( ) . METHOD_3 ( ) && METHOD_2 ( ) . METHOD_4 ( ) == null ) { <END> TYPE_1 . METHOD_5 ( METHOD_2 ( ) . METHOD_6 ( ) , false ) ; } }
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) != null && METHOD_2 ( ) . METHOD_4 ( ) == null ) { TYPE_1 . METHOD_5 ( METHOD_2 ( ) . METHOD_6 ( ) , false ) ; } }
please inline need VAR_6 variable
protected Integer METHOD_1 ( TYPE_1 VAR_1 , String string , Integer VAR_2 ) { TYPE_1 VAR_3 = METHOD_2 ( VAR_1 , string , VAR_4 ) ; if ( VAR_3 != null && VAR_3 . VAR_5 != null ) { Integer VAR_6 = Integer . parseInt ( VAR_3 . VAR_5 ) ; <START> return VAR_6 ; <END> } return VAR_2 ; }
protected Integer METHOD_1 ( TYPE_1 VAR_1 , String string , Integer VAR_2 ) { TYPE_1 VAR_3 = METHOD_2 ( VAR_1 , string , VAR_4 ) ; if ( VAR_3 != null && VAR_3 . VAR_5 != null ) { return Integer . parseInt ( VAR_3 . VAR_5 ) ; } return VAR_2 ; }
simply call other constructor : ( Integer VAR_2 Integer VAR_3 ) ;
public TYPE_1 ( ) { <START> super ( Integer . VAR_2 , Integer . VAR_3 , Integer . VAR_4 ) ; <END> }
public TYPE_1 ( ) { this ( Integer . VAR_2 , Integer . VAR_3 ) ; }
line redundant call METHOD_13
protected void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( new TYPE_2 < TYPE_3 > ( ) { @Override public TYPE_3 METHOD_3 ( ) { METHOD_4 ( ) . METHOD_5 ( METHOD_6 ( ) ) ; METHOD_7 ( ) ; METHOD_8 ( ) ; METHOD_4 ( ) . METHOD_9 ( ) ; return null ; } } ) ; METHOD_10 ( false ) ; log ( ) ; METHOD_11 ( ) ; if ( VAR_1 ) { <START> getParameters ( ) . METHOD_12 ( true ) ; <END> METHOD_13 ( ) ; } else { METHOD_14 ( true ) ; } }
protected void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( new TYPE_2 < TYPE_3 > ( ) { @Override public TYPE_3 METHOD_3 ( ) { METHOD_4 ( ) . METHOD_5 ( METHOD_6 ( ) ) ; METHOD_7 ( ) ; METHOD_8 ( ) ; METHOD_4 ( ) . METHOD_9 ( ) ; return null ; } } ) ; METHOD_10 ( false ) ; log ( ) ; METHOD_11 ( ) ; if ( VAR_1 ) { METHOD_13 ( ) ; } else { METHOD_14 ( true ) ; } }
consider syntax : return METHOD_2 ( ) = = null ? null : METHOD_2 ( ) METHOD_1 ( )
<START> private TYPE_1 METHOD_1 ( ) { TYPE_1 status = null ; if ( METHOD_2 ( ) != null ) { status = METHOD_2 ( ) . METHOD_1 ( ) ; } return status ; } <END>
private TYPE_1 METHOD_1 ( ) { return METHOD_2 ( ) == null ? null : METHOD_2 ( ) . METHOD_1 ( ) ; }
initialize VAR_4 status i e : Object VAR_4 = METHOD_3 ( ) ; check : ( VAR_4 = = TYPE_3 && VAR_3 ! = null ) { VAR_4 = VAR_3 ; } save else part BTW call METHOD_4 ( ) expensive want save validating METHOD_3 ( ) TYPE_3 : Object VAR_4 = METHOD_3 ( ) ; ( VAR_4 = = TYPE_3 ) { _CODE_ VAR_3 = _CODE_ ( ) ; ( VAR_3 ! = null ) { VAR_4 = VAR_3 ; } } _CODE_
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_4 . VAR_2 ) ; TYPE_1 status = METHOD_3 ( ) ; TYPE_2 VAR_3 = METHOD_4 ( ) ; <START> Object VAR_4 ; if ( status == TYPE_1 . TYPE_3 && VAR_3 != null ) { VAR_4 = VAR_3 ; } else { VAR_4 = status ; } <END> METHOD_5 ( STRING_1 , VAR_4 ) ; }
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_4 . VAR_2 ) ; TYPE_1 status = METHOD_3 ( ) ; TYPE_2 VAR_3 = METHOD_4 ( ) ; Object VAR_4 = status ; if ( status == TYPE_1 . TYPE_3 && VAR_3 != null ) { VAR_4 = VAR_3 ; } METHOD_5 ( STRING_1 , VAR_4 ) ; }
METHOD_2 introduced java 8 - class compiled gwt supports 1 7 implement behavior
public static TYPE_1 METHOD_1 ( int value ) { <START> return VAR_1 . METHOD_2 ( value , VAR_2 ) ; <END> }
public static TYPE_1 METHOD_1 ( int value ) { return VAR_1 . containsKey ( value ) ? VAR_1 . get ( value ) : VAR_2 ; }
METHOD_3 invokes a chain queries final initiates class models add query chain ( ) query parallel chain chance chain finished query NPE models initialization assumes _CODE_ null
private void METHOD_1 ( boolean VAR_1 ) { if ( VAR_1 ) { METHOD_2 ( ) ; METHOD_3 ( ) ; <START> METHOD_4 ( ) ; <END> } else { METHOD_5 ( ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; } }
private void METHOD_1 ( boolean VAR_1 ) { if ( VAR_1 ) { METHOD_2 ( ) ; METHOD_3 ( ) ; } else { METHOD_5 ( ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; } }
please inline ( I r e METHOD_2 ( ) )
protected boolean METHOD_1 ( ) { final TYPE_1 vm = METHOD_2 ( ) ; <START> if ( vm == null ) { <END> return METHOD_3 ( TYPE_4 . VAR_2 ) ; } if ( ! METHOD_4 ( ) ) { return false ; } if ( METHOD_2 ( ) . getStatus ( ) != TYPE_5 . TYPE_2 && METHOD_2 ( ) . getStatus ( ) != TYPE_5 . TYPE_3 ) { return METHOD_5 ( ) ; } return true ; }
protected boolean METHOD_1 ( ) { if ( METHOD_2 ( ) == null ) { return METHOD_3 ( TYPE_4 . VAR_2 ) ; } if ( ! METHOD_4 ( ) ) { return false ; } if ( METHOD_2 ( ) . getStatus ( ) != TYPE_5 . TYPE_2 && METHOD_2 ( ) . getStatus ( ) != TYPE_5 . TYPE_3 ) { return METHOD_5 ( ) ; } return true ; }
reorder methods ? 1 harder review patch2 methods interesting _CODE_ interesting methods class _CODE_
protected boolean METHOD_1 ( Guid VAR_1 , TYPE_1 VAR_2 ) { return VAR_3 . METHOD_2 ( TYPE_4 . TYPE_5 , new TYPE_2 ( VAR_1 ) , TYPE_3 . METHOD_3 ( VAR_2 ) ) . METHOD_4 ( ) ; <START> } <END>
private boolean METHOD_1 ( Guid VAR_1 , TYPE_1 VAR_2 ) { return VAR_3 . METHOD_2 ( TYPE_4 . TYPE_5 , new TYPE_2 ( VAR_1 ) , TYPE_3 . METHOD_3 ( VAR_2 ) ) . METHOD_4 ( ) ; }
sed s / = = VAR_1 ? true : false / = = VAR_1 / ( redundant inline )
public boolean METHOD_1 ( ) { <START> return value == VAR_1 . value ? true : false ; <END> }
public boolean METHOD_1 ( ) { return value == VAR_1 . value ; }
public
<START> public static TYPE_1 METHOD_1 ( String VAR_1 ) { <END> if ( VAR_1 == null ) { return null ; } String VAR_2 = METHOD_2 ( VAR_1 ) ; if ( VAR_2 == null ) { return null ; } for ( TYPE_1 VAR_3 : TYPE_1 . values ( ) ) { if ( VAR_3 . getValue ( ) . equals ( VAR_2 ) ) { return VAR_3 ; } } return null ; }
static TYPE_1 METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { return null ; } String VAR_2 = METHOD_2 ( VAR_1 ) ; if ( VAR_2 == null ) { return null ; } for ( TYPE_1 VAR_3 : TYPE_1 . values ( ) ) { if ( VAR_3 . getValue ( ) . equals ( VAR_2 ) ) { return VAR_3 ; } } return null ; }
please check usages method class please private
<START> public static TYPE_1 METHOD_1 ( String VAR_1 ) { <END> if ( VAR_1 == null ) { return VAR_2 ; } String VAR_3 = METHOD_2 ( VAR_1 ) ; if ( VAR_3 == null ) { return VAR_2 ; } for ( TYPE_1 VAR_4 : TYPE_1 . values ( ) ) { if ( VAR_4 . getValue ( ) . equals ( VAR_3 ) ) { return VAR_4 ; } } return VAR_2 ; }
public static TYPE_1 METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { return null ; } String VAR_3 = METHOD_2 ( VAR_1 ) ; if ( VAR_3 == null ) { return null ; } for ( TYPE_1 VAR_4 : TYPE_1 . values ( ) ) { if ( VAR_4 . getValue ( ) . equals ( VAR_3 ) ) { return VAR_4 ; } } return null ; }
please fix
public TYPE_1 ( String VAR_2 , String VAR_3 , String VAR_4 , String VAR_5 , String VAR_6 , String VAR_7 , List < Map > VAR_8 , boolean VAR_9 ) { METHOD_1 ( VAR_2 ) ; METHOD_2 ( VAR_3 ) ; METHOD_3 ( VAR_4 ) ; METHOD_4 ( VAR_5 ) ; METHOD_5 ( VAR_6 ) ; <START> METHOD_6 ( STRING_1 ) ; <END> METHOD_7 ( VAR_8 ) ; METHOD_8 ( VAR_9 ) ; }
public TYPE_1 ( String VAR_2 , String VAR_3 , String VAR_4 , String VAR_5 , String VAR_6 , String VAR_7 , List < Map > VAR_8 , boolean VAR_9 ) { METHOD_1 ( VAR_2 ) ; METHOD_2 ( VAR_3 ) ; METHOD_3 ( VAR_4 ) ; METHOD_4 ( VAR_5 ) ; METHOD_5 ( VAR_6 ) ; METHOD_6 ( VAR_7 ) ; METHOD_7 ( VAR_8 ) ; METHOD_8 ( VAR_9 ) ; }
removal static patch fail compilation
<START> private TYPE_1 METHOD_1 ( ) { <END> return TYPE_2 . getInstance ( ) . METHOD_1 ( ) ; }
private static TYPE_1 METHOD_1 ( ) { return TYPE_2 . getInstance ( ) . METHOD_1 ( ) ; }
done mapper don t need addition don t need support policy attribute adding scheduling policies changing policy a cluster
public Response add ( TYPE_1 VAR_1 ) { if ( ! VAR_1 . METHOD_1 ( ) ) { VAR_1 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; <START> } <END> METHOD_4 ( VAR_1 , STRING_1 ) ; return METHOD_5 ( TYPE_3 . TYPE_4 , new TYPE_2 ( null , map ( VAR_1 ) ) , VAR_4 ) ; }
public Response add ( TYPE_1 VAR_1 ) { METHOD_4 ( VAR_1 , STRING_1 ) ; return METHOD_5 ( TYPE_3 . TYPE_4 , new TYPE_2 ( null , map ( VAR_1 ) ) , VAR_4 ) ; }
need method unit tests default ( package ) visibility instead public : boolean METHOD_1 ( ) { }
<START> public boolean METHOD_1 ( ) { <END> return VAR_1 ; }
boolean METHOD_1 ( ) { return VAR_1 ; }
I find more readable : ( VAR_1 ! = null ) { return VAR_1 ; } ( VAR_2 ! = null ) { return VAR_2 ; } return VAR_3 ; please consider
public static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 , TYPE_1 VAR_3 ) { if ( VAR_1 != null ) { return VAR_1 ; } else if ( VAR_2 != null ) { return VAR_2 ; } else { return VAR_3 ; <START> } <END> }
public static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 , TYPE_1 VAR_3 ) { if ( VAR_1 != null ) { return VAR_1 ; } if ( VAR_2 != null ) { return VAR_2 ; } return VAR_3 ; }
METHOD_1 ( ) _CODE_ ( please notice a null check - getParameters ( ) METHOD_2 ( ) = = null please add )
private Guid METHOD_1 ( ) { <START> return getParameters ( ) . METHOD_2 ( ) . METHOD_3 ( ) ; <END> }
private Guid METHOD_1 ( ) { return getParameters ( ) . METHOD_2 ( ) == null ? null : getParameters ( ) . METHOD_2 ( ) . METHOD_3 ( ) ; }
mandatory ? names cached calling _CODE_ invoked _CODE_ s execute flow ( execute - > _CODE_ )
protected void METHOD_1 ( ) { <START> METHOD_2 ( ) ; <END> if ( METHOD_3 ( ) ) { getParameters ( ) . METHOD_4 ( true ) ; METHOD_5 ( getParameters ( ) . METHOD_6 ( ) , true ) ; } METHOD_7 ( ) ; METHOD_8 ( true ) ; }
protected void METHOD_1 ( ) { if ( METHOD_3 ( ) ) { getParameters ( ) . METHOD_4 ( true ) ; METHOD_5 ( getParameters ( ) . METHOD_6 ( ) , true ) ; } METHOD_7 ( ) ; METHOD_8 ( true ) ; }
I guess forgot VAR_1 prefix
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return super . equals ( obj ) && TYPE_2 . equals ( VAR_2 , <START> VAR_2 ) <END> && TYPE_2 . equals ( VAR_3 , VAR_1 . VAR_3 ) ; }
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return super . equals ( obj ) && TYPE_2 . equals ( VAR_2 , VAR_1 . VAR_2 ) && TYPE_2 . equals ( VAR_3 , VAR_1 . VAR_3 ) ; }
missing { }
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( ! ( obj instanceof TYPE_1 ) ) <START> return false ; <END> TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return TYPE_2 . equals ( VAR_2 , VAR_1 . VAR_2 ) && TYPE_2 . equals ( VAR_3 , VAR_1 . VAR_3 ) && TYPE_2 . equals ( VAR_4 , VAR_1 . VAR_4 ) && TYPE_2 . equals ( VAR_5 , VAR_1 . VAR_5 ) ; }
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return TYPE_2 . equals ( VAR_2 , VAR_1 . VAR_2 ) && TYPE_2 . equals ( VAR_3 , VAR_1 . VAR_3 ) && TYPE_2 . equals ( VAR_4 , VAR_1 . VAR_4 ) && TYPE_2 . equals ( VAR_5 , VAR_1 . VAR_5 ) ; }
good - s I add a field _CODE_ I ll need classes inherit add new field METHOD_1
public int METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( VAR_1 , METHOD_3 ( ) , VAR_2 ) ; <START> } <END>
public int METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( super . METHOD_1 ( ) , VAR_1 , VAR_2 ) ; }
please ( expected = TYPE_2 class ) instead { } catch { }
public void METHOD_1 ( ) { try { String key = STRING_1 ; TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( key ) ; METHOD_3 ( STRING_2 ) ; <START> } catch ( TYPE_2 e ) { <END> assertNotNull ( e ) ; } }
public void METHOD_1 ( ) { String key = STRING_1 ; TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( key ) ; METHOD_3 ( STRING_2 ) ; }
please rename vm
private List < TYPE_1 > METHOD_1 ( final TYPE_2 VAR_1 , final Guid VAR_2 ) { List < TYPE_1 > VAR_3 = VAR_1 . METHOD_2 ( VAR_2 ) ; return VAR_3 . stream ( ) . filter ( <START> v - > <END> v . VAR_4 ( ) == TYPE_3 . VAR_6 && ! v . VAR_7 ( ) . contains ( VAR_2 ) ) . collect ( Collectors . VAR_8 ( ) ) ; }
private List < TYPE_1 > METHOD_1 ( final TYPE_2 VAR_1 , final Guid VAR_2 ) { List < TYPE_1 > VAR_3 = VAR_1 . METHOD_2 ( VAR_2 ) ; return VAR_3 . stream ( ) . filter ( vm - > vm . VAR_4 ( ) == TYPE_3 . VAR_6 && ! vm . VAR_7 ( ) . contains ( VAR_2 ) ) . collect ( Collectors . VAR_8 ( ) ) ; }
consider ternary instead
protected void METHOD_1 ( final TYPE_1 VAR_1 ) { final TYPE_2 VAR_2 ; <START> if ( getParameters ( ) . METHOD_2 ( ) ) { <END> VAR_2 = METHOD_3 ( VAR_1 ) ; } else { VAR_2 = null ; } TYPE_3 . METHOD_4 ( TYPE_5 . TYPE_6 , new TYPE_4 < Object > ( ) { @Override public Object METHOD_5 ( ) { METHOD_6 ( VAR_1 , VAR_2 ) ; return null ; } } ) ; }
protected void METHOD_1 ( final TYPE_1 VAR_1 ) { final TYPE_2 VAR_2 = getParameters ( ) . METHOD_2 ( ) ? METHOD_3 ( VAR_1 ) : null ; TYPE_3 . METHOD_4 ( TYPE_5 . TYPE_6 , new TYPE_4 < Object > ( ) { @Override public Object METHOD_5 ( ) { METHOD_6 ( VAR_1 , VAR_2 ) ; return null ; } } ) ; }
VAR_5 completely redundant
public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; VAR_1 = VAR_2 . METHOD_2 ( ) ; TYPE_1 VAR_3 = VAR_2 . METHOD_3 ( ) ; TYPE_2 VAR_4 = VAR_3 . get ( STRING_1 ) ; TYPE_2 <START> VAR_5 = <END> new TYPE_2 ( ) ; VAR_5 . METHOD_4 ( STRING_2 ) ; VAR_5 . METHOD_5 ( VAR_6 ) ; VAR_7 = VAR_1 . get ( new TYPE_3 ( STRING_3 , VAR_4 . METHOD_6 ( ) ) ) ; VAR_8 = new TYPE_4 ( VAR_9 , VAR_4 . METHOD_6 ( ) ) ; }
public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; VAR_1 = VAR_2 . METHOD_2 ( ) ; TYPE_1 VAR_3 = VAR_2 . METHOD_3 ( ) ; TYPE_2 VAR_4 = VAR_3 . get ( STRING_1 ) ; VAR_7 = VAR_1 . get ( new TYPE_3 ( STRING_3 , VAR_4 . METHOD_6 ( ) ) ) ; VAR_8 = new TYPE_4 ( VAR_9 , VAR_4 . METHOD_6 ( ) ) ; }
error prone : schedule start process line executed ll face NPE line 82 please METHOD_1 VAR_7 c tor declared ( line 52 )
private void METHOD_1 ( ) { log . info ( STRING_1 , getClass ( ) . METHOD_2 ( ) ) ; Integer VAR_1 = TYPE_2 < Integer > getValue ( TYPE_3 . TYPE_4 ) ; if ( VAR_1 > 0 ) { VAR_5 . METHOD_3 ( this , STRING_2 , new Class [ ] { } , new Object [ ] { } , VAR_1 , VAR_1 , TimeUnit . VAR_6 ) ; log . info ( STRING_3 , getClass ( ) . METHOD_2 ( ) ) ; } <START> VAR_7 = new TYPE_1 ( ) ; <END> }
private void METHOD_1 ( ) { log . info ( STRING_1 , getClass ( ) . METHOD_2 ( ) ) ; Integer VAR_1 = TYPE_2 < Integer > getValue ( TYPE_3 . TYPE_4 ) ; if ( VAR_1 > 0 ) { VAR_5 . METHOD_3 ( this , STRING_2 , new Class [ ] { } , new Object [ ] { } , VAR_1 , VAR_1 , TimeUnit . VAR_6 ) ; log . info ( STRING_3 , getClass ( ) . METHOD_2 ( ) ) ; } }
shouldn t - ( index + 1 ) % VAR_4
private long METHOD_1 ( ) { int index = VAR_1 . METHOD_2 ( VAR_2 ) ; boolean VAR_3 = index == VAR_4 ; if ( VAR_3 ) { index = VAR_1 . METHOD_2 ( 0 ) ; } <START> VAR_2 = index + 1 ; <END> return VAR_5 + index ; }
private long METHOD_1 ( ) { int index = VAR_1 . METHOD_2 ( VAR_2 ) ; boolean VAR_3 = index == VAR_4 ; if ( VAR_3 ) { index = VAR_1 . METHOD_2 ( 0 ) ; } VAR_2 = ( index + 1 ) % VAR_4 ; return VAR_5 + index ; }
TYPE_1 class implements correctly equals method : return TYPE_2 ( type getName ( ) ) ;
<START> public boolean METHOD_1 ( Type type ) { <END> for ( TYPE_1 name : TYPE_2 ) { if ( name . toString ( ) . equals ( type . getName ( ) . toString ( ) ) ) { return true ; } } return false ; }
public boolean METHOD_1 ( Type type ) { return TYPE_2 . contains ( type . getName ( ) ) ; }
need temp variable ? TYPE_3 execute ( ( ) - > { METHOD_2 ( ) ; METHOD_3 ( VAR_2 ) ; } ) ;
private void METHOD_1 ( List < TYPE_1 > VAR_1 ) { final List < TYPE_1 > VAR_2 = VAR_1 . stream ( ) . filter ( host - > host . VAR_3 ( ) && host . getStatus ( ) == TYPE_4 . TYPE_5 ) . collect ( Collectors . VAR_6 ( ) ) ; if ( VAR_2 . size ( ) > 0 ) { TYPE_2 task = ( ) - > { METHOD_2 ( ) ; METHOD_3 ( VAR_2 ) ; } ; <START> TYPE_3 . execute ( task ) ; <END> } }
private void METHOD_1 ( List < TYPE_1 > VAR_1 ) { final List < TYPE_1 > VAR_2 = VAR_1 . stream ( ) . filter ( host - > host . VAR_3 ( ) ) . filter ( host - > host . getStatus ( ) == TYPE_4 . TYPE_5 ) . collect ( Collectors . VAR_6 ( ) ) ; if ( VAR_2 . size ( ) > 0 ) { TYPE_3 . execute ( ( ) - > { METHOD_2 ( ) ; METHOD_3 ( VAR_2 ) ; } ) ; } }
shouldn t push previous ? I don t a point setting text empty string visible
public void METHOD_1 ( String message ) { super . METHOD_1 ( message ) ; if ( message != null && message . length ( ) > 0 ) { table . VAR_1 ( false ) ; } if ( message != null ) { <START> VAR_2 . setText ( message ) ; <END> } }
public void METHOD_1 ( String message ) { super . METHOD_1 ( message ) ; if ( message != null && message . length ( ) > 0 ) { table . VAR_1 ( false ) ; VAR_2 . setText ( message ) ; } }
TYPE_1 toString ( METHOD_1 ( ) ) TYPE_1 toString ( METHOD_2 ( ) ) behavior
public String toString ( ) { <START> return TYPE_1 . toString ( METHOD_1 ( ) , null ) + CHAR_1 + TYPE_1 . toString ( METHOD_2 ( ) , null ) ; <END> }
public String toString ( ) { return TYPE_1 . toString ( METHOD_1 ( ) ) + CHAR_1 + TYPE_1 . toString ( METHOD_2 ( ) ) ; }
I drop false default
public TYPE_2 ( ) { this . VAR_2 = "" ; this . VAR_3 = Guid . TYPE_1 ; <START> this . VAR_5 = false ; <END> }
public TYPE_2 ( ) { this . VAR_2 = "" ; this . VAR_3 = Guid . TYPE_1 ; }
VAR_1 isEmpty ( ) loop body run check redundant
private void update ( List < TYPE_1 > VAR_1 ) { <START> if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { <END> for ( TYPE_1 VAR_2 : VAR_1 ) { TYPE_2 VAR_3 = VAR_2 . METHOD_1 ( ) ; VAR_4 . update ( VAR_3 ) ; } } }
private void update ( List < TYPE_1 > VAR_1 ) { if ( VAR_1 == null ) { return ; } for ( TYPE_1 VAR_2 : VAR_1 ) { VAR_4 . update ( VAR_2 . METHOD_1 ( ) ) ; } }
please configure IDE brackets equals methods statements convention present
public boolean equals ( Object o ) { <START> if ( this == o ) return true ; if ( o == null || getClass ( ) != o . getClass ( ) ) return false ; <END> TYPE_1 that = ( TYPE_1 ) o ; return TYPE_2 . equals ( name , that . name ) && TYPE_2 . equals ( version , that . version ) && TYPE_2 . equals ( id , that . id ) ; }
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( o == null || getClass ( ) != o . getClass ( ) ) { return false ; } TYPE_1 that = ( TYPE_1 ) o ; return TYPE_2 . equals ( name , that . name ) && TYPE_2 . equals ( version , that . version ) && TYPE_2 . equals ( id , that . id ) ; }
package private
<START> TYPE_2 ( TYPE_1 parameters ) { <END> super ( parameters ) ; }
public TYPE_2 ( TYPE_1 parameters ) { super ( parameters ) ; }
i don t advantage initializing builder empty string affect default c tor instead
public String METHOD_1 ( ) { StringBuilder VAR_1 = new <START> StringBuilder ( "" ) ; <END> int VAR_2 = METHOD_2 ( ) . size ( ) ; for ( TYPE_2 . TYPE_3 VAR_3 : METHOD_2 ( ) ) { VAR_1 . append ( VAR_3 . METHOD_3 ( ) ) ; if ( VAR_2 != 1 ) { VAR_1 . append ( STRING_1 ) ; } VAR_2 -- ; } return VAR_1 . toString ( ) ; }
public String METHOD_1 ( ) { StringBuilder VAR_1 = new StringBuilder ( ) ; int VAR_2 = METHOD_2 ( ) . size ( ) ; for ( TYPE_2 . TYPE_3 VAR_3 : METHOD_2 ( ) ) { VAR_1 . append ( VAR_3 . METHOD_3 ( ) ) ; if ( VAR_2 != 1 ) { VAR_1 . append ( STRING_1 ) ; } VAR_2 -- ; } return VAR_1 . toString ( ) ; }
I d inline a single statement predicate
private TYPE_1 < TYPE_2 < ? > > METHOD_1 ( TYPE_3 VAR_1 ) { return VAR_2 - > { <START> int VAR_3 = VAR_2 . METHOD_2 ( ) ; <END> return TYPE_4 . METHOD_3 ( VAR_3 ) || ( ! VAR_1 . equals ( VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) ) && ! TYPE_4 . METHOD_6 ( VAR_3 ) ) ; } ; }
private TYPE_1 < TYPE_2 < ? > > METHOD_1 ( TYPE_3 VAR_1 ) { return VAR_2 - > TYPE_4 . METHOD_3 ( VAR_2 . METHOD_2 ( ) ) || ( ! VAR_1 . equals ( VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) ) && ! TYPE_4 . METHOD_6 ( VAR_2 . METHOD_2 ( ) ) ) ; }
VAR_2 null - cluster ( happen ) 3 0 returned _CODE_ 124 - 126 redundant - removed
private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 VAR_2 = TYPE_4 . METHOD_2 ( VAR_1 ) ; if ( VAR_2 == null ) { VAR_2 = TYPE_3 . METHOD_3 ( ) ; <START> } <END> if ( VAR_2 . METHOD_4 ( new TYPE_3 ( 3 , INT_1 ) ) ) { return new TYPE_5 ( ) ; } else { return new TYPE_6 ( ) ; } }
private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( TYPE_4 . METHOD_2 ( VAR_1 ) . METHOD_4 ( new TYPE_3 ( 3 , INT_1 ) ) ) { return new TYPE_5 ( ) ; } else { return new TYPE_6 ( ) ; } }
please add public prefix
<START> boolean METHOD_1 ( ) <END> { METHOD_2 ( ) . METHOD_3 ( new TYPE_1 [ ] { new TYPE_2 ( TYPE_4 . VAR_2 ) , new TYPE_3 ( ) } ) ; return METHOD_2 ( ) . METHOD_4 ( ) ; }
public boolean METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( new TYPE_1 [ ] { new TYPE_2 ( TYPE_4 . VAR_2 ) , new TYPE_3 ( ) } ) ; return METHOD_2 ( ) . METHOD_4 ( ) ; }
members static methods - data doesn t change test executed read
public void METHOD_1 ( ) { VAR_1 = METHOD_2 ( TYPE_1 . class , TYPE_2 . class ) ; <START> } <END>
public static void METHOD_1 ( ) { VAR_1 = METHOD_2 ( TYPE_1 . class , TYPE_2 . class ) ; }
related
<START> protected void <END> METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { VAR_3 . log ( VAR_1 , VAR_2 ) ; }
void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { VAR_3 . log ( VAR_1 , VAR_2 ) ; }
please replace java8 stream filter forEach ( )
private void METHOD_1 ( ) { <START> for ( TYPE_1 VAR_1 : getParameters ( ) . METHOD_2 ( ) ) { <END> if ( VAR_1 . METHOD_3 ( ) == null ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_4 ( ) ; VAR_1 . METHOD_5 ( VAR_2 ) ; } } }
private void METHOD_1 ( ) { getParameters ( ) . METHOD_2 ( ) . stream ( ) . forEach ( VAR_1 - > { if ( VAR_1 . METHOD_3 ( ) == null ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_4 ( ) ; VAR_1 . METHOD_5 ( VAR_2 ) ; } } ) ; }
s need variable broad scope want define define variable
private TYPE_1 METHOD_1 ( ) { final TYPE_2 VAR_1 = METHOD_2 ( ) ; <START> TYPE_1 VAR_2 = null ; <END> if ( TYPE_3 . METHOD_3 ( VAR_1 ) && TYPE_4 < Boolean > getValue ( TYPE_5 . TYPE_6 ) ) { VAR_2 = VAR_6 . METHOD_4 ( TYPE_1 . VAR_7 ) ; } return VAR_2 ; }
private TYPE_1 METHOD_1 ( ) { if ( TYPE_4 < Boolean > getValue ( TYPE_5 . TYPE_6 ) ) { return VAR_6 . METHOD_4 ( TYPE_1 . VAR_7 ) ; } return null ; }
please _CODE_
public TYPE_1 METHOD_1 ( boolean VAR_1 ) { return TYPE_1 . METHOD_2 ( TYPE_3 . VAR_3 , TYPE_2 . METHOD_3 ( VAR_4 , VAR_5 . getName ( ) ) , TYPE_2 . METHOD_3 ( VAR_6 , VAR_5 . METHOD_4 ( ) ) ) <START> . when ( VAR_1 & VAR_5 . METHOD_4 ( ) != null ) ; <END> }
public TYPE_1 METHOD_1 ( boolean VAR_1 ) { return TYPE_1 . METHOD_2 ( TYPE_3 . VAR_3 , TYPE_2 . METHOD_3 ( VAR_4 , VAR_5 . getName ( ) ) , TYPE_2 . METHOD_3 ( VAR_6 , VAR_5 . METHOD_4 ( ) ) ) . when ( VAR_1 && VAR_5 . METHOD_4 ( ) != null ) ; }
TYPE_1 s custom compatibility version set cluster s compatibility version means don t need display warning changed TYPE_1
public boolean METHOD_1 ( TYPE_1 vm ) { if ( vm . getStatus ( ) == TYPE_5 . TYPE_4 || vm . getStatus ( ) == TYPE_5 . TYPE_6 || vm . getStatus ( ) == TYPE_5 . TYPE_3 ) { TYPE_2 VAR_5 = vm . VAR_6 ( ) ; return VAR_5 == null ? false <START> : VAR_5 . METHOD_2 ( VAR_7 ) ; <END> } return true ; }
public boolean METHOD_1 ( TYPE_1 vm ) { if ( vm . getStatus ( ) == TYPE_5 . TYPE_4 || vm . getStatus ( ) == TYPE_5 . TYPE_6 || vm . getStatus ( ) == TYPE_5 . TYPE_3 ) { return vm . VAR_6 ( ) == null ; } return true ; }
brackets left hand - > operator redundant ( frankly a bit confusing ) please remove
protected List < Guid > METHOD_1 ( Guid VAR_1 ) { return getParameters ( ) . METHOD_2 ( ) . stream ( ) <START> . filter ( ( VAR_2 ) - > METHOD_3 ( VAR_1 , VAR_2 ) ) <END> . collect ( METHOD_4 ( ) ) ; }
protected List < Guid > METHOD_1 ( Guid VAR_1 ) { return getParameters ( ) . METHOD_2 ( ) . stream ( ) . filter ( VAR_2 - > METHOD_3 ( VAR_1 , VAR_2 ) ) . collect ( METHOD_4 ( ) ) ; }
method return interfaces empty bond remove negation
public static Collection < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 ) { return METHOD_2 ( VAR_1 , new TYPE_2 < TYPE_1 > ( ) { @Override public boolean METHOD_3 ( TYPE_1 i ) { return <START> ! TYPE_3 . METHOD_4 ( i . VAR_2 ( ) ) ; <END> } } ) ; }
public static Collection < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 ) { return METHOD_2 ( VAR_1 , new TYPE_2 < TYPE_1 > ( ) { @Override public boolean METHOD_3 ( TYPE_1 i ) { return TYPE_3 . METHOD_4 ( i . VAR_2 ( ) ) ; } } ) ; }
pool open entire idea
protected TYPE_1 METHOD_1 ( String VAR_1 , Object [ ] VAR_2 ) { TYPE_2 connection = null ; try { connection = METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; return connection . VAR_3 ( VAR_1 , VAR_2 ) ; } catch ( TYPE_3 e ) { throw new RuntimeException ( e ) ; } finally { if ( connection != null ) { <START> try { connection . close ( ) ; } catch ( TYPE_3 e ) { } <END> } } }
protected TYPE_1 METHOD_1 ( String VAR_1 , Object [ ] VAR_2 ) { try ( TYPE_2 connection = METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ) { return connection . VAR_3 ( VAR_1 , VAR_2 ) ; } catch ( TYPE_3 ex ) { throw new RuntimeException ( ex ) ; } }
refer VAR_2 please consistent
public void METHOD_1 ( String VAR_1 , TYPE_1 host ) { <START> VAR_2 . put ( VAR_1 , host ) ; <END> }
public void METHOD_1 ( String VAR_1 , TYPE_1 host ) { this . VAR_2 . put ( VAR_1 , host ) ; }
move METHOD_2 method cache method called chance falling null cache
public static void METHOD_1 ( TYPE_1 VAR_1 , Guid VAR_2 , TYPE_2 cache ) { <START> if ( cache == null ) { cache = new TYPE_2 ( ) ; } <END> Map < String , Long > VAR_3 = METHOD_2 ( VAR_2 , cache ) ; if ( VAR_3 == null ) { return ; } if ( VAR_1 . METHOD_3 ( ) == null ) { VAR_1 . METHOD_4 ( new HashMap < > ( ) ) ; } VAR_1 . METHOD_3 ( ) . put ( TYPE_4 . TYPE_3 , VAR_3 ) ; }
public static void METHOD_1 ( TYPE_1 VAR_1 , Guid VAR_2 , TYPE_2 cache ) { Map < String , Long > VAR_3 = METHOD_2 ( VAR_2 , cache ) ; if ( VAR_3 == null ) { return ; } if ( VAR_1 . METHOD_3 ( ) == null ) { VAR_1 . METHOD_4 ( new HashMap < > ( ) ) ; } VAR_1 . METHOD_3 ( ) . put ( TYPE_4 . TYPE_3 , VAR_3 ) ; }
I missed : - (
public static void METHOD_1 ( TYPE_1 VAR_1 ) { <START> HashMap < String , TYPE_1 > VAR_2 = new HashMap < > ( ) ; <END> METHOD_1 ( VAR_1 , TYPE_2 . VAR_4 , VAR_2 ) ; VAR_1 . put ( TYPE_2 . VAR_4 , new ArrayList < > ( VAR_2 . values ( ) ) ) ; }
public static void METHOD_1 ( TYPE_1 VAR_1 ) { Map < String , TYPE_1 > VAR_2 = new HashMap < > ( ) ; METHOD_1 ( VAR_1 , TYPE_2 . VAR_4 , VAR_2 ) ; VAR_1 . put ( TYPE_2 . VAR_4 , new ArrayList < > ( VAR_2 . values ( ) ) ) ; }
a transaction started calls METHOD_3 ( ) sense move transaction method ( unneeded avoid creating transaction ) callers doesn t repeat remember instead adding call
public void METHOD_1 ( ) { <START> TYPE_1 . METHOD_2 ( ( ) - > { <END> METHOD_3 ( true ) ; return null ; } ) ; log . info ( STRING_1 , METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) , METHOD_4 ( ) . METHOD_7 ( ) , METHOD_8 ( ) != null ? METHOD_8 ( ) . METHOD_7 ( ) : STRING_2 ) ; }
METHOD_1 ( ) { METHOD_3 ( true ) ; log . info ( STRING_1 , METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) , METHOD_4 ( ) . METHOD_7 ( ) , METHOD_8 ( ) != null ? METHOD_8 ( ) . METHOD_7 ( ) : STRING_2 ) ; }
move line 439 - 441 line 435 - performance more clear case don t need cluster version
public boolean METHOD_1 ( TYPE_1 vm ) { if ( vm == null ) { return true ; } TYPE_2 VAR_1 = vm . VAR_2 ( ) ; TYPE_2 VAR_3 = vm . VAR_4 ( ) ; if ( vm . VAR_5 ( ) != null ) { return true ; <START> } <END> return VAR_3 != null && VAR_1 . METHOD_2 ( ) == VAR_3 . METHOD_2 ( ) && VAR_1 . METHOD_3 ( ) == VAR_3 . METHOD_3 ( ) ; }
public boolean METHOD_1 ( TYPE_1 vm ) { if ( vm == null || vm . VAR_5 ( ) != null ) { return true ; } TYPE_2 VAR_1 = vm . VAR_2 ( ) ; TYPE_2 VAR_3 = vm . VAR_4 ( ) ; return VAR_3 != null && VAR_1 . METHOD_2 ( ) == VAR_3 . METHOD_2 ( ) && VAR_1 . METHOD_3 ( ) == VAR_3 . METHOD_3 ( ) ; }
done
private TYPE_1 METHOD_1 ( Map < TYPE_1 , Set < Guid > > VAR_1 ) { if ( VAR_1 != null ) { for ( Map . Entry < TYPE_1 , Set < Guid > > entry : VAR_1 . entrySet ( ) ) { TYPE_1 VAR_2 = entry . getKey ( ) ; TYPE_2 VAR_3 = VAR_2 . METHOD_2 ( ) ; if ( TYPE_3 . equals ( VAR_3 . METHOD_3 ( ) , id ) ) { return VAR_2 ; } } <START> } METHOD_4 ( ) ; return null ; <END> }
private TYPE_1 METHOD_1 ( Map < TYPE_1 , Set < Guid > > VAR_1 ) { if ( VAR_1 != null ) { for ( Map . Entry < TYPE_1 , Set < Guid > > entry : VAR_1 . entrySet ( ) ) { TYPE_1 VAR_2 = entry . getKey ( ) ; TYPE_2 VAR_3 = VAR_2 . METHOD_2 ( ) ; if ( TYPE_3 . equals ( VAR_3 . METHOD_3 ( ) , id ) ) { return VAR_2 ; } } } return METHOD_4 ( ) ; }
don t fallback default locale initialized constructor don t translation client locale ? wouldn t forced nasty split / VAR_5 code
public String METHOD_1 ( final String VAR_1 , final TYPE_1 VAR_2 ) { String VAR_3 = "" ; TYPE_2 VAR_4 = METHOD_2 ( VAR_2 == null ? TYPE_1 . METHOD_3 ( ) : VAR_2 ) ; if ( VAR_4 != null && VAR_4 . containsKey ( VAR_1 ) ) { VAR_3 = VAR_4 . getString ( VAR_1 ) ; } else if ( ! StringUtils . isEmpty ( VAR_1 ) ) { <START> VAR_3 = StringUtils . VAR_5 ( VAR_1 . METHOD_4 ( ) . split ( STRING_1 , - 1 ) , STRING_2 ) ; <END> } return VAR_3 ; }
public String METHOD_1 ( final String VAR_1 , final TYPE_1 VAR_2 ) { String VAR_3 = VAR_1 ; TYPE_2 VAR_4 = METHOD_2 ( VAR_2 == null ? TYPE_1 . METHOD_3 ( ) : VAR_2 ) ; if ( VAR_4 != null && VAR_4 . containsKey ( VAR_1 ) ) { VAR_3 = VAR_4 . getString ( VAR_1 ) ; } return VAR_3 ; }
hmm idea : wouldn t faster load messages existing locales startup ( IMO don t messages / locales memory issue ) calling synchronized method translated message user request
<START> private synchronized TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <END> try { if ( ! VAR_2 . containsKey ( VAR_1 ) ) { VAR_2 . put ( VAR_1 , TYPE_1 . METHOD_2 ( VAR_3 , VAR_1 ) ) ; } } catch ( RuntimeException e ) { log . error ( STRING_1 , VAR_3 , e . getMessage ( ) ) ; log . debug ( STRING_2 , e ) ; } return VAR_2 . get ( VAR_1 ) ; }
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { try { if ( ! VAR_2 . containsKey ( VAR_1 ) ) { VAR_2 . put ( VAR_1 , TYPE_1 . METHOD_2 ( VAR_3 , VAR_1 ) ) ; } } catch ( RuntimeException e ) { log . error ( STRING_1 , VAR_3 , e . getMessage ( ) ) ; log . debug ( STRING_2 , e ) ; } return VAR_2 . get ( VAR_1 ) ; }
check null
private void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = METHOD_2 ( ) ; <END> TYPE_2 . getInstance ( ) . METHOD_3 ( TYPE_5 . TYPE_4 , new TYPE_3 ( VAR_1 . METHOD_4 ( ) , VAR_1 . getId ( ) ) ) ; }
private void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 != null ) { TYPE_2 . getInstance ( ) . METHOD_3 ( TYPE_5 . TYPE_4 , new TYPE_3 ( VAR_1 . METHOD_4 ( ) , VAR_1 . getId ( ) ) ) ; } }
reuse existing constructors ? public TYPE_2 ( TYPE_1 VAR_2 Guid VAR_3 ) { ( VAR_2 ) ; VAR_3 = VAR_3 ; }
public TYPE_2 ( TYPE_1 VAR_2 , Guid VAR_3 ) { <START> this . VAR_2 = VAR_2 ; <END> this . VAR_3 = VAR_3 ; }
public TYPE_2 ( TYPE_1 VAR_2 , Guid VAR_3 ) { this ( VAR_2 ) ; this . VAR_3 = VAR_3 ; }
VAR_5 = ( Map < String Object > ) VAR_3 ;
public TYPE_1 ( Map < String , Object > VAR_2 ) { super ( VAR_2 ) ; Object VAR_3 = VAR_2 . get ( VAR_4 ) ; if ( VAR_3 != null ) { <START> VAR_5 = ( Map < String , Object > ) VAR_2 . get ( VAR_4 ) ; <END> } }
public TYPE_1 ( Map < String , Object > VAR_2 ) { super ( VAR_2 ) ; VAR_5 = ( Map < String , Object > ) VAR_2 . get ( VAR_4 ) ; }
existing network attachments ( returned db ) id set
private void METHOD_1 ( List < TYPE_1 > VAR_1 ) { for ( Guid VAR_2 : VAR_3 ) { VAR_4 . remove ( VAR_2 ) ; } for ( Iterator < TYPE_1 > iterator = VAR_1 . iterator ( ) ; iterator . hasNext ( ) ; ) { Guid VAR_5 = iterator . next ( ) . getId ( ) ; if <START> ( VAR_5 != null && <END> VAR_3 . contains ( VAR_5 ) ) { iterator . remove ( ) ; break ; } } }
private void METHOD_1 ( List < TYPE_1 > VAR_1 ) { for ( Guid VAR_2 : VAR_3 ) { VAR_4 . remove ( VAR_2 ) ; } for ( Iterator < TYPE_1 > iterator = VAR_1 . iterator ( ) ; iterator . hasNext ( ) ; ) { Guid VAR_5 = iterator . next ( ) . getId ( ) ; if ( VAR_3 . contains ( VAR_5 ) ) { iterator . remove ( ) ; } } }