Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
backported ? checkstyle complaining
private void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = TYPE_2 . METHOD_2 ( ) ; <START> VAR_1 . addAll ( TYPE_2 . getInstance ( ) . METHOD_3 ( ) ) ; <END> VAR_1 . addAll ( TYPE_2 . METHOD_4 ( ) ) ; VAR_1 . addAll ( TYPE_2 . METHOD_5 ( ) ) ; METHOD_6 ( ) . METHOD_7 ( VAR_1 ) ; }
private void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = TYPE_2 . METHOD_2 ( ) ; VAR_1 . addAll ( TYPE_2 . METHOD_3 ( ) ) ; VAR_1 . addAll ( TYPE_2 . METHOD_4 ( ) ) ; VAR_1 . addAll ( TYPE_2 . METHOD_5 ( ) ) ; METHOD_6 ( ) . METHOD_7 ( VAR_1 ) ; }
please fix bracketing
private boolean VAR_1 ( VAR_2 vds ) { TYPE_6 VAR_4 = vds . VAR_5 ( ) ; return ( VAR_4 . getStatus ( ) == TYPE_5 . TYPE_2 || VAR_4 . getStatus ( ) == TYPE_5 . TYPE_4 || VAR_4 . getStatus ( ) == TYPE_5 . TYPE_1 || VAR_4 . getStatus ( ) == TYPE_5 . TYPE_3 || ( VAR_4 . getStatus ( ) == TYPE_5 . TYPE_8 <START> || ( VAR_4 . getStatus ( ) == TYPE_5 . TYPE_9 <END> && VAR_4 . VAR_13 ( ) == TYPE_7 . VAR_15 ) ) ; }
private boolean VAR_1 ( VAR_2 vds ) { TYPE_6 VAR_4 = vds . VAR_5 ( ) ; return ( VAR_4 . getStatus ( ) == TYPE_5 . TYPE_2 || VAR_4 . getStatus ( ) == TYPE_5 . TYPE_4 || VAR_4 . getStatus ( ) == TYPE_5 . TYPE_1 || VAR_4 . getStatus ( ) == TYPE_5 . TYPE_3 || VAR_4 . getStatus ( ) == TYPE_5 . TYPE_9 || ( VAR_4 . getStatus ( ) == TYPE_5 . TYPE_8 && VAR_4 . VAR_13 ( ) == TYPE_7 . VAR_15 ) ) ; }
variable left outuua
private double METHOD_1 ( TYPE_1 VAR_1 ) { int VAR_2 = ( VAR_1 . METHOD_2 ( ) == 0 ) ? 100 : VAR_1 . METHOD_3 ( ) ; <START> double VAR_3 = VAR_2 * VAR_1 . METHOD_4 ( ) / FLOAT_1 ; <END> return VAR_3 ; }
private double METHOD_1 ( TYPE_1 VAR_1 ) { int VAR_2 = ( VAR_1 . METHOD_2 ( ) == 0 ) ? 100 : VAR_1 . METHOD_3 ( ) ; return ( VAR_2 * VAR_1 . METHOD_4 ( ) / FLOAT_1 ) ; }
c tor implies entity immutable please assumption _CODE_ class introduce a c tor expect VAR_3 VAR_4 instead setters
public TYPE_2 ( Guid VAR_2 , TYPE_1 VAR_3 , Guid VAR_4 ) { <START> this . VAR_2 = VAR_2 ; <END> METHOD_1 ( VAR_3 ) ; METHOD_2 ( VAR_4 ) ; }
public TYPE_2 ( Guid VAR_2 , TYPE_1 VAR_3 , Guid VAR_4 ) { super ( VAR_3 , VAR_4 ) ; this . VAR_2 = VAR_2 ; }
shouldn t update VAR_1 member
public void METHOD_1 ( TYPE_1 model , boolean value ) { if ( ! METHOD_2 ( ) ) { if ( value ) { if ( METHOD_3 ( ) != null ) { METHOD_3 ( ) . METHOD_1 ( false ) ; } VAR_1 = model ; } else { <START> METHOD_4 ( ) . METHOD_1 ( true ) ; <END> } } model . VAR_2 ( value ) ; }
public void METHOD_1 ( TYPE_1 model , boolean value ) { if ( ! METHOD_2 ( ) ) { if ( value ) { if ( METHOD_3 ( ) != null ) { METHOD_3 ( ) . METHOD_1 ( false ) ; } VAR_1 = model ; } } model . VAR_2 ( value ) ; }
a Boolean null ( don t load disk disk vm )
<START> public boolean METHOD_1 ( ) { <END> return VAR_1 ; }
public Boolean METHOD_1 ( ) { return VAR_1 ; }
Boolean VAR_2 equals ( )
public TYPE_1 METHOD_1 ( TYPE_2 vm , TYPE_3 VAR_1 ) { if ( vm == null && Boolean . VAR_2 . equals ( VAR_1 . METHOD_2 ( ) ) ) { return new TYPE_1 ( TYPE_4 . VAR_4 ) ; } if ( VAR_1 . METHOD_2 ( ) != null && <START> VAR_1 . METHOD_2 ( ) <END> && VAR_1 . METHOD_3 ( ) == TYPE_5 . VAR_6 ) { return new TYPE_1 ( TYPE_4 . VAR_7 ) ; } return TYPE_1 . VAR_8 ; }
public TYPE_1 METHOD_1 ( TYPE_2 vm , TYPE_3 VAR_1 ) { if ( vm == null && Boolean . VAR_2 . equals ( VAR_1 . METHOD_2 ( ) ) ) { return new TYPE_1 ( TYPE_4 . VAR_4 ) ; } if ( Boolean . VAR_2 . equals ( VAR_1 . METHOD_2 ( ) ) && VAR_1 . METHOD_3 ( ) == TYPE_5 . VAR_6 ) { return new TYPE_1 ( TYPE_4 . VAR_7 ) ; } return TYPE_1 . VAR_8 ; }
address assertion isn t related testing scsi reservation property
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . get ( METHOD_2 ( ) ) ; boolean VAR_3 = ! VAR_1 . METHOD_3 ( ) ; <START> Assert . assertTrue ( StringUtils . VAR_4 ( VAR_1 . METHOD_4 ( ) ) ) ; <END> VAR_1 . METHOD_5 ( VAR_3 ) ; VAR_2 . update ( VAR_1 ) ; VAR_2 . get ( METHOD_2 ( ) ) ; assertEquals ( VAR_1 . METHOD_3 ( ) , VAR_3 ) ; }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . get ( METHOD_2 ( ) ) ; boolean VAR_3 = ! VAR_1 . METHOD_3 ( ) ; VAR_1 . METHOD_5 ( VAR_3 ) ; VAR_2 . update ( VAR_1 ) ; VAR_2 . get ( METHOD_2 ( ) ) ; assertEquals ( VAR_1 . METHOD_3 ( ) , VAR_3 ) ; }
I d prefer implementation similar line 55
public int METHOD_1 ( ) { final int VAR_1 = INT_1 ; int result = super . METHOD_1 ( ) ; <START> result = VAR_1 * result + ( Boolean . VAR_2 . equals ( VAR_3 ) ? INT_2 : INT_3 ) ; <END> result = VAR_1 * result + ( ( VAR_4 == null ) ? 0 : VAR_4 . METHOD_1 ( ) ) ; return result ; }
public int METHOD_1 ( ) { final int VAR_1 = INT_1 ; int result = super . METHOD_1 ( ) ; result = VAR_1 * result + ( ( VAR_3 == null ) ? 0 : VAR_3 . METHOD_1 ( ) ) ; result = VAR_1 * result + ( ( VAR_4 == null ) ? 0 : VAR_4 . METHOD_1 ( ) ) ; return result ; }
please call other constructor
public TYPE_2 ( TYPE_1 resource , String VAR_2 ) { this . properties = METHOD_1 ( resource ) ; this . VAR_2 = VAR_2 ; METHOD_2 ( ) ; <START> } <END>
public TYPE_2 ( TYPE_1 resource , String VAR_2 ) { this ( METHOD_1 ( resource ) , VAR_2 ) ; }
io exception good enough ? please include exception rethrowing
public static TYPE_1 METHOD_1 ( Class < ? > VAR_1 , String resource ) throws IOException { try ( TYPE_2 is = new TYPE_3 ( VAR_1 . METHOD_2 ( resource ) , STRING_1 ) ) { TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 . METHOD_3 ( is ) ; return VAR_2 ; } catch ( IOException e ) { throw new IOException ( String . format ( STRING_2 , resource ) <START> ) ; <END> } }
public static TYPE_1 METHOD_1 ( Class < ? > VAR_1 , String resource ) throws IOException { TYPE_2 is = new TYPE_3 ( VAR_1 . METHOD_2 ( resource ) , STRING_1 ) ; TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 . METHOD_3 ( is ) ; return VAR_2 ; }
done
public boolean METHOD_1 ( List < String > VAR_1 ) throws Exception { TYPE_1 parser = new TYPE_1 ( TYPE_2 . METHOD_2 ( getClass ( ) , STRING_1 ) , TYPE_2 . METHOD_2 ( getClass ( ) , STRING_2 ) ) ; args = parser . parse ( VAR_1 ) ; <START> return args . containsKey ( STRING_3 ) ; <END> }
public void METHOD_1 ( List < String > VAR_1 ) throws Exception { args = new TYPE_1 ( TYPE_2 . METHOD_2 ( getClass ( ) , STRING_1 ) ) . parse ( VAR_1 ) ; }
please add static import
public void METHOD_1 ( ) { <START> TYPE_1 . when ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( true ) ; <END> Assert . assertTrue ( VAR_2 . METHOD_4 ( VAR_1 ) ) ; }
public void METHOD_1 ( ) { when ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( true ) ; assertTrue ( VAR_2 . METHOD_4 ( VAR_1 ) ) ; }
convention - move annotation a separate line
<START> @Override protected void METHOD_1 ( TYPE_1 connection ) { } <END>
protected void METHOD_1 ( TYPE_1 connection ) { }
super called
public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( VAR_1 ) ) ; <START> super . METHOD_1 ( VAR_1 ) ; <END> }
public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( VAR_1 ) ) ; }
VAR_3 null contract dao fetching collections please replace withif ( ! VAR_3 isEmpty ( ) )
private TYPE_1 METHOD_1 ( Guid VAR_1 , Guid VAR_2 ) { List < TYPE_1 > VAR_3 = METHOD_2 ( ) . METHOD_3 ( VAR_1 , TYPE_2 . TYPE_3 ) ; <START> if ( VAR_3 != null && VAR_3 . size ( ) > 0 ) { <END> for ( TYPE_1 vds : VAR_3 ) { if ( ! VAR_2 . equals ( vds . getId ( ) ) ) { return vds ; } } } return null ; }
private TYPE_1 METHOD_1 ( Guid VAR_1 , Guid VAR_2 ) { List < TYPE_1 > VAR_3 = METHOD_2 ( ) . METHOD_3 ( VAR_1 , TYPE_2 . TYPE_3 ) ; if ( VAR_3 . isEmpty ( ) ) { return null ; } for ( TYPE_1 vds : VAR_3 ) { if ( ! VAR_2 . equals ( vds . getId ( ) ) ) { return vds ; } } return null ; }
TYPE_3 TYPE_1 ( ) worry some unexpected TYPE_3 toString ( ) future implementation
public static void METHOD_1 ( final TYPE_1 vm ) { vm . VAR_1 ( METHOD_2 ( ) . METHOD_3 ( String . format ( STRING_1 , vm . getId ( ) , <START> TYPE_3 . TYPE_1 ) ) ) ; <END> }
public static void METHOD_1 ( final TYPE_1 vm ) { vm . VAR_1 ( METHOD_2 ( ) . METHOD_3 ( String . format ( STRING_1 , vm . getId ( ) , TYPE_3 . TYPE_1 . name ( ) ) ) ) ; }
I feel alias pass cluster volume VAR_2 messages a string volume data { 0 } cluster { 1 } replicated volume a thought
private String METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { return null ; } String [ ] VAR_2 = VAR_1 . split ( STRING_1 ) ; <START> return VAR_2 . length == 2 ? VAR_2 [ 0 ] + STRING_2 + VAR_2 [ 1 ] + STRING_3 : VAR_2 [ 0 ] ; <END> }
private String [ ] METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { return null ; } String [ ] VAR_2 = VAR_1 . split ( STRING_1 ) ; return VAR_2 ; }
editor bounded _CODE_ entity s visibility altered model TYPE_1 - > diskstoragetype_entitychanged ( )
private void METHOD_1 ( final TYPE_1 VAR_1 ) { boolean VAR_2 = VAR_1 . METHOD_2 ( ) != null ; VAR_3 . METHOD_3 ( VAR_4 ) ; VAR_5 . METHOD_3 ( VAR_4 && VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) == TYPE_2 . VAR_7 ) ; <START> VAR_8 . METHOD_3 ( VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) != TYPE_2 . VAR_7 ) ; <END> VAR_9 . METHOD_6 ( ! VAR_2 ) ; }
private void METHOD_1 ( final TYPE_1 VAR_1 ) { boolean VAR_2 = VAR_1 . METHOD_2 ( ) != null ; VAR_3 . METHOD_3 ( VAR_4 ) ; VAR_5 . METHOD_3 ( VAR_4 && VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) == TYPE_2 . VAR_7 ) ; VAR_9 . METHOD_6 ( ! VAR_2 ) ; }
I : return Arrays asList ( { TYPE_1 VAR_2 TYPE_1 VAR_3 TYPE_1 VAR_4 TYPE_1 VAR_5 } ) ; more concise doesn t create array lists
public ArrayList < TYPE_1 > METHOD_1 ( ) { ArrayList < TYPE_1 > VAR_1 = new ArrayList < > ( Arrays . asList ( new TYPE_1 [ ] { TYPE_1 . VAR_2 , TYPE_1 . VAR_3 , TYPE_1 . VAR_4 , TYPE_1 . VAR_5 } ) ) ; <START> return VAR_1 ; <END> }
public List < TYPE_1 > METHOD_1 ( ) { return Arrays . asList ( TYPE_1 . VAR_2 , TYPE_1 . VAR_3 , TYPE_1 . VAR_4 , TYPE_1 . VAR_5 ) ; }
implicit
public TYPE_2 ( List < TYPE_1 < T > > VAR_2 , List VAR_3 ) { <START> super ( ) ; <END> METHOD_1 ( ) ; METHOD_2 ( TYPE_3 . VAR_5 . METHOD_3 ( this ) ) ; METHOD_4 ( VAR_2 , VAR_3 ) ; METHOD_5 ( ) ; }
public TYPE_2 ( List < TYPE_1 < T > > VAR_2 , List VAR_3 ) { METHOD_1 ( ) ; METHOD_2 ( TYPE_3 . VAR_5 . METHOD_3 ( this ) ) ; METHOD_4 ( VAR_2 , VAR_3 ) ; METHOD_5 ( ) ; }
implicit
public TYPE_4 ( String VAR_2 , TYPE_1 VAR_3 , TYPE_1 VAR_4 , String VAR_5 ) { <START> super ( ) ; <END> METHOD_1 ( TYPE_5 . VAR_7 . METHOD_2 ( this ) ) ; METHOD_3 ( VAR_2 ) ; METHOD_4 ( TYPE_2 . METHOD_5 ( TYPE_3 . create ( VAR_3 ) . METHOD_6 ( ) ) ) ; METHOD_7 ( TYPE_2 . METHOD_5 ( TYPE_3 . create ( VAR_4 ) . METHOD_6 ( ) ) ) ; VAR_8 . METHOD_8 ( VAR_5 ) ; }
public TYPE_4 ( String VAR_2 , TYPE_1 VAR_3 , TYPE_1 VAR_4 , String VAR_5 ) { METHOD_1 ( TYPE_5 . VAR_7 . METHOD_2 ( this ) ) ; METHOD_3 ( VAR_2 ) ; METHOD_4 ( TYPE_2 . METHOD_5 ( TYPE_3 . create ( VAR_3 ) . METHOD_6 ( ) ) ) ; METHOD_7 ( TYPE_2 . METHOD_5 ( TYPE_3 . create ( VAR_4 ) . METHOD_6 ( ) ) ) ; VAR_8 . METHOD_8 ( VAR_5 ) ; }
return TYPE_2 getInstance ( ) METHOD_2 ( VAR_1 ) ; host needed
public TYPE_1 METHOD_1 ( String VAR_1 ) { <START> final TYPE_1 host = TYPE_2 . getInstance ( ) . METHOD_2 ( VAR_1 ) ; <END> return host ; }
public TYPE_1 METHOD_1 ( String VAR_1 ) { return TYPE_2 . getInstance ( ) . METHOD_2 ( VAR_1 ) ; }
synchronized
public <START> synchronized static <END> Map < String , String > METHOD_1 ( ) { return VAR_1 ; }
public static Map < String , String > METHOD_1 ( ) { return VAR_1 ; }
t concurrent hash map instead synchronized
public <START> synchronized static <END> void METHOD_1 ( String VAR_1 , String VAR_2 ) { VAR_3 . put ( VAR_1 , VAR_2 ) ; }
public static void METHOD_1 ( String VAR_1 , String VAR_2 ) { VAR_3 . put ( VAR_1 , VAR_2 ) ; }
isn t empty diamond ? Map < String TYPE_1 > map = new HashMap < > ( ) ;
public static < TYPE_1 extends TYPE_2 > Map < String , TYPE_1 > METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { if ( VAR_1 != null ) { <START> Map < String , TYPE_1 > map = new HashMap < String , TYPE_1 > ( ) ; <END> for ( TYPE_1 VAR_2 : VAR_1 ) { if ( VAR_2 . METHOD_2 ( ) != null ) { map . put ( VAR_2 . METHOD_2 ( ) , VAR_2 ) ; } } return map ; } else { return Collections . VAR_3 ( ) ; } }
public static < TYPE_1 extends TYPE_2 > Map < String , TYPE_1 > METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { if ( VAR_1 != null ) { Map < String , TYPE_1 > map = new HashMap < > ( ) ; for ( TYPE_1 VAR_2 : VAR_1 ) { if ( VAR_2 . METHOD_2 ( ) != null ) { map . put ( VAR_2 . METHOD_2 ( ) , VAR_2 ) ; } } return map ; } else { return Collections . VAR_3 ( ) ; } }
won t args ? TYPE_3 METHOD_3 ( command = sso - token - validate String format ( sso_token = %s VAR_1 ) ; : TYPE_3 METHOD_3 ( req STRING_1 VAR_1 ) ;
public static boolean METHOD_1 ( TYPE_1 req ) throws TYPE_2 { String VAR_1 = ( String ) req . VAR_2 ( true ) . METHOD_2 ( TYPE_4 . VAR_4 ) ; boolean VAR_5 = false ; if ( StringUtils . VAR_6 ( VAR_1 ) ) { try { TYPE_3 . METHOD_3 ( req , String . format ( STRING_1 , VAR_1 ) ) ; <START> VAR_5 = true ; <END> } catch ( Exception e ) { log . error ( STRING_2 + VAR_1 , e . getMessage ( ) ) ; } } return VAR_5 ; }
public static boolean METHOD_1 ( TYPE_1 req ) throws TYPE_2 { String VAR_1 = ( String ) req . VAR_2 ( true ) . METHOD_2 ( TYPE_4 . VAR_4 ) ; boolean VAR_5 = false ; if ( StringUtils . VAR_6 ( VAR_1 ) ) { try { TYPE_3 . METHOD_3 ( STRING_1 , VAR_1 ) ; VAR_5 = true ; } catch ( Exception e ) { log . error ( STRING_2 + VAR_1 , e . getMessage ( ) ) ; } } return VAR_5 ; }
IMO more readable : private boolean METHOD_1 ( String obj String VAR_1 boolean VAR_2 ) { ( VAR_2 ) { return VAR_3 containsKey ( obj + STRING_1 + VAR_1 ) ; } return false ; }
private boolean METHOD_1 ( String obj , String VAR_1 , boolean VAR_2 ) { if ( ! VAR_2 ) { return false ; } Boolean result = VAR_3 . containsKey ( obj + STRING_1 + VAR_1 ) ; if ( result != null && result ) { return true ; } <START> return false ; <END> }
private boolean METHOD_1 ( String obj , String VAR_1 , boolean VAR_2 ) { if ( VAR_2 ) { return VAR_3 . containsKey ( obj + STRING_1 + VAR_1 ) ; } return false ; }
1 method public ? isn t class 2 guaranteed time method called context VAR_3 find some CDI equivalent spring order CDI bean dependent _CODE_
<START> public < T <END> extends TYPE_1 > T METHOD_1 ( Class < T > VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_3 ) { if ( VAR_1 . METHOD_2 ( VAR_2 . getClass ( ) ) ) { METHOD_3 ( ( TYPE_2 ) VAR_2 ) ; return ( T ) VAR_2 ; } } log . error ( STRING_1 + VAR_1 ) ; return null ; }
protected < T extends TYPE_1 > T METHOD_1 ( Class < T > VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_3 ) { if ( VAR_1 . METHOD_2 ( VAR_2 . getClass ( ) ) ) { METHOD_3 ( ( TYPE_2 ) VAR_2 ) ; return ( T ) VAR_2 ; } } log . error ( STRING_1 + VAR_1 ) ; return null ; }
status TYPE_4 definition null - please remove redundant check
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return VAR_1 . METHOD_2 ( ) == TYPE_2 . TYPE_3 && VAR_1 . getStatus ( ) != null <END> && VAR_1 . getStatus ( ) == TYPE_5 . TYPE_4 ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 . METHOD_2 ( ) == TYPE_2 . TYPE_3 && VAR_1 . getStatus ( ) == TYPE_5 . TYPE_4 ; }
shouldn t return super METHOD_1 ( )
public TYPE_1 < TYPE_2 > METHOD_1 ( ) { <START> return ( TYPE_1 < TYPE_2 > ) METHOD_1 ( ) ; <END> }
public TYPE_1 < TYPE_2 > METHOD_1 ( ) { return ( TYPE_1 < TYPE_2 > ) super . METHOD_1 ( ) ; }
instead 3 lines ? return METHOD_2 ( TYPE_4 VAR_7 Arrays asList ( VAR_1 ) )
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_1 == null ) { return new TYPE_1 ( Status . VAR_2 , TYPE_3 . VAR_4 , STRING_1 ) ; } <START> List < TYPE_2 > VAR_5 = new ArrayList < > ( ) ; <END> VAR_5 . add ( VAR_1 ) ; return METHOD_2 ( TYPE_4 . VAR_7 , VAR_5 ) ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_1 == null ) { return new TYPE_1 ( Status . VAR_2 , TYPE_3 . VAR_4 , STRING_1 ) ; } return METHOD_2 ( TYPE_4 . VAR_7 , Arrays . asList ( VAR_1 ) ) ; }
calling unlock done METHOD_2 ( ) METHOD_7 ( ) ;
public void METHOD_1 ( Guid VAR_1 , List < Guid > VAR_2 ) { super . METHOD_1 ( VAR_1 , VAR_2 ) ; <START> METHOD_2 ( ) . METHOD_3 ( ) ; <END> log . error ( STRING_1 , METHOD_4 ( ) ) ; METHOD_5 ( TYPE_2 . VAR_4 , METHOD_2 ( ) . METHOD_6 ( ) ) ; METHOD_2 ( ) . METHOD_7 ( ) ; TYPE_1 . METHOD_8 ( VAR_1 ) ; }
public void METHOD_1 ( Guid VAR_1 , List < Guid > VAR_2 ) { super . METHOD_1 ( VAR_1 , VAR_2 ) ; log . error ( STRING_1 , METHOD_4 ( ) ) ; METHOD_5 ( TYPE_2 . VAR_4 , METHOD_2 ( ) . METHOD_6 ( ) ) ; METHOD_2 ( ) . METHOD_7 ( ) ; TYPE_1 . METHOD_8 ( VAR_1 ) ; }
please rename - host isn t neccessarily spm
protected TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = <START> TYPE_3 . METHOD_2 ( METHOD_3 ( ) ) ; <END> return METHOD_4 ( TYPE_6 . TYPE_5 , new TYPE_4 ( VAR_1 . getId ( ) , getParameters ( ) . METHOD_5 ( ) ) ) ; }
protected TYPE_1 METHOD_1 ( ) { TYPE_2 vds = TYPE_3 . METHOD_2 ( METHOD_3 ( ) ) ; return METHOD_4 ( TYPE_6 . TYPE_5 , new TYPE_4 ( vds . getId ( ) , getParameters ( ) . METHOD_5 ( ) ) ) ; }
don t care order remove operations - a HashSet
private boolean METHOD_1 ( List < String > VAR_1 , TYPE_1 VAR_2 ) { List < TYPE_2 > VAR_3 = METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_5 ( ) ) ; <START> List < String > VAR_4 = new ArrayList < > ( VAR_1 ) ; <END> for ( TYPE_2 VAR_5 : VAR_3 ) { if ( VAR_4 . contains ( VAR_5 . METHOD_6 ( ) ) ) { VAR_4 . remove ( VAR_5 . METHOD_6 ( ) ) ; } } return VAR_4 . isEmpty ( ) ; }
private boolean METHOD_1 ( List < String > VAR_1 , TYPE_1 VAR_2 ) { List < TYPE_2 > VAR_3 = METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_5 ( ) ) ; Set < String > VAR_4 = new HashSet < > ( VAR_1 ) ; for ( TYPE_2 VAR_5 : VAR_3 ) { if ( VAR_4 . contains ( VAR_5 . METHOD_6 ( ) ) ) { VAR_4 . remove ( VAR_5 . METHOD_6 ( ) ) ; } } return VAR_4 . isEmpty ( ) ; }
3 6 0 VAR_4 case METHOD_2 host
protected TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( TYPE_3 . filter ( METHOD_3 ( ) , new TYPE_4 < TYPE_2 > ( ) { @Override public boolean METHOD_4 ( TYPE_2 vds ) { return vds . VAR_2 ( ) == TYPE_6 . VAR_4 ; } } ) ) ; return METHOD_5 ( TYPE_8 . TYPE_7 , <START> new TYPE_5 ( VAR_1 . getId ( ) , getParameters ( ) . METHOD_6 ( ) ) ) ; <END> }
protected TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( METHOD_3 ( ) ) ; return METHOD_5 ( TYPE_8 . TYPE_7 , new TYPE_5 ( VAR_1 . getId ( ) , getParameters ( ) . METHOD_6 ( ) ) ) ; }
log doesn t add info log s unneeded s clear log TYPE_3 failed
private Long METHOD_1 ( String VAR_1 ) { try { return ( Long ) METHOD_2 ( TYPE_4 . TYPE_3 , new TYPE_1 ( METHOD_3 ( ) , METHOD_4 ( ) , VAR_1 ) ) . METHOD_5 ( ) ; } catch ( TYPE_2 e ) { <START> log . error ( STRING_1 + VAR_1 , e ) ; <END> throw e ; } }
private Long METHOD_1 ( String VAR_1 ) { return ( Long ) METHOD_2 ( TYPE_4 . TYPE_3 , new TYPE_1 ( METHOD_3 ( ) , METHOD_4 ( ) , VAR_1 ) ) . METHOD_5 ( ) ; }
thanks please replace order - METHOD_5 ( ) VAR_2 update call s a failure calls changes won t reverted
protected void METHOD_1 ( final String VAR_1 , final TYPE_1 VAR_2 ) { VAR_2 . METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) . METHOD_4 ( VAR_2 ) ; VAR_3 . update ( VAR_2 ) ; <START> METHOD_3 ( ) . METHOD_5 ( ) ; <END> }
protected void METHOD_1 ( final String VAR_1 , final TYPE_1 VAR_2 ) { VAR_2 . METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) . METHOD_4 ( VAR_2 ) ; METHOD_3 ( ) . METHOD_5 ( ) ; VAR_3 . update ( VAR_2 ) ; }
_CODE_ append ( final String final Map < > ) please replace append ( STRING_2 VAR_3 ) ;
protected TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { return super . METHOD_1 ( VAR_1 ) . append ( STRING_1 , VAR_2 . getId ( ) ) <START> . append ( STRING_2 , VAR_3 . toString ( ) ) ; <END> }
protected TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { return super . METHOD_1 ( VAR_1 ) . append ( STRING_1 , VAR_2 . getId ( ) ) . append ( STRING_2 , VAR_3 ) ; }
method parameters generic messages means var - action - xandvar - type - yand called automatically _CODE_ need call againthe specific failure messages added _CODE_ _CODE_ : ( _CODE_ ) { result = _CODE_ ( msg ) ; } ( a note - quick - return _CODE_ means issue return method more readable ( need ti check result complicated - else a a short )
<START> protected void METHOD_1 ( ) { <END> METHOD_2 ( TYPE_1 . VAR_2 ) ; METHOD_2 ( TYPE_1 . VAR_3 ) ; METHOD_2 ( TYPE_1 . VAR_4 ) ; }
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_1 . VAR_2 ) ; METHOD_2 ( TYPE_1 . VAR_3 ) ; }
i d add assertNotNull ( entry ) ; a proper assumption prior validating entry data
public void METHOD_1 ( ) { <START> TYPE_1 entry = VAR_1 . METHOD_2 ( VAR_2 , VAR_3 ) ; <END> METHOD_3 ( entry . VAR_4 ( ) ) ; VAR_1 . METHOD_4 ( ) ; entry = VAR_1 . METHOD_2 ( VAR_2 , VAR_3 ) ; assertTrue ( entry . VAR_4 ( ) ) ; }
public void METHOD_1 ( ) { TYPE_1 entry = VAR_1 . METHOD_2 ( VAR_2 , VAR_3 ) ; assertNotNull ( entry ) ; METHOD_3 ( entry . VAR_4 ( ) ) ; VAR_1 . METHOD_4 ( ) ; entry = VAR_1 . METHOD_2 ( VAR_2 , VAR_3 ) ; assertNotNull ( entry ) ; assertTrue ( entry . VAR_4 ( ) ) ; }
I pretty convention @Override method declaration
<START> @Override public void METHOD_1 ( ) { <END> METHOD_2 ( ) . METHOD_3 ( STRING_1 , METHOD_4 ( ) ) ; }
public void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( STRING_1 , METHOD_4 ( ) ) ; }
needed
public TYPE_2 ( TYPE_1 context ) { <START> super ( ) ; <END> this . context = context ; }
public TYPE_2 ( TYPE_1 context ) { this . context = context ; }
constructor work VAR_4
protected TYPE_3 ( Guid VAR_2 , Class < TYPE_1 > VAR_3 ) { <START> super ( VAR_3 , TYPE_2 . class , VAR_4 ) ; <END> this . VAR_2 = VAR_2 ; }
protected TYPE_3 ( Guid VAR_2 , Class < TYPE_1 > VAR_3 ) { super ( VAR_3 , TYPE_2 . class ) ; this . VAR_2 = VAR_2 ; }
need TYPE_2 s a METHOD_3 ( String guid ) method ancestor class
protected Response METHOD_1 ( String id ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; <START> VAR_1 . METHOD_2 ( TYPE_2 . METHOD_3 ( id ) ) ; <END> return METHOD_4 ( TYPE_4 . TYPE_3 , VAR_1 ) ; }
protected Response METHOD_1 ( String id ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( METHOD_3 ( id ) ) ; return METHOD_4 ( TYPE_4 . TYPE_3 , VAR_1 ) ; }
init false I line 442 _CODE_ _CODE_ doesn t
public void METHOD_1 ( TYPE_1 < Boolean > value ) { this . VAR_1 = value ; <START> this . VAR_1 . METHOD_2 ( value . VAR_2 ( ) ) ; <END> }
public void METHOD_1 ( TYPE_1 < Boolean > value ) { this . VAR_1 = value ; }
_CODE_ message custom required
public Map < String , String > METHOD_1 ( ) { <START> METHOD_2 ( STRING_1 , METHOD_3 ( ) ) ; <END> return super . METHOD_1 ( ) ; }
public Map < String , String > METHOD_1 ( ) { return super . METHOD_1 ( ) ; }
doesn t need public protected
<START> public void METHOD_1 ( ) { } <END>
protected void METHOD_1 ( ) { }
please put @Override a separate line
<START> @Override public <END> TYPE_1 getId ( ) { TYPE_1 key = new TYPE_1 ( ) ; key . VAR_1 ( VAR_2 ) ; key . VAR_3 ( VAR_4 ) ; return key ; }
public TYPE_1 getId ( ) { TYPE_1 key = new TYPE_1 ( ) ; key . VAR_1 ( VAR_2 ) ; key . VAR_3 ( VAR_4 ) ; return key ; }
please put @Override a separate line
<START> @Override public <END> void METHOD_1 ( TYPE_1 id ) { VAR_1 = id . VAR_2 ( ) ; VAR_3 = id . VAR_4 ( ) ; }
public void METHOD_1 ( TYPE_1 id ) { VAR_1 = id . VAR_2 ( ) ; VAR_3 = id . VAR_4 ( ) ; }
assumption VAR_2 null replace entire : ( VAR_2 isEmpty ( ) ) { return null ; } else { return VAR_2 ( 0 ) ; }
public TYPE_1 METHOD_1 ( String VAR_1 ) { List < TYPE_1 > VAR_2 = METHOD_2 ( VAR_3 . METHOD_3 ( STRING_1 , TYPE_1 . class ) . METHOD_4 ( STRING_2 , VAR_1 ) ) ; <START> if ( VAR_2 != null && VAR_2 . size ( ) > 0 ) { <END> return VAR_2 . get ( 0 ) ; } else { return null ; } }
public TYPE_1 METHOD_1 ( String VAR_1 ) { List < TYPE_1 > VAR_2 = METHOD_2 ( VAR_3 . METHOD_3 ( STRING_1 , TYPE_1 . class ) . METHOD_4 ( STRING_2 , VAR_1 ) ) ; if ( VAR_2 . isEmpty ( ) ) { return null ; } else { return VAR_2 . get ( 0 ) ; } }
1 I don t needed check VM null - locked remove it2 important status ? powering -
protected void METHOD_1 ( ) { <START> if ( METHOD_2 ( ) != null && METHOD_2 ( ) . getStatus ( ) == TYPE_7 . TYPE_6 ) { <END> try { TYPE_1 VAR_3 = METHOD_3 ( TYPE_5 . TYPE_4 , new TYPE_2 ( METHOD_4 ( ) , METHOD_5 ( ) ) ) ; if ( VAR_3 != null ) { VAR_6 = ( Integer ) VAR_3 . METHOD_6 ( ) ; } } catch ( TYPE_3 e ) { VAR_7 = e . VAR_8 ( ) ; } } }
protected void METHOD_1 ( ) { try { TYPE_1 VAR_3 = METHOD_3 ( TYPE_5 . TYPE_4 , new TYPE_2 ( METHOD_4 ( ) , METHOD_5 ( ) ) ) ; if ( VAR_3 != null ) { VAR_6 = ( Integer ) VAR_3 . METHOD_6 ( ) ; } } catch ( TYPE_3 e ) { VAR_7 = e . VAR_8 ( ) ; } }
call METHOD_4 ( null ) whithout explicit reference outer
protected void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( new TYPE_2 ( ) { @Override public void METHOD_3 ( TYPE_3 result ) { <START> TYPE_4 . this . METHOD_4 ( null ) ; <END> } } , VAR_3 ) ; }
protected void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( new TYPE_2 ( ) { @Override public void METHOD_3 ( TYPE_3 result ) { METHOD_4 ( null ) ; } } , VAR_3 ) ; }
I don t change related elapsed - time change needed
TYPE_1 METHOD_1 ( ) { TYPE_1 vm = new TYPE_1 ( ) ; vm . VAR_1 ( new TYPE_2 ( ) ) ; vm . VAR_2 ( id ) ; vm . VAR_3 ( name ( ) ) ; vm . VAR_4 ( VAR_5 ) ; <START> vm . VAR_6 ( - FLOAT_1 ) ; <END> return vm ; }
TYPE_1 METHOD_1 ( ) { TYPE_1 vm = new TYPE_1 ( ) ; vm . VAR_1 ( new TYPE_2 ( ) ) ; vm . VAR_2 ( id ) ; vm . VAR_3 ( name ( ) ) ; vm . VAR_4 ( VAR_5 ) ; return vm ; }
needed ( null won t )
public void METHOD_1 ( TYPE_1 vm ) { METHOD_2 ( vm . getId ( ) ) ; <START> METHOD_3 ( vm , TYPE_5 . TYPE_4 , vm . VAR_3 ( ) ) ; <END> TYPE_2 VAR_4 = new TYPE_2 ( ) ; VAR_4 . METHOD_4 ( vm . getId ( ) ) ; VAR_5 . log ( VAR_4 , TYPE_3 . VAR_7 ) ; METHOD_5 ( vm ) ; }
public void METHOD_1 ( TYPE_1 vm ) { METHOD_2 ( vm . getId ( ) ) ; METHOD_3 ( vm , TYPE_5 . TYPE_4 ) ; TYPE_2 VAR_4 = new TYPE_2 ( ) ; VAR_4 . METHOD_4 ( vm . getId ( ) ) ; VAR_5 . log ( VAR_4 , TYPE_3 . VAR_7 ) ; METHOD_5 ( vm ) ; }
_CODE_ parameter custom variable required
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_2 . VAR_2 ) ; METHOD_3 ( TYPE_1 . VAR_4 , getParameters ( ) . METHOD_4 ( ) . METHOD_5 ( ) ) ; <START> METHOD_3 ( STRING_1 , <END> METHOD_6 ( ) ) ; }
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_2 . VAR_2 ) ; METHOD_3 ( TYPE_1 . VAR_4 , getParameters ( ) . METHOD_4 ( ) . METHOD_5 ( ) ) ; }
assumes collections type safe side surround collection ( e g new ArrayList < > )
public void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( false ) ; <START> assertEquals ( VAR_1 , Arrays . asList ( VAR_2 ) ) ; <END> }
public void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < > ( METHOD_2 ( false ) ) ; assertEquals ( VAR_1 , Arrays . asList ( VAR_2 ) ) ; }
List < TYPE_1 >
private List < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> final ArrayList < TYPE_1 > result = new ArrayList < > ( ) ; <END> for ( TYPE_1 VAR_2 : VAR_1 ) { if ( ! VAR_2 . METHOD_2 ( ) ) { result . add ( VAR_2 ) ; } } return result ; }
private List < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 ) { final List < TYPE_1 > result = new ArrayList < > ( ) ; for ( TYPE_1 VAR_2 : VAR_1 ) { if ( ! VAR_2 . METHOD_2 ( ) ) { result . add ( VAR_2 ) ; } } return result ; }
please static import TYPE_2
private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( TYPE_1 . class ) ; <START> TYPE_2 . when ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( TYPE_4 < TYPE_3 > METHOD_5 ( ) ) ; <END> return VAR_1 ; }
private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( TYPE_4 < TYPE_3 > METHOD_5 ( ) ) ; return VAR_1 ; }
need ? planning add column _CODE_
<START> <END> <END> public <END> <END> TYPE_1 getValue <END> ( <END> <END> <END> TYPE_2 object <END> ) <END> { <END> if ( <END> <END> object <END> <END> <END> instanceof TYPE_1 <END> <END> ) { return <END> ( TYPE_1 ) object ; } <END> if ( <END> object instanceof <END> <END> TYPE_3 ) <END> { <END> if ( ( <END> ( TYPE_3 < ? , ? <END> > ) <END> object ) . METHOD_1 ( <END> <END> ) instanceof
public TYPE_1 getValue ( TYPE_2 object ) { if ( object instanceof TYPE_1 ) { return ( TYPE_1 ) object ; } return null ; }
change protected
<START> public TYPE_1 METHOD_1 ( ) { <END> return VAR_1 ; }
protected TYPE_1 METHOD_1 ( ) { return VAR_1 ; }
need final
public static TYPE_1 [ ] METHOD_1 ( List < TYPE_2 > VAR_1 ) { Set < TYPE_1 > VAR_2 = new HashSet < > ( ) ; for <START> ( final TYPE_2 <END> VAR_3 : VAR_1 ) { TYPE_1 VAR_4 = new TYPE_1 ( TYPE_4 . TYPE_3 , VAR_3 . METHOD_2 ( ) . get ( 0 ) ) ; VAR_2 . add ( VAR_4 ) ; } return VAR_2 . METHOD_3 ( new TYPE_1 [ VAR_2 . size ( ) ] ) ; }
public static TYPE_1 [ ] METHOD_1 ( List < TYPE_2 > VAR_1 ) { Set < TYPE_1 > VAR_2 = new HashSet < > ( ) ; for ( TYPE_2 VAR_3 : VAR_1 ) { TYPE_1 VAR_4 = new TYPE_1 ( TYPE_4 . TYPE_3 , VAR_3 . METHOD_2 ( ) . get ( 0 ) ) ; VAR_2 . add ( VAR_4 ) ; } return VAR_2 . METHOD_3 ( new TYPE_1 [ VAR_2 . size ( ) ] ) ; }
problems ve other properties _CODE_ converstion Integer int _CODE_ resulting I s return type int return null please fix I ll merge
<START> public Integer METHOD_1 ( ) { <END> return METHOD_2 ( ) == null ? 0 : METHOD_3 ( ) * METHOD_2 ( ) / 100 ; }
public int METHOD_1 ( ) { return METHOD_2 ( ) == null ? 0 : METHOD_3 ( ) * METHOD_2 ( ) / 100 ; }
simply VAR_2 getValue ( ) METHOD_2 ( true )
private void METHOD_1 ( List < T > VAR_1 ) { for ( Entry < T , TYPE_1 > VAR_2 : VAR_3 . entrySet ( ) ) { VAR_4 . add ( VAR_2 . getValue ( ) ) ; if ( VAR_1 . contains ( VAR_2 . getKey ( ) ) ) { <START> VAR_2 . getValue ( ) . METHOD_2 ( true , false ) ; <END> } } }
private void METHOD_1 ( List < T > VAR_1 ) { for ( Entry < T , TYPE_1 > VAR_2 : VAR_3 . entrySet ( ) ) { VAR_4 . add ( VAR_2 . getValue ( ) ) ; if ( VAR_1 . contains ( VAR_2 . getKey ( ) ) ) { VAR_2 . getValue ( ) . METHOD_2 ( true ) ; } } }
s / / id
<START> private TYPE_1 ( int value ) { <END> VAR_2 = value ; }
private TYPE_1 ( int value ) { id = value ; }
s / getValue / getId
<START> public int getValue ( ) { <END> return VAR_1 ; }
public int getValue ( ) { return id ; }
please compare _CODE_ fields explicitly
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . get ( VAR_3 . getId ( ) ) ; VAR_1 . METHOD_2 ( TYPE_2 . TYPE_3 ) ; VAR_2 . METHOD_3 ( VAR_1 . getId ( ) , VAR_1 . METHOD_4 ( ) ) ; TYPE_1 VAR_6 = VAR_2 . get ( VAR_3 . getId ( ) ) ; <START> assertEquals ( VAR_1 , VAR_6 ) ; <END> }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . get ( VAR_3 . getId ( ) ) ; VAR_1 . METHOD_2 ( TYPE_2 . TYPE_3 ) ; VAR_2 . METHOD_3 ( VAR_1 . getId ( ) , VAR_1 . METHOD_4 ( ) ) ; TYPE_1 VAR_6 = VAR_2 . get ( VAR_3 . getId ( ) ) ; assertEquals ( VAR_1 . METHOD_4 ( ) , VAR_6 . METHOD_4 ( ) ) ; }
part : new Guid ( getParameters ( ) METHOD_3 ( ) METHOD_5 ( ) toString ( ) ) replaced : getParameters ( ) METHOD_3 ( ) METHOD_5 ( )
public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( getParameters ( ) . METHOD_3 ( ) ) ; if ( METHOD_4 ( ) ) { <START> VAR_1 . add ( new TYPE_1 ( new Guid ( getParameters ( ) . METHOD_3 ( ) . METHOD_5 ( ) . toString ( ) ) , <END> TYPE_3 . VAR_3 , TYPE_2 . VAR_5 ) ) ; } return VAR_1 ; }
public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( getParameters ( ) . METHOD_3 ( ) ) ; if ( METHOD_4 ( ) ) { VAR_1 . add ( new TYPE_1 ( getParameters ( ) . METHOD_3 ( ) . METHOD_5 ( ) , TYPE_3 . VAR_3 , TYPE_2 . VAR_5 ) ) ; } return VAR_1 ; }
return type TYPE_1 avoid casting method called
<START> <END> <END> <END> protected <END> <END> Object METHOD_1 <END> <END> <END> ( TYPE_1
protected TYPE_1 METHOD_1 ( TYPE_1 object ) { return null ; }
need variable return returned call METHOD_3
public List < TYPE_1 > METHOD_1 ( Guid VAR_1 , TYPE_2 VAR_2 , boolean VAR_3 ) { <START> List < TYPE_1 > VAR_4 ; <END> if ( ! METHOD_2 ( VAR_1 , VAR_2 , VAR_3 ) ) { throw new TYPE_3 ( TYPE_4 . TYPE_5 ) ; } VAR_4 = METHOD_3 ( VAR_1 , VAR_2 ) ; return VAR_4 ; }
public List < TYPE_1 > METHOD_1 ( Guid VAR_1 , TYPE_2 VAR_2 , boolean VAR_3 ) { if ( ! METHOD_2 ( VAR_1 , VAR_2 , VAR_3 ) ) { throw new TYPE_3 ( TYPE_4 . TYPE_5 ) ; } return METHOD_3 ( VAR_1 , VAR_2 ) ; }
* shuoldn t call super ? * worth adding some log
protected void METHOD_1 ( ) { <START> METHOD_2 ( true ) ; <END> }
protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; }
I mark final safe - final methods ctor override foolish
<START> public void METHOD_1 ( ) { <END> VAR_1 = System . VAR_2 ( ) ; }
public final void METHOD_1 ( ) { VAR_1 = System . VAR_2 ( ) ; }
compute time - stamp a lot more efficient System currentTimeMillis ( )
public void METHOD_1 ( ) { <START> VAR_1 = TYPE_1 . getInstance ( ) . METHOD_2 ( ) ; <END> TYPE_2 VAR_2 = METHOD_3 ( ) . METHOD_4 ( TYPE_5 . List , new TYPE_3 ( VAR_4 . METHOD_5 ( ) ) ) ; if ( VAR_2 . METHOD_6 ( ) ) { VAR_5 = ( Map < Guid , TYPE_4 > ) VAR_2 . METHOD_7 ( ) ; METHOD_8 ( ) ; } else { METHOD_9 ( ) ; } }
public void METHOD_1 ( ) { TYPE_2 VAR_2 = METHOD_3 ( ) . METHOD_4 ( TYPE_5 . List , new TYPE_3 ( VAR_4 . METHOD_5 ( ) ) ) ; if ( VAR_2 . METHOD_6 ( ) ) { VAR_5 = ( Map < Guid , TYPE_4 > ) VAR_2 . METHOD_7 ( ) ; METHOD_8 ( ) ; } else { METHOD_9 ( ) ; } }
add method : public String _CODE_ ( ) audit log purposes
protected void METHOD_1 ( ) { Guid VAR_1 = getParameters ( ) . METHOD_2 ( ) . getId ( ) ; <START> METHOD_3 ( STRING_1 , VAR_1 . toString ( ) ) ; <END> METHOD_4 ( ) . METHOD_5 ( VAR_1 ) ; }
protected void METHOD_1 ( ) { METHOD_4 ( ) . METHOD_5 ( getParameters ( ) . METHOD_2 ( ) . getId ( ) ) ; }
recursive
private void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { do { logger . info ( STRING_1 , VAR_1 . get ( TYPE_2 . TYPE_3 . VAR_4 , "" ) , VAR_1 . get ( TYPE_2 . TYPE_3 . VAR_5 , "" ) , VAR_1 . get ( TYPE_2 . TYPE_3 . VAR_6 , "" ) , VAR_1 . get ( TYPE_2 . TYPE_3 . VAR_7 , "" ) ) ; <START> } while ( ( VAR_1 = VAR_1 . get ( TYPE_2 . TYPE_3 . VAR_8 ) ) != null ) ; <END> } }
private void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { log . info ( STRING_1 , VAR_1 . get ( TYPE_2 . TYPE_3 . VAR_4 , "" ) , VAR_1 . get ( TYPE_2 . TYPE_3 . VAR_5 , "" ) , VAR_1 . get ( TYPE_2 . TYPE_3 . VAR_6 , "" ) , VAR_1 . get ( TYPE_2 . TYPE_3 . VAR_7 , "" ) ) ; } }
cleaner store string a simple - stupid POJO optional logic s
public TYPE_1 ( Guid VAR_2 , Guid VAR_3 , Guid VAR_4 , Guid VAR_5 , Guid VAR_6 , Guid VAR_7 , Guid VAR_8 , String VAR_9 ) { super ( VAR_2 , VAR_3 ) ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_6 ; this . VAR_7 = VAR_7 ; this . VAR_8 = VAR_8 ; <START> this . VAR_9 = Optional . VAR_10 ( VAR_9 ) ; <END> }
public TYPE_1 ( Guid VAR_2 , Guid VAR_3 , Guid VAR_4 , Guid VAR_5 , Guid VAR_6 , Guid VAR_7 , Guid VAR_8 , String VAR_9 ) { super ( VAR_2 , VAR_3 ) ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_6 ; this . VAR_7 = VAR_7 ; this . VAR_8 = VAR_8 ; }
project s conventions I d drop
public Map < String , Object > METHOD_1 ( TYPE_1 vm , TYPE_2 VAR_1 , Map < String , Object > VAR_2 ) { <START> this . METHOD_2 ( vm , <END> VAR_1 ) . METHOD_3 ( ( VAR_3 ) - > VAR_2 . put ( TYPE_4 . TYPE_3 , VAR_3 ) ) ; return VAR_2 ; }
public Map < String , Object > METHOD_1 ( TYPE_1 vm , TYPE_2 VAR_1 , Map < String , Object > VAR_2 ) { METHOD_2 ( vm , VAR_1 ) . METHOD_3 ( ( VAR_3 ) - > VAR_2 . put ( TYPE_4 . TYPE_3 , VAR_3 ) ) ; return VAR_2 ; }
needs hidden
private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( false ) ; <START> VAR_2 . METHOD_2 ( false ) ; <END> VAR_3 . METHOD_2 ( false ) ; }
private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( false ) ; VAR_3 . METHOD_2 ( false ) ; }
null check done line 274
private Integer METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( ! VAR_1 . METHOD_2 ( ) ) { <END> Integer VAR_2 = VAR_3 . METHOD_3 ( ) . getValue ( ) ; return VAR_2 == null ? 0 : VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) * VAR_2 / 100 ; } return 0 ; }
private Integer METHOD_1 ( TYPE_1 VAR_1 ) { Integer VAR_2 = VAR_3 . METHOD_3 ( ) . getValue ( ) ; return VAR_2 == null ? 0 : VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) * VAR_2 / 100 ; }
I assignment VAR_3 base class ? doesn t
protected TYPE_3 ( String VAR_2 , String id ) { super ( id , TYPE_1 . class , TYPE_2 . class ) ; this . VAR_2 = VAR_2 ; <START> this . VAR_3 = METHOD_1 ( id ) ; <END> }
protected TYPE_3 ( String VAR_2 , String id ) { super ( id , TYPE_1 . class , TYPE_2 . class ) ; this . VAR_2 = VAR_2 ; }
equals 1 ? editing multiple VAR_1 allowed
private void METHOD_1 ( ) { ArrayList < TYPE_1 > VAR_1 = METHOD_2 ( ) != null ? TYPE_2 < TYPE_1 > METHOD_3 ( METHOD_2 ( ) ) : new ArrayList < TYPE_1 > ( ) ; <START> METHOD_4 ( ) . METHOD_5 ( VAR_1 . size ( ) > 0 ) ; <END> METHOD_6 ( ) . METHOD_5 ( VAR_1 . size ( ) > 0 ) ; }
private void METHOD_1 ( ) { ArrayList < TYPE_1 > VAR_1 = METHOD_2 ( ) != null ? TYPE_2 < TYPE_1 > METHOD_3 ( METHOD_2 ( ) ) : new ArrayList < TYPE_1 > ( ) ; METHOD_4 ( ) . METHOD_5 ( VAR_1 . size ( ) == 1 ) ; METHOD_6 ( ) . METHOD_5 ( VAR_1 . size ( ) > 0 ) ; }
1 need changed a new master config added
public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( VAR_1 ) ; List < TYPE_1 > VAR_3 = VAR_2 . METHOD_4 ( TYPE_2 . VAR_5 ) ; <START> assertEquals ( 1 , VAR_3 . size ( ) ) ; <END> assertEquals ( STRING_1 , VAR_3 . get ( 0 ) . getKey ( ) ) ; }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( VAR_1 ) ; List < TYPE_1 > VAR_3 = VAR_2 . METHOD_4 ( TYPE_2 . VAR_5 ) ; assertEquals ( STRING_1 , VAR_3 . get ( 0 ) . getKey ( ) ) ; }
won t return true null ? return object ? similar findbugs issue host patch
protected TYPE_1 METHOD_1 ( TYPE_1 object ) { if ( object instanceof <START> TYPE_1 ) { <END> return object ; } else { return null ; } }
protected TYPE_1 METHOD_1 ( TYPE_1 object ) { return object ; }
followup required
void METHOD_1 ( ) { TYPE_1 . get ( ) . METHOD_2 ( new TYPE_2 ( ) { @Override public boolean execute ( ) { boolean VAR_1 = VAR_2 != null ; if ( VAR_1 && VAR_3 ) { <START> METHOD_3 ( METHOD_4 ( VAR_4 ) , new TYPE_3 ( ) ) ; <END> VAR_3 = false ; } return VAR_1 ; } } , VAR_5 ) ; }
void METHOD_1 ( ) { TYPE_1 . get ( ) . METHOD_2 ( new TYPE_2 ( ) { @Override public boolean execute ( ) { boolean VAR_1 = VAR_2 != null ; if ( VAR_1 && VAR_3 ) { METHOD_3 ( METHOD_4 ( ) , new TYPE_3 ( ) ) ; VAR_3 = false ; } return VAR_1 ; } } , VAR_5 ) ; }
super ( ) spared
public TYPE_1 ( ) { <START> super ( ) ; <END> }
public TYPE_1 ( ) { }
need compare true : ( VAR_1 && VAR_2 = = null ) ;
public TYPE_1 METHOD_1 ( boolean VAR_1 , TYPE_2 VAR_2 ) { return TYPE_1 . METHOD_2 ( TYPE_3 . VAR_4 ) . when ( VAR_1 == true && VAR_2 == null ) ; <START> } <END>
public TYPE_1 METHOD_1 ( boolean VAR_1 , TYPE_2 VAR_2 ) { return TYPE_1 . METHOD_2 ( TYPE_3 . VAR_4 ) . when ( VAR_1 && VAR_2 == null ) ; }
shouldnt _CODE_ _CODE_ ( )
private void METHOD_1 ( ) { <START> if ( METHOD_2 ( ) . METHOD_3 ( ) ) { <END> VAR_1 . METHOD_4 ( VAR_2 . METHOD_5 ( ) , VAR_1 ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; METHOD_8 ( ) ; METHOD_9 ( ) ; for ( TYPE_1 VAR_3 : VAR_2 . METHOD_10 ( ) . METHOD_11 ( ) ) { VAR_4 . METHOD_12 ( new Pair < > ( VAR_1 . getId ( ) , VAR_3 ) ) ; } } }
protected void METHOD_1 ( ) { if ( VAR_2 . METHOD_5 ( ) != null ) { VAR_1 . METHOD_4 ( VAR_2 . METHOD_5 ( ) , VAR_1 ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; METHOD_8 ( ) ; METHOD_9 ( ) ; for ( TYPE_1 VAR_3 : VAR_2 . METHOD_10 ( ) . METHOD_11 ( ) ) { VAR_4 . METHOD_12 ( new Pair < > ( VAR_1 . getId ( ) , VAR_3 ) ) ; } } }
need migrate _CODE_ host operational gluster ? worth call : _CODE_ ( _CODE_ _CODE_ )
private boolean METHOD_1 ( ) { if ( ! TYPE_1 . METHOD_1 ( METHOD_2 ( ) ) ) { log . error ( STRING_1 , METHOD_2 ( ) . getName ( ) ) ; <START> METHOD_3 ( TYPE_2 . VAR_2 , METHOD_2 ( ) ) ; <END> return false ; } return true ; }
private boolean METHOD_1 ( ) { if ( ! TYPE_1 . METHOD_1 ( METHOD_2 ( ) ) ) { log . error ( STRING_1 , METHOD_2 ( ) . getName ( ) ) ; METHOD_3 ( TYPE_2 . VAR_2 ) ; return false ; } return true ; }
more standard compare enums = = ! = equals - behaves
private void METHOD_1 ( ) { if ( METHOD_2 ( ) . exists ( METHOD_3 ( ) , TYPE_8 . VAR_2 ) <START> && ! TYPE_4 . TYPE_5 . equals ( METHOD_4 ( ) ) ) { <END> log . info ( STRING_1 , METHOD_3 ( ) ) ; METHOD_5 ( TYPE_7 . TYPE_6 , new TYPE_2 ( METHOD_3 ( ) ) , TYPE_3 . METHOD_6 ( METHOD_7 ( ) , METHOD_8 ( ) ) ) ; } }
private void METHOD_1 ( ) { if ( METHOD_2 ( ) . exists ( METHOD_3 ( ) , TYPE_8 . VAR_2 ) && METHOD_4 ( ) != TYPE_4 . TYPE_5 ) { log . info ( STRING_1 , METHOD_3 ( ) ) ; METHOD_5 ( TYPE_7 . TYPE_6 , new TYPE_2 ( METHOD_3 ( ) ) , TYPE_3 . METHOD_6 ( METHOD_7 ( ) , METHOD_8 ( ) ) ) ; } }
alternatively a bit shorter : ( VAR_1 ! = null ) { VAR_2 set ( 1 VAR_1 ) ; } VAR_4 = VAR_2 ( 1 ) ;
int METHOD_1 ( TYPE_1 item , Integer VAR_1 ) { List < Integer > VAR_2 = VAR_3 . get ( item ) ; int VAR_4 ; if ( VAR_1 != null ) { VAR_2 . set ( 1 , VAR_1 ) ; <START> VAR_4 = VAR_1 ; <END> } else { VAR_4 = VAR_2 . get ( 1 ) ; } return VAR_4 ; }
int METHOD_1 ( TYPE_1 item , Integer VAR_1 ) { List < Integer > VAR_2 = VAR_3 . get ( item ) ; if ( VAR_1 != null ) { VAR_2 . set ( 1 , VAR_1 ) ; } return VAR_2 . get ( 1 ) ; }
please add - NLS : - )
private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , boolean VAR_2 ) { switch ( VAR_1 ) { case TYPE_3 : return VAR_2 ? VAR_4 . METHOD_2 ( ) : VAR_4 . METHOD_3 ( ) ; case TYPE_4 : return VAR_2 ? VAR_4 . METHOD_4 ( ) : VAR_4 . METHOD_5 ( ) ; default : <START> log . VAR_6 ( STRING_1 ) ; <END> return null ; } }
private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , boolean VAR_2 ) { switch ( VAR_1 ) { case TYPE_4 : return VAR_2 ? VAR_4 . METHOD_4 ( ) : VAR_4 . METHOD_5 ( ) ; case TYPE_3 : default : return VAR_2 ? VAR_4 . METHOD_2 ( ) : VAR_4 . METHOD_3 ( ) ; } }
needed
private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; METHOD_3 ( VAR_1 ) ; <START> return new ArrayList < > ( VAR_1 ) ; <END> }
private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; METHOD_3 ( VAR_1 ) ; return VAR_1 ; }
String valueOf ( str )
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { Guid VAR_2 = VAR_1 . METHOD_2 ( ) ; String VAR_3 = VAR_1 . METHOD_3 ( ) ; Guid VAR_4 = VAR_1 . getId ( ) ; <START> return METHOD_4 ( VAR_4 == null ? null : VAR_4 . toString ( ) , <END> VAR_2 , VAR_3 , TYPE_3 . VAR_6 , VAR_7 ) ; }
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { Guid VAR_2 = VAR_1 . METHOD_2 ( ) ; String VAR_3 = VAR_1 . METHOD_3 ( ) ; Guid VAR_4 = VAR_1 . getId ( ) ; return METHOD_4 ( String . valueOf ( VAR_4 ) , VAR_2 , VAR_3 , TYPE_3 . VAR_6 , VAR_7 ) ; }
exception attempt catch ? java doc exceptions method
public static Boolean METHOD_1 ( String val ) { if ( val == null || val . trim ( ) . length ( ) == 0 ) { return false ; } try { return Boolean . valueOf ( val ) ; <START> } catch ( Exception e ) { <END> return false ; } }
public static Boolean METHOD_1 ( String val ) { if ( val == null || val . trim ( ) . length ( ) == 0 ) { return false ; } try { return Boolean . valueOf ( val ) ; } catch ( IllegalArgumentException e ) { return false ; } }
TYPE_3 issues network connection please consider reconnect logic
private void METHOD_1 ( String message ) { TYPE_1 client = TYPE_2 . METHOD_2 ( ) ; try { client . VAR_1 ( message . VAR_2 ( ) ) ; log . error ( STRING_1 , message ) ; } catch ( TYPE_3 e ) { <START> log . error ( STRING_2 , e ) ; <END> } finally { log . debug ( STRING_3 ) ; } }
private void METHOD_1 ( String message ) { TYPE_1 client = TYPE_2 . METHOD_2 ( ) ; try { client . VAR_1 ( message . VAR_2 ( ) ) ; log . debug ( STRING_1 , message ) ; } catch ( TYPE_3 e ) { log . error ( STRING_2 , e ) ; } }
create TYPE_3 time want fire event ? please instance variable class
public void METHOD_1 ( TYPE_1 t , long VAR_1 , Object o ) { try { if ( TYPE_2 . getInstance ( ) . METHOD_2 ( ) ) { <START> TYPE_3 VAR_2 = new TYPE_3 ( ) ; <END> VAR_2 . METHOD_3 ( t , VAR_1 , o ) ; } else { TYPE_4 . getInstance ( ) . METHOD_1 ( new TYPE_5 ( t , VAR_1 , o ) ) ; } } catch ( Exception e ) { log . error ( STRING_1 , e . toString ( ) ) ; } }
public static void METHOD_1 ( TYPE_1 t , long VAR_1 , Object o ) { try { if ( TYPE_2 . getInstance ( ) . METHOD_2 ( ) ) { TYPE_3 VAR_2 = new TYPE_3 ( ) ; VAR_2 . METHOD_3 ( t , VAR_1 , o ) ; } else { TYPE_4 . getInstance ( ) . METHOD_1 ( new TYPE_5 ( t , VAR_1 , o ) ) ; } } catch ( Exception e ) { log . error ( STRING_1 , e . toString ( ) ) ; } }
need VAR_3 log error please call
private void METHOD_1 ( String message , String VAR_1 , boolean VAR_2 ) throws TYPE_1 { String VAR_3 = null ; try { TYPE_2 client = TYPE_3 . METHOD_2 ( ) . get ( VAR_1 ) ; <START> VAR_3 = client . VAR_4 ( ) ; <END> client . VAR_5 ( message . VAR_6 ( ) ) ; log . debug ( STRING_1 , message ) ; } catch ( TYPE_1 e ) { log . error ( STRING_2 , VAR_3 , e ) ; } if ( VAR_2 ) { TYPE_3 . METHOD_3 ( VAR_1 ) ; } }
private void METHOD_1 ( String message , String VAR_1 , boolean VAR_2 ) throws TYPE_1 { TYPE_2 client = null ; try { client = TYPE_3 . METHOD_2 ( ) . get ( VAR_1 ) ; client . VAR_5 ( message . VAR_6 ( ) ) ; log . debug ( STRING_1 , message ) ; } catch ( TYPE_1 e ) { log . error ( STRING_2 , client . VAR_4 ( ) , e ) ; } if ( VAR_2 ) { TYPE_3 . METHOD_3 ( VAR_1 ) ; } }
Map static single instance _CODE_ pass call instance methods
public <START> static void <END> METHOD_1 ( String VAR_1 , TYPE_1 client ) { VAR_2 . put ( VAR_1 , client ) ; }
public void METHOD_1 ( String VAR_1 , TYPE_1 client ) { VAR_2 . put ( VAR_1 , client ) ; }
lack consistency naming please fix
public synchronized static void <START> METHOD_1 ( String <END> VAR_1 , TYPE_1 client ) { VAR_2 . put ( VAR_1 , client ) ; }
public static void METHOD_1 ( String VAR_1 , TYPE_1 client ) { VAR_2 . put ( VAR_1 , client ) ; }
METHOD_3 ( METHOD_2 ( message id ) ) ;
public void METHOD_1 ( String message , String id ) { if ( message == null ) { log . warn ( STRING_1 ) ; return ; } message = METHOD_2 ( message , id ) ; <START> METHOD_3 ( message ) ; <END> }
public void METHOD_1 ( String message , String id ) { if ( message == null ) { log . warn ( STRING_1 ) ; return ; } METHOD_3 ( METHOD_2 ( message , id ) ) ; }