Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
ll generics won t need cast
protected void METHOD_1 ( String VAR_1 , TYPE_1 query ) { TYPE_2 . getInstance ( ) . METHOD_2 ( TYPE_5 . TYPE_7 , <START> new TYPE_3 ( STRING_1 + ( ( TYPE_4 ) METHOD_3 ( ) . METHOD_4 ( ) ) . METHOD_5 ( ) + STRING_2 + VAR_1 , TYPE_8 . TYPE_6 , ( String ) METHOD_6 ( ) . METHOD_4 ( ) ) , query ) ; <END> }
protected void METHOD_1 ( String VAR_1 , TYPE_1 query ) { TYPE_2 . getInstance ( ) . METHOD_2 ( TYPE_5 . TYPE_7 , new TYPE_3 ( STRING_1 + ( ( TYPE_4 ) METHOD_3 ( ) . METHOD_4 ( ) ) . METHOD_5 ( ) + STRING_2 + VAR_1 , TYPE_8 . TYPE_6 , METHOD_6 ( ) . METHOD_4 ( ) ) , query ) ; }
please remove
public List METHOD_1 ( ) { List VAR_1 = METHOD_2 ( ) ; VAR_1 . add ( STRING_1 ) ; <START> VAR_1 . add ( STRING_2 ) ; <END> VAR_1 . add ( STRING_3 ) ; VAR_1 . add ( STRING_4 ) ; VAR_1 . add ( STRING_5 ) ; VAR_1 . add ( STRING_6 ) ; VAR_1 . add ( STRING_7 ) ; VAR_1 . add ( STRING_7 ) ; VAR_1 . add ( STRING_8 ) ; VAR_1 . add ( STRING_9 ) ; VAR_1 . add ( STRING_10 ) ; return VAR_1 ; }
public List METHOD_1 ( ) { List VAR_1 = METHOD_2 ( ) ; VAR_1 . add ( STRING_1 ) ; VAR_1 . add ( STRING_3 ) ; VAR_1 . add ( STRING_4 ) ; VAR_1 . add ( STRING_5 ) ; VAR_1 . add ( STRING_6 ) ; VAR_1 . add ( STRING_7 ) ; VAR_1 . add ( STRING_7 ) ; VAR_1 . add ( STRING_8 ) ; VAR_1 . add ( STRING_9 ) ; VAR_1 . add ( STRING_10 ) ; return VAR_1 ; }
protected private
<START> protected static <END> void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 context , List < TYPE_3 > VAR_2 ) { TYPE_4 builder = new TYPE_4 ( VAR_1 , context ) ; ArrayList < TYPE_5 > parameters = builder . VAR_3 ( VAR_2 ) ; if ( ! parameters . isEmpty ( ) ) { TYPE_6 . METHOD_2 ( parameters ) ; TYPE_7 . getInstance ( ) . METHOD_3 ( TYPE_8 . TYPE_9 , parameters , context ) ; } }
private static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 context , List < TYPE_3 > VAR_2 ) { TYPE_4 builder = new TYPE_4 ( VAR_1 , context ) ; ArrayList < TYPE_5 > parameters = builder . VAR_3 ( VAR_2 ) ; if ( ! parameters . isEmpty ( ) ) { TYPE_6 . METHOD_2 ( parameters ) ; TYPE_7 . getInstance ( ) . METHOD_3 ( TYPE_8 . TYPE_9 , parameters , context ) ; } }
a model a UI infra object ( _CODE_ ) original code ( _CODE_ _CODE_ ) copy - pasted _CODE_ method refers _CODE_ I suggest remove line I don t effect
public void METHOD_1 ( ) { TYPE_1 query = new TYPE_1 ( ) ; query . VAR_1 ( true ) ; <START> query . VAR_2 ( this ) ; <END> query . VAR_3 = new TYPE_2 ( ) { @Override public void METHOD_2 ( Object model , Object TYPE_6 ) { TYPE_4 . TYPE_5 . METHOD_3 ( ) ; } } ; VAR_5 . METHOD_4 ( VAR_5 . METHOD_5 ( ) , query ) ; }
public void METHOD_1 ( ) { TYPE_1 query = new TYPE_1 ( ) ; query . VAR_1 ( true ) ; query . VAR_3 = new TYPE_2 ( ) { @Override public void METHOD_2 ( Object model , Object TYPE_6 ) { TYPE_4 . TYPE_5 . METHOD_3 ( ) ; } } ; VAR_5 . METHOD_4 ( VAR_5 . METHOD_5 ( ) , query ) ; }
shouldn t _CODE_ = TYPE_4 filter ( VAR_4 VAR_5 ) ;
private boolean METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_2 < TYPE_3 > > VAR_2 ) { List < TYPE_3 > VAR_3 = new ArrayList < TYPE_3 > ( VAR_1 . METHOD_2 ( ) ) ; List < TYPE_3 > VAR_4 = VAR_3 ; for ( TYPE_2 < TYPE_3 > VAR_5 : VAR_2 ) { <START> VAR_4 = TYPE_4 . filter ( VAR_3 , VAR_5 ) ; <END> } if ( VAR_4 . size ( ) > 0 ) { return true ; } return false ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_2 < TYPE_3 > > VAR_2 ) { List < TYPE_3 > VAR_3 = new ArrayList < TYPE_3 > ( VAR_1 . METHOD_2 ( ) ) ; List < TYPE_3 > VAR_4 = VAR_3 ; for ( TYPE_2 < TYPE_3 > VAR_5 : VAR_2 ) { VAR_4 = TYPE_4 . filter ( VAR_4 , VAR_5 ) ; } if ( VAR_4 . size ( ) > 0 ) { return true ; } return false ; }
patterns : sync { VAR_1 = ( byte [ ] ) session VAR_2 ( VAR_3 ) ; ( VAR_1 = = null ) { session VAR_6 ( VAR_3 VAR_1 ) ; } } : sync { ( session VAR_2 ( VAR_3 ) = = null ) { session VAR_6 ( VAR_3 VAR_1 ) ; } } VAR_1 = ( byte [ ] ) session VAR_2 ( VAR_3 ) ;
private String METHOD_1 ( ) { byte [ ] VAR_1 ; TYPE_1 session = METHOD_2 ( ) . METHOD_3 ( ) ; synchronized ( session ) { if ( session . VAR_2 ( VAR_3 ) == null ) { VAR_1 = new byte [ VAR_4 ] ; VAR_5 . METHOD_4 ( VAR_1 ) ; session . VAR_6 ( VAR_3 , VAR_1 ) ; } else { VAR_1 = ( byte [ ] ) session . VAR_2 ( VAR_3 ) ; <START> } <END> } return StringUtils . VAR_7 ( VAR_1 ) ; }
private String METHOD_1 ( ) { byte [ ] VAR_1 ; TYPE_1 session = METHOD_2 ( ) . METHOD_3 ( ) ; synchronized ( session ) { VAR_1 = ( byte [ ] ) session . VAR_2 ( VAR_3 ) ; if ( session . VAR_2 ( VAR_3 ) == null ) { VAR_1 = new byte [ VAR_4 ] ; VAR_5 . METHOD_4 ( VAR_1 ) ; session . VAR_6 ( VAR_3 , VAR_1 ) ; } } return StringUtils . VAR_7 ( VAR_1 ) ; }
user point view action failed restarting host s true implementing restart stop - wait - start - wait transparent user IMO log restart operation _CODE_ log _CODE_ IMO block remain change : TYPE_1 METHOD_1 ( ) { return METHOD_2 ( ) ? TYPE_1 VAR_1 : TYPE_1 VAR_4 ;
public TYPE_1 METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return TYPE_1 . VAR_1 ; <START> } else { <END> return VAR_2 ? TYPE_1 . VAR_3 : TYPE_1 . VAR_4 ; } }
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( ) ? TYPE_1 . VAR_1 : TYPE_1 . VAR_4 ; }
please change left side Collection
public void METHOD_1 ( ) { <START> ArrayList < TYPE_1 < ? > > <END> VAR_1 = new ArrayList < TYPE_1 < ? > > ( ) ; VAR_1 . add ( VAR_2 ) ; METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ; METHOD_2 ( ) . METHOD_4 ( VAR_2 ) ; }
public void METHOD_1 ( ) { Collection < TYPE_1 < ? > > VAR_1 = new ArrayList < TYPE_1 < ? > > ( ) ; VAR_1 . add ( VAR_2 ) ; METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ; METHOD_2 ( ) . METHOD_4 ( VAR_2 ) ; }
replace assertEquals
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) . get ( TYPE_2 . VAR_4 ) ; assertNotNull ( VAR_1 ) ; String name = VAR_1 . getName ( ) ; <START> assertTrue ( name . equals ( VAR_2 . METHOD_3 ( TYPE_2 . VAR_4 , TYPE_3 . TYPE_1 ) ) ) ; <END> }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) . get ( TYPE_2 . VAR_4 ) ; assertNotNull ( VAR_1 ) ; String name = VAR_1 . getName ( ) ; assertEquals ( name , VAR_2 . METHOD_3 ( TYPE_2 . VAR_4 , TYPE_3 . TYPE_1 ) ) ; }
please change equals ( )
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) != null ) { TYPE_1 cluster = METHOD_2 ( ) . METHOD_3 ( ) ; boolean VAR_1 = ( cluster . VAR_2 ( ) . METHOD_4 ( TYPE_2 . VAR_4 ) >= 0 && cluster . VAR_5 ( ) <START> . METHOD_4 ( TYPE_2 . VAR_6 ) != 0 ) ; <END> METHOD_2 ( ) . METHOD_5 ( ) . METHOD_6 ( VAR_1 ) ; } }
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) != null ) { TYPE_1 cluster = METHOD_2 ( ) . METHOD_3 ( ) ; boolean VAR_1 = ( cluster . VAR_2 ( ) . METHOD_4 ( TYPE_2 . VAR_4 ) >= 0 && cluster . VAR_5 ( ) . equals ( TYPE_2 . VAR_6 ) ) ; METHOD_2 ( ) . METHOD_5 ( ) . METHOD_6 ( VAR_1 ) ; } }
I appeared - move trenary logic insidecoco METHOD_2 ( guid )
private TYPE_1 METHOD_1 ( Guid VAR_1 , TYPE_2 VAR_2 , TYPE_3 parameters ) { <START> TYPE_1 VAR_3 = Guid . VAR_4 ( VAR_1 ) ? null : VAR_5 . METHOD_2 ( VAR_1 ) ; <END> if ( VAR_3 == null ) { VAR_3 = VAR_5 . METHOD_3 ( VAR_1 , VAR_2 , parameters ) ; if ( ! Guid . VAR_4 ( VAR_1 ) ) { VAR_3 . METHOD_4 ( TYPE_4 . VAR_7 ) ; VAR_5 . METHOD_5 ( VAR_3 ) ; } } return VAR_3 ; }
private TYPE_1 METHOD_1 ( Guid VAR_1 , TYPE_2 VAR_2 , TYPE_3 parameters ) { TYPE_1 VAR_3 = VAR_5 . METHOD_2 ( VAR_1 ) ; if ( VAR_3 == null ) { VAR_3 = VAR_5 . METHOD_3 ( VAR_1 , VAR_2 , parameters ) ; if ( ! Guid . VAR_4 ( VAR_1 ) ) { VAR_3 . METHOD_4 ( TYPE_4 . VAR_7 ) ; VAR_5 . METHOD_5 ( VAR_3 ) ; } } return VAR_3 ; }
wouldn t solution traverse values string comparisons ? private boolean METHOD_1 ( String VAR_1 ) { boolean exists = false ; { TYPE_1 valueOf ( VAR_1 ) ; exists = true ; } catch ( Exception ) { } return exists ; }
private boolean METHOD_1 ( String VAR_1 ) { <START> for ( TYPE_1 VAR_2 : TYPE_1 . values ( ) ) { <END> if ( VAR_2 . name ( ) . equals ( VAR_1 ) ) { return true ; } } return false ; }
private boolean METHOD_1 ( String VAR_1 ) { boolean exists = false ; try { TYPE_1 . valueOf ( VAR_1 ) ; exists = true ; } catch ( Exception ex ) { } return exists ; }
frontend ? shouldn t a concrete class List ? ( other place code ) GWT issues dynamic types / inheritance
<START> public List < TYPE_1 > METHOD_1 ( ) { <END> return VAR_1 ; }
public ArrayList < TYPE_1 > METHOD_1 ( ) { return VAR_1 ; }
public
<START> public void METHOD_1 ( ) { <END> TYPE_1 VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) . get ( getParameters ( ) . getId ( ) ) ; if ( VAR_1 != null ) { VAR_1 . METHOD_4 ( ) . addAll ( METHOD_2 ( ) . METHOD_3 ( ) . METHOD_5 ( VAR_1 . getId ( ) ) ) ; VAR_1 . METHOD_6 ( ) . addAll ( METHOD_2 ( ) . METHOD_3 ( ) . METHOD_7 ( VAR_1 . getId ( ) ) ) ; METHOD_8 ( ) . METHOD_9 ( VAR_1 ) ; } }
protected void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) . get ( getParameters ( ) . getId ( ) ) ; if ( VAR_1 != null ) { VAR_1 . METHOD_4 ( ) . addAll ( METHOD_2 ( ) . METHOD_3 ( ) . METHOD_5 ( VAR_1 . getId ( ) ) ) ; VAR_1 . METHOD_6 ( ) . addAll ( METHOD_2 ( ) . METHOD_3 ( ) . METHOD_7 ( VAR_1 . getId ( ) ) ) ; METHOD_8 ( ) . METHOD_9 ( VAR_1 ) ; } }
please method protected
<START> boolean METHOD_1 ( ) { <END> Boolean VAR_1 = getParameters ( ) . METHOD_1 ( ) ; return VAR_1 != null ? VAR_1 : TYPE_1 . METHOD_1 ( METHOD_2 ( ) ) ; }
protected boolean METHOD_1 ( ) { Boolean VAR_1 = getParameters ( ) . METHOD_1 ( ) ; return VAR_1 != null ? VAR_1 : TYPE_1 . METHOD_1 ( METHOD_2 ( ) ) ; }
braces removed
public void METHOD_1 ( ) { <START> if ( METHOD_2 ( ) != null ) <END> super . METHOD_1 ( ) ; }
public void METHOD_1 ( ) { if ( METHOD_2 ( ) != null ) { super . METHOD_1 ( ) ; } }
_CODE_ ( null ) ; method
private void METHOD_1 ( ) { if ( METHOD_2 ( ) == null ) { return ; } else { METHOD_3 ( null ) ; <START> } <END> }
private void METHOD_1 ( ) { METHOD_3 ( null ) ; }
need surrounding brackets
public boolean METHOD_1 ( String VAR_1 ) { <START> return ( VAR_1 != null && VAR_1 . METHOD_2 ( TYPE_1 . VAR_3 ) ) ; <END> }
public boolean METHOD_1 ( String VAR_1 ) { return VAR_1 != null && VAR_1 . METHOD_2 ( TYPE_1 . VAR_3 ) ; }
replaced : return VAR_1 ! = null && VAR_1 METHOD_2 ( TYPE_1 VAR_3 ) ;
public boolean METHOD_1 ( String VAR_1 ) { <START> return ( VAR_1 == null || ! VAR_1 . METHOD_2 ( TYPE_1 . VAR_3 ) ) ? <END> false : true ; }
public boolean METHOD_1 ( String VAR_1 ) { return ( VAR_1 != null && VAR_1 . METHOD_2 ( TYPE_1 . VAR_3 ) ) ; }
methods - static
<START> public static boolean METHOD_1 ( String VAR_1 ) { <END> return ( VAR_1 == null || ! VAR_1 . METHOD_2 ( TYPE_1 . VAR_3 ) ) ? false : true ; }
public boolean METHOD_1 ( String VAR_1 ) { return ( VAR_1 == null || ! VAR_1 . METHOD_2 ( TYPE_1 . VAR_3 ) ) ? false : true ; }
1 _CODE_ prone 2 start significant part
private static int METHOD_1 ( String VAR_1 ) { String [ ] VAR_2 = VAR_1 . split ( STRING_1 ) ; int output = 0 ; int VAR_3 ; <START> for ( int index = 3 ; index > - 1 ; index -- ) { <END> VAR_3 = Integer . parseInt ( VAR_2 [ 3 - index ] ) ; VAR_3 <<= ( index * INT_1 ) ; output |= VAR_3 ; } return output ; }
private static long METHOD_1 ( String VAR_1 ) { String [ ] VAR_2 = VAR_1 . split ( STRING_1 ) ; long output = 0 ; long VAR_3 ; for ( int index = 3 ; index > - 1 ; index -- ) { VAR_3 = Integer . parseInt ( VAR_2 [ 3 - index ] ) ; VAR_3 <<= ( index * INT_1 ) ; output |= VAR_3 ; } return output ; }
call empty c tor redundant
public TYPE_1 ( String VAR_2 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; }
public TYPE_1 ( String VAR_2 ) { this . VAR_2 = VAR_2 ; }
1 shouldn t check assert ( = = null || instanceof String ) ? 2 please add some text explaining assertion case fails ( e g validation applied a String )
public TYPE_1 METHOD_1 ( Object value ) { <START> assert value instanceof String ; <END> String VAR_1 = ( String ) value ; TYPE_1 result = new TYPE_1 ( ) ; if ( ! TYPE_2 . METHOD_2 ( VAR_1 ) ) { return METHOD_3 ( result , METHOD_4 ( ) ) ; } else if ( ! TYPE_2 . METHOD_5 ( VAR_1 ) ) { return METHOD_3 ( result , METHOD_6 ( ) ) ; } else { result . VAR_2 ( true ) ; return result ; } }
public TYPE_1 METHOD_1 ( Object value ) { assert value == null || value instanceof String ; String VAR_1 = ( String ) value ; TYPE_1 result = new TYPE_1 ( ) ; result . VAR_2 ( true ) ; if ( ! TYPE_2 . METHOD_2 ( VAR_1 ) ) { METHOD_3 ( result , METHOD_4 ( ) ) ; } else if ( ! TYPE_2 . METHOD_5 ( VAR_1 ) ) { METHOD_3 ( result , METHOD_6 ( ) ) ; } return result ; }
please trim ( ) isEmpty ( ) instead length check
public void METHOD_1 ( String VAR_1 ) { <START> this . VAR_1 = ( ( VAR_1 == null || VAR_1 . length ( ) == 0 ) ? null : VAR_1 ) ; <END> }
public void METHOD_1 ( String VAR_1 ) { this . VAR_1 = ( ( VAR_1 == null || VAR_1 . trim ( ) . isEmpty ( ) ) ? null : VAR_1 ) ; }
METHOD_4 ( )
public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( new TYPE_2 < Object > ( ) { @Override public Object METHOD_3 ( ) { <START> TYPE_3 VAR_1 = db ( ) . METHOD_4 ( ) . get ( id ) ; <END> VAR_1 . METHOD_5 ( TYPE_4 . TYPE_5 ) ; update ( VAR_1 ) ; return null ; } } ) ; }
public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( new TYPE_2 < Object > ( ) { @Override public Object METHOD_3 ( ) { TYPE_3 VAR_1 = METHOD_4 ( ) . get ( id ) ; VAR_1 . METHOD_5 ( TYPE_4 . TYPE_5 ) ; update ( VAR_1 ) ; return null ; } } ) ; }
call super METHOD_1 ( ) ;
<START> protected void METHOD_1 ( ) { <END> METHOD_2 ( TYPE_1 . VAR_2 ) ; }
protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; METHOD_2 ( TYPE_1 . VAR_2 ) ; }
_CODE_ set constructor parameters
protected boolean METHOD_1 ( ) { <START> METHOD_2 ( METHOD_3 ( ) . METHOD_4 ( ) ) ; <END> if ( ! super . METHOD_1 ( ) ) { return false ; } if ( METHOD_3 ( ) . getStatus ( ) == TYPE_1 . VAR_2 ) { return METHOD_5 ( TYPE_2 . VAR_4 ) ; } return false ; }
protected boolean METHOD_1 ( ) { if ( ! super . METHOD_1 ( ) ) { return false ; } if ( METHOD_3 ( ) . getStatus ( ) == TYPE_1 . VAR_2 ) { return METHOD_5 ( TYPE_2 . VAR_4 ) ; } return false ; }
synchronized getters lists
<START> public synchronized ArrayList METHOD_1 ( ) { <END> return VAR_1 ; }
public ArrayList METHOD_1 ( ) { return VAR_1 ; }
vm null
public Map METHOD_1 ( String VAR_1 ) { final TYPE_1 host = METHOD_2 ( ) ; Map VAR_2 = METHOD_3 ( ) ; List VAR_3 = new ArrayList ( ) ; <START> TYPE_2 vm = host . VAR_4 ( ) . get ( VAR_1 ) ; <END> VAR_3 . add ( METHOD_4 ( vm ) ) ; VAR_2 . put ( STRING_1 , VAR_3 ) ; Utils . VAR_5 ( ) ; return VAR_2 ; }
public Map METHOD_1 ( String VAR_1 ) { final TYPE_1 host = METHOD_2 ( ) ; Map VAR_2 = METHOD_3 ( ) ; List VAR_3 = new ArrayList ( ) ; TYPE_2 vm = host . VAR_4 ( ) . get ( VAR_1 ) ; if ( vm != null ) { VAR_3 . add ( METHOD_4 ( vm ) ) ; } VAR_2 . put ( STRING_1 , VAR_3 ) ; Utils . VAR_5 ( ) ; return VAR_2 ; }
good Map < String Object > remove suppressed warnings
<START> public static Map METHOD_1 ( String message , int VAR_1 ) { <END> Map VAR_2 = new HashMap ( ) ; Map VAR_3 = new HashMap ( ) ; VAR_3 . put ( STRING_1 , message ) ; VAR_3 . put ( STRING_2 , Integer . valueOf ( VAR_1 ) ) ; VAR_2 . put ( STRING_3 , VAR_3 ) ; return VAR_2 ; }
public static Map METHOD_1 ( String message , int VAR_1 ) { Map < String , Object > VAR_2 = new HashMap ( ) ; Map < String , Object > VAR_3 = new HashMap ( ) ; VAR_3 . put ( STRING_1 , message ) ; VAR_3 . put ( STRING_2 , Integer . valueOf ( VAR_1 ) ) ; VAR_2 . put ( STRING_3 , VAR_3 ) ; return VAR_2 ; }
s point asserting list isn t empty - check size line assert s null
public void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( TYPE_2 . VAR_4 , null ) ; <START> assertTrue ( STRING_1 , ! VAR_1 . isEmpty ( ) ) ; <END> assertEquals ( STRING_2 , 2 , VAR_1 . size ( ) ) ; }
public void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( TYPE_2 . VAR_4 , null ) ; assertEquals ( STRING_2 , 2 , VAR_1 . size ( ) ) ; }
a good idea perform steps client code ? implementations instance hand
public void METHOD_1 ( ) { log . info ( STRING_1 ) ; TYPE_1 . getInstance ( ) . METHOD_2 ( VAR_1 ) ; TYPE_2 . METHOD_3 ( VAR_2 . METHOD_4 ( ) ) ; <START> if ( TYPE_3 . class . METHOD_5 ( VAR_2 ) ) { <END> ( ( TYPE_3 ) VAR_2 ) . close ( ) ; } }
public void METHOD_1 ( ) { log . info ( STRING_1 ) ; TYPE_1 . getInstance ( ) . METHOD_2 ( VAR_1 ) ; VAR_2 . close ( ) ; }
I d achieve intended - Integer immutable VAR_3 + + replace passed effect function 0
<START> private void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , Integer VAR_3 ) { <END> List < Integer > VAR_4 = new ArrayList < Integer > ( ) ; for ( int j = 0 ; j < VAR_2 ; j ++ , VAR_3 ++ ) { VAR_4 . add ( VAR_3 ) ; } VAR_1 . METHOD_2 ( VAR_4 ) ; }
private Integer METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , Integer VAR_3 ) { List < Integer > VAR_4 = new ArrayList < Integer > ( ) ; for ( int j = 0 ; j < VAR_2 ; j ++ , VAR_3 ++ ) { VAR_4 . add ( VAR_3 ) ; } VAR_1 . METHOD_2 ( VAR_4 ) ; return VAR_3 ; }
VAR_3 passed I feel VAR_2 passed arg
public TYPE_1 METHOD_1 ( String VAR_1 , String VAR_2 , String VAR_3 ) { try { <START> return new TYPE_1 ( VAR_4 . METHOD_1 ( VAR_1 , VAR_3 , VAR_3 ) ) ; <END> } catch ( TYPE_2 VAR_5 ) { throw new TYPE_3 ( VAR_5 ) ; } }
public TYPE_1 METHOD_1 ( String VAR_1 , String VAR_2 , String VAR_3 ) { try { return new TYPE_1 ( VAR_4 . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 ) ) ; } catch ( TYPE_2 VAR_5 ) { throw new TYPE_3 ( VAR_5 ) ; } }
lock georep session case else case lock cluster level expected behavior
<START> protected Map < String , Pair < String , String > > METHOD_1 ( ) { <END> if ( ! METHOD_2 ( ) ) { return Collections . VAR_1 ( METHOD_3 ( ) . getId ( ) . toString ( ) , TYPE_1 . METHOD_4 ( TYPE_2 . VAR_3 , TYPE_3 . VAR_5 ) ) ; } return super . METHOD_1 ( ) ; }
protected Map < String , Pair < String , String > > METHOD_1 ( ) { if ( ! METHOD_2 ( ) ) { return Collections . VAR_1 ( METHOD_3 ( ) . getId ( ) . toString ( ) , TYPE_1 . METHOD_4 ( TYPE_2 . VAR_3 , TYPE_3 . VAR_5 ) ) ; } return null ; }
set done line 115
private TYPE_1 METHOD_1 ( ) { TYPE_1 params = new TYPE_1 ( getParameters ( ) . METHOD_2 ( ) , getParameters ( ) . METHOD_3 ( ) ) ; params . VAR_1 ( getParameters ( ) . METHOD_4 ( ) ) ; params . VAR_2 ( getParameters ( ) . METHOD_5 ( ) ) ; <START> params . VAR_1 ( getParameters ( ) . METHOD_4 ( ) ) ; <END> params . VAR_3 ( getParameters ( ) . METHOD_6 ( ) ) ; return params ; }
private TYPE_1 METHOD_1 ( ) { TYPE_1 params = new TYPE_1 ( getParameters ( ) . METHOD_2 ( ) , getParameters ( ) . METHOD_3 ( ) ) ; params . VAR_1 ( getParameters ( ) . METHOD_4 ( ) ) ; params . VAR_2 ( getParameters ( ) . METHOD_5 ( ) ) ; params . VAR_3 ( getParameters ( ) . METHOD_6 ( ) ) ; return params ; }
meanconfig = ? : )
protected TYPE_1 METHOD_1 ( ) { if ( config != null ) { <START> new TYPE_1 ( <END> ( String ) TYPE_2 . getInstance ( ) . METHOD_2 ( TYPE_4 . TYPE_3 ) , METHOD_3 ( ) ) ; } return config ; }
protected TYPE_1 METHOD_1 ( ) { if ( config != null ) { config = new TYPE_1 ( ( String ) TYPE_2 . getInstance ( ) . METHOD_2 ( TYPE_4 . TYPE_3 ) , METHOD_3 ( ) ) ; } return config ; }
user_id is_filtered parameters required
public List < TYPE_1 > METHOD_1 ( ) { <START> return METHOD_2 ( ) . METHOD_3 ( STRING_1 , VAR_1 , METHOD_4 ( ) . METHOD_5 ( STRING_2 , null ) . METHOD_5 ( STRING_3 , false ) ) ; <END> }
public List < TYPE_1 > METHOD_1 ( ) { return METHOD_2 ( ) . METHOD_3 ( STRING_1 , VAR_1 , METHOD_4 ( ) ) ; }
add ( _CODE_ class ) class ll able declaration instead initialization a matter style wish
public void METHOD_1 ( ) { <START> VAR_1 = METHOD_2 ( TYPE_1 . class ) ; <END> VAR_2 = new TYPE_2 ( VAR_1 ) ; VAR_3 = new TYPE_2 ( null ) ; }
public void METHOD_1 ( ) { VAR_2 = new TYPE_2 ( VAR_1 ) ; VAR_3 = new TYPE_2 ( null ) ; }
a parameter caching validator doesn t sense - API pass a TYPE_2 a validator practice ll validator param
protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> if ( VAR_2 == null ) { <END> TYPE_3 VAR_3 = METHOD_2 ( ) . METHOD_3 ( VAR_1 . METHOD_4 ( ) . get ( 0 ) , VAR_1 . METHOD_5 ( ) ) ; VAR_2 = new TYPE_1 ( VAR_3 ) ; } return VAR_2 ; }
protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 VAR_3 = METHOD_2 ( ) . METHOD_3 ( VAR_1 . METHOD_4 ( ) . get ( 0 ) , VAR_1 . METHOD_5 ( ) ) ; return new TYPE_1 ( VAR_3 ) ; }
replace code withreturn METHOD_2 ( METHOD_3 ( ) METHOD_1 ( ) )
private boolean METHOD_1 ( ) { <START> if ( ! METHOD_2 ( METHOD_3 ( ) . METHOD_1 ( ) ) ) { <END> return false ; } return true ; }
private boolean METHOD_1 ( ) { return ( METHOD_2 ( METHOD_3 ( ) . METHOD_1 ( ) ) ) ; }
please define row
public void METHOD_1 ( ) throws IOException { <START> String VAR_1 = null ; <END> VAR_1 = TYPE_1 . METHOD_2 ( STRING_1 , null ) ; assertTrue ( STRING_2 , VAR_1 . equals ( STRING_3 ) ) ; }
public void METHOD_1 ( ) throws IOException { String VAR_1 = TYPE_1 . METHOD_2 ( STRING_1 , null ) ; assertTrue ( STRING_2 , VAR_1 . equals ( STRING_3 ) ) ; }
drop toString ( )
private static void METHOD_1 ( ) { TYPE_1 [ ] values = TYPE_1 . values ( ) ; if ( values . length != VAR_1 . size ( ) ) { for ( TYPE_1 value : values ) { if ( ! VAR_1 . containsKey ( value ) ) { <START> log . info ( STRING_1 , value . toString ( ) ) ; <END> } } } }
private static void METHOD_1 ( ) { TYPE_1 [ ] values = TYPE_1 . values ( ) ; if ( values . length != VAR_1 . size ( ) ) { for ( TYPE_1 value : values ) { if ( ! VAR_1 . containsKey ( value ) ) { log . info ( STRING_1 , value ) ; } } } }
instead manually invoking VAR_4 METHOD_6 ( ) _CODE_ implement _CODE_ interface implementation : * widget s DOM element set ID * execute code METHOD_6 ( need separate method ) manually invoking VAR_4 METHOD_6 ( ) wouldn t needed anymore _CODE_ _CODE_ ( ) called part METHOD_5 ( )
public TYPE_8 ( TYPE_1 < TYPE_2 , TYPE_3 > VAR_2 , TYPE_4 VAR_3 ) { super ( VAR_2 ) ; this . VAR_4 = new TYPE_5 ( VAR_2 , VAR_3 ) ; VAR_5 = TYPE_6 . METHOD_1 ( ) ; METHOD_2 ( TYPE_7 . VAR_7 . METHOD_3 ( this ) ) ; METHOD_4 ( ) ; METHOD_5 ( ) ; <START> this . VAR_4 . METHOD_6 ( ) ; <END> }
public TYPE_8 ( TYPE_1 < TYPE_2 , TYPE_3 > VAR_2 , TYPE_4 VAR_3 ) { super ( VAR_2 ) ; this . VAR_4 = new TYPE_5 ( VAR_2 , VAR_3 ) ; VAR_5 = TYPE_6 . METHOD_1 ( ) ; METHOD_2 ( TYPE_7 . VAR_7 . METHOD_3 ( this ) ) ; METHOD_4 ( ) ; METHOD_5 ( ) ; }
stack trace level message
public static TYPE_1 map ( TYPE_2 entity , TYPE_1 VAR_1 ) { try { return TYPE_1 . valueOf ( entity ) ; } catch ( IllegalArgumentException e ) { log . error ( STRING_1 , entity , TYPE_1 . class . getName ( ) , e . getMessage ( ) ) ; <START> log . debug ( STRING_2 , e ) ; <END> return null ; } }
public static TYPE_1 map ( TYPE_2 entity , TYPE_1 VAR_1 ) { try { return TYPE_1 . valueOf ( entity ) ; } catch ( IllegalArgumentException e ) { log . error ( STRING_1 , entity , TYPE_1 . class . getName ( ) , e . getMessage ( ) ) ; log . error ( STRING_2 , e ) ; return null ; } }
please consider a method overloading case volume
public void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; for ( TYPE_1 cluster : VAR_1 ) { <START> METHOD_4 ( cluster , null ) ; <END> } }
public void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; for ( TYPE_1 cluster : VAR_1 ) { METHOD_4 ( cluster ) ; } }
s need result attribute : int METHOD_1 ( ) { return TYPE_1 METHOD_1 ( id ) ; }
public int METHOD_1 ( ) { int result = TYPE_1 . METHOD_1 ( id ) ; <START> return result ; <END> }
public int METHOD_1 ( ) { return TYPE_1 . METHOD_1 ( id ) ; }
repeated
public boolean equals ( Object obj ) { if ( this == obj ) <START> return true ; <END> if ( this == obj ) { return true ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return TYPE_2 . equals ( VAR_2 , VAR_1 . VAR_2 ) && TYPE_2 . equals ( VAR_3 , VAR_1 . VAR_3 ) ; }
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return TYPE_2 . equals ( VAR_2 , VAR_1 . VAR_2 ) && TYPE_2 . equals ( VAR_3 , VAR_1 . VAR_3 ) ; }
remove TYPE_2 getInstance ( ) METHOD_2 return METHOD_3
public String METHOD_1 ( int VAR_1 , TYPE_1 version ) { <START> return TYPE_2 . getInstance ( ) . METHOD_2 ( METHOD_3 ( VAR_2 . get ( VAR_1 ) , STRING_1 , version ) ) ; <END> }
public String METHOD_1 ( int VAR_1 , TYPE_1 version ) { return METHOD_3 ( VAR_2 . get ( VAR_1 ) , STRING_1 , version ) ; }
shared ? ? need private
<START> protected void METHOD_1 ( TYPE_1 VAR_1 ) { <END> if ( StringUtils . isEmpty ( VAR_1 . METHOD_2 ( ) ) && METHOD_3 ( ) . METHOD_4 ( ) > 0 ) { VAR_1 . METHOD_5 ( METHOD_3 ( ) . METHOD_6 ( ) ) ; } }
private void METHOD_1 ( TYPE_1 VAR_1 ) { if ( StringUtils . isEmpty ( VAR_1 . METHOD_2 ( ) ) && METHOD_3 ( ) . METHOD_4 ( ) > 0 ) { VAR_1 . METHOD_5 ( METHOD_3 ( ) . METHOD_6 ( ) ) ; } }
please remove METHOD_1
public TYPE_7 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 , TYPE_4 VAR_5 , TYPE_5 VAR_6 ) { super ( VAR_2 , VAR_3 ) ; this . VAR_5 = VAR_5 ; this . VAR_4 = VAR_4 ; this . VAR_6 = VAR_6 ; <START> METHOD_1 ( ) ; <END> METHOD_2 ( TYPE_6 . VAR_8 . METHOD_3 ( this ) ) ; TYPE_8 . VAR_10 . METHOD_4 ( this ) ; METHOD_5 ( ) ; VAR_11 . METHOD_6 ( this ) ; METHOD_7 ( VAR_4 . METHOD_8 ( ) ) ; }
public TYPE_7 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 , TYPE_4 VAR_5 , TYPE_5 VAR_6 ) { super ( VAR_2 , VAR_3 ) ; this . VAR_5 = VAR_5 ; this . VAR_4 = VAR_4 ; this . VAR_6 = VAR_6 ; METHOD_2 ( TYPE_6 . VAR_8 . METHOD_3 ( this ) ) ; TYPE_8 . VAR_10 . METHOD_4 ( this ) ; METHOD_5 ( ) ; VAR_11 . METHOD_6 ( this ) ; METHOD_7 ( VAR_4 . METHOD_8 ( ) ) ; }
converter effect
public void METHOD_1 ( TYPE_1 VAR_1 , Guid VAR_2 ) { VAR_1 . VAR_3 = new TYPE_2 ( ) { @Override public Object METHOD_2 ( Object source , TYPE_1 VAR_4 ) { <START> return source != null ? source : null ; <END> } } ; TYPE_3 . getInstance ( ) . METHOD_3 ( TYPE_5 . TYPE_6 , new TYPE_4 ( VAR_2 ) , VAR_1 ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 , Guid VAR_2 ) { VAR_1 . VAR_3 = new TYPE_2 ( ) { @Override public Object METHOD_2 ( Object source , TYPE_1 VAR_4 ) { return source ; } } ; TYPE_3 . getInstance ( ) . METHOD_3 ( TYPE_5 . TYPE_6 , new TYPE_4 ( VAR_2 ) , VAR_1 ) ; }
please declaration boolean VAR_1 = true ;
private void METHOD_1 ( ) { boolean VAR_1 = true ; if ( METHOD_2 ( ) == null || METHOD_2 ( ) . getStatus ( ) == TYPE_1 . VAR_3 ) { VAR_1 = false ; } METHOD_3 ( ) . METHOD_4 ( VAR_1 ) ; <START> boolean VAR_4 = false ; <END> if ( METHOD_2 ( ) != null && METHOD_2 ( ) . getStatus ( ) == TYPE_1 . VAR_5 && METHOD_2 ( ) . METHOD_5 ( ) ) { VAR_4 = true ; } METHOD_6 ( ) . METHOD_4 ( VAR_4 ) ; }
private void METHOD_1 ( ) { boolean VAR_1 = true ; boolean VAR_4 = false ; if ( METHOD_2 ( ) == null || METHOD_2 ( ) . getStatus ( ) == TYPE_1 . VAR_3 ) { VAR_1 = false ; } if ( METHOD_2 ( ) != null && METHOD_2 ( ) . getStatus ( ) == TYPE_1 . VAR_5 && METHOD_2 ( ) . METHOD_5 ( ) ) { VAR_4 = true ; } METHOD_3 ( ) . METHOD_4 ( VAR_1 ) ; METHOD_6 ( ) . METHOD_4 ( VAR_4 ) ; }
View METHOD_1 ( model ) add new listeners model object responsibility presenter - example _CODE_ : void init ( final TYPE_1 model ) { super init ( model ) ; model VAR_3 ( ) METHOD_4 ( ) METHOD_5 ( ) ; } View METHOD_1 ( ) responsible populating UI model data potentially called multiple times model listener registration doesn t belong _CODE_ init ( model ) method override
public void METHOD_1 ( final TYPE_1 object ) { VAR_1 . METHOD_1 ( object ) ; VAR_2 . METHOD_2 ( object . VAR_3 ( ) . METHOD_3 ( ) ) ; <START> object . VAR_3 ( ) . METHOD_4 ( ) . METHOD_5 ( new TYPE_2 < TYPE_3 > ( ) { <END> @Override public void METHOD_6 ( TYPE_4 < ? extends TYPE_3 > VAR_4 , Object VAR_5 , TYPE_3 args ) { VAR_2 . METHOD_2 ( object . VAR_3 ( ) . METHOD_3 ( ) ) ; } } ) ; }
public void METHOD_1 ( final TYPE_1 object ) { VAR_1 . METHOD_1 ( object ) ; VAR_2 . METHOD_2 ( object . VAR_3 ( ) . METHOD_3 ( ) ) ; }
please remove
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { <START> METHOD_2 ( ) ; <END> if ( VAR_1 != null && VAR_1 . METHOD_3 ( ) ) { METHOD_4 ( null ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { if ( VAR_1 != null && VAR_1 . METHOD_3 ( ) ) { METHOD_4 ( null ) ; } }
VAR_2 parameter irrelevant test checks input valid prefix format
public void METHOD_1 ( ) { assertEquals ( STRING_1 + VAR_1 , <START> VAR_2 && VAR_3 , TYPE_1 . getInstance ( ) . METHOD_2 ( VAR_1 ) ) ; <END> }
public void METHOD_1 ( ) { assertEquals ( STRING_1 + VAR_1 , VAR_3 , TYPE_1 . getInstance ( ) . METHOD_2 ( VAR_1 ) ) ; }
opinion test case useless - s verify valid a human eye
public static Collection < Object [ ] > data ( ) { return Arrays . asList ( new Object [ ] [ ] { { STRING_1 , INT_1 } , { STRING_2 , INT_2 } , { STRING_3 , INT_3 } , { STRING_4 , INT_4 } , { STRING_5 , INT_5 } , <START> { STRING_6 , INT_6 } , <END> { STRING_7 , INT_7 } , { STRING_2 , INT_2 } , } ) ; }
public static Collection < Object [ ] > data ( ) { return Arrays . asList ( new Object [ ] [ ] { { STRING_1 , INT_1 } , { STRING_2 , INT_2 } , { STRING_3 , INT_3 } , { STRING_4 , INT_4 } , { STRING_5 , INT_5 } , { STRING_7 , INT_7 } , { STRING_2 , INT_2 } , } ) ; }
written - critical consider set ( ensure making a mistake adding UUID - i add copy )
public Collection < Guid > METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = Collections . VAR_2 ( ) ; } <START> return new ArrayList < Guid > ( VAR_1 ) ; <END> }
public Collection < Guid > METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = Collections . VAR_2 ( ) ; } return new HashSet < Guid > ( VAR_1 ) ; }
final method
<START> protected void METHOD_1 ( TYPE_1 ... VAR_1 ) { <END> for ( TYPE_1 msg : VAR_1 ) { METHOD_2 ( msg ) ; } }
protected final void METHOD_1 ( TYPE_1 ... VAR_1 ) { for ( TYPE_1 msg : VAR_1 ) { METHOD_2 ( msg ) ; } }
s / TYPE_3 VAR_4 / VAR_4 / : - )
public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { <START> VAR_1 . METHOD_2 ( TYPE_3 . VAR_4 , <END> String . valueOf ( VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ) ) ; }
public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { VAR_1 . METHOD_2 ( VAR_4 , String . valueOf ( VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ) ) ; }
please method private
<START> protected void METHOD_1 ( ArrayList < TYPE_1 > VAR_1 ) { <END> if ( METHOD_2 ( VAR_1 ) ) { if ( VAR_2 ) { METHOD_3 ( ) ; } else { METHOD_1 ( ) ; } } }
private void METHOD_1 ( ArrayList < TYPE_1 > VAR_1 ) { if ( METHOD_2 ( VAR_1 ) ) { if ( VAR_2 ) { METHOD_3 ( ) ; } else { METHOD_1 ( ) ; } } }
mac domain ? changable
private void METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) . METHOD_3 ( ) ; TYPE_2 VAR_2 = ( TYPE_2 ) METHOD_4 ( ) . METHOD_3 ( ) ; TYPE_3 vds = new TYPE_3 ( ) ; if ( VAR_1 != null && VAR_2 != null ) { <START> vds . VAR_3 ( VAR_1 . getName ( ) + STRING_1 + VAR_2 . METHOD_5 ( ) ) ; <END> vds . VAR_4 ( VAR_1 . METHOD_6 ( ) ) ; } METHOD_7 ( vds , null , false , null ) ; }
private void METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) . METHOD_3 ( ) ; TYPE_2 VAR_2 = ( TYPE_2 ) METHOD_4 ( ) . METHOD_3 ( ) ; TYPE_3 vds = new TYPE_3 ( ) ; if ( VAR_1 != null && VAR_2 != null ) { vds . VAR_3 ( VAR_1 . getName ( ) ) ; vds . VAR_4 ( VAR_1 . getName ( ) + STRING_1 + VAR_2 . METHOD_5 ( ) ) ; } METHOD_7 ( vds , null , false , null ) ; }
required checking null view
private void METHOD_1 ( ) { METHOD_2 ( new TYPE_1 < String > ( ) ) ; METHOD_3 ( new TYPE_1 < String > ( ) ) ; METHOD_4 ( new TYPE_1 < String > ( ) ) ; METHOD_5 ( new TYPE_1 < Boolean > ( ) ) ; <START> METHOD_6 ( "" ) ; <END> METHOD_7 ( ) . METHOD_8 ( false ) ; }
private void METHOD_1 ( ) { METHOD_2 ( new TYPE_1 < String > ( ) ) ; METHOD_3 ( new TYPE_1 < String > ( ) ) ; METHOD_4 ( new TYPE_1 < String > ( ) ) ; METHOD_5 ( new TYPE_1 < Boolean > ( ) ) ; METHOD_7 ( ) . METHOD_8 ( false ) ; }
required ? bind automatically
public void METHOD_1 ( final TYPE_1 object ) { VAR_1 . METHOD_1 ( object ) ; <START> VAR_2 . METHOD_2 ( object . VAR_3 ( ) == null ? VAR_4 . METHOD_3 ( ) : object . getMessage ( ) ) ; <END> VAR_5 . setText ( object . getMessage ( ) == null ? VAR_4 . METHOD_3 ( ) : object . getMessage ( ) ) ; }
public void METHOD_1 ( final TYPE_1 object ) { VAR_1 . METHOD_1 ( object ) ; }
1 error failure engine time stamp 2 failure touch base engine essentially subsequent commands fail s asking user intervention nature attempting proceed normal flow snapshot creation 3 1 2 I feel handling failure manually code atleast order close other previous window ( : snapshot create window ) opine
public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> VAR_1 . METHOD_2 ( true ) ; <END> TYPE_2 . getInstance ( ) . METHOD_3 ( TYPE_4 . TYPE_5 , new TYPE_3 ( ) , VAR_1 ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 . getInstance ( ) . METHOD_3 ( TYPE_4 . TYPE_5 , new TYPE_3 ( ) , VAR_1 ) ; }
static modifier
<START> private static List < String > METHOD_1 ( ) { <END> return Arrays . asList ( TYPE_2 < String > getValue ( TYPE_3 . TYPE_1 ) . split ( STRING_1 ) ) ; }
private List < String > METHOD_1 ( ) { return Arrays . asList ( TYPE_2 < String > getValue ( TYPE_3 . TYPE_1 ) . split ( STRING_1 ) ) ; }
vds getStatus ( ) = = TYPE_3 TYPE_4
private void METHOD_1 ( ) { TYPE_1 vds = METHOD_2 ( ) ; <START> METHOD_3 ( ) . METHOD_4 ( TYPE_3 . TYPE_4 . equals ( vds . getStatus ( ) ) ) ; <END> }
private void METHOD_1 ( ) { TYPE_1 vds = METHOD_2 ( ) ; METHOD_3 ( ) . METHOD_4 ( vds . getStatus ( ) == TYPE_3 . TYPE_4 ) ; }
instead METHOD_4 - ctor
private void METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; if ( VAR_2 != null ) { TYPE_2 VAR_3 = new TYPE_2 ( METHOD_3 ( VAR_1 , false ) ) ; <START> VAR_3 . METHOD_4 ( VAR_1 ) ; <END> VAR_2 . VAR_4 . put ( VAR_5 , METHOD_5 ( ) . METHOD_6 ( ) . METHOD_7 ( VAR_3 ) ) ; } }
private void METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; if ( VAR_2 != null ) { VAR_2 . VAR_4 . put ( VAR_5 , METHOD_5 ( ) . METHOD_6 ( ) . METHOD_7 ( new TYPE_2 ( METHOD_3 ( VAR_1 , false ) , VAR_1 ) ) ) ; } }
assignment ? ? importance case sensitivity
private TYPE_1 METHOD_1 ( String VAR_1 ) { <START> VAR_1 . METHOD_2 ( ) ; <END> boolean VAR_2 = TYPE_2 . matcher ( VAR_1 ) . METHOD_3 ( ) ; if ( ! VAR_2 ) { return new TYPE_1 ( false , STRING_1 + VAR_1 + STRING_2 ) ; } else { return new TYPE_1 ( true ) ; } }
private TYPE_1 METHOD_1 ( String VAR_1 ) { boolean VAR_2 = TYPE_2 . matcher ( VAR_1 ) . METHOD_3 ( ) ; if ( ! VAR_2 ) { return new TYPE_1 ( false , STRING_1 + VAR_1 + STRING_2 ) ; } else { return new TYPE_1 ( true ) ; } }
private
protected void <START> METHOD_1 ( ) <END> { List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; for ( TYPE_1 VAR_2 : VAR_1 ) { if ( VAR_2 . METHOD_3 ( ) != null ) { METHOD_4 ( VAR_2 . METHOD_3 ( ) ) ; } } }
private void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; for ( TYPE_1 VAR_2 : VAR_1 ) { if ( VAR_2 . METHOD_3 ( ) != null ) { METHOD_4 ( VAR_2 . METHOD_3 ( ) ) ; } } }
/ s / METHOD_15 / _CODE_ ( ) i check reside METHOD_9 ( ) method
protected boolean METHOD_1 ( ) { return METHOD_2 ( ) && METHOD_3 ( ) && METHOD_4 ( ) && METHOD_5 ( ) && METHOD_6 ( ) && METHOD_7 ( ) && METHOD_8 ( ) && METHOD_9 ( ) && METHOD_10 ( ) && METHOD_11 ( ) && METHOD_12 ( ) && METHOD_13 ( ) && METHOD_14 ( ) <START> && METHOD_15 ( ) ; <END> }
protected boolean METHOD_1 ( ) { return METHOD_2 ( ) && METHOD_3 ( ) && METHOD_4 ( ) && METHOD_5 ( ) && METHOD_6 ( ) && METHOD_7 ( ) && METHOD_8 ( ) && METHOD_9 ( ) && METHOD_10 ( ) && METHOD_11 ( ) && METHOD_12 ( ) && METHOD_13 ( ) && METHOD_14 ( ) ; }
else redundant - unwrap ( project s style )
protected boolean METHOD_1 ( ) { if ( getParameters ( ) . METHOD_2 ( ) . isEmpty ( ) ) { return METHOD_3 ( TYPE_1 . VAR_2 ) ; <START> } else { <END> return METHOD_4 ( ) ; } }
protected boolean METHOD_1 ( ) { if ( getParameters ( ) . METHOD_2 ( ) . isEmpty ( ) ) { return METHOD_3 ( TYPE_1 . VAR_2 ) ; } return METHOD_4 ( ) ; }
t completely remove VAR_1 ? unsued
public void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; <END> assertEquals ( true , VAR_1 . METHOD_3 ( ) ) ; when ( VAR_4 . get ( VAR_2 ) ) . METHOD_4 ( METHOD_5 ( ) ) ; TYPE_2 parameters = METHOD_6 ( ) ; parameters . VAR_5 ( ) . METHOD_7 ( true ) ; METHOD_8 ( parameters , Collections . VAR_6 ( METHOD_9 ( TYPE_6 . TYPE_5 ) ) ) ; TYPE_3 . METHOD_10 ( command , TYPE_4 . VAR_10 ) ; }
public void METHOD_1 ( ) { when ( VAR_4 . get ( VAR_2 ) ) . METHOD_4 ( METHOD_5 ( ) ) ; TYPE_2 parameters = METHOD_6 ( ) ; parameters . VAR_5 ( ) . METHOD_7 ( true ) ; METHOD_8 ( parameters , Collections . VAR_6 ( METHOD_9 ( TYPE_6 . TYPE_5 ) ) ) ; TYPE_3 . METHOD_10 ( command , TYPE_4 . VAR_10 ) ; }
I : 1 put a separate method 2 create a METHOD_2 network returned _CODE_ - doesn t reflect proper behavior ll return null a network shouldn t happen real - life scenarios 3 METHOD_2 _CODE_ ( a separate method ) - - sync functionality tested _CODE_ necessary test
private void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = Collections . VAR_2 ( VAR_3 ) ; TYPE_2 VAR_4 = METHOD_2 ( TYPE_2 . class ) ; when ( VAR_4 . METHOD_3 ( VAR_5 ) ) . METHOD_4 ( VAR_1 ) ; when ( METHOD_5 ( ) . METHOD_6 ( ) ) . METHOD_4 ( VAR_4 ) ; <START> TYPE_3 VAR_6 = METHOD_2 ( TYPE_3 . class ) ; <END> when ( METHOD_5 ( ) . METHOD_7 ( ) ) . METHOD_4 ( VAR_6 ) ; }
private void METHOD_1 ( ) { when ( METHOD_5 ( ) . METHOD_6 ( ) ) . METHOD_4 ( VAR_4 ) ; List < TYPE_1 > VAR_1 = Collections . VAR_2 ( VAR_3 ) ; when ( VAR_4 . METHOD_3 ( VAR_5 ) ) . METHOD_4 ( VAR_1 ) ; }
consider explaining change commit message extract another patch
public boolean METHOD_1 ( ) { <START> if ( getMessage ( ) . startsWith ( VAR_1 ) || getMessage ( ) . startsWith ( VAR_2 ) ) { <END> return true ; } else { return false ; } }
public boolean METHOD_1 ( ) { if ( getMessage ( ) . startsWith ( VAR_1 ) ) { return true ; } else { return false ; } }
reverse order conditions importance ? { ( bridge host id ) { return bridge ; } _CODE_ = METHOD_3 ( ) ; return }
private static String METHOD_1 ( TYPE_1 vds , Map < String , Map < String , Object > > VAR_1 ) { final String VAR_2 = TYPE_2 . METHOD_2 ( vds ) ; final TYPE_3 VAR_3 = METHOD_3 ( vds , VAR_2 ) ; String VAR_4 = ( VAR_3 == null ) ? null : VAR_3 . getName ( ) ; <START> final String VAR_5 = METHOD_4 ( VAR_2 , VAR_1 ) ; <END> if ( VAR_5 != null ) { VAR_4 = VAR_5 ; } return VAR_4 ; }
private static String METHOD_1 ( TYPE_1 vds , Map < String , Map < String , Object > > VAR_1 ) { final String VAR_2 = TYPE_2 . METHOD_2 ( vds ) ; final String VAR_5 = METHOD_4 ( VAR_2 , VAR_1 ) ; if ( VAR_5 != null ) { return VAR_5 ; } final TYPE_3 VAR_3 = METHOD_3 ( vds , VAR_2 ) ; String VAR_4 = ( VAR_3 == null ) ? null : VAR_3 . getName ( ) ; return VAR_4 ; }
yikes new ArrayList < > ( METHOD_2 ( ) )
private List < TYPE_1 > METHOD_1 ( ) { <START> List < TYPE_1 > VAR_1 = ( ArrayList ) METHOD_2 ( ) . METHOD_3 ( ) ; <END> ArrayList < Guid > VAR_2 = new ArrayList < > ( ) ; for ( TYPE_1 VAR_3 : VAR_1 ) { VAR_3 . METHOD_4 ( VAR_2 ) ; } return VAR_1 ; }
private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < > ( METHOD_2 ( ) ) ; ArrayList < Guid > VAR_2 = new ArrayList < > ( ) ; for ( TYPE_1 VAR_3 : VAR_1 ) { VAR_3 . METHOD_4 ( VAR_2 ) ; } return VAR_1 ; }
remove
public int METHOD_1 ( ) { final int VAR_1 = INT_1 ; int result = 1 ; result = VAR_1 * result + VAR_2 . METHOD_1 ( ) ; <START> result = VAR_1 * result + VAR_3 . METHOD_1 ( ) ; <END> result = VAR_1 * result + super . METHOD_1 ( ) ; return result ; }
public int METHOD_1 ( ) { final int VAR_1 = INT_1 ; int result = 1 ; result = VAR_1 * result + VAR_2 . METHOD_1 ( ) ; result = VAR_1 * result + super . METHOD_1 ( ) ; return result ; }
VAR_1 considered object equality
public boolean equals ( Object obj ) { return obj != null && obj instanceof TYPE_1 && TYPE_2 . METHOD_1 ( getId ( ) , ( ( TYPE_1 ) obj ) . getId ( ) ) <START> && TYPE_2 . METHOD_2 ( VAR_1 , <END> ( ( TYPE_1 ) obj ) . METHOD_3 ( ) ) && super . equals ( obj ) ; }
public boolean equals ( Object obj ) { return obj != null && obj instanceof TYPE_1 && TYPE_2 . METHOD_1 ( getId ( ) , ( ( TYPE_1 ) obj ) . getId ( ) ) && super . equals ( obj ) ; }
apply default formatter
public void METHOD_1 ( List < TYPE_1 > VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; List < TYPE_1 > VAR_3 = new ArrayList < > ( ) ; for ( TYPE_1 VAR_4 : VAR_1 ) <START> if ( METHOD_2 ( VAR_4 . METHOD_3 ( ) , VAR_4 . METHOD_4 ( ) ) == null ) <END> VAR_2 . add ( VAR_4 ) ; else VAR_3 . add ( VAR_4 ) ; METHOD_5 ( VAR_2 ) ; METHOD_6 ( VAR_3 ) ; }
public void METHOD_1 ( List < TYPE_1 > VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; List < TYPE_1 > VAR_3 = new ArrayList < > ( ) ; for ( TYPE_1 VAR_4 : VAR_1 ) { if ( METHOD_2 ( VAR_4 . METHOD_3 ( ) , VAR_4 . METHOD_4 ( ) ) == null ) { VAR_2 . add ( VAR_4 ) ; } else { VAR_3 . add ( VAR_4 ) ; } } METHOD_5 ( VAR_2 ) ; METHOD_6 ( VAR_3 ) ; }
default standard curly braces
public TYPE_1 METHOD_1 ( ) { <START> if ( METHOD_2 ( ) ) <END> return TYPE_1 . VAR_1 ; else return VAR_2 == null ? TYPE_1 . VAR_3 : VAR_2 ; }
public TYPE_1 METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return TYPE_1 . VAR_1 ; } else { return VAR_2 == null ? TYPE_1 . VAR_3 : VAR_2 ; } }
shouldn t _CODE_ set constructor
protected boolean METHOD_1 ( ) { <START> METHOD_2 ( METHOD_3 ( ) . METHOD_4 ( ) ) ; <END> return super . METHOD_1 ( ) ; }
protected boolean METHOD_1 ( ) { return super . METHOD_1 ( ) ; }
code style give formatting error line statement curly braces
private void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 model = ( TYPE_2 ) METHOD_2 ( ) ; model . VAR_2 ( ) ; if ( VAR_1 != null <START> && VAR_1 . METHOD_3 ( ) ) <END> METHOD_4 ( null ) ; }
private void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 model = ( TYPE_2 ) METHOD_2 ( ) ; model . VAR_2 ( ) ; if ( VAR_1 != null && VAR_1 . METHOD_3 ( ) ) { METHOD_4 ( null ) ; } }
prefix redundant
protected boolean METHOD_1 ( ) { String VAR_1 = ( String ) <START> this . entry . get ( STRING_1 ) ; <END> return VAR_1 != null && STRING_2 . equalsIgnoreCase ( VAR_1 ) ; }
protected boolean METHOD_1 ( ) { return STRING_2 . equalsIgnoreCase ( ( String ) entry . get ( STRING_1 ) ) ; }
TYPE_3 enum - compared = =
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { <START> if ( VAR_1 . METHOD_2 ( ) && VAR_2 . METHOD_3 ( ) . equals ( TYPE_3 . VAR_4 ) ) { <END> return false ; } return true ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { if ( VAR_1 . METHOD_2 ( ) && VAR_2 . METHOD_3 ( ) == TYPE_3 . VAR_4 ) { return false ; } return true ; }
prefix required getters
public Guid getId ( ) { <START> return this . id ; <END> }
public Guid getId ( ) { return id ; }
expected arg actual arg
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( VAR_3 ) ; assertNotNull ( STRING_1 , VAR_1 ) ; <START> assertEquals ( STRING_2 , VAR_1 . getId ( ) , VAR_3 ) ; <END> VAR_1 = VAR_2 . METHOD_2 ( VAR_4 ) ; METHOD_3 ( VAR_1 ) ; }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( VAR_3 ) ; assertNotNull ( STRING_1 , VAR_1 ) ; assertEquals ( STRING_2 , VAR_3 , VAR_1 . getId ( ) ) ; VAR_1 = VAR_2 . METHOD_2 ( VAR_4 ) ; METHOD_3 ( VAR_1 ) ; }
s a matter styling written : return METHOD_2 ( ) ? TYPE_1 VAR_1 : TYPE_1 VAR_2 ;
public TYPE_1 METHOD_1 ( ) { <START> if ( METHOD_2 ( ) ) { <END> return TYPE_1 . VAR_1 ; } else { return TYPE_1 . VAR_2 ; } }
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( ) ? TYPE_1 . VAR_1 : TYPE_1 . VAR_2 ; }
method ( ) private
<START> protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { <END> return ( VAR_1 . getStatus ( ) == TYPE_4 . TYPE_2 || VAR_1 . METHOD_2 ( ) == TYPE_5 . TYPE_3 ) ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return ( VAR_1 . getStatus ( ) == TYPE_4 . TYPE_2 || VAR_1 . METHOD_2 ( ) == TYPE_5 . TYPE_3 ) ; }
style - move @Override annotation a separate line
<START> @Override protected void METHOD_1 ( ) { <END> if ( getParameters ( ) . METHOD_2 ( ) != null ) { METHOD_3 ( ) . METHOD_4 ( TYPE_1 . METHOD_5 ( getParameters ( ) . METHOD_2 ( ) ) ) ; } }
protected void METHOD_1 ( ) { if ( getParameters ( ) . METHOD_2 ( ) != null ) { METHOD_3 ( ) . METHOD_4 ( TYPE_1 . METHOD_5 ( getParameters ( ) . METHOD_2 ( ) ) ) ; } }
good check server side perform refresh specific provided
TYPE_1 METHOD_1 ( ) { TYPE_1 builder = METHOD_2 ( ) ; <START> builder . VAR_1 ( VAR_2 , STRING_1 ) ; <END> return builder ; }
TYPE_1 METHOD_1 ( ) { return METHOD_2 ( ) ; }
suggestion : return TYPE_1 ! VAR_2 - default return VAR_5 I s validator extended future adding additional validations easier modify
public TYPE_1 METHOD_1 ( TYPE_2 cluster , TYPE_3 VAR_1 ) { TYPE_3 . TYPE_5 source = VAR_1 . METHOD_2 ( ) ; boolean VAR_2 = cluster != null && METHOD_3 ( cluster . VAR_3 ( ) ) && cluster . VAR_4 ( ) . contains ( source ) ; if ( VAR_2 ) { return TYPE_1 . VAR_5 ; } <START> return new TYPE_1 ( TYPE_6 . VAR_7 ) ; <END> }
public TYPE_1 METHOD_1 ( TYPE_2 cluster , TYPE_3 VAR_1 ) { TYPE_3 . TYPE_5 source = VAR_1 . METHOD_2 ( ) ; boolean VAR_2 = cluster != null && METHOD_3 ( cluster . VAR_3 ( ) ) && cluster . VAR_4 ( ) . contains ( source ) ; if ( ! VAR_2 ) { return new TYPE_1 ( TYPE_6 . VAR_7 ) ; } return TYPE_1 . VAR_5 ; }
return VAR_1 ; - suffice
protected TYPE_1 METHOD_1 ( ) { <START> return this . VAR_1 ; <END> }
protected TYPE_1 METHOD_1 ( ) { return VAR_1 ; }
don t need listening role property changed event TYPE_1 METHOD_2 ( ) check isn t necessary set member ( case item wasn t form constructors _CODE_ )
public void METHOD_1 ( Boolean VAR_1 ) { if ( ! TYPE_1 . METHOD_2 ( this . VAR_1 , VAR_1 ) ) { this . VAR_1 = VAR_1 ; <START> METHOD_3 ( new TYPE_2 ( STRING_1 ) ) ; <END> } }
public void METHOD_1 ( Boolean VAR_1 ) { this . VAR_1 = VAR_1 ; }
I missed review - METHOD_1 ( ) called due ( ) ( other constructor ) calling METHOD_1 ( ) needed I guess
public TYPE_5 ( TYPE_1 VAR_2 ) { this ( VAR_2 , new TYPE_3 . TYPE_4 ( ) ) ; <START> METHOD_1 ( ) ; <END> }
public TYPE_5 ( TYPE_1 VAR_2 ) { this ( VAR_2 , new TYPE_3 . TYPE_4 ( ) ) ; }
t VAR_2 hash starters
private void METHOD_1 ( TYPE_1 response ) throws IOException { <START> for ( String VAR_1 : new HashSet < > ( VAR_2 ) ) { <END> response . VAR_3 ( STRING_1 , VAR_1 ) ; } response . VAR_4 ( TYPE_1 . VAR_5 ) ; }
private void METHOD_1 ( TYPE_1 response ) throws IOException { for ( String VAR_1 : VAR_2 ) { response . VAR_3 ( STRING_1 , VAR_1 ) ; } response . VAR_4 ( TYPE_1 . VAR_5 ) ; }
apply a formatting style eclipse
public TYPE_1 METHOD_1 ( ) { <START> if ( METHOD_2 ( ) ) <END> return TYPE_1 . VAR_1 ; else return TYPE_1 . VAR_2 ; }
public TYPE_1 METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return TYPE_1 . VAR_1 ; } else { return TYPE_1 . VAR_2 ; } }
combination : METHOD_1 ( false ) ;
<START> public void METHOD_1 ( String value ) { <END> if ( value == null ) { METHOD_2 ( ) ; } if ( value . isEmpty ( ) ) { return ; } METHOD_1 ( value , false ) ; }
public void METHOD_1 ( String value ) { METHOD_1 ( value , false ) ; }
places call method check a duplicate key don t check
private void METHOD_1 ( T VAR_1 ) { String VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; if ( VAR_2 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } <START> if ( VAR_4 . containsKey ( VAR_1 ) ) { <END> throw new IllegalArgumentException ( STRING_2 + VAR_2 ) ; } final TYPE_1 VAR_5 = METHOD_3 ( VAR_1 ) ; VAR_4 . put ( VAR_1 , VAR_5 ) ; }
private void METHOD_1 ( T VAR_1 ) { String VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; if ( VAR_2 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } final TYPE_1 VAR_5 = METHOD_3 ( VAR_1 ) ; VAR_4 . put ( VAR_1 , VAR_5 ) ; }
VAR_2
private int METHOD_1 ( int VAR_1 ) { int row = VAR_1 / VAR_2 ; <START> return VAR_1 % INT_1 == 0 ? row - 1 : row ; <END> }
private int METHOD_1 ( int VAR_1 ) { int row = VAR_1 / VAR_2 ; return VAR_1 % VAR_2 == 0 ? row - 1 : row ; }