ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
shouldn t temp file deleted
public void execute ( TYPE_1 monitor ) throws TYPE_2 , InterruptedException { super . execute ( monitor ) ; if ( VAR_1 . length ( ) == 0 ) { VAR_1 . METHOD_1 ( ) ; METHOD_2 ( ) ; return ; } if ( this . VAR_2 && ( ! VAR_3 && ! VAR_4 && ! VAR_5 ) ) { <START> VAR_1 . METHOD_1 ( ) ; <END> METHOD_2 ( ) ; return ; } METHOD_3 ( ) ; }
public void execute ( TYPE_1 monitor ) throws TYPE_2 , InterruptedException { super . execute ( monitor ) ; if ( VAR_1 . length ( ) == 0 ) { VAR_1 . METHOD_1 ( ) ; METHOD_2 ( ) ; return ; } if ( this . VAR_2 && ( ! VAR_3 && ! VAR_4 ) ) { VAR_1 . METHOD_1 ( ) ; METHOD_2 ( ) ; return ; } METHOD_3 ( ) ; }
METHOD_1 ( Arrays asList ( cmd ) )
public TYPE_1 METHOD_1 ( TYPE_2 ... cmd ) { <START> VAR_1 . addAll ( Arrays . asList ( cmd ) ) ; <END> VAR_2 = false ; return this ; }
public TYPE_1 METHOD_1 ( TYPE_2 ... cmd ) { return METHOD_1 ( Arrays . asList ( cmd ) ) ; }
I drop parameter _CODE_ constant entire commit
byte [ ] METHOD_1 ( TYPE_1 obj , TYPE_2 VAR_1 ) throws TYPE_3 , TYPE_4 , IOException { try { <START> return VAR_1 . METHOD_1 ( VAR_2 ) ; <END> } catch ( TYPE_3 VAR_3 ) { VAR_3 . METHOD_2 ( obj ) ; throw VAR_3 ; } }
byte [ ] METHOD_1 ( TYPE_1 obj , TYPE_2 VAR_1 ) throws TYPE_3 , TYPE_4 , IOException { try { return VAR_1 . METHOD_1 ( ) ; } catch ( TYPE_3 VAR_3 ) { VAR_3 . METHOD_2 ( obj ) ; throw VAR_3 ; } }
move line 51
private String [ ] METHOD_1 ( String VAR_1 , String [ ] VAR_2 ) { int VAR_3 = VAR_2 . length ; String [ ] VAR_4 = new String [ VAR_3 + 1 ] ; System . VAR_5 ( VAR_2 , 0 , VAR_4 , 1 , VAR_3 ) ; <START> VAR_4 [ 0 ] = VAR_1 ; <END> return VAR_4 ; }
private String [ ] METHOD_1 ( String VAR_1 , String [ ] VAR_2 ) { int VAR_3 = VAR_2 . length ; String [ ] VAR_4 = new String [ VAR_3 + 1 ] ; VAR_4 [ 0 ] = VAR_1 ; System . VAR_5 ( VAR_2 , 0 , VAR_4 , 1 , VAR_3 ) ; return VAR_4 ; }
inline o
private void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( VAR_2 ) ; for ( TYPE_2 VAR_3 : VAR_1 . METHOD_3 ( ) ) { try { Object o = VAR_3 . METHOD_4 ( VAR_4 ) ; <START> VAR_5 = ( TYPE_3 ) o ; <END> } catch ( TYPE_4 e ) { TYPE_5 . log ( e ) ; } } }
private void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( VAR_2 ) ; for ( TYPE_2 VAR_3 : VAR_1 . METHOD_3 ( ) ) { try { VAR_5 = ( TYPE_3 ) VAR_3 . METHOD_4 ( VAR_4 ) ; } catch ( TYPE_4 e ) { TYPE_5 . log ( e ) ; } } }
please remove isEmpty ( ) check null check removed comparisons null - proof
public static int getValue ( String text ) { <START> if ( text == null || text . isEmpty ( ) || text . equals ( STRING_1 ) ) { <END> return VAR_1 ; } if ( text . equals ( STRING_2 ) ) { return VAR_2 ; } throw new IllegalArgumentException ( STRING_3 + text ) ; }
public static int getValue ( String text ) { if ( STRING_1 . equals ( text ) ) { return VAR_1 ; } if ( STRING_2 . equals ( text ) ) { return VAR_2 ; } throw new IllegalArgumentException ( STRING_3 + text ) ; }
VAR_3 removal cleaned a vector
public void METHOD_1 ( ) { if ( VAR_1 != null ) { for ( TYPE_1 child : VAR_1 ) { METHOD_2 ( child ) ; } VAR_1 = null ; VAR_2 = 0 ; } if ( VAR_3 != null ) { for ( TYPE_1 VAR_4 : VAR_3 ) { if ( VAR_4 == null ) { break ; } METHOD_2 ( VAR_4 ) ; } METHOD_3 ( ) ; <START> } <END> }
public void METHOD_1 ( ) { if ( VAR_1 != null ) { for ( TYPE_1 child : VAR_1 ) { METHOD_2 ( child ) ; } VAR_1 = null ; VAR_2 = 0 ; } for ( TYPE_1 VAR_4 : VAR_3 ) { METHOD_2 ( VAR_4 ) ; } VAR_3 . clear ( ) ; }
I don t useful organize tests regression category I d regular test VAR_1
public static TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( TYPE_3 . class . getName ( ) ) ; VAR_1 . METHOD_2 ( TYPE_4 . class ) ; VAR_1 . METHOD_2 ( TYPE_5 . class ) ; <START> <END> return VAR_1 ; }
public static TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( TYPE_3 . class . getName ( ) ) ; VAR_1 . METHOD_2 ( TYPE_4 . class ) ; return VAR_1 ; }
please bring braces
public TYPE_1 METHOD_1 ( ) { <START> if ( ! VAR_1 . isEmpty ( ) ) <END> return VAR_1 . METHOD_2 ( ) ; return VAR_2 ; }
public TYPE_1 METHOD_1 ( ) { if ( ! VAR_1 . isEmpty ( ) ) { return VAR_1 . METHOD_2 ( ) ; } return VAR_2 ; }
please bring braces
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { TYPE_2 uri ; TYPE_2 VAR_2 = METHOD_2 ( ) ; <START> if ( ! VAR_1 . METHOD_3 ( ) ) <END> uri = TYPE_3 . append ( VAR_2 , VAR_1 . toString ( ) ) ; else { uri = METHOD_4 ( VAR_1 ) ; if ( uri == null ) return ; } METHOD_5 ( uri ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { TYPE_2 uri ; TYPE_2 VAR_2 = METHOD_2 ( ) ; if ( ! VAR_1 . METHOD_3 ( ) ) { uri = TYPE_3 . append ( VAR_2 , VAR_1 . toString ( ) ) ; } else { uri = METHOD_4 ( VAR_1 ) ; if ( uri == null ) { return ; } } METHOD_5 ( uri ) ; } }
please bring braces
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { <START> if ( VAR_1 . METHOD_2 ( ) ) <END> VAR_2 . METHOD_3 ( VAR_1 ) ; else VAR_2 . METHOD_3 ( TYPE_2 . METHOD_4 ( VAR_1 , METHOD_5 ( ) ) ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { if ( VAR_1 . METHOD_2 ( ) ) { VAR_2 . METHOD_3 ( VAR_1 ) ; } else { VAR_2 . METHOD_3 ( TYPE_2 . METHOD_4 ( VAR_1 , METHOD_5 ( ) ) ) ; } } }
please bring braces
protected TYPE_1 METHOD_1 ( TYPE_2 path ) { TYPE_3 uri ; if ( ! path . VAR_1 ( ) ) { TYPE_3 VAR_2 = METHOD_2 ( ) ; uri = TYPE_4 . METHOD_3 ( ) . append ( VAR_2 , path . toString ( ) ) ; } else { uri = METHOD_4 ( path ) ; <START> if ( uri == null ) <END> return null ; } return METHOD_1 ( uri ) ; }
protected TYPE_1 METHOD_1 ( TYPE_2 path ) { TYPE_3 uri ; if ( ! path . VAR_1 ( ) ) { TYPE_3 VAR_2 = METHOD_2 ( ) ; uri = TYPE_4 . METHOD_3 ( ) . append ( VAR_2 , path . toString ( ) ) ; } else { uri = METHOD_4 ( path ) ; if ( uri == null ) { return null ; } } return METHOD_1 ( uri ) ; }
please bring braces
protected TYPE_1 METHOD_1 ( TYPE_2 uri ) { <START> if ( ! uri . VAR_1 ( ) ) <END> uri = TYPE_3 . METHOD_2 ( uri , METHOD_3 ( ) ) ; TYPE_1 f = TYPE_4 . METHOD_4 ( uri , VAR_2 ) ; if ( f != null && f . VAR_3 ( ) ) return f ; return null ; }
protected TYPE_1 METHOD_1 ( TYPE_2 uri ) { if ( ! uri . VAR_1 ( ) ) { uri = TYPE_3 . METHOD_2 ( uri , METHOD_3 ( ) ) ; } TYPE_1 f = TYPE_4 . METHOD_4 ( uri , VAR_2 ) ; if ( f != null && f . VAR_3 ( ) ) { return f ; } return null ; }
please bring braces
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . add ( VAR_1 ) ; VAR_3 . METHOD_2 ( VAR_1 ) ; <START> if ( VAR_1 . VAR_4 == TYPE_2 . VAR_6 ) <END> VAR_7 = true ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . add ( VAR_1 ) ; VAR_3 . METHOD_2 ( VAR_1 ) ; if ( VAR_1 . VAR_4 == TYPE_2 . VAR_6 ) { VAR_7 = true ; } }
please bring braces
public void METHOD_1 ( ) throws IOException { <START> if ( outputStream != null ) <END> outputStream . VAR_1 ( ) ; }
public void METHOD_1 ( ) throws IOException { if ( outputStream != null ) { outputStream . VAR_1 ( ) ; } }
please bring braces
private TYPE_1 METHOD_1 ( TYPE_2 path ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; String VAR_2 = path . toString ( ) ; <START> if ( path . VAR_3 ( ) && VAR_2 . METHOD_3 ( 0 ) != TYPE_2 . VAR_4 ) <END> VAR_2 = TYPE_2 . VAR_4 + VAR_2 ; return TYPE_3 . METHOD_4 ( ) . METHOD_5 ( VAR_1 , VAR_2 ) ; }
private TYPE_1 METHOD_1 ( TYPE_2 path ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; String VAR_2 = path . toString ( ) ; if ( path . VAR_3 ( ) && VAR_2 . METHOD_3 ( 0 ) != TYPE_2 . VAR_4 ) { VAR_2 = TYPE_2 . VAR_4 + VAR_2 ; } return TYPE_3 . METHOD_4 ( ) . METHOD_5 ( VAR_1 , VAR_2 ) ; }
new String [ VAR_1 size ( ) ]
public static String [ ] METHOD_1 ( ) { <START> return VAR_1 . keySet ( ) . METHOD_2 ( new String [ 0 ] ) ; <END> }
public static String [ ] METHOD_1 ( ) { return VAR_1 . keySet ( ) . METHOD_2 ( new String [ VAR_1 . size ( ) ] ) ; }
restore spaces
public static String [ ] METHOD_1 ( ) { <START> if ( VAR_1 == null ) { <END> return VAR_2 . keySet ( ) . METHOD_2 ( new String [ 0 ] ) ; } return VAR_1 . METHOD_2 ( new String [ 0 ] ) ; }
public static String [ ] METHOD_1 ( ) { if ( VAR_1 == null ) { return VAR_2 . keySet ( ) . METHOD_2 ( new String [ VAR_2 . size ( ) ] ) ; } return VAR_1 . METHOD_2 ( new String [ VAR_1 . size ( ) ] ) ; }
I d prefer remove field feels a bit unclean a field valid execute method a local variable execute passed argument _CODE_
public boolean METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; <START> return VAR_1 != null && METHOD_3 ( VAR_1 ) ; <END> }
public boolean METHOD_1 ( ) { final TYPE_1 repo = METHOD_2 ( ) ; return repo != null && METHOD_3 ( repo ) ; }
_CODE_ print ( VAR_3 ) ; loop deal part string < = 100
public static void trace ( String VAR_1 , String message , Throwable VAR_2 ) { String VAR_3 = message ; while ( VAR_3 . length ( ) > 100 ) { String VAR_4 = VAR_3 . substring ( 0 , 100 ) ; VAR_3 = VAR_3 . substring ( 100 ) ; System . out . println ( VAR_4 + STRING_1 ) ; <START> } <END> if ( VAR_5 != null ) { VAR_5 . trace ( VAR_1 , message , VAR_2 ) ; } }
public static void trace ( String VAR_1 , String message , Throwable VAR_2 ) { String VAR_3 = message ; while ( VAR_3 . length ( ) > 100 ) { String VAR_4 = VAR_3 . substring ( 0 , 100 ) ; VAR_3 = VAR_3 . substring ( 100 ) ; System . out . println ( VAR_4 + STRING_1 ) ; } System . out . println ( VAR_3 ) ; if ( VAR_5 != null ) { VAR_5 . trace ( VAR_1 , message , VAR_2 ) ; } }
remove done plugin start ( ) method
public TYPE_5 ( TYPE_1 VAR_2 ) { VAR_3 = VAR_2 ; VAR_4 = new TYPE_2 ( ) ; <START> new TYPE_3 ( TYPE_4 . METHOD_1 ( ) ) ; <END> }
public TYPE_5 ( TYPE_1 VAR_2 ) { VAR_3 = VAR_2 ; VAR_4 = new TYPE_2 ( ) ; }
changed wrong : ) loop METHOD_1 ( )
public static void trace ( String VAR_1 , String message , Throwable VAR_2 ) { String VAR_3 = message ; while ( VAR_3 . length ( ) > 100 ) { String VAR_4 = VAR_3 . substring ( 0 , 100 ) ; VAR_3 = VAR_3 . substring ( 100 ) ; System . out . METHOD_1 ( VAR_4 + STRING_1 ) ; } <START> System . out . println ( VAR_3 ) ; <END> if ( VAR_5 != null ) { VAR_5 . trace ( VAR_1 , message , VAR_2 ) ; } }
public static void trace ( String VAR_1 , String message , Throwable VAR_2 ) { String VAR_3 = message ; while ( VAR_3 . length ( ) > 100 ) { String VAR_4 = VAR_3 . substring ( 0 , 100 ) ; VAR_3 = VAR_3 . substring ( 100 ) ; System . out . println ( VAR_4 + STRING_1 ) ; } System . out . METHOD_1 ( VAR_3 ) ; if ( VAR_5 != null ) { VAR_5 . trace ( VAR_1 , message , VAR_2 ) ; } }
style : don t curly braces single line statements
public TYPE_1 METHOD_1 ( boolean VAR_1 ) { METHOD_2 ( ) ; <START> if ( VAR_1 ) { <END> VAR_2 = TYPE_2 . VAR_4 ; } else { VAR_2 = TYPE_2 . VAR_5 ; } return this ; }
public TYPE_1 METHOD_1 ( boolean VAR_1 ) { METHOD_2 ( ) ; VAR_2 = VAR_1 ? TYPE_2 . VAR_4 : TYPE_2 . VAR_5 ; return this ; }
Exception thrown developing a change required throws clause isn t need proposed patch I expected reviewed change proposing removed change
<START> private String METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) throws TYPE_2 { <END> String VAR_3 = VAR_1 . METHOD_1 ( VAR_2 ) ; if ( VAR_3 == null ) { return null ; } VAR_3 = VAR_3 . trim ( ) ; if ( VAR_3 . length ( ) == 0 ) { return null ; } return VAR_3 ; }
private String METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { String VAR_3 = VAR_1 . METHOD_1 ( VAR_2 ) ; if ( VAR_3 == null ) { return null ; } VAR_3 = VAR_3 . trim ( ) ; if ( VAR_3 . length ( ) == 0 ) { return null ; } return VAR_3 ; }
invoke object toString ( )
public String METHOD_1 ( Object object ) { <START> return "" + object ; <END> }
public String METHOD_1 ( Object object ) { return object . toString ( ) ; }
private
<START> public String getKey ( ) { <END> return key ; }
String getKey ( ) { return key ; }
curly braces aren t required
private void METHOD_1 ( ) throws IOException , TYPE_1 { <START> if ( VAR_1 == null ) { <END> METHOD_2 ( ) ; } }
private void METHOD_1 ( ) throws IOException , TYPE_1 { if ( VAR_1 == null ) METHOD_2 ( ) ; }
sense ? I didn t bare repositories index VAR_1 METHOD_2 ( ) throw exception point VAR_1 _CODE_ ( ) throws exception bare repositories called TYPE_3 read
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws IOException { TYPE_1 VAR_2 = new TYPE_1 ( VAR_1 ) ; try { TYPE_3 index = VAR_1 . METHOD_2 ( ) ; VAR_2 . METHOD_3 ( new TYPE_4 ( index ) ) ; <START> if ( VAR_1 . METHOD_4 ( ) ) <END> VAR_2 . METHOD_5 ( new TYPE_4 ( index ) ) ; else VAR_2 . VAR_3 = true ; } catch ( IOException e ) { VAR_2 . METHOD_6 ( ) ; throw e ; } return VAR_2 ; }
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws IOException { TYPE_1 VAR_2 = new TYPE_1 ( VAR_1 ) ; try { TYPE_3 index = VAR_1 . METHOD_2 ( ) ; VAR_2 . METHOD_3 ( new TYPE_4 ( index ) ) ; VAR_2 . VAR_3 = true ; } catch ( IOException e ) { VAR_2 . METHOD_6 ( ) ; throw e ; } return VAR_2 ; }
toString ( ) isn t necessary + call
public String toString ( ) { <START> return STRING_1 + command . toString ( ) + STRING_2 + VAR_1 + STRING_3 ; <END> }
public String toString ( ) { return STRING_1 + command + STRING_2 + VAR_1 + STRING_3 ; }
alternatively : Arrays VAR_2 ( new Object [ ] { command VAR_3 } ) ;
public int METHOD_1 ( ) { int VAR_1 = 1 ; VAR_1 = VAR_1 * INT_1 + command . VAR_2 ( ) ; VAR_1 = VAR_1 * INT_1 + VAR_3 . METHOD_1 ( ) ; <START> return VAR_1 ; <END> }
public int METHOD_1 ( ) { return Arrays . VAR_2 ( new Object [ ] { command , VAR_3 } ) ; }
include cmd message
private void METHOD_1 ( String VAR_1 , List < TYPE_1 > VAR_2 ) throws IOException { write ( STRING_1 + VAR_1 ) ; for ( TYPE_1 cmd : VAR_2 ) { switch ( cmd . VAR_3 ( ) ) { case VAR_4 : write ( STRING_2 + cmd . VAR_5 ( ) ) ; break ; case VAR_6 : write ( STRING_3 + cmd . VAR_5 ( ) ) ; break ; default : <START> throw new IllegalArgumentException ( ) ; <END> } } }
private void METHOD_1 ( String VAR_1 , List < TYPE_1 > VAR_2 ) throws IOException { write ( STRING_1 + VAR_1 ) ; for ( TYPE_1 cmd : VAR_2 ) { switch ( cmd . VAR_3 ( ) ) { case VAR_4 : write ( STRING_2 + cmd . VAR_5 ( ) ) ; break ; case VAR_6 : write ( STRING_3 + cmd . VAR_5 ( ) ) ; break ; default : throw new IllegalArgumentException ( cmd . toString ( ) ) ; } } }
unnecessary booleans default false
TYPE_2 ( TYPE_1 VAR_2 ) { super ( VAR_2 ) ; <START> VAR_3 = false ; <END> }
TYPE_2 ( TYPE_1 VAR_2 ) { super ( VAR_2 ) ; }
method overrides _CODE_ METHOD_1 ( ) don t super METHOD_1 ( ) METHOD_1 widgets classes added _CODE_
<START> public void METHOD_1 ( ) { <END> VAR_1 . METHOD_1 ( ) ; VAR_2 . METHOD_1 ( ) ; VAR_3 . METHOD_1 ( ) ; VAR_4 . METHOD_1 ( ) ; }
public void METHOD_1 ( ) { VAR_1 . METHOD_1 ( ) ; VAR_2 . METHOD_1 ( ) ; VAR_3 . METHOD_1 ( ) ; VAR_4 . METHOD_1 ( ) ; super . METHOD_1 ( ) ; }
synchronized
<START> public void METHOD_1 ( int VAR_1 ) { <END> VAR_2 = VAR_1 ; }
public synchronized void METHOD_1 ( int VAR_1 ) { VAR_2 = VAR_1 ; }
VAR_2 + 1
private TYPE_2 ( TYPE_1 n , int VAR_2 ) { VAR_3 = start = VAR_4 = n ; VAR_5 = VAR_2 ; <START> VAR_6 = new ArrayList < TYPE_1 > ( VAR_2 ) ; <END> }
private TYPE_2 ( TYPE_1 n , int VAR_2 ) { VAR_3 = start = VAR_4 = n ; VAR_5 = VAR_2 ; VAR_6 = new ArrayList < TYPE_1 > ( VAR_2 + 1 ) ; }
pubsub handler matches ^ / * / logic needs
public static boolean METHOD_1 ( String VAR_1 ) { <START> return VAR_1 != null && VAR_1 . METHOD_2 ( VAR_2 ) ; <END> }
public static boolean METHOD_1 ( String VAR_1 ) { return VAR_1 != null && VAR_1 . equals ( VAR_2 ) ; }
I _CODE_ NANOS _CODE_ ( System VAR_1 ( ) )
long METHOD_1 ( ) { <START> return System . VAR_1 ( ) / INT_1 ; <END> }
private long METHOD_1 ( ) { return System . VAR_1 ( ) / INT_1 ; }
private
<START> void METHOD_1 ( <END> Map < String , List < TYPE_1 > > VAR_1 , TYPE_2 output ) throws TYPE_3 , TYPE_4 , InterruptedException , IOException { connection = VAR_2 . METHOD_2 ( VAR_3 ) ; VAR_2 . METHOD_3 ( VAR_4 ) ; try { connection . VAR_5 ( VAR_3 , VAR_1 , output ) ; } finally { METHOD_4 ( ) ; } }
void METHOD_1 ( Map < String , List < TYPE_1 > > VAR_1 , TYPE_2 output ) throws TYPE_3 , TYPE_4 , InterruptedException , IOException { VAR_2 . METHOD_3 ( VAR_4 ) ; connection = VAR_2 . METHOD_2 ( VAR_3 ) ; try { connection . VAR_5 ( VAR_3 , VAR_1 , output ) ; } finally { connection . close ( ) ; connection = null ; } }
loading a chain classes potentially activating other bundles bundle startup problematic ll need find a initialize contributors lazily e g context activation
public void start ( TYPE_1 context ) throws Exception { super . start ( context ) ; VAR_1 = new TYPE_2 ( VAR_2 ) ; File VAR_3 = METHOD_1 ( ) . METHOD_2 ( ) ; if ( ! VAR_3 . exists ( ) ) { VAR_3 . METHOD_3 ( ) ; } VAR_1 . METHOD_4 ( VAR_3 ) ; VAR_4 = new TYPE_3 ( VAR_1 ) ; <START> METHOD_5 ( ) ; <END> }
public void start ( TYPE_1 context ) throws Exception { super . start ( context ) ; VAR_1 = new TYPE_2 ( VAR_2 ) ; File VAR_3 = METHOD_1 ( ) . METHOD_2 ( ) ; if ( ! VAR_3 . exists ( ) ) { VAR_3 . METHOD_3 ( ) ; } VAR_1 . METHOD_4 ( VAR_3 ) ; VAR_4 = new TYPE_3 ( VAR_1 ) ; }
TYPE_2 actaully thrown method body
protected void METHOD_1 ( <START> TYPE_1 VAR_1 ) throws TYPE_2 { <END> VAR_1 . METHOD_2 ( TYPE_3 . VAR_3 , false ) ; VAR_1 . METHOD_2 ( TYPE_3 . VAR_4 , true ) ; }
protected void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( TYPE_3 . VAR_3 , false ) ; VAR_1 . METHOD_2 ( TYPE_3 . VAR_4 , true ) ; }
please don t catch Exception code compiles fine catch want replace catch _CODE_
public String METHOD_1 ( ) { try { float res = TYPE_1 . METHOD_2 ( result ) ; if ( res > 0 ) { return STRING_1 + result ; } else { return result ; } <START> } catch ( Exception e ) { <END> return result ; } }
public String METHOD_1 ( ) { return result ; }
done constructor allow changed a debug session other areas allow a dynamic change I m worried ll a conflict tracing initialized stuff constructor moved a smart flags instance class allowed change class created
public TYPE_2 ( String name ) { super ( 1 , new TYPE_1 ( name + STRING_1 + VAR_2 ++ ) ) ; VAR_3 = name ; <START> if ( TYPE_3 . VAR_5 || VAR_6 ) { <END> METHOD_1 ( ) ; VAR_7 . put ( ( ( TYPE_1 ) METHOD_2 ( ) ) . VAR_8 , TYPE_2 . VAR_9 ) ; } }
public TYPE_2 ( String name ) { super ( 1 , new TYPE_1 ( name + STRING_1 + VAR_2 ++ ) ) ; VAR_3 = name ; if ( VAR_5 || VAR_6 ) { METHOD_1 ( ) ; VAR_7 . put ( ( ( TYPE_1 ) METHOD_2 ( ) ) . VAR_8 , TYPE_2 . VAR_9 ) ; } }
remove chedk VAR_2 part TYPE_3
public void execute ( TYPE_1 command ) { <START> if ( TYPE_3 . VAR_2 && TYPE_3 . VAR_3 && command instanceof TYPE_2 ) { <END> assert ! ( ( TYPE_2 ) command ) . METHOD_1 ( ) : STRING_1 ; ( ( TYPE_2 ) command ) . METHOD_2 ( ) ; } command . run ( ) ; }
public void execute ( TYPE_1 command ) { if ( TYPE_3 . VAR_3 && command instanceof TYPE_2 ) { assert ! ( ( TYPE_2 ) command ) . METHOD_1 ( ) : STRING_1 ; ( ( TYPE_2 ) command ) . METHOD_2 ( ) ; } command . run ( ) ; }
s TYPE_1 mentioned
public void METHOD_1 ( Class < ? > VAR_1 , Object VAR_2 ) { <START> if ( TYPE_1 . VAR_3 && TYPE_1 . VAR_4 && TYPE_1 . VAR_5 ) { <END> String msg = new TYPE_2 ( ) . format ( STRING_1 , TYPE_3 . METHOD_2 ( ) , TYPE_4 . toString ( VAR_2 ) , VAR_1 . getName ( ) , TYPE_4 . toString ( this ) , getId ( ) ) . toString ( ) ; TYPE_1 . trace ( msg ) ; } VAR_6 . put ( VAR_1 , VAR_2 ) ; }
public void METHOD_1 ( Class < ? > VAR_1 , Object VAR_2 ) { if ( TYPE_1 . VAR_5 ) { String msg = new TYPE_2 ( ) . format ( STRING_1 , TYPE_3 . METHOD_2 ( ) , TYPE_4 . toString ( VAR_2 ) , VAR_1 . getName ( ) , TYPE_4 . toString ( this ) , getId ( ) ) . toString ( ) ; TYPE_1 . trace ( msg ) ; } VAR_6 . put ( VAR_1 , VAR_2 ) ; }
s TYPE_1 mentioned
public void METHOD_1 ( Class < ? > VAR_1 ) { <START> if ( TYPE_1 . VAR_2 && TYPE_1 . VAR_3 && TYPE_1 . VAR_4 ) { <END> String msg = new TYPE_2 ( ) . format ( STRING_1 , TYPE_3 . METHOD_2 ( ) , VAR_1 . getName ( ) , TYPE_4 . toString ( this ) , getId ( ) ) . toString ( ) ; TYPE_1 . trace ( msg ) ; } VAR_5 . remove ( VAR_1 ) ; }
public void METHOD_1 ( Class < ? > VAR_1 ) { if ( TYPE_1 . VAR_4 ) { String msg = new TYPE_2 ( ) . format ( STRING_1 , TYPE_3 . METHOD_2 ( ) , VAR_1 . getName ( ) , TYPE_4 . toString ( this ) , getId ( ) ) . toString ( ) ; TYPE_1 . trace ( msg ) ; } VAR_5 . remove ( VAR_1 ) ; }
a local context instead
public double METHOD_1 ( TYPE_1 < ? > location ) { final TYPE_2 VAR_1 = ( TYPE_2 ) location ; <START> TYPE_3 iterator = TYPE_4 . METHOD_2 ( this , ctx ) ; <END> ctx . VAR_2 ( VAR_1 ) ; ctx . VAR_3 ( VAR_1 . METHOD_3 ( ) ) ; long VAR_4 = ( ( Long ) ctx . VAR_5 ( ) . METHOD_3 ( ) ) ; return ( ( double ) VAR_4 - iterator . VAR_6 ( ) ) / ( iterator . VAR_7 ( ) - iterator . VAR_6 ( ) ) ; }
public double METHOD_1 ( TYPE_1 < ? > location ) { final TYPE_2 VAR_1 = ( TYPE_2 ) location ; TYPE_3 iterator = METHOD_2 ( ) ; ctx . VAR_2 ( VAR_1 ) ; ctx . VAR_3 ( VAR_1 . METHOD_3 ( ) ) ; long VAR_4 = ( ( Long ) ctx . VAR_5 ( ) . METHOD_3 ( ) ) ; return ( ( double ) VAR_4 - iterator . VAR_6 ( ) ) / ( iterator . VAR_7 ( ) - iterator . VAR_6 ( ) ) ; }
VAR_2 [ length ] = VAR_1 havesufficed
public void METHOD_1 ( TYPE_1 VAR_1 ) { for ( int i = 0 ; i < this . VAR_2 . length ; i ++ ) { if ( this . VAR_2 [ i ] . equals ( VAR_1 ) ) return ; } int length = this . VAR_2 . length ; System . VAR_3 ( this . VAR_2 , 0 , this . VAR_2 = new TYPE_1 [ length + 1 ] , 0 , length ) ; <START> this . VAR_2 [ this . VAR_2 . length - 1 ] = VAR_1 ; <END> }
public void METHOD_1 ( TYPE_1 VAR_1 ) { for ( int i = 0 ; i < this . VAR_2 . length ; i ++ ) { if ( this . VAR_2 [ i ] . equals ( VAR_1 ) ) return ; } int length = this . VAR_2 . length ; System . VAR_3 ( this . VAR_2 , 0 , this . VAR_2 = new TYPE_1 [ length + 1 ] , 0 , length ) ; this . VAR_2 [ length ] = VAR_1 ; }
hmm I don t a getter shouldn t writing a add _CODE_ ( ) method
public void METHOD_1 ( TYPE_1 event , TYPE_2 VAR_1 ) { TYPE_3 < String > [ ] VAR_2 = METHOD_2 ( event , VAR_1 ) ; for ( TYPE_3 < String > path : VAR_2 ) <START> ++ ( METHOD_3 ( path ) . getValue ( ) . VAR_3 ) ; <END> VAR_2 = METHOD_4 ( event , VAR_1 ) ; for ( TYPE_3 < String > path : VAR_2 ) ++ ( METHOD_3 ( path ) . getValue ( ) . VAR_3 ) ; }
public void METHOD_1 ( TYPE_1 event , TYPE_2 VAR_1 ) { TYPE_3 < String > [ ] VAR_2 = METHOD_2 ( event , VAR_1 ) ; for ( TYPE_3 < String > path : VAR_2 ) { ++ ( METHOD_3 ( path ) . getValue ( ) . VAR_3 ) ; } VAR_2 = METHOD_4 ( event , VAR_1 ) ; for ( TYPE_3 < String > path : VAR_2 ) { ++ ( METHOD_3 ( path ) . getValue ( ) . VAR_3 ) ; } }
implementation transitive null elements ordered
<START> public int METHOD_1 ( TYPE_1 object ) { <END> if ( VAR_1 == null || object . VAR_2 ( ) == null ) { return 0 ; } return VAR_1 . METHOD_1 ( object . VAR_2 ( ) ) ; }
public int METHOD_1 ( TYPE_1 object ) { if ( VAR_1 == null && object . VAR_2 ( ) == null ) { return 0 ; } if ( VAR_1 == null || object . VAR_2 ( ) == null ) { return - 1 ; } return VAR_1 . METHOD_1 ( object . VAR_2 ( ) ) ; }
constructor asserts
private void METHOD_1 ( ) { <START> Assert . VAR_1 ( VAR_2 , STRING_1 ) ; <END> VAR_3 . addAll ( VAR_4 . METHOD_2 ( VAR_2 ) ) ; try { TYPE_1 VAR_5 = new TYPE_1 ( ) ; VAR_5 . METHOD_3 ( VAR_4 ) ; VAR_5 . query ( VAR_2 , null ) ; } catch ( TYPE_2 e ) { System . out . println ( e ) ; } VAR_3 . addAll ( VAR_4 . METHOD_2 ( VAR_2 ) ) ; }
private void METHOD_1 ( ) { VAR_3 . addAll ( VAR_4 . METHOD_2 ( VAR_2 ) ) ; }
querying provider implemented _CODE_ invoking query ( ) method providers
public Collection < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { Assert . VAR_2 ( VAR_1 , STRING_1 ) ; <START> VAR_3 . addAll ( new TYPE_3 ( ) . METHOD_2 ( ( ( TYPE_4 ) VAR_1 ) . METHOD_3 ( ) . METHOD_4 ( ) ) ) ; <END> return VAR_3 ; }
public Collection < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { return VAR_3 ; }
I check places VAR_1 null ? final initialize constructor
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; <START> if ( VAR_1 != null ) { <END> VAR_1 . METHOD_1 ( ) ; } TYPE_1 . METHOD_2 ( ) ; }
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; VAR_1 . METHOD_1 ( ) ; TYPE_1 . METHOD_2 ( ) ; }
I wondering check shouldn t caller side method
public TYPE_1 < TYPE_2 > query ( TYPE_3 < TYPE_2 > query , TYPE_4 monitor ) { <START> if ( VAR_1 == TYPE_6 . VAR_3 ) { <END> return new TYPE_5 < TYPE_2 > ( TYPE_7 < TYPE_2 > METHOD_1 ( ) ) ; } else { return super . query ( query , monitor ) ; } }
public TYPE_1 < TYPE_2 > query ( TYPE_3 < TYPE_2 > query , TYPE_4 monitor ) { if ( VAR_1 == Boolean . VAR_3 ) { return new TYPE_5 < TYPE_2 > ( TYPE_7 < TYPE_2 > METHOD_1 ( ) ) ; } else { return super . query ( query , monitor ) ; } }
missing
void METHOD_1 ( boolean VAR_1 ) { if ( VAR_1 ) VAR_2 |= VAR_3 ; else <START> VAR_2 &= VAR_3 ; <END> }
void METHOD_1 ( boolean VAR_1 ) { if ( VAR_1 ) VAR_2 |= VAR_3 ; else VAR_2 &= ~ VAR_3 ; }
I m thought : throw exception a conversion function i e normalize scale = 0 drop precision
public TYPE_2 ( final TYPE_1 VAR_2 ) { super ( VAR_2 . getValue ( ) , 0 , 0 ) ; <START> if ( VAR_2 . METHOD_1 ( ) != 0 || VAR_2 . METHOD_2 ( ) != 0 ) { <END> throw new IllegalArgumentException ( ) ; } }
public TYPE_2 ( final TYPE_1 VAR_2 ) { super ( VAR_2 . getValue ( ) , 0 , 0 ) ; }
spacing wrong ctrl + shift + F part
public TYPE_1 METHOD_1 ( double VAR_1 ) { TYPE_2 context = new TYPE_2 ( this ) ; final long VAR_2 = this . METHOD_2 ( ) . getValue ( ) ; final long start = this . METHOD_3 ( ) . getValue ( ) ; final long VAR_3 = VAR_2 - start ; final TYPE_3 VAR_4 = new TYPE_3 ( ( long ) ( VAR_3 * VAR_1 ) + start ) ; <START> context . VAR_5 ( VAR_4 . getValue ( ) ) ; <END> context . VAR_6 ( TYPE_1 . VAR_7 ) ; return context ; }
public TYPE_1 METHOD_1 ( double VAR_1 ) { TYPE_2 context = new TYPE_2 ( this ) ; final long VAR_2 = this . METHOD_2 ( ) . getValue ( ) ; final long start = this . METHOD_3 ( ) . getValue ( ) ; final long VAR_3 = VAR_2 - start ; final long VAR_4 = ( long ) ( VAR_3 * VAR_1 ) + start ; context . VAR_5 ( VAR_4 ) ; context . VAR_6 ( TYPE_1 . VAR_7 ) ; return context ; }
don t need check STRING_2 I doubt TYPE_4 - exlanatory enough investigate fix
private void METHOD_1 ( TYPE_1 result , TYPE_2 configuration ) { String value = METHOD_2 ( configuration . VAR_1 ( STRING_1 ) ) ; if ( value == null ) { return ; } <START> if ( value . startsWith ( STRING_2 ) ) { <END> throw new RuntimeException ( STRING_3 ) ; } try { TYPE_3 . METHOD_3 ( value ) ; } catch ( TYPE_4 e ) { throw new RuntimeException ( STRING_4 + value ) ; } result . VAR_2 ( value ) ; }
private void METHOD_1 ( TYPE_1 result , TYPE_2 configuration ) { String value = METHOD_2 ( configuration . VAR_1 ( STRING_1 ) ) ; if ( value == null ) { return ; } try { TYPE_3 . METHOD_3 ( value ) ; } catch ( TYPE_4 e ) { throw new RuntimeException ( STRING_4 + value ) ; } result . VAR_2 ( value ) ; }
data a _CODE_ s cast a Map s require
public void METHOD_1 ( TYPE_1 config , String VAR_1 , Object data ) { <START> TYPE_2 < String , String > parameters = ( TYPE_2 < String , String > ) data ; <END> String VAR_2 = parameters . get ( TYPE_3 . VAR_4 ) ; String VAR_5 = parameters . get ( TYPE_3 . VAR_6 ) ; if ( VAR_2 == null ) { VAR_2 = "" ; } if ( VAR_5 == null ) { VAR_5 = "" ; } METHOD_2 ( VAR_2 ) ; METHOD_3 ( VAR_5 ) ; }
public void METHOD_1 ( TYPE_1 config , String VAR_1 , Object data ) { Map < String , String > parameters = ( Map < String , String > ) data ; String VAR_2 = parameters . get ( TYPE_3 . VAR_4 ) ; String VAR_5 = parameters . get ( TYPE_3 . VAR_6 ) ; if ( VAR_2 == null ) { VAR_2 = "" ; } if ( VAR_5 == null ) { VAR_5 = "" ; } METHOD_2 ( VAR_2 ) ; METHOD_3 ( VAR_5 ) ; }
cast Map < String String >
public void METHOD_1 ( TYPE_1 config , String VAR_1 , Object data ) { <START> TYPE_2 < String , String > parameters = ( TYPE_2 < String , String > ) data ; <END> String VAR_2 = parameters . get ( TYPE_3 . VAR_4 ) ; String VAR_5 = parameters . get ( TYPE_3 . VAR_6 ) ; if ( VAR_2 == null ) { VAR_2 = "" ; } if ( VAR_5 == null ) { VAR_5 = "" ; } METHOD_2 ( VAR_5 ) ; METHOD_3 ( VAR_2 ) ; }
public void METHOD_1 ( TYPE_1 config , String VAR_1 , Object data ) { Map < String , String > parameters = ( Map < String , String > ) data ; String VAR_2 = parameters . get ( TYPE_3 . VAR_4 ) ; String VAR_5 = parameters . get ( TYPE_3 . VAR_6 ) ; if ( VAR_2 == null ) { VAR_2 = "" ; } if ( VAR_5 == null ) { VAR_5 = "" ; } METHOD_2 ( VAR_5 ) ; METHOD_3 ( VAR_2 ) ; }
style : don t braces single line blocks
public String METHOD_1 ( ) { String text = METHOD_2 ( ) ; text = Utils . VAR_1 ( text ) ; <START> if ( METHOD_3 ( ) ) { <END> text = METHOD_4 ( text ) ; } return text ; }
public String METHOD_1 ( ) { String text = METHOD_2 ( ) ; text = Utils . VAR_1 ( text ) ; if ( METHOD_3 ( ) ) text = METHOD_4 ( text ) ; return text ; }
style : don t braces single line blocks
public void METHOD_1 ( ) { <START> if ( ! METHOD_2 ( TYPE_1 . VAR_2 ) ) { <END> return ; } super . METHOD_1 ( ) ; }
public void METHOD_1 ( ) { if ( ! METHOD_2 ( TYPE_1 . VAR_2 ) ) return ; super . METHOD_1 ( ) ; }
check needed ? omit allow others create a packaging type - eclipse - target - definition example includes additional steps default lifecycle
public void execute ( ) throws TYPE_1 , TYPE_2 { if ( ! TYPE_3 . equals ( project . VAR_1 ( ) ) ) { throw new TYPE_1 ( STRING_1 <START> + TYPE_3 + STRING_2 ) ; <END> } File VAR_2 = new File ( project . VAR_3 ( ) , project . VAR_4 ( ) + VAR_5 ) ; if ( ! VAR_2 . METHOD_1 ( ) ) { throw new TYPE_1 ( STRING_3 + VAR_2 . METHOD_2 ( ) + STRING_4 ) ; } project . VAR_6 ( ) . METHOD_3 ( VAR_2 ) ; }
public void execute ( ) throws TYPE_1 , TYPE_2 { File VAR_2 = new File ( project . VAR_3 ( ) , project . VAR_4 ( ) + VAR_5 ) ; if ( ! VAR_2 . METHOD_1 ( ) ) { throw new TYPE_1 ( STRING_3 + VAR_2 . METHOD_2 ( ) + STRING_4 ) ; } project . VAR_6 ( ) . METHOD_3 ( VAR_2 ) ; }
don t need change method signature I leave method private
<START> protected TYPE_1 METHOD_1 ( TYPE_1 e ) { <END> TYPE_1 VAR_1 = new TYPE_1 ( e . VAR_2 ( ) , e . VAR_3 ( ) ) ; VAR_1 . METHOD_2 ( e . VAR_4 ( ) ) ; VAR_1 . METHOD_3 ( e . VAR_5 ( ) ) ; VAR_1 . METHOD_4 ( e . VAR_6 ( ) ) ; VAR_1 . METHOD_5 ( e . VAR_7 ( ) ) ; builder . add ( VAR_1 ) ; return VAR_1 ; }
private TYPE_1 METHOD_1 ( TYPE_1 e ) { TYPE_1 VAR_1 = new TYPE_1 ( e . VAR_2 ( ) , e . VAR_3 ( ) ) ; VAR_1 . METHOD_2 ( e . VAR_4 ( ) ) ; VAR_1 . METHOD_3 ( e . VAR_5 ( ) ) ; VAR_1 . METHOD_4 ( e . VAR_6 ( ) ) ; VAR_1 . METHOD_5 ( e . VAR_7 ( ) ) ; builder . add ( VAR_1 ) ; return VAR_1 ; }
don t need change method signature I leave method private
<START> protected int METHOD_1 ( int VAR_1 , int VAR_2 , int VAR_3 ) { <END> if ( VAR_2 == VAR_3 ) return VAR_2 ; if ( VAR_1 == VAR_2 ) return ( VAR_3 == TYPE_2 . TYPE_3 . METHOD_2 ( ) ) ? VAR_2 : VAR_3 ; if ( VAR_1 == VAR_3 ) return ( VAR_2 == TYPE_2 . TYPE_3 . METHOD_2 ( ) ) ? VAR_3 : VAR_2 ; return TYPE_2 . TYPE_3 . METHOD_2 ( ) ; }
private int METHOD_1 ( int VAR_1 , int VAR_2 , int VAR_3 ) { if ( VAR_2 == VAR_3 ) return VAR_2 ; if ( VAR_1 == VAR_2 ) return ( VAR_3 == TYPE_2 . TYPE_3 . METHOD_2 ( ) ) ? VAR_2 : VAR_3 ; if ( VAR_1 == VAR_3 ) return ( VAR_2 == TYPE_2 . TYPE_3 . METHOD_2 ( ) ) ? VAR_3 : VAR_2 ; return TYPE_2 . TYPE_3 . METHOD_2 ( ) ; }
style : braces single line blocks
protected boolean METHOD_1 ( ) throws IOException { boolean VAR_1 = false ; boolean VAR_2 = false ; if ( VAR_3 == null ) { VAR_3 = METHOD_2 ( ) . METHOD_3 ( ) ; VAR_1 = true ; } VAR_2 = METHOD_4 ( METHOD_5 ( ) . METHOD_6 ( ) , VAR_4 [ 0 ] , VAR_4 [ 1 ] ) ; <START> if ( VAR_1 ) { <END> VAR_3 . METHOD_7 ( ) ; } return VAR_2 ; }
protected boolean METHOD_1 ( ) throws IOException { boolean VAR_1 = false ; boolean VAR_2 = false ; if ( VAR_3 == null ) { VAR_3 = METHOD_2 ( ) . METHOD_3 ( ) ; VAR_1 = true ; } try { VAR_2 = METHOD_4 ( METHOD_5 ( ) , VAR_4 [ 0 ] , VAR_4 [ 1 ] ) ; } finally { if ( VAR_1 ) { VAR_3 . METHOD_7 ( ) ; } } return VAR_2 ; }
invoke other constructor _CODE_ marked final
public TYPE_2 ( TYPE_1 VAR_2 , TYPE_1 task ) { <START> this . VAR_2 = VAR_2 ; <END> this . task = task ; }
public TYPE_2 ( TYPE_1 VAR_2 , TYPE_1 task ) { this ( VAR_2 , task , null ) ; }
page update VAR_1 previously active
public boolean filter ( List < ? > VAR_1 ) { if ( VAR_1 == null ) { <START> return true ; <END> } VAR_2 . METHOD_1 ( ) ; try { METHOD_2 ( ) ; List < TYPE_1 > list = ( List < TYPE_1 > ) VAR_1 ; VAR_3 = new ArrayList < TYPE_1 > ( list ) ; METHOD_3 ( VAR_4 ) ; } finally { VAR_2 . METHOD_4 ( ) ; } return true ; }
public boolean filter ( List < ? > VAR_1 ) { VAR_2 . METHOD_1 ( ) ; try { METHOD_2 ( ) ; if ( VAR_1 == null ) { VAR_3 = new ArrayList < TYPE_1 > ( ) ; } else { List < TYPE_1 > list = ( List < TYPE_1 > ) VAR_1 ; VAR_3 = new ArrayList < TYPE_1 > ( list ) ; } METHOD_3 ( VAR_4 ) ; } finally { VAR_2 . METHOD_4 ( ) ; } return true ; }
string don t need
public TYPE_1 ( ) { <START> METHOD_1 ( Messages . TYPE_2 ) ; <END> }
public TYPE_1 ( ) { }
leave protected avoid breaking people
<START> private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { <END> Collection < TYPE_3 > VAR_3 = METHOD_2 ( ) ; for ( TYPE_3 VAR_4 : VAR_3 ) { METHOD_3 ( VAR_2 , VAR_1 , VAR_4 ) ; } }
protected void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { Collection < TYPE_3 > VAR_3 = METHOD_2 ( ) ; for ( TYPE_3 VAR_4 : VAR_3 ) { METHOD_3 ( VAR_2 , VAR_1 , VAR_4 ) ; } }
alternate shouldn t repository s shallow file define alternate a shallow file null handle case _CODE_ ( ) VAR_3 = = null means empty set
private TYPE_1 METHOD_1 ( File VAR_1 ) throws IOException { final File parent = VAR_1 . METHOD_2 ( ) ; if ( TYPE_2 . METHOD_3 ( parent , VAR_2 ) ) { TYPE_2 key = TYPE_2 . METHOD_4 ( parent , VAR_2 ) ; TYPE_3 db = ( TYPE_3 ) TYPE_4 . METHOD_5 ( key ) ; return new TYPE_5 ( db ) ; } <START> TYPE_6 db = new TYPE_6 ( config , VAR_1 , null , VAR_2 , VAR_3 ) ; <END> return new TYPE_1 ( db ) ; }
private TYPE_1 METHOD_1 ( File VAR_1 ) throws IOException { final File parent = VAR_1 . METHOD_2 ( ) ; if ( TYPE_2 . METHOD_3 ( parent , VAR_2 ) ) { TYPE_2 key = TYPE_2 . METHOD_4 ( parent , VAR_2 ) ; TYPE_3 db = ( TYPE_3 ) TYPE_4 . METHOD_5 ( key ) ; return new TYPE_5 ( db ) ; } TYPE_6 db = new TYPE_6 ( config , VAR_1 , null , VAR_2 , null ) ; return new TYPE_1 ( db ) ; }
necessary
public boolean METHOD_1 ( final TYPE_1 VAR_1 , final TYPE_1 VAR_2 ) throws TYPE_2 , TYPE_3 , IOException { <START> METHOD_2 ( ) ; <END> final TYPE_4 VAR_3 = filter ; final TYPE_5 VAR_4 = VAR_5 ; try { METHOD_3 ( ) ; METHOD_4 ( ~ VAR_6 & VAR_7 ) ; filter = TYPE_4 . VAR_8 ; VAR_5 = TYPE_5 . VAR_9 ; METHOD_5 ( VAR_2 ) ; METHOD_5 ( VAR_1 ) ; return next ( ) == VAR_1 ; } finally { filter = VAR_3 ; VAR_5 = VAR_4 ; } }
public boolean METHOD_1 ( final TYPE_1 VAR_1 , final TYPE_1 VAR_2 ) throws TYPE_2 , TYPE_3 , IOException { final TYPE_4 VAR_3 = filter ; final TYPE_5 VAR_4 = VAR_5 ; try { METHOD_3 ( ) ; METHOD_4 ( ~ VAR_6 & VAR_7 ) ; filter = TYPE_4 . VAR_8 ; VAR_5 = TYPE_5 . VAR_9 ; METHOD_5 ( VAR_2 ) ; METHOD_5 ( VAR_1 ) ; return next ( ) == VAR_1 ; } finally { filter = VAR_3 ; VAR_5 = VAR_4 ; } }
necessary
public TYPE_1 next ( ) throws TYPE_2 , TYPE_3 , IOException { <START> METHOD_1 ( ) ; <END> return VAR_1 . next ( ) ; }
public TYPE_1 next ( ) throws TYPE_2 , TYPE_3 , IOException { return VAR_1 . next ( ) ; }
necessary handled METHOD_4
public TYPE_1 METHOD_1 ( final TYPE_2 id ) throws TYPE_3 , TYPE_4 , IOException { <START> METHOD_2 ( ) ; <END> TYPE_5 c = METHOD_3 ( METHOD_4 ( id ) ) ; if ( ! ( c instanceof TYPE_1 ) ) throw new TYPE_4 ( id . VAR_1 ( ) , Constants . VAR_2 ) ; return ( TYPE_1 ) c ; }
public TYPE_1 METHOD_1 ( final TYPE_2 id ) throws TYPE_3 , TYPE_4 , IOException { TYPE_5 c = METHOD_3 ( METHOD_4 ( id ) ) ; if ( ! ( c instanceof TYPE_1 ) ) throw new TYPE_4 ( id . VAR_1 ( ) , Constants . VAR_2 ) ; return ( TYPE_1 ) c ; }
catch Exception instead simplify code
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , String VAR_2 ) { TYPE_3 VAR_3 = null ; try { VAR_3 = new TYPE_3 ( VAR_1 ) ; return VAR_3 . METHOD_2 ( TYPE_4 . METHOD_3 ( VAR_2 ) ) ; <START> } catch ( TYPE_5 e ) { <END> return null ; } catch ( TYPE_6 e ) { return null ; } catch ( IOException e ) { return null ; } finally { if ( VAR_3 != null ) { VAR_3 . METHOD_4 ( ) ; } } }
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , String VAR_2 ) { TYPE_3 VAR_3 = null ; try { VAR_3 = new TYPE_3 ( VAR_1 ) ; return VAR_3 . METHOD_2 ( TYPE_4 . METHOD_3 ( VAR_2 ) ) ; } catch ( Exception e ) { return null ; } finally { if ( VAR_3 != null ) { VAR_3 . METHOD_4 ( ) ; } } }
style : braces
TYPE_1 METHOD_1 ( ) { <START> if ( VAR_1 instanceof TYPE_1 ) { <END> return ( TYPE_1 ) VAR_1 ; } return null ; }
TYPE_1 METHOD_1 ( ) { if ( VAR_1 instanceof TYPE_1 ) return ( TYPE_1 ) VAR_1 ; return null ; }
return properties ( ) containsKey ( ) call redundant
public String getProperty ( String key ) { if ( properties != null ) { <START> if ( properties . containsKey ( key ) ) { <END> return properties . get ( key ) ; } } return null ; }
public String getProperty ( String key ) { if ( properties != null ) { return properties . get ( key ) ; } return null ; }
NPE catched btu case checked ( smth ! = null ) definetely don t want ignore NPE
public void add ( final String [ ] log ) { table . VAR_1 ( ) . METHOD_1 ( ) . METHOD_2 ( new TYPE_1 ( ) { public void run ( ) { table . VAR_2 ( log ) ; try { TYPE_2 . METHOD_3 ( ) . METHOD_4 ( ) [ 0 ] . METHOD_5 ( ) . METHOD_6 ( VAR_3 ) ; } catch ( TYPE_3 VAR_4 ) { <START> } catch ( TYPE_4 VAR_5 ) { } <END> } } ) ; }
public void add ( final String [ ] log ) { table . VAR_1 ( ) . METHOD_1 ( ) . METHOD_2 ( new TYPE_1 ( ) { public void run ( ) { table . VAR_2 ( log ) ; try { TYPE_2 . METHOD_3 ( ) . METHOD_4 ( ) [ 0 ] . METHOD_5 ( ) . METHOD_6 ( VAR_3 ) ; } catch ( TYPE_3 VAR_4 ) { } } } ) ; }
done super METHOD_1 ( ) ;
public void METHOD_1 ( ) throws Exception { <START> METHOD_2 ( ) . METHOD_3 ( ) ; <END> VAR_1 = null ; VAR_2 = null ; VAR_3 = null ; VAR_4 = null ; if ( VAR_5 != null ) { VAR_5 . METHOD_4 ( ) ; VAR_5 = null ; } super . METHOD_1 ( ) ; }
public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; VAR_1 = null ; VAR_2 = null ; VAR_3 = null ; VAR_4 = null ; if ( VAR_5 != null ) { VAR_5 . METHOD_4 ( ) ; VAR_5 = null ; } }
METHOD_2 ( ) sufficient GNU extensions needed
public void METHOD_1 ( ) throws Exception { <START> METHOD_2 ( METHOD_3 ( ) , VAR_1 , true ) ; <END> }
public void METHOD_1 ( ) throws Exception { METHOD_2 ( ) ; }
change VAR_4 length 0 need change array length 0
public String [ ] METHOD_1 ( String VAR_1 , String VAR_2 ) { TYPE_1 node = TYPE_2 . METHOD_2 ( ) ; node = node . VAR_3 ( METHOD_3 ( VAR_1 ) ) ; if ( node == null ) return VAR_4 ; node = node . VAR_3 ( VAR_1 ) ; if ( node == null ) return VAR_4 ; String [ ] VAR_5 = METHOD_4 ( node , VAR_2 ) ; if ( VAR_5 . length == 0 ) <START> return VAR_4 ; <END> return VAR_5 ; }
public String [ ] METHOD_1 ( String VAR_1 , String VAR_2 ) { TYPE_1 node = TYPE_2 . METHOD_2 ( ) ; node = node . VAR_3 ( METHOD_3 ( VAR_1 ) ) ; if ( node == null ) return VAR_4 ; node = node . VAR_3 ( VAR_1 ) ; if ( node == null ) return VAR_4 ; return METHOD_4 ( node , VAR_2 ) ; }
Set < String > doesn t matter
public void METHOD_1 ( ) { <START> Collection < String > VAR_1 = VAR_2 . METHOD_2 ( ) ; <END> assertEquals ( 0 , VAR_1 . size ( ) ) ; String VAR_3 = VAR_2 . METHOD_3 ( STRING_1 ) ; METHOD_4 ( VAR_3 ) ; }
public void METHOD_1 ( ) { Set < String > VAR_1 = VAR_2 . METHOD_2 ( ) ; assertEquals ( 0 , VAR_1 . size ( ) ) ; String VAR_3 = VAR_2 . METHOD_3 ( STRING_1 ) ; METHOD_4 ( VAR_3 ) ; }
call clear disposing readers
public void METHOD_1 ( ) { for ( TYPE_1 reader : VAR_1 ) { if ( reader != null ) { reader . VAR_2 ( ) ; } <START> } <END> }
public void METHOD_1 ( ) { for ( TYPE_1 reader : VAR_1 ) { if ( reader != null ) { reader . VAR_2 ( ) ; } } VAR_1 . clear ( ) ; }
style : braces
static String METHOD_1 ( File path ) throws IOException { Path VAR_1 = path . VAR_2 ( ) ; Path target = TYPE_1 . METHOD_2 ( VAR_1 ) ; String VAR_3 = target . toString ( ) ; if ( TYPE_2 . getInstance ( ) . METHOD_3 ( ) ) VAR_3 = VAR_3 . METHOD_4 ( CHAR_1 , CHAR_2 ) ; <START> else if ( TYPE_2 . getInstance ( ) . METHOD_5 ( ) ) { <END> VAR_3 = TYPE_3 . METHOD_6 ( VAR_3 , TYPE_4 . VAR_5 ) ; } return VAR_3 ; }
static String METHOD_1 ( File path ) throws IOException { Path VAR_1 = path . VAR_2 ( ) ; Path target = TYPE_1 . METHOD_2 ( VAR_1 ) ; String VAR_3 = target . toString ( ) ; if ( TYPE_2 . getInstance ( ) . METHOD_3 ( ) ) VAR_3 = VAR_3 . METHOD_4 ( CHAR_1 , CHAR_2 ) ; else if ( TYPE_2 . getInstance ( ) . METHOD_5 ( ) ) VAR_3 = TYPE_3 . METHOD_6 ( VAR_3 , TYPE_4 . VAR_5 ) ; return VAR_3 ; }
instead delegating super class I instead override method subclass
public void METHOD_1 ( File path , boolean VAR_1 ) throws IOException { <START> super . METHOD_1 ( path , VAR_1 ) ; <END> }
public void METHOD_1 ( File path , boolean VAR_1 ) throws IOException { }
please don t print stack trace
public TYPE_4 ( TYPE_1 project ) { VAR_2 = null ; VAR_3 = false ; try { if ( project . VAR_4 ( VAR_5 ) ) { TYPE_2 VAR_6 = ( TYPE_2 ) project . VAR_7 ( TYPE_2 . class ) ; uri = VAR_6 . METHOD_1 ( ) ; } else { uri = project . VAR_8 ( ) ; } VAR_9 = System . getProperty ( STRING_1 , STRING_2 ) ; } catch ( TYPE_3 e ) { <START> e . VAR_10 ( ) ; <END> } }
public TYPE_4 ( TYPE_1 project ) { VAR_2 = null ; VAR_3 = false ; try { if ( project . VAR_4 ( Messages . VAR_5 ) ) { TYPE_2 VAR_6 = ( TYPE_2 ) project . VAR_7 ( TYPE_2 . class ) ; uri = VAR_6 . METHOD_1 ( ) ; } else { uri = project . VAR_8 ( ) ; } VAR_9 = System . getProperty ( STRING_1 , STRING_2 ) ; } catch ( TYPE_3 e ) { uri = project . VAR_8 ( ) ; } }
adhere coding style file multiple return statements
private String METHOD_1 ( ) { if ( TYPE_1 . METHOD_2 ( METHOD_3 ( ) ) ) { return STRING_1 + METHOD_3 ( ) ; } return "" ; <START> } <END>
private String METHOD_1 ( ) { String description = "" ; if ( TYPE_1 . METHOD_2 ( METHOD_3 ( ) ) ) { description = STRING_1 + METHOD_3 ( ) ; } return description ; }
style : braces single line blocks
public static int METHOD_1 ( String message , String VAR_1 ) { String [ ] VAR_2 = message . split ( VAR_1 ) ; int VAR_3 = METHOD_2 ( VAR_2 ) ; if ( VAR_3 == VAR_2 . length ) return - 1 ; int VAR_4 = 0 ; <START> for ( int i = 0 ; i < VAR_3 ; ++ i ) { <END> VAR_4 += VAR_2 [ i ] . length ( ) + VAR_1 . length ( ) ; } return message . VAR_5 ( VAR_6 , VAR_4 ) ; }
public static int METHOD_1 ( String message , String VAR_1 ) { String [ ] VAR_2 = message . split ( VAR_1 ) ; int VAR_3 = METHOD_2 ( VAR_2 ) ; if ( VAR_3 == VAR_2 . length ) return - 1 ; int VAR_4 = 0 ; for ( int i = 0 ; i < VAR_3 ; ++ i ) VAR_4 += VAR_2 [ i ] . length ( ) + VAR_1 . length ( ) ; return message . VAR_5 ( VAR_6 , VAR_4 ) ; }
don t need pass instance s formatting characters string
public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> VAR_1 . METHOD_2 ( STRING_1 , TYPE_2 . instance ) ; <END> VAR_1 . METHOD_2 ( STRING_2 , VAR_3 . keySet ( ) . size ( ) ) ; VAR_1 . METHOD_2 ( STRING_3 , VAR_4 . size ( ) ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( STRING_2 , VAR_3 . keySet ( ) . size ( ) ) ; VAR_1 . METHOD_2 ( STRING_3 , VAR_4 . size ( ) ) ; }
Set table size 5 expect 4 entries 5 a good default size
public TYPE_2 ( TYPE_1 VAR_2 , String name ) { this . VAR_2 = VAR_2 ; int VAR_3 = name . VAR_4 ( CHAR_1 ) ; this . VAR_5 = ( VAR_3 < 0 ) ? name : name . substring ( 0 , VAR_3 ) ; <START> this . VAR_6 = new HashMap < String , Long > ( ) ; <END> }
public TYPE_2 ( TYPE_1 VAR_2 , String name ) { this . VAR_2 = VAR_2 ; int VAR_3 = name . VAR_4 ( CHAR_1 ) ; this . VAR_5 = ( VAR_3 < 0 ) ? name : name . substring ( 0 , VAR_3 ) ; this . VAR_6 = new HashMap < String , Long > ( 5 ) ; }
parens condition
public long METHOD_1 ( String VAR_1 ) { Long size = VAR_2 . get ( VAR_1 ) ; <START> return ( size == null ) ? 0 : size . VAR_3 ( ) ; <END> }
public long METHOD_1 ( String VAR_1 ) { Long size = VAR_2 . get ( VAR_1 ) ; return size == null ? 0 : size . VAR_3 ( ) ; }
instead String + = _CODE_ s more efficient a StringBuilder append ( ) ( especially a loop ) return sb toString ( )
public String METHOD_1 ( ) { String VAR_1 = "" ; for ( int i = 0 ; i < VAR_2 . length ; i ++ ) { <START> VAR_1 += STRING_1 + i + STRING_2 + VAR_3 [ i ] . size ( ) + STRING_3 ; <END> } return VAR_1 ; }
public String METHOD_1 ( ) { StringBuilder b = new StringBuilder ( ) ; for ( int i = 0 ; i < VAR_2 . length ; i ++ ) { b . append ( STRING_1 + i + STRING_2 + VAR_3 [ i ] . size ( ) + STRING_3 ) ; } return b . toString ( ) ; }
a tad simpler : ( List < TYPE_2 > list : VAR_1 values ( ) ) { count + = list size ( ) ; }
protected int METHOD_1 ( Map < Object , TYPE_1 < TYPE_2 > > VAR_1 ) { Iterator < Entry < Object , TYPE_1 < TYPE_2 > > > iterator = VAR_1 . entrySet ( ) . iterator ( ) ; int count = 0 ; while ( iterator . hasNext ( ) ) { count += iterator . next ( ) . getValue ( ) . size ( ) ; <START> } <END> return count ; }
protected int METHOD_1 ( Map < Object , TYPE_1 < TYPE_2 > > VAR_1 ) { int count = 0 ; for ( TYPE_1 < TYPE_2 > entry : VAR_1 . values ( ) ) { count += entry . size ( ) ; } return count ; }
VAR_1 class member ask active
public void run ( ) { TYPE_1 . METHOD_1 ( ) . METHOD_2 ( ) . METHOD_3 ( new TYPE_2 ( ) { public void run ( ) { <START> TYPE_3 VAR_1 = TYPE_3 . METHOD_4 ( ) ; <END> if ( null != VAR_1 && VAR_1 . METHOD_5 ( ) ) { VAR_1 . METHOD_6 ( ) ; } } } ) ; }
public void run ( ) { TYPE_1 . METHOD_1 ( ) . METHOD_2 ( ) . METHOD_3 ( new TYPE_2 ( ) { public void run ( ) { if ( null != VAR_1 && VAR_1 . METHOD_5 ( ) ) { VAR_1 . METHOD_6 ( ) ; } } } ) ; }
TYPE_3
<START> public TYPE_1 METHOD_1 ( ) { <END> final TYPE_2 VAR_1 = super . VAR_2 . METHOD_2 ( ) ; if ( VAR_1 != null ) { return new TYPE_3 ( VAR_1 . METHOD_1 ( ) , VAR_1 . METHOD_3 ( ) , ( TYPE_4 ) this . METHOD_4 ( ) ) ; } return null ; }
public TYPE_3 METHOD_1 ( ) { final TYPE_2 VAR_1 = super . VAR_2 . METHOD_2 ( ) ; if ( VAR_1 != null ) { return new TYPE_3 ( VAR_1 . METHOD_1 ( ) , VAR_1 . METHOD_3 ( ) , ( TYPE_4 ) this . METHOD_4 ( ) ) ; } return null ; }
! = 0 valid bit 1 bit set
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return ( VAR_2 & VAR_1 . METHOD_2 ( ) ) == VAR_1 . METHOD_2 ( ) ; <END> }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return ( VAR_2 & VAR_1 . METHOD_2 ( ) ) != 0 ; }
put assert want assert ( p > m_loadmetertimerperiodmin ) ; warn designer wrong code recover production
public void METHOD_1 ( int p ) { <START> if ( VAR_1 == p ) return ; <END> VAR_1 = p > VAR_2 ? p : VAR_2 ; METHOD_2 ( ) ; METHOD_3 ( ) ; }
public void METHOD_1 ( int p ) { assert ( p > VAR_2 ) ; if ( VAR_1 == p ) return ; VAR_1 = p > VAR_2 ? p : VAR_2 ; METHOD_2 ( ) ; METHOD_3 ( ) ; }
I haveif ( c = = null || c length < INT_1 ) return ; else ll hav NPE
public TYPE_1 ( Integer [ ] c ) { <START> assert ( c != null && c . length >= INT_1 ) ; <END> VAR_2 = c [ 0 ] ; VAR_3 = c [ 1 ] ; VAR_4 = c [ 2 ] ; VAR_5 = c [ 3 ] ; VAR_6 = c [ 4 ] ; VAR_7 = c [ 5 ] ; VAR_8 = c [ INT_2 ] ; }
public TYPE_1 ( Integer [ ] c ) { assert ( c != null && c . length >= INT_1 ) ; if ( c == null || c . length < INT_1 ) return ; VAR_2 = c [ 0 ] ; VAR_3 = c [ 1 ] ; VAR_4 = c [ 2 ] ; VAR_5 = c [ 3 ] ; VAR_6 = c [ 4 ] ; VAR_7 = c [ 5 ] ; VAR_8 = c [ INT_2 ] ; }
METHOD_1 ( ) s remove
public String toString ( ) { if ( VAR_1 != null ) { <START> return STRING_1 + VAR_2 + STRING_2 + VAR_1 . METHOD_1 ( ) ; <END> } else { return STRING_1 + VAR_2 + STRING_3 ; } }
public String toString ( ) { if ( VAR_1 != null ) { return STRING_1 + VAR_2 + STRING_2 + VAR_1 ; } else { return STRING_1 + VAR_2 + STRING_3 ; } }
s return Integer consistent
<START> public int METHOD_1 ( ) { <END> return VAR_1 ; }
public Integer METHOD_1 ( ) { return VAR_1 ; }
maybeif ( VAR_2 = = VAR_1 ) return ;
<START> public void METHOD_1 ( boolean VAR_1 ) { <END> VAR_2 = VAR_1 ; METHOD_2 ( ) ; METHOD_3 ( ) ; }
public void METHOD_1 ( boolean VAR_1 ) { if ( VAR_2 == VAR_1 ) return ; VAR_2 = VAR_1 ; METHOD_2 ( ) ; METHOD_3 ( ) ; }