Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
good bad else good
synchronized TYPE_1 METHOD_1 ( ) throws IOException { if ( VAR_1 || VAR_2 ) return null ; if ( VAR_3 == null && METHOD_2 ( VAR_4 ) ) { final TYPE_1 VAR_5 = TYPE_1 . METHOD_3 ( METHOD_4 ( VAR_4 ) , METHOD_5 ( ) , METHOD_6 ( ) ) ; <START> if ( ! Arrays . equals ( VAR_6 , VAR_5 . VAR_6 ) ) <END> VAR_2 = true ; else VAR_3 = VAR_5 ; } return VAR_3 ; }
synchronized TYPE_1 METHOD_1 ( ) throws IOException { if ( VAR_1 || VAR_2 ) return null ; if ( VAR_3 == null && METHOD_2 ( VAR_4 ) ) { final TYPE_1 VAR_5 = TYPE_1 . METHOD_3 ( METHOD_4 ( VAR_4 ) , METHOD_5 ( ) , METHOD_6 ( ) ) ; if ( Arrays . equals ( VAR_6 , VAR_5 . VAR_6 ) ) VAR_3 = VAR_5 ; else VAR_2 = true ; } return VAR_3 ; }
unnecessarily flipped order statements diff unnecessarily larger
protected TYPE_1 ( String VAR_2 , String VAR_3 ) { this . VAR_3 = VAR_3 ; <START> this . VAR_2 = VAR_2 ; <END> }
protected TYPE_1 ( String VAR_2 , String VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; }
? claim a refactoring
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { <START> Assert . VAR_4 ( VAR_3 != TYPE_2 . VAR_5 ) ; <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_6 = null ; }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_6 = null ; }
omit explicit else - case return false instead
protected boolean METHOD_1 ( ) { if ( METHOD_2 ( ) != null ) { return METHOD_2 ( ) . METHOD_1 ( ) ; } else { <START> return false ; <END> } }
protected boolean METHOD_1 ( ) { if ( METHOD_2 ( ) != null ) { return METHOD_2 ( ) . METHOD_1 ( ) ; } return false ; }
I don t need anymore ( able kill METHOD_5 ( String bla ) _CODE_
public boolean METHOD_1 ( String path ) { boolean VAR_1 = false ; if ( VAR_2 != null ) { VAR_1 = METHOD_2 ( path ) ; } else if ( TYPE_1 . METHOD_3 ( METHOD_4 ( ) ) ) { <START> VAR_1 = METHOD_5 ( path ) ; <END> } return VAR_1 ; }
public boolean METHOD_1 ( String path ) { boolean VAR_1 = false ; if ( VAR_2 != null ) { VAR_1 = METHOD_2 ( path ) ; } return VAR_1 ; }
remove line variable configuration useless
public Object METHOD_1 ( Object VAR_1 , Class VAR_2 ) { if ( VAR_2 == TYPE_1 . class ) { if ( VAR_3 == null ) { if ( VAR_1 instanceof TYPE_2 ) { TYPE_3 VAR_4 = ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( ) ; if ( VAR_4 instanceof TYPE_4 ) { VAR_3 = new TYPE_5 ( null ) ; <START> TYPE_6 configuration = ( ( TYPE_4 ) VAR_4 ) <END> . METHOD_3 ( ) ; } } } return VAR_3 ; } return null ; }
public Object METHOD_1 ( Object VAR_1 , Class VAR_2 ) { if ( VAR_2 == TYPE_1 . class ) { if ( VAR_3 == null ) { if ( VAR_1 instanceof TYPE_2 ) { TYPE_3 VAR_4 = ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( ) ; if ( VAR_4 instanceof TYPE_4 ) { VAR_3 = new TYPE_5 ( null ) ; } } } return VAR_3 ; } return null ; }
delete file a new generated ? s nice behavior clean mess _CODE_ some tests file
<START> public static void METHOD_1 ( ) { <END> List < String > VAR_1 = new ArrayList < String > ( ) ; for ( String s : VAR_2 ) { VAR_1 . add ( s ) ; } final int VAR_3 = INT_1 ; TYPE_1 VAR_4 = new TYPE_1 ( VAR_1 , INT_2 * Integer . VAR_5 - 100 , INT_3 , VAR_3 ) ; VAR_4 . METHOD_2 ( VAR_6 ) ; }
public static void METHOD_1 ( ) { final int VAR_3 = INT_1 ; TYPE_1 VAR_4 = new TYPE_1 ( INT_2 * Integer . VAR_5 - 100 , INT_3 , VAR_3 ) ; VAR_4 . METHOD_2 ( VAR_6 ) ; }
style : braces
private String METHOD_1 ( ) { TYPE_1 VAR_1 = getClass ( ) . METHOD_2 ( ) ; <START> if ( VAR_1 != null ) { <END> return VAR_1 . METHOD_1 ( ) ; } return null ; }
private String METHOD_1 ( ) { TYPE_1 VAR_1 = getClass ( ) . METHOD_2 ( ) ; return ( VAR_1 == null ) ? null : VAR_1 . METHOD_1 ( ) ; }
TYPE_2 s full path encoded created bug higher call stack handled instead tackle avoid slip cracks repeated
public static TYPE_1 METHOD_1 ( TYPE_2 file ) { final TYPE_1 uri ; String VAR_1 = file . VAR_2 ( ) . toString ( ) ; <START> if ( METHOD_2 ( VAR_1 ) ) { <END> uri = TYPE_1 . METHOD_3 ( VAR_1 , false ) ; } else { uri = TYPE_1 . METHOD_3 ( VAR_1 , true ) ; } return uri ; }
public static TYPE_1 METHOD_1 ( TYPE_2 file ) { return TYPE_1 . METHOD_3 ( file . VAR_2 ( ) . toString ( ) , true ) ; }
s combination a default null a silent catch ( relies earlier initialization set correct ) confusing : final TYPE_1 VAR_2 ; { VAR_2 = ; } catch ( IllegalStateException e ) { VAR_2 = null ; / / log error ? } clearer error occurs return null ( IMHO )
protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> TYPE_1 VAR_2 = null ; <END> try { VAR_2 = TYPE_9 . TYPE_8 . METHOD_1 ( VAR_1 ) ; if ( VAR_2 != null ) { if ( ! VAR_2 . METHOD_2 ( ) ) { VAR_2 . METHOD_3 ( new TYPE_4 ( ) ) ; } TYPE_5 VAR_3 = TYPE_7 . TYPE_8 . METHOD_4 ( VAR_2 ) ; VAR_3 . METHOD_3 ( ) ; } } catch ( IllegalStateException e ) { } return VAR_2 ; }
protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 ; try { VAR_2 = TYPE_9 . TYPE_8 . METHOD_1 ( VAR_1 ) ; if ( VAR_2 != null ) { if ( ! VAR_2 . METHOD_2 ( ) ) { VAR_2 . METHOD_3 ( new TYPE_4 ( ) ) ; } TYPE_5 VAR_3 = TYPE_7 . TYPE_8 . METHOD_4 ( VAR_2 ) ; VAR_3 . METHOD_3 ( ) ; } } catch ( IllegalStateException e ) { VAR_2 = null ; } return VAR_2 ; }
add brackets loop body ( required code conventions )
public String toString ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; TYPE_2 VAR_2 = new TYPE_2 ( VAR_1 ) ; VAR_2 . METHOD_1 ( STRING_1 ) ; for ( Map . Entry < String , String > e : VAR_3 . entrySet ( ) ) <START> VAR_2 . METHOD_1 ( e . getKey ( ) + STRING_2 + e . getValue ( ) + STRING_3 ) ; <END> VAR_2 . close ( ) ; return VAR_1 . toString ( ) ; }
public String toString ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; TYPE_2 VAR_2 = new TYPE_2 ( VAR_1 ) ; VAR_2 . METHOD_1 ( STRING_1 ) ; for ( Map . Entry < String , String > e : VAR_3 . entrySet ( ) ) { VAR_2 . METHOD_1 ( e . getKey ( ) + STRING_2 + e . getValue ( ) + STRING_3 ) ; } VAR_2 . close ( ) ; return VAR_1 . toString ( ) ; }
please remove
public TYPE_2 ( TYPE_1 VAR_2 ) { VAR_3 = VAR_2 ; <START> new Throwable ( ) . METHOD_1 ( ) ; <END> }
public TYPE_2 ( TYPE_1 VAR_2 ) { VAR_3 = VAR_2 ; }
call super ( )
<START> public TYPE_1 ( ) { <END> METHOD_1 ( this ) ; }
public TYPE_1 ( ) { super ( ) ; METHOD_1 ( this ) ; }
private
<START> String METHOD_1 ( String val , String VAR_1 ) { <END> if ( val == null || val . trim ( ) . equals ( "" ) ) { return VAR_1 ; } else { return val ; } }
private String METHOD_1 ( String val , String VAR_1 ) { if ( val == null || val . trim ( ) . equals ( "" ) ) { return VAR_1 ; } else { return val ; } }
public synchronized
<START> synchronized public void METHOD_1 ( ) { <END> if ( METHOD_2 ( ) != null ) { try { METHOD_2 ( ) . close ( ) ; } catch ( Exception exception ) { TYPE_1 . log ( exception ) ; } } if ( METHOD_3 ( ) != null ) { try { METHOD_3 ( ) . close ( ) ; } catch ( Exception exception ) { TYPE_1 . log ( exception ) ; } } }
public synchronized void METHOD_1 ( ) { if ( METHOD_2 ( ) != null ) { try { METHOD_2 ( ) . close ( ) ; } catch ( Exception exception ) { TYPE_1 . log ( exception ) ; } } if ( METHOD_3 ( ) != null ) { try { METHOD_3 ( ) . close ( ) ; } catch ( Exception exception ) { TYPE_1 . log ( exception ) ; } } }
visibility missing synchronized static
<START> static synchronized void METHOD_1 ( TYPE_1 view ) { <END> VAR_1 . add ( view ) ; }
private static synchronized void METHOD_1 ( TYPE_1 view ) { VAR_1 . add ( view ) ; }
protected more s meant - classes definition matter package minor
<START> static void METHOD_1 ( TYPE_1 input , TYPE_2 VAR_1 ) { <END> int VAR_2 = ( int ) VAR_1 . METHOD_2 ( ) ; int VAR_3 = input . position ( ) + ( ( VAR_2 - ( input . position ( ) % VAR_2 ) ) % VAR_2 ) ; input . position ( VAR_3 ) ; }
protected static void METHOD_1 ( TYPE_1 input , TYPE_2 VAR_1 ) { int VAR_2 = ( int ) VAR_1 . METHOD_2 ( ) ; int VAR_3 = input . position ( ) + ( ( VAR_2 - ( input . position ( ) % VAR_2 ) ) % VAR_2 ) ; input . position ( VAR_3 ) ; }
call METHOD_1 multiple times a trace a safe - guard ? curious
public void METHOD_1 ( String name , Class < ? extends TYPE_1 > type ) { super . METHOD_1 ( name ) ; VAR_1 = type ; VAR_2 = ( VAR_3 > 1 ) ? new TYPE_2 < TYPE_1 > ( VAR_3 ) : new TYPE_3 < TYPE_1 > ( ) ; <START> if ( VAR_4 != null ) { <END> VAR_4 . METHOD_2 ( ) ; } VAR_4 = new TYPE_4 ( ) ; VAR_5 = 0 ; VAR_6 = TYPE_5 . METHOD_3 ( ) ; TYPE_6 . METHOD_4 ( VAR_1 , this ) ; }
public void METHOD_1 ( String name , Class < ? extends TYPE_1 > type ) { super . METHOD_1 ( name ) ; VAR_1 = type ; VAR_2 = ( VAR_3 > 1 ) ? new TYPE_2 < TYPE_1 > ( VAR_3 ) : new TYPE_3 < TYPE_1 > ( ) ; VAR_4 . METHOD_1 ( ) ; VAR_5 = 0 ; VAR_6 = TYPE_5 . METHOD_3 ( ) ; TYPE_6 . METHOD_4 ( VAR_1 , this ) ; }
I filter part TYPE_3 please move
private TYPE_6 ( ) { VAR_2 = new TYPE_1 < TYPE_2 , TYPE_3 > ( ) ; <START> VAR_3 = new TYPE_1 < TYPE_2 , TYPE_4 > ( ) ; <END> TYPE_5 . METHOD_1 ( this ) ; }
private TYPE_6 ( ) { VAR_2 = new TYPE_1 < TYPE_2 , TYPE_3 > ( ) ; TYPE_5 . METHOD_1 ( this ) ; }
remove clear ( ) call ( left refactor )
public void METHOD_1 ( List < TYPE_1 < ? > > VAR_1 ) { <START> VAR_2 . clear ( ) ; <END> int VAR_3 = VAR_1 . size ( ) + VAR_2 . size ( ) ; for ( TYPE_1 < ? > VAR_4 : VAR_1 ) { this . METHOD_2 ( VAR_4 , VAR_3 ) ; VAR_3 -- ; } }
public void METHOD_1 ( List < TYPE_1 < ? > > VAR_1 ) { int VAR_3 = VAR_1 . size ( ) + VAR_2 . size ( ) ; for ( TYPE_1 < ? > VAR_4 : VAR_1 ) { this . METHOD_2 ( VAR_4 , VAR_3 ) ; VAR_3 -- ; } }
default usage recording job problematic please remove model editing API handle editing domains
public TYPE_11 ( String name , TYPE_1 < TYPE_2 > VAR_2 , TYPE_3 < TYPE_4 > action , TYPE_5 VAR_3 , TYPE_6 VAR_4 ) { TYPE_7 < TYPE_4 > VAR_5 = TYPE_8 . METHOD_1 ( VAR_3 , action ) ; <START> TYPE_7 < TYPE_4 > job = TYPE_8 . METHOD_2 ( VAR_5 ) ; <END> VAR_6 = TYPE_9 . METHOD_3 ( VAR_2 , VAR_4 , TYPE_10 . METHOD_4 ( job ) ) ; }
public TYPE_11 ( String name , TYPE_1 < TYPE_2 > VAR_2 , TYPE_3 < TYPE_4 > action , TYPE_5 VAR_3 , TYPE_6 VAR_4 ) { TYPE_7 < TYPE_4 > job = TYPE_8 . METHOD_1 ( VAR_3 , action ) ; VAR_6 = TYPE_9 . METHOD_3 ( VAR_2 , VAR_4 , TYPE_10 . METHOD_4 ( job ) ) ; }
accesses volatile primitives guaranteed atomic ( long don t depend current ) synchronized block redundant good reference volatile keyword :
public boolean METHOD_1 ( ) { synchronized ( VAR_1 ) { <START> return VAR_2 ; <END> } }
public boolean METHOD_1 ( ) { return VAR_2 ; }
synchronized block needed
public synchronized void METHOD_1 ( ) { <START> synchronized ( VAR_1 ) { <END> VAR_2 = true ; } TYPE_1 . METHOD_2 ( VAR_3 , STRING_1 ) ; }
public void METHOD_1 ( ) { VAR_2 = true ; TYPE_1 . METHOD_2 ( VAR_3 , STRING_1 ) ; }
please add a TODO replace logging throwing NPE
public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 type , TYPE_1 VAR_3 ) { super ( VAR_3 ) ; VAR_4 = - 1 ; VAR_5 = VAR_2 ; VAR_6 = type ; VAR_7 = type != null ; if ( VAR_5 == null ) { <START> TYPE_3 . log ( new TYPE_4 ( ) ) ; <END> } }
public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 type , TYPE_1 VAR_3 ) { super ( VAR_3 ) ; VAR_4 = - 1 ; VAR_5 = VAR_2 ; VAR_6 = type ; VAR_7 = type != null ; }
symmetry s sake d load ( _CODE_ ( ) ) a method
public void METHOD_1 ( ) { TYPE_5 . TYPE_6 . METHOD_2 ( ) ; <START> TYPE_3 . TYPE_4 . METHOD_2 ( ) ; <END> }
public void METHOD_1 ( ) { TYPE_5 . TYPE_6 . METHOD_2 ( ) ; }
changed return type Double act returning double example Double METHOD_3 ( ) instead returning object cast Double
<START> protected Double METHOD_1 ( Object o ) { <END> if ( o == null ) { return null ; } if ( o instanceof Integer ) { return ( double ) ( ( Integer ) o ) . METHOD_2 ( ) ; } if ( o instanceof Double ) { return ( ( Double ) o ) . METHOD_3 ( ) ; } try { return new Double ( o . toString ( ) ) . METHOD_3 ( ) ; } catch ( TYPE_1 e ) { return null ; } }
protected Double METHOD_1 ( Object o ) { if ( o == null ) { return null ; } if ( o instanceof Integer ) { return ( ( Integer ) o ) . METHOD_3 ( ) ; } if ( o instanceof Double ) { return ( Double ) o ; } try { return new Double ( o . toString ( ) ) ; } catch ( TYPE_1 e ) { return null ; } }
I don t need call toString ( ) objects passed String format - method internally
public String toString ( ) { return String . format ( STRING_1 , VAR_1 . toString ( ) , VAR_2 . toString ( ) , <START> VAR_3 . toString ( ) ) ; <END> }
public String toString ( ) { return String . format ( STRING_1 , VAR_1 , VAR_2 , VAR_3 ) ; }
style : braces single line block
private void METHOD_1 ( File VAR_1 ) { VAR_2 . METHOD_2 ( VAR_1 ) ; <START> if ( METHOD_3 ( ) ) { <END> METHOD_4 ( VAR_1 ) ; } }
private void METHOD_1 ( File VAR_1 ) { VAR_2 . METHOD_2 ( VAR_1 ) ; if ( METHOD_3 ( ) ) METHOD_4 ( VAR_1 ) ; }
isn t enough guarantee equality key implement VAR_1 ( ) = = 1 broken key equals ( obj key )
<START> public boolean equals ( Object obj ) { <END> return obj instanceof TYPE_1 && key . VAR_1 ( ) == obj . VAR_1 ( ) ; }
public boolean equals ( Object obj ) { return obj instanceof TYPE_1 && key . equals ( ( ( TYPE_1 ) obj ) . key ) ; }
guy missed question patch ? I ll copied : METHOD_3 ? I m familiar code I don t called CDT code path parameter os separators ? sounds host dependent I m thinking a case host windows toolchain works remotely linux
public TYPE_1 METHOD_1 ( String path ) { for ( TYPE_2 VAR_1 : METHOD_2 ( ) ) { String VAR_2 = ( new <START> Path ( VAR_1 . getPath ( ) ) ) . METHOD_3 ( ) ; <END> if ( path . VAR_3 ( VAR_2 ) == 0 ) { return VAR_1 ; } } return null ; }
public TYPE_1 METHOD_1 ( String path ) { for ( TYPE_2 VAR_1 : METHOD_2 ( ) ) { if ( path . VAR_3 ( VAR_1 . getPath ( ) ) == 0 ) { return VAR_1 ; } } return null ; }
line long
private void METHOD_1 ( TYPE_1 parent ) { TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( parent ) ; if ( VAR_1 != null ) { try { METHOD_3 ( parent , VAR_1 ) ; } catch ( IOException e ) { TYPE_3 . METHOD_4 ( <START> STRING_1 + parent . VAR_3 ( ) , e ) ; <END> } } }
private void METHOD_1 ( TYPE_1 parent ) { TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( parent ) ; if ( VAR_1 != null ) { try { METHOD_3 ( parent , VAR_1 ) ; } catch ( IOException e ) { String msg = STRING_1 + parent . VAR_3 ( ) ; TYPE_3 . METHOD_4 ( msg , e ) ; } } }
style : braces
public TYPE_3 ( TYPE_1 VAR_2 , Collection < String > VAR_3 ) { super ( TYPE_6 . TYPE_4 ) ; METHOD_1 ( TYPE_6 . TYPE_5 ) ; METHOD_2 ( TYPE_6 . TYPE_2 ) ; this . VAR_2 = VAR_2 ; for ( String VAR_8 : VAR_3 ) { <START> if ( VAR_8 . startsWith ( Constants . VAR_9 ) ) { <END> VAR_10 . add ( VAR_8 ) ; } else { VAR_10 . add ( Constants . VAR_9 + VAR_8 ) ; } } }
public TYPE_3 ( TYPE_1 VAR_2 , Collection < String > VAR_3 ) { super ( TYPE_6 . TYPE_4 ) ; METHOD_1 ( TYPE_6 . TYPE_5 ) ; METHOD_2 ( TYPE_6 . TYPE_2 ) ; this . VAR_2 = VAR_2 ; for ( String VAR_8 : VAR_3 ) { if ( VAR_8 . startsWith ( Constants . VAR_9 ) ) VAR_10 . add ( VAR_8 ) ; else VAR_10 . add ( Constants . VAR_9 + VAR_8 ) ; } }
don t braces ( { } ) simple - line statements please remove
private void METHOD_1 ( boolean VAR_1 ) { final String VAR_2 ; if ( VAR_1 ) { VAR_2 = TYPE_2 . TYPE_3 ; } else { VAR_2 = TYPE_2 . TYPE_1 ; <START> } <END> METHOD_1 ( VAR_2 ) ; }
private void METHOD_1 ( boolean VAR_1 ) { final String VAR_2 ; if ( VAR_1 ) VAR_2 = TYPE_2 . TYPE_3 ; else VAR_2 = TYPE_2 . TYPE_1 ; METHOD_1 ( VAR_2 ) ; }
a thrown exception
public TYPE_1 METHOD_1 ( ) throws TYPE_2 { TYPE_1 user = VAR_1 . METHOD_2 ( ) ; if ( user == null ) { <START> System . err . println ( STRING_1 ) ; <END> user = TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) ; } return user ; }
public TYPE_1 METHOD_1 ( ) throws TYPE_2 { TYPE_1 user = VAR_1 . METHOD_2 ( ) ; if ( user == null ) { user = TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) ; } return user ; }
need constant ? isn t Collections _CODE_ ( ) sufficient
private List < String > METHOD_1 ( ) { if ( VAR_1 != null ) { String VAR_2 = VAR_1 . get ( TYPE_1 . VAR_4 , TYPE_2 . VAR_6 ) ; if ( ! VAR_2 . isEmpty ( ) ) { return Arrays . asList ( VAR_2 . split ( TYPE_2 . VAR_7 ) ) ; } } <START> return TYPE_2 . VAR_8 ; <END> }
private List < String > METHOD_1 ( ) { if ( VAR_1 != null ) { String VAR_2 = VAR_1 . get ( TYPE_1 . VAR_4 , TYPE_2 . VAR_6 ) ; if ( ! VAR_2 . isEmpty ( ) ) { return Arrays . asList ( VAR_2 . split ( TYPE_2 . VAR_7 ) ) ; } } return Collections . VAR_8 ; }
import need VAR_2 VAR_3 part
public void METHOD_1 ( ) throws TYPE_1 { <START> VAR_1 = new TYPE_2 ( VAR_2 . VAR_3 . ByteBuffer . VAR_4 ( INT_1 ) ) ; <END> VAR_1 . METHOD_2 ( TYPE_3 . VAR_6 ) ; METHOD_3 ( VAR_1 ) ; }
public void METHOD_1 ( ) throws TYPE_1 { VAR_1 = new TYPE_2 ( ByteBuffer . VAR_4 ( INT_1 ) ) ; VAR_1 . METHOD_2 ( TYPE_3 . VAR_6 ) ; METHOD_3 ( VAR_1 ) ; }
I assume don t want - box ? ; ) ( btw I learned cases s Integer valueOf ( int ) new Integer ( int ) valueOf cache - values new Integer ( ) create a new object time )
public TYPE_1 ( int VAR_2 ) { <START> this . value = new Integer ( VAR_2 ) ; <END> }
public TYPE_1 ( int VAR_2 ) { this . value = VAR_2 ; }
usethis = = VAR_1 valuehere VAR_1 classes save function call I guess
public boolean equals ( ANNOTATION_1 Object object ) { if ( ! ( object instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) object ; <START> return this . METHOD_1 ( ) == VAR_1 . METHOD_1 ( ) ; <END> }
public boolean equals ( ANNOTATION_1 Object object ) { if ( ! ( object instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) object ; return this . value == VAR_1 . value ; }
method marked synchronized ( ensure caller build array ) minor issue work d ; ) I guess ll fix _CODE_
<START> public String METHOD_1 ( ) { <END> if ( VAR_1 == null ) { List < String > VAR_2 = new ArrayList < String > ( ) ; for ( TYPE_1 element : getValue ( ) ) { VAR_2 . add ( element . VAR_3 ( ) ) ; } VAR_1 = VAR_2 . toString ( ) ; } return VAR_1 ; }
public synchronized String METHOD_1 ( ) { if ( VAR_1 == null ) { List < String > VAR_2 = new ArrayList < String > ( ) ; for ( TYPE_1 element : getValue ( ) ) { VAR_2 . add ( element . VAR_3 ( ) ) ; } VAR_1 = VAR_2 . toString ( ) ; } return VAR_1 ; }
VAR_1 ! = null && ! VAR_1 isEmpty ( )
private Set < String > METHOD_1 ( String key ) { String VAR_1 = METHOD_2 ( ) . getProperty ( key ) ; <START> if ( VAR_1 != null && VAR_1 . length ( ) > 0 ) { <END> return new HashSet < String > ( Arrays . asList ( VAR_1 . split ( STRING_1 ) ) ) ; } return Collections . VAR_2 ( ) ; }
private Set < String > METHOD_1 ( String key ) { String VAR_1 = METHOD_2 ( ) . getProperty ( key ) ; if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { return new HashSet < String > ( Arrays . asList ( VAR_1 . split ( STRING_1 ) ) ) ; } return Collections . VAR_2 ( ) ; }
method declared static
<START> private String METHOD_1 ( TYPE_1 VAR_1 ) { <END> String VAR_2 ; if ( VAR_1 . METHOD_2 ( ) ) VAR_2 = VAR_1 . METHOD_3 ( ) . getName ( ) ; else VAR_2 = VAR_1 . METHOD_4 ( ) . getName ( ) ; return VAR_2 ; }
private static String METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 ; if ( VAR_1 . METHOD_2 ( ) ) VAR_2 = VAR_1 . METHOD_3 ( ) . getName ( ) ; else VAR_2 = VAR_1 . METHOD_4 ( ) . getName ( ) ; return VAR_2 ; }
order arguments assert * ( ) counter - intuitive s ( expected actual ) technically result variables
public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( STRING_1 ) ; String result = VAR_1 . getValue ( ) ; assertNotNull ( result ) ; <START> assertEquals ( result , STRING_1 ) ; <END> }
public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( STRING_1 ) ; String result = VAR_1 . getValue ( ) ; assertNotNull ( result ) ; assertEquals ( STRING_1 , result ) ; }
give a _CODE_ METHOD_4 ( ) return null
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 ; METHOD_2 ( VAR_1 ) ; try { METHOD_3 ( VAR_1 ) ; <START> METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( this ) ; <END> } catch ( TYPE_2 e ) { LOG . warn ( null , e ) ; } catch ( Throwable t ) { LOG . warn ( null , t ) ; } }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 ; METHOD_2 ( VAR_1 ) ; try { METHOD_3 ( VAR_1 ) ; if ( METHOD_4 ( ) != null && METHOD_4 ( ) . METHOD_5 ( ) != null ) { METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( this ) ; } } catch ( TYPE_2 e ) { LOG . warn ( null , e ) ; } catch ( Throwable t ) { LOG . warn ( null , t ) ; } }
pass null instead entry
public boolean METHOD_1 ( TYPE_1 entry , boolean VAR_1 ) { <START> return METHOD_1 ( null , false , null ) ; <END> }
public boolean METHOD_1 ( TYPE_1 entry , boolean VAR_1 ) { return METHOD_1 ( entry , false , null ) ; }
check moved _CODE_ ( ) ( overridden version calls super _CODE_ ( ) ) METHOD_2 ( ) overridden class return a TYPE_3
protected ANNOTATION_1 TYPE_1 METHOD_1 ( ) { TYPE_2 trace = METHOD_2 ( ) ; <START> if ( ! ( trace instanceof TYPE_3 ) ) { <END> throw new IllegalStateException ( STRING_1 ) ; } return new TYPE_4 ( ( TYPE_3 ) trace ) ; }
protected ANNOTATION_1 TYPE_1 METHOD_1 ( ) { return new TYPE_4 ( METHOD_2 ( ) ) ; }
instead usereturn ; avoid creating new objects everytime method called refer object ( string literals internalized ) a private static final String EMTPY_STRING = ; class instead a lot file
public String METHOD_1 ( ) { <START> return new String ( ) ; <END> }
public String METHOD_1 ( ) { return "" ; }
throw exception
public TYPE_4 ( String VAR_2 , TYPE_1 config , TYPE_2 session ) <START> throws TYPE_3 { <END> VAR_3 = VAR_2 ; VAR_4 = session ; VAR_5 = config ; }
public TYPE_4 ( String VAR_2 , TYPE_1 config , TYPE_2 session ) { VAR_3 = VAR_2 ; VAR_4 = session ; VAR_5 = config ; }
substring ( # ) calculated TYPE_3
private TYPE_1 METHOD_1 ( TYPE_2 element ) { if ( element != null ) { for ( String VAR_1 : element . VAR_2 ( ) ) { if ( VAR_1 . startsWith ( TYPE_3 ) ) { <START> return TYPE_1 . parse ( VAR_1 . substring ( 5 ) ) ; <END> } } } return null ; }
private TYPE_1 METHOD_1 ( TYPE_2 element ) { if ( element != null ) { for ( String VAR_1 : element . VAR_2 ( ) ) { if ( VAR_1 . startsWith ( TYPE_3 ) ) { return TYPE_1 . parse ( VAR_1 . substring ( TYPE_3 . length ( ) ) ) ; } } } return null ; }
common code base I dislike size ( ) = = 0 - > isEmpty ( ) assume List operator implements size ( ) a huge cost ( linear constant time )
void METHOD_1 ( TYPE_1 VAR_1 ) { assert ( this . VAR_2 ) ; <START> if ( VAR_3 . size ( ) == 0 ) { <END> return ; } for ( int i = 0 ; i < VAR_3 . size ( ) ; i ++ ) { VAR_1 . add ( VAR_3 . get ( i ) ) ; } return ; }
void METHOD_1 ( TYPE_1 VAR_1 ) { assert ( this . VAR_2 ) ; if ( VAR_3 . isEmpty ( ) ) { return ; } for ( int i = 0 ; i < VAR_3 . size ( ) ; i ++ ) { VAR_1 . add ( VAR_3 . get ( i ) ) ; } return ; }
import import section
<START> public TYPE_1 < org . VAR_1 . VAR_2 . VAR_3 . description . filter . TYPE_2 > METHOD_1 ( ) { <END> if ( VAR_4 == null ) { VAR_4 = new TYPE_4 . TYPE_5 < org . VAR_1 . VAR_2 . VAR_3 . description . filter . TYPE_2 > ( org . VAR_1 . VAR_2 . VAR_3 . description . filter . TYPE_2 . class , this , TYPE_6 . VAR_6 ) ; } return VAR_4 ; }
public TYPE_1 < TYPE_2 > METHOD_1 ( ) { if ( VAR_4 == null ) { VAR_4 = new TYPE_4 . TYPE_5 < TYPE_2 > ( TYPE_2 . class , this , TYPE_6 . VAR_6 ) ; } return VAR_4 ; }
throw error
public int METHOD_1 ( TYPE_1 event , int VAR_1 ) { int VAR_2 = VAR_1 ; for ( TYPE_2 VAR_3 : VAR_4 ) { <START> VAR_2 = VAR_3 . METHOD_2 ( event , VAR_2 ) ; <END> } return VAR_2 ; }
public int METHOD_1 ( TYPE_1 event , int VAR_1 ) { int VAR_2 = VAR_1 ; for ( TYPE_2 VAR_3 : VAR_4 ) { VAR_2 = VAR_3 . METHOD_2 ( event , VAR_2 ) ; if ( VAR_2 == - 1 ) { break ; } } return VAR_2 ; }
null check needed
protected void METHOD_1 ( TYPE_1 node ) { <START> if ( METHOD_2 ( ) != null ) { <END> METHOD_2 ( ) . update ( node , null ) ; } }
protected void METHOD_1 ( TYPE_1 node ) { METHOD_2 ( ) . update ( node , null ) ; }
valueof ? id a String
public String METHOD_1 ( ) { <START> return String . valueOf ( id ) ; <END> }
public String METHOD_1 ( ) { return id ; }
tmf core activator plugin depends tmf core loaded necessary call
public void start ( TYPE_1 context ) throws Exception { super . start ( context ) ; METHOD_1 ( this ) ; <START> TYPE_2 . METHOD_2 ( ) ; <END> }
public void start ( TYPE_1 context ) throws Exception { super . start ( context ) ; METHOD_1 ( this ) ; }
VAR_1 static ? list modules XML modules ? case METHOD_1 ( ) method a static method ( interface method ) class ends a static class empty private constructor prevent instantiation method synchronized avoid risk threads calling time entering block
<START> public TYPE_1 < TYPE_2 > METHOD_1 ( ) { <END> if ( VAR_1 == null ) { METHOD_2 ( ) ; } return VAR_1 ; }
public synchronized TYPE_1 < TYPE_2 > METHOD_1 ( ) { if ( VAR_1 == null ) { METHOD_2 ( ) ; } return VAR_1 ; }
s needed anymore delete ; - )
public void METHOD_1 ( final boolean VAR_1 ) { if ( VAR_1 ) { <START> VAR_2 = VAR_3 ; <END> } else if ( VAR_2 != VAR_3 ) { VAR_2 = VAR_4 ; } if ( METHOD_2 ( ) instanceof TYPE_1 ) { ( ( TYPE_1 ) METHOD_2 ( ) ) . METHOD_1 ( false ) ; } }
public void METHOD_1 ( final boolean VAR_1 ) { if ( VAR_1 ) { VAR_2 = VAR_3 ; } else { VAR_2 = VAR_4 ; } if ( METHOD_2 ( ) instanceof TYPE_1 ) { ( ( TYPE_1 ) METHOD_2 ( ) ) . METHOD_1 ( false ) ; } }
I access VAR_1 synchronized
private List < TYPE_1 > METHOD_1 ( TYPE_2 project ) { <START> List < TYPE_1 > result = VAR_1 . get ( project ) ; <END> if ( result == null ) { result = new ArrayList < TYPE_1 > ( ) ; for ( TYPE_1 VAR_2 : VAR_3 ) { if ( VAR_2 . METHOD_2 ( project ) ) { result . add ( VAR_2 ) ; } } VAR_1 . put ( project , result ) ; } return result ; }
private List < TYPE_1 > METHOD_1 ( TYPE_2 project ) { synchronized ( VAR_1 ) { List < TYPE_1 > result = VAR_1 . get ( project ) ; if ( result == null ) { result = new ArrayList < TYPE_1 > ( ) ; for ( TYPE_1 VAR_2 : VAR_3 ) { if ( VAR_2 . METHOD_2 ( project ) ) { result . add ( VAR_2 ) ; } } VAR_1 . put ( project , result ) ; } return result ; } }
need protected couldn t private ? number background requests specific internal implementation ( notion foreground background s another story ; ) )
<START> protected int METHOD_1 ( ) { <END> int VAR_1 = 0 ; synchronized ( VAR_2 ) { for ( TYPE_1 request : VAR_3 ) { if ( request . VAR_4 ( ) . equals ( TYPE_2 . VAR_6 ) ) { VAR_1 ++ ; } } } return VAR_1 ; }
private int METHOD_1 ( ) { int VAR_1 = 0 ; synchronized ( VAR_2 ) { for ( TYPE_1 request : VAR_3 ) { if ( request . VAR_4 ( ) . equals ( TYPE_2 . VAR_6 ) ) { VAR_1 ++ ; } } } return VAR_1 ; }
METHOD_1 another method init METHOD_2 stay METHOD_1
<START> private void METHOD_1 ( ) throws TYPE_1 { <END> METHOD_2 ( VAR_1 . exists ( ) ) ; VAR_2 = new TYPE_2 ( VAR_1 . METHOD_3 ( ) ) ; }
public void METHOD_1 ( ) throws TYPE_1 { METHOD_2 ( VAR_1 . exists ( ) ) ; VAR_2 = new TYPE_2 ( VAR_1 . METHOD_3 ( ) ) ; }
statements else branches curly braces branches
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 name ) throws TYPE_3 { <START> if ( VAR_1 . equals ( METHOD_2 ( ) ) ) <END> METHOD_1 ( name ) ; else new TYPE_4 ( METHOD_3 ( ) , record + VAR_2 ) . METHOD_1 ( VAR_1 , name ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 name ) throws TYPE_3 { if ( VAR_1 . equals ( METHOD_2 ( ) ) ) { METHOD_1 ( name ) ; } else { new TYPE_4 ( METHOD_3 ( ) , record + VAR_2 ) . METHOD_1 ( VAR_1 , name ) ; } }
remove unnecessary surrounding parenthesis
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return ( VAR_1 . METHOD_2 ( TYPE_3 . TYPE_4 . name ( ) ) ) ; <END> }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 . METHOD_2 ( TYPE_3 . TYPE_4 . name ( ) ) ; }
protected
<START> public void set ( TYPE_1 VAR_1 ) { <END> this . VAR_2 = VAR_1 ; }
protected void set ( TYPE_1 VAR_1 ) { this . VAR_2 = VAR_1 ; }
( a bunch statements return statement w / && )
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( obj == null ) { return false ; } if ( getClass ( ) != obj . getClass ( ) ) { return false ; } <START> return this . VAR_1 . equals ( ( ( TYPE_1 ) obj ) . METHOD_1 ( ) ) ; <END> }
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( obj == null || getClass ( ) != obj . getClass ( ) ) { return false ; } return this . VAR_1 . equals ( ( ( TYPE_1 ) obj ) . METHOD_1 ( ) ) ; }
need ? doesn t
public void METHOD_1 ( ) { <START> VAR_1 = new TYPE_1 ( ) ; <END> VAR_1 . METHOD_2 ( VAR_2 . METHOD_3 ( ) ) ; VAR_3 = new TYPE_2 ( ) ; }
public void METHOD_1 ( ) { VAR_3 = new TYPE_2 ( ) ; }
instead making a singleton create VAR_1 _CODE_
public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 ( ) ; assertNotNull ( VAR_1 ) ; <START> assertEquals ( VAR_1 , TYPE_1 . METHOD_2 ( ) ) ; <END> TYPE_2 VAR_2 = new TYPE_2 ( TYPE_1 . METHOD_2 ( ) . METHOD_3 ( ) , STRING_1 ) ; TYPE_3 VAR_3 = new TYPE_3 ( STRING_2 , STRING_3 ) ; VAR_2 . METHOD_4 ( TYPE_5 . VAR_5 , VAR_3 , false ) ; TYPE_4 configuration = TYPE_1 . METHOD_2 ( ) . METHOD_5 ( VAR_2 ) ; METHOD_6 ( configuration ) ; }
public void METHOD_1 ( ) throws Exception { TYPE_2 VAR_2 = new TYPE_2 ( VAR_1 . METHOD_3 ( ) , STRING_1 ) ; TYPE_3 VAR_3 = new TYPE_3 ( STRING_2 , STRING_3 ) ; VAR_2 . METHOD_4 ( TYPE_5 . VAR_5 , VAR_3 , false ) ; TYPE_4 configuration = VAR_1 . METHOD_5 ( VAR_2 ) ; METHOD_6 ( configuration ) ; }
return VAR_2 METHOD_1 ( )
public int METHOD_1 ( ) { final int VAR_1 = INT_1 ; int result = 1 ; <START> result = VAR_1 * result + ( ( VAR_2 == null ) ? 0 : VAR_2 . METHOD_1 ( ) ) ; <END> return result ; }
public int METHOD_1 ( ) { return VAR_2 . METHOD_1 ( ) ; }
return immutable collection
public Collection < TYPE_1 > METHOD_1 ( ) { <START> return VAR_1 . values ( ) ; <END> }
public Map < String , TYPE_1 > METHOD_1 ( ) { return VAR_1 ; }
methods private
<START> public Map < String , TYPE_1 > METHOD_1 ( TYPE_2 monitor ) throws TYPE_3 { <END> return METHOD_2 ( monitor , STRING_1 , new TYPE_4 < TYPE_5 , TYPE_1 [ ] > ( ) { public TYPE_1 [ ] apply ( TYPE_5 input ) { return input . VAR_1 ( ) ; } } , new TYPE_6 < TYPE_5 > ( ) { } ) ; }
private Map < String , TYPE_1 > METHOD_1 ( TYPE_2 monitor ) throws TYPE_3 { return METHOD_2 ( monitor , STRING_1 , new TYPE_6 < TYPE_5 > ( ) { } ) ; }
constructors calls METHOD_1 ( ) create a thread construction called fake traces ? I d safer lazy - METHOD_1 done previous version _CODE_ ( ) dispose ( ) synchronized ( synchronizes ) doesn t VAR_6
public void METHOD_1 ( String name , Class < ? extends TYPE_1 > type ) { super . METHOD_1 ( name ) ; VAR_1 = type ; VAR_2 = ( VAR_3 > 1 ) ? new TYPE_2 < TYPE_1 > ( VAR_3 ) : new TYPE_3 < TYPE_1 > ( ) ; VAR_4 . METHOD_1 ( ) ; VAR_5 = 0 ; synchronized ( VAR_6 ) { <START> VAR_7 = new TYPE_4 ( ) ; <END> } TYPE_5 . METHOD_2 ( VAR_1 , this ) ; }
public void METHOD_1 ( String name , Class < ? extends TYPE_1 > type ) { super . METHOD_1 ( name ) ; VAR_1 = type ; VAR_4 . METHOD_1 ( ) ; VAR_5 = 0 ; synchronized ( VAR_6 ) { VAR_7 = new TYPE_4 ( ) ; } TYPE_5 . METHOD_2 ( VAR_1 , this ) ; }
I handling fetches a server shallow commits more work ( v1 9 - rc0 3^2 17 upload - pack : deepening preserves shallow roots 2013 - 12 - 05 ) lines needed
public void METHOD_1 ( Collection < ? extends TYPE_1 > VAR_1 ) throws IOException { if ( ! VAR_2 ) <START> METHOD_2 ( ) ; <END> for ( TYPE_1 id : VAR_1 ) METHOD_3 ( id ) . VAR_3 = TYPE_2 . VAR_5 ; }
public void METHOD_1 ( Collection < ? extends TYPE_1 > VAR_1 ) { for ( TYPE_1 id : VAR_1 ) METHOD_3 ( id ) . VAR_3 = TYPE_2 . VAR_5 ; }
private
<START> protected TYPE_1 METHOD_1 ( ) { <END> return VAR_1 . METHOD_2 ( SWT . VAR_2 ) . METHOD_3 ( ) ; }
private TYPE_1 METHOD_1 ( ) { return VAR_1 . METHOD_2 ( SWT . VAR_2 ) . METHOD_3 ( ) ; }
_CODE_ instead ease maintenance
protected void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( new TYPE_3 ( ) ) ; VAR_1 . METHOD_4 ( new TYPE_4 ( ) ) ; VAR_1 . METHOD_4 ( new TYPE_5 ( ) ) ; METHOD_5 ( ) . METHOD_6 ( VAR_1 ) ; <START> METHOD_7 ( ) ; <END> VAR_2 = new TYPE_6 ( STRING_1 ) ; }
protected void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( new TYPE_3 ( ) ) ; VAR_1 . METHOD_4 ( new TYPE_4 ( ) ) ; VAR_1 . METHOD_4 ( new TYPE_5 ( ) ) ; METHOD_5 ( ) . METHOD_6 ( VAR_1 ) ; VAR_2 = new TYPE_6 ( STRING_1 ) ; }
call other constructor giving diff builder instance parameter
public TYPE_2 ( ) { <START> this . VAR_2 = new TYPE_1 ( ) ; <END> }
public TYPE_2 ( ) { this ( new TYPE_1 ( ) ) ; }
isn t place modifying list VAR_1 I progammatically created VAR_1 added model survive
<START> public TYPE_1 [ ] METHOD_1 ( ) { <END> Set < TYPE_1 > VAR_1 = new HashSet < TYPE_1 > ( ) ; VAR_1 . addAll ( VAR_2 . METHOD_2 ( ) ) ; for ( TYPE_1 VAR_3 : VAR_4 . METHOD_1 ( ) ) { VAR_1 . add ( VAR_3 ) ; } return VAR_1 . METHOD_3 ( new TYPE_1 [ 0 ] ) ; }
public TYPE_1 [ ] METHOD_1 ( ) { return VAR_4 . METHOD_1 ( ) ; }
VAR_3 getter
public List < TYPE_1 < T > > METHOD_1 ( ) { ArrayList < TYPE_1 < T > > VAR_1 = TYPE_2 . METHOD_2 ( VAR_2 . values ( ) ) ; if ( VAR_1 . size ( ) > 0 ) { <START> Collections . VAR_3 ( VAR_1 ) ; <END> } return VAR_1 ; }
public List < TYPE_1 < T > > METHOD_1 ( ) { return TYPE_2 . METHOD_2 ( VAR_2 . values ( ) ) ; }
a bunch templates I a list / set check template pref store
private void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( VAR_1 , true ) ; METHOD_2 ( ) . METHOD_3 ( VAR_2 , VAR_3 ) ; if ( METHOD_2 ( ) . getString ( VAR_2 ) . equals ( VAR_4 ) || METHOD_2 ( ) . getString ( VAR_2 ) . equals ( VAR_5 ) <START> || METHOD_2 ( ) . getString ( VAR_2 ) . equals ( VAR_6 ) ) { <END> METHOD_2 ( ) . METHOD_4 ( VAR_2 , VAR_3 ) ; } }
private void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( VAR_1 , true ) ; METHOD_2 ( ) . METHOD_3 ( VAR_2 , VAR_3 ) ; }
occur METHOD_3 ( input ) ;
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 input ) throws TYPE_3 { METHOD_2 ( VAR_1 ) ; METHOD_3 ( input ) ; <START> if ( ! ( input instanceof TYPE_4 ) ) { <END> throw new TYPE_3 ( new Status ( TYPE_5 . VAR_3 , TYPE_6 . VAR_5 , STRING_1 ) ) ; } TYPE_4 VAR_6 = ( ( TYPE_4 ) input ) ; if ( VAR_6 != null ) { source = VAR_6 . METHOD_4 ( ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 input ) throws TYPE_3 { if ( ! ( input instanceof TYPE_4 ) ) { throw new TYPE_3 ( new Status ( TYPE_5 . VAR_3 , TYPE_6 . VAR_5 , STRING_1 ) ) ; } METHOD_2 ( VAR_1 ) ; METHOD_3 ( input ) ; TYPE_4 VAR_6 = ( ( TYPE_4 ) input ) ; if ( VAR_6 != null ) { source = VAR_6 . METHOD_4 ( ) ; } }
shouldn t call parse ( )
public TYPE_1 ( File VAR_2 ) { <START> this . VAR_2 = VAR_2 ; <END> }
public TYPE_1 ( File VAR_2 ) { this . VAR_2 = VAR_2 ; parse ( ) ; }
need variable instead inline
public static void METHOD_1 ( ) { <START> final TYPE_1 c = new TYPE_1 ( ) ; <END> TYPE_2 . METHOD_2 ( c ) ; }
public static void METHOD_1 ( ) { TYPE_2 . METHOD_2 ( new TYPE_1 ( ) ) ; }
introducing a local variable justified
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { boolean result ; <START> result = VAR_1 != null && VAR_1 . METHOD_2 ( ) == TYPE_1 . VAR_2 || VAR_1 . METHOD_2 ( ) == TYPE_1 . VAR_3 ; <END> return result ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 != null && VAR_1 . METHOD_2 ( ) == TYPE_1 . VAR_2 || VAR_1 . METHOD_2 ( ) == TYPE_1 . VAR_3 ; }
isn t condition inverted ? juno kepler versions * * support dynamic tabbar
public static boolean METHOD_1 ( ) { <START> return METHOD_2 ( ) || METHOD_3 ( ) ; <END> }
public static boolean METHOD_1 ( ) { return ! ( METHOD_2 ( ) || METHOD_3 ( ) ) ; }
field removed
public TYPE_1 METHOD_1 ( ) { <START> VAR_1 = new TYPE_1 ( METHOD_2 ( ) , METHOD_3 ( ) ) ; <END> return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( METHOD_2 ( ) , METHOD_3 ( ) ) ; }
I s return null _CODE_ handling result
public String METHOD_1 ( ) { <START> if ( VAR_1 == null ) { <END> return "" ; } else { return VAR_1 ; } }
public String METHOD_1 ( ) { return VAR_1 ; }
set false ? set true
public TYPE_2 ( TYPE_1 VAR_2 , String VAR_3 ) { super ( VAR_2 , VAR_3 ) ; <START> METHOD_1 ( false ) ; <END> METHOD_2 ( false ) ; }
public TYPE_2 ( TYPE_1 VAR_2 , String VAR_3 ) { super ( VAR_2 , VAR_3 ) ; METHOD_1 ( true ) ; METHOD_2 ( true ) ; }
needs done _CODE_ ( ) s _CODE_ ( ) instead
public void METHOD_1 ( TYPE_1 VAR_1 ) { assert ( VAR_1 != null ) ; VAR_2 = VAR_1 . METHOD_2 ( ) ; TYPE_2 [ ] VAR_3 = TYPE_3 . METHOD_3 ( VAR_2 ) ; if ( VAR_3 != null ) { this . VAR_4 . METHOD_4 ( VAR_3 . length < VAR_5 . METHOD_5 ( ) ) ; <START> } <END> METHOD_6 ( ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { assert ( VAR_1 != null ) ; VAR_2 = VAR_1 . METHOD_2 ( ) ; METHOD_6 ( ) ; }
s remove
public TYPE_1 ( String VAR_2 , String VAR_3 , long VAR_4 , String VAR_5 , long line ) { VAR_6 = VAR_2 ; VAR_7 = VAR_5 ; VAR_8 = VAR_3 ; <START> this . VAR_9 = VAR_4 ; <END> this . VAR_10 = line ; }
public TYPE_1 ( String VAR_2 , String VAR_3 , long VAR_4 , String VAR_5 , long line ) { VAR_6 = VAR_2 ; VAR_7 = VAR_5 ; VAR_8 = VAR_3 ; VAR_9 = VAR_4 ; VAR_10 = line ; }
need casting
protected T METHOD_1 ( T VAR_1 ) throws TYPE_1 { T VAR_2 ; if ( VAR_1 == null ) { VAR_2 = null ; } else { <START> T t = TYPE_2 . METHOD_2 ( VAR_1 , METHOD_3 ( ) ) ; <END> TYPE_3 b = METHOD_4 ( t ) ; if ( b != null ) { VAR_2 = t ; } else { throw new TYPE_1 ( STRING_1 + VAR_1 ) ; } } return VAR_2 ; }
protected T METHOD_1 ( T VAR_1 ) throws TYPE_1 { T VAR_2 ; if ( VAR_1 == null ) { VAR_2 = null ; } else { TYPE_3 b = METHOD_4 ( VAR_1 ) ; if ( b != null ) { VAR_2 = VAR_1 ; } else { throw new TYPE_1 ( STRING_1 + VAR_1 ) ; } } return VAR_2 ; }
need casting
public TYPE_1 < T > METHOD_1 ( T value ) { for ( TYPE_1 < T > b : METHOD_2 ( ) ) { <START> T VAR_1 = TYPE_2 . METHOD_3 ( b . VAR_2 ( ) , METHOD_4 ( ) ) ; <END> if ( TYPE_3 . equals ( VAR_1 , value ) ) { return b ; } } return null ; }
public TYPE_1 < T > METHOD_1 ( T value ) { for ( TYPE_1 < T > b : METHOD_2 ( ) ) { T VAR_1 = b . VAR_2 ( ) ; if ( TYPE_3 . equals ( VAR_1 , value ) ) { return b ; } } return null ; }
remove unnecessary cast
protected void METHOD_1 ( ) throws TYPE_1 { METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( ) . METHOD_6 ( ) ) ; METHOD_7 ( ) . METHOD_8 ( METHOD_5 ( ) . METHOD_9 ( ) ) ; <START> METHOD_7 ( ) . METHOD_10 ( ( TYPE_2 ) METHOD_5 ( ) . METHOD_11 ( ) ) ; <END> METHOD_12 ( ) . METHOD_13 ( METHOD_5 ( ) . METHOD_14 ( ) != null ) ; METHOD_12 ( ) . METHOD_15 ( METHOD_5 ( ) . METHOD_14 ( ) ) ; }
protected void METHOD_1 ( ) throws TYPE_1 { METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( ) . METHOD_6 ( ) ) ; METHOD_7 ( ) . METHOD_8 ( METHOD_5 ( ) . METHOD_9 ( ) ) ; METHOD_7 ( ) . METHOD_10 ( METHOD_5 ( ) . METHOD_11 ( ) ) ; METHOD_12 ( ) . METHOD_13 ( METHOD_5 ( ) . METHOD_14 ( ) != null ) ; METHOD_12 ( ) . METHOD_15 ( METHOD_5 ( ) . METHOD_14 ( ) ) ; }
remove
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { <START> this . VAR_4 = VAR_2 ; <END> this . VAR_5 = VAR_3 ; }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { VAR_4 = VAR_2 ; VAR_5 = VAR_3 ; }
remove
public TYPE_1 ( TYPE_1 VAR_1 ) { <START> this . VAR_2 = VAR_1 ; <END> }
public TYPE_1 ( TYPE_1 VAR_1 ) { VAR_2 = VAR_1 ; }
remove
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 trace ) { <START> this . VAR_3 = trace ; <END> this . VAR_4 = VAR_2 ; }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 trace ) { VAR_3 = trace ; VAR_4 = VAR_2 ; }
slightly more efficient : TYPE_3 VAR_2 = VAR_2 ( new TYPE_3 ( ) VAR_1 ) ; VAR_2 VAR_4 = TYPE_5 trim ( VAR_4 ) ; ( int i = 0 ; i < VAR_2 VAR_4 length ; i + + ) { VAR_2 VAR_4 [ i ] = VAR_2 VAR_4 [ i ] VAR_2 ( VAR_1 ) ; } return VAR_2 ;
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> TYPE_1 VAR_2 = METHOD_1 ( new TYPE_3 ( ) , VAR_1 ) ; <END> for ( TYPE_4 VAR_3 : TYPE_5 . trim ( VAR_4 ) ) { VAR_2 . METHOD_2 ( VAR_3 . METHOD_1 ( VAR_1 ) ) ; } return VAR_2 ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 VAR_2 = METHOD_1 ( new TYPE_3 ( ) , VAR_1 ) ; VAR_2 . VAR_4 = TYPE_5 . trim ( VAR_4 , true ) ; for ( int i = 0 ; i < VAR_2 . VAR_4 . length ; i ++ ) { VAR_2 . VAR_4 [ i ] = VAR_2 . VAR_4 [ i ] . METHOD_1 ( VAR_1 ) ; } return VAR_2 ; }
attribute null
public void METHOD_1 ( String key , String value ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; <START> VAR_1 . METHOD_3 ( key ) . METHOD_4 ( value ) ; <END> METHOD_5 ( key , value ) ; }
public void METHOD_1 ( String key , String value ) { if ( key != null && value != null ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( key ) . METHOD_4 ( value ) ; METHOD_5 ( key , value ) ; } }
List
protected ArrayList < TYPE_1 > METHOD_1 ( TYPE_2 in ) { <START> TYPE_3 < ArrayList < TYPE_1 > > <END> type = new TYPE_3 < ArrayList < TYPE_1 > > ( ) { } ; return new TYPE_4 ( ) . METHOD_2 ( type . getType ( ) , new TYPE_5 ( ) ) . METHOD_3 ( VAR_1 ) . create ( ) . METHOD_4 ( in , type . getType ( ) ) ; }
protected ArrayList < TYPE_1 > METHOD_1 ( TYPE_2 in ) { TYPE_3 < ArrayList < TYPE_1 > > type = new TYPE_3 < ArrayList < TYPE_1 > > ( ) { } ; return new TYPE_4 ( ) . METHOD_2 ( type . getType ( ) , new TYPE_5 ( ) ) . create ( ) . METHOD_4 ( in , type . getType ( ) ) ; }
change _CODE_ METHOD_1 ( ! VAR_1 || VAR_2 = = null || VAR_2 size ( ) = = 1 )
public TYPE_1 build ( ) { if ( VAR_1 ) { <START> TYPE_2 . METHOD_1 ( VAR_2 == null || VAR_2 . size ( ) == 1 ) ; <END> } boolean VAR_3 = VAR_4 != null ; if ( VAR_3 ) { TYPE_2 . METHOD_1 ( VAR_5 != null ) ; } final TYPE_1 VAR_6 = new TYPE_1 ( parent , VAR_7 , VAR_3 ) ; TYPE_3 VAR_8 = METHOD_2 ( VAR_6 ) ; if ( VAR_3 ) { METHOD_3 ( VAR_6 ) ; } METHOD_4 ( VAR_8 ) ; METHOD_5 ( VAR_6 , VAR_8 ) ; return VAR_6 ; }
public TYPE_1 build ( ) { TYPE_2 . METHOD_1 ( ! VAR_1 || VAR_2 == null || VAR_2 . size ( ) == 1 ) ; boolean VAR_3 = VAR_4 != null ; TYPE_2 . METHOD_1 ( ! VAR_3 || VAR_5 != null ) ; final TYPE_1 VAR_6 = new TYPE_1 ( parent , VAR_7 , VAR_3 ) ; TYPE_3 VAR_8 = METHOD_2 ( VAR_6 ) ; if ( VAR_3 ) { METHOD_3 ( VAR_6 ) ; } METHOD_4 ( VAR_8 ) ; METHOD_5 ( VAR_6 , VAR_8 ) ; return VAR_6 ; }
VAR_2 _CODE_ instead looping
public static void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) { <START> final List < TYPE_2 > VAR_3 = VAR_2 . METHOD_2 ( ) ; <END> for ( TYPE_2 view : VAR_3 ) { if ( view . VAR_4 ( ) . METHOD_3 ( ) . equals ( VAR_1 . METHOD_3 ( ) ) ) { view . close ( ) ; VAR_2 . METHOD_4 ( TYPE_3 . METHOD_5 ( view ) ) ; } } }
public static void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) { final List < TYPE_2 > VAR_3 = VAR_2 . METHOD_2 ( ) ; for ( TYPE_2 view : VAR_3 ) { if ( view . VAR_4 ( ) . equalsIgnoreCase ( VAR_1 ) ) { view . close ( ) ; VAR_2 . METHOD_4 ( TYPE_3 . METHOD_5 ( view ) ) ; } } }
please don t print stack trace log properly ignore information useless
public static String METHOD_1 ( String VAR_1 ) { try ( TYPE_1 VAR_2 = new TYPE_1 ( new TYPE_2 ( VAR_1 ) ) ) { TYPE_3 buffer = new TYPE_3 ( ) ; String line ; while ( ( line = VAR_2 . METHOD_2 ( ) ) != null ) { buffer . append ( line . VAR_3 ( STRING_1 ) ) ; } return METHOD_3 ( buffer . toString ( ) ) ; } catch ( IOException e ) { <START> e . VAR_4 ( ) ; <END> return "" ; } }
public static String METHOD_1 ( String VAR_1 ) { try ( TYPE_1 VAR_2 = new TYPE_1 ( new TYPE_2 ( VAR_1 ) ) ) { TYPE_3 buffer = new TYPE_3 ( ) ; String line ; while ( ( line = VAR_2 . METHOD_2 ( ) ) != null ) { buffer . append ( line . VAR_3 ( STRING_1 ) ) ; } return METHOD_3 ( buffer . toString ( ) ) ; } catch ( IOException e ) { return "" ; } }
needs synchronized VAR_1
<START> public static void METHOD_1 ( TYPE_1 source ) { <END> synchronized ( VAR_1 ) { VAR_1 . add ( source ) ; METHOD_2 ( ) ; } }
public static synchronized void METHOD_1 ( TYPE_1 source ) { VAR_1 . add ( source ) ; METHOD_2 ( ) ; }
needs synchronized VAR_2 / _CODE_ / initialize
<START> public static Map < String , TYPE_1 > METHOD_1 ( ) { <END> synchronized ( VAR_1 ) { if ( VAR_1 . isEmpty ( ) ) { for ( TYPE_2 source : VAR_2 ) { for ( TYPE_1 VAR_3 : source . VAR_4 ( ) ) { VAR_1 . put ( VAR_3 . getId ( ) , VAR_3 ) ; } } } } return Collections . VAR_5 ( VAR_1 ) ; }
public static synchronized Map < String , TYPE_1 > METHOD_1 ( ) { if ( VAR_1 . isEmpty ( ) ) { for ( TYPE_2 source : VAR_2 ) { for ( TYPE_1 VAR_3 : source . VAR_4 ( ) ) { VAR_1 . put ( VAR_3 . getId ( ) , VAR_3 ) ; } } } return Collections . VAR_5 ( VAR_1 ) ; }