Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
consider moving assertions separate method
public void METHOD_1 ( ) { METHOD_2 ( "" , "" ) ; METHOD_2 ( "" , STRING_1 ) ; METHOD_2 ( STRING_1 , STRING_2 ) ; METHOD_2 ( STRING_3 , STRING_4 ) ; METHOD_2 ( STRING_5 , STRING_6 ) ; <START> assertEquals ( 0 , METHOD_3 ( "" , "" ) ) ; <END> assertEquals ( 0 , METHOD_3 ( STRING_1 , STRING_1 ) ) ; assertTrue ( METHOD_3 ...
public void METHOD_1 ( ) { METHOD_2 ( "" , "" ) ; METHOD_2 ( "" , STRING_1 ) ; METHOD_2 ( STRING_1 , STRING_2 ) ; METHOD_2 ( STRING_3 , STRING_4 ) ; METHOD_2 ( STRING_5 , STRING_6 ) ; }
needed VAR_2 implies VAR_1 ( explicitly chosen _CODE_ ( false ) _CODE_ ( true ) )
private boolean METHOD_1 ( byte [ ] buf , int p ) { <START> if ( VAR_1 || VAR_2 ) <END> return METHOD_2 ( buf [ p ] ) == CHAR_1 && METHOD_2 ( buf [ p + 1 ] ) == CHAR_2 && METHOD_2 ( buf [ p + 2 ] ) == CHAR_3 ; return buf [ p ] == CHAR_1 && buf [ p + 1 ] == CHAR_2 && buf [ p + 2 ] == CHAR_3 ; }
private boolean METHOD_1 ( byte [ ] buf , int p ) { if ( VAR_2 ) return METHOD_2 ( buf [ p ] ) == CHAR_1 && METHOD_2 ( buf [ p + 1 ] ) == CHAR_2 && METHOD_2 ( buf [ p + 2 ] ) == CHAR_3 ; return buf [ p ] == CHAR_1 && buf [ p + 1 ] == CHAR_2 && buf [ p + 2 ] == CHAR_3 ; }
add single space {
void METHOD_1 ( long id , long VAR_1 , long VAR_2 ) { VAR_3 . METHOD_2 ( ) ; <START> if ( VAR_4 . length > 0 ) { <END> METHOD_3 ( VAR_4 [ ( int ) VAR_5 . METHOD_4 ( ) ] ) ; } }
void METHOD_1 ( long id , long VAR_1 , long VAR_2 ) { VAR_3 . METHOD_2 ( ) ; if ( VAR_4 != null && VAR_4 . length > 0 ) { METHOD_3 ( VAR_4 [ ( int ) VAR_5 . METHOD_4 ( ) ] ) ; } }
d METHOD_1 stuff call super METHOD_1 ( )
public void METHOD_1 ( ) { <START> super . METHOD_1 ( ) ; <END> if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; } }
public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; } super . METHOD_1 ( ) ; }
convention a monitor passed s param
protected TYPE_1 execute ( TYPE_2 client , TYPE_3 monitor ) throws TYPE_4 { <START> return client . VAR_1 ( METHOD_1 ( ) , getMessage ( ) , METHOD_2 ( ) , METHOD_3 ( ) , METHOD_4 ( ) , monitor , METHOD_5 ( ) ) ; <END> }
protected TYPE_1 execute ( TYPE_2 client , TYPE_3 monitor ) throws TYPE_4 { return client . VAR_1 ( METHOD_1 ( ) , getMessage ( ) , METHOD_2 ( ) , METHOD_3 ( ) , METHOD_4 ( ) , METHOD_5 ( ) , monitor ) ; }
return TYPE_1 METHOD_2 ( ) equals ( TYPE_1 VAR_1 )
private boolean METHOD_1 ( ) { <START> if ( TYPE_1 . METHOD_2 ( ) . equals ( TYPE_1 . VAR_1 ) ) { <END> return true ; } return false ; }
private boolean METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( ) . equals ( TYPE_1 . VAR_1 ) ; }
making * * s null ? ; )
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = ( TYPE_1 ) VAR_1 . METHOD_2 ( VAR_3 ) ; if ( VAR_2 == null ) { <START> if ( VAR_2 == null ) { <END> VAR_2 = new TYPE_1 ( VAR_1 ) ; VAR_1 . METHOD_3 ( VAR_3 , VAR_2 ) ; } } return VAR_2 ; }
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = ( TYPE_1 ) VAR_1 . METHOD_2 ( VAR_3 ) ; if ( VAR_2 == null ) { VAR_2 = new TYPE_1 ( VAR_1 ) ; VAR_1 . METHOD_3 ( VAR_3 , VAR_2 ) ; } return VAR_2 ; }
minor case a reference new TYPE_2 need a map lookup case
public void METHOD_1 ( long id , File VAR_1 ) throws TYPE_1 { if ( ! VAR_2 . containsKey ( id ) ) { VAR_2 . put ( id , new TYPE_2 ( this ) ) ; } <START> TYPE_2 stream = VAR_2 . get ( id ) ; <END> stream . VAR_3 ( new TYPE_3 ( stream , VAR_1 ) ) ; }
public void METHOD_1 ( long id , File VAR_1 ) throws TYPE_1 { TYPE_2 stream = null ; if ( VAR_2 . containsKey ( id ) ) { stream = VAR_2 . get ( id ) ; } else { stream = new TYPE_2 ( this ) ; VAR_2 . put ( id , stream ) ; } stream . VAR_3 ( new TYPE_3 ( stream , VAR_1 ) ) ; }
remote
public void METHOD_1 ( long VAR_1 ) { <START> this . VAR_2 = VAR_1 ; <END> }
public void METHOD_1 ( long VAR_1 ) { VAR_2 = VAR_1 ; }
remove
public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> this . VAR_2 = VAR_1 ; <END> }
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = VAR_1 ; }
I guess WIP part
public void METHOD_1 ( final ANNOTATION_1 TYPE_1 event ) { super . METHOD_1 ( event ) ; if ( event != null && event . VAR_1 ( ) != trace ) { <START> System . out . println ( STRING_1 ) ; <END> } if ( event != null && event . VAR_1 ( ) == trace ) { VAR_2 . METHOD_2 ( event ) ; } }
public void METHOD_1 ( final ANNOTATION_1 TYPE_1 event ) { super . METHOD_1 ( event ) ; if ( event != null && event . VAR_1 ( ) == trace ) { VAR_2 . METHOD_2 ( event ) ; } }
public modifier consistency
<START> int METHOD_1 ( TYPE_1 entry ) { <END> TYPE_2 item = VAR_1 . get ( entry ) ; if ( item == null ) { return - 1 ; } return item . VAR_2 ; }
public int METHOD_1 ( TYPE_1 entry ) { TYPE_2 item = VAR_1 . get ( entry ) ; if ( item == null ) { return - 1 ; } return item . VAR_2 ; }
braces single line block
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 commit ) { <START> if ( commit . VAR_3 ( ) != 1 ) { <END> throw new TYPE_3 ( STRING_1 ) ; } this . VAR_2 = VAR_2 ; this . commit = commit ; }
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 commit ) { if ( commit . VAR_3 ( ) != 1 ) throw new TYPE_3 ( STRING_1 ) ; this . VAR_2 = VAR_2 ; this . commit = commit ; }
method
public void METHOD_1 ( ) { <START> super . METHOD_1 ( ) ; <END> VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_2 ( VAR_3 ) ; VAR_1 . METHOD_2 ( VAR_4 ) ; VAR_1 . METHOD_2 ( VAR_5 ) ; VAR_1 . METHOD_2 ( VAR_6 ) ; }
public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_2 ( VAR_3 ) ; VAR_1 . METHOD_2 ( VAR_4 ) ; VAR_1 . METHOD_2 ( VAR_5 ) ; VAR_1 . METHOD_2 ( VAR_6 ) ; super . METHOD_1 ( ) ; }
remove assertion reached
public void METHOD_1 ( ) { VAR_1 . add ( null ) ; <START> assertTrue ( VAR_1 . METHOD_2 ( ) . isEmpty ( ) ) ; <END> }
public void METHOD_1 ( ) { VAR_1 . add ( null ) ; }
checking list ( ) remove ( ) s avoid double iterations
public void METHOD_1 ( TYPE_1 listener ) { <START> if ( METHOD_2 ( listener ) ) { <END> VAR_1 . remove ( listener ) ; } }
public void METHOD_1 ( TYPE_1 listener ) { VAR_1 . remove ( listener ) ; }
remove syserrs
public String METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = TYPE_1 . METHOD_2 ( METHOD_3 ( ) . getClass ( ) ) ; } <START> System . err . println ( VAR_1 ) ; <END> return VAR_1 ; }
public String METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = TYPE_1 . METHOD_2 ( METHOD_3 ( ) . getClass ( ) ) ; } return VAR_1 ; }
3rd a weird condition : I add attribute 0 ( tid ) a subattribute 0 ( cpu ) throws exception asserts I noticed
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null || VAR_1 . getName ( ) == null || <START> VAR_1 . getName ( ) . equals ( this . getName ( ) ) ) { <END> throw new IllegalArgumentException ( ) ; } VAR_2 . put ( VAR_1 . getName ( ) , VAR_1 ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null || VAR_1 . getName ( ) == null ) { throw new IllegalArgumentException ( ) ; } VAR_2 . put ( VAR_1 . getName ( ) , VAR_1 ) ; }
a Set instead ArrayList
public TYPE_1 < TYPE_2 > METHOD_1 ( ) { <START> List < TYPE_2 > VAR_1 = new ArrayList < > ( ) ; <END> TYPE_3 factory = new TYPE_3 ( ) ; switch ( VAR_2 ) { case VAR_3 : VAR_1 . add ( factory . VAR_4 ( ) ) ; VAR_1 . add ( factory . VAR_5 ( ) ) ; break ; case VAR_6 : VAR_1 . add ( factory . VAR_7 ( ) ) ; VAR_1 . add ( fac...
public TYPE_1 < TYPE_2 > METHOD_1 ( ) { Set < TYPE_2 > VAR_1 = new HashSet < > ( ) ; TYPE_3 factory = new TYPE_3 ( ) ; switch ( VAR_2 ) { case VAR_3 : VAR_1 . add ( factory . VAR_4 ( ) ) ; VAR_1 . add ( factory . VAR_5 ( ) ) ; break ; case VAR_6 : VAR_1 . add ( factory . VAR_7 ( ) ) ; VAR_1 . add ( factory . VAR_5 ( ) ...
syserr
public int METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; int VAR_2 = 0 ; if ( VAR_1 instanceof TYPE_2 ) { VAR_2 = ( ( TYPE_2 ) VAR_1 ) . METHOD_3 ( ) . length ; if ( VAR_1 instanceof TYPE_3 ) { for ( TYPE_4 VAR_3 : ( ( TYPE_3 ) VAR_1 ) . METHOD_4 ( ) ) { if ( VAR_3 . METHOD_5 ( ) ) { <START> System . err . println ( STR...
public int METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; int VAR_2 = 0 ; if ( VAR_1 instanceof TYPE_2 ) { VAR_2 = ( ( TYPE_2 ) VAR_1 ) . METHOD_3 ( ) . length ; if ( VAR_1 instanceof TYPE_3 ) { for ( TYPE_4 VAR_3 : ( ( TYPE_3 ) VAR_1 ) . METHOD_4 ( ) ) { if ( VAR_3 . METHOD_5 ( ) ) { break ; } else { VAR_2 ++ ; } } } } ...
don t braces single line blocks
TYPE_1 ( String name , String path , String VAR_2 ) { this . name = name ; this . path = path ; this . VAR_2 = new HashSet < String > ( ) ; <START> if ( VAR_2 != null && VAR_2 . length ( ) > 0 ) { <END> this . VAR_2 . addAll ( Arrays . asList ( VAR_2 . split ( STRING_1 ) ) ) ; } }
TYPE_1 ( String name , String path , String VAR_2 ) { this . name = name ; this . path = path ; this . VAR_2 = new HashSet < String > ( ) ; if ( VAR_2 != null && VAR_2 . length ( ) > 0 ) this . VAR_2 . addAll ( Arrays . asList ( VAR_2 . split ( STRING_1 ) ) ) ; }
need levels / finally input closed TYPE_2 fails create
void METHOD_1 ( ) throws IOException { TYPE_1 input = new TYPE_1 ( VAR_1 ) ; TYPE_2 output = new TYPE_2 ( VAR_2 ) ; try { TYPE_3 channel = input . VAR_3 ( ) ; output . VAR_3 ( ) . METHOD_2 ( channel , 0 , channel . size ( ) ) ; <START> } finally { input . close ( ) ; output . close ( ) ; } <END> }
void METHOD_1 ( ) throws IOException { TYPE_1 input = new TYPE_1 ( VAR_1 ) ; try { TYPE_2 output = new TYPE_2 ( VAR_2 ) ; try { TYPE_3 channel = input . VAR_3 ( ) ; output . VAR_3 ( ) . METHOD_2 ( channel , 0 , channel . size ( ) ) ; } finally { output . close ( ) ; } } finally { input . close ( ) ; } }
wrap / finally ensure streams closed case failure
void METHOD_1 ( ) throws IOException { TYPE_1 input = new TYPE_1 ( VAR_1 ) ; TYPE_2 output = new TYPE_2 ( VAR_2 ) ; <START> TYPE_3 channel = input . VAR_3 ( ) ; output . VAR_3 ( ) . METHOD_2 ( channel , 0 , channel . size ( ) ) ; input . close ( ) ; output . close ( ) ; <END> }
void METHOD_1 ( ) throws IOException { TYPE_1 input = new TYPE_1 ( VAR_1 ) ; TYPE_2 output = new TYPE_2 ( VAR_2 ) ; try { TYPE_3 channel = input . VAR_3 ( ) ; output . VAR_3 ( ) . METHOD_2 ( channel , 0 , channel . size ( ) ) ; } finally { input . close ( ) ; output . close ( ) ; } }
order matter
private static Map < String , String > METHOD_1 ( TYPE_1 configuration ) throws IOException { <START> Map < String , String > VAR_1 = new HashMap < String , String > ( TYPE_2 . METHOD_2 ( ) ) ; <END> VAR_1 . METHOD_3 ( configuration . VAR_2 ( ) ) ; return VAR_1 ; }
private static Map < String , String > METHOD_1 ( TYPE_1 configuration ) throws IOException { Map < String , String > VAR_1 = TYPE_2 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( configuration . VAR_2 ( ) ) ; return VAR_1 ; }
I return a string
<START> public TYPE_1 METHOD_1 ( ) { <END> return version ; }
public String METHOD_1 ( ) { return version ; }
need qualify access TYPE_2 type
public boolean METHOD_1 ( ) { <START> return Type . VAR_1 . equals ( type ) && TYPE_3 . TYPE_2 . METHOD_2 ( version ) < 0 ; <END> }
public boolean METHOD_1 ( ) { return Type . VAR_1 . equals ( type ) && TYPE_2 . METHOD_2 ( version ) < 0 ; }
add a text show output means running benchmark I d need more verbose ; - )
private static TYPE_1 METHOD_1 ( long start , long VAR_1 ) { <START> return System . out . format ( STRING_1 , FLOAT_1 * ( VAR_1 - start ) ) ; <END> }
private static void METHOD_1 ( long start , long VAR_1 ) { System . out . format ( STRING_1 , FLOAT_1 * ( VAR_1 - start ) ) ; }
style : early return avoid need else { } statements else case
boolean add ( TYPE_1 VAR_1 ) { if ( VAR_2 . METHOD_1 ( VAR_1 ) ) return false ; <START> else { <END> VAR_2 . add ( VAR_1 ) ; return true ; } }
boolean add ( TYPE_1 VAR_1 ) { if ( VAR_2 . METHOD_1 ( VAR_1 ) ) return false ; VAR_2 . add ( VAR_1 ) ; return true ; }
part a commit
public Response METHOD_1 ( ANNOTATION_1 ( STRING_1 ) String VAR_1 ) { Response response ; TYPE_1 result = VAR_2 . METHOD_2 ( VAR_3 , VAR_1 ) ; if ( result == null ) { response = Response . status ( Response . Status . VAR_4 ) . entity ( TYPE_3 . TYPE_4 ) . build ( ) ; } else { <START> response = Response . status ( Res...
public Response METHOD_1 ( ANNOTATION_1 ( STRING_1 ) String VAR_1 ) { Response response ; TYPE_1 result = VAR_2 . METHOD_2 ( VAR_3 , VAR_1 ) ; if ( result == null ) { response = Response . status ( Response . Status . VAR_4 ) . entity ( TYPE_3 . TYPE_4 ) . build ( ) ; } else { response = Response . status ( Response . ...
remove field create function _CODE_ method
public TYPE_9 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { TYPE_2 VAR_4 = TYPE_3 . METHOD_1 ( VAR_3 , this ) ; <START> this . VAR_5 = new TYPE_4 ( ) ; <END> this . VAR_6 = new TYPE_5 ( VAR_2 , VAR_4 ) ; this . VAR_7 = new TYPE_6 ( VAR_2 , VAR_4 ) ; this . VAR_8 = new TYPE_7 ( VAR_2 , VAR_4 ) ; this . VAR_9 = new TYPE_8 ( VAR_2 , ...
public TYPE_9 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { TYPE_2 VAR_4 = TYPE_3 . METHOD_1 ( VAR_3 , this ) ; this . VAR_6 = new TYPE_5 ( VAR_2 , VAR_4 ) ; this . VAR_7 = new TYPE_6 ( VAR_2 , VAR_4 ) ; this . VAR_8 = new TYPE_7 ( VAR_2 , VAR_4 ) ; this . VAR_9 = new TYPE_8 ( VAR_2 , VAR_4 ) ; }
I don t a catch block rethrow exception
public void METHOD_1 ( final TYPE_1 monitor ) throws TYPE_2 { try { ( new TYPE_3 < Integer > ( this ) { @Override public Integer execute ( ) throws TYPE_2 { call ( monitor , VAR_1 ) ; return - 1 ; } } ) . execute ( ) ; <START> } catch ( TYPE_2 e ) { <END> e . VAR_2 ( ) ; throw e ; } finally { VAR_3 = - 1 ; token = null...
public void METHOD_1 ( final TYPE_1 monitor ) throws TYPE_2 { try { ( new TYPE_3 < Integer > ( this ) { @Override public Integer execute ( ) throws TYPE_2 { call ( monitor , VAR_1 ) ; return - 1 ; } } ) . execute ( ) ; } finally { VAR_3 = - 1 ; token = null ; } return ; }
call METHOD_2 logging pass monitor
public void METHOD_1 ( final TYPE_1 monitor ) throws TYPE_2 { VAR_1 = - 1 ; token = null ; ( new TYPE_3 < Integer > ( this ) { ANNOTATION_1 ( STRING_1 ) @Override public Integer execute ( ) throws TYPE_2 { try { <START> VAR_2 . METHOD_2 ( null ) ; <END> } catch ( TYPE_4 e ) { e . VAR_3 ( ) ; } Object response = call ( ...
public void METHOD_1 ( final TYPE_1 monitor ) throws TYPE_2 { VAR_1 = - 1 ; token = null ; ( new TYPE_3 < Integer > ( this ) { ANNOTATION_1 ( STRING_1 ) @Override public Integer execute ( ) throws TYPE_2 { try { VAR_2 . METHOD_2 ( monitor ) ; } catch ( TYPE_4 e ) { e . VAR_3 ( ) ; } Object response = call ( monitor , V...
null passed
<START> public static boolean METHOD_1 ( byte [ ] VAR_1 ) { <END> return VAR_1 . length > 4 && VAR_1 [ 0 ] == CHAR_1 && VAR_1 [ 1 ] == CHAR_2 && VAR_1 [ 2 ] == 3 && VAR_1 [ 3 ] == 4 ; }
public static boolean METHOD_1 ( byte [ ] VAR_1 ) { return VAR_1 != null && VAR_1 . length > 4 && VAR_1 [ 0 ] == CHAR_1 && VAR_1 [ 1 ] == CHAR_2 && VAR_1 [ 2 ] == 3 && VAR_1 [ 3 ] == 4 ; }
consider file adding files ( STRING_1 ) result
public void METHOD_1 ( String VAR_1 , File file ) throws Exception { TYPE_1 VAR_2 = METHOD_2 ( ) ; TYPE_2 . METHOD_3 ( file , new File ( METHOD_4 ( ) , VAR_1 ) ) ; <START> VAR_2 . add ( ) . METHOD_5 ( STRING_1 ) . call ( ) ; <END> }
public void METHOD_1 ( String VAR_1 , File file ) throws Exception { TYPE_1 VAR_2 = METHOD_2 ( ) ; TYPE_2 . METHOD_3 ( file , new File ( METHOD_4 ( ) , VAR_1 ) ) ; VAR_2 . add ( ) . METHOD_5 ( VAR_1 ) . call ( ) ; }
static
<START> private TYPE_1 < byte [ ] > empty ( ) { <END> return METHOD_1 ( byte [ ] . class ) ; }
private static TYPE_1 < byte [ ] > empty ( ) { return METHOD_1 ( byte [ ] . class ) ; }
call super METHOD_1 ( )
public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; } if ( VAR_2 != null ) { VAR_2 . METHOD_1 ( ) ; <START> } <END> }
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; } if ( VAR_2 != null ) { VAR_2 . METHOD_1 ( ) ; } }
object _CODE_ provides a method allows add information dialog boundaries - > _CODE_ ( )
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 resource , Messages Messages ) { super ( VAR_2 ) ; this . resource = resource ; this . Messages = Messages ; <START> TYPE_3 . METHOD_1 ( ) . METHOD_2 ( this ) ; <END> }
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 resource , Messages Messages ) { super ( VAR_2 ) ; this . resource = resource ; this . Messages = Messages ; }
tests a instead ? I assume traces closed / disposed
public void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = ( TYPE_1 ) TYPE_3 . TYPE_4 . METHOD_2 ( ) ; <END> assertNotNull ( VAR_1 ) ; }
public void METHOD_1 ( ) { VAR_1 = TYPE_3 . TYPE_4 . METHOD_2 ( ) ; assertNotNull ( VAR_1 ) ; }
want RAF ( s royal air force ) read events ? a separate local ( pass parameter METHOD_2 ) close opening real events
public void METHOD_1 ( TYPE_1 resource , String path , Class < ? extends TYPE_2 > type ) throws TYPE_3 { super . METHOD_1 ( resource , path , type ) ; VAR_1 = new File ( path ) ; try { <START> VAR_2 = new TYPE_4 ( VAR_1 , STRING_1 ) ; <END> METHOD_2 ( ) ; } catch ( IOException e ) { } }
public void METHOD_1 ( TYPE_1 resource , String path , Class < ? extends TYPE_2 > type ) throws TYPE_3 { super . METHOD_1 ( resource , path , type ) ; VAR_1 = new File ( path ) ; try { VAR_2 = new TYPE_4 ( VAR_1 , STRING_1 ) ; METHOD_2 ( VAR_2 ) ; } catch ( IOException e ) { } }
Type checked casting
public Object METHOD_1 ( Object element , Class key ) { <START> TYPE_1 VAR_1 = ( TYPE_1 ) element ; <END> if ( TYPE_2 . class . equals ( key ) ) { return new TYPE_3 ( VAR_1 ) ; } return null ; }
public Object METHOD_1 ( Object element , Class key ) { if ( element instanceof TYPE_1 && TYPE_2 . class . equals ( key ) ) { TYPE_1 VAR_1 = ( TYPE_1 ) element ; return new TYPE_3 ( VAR_1 ) ; } return null ; }
a null check previous test classes ? null more others
public void METHOD_1 ( ) { <START> if ( VAR_1 != null ) { <END> VAR_1 . close ( ) ; } if ( VAR_2 != null ) { VAR_2 . METHOD_2 ( ) ; File VAR_3 = new File ( TYPE_1 . METHOD_3 ( VAR_2 ) ) ; METHOD_4 ( VAR_3 ) ; } }
public void METHOD_1 ( ) { VAR_1 . close ( ) ; if ( VAR_2 != null ) { VAR_2 . METHOD_2 ( ) ; File VAR_3 = new File ( TYPE_1 . METHOD_3 ( VAR_2 ) ) ; METHOD_4 ( VAR_3 ) ; } }
needed ? ( int id ) ? answer : iterate dingus ! I ll return iterable instead expose underlying data structure ( allow change underlying implementation _CODE_ breaking API )
<START> public List < TYPE_1 > METHOD_1 ( ) { <END> ArrayList < TYPE_1 > VAR_1 = new ArrayList < > ( VAR_2 ) ; VAR_1 . METHOD_2 ( Collections . VAR_3 ( null ) ) ; return VAR_1 ; }
public Collection < TYPE_1 > METHOD_1 ( ) { ArrayList < TYPE_1 > VAR_1 = new ArrayList < > ( VAR_2 ) ; VAR_1 . METHOD_2 ( Collections . VAR_3 ( null ) ) ; return VAR_1 ; }
need a concurrent data structure a regular list a linkedlist variable local subject comodification
public TYPE_1 METHOD_1 ( String string ) { <START> for ( TYPE_1 state : new TYPE_2 < TYPE_1 > ( VAR_1 ) ) { <END> if ( state . getName ( ) . equals ( string ) ) { return state ; } } return null ; }
public TYPE_1 METHOD_1 ( String string ) { for ( TYPE_1 state : VAR_1 ) { if ( state . getName ( ) . equals ( string ) ) { return state ; } } return null ; }
VAR_1 allowed null
public TYPE_1 METHOD_1 ( TYPE_2 context , TYPE_3 VAR_1 ) { <START> if ( VAR_1 == null ) { <END> return TYPE_1 . VAR_2 ; } return TYPE_1 . VAR_3 ; }
public TYPE_1 METHOD_1 ( TYPE_2 context , TYPE_3 VAR_1 ) { return TYPE_1 . VAR_3 ; }
more descriptive string put a constant
public void METHOD_1 ( int VAR_1 ) { int VAR_2 = VAR_3 . size ( ) + 1 ; if ( ! METHOD_2 ( ) ) { throw new TYPE_1 ( STRING_1 ) ; } <START> String VAR_4 = STRING_2 ; <END> METHOD_3 ( VAR_2 , false ) ; int VAR_5 = 1 ; while ( ! VAR_4 . equals ( VAR_6 ) && VAR_5 <= VAR_1 ) { VAR_4 = VAR_6 ; METHOD_4 ( VAR_5 ++ ) ; METHOD_3...
public void METHOD_1 ( int VAR_1 ) { int VAR_2 = VAR_3 . size ( ) + 1 ; if ( ! METHOD_2 ( ) ) { throw new TYPE_1 ( STRING_1 ) ; } String VAR_4 = null ; METHOD_3 ( VAR_2 , false ) ; int VAR_5 = 1 ; while ( ! VAR_4 . equals ( VAR_6 ) && VAR_5 <= VAR_1 ) { VAR_4 = VAR_6 ; METHOD_4 ( VAR_5 ++ ) ; METHOD_3 ( VAR_2 , false )...
lists
private TYPE_1 [ ] METHOD_1 ( ) { <START> TYPE_1 [ ] VAR_1 = new TYPE_1 [ 10 ] ; <END> for ( int i = 0 ; i < VAR_1 . length ; i ++ ) { VAR_1 [ i ] = new TYPE_1 ( i ) ; } return VAR_1 ; }
private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; for ( int i = 0 ; i < 10 ; i ++ ) { VAR_1 . add ( new TYPE_1 ( i ) ) ; } return VAR_1 ; }
list
private TYPE_1 [ ] METHOD_1 ( ) { <START> TYPE_1 [ ] VAR_1 = new TYPE_1 [ INT_1 ] ; <END> for ( int i = 0 ; i < VAR_1 . length - 1 ; i ++ ) { VAR_1 [ i ] = new TYPE_1 ( i ) ; } VAR_1 [ VAR_1 . length - 1 ] = new TYPE_1 ( INT_2 ) ; return VAR_1 ; }
private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; for ( int i = 0 ; i < 10 ; i ++ ) { VAR_1 . add ( new TYPE_1 ( i ) ) ; } return VAR_1 ; }
( VAR_1 instanceof TYPE_1 )
public TYPE_1 METHOD_1 ( String name ) { TYPE_2 VAR_1 = METHOD_2 ( name ) ; <START> return ( TYPE_1 ) ( ( VAR_1 . METHOD_3 ( ) instanceof TYPE_3 ) ? VAR_1 : null ) ; <END> }
public TYPE_1 METHOD_1 ( String name ) { TYPE_2 VAR_1 = METHOD_2 ( name ) ; return ( TYPE_1 ) ( ( VAR_1 instanceof TYPE_1 ) ? VAR_1 : null ) ; }
t constructor field VAR_1 final
public TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = this ; while ( VAR_1 . METHOD_2 ( ) != null && VAR_1 . METHOD_2 ( ) . METHOD_2 ( ) != null ) { VAR_1 = VAR_1 . METHOD_2 ( ) ; <START> } <END> } return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { return VAR_1 ; }
included _CODE_ ( )
public void METHOD_1 ( ) throws Exception { String VAR_1 = STRING_1 ; METHOD_2 ( VAR_1 , STRING_2 ) ; VAR_2 . add ( ) . METHOD_3 ( VAR_1 ) . call ( ) ; TYPE_1 VAR_3 = VAR_2 . METHOD_4 ( ) . call ( ) ; <START> assertNotNull ( VAR_3 ) ; <END> METHOD_5 ( VAR_3 ) ; assertTrue ( STRING_3 , VAR_4 . exists ( ) ) ; assertEqual...
public void METHOD_1 ( ) throws Exception { String VAR_1 = STRING_1 ; METHOD_2 ( VAR_1 , STRING_2 ) ; VAR_2 . add ( ) . METHOD_3 ( VAR_1 ) . call ( ) ; TYPE_1 VAR_3 = VAR_2 . METHOD_4 ( ) . call ( ) ; METHOD_5 ( VAR_3 ) ; assertTrue ( STRING_3 , VAR_4 . exists ( ) ) ; assertEquals ( STRING_4 , read ( VAR_4 ) ) ; }
returns early : ( VAR_2 getType ( ) = = TYPE_1 VAR_4 && METHOD_2 ( VAR_2 ) ) return true ;
private static boolean METHOD_1 ( TYPE_1 [ ] VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 ) { if ( VAR_2 . getType ( ) == TYPE_1 . VAR_3 ) return true ; else if ( VAR_2 . getType ( ) == TYPE_1 . VAR_4 ) <START> return METHOD_2 ( VAR_2 ) ; <END> } return false ; }
private static boolean METHOD_1 ( TYPE_1 [ ] VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 ) { if ( VAR_2 . getType ( ) == TYPE_1 . VAR_3 ) return true ; else if ( VAR_2 . getType ( ) == TYPE_1 . VAR_4 ) if ( METHOD_2 ( VAR_2 ) ) return true ; } return false ; }
line statement
public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( ) ; if ( VAR_1 != null ) { <START> this . VAR_1 = VAR_1 ; <END> VAR_1 . METHOD_3 ( this ) ; VAR_1 . METHOD_4 ( VAR_2 ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( ) ; this . VAR_1 = VAR_1 ; if ( VAR_1 != null ) { VAR_1 . METHOD_3 ( this ) ; VAR_1 . METHOD_4 ( VAR_2 ) ; } }
I d catch org eclipse emf common util _CODE_ instead exceptions wouldn t sufficient
protected void METHOD_1 ( TYPE_1 resource , IOException exception ) throws RuntimeException { try { super . METHOD_1 ( resource , exception ) ; <START> } catch ( Exception e ) { <END> } }
protected void METHOD_1 ( TYPE_1 resource , IOException exception ) throws RuntimeException { try { super . METHOD_1 ( resource , exception ) ; } catch ( RuntimeException e ) { } }
_CODE_ implementation takes care remove test
public void METHOD_1 ( TYPE_1 listener ) { <START> if ( ! METHOD_2 ( listener ) ) { <END> VAR_1 . add ( listener ) ; } }
public void METHOD_1 ( TYPE_1 listener ) { VAR_1 . add ( listener ) ; }
suggestion Throwable incorrect version patch set #2 simpler
private TYPE_1 [ ] METHOD_1 ( int offset ) { TYPE_1 [ ] VAR_1 = null ; boolean VAR_2 = false ; try { if ( VAR_3 != null ) { VAR_1 = VAR_4 . METHOD_2 ( VAR_3 , offset ) ; } else { VAR_1 = VAR_4 . METHOD_2 ( VAR_5 , offset ) ; } <START> VAR_2 = true ; <END> } finally { if ( ! VAR_2 ) { METHOD_3 ( ) ; } } return VAR_1 ; }
private TYPE_1 [ ] METHOD_1 ( int offset ) { if ( VAR_3 != null ) return VAR_4 . METHOD_2 ( VAR_3 , offset ) ; return VAR_4 . METHOD_2 ( VAR_5 , offset ) ; }
nest
public void METHOD_1 ( Thread t , Throwable e ) { if ( e instanceof TYPE_1 ) { } else { <START> if ( VAR_1 != null ) { <END> VAR_1 . add ( TYPE_2 . METHOD_2 ( e ) ) ; } else { TYPE_3 . METHOD_3 ( ) . log ( e ) ; } } }
public void METHOD_1 ( Thread t , Throwable e ) { if ( e instanceof TYPE_1 ) { } else if ( VAR_1 != null ) { VAR_1 . add ( TYPE_2 . METHOD_2 ( e ) ) ; } else { TYPE_3 . METHOD_3 ( ) . log ( e ) ; } }
a constants static final array changes need - creating array time
private String [ ] METHOD_1 ( ) { String [ ] VAR_1 = { STRING_1 , STRING_2 , STRING_3 , STRING_4 , STRING_5 , STRING_6 , STRING_7 , STRING_8 , STRING_9 , STRING_10 , STRING_11 , <START> STRING_12 } ; <END> return VAR_1 ; }
private static String [ ] METHOD_1 ( ) { String [ ] VAR_1 = { STRING_1 , STRING_2 , STRING_3 , STRING_4 , STRING_5 , STRING_6 , STRING_7 , STRING_8 , STRING_9 , STRING_10 , STRING_11 , STRING_12 } ; return VAR_1 ; }
API breakage returned collection modifiable more I m affected
public Collection < TYPE_1 > call ( ) throws TYPE_2 , TYPE_3 , org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_4 { <START> return METHOD_1 ( ) . values ( ) ; <END> }
public Collection < TYPE_1 > call ( ) throws TYPE_2 , TYPE_3 , org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_4 { return execute ( ) . values ( ) ; }
method synchronized
<START> private void METHOD_1 ( ) { <END> if ( ! VAR_1 ) { for ( TYPE_1 VAR_2 : TYPE_2 . METHOD_2 ( TYPE_6 . TYPE_4 , TYPE_3 . METHOD_3 ( ) ) ) { TYPE_4 user = ( TYPE_4 ) VAR_2 ; TYPE_5 VAR_5 = new TYPE_5 ( user ) ; VAR_6 . put ( user . VAR_7 ( ) , VAR_5 ) ; VAR_8 . put ( user . getName ( ) , VAR_5 ) ; } VAR_1 = true ;...
protected synchronized void METHOD_1 ( ) { if ( ! VAR_1 ) { for ( TYPE_1 VAR_2 : TYPE_2 . METHOD_2 ( TYPE_6 . TYPE_4 , TYPE_3 . METHOD_3 ( ) ) ) { TYPE_4 user = ( TYPE_4 ) VAR_2 ; TYPE_5 VAR_5 = new TYPE_5 ( user ) ; VAR_6 . put ( user . VAR_7 ( ) , VAR_5 ) ; VAR_8 . put ( user . getName ( ) , VAR_5 ) ; } VAR_1 = true ...
move 1 line remove call _CODE_ METHOD_4
public void METHOD_1 ( ) { METHOD_2 ( ) ; <START> METHOD_3 ( ) ; <END> METHOD_4 ( ) ; }
public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_4 ( ) ; METHOD_3 ( ) ; }
private remove tag
<START> protected void METHOD_1 ( TYPE_1 VAR_1 ) { <END> this . VAR_1 = VAR_1 ; }
private void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; }
I prefer public s impossible clients correctly initialize class mark hide API
<START> private void METHOD_1 ( TYPE_1 VAR_1 ) { <END> this . VAR_1 = VAR_1 ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; }
pass parameters instead null checks
public TYPE_6 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { <START> super ( STRING_1 , VAR_5 , VAR_2 , VAR_3 == null <END> ? ( TYPE_4 . METHOD_1 ( ) == null ? new TYPE_4 ( ) : TYPE_4 . METHOD_1 ( ) ) : VAR_3 , VAR_4 == null ? new TYPE_5 ( ) : VAR_4 ) ; METHOD_2 ( true ) ; METHOD_3 ( true ) ; }
public TYPE_6 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { super ( STRING_1 , VAR_5 , VAR_2 , VAR_3 , VAR_4 ) ; METHOD_2 ( true ) ; METHOD_3 ( true ) ; }
VAR_2 null happen shouldn t bail point ? brackets needed
private boolean METHOD_1 ( ) throws IOException { TYPE_1 repo = METHOD_2 ( ) ; TYPE_2 VAR_1 = new TYPE_2 ( repo ) ; VAR_1 . METHOD_3 ( true ) ; final TYPE_3 VAR_2 = repo . VAR_3 ( STRING_1 ) ; if ( VAR_2 != null ) <START> VAR_1 . METHOD_4 ( new TYPE_4 ( repo ) . METHOD_5 ( VAR_2 ) ) ; <END> VAR_1 . METHOD_4 ( new TYPE_...
private boolean METHOD_1 ( ) throws IOException { final TYPE_1 repo = METHOD_2 ( ) ; final TYPE_2 VAR_1 = new TYPE_2 ( repo ) ; VAR_1 . METHOD_3 ( true ) ; final TYPE_3 VAR_2 = repo . VAR_3 ( STRING_1 ) ; if ( VAR_2 != null ) { VAR_1 . METHOD_4 ( new TYPE_4 ( repo ) . METHOD_5 ( VAR_2 ) ) ; } VAR_1 . METHOD_4 ( new TYP...
style : don t braces single line blocks
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; <START> for ( TYPE_1 VAR_1 : this . VAR_2 ) { <END> VAR_1 . METHOD_1 ( ) ; } }
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; for ( TYPE_1 VAR_1 : this . VAR_2 ) VAR_1 . METHOD_1 ( ) ; }
applying VAR_1 package time ? s command
public boolean add ( Object o ) { if ( ! ( o instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = TYPE_2 . METHOD_1 ( ( TYPE_1 ) o , VAR_2 ) ; TYPE_3 command = new TYPE_4 ( VAR_2 , VAR_1 , ( TYPE_5 ) VAR_3 ) ; VAR_4 . add ( command ) ; <START> VAR_4 . add ( new TYPE_4 ( VAR_2 , VAR_1 , ( TYPE_5 ) VAR_3 ) ) ; <END> r...
public boolean add ( Object o ) { if ( ! ( o instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = TYPE_2 . METHOD_1 ( ( TYPE_1 ) o , VAR_2 ) ; TYPE_3 command = new TYPE_4 ( VAR_2 , VAR_1 , ( TYPE_5 ) VAR_3 ) ; VAR_4 . add ( command ) ; return VAR_5 . add ( o ) ; }
instruction abstract class fields belong super ( set parent VAR_2 ) ;
public TYPE_4 ( TYPE_1 set , TYPE_2 parent , Collection < TYPE_3 > VAR_2 ) { super ( set ) ; this . VAR_2 = VAR_2 ; <START> this . parent = parent ; <END> }
public TYPE_4 ( TYPE_1 set , TYPE_2 parent , Collection < TYPE_3 > VAR_2 ) { super ( set , parent , VAR_2 ) ; }
public methods METHOD_2 ( ) required
void METHOD_1 ( ) { <START> METHOD_2 ( ) ; <END> if ( VAR_1 == null ) return ; VAR_1 . METHOD_3 ( false ) ; }
void METHOD_1 ( ) { if ( VAR_1 == null ) return ; VAR_1 . METHOD_3 ( false ) ; }
public methods METHOD_2 ( ) required
void METHOD_1 ( int x , int y ) { <START> METHOD_2 ( ) ; <END> if ( VAR_1 == null ) return ; VAR_1 . METHOD_3 ( x , y ) ; VAR_1 . METHOD_4 ( true ) ; }
void METHOD_1 ( int x , int y ) { if ( VAR_1 == null ) return ; VAR_1 . METHOD_3 ( x , y ) ; VAR_1 . METHOD_4 ( true ) ; }
implementation restructured : int METHOD_1 ( ) { ( VAR_3 = = 0 || ( state & VAR_1 ) ! = 0 ) return 0 ; TYPE_1 VAR_2 = new TYPE_1 ( ) ; METHOD_2 ( VAR_3 VAR_2 ) ; return VAR_2 VAR_4 ; }
int METHOD_1 ( ) { if ( ( state & VAR_1 ) != 0 ) return 0 ; TYPE_1 VAR_2 = new TYPE_1 ( ) ; if ( VAR_3 != 0 ) { METHOD_2 ( VAR_3 , VAR_2 ) ; return VAR_2 . VAR_4 ; } else { return 0 ; <START> } <END> }
int METHOD_1 ( ) { if ( VAR_3 == 0 || ( state & VAR_1 ) != 0 ) return 0 ; TYPE_1 VAR_2 = new TYPE_1 ( ) ; METHOD_2 ( VAR_3 , VAR_2 ) ; return VAR_2 . VAR_4 ; }
point testing method marked a compiler check instead a unit test check means remove test altogether
public void METHOD_1 ( ) { <START> ANNOTATION_1 ( STRING_1 ) <END> TYPE_1 result = VAR_1 . METHOD_2 ( VAR_2 ) ; METHOD_3 ( result ) ; }
public void METHOD_1 ( ) { TYPE_1 result = VAR_1 . METHOD_2 ( VAR_2 ) ; METHOD_3 ( result ) ; }
redundant
private void METHOD_1 ( Object element , boolean VAR_1 ) { <START> VAR_2 . METHOD_2 ( element , VAR_1 ) ; <END> if ( VAR_1 ) { VAR_2 . METHOD_3 ( element , false ) ; } VAR_2 . METHOD_2 ( element , VAR_1 ) ; Object [ ] VAR_3 = VAR_4 . METHOD_4 ( element ) ; if ( VAR_3 != null ) { for ( Object child : VAR_3 ) { METHOD_1 ...
private void METHOD_1 ( Object element , boolean VAR_1 ) { VAR_2 . METHOD_2 ( element , VAR_1 ) ; if ( VAR_1 ) { VAR_2 . METHOD_3 ( element , false ) ; } Object [ ] VAR_3 = VAR_4 . METHOD_4 ( element ) ; if ( VAR_3 != null ) { for ( Object child : VAR_3 ) { METHOD_1 ( child , VAR_1 ) ; } } }
VAR_1 ! = null && VAR_1 METHOD_2 ! = nullif METHOD_1 called example proposition leads a NPE
public void METHOD_1 ( ) { <START> if ( VAR_1 . METHOD_2 ( ) != null ) { <END> VAR_1 . METHOD_3 ( ) . remove ( this ) ; } VAR_1 = null ; session = null ; }
public void METHOD_1 ( ) { if ( VAR_1 != null && VAR_1 . METHOD_2 ( ) != null ) { VAR_1 . METHOD_3 ( ) . remove ( this ) ; } VAR_1 = null ; session = null ; }
I m convinced needed free file descriptors don t close _CODE_ memory safe s more simple / representative VAR_1 null
public void close ( ) { <START> VAR_1 = TYPE_1 . VAR_3 ; <END> }
public void close ( ) { VAR_1 = null ; }
ANNOTATION_1 line
<START> private ANNOTATION_1 static List < TYPE_1 > METHOD_1 ( int size , int VAR_1 ) { <END> List < TYPE_1 > VAR_2 = new ArrayList < > ( size ) ; for ( int i = 0 ; i < size ; i ++ ) { String content = STRING_1 + i ; VAR_2 . add ( new TYPE_2 ( TYPE_3 . METHOD_2 ( VAR_1 , false , INT_1 , TYPE_5 . VAR_4 , TYPE_4 . VAR_6 ...
private static List < TYPE_1 > METHOD_1 ( int size , int VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( size ) ; for ( int i = 0 ; i < size ; i ++ ) { String content = STRING_1 + i ; VAR_2 . add ( new TYPE_2 ( TYPE_3 . METHOD_2 ( VAR_1 , false , INT_1 , TYPE_5 . VAR_4 , TYPE_4 . VAR_6 , content , INT_2 ) , null ...
annotation a separate line
<START> ANNOTATION_1 ByteBuffer METHOD_1 ( long position , long size ) throws TYPE_1 , IOException { <END> TYPE_2 map = VAR_1 . map ( TYPE_3 . VAR_3 , position , size ) ; if ( map == null ) { throw new TYPE_1 ( STRING_1 ) ; } return map ; }
ByteBuffer METHOD_1 ( long position , long size ) throws TYPE_1 , IOException { TYPE_2 map = VAR_1 . map ( TYPE_3 . VAR_3 , position , size ) ; if ( map == null ) { throw new TYPE_1 ( STRING_1 ) ; } return map ; }
Boolean toString ( true )
public TYPE_1 METHOD_1 ( Object VAR_1 , int VAR_2 ) { if ( VAR_1 instanceof TYPE_2 ) { TYPE_2 item = ( TYPE_2 ) VAR_1 ; String state = item . VAR_3 ( TYPE_2 . VAR_4 ) ; if ( state != null ) { <START> if ( state . equals ( STRING_1 ) ) { <END> return VAR_5 ; } else if ( state . equals ( STRING_2 ) ) { return VAR_6 ; } }...
public TYPE_1 METHOD_1 ( Object VAR_1 , int VAR_2 ) { if ( VAR_1 instanceof TYPE_2 ) { TYPE_2 item = ( TYPE_2 ) VAR_1 ; String state = item . VAR_3 ( TYPE_2 . VAR_4 ) ; if ( state != null ) { if ( state . equals ( Boolean . toString ( true ) ) ) { return VAR_5 ; } else if ( state . equals ( Boolean . toString ( false )...
style : don t braces single line blocks
public void METHOD_1 ( boolean VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; <START> if ( ! VAR_1 ) { <END> METHOD_2 ( null ) ; } }
public void METHOD_1 ( boolean VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; if ( ! VAR_1 ) METHOD_2 ( null ) ; }
increase give some space other visualizer 10
public int METHOD_1 ( TYPE_1 VAR_1 ) { int result = 0 ; Object VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 ) ; if ( VAR_2 instanceof TYPE_3 || VAR_2 instanceof TYPE_4 || VAR_2 instanceof TYPE_5 ) { <START> result = 2 ; <END> } METHOD_3 ( ) ; return result ; }
public int METHOD_1 ( TYPE_1 VAR_1 ) { int result = 0 ; Object VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 ) ; if ( VAR_2 instanceof TYPE_3 || VAR_2 instanceof TYPE_4 || VAR_2 instanceof TYPE_5 ) { result = 10 ; } METHOD_3 ( ) ; return result ; }
inline return ( need VAR_2 variable )
private TYPE_1 METHOD_1 ( TYPE_2 writer , boolean VAR_1 ) { TYPE_3 VAR_2 = builder . add ( TYPE_4 . VAR_4 ) . METHOD_2 ( VAR_1 ) . METHOD_3 ( "" , "" ) . name ( STRING_1 ) . create ( ) ; <START> return VAR_2 . METHOD_4 ( writer ) ; <END> }
private TYPE_1 METHOD_1 ( TYPE_2 writer , boolean VAR_1 ) { return builder . add ( TYPE_4 . VAR_4 ) . METHOD_2 ( VAR_1 ) . METHOD_3 ( "" , "" ) . name ( STRING_1 ) . create ( ) . METHOD_4 ( writer ) ; }
please stick java convention naming variables - letter case another case local variable needed return
private static TYPE_1 METHOD_1 ( TYPE_2 project ) { TYPE_3 VAR_1 = TYPE_4 . METHOD_2 ( project ) ; <START> TYPE_1 TYPE_5 = VAR_1 . METHOD_3 ( ) ; <END> return TYPE_5 ; }
private static TYPE_1 METHOD_1 ( TYPE_2 project ) { TYPE_3 VAR_1 = TYPE_4 . METHOD_2 ( project ) ; return VAR_1 . METHOD_3 ( ) ; }
don t put s a real warning atm rid ; )
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null ) { throw new IllegalArgumentException ( ) ; } TYPE_2 VAR_2 = TYPE_3 . getInstance ( ) . METHOD_2 ( ) ; if ( VAR_2 == null ) { VAR_3 = VAR_1 ; return ; } <START> ANNOTATION_1 ( STRING_1 ) <END> TYPE_1 VAR_4 = VAR_2 . METHOD_3 ( VAR_1 . getId ( ) ) ; if ( VAR_4 ...
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null ) { throw new IllegalArgumentException ( ) ; } TYPE_2 VAR_2 = TYPE_3 . getInstance ( ) . METHOD_2 ( ) ; if ( VAR_2 == null ) { VAR_3 = VAR_1 ; return ; } TYPE_1 VAR_4 = VAR_2 . METHOD_3 ( VAR_1 . getId ( ) ) ; if ( VAR_4 == VAR_1 ) { VAR_3 = VAR_1 ; } }
method return instance time ( meaning ) store a field named VAR_6
<START> public TYPE_4 . TYPE_5 METHOD_1 ( ) { <END> TYPE_2 VAR_1 = new TYPE_2 ( TYPE_6 . TYPE_7 . TYPE_5 . VAR_5 , TYPE_3 . METHOD_2 ( VAR_6 ) ) ; return VAR_1 ; }
public TYPE_4 . TYPE_5 METHOD_1 ( ) { return VAR_1 ; }
s worth changing remove _CODE_ TYPE_3 _error_ ! * gasp *
public TYPE_1 < TYPE_2 > METHOD_1 ( ) { <START> try ( TYPE_3 VAR_1 = METHOD_2 ( ) ; ) { <END> if ( VAR_1 != null ) { return VAR_1 . METHOD_1 ( ) ; } return Collections . VAR_2 ; } }
public TYPE_1 < TYPE_2 > METHOD_1 ( ) { TYPE_3 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 != null ) { return VAR_1 . METHOD_1 ( ) ; } return Collections . VAR_2 ; }
need ? t pass offset context region
<START> protected int METHOD_1 ( ) { <END> int start ; if ( VAR_1 instanceof TYPE_1 ) { TYPE_1 VAR_2 = ( TYPE_1 ) VAR_1 ; start = VAR_2 . METHOD_2 ( ) ; } else { start = VAR_3 . METHOD_3 ( ) ; } return start ; }
protected final int METHOD_1 ( ) { int start ; if ( VAR_1 instanceof TYPE_1 ) { TYPE_1 VAR_2 = ( TYPE_1 ) VAR_1 ; start = VAR_2 . METHOD_2 ( ) ; } else { start = VAR_3 . METHOD_3 ( ) ; } return start ; }
else
public void METHOD_1 ( boolean VAR_1 ) { METHOD_2 ( ) ; TYPE_1 event = null ; synchronized ( TYPE_4 . this ) { if ( VAR_1 != VAR_3 ) { VAR_3 = VAR_1 ; if ( VAR_1 ) { VAR_4 = new TYPE_2 ( TYPE_4 . VAR_5 ) ; } <START> else if ( VAR_4 != null ) <END> { VAR_4 . METHOD_3 ( ) ; VAR_4 = null ; } event = new TYPE_3 ( VAR_1 ) ;...
public void METHOD_1 ( boolean VAR_1 ) { METHOD_2 ( ) ; TYPE_1 event = null ; synchronized ( TYPE_4 . VAR_5 ) { if ( VAR_1 != VAR_3 ) { VAR_3 = VAR_1 ; if ( VAR_1 ) { VAR_4 = new TYPE_2 ( ) ; } else { VAR_4 . METHOD_3 ( ) ; VAR_4 = null ; } event = new TYPE_3 ( VAR_1 ) ; } } METHOD_4 ( event ) ; }
safer synchronize method ! other methods return a List < >
<START> public Collection < TYPE_1 < TYPE_2 , TYPE_3 > > METHOD_1 ( ) <END> { return new ArrayList < TYPE_5 . TYPE_1 < TYPE_2 , TYPE_3 > > ( VAR_1 . values ( ) ) ; }
public synchronized List < TYPE_1 < TYPE_2 , TYPE_3 > > METHOD_1 ( ) { return new ArrayList < TYPE_5 . TYPE_1 < TYPE_2 , TYPE_3 > > ( VAR_1 . values ( ) ) ; }
add braces else ? omit braces simple statements
public static void METHOD_1 ( ) { TYPE_1 job = new TYPE_1 ( TYPE_6 . TYPE_7 ) { @Override protected TYPE_2 run ( TYPE_3 monitor ) { if ( TYPE_4 . METHOD_2 ( ) ) TYPE_4 . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( new TYPE_5 ( ) { public void run ( ) { METHOD_6 ( ) ; } } ) ; else <START> METHOD_7 ( INT_1 ) ; <END> return ...
public static void METHOD_1 ( ) { TYPE_1 job = new TYPE_1 ( TYPE_6 . TYPE_7 ) { @Override protected TYPE_2 run ( TYPE_3 monitor ) { if ( TYPE_4 . METHOD_2 ( ) ) { TYPE_4 . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( new TYPE_5 ( ) { public void run ( ) { METHOD_6 ( ) ; } } ) ; } else { METHOD_7 ( INT_1 ) ; } return Status...
extra blank line
public String METHOD_1 ( long time ) { try { int VAR_1 = VAR_2 . METHOD_2 ( VAR_3 , time ) ; TYPE_1 value = VAR_4 . METHOD_3 ( time , VAR_1 ) ; if ( value != null && ! value . VAR_5 ( ) . METHOD_4 ( ) ) { TYPE_2 state = value . VAR_5 ( ) ; return state . toString ( ) ; } } catch ( TYPE_3 | TYPE_4 | TYPE_5 | TYPE_6 e ) ...
public String METHOD_1 ( long time ) { if ( VAR_2 == null ) { return null ; } try { int VAR_1 = VAR_2 . METHOD_2 ( VAR_3 , time ) ; TYPE_1 value = VAR_4 . METHOD_3 ( time , VAR_1 ) ; if ( value != null && ! value . VAR_5 ( ) . METHOD_4 ( ) ) { TYPE_2 state = value . VAR_5 ( ) ; return state . toString ( ) ; } } catch (...
TYPE_3 : (
private static Collection < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { <START> List < TYPE_1 > VAR_2 = new TYPE_3 < > ( ) ; <END> List < TYPE_4 > VAR_3 = VAR_1 . VAR_3 ; for ( int i = 0 ; i < VAR_3 . size ( ) ; i ++ ) { String name = VAR_3 . get ( i ) . name ; if ( name != null ) { VAR_2 . add ( new TYPE_1 ( name , i ) ) ; }...
private static Collection < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { ImmutableList . Builder < TYPE_1 > builder = new ImmutableList . Builder < > ( ) ; List < TYPE_4 > VAR_3 = VAR_1 . VAR_3 ; for ( int i = 0 ; i < VAR_3 . size ( ) ; i ++ ) { String name = VAR_3 . get ( i ) . name ; if ( name != null ) { builder . add ( new...
( ? ! ) offset larger Long MAX_VALUE nanoseconds ( a scale ) overflow
<START> public TYPE_3 ( TYPE_1 offset ) { <END> VAR_2 = new TYPE_2 ( offset ) ; }
public TYPE_3 ( TYPE_1 offset ) { VAR_2 = offset ; }
unused variable
private String METHOD_1 ( TYPE_1 VAR_1 ) { <START> final StringBuilder VAR_2 = new StringBuilder ( ) ; <END> final Integer VAR_3 ; for ( String VAR_4 : VAR_1 . METHOD_2 ( ) . keySet ( ) ) { VAR_2 . append ( STRING_1 ) . append ( VAR_4 ) . append ( VAR_5 ) ; VAR_2 . append ( STRING_2 ) . append ( VAR_4 ) . append ( VAR_...
private String METHOD_1 ( TYPE_1 VAR_1 ) { final StringBuilder VAR_2 = new StringBuilder ( ) ; for ( String VAR_4 : VAR_1 . METHOD_2 ( ) . keySet ( ) ) { VAR_2 . append ( STRING_1 ) . append ( VAR_4 ) . append ( VAR_5 ) ; VAR_2 . append ( STRING_2 ) . append ( VAR_4 ) . append ( VAR_5 ) ; } return VAR_2 . toString ( ) ...
please install checkstyle environment ( ) forbid ternary operator EMF compare beif ( VAR_2 ) { return METHOD_2 ( VAR_1 ) ; } else { return METHOD_3 ( VAR_1 ) ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 ) { <START> return VAR_2 ? METHOD_2 ( VAR_1 ) : METHOD_3 ( VAR_1 ) ; <END> }
private boolean METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 ) { if ( VAR_2 ) { return METHOD_2 ( VAR_1 ) ; } else { return METHOD_3 ( VAR_1 ) ; } }
checkstyle allow I easier read : ( VAR_1 METHOD_3 ( ) = = TYPE_2 VAR_5 ) { return VAR_1 METHOD_2 ( ) = = TYPE_3 VAR_3 ; } else { return VAR_1 METHOD_2 ( ) = = _CODE_ VAR_6 ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return ( VAR_1 . METHOD_2 ( ) == TYPE_3 . VAR_3 && VAR_1 . METHOD_3 ( ) == TYPE_2 . VAR_5 ) <END> || ( VAR_1 . METHOD_2 ( ) == TYPE_3 . VAR_6 && VAR_1 . METHOD_3 ( ) == TYPE_2 . VAR_7 ) ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_3 ( ) == TYPE_2 . VAR_5 ) { return VAR_1 . METHOD_2 ( ) == TYPE_3 . VAR_3 ; } else { return VAR_1 . METHOD_2 ( ) == TYPE_3 . VAR_6 ; } }
VAR_2 write ( text )
public void METHOD_1 ( String text ) { METHOD_2 ( ) ; <START> try { <END> for ( int x = 0 ; x < text . length ( ) ; ++ x ) { char c = text . VAR_1 ( x ) ; VAR_2 . write ( c ) ; } } catch ( IOException e ) { throw new RuntimeException ( e ) ; } }
public void METHOD_1 ( String text ) { METHOD_2 ( ) ; try { VAR_2 . write ( text ) ; } catch ( IOException e ) { throw new RuntimeException ( e ) ; } }
need messages exceptions ( detail stack trace throw statements removed part review chain )
public void METHOD_1 ( String entity ) { <START> throw new TYPE_1 ( STRING_1 ) ; <END> }
public void METHOD_1 ( String entity ) { throw new TYPE_1 ( ) ; }
configure selected pattern user clic finish skeleton created default another remark : a dangerous cast : combo selection a _CODE_ enough time TYPE_1 expected friends
protected void METHOD_1 ( ) throws Throwable { <START> ( ( TYPE_1 ) VAR_1 ) . METHOD_2 ( false , false ) ; <END> super . METHOD_1 ( ) ; }
protected void METHOD_1 ( ) throws Throwable { if ( VAR_1 instanceof TYPE_1 ) ( ( TYPE_1 ) VAR_1 ) . METHOD_2 ( false , false ) ; super . METHOD_1 ( ) ; }
init command configuration page configure VAR_2 provider instantiate command demand
public Collection < TYPE_1 > METHOD_1 ( ) { Collection < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; TYPE_2 VAR_2 = new TYPE_2 ( ) ; <START> VAR_2 . METHOD_2 ( new TYPE_3 ( VAR_3 , VAR_4 ) ) ; <END> VAR_1 . add ( VAR_2 ) ; return VAR_1 ; }
public Collection < TYPE_1 > METHOD_1 ( ) { Collection < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; TYPE_2 VAR_2 = new TYPE_2 ( this . VAR_3 , this . VAR_4 ) ; VAR_1 . add ( VAR_2 ) ; return VAR_1 ; }
please add { } statement ( VAR_4 METHOD_2 ( ) = = TYPE_3 VAR_6 ) { _CODE_ cmd = VAR_1 METHOD_3 ( ) ; / / command execution ? } modifiy inheritance action add command execution
public void run ( ) { TYPE_1 VAR_1 = new TYPE_1 ( this . VAR_2 . METHOD_1 ( ) , VAR_3 ) ; TYPE_2 VAR_4 = new TYPE_2 ( null , VAR_1 ) ; VAR_4 . create ( ) ; if ( VAR_4 . METHOD_2 ( ) == TYPE_3 . VAR_6 ) <START> this . result = VAR_1 . METHOD_3 ( ) ; <END> }
public void run ( ) { TYPE_1 VAR_1 = new TYPE_1 ( this . VAR_2 . METHOD_1 ( ) , VAR_3 ) ; TYPE_2 VAR_4 = new TYPE_2 ( null , VAR_1 ) ; VAR_4 . create ( ) ; if ( VAR_4 . METHOD_2 ( ) == TYPE_3 . VAR_6 ) { this . result = VAR_1 . METHOD_3 ( ) ; result . execute ( ) ; } }
rewrite : int c = VAR_2 METHOD_1 ( VAR_1 VAR_2 ) ; ( c ! = 0 ) return c ; return VAR_3 METHOD_1 ( VAR_1 VAR_3 ) ;
public int METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( ! this . VAR_2 . equals ( VAR_1 . VAR_2 ) ) { <END> return this . VAR_2 . METHOD_1 ( VAR_1 . VAR_2 ) ; } else if ( ! this . VAR_3 . equals ( VAR_1 . VAR_3 ) ) { return this . VAR_3 . METHOD_1 ( VAR_1 . VAR_3 ) ; } return 0 ; }
public int METHOD_1 ( TYPE_1 VAR_1 ) { int c = VAR_2 . METHOD_1 ( VAR_1 . VAR_2 ) ; if ( c != 0 ) { return c ; } return VAR_3 . METHOD_1 ( VAR_1 . VAR_3 ) ; }