ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
aren t selection index starts 0 ? main VAR_3 0th element need regular NPE protectionif ( VAR_2 = = null ) return ; | protected void METHOD_1 ( ) { <START> if ( VAR_1 != null && VAR_1 . METHOD_2 ( ) > 0 ) { <END> String VAR_2 = ( String ) VAR_1 . METHOD_3 ( Integer . toString ( VAR_1 . METHOD_2 ( ) ) ) ; String VAR_3 = VAR_4 ; if ( VAR_2 . equals ( VAR_5 ) ) { VAR_3 = TYPE_3 . TYPE_1 ; } else if ( VAR_2 . equals ( VAR_4 ) ) { VAR_3 = ... | protected void METHOD_1 ( ) { if ( VAR_1 != null ) { String VAR_2 = ( String ) VAR_1 . METHOD_3 ( Integer . toString ( VAR_1 . METHOD_2 ( ) ) ) ; String VAR_3 = VAR_4 ; if ( VAR_2 != null ) { if ( VAR_2 . equals ( VAR_5 ) ) { VAR_3 = TYPE_3 . TYPE_1 ; } else if ( VAR_2 . equals ( VAR_4 ) ) { VAR_3 = TYPE_3 . TYPE_2 ; }... |
replace method / / supported anymore | public void METHOD_1 ( boolean VAR_1 ) { <START> boolean VAR_2 = VAR_3 ; <END> VAR_3 = VAR_1 ; if ( VAR_2 != VAR_3 ) { } } | public void METHOD_1 ( boolean VAR_1 ) { } |
I suggest false remove field | public boolean METHOD_1 ( ) { return <START> VAR_1 ; <END> } | public boolean METHOD_1 ( ) { return false ; } |
return false update _CODE_ | public boolean METHOD_1 ( ) { return <START> METHOD_2 ( ) . METHOD_1 ( ) ; <END> } | public boolean METHOD_1 ( ) { return false ; } |
s unnecessary declare method public s package visible test s package | <START> public static <END> Set < String > METHOD_1 ( Set < String > VAR_1 , Collection < String > VAR_2 , Set < String > VAR_3 ) { Set < String > VAR_4 = new HashSet < String > ( ) ; for ( String VAR_5 : VAR_1 ) { boolean VAR_6 = METHOD_2 ( VAR_5 , VAR_2 ) ; if ( ! VAR_6 ) { VAR_4 . add ( VAR_5 ) ; } } VAR_4 . addAll ... | protected static Set < String > METHOD_1 ( Set < String > VAR_1 , Collection < String > VAR_2 , Set < String > VAR_3 ) { Set < String > VAR_4 = new HashSet < String > ( ) ; for ( String VAR_5 : VAR_1 ) { boolean VAR_6 = METHOD_2 ( VAR_5 , VAR_2 ) ; if ( ! VAR_6 ) { VAR_4 . add ( VAR_5 ) ; } } VAR_4 . addAll ( VAR_3 ) ;... |
s unnecessary declare method public s package visible test s package | <START> public static <END> boolean METHOD_1 ( String VAR_1 , Collection < String > VAR_2 ) { for ( String VAR_3 : VAR_2 ) { if ( VAR_1 . startsWith ( VAR_3 ) ) { return true ; } if ( VAR_3 . length ( ) == VAR_1 . length ( ) + 1 && VAR_3 . METHOD_2 ( VAR_3 . length ( ) - 1 ) == CHAR_1 && VAR_3 . startsWith ( VAR_1 ) ) ... | protected static boolean METHOD_1 ( String VAR_1 , Collection < String > VAR_2 ) { for ( String VAR_3 : VAR_2 ) { if ( VAR_1 . startsWith ( VAR_3 ) ) { return true ; } if ( VAR_3 . length ( ) == VAR_1 . length ( ) + 1 && VAR_3 . METHOD_2 ( VAR_3 . length ( ) - 1 ) == CHAR_1 && VAR_3 . startsWith ( VAR_1 ) ) { return tr... |
trim string more ? ( i e INT_1 max ) ? adding STRING_1 INT_1 chars greater | private String METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( VAR_2 . length ( ) > INT_1 ) { <START> VAR_2 = STRING_1 + VAR_2 . substring ( 0 , INT_2 ) ; <END> } if ( VAR_2 . length ( ) == 0 ) { VAR_2 += STRING_2 ; } return TYPE_2 . METHOD_3 ( VAR_2 ) ; } | private String METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 = VAR_1 . METHOD_2 ( ) ; return TYPE_2 . METHOD_3 ( VAR_2 ) ; } |
method map expected < String String > < ? ? > | public String getProperty ( String key ) { <START> return ( String ) value . get ( key ) ; <END> } | public String getProperty ( String key ) { return value . get ( key ) ; } |
map generified | private void METHOD_1 ( TYPE_1 [ ] VAR_1 ) throws TYPE_2 { assertEquals ( STRING_1 , VAR_2 . size ( ) , VAR_1 . length ) ; for ( int i = 0 ; i < VAR_1 . length ; i ++ ) { <START> Map values = VAR_2 . get ( new Long ( VAR_1 [ i ] . getId ( ) ) ) ; <END> assertEquals ( STRING_2 , VAR_1 [ i ] . METHOD_2 ( ) , values ) ; }... | private void METHOD_1 ( TYPE_1 [ ] VAR_1 ) throws TYPE_2 { assertEquals ( STRING_1 , VAR_2 . size ( ) , VAR_1 . length ) ; for ( int i = 0 ; i < VAR_1 . length ; i ++ ) { Map < String , Object > values = VAR_2 . get ( new Long ( VAR_1 [ i ] . getId ( ) ) ) ; assertEquals ( STRING_2 , VAR_1 [ i ] . METHOD_2 ( ) , values... |
done | private static List < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 ) { HashSet < TYPE_1 > set = new <START> HashSet < TYPE_1 > ( ) ; <END> set . addAll ( VAR_1 ) ; return Arrays . asList ( set . VAR_2 ( new TYPE_1 [ set . size ( ) ] ) ) ; } | private static List < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 ) { HashSet < TYPE_1 > set = new HashSet < > ( ) ; set . addAll ( VAR_1 ) ; return Arrays . asList ( set . VAR_2 ( new TYPE_1 [ set . size ( ) ] ) ) ; } |
size result list properly : final List < Object > result = new ArrayList < Object > ( list size ( ) + 1 ) ; | public List < Object > METHOD_1 ( List < Object > list , Object object ) { <START> final List < Object > result = TYPE_1 . METHOD_2 ( ) ; <END> result . add ( object ) ; result . addAll ( list ) ; return result ; } | public List < Object > METHOD_1 ( List < Object > list , Object object ) { final List < Object > result = new ArrayList < Object > ( list . size ( ) + 1 ) ; result . add ( object ) ; result . addAll ( list ) ; return result ; } |
I t reason throw TYPE_1 | <START> private String METHOD_1 ( ) throws TYPE_1 { <END> String name = VAR_1 ; int count = 1 ; while ( METHOD_2 ( ) . METHOD_3 ( name ) != null ) { name = VAR_1 + STRING_1 + count ++ ; } return name ; } | private String METHOD_1 ( ) { String name = VAR_1 ; int count = 1 ; while ( METHOD_2 ( ) . METHOD_3 ( name ) != null ) { name = VAR_1 + STRING_1 + count ++ ; } return name ; } |
some time track returning false return true causing remote commands break escaped properly a separate problem ( a bug original implementation I ) attribute needs fixed | <START> public boolean METHOD_1 ( ) { <END> String VAR_1 = VAR_2 . METHOD_2 ( VAR_3 ) ; return VAR_1 != null ? Boolean . VAR_4 ( VAR_1 ) : VAR_5 ; } | public boolean METHOD_1 ( ) { String VAR_1 = VAR_2 . METHOD_2 ( VAR_3 ) ; return ! VAR_1 . isEmpty ( ) ? Boolean . VAR_4 ( VAR_1 ) : VAR_5 ; } |
remove thises | public TYPE_1 ( final long VAR_1 ) { <START> this . VAR_2 = VAR_1 ; <END> this . VAR_3 = count ++ ; } | public TYPE_1 ( final long VAR_1 ) { VAR_2 = VAR_1 ; synchronized ( TYPE_1 . class ) { VAR_3 = count ++ ; } } |
+ = a Long object boxing time d VAR_2 a long return Long valueOf ( VAR_2 ) simply return a long method | public Long METHOD_1 ( ANNOTATION_1 Object VAR_1 ) { Long VAR_2 = INT_1 ; for ( Long VAR_3 : VAR_4 . get ( VAR_1 ) ) { <START> VAR_2 += VAR_3 ; <END> } return VAR_2 ; } | public Long METHOD_1 ( ANNOTATION_1 Object VAR_1 ) { long VAR_2 = INT_1 ; synchronized ( VAR_4 ) { for ( long VAR_3 : VAR_4 . get ( VAR_1 ) ) { VAR_2 += VAR_3 ; } } return VAR_2 ; } |
s useless check null sincenull instanceof somethingalways returns false | private TYPE_1 METHOD_1 ( ) { final TYPE_1 VAR_1 ; TYPE_2 VAR_2 = METHOD_2 ( ) ; <START> if ( VAR_2 != null && VAR_2 instanceof TYPE_1 ) { <END> VAR_1 = ( TYPE_1 ) VAR_2 ; } else { VAR_1 = new TYPE_1 ( ) { public TYPE_3 METHOD_3 ( ) { return new TYPE_4 ( ) ; } } ; } return VAR_1 ; } | private TYPE_1 METHOD_1 ( ) { final TYPE_1 VAR_1 ; TYPE_2 VAR_2 = METHOD_2 ( ) ; if ( VAR_2 instanceof TYPE_1 ) { VAR_1 = ( TYPE_1 ) VAR_2 ; } else { VAR_1 = new TYPE_1 ( ) { public TYPE_3 METHOD_3 ( ) { return new TYPE_4 ( ) ; } } ; } return VAR_1 ; } |
brackets single statements ( I inconsitent goal ) | private void METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 ) { TYPE_2 < TYPE_3 > container = METHOD_2 ( VAR_1 ) ; <START> if ( container == null ) <END> return ; List < TYPE_1 > VAR_3 = METHOD_3 ( VAR_1 , VAR_2 ) ; METHOD_4 ( VAR_1 , VAR_3 , true ) ; } | private void METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 ) { TYPE_2 < TYPE_3 > container = METHOD_2 ( VAR_1 ) ; if ( container == null ) { return ; } List < TYPE_1 > VAR_3 = METHOD_3 ( VAR_1 , VAR_2 ) ; METHOD_4 ( VAR_1 , VAR_3 , true ) ; } |
private | <START> protected void METHOD_1 ( TYPE_1 value ) { <END> METHOD_2 ( ) . METHOD_3 ( TYPE_2 . class ) . METHOD_4 ( value ) ; } | private void METHOD_1 ( TYPE_1 value ) { METHOD_2 ( ) . METHOD_3 ( TYPE_2 . class ) . METHOD_4 ( value ) ; } |
private | <START> protected final TYPE_1 METHOD_1 ( TYPE_2 parent , int VAR_1 ) { <END> if ( parent == null ) { return TYPE_3 . METHOD_2 ( ) . METHOD_1 ( VAR_1 ) ; } return parent . VAR_2 ( ) . METHOD_3 ( ) . METHOD_1 ( VAR_1 ) ; } | private final TYPE_1 METHOD_1 ( TYPE_2 parent , int VAR_1 ) { if ( parent == null ) { return TYPE_3 . METHOD_2 ( ) . METHOD_1 ( VAR_1 ) ; } return parent . VAR_2 ( ) . METHOD_3 ( ) . METHOD_1 ( VAR_1 ) ; } |
consider moving null check write ( ) method guard other places | public void METHOD_1 ( TYPE_1 VAR_1 , String url ) { METHOD_2 ( ) ; try { VAR_2 . write ( CHAR_1 ) ; METHOD_3 ( VAR_1 ) ; if ( url != null ) <START> { <END> VAR_2 . write ( url ) ; } VAR_2 . write ( CHAR_1 ) ; } catch ( IOException e ) { throw new RuntimeException ( e ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 , String url ) { METHOD_2 ( ) ; try { VAR_2 . write ( CHAR_1 ) ; METHOD_3 ( VAR_1 ) ; VAR_2 . write ( url ) ; VAR_2 . write ( CHAR_1 ) ; } catch ( IOException e ) { throw new RuntimeException ( e ) ; } } |
I instance check method meaning method exception object type | <START> public static void METHOD_1 ( Object VAR_1 ) { <END> int length = ( ( String ) VAR_1 ) . length ( ) ; if ( length > VAR_2 ) { throw METHOD_2 ( STRING_1 , VAR_2 , length , VAR_1 ) ; } } | private static void METHOD_1 ( Object VAR_1 ) { int length = ( ( String ) VAR_1 ) . length ( ) ; if ( length > VAR_2 ) { throw METHOD_2 ( STRING_1 , VAR_2 , length , VAR_1 ) ; } } |
a new ( else lose logging test ) | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ) ; <END> VAR_2 . METHOD_3 ( ) ; } | public void METHOD_1 ( ) { VAR_2 . METHOD_3 ( ) ; } |
I d recommend parentheses elvis notations : VAR_7 = ( VAR_4 ! = SWT VAR_6 ? VAR_4 : VAR_3 ) ; don t read code _CODE_ = _CODE_ assigning _CODE_ s bad | public void METHOD_1 ( long VAR_1 , long VAR_2 ) { VAR_3 = VAR_1 ; VAR_4 = VAR_2 ; VAR_5 = VAR_3 != SWT . VAR_6 ? VAR_3 : VAR_4 ; <START> VAR_7 = VAR_4 != SWT . VAR_6 ? VAR_4 : VAR_3 ; <END> if ( VAR_5 > VAR_7 ) { VAR_3 = VAR_2 ; VAR_4 = VAR_1 ; VAR_5 = VAR_3 ; VAR_7 = VAR_4 ; } METHOD_2 ( ) ; } | public void METHOD_1 ( long VAR_1 , long VAR_2 ) { VAR_3 = VAR_1 ; VAR_4 = VAR_2 ; VAR_5 = ( VAR_3 != SWT . VAR_6 ? VAR_3 : VAR_4 ) ; VAR_7 = ( VAR_4 != SWT . VAR_6 ? VAR_4 : VAR_3 ) ; if ( VAR_5 > VAR_7 ) { VAR_3 = VAR_2 ; VAR_4 = VAR_1 ; VAR_5 = VAR_3 ; VAR_7 = VAR_4 ; } METHOD_2 ( ) ; } |
don t need check | private void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 , String VAR_2 ) { <START> if ( VAR_3 . size ( ) > 0 ) { <END> for ( String VAR_4 : VAR_3 ) { if ( VAR_4 . METHOD_2 ( ) . contains ( VAR_2 ) ) { VAR_1 . add ( new TYPE_2 ( VAR_4 ) ) ; } } } } | private void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 , String VAR_2 ) { for ( String VAR_4 : VAR_3 ) { if ( VAR_4 . METHOD_2 ( ) . contains ( VAR_2 ) ) { VAR_1 . add ( new TYPE_2 ( VAR_4 ) ) ; } } } |
change removing org eclipse core runtime compatibility * bundles | public TYPE_2 ( ) { <START> super ( ) ; <END> VAR_2 = new TYPE_1 ( ) ; } | public TYPE_2 ( ) { VAR_2 = new TYPE_1 ( ) ; } |
instead METHOD_2 ( ) METHOD_3 ( ) methods METHOD_3 ( ) | private void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( ) ; <START> VAR_1 . METHOD_3 ( ) ; <END> VAR_1 = null ; } if ( this . VAR_2 != null ) { this . VAR_2 . METHOD_2 ( ) ; this . VAR_2 = null ; } } | private void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_3 ( ) ; VAR_1 = null ; } if ( this . VAR_2 != null ) { this . VAR_2 . METHOD_2 ( ) ; this . VAR_2 = null ; } } |
= = sufficient | public void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { if ( session != null ) { <START> if ( TYPE_3 . TYPE_4 . equals ( session . getStatus ( ) ) ) { <END> VAR_2 = null ; } } } | public void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { if ( session != null ) { if ( TYPE_3 . TYPE_4 == session . getStatus ( ) ) { VAR_2 = null ; } } } |
equals ( ) usefull enum = = sufficient | public void METHOD_1 ( TYPE_1 event ) { if ( session != null && <START> TYPE_3 . TYPE_4 . equals ( session . getStatus ( ) ) ) <END> { if ( VAR_1 == null ) { VAR_1 = event . VAR_2 ( ) ; } } } | public void METHOD_1 ( TYPE_1 event ) { if ( session != null && TYPE_3 . TYPE_4 == session . getStatus ( ) ) { if ( VAR_1 == null ) { VAR_1 = event . VAR_2 ( ) ; } } } |
exclude TYPE_3 TYPE_4 _CODE_ overrides method ? 3 override | protected String METHOD_1 ( ) { String VAR_1 = METHOD_2 ( ) ; TYPE_1 token = ( ( TYPE_2 ) METHOD_3 ( ) ) . METHOD_4 ( ) ; <START> if ( ( ! ( this instanceof TYPE_3 ) && ! ( this instanceof TYPE_4 ) ) <END> && token != null && VAR_1 . length ( ) > 0 ) { if ( ! VAR_1 . METHOD_5 ( STRING_1 ) ) { VAR_1 += STRING_2 ; } VAR_... | protected String METHOD_1 ( ) { String VAR_1 = METHOD_2 ( ) ; TYPE_1 token = ( ( TYPE_2 ) METHOD_3 ( ) ) . METHOD_4 ( ) ; if ( token != null && VAR_1 . length ( ) > 0 ) { if ( ! VAR_1 . METHOD_5 ( STRING_1 ) ) { VAR_1 += STRING_2 ; } VAR_1 += STRING_3 + token . VAR_2 ( ) ; } return METHOD_6 ( ) + VAR_1 ; } |
join variable definition please | public static TYPE_1 METHOD_1 ( TYPE_2 config , String VAR_1 ) throws TYPE_3 { <START> List < TYPE_1 > VAR_2 ; <END> TYPE_1 VAR_3 = null ; VAR_2 = TYPE_1 . METHOD_2 ( config ) ; for ( TYPE_1 VAR_4 : VAR_2 ) { if ( VAR_4 . getName ( ) . equals ( VAR_1 ) ) VAR_3 = VAR_4 ; } return VAR_3 ; } | public static TYPE_1 METHOD_1 ( TYPE_2 config , String VAR_1 ) throws TYPE_3 { TYPE_1 VAR_3 = null ; List < TYPE_1 > VAR_2 = TYPE_1 . METHOD_2 ( config ) ; for ( TYPE_1 VAR_4 : VAR_2 ) { if ( VAR_4 . getName ( ) . equals ( VAR_1 ) ) { VAR_3 = VAR_4 ; break ; } } return VAR_3 ; } |
exception thrown code needed | public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) <START> throws TYPE_3 { <END> List < TYPE_2 > VAR_3 = new ArrayList < TYPE_2 > ( VAR_1 . METHOD_2 ( ) ) ; for ( TYPE_2 VAR_4 : VAR_3 ) { VAR_1 . METHOD_3 ( VAR_4 ) ; } VAR_1 . METHOD_4 ( VAR_2 ) ; } | public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { List < TYPE_2 > VAR_3 = new ArrayList < TYPE_2 > ( VAR_1 . METHOD_2 ( ) ) ; for ( TYPE_2 VAR_4 : VAR_3 ) { VAR_1 . METHOD_3 ( VAR_4 ) ; } VAR_1 . METHOD_4 ( VAR_2 ) ; } |
put braces block please | public static void METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 = Constants . VAR_3 + STRING_1 ; List < TYPE_2 > VAR_4 = VAR_1 . METHOD_2 ( ) ; for ( TYPE_2 VAR_5 : VAR_4 ) { <START> if ( VAR_5 . METHOD_3 ( VAR_2 ) ) <END> return ; } VAR_1 . METHOD_4 ( new TYPE_2 ( VAR_2 + STRING_2 + VAR_2 ) ) ; } | public static void METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 = Constants . VAR_3 + STRING_1 ; List < TYPE_2 > VAR_4 = VAR_1 . METHOD_2 ( ) ; for ( TYPE_2 VAR_5 : VAR_4 ) { if ( VAR_5 . METHOD_3 ( VAR_2 ) ) { return ; } } VAR_1 . METHOD_4 ( new TYPE_2 ( VAR_2 + STRING_2 + VAR_2 ) ) ; } |
I put not_touch position METHOD_3 TYPE_2 type filter | public TYPE_1 METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( TYPE_5 . VAR_2 ) . METHOD_3 ( TYPE_1 . METHOD_2 ( TYPE_5 . VAR_3 ) ) <START> . and ( TYPE_1 . METHOD_4 ( TYPE_2 . class ) . and ( TYPE_1 . TYPE_4 ) ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return TYPE_1 . TYPE_4 . and ( TYPE_1 . METHOD_2 ( TYPE_5 . VAR_2 ) ) . METHOD_3 ( TYPE_1 . METHOD_2 ( TYPE_5 . VAR_3 ) ) . and ( TYPE_1 . METHOD_4 ( TYPE_2 . class ) ) ; } |
good multi - thread catch | public TYPE_1 METHOD_1 ( ) { <START> TYPE_2 VAR_1 <END> = VAR_2 ; if ( VAR_1 == null ) { VAR_1 = new TYPE_2 ( ) ; if ( ( VAR_3 != null ) && ( VAR_4 != null ) ) { VAR_1 . METHOD_2 ( VAR_3 ) ; VAR_1 . METHOD_3 ( VAR_4 ) ; } VAR_2 = VAR_1 ; } return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = VAR_2 ; if ( VAR_1 == null ) { VAR_1 = new TYPE_2 ( ) ; if ( ( VAR_3 != null ) && ( VAR_4 != null ) ) { VAR_1 . METHOD_2 ( VAR_3 ) ; VAR_1 . METHOD_3 ( VAR_4 ) ; VAR_2 = VAR_1 ; } VAR_2 = VAR_1 ; } return VAR_1 ; } |
editor control disposed null I add METHOD_3 ( ) ! = null && please && condition a new line readability fault readability | public void run ( ) { TYPE_1 . METHOD_1 ( ) . METHOD_2 ( new TYPE_2 ( ) { @Override public void run ( ) { <START> if ( ! METHOD_3 ( ) . METHOD_4 ( ) && TYPE_4 . this . VAR_2 != null && TYPE_4 . VAR_3 . VAR_2 . equals ( METHOD_5 ( ) ) ) { <END> commit ( TYPE_3 . NONE , false ) ; } } } ) ; } | public void run ( ) { TYPE_1 . METHOD_1 ( ) . METHOD_2 ( new TYPE_2 ( ) { @Override public void run ( ) { if ( METHOD_3 ( ) != null && ! METHOD_3 ( ) . METHOD_4 ( ) && TYPE_4 . VAR_3 . VAR_2 != null && TYPE_4 . VAR_3 . VAR_2 . equals ( METHOD_5 ( ) ) ) { commit ( TYPE_3 . NONE , false ) ; } } } ) ; } |
line number command separated failure message example : 50 : click : control disabled discuss ulyana ond olya | private static String METHOD_1 ( TYPE_1 result ) { TYPE_1 VAR_1 = METHOD_2 ( result . VAR_2 ( ) ) ; if ( VAR_1 != null ) { <START> return result . getMessage ( ) + STRING_1 + METHOD_1 ( VAR_1 ) + METHOD_3 ( VAR_1 ) ; <END> } return result . getMessage ( ) ; } | private static String METHOD_1 ( TYPE_1 result ) { TYPE_1 VAR_1 = METHOD_2 ( result . VAR_2 ( ) ) ; if ( VAR_1 != null ) { return METHOD_3 ( VAR_1 ) + result . getMessage ( ) + STRING_1 + METHOD_1 ( VAR_1 ) ; } return result . getMessage ( ) ; } |
monitor parameter especially METHOD_2 ( ) longer time | <START> public void METHOD_1 ( TYPE_1 monitor ) { <END> item . VAR_1 ( true ) ; METHOD_2 ( ) ; } | public void METHOD_1 ( TYPE_1 monitor ) { item . VAR_1 ( true ) ; METHOD_2 ( false , monitor ) ; } |
useful monitor field pass METHOD_2 ( ) parameter useful refresh | public void METHOD_1 ( TYPE_1 monitor ) { <START> this . VAR_1 = monitor ; <END> item . VAR_2 ( true ) ; METHOD_2 ( ) ; } | public void METHOD_1 ( TYPE_1 monitor ) { item . VAR_2 ( true ) ; METHOD_2 ( ) ; } |
check | public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( obj == null ) { return false ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; if ( ! TYPE_2 . METHOD_1 ( VAR_2 , VAR_1 . VAR_2 ) ) { return false ; } <START> return TYPE_2 . METHOD_1 ( VAR_3 , VAR_1... | public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( obj == null ) { return false ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; if ( ! METHOD_1 ( VAR_2 , VAR_1 . VAR_2 ) ) { return false ; } if ( ! METHOD_1 ( VAR_3 , VAR_1 . VAR_3 ) ) { return fals... |
strings equals ( ) compare = = ! = | private String METHOD_1 ( boolean VAR_1 ) { <START> return ( VAR_1 ? VAR_2 : "" ) + ( VAR_3 != "" ? STRING_1 + VAR_3 : "" ) ; <END> } | private String METHOD_1 ( boolean VAR_1 ) { return ( VAR_1 ? VAR_2 : "" ) + ( ! VAR_3 . equals ( "" ) ? STRING_1 + VAR_3 : "" ) ; } |
pass _CODE_ method avoid method moved a place _CODE_ set | public void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( this ) ; VAR_2 = new ArrayList < TYPE_2 > ( ) ; VAR_3 = METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; if ( VAR_3 == null ) { VAR_3 = STRING_1 ; } <START> METHOD_6 ( ) ; <END> } | public void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( this ) ; VAR_2 = new ArrayList < TYPE_2 > ( ) ; VAR_3 = METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; if ( VAR_3 == null ) { VAR_3 = STRING_1 ; } METHOD_6 ( VAR_3 ) ; } |
move line | private void METHOD_1 ( T value ) { String VAR_1 = TYPE_1 . METHOD_2 ( value . toString ( ) ) ; <START> TYPE_2 VAR_2 = TYPE_3 . METHOD_3 ( ) ; <END> if ( VAR_1 != null ) { VAR_2 . put ( VAR_3 , VAR_1 ) ; try { VAR_2 . METHOD_4 ( ) ; } catch ( TYPE_4 e ) { e . VAR_4 ( ) ; } } } | private void METHOD_1 ( T value ) { String VAR_1 = TYPE_1 . METHOD_2 ( value . toString ( ) ) ; if ( VAR_1 != null ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_3 ( ) ; VAR_2 . put ( VAR_3 , VAR_1 ) ; try { VAR_2 . METHOD_4 ( ) ; } catch ( TYPE_4 e ) { e . VAR_4 ( ) ; } } } |
remove protected prevent access package place method other gtk_widget methods class | <START> protected <END> void METHOD_1 ( long VAR_1 , int VAR_2 , int VAR_3 ) { OS . VAR_4 ( VAR_1 , VAR_2 ) ; OS . VAR_5 ( VAR_1 , VAR_3 ) ; } | void METHOD_1 ( long VAR_1 , int VAR_2 , int VAR_3 ) { OS . VAR_4 ( VAR_1 , VAR_2 ) ; OS . VAR_5 ( VAR_1 , VAR_3 ) ; } |
project stuff _CODE_ ? base class | protected void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; <START> METHOD_2 ( ) ; <END> VAR_1 = METHOD_3 ( METHOD_4 ( ) ) ; VAR_2 = VAR_1 . METHOD_5 ( ) . METHOD_6 ( ) . METHOD_7 ( ) . METHOD_8 ( ) ; final TYPE_1 VAR_3 = TYPE_2 . METHOD_9 ( ) . METHOD_10 ( ) . METHOD_11 ( ) ; TYPE_3 view = VAR_3 . METHOD_12 ... | protected void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; final TYPE_1 VAR_3 = TYPE_2 . METHOD_9 ( ) . METHOD_10 ( ) . METHOD_11 ( ) ; TYPE_3 view = VAR_3 . METHOD_12 ( STRING_1 ) ; if ( view != null ) { VAR_3 . METHOD_13 ( view ) ; } } |
set fields null generally a good idea METHOD_1 ( ) fail called case ll NPE | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_1 ( ) ; <END> VAR_1 = null ; super . METHOD_1 ( ) ; if ( METHOD_2 ( ) instanceof TYPE_1 ) { ( ( TYPE_1 ) METHOD_2 ( ) ) . METHOD_1 ( ) ; } if ( VAR_2 != null ) { METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_2 ) ; VAR_2 = null ; } } | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; if ( METHOD_2 ( ) instanceof TYPE_1 ) { ( ( TYPE_1 ) METHOD_2 ( ) ) . METHOD_1 ( ) ; } if ( VAR_2 != null ) { METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_2 ) ; VAR_2 = null ; } } |
VAR_1 disposed ? _CODE_ parent _CODE_ | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_1 ( ) ; <END> VAR_1 = null ; if ( VAR_2 != null ) { METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( VAR_2 ) ; } VAR_2 = null ; super . METHOD_1 ( ) ; if ( METHOD_5 ( ) instanceof TYPE_1 ) { ( ( TYPE_1 ) METHOD_5 ( ) ) . METHOD_1 ( ) ; } } | public void METHOD_1 ( ) { if ( VAR_2 != null ) { METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( VAR_2 ) ; } VAR_2 = null ; super . METHOD_1 ( ) ; if ( METHOD_5 ( ) instanceof TYPE_1 ) { ( ( TYPE_1 ) METHOD_5 ( ) ) . METHOD_1 ( ) ; } } |
debugging leftover | public void METHOD_1 ( int state ) { try { final TYPE_1 field = TYPE_2 . class . METHOD_2 ( STRING_1 ) ; field . VAR_1 ( true ) ; field . set ( this , new Integer ( state ) ) ; } catch ( Exception e ) { <START> e . VAR_2 ( ) ; <END> throw new RuntimeException ( e ) ; } } | public void METHOD_1 ( int state ) { try { final TYPE_1 field = TYPE_2 . class . METHOD_2 ( STRING_1 ) ; field . VAR_1 ( true ) ; field . set ( this , new Integer ( state ) ) ; } catch ( Exception e ) { throw new RuntimeException ( e ) ; } } |
variable declared bad scope | public static TYPE_1 METHOD_1 ( View view , String VAR_1 , TYPE_1 VAR_2 ) { TYPE_1 value = VAR_2 ; TYPE_2 VAR_3 = TYPE_5 . VAR_5 . METHOD_2 ( ) ; TYPE_3 <START> VAR_6 ; <END> if ( VAR_3 != null ) { VAR_6 = view . VAR_7 ( VAR_3 , VAR_1 ) ; if ( VAR_6 instanceof TYPE_4 ) { value = ( ( TYPE_4 ) VAR_6 ) . METHOD_1 ( ) ; } ... | public static TYPE_1 METHOD_1 ( View view , String VAR_1 , TYPE_1 VAR_2 ) { TYPE_1 value = VAR_2 ; TYPE_2 VAR_3 = TYPE_5 . VAR_5 . METHOD_2 ( ) ; if ( VAR_3 != null ) { TYPE_3 VAR_6 = view . VAR_7 ( VAR_3 , VAR_1 ) ; if ( VAR_6 instanceof TYPE_4 ) { value = ( ( TYPE_4 ) VAR_6 ) . METHOD_1 ( ) ; } } return value ; } |
call copy 2nd time | public TYPE_1 METHOD_1 ( int VAR_1 ) { METHOD_2 ( TYPE_2 . METHOD_3 ( VAR_1 ) ) ; TYPE_1 VAR_2 = METHOD_1 ( ) ; <START> METHOD_2 ( VAR_3 . METHOD_4 ( ) ) ; <END> return VAR_2 ; } | public TYPE_1 METHOD_1 ( int VAR_1 ) { METHOD_2 ( TYPE_2 . METHOD_3 ( VAR_1 ) ) ; TYPE_1 VAR_2 = METHOD_1 ( ) ; METHOD_2 ( METHOD_4 ( ) ) ; return VAR_2 ; } |
want decorate TYPE_2 plugins workspace | private TYPE_1 METHOD_1 ( final TYPE_1 VAR_1 , final TYPE_2 VAR_2 ) { if <START> ( TYPE_3 . getInstance ( ) . METHOD_2 ( VAR_2 ) <END> && VAR_1 != null ) { return TYPE_4 . METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( VAR_1 , STRING_1 ) ) ; } return VAR_1 ; } | private TYPE_1 METHOD_1 ( final TYPE_1 VAR_1 , final TYPE_2 VAR_2 ) { if ( ! TYPE_3 . getInstance ( ) . METHOD_2 ( VAR_2 ) && VAR_1 != null ) { return TYPE_4 . METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( VAR_1 , STRING_1 ) ) ; } return VAR_1 ; } |
A diamond operator suffice | public void add ( TYPE_1 VAR_1 ) { if ( VAR_2 == null ) VAR_2 = new <START> ArrayList < TYPE_1 > ( 2 ) ; <END> VAR_2 . add ( VAR_1 ) ; } | public void add ( TYPE_1 VAR_1 ) { if ( VAR_2 == null ) VAR_2 = new ArrayList < > ( 2 ) ; VAR_2 . add ( VAR_1 ) ; } |
Optional : presize 2 * VAR_1 length | private static String METHOD_1 ( byte [ ] VAR_1 ) { <START> StringBuilder builder = new StringBuilder ( ) ; <END> for ( byte b : VAR_1 ) { builder . append ( TYPE_1 . METHOD_2 ( ( b & INT_1 ) > > 4 ) ) ; builder . append ( TYPE_1 . METHOD_2 ( b & INT_2 ) ) ; } return builder . toString ( ) ; } | private static String METHOD_1 ( byte [ ] VAR_1 ) { StringBuilder builder = new StringBuilder ( 2 * VAR_1 . length ) ; for ( byte b : VAR_1 ) { builder . append ( TYPE_1 . METHOD_2 ( ( b & INT_1 ) > > 4 ) ) ; builder . append ( TYPE_1 . METHOD_2 ( b & INT_2 ) ) ; } return builder . toString ( ) ; } |
rewrite - - resources : ( TYPE_7 reader = db VAR_2 ( ) ) { return METHOD_1 ( reader path VAR_1 ) ; } | public static TYPE_1 METHOD_1 ( final TYPE_2 db , final String path , final TYPE_3 ... VAR_1 ) throws TYPE_4 , TYPE_5 , TYPE_6 , IOException { <START> TYPE_7 reader = db . VAR_2 ( ) ; try { return METHOD_1 ( reader , path , VAR_1 ) ; } finally { reader . close ( ) ; } <END> } | public static TYPE_1 METHOD_1 ( final TYPE_2 db , final String path , final TYPE_3 ... VAR_1 ) throws TYPE_4 , TYPE_5 , TYPE_6 , IOException { try ( TYPE_7 reader = db . VAR_2 ( ) ) { return METHOD_1 ( reader , path , VAR_1 ) ; } } |
method static | <START> public static boolean METHOD_1 ( TYPE_1 VAR_1 ) { <END> if ( ! ( VAR_1 instanceof TYPE_2 ) ) { return false ; } TYPE_2 node = ( TYPE_2 ) VAR_1 ; if ( node instanceof TYPE_3 ) { return false ; } if ( node . VAR_2 ( ) instanceof TYPE_4 ) { return true ; } if ( node . VAR_2 ( ) instanceof TYPE_5 ) { if ( node . VA... | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! ( VAR_1 instanceof TYPE_2 ) ) { return false ; } TYPE_2 node = ( TYPE_2 ) VAR_1 ; if ( node instanceof TYPE_3 ) { return false ; } if ( node . VAR_2 ( ) instanceof TYPE_4 ) { return true ; } if ( node . VAR_2 ( ) instanceof TYPE_5 ) { if ( node . VAR_3 ( ) != null ) { r... |
I _CODE_ singleton | public TYPE_1 METHOD_1 ( Object node ) { if ( node == null ) { return null ; } TYPE_2 VAR_1 = METHOD_2 ( node ) ; <START> TYPE_3 VAR_2 = new TYPE_3 ( ) ; <END> View VAR_3 = VAR_2 . METHOD_3 ( VAR_1 ) ; if ( VAR_3 . METHOD_4 ( ) == null ) { return null ; } return super . METHOD_1 ( VAR_3 ) ; } | public TYPE_1 METHOD_1 ( Object node ) { if ( node == null ) { return null ; } TYPE_2 VAR_1 = METHOD_2 ( node ) ; View VAR_3 = TYPE_3 . getInstance ( ) . METHOD_3 ( VAR_1 ) ; if ( VAR_3 . METHOD_4 ( ) == null ) { return null ; } return super . METHOD_1 ( VAR_3 ) ; } |
field final ? method scope | public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> final int VAR_2 = VAR_1 . METHOD_2 ( ) ; <END> if ( VAR_2 == TYPE_2 . VAR_4 ) { METHOD_3 ( ) ; METHOD_4 ( ) ; } else if ( VAR_2 == TYPE_2 . VAR_5 ) { METHOD_3 ( ) ; METHOD_4 ( ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { int VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( VAR_2 == TYPE_2 . VAR_4 ) { METHOD_3 ( ) ; METHOD_4 ( ) ; } else if ( VAR_2 == TYPE_2 . VAR_5 ) { METHOD_3 ( ) ; METHOD_4 ( ) ; } } |
other initialise VAR_3 field a setter | public TYPE_3 ( View view , TYPE_1 VAR_2 ) { super ( view , VAR_2 ) ; <START> super . VAR_3 = new TYPE_2 ( ) ; <END> } | public TYPE_3 ( View view , TYPE_1 VAR_2 ) { super ( view , VAR_2 ) ; VAR_3 = TYPE_2 . getInstance ( ) ; } |
protected want allow call class | <START> public String METHOD_1 ( ) { <END> return VAR_1 ; } | protected String METHOD_1 ( ) { return VAR_1 ; } |
check null instead ! null logic new class _CODE_ | public T value ( ) { if ( VAR_1 == null ) { VAR_1 = METHOD_1 ( ) ; } else if ( ! METHOD_2 ( ) ) { VAR_1 = METHOD_1 ( ) ; } <START> return ( VAR_1 != null ) ? VAR_1 : VAR_2 ; <END> } | public T value ( ) { if ( VAR_1 == null ) { VAR_1 = METHOD_1 ( ) ; } else if ( ! METHOD_2 ( ) ) { VAR_1 = METHOD_1 ( ) ; } return ( VAR_1 == null ) ? VAR_2 : VAR_1 ; } |
need super | private List < T > METHOD_1 ( List < String > VAR_1 ) { List < T > VAR_2 = new ArrayList < T > ( ) ; for ( String val : VAR_1 ) { <START> VAR_2 . add ( super . METHOD_1 ( val ) ) ; <END> } return VAR_2 ; } | private List < T > METHOD_1 ( List < String > VAR_1 ) { List < T > VAR_2 = new ArrayList < T > ( ) ; for ( String val : VAR_1 ) { VAR_2 . add ( METHOD_1 ( val ) ) ; } return VAR_2 ; } |
reveals a more impacting problem METHOD_1 called ? change hide consequence problem | public void METHOD_1 ( final TYPE_1 VAR_1 ) { <START> if ( ! VAR_1 . METHOD_2 ( ) . contains ( this ) ) { <END> VAR_1 . METHOD_2 ( ) . add ( this ) ; } for ( final TYPE_2 view : VAR_1 . METHOD_3 ( ) ) { METHOD_4 ( view ) ; } } | public void METHOD_1 ( final TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( ) . add ( this ) ; for ( final TYPE_2 view : VAR_1 . METHOD_3 ( ) ) { METHOD_4 ( view ) ; } } |
wrong arg order | public TYPE_1 ( final int VAR_2 , final int VAR_3 ) { <START> super ( VAR_3 , VAR_2 ) ; <END> } | public TYPE_1 ( final int VAR_2 , final int VAR_3 ) { super ( VAR_2 , VAR_3 ) ; } |
a reason set strength ? platform / UI JDT code | public TYPE_4 ( boolean VAR_2 , int VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; VAR_4 = TYPE_1 . METHOD_1 ( ) . METHOD_2 ( ) ; VAR_5 = new HashSet ( ) ; TYPE_2 VAR_6 = TYPE_2 . getInstance ( ) ; <START> VAR_6 . METHOD_3 ( TYPE_2 . VAR_7 ) ; <END> VAR_8 = new TYPE_3 ( VAR_6 ) ; METHOD_4 ( ) ; } | public TYPE_4 ( boolean VAR_2 , int VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; VAR_4 = TYPE_1 . METHOD_1 ( ) . METHOD_2 ( ) ; VAR_5 = new HashSet ( ) ; TYPE_2 VAR_6 = TYPE_2 . getInstance ( ) ; VAR_8 = new TYPE_3 ( VAR_6 ) ; METHOD_4 ( ) ; } |
line dash / line attributes | protected void METHOD_1 ( final TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( METHOD_5 ( ) ) ; VAR_1 . METHOD_6 ( METHOD_7 ( ) ) ; <START> VAR_1 . METHOD_8 ( METHOD_9 ( ) ) ; <END> final TYPE_2 VAR_2 = METHOD_10 ( new TYPE_3 ( METHOD_11 ( ) ) ) ; VAR_1 . METHOD_12 ( VAR_2 ) ; VAR_1 . METHOD_13... | protected void METHOD_1 ( final TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( METHOD_5 ( ) ) ; VAR_1 . METHOD_6 ( METHOD_7 ( ) ) ; final TYPE_2 VAR_2 = METHOD_10 ( new TYPE_3 ( METHOD_11 ( ) ) ) ; VAR_1 . METHOD_12 ( VAR_2 ) ; VAR_1 . METHOD_13 ( VAR_2 ) ; } |
style : add braces block | public TYPE_6 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , boolean VAR_4 , boolean VAR_5 ) { super ( VAR_2 ) ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_2 = VAR_2 ; this . VAR_6 = new TYPE_3 ( ) { @Override public void METHOD_1 ( TYPE_4 event ) { <START> if ( event . VAR_7 == SWT . VAR_8 ) <END... | public TYPE_6 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , boolean VAR_4 , boolean VAR_5 ) { super ( VAR_2 ) ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_2 = VAR_2 ; this . VAR_6 = new TYPE_3 ( ) { @Override public void METHOD_1 ( TYPE_4 event ) { if ( event . VAR_7 == SWT . VAR_8 ) { METHOD_2 (... |
reverse order : assertEquals ( VAR_1 ) | public void METHOD_1 ( ) { String VAR_1 = METHOD_2 ( STRING_1 ) ; <START> assertEquals ( VAR_1 , "" ) ; <END> } | public void METHOD_1 ( ) { String VAR_1 = METHOD_2 ( STRING_1 ) ; assertEquals ( "" , VAR_1 ) ; } |
tests METHOD_1 preceding character content character content ( areas ve troubles ) | public void METHOD_1 ( ) { String VAR_1 = METHOD_2 ( STRING_1 ) ; assertEquals ( VAR_1 , STRING_2 ) ; <START> } <END> | public void METHOD_1 ( ) { String VAR_1 = METHOD_2 ( STRING_1 ) ; assertEquals ( STRING_2 , VAR_1 ) ; } |
set variable false close connection | public void METHOD_1 ( ) { if ( VAR_1 ) { <START> VAR_2 . close ( ) ; <END> } } | public void METHOD_1 ( ) { if ( VAR_1 ) { VAR_2 . close ( ) ; VAR_1 = false ; } } |
return ( e VAR_2 ( ) isEmpty ( ) ? null : e VAR_2 ( ) ; | private static String METHOD_1 ( TYPE_1 e ) { <START> String VAR_1 = e . VAR_2 ( ) ; <END> if ( VAR_1 . equals ( "" ) ) return null ; return VAR_1 ; } | private static String METHOD_1 ( TYPE_1 e ) { String VAR_1 = e . VAR_2 ( ) ; if ( VAR_1 . isEmpty ( ) ) return null ; return VAR_1 ; } |
logic weird I change : ( VAR_6 ) { return } | private static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws TYPE_3 { final TYPE_4 < TYPE_5 > VAR_3 = VAR_1 . METHOD_2 ( ) ; for ( final TYPE_5 VAR_4 : VAR_3 ) { if ( TYPE_6 . class . METHOD_3 ( VAR_4 ) ) { final TYPE_6 VAR_5 = ( TYPE_6 ) VAR_4 ; final boolean VAR_6 = VAR_5 . METHOD_4 ( VAR_2 ) ; if ( ! VAR_6 ) ... | private static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws TYPE_3 { final TYPE_4 < TYPE_5 > VAR_3 = VAR_1 . METHOD_2 ( ) ; for ( final TYPE_5 VAR_4 : VAR_3 ) { if ( TYPE_6 . class . METHOD_3 ( VAR_4 ) ) { final TYPE_6 VAR_5 = ( TYPE_6 ) VAR_4 ; final boolean VAR_6 = VAR_5 . METHOD_4 ( VAR_2 ) ; if ( VAR_6 ) { ... |
return evaluation | public boolean METHOD_1 ( View VAR_1 ) { boolean TYPE_5 ; String VAR_3 = TYPE_1 . METHOD_2 ( VAR_1 , TYPE_3 . VAR_5 , TYPE_3 . VAR_6 ) ; <START> TYPE_5 = TYPE_3 . TYPE_4 . equals ( VAR_3 ) ; <END> return TYPE_5 ; } | public boolean METHOD_1 ( View VAR_1 ) { String VAR_3 = TYPE_1 . METHOD_2 ( VAR_1 , TYPE_3 . VAR_5 , TYPE_3 . VAR_6 ) ; return TYPE_3 . TYPE_4 . equals ( VAR_3 ) ; } |
need type | void METHOD_1 ( ) { <START> VAR_1 = new HashMap < String , Integer > ( ) ; <END> Integer VAR_2 = new Integer ( VAR_3 ) ; for ( String VAR_4 : VAR_5 ) VAR_1 . put ( VAR_4 , VAR_2 ) ; } | void METHOD_1 ( ) { VAR_1 = new HashMap < > ( ) ; Integer VAR_2 = new Integer ( VAR_3 ) ; for ( String VAR_4 : VAR_5 ) VAR_1 . put ( VAR_4 , VAR_2 ) ; } |
_CODE_ ( ) other ways set VAR_2 validated pull a dedicated _CODE_ method call VAR_2 determined | <START> String METHOD_1 ( Date VAR_1 ) throws TYPE_1 { <END> String VAR_2 = format . format ( VAR_1 ) ; try { TYPE_2 . METHOD_2 ( TYPE_2 . VAR_3 + STRING_1 + VAR_2 ) ; } catch ( IllegalArgumentException e ) { throw new TYPE_1 ( STRING_2 + format . VAR_4 ( ) + STRING_3 ) ; } return VAR_2 ; } | String METHOD_1 ( Date VAR_1 ) { return format . format ( VAR_1 ) ; } |
I effect consistent rest code class statement changed return METHOD_1 ( ) - wdyt ? I m fine don t want change decided ask | public String METHOD_1 ( ) { try { return METHOD_2 ( ) ; } catch ( TYPE_1 e ) { if ( ! VAR_1 ) { METHOD_3 ( ) ; <START> return METHOD_2 ( ) ; <END> } return null ; } } | public String METHOD_1 ( ) { try { return METHOD_2 ( ) ; } catch ( TYPE_1 e ) { if ( ! VAR_1 ) { METHOD_3 ( ) ; return METHOD_1 ( ) ; } return null ; } } |
infinite loop | private static void METHOD_1 ( ) { synchronized ( VAR_1 ) { <START> while ( VAR_2 > 0 ) { <END> try { VAR_1 . METHOD_2 ( INT_1 ) ; } catch ( InterruptedException e ) { } } if ( VAR_1 . isEmpty ( ) == false ) { TYPE_1 buffer = new TYPE_1 ( ) ; for ( String VAR_3 : VAR_1 ) { buffer . append ( STRING_1 + VAR_3 ) ; } VAR_1... | private static void METHOD_1 ( ) { synchronized ( VAR_1 ) { while ( VAR_2 > 0 ) { try { VAR_1 . METHOD_2 ( INT_1 ) ; } catch ( InterruptedException e ) { } } if ( VAR_1 . isEmpty ( ) == false ) { StringBuilder buffer = new StringBuilder ( ) ; for ( String VAR_3 : VAR_1 ) { buffer . append ( STRING_1 + VAR_3 ) ; } VAR_1... |
done ( copy - paste ) | public TYPE_1 METHOD_1 ( TYPE_2 req , String name ) throws TYPE_3 , TYPE_4 { if ( ! name . equals ( VAR_1 ) ) <START> throw new TYPE_3 ( name ) ; <END> TYPE_1 db = repo . VAR_2 ( ) ; db . VAR_3 ( ) ; return db ; } | public TYPE_1 METHOD_1 ( TYPE_2 req , String name ) throws TYPE_3 , TYPE_4 { if ( ! name . equals ( VAR_1 ) ) { throw new TYPE_3 ( name ) ; } TYPE_1 db = repo . VAR_2 ( ) ; db . VAR_3 ( ) ; return db ; } |
argument constructor argument constructor removed missing / / $NON - NLS - $ | public TYPE_1 METHOD_1 ( int VAR_1 ) throws IOException { <START> return new TYPE_2 ( METHOD_2 ( ) , STRING_1 ) . start ( VAR_1 ) ; <END> } | public TYPE_1 METHOD_1 ( int VAR_1 ) throws IOException { return new TYPE_2 ( METHOD_2 ( ) ) . start ( VAR_1 ) ; } |
else redundant | public < T extends TYPE_2 . TYPE_5 > T METHOD_1 ( TYPE_2 connection , Class < T > VAR_1 ) { if ( TYPE_3 . class . equals ( VAR_1 ) ) { return ( T ) new TYPE_4 ( connection ) ; } else { <START> return null ; <END> } } | public < T extends TYPE_2 . TYPE_5 > T METHOD_1 ( TYPE_2 connection , Class < T > VAR_1 ) { if ( TYPE_3 . class . equals ( VAR_1 ) ) { return ( T ) new TYPE_4 ( connection ) ; } return null ; } |
replace platform TYPE_2 | protected void METHOD_1 ( ) { TYPE_1 <START> VAR_1 = <END> TYPE_2 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( TYPE_3 . VAR_3 ) ; } | protected void METHOD_1 ( ) { TYPE_2 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 . VAR_3 ) ; } |
remove rounding 3rd strike ; ) | public long METHOD_1 ( int index ) { <START> return VAR_1 + ( long ) ( index * VAR_2 + FLOAT_1 ) ; <END> } | public long METHOD_1 ( int index ) { return VAR_1 + ( long ) ( index * VAR_2 ) ; } |
/ upper constraint disabled case unrelated constraints element | protected boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , Map < Object , Object > context ) { TYPE_3 status = Status . VAR_3 ; if ( VAR_2 != null ) { if ( ! METHOD_2 ( VAR_1 , context ) ) { <START> if ( METHOD_3 ( VAR_1 ) ) { <END> status = VAR_4 . METHOD_4 ( VAR_1 , new TYPE_4 ( ) ) ; METHOD_5 ( VAR_1 , context , sta... | protected boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , Map < Object , Object > context ) { TYPE_3 status = Status . VAR_3 ; if ( VAR_2 != null ) { if ( ! METHOD_2 ( VAR_1 , context ) ) { status = VAR_4 . METHOD_4 ( VAR_1 , new TYPE_4 ( ) ) ; METHOD_5 ( VAR_1 , context , status ) ; METHOD_6 ( status , VAR_2 ) ; } } ... |
needsynchronized ( TYPE_3 ) { block _CODE_ ( ) calls | public int METHOD_1 ( TYPE_1 VAR_1 , long VAR_2 , TYPE_2 VAR_3 ) { String VAR_4 ; <START> synchronized ( VAR_5 ) { <END> VAR_4 = TYPE_3 . format ( new Date ( VAR_2 / VAR_6 ) ) ; } return Utils . VAR_7 ( VAR_1 , VAR_4 , VAR_3 , true ) ; } | public int METHOD_1 ( TYPE_1 VAR_1 , long VAR_2 , TYPE_2 VAR_3 ) { String VAR_4 ; synchronized ( TYPE_3 ) { VAR_4 = TYPE_3 . format ( new Date ( VAR_2 / VAR_6 ) ) ; } return Utils . VAR_7 ( VAR_1 , VAR_4 , VAR_3 , true ) ; } |
inline | public int METHOD_1 ( int VAR_1 ) { <START> int VAR_2 = VAR_3 . METHOD_2 ( ) . x ; <END> int VAR_4 = VAR_2 - VAR_1 ; return VAR_4 ; } | public int METHOD_1 ( int VAR_1 ) { return VAR_3 . METHOD_2 ( ) . x - VAR_1 ; } |
t return null | public TYPE_1 METHOD_1 ( ) { <START> return TYPE_2 . METHOD_2 ( TYPE_4 < TYPE_3 > METHOD_3 ( ) ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return null ; } |
missing braces | public static void METHOD_1 ( int VAR_1 , String message , Throwable VAR_2 , boolean VAR_3 ) { TYPE_1 status = new Status ( VAR_1 , METHOD_2 ( ) , message , VAR_2 ) ; int VAR_4 = TYPE_2 . LOG ; <START> if ( VAR_3 ) <END> VAR_4 |= TYPE_2 . VAR_5 ; TYPE_2 . METHOD_3 ( ) . METHOD_4 ( status , VAR_4 ) ; } | public static void METHOD_1 ( int VAR_1 , String message , Throwable VAR_2 , boolean VAR_3 ) { TYPE_1 status = new Status ( VAR_1 , METHOD_2 ( ) , message , VAR_2 ) ; int VAR_4 = TYPE_2 . LOG ; if ( VAR_3 ) { VAR_4 |= TYPE_2 . VAR_5 ; } TYPE_2 . METHOD_3 ( ) . METHOD_4 ( status , VAR_4 ) ; } |
shouldnt < = ? haven t pulled latest changes ? I changed < 2_12_0 < = 2_11_0 equivalent ( maintain VAR_3 ) | public boolean METHOD_1 ( ) { <START> return version . VAR_1 ( VAR_2 ) >= 0 && version . VAR_1 ( VAR_3 ) < 0 ; <END> } | public boolean METHOD_1 ( ) { return version . VAR_1 ( VAR_2 ) >= 0 && version . VAR_1 ( VAR_3 ) <= 0 ; } |
method static | <START> boolean METHOD_1 ( TYPE_1 <END> VAR_1 ) { return ( VAR_1 instanceof TYPE_2 || VAR_1 instanceof TYPE_3 ) ; } | private static boolean METHOD_1 ( TYPE_1 VAR_1 ) { return ( VAR_1 instanceof TYPE_2 || VAR_1 instanceof TYPE_3 ) ; } |
TYPE_3 METHOD_1 ( ) ; | public void METHOD_1 ( ) { if ( ! METHOD_2 ( ) ) { final TYPE_1 VAR_1 = TYPE_2 . METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( ) . METHOD_6 ( ) ) ; VAR_1 . METHOD_7 ( this . METHOD_8 ( ) ) ; super . METHOD_1 ( ) ; TYPE_3 . METHOD_1 ( this ) ; } <START> TYPE_4 VAR_2 = METHOD_8 ( ) ; if ( VAR_2 . METHOD_9 ( ) ) { VAR_2 . METHOD_1... | public void METHOD_1 ( ) { if ( ! METHOD_2 ( ) ) { final TYPE_1 VAR_1 = TYPE_2 . METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( ) . METHOD_6 ( ) ) ; VAR_1 . METHOD_7 ( this . METHOD_8 ( ) ) ; super . METHOD_1 ( ) ; TYPE_3 . METHOD_1 ( this ) ; } } |
A dangerous access array index checking validity | public TYPE_2 ( final String VAR_2 , final Collection < TYPE_1 > VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; TYPE_1 VAR_4 = ( TYPE_1 ) <START> VAR_3 . METHOD_1 ( ) [ 0 ] ; <END> VAR_5 = VAR_4 . METHOD_2 ( ) ; } | public TYPE_2 ( final String VAR_2 , final Collection < TYPE_1 > VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; if ( VAR_3 != null && VAR_3 . METHOD_1 ( ) . length > 0 ) { TYPE_1 VAR_4 = ( TYPE_1 ) VAR_3 . METHOD_1 ( ) [ 0 ] ; VAR_5 = VAR_4 . METHOD_2 ( ) ; } } |
synchronized | <START> public static void METHOD_1 ( ) { <END> VAR_1 = new TYPE_1 ( TYPE_2 . METHOD_2 ( ) , TYPE_2 . METHOD_3 ( ) , TYPE_2 . METHOD_4 ( ) ) ; VAR_2 = new TYPE_1 ( TYPE_2 . METHOD_5 ( ) ) ; } | public static synchronized void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( TYPE_2 . METHOD_2 ( ) , TYPE_2 . METHOD_3 ( ) , TYPE_2 . METHOD_4 ( ) ) ; VAR_2 = new TYPE_1 ( TYPE_2 . METHOD_5 ( ) ) ; } |
avoid local variable store VAR_3 clause feel ( unnecessary ) | public void METHOD_1 ( int VAR_1 ) { <START> int VAR_2 = this . VAR_3 ; <END> this . VAR_3 = VAR_1 ; if ( VAR_2 != VAR_1 ) { METHOD_2 ( ) . METHOD_3 ( new TYPE_1 [ ] { this } ) ; } } | public void METHOD_1 ( int VAR_1 ) { if ( VAR_3 != VAR_1 ) { VAR_3 = VAR_1 ; METHOD_2 ( ) . METHOD_3 ( new TYPE_1 [ ] { this } ) ; } } |
merge s : ( VAR_1 = = 0 _CODE_ ( ) ! = null &&o VAR_3 ( ) ! = null ) { VAR_1 = } technically VAR_3 ( ) returns a mutable d safer extract a local variable change check METHOD_1 ( ) more condition I don t trace type ID supposed change s fine | public int METHOD_1 ( TYPE_1 o ) { int VAR_1 = METHOD_2 ( ) . METHOD_1 ( o . VAR_2 ( ) ) ; if ( VAR_1 == 0 ) { if ( METHOD_3 ( ) != null ) { <START> if ( o . VAR_3 ( ) != null ) { <END> VAR_1 = METHOD_3 ( ) . METHOD_1 ( o . VAR_3 ( ) ) ; } } } return VAR_1 ; } | public int METHOD_1 ( TYPE_1 o ) { int VAR_1 = METHOD_2 ( ) . METHOD_1 ( o . VAR_2 ( ) ) ; if ( VAR_1 == 0 ) { if ( METHOD_3 ( ) != null && o . VAR_3 ( ) != null ) { VAR_1 = METHOD_3 ( ) . METHOD_1 ( o . VAR_3 ( ) ) ; } } return VAR_1 ; } |
braces I guess | private void METHOD_1 ( final TYPE_1 e ) { TYPE_1 p = e . VAR_1 ; TYPE_1 n = e . VAR_2 ; <START> if ( p != null ) <END> p . VAR_2 = n ; else VAR_3 = n ; if ( n != null ) n . VAR_1 = p ; else VAR_4 = p ; } | private void METHOD_1 ( final TYPE_1 e ) { TYPE_1 p = e . VAR_1 ; TYPE_1 n = e . VAR_2 ; if ( p != null ) { p . VAR_2 = n ; } else { VAR_3 = n ; } if ( n != null ) { n . VAR_1 = p ; } else { VAR_4 = p ; } } |
wouldn t VAR_5 block caller | public static void METHOD_1 ( String task , TYPE_1 < TYPE_2 > VAR_1 ) { TYPE_3 group = METHOD_2 ( ) ; try { group . VAR_2 ( task , size ( VAR_1 ) ) ; for ( TYPE_2 job : VAR_1 ) { job . VAR_3 ( group , 1 ) ; job . VAR_4 ( ) ; } for ( TYPE_2 job : VAR_1 ) { <START> job . VAR_5 ( ) ; <END> } } catch ( InterruptedException... | public static TYPE_3 METHOD_1 ( String task , TYPE_1 < TYPE_2 > VAR_1 ) { TYPE_3 group = METHOD_2 ( ) ; try { group . VAR_2 ( task , size ( VAR_1 ) ) ; for ( TYPE_2 job : VAR_1 ) { job . VAR_3 ( group , 1 ) ; job . VAR_4 ( ) ; } for ( TYPE_2 job : VAR_1 ) { job . VAR_5 ( ) ; } } catch ( InterruptedException e ) { } fin... |
set null especially _CODE_ fields set null METHOD_4 ( ) call | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; if ( this . VAR_1 != null ) { this . VAR_1 . METHOD_1 ( ) ; this . VAR_1 = null ; } VAR_2 . clear ( ) ; for ( TYPE_1 VAR_3 : TYPE_2 . METHOD_2 ( ) ) { TYPE_3 VAR_4 = VAR_3 . METHOD_3 ( ) ; if ( VAR_4 != null ) { VAR_4 . METHOD_1 ( ) ; } } <START> VAR_5 . METHOD_4 ( ) ; ... | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; if ( this . VAR_1 != null ) { this . VAR_1 . METHOD_1 ( ) ; this . VAR_1 = null ; } VAR_2 . clear ( ) ; for ( TYPE_1 VAR_3 : TYPE_2 . METHOD_2 ( ) ) { TYPE_3 VAR_4 = VAR_3 . METHOD_3 ( ) ; if ( VAR_4 != null ) { VAR_4 . METHOD_1 ( ) ; } } VAR_5 . METHOD_4 ( ) ; VAR_5 = ... |
call METHOD_4 | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( VAR_2 ) ; METHOD_4 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; <START> assertEquals ( Collections . VAR_3 ( ) , METHOD_5 ( TYPE_1 . class ) ) ; <END> } | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( VAR_2 ) ; METHOD_4 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; METHOD_4 ( ) ; } |
done | <START> public static TYPE_1 [ ] METHOD_1 ( TYPE_2 connection ) { <END> return new TYPE_3 ( ) . METHOD_1 ( connection ) ; } | public static List < TYPE_1 > METHOD_1 ( TYPE_2 connection ) { return new TYPE_3 ( ) . METHOD_1 ( connection ) ; } |
I checkstyle disabled project ( ) EMF compare checkstyle config discourages ternary expressions I d replace a common statement | private TYPE_1 METHOD_1 ( TYPE_1 item ) { <START> return item != null ? item : METHOD_2 ( ) ; <END> } | private TYPE_1 METHOD_1 ( TYPE_1 item ) { if ( item != null ) { return item ; } return METHOD_2 ( ) ; } |
don t catch instead allow _CODE_ handle | public TYPE_1 METHOD_1 ( TYPE_2 data ) { TYPE_3 VAR_1 = new TYPE_3 ( logger , VAR_2 ) ; TYPE_1 VAR_3 = null ; try { METHOD_2 ( data ) ; VAR_3 = VAR_1 . METHOD_3 ( data , VAR_4 ) ; <START> } catch ( Exception ex ) { <END> throw new TYPE_4 ( Status . VAR_5 , STRING_1 , ex ) ; } return VAR_3 ; } | public TYPE_1 METHOD_1 ( TYPE_2 data ) { TYPE_3 VAR_1 = new TYPE_3 ( logger , VAR_2 ) ; METHOD_2 ( data ) ; return VAR_1 . METHOD_3 ( data , VAR_4 ) ; } |
( optional ) | private TYPE_1 METHOD_1 ( String name ) throws IOException { final TYPE_2 id = db . VAR_1 ( name ) ; if ( id == null ) throw new IllegalArgumentException ( name ) ; final TYPE_3 p = new TYPE_3 ( ) ; <START> try ( final TYPE_4 VAR_2 = db . VAR_3 ( ) ) { <END> p . VAR_4 ( VAR_2 , new TYPE_5 ( db ) . METHOD_2 ( id ) ) ; r... | private TYPE_1 METHOD_1 ( String name ) throws IOException { final TYPE_2 id = db . VAR_1 ( name ) ; if ( id == null ) throw new IllegalArgumentException ( name ) ; final TYPE_3 p = new TYPE_3 ( ) ; try ( TYPE_4 VAR_2 = db . VAR_3 ( ) ) { p . VAR_4 ( VAR_2 , new TYPE_5 ( db ) . METHOD_2 ( id ) ) ; return p ; } } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.