ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
argh thanks noticing ! ; - ) | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { if ( VAR_2 == null || VAR_1 instanceof TYPE_3 ) { return ; } TYPE_4 VAR_3 = TYPE_5 . METHOD_2 ( VAR_2 ) ; System . out . println ( STRING_1 + VAR_1 + STRING_2 <START> + VAR_3 . size ( ) ) ; <END> if ( VAR_3 . isEmpty ( ) ) { return ; } METHOD_3 ( VAR_3 ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { if ( VAR_2 == null || VAR_1 instanceof TYPE_3 ) { return ; } TYPE_4 VAR_3 = TYPE_5 . METHOD_2 ( VAR_2 ) ; if ( VAR_3 . isEmpty ( ) ) { return ; } METHOD_3 ( VAR_3 ) ; } |
evaluate VAR_2 lazily _CODE_ ( ) a call METHOD_1 ( ) avoided completely VAR_2 set manually METHOD_1 ( ) possibly slow hang bash configuration screwed | protected VAR_1 ( ) { <START> VAR_2 = new TYPE_1 < File > ( METHOD_1 ( ) ) ; <END> } | protected VAR_1 ( ) { } |
multi return forbidden | <START> protected View METHOD_1 ( ) { <END> if ( METHOD_2 ( ) . METHOD_3 ( ) instanceof View ) { if ( ( ( View ) METHOD_2 ( ) . METHOD_3 ( ) ) instanceof View ) { return ( View ) ( ( View ) METHOD_2 ( ) . METHOD_3 ( ) ) ; } return null ; } return null ; } | protected View METHOD_1 ( ) { View view = null ; if ( METHOD_2 ( ) . METHOD_3 ( ) instanceof View ) { if ( ( ( View ) METHOD_2 ( ) . METHOD_3 ( ) ) instanceof View ) { view = ( View ) ( ( View ) METHOD_2 ( ) . METHOD_3 ( ) ) ; } } return view ; } |
return VAR_1 METHOD_2 ( new TYPE_1 [ 0 ] ) ; | public TYPE_1 [ ] METHOD_1 ( ) { <START> return VAR_1 . METHOD_2 ( new TYPE_1 [ VAR_1 . size ( ) ] ) ; <END> } | public TYPE_1 [ ] METHOD_1 ( ) { return VAR_1 . METHOD_2 ( new TYPE_1 [ 0 ] ) ; } |
s / public / / type visible methods aren t visible declared public cases avoid public confusing | <START> public long <END> METHOD_1 ( ) { return VAR_1 ; } | long METHOD_1 ( ) { return VAR_1 ; } |
I = = don t want equivalent entries a gzipfile return inputstream file | public TYPE_1 METHOD_1 ( TYPE_2 entry ) { if <START> ( entry . equals ( VAR_1 ) ) <END> { return VAR_2 ; } throw new IllegalArgumentException ( ) ; } | public TYPE_1 METHOD_1 ( TYPE_2 entry ) { if ( entry != VAR_1 ) { throw new IllegalArgumentException ( ) ; } return VAR_2 ; } |
means VAR_1 ( ) VAR_1 ( wonka ) VAR_1 ( wonka ) VAR_1 ( ) result VAR_1 wonka ? inconsistent needed | public Builder METHOD_1 ( final String VAR_1 ) { <START> if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { <END> this . VAR_1 = VAR_1 ; } return this ; } | public Builder METHOD_1 ( final String VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; } |
set coming | public Builder cmd ( final List < String > cmd ) { <START> if ( cmd != null && ! cmd . isEmpty ( ) ) { <END> this . cmd = new ArrayList < String > ( cmd ) ; } return this ; } | public Builder cmd ( final List < String > cmd ) { this . cmd = cmd ; return this ; } |
METHOD_1 empty | public Builder METHOD_1 ( final String VAR_1 ) { <START> if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { <END> return METHOD_1 ( VAR_1 . split ( STRING_1 ) ) ; } return this ; } | public Builder METHOD_1 ( final String VAR_1 ) { if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { return METHOD_1 ( VAR_1 . split ( STRING_1 ) ) ; } else { this . VAR_1 = null ; } return this ; } |
idem | public void METHOD_1 ( long time , boolean VAR_1 ) { synchronized ( VAR_2 ) { <START> if ( VAR_3 != null && VAR_3 . METHOD_2 ( ) ) { <END> return ; } } METHOD_3 ( time , VAR_1 , false ) ; } | public void METHOD_1 ( long time , boolean VAR_1 ) { if ( VAR_3 != null && VAR_3 . METHOD_2 ( ) ) { return ; } METHOD_3 ( time , VAR_1 , false ) ; } |
idem | public void METHOD_1 ( long VAR_1 , long VAR_2 ) { synchronized ( VAR_3 ) { <START> if ( VAR_4 != null && VAR_4 . METHOD_2 ( ) ) { <END> return ; } } VAR_5 = Math . max ( VAR_6 , Math . VAR_7 ( VAR_8 , VAR_1 ) ) ; VAR_9 = Math . max ( VAR_6 , Math . VAR_7 ( VAR_8 , VAR_2 ) ) ; VAR_10 . METHOD_3 ( ) ; VAR_11 . METHOD_3 ... | public void METHOD_1 ( long VAR_1 , long VAR_2 ) { if ( VAR_4 != null && VAR_4 . METHOD_2 ( ) ) { return ; } VAR_5 = Math . max ( VAR_6 , Math . VAR_7 ( VAR_8 , VAR_1 ) ) ; VAR_9 = Math . max ( VAR_6 , Math . VAR_7 ( VAR_8 , VAR_2 ) ) ; VAR_10 . METHOD_3 ( ) ; VAR_11 . METHOD_3 ( ) ; } |
sollte false nicht default sein | protected boolean METHOD_1 ( ) { <START> return true ; <END> } | protected boolean METHOD_1 ( ) { return false ; } |
else more obvious exclusive cases | public TYPE_1 < String > METHOD_1 ( String VAR_1 ) { boolean contains = false ; String VAR_2 = VAR_1 ; if ( VAR_1 . METHOD_2 ( STRING_1 ) ) { contains = true ; VAR_2 = VAR_2 + STRING_2 ; <START> } if ( VAR_1 . contains ( STRING_3 ) ) <END> { contains = true ; VAR_2 = VAR_2 . METHOD_3 ( STRING_3 , STRING_4 ) ; } if ( co... | public TYPE_1 < String > METHOD_1 ( String VAR_1 ) { boolean contains = false ; String VAR_2 = VAR_1 ; if ( VAR_1 . METHOD_2 ( STRING_1 ) ) { contains = true ; VAR_2 = VAR_2 + STRING_2 ; } else if ( VAR_1 . contains ( STRING_3 ) ) { contains = true ; VAR_2 = VAR_2 . METHOD_3 ( STRING_3 , STRING_4 ) ; } if ( contains ) ... |
shouldn t check top method ignore working copies time | public boolean METHOD_1 ( TYPE_1 configuration ) throws TYPE_2 { if ( METHOD_2 ( configuration ) ) { <START> if ( configuration . VAR_1 ( ) ) <END> return true ; METHOD_3 ( configuration ) ; return METHOD_4 ( configuration ) ; } else if ( VAR_2 . contains ( configuration ) ) { TYPE_3 VAR_3 = METHOD_5 ( ) ; VAR_3 . METH... | public boolean METHOD_1 ( TYPE_1 configuration ) throws TYPE_2 { if ( METHOD_2 ( configuration ) ) { METHOD_3 ( configuration ) ; return METHOD_4 ( configuration ) ; } else if ( VAR_2 . contains ( configuration ) ) { TYPE_3 VAR_3 = METHOD_5 ( ) ; VAR_3 . METHOD_3 ( configuration ) ; VAR_3 . METHOD_6 ( configuration ) ;... |
multi returns avoid | <START> public boolean METHOD_1 ( final Object element ) { <END> if ( element instanceof TYPE_1 ) { final Object object = ( ( TYPE_1 ) element ) . METHOD_2 ( ) ; if ( object instanceof TYPE_2 ) { TYPE_2 VAR_1 = ( TYPE_2 ) object ; Object VAR_2 = VAR_1 . METHOD_3 ( ) ; if ( VAR_2 instanceof TYPE_3 ) { final TYPE_4 VAR_3... | public boolean METHOD_1 ( final Object element ) { boolean result = false ; if ( element instanceof TYPE_1 ) { final Object object = ( ( TYPE_1 ) element ) . METHOD_2 ( ) ; if ( object instanceof TYPE_2 ) { TYPE_2 VAR_1 = ( TYPE_2 ) object ; Object VAR_2 = VAR_1 . METHOD_3 ( ) ; if ( VAR_2 instanceof TYPE_3 ) { final T... |
multi return avoid | private String METHOD_1 ( final TYPE_1 table , final Object VAR_1 ) { <START> if ( VAR_1 instanceof TYPE_2 ) { <END> return Constants . VAR_2 ; } else if ( VAR_1 instanceof TYPE_3 ) { return Constants . VAR_3 ; } else { return "" ; } } | private String METHOD_1 ( final TYPE_1 table , final Object VAR_1 ) { String result = "" ; if ( VAR_1 instanceof TYPE_2 ) { result = Constants . VAR_2 ; } else if ( VAR_1 instanceof TYPE_3 ) { result = Constants . VAR_3 ; } return result ; } |
s odd METHOD_1 call METHOD_5 instead a method _CODE_ calls METHOD_1 METHOD_5 | private TYPE_1 METHOD_1 ( String value ) { if ( TYPE_2 . METHOD_2 ( STRING_1 ) != null ) { String VAR_1 = TYPE_3 . METHOD_3 ( VAR_2 , value ) ; if ( VAR_1 != null ) { TYPE_1 VAR_3 = TYPE_3 . METHOD_4 ( VAR_1 ) ; if ( VAR_3 != null ) { return VAR_3 ; } } } <START> return METHOD_5 ( ) . METHOD_6 ( ) ; <END> } | private TYPE_1 METHOD_1 ( String value ) { if ( TYPE_2 . METHOD_2 ( STRING_1 ) != null ) { String VAR_1 = TYPE_3 . METHOD_3 ( VAR_2 , value ) ; if ( VAR_1 != null ) { TYPE_1 VAR_3 = TYPE_3 . METHOD_4 ( VAR_1 ) ; if ( VAR_3 != null ) { return VAR_3 ; } } } return null ; } |
instanceof ? ? a thought | public synchronized void METHOD_1 ( TYPE_1 location ) { if ( location != null ) { TYPE_2 iterator = METHOD_2 ( ) ; <START> iterator . VAR_1 ( ( ( TYPE_3 ) location ) . METHOD_3 ( ) ) ; <END> VAR_2 = iterator . VAR_3 ( ) ; } else { VAR_2 = null ; } } | public synchronized void METHOD_1 ( TYPE_1 location ) { if ( location instanceof TYPE_3 ) { TYPE_2 iterator = METHOD_2 ( ) ; iterator . VAR_1 ( ( ( TYPE_3 ) location ) . METHOD_3 ( ) ) ; VAR_2 = iterator . VAR_3 ( ) ; } else { VAR_2 = null ; } } |
casting View checking instanceof highly suspicious | protected View METHOD_1 ( ) { TYPE_1 host = METHOD_2 ( ) ; if ( host == null ) { return null ; } Object VAR_1 = host . VAR_2 ( ) ; if ( VAR_1 instanceof View ) { <START> if ( ( ( View ) METHOD_2 ( ) . METHOD_3 ( ) ) instanceof View ) { <END> return ( View ) ( ( View ) METHOD_2 ( ) . METHOD_3 ( ) ) ; } return null ; } r... | protected View METHOD_1 ( ) { TYPE_1 host = METHOD_2 ( ) ; if ( host == null ) { return null ; } Object VAR_1 = host . VAR_2 ( ) ; if ( VAR_1 instanceof View ) { return ( View ) VAR_1 ; } return null ; } |
_CODE_ instead METHOD_4 | public void METHOD_1 ( ) throws Exception { <START> String result = <END> METHOD_2 ( STRING_1 + METHOD_3 ( ) . METHOD_4 ( ) + STRING_2 , TYPE_1 . VAR_2 , null , VAR_3 . VAR_4 . VAR_5 . VAR_6 . Response . Status . VAR_7 . METHOD_5 ( ) ) ; Assert . assertTrue ( result . contains ( STRING_3 ) ) ; } | public void METHOD_1 ( ) throws Exception { String result = METHOD_2 ( STRING_1 + METHOD_3 ( ) + STRING_2 , TYPE_1 . VAR_2 , null , VAR_3 . VAR_4 . VAR_5 . VAR_6 . Response . Status . VAR_7 . METHOD_5 ( ) ) ; Assert . assertTrue ( result . contains ( STRING_3 ) ) ; } |
final missing | <START> public boolean METHOD_1 ( View VAR_1 ) { <END> boolean empty = true ; if ( METHOD_2 ( VAR_1 ) ) { Iterator < ? > VAR_2 = VAR_1 . METHOD_3 ( ) . iterator ( ) ; while ( VAR_2 . hasNext ( ) && empty ) { Object child = VAR_2 . next ( ) ; if ( METHOD_4 ( child ) ) { empty = ! ( ( View ) child ) . METHOD_5 ( ) ; } } ... | public boolean METHOD_1 ( View VAR_1 ) { boolean empty = true ; if ( METHOD_2 ( VAR_1 ) ) { Iterator < ? > VAR_2 = VAR_1 . METHOD_3 ( ) . iterator ( ) ; while ( empty && VAR_2 . hasNext ( ) ) { Object child = VAR_2 . next ( ) ; if ( METHOD_4 ( child ) ) { empty = ! ( ( View ) child ) . METHOD_5 ( ) ; } } } return ! emp... |
null ! = preferably | public void METHOD_1 ( ) { if ( ! VAR_1 . isEmpty ( ) ) { <START> if ( VAR_2 != null ) { <END> for ( TYPE_1 VAR_3 : VAR_1 ) { METHOD_2 ( ) . METHOD_3 ( VAR_4 . METHOD_4 ( VAR_2 , VAR_3 ) , this ) ; METHOD_2 ( ) . METHOD_3 ( VAR_4 . METHOD_5 ( VAR_2 , VAR_3 ) , this ) ; } } } } | public void METHOD_1 ( ) { if ( ! VAR_1 . isEmpty ( ) ) { if ( null != VAR_2 ) { for ( TYPE_1 VAR_3 : VAR_1 ) { METHOD_2 ( ) . METHOD_3 ( VAR_4 . METHOD_4 ( VAR_2 , VAR_3 ) , this ) ; METHOD_2 ( ) . METHOD_3 ( VAR_4 . METHOD_5 ( VAR_2 , VAR_3 ) , this ) ; } } } } |
null constant operations | protected void METHOD_1 ( final TYPE_1 VAR_1 , final View VAR_2 ) { <START> if ( VAR_2 != null ) { <END> TYPE_2 . METHOD_2 ( ) . METHOD_3 ( new TYPE_3 ( ) { @Override public void run ( ) { if ( TYPE_4 . METHOD_4 ( VAR_2 ) == VAR_1 ) { TYPE_5 command = new TYPE_5 ( VAR_2 ) ; try { TYPE_6 . write ( VAR_1 , command ) ; } ... | protected void METHOD_1 ( final TYPE_1 VAR_1 , final View VAR_2 ) { if ( null != VAR_2 ) { TYPE_2 . METHOD_2 ( ) . METHOD_3 ( new TYPE_3 ( ) { @Override public void run ( ) { if ( TYPE_4 . METHOD_4 ( VAR_2 ) == VAR_1 ) { TYPE_5 command = new TYPE_5 ( VAR_2 ) ; try { TYPE_6 . write ( VAR_1 , command ) ; } catch ( Except... |
return condition | protected boolean METHOD_1 ( final View view ) { boolean result = false ; <START> if ( view . VAR_1 ( ) instanceof TYPE_1 && ! ( ( TYPE_1 ) view . VAR_1 ( ) ) . METHOD_2 ( ) . isEmpty ( ) ) { <END> result = true ; } return result ; } | protected boolean METHOD_1 ( final View view ) { return ( view . VAR_1 ( ) instanceof TYPE_1 && ! ( ( TYPE_1 ) view . VAR_1 ( ) ) . METHOD_2 ( ) . isEmpty ( ) ) ; } |
I - factoring haven t changes function other refactoring I recommend submit a separate - factoring patch patch long ideally - separation widget a 2nd refactoring patch ( menu - item ideally ) touch line don t change identical line statement ( L 900 ) function a bit inconsistent | public void METHOD_1 ( int VAR_1 ) { METHOD_2 ( ) ; if ( this . VAR_1 == VAR_1 ) return ; long VAR_2 = METHOD_3 ( ) ; if ( VAR_2 != 0 ) METHOD_4 ( VAR_2 ) ; this . VAR_1 = VAR_1 ; <START> if ( VAR_2 != 0 ) { METHOD_5 ( VAR_2 ) ; } } <END> | public void METHOD_1 ( int VAR_1 ) { METHOD_2 ( ) ; if ( this . VAR_1 == VAR_1 ) return ; long VAR_2 = METHOD_3 ( ) ; if ( VAR_2 != 0 ) METHOD_4 ( VAR_2 ) ; this . VAR_1 = VAR_1 ; if ( VAR_2 != 0 ) METHOD_5 ( VAR_2 ) ; } |
break equal sign | public static < TYPE_1 > TYPE_2 < TYPE_1 > METHOD_1 ( final List < TYPE_3 < TYPE_1 > > VAR_1 ) { final TYPE_3 < ? > [ ] VAR_2 <START> = <END> VAR_1 . METHOD_2 ( new TYPE_3 [ VAR_1 . size ( ) ] ) ; return new TYPE_2 < TYPE_1 > ( ) { @Override public TYPE_3 < ? > [ ] METHOD_3 ( ) { return VAR_2 ; } } ; } | public static < TYPE_1 > TYPE_2 < TYPE_1 > METHOD_1 ( final List < TYPE_3 < TYPE_1 > > VAR_1 ) { final TYPE_3 < TYPE_1 > [ ] VAR_2 = VAR_1 . METHOD_2 ( new TYPE_3 [ VAR_1 . size ( ) ] ) ; return new TYPE_2 < TYPE_1 > ( ) { @Override public TYPE_3 < TYPE_1 > [ ] METHOD_3 ( ) { return VAR_2 ; } } ; } |
code simplified rely autounboxing | private T METHOD_1 ( ) { for ( TYPE_1 VAR_1 : options ) { if <START> ( Boolean . VAR_2 . equals ( VAR_1 . VAR_3 . getValue ( ) ) ) <END> return VAR_1 . value ; } return null ; } | private T METHOD_1 ( ) { for ( TYPE_1 VAR_1 : options ) { if ( VAR_1 . VAR_3 . getValue ( ) ) return VAR_1 . value ; } return null ; } |
code simplified rely autoboxing | protected void METHOD_1 ( Object value ) { int index = METHOD_2 ( value ) ; try { VAR_1 = true ; for ( int i = 0 ; i < options . size ( ) ; i ++ ) { <START> options . get ( i ) . VAR_2 . METHOD_3 ( i == index ? Boolean . VAR_3 : Boolean . VAR_4 ) ; <END> } } finally { VAR_1 = false ; } METHOD_4 ( index ) ; } | protected void METHOD_1 ( Object value ) { int index = METHOD_2 ( value ) ; try { VAR_1 = true ; for ( int i = 0 ; i < options . size ( ) ; i ++ ) { options . get ( i ) . VAR_2 . METHOD_3 ( i == index ) ; } } finally { VAR_1 = false ; } METHOD_4 ( index ) ; } |
TYPE_1 element : c | public boolean addAll ( Collection < ? extends TYPE_1 > c ) { boolean VAR_1 = false ; for <START> ( Iterator < ? <END> extends TYPE_1 > iterator = c . iterator ( ) ; iterator . hasNext ( ) ; ) { TYPE_1 element = iterator . next ( ) ; VAR_1 |= VAR_2 . add ( TYPE_2 . METHOD_1 ( element ) ) ; } return VAR_1 ; } | public boolean addAll ( Collection < ? extends TYPE_1 > c ) { boolean VAR_1 = false ; for ( TYPE_1 element : c ) { VAR_1 |= VAR_2 . add ( TYPE_2 . METHOD_1 ( element ) ) ; } return VAR_1 ; } |
code simplified rely autoboxing | protected Boolean METHOD_1 ( ) { return <START> VAR_1 . METHOD_2 ( ) ? Boolean . VAR_2 : Boolean . VAR_3 ; <END> } | protected Boolean METHOD_1 ( ) { return VAR_1 . METHOD_2 ( ) ; } |
TYPE_1 cache : _CODE_ values ( ) | boolean METHOD_1 ( Object value ) { for <START> ( Iterator < TYPE_1 > <END> it = VAR_1 . values ( ) . iterator ( ) ; it . hasNext ( ) ; ) { TYPE_1 cache = it . next ( ) ; if ( cache . VAR_2 ( value ) ) return true ; } return false ; } | boolean METHOD_1 ( Object value ) { for ( TYPE_1 cache : VAR_1 . values ( ) ) { if ( cache . VAR_2 ( value ) ) return true ; } return false ; } |
; work controlled models | public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> METHOD_2 ( ) . METHOD_3 ( ) . remove ( VAR_1 ) ; <END> } | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( METHOD_2 ( ) != null ) { METHOD_2 ( ) . METHOD_3 ( ) . remove ( VAR_1 ) ; } } |
METHOD_1 | public void METHOD_1 ( TYPE_1 cmd , String VAR_1 ) { <START> VAR_2 = true ; <END> VAR_3 . add ( cmd ) ; VAR_4 . append ( VAR_1 ) ; } | public void METHOD_1 ( TYPE_1 cmd , String VAR_1 ) { VAR_3 . add ( cmd ) ; VAR_4 . append ( VAR_1 ) ; } |
METHOD_1 caller runs push cert enabled client didn t send a push cert | public void METHOD_1 ( String VAR_1 ) { <START> VAR_2 = true ; <END> VAR_3 . add ( METHOD_2 ( METHOD_3 ( VAR_1 ) ) ) ; VAR_4 . append ( VAR_1 ) ; } | public void METHOD_1 ( String VAR_1 ) { VAR_3 . add ( METHOD_2 ( METHOD_3 ( VAR_1 ) ) ) ; VAR_4 . append ( VAR_1 ) ; } |
a bug reported JDT ( 470535 ) | public int METHOD_1 ( ) { int VAR_1 = 0 ; if ( this . METHOD_2 ( ) ) { VAR_1 ++ ; } for ( int i = 0 ; i < this . VAR_2 . length ; i ++ ) { <START> VAR_1 = VAR_1 * INT_1 + this . VAR_2 . METHOD_1 ( ) ; <END> } return VAR_1 ; } | public int METHOD_1 ( ) { int VAR_1 = 0 ; if ( this . METHOD_2 ( ) ) { VAR_1 ++ ; } for ( int i = 0 ; i < this . VAR_2 . length ; i ++ ) { VAR_1 = VAR_1 * INT_1 + this . VAR_2 [ i ] . METHOD_1 ( ) ; } return VAR_1 ; } |
assigning VAR_7 a new return VAR_7 - assign VAR_7 s s returned duplicate assignment strange code instead consider simply returning a new TYPE_1 object touching VAR_7 call leave assignment parent method | TYPE_1 METHOD_1 ( long VAR_1 , TYPE_2 VAR_2 ) { int VAR_3 = 0 ; int VAR_4 = 0 ; int VAR_5 = 0 ; OS . VAR_6 ( VAR_1 , VAR_2 ) ; VAR_3 = ( int ) ( VAR_2 . VAR_3 * INT_1 ) ; VAR_4 = ( int ) ( VAR_2 . VAR_4 * INT_1 ) ; VAR_5 = ( int ) ( VAR_2 . VAR_5 * INT_1 ) ; <START> VAR_7 = new TYPE_1 ( VAR_3 , VAR_4 , VAR_5 ) ; <END> ... | TYPE_1 METHOD_1 ( long VAR_1 , TYPE_2 VAR_2 ) { int VAR_3 = 0 ; int VAR_4 = 0 ; int VAR_5 = 0 ; OS . VAR_6 ( VAR_1 , VAR_2 ) ; VAR_3 = ( int ) ( VAR_2 . VAR_3 * INT_1 ) ; VAR_4 = ( int ) ( VAR_2 . VAR_4 * INT_1 ) ; VAR_5 = ( int ) ( VAR_2 . VAR_5 * INT_1 ) ; return new TYPE_1 ( VAR_3 , VAR_4 , VAR_5 ) ; } |
VAR_2 = VAR_1 | <START> public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; VAR_2 . METHOD_4 ( VAR_1 . getMessage ( ) ) ; } <END> | public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = VAR_1 ; } |
simpler : return new ArrayList < > ( new HashSet < > ( VAR_1 ) ) ; | private static List < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> HashSet < TYPE_1 > set <END> = new HashSet < > ( ) ; set . addAll ( VAR_1 ) ; return Arrays . asList ( set . VAR_2 ( new TYPE_1 [ set . size ( ) ] ) ) ; } | private static List < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 ) { return new ArrayList < > ( new HashSet < > ( VAR_1 ) ) ; } |
redundant else | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_1 instanceof TYPE_1 ) { return ( TYPE_1 ) VAR_1 ; } <START> else { <END> return null ; } } | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_1 instanceof TYPE_1 ) { return ( TYPE_1 ) VAR_1 ; } return null ; } |
redundant initialization | public TYPE_3 ( String name , TYPE_1 VAR_2 , int VAR_3 , char [ ] VAR_4 , TYPE_2 VAR_5 ) { this . name = name ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_6 = <START> false ; <END> } | public TYPE_3 ( String name , TYPE_1 VAR_2 , int VAR_3 , char [ ] VAR_4 , TYPE_2 VAR_5 ) { this . name = name ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; } |
redundant else clause | protected TYPE_1 getType ( TYPE_2 VAR_1 ) { if ( ! METHOD_1 ( VAR_1 ) ) { if ( VAR_1 instanceof TYPE_3 ) { return ( ( TYPE_3 ) VAR_1 ) . getType ( ) ; } else { <START> return null ; <END> } } return null ; } | protected TYPE_1 getType ( TYPE_2 VAR_1 ) { if ( ! METHOD_1 ( VAR_1 ) && VAR_1 instanceof TYPE_3 ) return ( ( TYPE_3 ) VAR_1 ) . getType ( ) ; return null ; } |
checkif remove thatbecause a notification service VAR_1 | protected void METHOD_1 ( ) { for ( TYPE_1 VAR_1 : VAR_2 ) { element . VAR_3 ( VAR_1 ) ; <START> element . VAR_4 ( new TYPE_2 ( TYPE_3 . VAR_6 , true , true , true ) ) ; <END> } } | protected void METHOD_1 ( ) { for ( TYPE_1 VAR_1 : VAR_2 ) { element . VAR_3 ( VAR_1 ) ; } } |
avoid unrelated formatting changes | <START> public static void METHOD_1 ( TYPE_1 VAR_1 , <END> TYPE_1 VAR_2 , String VAR_3 , String VAR_4 , TYPE_2 VAR_5 , TYPE_3 VAR_6 ) { final TYPE_4 VAR_7 = TYPE_5 . METHOD_2 ( VAR_3 , VAR_1 , VAR_5 ) ; final TYPE_4 next = TYPE_5 . METHOD_2 ( VAR_4 , VAR_2 , VAR_5 ) ; TYPE_6 in = new TYPE_7 ( VAR_7 , next , VAR_5 , nul... | public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 , String VAR_3 , String VAR_4 , TYPE_2 VAR_5 , TYPE_3 VAR_6 ) { final TYPE_4 VAR_7 = TYPE_5 . METHOD_2 ( VAR_3 , VAR_1 , VAR_5 ) ; final TYPE_4 next = TYPE_5 . METHOD_2 ( VAR_4 , VAR_2 , VAR_5 ) ; TYPE_6 in = new TYPE_7 ( VAR_7 , next , null ) ; TYPE_5 . METHOD_... |
revert unrelated formatting change | public String getPath ( ) { TYPE_1 uri = VAR_1 . METHOD_1 ( ) ; <START> if ( uri != null ) { <END> return uri . getPath ( ) ; } return getName ( ) ; } | public String getPath ( ) { TYPE_1 uri = VAR_1 . METHOD_1 ( ) ; if ( uri != null ) return uri . getPath ( ) ; return getName ( ) ; } |
removed | protected void METHOD_1 ( String VAR_1 , String VAR_2 , TYPE_1 VAR_3 ) throws TYPE_2 , IOException { project = TYPE_3 . METHOD_2 ( VAR_1 ) ; VAR_4 = TYPE_4 . METHOD_3 ( project , VAR_3 , METHOD_4 ( ) , VAR_2 ) ; if ( VAR_4 != null ) { <START> System . out . println ( STRING_1 ) ; <END> } } | protected void METHOD_1 ( String VAR_1 , String VAR_2 , TYPE_1 VAR_3 ) throws TYPE_2 , IOException { project = TYPE_3 . METHOD_2 ( VAR_1 ) ; VAR_4 = TYPE_4 . METHOD_3 ( project , VAR_3 , METHOD_4 ( ) , VAR_2 ) ; } |
done | public TYPE_2 ( TYPE_1 VAR_2 ) { <START> this . VAR_3 = VAR_2 ; <END> } | public TYPE_2 ( TYPE_1 VAR_2 ) { VAR_3 = VAR_2 ; } |
constant variable operator | protected void METHOD_1 ( final TYPE_1 VAR_1 , final View VAR_2 ) { if ( null != VAR_2 ) { <START> if ( VAR_1 != null && TYPE_2 . METHOD_2 ( VAR_2 ) == VAR_1 ) { <END> TYPE_3 command = new TYPE_3 ( VAR_2 ) ; try { TYPE_4 . write ( VAR_1 , command ) ; } catch ( Exception e ) { TYPE_5 . log . error ( e ) ; } } } } | protected void METHOD_1 ( final TYPE_1 VAR_1 , final View VAR_2 ) { if ( null != VAR_2 ) { if ( null != VAR_1 && TYPE_2 . METHOD_2 ( VAR_2 ) == VAR_1 ) { TYPE_3 command = new TYPE_3 ( VAR_2 ) ; try { TYPE_4 . write ( VAR_1 , command ) ; } catch ( Exception e ) { TYPE_5 . log . error ( e ) ; } } } } |
cnn | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 [ ] VAR_2 = new TYPE_1 [ VAR_1 . VAR_3 . size ( ) ] ; for ( int i = 0 ; i < VAR_2 . length ; i ++ ) { <START> VAR_2 [ i ] = new TYPE_3 ( METHOD_2 ( VAR_1 . VAR_3 . get ( i ) . name ) , null , null ) ; <END> } TYPE_1 VAR_4 = new TYPE_3 ( TYPE_1 . VAR_5 , null , VA... | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 [ ] VAR_2 = new TYPE_1 [ VAR_1 . VAR_3 . size ( ) ] ; for ( int i = 0 ; i < VAR_2 . length ; i ++ ) { VAR_2 [ i ] = new TYPE_3 ( VAR_1 . VAR_3 . get ( i ) . name , null , null ) ; } TYPE_1 VAR_4 = new TYPE_3 ( TYPE_1 . VAR_5 , null , VAR_2 ) ; return VAR_4 ; } |
I assume didn t expect commit : - D | public Object METHOD_1 ( ANNOTATION_1 ( STRING_1 ) final Class VAR_1 ) { Object result ; <START> if ( STRING_2 . equals ( VAR_1 . toString ( ) ) ) { System . out . println ( ) ; } <END> if ( VAR_1 . METHOD_2 ( this ) ) { result = this ; } else { result = this . VAR_2 . METHOD_1 ( VAR_1 ) ; if ( result == null ) { resul... | public Object METHOD_1 ( ANNOTATION_1 ( STRING_1 ) final Class VAR_1 ) { Object result ; if ( VAR_1 . METHOD_2 ( this ) ) { result = this ; } else { result = this . VAR_2 . METHOD_1 ( VAR_1 ) ; if ( result == null ) { result = super . METHOD_1 ( VAR_1 ) ; } } return result ; } |
logged instead ? removed needed | public TYPE_1 METHOD_1 ( String id ) { <START> System . err . println ( id ) ; <END> for ( TYPE_1 column : VAR_1 ) { if ( column . VAR_2 ( ) . equals ( id ) ) { return column ; } } return null ; } | public TYPE_1 METHOD_1 ( String id ) { for ( TYPE_1 column : VAR_1 ) { if ( column . VAR_2 ( ) . equals ( id ) ) { return column ; } } return null ; } |
das gibt eine _CODE_ wenn format = null | private boolean METHOD_1 ( String format ) { <START> String VAR_1 = format . VAR_2 ( STRING_1 , "" ) ; <END> return ! VAR_1 . contains ( STRING_2 ) && ! VAR_1 . contains ( STRING_3 ) && ! VAR_1 . contains ( STRING_4 ) && ! VAR_1 . contains ( STRING_5 ) && ! VAR_1 . contains ( STRING_6 ) && ! VAR_1 . contains ( STRING_7... | private boolean METHOD_1 ( String format ) { if ( format == null ) { return true ; } String VAR_1 = format . VAR_2 ( STRING_1 , "" ) ; return ! VAR_1 . contains ( STRING_2 ) && ! VAR_1 . contains ( STRING_3 ) && ! VAR_1 . contains ( STRING_4 ) && ! VAR_1 . contains ( STRING_5 ) && ! VAR_1 . contains ( STRING_6 ) && ! V... |
parameter true | public void METHOD_1 ( ) throws Throwable { <START> METHOD_2 ( false ) ; <END> } | public void METHOD_1 ( ) throws Throwable { METHOD_2 ( true ) ; } |
experiment parameter trace experiment handling _CODE_ signal traces experiment remove VAR_4 | protected void METHOD_1 ( TYPE_1 trace , TYPE_2 VAR_1 , List < TYPE_3 > list ) { METHOD_1 ( trace , list ) ; synchronized ( VAR_2 ) { List < TYPE_3 > VAR_3 = VAR_2 . get ( VAR_1 ) ; if ( VAR_3 == null ) { VAR_2 . put ( VAR_1 , new TYPE_4 < > ( list ) ) ; } else { VAR_3 . addAll ( list ) ; } <START> VAR_4 . put ( trace ... | protected void METHOD_1 ( TYPE_1 trace , TYPE_2 VAR_1 , List < TYPE_3 > list ) { super . METHOD_1 ( trace , list ) ; synchronized ( VAR_2 ) { List < TYPE_3 > VAR_3 = VAR_2 . get ( VAR_1 ) ; if ( VAR_3 == null ) { VAR_2 . put ( VAR_1 , new TYPE_4 < > ( list ) ) ; } else { VAR_3 . addAll ( list ) ; } VAR_4 . put ( trace ... |
selected trace a kernel trace viewer data remains call METHOD_3 ( null ) | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { if ( VAR_1 == null ) { <START> return ; <END> } TYPE_2 < TYPE_3 > results = VAR_1 . METHOD_2 ( ) ; if ( results != null ) { METHOD_3 ( TYPE_4 . METHOD_4 ( results ) ) ; return ; } TYPE_4 . METHOD_5 ( VAR_2 ) ; } | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { if ( VAR_1 == null ) { METHOD_3 ( null ) ; return ; } TYPE_2 < TYPE_3 > results = VAR_1 . METHOD_2 ( ) ; if ( results != null ) { METHOD_3 ( TYPE_4 . METHOD_4 ( results ) ) ; return ; } METHOD_3 ( null ) ; TYPE_4 . METHOD_5 ( VAR_2 ) ; } |
controls disposed platform need call super METHOD_1 ( ) viewer a _CODE_ | public void METHOD_1 ( ) { <START> METHOD_2 ( ) . METHOD_3 ( ) . METHOD_1 ( ) ; <END> super . METHOD_1 ( ) ; } | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; } |
switch traces added times a listener | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( VAR_1 ) ; if ( VAR_2 != null ) { <START> VAR_2 . METHOD_3 ( VAR_3 ) ; <END> if ( VAR_2 . METHOD_4 ( ) == null ) { if ( TYPE_3 . METHOD_5 ( ) ) { return ; } } VAR_4 = TYPE_3 . METHOD_6 ( VAR_2 ) ; METHOD_7 ( VAR_4 ) ; } } | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( VAR_1 ) ; VAR_4 = TYPE_3 . METHOD_6 ( VAR_2 ) ; METHOD_7 ( VAR_4 ) ; } |
a listener _CODE_ METHOD_1 | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( VAR_1 ) ; if ( VAR_2 != null ) { <START> VAR_2 . METHOD_3 ( VAR_3 ) ; <END> TYPE_3 . METHOD_4 ( ) ; } } | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( VAR_1 ) ; if ( VAR_2 != null ) { TYPE_3 . METHOD_4 ( VAR_3 ) ; } } |
I m mistaken VAR_1 results stay memory long trace opened full copy results tree map store copy memory | public static TYPE_1 METHOD_1 ( ANNOTATION_1 TYPE_2 VAR_1 ) { if ( VAR_1 != null ) { TYPE_3 < TYPE_4 > results = VAR_1 . METHOD_2 ( ) ; if ( results != null ) { <START> return METHOD_3 ( results ) ; <END> } } return new TYPE_1 ( new TYPE_5 < > ( ) ) ; } | public static TYPE_1 METHOD_1 ( ANNOTATION_1 TYPE_2 VAR_1 ) { TYPE_3 < TYPE_4 > results = null ; if ( VAR_1 != null ) { results = VAR_1 . METHOD_2 ( ) ; } return METHOD_3 ( results ) ; } |
TYPE_1 _CODE_ ( ) called preserve selection ( based index ) _CODE_ _CODE_ ( ) : 489 update element ( calls method ) * * a bounds check selection index I a bug _CODE_ a workaround clear selection changing input sense want preserve selected index unrelated input segment store | public void METHOD_1 ( int index ) { final TYPE_1 VAR_1 = VAR_2 ; final TYPE_2 [ ] VAR_3 = VAR_4 ; <START> if ( VAR_1 != null && VAR_3 != null ) { VAR_1 . METHOD_2 ( VAR_3 [ index ] , index ) ; } <END> } | public void METHOD_1 ( int index ) { final TYPE_1 VAR_1 = VAR_2 ; final TYPE_2 [ ] VAR_3 = VAR_4 ; if ( VAR_1 != null && VAR_3 != null ) { if ( index < VAR_3 . length ) { VAR_1 . METHOD_2 ( VAR_3 [ index ] , index ) ; } } } |
Set segment array null input a valid segment store | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , ANNOTATION_1 Object VAR_2 , ANNOTATION_1 Object VAR_3 ) { VAR_4 = ( TYPE_2 ) VAR_1 ; if ( VAR_3 instanceof TYPE_3 < ? > ) { TYPE_3 < ? > VAR_5 = ( TYPE_3 < ? > ) VAR_3 ; VAR_6 = TYPE_4 . METHOD_2 ( VAR_5 , TYPE_5 . class ) ; if ( VAR_7 != null ) { Arrays . VAR_8 ( VAR_... | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , ANNOTATION_1 Object VAR_2 , ANNOTATION_1 Object VAR_3 ) { VAR_4 = ( TYPE_2 ) VAR_1 ; if ( VAR_3 instanceof TYPE_3 < ? > ) { TYPE_3 < ? > VAR_5 = ( TYPE_3 < ? > ) VAR_3 ; VAR_6 = TYPE_4 . METHOD_2 ( VAR_5 , TYPE_5 . class ) ; if ( VAR_7 != null ) { Arrays . VAR_8 ( VAR_... |
consider making method private package scope | protected boolean <START> METHOD_1 ( char <END> VAR_1 ) { return TYPE_1 . METHOD_2 ( VAR_1 ) ; } | private boolean METHOD_1 ( char VAR_1 ) { return TYPE_1 . METHOD_2 ( VAR_1 ) ; } |
please set instruction file getPath ( ) case errors instead file VAR_2 ( ) | public String getPath ( ) { <START> try { return file . VAR_1 ( ) . getPath ( ) ; } catch ( TYPE_1 e ) { return file . VAR_2 ( ) ; } <END> } | public String getPath ( ) { try { return file . VAR_1 ( ) . getPath ( ) ; } catch ( TYPE_1 e ) { return file . getPath ( ) ; } } |
doesn t need public | <START> public void METHOD_1 ( boolean VAR_1 ) { <END> this . VAR_2 = VAR_1 ; } | private void METHOD_1 ( boolean VAR_1 ) { this . VAR_2 = VAR_1 ; } |
please delete line replace adapterfactory ! = null statement don t want raise error tooltip t computed | protected String METHOD_1 ( TYPE_1 VAR_1 ) { <START> TYPE_2 . METHOD_2 ( VAR_2 ) ; <END> if ( VAR_1 != null ) { Object VAR_3 = VAR_2 . METHOD_3 ( VAR_1 , TYPE_3 . class ) ; if ( VAR_3 instanceof TYPE_3 ) { return ( ( TYPE_3 ) VAR_3 ) . METHOD_4 ( VAR_1 ) ; } } return null ; } | protected String METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { Object VAR_3 = VAR_2 . METHOD_3 ( VAR_1 , TYPE_3 . class ) ; if ( VAR_3 instanceof TYPE_3 ) { return ( ( TYPE_3 ) VAR_3 ) . METHOD_4 ( VAR_1 ) ; } } return null ; } |
VAR_5 prevent - entrant calls function I m normal table modified modified boolean flag avoids problem added ( VAR_3 length > index ) check needed number entries current intervals view reduced selecting a new timestamp viewer new limit | public void METHOD_1 ( int index ) { final TYPE_1 VAR_1 = VAR_2 ; final TYPE_2 [ ] VAR_3 = VAR_4 ; if ( ( VAR_1 != null ) && ( VAR_3 != null ) && <START> ( VAR_3 . length > index ) && ! VAR_5 ) { <END> VAR_5 = true ; VAR_1 . METHOD_2 ( VAR_3 [ index ] , index ) ; VAR_5 = false ; } } | public void METHOD_1 ( int index ) { final TYPE_1 VAR_1 = VAR_2 ; final TYPE_2 [ ] VAR_3 = VAR_4 ; if ( ( VAR_1 != null ) && ( VAR_3 != null ) && ( VAR_3 . length > index ) ) { VAR_1 . METHOD_2 ( VAR_3 [ index ] , index ) ; } } |
protected | <START> public void METHOD_1 ( final boolean VAR_1 , final boolean VAR_2 ) { <END> final TYPE_1 VAR_3 = METHOD_2 ( ) ; if ( VAR_3 . METHOD_3 ( ) ) { return ; } TYPE_2 . METHOD_4 ( ) . METHOD_5 ( new TYPE_3 ( ) { @Override public void run ( ) { if ( ! VAR_3 . METHOD_3 ( ) ) { VAR_4 . METHOD_6 ( VAR_1 , VAR_2 ) ; } } } )... | protected void METHOD_1 ( final boolean VAR_1 , final boolean VAR_2 ) { final TYPE_1 VAR_3 = METHOD_2 ( ) ; if ( VAR_3 . METHOD_3 ( ) ) { return ; } TYPE_2 . METHOD_4 ( ) . METHOD_5 ( new TYPE_3 ( ) { @Override public void run ( ) { if ( ! VAR_3 . METHOD_3 ( ) ) { VAR_4 . METHOD_6 ( VAR_1 , VAR_2 ) ; } } } ) ; } |
protected | <START> public void METHOD_1 ( boolean VAR_1 ) { <END> METHOD_2 ( ) ; METHOD_3 ( false ) ; } | protected void METHOD_1 ( boolean VAR_1 ) { METHOD_2 ( ) ; METHOD_3 ( false ) ; } |
needs synchronized | <START> TYPE_1 METHOD_1 ( ) { <END> return VAR_1 ; } | synchronized TYPE_1 METHOD_1 ( ) { return VAR_1 ; } |
purpose METHOD_1 method allow extenders overwrite implementation instead : ( VAR_1 = = null ) { VAR_1 = new TYPE_1 ( ) ; } return VAR_1 ; | public TYPE_1 METHOD_1 ( ) { <START> return VAR_1 ; <END> } | public TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( ) ; } return VAR_1 ; } |
private | <START> public void METHOD_1 ( ) { <END> final TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 . METHOD_3 ( ) ) { return ; } TYPE_2 . METHOD_4 ( ) . METHOD_5 ( new TYPE_3 ( ) { @Override public void run ( ) { if ( ! VAR_1 . METHOD_3 ( ) ) { VAR_2 . METHOD_6 ( ) ; } } } ) ; } | private void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 . METHOD_3 ( ) ) { return ; } TYPE_2 . METHOD_4 ( ) . METHOD_5 ( new TYPE_3 ( ) { @Override public void run ( ) { if ( ! VAR_1 . METHOD_3 ( ) ) { VAR_2 . METHOD_6 ( ) ; } } } ) ; } |
package visible | <START> public void METHOD_1 ( boolean VAR_1 , TYPE_1 VAR_2 ) { <END> Map < TYPE_1 , TYPE_2 > VAR_3 = VAR_1 ? VAR_4 : VAR_5 ; TYPE_2 job = VAR_3 . remove ( VAR_2 ) ; if ( job != null ) { job . VAR_6 ( ) ; } } | void METHOD_1 ( boolean VAR_1 , TYPE_1 VAR_2 ) { Map < TYPE_1 , TYPE_2 > VAR_3 = VAR_1 ? VAR_4 : VAR_5 ; TYPE_2 job = VAR_3 . remove ( VAR_2 ) ; if ( job != null ) { job . VAR_6 ( ) ; } } |
context sync obj | public void METHOD_1 ( final TYPE_1 context ) { TYPE_2 . METHOD_2 ( ) . METHOD_3 ( new TYPE_3 ( ) { @Override public void run ( ) { <START> synchronized ( context . VAR_1 ( ) ) { <END> if ( ! context . VAR_2 ( ) ) { context . VAR_3 ( ) ; context . VAR_4 ( ) . METHOD_4 ( ) ; } } } } ) ; } | public void METHOD_1 ( final TYPE_1 context ) { TYPE_2 . METHOD_2 ( ) . METHOD_3 ( new TYPE_3 ( ) { @Override public void run ( ) { synchronized ( context ) { if ( ! context . VAR_2 ( ) ) { context . VAR_3 ( ) ; context . VAR_4 ( ) . METHOD_4 ( ) ; } } } } ) ; } |
remove | public void METHOD_1 ( TYPE_1 parent , String VAR_1 , TYPE_2 trace ) { super . METHOD_1 ( parent , VAR_1 ) ; VAR_2 ++ ; VAR_3 = VAR_2 ; VAR_4 = trace ; <START> VAR_5 = new TYPE_3 ( ) ; <END> VAR_6 = ( trace instanceof TYPE_4 ) ; METHOD_2 ( parent ) ; METHOD_3 ( ) ; } | public void METHOD_1 ( TYPE_1 parent , String VAR_1 , TYPE_2 trace ) { super . METHOD_1 ( parent , VAR_1 ) ; VAR_2 ++ ; VAR_3 = VAR_2 ; VAR_4 = trace ; VAR_6 = ( trace instanceof TYPE_4 ) ; METHOD_2 ( parent ) ; METHOD_3 ( ) ; } |
want potential NPE ? checks VAR_1 ! = null a null VAR_1 caught catch I d argue VAR_2 = = null result VAR_3 cases VAR_1 null | public Boolean exists ( Collection < Object > VAR_1 , TYPE_1 VAR_2 ) { Boolean result = Boolean . VAR_3 ; if ( VAR_1 != null && VAR_2 == null ) { result = Boolean . VAR_3 ; } else { <START> for ( Object input : VAR_1 ) { <END> try { if ( Boolean . VAR_4 . equals ( VAR_2 . METHOD_1 ( new Object [ ] { input } ) ) ) { res... | public Boolean exists ( Collection < Object > VAR_1 , TYPE_1 VAR_2 ) { Boolean result = Boolean . VAR_3 ; if ( VAR_1 != null && VAR_2 != null ) { for ( Object input : VAR_1 ) { try { if ( Boolean . VAR_4 . equals ( VAR_2 . METHOD_1 ( new Object [ ] { input } ) ) ) { result = Boolean . VAR_4 ; break ; } } catch ( Except... |
don t VAR_3 needed VAR_4 artifact readable | <START> public Map < String , TYPE_1 > METHOD_1 ( long VAR_1 , String VAR_2 ) { <END> TYPE_2 VAR_3 = TYPE_3 . METHOD_2 ( VAR_1 , "" ) ; TYPE_1 VAR_4 = METHOD_3 ( ) . METHOD_4 ( VAR_1 ) . METHOD_5 ( VAR_2 ) . METHOD_6 ( ) . METHOD_7 ( ) ; List < TYPE_1 > VAR_5 = VAR_4 . METHOD_8 ( ) ; return METHOD_9 ( VAR_5 , VAR_3 ) ;... | public Map < String , TYPE_1 > METHOD_1 ( long VAR_1 , String VAR_2 ) { TYPE_1 VAR_4 = METHOD_3 ( ) . METHOD_4 ( VAR_1 ) . METHOD_5 ( VAR_2 ) . METHOD_6 ( ) . METHOD_7 ( ) ; List < TYPE_1 > VAR_5 = VAR_4 . METHOD_8 ( ) ; return METHOD_9 ( VAR_5 ) ; } |
METHOD_3 ( VAR_1 ) | protected TYPE_1 METHOD_1 ( int VAR_1 ) { <START> TYPE_2 ctx = VAR_2 . METHOD_2 ( ) . METHOD_3 ( 0 ) ; <END> for ( int i = 0 ; i < VAR_1 ; i ++ ) { VAR_2 . METHOD_2 ( ) . METHOD_4 ( ctx ) ; } final TYPE_1 next = VAR_2 . METHOD_2 ( ) . METHOD_4 ( ctx ) ; ctx . VAR_3 ( ) ; return next ; } | protected TYPE_1 METHOD_1 ( int VAR_1 ) { TYPE_2 ctx = VAR_2 . METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ; final TYPE_1 next = VAR_2 . METHOD_2 ( ) . METHOD_4 ( ctx ) ; ctx . VAR_3 ( ) ; return next ; } |
protected | <START> private void METHOD_1 ( String VAR_1 ) { <END> TYPE_1 VAR_2 = TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) ; METHOD_4 ( VAR_2 . METHOD_5 ( METHOD_6 ( ) , VAR_1 ) ) ; } | protected void METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) ; METHOD_4 ( VAR_2 . METHOD_5 ( METHOD_6 ( ) , VAR_1 ) ) ; } |
weird | public static TYPE_1 METHOD_1 ( ) { TYPE_1 path = TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) ; path = path . VAR_1 ( ) . append ( VAR_2 ) ; File VAR_3 = path . VAR_4 ( ) ; if ( ! VAR_3 . exists ( ) || ! VAR_3 . METHOD_4 ( ) ) { VAR_3 . METHOD_5 ( ) ; } <START> VAR_3 . METHOD_6 ( ) ; <END> return path ; } | public static TYPE_1 METHOD_1 ( ) { TYPE_1 path = TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) ; path = path . VAR_1 ( ) . append ( VAR_2 ) ; File VAR_3 = path . VAR_4 ( ) ; if ( ! VAR_3 . exists ( ) || ! VAR_3 . METHOD_4 ( ) ) { VAR_3 . METHOD_5 ( ) ; } return path ; } |
necessary ? _CODE_ ( ) overriden check a selected image checked | public TYPE_3 ( final TYPE_1 model ) { super ( STRING_1 , TYPE_2 . getString ( STRING_2 ) , TYPE_4 . VAR_3 ) ; METHOD_1 ( TYPE_2 . getString ( STRING_2 ) ) ; <START> METHOD_2 ( true ) ; <END> this . model = model ; } | public TYPE_3 ( final TYPE_1 model ) { super ( STRING_1 , TYPE_2 . getString ( STRING_2 ) , TYPE_4 . VAR_3 ) ; METHOD_1 ( TYPE_2 . getString ( STRING_2 ) ) ; this . model = model ; } |
please remove redundant type information another follow commit | public Object [ ] METHOD_1 ( Object VAR_1 ) { <START> List < TYPE_1 > list = new ArrayList < TYPE_1 > ( ) ; <END> Iterator < TYPE_1 > iterator = TYPE_2 . getInstance ( ) . METHOD_2 ( ) . iterator ( ) ; while ( iterator . hasNext ( ) ) { TYPE_1 VAR_2 = iterator . next ( ) ; list . add ( VAR_2 ) ; } return list . VAR_3 (... | public Object [ ] METHOD_1 ( Object VAR_1 ) { List < TYPE_1 > list = new ArrayList < > ( ) ; Iterator < TYPE_1 > iterator = TYPE_2 . getInstance ( ) . METHOD_2 ( ) . iterator ( ) ; while ( iterator . hasNext ( ) ) { TYPE_1 VAR_2 = iterator . next ( ) ; list . add ( VAR_2 ) ; } return list . VAR_3 ( ) ; } |
a pre - commit listener ( I agree more sense a post - commit listener ) I needs aggregate pre - commit listener meaning invoked commit top - transaction case nested transactions running a refactoring operation ( user interaction time ? ) nested transaction commits | public TYPE_1 <START> METHOD_1 ( TYPE_2 <END> event ) throws TYPE_3 { List < TYPE_4 > VAR_1 = event . VAR_2 ( ) ; TYPE_5 VAR_3 = new TYPE_5 ( ) ; for ( TYPE_4 VAR_4 : VAR_1 ) { TYPE_1 VAR_5 = METHOD_2 ( VAR_4 ) ; if ( null != VAR_5 ) { VAR_3 . append ( VAR_5 ) ; } } return VAR_3 . isEmpty ( ) ? null : VAR_3 ; } | public TYPE_1 METHOD_1 ( TYPE_2 event ) throws TYPE_3 { List < TYPE_4 > VAR_1 = event . VAR_2 ( ) ; TYPE_1 VAR_5 = null ; if ( ! VAR_1 . isEmpty ( ) ) { VAR_5 = METHOD_2 ( VAR_1 . get ( 0 ) ) ; } return VAR_5 ; } |
returned | public String METHOD_1 ( Object element ) { String VAR_1 = <START> VAR_2 ; <END> if ( element instanceof TYPE_1 ) { VAR_1 = ( ( TYPE_1 ) element ) . getName ( ) ; } else { VAR_1 = super . METHOD_1 ( element ) ; } return VAR_1 ; } | public String METHOD_1 ( Object element ) { String VAR_1 = null ; if ( element instanceof TYPE_1 ) { VAR_1 = ( ( TYPE_1 ) element ) . getName ( ) ; } else { VAR_1 = super . METHOD_1 ( element ) ; } return VAR_1 ; } |
capitals enumeration constant code human - readable ( getName ( ) method ) | public String METHOD_1 ( final Object element ) { String text = STRING_1 ; if ( element instanceof TYPE_1 ) { text = <START> element . toString ( ) ; <END> } return text ; } | public String METHOD_1 ( final Object element ) { String text = STRING_1 ; if ( element instanceof TYPE_1 ) { text = ( ( TYPE_1 ) element ) . getName ( ) ; } return text ; } |
I _CODE_ arrays boring I dangerous transforming a List : - METHOD_2 ( ) returns null a _CODE_ - turning a list iterate private method decided define a Collection parameter weel receive array parameter = > I recommend array check null case security | public TYPE_1 METHOD_1 ( ) { <START> Collection < TYPE_2 > VAR_1 = Arrays . asList ( VAR_2 . METHOD_2 ( ) ) ; <END> Set < TYPE_3 > VAR_3 = METHOD_3 ( VAR_1 ) ; return new TYPE_1 ( VAR_3 ) ; } | public TYPE_1 METHOD_1 ( ) { TYPE_2 [ ] VAR_1 = VAR_2 . METHOD_2 ( ) ; Set < TYPE_3 > VAR_3 = METHOD_3 ( VAR_1 ) ; return new TYPE_1 ( VAR_3 ) ; } |
remove else branch | public TYPE_1 METHOD_1 ( TYPE_2 parent ) { TYPE_1 table = ( TYPE_1 ) METHOD_2 ( ) ; if ( table == null ) { VAR_1 = parent ; VAR_2 = METHOD_3 ( parent , SWT . VAR_3 | SWT . VAR_4 | SWT . VAR_5 | SWT . VAR_6 | SWT . VAR_7 ) ; table = VAR_2 . METHOD_4 ( ) ; table . VAR_8 ( parent . VAR_9 ( ) ) ; VAR_2 . METHOD_5 ( new TYP... | public TYPE_1 METHOD_1 ( TYPE_2 parent ) { TYPE_1 table = ( TYPE_1 ) METHOD_2 ( ) ; if ( table == null ) { VAR_1 = parent ; VAR_2 = METHOD_3 ( parent , SWT . VAR_3 | SWT . VAR_4 | SWT . VAR_5 | SWT . VAR_6 | SWT . VAR_7 ) ; table = VAR_2 . METHOD_4 ( ) ; table . VAR_8 ( parent . VAR_9 ( ) ) ; VAR_2 . METHOD_5 ( new TYP... |
changed Arrays asList ( VAR_1 ) | <START> private List < Object > METHOD_1 ( ) { <END> List < Object > result = new ArrayList ( this . VAR_1 . length ) ; for ( String VAR_2 : this . VAR_1 ) { result . add ( VAR_2 ) ; } return result ; } | private List < String > METHOD_1 ( ) { return Arrays . asList ( this . VAR_1 ) ; } |
trace statements removed | public boolean METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( TYPE_1 . VAR_2 , VAR_3 . METHOD_4 ( ) ) ; <START> System . out . println ( VAR_3 . METHOD_4 ( ) ) ; <END> System . out . println ( VAR_4 . METHOD_4 ( ) ) ; METHOD_2 ( ) . METHOD_3 ( TYPE_1 . VAR_5 , VAR_4 . METHOD_4 ( ) ) ; return super . METHOD_1 ( ) ; } | public boolean METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( TYPE_1 . VAR_2 , VAR_3 . METHOD_4 ( ) ) ; METHOD_2 ( ) . METHOD_3 ( TYPE_1 . VAR_5 , VAR_4 . METHOD_4 ( ) ) ; return super . METHOD_1 ( ) ; } |
necessary quality rule : MITRE CWE - 397 - declaration throws generic Exception | public void METHOD_1 ( ) <START> throws Exception { <END> METHOD_2 ( null ) ; } | public void METHOD_1 ( ) { METHOD_2 ( null ) ; } |
list empty change VAR_1 select ( erase current editor VAR_1 ) example diagram editor select diagram case | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { List < TYPE_3 > VAR_3 = METHOD_2 ( VAR_2 . METHOD_3 ( ) , ( ( TYPE_4 ) VAR_1 ) . METHOD_4 ( ) ) ; if ( ! VAR_3 . isEmpty ( ) ) { TYPE_6 . TYPE_7 . METHOD_5 ( VAR_2 , VAR_3 ) ; <START> } <END> } | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { List < TYPE_3 > VAR_3 = METHOD_2 ( VAR_2 . METHOD_3 ( ) , ( ( TYPE_4 ) VAR_1 ) . METHOD_4 ( ) ) ; TYPE_6 . TYPE_7 . METHOD_5 ( VAR_2 , VAR_3 ) ; } |
method declared private | <START> TYPE_2 . TYPE_3 METHOD_1 ( ) { <END> return VAR_1 . METHOD_1 ( ) ; } | private TYPE_2 . TYPE_3 METHOD_1 ( ) { return VAR_1 . METHOD_1 ( ) ; } |
add braces - block | Set < TYPE_2 . TYPE_3 > METHOD_1 ( Set < TYPE_2 . TYPE_3 > VAR_1 ) { Set < TYPE_2 . TYPE_3 > VAR_2 = new HashSet < TYPE_2 . TYPE_3 > ( ) ; <START> if ( VAR_1 != null ) VAR_2 . addAll ( VAR_1 ) ; <END> VAR_2 . add ( METHOD_2 ( ) ) ; return VAR_2 ; } | Set < TYPE_2 . TYPE_3 > METHOD_1 ( Set < TYPE_2 . TYPE_3 > VAR_1 ) { Set < TYPE_2 . TYPE_3 > VAR_2 = new HashSet < TYPE_2 . TYPE_3 > ( ) ; if ( VAR_1 != null ) { VAR_2 . addAll ( VAR_1 ) ; } VAR_2 . add ( METHOD_2 ( ) ) ; return VAR_2 ; } |
replace withboolean VAR_4 = file ! = null ; | public TYPE_1 METHOD_1 ( String path , boolean VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ( TYPE_3 ) VAR_3 ) ; TYPE_4 file = METHOD_3 ( ( TYPE_3 ) VAR_3 ) ; boolean VAR_4 ; <START> if ( file == null ) { <END> VAR_4 = false ; } else { VAR_4 = true ; } if ( ! VAR_1 && VAR_2 != null ) { return new TYPE_5 ( path , VAR_4 , VAR_2 .... | public TYPE_1 METHOD_1 ( String path , boolean VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ( TYPE_3 ) VAR_3 ) ; TYPE_4 file = METHOD_3 ( ( TYPE_3 ) VAR_3 ) ; boolean VAR_4 = file != null ; if ( ! VAR_1 && VAR_2 != null ) { return new TYPE_5 ( path , VAR_4 , VAR_2 . METHOD_4 ( ) , VAR_2 . METHOD_5 ( ) ) ; } else { return new TY... |
A conditionnal test added wizard container ( null ! = ) | public void METHOD_1 ( final TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; <START> VAR_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_2 . METHOD_4 ( ) . METHOD_5 ( TYPE_3 . VAR_3 ) ) ; <END> } | public void METHOD_1 ( final TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; if ( null != VAR_1 ) { VAR_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_2 . METHOD_4 ( ) . METHOD_5 ( TYPE_3 . VAR_3 ) ) ; } } |
break - condition continue - condition | private View METHOD_1 ( TYPE_1 VAR_1 ) { View VAR_2 = null ; Iterator < ? > iterator = VAR_3 . METHOD_2 ( ) . iterator ( ) ; while ( iterator . hasNext ( ) <START> && null == VAR_2 ) { <END> Object child = iterator . next ( ) ; if ( ( child instanceof TYPE_2 ) && ( ( TYPE_2 ) child ) . METHOD_3 ( ) . equals ( VAR_1 ) )... | private View METHOD_1 ( TYPE_1 VAR_1 ) { View VAR_2 = null ; Iterator < ? > iterator = VAR_3 . METHOD_2 ( ) . iterator ( ) ; while ( null == VAR_2 && iterator . hasNext ( ) ) { Object child = iterator . next ( ) ; if ( ( child instanceof TYPE_2 ) && ( ( TYPE_2 ) child ) . METHOD_3 ( ) . equals ( VAR_1 ) ) { VAR_2 = ( T... |
System removed | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( TYPE_4 . VAR_4 ) ; TYPE_2 [ ] VAR_5 = null ; try { VAR_5 = VAR_1 . call ( ) ; } catch ( TYPE_3 e ) { METHOD_3 ( e . getMessage ( ) ) ; } <START> System . out . println ( VAR_5 [ 0 ] . METHOD_4 ( ) ) ; <END> assertEquals ( VAR_5 [ 0 ] . METHOD... | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( TYPE_4 . VAR_4 ) ; TYPE_2 [ ] VAR_5 = null ; try { VAR_5 = VAR_1 . call ( ) ; } catch ( TYPE_3 e ) { METHOD_3 ( e . getMessage ( ) ) ; } assertEquals ( VAR_5 [ 0 ] . METHOD_4 ( ) , STRING_1 ) ; } |
return a boolean | public String METHOD_1 ( ) { <START> return VAR_1 ; <END> } | public boolean METHOD_1 ( ) { return VAR_1 ; } |
delete pass m | public Collection < TYPE_1 > METHOD_1 ( TYPE_2 m , boolean VAR_1 ) throws TYPE_3 { <START> TYPE_2 monitor ; if ( m == null ) monitor = new TYPE_4 ( ) ; else monitor = m ; <END> METHOD_1 ( monitor , VAR_2 , VAR_1 ) ; return results ; } | public List < TYPE_1 > METHOD_1 ( TYPE_2 m , boolean VAR_1 ) throws TYPE_3 { METHOD_1 ( m , VAR_2 , VAR_1 ) ; return results ; } |
argument constructor | public void run ( TYPE_1 monitor ) throws TYPE_2 { ArrayList < TYPE_3 > list = new ArrayList < > ( ) ; if ( VAR_1 != null ) { <START> TYPE_4 VAR_2 = TYPE_4 . METHOD_1 ( monitor , "" , 3 ) ; <END> METHOD_2 ( list , VAR_2 . METHOD_3 ( 1 ) ) ; METHOD_4 ( list , VAR_2 . METHOD_3 ( 1 ) ) ; METHOD_5 ( list , VAR_2 . METHOD_3... | public void run ( TYPE_1 monitor ) throws TYPE_2 { ArrayList < TYPE_3 > list = new ArrayList < > ( ) ; if ( VAR_1 != null ) { TYPE_4 VAR_2 = TYPE_4 . METHOD_1 ( monitor , 3 ) ; METHOD_2 ( list , VAR_2 . METHOD_3 ( 1 ) ) ; METHOD_4 ( list , VAR_2 . METHOD_3 ( 1 ) ) ; METHOD_5 ( list , VAR_2 . METHOD_3 ( 1 ) ) ; } VAR_3 ... |
parameter constructor | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws TYPE_3 , TYPE_4 { TYPE_5 VAR_2 = new TYPE_5 ( TYPE_6 . format ( TYPE_8 . TYPE_9 , new Object [ ] { VAR_5 . METHOD_2 ( ) , VAR_5 . METHOD_3 ( ) } ) ) ; <START> TYPE_7 VAR_6 = TYPE_7 . METHOD_4 ( VAR_1 , "" , 2 ) ; <END> METHOD_5 ( VAR_2 , VAR_6 . METHOD_6 ( 1 ) ) ; if ( VAR... | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws TYPE_3 , TYPE_4 { TYPE_5 VAR_2 = new TYPE_5 ( TYPE_6 . format ( TYPE_8 . TYPE_9 , new Object [ ] { VAR_5 . METHOD_2 ( ) , VAR_5 . METHOD_3 ( ) } ) ) ; TYPE_7 VAR_6 = TYPE_7 . METHOD_4 ( VAR_1 , 2 ) ; METHOD_5 ( VAR_2 , VAR_6 . METHOD_6 ( 1 ) ) ; if ( VAR_5 . METHOD_7 ( ) )... |
unnecessary | private boolean METHOD_1 ( TYPE_1 VAR_1 , Collection < ? > VAR_2 , TYPE_2 monitor ) { if ( VAR_2 != null && VAR_2 . contains ( VAR_1 . getValue ( ) ) ) { <START> monitor . VAR_3 ( ) ; <END> return false ; } return ! METHOD_2 ( VAR_1 , monitor ) ; } | private boolean METHOD_1 ( TYPE_1 VAR_1 , Collection < ? > VAR_2 , TYPE_2 monitor ) { if ( VAR_2 != null && VAR_2 . contains ( VAR_1 . getValue ( ) ) ) { return false ; } return ! METHOD_2 ( VAR_1 , monitor ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.