ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
assertNotNull VAR_4 | protected TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! VAR_2 ) { return VAR_1 ; } VAR_1 . METHOD_2 ( ) ; try { <START> return new TYPE_2 ( VAR_3 , METHOD_3 ( VAR_4 ) , VAR_5 ) ; <END> } catch ( IOException e ) { METHOD_4 ( e . getMessage ( ) ) ; return null ; } } | protected TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { if ( ! VAR_2 ) { return VAR_1 ; } VAR_1 . METHOD_2 ( ) ; return new TYPE_2 ( VAR_3 , METHOD_3 ( VAR_4 ) , VAR_5 ) ; } |
expected | public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( STRING_1 ) ; VAR_1 . METHOD_4 ( STRING_2 ) ; VAR_1 . METHOD_5 ( ) . METHOD_6 ( TYPE_1 . VAR_3 ) ; TYPE_2 VAR_4 = VAR_5 . METHOD_7 ( VAR_2 , VAR_6 , new TYPE_3 ( ) ) ; <START> assertEquals ( VAR_4 . METHOD_8 ( ) , Collections . VAR_7 ( VAR_1 ) )... | public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( STRING_1 ) ; VAR_1 . METHOD_4 ( STRING_2 ) ; VAR_1 . METHOD_5 ( ) . METHOD_6 ( TYPE_1 . VAR_3 ) ; TYPE_2 VAR_4 = VAR_5 . METHOD_7 ( VAR_2 , VAR_6 , new TYPE_3 ( ) ) ; assertEquals ( Collections . VAR_7 ( VAR_1 ) , VAR_4 . METHOD_8 ( ) ) ; } |
purpose METHOD_1 ( TYPE_1 ) ? weird need filter _CODE_ METHOD_5 METHOD_3 other numerous _CODE_ extensions filter interested instead | protected void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( TYPE_2 . METHOD_3 ( VAR_1 . METHOD_4 ( ) , new TYPE_3 < TYPE_4 > ( ) { ANNOTATION_1 ( STRING_1 ) public boolean apply ( TYPE_4 input ) { return TYPE_5 . size ( TYPE_5 . filter ( input . VAR_2 ( ) . iterator ( ) , <START> METHOD_5 ( METHOD_6 ( TYPE_6 . class ) ) ) ) ... | protected void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( TYPE_2 . METHOD_3 ( VAR_1 . METHOD_4 ( ) , new TYPE_3 < TYPE_4 > ( ) { public boolean apply ( TYPE_4 input ) { return input . VAR_2 ( ) . size ( ) > 1 ; } } ) ) ; } |
want return set case s behavior List | public < T > Set < T > METHOD_1 ( Set < T > set , T object ) { if ( set . contains ( object ) ) { return TYPE_1 . METHOD_2 ( set ) ; <START> } else { <END> Set < T > result = TYPE_1 . METHOD_2 ( set ) ; result . add ( object ) ; return result ; } } | public < T > Set < T > METHOD_1 ( Set < T > set , T object ) { if ( set . contains ( object ) ) { return set ; } else { Set < T > result = TYPE_1 . METHOD_2 ( set ) ; result . add ( object ) ; return result ; } } |
root _CODE_ instead | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { final TYPE_3 VAR_3 = VAR_2 . METHOD_2 ( TYPE_3 . class ) ; <START> METHOD_3 ( METHOD_4 ( VAR_3 ) ) ; <END> } | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { METHOD_3 ( METHOD_4 ( ) ) ; } |
check VAR_1 isEmpty ( ) continuing other checks eliminating need null checks | public void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { <START> if ( VAR_1 instanceof TYPE_2 ) { <END> Object element = ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( ) ; if ( element != null && element instanceof TYPE_3 ) { TYPE_3 VAR_3 = ( TYPE_3 ) element ; METHOD_1 ( VAR_3 , VAR_2 ) ; } } } | public void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { if ( ! VAR_1 . isEmpty ( ) && VAR_1 instanceof TYPE_2 ) { Object element = ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( ) ; if ( element instanceof TYPE_3 ) { TYPE_3 VAR_3 = ( TYPE_3 ) element ; METHOD_1 ( VAR_3 , VAR_2 ) ; } } } |
s create new API instead _CODE_ ( ) set a member variable store launch method private | <START> protected TYPE_1 METHOD_1 ( ) { <END> return ( TYPE_1 ) METHOD_2 ( ) . METHOD_3 ( TYPE_2 . class ) ; } | private TYPE_1 METHOD_1 ( ) { return ( TYPE_1 ) METHOD_2 ( ) . METHOD_3 ( TYPE_2 . class ) ; } |
VAR_1 METHOD_2 ( ) other extension points | public void METHOD_1 ( TYPE_1 context ) throws Exception { TYPE_2 . METHOD_2 ( ) ; VAR_1 . METHOD_2 ( ) ; VAR_1 = null ; VAR_2 . METHOD_2 ( ) ; VAR_2 = null ; VAR_3 . METHOD_2 ( ) ; VAR_3 = null ; TYPE_3 . getInstance ( ) . METHOD_2 ( ) ; TYPE_4 . getInstance ( ) . METHOD_2 ( ) ; <START> TYPE_5 . getInstance ( ) . METH... | public void METHOD_1 ( TYPE_1 context ) throws Exception { TYPE_2 . METHOD_2 ( ) ; VAR_1 . METHOD_2 ( ) ; VAR_1 = null ; VAR_2 . METHOD_2 ( ) ; VAR_2 = null ; VAR_3 . METHOD_2 ( ) ; VAR_3 = null ; TYPE_3 . getInstance ( ) . METHOD_2 ( ) ; TYPE_4 . getInstance ( ) . METHOD_2 ( ) ; TYPE_5 . getInstance ( ) . METHOD_2 ( )... |
I don t return null add external annotation | public ANNOTATION_1 Map < ANNOTATION_1 String , ANNOTATION_1 String > METHOD_1 ( ) { Map < ANNOTATION_1 String , ANNOTATION_1 String > properties = new HashMap < > ( ) ; properties . put ( TYPE_1 . METHOD_2 ( Messages . TYPE_3 ) , TYPE_1 . METHOD_2 ( VAR_2 . getName ( ) ) ) ; properties . put ( TYPE_1 . METHOD_2 ( Mess... | public ANNOTATION_1 Map < ANNOTATION_1 String , ANNOTATION_1 String > METHOD_1 ( ) { Map < ANNOTATION_1 String , ANNOTATION_1 String > properties = new HashMap < > ( ) ; properties . put ( TYPE_1 . METHOD_2 ( Messages . TYPE_3 ) , VAR_2 . getName ( ) ) ; properties . put ( TYPE_1 . METHOD_2 ( Messages . TYPE_2 ) , VAR_... |
t remove call | protected TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_1 VAR_2 = new TYPE_1 ( VAR_1 , SWT . NONE ) ; TYPE_2 . METHOD_2 ( ) . METHOD_3 ( true , true ) . METHOD_4 ( SWT . VAR_3 , SWT . VAR_3 ) . METHOD_5 ( 1 , METHOD_6 ( ) ) <START> . METHOD_7 ( VAR_2 ) ; <END> TYPE_3 . METHOD_2 ( ) . METHOD_8 ( 1 ) . METHOD_7 ( VAR_2 )... | protected TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_1 VAR_2 = new TYPE_1 ( VAR_1 , SWT . NONE ) ; TYPE_3 . METHOD_2 ( ) . METHOD_8 ( 1 ) . METHOD_7 ( VAR_2 ) ; return VAR_2 ; } |
call METHOD_6 ( ) instead | private void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( ) . METHOD_3 ( new TYPE_2 ( ) { @Override public void run ( ) { <START> METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) ; <END> } } ) ; } | private void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( ) . METHOD_3 ( new TYPE_2 ( ) { @Override public void run ( ) { METHOD_6 ( ) ; } } ) ; } |
call method 4 5 : = = > return METHOD_1 ( file true ) ; | public static TYPE_1 METHOD_1 ( TYPE_2 file ) throws TYPE_3 { <START> try { return METHOD_1 ( file , true , false ) ; } catch ( TYPE_4 ex ) { throw new TYPE_3 ( ex . getMessage ( ) , ex ) ; } <END> } | public static TYPE_1 METHOD_1 ( TYPE_2 file ) throws TYPE_3 { return METHOD_1 ( file , true ) ; } |
remove unnecessary checks | public boolean METHOD_1 ( final String VAR_1 ) { <START> if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) <END> return false ; return METHOD_2 ( VAR_1 ) != null ; } | public boolean METHOD_1 ( final String VAR_1 ) { return METHOD_2 ( VAR_1 ) != null ; } |
TYPE_1 _CODE_ ( s ) ( String ) instead text equality test catch _CODE_ iterate recursively children items | public static TYPE_1 METHOD_1 ( final TYPE_1 [ ] VAR_1 , final String name ) { TYPE_1 VAR_2 = null ; if ( VAR_1 != null && VAR_1 . length > 0 ) { <START> for ( TYPE_1 VAR_3 : VAR_1 ) { <END> if ( VAR_3 . METHOD_2 ( ) . equals ( name ) ) { VAR_2 = VAR_3 ; break ; } VAR_2 = METHOD_1 ( VAR_3 . METHOD_3 ( ) , name ) ; if (... | public static TYPE_1 METHOD_1 ( final TYPE_1 [ ] VAR_1 , final String name ) { TYPE_1 VAR_2 = null ; if ( VAR_1 != null ) { for ( TYPE_1 VAR_3 : VAR_1 ) { if ( VAR_3 . METHOD_2 ( ) . equals ( name ) ) { VAR_2 = VAR_3 ; break ; } VAR_2 = METHOD_1 ( VAR_3 . METHOD_3 ( ) , name ) ; if ( VAR_2 != null ) { break ; } } } ret... |
method added java 8 fail java 7 note compile gerrit compile java 8 | public Map < String , String > METHOD_1 ( ) { Map < String , String > properties = new HashMap < > ( ) ; properties . VAR_1 ( VAR_2 . METHOD_2 ( ) ) ; properties . put ( VAR_3 , <START> Long . VAR_4 ( VAR_2 . METHOD_3 ( ) ) ) ; <END> properties . put ( Messages . TYPE_1 , METHOD_4 ( ) ) ; return properties ; } | public Map < String , String > METHOD_1 ( ) { Map < String , String > properties = new HashMap < > ( ) ; properties . VAR_1 ( VAR_2 . METHOD_2 ( ) ) ; properties . put ( VAR_3 , Long . toString ( VAR_2 . METHOD_3 ( ) ) ) ; properties . put ( Messages . TYPE_1 , METHOD_4 ( ) ) ; return properties ; } |
VAR_1 t null | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; <START> if ( VAR_1 != null ) <END> { VAR_1 . close ( false ) ; VAR_1 = null ; } } | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; VAR_1 . close ( false ) ; VAR_1 = null ; } |
Long valueOf ( ) instead new Long ( ) - performance reasons | public Long METHOD_1 ( ) { <START> return new Long ( METHOD_2 ( ) ) ; <END> } | public Long METHOD_1 ( ) { return Long . valueOf ( METHOD_2 ( ) ) ; } |
remove | public TYPE_1 METHOD_1 ( ) { <START> return new TYPE_2 ( this . METHOD_2 ( ) , this . VAR_1 ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( METHOD_2 ( ) , VAR_1 ) ; } |
need ANNOTATION_1 | <START> public ANNOTATION_1 String METHOD_1 ( ) { <END> return STRING_1 ; } | public String METHOD_1 ( ) { return STRING_1 ; } |
VAR_1 int Math VAR_4 unnecessary need overflow I d Math max ( 0 VAR_1 ) ; | public int METHOD_1 ( ) { int VAR_1 = 0 ; for ( TYPE_1 field : VAR_2 ) { VAR_1 += field . VAR_3 ( ) ; } <START> return Math . VAR_4 ( VAR_1 , Integer . VAR_5 ) ; <END> } | public int METHOD_1 ( ) { long VAR_1 = 0 ; for ( TYPE_1 field : VAR_2 ) { VAR_1 += field . VAR_3 ( ) ; } return ( int ) Math . VAR_4 ( VAR_1 , Integer . VAR_5 ) ; } |
A problem relies zoom thread implementation zoom list thread ( override _CODE_ ( ) return null ) s clear flag completed zoom empty entry list entries filtered work build thread done a iteration called refresh ( ) hasn t discovered entries | public final void run ( ) { METHOD_1 ( ) ; <START> VAR_1 = true ; <END> VAR_2 . METHOD_2 ( ) ; } | public final void run ( ) { METHOD_1 ( ) ; VAR_2 . METHOD_2 ( ) ; } |
format names inconsistent remove duration | public String toString ( ) { StringBuilder builder = new StringBuilder ( ) ; builder . append ( STRING_1 ) . append ( METHOD_1 ( ) ) . append ( STRING_2 ) . append ( METHOD_2 ( ) ) . append ( STRING_3 ) . append ( METHOD_3 ( ) ) <START> . append ( STRING_4 ) . append ( METHOD_4 ( ) ) <END> . append ( CHAR_1 ) ; return ... | public String toString ( ) { return new StringBuilder ( ) . append ( STRING_1 ) . append ( METHOD_1 ( ) ) . append ( STRING_2 ) . append ( METHOD_2 ( ) ) . append ( STRING_3 ) . append ( METHOD_3 ( ) ) . append ( STRING_4 ) . append ( METHOD_4 ( ) ) . append ( CHAR_1 ) . toString ( ) ; } |
_CODE_ ( ) called ( user changes list returned METHOD_2 ( ) ) VAR_1 changed inconsistent | public String METHOD_1 ( ) { String VAR_1 = VAR_2 ; if ( VAR_1 == null ) { TYPE_1 VAR_3 = new TYPE_1 ( STRING_1 ) ; METHOD_2 ( ) . forEach ( ( Long value ) - > VAR_3 . add ( TYPE_2 . METHOD_3 ( TYPE_3 . METHOD_4 ( ) ) . format ( value ) ) ) ; VAR_1 = VAR_3 . toString ( ) ; <START> VAR_2 = VAR_1 ; <END> } return VAR_1 ;... | public String METHOD_1 ( ) { String VAR_1 = VAR_2 ; if ( VAR_1 == null ) { TYPE_1 VAR_3 = new TYPE_1 ( STRING_1 ) ; METHOD_2 ( ) . forEach ( ( Long value ) - > VAR_3 . add ( value == null ? String . valueOf ( value ) : TYPE_2 . METHOD_3 ( TYPE_3 . METHOD_4 ( ) ) . format ( value ) ) ) ; VAR_1 = VAR_3 . toString ( ) ; V... |
switch equals check ( a equals ( b ) - - > b equals ( a ) ) null - safe potentially faster | public String METHOD_1 ( int column ) { String value = METHOD_2 ( ) . get ( column ) ; if <START> ( value . equals ( TYPE_2 . TYPE_3 ) ) { <END> return null ; } return value ; } | public String METHOD_1 ( int column ) { String value = METHOD_2 ( ) . get ( column ) ; if ( TYPE_2 . TYPE_3 . equals ( value ) ) { return null ; } return value ; } |
editing setter making collection dirty | void METHOD_1 ( List < String > VAR_1 ) { <START> for ( TYPE_1 < String > iterator = VAR_1 . METHOD_2 ( ) ; iterator . hasNext ( ) ; ) { String string = iterator . next ( ) ; iterator . set ( StringUtils . VAR_2 ( string , TYPE_2 . VAR_4 ) ) ; } <END> VAR_5 = VAR_1 ; } | void METHOD_1 ( List < String > VAR_1 ) { VAR_5 = VAR_1 ; } |
d want return a read - view VAR_1 | public Map < TYPE_1 , TYPE_2 > METHOD_1 ( ) { <START> return VAR_1 ; <END> } | public final Map < TYPE_1 , TYPE_2 > METHOD_1 ( ) { return VAR_1 ; } |
VAR_3 METHOD_2 returns null remove VAR_2 = new TYPE_2 ( ) | private void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = null ; if ( VAR_1 != null ) { VAR_2 = new TYPE_2 ( ) ; <START> VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; <END> } String VAR_4 = STRING_1 ; if ( VAR_2 != null ) { String VAR_5 = METHOD_3 ( VAR_2 ) ; VAR_4 += STRING_2 + VAR_5 + STRING_3 ; } VAR_4 += STRING_4 ; long conte... | private void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = null ; if ( VAR_1 != null ) { VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; } String VAR_4 = STRING_1 ; if ( VAR_2 != null ) { String VAR_5 = METHOD_3 ( VAR_2 ) ; VAR_4 += STRING_2 + VAR_5 + STRING_3 ; } VAR_4 += STRING_4 ; long context = OS . VAR_6 ( VAR_7 ) ; METHOD_4 ( ... |
VAR_3 METHOD_2 returns null remove VAR_2 = new TYPE_1 ( ) | TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = null ; if ( VAR_1 != null ) { <START> VAR_2 = new TYPE_1 ( ) ; <END> VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; } return VAR_2 ; } | TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = null ; if ( VAR_1 != null ) { VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; } return VAR_2 ; } |
don t return a continue other VAR_2 add state systems children | private static TYPE_1 METHOD_1 ( TYPE_2 trace ) { TYPE_1 VAR_1 = new TYPE_1 ( trace . getName ( ) ) ; TYPE_3 < TYPE_4 > VAR_2 = TYPE_5 . METHOD_2 ( trace , TYPE_4 . class ) ; for ( TYPE_4 VAR_3 : VAR_2 ) { VAR_3 . METHOD_3 ( ) ; if ( ! VAR_3 . METHOD_4 ( ) ) { <START> return VAR_1 ; <END> } for ( TYPE_6 VAR_4 : VAR_3 .... | private static TYPE_1 METHOD_1 ( TYPE_2 trace ) { TYPE_1 VAR_1 = new TYPE_1 ( trace . getName ( ) ) ; TYPE_3 < TYPE_4 > VAR_2 = TYPE_5 . METHOD_2 ( trace , TYPE_4 . class ) ; for ( TYPE_4 VAR_3 : VAR_2 ) { VAR_3 . METHOD_3 ( ) ; if ( ! VAR_3 . METHOD_4 ( ) ) { continue ; } for ( TYPE_6 VAR_4 : VAR_3 . METHOD_5 ( ) ) { ... |
false returned | public boolean METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( ) ; <START> } catch ( InterruptedException e ) { } <END> return VAR_2 ; } | public boolean METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( ) ; } catch ( InterruptedException e ) { return false ; } return VAR_2 ; } |
assertTrue instead | public void METHOD_1 ( ) { METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( ) ; <START> assertEquals ( STRING_1 , true , VAR_1 . METHOD_5 ( ) ) ; <END> assertNotNull ( VAR_1 . METHOD_3 ( ) ) ; } | public void METHOD_1 ( ) { METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( ) ; assertTrue ( STRING_1 , VAR_1 . METHOD_5 ( ) ) ; assertNotNull ( VAR_1 . METHOD_3 ( ) ) ; } |
written : return super METHOD_1 ( node ) ; consistency | public boolean METHOD_1 ( TYPE_1 node ) { VAR_1 . METHOD_2 ( node ) ; <START> return METHOD_1 ( ( TYPE_2 ) node ) ; <END> } | public boolean METHOD_1 ( TYPE_1 node ) { VAR_1 . METHOD_2 ( node ) ; return super . METHOD_1 ( node ) ; } |
wouldn t implementation apply cases ? a generic utility method defined a default a static method interface | <START> public ANNOTATION_1 String METHOD_1 ( long VAR_1 ) { <END> if ( ( VAR_1 & ( INT_1 < < INT_2 ) ) != 0 ) { return String . format ( STRING_1 , VAR_1 ) ; } return String . format ( STRING_2 , VAR_1 ) ; } | public ANNOTATION_1 String METHOD_1 ( long VAR_1 ) { if ( ( VAR_1 & ( INT_1 < < INT_2 ) ) == 0 ) { return String . format ( STRING_1 , VAR_1 ) ; } return String . format ( STRING_2 , VAR_1 ) ; } |
toString ( ) ? output a String I ve pushed a new patch removes reformats some stuff | protected void METHOD_1 ( String output ) { <START> if ( output . toString ( ) . contains ( STRING_1 ) ) { <END> VAR_1 = TYPE_1 . VAR_3 ; } else if ( output . toString ( ) . contains ( STRING_2 ) ) { VAR_1 = TYPE_1 . VAR_4 ; } else if ( output . toString ( ) . contains ( STRING_3 ) ) { VAR_1 = TYPE_1 . VAR_5 ; } else {... | protected void METHOD_1 ( String output ) { if ( output . contains ( STRING_1 ) ) { VAR_1 = TYPE_1 . VAR_3 ; } else if ( output . contains ( STRING_2 ) ) { VAR_1 = TYPE_1 . VAR_4 ; } else if ( output . contains ( STRING_3 ) ) { VAR_1 = TYPE_1 . VAR_5 ; } else { VAR_1 = TYPE_1 . VAR_6 ; } } |
method external annotation | public TYPE_1 < TYPE_2 > METHOD_1 ( ) { TYPE_3 . Builder < TYPE_2 > builder = TYPE_3 . builder ( ) ; builder . addAll ( super . METHOD_1 ( ) ) ; builder . add ( TYPE_5 . VAR_2 ) ; builder . add ( TYPE_6 . VAR_2 ) ; return <START> TYPE_4 . METHOD_2 ( builder . build ( ) ) ; <END> } | public TYPE_1 < TYPE_2 > METHOD_1 ( ) { TYPE_3 . Builder < TYPE_2 > builder = TYPE_3 . builder ( ) ; builder . addAll ( super . METHOD_1 ( ) ) ; builder . add ( TYPE_5 . VAR_2 ) ; builder . add ( TYPE_6 . VAR_2 ) ; return builder . build ( ) ; } |
final | public Object execute ( final TYPE_1 event ) throws TYPE_2 { final TYPE_3 VAR_1 = TYPE_4 . METHOD_1 ( event ) ; final TYPE_5 VAR_2 = METHOD_2 ( VAR_1 ) ; final TYPE_6 configuration = METHOD_3 ( VAR_2 ) ; <START> TYPE_7 VAR_3 = new TYPE_7 ( configuration , VAR_2 ) ; <END> TYPE_8 VAR_4 = new TYPE_8 ( TYPE_9 . METHOD_4 ( ... | public Object execute ( final TYPE_1 event ) throws TYPE_2 { final TYPE_3 VAR_1 = TYPE_4 . METHOD_1 ( event ) ; final TYPE_5 VAR_2 = METHOD_2 ( VAR_1 ) ; final TYPE_6 configuration = METHOD_3 ( VAR_2 ) ; final TYPE_7 VAR_3 = new TYPE_7 ( configuration , VAR_2 ) ; final TYPE_8 VAR_4 = new TYPE_8 ( TYPE_9 . METHOD_4 ( ) ... |
final | protected TYPE_1 METHOD_1 ( final TYPE_2 configuration ) { TYPE_1 VAR_1 = null ; if ( 0 < configuration . VAR_2 ( ) . size ( ) ) { final Iterator < TYPE_3 > VAR_3 = configuration . VAR_2 ( ) . iterator ( ) ; while ( VAR_3 . hasNext ( ) && null == VAR_1 ) { <START> TYPE_3 VAR_4 = VAR_3 . next ( ) ; <END> if ( VAR_4 inst... | protected TYPE_1 METHOD_1 ( final TYPE_2 configuration ) { TYPE_1 VAR_1 = null ; if ( 0 < configuration . VAR_2 ( ) . size ( ) ) { final Iterator < TYPE_3 > VAR_3 = configuration . VAR_2 ( ) . iterator ( ) ; while ( VAR_3 . hasNext ( ) && null == VAR_1 ) { final TYPE_3 VAR_4 = VAR_3 . next ( ) ; if ( VAR_4 instanceof T... |
final | protected TYPE_1 METHOD_1 ( final TYPE_2 configuration ) { TYPE_1 VAR_1 = null ; if ( 0 < configuration . VAR_2 ( ) . size ( ) ) { final Iterator < TYPE_3 > VAR_3 = configuration . VAR_4 ( ) . iterator ( ) ; while ( VAR_3 . hasNext ( ) && null == VAR_1 ) { <START> TYPE_3 VAR_5 = VAR_3 . next ( ) ; <END> if ( VAR_5 inst... | protected TYPE_1 METHOD_1 ( final TYPE_2 configuration ) { TYPE_1 VAR_1 = null ; if ( 0 < configuration . VAR_2 ( ) . size ( ) ) { final Iterator < TYPE_3 > VAR_3 = configuration . VAR_4 ( ) . iterator ( ) ; while ( VAR_3 . hasNext ( ) && null == VAR_1 ) { final TYPE_3 VAR_5 = VAR_3 . next ( ) ; if ( VAR_5 instanceof T... |
final | public static final boolean METHOD_1 ( final TYPE_1 VAR_1 ) { <START> TYPE_2 VAR_2 = ( TYPE_2 ) VAR_1 . METHOD_2 ( TYPE_6 . VAR_4 . METHOD_3 ( ) ) ; <END> Assert . VAR_5 ( VAR_2 ) ; final TYPE_3 VAR_6 = VAR_2 . METHOD_4 ( ) ; return TYPE_3 . TYPE_5 . equals ( VAR_6 ) ; } | public static final boolean METHOD_1 ( final TYPE_1 VAR_1 ) { final TYPE_2 VAR_2 = ( TYPE_2 ) VAR_1 . METHOD_2 ( TYPE_6 . VAR_4 . METHOD_3 ( ) ) ; Assert . VAR_5 ( VAR_2 ) ; final TYPE_3 VAR_6 = VAR_2 . METHOD_4 ( ) ; return TYPE_3 . TYPE_5 . equals ( VAR_6 ) ; } |
set class variable | private boolean METHOD_1 ( String type ) { <START> return Arrays . asList ( TYPE_1 ) . contains ( type ) ; <END> } | private boolean METHOD_1 ( String type ) { return TYPE_1 . contains ( type ) ; } |
artifact intentional ? s interface | public <START> ANNOTATION_1 TYPE_1 <END> METHOD_1 ( ) { String VAR_1 = METHOD_2 ( ) ; if ( VAR_1 != null ) { TYPE_2 VAR_2 = METHOD_3 ( ) ; if ( VAR_2 != null ) { TYPE_1 VAR_3 = TYPE_3 . METHOD_4 ( VAR_2 , VAR_1 ) ; if ( VAR_3 != null ) { return VAR_3 ; } } } return TYPE_3 . VAR_4 ; } | public TYPE_1 METHOD_1 ( ) { String VAR_1 = METHOD_2 ( ) ; if ( VAR_1 != null ) { TYPE_2 VAR_2 = METHOD_3 ( ) ; if ( VAR_2 != null ) { TYPE_1 VAR_3 = TYPE_3 . METHOD_4 ( VAR_2 , VAR_1 ) ; if ( VAR_3 != null ) { return VAR_3 ; } } } return TYPE_3 . VAR_4 ; } |
synchronized | <START> public <END> TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( ) ; } return VAR_1 ; } | public synchronized TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( ) ; } return VAR_1 ; } |
changes unnecessary builder a separate method setting span substitutions | public void METHOD_1 ( ) { writer = new TYPE_1 ( ) ; VAR_1 = new TYPE_2 ( writer ) ; VAR_1 . METHOD_2 ( false ) ; builder = new TYPE_3 ( VAR_1 ) ; builder . VAR_2 ( TYPE_4 . METHOD_3 ( TYPE_8 . VAR_4 ) ) ; builder . VAR_5 ( TYPE_4 . METHOD_3 ( TYPE_5 . VAR_6 ) , TYPE_9 < TYPE_6 > METHOD_4 ( ) , <START> TYPE_7 < TYPE_5 ... | public void METHOD_1 ( ) { writer = new TYPE_1 ( ) ; VAR_1 = new TYPE_2 ( writer ) ; VAR_1 . METHOD_2 ( false ) ; builder = new TYPE_3 ( VAR_1 ) ; builder . VAR_2 ( TYPE_4 . METHOD_3 ( TYPE_8 . VAR_4 ) ) ; builder . VAR_5 ( TYPE_4 . METHOD_3 ( TYPE_5 . VAR_6 ) , TYPE_9 < TYPE_6 > METHOD_4 ( ) ) ; builder . VAR_9 ( 3 ) ... |
touching add missing braces ? VAR_1 isEmpty ( ) | private Set < String > METHOD_1 ( String VAR_1 ) { <START> if ( VAR_1 == null || VAR_1 . length ( ) == 0 ) <END> return Collections . VAR_2 ( ) ; Set < String > VAR_3 = new HashSet < String > ( ) ; TYPE_1 VAR_4 = new TYPE_1 ( VAR_1 , File . VAR_5 ) ; while ( VAR_4 . METHOD_2 ( ) ) { VAR_3 . add ( VAR_6 . METHOD_3 ( VAR... | private Set < String > METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { return Collections . VAR_2 ( ) ; } Set < String > VAR_3 = new HashSet < String > ( ) ; TYPE_1 VAR_4 = new TYPE_1 ( VAR_1 , File . VAR_5 ) ; while ( VAR_4 . METHOD_2 ( ) ) { VAR_3 . add ( VAR_6 . METHOD_3 ( VAR_4 . METHOD_4 ... |
style : missing braces | protected void METHOD_1 ( ) throws IOException { if ( METHOD_2 ( ) == null ) { <START> if ( METHOD_3 ( ) != null ) <END> METHOD_4 ( METHOD_5 ( ) . METHOD_6 ( METHOD_3 ( ) , VAR_1 ) ) ; else if ( METHOD_7 ( ) != null ) METHOD_4 ( METHOD_5 ( ) . METHOD_6 ( METHOD_7 ( ) , VAR_1 ) ) ; } } | protected void METHOD_1 ( ) throws IOException { if ( METHOD_2 ( ) == null ) { if ( METHOD_3 ( ) != null ) { METHOD_4 ( METHOD_5 ( ) . METHOD_6 ( METHOD_3 ( ) , VAR_1 ) ) ; } else if ( METHOD_7 ( ) != null ) { METHOD_4 ( METHOD_5 ( ) . METHOD_6 ( METHOD_7 ( ) , VAR_1 ) ) ; } } } |
added external annotations instead | public static TYPE_1 < String , String > METHOD_1 ( TYPE_2 < TYPE_3 > VAR_1 ) { <START> TYPE_1 < String , String > VAR_2 = TYPE_4 . METHOD_2 ( TYPE_5 . create ( ) ) ; <END> for ( TYPE_3 VAR_3 : VAR_1 ) { for ( TYPE_6 VAR_4 : VAR_3 . METHOD_3 ( ) ) { VAR_2 . METHOD_4 ( VAR_4 . getType ( ) , VAR_4 . METHOD_5 ( ) ) ; } } ... | public static TYPE_1 < String , String > METHOD_1 ( TYPE_2 < TYPE_3 > VAR_1 ) { TYPE_1 < String , String > VAR_2 = TYPE_5 . create ( ) ; for ( TYPE_3 VAR_3 : VAR_1 ) { for ( TYPE_6 VAR_4 : VAR_3 . METHOD_3 ( ) ) { VAR_2 . METHOD_4 ( VAR_4 . getType ( ) , VAR_4 . METHOD_5 ( ) ) ; } } return VAR_2 ; } |
a guarantee statement a executed preempted statement [ 1 ] null - check VAR_2 s good practice extract a local variable general s a small method fine imo [ 1 ] I remember I a class a looong time I t find references online compiler agree s a bug I m crazy ? : O | public void METHOD_1 ( ) { File VAR_1 = VAR_2 ; if ( VAR_1 != null ) { <START> VAR_1 . METHOD_2 ( ) ; <END> } } | public void METHOD_1 ( ) { if ( VAR_2 != null ) { VAR_2 . METHOD_2 ( ) ; } } |
add a package - info java file package | <START> public ANNOTATION_1 String METHOD_1 ( ) { <END> return VAR_1 . METHOD_2 ( ) ; } | public String METHOD_1 ( ) { return VAR_1 . METHOD_2 ( ) ; } |
I don t VAR_2 returned ( previous entry ) critical path module needs remove line updating file | public Object METHOD_1 ( String name ) { if ( name . equals ( TYPE_1 . VAR_1 ) ) { final TYPE_2 VAR_2 = VAR_3 ; if ( VAR_2 == null ) { return null ; } TYPE_3 VAR_4 = METHOD_2 ( ) ; if ( ( VAR_4 != null ) && ( VAR_4 instanceof TYPE_1 ) ) { TYPE_4 VAR_5 = new TYPE_4 ( VAR_2 , "" , 0 ) ; return VAR_5 ; } <START> return VA... | public Object METHOD_1 ( String name ) { if ( name . equals ( TYPE_1 . VAR_1 ) ) { final TYPE_2 VAR_2 = VAR_3 ; if ( VAR_2 == null ) { return null ; } TYPE_3 VAR_4 = METHOD_2 ( ) ; if ( ( VAR_4 != null ) && ( VAR_4 instanceof TYPE_1 ) ) { TYPE_4 VAR_5 = new TYPE_4 ( VAR_2 , "" , 0 ) ; return VAR_5 ; } } return null ; } |
please interfaces | private <START> ArrayList < TYPE_1 > <END> METHOD_1 ( Set < TYPE_2 > VAR_1 ) { ArrayList < TYPE_1 > VAR_2 = new ArrayList < TYPE_1 > ( ) ; for ( TYPE_2 VAR_3 : VAR_1 ) { VAR_2 . add ( new TYPE_1 ( VAR_3 , TYPE_3 . TYPE_4 , TYPE_5 . VAR_7 ) ) ; } return VAR_2 ; } | private List < TYPE_1 > METHOD_1 ( Set < TYPE_2 > VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < TYPE_1 > ( ) ; for ( TYPE_2 VAR_3 : VAR_1 ) { VAR_2 . add ( new TYPE_1 ( VAR_3 , TYPE_3 . TYPE_4 , TYPE_5 . VAR_7 ) ) ; } return VAR_2 ; } |
please interfaces | private <START> ArrayList < TYPE_1 > <END> METHOD_1 ( Set < TYPE_2 > VAR_1 ) { ArrayList < TYPE_1 > VAR_2 = new ArrayList < TYPE_1 > ( ) ; for ( TYPE_2 VAR_3 : VAR_1 ) { VAR_2 . add ( new TYPE_1 ( VAR_3 , TYPE_4 . TYPE_3 , TYPE_5 . VAR_7 ) ) ; } return VAR_2 ; } | private List < TYPE_1 > METHOD_1 ( Set < TYPE_2 > VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < TYPE_1 > ( ) ; for ( TYPE_2 VAR_3 : VAR_1 ) { VAR_2 . add ( new TYPE_1 ( VAR_3 , TYPE_4 . TYPE_3 , TYPE_5 . VAR_7 ) ) ; } return VAR_2 ; } |
{ } block please | public String METHOD_1 ( int row , int VAR_1 ) { METHOD_2 ( row , VAR_1 ) ; Object obj = VAR_2 . METHOD_3 ( VAR_1 , row ) ; if ( obj != null ) { return obj . toString ( ) ; } <START> else <END> return "" ; } | public String METHOD_1 ( int row , int VAR_1 ) { METHOD_2 ( row , VAR_1 ) ; Object obj = VAR_2 . METHOD_3 ( VAR_1 , row ) ; if ( obj != null ) { return obj . toString ( ) ; } else { return "" ; } } |
a real application order events _CODE_ _CODE_ _CODE_ send _CODE_ TYPE_5 _CODE_ requires _CODE_ event call METHOD_3 instead send mouse events TYPE_5 | public TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) throws TYPE_3 { METHOD_2 ( ) ; <START> METHOD_3 ( ) ; <END> TYPE_4 location = METHOD_4 ( ) ; return TYPE_5 . METHOD_1 ( VAR_2 , location . x + ( location . VAR_3 / 2 ) , location . y + ( location . VAR_4 / 2 ) ) ; } | public TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) throws TYPE_3 { METHOD_2 ( ) ; TYPE_4 location = METHOD_4 ( ) ; return TYPE_5 . METHOD_1 ( VAR_2 , location . VAR_3 / 2 , location . VAR_4 / 2 ) ; } |
s assuming METHOD_5 cell s bound relative _CODE_ control | public TYPE_1 METHOD_1 ( int row , int VAR_1 , String text ) throws TYPE_2 { METHOD_2 ( row , VAR_1 ) ; Assert . VAR_2 ( text ) ; METHOD_3 ( ) ; METHOD_4 ( row , VAR_1 ) ; TYPE_3 location = VAR_3 . METHOD_5 ( VAR_1 , row ) ; <START> return TYPE_4 . METHOD_1 ( VAR_3 , location . x + ( location . VAR_4 / 2 ) , location .... | public TYPE_1 METHOD_1 ( int row , int VAR_1 , String text ) throws TYPE_2 { METHOD_2 ( row , VAR_1 ) ; Assert . VAR_2 ( text ) ; METHOD_3 ( ) ; TYPE_3 location = VAR_3 . METHOD_5 ( VAR_1 , row ) ; return TYPE_4 . METHOD_1 ( VAR_3 , location . x + ( location . VAR_4 / 2 ) , location . y + ( location . VAR_5 / 2 ) , tex... |
I want leave protected user call public METHOD_1 ( ) turn call | <START> public TYPE_1 <END> METHOD_1 ( final TYPE_2 VAR_1 ) throws TYPE_3 { METHOD_2 ( ) ; TYPE_4 location = METHOD_3 ( ) ; return TYPE_5 . METHOD_1 ( VAR_2 , location . VAR_3 / 2 , location . VAR_4 / 2 ) ; } | protected TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) throws TYPE_3 { METHOD_2 ( ) ; TYPE_4 location = METHOD_3 ( ) ; return TYPE_5 . METHOD_1 ( VAR_2 , location . VAR_3 / 2 , location . VAR_4 / 2 ) ; } |
avoid assignation ( trace ! = null ) ? trace VAR_5 : _CODE_ | public ANNOTATION_1 TYPE_1 < ANNOTATION_1 TYPE_2 > METHOD_1 ( ) { Set < ANNOTATION_1 TYPE_2 > VAR_1 = VAR_2 ; if ( VAR_1 == null ) { TYPE_3 trace = METHOD_2 ( ) ; <START> TYPE_4 VAR_3 = TYPE_4 . VAR_4 ; <END> if ( trace != null ) { VAR_3 = trace . VAR_5 ( ) ; } VAR_1 = TYPE_5 . of ( new TYPE_6 ( VAR_3 ) ) ; VAR_2 = VAR... | public ANNOTATION_1 TYPE_1 < ANNOTATION_1 TYPE_2 > METHOD_1 ( ) { Set < ANNOTATION_1 TYPE_2 > VAR_1 = VAR_2 ; if ( VAR_1 == null ) { TYPE_3 trace = METHOD_2 ( ) ; TYPE_4 VAR_3 = ( trace != null ) ? trace . VAR_5 ( ) : TYPE_4 . VAR_4 ; VAR_1 = TYPE_5 . of ( new TYPE_6 ( VAR_3 ) ) ; VAR_2 = VAR_1 ; } return VAR_1 ; } |
I thinking 0 - argument version shouldn t create TYPE_2 d 0 - arg obtain TYPE_1 static methods _CODE_ I d suggest calling default constructor TYPE_4 | <START> static TYPE_1 METHOD_1 ( ) { <END> TYPE_2 TYPE_3 = TYPE_2 . create ( ) ; return new TYPE_4 ( TYPE_3 : : add ) ; } | static TYPE_1 METHOD_1 ( ) { return new TYPE_4 ( ) ; } |
unrelated patch a good change adds diff noise | public boolean METHOD_1 ( long VAR_1 ) { <START> return ( start <= VAR_1 && VAR_2 >= VAR_1 ) ; <END> } | public boolean METHOD_1 ( long VAR_1 ) { if ( start <= VAR_1 ) { if ( VAR_2 >= VAR_1 ) { return true ; } } return false ; } |
block avoid conversions ( String - > int int - > String ) String returned VAR_2 METHOD_4 ( ) ? code ready handle new thread ids change | private String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { TYPE_3 VAR_3 = METHOD_2 ( VAR_1 ) ; String VAR_4 = METHOD_3 ( VAR_3 ) ; if ( VAR_2 != null ) { <START> int VAR_5 ; <END> try { VAR_5 = Integer . parseInt ( VAR_2 . METHOD_4 ( ) ) ; VAR_4 += ! VAR_4 . isEmpty ( ) ? STRING_1 : "" ; VAR_4 += STRING_2 + Integer . to... | private String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { TYPE_3 VAR_3 = METHOD_2 ( VAR_1 ) ; String VAR_4 = METHOD_3 ( VAR_3 ) ; if ( VAR_2 != null ) { String VAR_5 = VAR_2 . METHOD_4 ( ) ; VAR_4 += ! VAR_4 . isEmpty ( ) ? STRING_1 : "" ; VAR_4 += STRING_2 + VAR_5 + STRING_3 ; } return VAR_4 ; } |
private | <START> public synchronized static void METHOD_1 ( String key , TYPE_1 VAR_1 ) { <END> METHOD_2 ( ) . put ( key , VAR_1 ) ; } | private synchronized static void METHOD_1 ( String key , TYPE_1 VAR_1 ) { METHOD_2 ( ) . put ( key , VAR_1 ) ; } |
I throws Exception unnecessary | <START> public void METHOD_1 ( ) throws Exception { <END> TYPE_1 VAR_1 = VAR_2 . get ( TYPE_1 . class ) ; VAR_1 . METHOD_2 ( listener ) ; if ( VAR_3 != null ) { VAR_3 . close ( ) ; } VAR_2 . METHOD_3 ( ) ; } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . get ( TYPE_1 . class ) ; VAR_1 . METHOD_2 ( listener ) ; if ( VAR_3 != null ) { VAR_3 . close ( ) ; } VAR_2 . METHOD_3 ( ) ; } |
synchronize | public boolean isEmpty ( ) { <START> return this . VAR_1 . isEmpty ( ) ; <END> } | public boolean isEmpty ( ) { synchronized ( this . VAR_1 ) { return this . VAR_1 . isEmpty ( ) ; } } |
_CODE_ case InterruptedException change ? test difference | private TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) { TYPE_1 session = TYPE_7 . TYPE_8 . METHOD_2 ( VAR_1 ) ; if ( session == null ) { TYPE_9 . TYPE_8 . METHOD_3 ( VAR_1 , true ) ; try { TYPE_5 . METHOD_4 ( ) . METHOD_5 ( TYPE_10 . VAR_3 , new TYPE_6 ( ) ) ; } catch ( InterruptedException e ) { <START> throw new RuntimeExce... | private TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) { TYPE_1 session = TYPE_7 . TYPE_8 . METHOD_2 ( VAR_1 ) ; if ( session == null ) { TYPE_9 . TYPE_8 . METHOD_3 ( VAR_1 , true ) ; try { TYPE_5 . METHOD_4 ( ) . METHOD_5 ( TYPE_10 . VAR_3 , new TYPE_6 ( ) ) ; } catch ( InterruptedException e ) { } session = TYPE_7 . TYPE_8 .... |
databindingcontext super class | public TYPE_8 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 , TYPE_4 VAR_5 , TYPE_5 VAR_6 , TYPE_6 VAR_7 ) { super ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 ) ; <START> VAR_8 = new TYPE_7 ( ) ; <END> } | public TYPE_8 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 , TYPE_4 VAR_5 , TYPE_5 VAR_6 , TYPE_6 VAR_7 ) { super ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 ) ; } |
simply assign | TYPE_6 ( Map < TYPE_1 , TYPE_2 > VAR_2 ) { this . VAR_2 = new TYPE_3 < TYPE_1 , TYPE_5 . TYPE_2 > ( ) ; <START> this . VAR_2 . METHOD_1 ( VAR_2 ) ; <END> } | TYPE_6 ( Map < TYPE_1 , TYPE_2 > VAR_2 ) { this . VAR_2 = VAR_2 ; } |
a bit puzzling instanceof necessary | public void METHOD_1 ( TYPE_1 config , String VAR_1 , Object data ) throws TYPE_2 { VAR_2 = new String [ 0 ] ; if ( data != null ) { <START> if ( data instanceof String && data . toString ( ) . length ( ) > 0 ) { <END> VAR_2 = StringUtils . VAR_3 ( data . toString ( ) ) ; } } } | public void METHOD_1 ( TYPE_1 config , String VAR_1 , Object data ) throws TYPE_2 { VAR_2 = new String [ 0 ] ; if ( data instanceof String && data . toString ( ) . length ( ) > 0 ) { VAR_2 = StringUtils . VAR_3 ( data . toString ( ) ) ; } } |
static _CODE_ ( ) | <START> private TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 , TYPE_2 record , TYPE_3 context ) { <END> TYPE_1 VAR_3 = new TYPE_4 ( TYPE_6 . VAR_5 , VAR_1 , null , context . VAR_6 ( ) ) . METHOD_2 ( record , context ) ; if ( VAR_2 ) { return VAR_3 ; } else { return new TYPE_5 ( VAR_3 . getType ( null ) , VAR_3 . METH... | private static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 , TYPE_2 record , TYPE_3 context ) { TYPE_1 VAR_3 = new TYPE_4 ( TYPE_6 . VAR_5 , VAR_1 , null , context . VAR_6 ( ) ) . METHOD_2 ( record , context ) ; if ( VAR_2 ) { return VAR_3 ; } else { return new TYPE_5 ( VAR_3 . getType ( context . VAR_6 ( ) ) , VAR_... |
redundant | public TYPE_1 [ ] METHOD_1 ( ) { <START> return new TYPE_1 [ ] { this . METHOD_2 ( ) } ; <END> } | public TYPE_1 [ ] METHOD_1 ( ) { return new TYPE_1 [ ] { METHOD_2 ( ) } ; } |
return ( ( VAR_1 & 1 ) = = 0 ) ? VAR_2 : VAR_3 ; | public static TYPE_1 getType ( int VAR_1 ) { <START> if ( VAR_1 % 2 == 0 ) { <END> return VAR_2 ; } return VAR_3 ; } | public static TYPE_1 getType ( int VAR_1 ) { return ( VAR_1 % 2 == 0 ) ? VAR_2 : VAR_3 ; } |
need catch | public boolean METHOD_1 ( ) { <START> if ( resource . VAR_1 ( ) != null ) { <END> return new TYPE_1 ( resource . VAR_1 ( ) . METHOD_2 ( ) ) . METHOD_3 ( ) ; } return false ; } | public boolean METHOD_1 ( ) { try { if ( resource . VAR_1 ( ) != null ) { return new TYPE_1 ( resource . VAR_1 ( ) . METHOD_2 ( ) ) . METHOD_3 ( ) ; } } catch ( IllegalStateException e ) { } return false ; } |
loaded lazy | protected final void METHOD_1 ( TYPE_1 VAR_1 ) { <START> VAR_2 = VAR_1 . METHOD_2 ( TYPE_2 . class ) ; <END> if ( VAR_2 == null ) { throw new IllegalStateException ( STRING_1 ) ; } METHOD_3 ( VAR_1 . METHOD_4 ( VAR_2 ) ) ; } | protected final void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; } |
lambda | public void METHOD_1 ( TYPE_1 parent , String VAR_1 , TYPE_2 trace ) { super . METHOD_1 ( parent , VAR_1 ) ; VAR_2 ++ ; VAR_3 = VAR_2 ; VAR_4 = trace ; VAR_5 = ( trace instanceof TYPE_3 ) ; METHOD_2 ( parent ) ; METHOD_3 ( ) ; <START> VAR_6 . METHOD_4 ( new TYPE_4 ( ) { <END> @Override public void METHOD_5 ( TYPE_5 e )... | public void METHOD_1 ( TYPE_1 parent , String VAR_1 , TYPE_2 trace ) { super . METHOD_1 ( parent , VAR_1 ) ; VAR_2 ++ ; VAR_3 = VAR_2 ; VAR_4 = trace ; VAR_5 = ( trace instanceof TYPE_3 ) ; METHOD_2 ( parent ) ; METHOD_3 ( ) ; VAR_6 . METHOD_4 ( ( e ) - > { METHOD_6 ( ) ; } ) ; } |
lucene works java7 Path _CODE_ eclipse needed VAR_3 declared string : TYPE_4 ( VAR_3 VAR_4 VAR_5 ) ( similar code a places ) | public synchronized TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { try { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( TYPE_4 . get ( VAR_3 . append ( VAR_4 ) <START> . append ( VAR_5 ) . METHOD_3 ( ) ) ) ; <END> TYPE_5 config = new TYPE_5 ( new TYPE_6 ( ) ) ; config . VAR_6 ( TYPE_7 . VAR_8 ) ; VAR_1 = new TYPE_1 ( VAR_2 , config ... | public synchronized TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { try { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( TYPE_4 . get ( VAR_3 , VAR_4 , VAR_5 ) ) ; TYPE_5 config = new TYPE_5 ( new TYPE_6 ( ) ) ; config . VAR_6 ( TYPE_7 . VAR_8 ) ; VAR_1 = new TYPE_1 ( VAR_2 , config ) ; } catch ( IOException e ) { Logger . VAR_9 ( e ... |
( VAR_1 instanceof TYPE_3 ) { } state code safely today a class cast exception I t condone casting testing type | protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> return ( ( TYPE_3 ) VAR_1 ) . METHOD_2 ( ) ; <END> } | protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_1 instanceof TYPE_3 ) { return ( ( TYPE_3 ) VAR_1 ) . METHOD_2 ( ) ; } return null ; } |
equals needed | public void METHOD_1 ( File VAR_1 ) { if ( VAR_1 != null && <START> ! VAR_1 . equals ( VAR_2 ) ) { <END> VAR_2 = VAR_1 ; } } | public void METHOD_1 ( File VAR_1 ) { VAR_2 = VAR_1 ; } |
a reason update VAR_2 changes | public void METHOD_1 ( String VAR_1 ) { <START> if ( VAR_2 == null ) { <END> if ( VAR_1 == null ) { return ; } } else if ( VAR_2 . equals ( VAR_1 ) ) { return ; } VAR_2 = VAR_1 ; } | public void METHOD_1 ( String VAR_1 ) { VAR_2 = VAR_1 ; } |
lambda | private static Integer METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 . METHOD_4 ( TYPE_2 . class ) ) ; <START> return TYPE_4 . METHOD_5 ( new TYPE_5 ( ) { <END> @Override public Integer run ( ) { return VAR_2 . METHOD_6 ( ) ; } } ) ; } | private static Integer METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 . METHOD_4 ( TYPE_2 . class ) ) ; return TYPE_4 . METHOD_5 ( ( ) - > { return VAR_2 . METHOD_6 ( ) ; } ) ; } |
belong TYPE_2 create ( ) a shell visible _CODE_ set result _CODE_ ( ) pass values I intermittently a minimum height small height trim reason | public void run ( ) { TYPE_1 VAR_1 = VAR_2 ; if ( VAR_1 == null ) { return ; } METHOD_1 ( VAR_1 ) ; if ( VAR_3 == null ) { VAR_3 = new TYPE_2 ( VAR_1 . METHOD_2 ( ) ) ; } if ( VAR_3 != null ) { VAR_3 . update ( VAR_1 ) ; VAR_3 . METHOD_3 ( ) ; <START> VAR_3 . METHOD_2 ( ) . METHOD_4 ( VAR_4 , VAR_4 ) ; <END> } } | public void run ( ) { TYPE_1 VAR_1 = VAR_2 ; if ( VAR_1 == null ) { return ; } METHOD_1 ( VAR_1 ) ; if ( VAR_3 == null ) { VAR_3 = new TYPE_2 ( VAR_1 . METHOD_2 ( ) ) ; } if ( VAR_3 != null ) { VAR_3 . update ( VAR_1 ) ; VAR_3 . METHOD_3 ( ) ; } } |
unnecessary | public TYPE_1 METHOD_1 ( TYPE_2 req , String name ) throws TYPE_3 , TYPE_4 { if ( ! name . equals ( VAR_1 ) ) throw new TYPE_3 ( name ) ; <START> final TYPE_1 <END> db = repo . VAR_2 ( ) ; db . VAR_3 ( ) ; return db ; } | public TYPE_1 METHOD_1 ( TYPE_2 req , String name ) throws TYPE_3 , TYPE_4 { if ( ! name . equals ( VAR_1 ) ) throw new TYPE_3 ( name ) ; TYPE_1 db = repo . VAR_2 ( ) ; db . VAR_3 ( ) ; return db ; } |
NPE passed TYPE_1 part a resource | public String getMessage ( TYPE_1 VAR_1 , String value ) { TYPE_2 uri = <START> VAR_1 . METHOD_1 ( ) . METHOD_2 ( ) ; <END> if ( uri != null && uri . VAR_2 ( ) && uri . VAR_3 ( ) > 1 ) { TYPE_3 VAR_4 = TYPE_4 . METHOD_3 ( uri . VAR_5 ( 1 ) ) ; return TYPE_6 . TYPE_7 . getMessage ( VAR_4 , value ) ; } return value ; } | public String getMessage ( TYPE_1 VAR_1 , String value ) { if ( VAR_1 . METHOD_1 ( ) != null ) { TYPE_2 uri = VAR_1 . METHOD_1 ( ) . METHOD_2 ( ) ; if ( uri != null && uri . VAR_2 ( ) && uri . VAR_3 ( ) > 1 ) { TYPE_3 VAR_4 = TYPE_4 . METHOD_3 ( uri . VAR_5 ( 1 ) ) ; return TYPE_6 . TYPE_7 . getMessage ( VAR_4 , value ... |
needed | protected void METHOD_1 ( ) throws Exception { <START> TYPE_1 . METHOD_2 ( ) ; <END> TYPE_1 . METHOD_3 ( VAR_1 ) ; VAR_2 = null ; VAR_3 = null ; VAR_4 = null ; super . METHOD_1 ( ) ; } | protected void METHOD_1 ( ) throws Exception { TYPE_1 . METHOD_3 ( VAR_1 ) ; VAR_2 = null ; VAR_3 = null ; VAR_4 = null ; super . METHOD_1 ( ) ; } |
unsafe VAR_2 protected set null contract return supplier null values rewritten check null | protected TYPE_1 < String > METHOD_1 ( String VAR_1 ) { if ( STRING_1 . equals ( VAR_1 ) ) { return ( ) - > <START> VAR_2 ; <END> } return super . METHOD_1 ( VAR_1 ) ; } | protected TYPE_1 < String > METHOD_1 ( String VAR_1 ) { if ( STRING_1 . equals ( VAR_1 ) ) { return ( ) - > VAR_2 != null ? VAR_2 : "" ; } return super . METHOD_1 ( VAR_1 ) ; } |
useful method _CODE_ | <START> protected String <END> METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { String VAR_4 = VAR_3 . getName ( ) ; TYPE_3 VAR_5 = new TYPE_3 ( VAR_6 , VAR_7 ) ; if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { String VAR_8 = VAR_5 . get ( VAR_2 , VAR_1 , String . VAR_9 ) ; if ( VAR_8 != null ) { VAR_4 = VAR_8... | private String METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { String VAR_4 = VAR_3 . getName ( ) ; TYPE_3 VAR_5 = new TYPE_3 ( VAR_6 , VAR_7 ) ; if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { String VAR_8 = VAR_5 . get ( VAR_2 , VAR_1 , String . VAR_9 ) ; if ( VAR_8 != null ) { VAR_4 = VAR_8 ; } } return VA... |
useful method _CODE_ | <START> protected int <END> METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { int VAR_4 = VAR_3 . METHOD_2 ( ) ; if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { TYPE_3 VAR_5 = new TYPE_3 ( VAR_6 , VAR_7 ) ; Integer VAR_8 = VAR_5 . get ( VAR_2 , VAR_1 , Integer . VAR_9 ) ; if ( VAR_8 != null && VAR_8 . METHOD_3 ... | private int METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { int VAR_4 = VAR_3 . METHOD_2 ( ) ; if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { TYPE_3 VAR_5 = new TYPE_3 ( VAR_6 , VAR_7 ) ; Integer VAR_8 = VAR_5 . get ( VAR_2 , VAR_1 , Integer . VAR_9 ) ; if ( VAR_8 != null && VAR_8 . METHOD_3 ( ) != VAR_4 ) {... |
need public static ? method | <START> public static <END> boolean METHOD_1 ( TYPE_1 project ) { TYPE_2 VAR_1 = project . VAR_2 ( TYPE_3 . VAR_4 ) ; if ( VAR_1 != null && VAR_1 . METHOD_2 ( ) ) { return true ; } return false ; } | private boolean METHOD_1 ( TYPE_1 project ) { TYPE_2 VAR_1 = project . VAR_2 ( TYPE_3 . VAR_4 ) ; if ( VAR_1 != null && VAR_1 . METHOD_2 ( ) ) { return true ; } return false ; } |
need public static ? method | <START> public static <END> boolean METHOD_1 ( TYPE_1 file ) { String VAR_1 = file . VAR_2 ( ) ; if ( ! VAR_1 . equals ( VAR_3 ) ) { return false ; } if ( file . exists ( ) && file . VAR_4 ( ) ) { String VAR_5 = file . VAR_6 ( ) . METHOD_2 ( ) ; if ( VAR_5 != null && ! VAR_5 . contains ( VAR_7 ) && ! VAR_5 . contains (... | private boolean METHOD_1 ( TYPE_1 file ) { String VAR_1 = file . VAR_2 ( ) ; if ( ! VAR_1 . equals ( VAR_3 ) ) { return false ; } if ( file . exists ( ) && file . VAR_4 ( ) ) { String VAR_5 = file . VAR_6 ( ) . METHOD_2 ( ) ; if ( VAR_5 != null && ! VAR_5 . contains ( VAR_7 ) && ! VAR_5 . contains ( VAR_8 ) ) { return ... |
new call line unreachable | public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 info ) { super ( VAR_2 ) ; METHOD_1 ( METHOD_2 ( ) | SWT . VAR_3 ) ; <START> VAR_4 = info != null ? info : new TYPE_2 ( TYPE_4 . VAR_6 ) ; <END> } | public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 info ) { super ( VAR_2 ) ; assert info != null ; METHOD_1 ( METHOD_2 ( ) | SWT . VAR_3 ) ; VAR_4 = info ; } |
change : assertEquals ( item ( ) item VAR_3 ( ) req VAR_4 ( item VAR_5 ( ) ) ) ; case fails loop failed | public void METHOD_1 ( ) { TYPE_1 req = new TYPE_1 ( TYPE_3 . VAR_2 ) ; for ( TYPE_2 item : TYPE_2 . values ( ) ) { <START> assertEquals ( item . VAR_3 ( ) , req . VAR_4 ( item . VAR_5 ( ) ) ) ; <END> } } | public void METHOD_1 ( ) { TYPE_1 req = new TYPE_1 ( TYPE_3 . VAR_2 ) ; for ( TYPE_2 item : TYPE_2 . values ( ) ) { assertEquals ( item . name ( ) , item . VAR_3 ( ) , req . VAR_4 ( item . VAR_5 ( ) ) ) ; } } |
String valueof ( String ) toString ( ) ; ? return string s final | public ANNOTATION_1 String toString ( ) { <START> return String . valueOf ( VAR_1 ) ; <END> } | public ANNOTATION_1 String toString ( ) { return VAR_1 ; } |
redundant parentheses | private boolean METHOD_1 ( ) { TYPE_1 VAR_1 = null ; try { VAR_1 = VAR_2 . getClass ( ) . METHOD_2 ( STRING_1 ) ; } catch ( TYPE_2 | TYPE_3 e ) { return false ; } return <START> ( VAR_1 != null ) ; <END> } | private boolean METHOD_1 ( ) { TYPE_1 VAR_1 = null ; try { VAR_1 = VAR_2 . getClass ( ) . METHOD_2 ( STRING_1 ) ; } catch ( TYPE_2 | TYPE_3 e ) { return false ; } return VAR_1 != null ; } |
please remove debug / log lines | protected TYPE_1 METHOD_1 ( TYPE_2 parent ) { final TYPE_2 VAR_1 = METHOD_2 ( parent ) ; <START> System . out . println ( VAR_1 . METHOD_3 ( ) ) ; <END> METHOD_4 ( VAR_1 ) ; METHOD_5 ( VAR_1 ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; return VAR_1 ; } | protected TYPE_1 METHOD_1 ( TYPE_2 parent ) { final TYPE_2 VAR_1 = METHOD_2 ( parent ) ; METHOD_4 ( VAR_1 ) ; METHOD_5 ( VAR_1 ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; return VAR_1 ; } |
TYPE_3 unwanted synchronization a performance problem I d suggest manually implementing copy - - write pattern a normal ArrayList a boolean list read ( copy omitted intervening read ) | public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { METHOD_2 ( ) ; if ( METHOD_3 ( ) ) { return ; } if ( this . VAR_2 == null ) { this . VAR_2 = new <START> TYPE_3 < > ( ) ; <END> } this . VAR_2 . add ( VAR_1 ) ; } | public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { METHOD_2 ( ) ; if ( METHOD_3 ( ) ) { return ; } if ( this . VAR_2 == null ) { this . VAR_2 = new ArrayList < > ( ) ; } this . VAR_2 . add ( VAR_1 ) ; } |
changing code instead String [ 0 ] String [ list size ( ) ] | public ANNOTATION_1 String ANNOTATION_1 [ ] METHOD_1 ( ) { TYPE_1 < String > list = new TYPE_1 < > ( ) ; TYPE_2 VAR_1 = this ; while ( VAR_1 . parent != null ) { list . VAR_2 ( VAR_1 . getName ( ) ) ; VAR_1 = VAR_1 . parent ; } <START> return list . VAR_3 ( new ANNOTATION_1 String [ 0 ] ) ; <END> } | public ANNOTATION_1 String ANNOTATION_1 [ ] METHOD_1 ( ) { TYPE_1 < String > list = new TYPE_1 < > ( ) ; TYPE_2 VAR_1 = this ; while ( VAR_1 . parent != null ) { list . VAR_2 ( VAR_1 . getName ( ) ) ; VAR_1 = VAR_1 . parent ; } return list . VAR_3 ( new ANNOTATION_1 String [ list . size ( ) ] ) ; } |
bug 487713#c11 previous revision return path case IOException sense add return statement | private String METHOD_1 ( TYPE_1 VAR_1 , String path ) { String VAR_2 = METHOD_2 ( path ) ; try { TYPE_2 url = null ; if ( VAR_2 != null ) { url = VAR_1 . METHOD_3 ( VAR_2 ) ; } if ( url == null ) { url = VAR_1 . METHOD_3 ( path ) ; } if ( url != null ) { TYPE_2 VAR_3 = TYPE_3 . METHOD_4 ( url ) ; return VAR_3 . toStri... | private String METHOD_1 ( TYPE_1 VAR_1 , String path ) throws IOException { String VAR_2 = METHOD_2 ( path ) ; TYPE_2 url = null ; if ( VAR_2 != null ) { url = VAR_1 . METHOD_3 ( VAR_2 ) ; } if ( url == null ) { url = VAR_1 . METHOD_3 ( path ) ; } if ( url != null ) { TYPE_2 VAR_3 = TYPE_3 . METHOD_4 ( url ) ; return V... |
false ? title displayed | public TYPE_3 ( TYPE_1 parent ) { super ( parent , Messages . TYPE_2 , Messages . TYPE_4 , Messages . TYPE_5 ) ; METHOD_1 ( VAR_5 ) ; <START> METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( true ) ; <END> METHOD_2 ( ) . METHOD_5 ( ) . METHOD_4 ( false ) ; } | public TYPE_3 ( TYPE_1 parent ) { super ( parent , Messages . TYPE_2 , Messages . TYPE_4 , Messages . TYPE_5 ) ; METHOD_1 ( VAR_5 ) ; METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( false ) ; METHOD_2 ( ) . METHOD_5 ( ) . METHOD_4 ( false ) ; } |
default preferred size ? I move class implementation specific - 1 - 1 treated default | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> return VAR_1 . METHOD_1 ( ) != null ? VAR_1 . METHOD_1 ( ) : TYPE_2 . VAR_2 ; <END> } | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return VAR_1 . METHOD_1 ( ) != null ? VAR_1 . METHOD_1 ( ) : VAR_2 ; } |
adding code pretty reverts attempts performance improvements method implies load basic informations detail a revision definitly part | public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { TYPE_2 VAR_3 = TYPE_3 . METHOD_2 ( VAR_1 , VAR_2 . getId ( ) ) ; <START> METHOD_3 ( VAR_2 , VAR_3 ) ; <END> TYPE_3 . METHOD_4 ( VAR_1 , VAR_2 . METHOD_5 ( ) ) ; } | public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { TYPE_2 VAR_3 = TYPE_3 . METHOD_2 ( VAR_1 , VAR_2 . getId ( ) ) ; METHOD_3 ( VAR_2 , VAR_3 ) ; } |
don t need null - check METHOD_3 method | public static TYPE_1 METHOD_1 ( Object object , TYPE_2 VAR_1 ) throws TYPE_3 { Object VAR_2 = METHOD_2 ( object , VAR_1 ) ; TYPE_1 VAR_3 = METHOD_3 ( VAR_2 ) ; if ( VAR_3 == null ) { VAR_2 = METHOD_2 ( object , VAR_4 , VAR_1 ) ; <START> if ( VAR_2 != null ) <END> VAR_3 = METHOD_3 ( VAR_2 ) ; } return VAR_3 ; } | public static TYPE_1 METHOD_1 ( Object object , TYPE_2 VAR_1 ) throws TYPE_3 { Object VAR_2 = METHOD_2 ( object , VAR_1 ) ; TYPE_1 VAR_3 = METHOD_3 ( VAR_2 ) ; if ( VAR_3 == null ) { VAR_2 = METHOD_2 ( object , VAR_4 , VAR_1 ) ; VAR_3 = METHOD_3 ( VAR_2 ) ; } return VAR_3 ; } |
returning empty list default nicer IMHO need null check invoker side | public TYPE_1 METHOD_1 ( ) { return <START> null ; <END> } | public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( ) ; } |
a static reduced : System getProperty ( STRING_1 ) startsWith ( 3 ) ; / / $NON - NLS - 1$ / / $NON - NLS - 2$ / / $NON - NLS - 3$ | public TYPE_2 ( String name ) { super ( name ) ; VAR_2 = TYPE_1 . METHOD_1 ( ) ; final String <START> VAR_3 = <END> STRING_1 ; String value = System . getProperty ( VAR_3 ) ; if ( value != null ) { if ( value . startsWith ( STRING_2 ) ) { VAR_4 = true ; } } } | public TYPE_2 ( String name ) { super ( name ) ; VAR_2 = TYPE_1 . METHOD_1 ( ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.