2020/06/29/#snappy.txt

[05:27] <mborzecki> morning
[07:00] <pstolowski> morning
[07:04] <zyga> Good morning
[07:04] <mborzecki> pstolowski: zyga: hey guys
[07:04] <zyga> I had a terrible night and I’m barely awake, I will not be around for some more time
[07:04] <zyga> Most likely I will take half a day or all day off
[07:05] <zyga> I managed to finally start sleeping only around 6
[07:53] <mup> PR snapd#8934 closed: overlord: mock timings.DurationThreshold in TestNewWithGoodState <Simple 😃> <Created by mvo5> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8934>
[08:00] <pedronis> mborzecki: hi, could you review #8683 ?
[08:00] <mup> PR #8683: osutil/disks: support IsDecryptedDevice for mountpoints which are dm devices <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8683>
[08:00] <mborzecki> pedronis: sure
[08:00] <pedronis> thx
[08:34] <zyga> o/
[08:34] <zyga> I feel somewhat better and I will work in 30 minutes, just need to handle some remote doctor stuff
[08:35] <zyga> thank you for the review pedronis, I think we will get the backend branch merged this week
[09:04] <pedronis> pstolowski: hi, I reviewed #8923
[09:04] <mup> PR #8923: wrappers: helper for enabling services (8/9) <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8923>
[09:04] <pstolowski> pedronis: hey, thank you
[09:11] <pstolowski> hmm something has changed (for worse) on https://ubuntu.com/core wrt downloading core images. it's super confusing and more difficult now
[09:13] <pedronis> pstolowski: probably something to talk with mvo when he's back
[09:13] <pstolowski> download link is buried at the bottom under Download Ubuntu Core. Download section at the top > Ubuntu for IoT > Raspberry.. redirects to server images. very confusing. I spent 10 minutes looking for core image
[09:25] <zyga> uh, github 500s
[09:30] <zyga> yeah, it's down
[09:31] <ogra> yeah 😞
[09:32] <ogra> well, only the UI ... seems cloning still works as expected
[09:33] <zyga> ogra: seems to be somewhat more than that
[09:34] <zyga> eh, I need to stretch my leg and back anyway
[09:34]  * zyga is not in a good shape today
[09:39] <mborzecki> brb, quick errand
[09:52] <mborzecki> re
[09:54] <pedronis> so github is not collaborating atm in terms of leaving reviews
[09:55] <zyga> https://github.com/snapcore/snapd/pull/8910 is in a funny state
[09:55] <mup> PR #8910: usersession: support additional zoom URL schemes <Bug> <Needs security review> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/8910>
[09:55] <zyga> it's not merged
[09:55] <zyga> but conflicts with nothing?
[09:55] <zyga> maybe got partially merged
[09:55] <zyga> as in merged in the tree but not in some database
[09:55] <zyga> eh, fun
[09:56] <zyga> pedronis: https://www.githubstatus.com indicates the issue is being fixed now
[10:06] <zyga> brb
[10:14] <mup> PR snapd#8936 opened: osutil: detect autofs mounted in /home <Bug> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/8936>
[10:22] <zyga> eh, github is still malfunctioning
[10:30] <ogra> GRRR ... it also affects build.snapcraft.io
[10:31] <ogra> (which is really funny because you can pull/push just fine ... but i guess websockets sit on top of the web service)
[10:45] <zyga> it seems everything is read only now
[10:45]  * zyga phone + doctor
[10:58] <zyga> re from doctor e-visit
[10:58] <zyga> weird but works
[11:01] <ogra> jdstrand, hmm, seems the raw-usb change to allow access to /dev/usb/lp[0-9] doesnt fully work ... a simple open call with (O_RDWR|O_NONBLOCK) : O_WRONLY) returns "Operation not permitted" ... but no errors are to be found anywhere (neither journal nor dmesg have anything)
[11:02] <ogra> do you have any idea what i should look for (and where) ?
[11:03] <zyga> ogra: look at the apparmor profile and check if there are any deny rules that could explain that
[11:03] <zyga> ogra: also look if the device is udev-tagged
[11:04] <zyga> ogra: a practical way is to check if major:minor and device/char code is present in the device cgroup of the snap that attempts access
[11:04] <ogra> well, but if there was anything with apparmor shouldnt i see denials ?
[11:04] <zyga> ogra: not if there are deny rules
[11:04] <zyga> there are two things that don't log
[11:04] <zyga> device cgroup not allowing things
[11:04] <zyga> and apparmor with a deny rule
[11:04] <zyga> is the /dev/usb/lp* thing a device node?
[11:04] <ogra> would the latter log in devmode ?
[11:04] <zyga> none of those log
[11:04] <ogra> yeah
[11:04] <zyga> in any mode
[11:04] <ogra> ah, k
[11:05] <ogra> ogra@localhost:~$ ls -lh /dev/usb/
[11:05] <ogra> total 0
[11:05] <ogra> crw-rw---- 1 root lp 180, 0 Jun 29 10:32 lp0
[11:05] <zyga> ok
[11:05] <ogra> just a char device
[11:05] <zyga> it's a char device
[11:05] <zyga> so check if that's listed in the device cgroup
[11:05] <zyga> in /sys/fs/cgroup/devices/snap.$SNAP_NAME
[11:06] <zyga> then cat the devices.list file
[11:07] <zyga> if it's not there then that's why
[11:07] <ogra> 180 is not in there
[11:07] <zyga> and we can check why it's not there
[11:07] <zyga> ok, look at the udev rules
[11:07] <ogra> well, most likely because my PR is incomplete 🙂
[11:07] <ogra> (i only added the entry for apparmor )
[11:07] <zyga> please check /etc/udev/rules.d/70-snap.$SNAP_NAME.rules
[11:07] <zyga> ah
[11:07] <zyga> I see
[11:08] <zyga> let me know if you need help with the udev side
[11:08] <zyga> you need to figure out what kind of udev attributes to match against
[11:08] <ogra> that was https://github.com/snapcore/snapd/pull/8329 btw
[11:08] <mup> PR #8329: interfaces: allow raw access to USB printers <Created by ogra1> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8329>
[11:08] <zyga> udevadm info --export-db is useful to know
[11:08] <zyga> heh
[11:08] <zyga> I reviewed it
[11:09] <zyga> can you export udev data and paste the relevant fragment please?
[11:09] <ogra> well, jamie made a comment already suspecting it is not enough
[11:09] <zyga> the one that describes that /dev/usb/lp0
[11:09] <zyga> :)
[11:09] <zyga> yeah
[11:09] <zyga> FWIW I'm happy it got merged
[11:09] <zyga> even if it's not complete
[11:09] <zyga> makes us move forward
[11:10] <ogra> https://paste.ubuntu.com/p/3jshrXD4zj/
[11:10] <zyga> huh
[11:10] <zyga> what kind of printer is that?
[11:10] <ogra> HP laserjet 1018
[11:11] <ogra> on UC18
[11:11] <zyga> maybe we need subsystem=USBMISC
[11:11] <zyga> or maybe core is missing something
[11:11] <zyga> can you plug it to a classic system
[11:11] <zyga> and check if udev says more?
[11:11]  * zyga is running system backup and that's long and makes fans go wrrrr
[11:12] <mborzecki> zyga: the fans go brrr? :)
[11:12] <ogra> thats tricky ... the one i have has the hplib stuff installed, that mangles udev afaik
[11:12] <zyga> mborzecki: I go grrr while the fans go wrrr
[11:12] <zyga> ogra: let's try it anyway
[11:12] <zyga> maybe we need more udev rules
[11:12] <zyga> as the core device does not seem to think this is a printer yet
[11:13] <pedronis> mborzecki: I reviewed #8924
[11:13] <mup> PR #8924: gadget, bootloader: preserve managed boot assets during gadget updates <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8924>
[11:14] <ogra> https://paste.ubuntu.com/p/46fDj5mzcf/ ... still usbmisc
[11:15] <mborzecki> pedronis: thanks
[11:21] <ogra> zyga, oh ... i only noticed now tht there is another (higher level) entry (i grepped for "usb/lp" ... ) that actually lists the snap ... it is just not the /dev/usb/lp0 itself that has any tags
[11:21] <zyga> ahh
[11:21] <zyga> interesting
[11:21] <zyga> what's the other entry?
[11:21] <ogra> https://paste.ubuntu.com/p/x7dW98cYFS/
[11:22] <zyga> hmmm, interesting that there's a precise entry for this
[11:22] <zyga> but not for lp0
[11:22]  * zyga doesn't understand usb and udev well enough
[11:23] <ogra> i wonder if i could DEVPATH from that entry ad the "printer device" in the app
[11:24] <ogra> heh
[11:24] <ogra> Connection from 192.168.2.48 port 32908 accepted
[11:24] <ogra> /sys/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.5/1-1.5:1.0: Is a directory
[11:24] <ogra> 😛
[11:27] <zyga> ogra: hmm?
[11:27] <zyga> does it work
[11:27] <zyga> btw maybe ask til for advice
[11:27] <ogra> nah
[11:27] <zyga> I would love to know more what to do with the permission stack
[11:27] <zyga> and why that character device was not annotated
[11:27] <ogra> well, i guess i need the tags for the actual device node
[11:28] <zyga> but there's nothing to match against, you saw the data
[11:28] <ogra> DEVNAME ?
[11:28] <ogra> after all it is a fixed path ... "/dev/usb/lp*"
[11:29] <zyga> hmm
[11:29] <zyga> maybe
[11:29] <zyga> can udev match against that?
[11:30] <ogra> i guess so ... iirc that is how HP creates the symlinks into /dev
[11:30] <zyga> try it
[11:32] <zyga> https://github.com/snapcore/snapd/pull/8936 is a low hanging fruit
[11:32] <mup> PR #8936: osutil: detect autofs mounted in /home <Bug> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/8936>
[11:32] <pedronis> mborzecki: reviewed #8930
[11:32] <mup> PR #8930: many: managed boot config during run mode setup <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8930>
[11:32] <mborzecki> pedronis: thanks again
[11:34] <mup> PR snapd#8910 closed: usersession: support additional zoom URL schemes <Bug> <Needs security review> <Simple 😃> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/8910>
[11:35] <zyga> backup complete, back to work
[11:37] <zyga> github actions are still down
[11:37] <zyga> but some pages work better now
[11:39] <zyga> all systems operational now
[11:41] <ogra> zyga, well, re-reading jdstrand's comment on the PR i guess just adding usbmisc might be the best
[11:41] <ogra> var rawusbConnectedPlugUDev = []string{
[11:41] <ogra>         `SUBSYSTEM=="usb"`,
[11:41] <ogra>         `SUBSYSTEM=="tty", ENV{ID_BUS}=="usb"`,
[11:41] <ogra> }
[11:41] <ogra> here ...
[11:41] <ogra> (no idea where that snippet comes from though)
[11:42] <ogra> probably something like:   `SUBSYSTEM=="usbmisc", ENV{DEVNAME}=="/dev/usb/lp*"` (now i dont know if globbing wrks here though)
[11:44] <pedronis> mborzecki: also #8925
[11:44] <mup> PR #8925: bootloader: allow managed bootloader to update its boot config <Needs Samuele review> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8925>
[11:44] <mup> PR snapd#8936 closed: osutil: detect autofs mounted in /home <Bug> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/8936>
[11:45] <mup> PR snapd#8910 opened: usersession: support additional zoom URL schemes <Bug> <Needs security review> <Simple 😃> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/8910>
[11:45] <mborzecki> pedronis: thank you
[11:50] <mup> PR snapd#8910 closed: usersession: support additional zoom URL schemes <Bug> <Needs security review> <Simple 😃> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/8910>
[11:50] <mup> PR snapd#8936 opened: osutil: detect autofs mounted in /home <Bug> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/8936>
[12:20] <mup> PR snapd#8935 closed: spread.yaml: allow amazon-linux-2-64 qemu with ec2-user/ec2-user <Simple 😃> <Created by jdstrand> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8935>
[12:28] <zyga> pstolowski: https://github.com/snapcore/snapd/pull/8932#pullrequestreview-439084856
[12:28] <mup> PR #8932: o/ifacestate: update security profiles in connect undo handler <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8932>
[12:28]  * zyga -> meds
[12:32] <zyga> re
[12:37] <pstolowski> zyga: great catch! and i got the test wrong, because with this is should be 0 security backend calls
[12:37] <zyga> happy to help :-)
[12:38] <pstolowski> thanks!
[12:39] <zyga> mborzecki: could you please do a 2nd review on https://github.com/snapcore/snapd/pull/8863
[12:39] <mup> PR #8863: sandbox/cgroup: allow discovering PIDs of given snap <Created by zyga> <https://github.com/snapcore/snapd/pull/8863>
[12:39] <zyga> with this the backend branch is super close to landing
[12:39] <zyga> (and has reduced from 2K+ to sub 1K now)
[12:40] <mup> PR snapd#8937 opened: o/devicestate: set mark-seeded to done in the task itself <Simple 😃> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8937>
[12:43] <ijohnson> morning folks
[12:43] <zyga> hey
[12:48] <zyga> ijohnson: hey, since you are here and expressed interested in https://github.com/snapcore/snapd/pull/8863
[12:48] <mup> PR #8863: sandbox/cgroup: allow discovering PIDs of given snap <Created by zyga> <https://github.com/snapcore/snapd/pull/8863>
[12:48] <zyga> could you please look, I think it is close
[12:48] <ijohnson> zyga: yes I will take a look today, sorry it was on my queue for Friday but got lost with other things that came up
[12:49] <zyga> no worries
[12:49] <zyga> I asked maciek as well
[12:49] <zyga> but I think this is very close and I would love to make progress on it :)
[12:52] <pstolowski> zyga: updated #8932
[12:52] <mup> PR #8932: o/ifacestate: update security profiles in connect undo handler <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8932>
[12:53] <zyga> ack
[12:55] <zyga> pstolowski: did you push?
[12:55] <zyga> maybe gh is broken again
[12:56] <pstolowski> zyga: yes, but wrong branch ;)
[12:56] <pstolowski> now
[12:56]  * pstolowski needs to cleanup his local git repo from old stale branches
[13:00] <zyga> pstolowski: +1
[13:00] <pstolowski> ty
[13:00] <mup> PR snapd#8938 opened: sandbox/cgroup: extend SnapNameFromPid with tracking cgroup data <Created by zyga> <https://github.com/snapcore/snapd/pull/8938>
[13:00] <zyga> ^ that's still a draft, I want to wait for the prerequisite to land and work on the TODO there
[13:30] <zyga> pstolowski: let me know if you want to work on snap-confine and udev or if I should pick it up please
[13:35] <mup> PR snapd#7168 closed: tests: measure testbed for leaking mountinfo entries <Test Robustness> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/7168>
[13:35] <mup> PR snapd#8570 closed: many: allow using ~/.snapdata instead of ~/snap <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/8570>
[13:38] <ijohnson> cachio: can you re-review / re-test #8933 ? I think I fixed the issue you found on Friday
[13:38] <mup> PR #8933: tests/core/uc20-recovery: apply hack to get gopath in recover mode w/ external backend <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8933>
[13:41] <pstolowski> zyga: i'll do it
[13:41] <zyga> pstolowski: ok
[13:52]  * zyga -> lunch!
[13:58] <cachio> ijohnson, checking
[14:19] <ijohnson> thanks cachio
[14:22] <zyga> back
[14:22]  * zyga migrates away from irccloud
[14:34] <zyga> yay
[14:34] <cachio> ijohnson, done
[14:34]  * zyga closed his IRCcloud account
[14:34] <ijohnson> thanks cachio
[14:34] <cachio> yaw
[14:49] <pstolowski> #8928 needs a 2nd review, test only and uncontroversial
[14:49] <mup> PR #8928: tests: add spread test for disconnect undo caused by failing disconnect hook <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8928>
[15:08] <mborzecki> pedronis_: do you mean first boot here? https://github.com/snapcore/snapd/pull/8924/files/567604a5eece95698088a21de1e36a9310a2ee77#r446889258
[15:08] <mup> PR #8924: gadget, bootloader: preserve managed boot assets during gadget updates <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8924>
=== pedronis_ is now known as pedronis
[15:11] <pedronis> mborzecki: no, I really mean more the combination of gadget/install and make bootable for run for handling install
[15:13] <pedronis> mborzecki: which doesn't use this code?  it's a different path?
[15:14] <mborzecki> pedronis: run mode install is https://github.com/snapcore/snapd/pull/8930
[15:14] <mup> PR #8930: many: managed boot config during run mode setup <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8930>
[15:14] <pedronis> mborzecki: yes, but that will overwrite things put there by gadget/install?
[15:14] <pedronis> I'm just slightly wondering if we should avoid the double write
[15:15] <pedronis> or if I'm confused there's not double write
[15:16] <mborzecki> pedronis: ah, i see, so you mean the scenario when system-boot is popuated by gadget install, and then InstallBootConfig coes in an overwrites grub.cfg
[15:16] <pedronis> yes
[15:17] <pedronis> maybe is not worth worrying about it because we will remove things from gadget at some point?
[15:17] <pedronis> but it feels a bit asymmetric to filter out things on update but not on write
[15:17] <mborzecki> pedronis: yeah, i would assume it's not a problem, provided we keep installing boot config last
[15:18] <mborzecki> with a note perhaps
[15:18] <mborzecki> pedronis: just to make the assumptions about the order of operations clear
[15:19] <pedronis> yea, it sounds like a low-prio todo, so a note here
[15:19] <pedronis> and maybe a todo in the write code
[15:19] <mborzecki> ok
[15:33]  * cachio lunch
[15:35] <mup> PR snapd#8936 closed: osutil: detect autofs mounted in /home <Bug> <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8936>
=== zyga-mbp is now known as zyga
[16:26] <mup> PR snapd#8939 opened: [RFC] snap-confine: don't die if a device from sysfs path cannot be found by udev <Created by stolowski> <https://github.com/snapcore/snapd/pull/8939>
[16:29] <zyga> ijohnson: https://github.com/snapcore/snapd/pull/8863 has +2 and I'll merge it when green, if you want to review it I will hold but I'd love to push forward
[16:29] <zyga> let me know please
[16:29] <mup> PR #8863: sandbox/cgroup: allow discovering PIDs of given snap <Created by zyga> <https://github.com/snapcore/snapd/pull/8863>
[16:40] <ijohnson> zyga: nah go for it, I wouldn't get to it for at least a couple of hours
[16:41] <ijohnson> sorry about that, but happy you're make progress, irrespective of my slow (and sometimes absent) reviews :-)
[16:41] <zyga> ijohnson ack, thank you :)
[16:41] <zyga> it was refined so I really think it's ready
[17:46] <mup> PR snapd#8683 closed: osutil/disks: support IsDecryptedDevice for mountpoints which are dm devices <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8683>
[18:36] <mup> PR snapd#8940 opened: tests: fix "restart.service" <Simple 😃> <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/8940>
[20:11] <mup> PR snapd#8863 closed: sandbox/cgroup: allow discovering PIDs of given snap <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8863>
[20:16] <mup> PR snapd#8941 opened: sandbox/cgroup: avoid parsing security tags twice <Created by zyga> <https://github.com/snapcore/snapd/pull/8941>
[20:32] <mup> PR snapd#8928 closed: tests: add spread test for disconnect undo caused by failing disconnect hook <Simple 😃> <Created by stolowski> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8928>
[20:42] <mup> PR snapd#8937 closed: o/devicestate: set mark-seeded to done in the task itself <Simple 😃> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8937>
[20:42] <mup> PR snapcraft#3192 opened: Flutter <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3192>
[20:47] <mup> PR snapcraft#3191 closed: plugins: introduce v1.FlutterPlugin <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3191>
[22:02] <mup> PR snapd#8942 opened: tests: to support different images on nested execution <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8942>