File size: 22,211 Bytes
4aa5fce |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 |
[00:01] <valorie> off to dinner & dad's [00:35] <mamarley> Riddell: Could I be taken off the Kubuntu Ninjas list? My "real job" is taking up too much time for me to be an effective tester. [06:19] <soee> good morning [07:56] <apachelogger> Riddell: please promote dev to admin https://launchpad.net/~kubuntu-ppa/+members [08:16] <Riddell> apachelogger: voila, remember with great power comes greater amounts of spam [08:20] <apachelogger> thx I think everyone filters that to trash already ^^ [08:20] <apachelogger> I certainly do [09:58] <shadeslayer> Riddell: can you give me the bug number for the Qt SRU [10:00] <BluesKaj> 'Morning folks [10:02] <shadeslayer> hmm [10:02] <shadeslayer> someone should be reviewing sgclark's work [10:02] <shadeslayer> http://bazaar.launchpad.net/~kubuntu-packagers/kubuntu-packaging/ksysguard/view/head:/debian/rules#L9 [10:03] <shadeslayer> shouldn't that be overriden_test [10:13] <Riddell> shadeslayer: shouldn't what be overriden_test? [10:13] <Riddell> shadeslayer: bug 1289600 [10:13] <ubottu> bug 1289600 in qt4-x11 (Ubuntu Saucy) "Fix for crashes due to ubuntu-specific accessibility patch" [Undecided,Fix committed] https://launchpad.net/bugs/1289600 [10:20] <shadeslayer> erm [10:20] <shadeslayer> I meant overriden_command [10:24] <Riddell> $(overridden_command) is correct [10:34] <shadeslayer> Riddell: right, but sgclark seems to be passing the actual command :) [10:34] <shadeslayer> oh hm, maybe overriden_command doesn't work with xvfb [10:36] <Riddell> ah you mean "xvfb-run -a dh_auto_test" should be "xvfb-run -a $(overridden_command)" ? [10:36] <Riddell> you could well be right, although it's not very important, but do tell her that [10:37] <shadeslayer> yep [10:37] <Riddell> shadeslayer: I do have this e-mail from her "ksysguard rev 3 in bzr needs review and upload Added sensors support and some cleanup." [10:37] <ubottu> http://websvn.kde.org/trunk/?rev=3&view=rev | svn://anonsvn.kde.org/home/kde/trunk -r 3 [10:37] <shadeslayer> but I /think/ using overridden_command with xvfb doesn't work [10:39] <shadeslayer> Riddell: I can't get plasma to crash in the 12.04.4 ISO [10:39] <Riddell> shadeslayer: just like the other person trying to verify, annoying when a bug disappears [11:06] <shadeslayer> Riddell: commented, so what do we do now? [11:08] <Riddell> shadeslayer: on the bug? get the ones which are verified in at least [11:08] <Riddell> and close the other one as disappeared if nobody can recreate it [11:12] <shadeslayer> Riddell: do you know sgclark's launchpad page? [11:26] <Riddell> it's... scarlett! [11:27] <sgclark> Riddell: morning :) [11:30] <Riddell> sgclark: there's no commits from you in oxygen bzr, where did you put your changes? [11:31] <sgclark> Riddell: still local due to the list-missing items I had questions on, I can commit what I have if you want [11:32] <Riddell> sgclark: go ahead and commit, easiest way to share I guess and revision control is easy to revert === jono is now known as Guest41797 [11:38] <sgclark> Riddell: committed [11:40] <Riddell> sgclark: groovy, I don't know if oxygen-settings5 is used but let's install it just incase [11:41] <Riddell> sgclark: the .so links in libraries are only used when compiling another programme against that library and I'm pretty sure nothing else uses these libraries [11:41] <Riddell> and it's usually not a good idea to install the .so and .h files which allow something to use it unless you know it has a stable ABI/API [11:41] <sgclark> ahh ok [11:42] <Riddell> I'm pretty sure these libraries are only some shared code between the window decoration and the qwidget style, but nothing outside the oxygen package [11:42] <sgclark> gotcha, then it looks good to me :) [11:42] <Riddell> sgclark: do you want to upload to experimental as reviewer? [11:42] <sgclark> sure! [11:48] <Riddell> sgclark: you know about bzr-buildpackage-ppa ? [11:48] <sgclark> Riddell: nope [11:50] <Riddell> sgclark: wee script in kubuntu-automation to build a source package from an unreleased bzr [11:51] <Riddell> it'll download the .orig, set UNRELEASED to trusty and add the ~ppa1 bit on the version number [11:51] <Riddell> then you can just dput ppa:kubuntu-ppa/experimental foo.changes [11:55] <Blizzz> mh, i can use either external and internal mic or none at all. [11:58] <Riddell> Blizzz: sounds like a good set of choices [11:58] <Blizzz> simplyfies things– [12:09] <sgclark> Riddell: I cannot find the source changes file. it fails at debsign, obviously because i am not you. [12:11] <Riddell> sgclark: debsign -k me@me.com foo.changes [12:11] <Riddell> I set this.. [12:11] <Riddell> >cat .devscripts [12:11] <Riddell> DEBSIGN_KEYID=jriddell@ubuntu.com [12:14] <sgclark> Riddell: worked! thank you [12:15] <sgclark> Riddell: oxygen uploaded! [12:17] <Riddell> yay! thanks [12:19] <mamarley> Riddell: Could I be taken off the Kubuntu Ninjas list? My "real job" is taking up too much time for me to be an effective tester. Sorry :( [12:22] <Riddell> mamarley: you mean the irc ping? [12:24] <mamarley> Riddell: That, and I have removed the secret PPA from my list. [12:24] <mamarley> Sorry, I just don't have time for it anymore. [12:27] <Riddell> mamarley: no problem, you're welcome back any time you're able to help :) [12:31] <mamarley> Thanks! [12:39] <Riddell> sgclark: are you going to make a doodle poll for your membership meeting? [12:41] <sgclark> Riddell: doodle poll? [12:41] <Riddell> sgclark: doodle.com easiest way of finding dates/times people can agree on [12:41] <sgclark> Riddell: also getting python errors trying to make wiki, should I make one on ubuntu as suggested? [12:43] <Riddell> sgclark: yeah just use wiki.ubuntu.com, it's the same wiki just different domain [12:48] <sgclark> Riddell: err emails to send this doodle to? [12:48] <Riddell> sgclark: none [12:49] <Riddell> sgclark: just send it manually to kubuntu-devel mailing list [12:53] <shadeslayer> sgclark: ping [12:53] <sgclark> shadeslayer: present [12:53] <shadeslayer> not a roll call :P [12:54] <shadeslayer> sgclark: any reason to drop qapt-batch from gwenview recommends [12:54] <sgclark> shadeslayer: ask debian [12:54] <shadeslayer> sgclark: no, that's ubuntu specific delta [12:54] <shadeslayer> since we ship with the kipi installation patch [12:55] * sgclark hates merges [12:55] <sgclark> I was told to go with debian so no I don't know. if it is wrong then change it. sorry [12:56] <shadeslayer> sgclark: you only go with debian if it makes sense to drop the ubuntu change [12:57] <yofel> hm, somehow kget is missing 2 versions in the changelog o.O [12:59] <yofel> Riddell: ^ ? [12:59] <Riddell> spooky [13:00] <sgclark> yofel: I use merge_changelog [13:00] <Riddell> I've always said I don't trust those merge scripts [13:00] <ScottK> sgclark: merges are hard. [13:00] <yofel> nono, not that, it's 4:4.13.0-0ubuntu1 -> 4:4.13.0-0ubuntu4 [13:00] <yofel> where's 2 and 3 ? [13:00] <sgclark> ScottK: I am seeing that [13:01] <yofel> sgclark: can it be that you're using 'dch -i' to edit changelogs? Please don't use -i for UNRELEASED [13:01] <ScottK> Good way to learn stuff though. [13:01] <yofel> also, tag is missing in bzr [13:03] <sgclark> yofel: oh, I was trying to upload to my ppa after fails but couldn't because it existed. Probably does not need to be 4. My fault [13:03] <yofel> sgclark: for ppa's please add ~ppaX [13:03] <yofel> that way the archive package will also be higher than the PPA package [13:03] <sgclark> ok [13:04] <yofel> sgclark: also, in case you don't know what's up with all the : and ~ in our versions: http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version [13:05] <sgclark> yofel: thank you, will read that! [13:06] <yofel> Riddell: and please don't forget to tag the branch after uploading [13:08] <shadeslayer> sgclark: gwenview looks good apart from that qapt recommends, do you want to push your merge into bzr or should I? [13:09] <Riddell> yofel: I don't think I've ever manually pushed a tag, do we actually care about them? [13:09] <sgclark> shadeslayer: I would be grateful if you would :) [13:09] <yofel> Riddell: well, they're handy to know what commit was actually uploaded. And our scripts and me add them at least [13:10] <shadeslayer> sgclark: ok [13:10] <yofel> usually it's just running 'bzr tag' which will figure out the version itself [13:11] <Riddell> mgraesslin: I'm getting lots of XCB requirements from cmake output of oxygen (presumably window decoration), do you know if they're actually needed? (click show/hide by the orange oxygen here http://qa.kubuntu.co.uk/plasma-status/build_status_4.96.0_trusty.html) [13:11] <yofel> shadeslayer: looking at kdepim now, didn't get to it yesterday [13:11] <shadeslayer> yofel: cheers [13:11] <shadeslayer> yofel: I was thinking of just running the build in a lxc and then installing the packages [13:11] <shadeslayer> to make sure stuff didn't conflict [13:11] <mgraesslin> Riddell: my gut feeling is "no" [13:12] <Riddell> mgraesslin: thanks [13:12] <yofel> shadeslayer: well, that will only find the conflicts for the order that apt decides to upgrade the packages in [13:12] <yofel> the diff isn't that long [13:12] <shadeslayer> right [13:12] <shadeslayer> ok [13:14] <ScottK> yofel: IMO whoever uploads should push the tag. [13:14] <shadeslayer> sgclark: pushed to bzr, thx for merging gwenview :) [13:15] <yofel> that's what I meant, though I see that what I said can be misunderstood [13:15] <sgclark> shadeslayer: thank you. I will get better at this! [13:15] <shadeslayer> sgclark: np [13:19] <yofel> shadeslayer: btw. breaks/replaces versions should end with a ~ [13:20] <yofel> if they have ubuntu in them [13:20] <yofel> or really in general [13:23] <shadeslayer> sgclark: fwiw kalgebra merge wasn't required [13:24] * yofel is curious why not [13:24] <sgclark> it was on the list! [13:25] <yofel> hm, they didn't change much yet indeed [13:25] <shadeslayer> yofel: last change was in 4.12.4 [13:25] <shadeslayer> which we have [13:25] <yofel> ah true [13:26] <shadeslayer> sgclark: the list a list of all KDE SC packages which might/might not need a merge :P [13:26] <ScottK> Doesn't hurt. [13:26] <shadeslayer> ScottK: hm? [13:27] <shadeslayer> sgclark: I don't see amor in https://launchpad.net/~scarlett-7/+archive/kubuntu-ppa [13:27] <shadeslayer> or kget [13:27] <sgclark> shadeslayer: afaik Riddell: got those [13:28] <shadeslayer> ok [13:28] <ScottK> Even if the merge is only changelog entries, there's no harm in it. [13:29] <shadeslayer> ScottK: it's not even changelog entries :) [13:29] <yofel> shadeslayer: kget at least is already in archive :/ [13:29] <shadeslayer> yofel: oh ok [13:31] <ScottK> Oh [13:31] * shadeslayer starts on kdepimlibs [13:32] <sgclark> I am trying to apply for memebership, if any kind souls could give me testimonial or cheers here: https://wiki.ubuntu.com/ScarlettGatelyClark#preview pretty please [13:33] <Riddell> shadeslayer: I uploaded amor but forgot to put it in bzr, done now [13:36] <sgclark> Riddell: I had to fix depends in systemsettings, pushed to bzr if you could review and push [13:36] <yofel> again with missing version in changelog -.- [13:37] <yofel> with tag though, Riddell++ [13:49] <yofel> shadeslayer: kdepim r359 up [13:50] <yofel> I removed the breaks/replaces for the mobile stuff, I didn't see anything getting moved there [13:56] <yofel> sgclark: could you maybe put up a new doodle poll that has actual times in it? We live all over the world, with our respective work times so the poll should also allow us to find a time to meet, not just a date [13:56] <yofel> would be nice [13:56] <sgclark> yofel: exactly, I have absolutely no idea what time to choose [13:57] <sgclark> I am in the US [13:57] <yofel> sgclark: enable all times that you are available at [13:57] <sgclark> but can set my alarm to accomodate [13:57] <yofel> i.e. you're not... sleeping/in town/work/school/drunk/whatever [13:57] <sgclark> I am flexible, usually up pretty early [13:58] <yofel> well, then you can enable all 24h hours of the day, so we can put in the times when we have time [13:58] <sgclark> that is what I did [13:59] <yofel> that resulted in there being one checkbox for the whole day :/ [13:59] <sgclark> oh I see, ok [14:00] <manchicken> /join #kubuntu [14:00] <manchicken> Death to the space bar [14:00] <yofel> hehe [14:03] <apachelogger> am I getting old or is it just incredibly hard to write sudo apt install instead of sudo apt-get install [14:05] <Riddell> why would you want to? [14:05] <apachelogger> because colors [14:05] <apachelogger> apt has arrived in the 1900's now \o/ [14:06] <Riddell> ooh ooh apt exists! [14:06] <Riddell> at last one simple to type command that can do what the other commands could with extra typing [14:06] <Riddell> today is a good day [14:06] <shadeslayer> heh [14:06] <Riddell> apachelogger: yes, you're getting old, here's your zimmer frame [14:06] <shadeslayer> apachelogger: you're old [14:06] <shadeslayer> It took me only 2 weeks to switch [14:07] <apachelogger> I think I should have made aliases at some point and then reused those [14:07] <yofel> apt also has progressbars! [14:07] <yofel> <3 progressbars [14:07] <yofel> though I agree with apachelogger :D [14:08] <apachelogger> you must also be old then [14:08] <shadeslayer> ^^ [14:08] <apachelogger> shadeslayer: GET OFF MY LAWN! [14:08] <Riddell> wow, colours! progress bars! [14:08] <shadeslayer> apachelogger: you don't have one old man [14:08] <apachelogger> pfft [14:08] <apachelogger> scru u old sport [14:10] <apachelogger> now apt just needs short hand aliases and I'd almost be happy [14:10] <apachelogger> apt in htop [14:10] <apachelogger> would be so much better [14:11] <apachelogger> Riddell: btw, did you try tarme.rb? [14:11] <Riddell> apachelogger: sorry, it's on the todo list [14:12] <apachelogger> no rush, busy with other stuff this week anyway [14:35] <sgclark> Riddell: sorry my internet cut out and my systemsettings did not get get pushed, it is now though if you could review and push. [14:37] <Riddell> thanks sgclark [14:39] <yofel> sgclark: https://projects.kde.org/projects/kde/workspace/systemsettings would be the correct homepage [14:39] <yofel> also, it would be nice if the control files had the Vcs-* fields [14:42] <sgclark> Vcs- fields? bzr address? [14:43] <yofel> right [14:43] <yofel> like the sc packages do [14:43] <sgclark> ok [14:49] <shadeslayer> yofel: Riddell kdepimlibs merged as well [14:49] <shadeslayer> plz review when you have time [14:50] <yofel> .gitattributes? ^^ [14:50] <shadeslayer> uf [14:52] <yofel> looks fine though [14:53] <sgclark> yofel, Riddell: fixed homepage and Vcs systemsettings [14:54] <Riddell> sgclark: I've pushed kfilemetadata5 ready for review [14:54] <yofel> thanks :) [14:54] <sgclark> Riddell: ok reviewing [14:55] <yofel> Riddell: also missing Vcs-* entries [14:55] <yofel> also, debian now uses wrap-and-sort, so we should do the same [14:55] <sgclark> Riddell; I can add them if you wish [14:56] <sgclark> yofel: wrap-and-sort? [14:56] <yofel> sgclark: part of the devscripts package: [14:56] <yofel> wrap-and-sort - wrap long lines and sort items in Debian packaging files [14:56] <yofel> readability++ [14:58] <yofel> shadeslayer: I think we should make wrap-and-sort mandatory for kde as maxy uses it now, right? [14:58] <shadeslayer> yep [14:59] <sgclark> is that a program? or setting in my text program? word wrap is easy enough, unsure on sort bit [14:59] <shadeslayer> <maxy> shadeslayer: Also, please, run wrap-and-sort, that will create smaller diffs [14:59] <yofel> sgclark: program [14:59] <yofel> sgclark: just run it inside the debian/ folder [14:59] <sgclark> ahh ok thank you [14:59] <Riddell> sgclark: go ahead [15:00] <shadeslayer> yofel: or well, in the folder that contains the debian folder :) [15:00] <yofel> ah right, that works too [15:01] <yofel> I got confused as I always had to pass -d . for neon as those branches have no folder inside ^^ [15:01] <Riddell> wrap-and-sort gives me a unicode error, wasn't python 3 supposed to get rid of unicode errors? http://paste.kde.org/plmycnavi [15:02] <Riddell> mm yes wrap-and-sort is nice when it doesn't give a unicode error [15:02] <apachelogger> python [15:02] * apachelogger giggles [15:05] <yofel> python needs to have at least one unicode bug per release, otherwise it's boring [15:05] * Riddell wraps wrap-and-sort around apachelogger and squeezes the breath out of him [15:06] * yofel puts marble-mobile on him to finish the work [15:07] <Riddell> shadeslayer: will you do a big announcement of kubuntu at akademy? [15:07] <yofel> apachelogger: maxy found something fun: [15:07] <yofel> debian/marble-mobile.install:usr/bin/marble-mobile [15:07] <yofel> debian/marble.install:usr/bin/marble-mobile [15:08] <apachelogger> someone forgot to remove it from install [15:08] * apachelogger hides [15:08] <apachelogger> yofel: nice catch [15:09] * apachelogger wonders why that can build [15:09] <shadeslayer> Riddell: need to co ordinate with akademy folks [15:09] <yofel> that'll build fine, it just won't install ^^ [15:09] <shadeslayer> I think the major stake holders are all there [15:09] <shadeslayer> so I can go ahead and book the room [15:09] <shadeslayer> FYI Anyone attending akademy / who wants to attend akademy https://notes.kde.org/p/kubuntu-akademy [15:10] <apachelogger> yofel: in what scenario would two packages want to have the exactly same file though [15:10] <apachelogger> my point is: things like that actually should cause a build failure [15:10] <yofel> can't really think of one that can't be solved by a -common package [15:11] <apachelogger> right, so it should fail :P [15:11] <yofel> although [15:11] <apachelogger> anyway, 30 lashes for apachelogger [15:11] <yofel> we did have that case I believe while double-building kde-workspace, at least when it comes to file paths [15:12] <yofel> I would appreciate a lintian warning though [15:14] <sgclark> err UnicodeDecodeError not sure where to go with this [15:15] <yofel> wait you too? -.- [15:15] <yofel> warrants a bug report I believe.. [15:15] <Riddell> you can just do wrap-and-sort -f debian/control [15:15] <Riddell> I don't think it cares about any other file does it? [15:16] <yofel> it runs over all files, at least when it comes to trimming [15:16] <yofel> esp. install file sorting is nice [15:16] <yofel> rules maybe not now that I think about it [15:17] <yofel> ok, checked the script, it runs over control[.in], copyright[.in], *.install [15:19] <shadeslayer> yofel: https://lists.ubuntu.com/archives/devel-permissions/2014-May/000673.html [15:19] <shadeslayer> Quintasan: ^^ [15:21] <sgclark> ok, well I narrowed it down to copyright being the problem file, The little copyright symbols [15:27] <Riddell> aah [15:27] <Riddell> you don't need those really [15:27] <Riddell> but then wrap-and-sort shouldn't crash because of them [15:28] * Riddell runs wrap-and-sort on all of kf5 packages [15:28] * Riddell starts a shadeslayer for MOTU campaign [15:29] <Riddell> shadeslayer: are you hanging out in the motu irc channel? on the mailing list? is there even much of motu alive these days? [15:29] <sgclark> still crashing [15:30] <shadeslayer> Riddell: yes, yes, dunno [15:30] <shadeslayer> last email on ubuntu-motu is from 3 days ago [15:31] <Riddell> sgclark: I just did wrap-and-sort -f debian/control [15:31] <Riddell> and then fancy bash loops for the .install file [15:35] <Quintasan> shadeslayer: I didn't write down anything there? [15:35] <Quintasan> wtf [15:35] <shadeslayer> Quintasan: no [15:35] <shadeslayer> bad Quintasan [15:36] <Riddell> uh oh, running wrap-and-sort on kunitconversion it deleted two of the packages [15:36] <sgclark> Riddell: ok, I am not versed in fancy bash loops. I did dind the other hiccups, names that have international chars [15:36] <sgclark> ack [15:38] <sgclark> so yofel: it seems wrap-and-sort only handles en_* ? that will certainly be an issue on copyright files... [15:38] <yofel> I never had it crash on me... [15:38] <sgclark> interesting [15:38] <yofel> but it indeed doesn't like kunitconversion o.O [15:39] <sgclark> is it maybe that I only have en_US install on my computer? [15:40] <Riddell> currently I have fr_GB on my computer, which might not help [15:41] <yofel> I usually only have en_US too, but I might also have de_DE [15:41] <sgclark> I am going to try and install some more languages, certainly won't hurt. [15:41] <yofel> FWIW, it can handle '©' fine here [15:43] <sgclark> interesting [15:46] <apachelogger> the locale does not matter, the encoding after the locale does [15:47] <apachelogger> to that extent it is entirely possible that fr_GB.UTF-8 for example could be discard as invalid locale and C could be used instead and I think with C you always get iso encoding regardless of what might be configured elsewhere [16:07] <yofel> apachelogger: there actually is a lintian warning for double install: [16:07] <yofel> W: marble source: binaries-have-file-conflict marble marble-mobile usr/bin/marble-mobile [16:08] * yofel makes his way home [16:09] <apachelogger> yofel: curious [16:14] <Quintasan> shadeslayer: There you go. [16:28] <sgclark> Riddell: Added Vcs entries and wrap-andsort on all but copyright. kfilemetadata5 is good to go. I will have to fight with my encoding later... [16:29] <shadeslayer> Quintasan: cheers [17:32] <shadeslayer> Riddell: yofel kdepim-runtime up too [17:33] <shadeslayer> and with that I'm off for the day [17:33] <shadeslayer> night === cyphermox_ is now known as cyphermox [19:45] <ovidiu-florin> valorie: sent you the invite [21:33] <kubotu> ::qt-bugs:: [1289600] Fix for crashes due to ubuntu-specific accessibility patch @ https://bugs.launchpad.net/bugs/1289600 (by Alexey Borzenkov) === kubotu_ is now known as kubotu === ubott2 is now known as ubottu === Mamarok_ is now known as Mamarok === valorie_ is now known as valorie === rdieter_laptop is now known as rdieter [23:32] <valorie> thank you ovidiu-florin [23:39] <dodger> so i think tearing prevention is currently broken [23:39] <dodger> it doesn't seem to want to vsync no matter what i do :P |