File size: 4,459 Bytes
4aa5fce |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 |
=== danilo_ is now known as danilos [12:28] <gary_poster> bac benji danilos (gmb is not here), call in 2 [12:28] <danilos> k [12:31] <bac> sorry i was late [12:52] <bac> hey gary_poster, can i ask you about https://code.launchpad.net/~nigelbabu/launchpad/ubuntu-font-787798/+merge/73793 , which is nigel's solution to the google ubuntu font but you filed [12:52] <gary_poster> bac, sure [12:52] <bac> is that reference to a non-https resource going to get us into trouble like the maps did? [12:53] <bac> we cannot use yahoo's CDN for the same reason [12:53] <gary_poster> bac, probably. [12:53] <bac> gary_poster: did you have another solution in mind? [12:53] <gary_poster> bac, https://fonts.googleapis.com/css?family=Ubuntu ? Seems to work [12:54] <bac> doh [14:08] <benji> I'm confused. Maybe someone can help me: I want to QA bug 810113, fixed in revision 13843 (as seen at https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html) but when I visit a URL on qastaging (that is at r13846 according to the footer at https://qastaging.launchpad.net/) which should not error out (https://api.qastaging.launchpad.net/1.0/checkbox?ws.op=1&ws.op=2) I still see an error. [14:08] <_mup_> Bug #810113: TypeError constructing page id: cannot concatenate 'str' and 'list' objects <oops> <qa-needstesting> <Launchpad itself:Fix Committed by benji> < https://launchpad.net/bugs/810113 > [14:22] <benji> danilos: if you have a second, I'd like your opinion on https://bugs.launchpad.net/launchpad/+bug/742662; I've come to the conclusion that the offending strings should be rejected at import time, but I want to be sure I'm not missing anything. [14:22] <_mup_> Bug #742662: Mixed new line markers causing OOPS while importing translations <oops> <rosetta-imports> <Launchpad itself:In Progress by benji> < https://launchpad.net/bugs/742662 > [14:30] <danilos> benji, sure, looking [14:30] <benji> k [14:33] <danilos> benji, yeah, you should just reject them with an error message (there's already similar stuff we do for other badly formatted messages) [14:33] <benji> danilos: cool; thanks for looking [14:37] <danilos> benji, lib/lp/translations/model/pofile.py seems to have code that was supposed to catch this already, not sure why it didn't :) [14:37] <benji> interesting, I'll check that out [14:38] <benji> danilos: in importFromQueue? [14:38] <danilos> benji, yep [14:41] * danilos -> out, enjoy the weekend folks [14:49] <gary_poster> bac, may I have a pre-mp-review? I don't love how the fact that I am using print, but I don't see what else to do. This is to get diagnostics for the seemingly spurious and intermittent error we are getting in buildbot. I plan to submit this as a testfix. http://pastebin.ubuntu.com/680615/ [14:50] * bac looks [14:50] <gary_poster> bac, this is an example of what it produces, fwiw: http://pastebin.ubuntu.com/680617/ [14:51] <gary_poster> that may not even be sufficient :-/ [14:51] <gary_poster> that bzr error in stdout does not give a traceback [14:52] <gary_poster> (from the forked server, which is what we need) [14:52] <gary_poster> at least it gives the command it used [14:52] <gary_poster> that might be sufficient to dupe [14:53] <bac> gary_poster: it looks ok to me if you're happy with it. desparate times... [14:53] <gary_poster> ok bac, thanks [15:42] * bac <- food [17:18] <gary_poster> I'm going to go get some food, and I'll be taking care of our baby daughter for a bit of a long lunch. I should be back around 3:00, I'll hope to talk to bac around 3:15 or 3:30, and benji soon after [17:18] <gary_poster> biab [17:18] <benji> sounds good [19:04] <bac> gary_poster: you still aiming for 3:15? [19:04] <gary_poster> yeah bac. OK for you? Can adjust [19:04] <bac> gary_poster: then is good. now is good. [19:05] <gary_poster> ok cool. 3:15 it is [19:05] <bac> cool [19:16] <bac> gary_poster: now? [19:16] <gary_poster> y [20:04] <gary_poster> benji, ready whenever you are. No rush, but gimme a call when you want. [20:04] <benji> gary_poster: I'm ready nowl calling. [20:14] <benji> gary_poster: https://api.qastaging.launchpad.net/1.0/checkbox?ws.op=1&ws.op=2 [20:14] <benji> gary_poster: https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html [20:22] <gary_poster> https://dev.launchpad.net/Foundations/Webservice/ClientSidePerformance?highlight=%28httplib2%29 [20:31] <gary_poster> https://lp-oops.canonical.com/oops/?oopsid=OOPS-2071QASTAGING11 |