fix challenge transformation error

dataset_infos.json

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:5106e12ea63eca19d85916c4f1db1f77695f281168355d147325338a6aa02d74
+oid sha256:715bfe00a48addd4d3f2b98bc45c018b1e9a49019de8fe9506bef514f506596a
 size 8821

train_val_test_split.py

@@ -233,18 +233,21 @@ def challenge_seen_unseen_transformation_split(pairs_by_transformation, training
     """
 
     # TODO transformations are hard-coded for now --> add argument in parser to specify them.
-    seen_transformations_ids = [1, 2, 3, 11, 13, 23, 31, 32, 33, 34, 37]
+    seen_transformations_ids = [1, 2, 3, 11, 13, 21, 23, 31, 33, 34, 37]
     unseen_transformations_ids = [12, 22, 32, 35, 36]
     
     train = []
     val = []
     seen_transformations_test = []
     unseen_transformations_test = []
-
+    total_samples= 0
+    for transf_id in unseen_transformations_ids:
+        total_samples += len(pairs_by_transformation[transf_id])
+    
     for transf_id in seen_transformations_ids:
         curr_len = len(pairs_by_transformation[transf_id])
         train_limit = int(curr_len * training_ratio)
-        val_limit = train_limit + int(curr_len * (1-training_ratio)/2.0)
+        val_limit = int(curr_len * (training_ratio + (1-training_ratio)/2.0))
         
         train += pairs_by_transformation[transf_id][:train_limit]
         val += pairs_by_transformation[transf_id][train_limit:val_limit]
@@ -254,7 +257,7 @@ def challenge_seen_unseen_transformation_split(pairs_by_transformation, training
     for transf_id in unseen_transformations_ids:
         unseen_transformations_test += pairs_by_transformation[transf_id]
 
-
+     
     return train, val, seen_transformations_test, unseen_transformations_test
 
 
@@ -315,6 +318,10 @@ def split(args):
 
     transformations_types = get_types(xml)
     pairs, pairs_by_transformation, pairs_by_source_dataset = get_pairs(xml, transformations_types)
+    
+    total_samples = 0 
+    for transf_id in pairs_by_transformation.keys():
+        total_samples += len(pairs_by_transformation[transf_id])
 
     if args.split_criteria == 'random':
         train, val, test = random_split(pairs, args.training_ratio)
@@ -325,7 +332,6 @@ def split(args):
 
     elif args.split_criteria == 'transformations':
         seen_transformations_train, seen_transformations_val, seen_transformations_test, unseen_transformations_test = challenge_seen_unseen_transformation_split(pairs_by_transformation, args.training_ratio)
-        
         os.makedirs(f'{args.out_dir}/{version}/transformations_split/', exist_ok=True)
         save_jsonl(seen_transformations_train, f'{args.out_dir}/{version}/transformations_split/train.jsonl')
         save_jsonl(seen_transformations_val, f'{args.out_dir}/{version}/transformations_split/val.jsonl')
@@ -351,7 +357,7 @@ if __name__ == '__main__':
     parser.add_argument('--data_path', type=str, required=True, help='path to (single) data file')
     parser.add_argument('--out_dir', type=str, required=True, help='output dir to store files')
 
-    parser.add_argument('--training_ratio', type=float, required=True, help='training ratio (e.g. 0.8). Remaining will be divided for val and test EQUALLY.')
+    parser.add_argument('--training_ratio', type=float, required=True, help='training ratio (e.g. 0.7). Remaining will be divided for val and test EQUALLY.')
 
     parser.add_argument('--split_criteria', type=str, required=True, choices=['random', 'transformations', 'source_dataset'], help='split criteria')