imranraad commited on
Commit
bfffd84
1 Parent(s): 1f842fb

Upload AutoTrain files

Browse files
Files changed (1) hide show
  1. raw/github-test.csv +722 -0
raw/github-test.csv ADDED
@@ -0,0 +1,722 @@
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
+ id,modified_comment,Anger,Love,Fear,Joy,Sadness,Surprise
2
+ 949058424,"Assuming this is not an issue any more. Please reopen, if this is still reproducible.",0,0,0,0,0,0
3
+ 121870320,I guess it's because when creating the module reasons the chunk graph is not created and `module._chunks` is null/empty.,0,0,0,0,0,0
4
+ 156956746,It's ok. You don't have to change it.,0,0,0,0,0,0
5
+ 644409171,"I didn't look at what it would take to remove this timeout/delay, but I did make it much smaller",0,0,0,0,0,0
6
+ 657568251,I've reverted this change since it's not needed anymore - this has gone back to being a debug static thing.,0,0,0,0,0,0
7
+ 660196149,"I agree it's odd, but I think the reason is that this test is fragile: it seems to look at the reloaded code, which includes the test code itself, so if I modify the test, it modifies the line numbers in this test.
8
+
9
+ So, adding seven lines at the top of this file altered these values by seven lines.",0,0,0,0,0,0
10
+ 664549743,Although I think it is probably good practice to always add `override` to all concrete methods that implement abstract base methods.,0,0,0,0,0,0
11
+ 679513242,I was mistaken! :sweat_smile:,0,0,0,0,0,0
12
+ 692307110,Yes it's absolutely the same test) You asked to add test with the action. So I decided to duplicate this one.,0,0,0,0,0,0
13
+ 721377123,`Array.from(filesPerGroup.values())` is an array of arrays. The `.concat()` is for flattening it :grin:,0,0,0,0,0,0
14
+ 724552743,"removed, so outdated now. New changes are also backward compatible",0,0,0,0,0,0
15
+ 912526425,"But we can't fix it here, because vue-cli should update dev server",0,0,0,0,0,0
16
+ 920382816,Closing because of inactivity. Feel free to report new issue with reproducible repo.,0,0,0,0,0,0
17
+ 944899238,The guidance we can provide its what we put in the error message; only the plugin's maintainer can update it.,0,0,0,0,0,0
18
+ 947358853,"[USER]
19
+ Have to wait a few years",0,0,0,0,0,0
20
+ 949081322,"I think I can say with a high degree of certainty that whatever is going on in [USER] example is unrelated. I removed all of the logic having to do with assignability to conditional types (i.e. both #30639 and this PR), and the example _still_ blows up with an instantiation depth error.",0,0,0,0,0,0
21
+ 949083272,"The excessive stack depth in react-hook-form happens during type parameter inference, but that's all I know right now.",0,0,0,0,0,0
22
+ 94292816,"Not just that; not wrapping would make the compiler very, very unhappy if there was more than one `let oldValue` inside the switch :) The scope block here is the switch itself; the `case` are just like `goto` labels. A similar trap exists with C.",0,0,0,0,0,0
23
+ 961310638,"[USER] or [USER] can you provide some more detail about the current and expected behavior? If you can, a small video or gif of what you expect to see vs what you are seeing?
24
+
25
+ I suspect that the reason here is not that the movement causes it to be ignored, but the timing: it might be interpreted as a long click if you hold the button down, and if there's no long click handler on the button then it does nothing.
26
+
27
+ If that's the case, we should probably investigate what should happen in that case so as to still allow long click detection, but send a regular click if there's no long click handler (which is how I _think_ it currently works, but I'm not sure).",0,0,0,0,0,0
28
+ 947450928,Pls Close. I figured that out already. Thank you,0,0,0,0,0,0
29
+ 94312015,Could you check if this method is used? I think it's unused and we can remove it...,0,0,0,0,0,0
30
+ 575636997,"[USER] I agree that this is `questionable`, I can remove support for object destructuring and leave only array destructuring. What do you think?",0,0,0,0,0,0
31
+ 939932146,No... Can you provide example?,0,0,0,0,0,0
32
+ 127892506,"It does, but the prototype is empty and concat is an immutable method so it's okay.",0,0,0,0,0,0
33
+ 943647545,"In any case, it's a bug that this one didn't work, right?
34
+
35
+ [TRIPLE QUOTE].",0,0,0,0,0,0
36
+ 533830991,This is how logger was designed way back so any change here would be breaking. (esp because msg is suppose to be public method),0,0,0,0,0,0
37
+ 109109706,"These two properties are not used in the webpack codebase itself, but may be used by plugins.
38
+
39
+ Don't remove them.",0,0,0,0,0,0
40
+ 176222755,No I don't have one. The purpose of these 2 alternatives is to have an object with a `null` prototype. Lookups on it would be faster since it doesn't require traversing the proto chain.,0,0,0,0,0,0
41
+ 176223360,"I have no issue with using the same format. The only reason I chose this format is that it happens to be the same that Firefox uses. Otherwise, there is no standard for this.",0,0,0,0,0,0
42
+ 460336981,"1. We want this to happen irrespective of augmenting that means any time we import the properties from object/function should be error so this might not happen at augmentation time.
43
+ 2. Will there be some kind of edge case where in valid scenario return globalfunctionType property symbol. That is what if getTypeOfSymbol(targetSymbol) is globalFunctionType or globalObjectType",0,0,0,0,0,0
44
+ 492276527,"As you can see below, this forces you to reparse. You already have the semantic structure, reuse that.",0,0,0,0,0,0
45
+ 536096487,"😏 Actually, it's the result of `bestDistance - 1` turned into `bestDistance`. `bestDistance - 1` can be replaced with `bestDistance - 0.1`, but it is very fragile since the minimum of distance could be changed to other values like `0.05` in the future.",0,0,0,0,0,0
46
+ 547236132,"Please do not touch logic, only types, otherwise it will not merged, I do mistake, it should be `{}`",0,0,0,0,0,0
47
+ 564892278,I dont think we should be doing this as part of program creation.. We should do it only if and when we need it as module resolution is costly,0,0,0,0,0,0
48
+ 628914206,No need to add a new parameter here. The `config` parameter already contains the `devDependencies` that you need.,0,0,0,0,0,0
49
+ 630618031,"No, it's easier to let the parser accept `async` like any other identifier, and just exclude the single incorrect case in the grammar checks in the checker. The parser would have to decide on a node to return in the error case, and if it *weren't* `Identifier` then the checker and emitter would have to handle that error case.",0,0,0,0,0,0
50
+ 655566860,"Can you add some documentation for these parameters above? I'm thinking line 2322 where this currently exists:
51
+ [TRIPLE QUOTE].",0,0,0,0,0,0
52
+ 667367169,Please put this below line 5 (together with the other non-app imports) :pray:,0,0,0,0,0,0
53
+ 669909132,All of the factory constructors should specify what features of the default FAB they are overriding.,0,0,0,0,0,0
54
+ 687187399,"That's fair, but at some level that's to be expected. There's never going to be a brief page that provides all the context, because there's too much context to be able to do it briefly. So we could mention that someone using Flutter will be able to provide the same experience for all versions of iOS, but then how about mentioning that on macOS desktop, we provide text field accessibility without using a private API, unlike Electron? There's so _many_ things that are worth mentioning that if you did mention them all, nobody would read it all, and so you'd guarantee some stuff would be missed anyway.",0,0,0,0,0,0
55
+ 687988964,"Agreed, this should be an error.",0,0,0,0,0,0
56
+ 688262169,"This isn't related to the name change, but I want to pull it over from [URL] as well.",0,0,0,0,0,0
57
+ 703928811,"I don’t think there’s a great way without restructuring a lot of calling code. If the node being checked is an `ImportClause`, it has to have a `name` in order to get to this function, or else it wouldn’t have been an alias at all (it would have been a side effect import like `import ""module""`). IOW, when `ImportClause` has a symbol, it is the alias represented by its `name`.",0,0,0,0,0,0
58
+ 721580107,"This isn't quite right: if `decoration!.labelStyle` resolves to null, then use the resolved value of `themeData.inputDecorationTheme.labelStyle`:
59
+
60
+ [TRIPLE QUOTE].",0,0,0,0,0,0
61
+ 878510515,I've never shared console logs is there a meaningful way of exporting it? or does the HAR log also have console logs?,0,0,0,0,0,0
62
+ 886811520,There is a Github Action demonstrating this issue at [URL],0,0,0,0,0,0
63
+ 888484641,"Or give the pipe some kind of output parameter which gets automatically passed back into the pipe transform function without any additional template syntax. The output parameter is added to the change detection tree, and when it gets modified, the transform is re-run.
64
+ I could go on but I feel like there are several plausible mechanisms with minimal / no impact outside of this specific use case.",0,0,0,0,0,0
65
+ 926237053,"Debatable, but IMO there’s nothing wrong with just showing the hint on every function.",0,0,0,0,0,0
66
+ 947062368,I'm waiting too...,0,0,0,0,0,0
67
+ 948646265,"I faced this problem too. In the Crashlytics log, I see such a trace, but it is not clear from it where the problem begins:
68
+ [TRIPLE QUOTE].
69
+ The application was created with Flutter 2.5.2.
70
+
71
+ It is likely that this is the same problem as here [URL]",0,0,0,0,0,0
72
+ 637253014,I'm sure there was a good reason not to allow extractions for functions which aren't declarations…,1,0,0,0,0,0
73
+ 946883350,"[BLOCK QUOTE].
74
+
75
+ [USER] Can't we setup a handshake protocol to determine channel availability? What happens if the application is waiting for a channel message but doesn't actually care to render a frame? I don't think we should use timeouts in this way ([or at all]([URL]).",1,0,0,0,0,0
76
+ 885281725,"I disagree, JIT/AOT doesn't make any difference here, it's the IVY / View Engine thing that is relevant. Just disable IVY in the demo and it will work: [URL] Moreover, I have not been given any workaround - how to make the code that was working with View Engine make to work with IVY?",1,0,0,0,0,0
77
+ 799457425,"No, those are actually different bugs (they hit different codepaths). Fixing one won't fix the other. That's why I've opened two issues. Also, they have quite different steps to reproduce.",1,0,0,0,0,0
78
+ 110512555,The callback doesn't make sense here.,1,0,0,0,0,0
79
+ 186760581,"[TRIPLE QUOTE].
80
+ This line is needless, because it overwritten bellow.",1,0,0,0,0,0
81
+ 919041736,"Bad idea to use `cjs.cjs`, there are another module with the same name",1,0,0,0,0,0
82
+ 197074254,This comment doesn't make sense here. It need to be before `const moduleFactory`,1,0,0,0,0,0
83
+ 804114113,"Sorry I can't merge this PR.
84
+
85
+ A while ago I merged a lot PRs adding unit tests, but it turned out that this was a big mistake.
86
+ Unit tests might be helpful while writing the code, but adding them afterwart has no benefit in my opinion.
87
+ They only make refactoring more difficult and doesn't find any new bugs.
88
+
89
+ That's also why we excluded unit tests from contributing to code coverage.
90
+
91
+ If you want to contribute to test coverage, please add integration tests instead.",1,0,0,0,0,0
92
+ 682947142,Bah. Wasn't supposed to add anything -- it was a debugging leftover...,1,0,0,0,0,0
93
+ 106782122,I don't think you need changes outside the BannerPlugin. Remove this line.,1,0,0,0,0,0
94
+ 193725456,Remove this comment. I don't think it make sense to have this on by default.,1,0,0,0,0,0
95
+ 453689942,"Make sense, but sounds terrible :smile:",1,0,0,0,0,0
96
+ 665721295,I don't think this paragraph is needed.,1,0,0,0,0,0
97
+ 671720449,the form is not really related to the list we want to animate,1,0,0,0,0,0
98
+ 690625447,Also this is incorrect.,1,0,0,0,0,0
99
+ 703851152,"Hmm, this one's a tough call. I feel like it should either be left the same or removed completely. If left the same, it shows that there are two ways to bind to `highlightColor` that are equivalent. This change makes it the same as the line above and I don't see any reason to have two lines that are showing the same thing.",1,0,0,0,0,0
100
+ 714377439,This isn't true anymore.,1,0,0,0,0,0
101
+ 724774445,"I don't understand the problem this PR is fixing.
102
+
103
+ I do not agree with changing `Android Studio` to `Android-Studio`.",1,0,0,0,0,0
104
+ 899917745,"I'm sorry [USER] I'm having trouble comprehending your example. In my eyes, it further demonstrates that the issue I described exists, i.e. `assertion(0, withArgs)` is illegal. I understand that resolving `In` and `Out` is undecidable (because it recurses infinitely), however, my claim here is that at least the tuple/overload assignment _should be legal_, because both functions may be called only with an equivalent set of arguments. In other words:
105
+ [TRIPLE QUOTE].",1,0,0,0,0,0
106
+ 940092072,"[BLOCK QUOTE].
107
+ Uh... no it's not? Nor is it a bug. It's just an error you didn't expect.",1,0,0,0,0,0
108
+ 797078303,"Guys, I'm very confused by this situation, documentation, examples and workarounds. I'm on Webpack 5.
109
+ I do appreciate work that Webpack team does and would happily donate money if somebody could put clarity in this.
110
+ It is so frustrating that I'm happy to pay just to get an answer.
111
+ There is [example]([URL]) of how Webpack can understand that we are importing a worker .
112
+ That helps us to not create a separate entry point - ok. But it doesn't demonstrate how worker and not worker would share module from a separate chunk. It looks like webpack 5 can't do that, correct? Is there a suggested way on how to do that?
113
+ In the example [URL] we have `chat-worker` which imports history from `chat-module`, while `example.js` creates a worker from `chat-worker`. The resulted bundle is 2 files 'main.js' and 'chat.js': [URL]
114
+ but there is no code shared between chat-worker.js and example.js!
115
+ _fibonacci is kind of the same case..._ Lets add import of `chat-module` into the `example.js` like this:
116
+
117
+ [TRIPLE QUOTE]
118
+
119
+ And result of such bundle is this: [URL]
120
+
121
+ `chat-module.js` appears twice in our bundle: inside `main.js` and inside `chat.js`.
122
+ So please can somebody give a clear answer on how can I get the result like this:
123
+ - `main.js` imports `chat-module.js` from a chunk like `chat-module-chunk.js`
124
+ - `chat-worker.js` imports `chat-module.js` from a chunk like `chat-module-chunk.js`
125
+ - `main.js` uses `chat-worker.js` and staff works :)
126
+ Now imagine a situation when `main.js` imports 5 different modules including soething from npm, while worker.js includes 5 of the same modules. What is the webpack.config.js magic should be written to put those 5 modules in one single chunk? Not all of those modules are from npm, some from my project, they are from different folders. All my attempts of chunk splitting optimization don't produce workable app. Right now I have to live with chunks which has huge portion of module duplicates because worker imports bunch of staff and the main app imports same staff.
127
+ Do I have to change all imports to dynamic? Do I need to do that only in the worker or I have to do that in both places? and after ask webpack to split only async chunks?
128
+ Which functions should I use for that? How I should direct webpack to produce particular modules I want into a single chunk?
129
+ **Update**
130
+ From my current understanding webpack would figure out chunks automatically only if we import same modules dynamically:
131
+ `const { fibonacci } = await import(""./fibonacci"")`
132
+ If we do so in the worker and in the main app, fibonacci module would be in a separate file.
133
+ Is that correct?
134
+ But why do we have to do that not only in the worker but also in the main app? Why can't we do `await import()` in the worker while have static `import` in the main app and webpack would understand that?",1,0,0,0,0,0
135
+ 730153701,"From what I've seen so far in our codebase, other node properties that are there for error reporting only just have a comment saying so 😕",1,0,0,0,0,0
136
+ 947059519,"Any updates on this? I'm implementing a flutter application with barcode scanners, the soft keyboard on screen is really annoying.",1,0,0,0,0,0
137
+ 950524355,"Any news? The workaround ebove do not work.
138
+
139
+ [TRIPLE QUOTE].
140
+ Is this a snap related issue?
141
+
142
+ Doctor said:
143
+ [TRIPLE QUOTE].",1,0,0,0,0,0
144
+ 945084673,"[BLOCK QUOTE].
145
+ same problem here
146
+ @ubitechdevelopers did you solve it?",1,0,0,0,0,0
147
+ 650628959,question: is this the correct approach (will it ever be '')?,1,0,0,0,0,0
148
+ 913812877,What does this do with Angular? You should ask this on stackoverflow.com,1,0,0,0,0,0
149
+ 878130590,[USER] Please provide reproducible example,1,0,0,0,0,0
150
+ 846407390,"No bugs here again, you have overlapping in rules, so it works as expected",1,0,0,0,0,0
151
+ 859716530,"As suspected, you didn't follow the specific recommendation [here]([URL]).
152
+ This issue is about [`compiler.intermediateFileSystem = memoryFs`]([URL]).
153
+ not [working expectedly]([URL]).",1,0,0,0,0,0
154
+ 912236348,"I am not saying Yarn 2 is bad. If you zoom out a little bit, then it is so hard to know which trend to follow and which one to ignore.
155
+
156
+ Let's imagine, the TypeScript team adds a flag to support YarnPnP. Then another tool comes and makes the same argument (the we are better or faster) and then TypeScript cannot say no, as they have already committed in the direction of adding flags.
157
+
158
+ I have seen this trend a lot less in other more mature ecosystems in comparison to JavaScript
159
+
160
+ ---
161
+
162
+ Also, the arguments should not be considered against something or someone. Yarn is a fantastic tool, created by great people. I am just talking about the idea of adding flags in general",1,0,0,0,0,0
163
+ 566522096,"This change is pretty much single-handedly responsible for the .js emit changes in this PR. `Symbol.iterator` and it's ilk aren't ""simple copyable expressions"" since, technically, accessing it could produce side effects (like any other property access). Now... at some point, we added `Identifier`s to `isSimpleCopiableExpression`'s domain (which isn't technically safe, since the identifier may get reassigned between the copied references), so maybe property accesses which only consist of `Identifier`s wouldn't be terribly unreasonable, either. 🤷",1,0,0,0,0,0
164
+ 622074335,Does this file really belong to this PR? It seems unrelated 😕,1,0,0,0,0,0
165
+ 953632693,"Hi [USER] this isn't a flutter framework issue, kindly file the issue here: [URL]
166
+
167
+ Closing this as it is not a flutter issue.",1,0,0,0,0,0
168
+ 955116781,"I should add that the reason this is so annoying is the cascading effect of telling me to install tslib and then warning me about settings when I'm trying to get other work done. And then adding injury by not giving me a ""click on this to avoid this message"" button with it all seeming to be tsc related. A very bad UX.",1,0,0,0,0,0
169
+ 957359634,"Issues with third-party plugins need to be reported to their developers.
170
+
171
+ You should verify with the developers that the Firebase background handler is designed to allow calling plugin methods (e.g., isn't using an isolate).",1,0,0,0,0,0
172
+ 899885864,"To expedite the triage process, we need everyone to follow the issue template and instructions.
173
+ When you clicked ""Create New Issue"", the issue form was pre-populated with a template and some instructions. We need you to read those instructions *completely*, follow them, and then fill in *all* the fields in that template.
174
+ We are not able to assist with issues that don't follow the template instructions as they represent a significantly larger amount of work compared to issues which are correctly specified. Thank you for understanding.",1,0,0,0,0,0
175
+ 683687420,"takeover => dispose
176
+
177
+ I understand what you mean by ""takeover"" however it doesn't hurt to be a little more explicit",1,0,0,0,0,0
178
+ 949447861,"[USER]
179
+ Please don't open issue using an issue comment from other issues. If you are facing an issue, please use `new issue` [template]([URL] and provide atleast some of the information asked in it, so that we can properly address the issue.
180
+ Closing from here, as no information is provided.",1,0,0,0,0,0
181
+ 628258049,I blame the autoformatter.,1,0,0,0,0,0
182
+ 958395369,"Yes. We need to add this test coverage. It's just not ""urgent"". 😐",1,0,0,0,0,0
183
+ 132025439,And here dumb template literal,1,0,0,0,0,0
184
+ 778164465,"No need to like it, because the problem on your side, you emit two files (as you can see in the error), it can lead to the problems, but you ignore our issue template so I can't help you, respect time of other developers. The problem can be in a plugin or a loader. The problem can be with invalid usage of assets modules, maybe you real do multiple request which have different casing. Nobody knows.
185
+
186
+ If you provide how you can reproduce your problem I will show your the problem place and how to fix it.",1,0,0,0,0,0
187
+ 797587283,Bug without example I can't help,1,0,0,0,0,0
188
+ 821852912,"oh my god, explanation of official documents waste eight hours of me, Why isn't there a case to explain this",1,0,0,0,0,0
189
+ 875342986,"Sorry, but this is really dumb. Why would developers want BOM in the middle
190
+ of their output when it makes the Javascript unparsable and therefore
191
+ unusable.
192
+ BOM only makes sense as the first few bytes of a file as stored on disk. It
193
+ never makes sense to include BOM in the middle of a file.
194
+ This is utter nonsense. If you just don't want to fix it, then just say
195
+ that you don't want to fix it. Making up some bogus excuse just makes you
196
+ look stupid.
197
+ On Mon, Jun 28, 2021 at 3:49 AM Alexander Akait ***@***.***>
198
+ wrote:
199
+ [BLOCK QUOTE].",1,0,0,0,0,0
200
+ 878132440,"Please respect time of other developers, we don't know your version/code/configuration/etc, so it is impossible to help",1,0,0,0,0,0
201
+ 880855658,"I don't know why it is hard to use the issue template and provide example how we can reproduce, this will not only make your life easier, but also reduce the time spent trying to guess, and will also save your nerves",1,0,0,0,0,0
202
+ 883197139,"Well, if you tried it you'd know.",1,0,0,0,0,0
203
+ 898442054,"Same problem with the same plugin, it is related",1,0,0,0,0,0
204
+ 911494409,"Not sure I understood your answer, much less the reason why you closed this so abruptly.
205
+
206
+ Would you please elaborate.",1,0,0,0,0,0
207
+ 918861933,"[BLOCK QUOTE].
208
+ I am sorry but this is a rubbish reason. Typescript includes features like private constructors, yet you say that the complexity of different getters/setters is too high and steepens the learning curve. Like somebody mentioned here, `it is hard to make` should not be an argument against a standard in most modern programming languages. Your suggestion to use private/protected is not really helpful either - it makes the code less readable and it adds complexity to it.",1,0,0,0,0,0
209
+ 922011519,"Hi, thanks for your contribution, but we can't review this because you didn’t follow the contributing instructions in [CONTRIBUTING.md]([URL] or in the PR template:
210
+ [BLOCK QUOTE].",1,0,0,0,0,0
211
+ 927812911,"[URL]
212
+ You know better than not to fill out the issue template. 🤨",1,0,0,0,0,0
213
+ 945179472,It's anoying me specifically when I want to set it as default value in constructors,1,0,0,0,0,0
214
+ 945921257,"Please see flutter.dev/community for pointers to other resources intended for general discussion.
215
+
216
+ Closing as this is neither a bug report nor feature request for Flutter.",1,0,0,0,0,0
217
+ 949609573,[USER] Please provide a complete minimal reproducible code sample that we can directly use or a sample github repo that we can clone.,1,0,0,0,0,0
218
+ 954708465,"[USER] In that case I would advise you to please file a separate issue with the exact steps and logs to reproduce the issue. Because this issue is about existing apps.
219
+
220
+ Thanks",1,0,0,0,0,0
221
+ 957190414,"Hi [USER]
222
+ I noticed you used Provider plugin in the sample code. For the issue to be workable, it needs to be reproducible with a [minimal complete reproducible code sample]([URL] that doesn’t include 3rd party plugins or complex production code and is properly formatted. Please provide such sample.
223
+ Thank you",1,0,0,0,0,0
224
+ 850856016,But this doesn't make sense you actually importing same module dynamically twice in two different javascript files.,1,0,0,0,0,0
225
+ 878627732,I added that and re-served the app but still having the same issue.,1,0,0,0,0,0
226
+ 379862876,😡. Introduced issue thanks to merge conflicts. Will fix...,1,0,0,0,0,0
227
+ 934124997,Brilliant arguments but I’m afraid nobody is listening. What would it take to bring this to TS team attention again? a petition of some sort?,1,0,0,0,0,0
228
+ 932785917,"This is not the first issue where all this extension thing is causing confusion. One was already been shutdown by Microsoft [URL]
229
+ The best part is, out of ignorance the Typescript team thinks its them only who knows better and everyone else is stupid.
230
+ This will blow up as more people will start moving to ESM.",1,0,0,0,0,0
231
+ 943471475,Could you please share a minimum reproduction?,1,0,0,0,0,0
232
+ 929008257,[USER] can you provide an example?,1,0,0,0,0,0
233
+ 956549938,"I see [USER] that is too bad, thank you very much for the update and for running the presubmit If I can help in any way please let me know :slightly_smiling_face:",0,1,0,0,0,0
234
+ 895676714,"my bad, didn't look through closed ones.
235
+ thanks for the explanation.",0,1,0,0,0,0
236
+ 717804258,"This is a nice way to wrap up this logic, and good explanation in the comment above 👍",0,1,0,0,0,0
237
+ 946629864,"[USER] thanks a lot, that was indeed the problem. Onboarding as a first-time contributor wannabe is apparently not as trivial as expected...",0,1,0,0,0,0
238
+ 857551496,"The solution via dependencies seems to work! I tried it with yarn within a yarn workspace environment and I did not experience any issues yet. So I see this issue as resolved. Thanks a lot again [USER] , your explanation was very helpful!",0,1,0,0,0,0
239
+ 898477405,"[USER] great point! Thank you. You are right that the testing components today rely on JIT. Usually not because they are dynamic but because you need the flexibility to declare them inline, usually within functions of a test file as your example shows.
240
+
241
+ With the right compiler and API modifications we should be able to support this with AOT (thanks to Ivy). This change could be rolled out with an automated migration so nobody has to rewrite their tests.
242
+
243
+ But as you bring up, this flexibility of testing components means that you could dynamically create a template or modify the component metadata (e.g. use string concat and interpolation to create a unique template for a bunch of components created within a loop that wraps an `it` or `describe`.
244
+
245
+ This is not the most common pattern but I'd be shocked if some codebases didn't rely on it. I currently don't have a solution for this one. Maybe the composition api could be it, but automated migration from unconstrained TS/JS code that generates a component to a component built using the composition API would be tricky and not 100% reliable.
246
+
247
+ I do appreciate bringing this up though. This is exactly the kind of feedback we are looking for.",0,1,0,0,0,0
248
+ 696173961,"I'm updating the docs to be more precise and getting rid of the macro, thanks for the suggestion.",0,1,0,0,0,0
249
+ 881739711,"yes, jenkins build is successful. thanks for your hard work!",0,1,0,0,0,0
250
+ 909634074,"[USER] thanks so very much for the approval :smile:
251
+ if possible I would love it if [USER] could also have another look if possible as he did help a lot in this PR and also I believe he hasn't checked out some of the latest fixes I made :slightly_smiling_face: ( George, if you're just sick of this PR that's fine too, it has been going for a bit :sweat_smile: )",0,1,0,0,0,0
252
+ 918961066,"[USER] This looks promising. I'll try it out, thank you!",0,1,0,0,0,0
253
+ 902198425,If it's unclear what the benefits are then I think closing the PR is the right thing to do at this time. Thanks again for looking into this though! Your contributions have been tremendous 💯,0,1,0,0,0,0
254
+ 864954763,"No worries, thanks for this!",0,1,0,0,0,0
255
+ 218156913,"Right, I didn't, as this was originally just a config change :smile:
256
+ Thanks for the guidance, will fix.",0,1,0,0,0,0
257
+ 880169397,"PS: I am fan of yours, I love your content out there! :smiley:",0,1,0,0,0,0
258
+ 883528050,"And, just confirmed it is totally fixed, wow, thank you [USER]",0,1,0,0,0,0
259
+ 943294122,"That seems to have fixed the problem, thanks!",0,1,0,0,0,0
260
+ 924299099,I liked this suggestion. I think the philosophy of language shouldn't be that uncompromising. We already have `enum` and `namespace` that are outside the rule.,0,1,0,0,0,0
261
+ 881607953,"thanks very much! take care, have a nice weekend!",0,1,0,0,0,0
262
+ 915346747,Awesome! Thank you two for the code review and triaging my first PR!,0,1,0,0,0,0
263
+ 713915307,Aw thank you so much! I really appreciate that insightful explanation 😄 I now better understand what `assumeTrue` means. Super helpful !!,0,1,0,0,0,0
264
+ 926764796,Thanks for your contribution.,0,1,0,0,0,0
265
+ 956332608,"Thanks so much, this works great 🤗",0,1,0,0,0,0
266
+ 676965014,"awesome, I will do that then! thanks a lot! :slightly_smiling_face:",0,1,0,0,0,0
267
+ 692888395,:man_facepalming: thanks for noticing this,0,1,0,0,0,0
268
+ 879458308,Just updated the guide. Thanks for the catch!,0,1,0,0,0,0
269
+ 880939197,Thanks! And thank you for taking time to think about this stuff. It is important that we try our best to get it right.,0,1,0,0,0,0
270
+ 906880454,"I didn't know about this, thanks for the help!",0,1,0,0,0,0
271
+ 924292403,"Oh ok. Thanks for the explanation. I see that now. I had imagined that if you imported `foo`, you would always transform. If you don't want the extension, don't import. That makes it very straight forward.",0,1,0,0,0,0
272
+ 940078319,"Thanks for the tip, [USER] - indeed, it does!
273
+
274
+ I'm still missing the tabular view as shown [here]([URL] though!",0,1,0,0,0,0
275
+ 952994083,🎉 thank you [USER] for your determination and brilliance in finding a resolution to this really really annoying issue.,0,1,0,0,0,0
276
+ 956680842,"Wow, thanks [USER] For us that reads ThemeData a lot this is really useful and nice! 💙",0,1,0,0,0,0
277
+ 648733907,"Awesome! This looks good. Is there a test validating this? There should be a test that verifies we don't end up duplicating a currently showing snackbar when we push a banner, and vice versa in order to validate this logic and make sure we don't regress later. I think once we have that, this is ready to land! 🎉",0,1,0,0,0,0
278
+ 890880185,"You really don't need to apologize, [USER] You are doing an amazing job tackling non-trivial problems all over the place 🏋️
279
+
280
+ ##
281
+ Regarding the `legacy-unit-tests-saucelabs` job failure: It looks like a flake. I have restarted the job, but don't worry about it for now.",0,1,0,0,0,0
282
+ 892774210,"God, I really need this feature!",0,1,0,0,0,0
283
+ 714377866,It would be nice if one could vary the iconTheme or labelTextStyle based on MaterialState.hovered. It would be OK to leave that out of this PR though.,0,1,0,0,0,0
284
+ 741519830,"It would be nice if color and colorScheme were colorScheme.primary and colorScheme.primaryVariant. We want to encourage developers to use the color scheme.
285
+
286
+ If this function was defined within the build method, you could refer to two additional local color variables that were based on the colorScheme (like odd,evenItemColor).",0,1,0,0,0,0
287
+ 872256203,"Is there any news on this? I think this is highly relevant for component-based architecture with inputs which can arrive and change at any time. In my case it's almost always to trigger some api call once all input values are present and then whenever either one changes.
288
+
289
+ My solution is to use two or more local `BehaviorSubjects` and a `combineLatest` to accomplish this behavior.
290
+ `BehaviorSubject` for use cases where I need to access its current value synchronously, otherwise a `ReplaySubject(1)` is also fine.
291
+
292
+ [TRIPLE QUOTE].
293
+
294
+ [TRIPLE QUOTE].",0,1,0,0,0,0
295
+ 730397911,We should also have tests with multiple occurrences of different comments to ensure that all of them are removed.,0,1,0,0,0,0
296
+ 732078161,"would be good to have more information here, e.g. mentioning the argument that you're adding to make these fatal, what kind of thing could be a warning vs just ordinary output, how rare warnings should be, etc.",0,1,0,0,0,0
297
+ 929770672,"This would be so incredibly helpful. I'm currently running into an issue where there are collisions from a 3rd-party library, but it's not coming from my code so I have to figure out where the collision is coming from. Seeing file names and paths would be awesome!",0,1,0,0,0,0
298
+ 886116181,Would love to have more documentation on this. Especially handling runtime localization and about building libraries with translations.,0,1,0,0,0,0
299
+ 103427515,"I am afraid that it is not possible, since we are using `=>` here the context will change. Either to remove `arrow` or to refer it via `another const/variable`",0,0,1,0,0,0
300
+ 600737153,"Hm...I just realized that currently we don't support linenums when skipping prettify 😱
301
+ I think it is fine for now. Maybe log a warning if `getLinenums()` returns anything other than `false` with `language: 'none'`. (In the future, if the need arises, we can add support for linenums.)",0,0,1,0,0,0
302
+ 946417006,"My guess is no, since implementing such a feature can compromise the security of your app and also it could lead to your app being rejected from the store.
303
+
304
+ You might think it's a good idea to implement it so it can be used for development, however, since this is a `work-around` you will not control, it'll be easy to forget about it which may lead to your app being rejected. ",0,0,1,0,0,0
305
+ 478686004,"I have some fears that this won't catch stuff like
306
+ [TRIPLE QUOTE].",0,0,1,0,0,0
307
+ 904025085,"[BLOCK QUOTE].
308
+ Am I missing something here? How could this possibly return `-1`?",0,0,1,0,0,0
309
+ 710107177,"And yes, there should be tests 😱 😱 😱",0,0,1,0,0,0
310
+ 904946264,"Thanks! Now if you don’t mind, can you restate your actual behavior and expected behavior in terms of the file names and identifiers used in that repro? I had a little trouble following your hypothetical example.",0,0,1,0,0,0
311
+ 717953293,"I worry about an over-reliance on Actions and Intents when I see ReplaceTextIntent, UpdateSelectionIntent, etc. used here. Is there a use case for needing those things to be overridable?
312
+
313
+ What I'm worried about is the increased mental load that a developer working on this part of the codebase has to bear:
314
+
315
+ 1. I can't be certain who will respond to this Intent, or even whether or not the EditableTextState will receive it, without knowing what overriders are in the widget tree.
316
+ 2. These Intents can be invoked from anywhere with the relevant BuildContext.
317
+
318
+ Do these two features benefit this code in any way?",0,0,1,0,0,0
319
+ 933720391,"[USER] Yes, with `immediate` covering the _used before assigned_ error, it makes more sense. My concern was whether `immediate` would not cover these scenarios.",0,0,1,0,0,0
320
+ 948345405,"Please correct me if I'm wrong – you are using something like [URL] to embed Flutter as a module. In your test, you have a script or something to set up the app and transition to the Flutter screen, after which you want to have code on the host connect to and run the integration test.
321
+
322
+ It's not possible to do so without some elaborate hacks. Integration Tests require test code to be built *into* the app under test. It sounds what you could do is create a placeholder Flutter app that hosts the flutter module that you're using, with some mocks to setup the app into a state suitable for testing. Otherwise, you're advised to look for something like [URL] to test the complete flow.",0,0,1,0,0,0
323
+ 664541822,"So this is a little bit worrying. By making this abstract, the `noImplicitOverride` seems to have no effect on the method in the child class, which sort of defeats the purpose of this compiler setting right? I.e. if the base class removed the abstract method, there would be no indication to update the child class.",0,0,1,0,0,0
324
+ 640916222,My concern was about how we will have non-generated files which import the generated file. And I am worried that its going to make intellisense go crazy,0,0,1,0,0,0
325
+ 783788386,If your analysis is correct [USER] then it's breaking any app using SRI and long-term caching (regardless of whether it's using our plugin or some other way to add SRI) so there's little we can do about it...,0,0,1,0,0,0
326
+ 637164426,"Little concerned about adding and removing watches here.. since this cache is cleared between the open files it seems like we may need to create and remove and again create same kinds of watches over and over.. if there are no watches for that directory .. eg there are no closed script infos for that node_modules folder in any program or something, this may be costly on linux where every recursive directory watching needs to go traverse the directory and create watches since there is no native recurisve watching support...",0,0,1,0,0,0
327
+ 680372454,Isn't this a breaking change? Can we get away with it?,0,0,1,0,0,0
328
+ 717880432,I guess my concern is that it sets a precedent where somebody could see it and think that it would be fine to use in `core`.,0,0,1,0,0,0
329
+ 738589623,[URL] it looks like a legitimate failure,0,0,1,0,0,0
330
+ 900413308,I'm still a little concerned that this is basically a one-time warning that can easily be missed by people when they're running the automated migration.,0,0,1,0,0,0
331
+ 912926657,My concern is that more new arrtibutes may appear in html in the future which potentially may overlap with input names on your already existing components and it may break their behavior.,0,0,1,0,0,0
332
+ 812613958,"You should not apply `ModuleConcatenationPlugin` plugin directly, you need use `optimization` options, double usage `ModuleConcatenationPlugin` can break code",0,0,1,0,0,0
333
+ 954581042,It should mean that it would have rejected the existing dill files and just started over from scratch. If not we would have to fix that.,0,0,1,0,0,0
334
+ 958138694,"I am seeing this failure [URL] which looks like a timeout, but I don't have any idea how to go about trying to diagnose that?
335
+
336
+ It appears to be timing out on a `flutter pub get` in the [android_intent]([URL] package?",0,0,1,0,0,0
337
+ 932519103,"FWIW I’ve always wanted this feature, but I’m not confident that a PR would get accepted and I would hate to see you burned by infinite bikeshedding as a first time contributor. If this feature is your passion, don’t let me stop you from implementing it, but be prepared that a PR for an “awaiting more feedback” issue may or may not ever get a proper review. If you are just looking to start contributing to TS anywhere, I would encourage you to search for “help wanted” and “good first issue” labels, where you’re much more likely to get support with a PR from start to finish.",0,0,1,0,0,0
338
+ 707599450,Is this widget really providing enough value to break it out as a building block?,0,0,1,0,0,0
339
+ 159127019,"I'm having a hard time doing this... Since previous methods were highly dynamic, I'm afraid of breaking anything...",0,0,1,0,0,0
340
+ 492221701,This one looks a little weird (there are some others like it in other tests too) 🤔,0,0,1,0,0,0
341
+ 506962928,"Hi sokra and pastak,
342
+ I also encountered this problem. Are you going to fix it soon?",0,0,1,0,0,0
343
+ 533012084,"I'm worried about the precision of 0.0000001. It's probably enough to make it 0.01, since that's smaller than 0.1.",0,0,1,0,0,0
344
+ 640182714,do you have to use `any`? it's always concerning when we give up on type safety and add new anys to the code base.,0,0,1,0,0,0
345
+ 643425611,"Specifically, I'm less confident in the second commit than the first. AFAICT, it could only return true if a recursive call to itself returned true and all of the recursive base cases returned false.",0,0,1,0,0,0
346
+ 670010894,"I don’t think this is a sufficient condition. This is a really weird case, because there actually is no symbol for `import.meta`, but because completions works with symbols, it creates a dummy symbol for it on line 1593 (and presumably the same crash happens with `new.target`). The least we can do is keep this kludge private to `completions.ts` and not ask the checker for the type of a completely made-up symbol with literally no context. The checker knows how to get the proper type for `import.meta` and `new.target` from a _node_, so I would suggest making `completions.ts` somehow aware that it needs to use a different method to get the type of these, and able to trace these dummy symbols back to the nodes they came from.",0,0,1,0,0,0
347
+ 878523587,"Hmm, that does not reveal anything useful I'm afraid. I'm a bit out of ideas but you may want to try adding `pathMatch: 'full'` to the empty route in the lazy module.",0,0,1,0,0,0
348
+ 901297945,"There are two separable concerns here:
349
+ * Is *syntactically unreachable* code -- code which we can be certain cannot execute -- allowed? That is the only thing that `allowUnreachableCode` speaks to
350
+ * What should be done with *type unreachable* code -- code which the type system believes will not execute? That is the realm of `assertNever`
351
+ Keeping these concepts separate, rather than conflating them, is the simpler design.",0,0,1,0,0,0
352
+ 928049597,[USER] Not that I know of. Still an open bug for my team,0,0,1,0,0,0
353
+ 950371551,"Yeah, that isn't right. The issue here is that we bypass caching of relations for small unions and intersections, but that bypass also causes us to loose a check for deeply nested types that would have stopped the recursion. It used to not matter, but after #41821 it does. We need to revise our logic such that we can bypass caching but still check for deep nesting.",0,0,1,0,0,0
354
+ 953479661,"[BLOCK QUOTE].
355
+
356
+ This problem is still happened on macOS Monterey 12.0.1",0,0,1,0,0,0
357
+ 957201597,"It is really bad at maintaining a decent frame rate.
358
+ This optimization would likely not help a lot, but could help some. [USER] may still have traces",0,0,1,0,0,0
359
+ 539150037,"Also a breaking change, right?",0,0,1,0,0,0
360
+ 350689381,"I'm not saying we don't want to enable this kind of thing, I'm just saying we have little interest in one-off PnP-specific things, when a more complete approach would render it redundant and allow for more use cases to be filled, and that this model, specifically, follows a pattern that we don't consider particularly usable (we should know, it is similar in setup to our existing ""language service plugin"" architecture that doesn't layer plugins easily, isn't easy to develop for, isn't particularly easy to use, isn't (well) documented, and and was rushed out to support a high pressure request from angular). We've had requests for custom resolver behavior for approximately forever, and would like to do right by those, and _not_ repeat the mistakes we've already made in a different context.",1,0,1,0,0,0
361
+ 954717019,"I myself also think that decoupling the material and also the cupertino library from the flutter framework would be a major benefit for the whole ecosystem. All the libraries get more and more complex just to support legacy m2 styling.. Also things like the m2 snackbar styling are still opt in because of that.
362
+
363
+ It currently is quite painful to create a new flutter app, that uses all widgets in its modern styling, as you have to opt into so many things. And also having to fight with all the old m1 properties and major inconsistencies everywhere.
364
+
365
+ I think having a material library, that is versioned independent from flutter, enabling developers to update the flutter version of old maintenance projects without the need to handle breaking changes in the material library, would be a major benefit for everyone, as it not only would make the life of each maintainer much more easy, as breaking changes do happen over time, but also making the life of everyone else, who wants to have the modern styling so much easier, as the material library package could just have breaking changes following semver etc.
366
+
367
+ Altogether I would say, especially if we are trying to think long term, the benefits outweigh the costs by far.
368
+ So I would very much recommend to fix this rather soon then late, so that we don't have the same conversation again when materail4 arrives :)",0,0,0,1,0,0
369
+ 665593171,"Nice, this is more slick 👍",0,0,0,1,0,0
370
+ 738670144,"The are allowed as identifiers and they're wonderfully short and clear, but OK.",0,0,0,1,0,0
371
+ 730474399,"Ahhh, yeah I see what you did there :thinking:
372
+ Ok thanks a lot :smiley::+1:",0,0,0,1,0,0
373
+ 161936074,I agree it is too much. I was trying to satisfy all the variations in the related issues that came up. I'll trim it down.,0,0,0,1,0,0
374
+ 677613305,"Bad link 🤦 , here's the correct link [URL]
375
+
376
+ And yes, I think you're right. The linked test should go to expression completion because it's an `EmptyExpression`, and this test should go to literal completion (i believe 🤞 ). We should keep both tests since they cover a different use case.",0,0,0,1,0,0
377
+ 538857413,Yes I think this makes sense. We currently don't use the top level symbol name at all,0,0,0,1,0,0
378
+ 704774129,"I think we are in agreement.
379
+ The doc author should be able to rely on a SME or the tech review (TR) stage to ensure the code example is accurate for the placement in the docs.",0,0,0,1,0,0
380
+ 894777854,I fully agree with [USER] and I think we should try to focus on the actual proposal which I agree would be really nice to have.,0,0,0,1,0,0
381
+ 634161745,"Yeah, that would sound the most reasonable to me.",0,0,0,1,0,0
382
+ 680622885,"Yes, you are right, I moved the code to comments.",0,0,0,1,0,0
383
+ 699641154,"Good point, I'm ok keeping it like it's currently implemented. Since it's a part of the testing logic, it has no impact on bundle size, so this optimization is not important.",0,0,0,1,0,0
384
+ 94509951,Yeah. It feels a bit awkward but if it's okay we can :shipit:,0,0,0,1,0,0
385
+ 163492136,"hmm.. yes, I only moved the code. When this code was written I considered unset module.type for backward-compatibility.",0,0,0,1,0,0
386
+ 443773547,"Yeah, I agree! Moving",0,0,0,1,0,0
387
+ 540571706,"Sorry, you answered that in the other location—36s to 10s 👍",0,0,0,1,0,0
388
+ 563925168,"Yes, I think this is a good change, because it's preserving the parent indent.",0,0,0,1,0,0
389
+ 678659480,Good catch! Removed.,0,0,0,1,0,0
390
+ 698673323,Agreed. I cleaned this up a bit and added some comments.,0,0,0,1,0,0
391
+ 948278997,Thanks for creating #89045 and #91981! We'd be happy to merge either of these PRs if the comments there have been addressed.,0,0,0,1,0,0
392
+ 181573636,"Anyway, the syntax change is fine.",0,0,0,1,0,0
393
+ 184104073,"Absolutely. But since it is the only case where it does not return a string, it is possible to bypass the call and hardcode the result.",0,0,0,1,0,0
394
+ 722511641,"[BLOCK QUOTE].
395
+
396
+ That sounds like a great compromise, thanks. If we end up needing them to be overridable for your `TextInputClient` work, or someone opens an issue with a good use case or something, then I'm all for opening them up to overriding.
397
+
398
+ You're right about point no. 2, it is currently possible to look up the EditableTextState and call methods directly on it in a similar way to invoking these Actions.",0,0,0,1,0,0
399
+ 675815308,"Ok, thanks for additional info! I was thinking if it makes sense to put some of this info into the comment, so when it's the right time to fix that - there is a context available. Up to you whether it's worth adding that or not :)",0,0,0,1,0,0
400
+ 599586487,"Are you planning on adding a note with the live example/download example link? Those are great! Oh! And that reminds me, remember to add your app to the example apps list. (Yay!!!🌈)",0,0,0,1,0,0
401
+ 186059118,They are quite similar so I thought they can live in the same folder. But it's not a big deal I can create a separate case. Interesting that I did exactly that in the first place but then I thought why not together? 😃,0,0,0,1,0,0
402
+ 920812499,"[BLOCK QUOTE].
403
+
404
+ Argh 😠 You're right 😞
405
+ OK, how about this:
406
+ [TRIPLE QUOTE].
407
+ It uses look-ahead (instead of look-behind) and thus should work everywhere (even on IE 😛).",0,0,0,1,0,0
408
+ 118183745,"I don't know if it's true but 100% spec-compliant have it, MDN documents it, it smells like a standard you can safely count on ;) plus it's way faster than new Promise in all native implementations right now afaik",0,0,0,1,0,0
409
+ 666577053,"I do not like this name, but so far have struggled to come up with something very good. `controlsBuilder` was aptly named 😆",0,0,0,1,0,0
410
+ 657493931,"ah ok, great to hear! thanks! :smiley:",0,0,0,1,0,0
411
+ 615446895,Yes and no 😁 The Babel plugin is available as an export from `@angular/compiler-cli/linker/babel` and that can be integrated into e.g. a custom Webpack build by registering the linker as a plugin for [`babel-loader`]([URL] We're planning to add a new export for easier creation of the linker plugin.,0,0,0,1,0,0
412
+ 644163389,That's attention to detail :-),0,0,0,1,0,0
413
+ 731287799,"my idea was indeed to be very loose in the tests and basically just match that anything except spaces (and newlines and whatnot) and just test that aspect in a specific decidated test
414
+ (got inspiration from here: [URL] :stuck_out_tongue_winking_eye: :heart_eyes:)
415
+ but it depends on what regexes we end up using I guess, I think you are suggesting that each type of comment can have different newlines etc. so we should indeed test that in the various tests?
416
+ I sort of liked the idea of here basically just testing the actual content of what we get and not caring about spacing whatsoever, but if you don't think it's the right approach (meaning that we can't just delegate it all to one or a small number of dedicated tests) I can be more strict in the various tests as you're suggesting :slightly_smiling_face: also if we're talking about strictness, would you reckon we can also try to match the exact number of spaces instead of using `*` or would that make the tests far too brittle?",0,0,0,1,0,0
417
+ 102399432,"right 👍
418
+ I was confused and though that it was mutated below. Thanks 👍",0,0,0,1,0,0
419
+ 900508165,"hmm, no. but that was a useful settings i have been looking for, thx
420
+ It solved the autocompletion when writing but it didn't solve the auto converter (quick fix) (turning cjs to esm)
421
+ importModuleSpecifierEnding should always be on when writing ESM modules",0,0,0,1,0,0
422
+ 719400900,awesome! I'm glad you know about this trick.,0,0,0,1,0,0
423
+ 721339145,"Ha! I knew you would say that 😛
424
+ No, it's not necessary to use backticks. Happy to switch to string concatenation.",0,0,0,1,0,0
425
+ 934364646,"[BLOCK QUOTE].
426
+ I think you can't mention this often enough, as it outweighs all the counter-arguments in my opinion... 😅",0,0,0,1,0,0
427
+ 951260230,"Sounds good.
428
+
429
+ In addition, we want to CP [URL] (to hide the web engine framework tests on release branches)",0,0,0,1,0,0
430
+ 477622875,It was a problem with the harness spreading away non-enumerable properties from `compilerOptions`. Fixed 👍,0,0,0,1,0,0
431
+ 615400191,"I did look into it initially, but wasn't sure whether it would be the best place to put it. However, I tried moving the code there, and it still works as expected, so I think it should be fine :-)",0,0,0,1,0,0
432
+ 711354723,"I think I prefer that to show the shorthand it must be only `boolean` and braces for everything else. This is true for a type `boolean | string` for example, which will use braces as well.
433
+
434
+ Nonetheless, I think there's a argument for adding as little as possible, as in the case of if _any_ of the types is boolean. If you feel this is a better approach I'm don't mind changing it.",0,0,0,1,0,0
435
+ 900670275,"Got it.. Thanks for your reply. This is my first PR to angular, so i am facing some tooling related issues. Let me fix those and upload a new commit.",0,0,0,1,0,0
436
+ 712921549,"Fair enough :smiley:
437
+ How about:
438
+ [TRIPLE QUOTE].",0,0,0,1,0,0
439
+ 716071659,"good point. Not sure if it's worth updating the VE code, but could probably do that instead of having the comment here 🤷‍♂️",0,0,0,1,0,0
440
+ 696040967,"I'm pretty sure it was drive-by. I assume your change doesn't introduce a new usage of realpath, so we should be fine.",0,0,0,1,0,0
441
+ 939521570,"I would say this is good expected behavior, If You want to validate if the input value is a numeric add a validator for it (custom or pattern with proper regex)",0,0,0,1,0,0
442
+ 891150456,"Ok, I'll need few more days, the results I got during manual tests with chrome performance profiles are very inconsistent.
443
+ In fact, I didn't reproduce the results from Friday.
444
+
445
+ I'm going to push the upgrade into our automatic performance tests. It'll take some time but should give us better results.
446
+ It's hard to believe that after few months of investigation it works as it should 😄
447
+
448
+ I'll let you know after the automatic tests end.",0,0,0,1,0,0
449
+ 676986657,"That seems totally plausible to me; not sure if there’s some reason why it’s not implemented like that. I’d be open to that, but would want to bring in a couple other reviewers to help think about edge case implications of it.",0,0,0,1,0,0
450
+ 950559742,"[USER] This currently seems to be a limitation of the framework to work properly with UiAutomatorViewer, as mentioned in the original linked [issue]([URL] I suggest you to share your findings in the linked issue for better tracking.",0,0,0,1,0,0
451
+ 948634666,"[BLOCK QUOTE].
452
+
453
+ I updated the tests repo to point to a newer gallery commit and I think/hope that solves the problem (as those properties are no longer referenced in that file at all now)",0,0,0,1,0,0
454
+ 548054130,that might be useful to improve. but could you describe the perf impact of getting the source here? my expectation is that originalSource is a RawSource that already had the file in memory from when we parsed it in the first place,0,0,0,1,0,0
455
+ 797505949,"[BLOCK QUOTE].
456
+ Understood. Will try and make a minimal example.",0,0,0,1,0,0
457
+ 918949272,[USER] - we are currently working on a potential design that will be put out as an RFC in the not-too-distant future.,0,0,0,1,0,0
458
+ 723625587,I assume that you will go through and tidy up all this commented out stuff before merging?,0,0,0,1,0,0
459
+ 568241412,"Unfortunately, this isn't enough to get the correct emit, but its the right start. I tinkered with your PR locally and I think I have a solution that builds off of what you've done here. Essentially, you need to move the `isCallChain` test out of the call to `updateCallExpression` and call `updateCallChain` in its own branch. In the new `updateCallChain` branch, you ""move"" the `?.` from the original call (i.e., `this.#x?.()`) to the new property access for `.call` needed to preserve the correct `this` (i.e., `_a?.call(this)`).
460
+
461
+ I can see if I can push an update to your PR with this change shortly.",0,0,0,1,0,0
462
+ 721970150,This was actually causing this test-case not to be executed!,0,0,0,1,0,0
463
+ 877454860,"This issue was fix in [URL]
464
+ It can be closed now.",0,0,0,1,0,0
465
+ 657225871,You are right! I think it's ok to keep as it as it's a standard thing that we do across the repo. Thanks for the clarification.,0,0,0,1,0,0
466
+ 742048484,"[USER] Thank you for the clarification.
467
+ I removed the redirect and the test for the redirect.
468
+ I will reach out to discuss this more as time permits.",0,0,0,1,0,0
469
+ 785457713,Cheers! Just noticed the same bug myself,0,0,0,1,0,0
470
+ 497805162,"You should either pass both the `id` and `ngRouterPageId` in here and modify the state inside the function or do both of them outside the function and not modify state here at all. The half and half nature is a bit awkward right now. I think the first option is nicer:
471
+ [TRIPLE QUOTE].",0,0,0,1,0,0
472
+ 902826193,"[USER]
473
+ This is awesome news! Could you link to the implementation or discussion of this feature?",0,0,0,1,0,0
474
+ 919325378,[USER] I think your review will be helpful 😄,0,0,0,1,0,0
475
+ 937034549,"I made a similar comment in the recreation README but worth mentioning here.
476
+ My usage of `yargs` is simply because it is the first package I ran into with this issue while testing out 4.5 beta. It is a very popular package so I suspect this issue could/would pop up for many users when 4.5 is officially released.
477
+ If my diagnosis is correct, this is by no means an issue with `yargs` itself, and could be recreated with any other package that:
478
+ 1) Uses package.json `exports` field
479
+ 2) Exports a file under some path (not just root/index)
480
+ 3) Does not include native typings and relies on something like [USER]",0,0,0,1,0,0
481
+ 247166036,"Personally I'd extract this into a variable or a local helper function - or maybe just add a comment, so it's clear that the reason for this is to check for case sensitivity on the filesystem",0,0,0,1,0,0
482
+ 645206496,"To share it across more than one affected file, it would have to be on the state. I'm going to try updating it in parallel with `seenAffectedFiles`.",0,0,0,1,0,0
483
+ 714376542,"I was initially tempted to do something overly clever for this, but I suspected that some sort of state machine would be harder to read/understand than collapsing the state into a horrible nest of if/else blocks. But I'm open to suggestions on how to make this more elegant (looking at you [USER]",0,0,0,1,0,0
484
+ 716885741,"Would it be any cleaner if this method were added to [TextLayoutMetrics]([URL]
485
+
486
+ The goal of that class is to simplify things by providing a read-only interface instead of the full RenderEditable. You probably have to use RenderEditable anyway though, so maybe it's not worth it here. Just wanted to bring it up.",0,0,0,1,0,0
487
+ 855192149,"[USER] No problem, I am glad I can help.",0,0,0,1,0,0
488
+ 864956198,"Oh nice!! I've seen that syntax floating around, wanting to try it for a while 🙌",0,0,0,1,0,0
489
+ 899508459,"Sorry for my long response time. Here is my suggestion for the API modifications:
490
+ I would add a new field to NgUpdate:
491
+ `potentialUpdateAvailalbe: Observable<PotentialUpdateAvailableEvent>` .
492
+ This should meet the `a new version has been detected to exist (but is not available to use yet)` and `a new version starts downloading` event. At least for me it looks there is no need to differentiate as downloading starts immediately after the potential update was detected.
493
+ Same is for `a new version finishes downloading` which is basically the same as `a new version is available to be activated`.
494
+ **Regarding [USER] comment:**
495
+ I guess sticking to Promises is fine here as Observables would require a call to `.subscribe()`. But I can agree on adding a meaningful return value. I would prefer a signature like this:
496
+ `checkForUpdate(): Promise<UpdateAvailableEvent | NoUpdateAvailableEvent | UpdateFailedEvent>`. Throwing an error in case of failure would force applications to catch it which would be definitely a breaking change.
497
+ And for `activateUpdate` it could look like this: `activateUpdate(): Promise<UpdateActivatedEvent | ActivationFailedEvent>`.
498
+ TBH I am not sure if returning the events is the best way here. If an error is thrown in case of failure, returning a `boolean` value would be possible as well.
499
+ @gkalpak WDYT?",0,0,0,1,0,0
500
+ 908719849,"I certainly won't get to it any time soon, so feel free to submit a PR :wink: I'll be happy to review and help with questions.",0,0,0,1,0,0
501
+ 924047643,"Thank you, [USER] My team is looking into this!",0,0,0,1,0,0
502
+ 951777341,"Perfect thank you, I know enough to start testing. I will keep you up to date on my findings.",0,0,0,1,0,0
503
+ 952407485,"[USER] it looks like you didn't have a chance to get back and investigate the issues mentioned above. I'm going to close this PR since it's not ready for review, but we are in general very interested in contributions so if you ever get back to it please don't hesitate to submit a new PR! Thanks!",0,0,0,1,0,0
504
+ 952947872,"[USER] can you assign this ticket to me, I can help in this.",0,0,0,1,0,0
505
+ 739537325,"that's awesome, I've been needing this for a while",0,0,0,1,0,0
506
+ 685326480,"I've had a think over the weekend and I have another idea for opting in.
507
+
508
+ @cedvdb thanks for the input! I think the goal is to give folks time to migrate to the new default first before making the final switch.",0,0,0,1,0,0
509
+ 926755938,"I’m not trying to be difficult here — I do get that this is kind of supported and I’m just pushing for a slightly cleaner/simpler/more shareable way of doing this, so I totally get if there’s no bandwidth for something like this.",0,0,0,1,0,0
510
+ 712202685,"I have a plan to do some additional work on these topics; your efforts are making that work much easier, [USER] !
511
+
512
+ As the merge conflict caused you to revert these sentences back to their original form, I'm fine if we leave them as is. Let's not have perfect be the enemy of good!",0,0,0,1,0,0
513
+ 895954471,"Adding this component in bootstrap is my stupid mistake. I remove CheckComponent from this example, and it is worked! Thanks!",0,1,0,1,0,0
514
+ 954259800,"Apologies, I should have been more specific with my comment. What I meant to say is that Flutter plugins (and even pure Dart packages) using FFI are in need of being able to detect a hot-restart as much as plugin's using platform channels.
515
+
516
+ Given this is a development-time only issue, I would be happy with as simple a mechanism as possible.
517
+
518
+ The effect I'm trying to fix is that I'm making use of a native library (eg. C, Rust, etc) which holds one or more resources (eg. sockets, bluetooth, audio etc) which need to be released on stop. On Linux desktop as an example, this happens if the hosting OS process is destroyed during debugging when the Flutter app is stopped, but does not happen during a hot-restart. I have to be honest and admit I don't know the details of what happens during a Dart hot-restart, but it seems to be that the running Isolate(s?) is killed and then started again? Any how, the effect is that Dart side references to the native library are lost, while the native library continues to run, potentially on its own thread(s).
519
+
520
+ To fix the above, I would request having some sort of lifecycle sync callback that can be registered by an app to be called prior to hot-restart taking place. This would allow me as the app author the chance to call any required `close()/destroy()/stop()`, etc on native libraries (or for that matter platform channel plugins) that I'm using to have them cleanup their resource usage. This then doesn't impact or require changes from existing native libraries as they would be expected to already be providing some sort of cleanup resources API and platform channel plugins do not need to be aware of this API, its just something a plugin user knows to make use of in order
521
+
522
+ I know this can potentially block hot-restart but as the app author I will have had to explicitly regsiter for this callback and then do something to block that callback completing so thats on me as the app author, plus I've already experienced existing bugs that cause hot-restarts to stall so its not something that would block dev work, but it would at least give app authors that are making use of such native libraries and platform channel plugins the effective use of hot-restart again.
523
+
524
+ Ideally I would expect this being done upstream in Dart because hot-restart is a Dart mechanism and there is an already [an issue for it](https://github.com/dart-lang/sdk/issues/42679) but I understand that pure Dart usage is a niche usage compared to Flutter so I would be happy just for a Flutter specific implementation.",0,0,1,1,0,0
525
+ 944895023,"Hey guys, any update on this problem? Or is it still not triaged\prioritized? Wondering because not just this is a concerning problem for anyone who actually develops desktop application with Flutter, but also a major fun killer - knowing that your app will end up draining quite a lot of RAM is really discouraging",0,0,0,0,1,0
526
+ 781475801,"[USER] yep, bug :disappointed: Feel free to send a fix",0,0,0,0,1,0
527
+ 162276817,"Still not happy with this. To make the warning cache correctly, it has to be in `module.warnings`, but I will try changing it myself.",0,0,0,0,1,0
528
+ 880859726,"unfortunately there can be many problems here, I cannot help without repo :disappointed:",0,0,0,0,1,0
529
+ 881899653,"Let's close, temporary reverted :disappointed: will be added late again",0,0,0,0,1,0
530
+ 902964228,"[USER] here we are! :smile: :tada:
531
+ But actually.... eslint seems to not handling very well the large amount of files to check here, and it is so much slower than tslint in this instance... whilst this check takes tslint around 40 seconds on my machine, eslint takes around 4 minutes.... :disappointed:
532
+ (and you can see I am ignoring all possible files except the ts ones)
533
+ This is rather unfortunate... but I guess it would still make sense to move away from the deprecates tslint.... what do you think?",0,0,0,0,1,0
534
+ 853732431,"[BLOCK QUOTE].
535
+
536
+ Thank you for your answer, this parameter was just a test, i forgot to remove it in my post. It doesn't fix the problem. I will open a new topic in the webpack-encore repo.",0,0,0,0,1,0
537
+ 877513580,"well, that's very disappointing",0,0,0,0,1,0
538
+ 877601095,"Well, that's a disappointing decision. I don't at all agree with the reasoning, you **already** coupled Angular with rxjs years ago and kinda left those actually utilizing it in the middle of the road, refusing to address the pain points for years until finally giving up altogether.
539
+
540
+ I'm not moving away from Angular, I'm way too deep in, but man, it's sad to see what has become of this framework (and I've been here since the early alphas!), the excitement is all but gone. I can't remember the last release that actually improved developer quality of life. I really hope that at some point Angular will at least provide enough extension points to properly integrate features such as this one without having to resolve to hackarounds.",0,0,0,0,1,0
541
+ 799353751,"[USER] I accidentally rewrite your changes using `force`, sorry :disappointed:",0,0,0,0,1,0
542
+ 846514267,"Apparently a breaking change in `webpack-dev-server`, which is still in beta :disappointed:",0,0,0,0,1,0
543
+ 881922682,This doesn't reproduce for me anymore (in v12),0,0,0,0,1,0
544
+ 719501069,for some reason clang-format wants it that way 😞 I'm extracting the input into a variable to make this more readable.,0,0,0,0,1,0
545
+ 881783714,"I don't think we want to expose Angular's management of styles as a public API, unfortunately.",0,0,0,0,1,0
546
+ 942594430,Closing this due to lack of additional feedback since it was opened,0,0,0,0,1,0
547
+ 859244125,I already see what I did wrong.,0,0,0,0,1,0
548
+ 940149931,"I was actually working on it, sorry I forgot to mention that earlier",0,0,0,0,1,0
549
+ 924203784,Thank you for your reply. So did I an implementation mistake and is it not a bug? Is it possible to lazy load many modules by other lazy loaded module?,0,0,0,0,1,0
550
+ 691563103,"ahhh ok.... sorry I wasn't sure what OOC stood for and thought it was Out Of Context, in a sense like ""what are you doing? you shouldn't do stuff like that!"" :sweat_smile: (google didn't help as that was one of the first results I got :sweat_smile:)
551
+ I finally got that it stands for Out Of Curiosity (sorry, not sure how I totally got my wires crossed :sweat_smile: )
552
+ When I see your ""OOC""s now I won't have to be scared anymore! :rofl:",0,0,0,0,1,0
553
+ 904080551,Even that was a little bit off - the real example should use a heterogeneous array and not discuss literal types. I guess taking notes during the discussion can throw me off a bit. 😅,0,0,0,0,1,0
554
+ 694289939,"damn, sorry I missed the last line of your comment, and indeed thought I fixed this one! sorry!!!!! :bow:",0,0,0,0,1,0
555
+ 715806314,"Sorry, I forgot to use the 80 chars in my own suggestion, should be:
556
+
557
+ [TRIPLE QUOTE].",0,0,0,0,1,0
558
+ 857618908,"Sorry, forgot to provide babel configuration information
559
+
560
+ .babelrc
561
+
562
+ [TRIPLE QUOTE].",0,0,0,0,1,0
563
+ 179120668,"Good idea, but sadly we can't use any dependency, since the setup script runs before dependencies are installed.",0,0,0,0,1,0
564
+ 662638379,Ah sorry I thought `ScaleUpdateDetails` was constructed in `_update` nvm.,0,0,0,0,1,0
565
+ 900881965,"Sorry, I made a mistake when writing my previous message. Trying to import the `<Footer />` component using `CTRL`+`.` shortcut.",0,0,0,0,1,0
566
+ 956861248,"Unfortunately, we have reports that the proposed workaround does not work on all samsungs. So we have a higher demand on a solution for the core issue.",0,0,0,0,1,0
567
+ 708565798,"yes.... sorry I honestly was unsure what to do about those... because the can be before a line staring at a certain column and ending after a line ending with a different one...
568
+ I think I'll just put them with the same number of spaces regarding on the next/previous line.... does that sound ok? :sweat:",0,0,0,0,1,0
569
+ 948617527,"> [BLOCK QUOTE].
570
+
571
+ I see, that's unfortunate. I think I forked off version 2.0.2, which works for me. So you can start your search there if you'd like. Good luck!",0,0,0,0,1,0
572
+ 676961343,PS: who and why decided to allow keyframes to be strings??? :sob:,0,0,0,0,1,0
573
+ 174042796,Let's ignore this for now and take care of this when finished the other problems.,0,0,0,0,1,0
574
+ 918947322,Is this still on the horizon for Angular 13? I haven't seen any PR related to this as of yet and nothing in the current next releases.,0,0,0,0,1,0
575
+ 951763456,"Patiently waiting for any updates..
576
+
577
+ One idea that I had was to add AdSense to an empty HTML page and then add Flutter app to the html page. Would that work? Or would the html page get rejected due to lack of content because AdSense would ignore the Flutter app?",0,0,0,0,1,0
578
+ 177303565,"Doh. Sorry for wasting your time.
579
+ I will update now, and move on to the test suite. That may take a few days as I'm quite busy atm, but I'll get there.",0,0,0,0,1,0
580
+ 643205227,"I don't really understand this test. isn't ""Your example app code"" the phrase you want to see?",0,0,0,0,1,0
581
+ 688404293,Bah! Sorry -- fixed. (Dusty keyboard...),0,0,0,0,1,0
582
+ 734835543,"We don't try to infer type predicate signatures - users always have to write them out deliberately, and can't rely on contextual types.
583
+ But even if we did rely on contextual types, we have another issue with class members not using them [URL] 😢",0,0,0,0,1,0
584
+ 877560568,You broke my heart,0,0,0,0,1,0
585
+ 953249434,Unfortunately this was pulled from v12 due to CI breakages and is not actually in 12.2.12; #43965 is pending for v12.,0,0,0,0,1,0
586
+ 961343762,"[TRIPLE QUOTE].
587
+ Ok sorry but why do i get this?
588
+
589
+ how do i get my Flutter SDK updated to current version ?",0,0,0,0,1,0
590
+ 667362075,Nit: Order import alphabetically (although import order is already a little messed up here 😓).,0,0,0,0,1,0
591
+ 908876916,"Sorry, the mapped type was not relevant to this problem, so I removed it to simplify problem. (`BaseTheme & Record<string, unknown` => `BaseTheme`)",0,0,0,0,1,0
592
+ 551068675,This one actually seems kind of unfortunate.,0,0,0,0,1,0
593
+ 708737406,"Yes, sorry for the confusion!",0,0,0,0,1,0
594
+ 884477798,"Yeah, I do, sorry. Busy days + vacations season 🙂",0,0,0,0,1,0
595
+ 948038798,"There isn't any guidance for this from Material unfortunately. It does seem like a tricky problem to solve.
596
+
597
+ An alternative could be building something custom with a dropdown menu that only shows the allowed times for hours/minutes.",0,0,0,0,1,0
598
+ 919041284,"Unfortunately, there is not much we can help with without getting more info. It is unclear how the app is set up and what might be causing the problem (or even what exactly the problem is). For example, how is the server configured, how is the ServiceWorker configured, how is routing configured, etc.
599
+
600
+ BTW, you can easily check what the ServiceWorker puts in cache after you visit the app, by opening the browser's DevTools, going to the `Application` tab and looking under `Cache Storage`.
601
+
602
+ ##
603
+ I am going to close this issue, since there is no clear indication of a problem with Angular and the issue is not actionable in its current state. Feel free to continue the discussion below, though.
604
+
605
+ Also, happy to re-open and investigate if you can provide a minimal reproduction of the problem.",0,0,0,0,1,0
606
+ 838585224,"I don't understand your problem, `args` is `Record<string, any>`, you can use `const myMode = args['mode'] as Configuration['mode']`",0,0,0,0,1,0
607
+ 946751412,Do you understand that it is impossible in some cases or can lead to increase size of bundle?,0,0,0,0,1,0
608
+ 796698161,"Answer above, sorry without any more information we can't fix it, anyway feel free to feedback, if you provide reproducible test repo I will look and answer your about the problem, won't fix right now, sorry again",0,0,0,0,1,0
609
+ 953883814,"[USER] We still not support this for `library: 'module'`..., but we are already close",0,0,0,0,1,0
610
+ 934544746,[USER] Sorry for the frustrating experience. I can't make any promises but of course this will be considered as we draw up the iteration plan for the next release.,0,0,0,0,1,0
611
+ 909227603,"Any chance of having the json file resolve even if it doesn't have the extension?
612
+ I have an external dependency that didn't specify the extension. I think it should be a concern of the developer to pay attention to the collisions. Preferably, the typescript compiler should warn about the collisions, but I'm not sure about the performance/development implications of this.",0,0,0,0,1,0
613
+ 922261795,"I have the same issue, updating the `""@types/react""` package didn't help",0,0,0,0,1,0
614
+ 945753981,"I have same problem,
615
+ dose anyone have any solution?",0,0,0,0,1,0
616
+ 933579958,"I am really confused now. You referred to #42609 and #40125 which describe an issue that affect type-checking when using `trackBy`, yet those examples show programmatic samples and appear to indicate that there is an issue with runtime behavior.",0,0,0,0,0,1
617
+ 956877982,"Not sure. It's not assigned and there is no milestone, so no one is planning to look at it in the near future and it's up for grabs if anyone wants to try fixing it.
618
+
619
+ That said I have a little bit more info that I'll post in a minute.",0,0,0,0,0,1
620
+ 716058442,"I'm confused, are you saying that it's a map of array of nodes? Why was the original signature `any[][]`?",0,0,0,0,0,1
621
+ 716937366,"I didn't mean to delete it, just restructure it. Previously it only verify if there was no symbol for the left side, so I changed it to test if there an expression on the left side, which I felt was still in line with the original intent of the test.
622
+
623
+ In retrospect, I don't think I fully understand what ""symbol"" means to the compiler. Is there a symbol for `func() ?? 'foo'` but *not* a symbol for `(123 | doesNotExist) ?? 'invalid date'`? I would expect neither cases to have symbols, but based on my investigation here I think that understanding is incorrect. If these are distinct cases, then you're right that we probably should keep the old test, but if they are the same then the new test should be enough on its own.",0,0,0,0,0,1
624
+ 924536126,"Hmmm seems weird, workspace packages do not act like real packages?",0,0,0,0,0,1
625
+ 540425501,"I thought I should leave it so we didn't get a bunch of duplicate reports, but I may have misunderstood what the flag does. I guess I should just test it.",0,0,0,0,0,1
626
+ 740059153,Oh yes - not sure how this happened. Confused why renovate did not resolve this previously....,0,0,0,0,0,1
627
+ 927168835,I was already wondering after logging the ActivatedRoute instance to console and I saw both params and paramsMap (Didnt know why and when I should use one over the other). I just started learning Angular and a lot of convention is kinda confusing. Thanks for the clarification [USER] .,0,0,0,0,0,1
628
+ 307419874,"This is not true. If a script claims webpack assigned policy, it means it has already control over the code and potentially can introduce more sever attacks. Also, I am not sure I understand which scripts are run before webpack. If I misunderstanding the comment can you please clarify what I am missing?",0,0,0,0,0,1
629
+ 697576617,"I'm not sure what this comment means, given that this template is for packages, not applications.",0,0,0,0,0,1
630
+ 701432359,"is this not always passed? or is it always passed, but sometimes null?",0,0,0,0,0,1
631
+ 920941785,"[BLOCK QUOTE].
632
+ can't see it in the plans for 4.5
633
+ is that right or am I missing something ?",0,0,0,0,0,1
634
+ 94406631,Not sure on embedded newline vs `\n`,0,0,0,0,0,1
635
+ 99430262,"Fixing these, but FYI the previous format was suggested by the linter, not sure why",0,0,0,0,0,1
636
+ 128880160,"i assume you mean?
637
+ [TRIPLE QUOTE].
638
+
639
+ is this needed anywhere?",0,0,0,0,0,1
640
+ 229230608,"[USER] Hi, thanks for your review, but i think this case cover my changed, because when i run the case in the older code, i got an error. i look at the `test/hotCases` folder, but i dont know how can i run these cases",0,0,0,0,0,1
641
+ 550324789,"Off the top of my head, I don’t see why you have to look at the children. Shouldn’t the span of the first to last child be equal to the span of the PropertyAccessEpression itself, i.e. `accessExpression.getFullWidth()`?",0,0,0,0,0,1
642
+ 732148879,Is this hint useful?,0,0,0,0,0,1
643
+ 799609373,That's not what the documentation is saying though? Now I have to change any existing (and future) rule that might process assets loaded as source.,0,0,0,0,0,1
644
+ 880698167,"so why is it generating this css that is invalid:
645
+ [TRIPLE QUOTE].",0,0,0,0,0,1
646
+ 900656460,"Also, `isMemberCompletion` seems possibly wrong, but I don’t know what that controls 🤔",0,0,0,0,0,1
647
+ 945616146,"I suspect this is known, but this isn't specific to test files, it happens with any non-`lib/main.dart` target including a normal app too ([URL] It does still only occur with with the plugin above and not with a newly-created empty app though.",0,0,0,0,0,1
648
+ 950999642,"What's the status here? I'm not sure what the comment on the revert about file structure means exactly, so I'm not clear on what the next steps are.",0,0,0,0,0,1
649
+ 955982703,When dismissing the keyboard the textField gets cleaned thus changed. Is it actually a bug?,0,0,0,0,0,1
650
+ 674226815,Why is this now necessary? Seems odd...,0,0,0,0,0,1
651
+ 684538023,"[USER] curious for your thoughts, I don't love this opt-in strategy but it was the most straight forward path.",0,0,0,0,0,1
652
+ 902764778,"I took a look at the meeting notes #45504, and I did note this bit:
653
+
654
+ [BLOCK QUOTE]
655
+
656
+ I am curious about what the right tool is then? There doesn't really seem to be a great alternative to doing this. In particular, the problem is that of run-time equivalence; the library is intended to be usable both with plain JS and TS. JSX cannot be used without compiling, and furthermore the use-case of safe HTML templates was among the original design considerations that TC39 looked at [URL]. Tagged template literals are a very natural API for native JS libraries (see also: [URL], [URL])
657
+
658
+ The approach taken by Svelte/Vue (custom language servers) or tsserver plugins doesn't really scale; writing transformers to turn syntax into JSX seems like a significant amount of work, especially for smaller projects. This approach also doesn't even allow for correctness checks at compile-time.",0,0,0,0,0,1
659
+ 114991684,[USER] Interesting. Curious as to why is `new Promise(function(resolve) { resolve(); })` better than `Promise.resolve()` here and above?,0,0,0,0,0,1
660
+ 659997318,Is this still true?,0,0,0,0,0,1
661
+ 699718625,Not returning was just a bug?,0,0,0,0,0,1
662
+ 724492053,"I'm not sure ""it should be enabled"" is an accurate description of this test 🤔",0,0,0,0,0,1
663
+ 950817426,"hm, what about if I want to use it in PHP/Ruby/Python, now developers can generate json file and read it",0,0,0,0,0,1
664
+ 559189902,"Strictly speaking, these two cases aren't in the scope of the original issue. As you're able to see from the baselines, the current behavior here is to throw errors. Intuitively, however, the behavior I described in the comments makes more sense to me.
665
+ I would be interested in your thoughts on this matter 🙂 Regarding implementation, I wasn't able to figure out how to check whether a mapped type is optional (includes the `?`). Do we have a property that tracks that or should we check whether the value type includes `undefined`?",0,0,0,0,0,1
666
+ 629791317,[USER] just curious if this field was unused?,0,0,0,0,0,1
667
+ 647951271,What happened?,0,0,0,0,0,1
668
+ 675821430,"I am not sure I understand here. Should `double.infinity` be allowed as a `minThumbLength`? Also, the scrollbar currently only supports finite viewports. Infinitely long scrollables are not currently supported.",0,0,0,0,0,1
669
+ 950842795,Hi [USER] do you experience the same behaviour when using the `GestureDetector` as when you're using the `Listener`?,0,0,0,0,0,1
670
+ 957139887,Hi [USER] how do you propose the error/assertion message be improved?,0,0,0,0,0,1
671
+ 958590598,"[USER] as this was inherited from the JavaScript version of this codelab, I'm curious how y'all fixed this ambiguity?",0,0,0,0,0,1
672
+ 903704134,Ooops! I put it there while I had CI rerun a flakey job and forgot to remove it once it passed 😇,0,0,0,0,0,1
673
+ 940022485,"Oh, it's my problem. The method just provided is indeed normal But there are mistakes in the following process [TRIPLE QUOTE]. The code given by webpack is
674
+ [TRIPLE QUOTE].
675
+ format:
676
+ [TRIPLE QUOTE].
677
+ in line 3, it is wrong
678
+ my webpack.config:
679
+ [TRIPLE QUOTE].",0,0,0,0,0,1
680
+ 946923780,"ahhh, totally forgot that generated the binary in my linux desktop.",0,0,0,0,0,1
681
+ 529279468,"To be honest, I'm not so confident with regular expressions that it took me some time to come up with this solution to replace **all leading** tab characters. I was surprised not to find an example where this is done. I've seen the note on MDN as well but without the _global_ flag, only the first tab character was replaced in my test.
682
+
683
+ [TRIPLE QUOTE].
684
+
685
+ I've created a jsfiddle([URL]) and asked about **why this works** on stackoverflow([URL])
686
+
687
+ While writing this comment, my question was answered([URL])
688
+
689
+ Now I just need to find a good comment that clarifies the use of both _sticky_ and _global_ for this line. Does this do it for you?
690
+
691
+ [TRIPLE QUOTE].",0,0,0,0,0,1
692
+ 553661439,"Odd, we shouldn't have needed the parentheses here. I assume its because the union is no longer flat?",0,0,0,0,0,1
693
+ 669680999,"Hm...that's unexpected. I tried this locally and the images look fine. Can you try again splitting the paths (at the points where the strings were previously split)?
694
+
695
+ <sub>NOTE: I have accidentally deleted a `c` in my suggested change. I fixed it now to avoid confusion in the future.</sub>",0,0,0,0,0,1
696
+ 714192825,"hmm, even after a push I still see this test on github, but not locally",0,0,0,0,0,1
697
+ 778756867,"I wonder why this hasn't happened before, since it's a pretty obvious bug",0,0,0,0,0,1
698
+ 690782507,I'm confused by `_ddsInstance?.done.whenComplete(())`. Wouldn't we get a NPE trying call `.whenComplete` if `_ddsInstance == null`? (I'm assuming I'm wrong and you and the analyzer are correct though...),0,0,0,0,0,1
699
+ 500947278,"Just interesting, why we need this?",0,0,0,0,0,1
700
+ 129552596,"I have currently no clue, but I'll have a look.",0,0,0,0,0,1
701
+ 645234623,"Oh, the error message is copied from Chrome. But Chrome does not support static initialization block either, that's strange.",0,0,0,0,0,1
702
+ 101271998,This is weird. A Parser doesn't have a parser method. I would expect `constructor() {}` or `parse() {}`.,0,0,0,0,0,1
703
+ 651202527,Surely there must be something like this already? [USER] [USER],0,0,0,0,0,1
704
+ 719800439,i'm actually surprised this didn't get flagged by the analyzer...,0,0,0,0,0,1
705
+ 727500323,"What do you mean by assert? And yeah, good point about handling null later, I'm surprised it isn't an analysis warning.",0,0,0,0,0,1
706
+ 819380417,"hmm that's really interesting.
707
+
708
+ I think this is something for [USER]",0,0,0,0,0,1
709
+ 929698853,"This is very surprising to me and seems undesirable, but I’ll let [USER] have the definitive word.",0,0,0,0,0,1
710
+ 582654913,I'm not sure this is working as expected,0,0,0,0,0,1
711
+ 931418820,"Very very weird, maybe you can debug and provide source code of module?",0,0,0,0,0,1
712
+ 217882236,I also wonder why this snapshot differs?,0,0,0,0,0,1
713
+ 152840278,That's strange,0,0,0,0,0,1
714
+ 950365195,"yes i am really surprised that it's only a p4 and for so long...
715
+ In the meantime, i will try to handle it with :
716
+ [TRIPLE QUOTE].
717
+ What do you think ?",0,0,0,0,0,1
718
+ 921044961,"I was quite surprised when my prebaked webpack cache was not used in Github Codespaces. I've tracked it down to the cache using absolute paths. I would love the cache stay valid when moving the project directory or downloading a prebuilt cache folder, it would make things easier.",0,1,0,0,0,1
719
+ 733155987,Thanks! That's what I was curious about,0,1,0,0,0,1
720
+ 675355439,"It’s very strange why there is a display error, I have confirmed that there is no problem before uploading the code; I will try to reproduce it and fix it.
721
+
722
+ ![WechatIMG36]([URL]",0,0,0,1,0,1