Fix defaults for sampling methods

mc4-sampling.py

@@ -324,8 +324,9 @@ class Mc4Sampling(datasets.GeneratorBasedBuilder):
             doc_length += length
         return 10.0 ** (-doc_log_score / doc_length)
 
-    def _should_keep_doc_step(self, doc, factor=1.5e5, boundaries=None, **kwargs):
+    def _should_keep_doc_step(self, doc, factor=None, boundaries=None, **kwargs):
         perplexity = self.get_perplexity(doc)
+        factor = 1.5e5 if factor is None else factor
         if boundaries is None:
             boundaries = [536394.99320948, 662247.50212365, 919250.87225178]
         if perplexity <= boundaries[0]:
@@ -339,9 +340,10 @@ class Mc4Sampling(datasets.GeneratorBasedBuilder):
         probability = factor / quartile_range
         return self.rng.uniform() < probability
 
-    def _should_keep_doc_gaussian(self, doc, factor=0.78, boundaries=None, **kwargs):
+    def _should_keep_doc_gaussian(self, doc, factor=None, boundaries=None, **kwargs):
         width = kwargs.get("width", 9 / 2)  # width (spread) of the exponential curve
         perplexity = self.get_perplexity(doc)
+        factor = 0.78 if factor is None else factor
         if boundaries is not None:
             m = boundaries[1]
         else:
@@ -423,8 +425,6 @@ class Mc4Sampling(datasets.GeneratorBasedBuilder):
                                 example = json.loads(line)
                                 if self.should_keep_doc(
                                     example["text"],
-                                    factor=self.sampling_factor,
-                                    boundaries=self.boundaries,
                                     **self.kwargs):
                                     yield id_, example
                                     id_ += 1