ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
call : METHOD_1 ( VAR_1 Arrays _CODE_ ( VAR_2 ) ) ; btw read VAR_3 other method write VAR_3 | <START> public void METHOD_1 ( Guid VAR_1 , Guid VAR_2 ) { <END> VAR_3 . METHOD_2 ( ) . METHOD_3 ( ) ; try { if ( ! VAR_4 . containsKey ( VAR_1 ) ) { return ; } synchronized ( VAR_4 . get ( VAR_1 ) ) { VAR_4 . get ( VAR_1 ) . remove ( VAR_2 ) ; } } finally { VAR_3 . METHOD_2 ( ) . METHOD_4 ( ) ; } } | public void METHOD_1 ( Guid VAR_1 , Guid VAR_2 ) { METHOD_1 ( VAR_1 , Arrays . asList ( VAR_2 ) ) ; } |
equals instead ! = | private boolean METHOD_1 ( Class VAR_1 , Class VAR_2 ) { if ( Arrays . asList ( VAR_1 . METHOD_2 ( ) ) . contains ( VAR_2 ) ) { return true ; } else { <START> return VAR_1 . METHOD_3 ( ) != TYPE_1 . class <END> && METHOD_1 ( VAR_1 . METHOD_3 ( ) , VAR_2 ) ; } } | private boolean METHOD_1 ( Class VAR_1 , Class VAR_2 ) { if ( Arrays . asList ( VAR_1 . METHOD_2 ( ) ) . contains ( VAR_2 ) ) { return true ; } else { return ! VAR_1 . METHOD_3 ( ) . equals ( TYPE_1 . class ) && METHOD_1 ( VAR_1 . METHOD_3 ( ) , VAR_2 ) ; } } |
done part VAR_2 logic fields added vm_interface_view need double query | public TYPE_1 get ( Guid id ) { TYPE_2 VAR_1 = METHOD_1 ( ) . METHOD_2 ( STRING_1 , id ) ; TYPE_1 entity = METHOD_3 ( ) . METHOD_4 ( STRING_2 , VAR_2 , VAR_1 ) ; <START> entity . VAR_3 ( TYPE_3 . getInstance ( ) . METHOD_5 ( ) . get ( id ) ) ; <END> return entity ; } | public TYPE_1 get ( Guid id ) { TYPE_2 VAR_1 = METHOD_1 ( ) . METHOD_2 ( STRING_1 , id ) ; TYPE_1 entity = METHOD_3 ( ) . METHOD_4 ( STRING_2 , VAR_2 , VAR_1 ) ; return entity ; } |
I disagree place s hiding logic unrelated place I call needs done explicitly remove called ( case statistics ) | public void remove ( Guid id ) { TYPE_1 VAR_1 = METHOD_1 ( ) . METHOD_2 ( STRING_1 , id ) ; METHOD_3 ( ) . METHOD_4 ( STRING_2 , VAR_1 ) ; <START> TYPE_2 . getInstance ( ) . METHOD_5 ( ) . remove ( id ) ; <END> } | public void remove ( Guid id ) { TYPE_1 VAR_1 = METHOD_1 ( ) . METHOD_2 ( STRING_1 , id ) ; METHOD_3 ( ) . METHOD_4 ( STRING_2 , VAR_1 ) ; } |
I network exist able edit ( attach ) parameters permission network permission cluster | public List < TYPE_1 > METHOD_1 ( ) { <START> <END> if ( METHOD_2 ( ) ) { return Collections . VAR_1 ( new TYPE_1 ( getParameters ( ) . METHOD_3 ( ) , TYPE_5 . TYPE_4 , TYPE_2 . VAR_5 ) ) ; } else { Guid VAR_6 = getParameters ( ) . METHOD_4 ( ) == null ? null : getParameters ( ) . METHOD_4 ( ) . getId ( ) ; return Collections . VAR_1 ( new TYPE_1 ( VAR_6 , TYPE_5 . TYPE_3 , METHOD_5 ( ) . METHOD_6 ( ) ) ) ; } } | public List < TYPE_1 > METHOD_1 ( ) { Guid VAR_6 = getParameters ( ) . METHOD_4 ( ) == null ? null : getParameters ( ) . METHOD_4 ( ) . getId ( ) ; return Collections . VAR_1 ( new TYPE_1 ( VAR_6 , TYPE_5 . TYPE_3 , METHOD_5 ( ) . METHOD_6 ( ) ) ) ; } |
I agree moti changing order enough ( METHOD_2 ( ) equals ( VAR_2 getName ( ) ) instead VAR_2 getName ( ) equals ( METHOD_2 ( ) ) ) need check cluster network null t null | private TYPE_1 METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> if ( METHOD_2 ( ) == null ) { <END> return null ; } else { return TYPE_2 . METHOD_3 ( VAR_1 , new TYPE_3 < TYPE_1 > ( ) { @Override public boolean METHOD_4 ( TYPE_1 VAR_2 ) { return METHOD_2 ( ) . equals ( VAR_2 . getName ( ) ) ; } } ) ; } } | private TYPE_1 METHOD_1 ( List < TYPE_1 > VAR_1 ) { return TYPE_2 . METHOD_3 ( VAR_1 , new TYPE_3 < TYPE_1 > ( ) { @Override public boolean METHOD_4 ( TYPE_1 VAR_2 ) { return METHOD_2 ( ) . equals ( VAR_2 . getName ( ) ) ; } } ) ; } |
a new transaction needed | protected void METHOD_1 ( ) { final TYPE_1 VAR_1 = getParameters ( ) . METHOD_2 ( ) ; if ( VAR_1 != null ) { <START> TYPE_2 . METHOD_3 ( new TYPE_3 < TYPE_4 > ( ) { <END> @Override public TYPE_4 METHOD_4 ( ) { METHOD_5 ( VAR_1 , METHOD_6 ( ) ) ; METHOD_7 ( ) . METHOD_8 ( VAR_1 . getId ( ) ) ; METHOD_7 ( ) . METHOD_9 ( true ) ; return null ; } } ) ; } } | protected void METHOD_1 ( ) { final TYPE_1 VAR_1 = getParameters ( ) . METHOD_2 ( ) ; if ( VAR_1 != null ) { METHOD_5 ( VAR_1 , METHOD_6 ( ) ) ; METHOD_7 ( ) . METHOD_8 ( VAR_1 . getId ( ) ) ; METHOD_7 ( ) . METHOD_9 ( true ) ; } } |
suggestion : I consider remove VAR_1 instead call METHOD_4 METHOD_7 ( CDA more shorter I more performance wise ) | protected boolean METHOD_1 ( ) { List < String > VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; Map < Guid , TYPE_1 > VAR_2 = new HashMap < Guid , TYPE_1 > ( ) ; <START> if ( ! METHOD_4 ( VAR_1 , VAR_2 ) ) { <END> return false ; } if ( getParameters ( ) . METHOD_5 ( ) ) { METHOD_6 ( ) ; } if ( ! METHOD_7 ( VAR_1 , VAR_2 ) ) { return false ; } return true ; } | protected boolean METHOD_1 ( ) { Map < Guid , TYPE_1 > VAR_2 = new HashMap < Guid , TYPE_1 > ( ) ; if ( ! METHOD_4 ( VAR_2 ) ) { return false ; } if ( getParameters ( ) . METHOD_5 ( ) ) { METHOD_6 ( ) ; } return METHOD_7 ( VAR_2 ) ; } |
a member enum return upper case | public static TYPE_1 METHOD_1 ( String v ) { try { if ( v == null ) { return null ; } if ( v . equals ( STRING_1 ) ) { return VAR_1 ; } else if ( v . equals ( STRING_2 ) ) { return VAR_2 ; } else { <START> return valueOf ( v . VAR_3 ( ) ) ; <END> } } catch ( IllegalArgumentException e ) { return null ; } } | public static TYPE_1 METHOD_1 ( String v ) { try { if ( v == null ) { return null ; } if ( v . equals ( STRING_1 ) ) { return VAR_1 ; } else if ( v . equals ( STRING_2 ) ) { return VAR_2 ; } else { return null ; } } catch ( IllegalArgumentException e ) { return null ; } } |
iiuc propietary a string enum added TYPE_3 adding < pm_proxy > validating | public void METHOD_1 ( TYPE_1 host ) { if ( host . VAR_1 ( ) ) { if ( host . VAR_2 ( ) . METHOD_2 ( ) ) { for ( TYPE_2 VAR_3 : host . VAR_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ) { <START> METHOD_5 ( TYPE_3 . class , VAR_3 . METHOD_6 ( ) , true ) ; <END> } } } } | public void METHOD_1 ( TYPE_1 host ) { if ( host . VAR_1 ( ) ) { if ( host . VAR_2 ( ) . METHOD_2 ( ) ) { for ( TYPE_2 VAR_3 : host . VAR_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ) { METHOD_5 ( TYPE_3 . class , VAR_3 . getType ( ) , true ) ; } } } } |
please switch assert values expected / s / disk / storage type / s / / | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 ( ) ; ArrayList < TYPE_2 > VAR_2 = new ArrayList < TYPE_2 > ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; <START> TYPE_3 VAR_3 = command . VAR_4 ( VAR_1 ) ; <END> assertEquals ( STRING_1 , VAR_3 , VAR_3 . VAR_5 ) ; } | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 ( ) ; ArrayList < TYPE_2 > VAR_2 = new ArrayList < TYPE_2 > ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; TYPE_3 VAR_3 = command . VAR_4 ( VAR_1 ) ; assertEquals ( STRING_1 , TYPE_3 . VAR_5 , VAR_3 ) ; } |
final | <START> protected < T > Response METHOD_1 ( TYPE_1 task , <END> TYPE_2 VAR_1 , TYPE_3 < T , TYPE_4 > VAR_2 , boolean VAR_3 ) { return METHOD_1 ( task , VAR_1 , VAR_2 , VAR_3 , null ) ; } | protected final < T > Response METHOD_1 ( TYPE_1 task , TYPE_2 VAR_1 , TYPE_3 < T , TYPE_4 > VAR_2 , boolean VAR_3 ) { return METHOD_1 ( task , VAR_1 , VAR_2 , VAR_3 , null ) ; } |
need return super METHOD_1 ( ) | protected TYPE_1 METHOD_1 ( TYPE_1 model , TYPE_2 entity ) { if ( TYPE_5 . TYPE_6 . equals ( entity . VAR_1 ( ) ) ) { model . VAR_2 ( TYPE_4 . create ( TYPE_7 . VAR_4 ) ) ; } else { model . VAR_2 ( null ) ; } <START> return model ; <END> } | protected TYPE_1 METHOD_1 ( TYPE_1 model , TYPE_2 entity ) { if ( TYPE_5 . TYPE_6 . equals ( entity . VAR_1 ( ) ) ) { model . VAR_2 ( TYPE_4 . create ( TYPE_7 . VAR_4 ) ) ; } else { model . VAR_2 ( null ) ; } return super . METHOD_1 ( model , entity ) ; } |
please < operator > null convention | protected File METHOD_1 ( final TYPE_1 request , TYPE_2 VAR_1 ) { File file = TYPE_3 . METHOD_2 ( request . VAR_2 ( ) , VAR_3 ) ; <START> if ( null != file && ! TYPE_3 . METHOD_3 ( file ) ) { <END> file = TYPE_3 . METHOD_2 ( METHOD_4 ( request . VAR_2 ( ) , VAR_1 ) , VAR_3 ) ; } return file ; } | protected File METHOD_1 ( final TYPE_1 request , TYPE_2 VAR_1 ) { File file = TYPE_3 . METHOD_2 ( request . VAR_2 ( ) , VAR_3 ) ; if ( file != null && ! TYPE_3 . METHOD_3 ( file ) ) { file = TYPE_3 . METHOD_2 ( METHOD_4 ( request . VAR_2 ( ) , VAR_1 ) , VAR_3 ) ; } return file ; } |
please < operator > null convention | protected TYPE_1 METHOD_1 ( final TYPE_2 request ) { String VAR_1 = METHOD_2 ( request ) ; <START> if ( null == VAR_1 ) { <END> VAR_1 = METHOD_3 ( request . VAR_2 ( ) ) ; } TYPE_1 VAR_3 = TYPE_3 . METHOD_4 ( VAR_1 , true ) ; return VAR_3 ; } | protected TYPE_1 METHOD_1 ( final TYPE_2 request ) { String VAR_1 = METHOD_2 ( request ) ; if ( VAR_1 == null ) { VAR_1 = METHOD_3 ( request . VAR_2 ( ) ) ; } TYPE_1 VAR_3 = TYPE_3 . METHOD_4 ( VAR_1 , true ) ; return VAR_3 ; } |
please < operator > null convention | protected void METHOD_1 ( TYPE_1 request , TYPE_2 response ) throws TYPE_3 , IOException { File file = TYPE_4 . METHOD_2 ( request . VAR_1 ( ) , VAR_2 ) ; file = METHOD_3 ( request , response , file , request . VAR_1 ( ) ) ; <START> if ( null == file ) { <END> response . VAR_3 ( TYPE_2 . VAR_4 ) ; } else { TYPE_4 . METHOD_4 ( request , response , file , type ) ; } } | protected void METHOD_1 ( TYPE_1 request , TYPE_2 response ) throws TYPE_3 , IOException { File file = TYPE_4 . METHOD_2 ( request . VAR_1 ( ) , VAR_2 ) ; file = METHOD_3 ( request , response , file , request . VAR_1 ( ) ) ; if ( file == null ) { response . VAR_3 ( TYPE_2 . VAR_4 ) ; } else { TYPE_4 . METHOD_4 ( request , response , file , type ) ; } } |
return null | private List < String > METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { <START> return Collections . VAR_2 ( ) ; <END> } return Arrays . asList ( StringUtils . split ( VAR_1 , VAR_3 ) ) ; } | private List < String > METHOD_1 ( String VAR_1 ) { return VAR_1 == null ? null : Arrays . asList ( StringUtils . split ( VAR_1 , VAR_3 ) ) ; } |
_CODE_ ( ) instead mocking | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; <START> when ( METHOD_2 ( ) . METHOD_3 ( ) ) . METHOD_4 ( VAR_1 ) ; <END> when ( VAR_1 . METHOD_5 ( ) ) . METHOD_4 ( VAR_2 ) ; } | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; } |
return terminates - remove else | public boolean METHOD_1 ( TYPE_1 VAR_1 , Guid VAR_2 , int type ) { TYPE_2 VAR_3 = TYPE_3 . getInstance ( ) . METHOD_2 ( ) . get ( VAR_2 ) ; if ( VAR_3 . METHOD_3 ( ) != null ) { return METHOD_4 ( VAR_1 , VAR_3 . METHOD_3 ( ) . getValue ( ) , type ) ; <START> } else { <END> log . VAR_4 ( STRING_1 , VAR_3 . METHOD_5 ( ) ) ; return false ; } } | public boolean METHOD_1 ( TYPE_1 VAR_1 , Guid VAR_2 , int type ) { TYPE_2 VAR_3 = TYPE_3 . getInstance ( ) . METHOD_2 ( ) . get ( VAR_2 ) ; if ( VAR_3 . METHOD_3 ( ) == null ) { log . VAR_4 ( STRING_1 , VAR_3 . METHOD_5 ( ) ) ; return false ; } return METHOD_4 ( VAR_1 , VAR_3 . METHOD_3 ( ) . getValue ( ) , type ) ; } |
super METHOD_1 ( ) dao call | public TYPE_1 METHOD_1 ( ) { TYPE_1 vm = super . METHOD_1 ( ) ; if ( vm != null ) { return vm ; } <START> vm = METHOD_2 ( ) . get ( getParameters ( ) . METHOD_3 ( ) ) ; <END> if ( vm != null ) { METHOD_4 ( vm ) ; METHOD_5 ( vm . getId ( ) ) ; } return vm ; } | public TYPE_1 METHOD_1 ( ) { TYPE_1 vm = super . METHOD_1 ( ) ; if ( vm != null ) { METHOD_4 ( vm ) ; } return vm ; } |
t vm = = null removed | private boolean METHOD_1 ( TYPE_1 vm ) { <START> return vm != null && vm . getStatus ( ) == TYPE_4 . TYPE_3 && <END> vm . VAR_3 ( ) != null && ! vm . VAR_3 ( ) . equals ( Guid . TYPE_2 ) ; } | private boolean METHOD_1 ( TYPE_1 vm ) { return vm . getStatus ( ) == TYPE_4 . TYPE_3 && vm . VAR_3 ( ) != null && ! vm . VAR_3 ( ) . equals ( Guid . TYPE_2 ) ; } |
t vm = = null removed | private boolean METHOD_1 ( TYPE_1 vm ) { <START> return vm != null && vm . getStatus ( ) == TYPE_3 . TYPE_2 ; <END> } | private boolean METHOD_1 ( TYPE_1 vm ) { return vm . getStatus ( ) == TYPE_3 . TYPE_2 ; } |
iterating keyset calling map line iterate entrySet instead | private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; for ( Guid VAR_2 : VAR_3 . keySet ( ) ) { <START> List < TYPE_2 > VAR_4 = VAR_3 . get ( VAR_2 ) ; <END> TYPE_1 VAR_5 = new TYPE_1 ( VAR_4 , VAR_2 ) ; VAR_5 . METHOD_2 ( TYPE_4 . TYPE_3 ) ; VAR_5 . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) ) ; VAR_1 . add ( VAR_5 ) ; } return VAR_1 ; } | private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; for ( Map . Entry < Guid , List < TYPE_2 > > entry : VAR_3 . entrySet ( ) ) { TYPE_1 VAR_5 = new TYPE_1 ( entry . getValue ( ) , entry . getKey ( ) ) ; VAR_5 . METHOD_2 ( TYPE_4 . TYPE_3 ) ; VAR_5 . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) ) ; VAR_1 . add ( VAR_5 ) ; } return VAR_1 ; } |
please check needed | <START> public synchronized void METHOD_1 ( Guid VAR_1 , List < Guid > VAR_2 ) { <END> VAR_3 . METHOD_2 ( ) . METHOD_3 ( ) ; try { if ( ! VAR_4 . containsKey ( VAR_1 ) ) { return ; } synchronized ( VAR_4 . get ( VAR_1 ) ) { Map < Guid , TYPE_1 > map = VAR_4 . get ( VAR_1 ) ; for ( Guid VAR_5 : VAR_2 ) { map . remove ( VAR_5 ) ; } } } finally { VAR_3 . METHOD_2 ( ) . METHOD_4 ( ) ; } } | public void METHOD_1 ( Guid VAR_1 , List < Guid > VAR_2 ) { VAR_3 . METHOD_2 ( ) . METHOD_3 ( ) ; try { if ( ! VAR_4 . containsKey ( VAR_1 ) ) { return ; } synchronized ( VAR_4 . get ( VAR_1 ) ) { Map < Guid , TYPE_1 > map = VAR_4 . get ( VAR_1 ) ; for ( Guid VAR_5 : VAR_2 ) { map . remove ( VAR_5 ) ; } } } finally { VAR_3 . METHOD_2 ( ) . METHOD_4 ( ) ; } } |
I agree vered | private boolean METHOD_1 ( TYPE_1 vm ) { <START> boolean VAR_1 = true ; <END> if ( ! METHOD_2 ( ) && ! TYPE_2 . METHOD_3 ( vm ) ) { METHOD_4 ( TYPE_3 . VAR_3 ) ; VAR_1 = false ; } return VAR_1 ; } | private boolean METHOD_1 ( TYPE_1 vm ) { if ( ! METHOD_2 ( ) && ! TYPE_2 . METHOD_3 ( vm ) ) { METHOD_4 ( TYPE_3 . VAR_3 ) ; return false ; } return true ; } |
relevant images hadnling a LUN VAR_1 | <START> private Guid METHOD_1 ( ) { <END> TYPE_1 VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) . values ( ) . iterator ( ) . next ( ) ; if ( VAR_1 . METHOD_4 ( ) == TYPE_4 . VAR_3 ) { return ( ( TYPE_2 ) VAR_1 ) . METHOD_5 ( ) . get ( 0 ) ; } else { return Guid . TYPE_3 ; } } | private Guid METHOD_1 ( ) { for ( TYPE_1 VAR_1 : METHOD_2 ( ) . METHOD_3 ( ) . values ( ) ) { if ( VAR_1 . METHOD_4 ( ) == TYPE_4 . VAR_3 ) { return ( ( TYPE_2 ) VAR_1 ) . METHOD_5 ( ) . get ( 0 ) ; } } return Guid . TYPE_3 ; } |
return ; statement | private void METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) . METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; <START> return ; <END> } | private void METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) . METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; } |
remove code : ( ! ( return false ; } return true ; simply : return super METHOD_1 ( ) && METHOD_5 ( ) | protected boolean METHOD_1 ( ) { if ( METHOD_2 ( ) == null ) { return METHOD_3 ( TYPE_1 . VAR_2 ) ; } if ( METHOD_2 ( ) . METHOD_4 ( ) ) { return METHOD_3 ( TYPE_1 . VAR_3 ) ; } if ( ! ( super . METHOD_1 ( ) && METHOD_5 ( ) ) ) { return false ; } <START> return true ; <END> } | protected boolean METHOD_1 ( ) { if ( METHOD_2 ( ) == null ) { return METHOD_3 ( TYPE_1 . VAR_2 ) ; } if ( METHOD_2 ( ) . METHOD_4 ( ) ) { return METHOD_3 ( TYPE_1 . VAR_3 ) ; } return ( super . METHOD_1 ( ) && METHOD_5 ( ) ) ; } |
check VAR_1 count doesn t add ll execute query time VAR_1 invoking METHOD_5 ( ) query cases VAR_1 won t delete succeed work | private void METHOD_1 ( ) { <START> List < TYPE_1 > VAR_1 = METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) ) ; <END> if ( VAR_1 . size ( ) > 0 ) { METHOD_2 ( ) . METHOD_5 ( METHOD_4 ( ) ) ; } } | private void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_5 ( METHOD_4 ( ) ) ; } |
forgot inline liner method moti suggested patch #1 : - ) other - good | public static < TYPE_1 > TYPE_2 < TYPE_1 > METHOD_1 ( ) { <START> TYPE_2 < TYPE_1 > VAR_1 = new TYPE_2 < TYPE_1 > ( VAR_2 ) ; <END> return VAR_1 ; } | public static < TYPE_1 > TYPE_2 < TYPE_1 > METHOD_1 ( ) { return new TYPE_2 < TYPE_1 > ( VAR_2 ) ; } |
TYPE_2 replaced loop return statement simplify reading reduce need creating new anonymous class | private TYPE_1 METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> return TYPE_2 . METHOD_2 ( VAR_1 , new TYPE_3 < TYPE_1 > ( ) { <END> @Override public boolean METHOD_3 ( TYPE_1 VAR_2 ) { return VAR_2 . METHOD_4 ( ) . equals ( METHOD_5 ( ) ) ; } } ) ; } | private TYPE_1 METHOD_1 ( List < TYPE_1 > VAR_1 ) { return TYPE_2 . METHOD_2 ( VAR_1 , new TYPE_3 < TYPE_1 > ( ) { @Override public boolean METHOD_3 ( TYPE_1 VAR_2 ) { return VAR_2 . getName ( ) . equals ( METHOD_5 ( ) ) ; } } ) ; } |
please policy tab hidden gluster mode | private void METHOD_1 ( ) { if ( TYPE_1 . METHOD_2 ( ) == TYPE_3 . TYPE_2 ) { VAR_3 . METHOD_3 ( false ) ; VAR_4 . METHOD_3 ( false ) ; <START> VAR_5 . METHOD_3 ( true ) ; <END> VAR_6 . METHOD_4 ( VAR_7 . METHOD_5 ( ) ) ; } } | private void METHOD_1 ( ) { if ( TYPE_1 . METHOD_2 ( ) == TYPE_3 . TYPE_2 ) { VAR_3 . METHOD_3 ( false ) ; VAR_4 . METHOD_3 ( false ) ; VAR_5 . METHOD_3 ( false ) ; VAR_6 . METHOD_4 ( VAR_7 . METHOD_5 ( ) ) ; } } |
I guess need a null check | public boolean METHOD_1 ( ) { <START> return this . VAR_1 > 0 ; <END> } | public boolean METHOD_1 ( ) { return VAR_1 != null && VAR_1 > 0 ; } |
check result empty | public void METHOD_1 ( ) { List < Guid > VAR_1 = new ArrayList < Guid > ( ) ; VAR_1 . add ( VAR_2 ) ; VAR_1 . add ( VAR_3 ) ; VAR_4 . METHOD_2 ( VAR_1 ) ; List < TYPE_1 > VAR_5 = VAR_4 . METHOD_3 ( VAR_6 ) ; <START> assertNotNull ( VAR_5 ) ; <END> } | public void METHOD_1 ( ) { List < Guid > VAR_1 = new ArrayList < Guid > ( ) ; VAR_1 . add ( VAR_2 ) ; VAR_1 . add ( VAR_3 ) ; VAR_4 . METHOD_2 ( VAR_1 ) ; List < TYPE_1 > VAR_5 = VAR_4 . METHOD_3 ( VAR_6 ) ; assertNotNull ( VAR_5 ) ; assertTrue ( VAR_5 . isEmpty ( ) ) ; } |
i need pass SERVER_ID want update status | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( TYPE_3 . VAR_3 , null , TYPE_2 . VAR_5 ) ; <END> TYPE_1 VAR_6 = VAR_1 . METHOD_3 ( TYPE_3 . VAR_3 ) ; assertNotNull ( VAR_6 ) ; assertEquals ( TYPE_2 . VAR_5 , VAR_6 . getStatus ( ) ) ; } | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( TYPE_3 . VAR_3 , TYPE_2 . VAR_5 ) ; TYPE_1 VAR_6 = VAR_1 . METHOD_3 ( TYPE_3 . VAR_3 ) ; assertNotNull ( VAR_6 ) ; assertEquals ( TYPE_2 . VAR_5 , VAR_6 . getStatus ( ) ) ; } |
I meant : METHOD_5 ( ) METHOD_6 ( * VAR_2 getId ( ) * ) | public TYPE_1 METHOD_1 ( ) { List < TYPE_2 > VAR_1 = new ArrayList < TYPE_2 > ( ) ; for ( TYPE_2 VAR_2 : METHOD_2 ( ) . METHOD_3 ( VAR_3 . METHOD_4 ( ) ) ) { <START> for ( TYPE_3 VAR_4 : METHOD_5 ( ) . METHOD_6 ( VAR_3 . METHOD_4 ( ) ) ) { <END> if ( VAR_4 . METHOD_7 ( ) == VAR_5 . getName ( ) ) { VAR_1 . add ( VAR_2 ) ; } } } return METHOD_8 ( VAR_1 , TYPE_4 . VAR_7 ) ; } | public TYPE_1 METHOD_1 ( ) { List < TYPE_2 > VAR_1 = new ArrayList < TYPE_2 > ( ) ; for ( TYPE_2 VAR_2 : METHOD_2 ( ) . METHOD_3 ( VAR_3 . METHOD_4 ( ) ) ) { for ( TYPE_3 VAR_4 : METHOD_5 ( ) . METHOD_6 ( VAR_2 . getId ( ) ) ) { if ( VAR_4 . METHOD_7 ( ) . equals ( VAR_5 . getName ( ) ) ) { VAR_1 . add ( VAR_2 ) ; } } } return METHOD_8 ( VAR_1 , TYPE_4 . VAR_7 ) ; } |
I m troubled line : _CODE_ configuration variable reloadable code won t serve case moved permissive restrictive mode : returning a MAC address VAR_1 address pool done longer VAR_2 | private void METHOD_1 ( String VAR_1 ) { if ( VAR_2 . containsKey ( VAR_1 ) ) { METHOD_2 ( VAR_2 , VAR_1 ) ; <START> VAR_3 . add ( VAR_1 ) ; <END> } else if ( VAR_4 . containsKey ( VAR_1 ) ) { METHOD_2 ( VAR_4 , VAR_1 ) ; } } | private void METHOD_1 ( String VAR_1 ) { if ( VAR_2 . containsKey ( VAR_1 ) ) { METHOD_2 ( VAR_2 , VAR_1 ) ; if ( ! VAR_2 . containsKey ( VAR_1 ) ) { VAR_3 . add ( VAR_1 ) ; } } else if ( VAR_4 . containsKey ( VAR_1 ) ) { METHOD_2 ( VAR_4 , VAR_1 ) ; } } |
I wouldn t a variable return spot method complicated need a variable track s return | private boolean METHOD_1 ( Map < String , Integer > VAR_1 , String VAR_2 ) { <START> boolean VAR_3 = false ; <END> if ( ! VAR_1 . containsKey ( VAR_2 ) ) { VAR_1 . put ( VAR_2 , 1 ) ; VAR_3 = true ; } else if ( METHOD_2 ( ) ) { METHOD_3 ( VAR_1 , VAR_2 ) ; VAR_3 = true ; } return VAR_3 ; } | private boolean METHOD_1 ( Map < String , Integer > VAR_1 , String VAR_2 ) { if ( ! VAR_1 . containsKey ( VAR_2 ) ) { VAR_1 . put ( VAR_2 , 1 ) ; return true ; } else if ( METHOD_2 ( ) ) { METHOD_3 ( VAR_1 , VAR_2 ) ; return true ; } return false ; } |
+ TYPE_3 class METHOD_3 ( ) ? leave space missing dictionaries | public static void METHOD_1 ( ) { log . info ( STRING_1 ) ; VAR_1 . clear ( ) ; for ( TYPE_1 VAR_2 : TYPE_4 < HashSet < TYPE_1 > > METHOD_2 ( TYPE_5 . TYPE_6 ) ) { VAR_1 . put ( VAR_2 , new TYPE_2 ( VAR_2 ) ) ; } <START> log . info ( STRING_2 + TYPE_3 . class . METHOD_3 ( ) ) ; <END> } | public static void METHOD_1 ( ) { log . info ( STRING_1 ) ; VAR_1 . clear ( ) ; for ( TYPE_1 VAR_2 : TYPE_4 < HashSet < TYPE_1 > > METHOD_2 ( TYPE_5 . TYPE_6 ) ) { VAR_1 . put ( VAR_2 , new TYPE_2 ( VAR_2 ) ) ; } log . info ( STRING_2 ) ; } |
vm unlocked super METHOD_1 ( ) ; | protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; <START> METHOD_2 ( ) . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) , TYPE_1 . VAR_2 ) ; <END> } | protected void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) , TYPE_1 . VAR_2 ) ; super . METHOD_1 ( ) ; } |
don t need call super method | protected Map < String , String > METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) && ! METHOD_4 ( ) ) { return Collections . VAR_1 ( METHOD_5 ( ) . toString ( ) , TYPE_2 . TYPE_3 . name ( ) ) ; <START> } <END> return super . METHOD_1 ( ) ; } | protected Map < String , String > METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) && ! METHOD_4 ( ) ) { return Collections . VAR_1 ( METHOD_5 ( ) . toString ( ) , TYPE_2 . TYPE_3 . name ( ) ) ; } return null ; } |
a potential NPE VAR_2 initialized I d suggest changing : Map < String String > METHOD_1 ( ) { ( VAR_2 = = null ) { VAR_2 = super METHOD_1 ( ) ; ( VAR_1 ! = null ) { VAR_2 put ( TYPE_1 VAR_4 VAR_1 getName ( ) ) ; } } return VAR_2 ; } | <START> public Map < String , String > METHOD_1 ( ) { <END> if ( VAR_1 != null ) { if ( VAR_2 == null ) { VAR_2 = super . METHOD_1 ( ) ; } VAR_2 . put ( TYPE_1 . VAR_4 , VAR_1 . getName ( ) ) ; } return VAR_2 ; } | public Map < String , String > METHOD_1 ( ) { if ( VAR_1 == null ) { return super . METHOD_1 ( ) ; } if ( VAR_2 == null ) { VAR_2 = super . METHOD_1 ( ) ; } VAR_2 . put ( TYPE_1 . VAR_4 , VAR_1 . getName ( ) ) ; return VAR_2 ; } |
code necessary s DAO responsibility return empty list VAR_1 de - facto contract system | protected List < TYPE_1 > METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; <START> if ( VAR_1 == null ) { <END> VAR_1 = TYPE_2 < TYPE_1 > METHOD_6 ( ) ; } } return VAR_1 ; } | protected List < TYPE_1 > METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; } return VAR_1 ; } |
assertEquals compare objects compare TYPE_2 objects : assertEquals ( TYPE_2 TYPE_3 VAR_1 METHOD_1 ( ) ) ; file | public void METHOD_1 ( ) throws Exception { <START> assertEquals ( TYPE_2 . TYPE_3 . getMessage ( ) , VAR_1 . METHOD_1 ( ) . getMessage ( ) ) ; <END> } | public void METHOD_1 ( ) throws Exception { assertEquals ( TYPE_2 . TYPE_3 , VAR_1 . METHOD_1 ( ) ) ; } |
please replace METHOD_2 ( ) ( ) entire file i e ( VAR_1 METHOD_3 ( ) ) _CODE_ ( null ) ; | public void METHOD_1 ( ) throws Exception { <START> METHOD_2 ( null ) . when ( VAR_1 ) . METHOD_3 ( ) ; <END> assertEquals ( new TYPE_1 ( TYPE_2 . VAR_3 ) . getMessage ( ) , VAR_1 . METHOD_4 ( ) . getMessage ( ) ) ; } | public void METHOD_1 ( ) throws Exception { METHOD_2 ( null ) . when ( VAR_1 ) . METHOD_3 ( ) ; assertEquals ( new TYPE_1 ( TYPE_2 . VAR_3 ) , VAR_1 . METHOD_4 ( ) ) ; } |
done | public TYPE_9 ( TYPE_1 < TYPE_2 , TYPE_3 > VAR_2 ) { super ( VAR_2 ) ; VAR_3 = new TYPE_4 ( ) ; METHOD_1 ( TYPE_7 . VAR_5 . METHOD_2 ( this ) ) ; <START> TYPE_8 . VAR_7 . METHOD_3 ( this ) ; <END> VAR_8 = new TYPE_5 ( VAR_3 , 1 , 1 ) ; VAR_8 . METHOD_4 ( new TYPE_6 ( VAR_9 . METHOD_5 ( ) , name , 0 , 0 ) ) ; } | public TYPE_9 ( TYPE_1 < TYPE_2 , TYPE_3 > VAR_2 ) { super ( VAR_2 ) ; VAR_3 = new TYPE_4 ( ) ; METHOD_1 ( TYPE_7 . VAR_5 . METHOD_2 ( this ) ) ; VAR_7 . METHOD_3 ( this ) ; VAR_8 = new TYPE_5 ( VAR_3 , 1 , 1 ) ; VAR_8 . METHOD_4 ( new TYPE_6 ( VAR_9 . METHOD_5 ( ) , name , 0 , 0 ) ) ; } |
done | public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> TYPE_2 . VAR_3 . METHOD_2 ( METHOD_3 ( ) ) ; <END> VAR_4 . update ( METHOD_3 ( ) ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_3 . METHOD_2 ( METHOD_3 ( ) ) ; VAR_4 . update ( METHOD_3 ( ) ) ; } |
needed METHOD_2 method performs check doees a atomic synchronized modifier required | public static synchronized void METHOD_1 ( TYPE_1 value ) { <START> if ( ! VAR_1 . containsKey ( value . VAR_2 ( ) ) ) <END> VAR_1 . METHOD_2 ( value . VAR_2 ( ) , value ) ; } | public void METHOD_1 ( TYPE_1 value ) { VAR_1 . METHOD_2 ( value . VAR_2 ( ) , value ) ; } |
remove method _CODE_ performs synchronization synchronized modifier required | <START> public static synchronized void METHOD_1 ( String key ) { <END> if ( key != null ) { VAR_1 . remove ( key ) ; } } | public void METHOD_1 ( String key ) { if ( key != null ) { VAR_1 . remove ( key ) ; } } |
return statement line : return VAR_1 ( key ) ; | public static TYPE_1 METHOD_1 ( String key ) { TYPE_1 value = VAR_1 . get ( key ) ; <START> return value ; <END> } | public TYPE_1 METHOD_1 ( String key ) { return VAR_1 . get ( key ) ; } |
won t VAR_1 remove ( ) enough | public static synchronized void METHOD_1 ( String key ) { if ( VAR_1 . containsKey ( key ) ) { VAR_1 . remove ( key ) ; <START> } <END> } | public static synchronized void METHOD_1 ( String key ) { if ( key != null ) { VAR_1 . remove ( key ) ; } } |
action shouldn t fail : & _CODE_ ( ) _CODE_ = = _CODE_ ( ) _CODE_ ( ) | protected boolean METHOD_1 ( ) { boolean VAR_1 = super . METHOD_1 ( ) ; if ( VAR_1 && ( getParameters ( ) . METHOD_2 ( ) == null ^ getParameters ( ) . METHOD_3 ( ) == null ) ) { METHOD_4 ( TYPE_1 . VAR_3 ) ; VAR_1 = false ; } <START> if ( getParameters ( ) . METHOD_5 ( ) != null && ! METHOD_6 ( ) . METHOD_7 ( ) ) { <END> METHOD_4 ( TYPE_1 . VAR_4 ) ; VAR_1 = false ; } return VAR_1 ; } | protected boolean METHOD_1 ( ) { boolean VAR_1 = super . METHOD_1 ( ) ; if ( VAR_1 && ( getParameters ( ) . METHOD_2 ( ) == null ^ getParameters ( ) . METHOD_3 ( ) == null ) ) { METHOD_4 ( TYPE_1 . VAR_3 ) ; VAR_1 = false ; } return VAR_1 ; } |
StringUtils _CODE_ ( source ) | public final static String METHOD_1 ( String source , String VAR_1 , String VAR_2 , String VAR_3 ) throws Exception { try { String result = "" ; <START> if ( ! TYPE_1 . METHOD_2 ( source . trim ( ) ) ) { <END> TYPE_2 VAR_4 = TYPE_3 . METHOD_3 ( VAR_1 , VAR_2 , VAR_5 ) ; result = METHOD_1 ( source , VAR_4 . METHOD_4 ( VAR_3 ) ) ; } return result ; } catch ( Exception e ) { log . error ( STRING_1 , e ) ; throw e ; } } | public final static String METHOD_1 ( String source , String VAR_1 , String VAR_2 , String VAR_3 ) throws Exception { try { String result = "" ; if ( source . trim ( ) . length ( ) > 0 ) { TYPE_2 VAR_4 = TYPE_3 . METHOD_3 ( VAR_1 , VAR_2 , VAR_5 ) ; result = METHOD_1 ( source , VAR_4 . METHOD_4 ( VAR_3 ) ) ; } return result ; } catch ( Exception e ) { log . error ( STRING_1 , e ) ; throw e ; } } |
related change isn t some enum instead hardcoded STRING_1 | public String getMessage ( ) { <START> return ( STRING_1 . equalsIgnoreCase ( VAR_1 . METHOD_1 ( ) ) ) ? "" : VAR_1 ; <END> } | public String getMessage ( ) { return ( STRING_1 . equalsIgnoreCase ( VAR_1 ) ) ? "" : VAR_1 ; } |
null check _CODE_ ( ) METHOD_1 ( ) | protected void METHOD_1 ( ) { final TYPE_1 VAR_1 = getParameters ( ) . METHOD_2 ( ) ; <START> if ( VAR_1 != null ) { <END> METHOD_3 ( VAR_1 , METHOD_4 ( ) ) ; METHOD_5 ( ) . METHOD_6 ( VAR_1 . getId ( ) ) ; METHOD_5 ( ) . METHOD_7 ( true ) ; } } | protected void METHOD_1 ( ) { final TYPE_1 VAR_1 = getParameters ( ) . METHOD_2 ( ) ; METHOD_3 ( VAR_1 , METHOD_4 ( ) ) ; METHOD_5 ( ) . METHOD_6 ( VAR_1 . getId ( ) ) ; METHOD_5 ( ) . METHOD_7 ( true ) ; } |
please case - sensitive comparison | public static boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return TYPE_3 < String > METHOD_2 ( TYPE_4 . TYPE_2 ) . equalsIgnoreCase ( VAR_1 . getName ( ) ) ; <END> } | public static boolean METHOD_1 ( TYPE_1 VAR_1 ) { return TYPE_3 < String > METHOD_2 ( TYPE_4 . TYPE_2 ) . equals ( VAR_1 . getName ( ) ) ; } |
private static | <START> protected TYPE_1 METHOD_1 ( int VAR_1 , Guid VAR_2 ) { <END> TYPE_1 VAR_3 = new TYPE_1 ( ) ; VAR_3 . METHOD_2 ( TYPE_2 . TYPE_3 ) ; VAR_3 . METHOD_3 ( TYPE_5 . TYPE_4 ) ; VAR_3 . METHOD_4 ( VAR_1 ) ; VAR_3 . METHOD_5 ( VAR_8 ) ; VAR_3 . METHOD_6 ( VAR_2 ) ; return VAR_3 ; } | private static TYPE_1 METHOD_1 ( int VAR_1 , Guid VAR_2 ) { TYPE_1 VAR_3 = new TYPE_1 ( ) ; VAR_3 . METHOD_2 ( TYPE_2 . TYPE_3 ) ; VAR_3 . METHOD_3 ( TYPE_5 . TYPE_4 ) ; VAR_3 . METHOD_4 ( VAR_1 ) ; VAR_3 . METHOD_5 ( VAR_8 ) ; VAR_3 . METHOD_6 ( VAR_2 ) ; return VAR_3 ; } |
1 error needed removed ( _CODE_ user ) _CODE_ query2 please remove exception _CODE_ ( ) youmake _CODE_ admin - wellthanks | public TYPE_1 list ( ) { if ( METHOD_1 ( ) ) { <START> throw new TYPE_2 ( Response . Status . VAR_1 ) ; <END> } TYPE_3 VAR_2 = METHOD_2 ( ) . get ( TYPE_3 . class ) ; if ( VAR_2 == TYPE_3 . TYPE_4 ) { return METHOD_3 ( ) ; } else { return METHOD_4 ( ) ; } } | public TYPE_1 list ( ) { TYPE_3 VAR_2 = METHOD_2 ( ) . get ( TYPE_3 . class ) ; if ( VAR_2 == TYPE_3 . TYPE_4 ) { return METHOD_3 ( ) ; } else { return METHOD_4 ( ) ; } } |
easier read a positive check a negative | private static int METHOD_1 ( String VAR_1 , String VAR_2 ) { int VAR_3 = ( ( Integer ) Integer . parseInt ( VAR_1 ) ) . METHOD_2 ( Integer . parseInt ( VAR_2 ) ) ; <START> return VAR_3 != 0 ? VAR_3 : METHOD_3 ( VAR_1 , VAR_2 ) ; <END> } | private static int METHOD_1 ( String VAR_1 , String VAR_2 ) { int VAR_3 = ( ( Integer ) Integer . parseInt ( VAR_1 ) ) . METHOD_2 ( Integer . parseInt ( VAR_2 ) ) ; return VAR_3 == 0 ? METHOD_3 ( VAR_1 , VAR_2 ) : VAR_3 ; } |
need else word s code more confusing opinion | private boolean METHOD_1 ( ) { TYPE_1 vm = METHOD_2 ( ) ; Guid VAR_1 = METHOD_3 ( ) ; VAR_2 = vm . VAR_3 ( ) . size ( ) > 0 ; if ( getParameters ( ) . METHOD_4 ( ) && VAR_2 ) { if ( ! METHOD_5 ( null ) ) { return false ; <START> } else if ( METHOD_6 ( ) . METHOD_7 ( ) . isEmpty ( ) ) { <END> METHOD_8 ( ) ; } } else { METHOD_8 ( ) ; } return true ; } | private boolean METHOD_1 ( ) { TYPE_1 vm = METHOD_2 ( ) ; VAR_2 = vm . VAR_3 ( ) . size ( ) > 0 ; if ( getParameters ( ) . METHOD_4 ( ) && VAR_2 ) { if ( ! METHOD_5 ( null ) ) { return false ; } } else { METHOD_8 ( ) ; } return true ; } |
METHOD_3 ( ) instead fetching disk | private boolean METHOD_1 ( Guid VAR_1 , Guid VAR_2 ) { TYPE_1 VAR_3 = METHOD_2 ( VAR_1 ) ; <START> Guid VAR_4 = VAR_3 . METHOD_3 ( ) . getValue ( ) ; <END> TYPE_2 VAR_5 = METHOD_4 ( VAR_2 , VAR_4 ) ; return METHOD_5 ( VAR_5 . METHOD_6 ( ) ) && METHOD_5 ( VAR_5 . METHOD_7 ( ) ) ; } | private boolean METHOD_1 ( Guid VAR_1 , Guid VAR_2 ) { TYPE_2 VAR_5 = METHOD_4 ( VAR_2 , METHOD_3 ( ) . getValue ( ) ) ; return METHOD_5 ( VAR_5 . METHOD_6 ( ) ) && METHOD_5 ( VAR_5 . METHOD_7 ( ) ) ; } |
extra semicolon | public TYPE_4 ( Map < TYPE_1 , Object > VAR_2 ) { <START> this ( VAR_2 , new TYPE_2 < TYPE_3 , Object > ( TYPE_3 . class ) ) ; ; <END> } | public TYPE_4 ( Map < TYPE_1 , Object > VAR_2 ) { this ( VAR_2 , new TYPE_2 < TYPE_3 , Object > ( TYPE_3 . class ) ) ; } |
please set a modifier - protected suitable | <START> boolean METHOD_1 ( ) { <END> if ( METHOD_2 ( ) == null ) { return METHOD_3 ( TYPE_1 . VAR_2 ) ; } return true ; } | protected boolean METHOD_1 ( ) { if ( METHOD_2 ( ) == null ) { return METHOD_3 ( TYPE_1 . VAR_2 ) ; } return true ; } |
protected access modifier instead default ( - ) | <START> boolean METHOD_1 ( ) { <END> return METHOD_2 ( ) . METHOD_3 ( ) && getParameters ( ) . METHOD_4 ( ) ; } | protected boolean METHOD_1 ( ) { return METHOD_2 ( ) . METHOD_3 ( ) && getParameters ( ) . METHOD_4 ( ) ; } |
encapsulate METHOD_3 ( ) METHOD_2 ( ) METHOD_3 ( ) | private TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { <START> VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) . get ( getParameters ( ) . METHOD_4 ( ) . getId ( ) ) ; <END> } return VAR_1 ; } | private TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = METHOD_3 ( ) . get ( getParameters ( ) . METHOD_4 ( ) . getId ( ) ) ; } return VAR_1 ; } |
done METHOD_1 method ? logic other appended version parts | public String getValue ( ) { final StringBuilder val = new StringBuilder ( ) ; if ( this . VAR_1 > - 1 ) <START> val . append ( this . VAR_1 ) ; <END> METHOD_1 ( val , this . VAR_2 ) ; METHOD_1 ( val , this . build ) ; METHOD_1 ( val , this . VAR_3 ) ; return val . toString ( ) ; } | public String getValue ( ) { final StringBuilder val = new StringBuilder ( ) ; if ( this . VAR_1 > - 1 ) { val . append ( this . VAR_1 ) ; } METHOD_1 ( val , this . VAR_2 ) ; METHOD_1 ( val , this . build ) ; METHOD_1 ( val , this . VAR_3 ) ; return val . toString ( ) ; } |
a reason static ? isn t declared private method | <START> static void METHOD_1 ( StringBuilder val , int VAR_1 ) { <END> if ( VAR_1 > - 1 ) { if ( val . length ( ) != 0 ) { val . append ( STRING_1 ) ; } val . append ( VAR_1 ) ; } } | private static void METHOD_1 ( StringBuilder val , int VAR_1 ) { if ( VAR_1 > - 1 ) { if ( val . length ( ) != 0 ) { val . append ( STRING_1 ) ; } val . append ( VAR_1 ) ; } } |
protected | <START> public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 parameters ) <END> throws TYPE_4 { TYPE_1 VAR_2 = METHOD_2 ( ) . METHOD_3 ( VAR_1 , parameters ) ; if ( ! VAR_2 . METHOD_4 ( ) ) { throw new TYPE_4 ( VAR_2 . METHOD_5 ( ) . METHOD_6 ( ) , VAR_2 . METHOD_5 ( ) . getMessage ( ) ) ; } return VAR_2 ; } | protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 parameters ) throws TYPE_4 { TYPE_1 VAR_2 = METHOD_2 ( ) . METHOD_3 ( VAR_1 , parameters ) ; if ( ! VAR_2 . METHOD_4 ( ) ) { throw new TYPE_4 ( VAR_2 . METHOD_5 ( ) . METHOD_6 ( ) , VAR_2 . METHOD_5 ( ) . getMessage ( ) ) ; } return VAR_2 ; } |
VAR_1 ( ) defined List < TYPE_1 > I d initialize arraylist _CODE_ METHOD_2 ( ) size ( ) + VAR_2 METHOD_3 ( ) size ( ) add items s a matter taste | protected void METHOD_1 ( ) { <START> ArrayList < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( VAR_2 . METHOD_2 ( ) ) ; <END> VAR_1 . addAll ( VAR_2 . METHOD_3 ( ) . values ( ) ) ; TYPE_2 . METHOD_1 ( METHOD_4 ( ) , METHOD_5 ( ) , VAR_2 , VAR_2 . METHOD_6 ( ) , true , VAR_1 , VAR_3 , VAR_4 ) ; } | protected void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( VAR_2 . METHOD_2 ( ) ) ; VAR_1 . addAll ( VAR_2 . METHOD_3 ( ) . values ( ) ) ; TYPE_2 . METHOD_1 ( METHOD_4 ( ) , METHOD_5 ( ) , VAR_2 , VAR_2 . METHOD_6 ( ) , true , VAR_1 , VAR_3 , VAR_4 ) ; } |
case don t need create instance - remove ( provided = true ) declaration remove VAR_3 = new TYPE_2 < TYPE_3 > ( ) ; completely TYPE_7 ui xml declare a new namespace : xmlns : l = urn : import : org ovirt engine ui common widget label replace < g : _CODE_ ui : field = VAR_3 < l : TYPE_2 ui : field = VAR_3 | public TYPE_7 ( TYPE_1 VAR_2 ) { <START> VAR_3 = new TYPE_2 < TYPE_3 > ( ) ; <END> METHOD_1 ( TYPE_4 . VAR_5 . METHOD_2 ( this ) ) ; TYPE_6 . VAR_7 . METHOD_3 ( this ) ; TYPE_5 . VAR_9 . METHOD_4 ( this ) ; } | public TYPE_7 ( TYPE_1 VAR_2 ) { METHOD_1 ( TYPE_4 . VAR_5 . METHOD_2 ( this ) ) ; TYPE_6 . VAR_7 . METHOD_3 ( this ) ; TYPE_5 . VAR_9 . METHOD_4 ( this ) ; } |
t NPE ? user case internal command | public String toString ( ) { StringBuilder builder = new StringBuilder ( INT_1 ) ; builder . append ( STRING_1 ) ; builder . append ( METHOD_1 ( ) ) ; builder . append ( STRING_2 ) ; <START> builder . append ( METHOD_2 ( ) . METHOD_3 ( ) ) ; <END> builder . append ( STRING_3 ) ; builder . append ( METHOD_4 ( ) ) ; return builder . toString ( ) ; } | public String toString ( ) { StringBuilder builder = new StringBuilder ( INT_1 ) ; builder . append ( STRING_1 ) ; builder . append ( METHOD_1 ( ) ) ; builder . append ( STRING_2 ) ; if ( METHOD_2 ( ) != null ) { builder . append ( METHOD_2 ( ) . METHOD_3 ( ) ) ; } builder . append ( STRING_3 ) ; builder . append ( METHOD_4 ( ) ) ; return builder . toString ( ) ; } |
missing log debug ( builder toString ( ) ) ; | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 params ) { if ( log . VAR_2 ( ) ) { StringBuilder builder = new StringBuilder ( INT_1 ) ; builder . append ( STRING_1 ) ; builder . append ( VAR_1 ) ; builder . append ( STRING_2 ) ; <START> builder . append ( params ) ; <END> } } | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 params ) { if ( log . VAR_2 ( ) ) { StringBuilder builder = new StringBuilder ( INT_1 ) ; builder . append ( STRING_1 ) ; builder . append ( VAR_1 ) ; builder . append ( STRING_2 ) ; builder . append ( params ) ; log . debug ( builder . toString ( ) ) ; } } |
consider removing else clause | private Guid METHOD_1 ( TYPE_1 VAR_1 ) { if ( getParameters ( ) . METHOD_2 ( ) != null && getParameters ( ) . METHOD_2 ( ) . get ( VAR_1 . getId ( ) ) != null ) { return getParameters ( ) . METHOD_2 ( ) . get ( VAR_1 . getId ( ) ) . METHOD_3 ( ) ; <START> } else { <END> return VAR_1 . METHOD_3 ( ) ; } } | private Guid METHOD_1 ( TYPE_1 VAR_1 ) { if ( getParameters ( ) . METHOD_2 ( ) != null && getParameters ( ) . METHOD_2 ( ) . get ( VAR_1 . getId ( ) ) != null ) { return getParameters ( ) . METHOD_2 ( ) . get ( VAR_1 . getId ( ) ) . METHOD_3 ( ) ; } return VAR_1 . METHOD_3 ( ) ; } |
minor : please < operator > null convention | private TYPE_1 METHOD_1 ( final TYPE_2 [ ] VAR_1 ) { TYPE_1 VAR_2 = null ; <START> if ( null != VAR_1 ) { <END> for ( TYPE_2 VAR_3 : VAR_1 ) { if ( TYPE_3 . equalsIgnoreCase ( VAR_3 . getName ( ) ) ) { VAR_2 = TYPE_4 . METHOD_2 ( VAR_3 . getValue ( ) ) ; break ; } } } return VAR_2 ; } | private TYPE_1 METHOD_1 ( final TYPE_2 [ ] VAR_1 ) { TYPE_1 VAR_2 = null ; if ( VAR_1 != null ) { for ( TYPE_2 VAR_3 : VAR_1 ) { if ( TYPE_3 . equalsIgnoreCase ( VAR_3 . getName ( ) ) ) { VAR_2 = TYPE_4 . METHOD_2 ( VAR_3 . getValue ( ) ) ; break ; } } } return VAR_2 ; } |
needed enum | public void METHOD_1 ( TYPE_1 value ) { <START> for ( Object VAR_1 : METHOD_2 ( ) . METHOD_3 ( ) ) { <END> if ( ( ( TYPE_2 ) VAR_1 ) . METHOD_4 ( ) == value ) { METHOD_2 ( ) . METHOD_5 ( VAR_1 ) ; break ; } } } | public void METHOD_1 ( TYPE_1 value ) { METHOD_2 ( ) . METHOD_5 ( value ) ; } |
convert some logic ( e g source null return emtpy list ) enough return source ; converter | public static void METHOD_1 ( TYPE_1 VAR_1 , Guid id ) { VAR_1 . VAR_2 = new TYPE_2 ( ) { @Override public Object METHOD_2 ( Object source , TYPE_1 VAR_3 ) <START> { <END> ArrayList < TYPE_3 > VAR_4 = ( ArrayList < TYPE_3 > ) source ; return VAR_4 ; } } ; TYPE_4 . METHOD_3 ( TYPE_7 . TYPE_6 , new TYPE_5 ( id ) , VAR_1 ) ; } | public static void METHOD_1 ( TYPE_1 VAR_1 , Guid id ) { VAR_1 . VAR_2 = new TYPE_2 ( ) { @Override public Object METHOD_2 ( Object source , TYPE_1 VAR_3 ) { if ( source == null ) { return new ArrayList < TYPE_3 > ( ) ; } return source ; } } ; TYPE_4 . METHOD_3 ( TYPE_7 . TYPE_6 , new TYPE_5 ( id ) , VAR_1 ) ; } |
I don t check calling method extracting method _CODE_ ( a similar method _CODE_ ( network ) extract a method _CODE_ ( String ) method ) | private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( ! TYPE_3 < String > METHOD_2 ( TYPE_4 . TYPE_2 ) . equals ( VAR_1 . METHOD_3 ( ) ) ) { <END> return true ; } if ( VAR_1 . METHOD_4 ( ) == TYPE_5 . VAR_6 && vds . VAR_7 ( ) . METHOD_5 ( TYPE_6 . VAR_9 ) ) { return StringUtils . equals ( vds . VAR_7 ( ) , VAR_1 . METHOD_6 ( ) ) ; } return true ; } | private boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_4 ( ) == TYPE_5 . VAR_6 && vds . VAR_7 ( ) . METHOD_5 ( TYPE_6 . VAR_9 ) ) { return StringUtils . equals ( vds . VAR_7 ( ) , VAR_1 . METHOD_6 ( ) ) ; } return true ; } |
super ref needed | protected Guid METHOD_1 ( ) { if ( VAR_1 == null ) { <START> return super . METHOD_1 ( VAR_2 ) ; <END> } TYPE_1 VAR_3 = METHOD_2 ( ) . get ( VAR_1 . METHOD_3 ( ) ) ; if ( VAR_3 . getStatus ( ) == TYPE_2 . TYPE_3 ) { return VAR_3 . getId ( ) ; } return super . METHOD_1 ( VAR_2 ) ; } | protected Guid METHOD_1 ( ) { if ( VAR_1 == null ) { return METHOD_1 ( VAR_2 ) ; } TYPE_1 VAR_3 = METHOD_2 ( ) . get ( VAR_1 . METHOD_3 ( ) ) ; if ( VAR_3 . getStatus ( ) == TYPE_2 . TYPE_3 ) { return VAR_3 . getId ( ) ; } return super . METHOD_1 ( VAR_2 ) ; } |
NPE - VAR_6 null I VAR_6 null null passed method advanceddetails bricks fetched | private TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( TYPE_4 . TYPE_5 , new TYPE_3 ( METHOD_3 ( ) , VAR_5 , <START> VAR_1 , <END> VAR_6 . METHOD_4 ( ) , VAR_7 ) ) ; return ( TYPE_1 ) VAR_2 . METHOD_5 ( ) ; } | private TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( TYPE_4 . TYPE_5 , new TYPE_3 ( METHOD_3 ( ) , VAR_5 , VAR_1 , VAR_6 == null ? null : VAR_6 . METHOD_4 ( ) , VAR_7 ) ) ; return ( TYPE_1 ) VAR_2 . METHOD_5 ( ) ; } |
sense ? - vm VAR_5 a _CODE_ ? I scenario blocked allowed arrive state | private boolean METHOD_1 ( TYPE_1 VAR_1 , Map < String , TYPE_2 > VAR_2 , boolean VAR_3 ) { boolean VAR_4 = true ; if ( ! VAR_1 . METHOD_2 ( ) ) { VAR_4 = false ; } else if ( VAR_3 ) { TYPE_2 VAR_5 = VAR_2 . get ( VAR_1 . METHOD_3 ( ) ) ; <START> VAR_4 = VAR_5 . METHOD_4 ( ) . METHOD_5 ( ) && VAR_5 . METHOD_6 ( ) ; <END> } return VAR_4 ; } | private boolean METHOD_1 ( TYPE_1 VAR_1 , Map < String , TYPE_2 > VAR_2 , boolean VAR_3 ) { boolean VAR_4 = true ; if ( ! VAR_1 . METHOD_2 ( ) ) { VAR_4 = false ; } else if ( VAR_3 ) { VAR_4 = VAR_2 . get ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( ) . METHOD_5 ( ) ; } return VAR_4 ; } |
option move ctor other place ? execute ? a feels related ctor | public TYPE_1 ( T parameters ) { super ( parameters ) ; <START> VAR_2 . addAll ( METHOD_1 ( ) . METHOD_2 ( METHOD_3 ( ) ) ) ; <END> } | public TYPE_1 ( T parameters ) { super ( parameters ) ; } |
calling super METHOD_1 i guess return true | protected boolean METHOD_1 ( ) { if ( ! super . METHOD_1 ( ) ) { return false ; } List < TYPE_1 > VAR_1 = METHOD_2 ( ) . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) , TYPE_3 . TYPE_4 . getName ( ) ) ; if ( VAR_1 . isEmpty ( ) ) { return METHOD_5 ( TYPE_5 . VAR_3 ) ; } <START> return super . METHOD_1 ( ) ; <END> } | protected boolean METHOD_1 ( ) { if ( ! super . METHOD_1 ( ) ) { return false ; } List < TYPE_1 > VAR_1 = METHOD_2 ( ) . METHOD_3 ( getParameters ( ) . getId ( ) , TYPE_3 . TYPE_4 . getName ( ) ) ; if ( VAR_1 . isEmpty ( ) ) { return METHOD_5 ( TYPE_5 . VAR_3 ) ; } return true ; } |
throwing exception | protected void METHOD_1 ( ) { <START> throw new TYPE_1 ( STRING_1 ) ; <END> } | protected void METHOD_1 ( ) { } |
METHOD_7 ( true ) enough update command | protected void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; TYPE_1 VAR_2 = VAR_1 . get ( 0 ) ; VAR_2 . METHOD_3 ( METHOD_4 ( ) ) ; METHOD_5 ( ) . update ( VAR_2 ) ; <START> METHOD_6 ( VAR_2 ) ; <END> METHOD_7 ( true ) ; } | protected void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; TYPE_1 VAR_2 = VAR_1 . get ( 0 ) ; VAR_2 . METHOD_3 ( METHOD_4 ( ) ) ; METHOD_5 ( ) . update ( VAR_2 ) ; METHOD_7 ( true ) ; } |
METHOD_1 ( ) execute additional queries complete entity whilewhat reside _CODE_ | protected TYPE_1 METHOD_1 ( TYPE_1 model , TYPE_2 entity ) { model . VAR_1 ( entity . VAR_2 ( ) == null ? null : entity . VAR_2 ( ) . name ( ) ) ; model . VAR_3 ( entity . VAR_4 ( ) == null ? null : entity . VAR_4 ( ) . name ( ) ) ; model . VAR_5 ( entity . getId ( ) . toString ( ) ) ; <START> return model ; <END> } | protected TYPE_1 METHOD_1 ( TYPE_1 model , TYPE_2 entity ) { return model ; } |
s true - - - > return entity getId ( ) equals ( id ) ; cut corners | protected < T > boolean METHOD_1 ( TYPE_1 entity , T id ) { <START> return true ; <END> } | protected < T > boolean METHOD_1 ( TYPE_1 entity , T id ) { return entity . getId ( ) . equals ( id ) ; } |
bare mind external task injection feature eli introduce a map _CODE_ TYPE_2 addition TYPE_2 evicted ( due LFU - btw LFU LRU ? ) - restore context due cache miss ? please elaborate | private TYPE_4 ( ) { VAR_2 = TYPE_5 < TYPE_1 , TYPE_2 > METHOD_1 ( VAR_4 ) ; <START> VAR_5 = TYPE_5 < TYPE_1 , TYPE_3 > METHOD_1 ( VAR_6 ) ; <END> } | private TYPE_4 ( ) { VAR_2 = TYPE_5 < TYPE_1 , TYPE_2 > METHOD_1 ( VAR_4 ) ; } |
instead iterating List < TYPE_2 > request Map < String TYPE_2 > - mapping VAR_3 getPath ( ) TYPE_2 instance avoid O ( n ) access due iteration favor O ( 1 ) access due map access regard TYPE_2 instance | private String METHOD_1 ( final String path ) { String result = null ; if ( TYPE_1 . METHOD_2 ( path ) ) { List < TYPE_2 > VAR_1 = VAR_2 . METHOD_3 ( ) ; for ( TYPE_2 VAR_3 : VAR_1 ) { <START> if ( path . startsWith ( VAR_3 . getPath ( ) ) ) { <END> result = VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) + path ; } } } else { log . error ( STRING_1 + path + STRING_2 ) ; } return result ; } | String METHOD_1 ( final String path ) { String result = null ; if ( TYPE_1 . METHOD_2 ( path ) ) { result = VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) + path ; } else { log . error ( STRING_1 + path + STRING_2 ) ; } return result ; } |
excellent change ! + 1 | <START> protected TYPE_1 METHOD_1 ( final TYPE_2 request ) <END> throws TYPE_3 { TYPE_1 VAR_1 = METHOD_2 ( ) ; for ( TYPE_4 VAR_2 : TYPE_4 . values ( ) ) { if ( request . VAR_3 ( VAR_2 . METHOD_3 ( ) ) != null ) { VAR_1 . update ( request . VAR_3 ( VAR_2 . METHOD_3 ( ) ) . toString ( ) . METHOD_4 ( ) ) ; } } return VAR_1 ; } | protected TYPE_1 METHOD_1 ( final TYPE_2 request ) throws TYPE_3 { TYPE_1 VAR_1 = METHOD_2 ( ) ; for ( TYPE_4 VAR_2 : TYPE_4 . values ( ) ) { if ( request . VAR_3 ( VAR_2 . getKey ( ) ) != null ) { VAR_1 . update ( request . VAR_3 ( VAR_2 . getKey ( ) ) . toString ( ) . METHOD_4 ( ) ) ; } } return VAR_1 ; } |
new File ( VAR_2 VAR_4 ) remove / VAR_4 | public TYPE_1 ( final File VAR_2 ) { <START> VAR_3 = new File ( VAR_2 + VAR_4 ) ; <END> } | public TYPE_1 ( final File VAR_2 ) { VAR_3 = new File ( VAR_2 , VAR_4 ) ; } |
need call super | public TYPE_2 ( String VAR_2 , TYPE_1 context ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; this . context = context ; } | public TYPE_2 ( String VAR_2 , TYPE_1 context ) { this . VAR_2 = VAR_2 ; this . context = context ; } |
METHOD_2 ( ) checked METHOD_4 ( ) return null NPE | protected boolean METHOD_1 ( ) { return METHOD_2 ( ) != null && <START> METHOD_3 ( new TYPE_1 ( METHOD_4 ( ) ) . METHOD_5 ( ) ) ; <END> } | protected boolean METHOD_1 ( ) { return METHOD_4 ( ) != null && METHOD_3 ( new TYPE_1 ( METHOD_4 ( ) ) . METHOD_5 ( ) ) ; } |
s checked vm / paused / line 45 reach vm locked | protected boolean METHOD_1 ( ) { VAR_1 = METHOD_2 ( ) . get ( getParameters ( ) . METHOD_3 ( ) ) ; return METHOD_4 ( ) && METHOD_5 ( ) && METHOD_6 ( VAR_1 ) && METHOD_7 ( ) && METHOD_8 ( ) && <START> METHOD_9 ( ) ; <END> } | protected boolean METHOD_1 ( ) { VAR_1 = METHOD_2 ( ) . get ( getParameters ( ) . METHOD_3 ( ) ) ; return METHOD_4 ( ) && METHOD_5 ( ) && METHOD_6 ( VAR_1 ) && METHOD_7 ( ) && METHOD_8 ( ) ; } |
awesome add a method METHOD_2 ( ) return TYPE_3 getInstance ( ) METHOD_2 I promised explanation I provide ( mocking life easier a step dependency injection ) | protected TYPE_1 METHOD_1 ( Guid TYPE_4 ) { <START> TYPE_2 VAR_2 = TYPE_3 . getInstance ( ) . METHOD_2 ( ) . get ( TYPE_4 ) ; <END> if ( VAR_2 != null ) { return VAR_2 . METHOD_3 ( ) ; } else { log . VAR_3 ( STRING_1 , getParameters ( ) . METHOD_4 ( ) ) ; return null ; } } | protected TYPE_1 METHOD_1 ( Guid TYPE_4 ) { TYPE_2 VAR_2 = METHOD_2 ( ) . get ( TYPE_4 ) ; if ( VAR_2 != null ) { return VAR_2 . METHOD_3 ( ) ; } else { log . VAR_3 ( STRING_1 , getParameters ( ) . METHOD_4 ( ) ) ; return null ; } } |
redundant _CODE_ ( ) _CODE_ ( false ) _CODE_ | public void METHOD_1 ( final TYPE_1 object ) { super . METHOD_1 ( object ) ; info . VAR_1 ( false ) ; message . VAR_1 ( false ) ; <START> VAR_2 . METHOD_2 ( false ) ; <END> VAR_3 . METHOD_2 ( false ) ; VAR_4 . remove ( VAR_5 ) ; VAR_4 . METHOD_3 ( VAR_6 , INT_1 ) ; METHOD_4 ( ) . METHOD_5 ( INT_2 , INT_2 ) ; } | public void METHOD_1 ( final TYPE_1 object ) { super . METHOD_1 ( object ) ; info . VAR_1 ( false ) ; message . VAR_1 ( false ) ; VAR_4 . remove ( VAR_5 ) ; VAR_4 . METHOD_3 ( VAR_6 , INT_1 ) ; METHOD_4 ( ) . METHOD_5 ( INT_2 , INT_2 ) ; } |
I d call variable _CODE_ | private void METHOD_1 ( TYPE_1 < ? > entity ) { if ( entity == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } <START> Class < ? extends TYPE_1 > VAR_1 = entity . getClass ( ) ; <END> if ( TYPE_2 . getInstance ( ) . METHOD_2 ( ( Class < TYPE_1 < TYPE_3 > > ) VAR_1 ) == null ) { throw new IllegalArgumentException ( STRING_2 + VAR_1 . getName ( ) ) ; } } | private void METHOD_1 ( TYPE_1 < ? > entity ) { if ( entity == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } if ( TYPE_2 . getInstance ( ) . METHOD_2 ( ( Class < TYPE_1 < TYPE_3 > > ) entity . getClass ( ) ) == null ) { throw new IllegalArgumentException ( STRING_2 + entity . getClass ( ) . getName ( ) ) ; } } |
please replace ^ log error ( ) | public Object METHOD_1 ( Object ctx ) { if ( ctx == null ) { return null ; } TYPE_1 VAR_1 = ( TYPE_1 ) ctx ; TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( VAR_2 == null ) { return null ; } try { return VAR_2 . get ( STRING_1 ) . get ( 0 ) ; } catch ( TYPE_3 e ) { <START> System . err . println ( VAR_3 + STRING_2 ) ; <END> return null ; } } | public Object METHOD_1 ( Object ctx ) { if ( ctx == null ) { return null ; } TYPE_1 VAR_1 = ( TYPE_1 ) ctx ; TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( VAR_2 == null ) { return null ; } try { return VAR_2 . get ( STRING_1 ) . get ( 0 ) ; } catch ( TYPE_3 e ) { log . error ( VAR_3 + STRING_2 ) ; return null ; } } |
produce a number constructor _CODE_ warning please Integer valueOf ( 0 ) | public void METHOD_1 ( Integer value ) { <START> value = ( value == null ) ? new Integer ( 0 ) : value ; <END> if ( ! VAR_1 . equals ( value ) ) { VAR_1 = value ; } } | public void METHOD_1 ( Integer value ) { value = ( value == null ) ? Integer . valueOf ( 0 ) : value ; if ( ! VAR_1 . equals ( value ) ) { VAR_1 = value ; } } |
Double valueOf ( 0 0 ) | private static Double METHOD_1 ( TYPE_1 input , String name ) { Double VAR_1 = METHOD_2 ( input , name ) ; <START> return ( VAR_1 == null ? new Double ( FLOAT_1 ) : VAR_1 ) ; <END> } | private static Double METHOD_1 ( TYPE_1 input , String name ) { Double VAR_1 = METHOD_2 ( input , name ) ; return ( VAR_1 == null ? Double . valueOf ( FLOAT_1 ) : VAR_1 ) ; } |
remove call ( ) ; | public TYPE_1 ( Guid VAR_2 ) { <START> this ( ) ; <END> this . VAR_2 = VAR_2 ; } | public TYPE_1 ( Guid VAR_2 ) { this . VAR_2 = VAR_2 ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.