ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
METHOD_3 sets state
private void METHOD_1 ( ) { final TYPE_1 VAR_1 = TYPE_1 . from ( VAR_2 ) ; VAR_1 . METHOD_2 ( VAR_3 ) ; METHOD_3 ( ) ; METHOD_4 ( ) ; VAR_4 = null ; <START> METHOD_5 ( TYPE_2 . VAR_6 , STRING_1 ) ; <END> }
private void METHOD_1 ( ) { final TYPE_1 VAR_1 = TYPE_1 . from ( VAR_2 ) ; VAR_1 . METHOD_2 ( VAR_3 ) ; METHOD_3 ( ) ; METHOD_4 ( ) ; VAR_4 = null ; }
unused
static Collection < TYPE_1 > METHOD_1 ( List < TYPE_2 > VAR_1 ) { <START> final HashSet < TYPE_3 > VAR_2 = new HashSet < > ( ) ; <END> final HashSet < TYPE_1 > VAR_3 = new HashSet < > ( ) ; for ( final TYPE_2 VAR_4 : VAR_1 ) { for ( final TYPE_3 VAR_5 : new TYPE_4 ( VAR_4 . VAR_6 , VAR_4 . VAR_7 ) . METHOD_2 ( ) ) { VAR_3 . add ( new TYPE_1 ( VAR_5 , null ) ) ; } } return VAR_3 ; }
static Collection < TYPE_1 > METHOD_1 ( List < TYPE_2 > VAR_1 ) { final HashSet < TYPE_1 > VAR_3 = new HashSet < > ( ) ; for ( final TYPE_2 VAR_4 : VAR_1 ) { for ( final TYPE_3 VAR_5 : new TYPE_4 ( VAR_4 . VAR_6 , VAR_4 . VAR_7 ) . METHOD_2 ( ) ) { VAR_3 . add ( new TYPE_1 ( VAR_5 , null ) ) ; } } return VAR_3 ; }
_CODE_ addAll ( VAR_1 )
public void METHOD_1 ( Set < String > VAR_1 ) { <START> for ( String filter : VAR_1 ) { VAR_2 . add ( filter ) ; } <END> }
public void METHOD_1 ( Set < String > VAR_1 ) { VAR_2 . addAll ( VAR_1 ) ; }
please separate lines
TYPE_1 VAR_2 ( ) { TYPE_1 VAR_3 = new TYPE_1 ( ) ; VAR_3 . VAR_4 ( VAR_5 , VAR_6 ) ; VAR_3 . VAR_4 ( VAR_7 , VAR_8 ) ; VAR_3 . VAR_9 ( VAR_10 , VAR_11 ) ; VAR_3 . VAR_4 ( VAR_12 , message ) ; VAR_3 . VAR_13 ( VAR_14 , VAR_3 ) ; return VAR_3 ; <START> } } <END>
TYPE_1 VAR_2 ( ) { TYPE_1 VAR_3 = new TYPE_1 ( ) ; VAR_3 . VAR_4 ( VAR_5 , VAR_6 ) ; VAR_3 . VAR_4 ( VAR_7 , VAR_8 ) ; VAR_3 . VAR_9 ( VAR_10 , VAR_11 ) ; VAR_3 . VAR_4 ( VAR_12 , message ) ; VAR_3 . VAR_13 ( VAR_14 , VAR_3 ) ; return VAR_3 ; }
wifi omit function removed
protected void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; if ( ! METHOD_2 ( ) ) { return ; } VAR_1 = ( TYPE_1 ) VAR_2 . METHOD_3 ( Context . VAR_3 ) ; assertNotNull ( VAR_1 ) ; TYPE_2 . METHOD_4 ( STRING_1 ) ; Thread . VAR_4 ( VAR_5 ) ; <START> if ( METHOD_2 ( ) ) { <END> assertTrue ( VAR_1 . METHOD_5 ( ) ) ; } }
protected void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; if ( ! METHOD_2 ( ) ) { return ; } VAR_1 = ( TYPE_1 ) VAR_2 . METHOD_3 ( Context . VAR_3 ) ; assertNotNull ( VAR_1 ) ; TYPE_2 . METHOD_4 ( STRING_1 ) ; Thread . VAR_4 ( VAR_5 ) ; assertTrue ( VAR_1 . METHOD_5 ( ) ) ; }
avoid duplicate code call METHOD_1 ( listener listener VAR_6 )
public void METHOD_1 ( TYPE_1 listener ) { <START> if ( listener == null ) return ; String VAR_1 = VAR_2 != null ? VAR_2 . METHOD_2 ( ) : STRING_1 ; if ( VAR_3 ) { METHOD_3 ( STRING_2 + VAR_1 + STRING_3 + listener ) ; } TYPE_2 VAR_4 = ( TYPE_2 ) VAR_2 . METHOD_4 ( Context . VAR_5 ) ; if ( VAR_4 != null ) { VAR_4 . METHOD_1 ( listener , listener . VAR_6 ) ; } <END> }
public void METHOD_1 ( TYPE_1 listener ) { if ( listener == null ) return ; METHOD_1 ( listener , listener . VAR_6 ) ; }
patchset 10 visible ( annotated ) s fine contradicts answer – intended
<START> void METHOD_1 ( ANNOTATION_1 <END> final int id ) { VAR_1 . METHOD_2 ( null , id ) ; }
private void METHOD_1 ( ANNOTATION_1 final int id ) { VAR_1 . METHOD_2 ( null , id ) ; }
reaching pretty deep implementation detail wrapper isn t METHOD_7 ( ) idempotent ? call
public void METHOD_1 ( ) { final TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; final boolean VAR_3 = VAR_1 . METHOD_3 ( TYPE_2 . VAR_5 ) ; final boolean VAR_6 = VAR_7 ; VAR_7 = VAR_3 ; final boolean VAR_8 = ( VAR_3 != VAR_6 ) ; if ( ! VAR_8 ) { return ; } if ( ! VAR_3 ) { VAR_9 . METHOD_4 ( ) ; return ; } VAR_9 . METHOD_5 ( ) ; <START> if ( VAR_10 . METHOD_6 ( ) . length != 0 ) { <END> VAR_10 . METHOD_7 ( ) ; } }
public void METHOD_1 ( ) { final TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; final boolean VAR_3 = VAR_1 . METHOD_3 ( TYPE_2 . VAR_5 ) ; final boolean VAR_6 = VAR_7 ; VAR_7 = VAR_3 ; final boolean VAR_8 = ( VAR_3 != VAR_6 ) ; if ( ! VAR_8 ) { return ; } if ( ! VAR_3 ) { VAR_9 . METHOD_4 ( ) ; return ; } VAR_9 . METHOD_5 ( ) ; VAR_10 . METHOD_7 ( ) ; }
tethering inactive tethering restricted updated restrict ? logic correct ? another question tethering inactive show notification ? wired tethering restricted notification I enable tethering I understand correctly
private void METHOD_1 ( ) { final boolean VAR_1 = VAR_2 <= VAR_3 ; synchronized ( VAR_4 ) { <START> if ( VAR_5 ) { METHOD_2 ( ) ; } else if ( VAR_1 ) { <END> METHOD_3 ( ) ; } else { if ( METHOD_4 ( ) ) { return ; } METHOD_3 ( ) ; } } }
private void METHOD_1 ( ) { synchronized ( VAR_4 ) { final boolean VAR_1 = VAR_2 <= VAR_3 ; if ( VAR_1 ) { METHOD_3 ( ) ; } else { if ( METHOD_4 ( ) ) { return ; } METHOD_3 ( ) ; } } }
don t need check VAR_1 - 1 0 VAR_3 length - 1
public void METHOD_1 ( int VAR_1 ) { int VAR_2 = <START> VAR_3 [ VAR_1 - 1 ] ; <END> TYPE_1 . METHOD_2 ( VAR_2 ) ; }
public void METHOD_1 ( int VAR_1 ) { if ( VAR_1 < 1 ) { VAR_1 = 1 ; } else if ( VAR_1 > 10 ) { VAR_1 = 10 ; } TYPE_1 . METHOD_2 ( VAR_3 [ VAR_1 - 1 ] ) ; }
add exception param
private void METHOD_1 ( ) { final TYPE_1 < TYPE_2 > VAR_1 = TYPE_1 . create ( ) ; TYPE_3 VAR_2 = METHOD_2 ( TYPE_3 . class ) ; VAR_2 . METHOD_3 ( this , new TYPE_3 . TYPE_7 ( ) { @Override public void METHOD_4 ( ) { VAR_1 . set ( null ) ; } } ) ; try { VAR_1 . get ( INT_1 , TimeUnit . VAR_3 ) ; } catch ( TYPE_5 | InterruptedException | TYPE_6 e ) { <START> Log . VAR_4 ( STRING_1 , STRING_2 ) ; <END> } }
private void METHOD_1 ( ) { final TYPE_1 < TYPE_2 > VAR_1 = TYPE_1 . create ( ) ; TYPE_3 VAR_2 = METHOD_2 ( TYPE_3 . class ) ; VAR_2 . METHOD_3 ( this , new TYPE_3 . TYPE_7 ( ) { @Override public void METHOD_4 ( ) { VAR_1 . set ( null ) ; } } ) ; try { VAR_1 . get ( INT_1 , TimeUnit . VAR_3 ) ; } catch ( TYPE_5 | InterruptedException | TYPE_6 e ) { Log . VAR_4 ( STRING_1 , STRING_2 , e ) ; } }
I tend a boolean return consistency
<START> public int METHOD_1 ( TYPE_1 VAR_1 ) { <END> try { return VAR_2 . METHOD_1 ( VAR_1 ) ; } catch ( TYPE_2 e ) { throw new RuntimeException ( e . toString ( ) ) ; } }
public boolean METHOD_1 ( TYPE_1 VAR_1 ) { try { return VAR_2 . METHOD_1 ( VAR_1 ) ; } catch ( TYPE_2 e ) { throw new RuntimeException ( e . toString ( ) ) ; } }
! TYPE_2 equals (
public boolean METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { if <START> ( TYPE_2 . equals ( VAR_2 , <END> VAR_1 . METHOD_2 ( ) ) ) { return false ; } int i = METHOD_3 ( VAR_1 ) ; if ( i == - 1 ) { return false ; } VAR_3 . remove ( i ) ; return true ; }
public boolean METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { if ( ! TYPE_2 . equals ( VAR_2 , VAR_1 . METHOD_2 ( ) ) ) { return false ; } int i = METHOD_3 ( VAR_1 ) ; if ( i == - 1 ) { return false ; } VAR_3 . remove ( i ) ; return true ; }
suggest unindenting clarity : ( ! TYPE_2 equals ( VAR_2 VAR_1 METHOD_2 ) { return false ; } int i = ; ( i = = - 1 ) { return false ; } VAR_3 remove ( i ) ; return true ;
public boolean METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { <START> if ( TYPE_2 . equals ( VAR_2 , VAR_1 . METHOD_2 ( ) ) ) { <END> int i = METHOD_3 ( VAR_1 ) ; if ( i >= 0 ) { VAR_3 . remove ( i ) ; return true ; } } return false ; }
public boolean METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { if ( TYPE_2 . equals ( VAR_2 , VAR_1 . METHOD_2 ( ) ) ) { return false ; } int i = METHOD_3 ( VAR_1 ) ; if ( i == - 1 ) { return false ; } VAR_3 . remove ( i ) ; return true ; }
thread safe access VAR_1
private void METHOD_1 ( ) { <START> for ( Map . Entry < TYPE_5 . TYPE_6 < TYPE_2 > , TYPE_3 < TYPE_4 > > entry <END> : VAR_1 . entrySet ( ) ) { entry . getKey ( ) . METHOD_2 ( ) ; } }
private synchronized void METHOD_1 ( ) { for ( Map . Entry < TYPE_5 . TYPE_6 < TYPE_2 > , TYPE_3 < TYPE_4 > > entry : VAR_1 . entrySet ( ) ) { entry . getKey ( ) . METHOD_2 ( ) ; } }
super _CODE_ doesn t call super other ? ditto
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { <START> super . METHOD_1 ( VAR_1 ) ; <END> VAR_2 . METHOD_1 ( VAR_1 ) ; }
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { VAR_2 . METHOD_1 ( VAR_1 ) ; }
return unused
private <START> boolean METHOD_1 ( TYPE_1 <END> VAR_1 ) { final TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( ) ; if ( VAR_2 == null ) { METHOD_3 ( STRING_1 + VAR_1 ) ; return false ; } int VAR_4 = VAR_2 . METHOD_4 ( VAR_1 ) ; if ( VAR_4 == TYPE_3 . VAR_6 ) { METHOD_5 ( STRING_2 + VAR_1 ) ; return VAR_2 . METHOD_6 ( VAR_1 ) ; } else { METHOD_5 ( STRING_3 + VAR_1 + STRING_4 + VAR_4 ) ; return false ; } }
private void METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( ) ; if ( VAR_2 == null ) { METHOD_3 ( STRING_1 + VAR_1 ) ; return ; } int VAR_4 = VAR_2 . METHOD_4 ( VAR_1 ) ; if ( VAR_4 == TYPE_3 . VAR_6 ) { METHOD_5 ( STRING_2 + VAR_1 ) ; VAR_2 . METHOD_6 ( VAR_1 ) ; } else { METHOD_5 ( STRING_3 + VAR_1 + STRING_4 + VAR_4 ) ; } }
current setup collecting rss processes running system case user supplied VAR_2 null dynamically query process PS - A inititlaize initialize garbage collection helper _CODE_ ( ) method query process names
public void METHOD_1 ( String VAR_1 , String ... VAR_2 ) { VAR_3 = VAR_2 ; VAR_4 = VAR_1 ; VAR_5 = 0 ; VAR_6 = TYPE_1 . getInstance ( TYPE_2 . METHOD_2 ( ) ) ; <START> VAR_7 . METHOD_1 ( VAR_2 ) ; <END> }
public void METHOD_1 ( String VAR_1 , String ... VAR_2 ) { VAR_3 = VAR_2 ; VAR_4 = VAR_1 ; VAR_5 = 0 ; VAR_6 = TYPE_1 . getInstance ( TYPE_2 . METHOD_2 ( ) ) ; }
shouldn t need order METHOD_4 ( ) I check I safely give READ_PRECISE_PHONE_STATE package
public void METHOD_1 ( ) { if ( ! VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 ) ) { return ; } int VAR_4 = <START> TYPE_1 . METHOD_3 ( VAR_5 , <END> ( VAR_6 ) - > VAR_6 . METHOD_4 ( ) ) ; assertEquals ( 2 , VAR_4 ) ; }
public void METHOD_1 ( ) { if ( ! VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 ) ) { return ; } int VAR_4 = VAR_5 . METHOD_4 ( ) ; assertEquals ( 0 , VAR_4 ) ; }
need check VAR_2 ? unrelated METHOD_1
private Set < Integer > METHOD_1 ( ) { Set < Integer > VAR_1 = new TYPE_1 < > ( Arrays . asList ( TYPE_2 . values ( ) ) ) ; <START> if ( VAR_2 != null ) { <END> if ( ! METHOD_2 ( TYPE_3 . VAR_4 ) ) { VAR_1 . remove ( TYPE_3 . VAR_4 ) ; } if ( ! METHOD_2 ( TYPE_3 . VAR_5 ) ) { VAR_1 . remove ( TYPE_3 . VAR_5 ) ; } } return VAR_1 ; }
private Set < Integer > METHOD_1 ( ) { Set < Integer > VAR_1 = new TYPE_1 < > ( Arrays . asList ( TYPE_2 . values ( ) ) ) ; if ( ! METHOD_2 ( TYPE_3 . VAR_4 ) ) { VAR_1 . remove ( TYPE_3 . VAR_4 ) ; } if ( ! METHOD_2 ( TYPE_3 . VAR_5 ) ) { VAR_1 . remove ( TYPE_3 . VAR_5 ) ; } return VAR_1 ; }
suggest a local visibility int other places a ternary inline don t duplicate code
private void METHOD_1 ( int type ) { <START> if ( METHOD_2 ( type ) ) { VAR_1 . METHOD_3 ( R . id . VAR_2 ) . METHOD_4 ( View . VAR_3 ) ; } else { VAR_1 . METHOD_3 ( R . id . VAR_2 ) . METHOD_4 ( View . VAR_4 ) ; } <END> }
private void METHOD_1 ( int type ) { VAR_1 . METHOD_3 ( R . id . VAR_2 ) . METHOD_4 ( METHOD_2 ( type ) ? View . VAR_3 : View . VAR_4 ) ; }
return METHOD_1 ( context VAR_1 false ) ; clearer 2 methods a potential difference default
public static boolean METHOD_1 ( ANNOTATION_1 Context context , ANNOTATION_1 String VAR_1 , ANNOTATION_1 String name ) { <START> final int VAR_2 = METHOD_2 ( VAR_1 , name , 0 ) ; return METHOD_3 ( context , VAR_2 ) ; <END> }
public static boolean METHOD_1 ( ANNOTATION_1 Context context , ANNOTATION_1 String VAR_1 , ANNOTATION_1 String name ) { final int VAR_2 = METHOD_2 ( VAR_1 , name , 0 ) ; return METHOD_1 ( context , VAR_1 , name , false ) ; }
happened code TYPE_1 METHOD_1 ? ( context _CODE_ ( android manifest permission CHANGE_NETWORK_STATE ) = = _CODE_ PERMISSION_GRANTED ) { return true ; } app CHANGE_NETWORK_STATE permission able call _CODE_ WRITE_SETTINGS
private static boolean METHOD_1 ( ANNOTATION_1 Context context , int VAR_1 , ANNOTATION_1 String VAR_2 , ANNOTATION_2 String VAR_3 , boolean VAR_4 ) { <START> return TYPE_1 . METHOD_2 ( context , VAR_1 , VAR_2 , VAR_4 ) ; <END> }
private static boolean METHOD_1 ( ANNOTATION_1 Context context , int VAR_1 , ANNOTATION_1 String VAR_2 , ANNOTATION_2 String VAR_3 , boolean VAR_4 ) { return TYPE_1 . METHOD_1 ( context , VAR_1 , VAR_2 , VAR_4 ) ; }
move a camera2 implementation leaking camera2 implementation details a thought a _CODE_ interface default flash mode _CODE_ device legacy provide implementation return precapture needed
boolean METHOD_1 ( TYPE_1 state ) { <START> if ( METHOD_2 ( ) ) { <END> return false ; } switch ( METHOD_3 ( ) ) { case VAR_1 : return true ; case VAR_2 : return state . VAR_3 . METHOD_4 ( ) == TYPE_3 . VAR_5 ; case VAR_6 : return false ; } throw new TYPE_2 ( METHOD_3 ( ) ) ; }
boolean METHOD_1 ( TYPE_1 state ) { switch ( METHOD_3 ( ) ) { case VAR_1 : return true ; case VAR_2 : return state . VAR_3 . METHOD_4 ( ) == TYPE_3 . VAR_5 ; case VAR_6 : return false ; } throw new TYPE_2 ( METHOD_3 ( ) ) ; }
null ? ll throwing exception doesn t matter else crash eventually ? binding a socket VAR_1
public static boolean METHOD_1 ( Context context , TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = ( TYPE_2 ) context . VAR_3 ( Context . VAR_4 ) ; TYPE_3 <START> VAR_5 = <END> VAR_2 . METHOD_2 ( VAR_1 ) ; return VAR_5 . METHOD_3 ( VAR_6 ) ; }
public static boolean METHOD_1 ( Context context , TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = ( TYPE_2 ) context . VAR_3 ( Context . VAR_4 ) ; TYPE_3 VAR_5 = VAR_2 . METHOD_2 ( VAR_1 ) ; if ( VAR_5 == null ) { return false ; } return VAR_5 . METHOD_3 ( VAR_6 ) ; }
simplified : return VAR_5 ! = null && VAR_5 METHOD_3 ( )
public static boolean METHOD_1 ( Context context , TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = ( TYPE_2 ) context . VAR_3 ( Context . VAR_4 ) ; TYPE_3 VAR_5 = VAR_2 . METHOD_2 ( VAR_1 ) ; <START> if ( VAR_5 == null ) { return false ; } return VAR_5 . METHOD_3 ( VAR_6 ) ; <END> }
public static boolean METHOD_1 ( Context context , TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = ( TYPE_2 ) context . VAR_3 ( Context . VAR_4 ) ; TYPE_3 VAR_5 = VAR_2 . METHOD_2 ( VAR_1 ) ; return VAR_5 != null && VAR_5 . METHOD_3 ( VAR_6 ) ; }
s test case return true
public void METHOD_1 ( ) { final TYPE_1 request = new TYPE_1 . Builder ( ) . METHOD_2 ( TYPE_2 ) . build ( ) ; METHOD_3 ( request . VAR_1 ( null ) ) ; METHOD_3 ( request . VAR_1 ( new TYPE_3 ( ) ) ) ; assertTrue ( request . VAR_1 ( TYPE_2 . METHOD_4 ( VAR_2 ) ) ) ; <START> assertEquals ( request . VAR_1 ( new TYPE_3 ( ) ) , TYPE_2 . METHOD_5 ( new TYPE_3 ( ) ) ) ; <END> }
public void METHOD_1 ( ) { final TYPE_1 request = new TYPE_1 . Builder ( ) . METHOD_2 ( TYPE_2 ) . build ( ) ; METHOD_3 ( request . VAR_1 ( null ) ) ; METHOD_3 ( request . VAR_1 ( new TYPE_3 ( ) ) ) ; assertTrue ( request . VAR_1 ( TYPE_2 . METHOD_4 ( VAR_2 ) ) ) ; assertEquals ( request . VAR_1 ( TYPE_2 ) , TYPE_2 . METHOD_5 ( TYPE_2 ) ) ; }
remove local var needed realy line write STRING_2
public void METHOD_1 ( ) throws Exception { final String VAR_1 = STRING_1 ; TYPE_1 VAR_2 = config . VAR_3 ( ) . METHOD_2 ( VAR_1 , STRING_2 ) ; final String VAR_4 = STRING_3 ; <START> final String version = STRING_2 ; <END> METHOD_3 ( VAR_1 , VAR_4 , version ) ; METHOD_4 ( VAR_1 , VAR_2 ) ; }
public void METHOD_1 ( ) throws Exception { final String VAR_1 = STRING_1 ; TYPE_1 VAR_2 = config . VAR_3 ( ) . METHOD_2 ( VAR_1 , STRING_2 ) ; final String VAR_4 = STRING_3 ; METHOD_3 ( VAR_1 , VAR_4 , STRING_2 ) ; METHOD_4 ( VAR_1 , VAR_2 ) ; }
write : return VAR_3
private String METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 ; String VAR_3 = null ; try { while ( ( VAR_2 = VAR_1 . METHOD_2 ( ) ) != null ) { VAR_3 += VAR_2 + CHAR_1 ; } } catch ( IOException e ) { log . error ( STRING_1 , e ) ; } <START> return ( VAR_3 == null ) ? null : VAR_3 . toString ( ) ; <END> }
private String METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 ; StringBuilder VAR_3 = new StringBuilder ( ) ; try { while ( ( VAR_2 = VAR_1 . METHOD_2 ( ) ) != null ) { VAR_3 . append ( VAR_2 ) . append ( CHAR_1 ) ; } } catch ( IOException e ) { log . error ( STRING_1 , e ) ; } return VAR_3 . toString ( ) ; }
a repetition parameters field names worth extracting constants
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 task ) { <START> super ( VAR_2 ) ; <END> METHOD_1 ( STRING_1 , task . VAR_3 ( ) ) ; METHOD_1 ( STRING_2 , task . VAR_4 ( ) ) ; METHOD_1 ( STRING_3 , task . VAR_5 ( ) ) ; METHOD_1 ( STRING_4 , task . VAR_6 ( ) ) ; task . VAR_7 ( ) ; METHOD_1 ( STRING_5 , METHOD_2 ( task . VAR_7 ( ) ) ) ; METHOD_1 ( STRING_6 , task . VAR_7 ( ) . getClass ( ) . getName ( ) ) ; }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 task ) { super ( VAR_2 ) ; METHOD_1 ( STRING_1 , task . VAR_3 ( ) ) ; METHOD_1 ( STRING_2 , task . VAR_4 ( ) ) ; METHOD_1 ( STRING_3 , task . VAR_5 ( ) ) ; METHOD_1 ( STRING_4 , task . VAR_6 ( ) ) ; METHOD_1 ( STRING_5 , METHOD_2 ( task . VAR_7 ( ) ) ) ; METHOD_1 ( STRING_6 , task . VAR_7 ( ) . getClass ( ) . getName ( ) ) ; }
don t need METHOD_2 ( ) METHOD_3 ( ) ! = null condition
private TYPE_1 METHOD_1 ( ) { <START> TYPE_1 status = null ; <END> if ( METHOD_2 ( ) != null && METHOD_2 ( ) . METHOD_3 ( ) != null ) { status = METHOD_2 ( ) . METHOD_3 ( ) ; } return status ; }
private TYPE_1 METHOD_1 ( ) { TYPE_1 status = null ; if ( METHOD_2 ( ) != null ) { status = METHOD_2 ( ) . METHOD_3 ( ) ; } return status ; }
assignment redundant
protected static < T > List < T > METHOD_1 ( List < T > list , List < T > VAR_1 ) { <START> List < T > VAR_2 = list ; <END> if ( list != null ) { if ( VAR_1 != null ) { for ( T item : VAR_1 ) { if ( ! VAR_2 . contains ( item ) ) { VAR_2 . add ( item ) ; } } } } else { VAR_2 = VAR_1 ; } return VAR_2 ; }
protected static < T > List < T > METHOD_1 ( List < T > list , List < T > VAR_1 ) { if ( list != null ) { if ( VAR_1 != null ) { for ( T item : VAR_1 ) { if ( ! list . contains ( item ) ) { list . add ( item ) ; } } } } else { return VAR_1 ; } return list ; }
message warnning level error
public static void execute ( TYPE_1 command ) { try { VAR_1 . METHOD_1 ( new TYPE_2 ( command , TYPE_3 . METHOD_2 ( ) , TYPE_3 . METHOD_3 ( ) ) ) ; } catch ( TYPE_4 e ) { log . error ( STRING_1 ) ; throw e ; <START> } <END> }
public static void execute ( TYPE_1 command ) { try { VAR_1 . METHOD_1 ( new TYPE_2 ( command , TYPE_3 . METHOD_2 ( ) , TYPE_3 . METHOD_3 ( ) ) ) ; } catch ( TYPE_4 e ) { log . warn ( STRING_1 ) ; throw e ; } }
remove initializing c tor done declaration statement : private TYPE_1 VAR_2 = TYPE_1 TYPE_3 ;
public TYPE_2 ( ) { <START> VAR_2 = TYPE_1 . TYPE_3 ; <END> }
public TYPE_2 ( ) { }
long System current time
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { <START> VAR_2 = new Date ( ) ; <END> VAR_1 . METHOD_2 ( id ) ; VAR_1 . METHOD_3 ( VAR_3 . size ( ) ) ; if ( VAR_1 . METHOD_4 ( ) == null ) { VAR_1 . METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ; } VAR_1 . METHOD_7 ( VAR_4 ) ; VAR_3 . add ( VAR_1 ) ; return VAR_1 ; }
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = new Date ( ) ; VAR_1 . METHOD_2 ( id ) ; VAR_1 . METHOD_3 ( VAR_3 . size ( ) ) ; VAR_1 . METHOD_7 ( VAR_4 ) ; VAR_3 . add ( VAR_1 ) ; return VAR_1 ; }
lines code updates DB clear open a 2 transaction updates related I understand committed
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = new Date ( ) ; VAR_1 . METHOD_2 ( id ) ; VAR_1 . METHOD_3 ( VAR_3 . size ( ) ) ; VAR_1 . METHOD_4 ( VAR_4 ) ; if ( VAR_1 . METHOD_5 ( ) == null ) { VAR_1 . METHOD_6 ( VAR_1 . METHOD_7 ( ) ) ; } VAR_1 . METHOD_8 ( VAR_5 ) ; <START> <END> VAR_3 . add ( VAR_1 ) ; VAR_4 . METHOD_9 ( VAR_1 ) ; VAR_4 . METHOD_10 ( id , VAR_2 ) ; return VAR_1 ; }
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = new Date ( ) ; VAR_1 . METHOD_2 ( id ) ; VAR_1 . METHOD_3 ( VAR_3 . size ( ) ) ; if ( VAR_1 . METHOD_5 ( ) == null ) { VAR_1 . METHOD_6 ( VAR_1 . METHOD_7 ( ) ) ; } VAR_1 . METHOD_8 ( VAR_5 ) ; VAR_3 . add ( VAR_1 ) ; return VAR_1 ; }
put code line part condition scope ( VAR_3 ! = null ) adding error logs null values VAR_1 VAR_3 entity helpful
public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { try { if ( VAR_1 != null ) { TYPE_3 VAR_3 = TYPE_4 . METHOD_2 ( ) . METHOD_3 ( VAR_1 . getValue ( ) ) ; if ( VAR_3 != null ) { VAR_3 . METHOD_4 ( VAR_2 ) ; } <START> TYPE_4 . METHOD_2 ( ) . METHOD_5 ( VAR_3 ) ; <END> } } catch ( Exception e ) { log . VAR_4 ( STRING_1 , VAR_1 , VAR_2 , e ) ; } }
public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { try { if ( VAR_1 != null ) { TYPE_3 VAR_3 = TYPE_4 . METHOD_2 ( ) . METHOD_3 ( VAR_1 . getValue ( ) ) ; if ( VAR_3 != null ) { VAR_3 . METHOD_4 ( VAR_2 ) ; TYPE_4 . METHOD_2 ( ) . METHOD_5 ( VAR_3 ) ; } } } catch ( Exception e ) { log . VAR_4 ( STRING_1 , VAR_1 , VAR_2 , e ) ; } }
a lot places ugly class initialized passed some other place
private TYPE_5 ( ) { VAR_2 = TYPE_3 < Integer > METHOD_1 ( TYPE_4 . TYPE_2 ) . METHOD_2 ( ) * - 1 ; VAR_6 = TYPE_3 < Integer > METHOD_1 ( TYPE_4 . TYPE_6 ) . METHOD_2 ( ) * - 1 ; <START> Integer VAR_8 = TYPE_3 < Integer > METHOD_1 ( TYPE_4 . TYPE_7 ) ; <END> TYPE_1 . getInstance ( ) . METHOD_3 ( this , STRING_1 , new Class [ ] { } , new Object [ ] { } , VAR_8 , VAR_8 , TimeUnit . VAR_10 ) ; }
private TYPE_5 ( ) { }
run vm
protected boolean METHOD_1 ( ) { if ( getParameters ( ) != null ) { if ( ! TYPE_1 . getInstance ( ) . METHOD_2 ( getParameters ( ) . METHOD_3 ( ) , METHOD_4 ( ) . METHOD_5 ( ) ) ) { METHOD_6 ( TYPE_4 . TYPE_5 . toString ( ) ) ; <START> METHOD_6 ( TYPE_4 . TYPE_6 . toString ( ) ) ; <END> return false ; } } return true ; }
protected boolean METHOD_1 ( ) { if ( getParameters ( ) == null ) { return false ; } else if ( ! TYPE_1 . getInstance ( ) . METHOD_2 ( getParameters ( ) . METHOD_3 ( ) , METHOD_4 ( ) . METHOD_5 ( ) ) ) { return false ; } return true ; }
true : run vm ! ! ! method fails
protected boolean METHOD_1 ( ) { if ( getParameters ( ) != null ) { if ( TYPE_1 . getInstance ( ) . METHOD_2 ( getParameters ( ) . METHOD_3 ( ) , METHOD_4 ( ) . METHOD_5 ( ) ) ) { METHOD_6 ( TYPE_4 . TYPE_5 . toString ( ) ) ; <START> METHOD_6 ( TYPE_4 . TYPE_6 . toString ( ) ) ; <END> } } return true ; }
protected boolean METHOD_1 ( ) { if ( getParameters ( ) == null ) { return false ; } else if ( ! TYPE_1 . getInstance ( ) . METHOD_2 ( getParameters ( ) . METHOD_3 ( ) , METHOD_4 ( ) . METHOD_5 ( ) ) ) { return false ; } return true ; }
call inline TYPE_2 getInstance ( ) METHOD_2 ( ) remove ( )
<START> protected void METHOD_1 ( ) { <END> TYPE_1 VAR_1 = TYPE_2 . getInstance ( ) . METHOD_2 ( ) ; VAR_1 . remove ( getParameters ( ) . METHOD_3 ( ) ) ; }
protected void METHOD_1 ( ) { METHOD_2 ( ) . remove ( getParameters ( ) . METHOD_3 ( ) ) ; }
change
public String METHOD_1 ( ) { int VAR_1 = VAR_2 . METHOD_2 ( ) ; <START> return ( VAR_1 != 0 ) ? Integer . toString ( VAR_1 ) : null ; <END> }
public String METHOD_1 ( ) { return Integer . toString ( VAR_2 . METHOD_2 ( ) ) ; }
I m logic correct TYPE_1 linked template fact a TYPE_1 instance don t _CODE_ anymore call removed duplicate field ( VAR_1 )
protected TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { TYPE_1 VAR_2 = METHOD_2 ( ) ; <START> VAR_1 = ( VAR_2 == null || VAR_2 . METHOD_3 ( ) == TYPE_2 . VAR_4 ) ? ( null ) : ( VAR_2 ) ; <END> } return VAR_1 ; }
protected TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = METHOD_2 ( ) ; } return VAR_1 ; }
don t need a transaction
protected void METHOD_1 ( ) { <START> TYPE_1 . METHOD_2 ( VAR_1 . METHOD_3 ( ) , METHOD_4 ( ) ) ; <END> TYPE_2 . METHOD_5 ( new TYPE_3 < TYPE_4 > ( ) { @Override public TYPE_4 METHOD_6 ( ) { TYPE_5 VAR_2 = TYPE_6 . getInstance ( ) . METHOD_7 ( TYPE_7 . TYPE_8 , METHOD_8 ( ) ) ; METHOD_9 ( VAR_2 ) ; METHOD_10 ( ) ; return null ; } } ) ; TYPE_1 . METHOD_11 ( VAR_1 . METHOD_3 ( ) ) ; }
protected void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( VAR_1 . METHOD_3 ( ) , METHOD_4 ( ) ) ; TYPE_5 VAR_2 = TYPE_6 . getInstance ( ) . METHOD_7 ( TYPE_7 . TYPE_8 , METHOD_8 ( ) ) ; METHOD_9 ( VAR_2 ) ; TYPE_1 . METHOD_11 ( VAR_1 . METHOD_3 ( ) ) ; }
METHOD_8 TYPE_5 called automatically
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_1 . getInstance ( ) . METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( ) ) ) ; TYPE_2 VAR_1 = METHOD_6 ( ) ; <START> <END> METHOD_7 ( TYPE_3 . getInstance ( ) . METHOD_8 ( TYPE_4 . TYPE_5 , getParameters ( ) . METHOD_9 ( ) . get ( 0 ) , METHOD_10 ( ) ) . METHOD_11 ( ) ) ; if ( ! METHOD_11 ( ) ) { log . warn ( STRING_1 ) ; } METHOD_12 ( ) ; }
protected void METHOD_1 ( ) { METHOD_7 ( TYPE_3 . getInstance ( ) . METHOD_8 ( TYPE_4 . TYPE_5 , getParameters ( ) . METHOD_9 ( ) . get ( 0 ) , METHOD_10 ( ) ) . METHOD_11 ( ) ) ; if ( ! METHOD_11 ( ) ) { log . warn ( STRING_1 ) ; } METHOD_12 ( ) ; }
rebase pass a new ArrayList ( ) _CODE_ need variable
protected static boolean METHOD_1 ( Guid VAR_1 ) { <START> TYPE_2 . TYPE_3 . ArrayList < String > VAR_2 = new TYPE_2 . TYPE_3 . ArrayList < String > ( ) ; <END> return METHOD_2 ( VAR_1 , VAR_2 ) ; }
protected static boolean METHOD_1 ( Guid VAR_1 ) { return METHOD_2 ( VAR_1 , new TYPE_2 . TYPE_3 . ArrayList < String > ( ) ) ; }
check isEmpty ( )
public void METHOD_1 ( ) { List < TYPE_1 > result = VAR_1 . METHOD_2 ( VAR_2 , VAR_3 , true ) ; assertNotNull ( result ) ; <START> assertTrue ( result . size ( ) == 0 ) ; <END> }
public void METHOD_1 ( ) { List < TYPE_1 > result = VAR_1 . METHOD_2 ( VAR_2 , VAR_3 , true ) ; assertNotNull ( result ) ; assertTrue ( result . isEmpty ( ) ) ; }
please move tot init ( ) method
private TYPE_4 ( ) { <START> TYPE_1 . METHOD_1 ( new TYPE_2 ( this , <END> new TYPE_3 ( ) { @Override public void METHOD_2 ( Object target , Object VAR_2 ) { METHOD_3 ( ( String ) VAR_2 ) ; } } ) ) ; }
private TYPE_4 ( ) { }
return check ? IIRC return true quota valid return true CDA
protected boolean METHOD_1 ( ) { <START> return ( ! TYPE_1 . getInstance ( ) . METHOD_2 ( getParameters ( ) . METHOD_3 ( ) , <END> METHOD_4 ( ) . METHOD_5 ( ) ) ) ; }
protected boolean METHOD_1 ( ) { return ( TYPE_1 . getInstance ( ) . METHOD_2 ( getParameters ( ) . METHOD_3 ( ) , METHOD_4 ( ) . METHOD_5 ( ) ) ) ; }
storage pool set quota object i don t a reason send separately apply update remove
public TYPE_1 ( T parameters ) { super ( parameters ) ; <START> METHOD_1 ( parameters . VAR_2 ( ) ) ; <END> }
public TYPE_1 ( T parameters ) { super ( parameters ) ; }
i check needed don t factory create command null params decide check add error message
protected boolean METHOD_1 ( ) { <START> if ( getParameters ( ) == null ) { <END> return false ; } else if ( ! TYPE_1 . getInstance ( ) . METHOD_2 ( getParameters ( ) . METHOD_3 ( ) , METHOD_4 ( ) . METHOD_5 ( ) ) ) { return false ; } return true ; }
protected boolean METHOD_1 ( ) { return ( ! TYPE_1 . getInstance ( ) . METHOD_2 ( getParameters ( ) . METHOD_3 ( ) , METHOD_4 ( ) . METHOD_5 ( ) ) ) ; }
ain t super call redundant
public TYPE_1 ( Guid VAR_2 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; }
public TYPE_1 ( Guid VAR_2 ) { this . VAR_2 = VAR_2 ; }
TYPE_2 stateless worth singletonize
protected void METHOD_1 ( ) { String configuration = METHOD_2 ( getParameters ( ) . METHOD_3 ( ) ) ; TYPE_1 result = new TYPE_1 ( ) ; if ( configuration != null ) { <START> new TYPE_2 ( ) . METHOD_4 ( result , configuration ) ; <END> } METHOD_5 ( ) . METHOD_6 ( result ) ; }
protected void METHOD_1 ( ) { String configuration = METHOD_2 ( getParameters ( ) . METHOD_3 ( ) ) ; TYPE_1 result = null ; if ( configuration != null ) { result = new TYPE_1 ( ) ; new TYPE_2 ( ) . METHOD_4 ( result , configuration ) ; } METHOD_5 ( ) . METHOD_6 ( result ) ; }
call VAR_3
private TYPE_1 < TYPE_2 > METHOD_1 ( Guid VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ) ; when ( VAR_2 . METHOD_3 ( ) ) . METHOD_4 ( VAR_1 ) ; TYPE_1 < TYPE_2 > VAR_3 = METHOD_5 ( ) ; <START> return VAR_3 ; <END> }
private TYPE_1 < TYPE_2 > METHOD_1 ( Guid VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ) ; when ( VAR_2 . METHOD_3 ( ) ) . METHOD_4 ( VAR_1 ) ; TYPE_1 < TYPE_2 > query = METHOD_5 ( ) ; return query ; }
copy & paste instead calling super remove ( images remove )
<START> protected void METHOD_1 ( ) { <END> METHOD_2 ( ) ; METHOD_3 ( ) ; new TYPE_1 ( ) . METHOD_4 ( METHOD_5 ( ) ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; }
protected void METHOD_1 ( ) { METHOD_6 ( ) ; super . METHOD_1 ( ) ; }
change public
<START> public void METHOD_1 ( Guid value ) { <END> VAR_1 = value ; }
private void METHOD_1 ( Guid value ) { VAR_1 = value ; }
need instantiate a variable a line override move instantiate else clause
protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 params , TYPE_4 context ) { <START> TYPE_1 result = new TYPE_1 ( ) ; <END> if ( METHOD_2 ( VAR_1 , params ) ) { result = METHOD_3 ( VAR_1 , params , context ) ; } else { result . VAR_2 ( false ) ; } return result ; }
protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 params , TYPE_4 context ) { TYPE_1 result = null ; if ( METHOD_2 ( VAR_1 , params ) ) { result = METHOD_3 ( VAR_1 , params , context ) ; } else { result = new TYPE_1 ( ) ; result . VAR_2 ( false ) ; } return result ; }
shouldn t context
protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 params , <START> TYPE_4 context ) { <END> if ( METHOD_2 ( VAR_1 , params ) ) { params . VAR_2 ( TYPE_6 . VAR_4 ) ; return TYPE_5 . getInstance ( ) . METHOD_3 ( VAR_1 , params ) ; } return new TYPE_1 ( ) ; }
protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 params , TYPE_4 context ) { if ( METHOD_2 ( VAR_1 , params ) ) { params . VAR_2 ( TYPE_6 . VAR_4 ) ; return TYPE_5 . getInstance ( ) . METHOD_3 ( VAR_1 , params , context ) ; } return new TYPE_1 ( ) ; }
I don t a cluster removed host monitor cluster null
public static TYPE_1 METHOD_1 ( TYPE_2 vds ) { TYPE_1 VAR_1 = null ; Guid VAR_2 = vds . VAR_3 ( ) ; TYPE_3 VAR_4 = VAR_5 . get ( VAR_2 ) ; <START> <END> if ( VAR_4 != null ) { VAR_1 = VAR_6 ; } return VAR_1 ; }
public static TYPE_1 METHOD_1 ( TYPE_2 vds ) { Guid VAR_2 = vds . VAR_3 ( ) ; TYPE_3 VAR_4 = VAR_5 . get ( VAR_2 ) ; return VAR_6 ; }
redundant
public String METHOD_1 ( ) { <START> this . VAR_1 = TYPE_1 . METHOD_2 ( this . getId ( ) . METHOD_3 ( ) , this . VAR_1 ) ; <END> return this . VAR_1 ; }
public String METHOD_1 ( ) { VAR_1 = TYPE_1 . METHOD_2 ( this . getId ( ) . METHOD_3 ( ) , VAR_1 ) ; return this . VAR_1 ; }
please wrap - else block brackets { }
private TYPE_1 METHOD_1 ( ) { <START> if ( TYPE_2 . METHOD_2 ( vm . VAR_1 ( ) ) ) <END> return new TYPE_3 ( vm , VAR_2 ) ; else return new TYPE_4 ( vm , VAR_2 ) ; }
private TYPE_1 METHOD_1 ( ) { if ( TYPE_2 . METHOD_2 ( vm . VAR_1 ( ) ) ) { return new TYPE_3 ( vm , VAR_2 ) ; } else { return new TYPE_4 ( vm , VAR_2 ) ; } }
wrap call a specific failure refresh fail
<START> private TYPE_1 [ ] METHOD_1 ( List < String > VAR_1 ) { <END> return ( TYPE_1 [ ] ) ( new TYPE_2 < TYPE_3 > ( new TYPE_4 ( VAR_2 . getId ( ) , VAR_1 ) ) . METHOD_2 ( ) ) ; }
private TYPE_1 [ ] METHOD_1 ( List < String > VAR_1 ) { return ( TYPE_1 [ ] ) ( new TYPE_2 < TYPE_4 > ( new TYPE_4 ( VAR_2 . getId ( ) , VAR_1 ) ) . METHOD_2 ( ) ) ; }
please omit TYPE_7 TYPE_8 prefix ArrayList imported ( lines )
public VAR_1 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { VAR_5 = new TYPE_7 . TYPE_8 . HashMap < String , TYPE_5 > ( ) ; VAR_6 = "" ; VAR_7 = "" ; VAR_8 = false ; VAR_9 = 0 ; VAR_10 = VAR_2 ; VAR_11 = VAR_3 ; VAR_12 = VAR_4 ; if ( VAR_10 != null ) { <START> VAR_10 . METHOD_1 ( new TYPE_7 . TYPE_8 . ArrayList < TYPE_5 > ( ) ) ; <END> VAR_10 . METHOD_2 ( new TYPE_7 . TYPE_8 . ArrayList < TYPE_6 > ( ) ) ; } }
public VAR_1 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { VAR_5 = new TYPE_7 . TYPE_8 . HashMap < String , TYPE_5 > ( ) ; VAR_6 = "" ; VAR_7 = "" ; VAR_8 = false ; VAR_9 = 0 ; VAR_10 = VAR_2 ; VAR_11 = VAR_3 ; VAR_12 = VAR_4 ; if ( VAR_10 != null ) { VAR_10 . METHOD_1 ( new ArrayList < TYPE_5 > ( ) ) ; VAR_10 . METHOD_2 ( new ArrayList < TYPE_6 > ( ) ) ; } }
perform update case vdsm call successes time _CODE_ ( ) change METHOD_4 ( ) update storage pool format type
protected void METHOD_1 ( ) { <START> METHOD_2 ( ) ; <END> METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( ) ) ; if ( METHOD_5 ( ) . METHOD_6 ( ) == TYPE_3 . TYPE_6 ) { if ( ! TYPE_1 . METHOD_7 ( VAR_3 . METHOD_8 ( ) , METHOD_5 ( ) . METHOD_8 ( ) ) ) { METHOD_9 ( TYPE_4 . TYPE_5 , new TYPE_2 ( METHOD_5 ( ) . getId ( ) , METHOD_5 ( ) . METHOD_8 ( ) ) ) ; } } METHOD_10 ( ) ; METHOD_11 ( true ) ; }
protected void METHOD_1 ( ) { METHOD_2 ( ) ; if ( VAR_3 . METHOD_6 ( ) == TYPE_3 . TYPE_6 ) { if ( ! TYPE_1 . METHOD_7 ( VAR_3 . METHOD_8 ( ) , METHOD_5 ( ) . METHOD_8 ( ) ) ) { METHOD_9 ( TYPE_4 . TYPE_5 , new TYPE_2 ( METHOD_5 ( ) . getId ( ) , METHOD_5 ( ) . METHOD_8 ( ) ) ) ; METHOD_3 ( ) . METHOD_4 ( METHOD_5 ( ) ) ; } } METHOD_10 ( ) ; METHOD_11 ( true ) ; }
static ? list expected change run need parse command
protected boolean METHOD_1 ( TYPE_1 vm ) { <START> String [ ] VAR_1 = TYPE_2 < String > METHOD_2 ( TYPE_3 . TYPE_5 ) . split ( STRING_1 ) ; <END> for ( String VAR_5 : VAR_1 ) { if ( VAR_5 . equalsIgnoreCase ( vm . VAR_6 ( ) ) ) { return true ; } } METHOD_3 ( TYPE_4 . VAR_8 ) ; return false ; }
protected boolean METHOD_1 ( TYPE_1 vm ) { for ( String VAR_5 : VAR_1 ) { if ( VAR_5 . equalsIgnoreCase ( vm . VAR_6 ( ) ) ) { return true ; } } METHOD_3 ( TYPE_4 . VAR_8 ) ; return false ; }
shouldn t braek VAR_1 false ? ( opinion ) i easier understand return false false : ( TYPE_2 VAR_2 : VAR_3 ) { ( ! VAR_2 METHOD_1 ( vds ) ) return false ; } return true ;
public boolean METHOD_1 ( TYPE_1 vds ) { boolean VAR_1 = true ; for ( TYPE_2 VAR_2 : VAR_3 ) { VAR_1 = VAR_1 && VAR_2 . METHOD_1 ( vds ) ; <START> if ( VAR_1 ) { <END> break ; } } return VAR_1 ; }
public boolean METHOD_1 ( TYPE_1 vds ) { for ( TYPE_2 VAR_2 : VAR_3 ) { if ( ! VAR_2 . METHOD_1 ( vds ) ) { return false ; } } return true ; }
opinion : ) ( break logic correct )
<START> public boolean METHOD_1 ( TYPE_1 vds ) { <END> boolean VAR_1 = false ; for ( TYPE_2 VAR_2 : VAR_3 ) { VAR_1 = VAR_1 || VAR_2 . METHOD_1 ( vds ) ; if ( VAR_1 ) { break ; } } return VAR_1 ; }
public boolean METHOD_1 ( TYPE_1 vds ) { for ( TYPE_2 VAR_2 : VAR_3 ) { if ( VAR_2 . METHOD_1 ( vds ) ) { return true ; } } return false ; }
minor : private method
<START> protected TYPE_1 METHOD_1 ( ) { <END> final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( Guid . TYPE_2 ( ) ) ; VAR_1 . METHOD_3 ( new ArrayList < Guid > ( Arrays . asList ( new Guid ( ) ) ) ) ; return VAR_1 ; }
private TYPE_1 METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( Guid . TYPE_2 ( ) ) ; VAR_1 . METHOD_3 ( new ArrayList < Guid > ( Arrays . asList ( new Guid ( ) ) ) ) ; return VAR_1 ; }
minor : private method
<START> protected TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) { <END> final TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 . METHOD_2 ( true ) ; VAR_2 . METHOD_3 ( new TYPE_3 ( VAR_1 . METHOD_4 ( ) , Guid . TYPE_4 ( ) ) ) ; return VAR_2 ; }
private TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) { final TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 . METHOD_2 ( true ) ; VAR_2 . METHOD_3 ( new TYPE_3 ( VAR_1 . METHOD_4 ( ) , Guid . TYPE_4 ( ) ) ) ; return VAR_2 ; }
shouldnt return ! ( _CODE_ )
private boolean METHOD_1 ( ) { return TYPE_2 < Boolean > METHOD_2 ( <START> TYPE_3 . TYPE_1 , METHOD_3 ( ) . METHOD_4 ( ) . getValue ( ) ) ; <END> }
private boolean METHOD_1 ( ) { return ! TYPE_2 < Boolean > METHOD_2 ( TYPE_3 . TYPE_1 , METHOD_3 ( ) . METHOD_4 ( ) . getValue ( ) ) ; }
permission vm storage
public List < TYPE_1 > METHOD_1 ( ) { if ( VAR_1 != null ) { if ( VAR_1 . METHOD_2 ( ) == TYPE_6 . VAR_3 ) { <START> return Collections . VAR_4 ( new TYPE_1 ( getParameters ( ) . METHOD_3 ( ) , <END> TYPE_5 . TYPE_2 , TYPE_3 . VAR_8 ) ) ; } if ( VAR_1 . METHOD_2 ( ) == TYPE_6 . VAR_9 ) { return Collections . VAR_4 ( new TYPE_1 ( VAR_1 . METHOD_4 ( ) , TYPE_5 . TYPE_4 , TYPE_3 . VAR_11 ) ) ; } } return null ; }
public List < TYPE_1 > METHOD_1 ( ) { if ( VAR_1 != null ) { if ( VAR_1 . METHOD_2 ( ) == TYPE_6 . VAR_3 ) { return Collections . VAR_4 ( new TYPE_1 ( VAR_1 . METHOD_4 ( ) , TYPE_5 . VAR_3 , TYPE_3 . VAR_8 ) ) ; } if ( VAR_1 . METHOD_2 ( ) == TYPE_6 . VAR_9 ) { return Collections . VAR_4 ( new TYPE_1 ( VAR_1 . METHOD_4 ( ) , TYPE_5 . TYPE_4 , TYPE_3 . VAR_11 ) ) ; } } return null ; }
need check vm ! = null
protected void METHOD_1 ( ) { String VAR_1 = null ; if ( getParameters ( ) . METHOD_2 ( ) == null ) { METHOD_3 ( ) . METHOD_4 ( VAR_1 ) ; } else { <START> TYPE_1 vm = TYPE_2 . getInstance ( ) . METHOD_5 ( ) . METHOD_6 ( getParameters ( ) . METHOD_2 ( ) ) ; <END> VAR_1 = TYPE_3 . METHOD_7 ( vm . VAR_2 ( ) , TYPE_4 . METHOD_8 ( vm ) ) ; } METHOD_3 ( ) . METHOD_4 ( VAR_1 ) ; }
protected void METHOD_1 ( ) { String VAR_1 = null ; if ( getParameters ( ) . METHOD_2 ( ) == null ) { METHOD_3 ( ) . METHOD_4 ( VAR_1 ) ; } else { TYPE_1 vm = TYPE_2 . getInstance ( ) . METHOD_5 ( ) . METHOD_6 ( getParameters ( ) . METHOD_2 ( ) ) ; if ( vm != null ) { VAR_1 = TYPE_3 . METHOD_7 ( vm . VAR_2 ( ) , TYPE_4 . METHOD_8 ( vm ) ) ; } METHOD_3 ( ) . METHOD_4 ( VAR_1 ) ; } }
add a check METHOD_2 exists ( null )
protected boolean METHOD_1 ( ) { <START> if ( METHOD_2 ( ) . METHOD_3 ( ) ) { <END> METHOD_4 ( TYPE_1 . VAR_2 ) ; return false ; } return super . METHOD_1 ( ) ; }
protected boolean METHOD_1 ( ) { if ( ! super . METHOD_1 ( ) ) { return false ; } if ( METHOD_2 ( ) . METHOD_3 ( ) ) { METHOD_4 ( TYPE_1 . VAR_2 ) ; return false ; } return true ; }
I VAR_2 variable passed VAR_3 method instead converting string
public TYPE_1 METHOD_1 ( String VAR_1 , Boolean VAR_2 ) { try { <START> return new TYPE_1 ( VAR_3 . METHOD_1 ( VAR_1 , VAR_2 . toString ( ) ) ) ; <END> } catch ( TYPE_2 VAR_4 ) { throw new TYPE_3 ( VAR_4 ) ; } }
public TYPE_1 METHOD_1 ( String VAR_1 , Boolean VAR_2 ) { try { return new TYPE_1 ( VAR_3 . METHOD_1 ( VAR_1 , VAR_2 ) ) ; } catch ( TYPE_2 VAR_4 ) { throw new TYPE_3 ( VAR_4 ) ; } }
i gluster volume id set super constructor
public TYPE_2 ( TYPE_1 params ) { super ( params ) ; <START> METHOD_1 ( getParameters ( ) . METHOD_2 ( ) ) ; <END> }
public TYPE_2 ( TYPE_1 params ) { super ( params ) ; }
consider testing ( ) ! = null test isn t completely dependent remove ( )
public void METHOD_1 ( ) { assertEquals ( VAR_1 . remove ( VAR_2 . METHOD_2 ( ) ) , 1 ) ; TYPE_1 result = VAR_1 . get ( VAR_2 . METHOD_2 ( ) ) ; METHOD_3 ( result ) ; <START> <END> assertEquals ( VAR_1 . remove ( VAR_2 . METHOD_2 ( ) ) , 0 ) ; }
public void METHOD_1 ( ) { TYPE_1 result = VAR_1 . get ( VAR_2 . METHOD_2 ( ) ) ; assertNotNull ( result ) ; assertEquals ( VAR_1 . remove ( VAR_2 . METHOD_2 ( ) ) , 1 ) ; result = VAR_1 . get ( VAR_2 . METHOD_2 ( ) ) ; METHOD_3 ( result ) ; assertEquals ( VAR_1 . remove ( VAR_2 . METHOD_2 ( ) ) , 0 ) ; }
a single line
<START> public static Guid METHOD_1 ( TYPE_1 id ) { <END> if ( id == null ) { return null ; } return id . getValue ( ) ; }
public static Guid METHOD_1 ( TYPE_1 id ) { return id == null ? null : id . getValue ( ) ; }
require permission disk calling super add requirement vm
public List < TYPE_1 > METHOD_1 ( ) { if ( VAR_1 == null ) { <START> VAR_1 = super . METHOD_1 ( ) ; <END> Guid VAR_2 = VAR_3 == null ? null : VAR_3 . METHOD_2 ( ) ; VAR_1 . add ( new TYPE_1 ( VAR_2 , TYPE_4 . TYPE_5 , TYPE_3 . VAR_7 ) ) ; VAR_1 = TYPE_2 . getInstance ( ) . METHOD_3 ( VAR_1 , METHOD_4 ( ) , METHOD_5 ( ) ) ; } return VAR_1 ; }
public List < TYPE_1 > METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = new ArrayList < TYPE_1 > ( ) ; Guid VAR_2 = VAR_3 == null ? null : VAR_3 . METHOD_2 ( ) ; VAR_1 . add ( new TYPE_1 ( VAR_2 , TYPE_4 . TYPE_5 , TYPE_3 . VAR_7 ) ) ; VAR_1 = TYPE_2 . getInstance ( ) . METHOD_3 ( VAR_1 , METHOD_4 ( ) , METHOD_5 ( ) ) ; } return VAR_1 ; }
I boolean removed add a default quota time create a DC flag time edit creation quota time _CODE_ = true
private TYPE_1 METHOD_1 ( ) { <START> boolean VAR_1 = ( METHOD_2 ( ) . METHOD_3 ( ) == TYPE_2 . VAR_3 ) ; <END> TYPE_1 VAR_4 = METHOD_4 ( ) . METHOD_5 ( METHOD_2 ( ) , VAR_1 ) ; return VAR_4 ; }
private TYPE_1 METHOD_1 ( ) { return METHOD_4 ( ) . METHOD_5 ( METHOD_2 ( ) , true ) ; }
put call METHOD_5 ( vm ) method METHOD_4 ( ) s method - adds information want VAR_7 objects mapped
protected TYPE_1 METHOD_1 ( List < org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . TYPE_2 > VAR_6 ) { TYPE_1 VAR_7 = new TYPE_1 ( ) ; for ( org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . TYPE_2 entity : VAR_6 ) { TYPE_2 vm = map ( entity ) ; VAR_7 . METHOD_2 ( ) . add ( METHOD_3 ( METHOD_4 ( vm , entity ) ) ) ; <START> METHOD_5 ( vm ) ; <END> } return VAR_7 ; }
protected TYPE_1 METHOD_1 ( List < org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . TYPE_2 > VAR_6 ) { TYPE_1 VAR_7 = new TYPE_1 ( ) ; for ( org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . TYPE_2 entity : VAR_6 ) { TYPE_2 vm = map ( entity ) ; VAR_7 . METHOD_2 ( ) . add ( METHOD_3 ( METHOD_4 ( vm , entity ) ) ) ; } return VAR_7 ; }
need check VAR_2 isEmpty ( )
public static ArrayList < Guid > METHOD_1 ( String VAR_1 ) { ArrayList < String > VAR_2 = METHOD_2 ( VAR_1 ) ; <START> ArrayList < Guid > VAR_3 = new ArrayList < Guid > ( ) ; <END> if ( ! ( VAR_2 == null || VAR_2 . isEmpty ( ) ) ) { for ( String VAR_4 : VAR_2 ) { VAR_3 . add ( Guid . VAR_5 ( VAR_4 ) ) ; } } if ( VAR_3 . isEmpty ( ) ) { VAR_3 . add ( Guid . TYPE_1 ) ; } return VAR_3 ; }
public static ArrayList < Guid > METHOD_1 ( String VAR_1 ) { ArrayList < String > VAR_2 = METHOD_2 ( VAR_1 ) ; ArrayList < Guid > VAR_3 = new ArrayList < Guid > ( ) ; if ( VAR_2 != null ) { for ( String VAR_4 : VAR_2 ) { VAR_3 . add ( Guid . VAR_5 ( VAR_4 ) ) ; } } if ( VAR_3 . isEmpty ( ) ) { VAR_3 . add ( Guid . TYPE_1 ) ; } return VAR_3 ; }
nt getter _CODE_ field VAR_1
<START> public Guid getId ( ) { <END> return VAR_1 ; }
public Guid getId ( ) { return id ; }
need explicit call toString METHOD_4 ( ) null safe
public String toString ( ) { return String . format ( STRING_1 , super . toString ( ) , METHOD_1 ( ) , METHOD_2 ( ) , <START> METHOD_3 ( ) , METHOD_4 ( ) . toString ( ) ) ; <END> }
public String toString ( ) { return String . format ( STRING_1 , super . toString ( ) , METHOD_1 ( ) , METHOD_2 ( ) , METHOD_3 ( ) , METHOD_4 ( ) ) ; }
answer
public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = super . METHOD_1 ( ) ; <START> if ( getParameters ( ) . METHOD_2 ( ) . METHOD_3 ( ) ) { <END> VAR_1 . add ( new TYPE_1 ( METHOD_4 ( ) . METHOD_5 ( ) , TYPE_4 . TYPE_2 , TYPE_3 . VAR_5 ) ) ; } return VAR_1 ; }
public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = super . METHOD_1 ( ) ; if ( getParameters ( ) . METHOD_2 ( ) != null && METHOD_4 ( ) != null && getParameters ( ) . METHOD_2 ( ) . METHOD_3 ( ) ) { VAR_1 . add ( new TYPE_1 ( METHOD_4 ( ) . METHOD_5 ( ) , TYPE_4 . TYPE_2 , TYPE_3 . VAR_5 ) ) ; } return VAR_1 ; }
compare VAR_1 id image id
private static void METHOD_1 ( TYPE_1 VAR_1 ) { for ( int i = 0 ; i < VAR_2 ; ++ i ) { <START> assertEquals ( STRING_1 + i + STRING_2 , VAR_1 . getId ( ) , VAR_1 . METHOD_2 ( ) . get ( i ) . METHOD_3 ( ) ) ; <END> } }
private static void METHOD_1 ( TYPE_1 VAR_1 ) { for ( int i = 0 ; i < VAR_2 ; ++ i ) { assertEquals ( STRING_1 + i + STRING_2 , VAR_1 . getId ( ) , VAR_1 . METHOD_2 ( ) . get ( i ) . getId ( ) ) ; } }
disk identifier s ID I s compare _CODE_ anymore
protected boolean METHOD_1 ( TYPE_1 entity , Guid id ) { <START> return id != null && ( id . equals ( entity . getId ( ) ) || id . equals ( entity . VAR_1 ( ) ) || id . equals ( entity . VAR_2 ( ) ) ) ; <END> }
protected boolean METHOD_1 ( TYPE_1 entity , Guid id ) { return id != null && ( id . equals ( entity . getId ( ) ) || id . equals ( entity . VAR_2 ( ) ) ) ; }
break loop reached a failed VAR_3 METHOD_1 ( )
public boolean METHOD_1 ( ) { boolean VAR_1 = VAR_2 ; for ( TYPE_1 VAR_3 : METHOD_2 ( ) ) { <START> VAR_1 &= VAR_3 . METHOD_1 ( ) ; <END> } return VAR_1 ; }
public boolean METHOD_1 ( ) { boolean VAR_1 = VAR_2 ; for ( TYPE_1 VAR_3 : METHOD_2 ( ) ) { VAR_1 &= VAR_3 . METHOD_1 ( ) ; if ( ! VAR_1 ) { break ; } } return VAR_1 ; }
I consider rewriting : ( values = = null ) { values = new HashMap < String Object > ( ) ; VAR_2 put ( VAR_1 METHOD_2 ( ) values ) ; } values put ( VAR_1 METHOD_3 ( ) METHOD_4 ( VAR_1 ) ) ;
private static void METHOD_1 ( TYPE_1 VAR_1 ) { Map < String , Object > values = VAR_2 . get ( VAR_1 . METHOD_2 ( ) ) ; <START> if ( values != null ) { <END> values . put ( VAR_1 . METHOD_3 ( ) , METHOD_4 ( VAR_1 ) ) ; } else { values = new HashMap < String , Object > ( ) ; values . put ( VAR_1 . METHOD_3 ( ) , METHOD_4 ( VAR_1 ) ) ; VAR_2 . put ( VAR_1 . METHOD_2 ( ) , values ) ; } }
private static void METHOD_1 ( TYPE_1 VAR_1 ) { Map < String , Object > values = VAR_2 . get ( VAR_1 . METHOD_2 ( ) ) ; if ( values == null ) { values = new HashMap < String , Object > ( ) ; VAR_2 . put ( VAR_1 . METHOD_2 ( ) , values ) ; } values . put ( VAR_1 . METHOD_3 ( ) , METHOD_4 ( VAR_1 ) ) ; }
TYPE_1 ? unchekced
<START> private static boolean METHOD_1 ( String VAR_1 ) throws TYPE_1 , TYPE_2 { <END> return TYPE_3 . class . METHOD_2 ( VAR_1 ) . METHOD_3 ( TYPE_4 . class ) ; }
private static boolean METHOD_1 ( String VAR_1 ) throws TYPE_2 { return TYPE_3 . class . METHOD_2 ( VAR_1 ) . METHOD_3 ( TYPE_4 . class ) ; }
METHOD_3 ( ) ? solve generic
protected TYPE_1 METHOD_1 ( String id ) { TYPE_2 params = new TYPE_2 ( Guid . VAR_1 ( id ) ) ; <START> params . VAR_2 ( TYPE_3 . METHOD_2 ( ) ) ; <END> return METHOD_3 ( TYPE_1 . class , TYPE_5 . TYPE_4 , params , id ) ; }
protected TYPE_1 METHOD_1 ( String id ) { return METHOD_3 ( TYPE_1 . class , TYPE_5 . TYPE_4 , new TYPE_2 ( Guid . VAR_1 ( id ) ) , id ) ; }
METHOD_3 ( ) ? solve generic
public TYPE_1 list ( ) { TYPE_2 params = new TYPE_2 ( VAR_1 ) ; <START> params . VAR_2 ( TYPE_3 . METHOD_1 ( ) ) ; <END> return METHOD_2 ( METHOD_3 ( TYPE_4 . TYPE_5 , params ) ) ; }
public TYPE_1 list ( ) { return METHOD_2 ( METHOD_3 ( TYPE_4 . TYPE_5 , new TYPE_2 ( VAR_1 ) ) ) ; }
METHOD_2 ( ) ? solve generic
public TYPE_1 get ( ) { TYPE_2 params = new TYPE_2 ( VAR_1 ) ; <START> params . VAR_2 ( TYPE_3 . METHOD_1 ( ) ) ; <END> return METHOD_2 ( TYPE_5 . TYPE_4 , params ) ; }
public TYPE_1 get ( ) { return METHOD_2 ( TYPE_5 . TYPE_4 , new TYPE_2 ( VAR_1 ) ) ; }
a matter taste tought : VAR_3 = Boolean VAR_2 ( VAR_1 ) ) ;
<START> public void METHOD_1 ( String VAR_1 ) { <END> if ( Boolean . VAR_2 ( VAR_1 ) ) { VAR_3 = true ; } else { VAR_3 = false ; } }
public void METHOD_1 ( String VAR_1 ) { VAR_3 = Boolean . VAR_2 ( VAR_1 ) ; }
needed cal METHOD_6 ( ) guids ? i don t remember need /
public void METHOD_1 ( Guid VAR_1 ) { METHOD_2 ( ) . METHOD_3 ( STRING_1 , <START> METHOD_4 ( ) . METHOD_5 ( STRING_2 , VAR_1 . METHOD_6 ( ) ) ) ; <END> }
public void METHOD_1 ( Guid VAR_1 ) { METHOD_2 ( ) . METHOD_3 ( STRING_1 , METHOD_4 ( ) . METHOD_5 ( STRING_2 , VAR_1 ) ) ; }
VAR_3 initialized command storage type VAR_4
private boolean METHOD_1 ( ) { final Set < TYPE_1 > VAR_1 = METHOD_2 ( METHOD_3 ( ) . METHOD_4 ( ) ) ; final TYPE_1 VAR_2 = METHOD_5 ( ) . METHOD_6 ( ) ; <START> final TYPE_2 VAR_3 = METHOD_5 ( ) . METHOD_7 ( ) ; <END> if ( ! VAR_1 . contains ( VAR_2 ) ) { return false ; } if ( ( VAR_2 == TYPE_1 . VAR_4 ) && ( VAR_3 != TYPE_2 . VAR_5 ) && ( VAR_3 != TYPE_2 . VAR_6 ) ) { return false ; } return true ; }
private boolean METHOD_1 ( ) { final Set < TYPE_1 > VAR_1 = METHOD_2 ( METHOD_3 ( ) . METHOD_4 ( ) ) ; final TYPE_1 VAR_2 = METHOD_5 ( ) . METHOD_6 ( ) ; if ( ! VAR_1 . contains ( VAR_2 ) ) { return false ; } if ( VAR_2 == TYPE_1 . VAR_4 ) { final TYPE_2 VAR_3 = METHOD_5 ( ) . METHOD_7 ( ) ; if ( VAR_3 != TYPE_2 . VAR_5 && VAR_3 != TYPE_2 . VAR_6 ) { return false } } return true ; }
storage pool null ? ( LUN disk floating )
protected boolean METHOD_1 ( ) { return TYPE_1 < Boolean > METHOD_2 ( TYPE_2 . TYPE_3 , <START> METHOD_3 ( ) . METHOD_4 ( ) . getValue ( ) ) ; <END> }
protected boolean METHOD_1 ( ) { return METHOD_3 ( ) != null ? TYPE_1 < Boolean > METHOD_2 ( TYPE_2 . TYPE_3 , METHOD_3 ( ) . METHOD_4 ( ) . getValue ( ) ) : true ; }
I don t idea put query constarctor _CODE_ unneeded query don t need a _CODE_ _CODE_ _CODE_ _CODE_ _CODE_ putting constractor wrong
public TYPE_2 ( T parameters ) { super ( parameters ) ; if ( parameters . VAR_2 ( ) != null && TYPE_3 . VAR_4 == parameters . VAR_2 ( ) . METHOD_1 ( ) ) { METHOD_2 ( ( ( TYPE_1 ) parameters . VAR_2 ( ) ) . METHOD_3 ( ) ) ; <START> } <END> if ( METHOD_4 ( ) != null ) { METHOD_5 ( METHOD_4 ( ) . METHOD_6 ( ) ) ; } }
public TYPE_2 ( T parameters ) { super ( parameters ) ; if ( parameters . VAR_2 ( ) != null && TYPE_3 . VAR_4 == parameters . VAR_2 ( ) . METHOD_1 ( ) ) { METHOD_2 ( ( ( TYPE_1 ) parameters . VAR_2 ( ) ) . METHOD_3 ( ) ) ; } }
a ( ! ) check i relevant
protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( VAR_1 == null || METHOD_2 ( VAR_1 ) ) { <END> METHOD_3 ( TYPE_2 . VAR_3 ) ; return false ; } return true ; }
protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null || ! METHOD_2 ( VAR_1 ) ) { METHOD_3 ( TYPE_2 . VAR_3 ) ; return false ; } return true ; }
rebase VAR_1 needed more point
private void METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . getInstance ( ) . METHOD_2 ( ) <START> . METHOD_3 ( TYPE_5 . TYPE_4 , new TYPE_3 ( METHOD_4 ( ) ) ) ; <END> }
private void METHOD_1 ( ) { TYPE_2 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_5 . TYPE_4 , new TYPE_3 ( METHOD_4 ( ) ) ) ; }
good enough some reason execution fail method called fail run error audit log failure
private void METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_6 . TYPE_4 , new TYPE_3 ( METHOD_4 ( ) ) ) ; if ( ! VAR_1 . METHOD_5 ( ) ) { <START> VAR_4 = TYPE_5 . VAR_6 ; <END> } }
private void METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_6 . TYPE_4 , new TYPE_3 ( METHOD_4 ( ) ) ) ; }