Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
redundant
public Guid METHOD_1 ( TYPE_1 VAR_1 ) { Guid VAR_2 = Guid . TYPE_5 ; try { TYPE_2 task = METHOD_2 ( new TYPE_3 ( ) , VAR_1 ) ; VAR_2 = task . VAR_4 ( ) ; TYPE_4 . METHOD_3 ( task , null , VAR_5 ) ; } catch ( RuntimeException ex ) { <START> log . VAR_6 ( STRING_1 , this . getClass ( ) . getName ( ) , ex ) ; <END> } return VAR_2 ; }
public Guid METHOD_1 ( TYPE_1 VAR_1 ) { Guid VAR_2 = Guid . TYPE_5 ; try { TYPE_2 task = METHOD_2 ( new TYPE_3 ( ) , VAR_1 ) ; VAR_2 = task . VAR_4 ( ) ; TYPE_4 . METHOD_3 ( task , null , VAR_5 ) ; } catch ( RuntimeException ex ) { log . VAR_6 ( STRING_1 , getClass ( ) . getName ( ) , ex ) ; } return VAR_2 ; }
redundant cast
public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_3 ( ) ; METHOD_4 ( ) ; METHOD_5 ( ) ; <START> if ( ( TYPE_1 ) METHOD_6 ( ) . METHOD_7 ( ) . METHOD_8 ( ) != null ) { <END> TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_6 ( ) . METHOD_7 ( ) . METHOD_8 ( ) ; METHOD_9 ( VAR_1 . METHOD_10 ( ) , VAR_1 . METHOD_11 ( ) ) ; } METHOD_12 ( ) ; }
public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_3 ( ) ; METHOD_4 ( ) ; METHOD_5 ( ) ; if ( METHOD_6 ( ) . METHOD_7 ( ) . METHOD_8 ( ) != null ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_6 ( ) . METHOD_7 ( ) . METHOD_8 ( ) ; METHOD_9 ( VAR_1 . METHOD_10 ( ) , VAR_1 . METHOD_11 ( ) ) ; } METHOD_12 ( ) ; }
instead Boolean valueOf ( boolean ) toString ( ) String valueOf ( boolean )
protected void METHOD_1 ( ) { <START> status = METHOD_2 ( ) . METHOD_3 ( VAR_1 . toString ( ) , ( Boolean . valueOf ( VAR_2 ) ) . toString ( ) ) ; <END> METHOD_4 ( ) ; }
protected void METHOD_1 ( ) { status = METHOD_2 ( ) . METHOD_3 ( VAR_1 . toString ( ) , String . valueOf ( VAR_2 ) ) ; METHOD_4 ( ) ; }
instead Integer valueOf ( int ) toString ( ) String valueOf ( int )
protected void METHOD_1 ( ) { if ( getParameters ( ) . METHOD_2 ( ) ) { status = METHOD_3 ( ) . METHOD_4 ( getParameters ( ) . METHOD_5 ( ) . toString ( ) , <START> ( Integer . valueOf ( getParameters ( ) . METHOD_6 ( ) ) ) . toString ( ) , <END> TYPE_1 < String > METHOD_7 ( TYPE_2 . TYPE_3 ) ) ; } else { status = METHOD_3 ( ) . METHOD_8 ( getParameters ( ) . METHOD_5 ( ) . toString ( ) ) ; } METHOD_9 ( ) ; }
protected void METHOD_1 ( ) { if ( getParameters ( ) . METHOD_2 ( ) ) { status = METHOD_3 ( ) . METHOD_4 ( getParameters ( ) . METHOD_5 ( ) . toString ( ) , String . valueOf ( getParameters ( ) . METHOD_6 ( ) ) , TYPE_1 < String > METHOD_7 ( TYPE_2 . TYPE_3 ) ) ; } else { status = METHOD_3 ( ) . METHOD_8 ( getParameters ( ) . METHOD_5 ( ) . toString ( ) ) ; } METHOD_9 ( ) ; }
instead Integer valueOf ( int ) toString ( ) String valueOf ( int )
private static void METHOD_1 ( TYPE_1 VAR_1 , Map < String , Object > VAR_2 ) { <START> String s = Integer . valueOf ( VAR_1 . METHOD_2 ( ) ) . toString ( ) ; <END> if ( ! org . VAR_3 . VAR_4 . VAR_5 . StringUtils . isEmpty ( s ) && ! s . equals ( STRING_1 ) ) { VAR_2 . put ( TYPE_3 . TYPE_2 , s ) ; } }
private static void METHOD_1 ( TYPE_1 VAR_1 , Map < String , Object > VAR_2 ) { String s = String . valueOf ( VAR_1 . METHOD_2 ( ) ) ; if ( ! org . VAR_3 . VAR_4 . VAR_5 . StringUtils . isEmpty ( s ) && ! s . equals ( STRING_1 ) ) { VAR_2 . put ( TYPE_3 . TYPE_2 , s ) ; } }
nullity check : )
public void METHOD_1 ( String value ) { <START> if ( ! VAR_1 . equals ( value ) ) <END> { VAR_1 = value ; METHOD_2 ( new TYPE_1 ( STRING_1 ) ) ; } }
public void METHOD_1 ( String value ) { if ( VAR_1 != null && ! VAR_1 . equals ( value ) ) { VAR_1 = value ; METHOD_2 ( new TYPE_1 ( STRING_1 ) ) ; } }
save null check : ! equals ( model VAR_1 ( ) )
private boolean METHOD_1 ( TYPE_1 model ) { <START> return ! ( model . VAR_1 ( ) != null && ! model . VAR_1 ( ) . equals ( "" ) ) ; <END> }
private boolean METHOD_1 ( TYPE_1 model ) { return ! ( ! "" . equals ( model . VAR_1 ( ) ) ) ; }
extracted code notice line redundant done line 80 _CODE_ message line done line 80 consideration
private void METHOD_1 ( Exception e , TYPE_1 status ) { log . VAR_1 ( STRING_1 , METHOD_2 ( ) . getId ( ) , METHOD_2 ( ) . getName ( ) , e ) ; METHOD_3 ( status ) ; METHOD_4 ( false ) ; VAR_2 = METHOD_5 ( e . getMessage ( ) ) ; <START> METHOD_6 ( STRING_2 , VAR_2 ) ; <END> }
private void METHOD_1 ( Exception e , TYPE_1 status ) { log . VAR_1 ( STRING_1 , METHOD_2 ( ) . getId ( ) , METHOD_2 ( ) . getName ( ) , e ) ; METHOD_3 ( status ) ; METHOD_4 ( false ) ; VAR_2 = e . getMessage ( ) ; }
need
public void METHOD_1 ( String VAR_1 ) { <START> this . VAR_2 = VAR_1 ; <END> }
public void METHOD_1 ( String VAR_1 ) { VAR_2 = VAR_1 ; }
empty string constructor redundant
public static String METHOD_1 ( String VAR_1 , List < TYPE_1 > params ) { <START> StringBuilder VAR_2 = new StringBuilder ( "" ) ; <END> if ( params != null ) { for ( TYPE_1 VAR_3 : params ) { for ( TYPE_2 VAR_4 : VAR_3 . getParameters ( ) ) { VAR_2 . append ( String . format ( VAR_5 , VAR_4 . getName ( ) , VAR_4 . getValue ( ) ) ) ; } } } VAR_2 . METHOD_2 ( 0 , VAR_1 ) ; return VAR_2 . toString ( ) ; }
public static String METHOD_1 ( String VAR_1 , List < TYPE_1 > params ) { StringBuilder VAR_2 = new StringBuilder ( ) ; if ( params != null ) { for ( TYPE_1 VAR_3 : params ) { for ( TYPE_2 VAR_4 : VAR_3 . getParameters ( ) ) { VAR_2 . append ( String . format ( VAR_5 , VAR_4 . getName ( ) , VAR_4 . getValue ( ) ) ) ; } } } VAR_2 . METHOD_2 ( 0 , VAR_1 ) ; return VAR_2 . toString ( ) ; }
consider a single line : VAR_1 append ( VAR_2 METHOD_2 ( ) append ( VAR_2 METHOD_3 ( ) append ( VAR_4 ) ;
String METHOD_1 ( ) { StringBuilder VAR_1 = new StringBuilder ( VAR_2 . empty ( ) ) ; for ( int i = 0 ; i < VAR_3 . size ( ) ; i ++ ) { String VAR_4 = VAR_3 . get ( i ) ; VAR_1 . append ( VAR_2 . METHOD_2 ( ) ) ; VAR_1 . append ( VAR_2 . METHOD_3 ( ) ) ; <START> VAR_1 . append ( VAR_4 ) ; <END> } return VAR_1 . toString ( ) ; }
String METHOD_1 ( ) { StringBuilder VAR_1 = new StringBuilder ( VAR_2 . empty ( ) ) ; for ( int i = 0 ; i < VAR_3 . size ( ) ; i ++ ) { String VAR_4 = VAR_3 . get ( i ) ; VAR_1 . append ( VAR_2 . METHOD_2 ( ) ) . append ( VAR_2 . METHOD_3 ( ) ) . append ( VAR_4 ) ; } return VAR_1 . toString ( ) ; }
empty string redundent
public TYPE_1 METHOD_1 ( ) { <START> StringBuilder VAR_1 = new StringBuilder ( "" ) ; <END> for ( TYPE_2 a : METHOD_2 ( ) ) { if ( a . VAR_2 ( ) ) { TYPE_1 VAR_3 = ( TYPE_1 ) a . VAR_4 ( ) ; VAR_1 . append ( VAR_3 . toString ( ) ) ; } } return ! VAR_1 . equals ( "" ) ? TYPE_1 . valueOf ( VAR_1 . toString ( ) ) : null ; }
public TYPE_1 METHOD_1 ( ) { StringBuilder VAR_1 = new StringBuilder ( ) ; for ( TYPE_2 a : METHOD_2 ( ) ) { if ( a . VAR_2 ( ) ) { TYPE_1 VAR_3 = ( TYPE_1 ) a . VAR_4 ( ) ; VAR_1 . append ( VAR_3 . toString ( ) ) ; } } return ! VAR_1 . equals ( "" ) ? TYPE_1 . valueOf ( VAR_1 . toString ( ) ) : null ; }
/ s / TYPE_2 getInstance ( ) METHOD_4 ( ) / METHOD_4
private void METHOD_1 ( ) { for ( Guid VAR_1 : METHOD_2 ( ) . METHOD_3 ( ) ) { <START> TYPE_1 task = TYPE_2 . getInstance ( ) . METHOD_4 ( ) . get ( VAR_1 ) ; <END> if ( task . VAR_2 ( ) . equals ( TYPE_5 . TYPE_4 ) ) { TYPE_3 . METHOD_5 ( task ) ; } } }
private void METHOD_1 ( ) { for ( Guid VAR_1 : METHOD_2 ( ) . METHOD_3 ( ) ) { TYPE_1 task = METHOD_4 ( ) . get ( VAR_1 ) ; if ( task . VAR_2 ( ) . equals ( TYPE_5 . TYPE_4 ) ) { TYPE_3 . METHOD_5 ( task ) ; } } }
IMHO explicit Object constructor redundant
public TYPE_1 ( final int VAR_2 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; }
public TYPE_1 ( final int VAR_2 ) { this . VAR_2 = VAR_2 ; }
equals - guarantee s Guid instance
protected void METHOD_1 ( ) { Guid VAR_1 = METHOD_2 ( ) . getParameters ( ) . METHOD_3 ( ) ; Guid VAR_2 = METHOD_2 ( ) . getParameters ( ) . METHOD_4 ( ) ; TYPE_1 VAR_3 = METHOD_5 ( ) . get ( VAR_2 ) ; <START> if ( VAR_3 != null && VAR_3 . METHOD_6 ( ) . get ( 0 ) == VAR_1 ) { <END> METHOD_2 ( ) . getParameters ( ) . METHOD_7 ( 0 ) ; } }
protected void METHOD_1 ( ) { Guid VAR_1 = METHOD_2 ( ) . getParameters ( ) . METHOD_3 ( ) ; Guid VAR_2 = METHOD_2 ( ) . getParameters ( ) . METHOD_4 ( ) ; TYPE_1 VAR_3 = METHOD_5 ( ) . get ( VAR_2 ) ; if ( VAR_3 != null && VAR_1 . equals ( VAR_3 . METHOD_6 ( ) . get ( 0 ) ) ) { METHOD_2 ( ) . getParameters ( ) . METHOD_7 ( 0 ) ; } }
replacing ternary ?
public TYPE_1 METHOD_1 ( ) { StringBuilder VAR_1 = new StringBuilder ( ) ; for ( TYPE_2 a : METHOD_2 ( ) ) { if ( a . VAR_2 ( ) ) { TYPE_1 VAR_3 = ( TYPE_1 ) a . VAR_4 ( ) ; VAR_1 . append ( VAR_3 . toString ( ) ) ; } } String VAR_5 = VAR_1 . toString ( ) ; if ( ! VAR_5 . equals ( "" ) ) { return TYPE_1 . valueOf ( VAR_5 ) ; } <START> return null ; <END> }
public TYPE_1 METHOD_1 ( ) { StringBuilder VAR_1 = new StringBuilder ( ) ; for ( TYPE_2 a : METHOD_2 ( ) ) { if ( a . VAR_2 ( ) ) { TYPE_1 VAR_3 = ( TYPE_1 ) a . VAR_4 ( ) ; VAR_1 . append ( VAR_3 . toString ( ) ) ; } } return ! VAR_1 . toString ( ) . equals ( "" ) ? TYPE_1 . valueOf ( VAR_1 . toString ( ) ) : null ; }
remove VM place audit log removed
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( ) ? ( VAR_1 . isEmpty ( ) ? TYPE_1 . VAR_2 : TYPE_1 . VAR_3 ) <START> : TYPE_1 . VAR_4 ; <END> }
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( ) ? TYPE_1 . VAR_2 : TYPE_1 . VAR_3 ; }
potential NPE host VAR_4 ( ) _CODE_ please remove Long valueOf ( ) host VAR_4 ( ) Long INT_2
public void METHOD_1 ( ) { TYPE_1 vds = new TYPE_1 ( ) ; vds . VAR_1 ( Guid . TYPE_4 ) ; vds . VAR_3 ( INT_1 ) ; TYPE_2 host = TYPE_3 . map ( vds , ( TYPE_2 ) null ) ; assertNotNull ( host . VAR_4 ( ) ) ; <START> assertEquals ( host . VAR_4 ( ) . METHOD_2 ( ) , INT_2 ) ; <END> }
public void METHOD_1 ( ) { TYPE_1 vds = new TYPE_1 ( ) ; vds . VAR_1 ( Guid . TYPE_4 ) ; vds . VAR_3 ( INT_1 ) ; TYPE_2 host = TYPE_3 . map ( vds , ( TYPE_2 ) null ) ; assertNotNull ( host . VAR_4 ( ) ) ; assertEquals ( host . VAR_4 ( ) , Long . valueOf ( INT_2 ) ) ; }
need check - vds VAR_2 ( ) ! = null
protected void METHOD_1 ( ArrayList < TYPE_1 > VAR_1 , TYPE_2 vds ) { <START> if ( VAR_1 != null && vds . VAR_2 ( ) != null ) <END> { METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ; METHOD_2 ( ) . METHOD_4 ( TYPE_3 . METHOD_5 ( VAR_1 , new TYPE_3 . TYPE_5 ( vds . VAR_2 ( ) ) ) ) ; if ( METHOD_2 ( ) . METHOD_6 ( ) == null ) { METHOD_2 ( ) . METHOD_4 ( TYPE_3 . METHOD_5 ( VAR_1 ) ) ; } } }
protected void METHOD_1 ( ArrayList < TYPE_1 > VAR_1 , TYPE_2 vds ) { if ( VAR_1 != null ) { METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ; METHOD_2 ( ) . METHOD_4 ( TYPE_3 . METHOD_5 ( VAR_1 , new TYPE_3 . TYPE_5 ( vds . VAR_2 ( ) ) ) ) ; if ( METHOD_2 ( ) . METHOD_6 ( ) == null ) { METHOD_2 ( ) . METHOD_4 ( TYPE_3 . METHOD_5 ( VAR_1 ) ) ; } } }
done
protected void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; boolean VAR_2 = true ; if ( VAR_1 . METHOD_3 ( ) ) { <START> METHOD_4 ( METHOD_5 ( ) ) ; <END> } if ( VAR_1 . METHOD_6 ( ) ) { VAR_2 = METHOD_7 ( ) ; } if ( VAR_2 && VAR_1 . METHOD_8 ( ) ) { VAR_2 = METHOD_9 ( ) ; } METHOD_4 ( VAR_2 ) ; }
protected void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; boolean VAR_2 = true ; if ( VAR_1 . METHOD_3 ( ) ) { VAR_2 = METHOD_5 ( ) ; } if ( VAR_2 && VAR_1 . METHOD_6 ( ) ) { VAR_2 = METHOD_7 ( ) ; } if ( VAR_2 && VAR_1 . METHOD_8 ( ) ) { VAR_2 = METHOD_9 ( ) ; } METHOD_4 ( VAR_2 ) ; }
please format code correctly enter { else
public TYPE_1 ( String [ ] VAR_2 ) { if ( VAR_2 == null ) { this . VAR_2 . add ( new String ( ) ) ; <START> } else for ( String VAR_3 : VAR_2 ) { <END> this . VAR_2 . add ( VAR_3 . METHOD_1 ( ) ) ; } }
public TYPE_1 ( String [ ] VAR_2 ) { if ( VAR_2 == null ) { this . VAR_2 . add ( new String ( ) ) ; } else { for ( String VAR_3 : VAR_2 ) { this . VAR_2 . add ( VAR_3 . METHOD_1 ( ) ) ; } } }
template null - - action checks fail command check template null _CODE_ ( ) case null return null won t build engine lock acquire
private String METHOD_1 ( ) { <START> if ( METHOD_2 ( ) != null ) { <END> return new StringBuilder ( TYPE_3 . TYPE_4 . name ( ) ) . append ( String . format ( STRING_1 , METHOD_2 ( ) . getName ( ) ) ) . toString ( ) ; } return TYPE_3 . TYPE_5 . name ( ) ; }
private String METHOD_1 ( ) { return new StringBuilder ( TYPE_3 . TYPE_4 . name ( ) ) . append ( String . format ( STRING_1 , METHOD_2 ( ) . getName ( ) ) ) . toString ( ) ; }
removed static
<START> private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 TYPE_3 ) { <END> boolean result = false ; TYPE_1 VAR_3 = new TYPE_1 ( TYPE_3 . VAR_4 ) ; if ( VAR_1 . METHOD_2 ( VAR_3 ) > 0 ) { result = true ; } return result ; }
private static boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 TYPE_3 ) { boolean result = false ; TYPE_1 VAR_3 = new TYPE_1 ( TYPE_3 . VAR_4 ) ; if ( VAR_1 . METHOD_2 ( VAR_3 ) > 0 ) { result = true ; } return result ; }
I ( want ) toString ( ) implicit formatting removed
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 vds = METHOD_2 ( getParameters ( ) . METHOD_3 ( ) ) ; TYPE_1 VAR_2 = vds . VAR_3 ( ) ; log . VAR_4 ( STRING_1 , VAR_2 . toString ( ) , <START> VAR_1 . toString ( ) <END> ) ; return ( VAR_2 . METHOD_4 ( ) == VAR_1 . METHOD_4 ( ) && VAR_2 . METHOD_5 ( ) <= VAR_1 . METHOD_5 ( ) ) ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 vds = METHOD_2 ( getParameters ( ) . METHOD_3 ( ) ) ; TYPE_1 VAR_2 = vds . VAR_3 ( ) ; log . VAR_4 ( STRING_1 , VAR_2 , VAR_1 ) ; return ( VAR_2 . METHOD_4 ( ) == VAR_1 . METHOD_4 ( ) && VAR_2 . METHOD_5 ( ) <= VAR_1 . METHOD_5 ( ) ) ; }
please add sync protection _CODE_
public static synchronized TYPE_1 getInstance ( ) { if ( instance == null ) { <START> instance = new TYPE_1 ( ) ; <END> } return instance ; }
public static synchronized TYPE_1 getInstance ( ) { if ( instance == null ) { instance = new TYPE_1 ( ) ; } else { if ( instance == null ) { synchronized ( TYPE_1 . class ) { if ( instance == null ) { instance = new TYPE_1 ( ) ; } } } } return instance ; }
removed static
<START> private TYPE_1 METHOD_1 ( TYPE_2 info ) { <END> log . VAR_1 ( STRING_1 , info . VAR_2 ) ; String VAR_3 = info . VAR_2 ; if ( VAR_4 == null || ! VAR_3 . equals ( VAR_4 . toString ( ) ) ) { VAR_4 = TYPE_1 . METHOD_2 ( VAR_3 ) ; } return VAR_4 ; }
private static TYPE_1 METHOD_1 ( TYPE_2 info ) { String VAR_3 = info . VAR_2 ; if ( VAR_4 == null || ! VAR_3 . equals ( VAR_4 . toString ( ) ) ) { VAR_4 = TYPE_1 . METHOD_2 ( VAR_3 ) ; } return VAR_4 ; }
fix initialization singleton device custom properties
public static TYPE_1 getInstance ( ) { <START> if ( VAR_1 == null ) { <END> synchronized ( TYPE_1 . class ) { if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( ) ; } } } return VAR_1 ; }
public static TYPE_1 getInstance ( ) { return VAR_1 ; }
user provides _CODE_ VAR_3 ? swap comparisons
protected void METHOD_1 ( ) { if ( ! ( Guid . VAR_1 ( VAR_2 ) ) ) { METHOD_2 ( ) ; } else if ( ! ( Guid . VAR_1 ( VAR_3 ) ) ) { METHOD_3 ( ) ; <START> } <END> }
protected void METHOD_1 ( ) { if ( ! ( Guid . VAR_1 ( VAR_3 ) ) ) { METHOD_3 ( ) ; } else if ( ! ( Guid . VAR_1 ( VAR_2 ) ) ) { METHOD_2 ( ) ; } }
move separate tests verify error message returned VAR_2
public void METHOD_1 ( ) { TYPE_1 params = new TYPE_1 ( ) ; params . VAR_1 ( STRING_1 ) ; cmd = METHOD_2 ( new TYPE_2 ( params ) ) ; METHOD_3 ( cmd . VAR_2 ( ) ) ; params . VAR_3 ( TYPE_3 . VAR_5 ) ; cmd = METHOD_2 ( new TYPE_2 ( params ) ) ; METHOD_3 ( cmd . VAR_2 ( ) ) ; <START> <END> params . VAR_6 ( null ) ; params . VAR_7 ( null ) ; METHOD_3 ( cmd . VAR_2 ( ) ) ; }
public void METHOD_1 ( ) { TYPE_1 params = new TYPE_1 ( ) ; params . VAR_1 ( STRING_1 ) ; cmd = METHOD_2 ( new TYPE_2 ( params ) ) ; METHOD_3 ( cmd . VAR_2 ( ) ) ; params . VAR_6 ( null ) ; params . VAR_7 ( null ) ; METHOD_3 ( cmd . VAR_2 ( ) ) ; }
CDA messages extend won t displayed CDA phase
private void METHOD_1 ( ) { METHOD_2 ( ) ; <START> TYPE_1 VAR_1 = METHOD_3 ( ) . METHOD_4 ( <END> TYPE_3 . TYPE_4 , METHOD_5 ( ) , TYPE_2 . METHOD_6 ( METHOD_7 ( ) ) ) ; if ( VAR_1 . METHOD_8 ( ) ) { METHOD_9 ( ) . METHOD_10 ( ) . addAll ( VAR_1 . METHOD_11 ( ) ) ; } else { METHOD_12 ( VAR_1 ) ; METHOD_13 ( ) ; METHOD_9 ( ) . METHOD_14 ( VAR_1 . METHOD_15 ( ) ) ; } METHOD_16 ( VAR_1 . METHOD_8 ( ) ) ; }
private void METHOD_1 ( ) { METHOD_2 ( ) ; TYPE_1 VAR_1 = METHOD_3 ( ) . METHOD_4 ( TYPE_3 . TYPE_4 , METHOD_5 ( ) , TYPE_2 . METHOD_6 ( METHOD_7 ( ) ) ) ; if ( VAR_1 . METHOD_8 ( ) ) { METHOD_9 ( ) . METHOD_10 ( ) . addAll ( VAR_1 . METHOD_11 ( ) ) ; } else { METHOD_12 ( VAR_1 ) ; METHOD_9 ( ) . METHOD_14 ( VAR_1 . METHOD_15 ( ) ) ; } METHOD_16 ( VAR_1 . METHOD_8 ( ) ) ; }
I prefer list VAR_4 ( new String [ list size ( ) ] ) - save instance : )
public String [ ] METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { return VAR_2 ; } List < String > list = new ArrayList < String > ( ) ; for ( String VAR_3 : TYPE_2 . TYPE_3 . METHOD_2 ( ) . values ( ) ) { if ( VAR_3 . startsWith ( VAR_1 ) ) { list . add ( VAR_3 ) ; } } <START> return list . VAR_4 ( new String [ ] { } ) ; <END> }
public String [ ] METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { return VAR_2 ; } List < String > list = new ArrayList < String > ( ) ; for ( String VAR_3 : map . values ( ) ) { if ( VAR_3 . startsWith ( VAR_1 ) ) { list . add ( VAR_3 ) ; } } return list . VAR_4 ( new String [ ] { } ) ; }
METHOD_4 ( ) code need
public void METHOD_1 ( final Guid VAR_1 , final List < TYPE_1 > VAR_2 ) { ArrayList < TYPE_2 > parameters = METHOD_2 ( VAR_1 , VAR_2 ) ; <START> if ( parameters . size ( ) == 0 ) { <END> VAR_3 . METHOD_3 ( ) ; return ; } METHOD_4 ( VAR_1 , parameters ) ; }
public void METHOD_1 ( final Guid VAR_1 , final List < TYPE_1 > VAR_2 ) { METHOD_4 ( VAR_1 , METHOD_2 ( VAR_1 , VAR_2 ) ) ; }
need addition ? isn t default
private void METHOD_1 ( ) { if ( ! METHOD_2 ( ) ) { return ; } METHOD_3 ( ) ; <START> TYPE_1 . METHOD_4 ( action , new TYPE_2 ( VAR_1 ) , null , true ) ; <END> METHOD_5 ( ) ; }
private void METHOD_1 ( ) { if ( ! METHOD_2 ( ) ) { return ; } METHOD_3 ( ) ; TYPE_1 . METHOD_4 ( action , new TYPE_2 ( VAR_1 ) ) ; METHOD_5 ( ) ; }
StringUtils isEmpty
protected boolean METHOD_1 ( ) { boolean VAR_1 = true ; <START> if ( getParameters ( ) . METHOD_2 ( ) . trim ( ) . length ( ) == 0 ) { <END> METHOD_3 ( TYPE_1 . VAR_3 ) ; VAR_1 = false ; } return VAR_1 ; }
protected boolean METHOD_1 ( ) { boolean VAR_1 = true ; if ( StringUtils . isEmpty ( getParameters ( ) . METHOD_2 ( ) ) ) { METHOD_3 ( TYPE_1 . VAR_3 ) ; VAR_1 = false ; } return VAR_1 ; }
solve NPE I suggest place null check TYPE_1 METHOD_5 method avoid similar omissions future sense METHOD_5 return VAR_2 _CODE_ unspecified
public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = ( TYPE_2 ) METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; <START> return VAR_1 == null ? TYPE_1 . VAR_2 : TYPE_1 . METHOD_5 ( VAR_1 ) ; <END> }
public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = ( TYPE_2 ) METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; return TYPE_1 . METHOD_5 ( VAR_1 ) ; }
consider : ( TYPE_3 VAR_2 = new TYPE_3 ( VAR_1 ) ) { VAR_2 write ( sb toString ( ) METHOD_2 ( ) ) ; } equivalent lines code : - )
public void METHOD_1 ( String VAR_1 , TYPE_1 sb ) throws TYPE_2 , IOException { TYPE_3 VAR_2 = null ; try { VAR_2 = new TYPE_3 ( VAR_1 ) ; VAR_2 . write ( sb . toString ( ) . METHOD_2 ( ) ) ; } finally { if ( VAR_2 != null ) { VAR_2 . close ( ) ; } <START> } <END> }
public void METHOD_1 ( String VAR_1 , TYPE_1 sb ) throws TYPE_2 , IOException { try ( TYPE_3 VAR_2 = new TYPE_3 ( VAR_1 ) ) { VAR_2 . write ( sb . toString ( ) . METHOD_2 ( ) ) ; } }
please revert order conditions static validation validation requires fetching DB : private void METHOD_1 ( TYPE_1 VAR_1 ) { ( StringUtils VAR_3 ( VAR_1 METHOD_5 ( ) ) && ! TYPE_3 METHOD_3 ( VAR_1 METHOD_4 ( ) ) && ! TYPE_2 METHOD_2 ( vds VAR_2 ( ) ) ) { }
private void METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! TYPE_2 . METHOD_2 ( vds . VAR_2 ( ) ) && ! TYPE_3 . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) <START> && StringUtils . VAR_3 ( VAR_1 . METHOD_5 ( ) ) ) { <END> METHOD_6 ( TYPE_4 . VAR_5 , VAR_1 . METHOD_4 ( ) ) ; } }
private void METHOD_1 ( TYPE_1 VAR_1 ) { if ( StringUtils . VAR_3 ( VAR_1 . METHOD_5 ( ) ) && ! TYPE_3 . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) && ! TYPE_2 . METHOD_2 ( vds . VAR_2 ( ) ) ) { METHOD_6 ( TYPE_4 . VAR_5 , VAR_1 . METHOD_4 ( ) ) ; } }
remove multiple distribution groups a single shot ? problem logic
public boolean METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_2 > VAR_2 , List < TYPE_2 > VAR_3 , TYPE_3 VAR_4 ) { int VAR_5 = VAR_4 . METHOD_2 ( ) ; int VAR_6 = VAR_4 . METHOD_3 ( ) ; if ( VAR_2 . size ( ) != VAR_5 * VAR_6 ) { return false ; <START> } <END> return true ; }
public boolean METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_2 > VAR_2 , List < TYPE_2 > VAR_3 , TYPE_3 VAR_4 ) { int VAR_5 = VAR_4 . METHOD_2 ( ) ; int VAR_6 = VAR_4 . METHOD_3 ( ) ; if ( VAR_2 . size ( ) % ( VAR_5 * VAR_6 ) != 0 ) { return false ; } return true ; }
point case sensitive check empty string StringUtils isEmpty ( connection getId ( ) )
private void METHOD_1 ( TYPE_1 connection , Guid VAR_1 ) { <START> if ( connection . VAR_2 ( ) != null && ! connection . VAR_2 ( ) . equalsIgnoreCase ( "" ) ) { <END> TYPE_2 . METHOD_2 ( TYPE_5 . TYPE_4 , new TYPE_3 ( connection , VAR_1 ) , null , this ) ; } }
private void METHOD_1 ( TYPE_1 connection , Guid VAR_1 ) { if ( connection . VAR_2 ( ) != null && ! connection . VAR_2 ( ) . equals ( "" ) ) { TYPE_2 . METHOD_2 ( TYPE_5 . TYPE_4 , new TYPE_3 ( connection , VAR_1 ) , null , this ) ; } }
i update null don t touch device setting ( leave don t create )
public TYPE_1 ( T parameters ) { super ( parameters ) ; if ( METHOD_1 ( ) != null ) { METHOD_2 ( METHOD_1 ( ) . METHOD_3 ( ) ) ; } if ( METHOD_4 ( ) ) { METHOD_5 ( parameters . VAR_2 ( ) ) ; METHOD_5 ( METHOD_6 ( ) . METHOD_7 ( ) ) ; } <START> if ( parameters . VAR_3 ( ) == null ) { <END> parameters . VAR_4 ( false ) ; } }
public TYPE_1 ( T parameters ) { super ( parameters ) ; if ( METHOD_1 ( ) != null ) { METHOD_2 ( METHOD_1 ( ) . METHOD_3 ( ) ) ; } if ( METHOD_4 ( ) ) { METHOD_5 ( parameters . VAR_2 ( ) ) ; METHOD_5 ( METHOD_6 ( ) . METHOD_7 ( ) ) ; } }
I d inline - TYPE_2 VAR_2 = METHOD_2 ( ) METHOD_3 ( STRING_1 VAR_1 ) ;
public List < TYPE_1 > METHOD_1 ( Guid VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ) ; <START> VAR_2 . METHOD_3 ( STRING_1 , VAR_1 ) ; <END> return METHOD_4 ( ) . METHOD_5 ( STRING_2 , TYPE_3 . instance , VAR_2 ) ; }
public List < TYPE_1 > METHOD_1 ( Guid VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ) . METHOD_3 ( STRING_1 , VAR_1 ) ; return METHOD_4 ( ) . METHOD_5 ( STRING_2 , TYPE_3 . instance , VAR_2 ) ; }
method static ? singleton access methods getInstance ( ) static
<START> public static String getMessage ( final String key ) { <END> return getMessage ( key , TYPE_1 . VAR_2 ) ; }
public String getMessage ( final String key ) { return getMessage ( key , TYPE_1 . VAR_2 ) ; }
behalf michael pasternak : [ 1 ] i d consider synchronizing writes getInstance ( ) & getInstance ( final File VAR_1 ) creating actual instance instance var definition
public static TYPE_1 getInstance ( final File VAR_1 ) { if ( instance == null ) { instance = new TYPE_1 ( VAR_1 ) ; <START> } <END> return instance ; }
public static synchronized TYPE_1 getInstance ( final File VAR_1 ) { if ( instance == null ) { instance = new TYPE_1 ( VAR_1 ) ; } return instance ; }
prefix full package TYPE_3 TYPE_4 redundant
public TYPE_1 METHOD_1 ( ) { TYPE_1 vds = null ; try { METHOD_2 ( vds ) ; <START> } catch ( TYPE_3 . TYPE_4 . Exception e ) { <END> log . VAR_1 ( STRING_1 , METHOD_3 ( ) , e . getMessage ( ) ) ; } return vds ; }
public TYPE_1 METHOD_1 ( ) { TYPE_1 vds = null ; try { METHOD_2 ( vds ) ; } catch ( Exception e ) { log . VAR_1 ( STRING_1 , METHOD_3 ( ) , e . getMessage ( ) ) ; } return vds ; }
line lock released s
protected void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { <START> final TYPE_2 vds = METHOD_2 ( ) ; <END> METHOD_3 ( ) . METHOD_4 ( VAR_1 ) ; log . VAR_3 ( VAR_2 + STRING_1 , vds . getName ( ) , vds . VAR_4 ( ) ) ; }
protected void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { METHOD_3 ( ) . METHOD_4 ( VAR_1 ) ; final TYPE_2 vds = METHOD_2 ( ) ; log . VAR_3 ( VAR_2 + STRING_1 , vds . getName ( ) , vds . VAR_4 ( ) ) ; }
return id ;
public static Guid METHOD_1 ( Guid id ) { <START> return id == null ? null : id ; <END> }
public static Guid METHOD_1 ( Guid id ) { return id ; }
I message VAR_8 changed _CODE_ instead server need add custom server other places - _CODE_ _CODE_
private void METHOD_1 ( TYPE_1 server ) { Map < String , String > VAR_1 = new HashMap < String , String > ( ) ; VAR_1 . put ( TYPE_5 . VAR_3 , STRING_1 ) ; <START> VAR_1 . put ( TYPE_5 . VAR_4 , server . VAR_5 ( ) ) ; <END> TYPE_2 VAR_6 = new TYPE_2 ( server . getId ( ) , TYPE_6 . VAR_8 , VAR_1 ) ; VAR_6 . METHOD_2 ( true ) ; TYPE_3 . getInstance ( ) . METHOD_3 ( TYPE_8 . TYPE_7 , VAR_6 , TYPE_4 . METHOD_4 ( ) ) ; }
private void METHOD_1 ( TYPE_1 server ) { Map < String , String > VAR_1 = new HashMap < String , String > ( ) ; VAR_1 . put ( TYPE_5 . VAR_3 , STRING_1 ) ; TYPE_2 VAR_6 = new TYPE_2 ( server . getId ( ) , TYPE_6 . VAR_8 , VAR_1 ) ; VAR_6 . METHOD_2 ( true ) ; TYPE_3 . getInstance ( ) . METHOD_3 ( TYPE_8 . TYPE_7 , VAR_6 , TYPE_4 . METHOD_4 ( ) ) ; }
y private
<START> protected static TYPE_1 METHOD_1 ( ) { <END> return TYPE_1 . getInstance ( ) ; }
private static TYPE_1 METHOD_1 ( ) { return TYPE_1 . getInstance ( ) ; }
meaning VAR_2 var local
public void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( ) ; HashMap < Integer , String > VAR_2 = new HashMap < > ( 1 ) ; <START> VAR_2 . put ( 0 , STRING_1 ) ; <END> }
public void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( ) ; }
reminder : remove TYPE_1 return null ( perform rollback previous task handler )
<START> protected TYPE_1 METHOD_1 ( ) { <END> return TYPE_1 . TYPE_2 ; }
protected TYPE_1 METHOD_1 ( ) { return null ; }
perform revert _CODE_ _CODE_ ( ) - image removed completely case ( DB ) i benefit additional logic _CODE_
<START> protected TYPE_1 METHOD_1 ( ) { <END> TYPE_2 parameters = new TYPE_2 ( ) ; parameters . VAR_1 ( METHOD_2 ( ) . getParameters ( ) . METHOD_3 ( ) ) ; parameters . VAR_2 ( METHOD_2 ( ) . getParameters ( ) . METHOD_4 ( ) ) ; parameters . VAR_3 ( METHOD_2 ( ) . getParameters ( ) . METHOD_5 ( ) ) ; return parameters ; }
protected TYPE_1 METHOD_1 ( ) { return null ; }
changed > ! =
public boolean METHOD_1 ( ArrayList < TYPE_1 > VAR_1 , TYPE_2 VAR_2 ) { boolean VAR_3 = false ; for ( TYPE_1 VAR_4 : VAR_1 ) { if ( VAR_4 . METHOD_2 ( ) == VAR_2 . METHOD_2 ( ) && <START> VAR_4 . METHOD_3 ( VAR_2 ) != 0 ) { <END> VAR_3 = true ; break ; } } return VAR_3 ; }
public boolean METHOD_1 ( ArrayList < TYPE_1 > VAR_1 , TYPE_2 VAR_2 ) { boolean VAR_3 = false ; for ( TYPE_1 VAR_4 : VAR_1 ) { if ( VAR_4 . METHOD_2 ( ) == VAR_2 . METHOD_2 ( ) && VAR_4 . METHOD_3 ( VAR_2 ) > 0 ) { VAR_3 = true ; break ; } } return VAR_3 ; }
please move METHOD_5 METHOD_2 connect ( VAR_1 ! = null )
public void METHOD_1 ( TYPE_1 vds ) { VAR_1 = vds ; METHOD_2 ( VAR_1 . METHOD_3 ( ) , VAR_1 . METHOD_4 ( ) ) ; <START> METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ; <END> }
public void METHOD_1 ( TYPE_1 vds ) { VAR_1 = vds ; if ( VAR_1 != null ) { METHOD_2 ( VAR_1 . METHOD_3 ( ) , VAR_1 . METHOD_4 ( ) ) ; METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ; } }
combination succedded force clear s discuss ; I API change
public Response METHOD_1 ( TYPE_1 action ) { return METHOD_2 ( TYPE_3 . TYPE_4 , <START> new TYPE_2 ( VAR_3 , action . VAR_4 ( ) , action . VAR_5 ( ) ) , action ) ; <END> }
public Response METHOD_1 ( TYPE_1 action ) { return METHOD_2 ( TYPE_3 . TYPE_4 , new TYPE_2 ( VAR_3 , action . VAR_4 ( ) ) , action ) ; }
btw true _CODE_ ( ) triggers _CODE_ ( )
protected TYPE_1 METHOD_1 ( TYPE_1 model , org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . TYPE_1 entity ) { <START> if ( METHOD_2 ( ) ) { <END> TYPE_2 VAR_6 = METHOD_3 ( TYPE_6 . TYPE_7 , new TYPE_3 ( Guid . VAR_9 ( model . getId ( ) ) ) ) ; if ( VAR_6 . METHOD_4 ( ) && VAR_6 . METHOD_5 ( ) != null ) { return TYPE_4 . METHOD_6 ( ( String ) VAR_6 . METHOD_5 ( ) , TYPE_5 . VAR_11 , model ) ; } } return model ; }
protected TYPE_1 METHOD_1 ( TYPE_1 model , org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . TYPE_1 entity ) { TYPE_2 VAR_6 = METHOD_3 ( TYPE_6 . TYPE_7 , new TYPE_3 ( Guid . VAR_9 ( model . getId ( ) ) ) ) ; if ( VAR_6 . METHOD_4 ( ) && VAR_6 . METHOD_5 ( ) != null ) { return TYPE_4 . METHOD_6 ( ( String ) VAR_6 . METHOD_5 ( ) , TYPE_5 . VAR_11 , model ) ; } return model ; }
STRING_1 capital ? don t need a case insensitive compare
public boolean METHOD_1 ( ) { String VAR_1 = ( String ) TYPE_1 . METHOD_2 ( TYPE_3 . TYPE_2 ) ; <START> return VAR_1 != null && ! "" . equals ( VAR_1 ) && ! STRING_1 . equals ( VAR_1 ) ; <END> }
public boolean METHOD_1 ( ) { String VAR_1 = ( String ) TYPE_1 . METHOD_2 ( TYPE_3 . TYPE_2 ) ; return VAR_1 != null && ! "" . equals ( VAR_1 ) && ! STRING_1 . equalsIgnoreCase ( VAR_1 ) ; }
line pulled METHOD_1 ( ) method _CODE_ class repeats _CODE_ commands
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_1 . VAR_2 ) ; <START> METHOD_2 ( TYPE_1 . VAR_3 ) ; <END> }
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_1 . VAR_3 ) ; }
yeah I didn t don t prefer add clause ( i check line 356 ) : METHOD_2 ( ) = = null || METHOD_2 ( ) METHOD_3 ( ) = = null ? s a matter style
protected Map < String , Pair < String , String > > METHOD_1 ( ) { if ( METHOD_2 ( ) == null ) { return null ; } <START> if ( METHOD_2 ( ) . METHOD_3 ( ) != null ) { <END> switch ( METHOD_2 ( ) . METHOD_3 ( ) ) { case VAR_1 : return METHOD_4 ( ) ; case VAR_2 : return METHOD_5 ( ) ; } } log . VAR_3 ( STRING_1 , METHOD_2 ( ) . METHOD_3 ( ) ) ; return null ; }
protected Map < String , Pair < String , String > > METHOD_1 ( ) { if ( METHOD_2 ( ) == null ) { return null ; } if ( METHOD_2 ( ) . METHOD_3 ( ) != null ) { switch ( METHOD_2 ( ) . METHOD_3 ( ) ) { case VAR_1 : return METHOD_4 ( ) ; case VAR_2 : return METHOD_5 ( ) ; } } return null ; }
please add brackets ifs
public boolean equals ( Object obj ) { if ( this == obj ) return true ; if ( obj == null ) return false ; if ( getClass ( ) != obj . getClass ( ) ) <START> return false ; <END> TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return TYPE_2 . METHOD_1 ( VAR_2 , VAR_1 . VAR_2 ) && TYPE_2 . METHOD_1 ( VAR_3 , VAR_1 . VAR_3 ) && TYPE_2 . METHOD_1 ( VAR_4 , VAR_1 . VAR_4 ) ; }
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( obj == null ) { return false ; } if ( getClass ( ) != obj . getClass ( ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return TYPE_2 . METHOD_1 ( VAR_2 , VAR_1 . VAR_2 ) && TYPE_2 . METHOD_1 ( VAR_3 , VAR_1 . VAR_3 ) && TYPE_2 . METHOD_1 ( VAR_4 , VAR_1 . VAR_4 ) ; }
need check ? _CODE_ takes TYPE_1
public TYPE_1 METHOD_1 ( ) { <START> return ( TYPE_1 ) ( ( super . METHOD_1 ( ) instanceof TYPE_1 ) ? super . METHOD_1 ( ) : null ) ; <END> }
public TYPE_1 METHOD_1 ( ) { return ( TYPE_1 ) super . METHOD_1 ( ) ; }
i d create a dedicated mapper TYPE_5 ( [ 1 ] ) [ 1 ] TYPE_4 _CODE_ map ( VM vm _CODE_ template )
public TYPE_1 getParameters ( TYPE_2 VAR_1 , TYPE_3 entity ) { TYPE_3 VAR_2 = METHOD_1 ( VAR_3 , TYPE_3 . class ) . map ( VAR_1 , entity ) ; VAR_2 . METHOD_2 ( TYPE_4 . METHOD_3 ( VAR_1 . METHOD_4 ( ) , entity . VAR_4 ( ) , METHOD_5 ( VAR_2 . METHOD_6 ( ) ) ) ) ; TYPE_5 params = new TYPE_5 ( VAR_2 ) ; if ( VAR_1 . METHOD_7 ( ) ) { params . VAR_5 ( VAR_1 . METHOD_8 ( ) ) ; <START> } <END> return params ; }
public TYPE_1 getParameters ( TYPE_2 VAR_1 , TYPE_3 entity ) { TYPE_3 VAR_2 = METHOD_1 ( VAR_3 , TYPE_3 . class ) . map ( VAR_1 , entity ) ; VAR_2 . METHOD_2 ( TYPE_4 . METHOD_3 ( VAR_1 . METHOD_4 ( ) , entity . VAR_4 ( ) , METHOD_5 ( VAR_2 . METHOD_6 ( ) ) ) ) ; return METHOD_1 ( VAR_3 , TYPE_5 . class ) . map ( VAR_1 , new TYPE_5 ( VAR_2 ) ) ; }
want remove null validation constructor added
public boolean METHOD_1 ( ) { <START> boolean result = false ; <END> switch ( vds . getStatus ( ) ) { case TYPE_1 : case TYPE_2 : case TYPE_4 : case TYPE_3 : case TYPE_5 : result = true ; break ; default : break ; } return result ; }
public boolean METHOD_1 ( ) { boolean result = false ; if ( vds == null ) { return false ; } switch ( vds . getStatus ( ) ) { case TYPE_1 : case TYPE_2 : case TYPE_4 : case TYPE_3 : case TYPE_5 : result = true ; break ; default : break ; } return result ; }
practice followingif ( TYPE_2 TYPE_5 equals ( vds getStatus ( ) ) ) check
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = exists ( ) ; if ( ! VAR_1 . METHOD_2 ( ) ) { return VAR_1 ; } if ( vds . getStatus ( ) . equals ( TYPE_2 . TYPE_4 ) ) { return new TYPE_1 ( TYPE_3 . VAR_5 ) ; } <START> if ( vds . getStatus ( ) . equals ( TYPE_2 . TYPE_5 ) ) { <END> return new TYPE_1 ( TYPE_3 . VAR_7 ) ; } return TYPE_1 . VAR_8 ; }
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = exists ( ) ; if ( ! VAR_1 . METHOD_2 ( ) ) { return VAR_1 ; } if ( TYPE_2 . TYPE_4 == vds . getStatus ( ) ) { return new TYPE_1 ( TYPE_3 . VAR_5 ) ; } if ( TYPE_2 . TYPE_5 == vds . getStatus ( ) ) { return new TYPE_1 ( TYPE_3 . VAR_7 ) ; } return TYPE_1 . VAR_8 ; }
reason local var
private void METHOD_1 ( TYPE_1 action ) { <START> String VAR_1 = action . VAR_2 ( ) ; <END> METHOD_1 ( action , STRING_1 ) ; METHOD_2 ( TYPE_2 . class , VAR_1 ) ; }
private void METHOD_1 ( TYPE_1 action ) { METHOD_1 ( action , STRING_1 ) ; METHOD_2 ( TYPE_2 . class , action . VAR_2 ( ) ) ; }
I d avoid continue : ( vm ! = null ) { VAR_1 add ( vm ) ; }
private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; if ( METHOD_2 ( ) == null ) { return VAR_1 ; } for ( Object VAR_2 : METHOD_2 ( ) ) { TYPE_2 VAR_3 = ( TYPE_2 ) VAR_2 ; TYPE_1 vm = VAR_3 . METHOD_3 ( ) ; if ( vm == null ) { <START> continue ; <END> } VAR_1 . add ( vm ) ; } return VAR_1 ; }
private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; if ( METHOD_2 ( ) == null ) { return VAR_1 ; } for ( Object VAR_2 : METHOD_2 ( ) ) { TYPE_2 VAR_3 = ( TYPE_2 ) VAR_2 ; TYPE_1 vm = VAR_3 . METHOD_3 ( ) ; if ( vm != null ) { VAR_1 . add ( vm ) ; } } return VAR_1 ; }
part METHOD_5 ( )
public void METHOD_1 ( ) { if ( METHOD_2 ( ) != null ) { return ; } final TYPE_1 VAR_1 = new TYPE_2 ( this ) ; METHOD_3 ( VAR_1 ) ; <START> VAR_1 . METHOD_4 ( null ) ; <END> METHOD_5 ( VAR_1 ) ; }
public void METHOD_1 ( ) { if ( METHOD_2 ( ) != null ) { return ; } final TYPE_1 VAR_1 = new TYPE_2 ( this ) ; METHOD_3 ( VAR_1 ) ; METHOD_5 ( VAR_1 ) ; }
I finally block case exception thrown previous methods
public void METHOD_1 ( final List < TYPE_1 > VAR_1 ) { TYPE_2 . execute ( new TYPE_3 ( ) { ANNOTATION_1 ( STRING_1 ) @Override public void run ( ) { TYPE_4 . METHOD_2 ( new TYPE_5 < Object > ( ) { @Override public Object METHOD_3 ( ) { boolean VAR_2 = METHOD_4 ( VAR_1 ) ; for ( TYPE_1 task : VAR_1 ) { METHOD_5 ( VAR_2 , task ) ; } <START> VAR_3 . METHOD_6 ( ) ; <END> return null ; } } ) ; } } ) ; }
public void METHOD_1 ( final List < TYPE_1 > VAR_1 ) { TYPE_2 . execute ( new TYPE_3 ( ) { ANNOTATION_1 ( STRING_1 ) @Override public void run ( ) { TYPE_4 . METHOD_2 ( new TYPE_5 < Object > ( ) { @Override public Object METHOD_3 ( ) { try { boolean VAR_2 = METHOD_4 ( VAR_1 ) ; for ( TYPE_1 task : VAR_1 ) { METHOD_5 ( VAR_2 , task ) ; } return null ; } finally { VAR_3 . METHOD_6 ( ) ; } } } ) ; } } ) ; }
NPE
private String METHOD_1 ( ) { StringBuilder builder = new StringBuilder ( TYPE_2 . TYPE_3 . name ( ) ) ; <START> builder . append ( String . format ( STRING_1 , METHOD_2 ( ) ) ) ; <END> return builder . toString ( ) ; }
private String METHOD_1 ( ) { StringBuilder builder = new StringBuilder ( TYPE_2 . TYPE_3 . name ( ) ) ; if ( METHOD_2 ( ) != null ) { builder . append ( String . format ( STRING_1 , METHOD_2 ( ) ) ) ; } return builder . toString ( ) ; }
new Guid ( String ) - literal t null
public void METHOD_1 ( ) { <START> Guid result = VAR_1 . METHOD_2 ( Guid . VAR_2 ( STRING_1 ) ) ; <END> assertNotNull ( result ) ; assertEquals ( VAR_3 , result ) ; }
public void METHOD_1 ( ) { Guid result = VAR_1 . METHOD_2 ( new Guid ( STRING_1 ) ) ; assertNotNull ( result ) ; assertEquals ( VAR_3 , result ) ; }
new Guid ( String ) - literal t null
public void METHOD_1 ( ) { <START> TYPE_1 result = VAR_1 . METHOD_2 ( Guid . VAR_2 ( STRING_1 ) , TYPE_2 . TYPE_3 ) ; <END> assertNotNull ( result ) ; METHOD_3 ( result ) ; }
public void METHOD_1 ( ) { TYPE_1 result = VAR_1 . METHOD_2 ( new Guid ( STRING_1 ) , TYPE_2 . TYPE_3 ) ; assertNotNull ( result ) ; METHOD_3 ( result ) ; }
new Guid ( String ) - literal t null
public void METHOD_1 ( ) { <START> TYPE_1 result = VAR_1 . METHOD_2 ( VAR_2 . getId ( ) , Guid . VAR_3 ( STRING_1 ) ) ; <END> METHOD_3 ( result ) ; }
public void METHOD_1 ( ) { TYPE_1 result = VAR_1 . METHOD_2 ( VAR_2 . getId ( ) , new Guid ( STRING_1 ) ) ; METHOD_3 ( result ) ; }
new Guid ( String ) - literal t null
public void METHOD_1 ( ) { <START> Guid VAR_1 = Guid . VAR_2 ( STRING_1 ) ; <END> List < TYPE_1 > result = VAR_3 . METHOD_2 ( VAR_1 , VAR_4 , true ) ; METHOD_3 ( result , VAR_1 ) ; }
public void METHOD_1 ( ) { Guid VAR_1 = new Guid ( STRING_1 ) ; List < TYPE_1 > result = VAR_3 . METHOD_2 ( VAR_1 , VAR_4 , true ) ; METHOD_3 ( result , VAR_1 ) ; }
new Guid ( String ) - literal t null
public void METHOD_1 ( ) { List < TYPE_1 > result = VAR_1 . METHOD_2 ( VAR_2 , TYPE_2 . VAR_4 , <START> Guid . VAR_5 ( STRING_1 ) ) ; <END> assertNotNull ( result ) ; METHOD_3 ( result . isEmpty ( ) ) ; assertEquals ( result . get ( 0 ) . getId ( ) , VAR_6 . getId ( ) ) ; }
public void METHOD_1 ( ) { List < TYPE_1 > result = VAR_1 . METHOD_2 ( VAR_2 , TYPE_2 . VAR_4 , new Guid ( STRING_1 ) ) ; assertNotNull ( result ) ; METHOD_3 ( result . isEmpty ( ) ) ; assertEquals ( result . get ( 0 ) . getId ( ) , VAR_6 . getId ( ) ) ; }
new Guid ( String ) - literal t null
public void METHOD_1 ( ) { List < TYPE_1 > result = VAR_1 . METHOD_2 ( VAR_2 , TYPE_2 . VAR_4 , <START> Guid . VAR_5 ( STRING_1 ) ) ; <END> assertNotNull ( result ) ; assertTrue ( result . isEmpty ( ) ) ; }
public void METHOD_1 ( ) { List < TYPE_1 > result = VAR_1 . METHOD_2 ( VAR_2 , TYPE_2 . VAR_4 , new Guid ( STRING_1 ) ) ; assertNotNull ( result ) ; assertTrue ( result . isEmpty ( ) ) ; }
important i nicer VAR_2 getName ( )
public void METHOD_1 ( List < TYPE_1 > VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 ) { TYPE_2 params = new TYPE_2 ( VAR_2 , null , null ) ; TYPE_3 VAR_3 = TYPE_4 . getInstance ( ) . METHOD_2 ( TYPE_7 . TYPE_6 , params , TYPE_5 . METHOD_3 ( ) ) ; if ( ! VAR_3 . METHOD_4 ( ) ) { <START> log . VAR_6 ( STRING_1 , params . VAR_7 ( ) . getName ( ) ) ; <END> } } }
public void METHOD_1 ( List < TYPE_1 > VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 ) { TYPE_2 params = new TYPE_2 ( VAR_2 , null , null ) ; TYPE_3 VAR_3 = TYPE_4 . getInstance ( ) . METHOD_2 ( TYPE_7 . TYPE_6 , params , TYPE_5 . METHOD_3 ( ) ) ; if ( ! VAR_3 . METHOD_4 ( ) ) { log . VAR_6 ( STRING_1 , VAR_2 . getName ( ) ) ; } } }
{ line scope lets itconsider a report null passed
public void METHOD_1 ( Collection < T > VAR_1 ) { <START> if ( VAR_1 != null && VAR_1 . size ( ) > 0 ) <END> METHOD_1 ( METHOD_2 ( ) , VAR_1 , METHOD_3 ( ) ) ; }
public void METHOD_1 ( Collection < T > VAR_1 ) { if ( VAR_1 != null && VAR_1 . size ( ) > 0 ) { METHOD_1 ( METHOD_2 ( ) , VAR_1 , METHOD_3 ( ) ) ; } }
reason synced ? _CODE_ variable volatile visibility problem solved
<START> public synchronized TYPE_1 METHOD_1 ( ) { <END> if ( VAR_1 == null ) { VAR_1 = TYPE_2 . getInstance ( ) . METHOD_2 ( ) . get ( VAR_2 . getId ( ) ) ; } return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { synchronized ( this ) { if ( VAR_1 == null ) { VAR_1 = TYPE_2 . getInstance ( ) . METHOD_2 ( ) . get ( VAR_2 . getId ( ) ) ; } } } return VAR_1 ; }
please _CODE_ class versioning checking s standard constrain feature a specific version
protected boolean METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( METHOD_2 ( ) ) ; return METHOD_3 ( VAR_1 . exists ( ) ) && METHOD_3 ( VAR_1 . METHOD_4 ( ) ) <START> && METHOD_3 ( VAR_1 . METHOD_5 ( TYPE_2 . VAR_3 ) ) ; <END> }
protected boolean METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( METHOD_2 ( ) ) ; return METHOD_3 ( VAR_1 . exists ( ) ) && METHOD_3 ( VAR_1 . METHOD_4 ( ) ) && METHOD_3 ( METHOD_5 ( ) ) ; }
a part METHOD_1 ( ) logic
protected void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_1 ( VAR_1 , STRING_1 ) ; <START> if ( ! VAR_1 . METHOD_2 ( ) || ! VAR_1 . METHOD_3 ( ) . METHOD_4 ( ) ) { <END> VAR_1 . METHOD_5 ( new TYPE_2 ( ) ) ; VAR_1 . METHOD_3 ( ) . METHOD_6 ( VAR_2 ) ; } }
protected void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_1 ( VAR_1 , STRING_1 ) ; }
split allow AD users context
protected String METHOD_1 ( ) { String VAR_1 = TYPE_1 . METHOD_2 ( METHOD_3 ( ) , "" , VAR_2 ) ; return VAR_1 . equals ( STRING_1 ) ? VAR_1 + VAR_3 : <START> VAR_1 + VAR_4 + VAR_3 ; <END> }
private String METHOD_1 ( ) { String VAR_1 = TYPE_1 . METHOD_2 ( METHOD_3 ( ) , "" , VAR_2 ) ; return VAR_1 . equals ( STRING_1 ) ? VAR_1 + VAR_3 : VAR_1 + VAR_4 + VAR_3 ; }
called VAR_6 ( ) wouldn t want remove list _CODE_
public void METHOD_1 ( ) { synchronized ( VAR_1 ) { TYPE_3 . TYPE_4 . ArrayList < TYPE_2 > TYPE_5 = METHOD_2 ( ) ; for ( TYPE_2 task : TYPE_5 ) { if ( task . VAR_3 ( ) . getStatus ( ) == TYPE_6 . VAR_5 ) { task . VAR_6 ( ) ; <START> if ( task . VAR_7 ( ) != null ) { <END> VAR_1 . remove ( task . VAR_7 ( ) ) ; } } } } }
public void METHOD_1 ( ) { synchronized ( VAR_1 ) { TYPE_3 . TYPE_4 . ArrayList < TYPE_2 > TYPE_5 = METHOD_2 ( ) ; for ( TYPE_2 task : TYPE_5 ) { if ( task . VAR_3 ( ) . getStatus ( ) == TYPE_6 . VAR_5 ) { task . VAR_6 ( ) ; VAR_1 . remove ( task . VAR_7 ( ) ) ; } } } }
inlined METHOD_3 ( new ArrayList )
private void METHOD_1 ( ) { <START> ArrayList < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; <END> METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ; METHOD_2 ( ) . METHOD_4 ( ) . METHOD_5 ( this ) ; }
private void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_4 ( ) . METHOD_5 ( this ) ; }
equals instead = = method logic please remove duplication
private static boolean METHOD_1 ( TYPE_1 task ) { if ( TYPE_5 . TYPE_7 . equals ( task . getStatus ( ) ) || TYPE_5 . TYPE_6 . equals ( task . getStatus ( ) ) <START> || TYPE_5 . TYPE_8 . equals ( task . getStatus ( ) ) ) { <END> return true ; } return false ; }
private static boolean METHOD_1 ( TYPE_1 task ) { if ( TYPE_5 . TYPE_7 == task . getStatus ( ) || TYPE_5 . TYPE_6 == task . getStatus ( ) || TYPE_5 . TYPE_8 == task . getStatus ( ) ) { return true ; } return false ; }
mind reverting condition a positive form ? return TYPE_4 METHOD_3 ( vm VAR_3 ( ) ) ? TYPE_1 VAR_6 : new TYPE_1 ( TYPE_5 VAR_5 ) ;
protected TYPE_1 METHOD_1 ( TYPE_2 vm ) { for ( TYPE_3 VAR_1 : vm . VAR_2 ( ) ) { if ( VAR_1 . METHOD_2 ( ) == null ) { <START> return ! TYPE_4 . METHOD_3 ( vm . VAR_3 ( ) ) ? <END> new TYPE_1 ( TYPE_5 . VAR_5 ) : TYPE_1 . VAR_6 ; } } return TYPE_1 . VAR_6 ; }
protected TYPE_1 METHOD_1 ( TYPE_2 vm ) { for ( TYPE_3 VAR_1 : vm . VAR_2 ( ) ) { if ( VAR_1 . METHOD_2 ( ) == null ) { return TYPE_4 . METHOD_3 ( vm . VAR_3 ( ) ) ? TYPE_1 . VAR_6 : new TYPE_1 ( TYPE_5 . VAR_5 ) ; } } return TYPE_1 . VAR_6 ; }
checks squashed check - VAR_1 METHOD_2 ( ) ! = TYPE_2 TYPE_3 I prefer ! TYPE_2 TYPE_3 equals ( VAR_1 METHOD_2 ( ) ) check removed s s changed check method call replaced check : )
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return VAR_1 != null && VAR_1 . METHOD_2 ( ) != null && <END> VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) == TYPE_2 . TYPE_3 ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 . METHOD_2 ( ) != null && VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) == TYPE_2 . TYPE_3 ; }
more a debug please remove log debug
private static void METHOD_1 ( TYPE_1 VAR_1 ) { Map < String , Object > values = VAR_2 . get ( VAR_1 . METHOD_2 ( ) ) ; if ( values == null ) { values = new HashMap < String , Object > ( ) ; VAR_2 . put ( VAR_1 . METHOD_2 ( ) , values ) ; } <START> log . info ( STRING_1 + VAR_1 . METHOD_2 ( ) + STRING_2 + VAR_1 . METHOD_3 ( ) ) ; <END> values . put ( VAR_1 . METHOD_3 ( ) , METHOD_4 ( VAR_1 ) ) ; }
private static void METHOD_1 ( TYPE_1 VAR_1 ) { Map < String , Object > values = VAR_2 . get ( VAR_1 . METHOD_2 ( ) ) ; if ( values == null ) { values = new HashMap < String , Object > ( ) ; VAR_2 . put ( VAR_1 . METHOD_2 ( ) , values ) ; } values . put ( VAR_1 . METHOD_3 ( ) , METHOD_4 ( VAR_1 ) ) ; }
redundant call ( VAR_2 VAR_3 VAR_4 VAR_5 ) handles
public TYPE_3 ( Guid VAR_2 , String VAR_3 , TYPE_1 VAR_4 , String [ ] VAR_5 , int VAR_6 ) { this ( VAR_2 , VAR_3 , VAR_4 , VAR_5 ) ; METHOD_1 ( VAR_6 ) ; <START> VAR_7 = TYPE_2 . NONE ; <END> }
public TYPE_3 ( Guid VAR_2 , String VAR_3 , TYPE_1 VAR_4 , String [ ] VAR_5 , int VAR_6 ) { this ( VAR_2 , VAR_3 , VAR_4 , VAR_5 ) ; METHOD_1 ( VAR_6 ) ; }
super
protected boolean METHOD_1 ( ) { if ( ! super . METHOD_1 ( ) ) { return false ; } <START> if ( getParameters ( ) . METHOD_2 ( ) == null ) { <END> return METHOD_3 ( TYPE_1 . VAR_2 ) ; } if ( ! METHOD_4 ( ) . isEmpty ( ) ) { return METHOD_3 ( TYPE_1 . VAR_3 ) ; } return true ; }
protected boolean METHOD_1 ( ) { if ( ! super . METHOD_1 ( ) ) { return false ; } if ( ! METHOD_4 ( ) . isEmpty ( ) ) { return METHOD_3 ( TYPE_1 . VAR_3 ) ; } return true ; }
s defined upper case - need run METHOD_1
public String value ( ) { <START> return VAR_1 . METHOD_1 ( ) ; <END> }
public String value ( ) { return VAR_1 ; }
resource interface ( branding properties ) relay file
<START> public String METHOD_1 ( String VAR_1 ) { <END> List < TYPE_1 > VAR_2 = METHOD_2 ( ) ; for ( int i = VAR_2 . size ( ) - 1 ; i >= 0 ; i -- ) { String VAR_3 = VAR_2 . get ( i ) . METHOD_3 ( VAR_1 ) ; if ( VAR_3 != null ) { return VAR_3 ; } } return null ; }
public String METHOD_1 ( String VAR_1 ) { if ( VAR_1 != null ) { List < TYPE_1 > VAR_2 = METHOD_2 ( ) ; for ( int i = VAR_2 . size ( ) - 1 ; i >= 0 ; i -- ) { String VAR_3 = VAR_2 . get ( i ) . METHOD_3 ( VAR_1 ) ; if ( VAR_3 != null ) { return VAR_3 ; } } } return null ; }
static please check
<START> private static int METHOD_1 ( String VAR_1 ) { <END> String VAR_2 = TYPE_2 < String > METHOD_2 ( TYPE_3 . TYPE_4 ) ; return TYPE_1 . METHOD_3 ( VAR_1 , VAR_2 ) ; }
private boolean METHOD_1 ( String VAR_1 ) { String VAR_2 = TYPE_2 < String > METHOD_2 ( TYPE_3 . TYPE_4 ) ; return TYPE_1 . METHOD_3 ( VAR_1 , VAR_2 ) >= 0 ; }
caching u
private String METHOD_1 ( ) { if ( VAR_1 == null ) { StringBuilder builder = new StringBuilder ( TYPE_2 . TYPE_3 . name ( ) ) ; if ( METHOD_2 ( ) != null ) { builder . append ( String . format ( STRING_1 , METHOD_3 ( ) ) ) ; } builder . append ( String . format ( STRING_2 , TYPE_5 . TYPE_4 == getParameters ( ) . METHOD_4 ( ) ? STRING_3 : STRING_4 ) ) ; <START> VAR_1 = builder . toString ( ) ; <END> } return VAR_1 ; }
private String METHOD_1 ( ) { if ( VAR_1 == null ) { StringBuilder builder = new StringBuilder ( TYPE_2 . TYPE_3 . name ( ) ) ; if ( METHOD_2 ( ) != null ) { builder . append ( String . format ( STRING_1 , METHOD_3 ( ) ) ) ; } VAR_1 = builder . toString ( ) ; } return VAR_1 ; }
readability / consistency consider invoking TYPE_2 - > METHOD_1 ( ) instead
void METHOD_1 ( TYPE_1 model ) { if ( model instanceof TYPE_2 ) { TYPE_3 VAR_1 = model . VAR_2 ( ) ; if ( VAR_1 != null && ! VAR_1 . METHOD_2 ( ) ) { TYPE_2 VAR_3 = ( TYPE_2 ) model ; <START> VAR_3 . METHOD_3 ( ) . execute ( ) ; <END> } } }
void METHOD_1 ( TYPE_1 model ) { if ( model instanceof TYPE_2 ) { TYPE_3 VAR_1 = model . VAR_2 ( ) ; if ( VAR_1 != null && ! VAR_1 . METHOD_2 ( ) ) { TYPE_2 VAR_3 = ( TYPE_2 ) model ; VAR_3 . METHOD_1 ( ) ; } } }
add a null check please
protected boolean METHOD_1 ( ) { final boolean VAR_1 = super . METHOD_1 ( ) ; <START> if ( ! VAR_1 && METHOD_2 ( ) . METHOD_3 ( ) ) { <END> TYPE_1 . getInstance ( ) . METHOD_4 ( getParameters ( ) . METHOD_5 ( ) ) ; } return VAR_1 ; }
protected boolean METHOD_1 ( ) { final boolean VAR_1 = super . METHOD_1 ( ) ; if ( ! VAR_1 && METHOD_2 ( ) != null && METHOD_2 ( ) . METHOD_3 ( ) ) { TYPE_1 . getInstance ( ) . METHOD_4 ( getParameters ( ) . METHOD_5 ( ) ) ; } return VAR_1 ; }
call _CODE_ ( ) setting return setting retunr statement
protected void METHOD_1 ( ) { VAR_1 = METHOD_2 ( ) . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) , getParameters ( ) . METHOD_5 ( ) . METHOD_6 ( new String [ 0 ] ) , getParameters ( ) . METHOD_7 ( ) , getParameters ( ) . METHOD_8 ( ) ) ; task = VAR_1 . METHOD_9 ( ) ; METHOD_10 ( task ) ; <START> METHOD_11 ( ) ; <END> }
protected void METHOD_1 ( ) { VAR_1 = METHOD_2 ( ) . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) , getParameters ( ) . METHOD_5 ( ) . METHOD_6 ( new String [ 0 ] ) , getParameters ( ) . METHOD_7 ( ) , getParameters ( ) . METHOD_8 ( ) ) ; task = VAR_1 . METHOD_9 ( ) ; METHOD_11 ( ) ; METHOD_10 ( task ) ; }
assertEquals
public void METHOD_1 ( ) { command . getParameters ( ) . METHOD_2 ( METHOD_3 ( ) ) ; METHOD_4 ( VAR_1 ) ; METHOD_5 ( TYPE_2 . TYPE_1 , Guid . VAR_4 ( ) , VAR_1 , false ) ; command . VAR_5 ( ) ; <START> assertTrue ( command . VAR_6 ( ) . size ( ) == 1 ) ; <END> }
public void METHOD_1 ( ) { command . getParameters ( ) . METHOD_2 ( METHOD_3 ( ) ) ; METHOD_4 ( VAR_1 ) ; METHOD_5 ( TYPE_2 . TYPE_1 , Guid . VAR_4 ( ) , VAR_1 , false ) ; command . VAR_5 ( ) ; assertEquals ( command . VAR_6 ( ) . size ( ) , 1 ) ; }
ummm a singleton simply instance method
<START> public static List < String > METHOD_1 ( Guid id ) { <END> return TYPE_1 . getInstance ( ) . METHOD_2 ( List . VAR_1 , TYPE_3 . TYPE_4 , new TYPE_2 ( id ) , STRING_1 , true ) ; }
public List < String > METHOD_1 ( Guid id ) { return METHOD_2 ( List . VAR_1 , TYPE_3 . TYPE_4 , new TYPE_2 ( id ) , STRING_1 , true ) ; }
please format uniformity i e argument line s a formatter s part git repository plug IDE job
protected TYPE_8 ( TYPE_1 vm , <START> TYPE_2 VAR_2 , Guid VAR_3 , <END> TYPE_3 VAR_4 , ArrayList < TYPE_4 > VAR_5 , TYPE_4 VAR_6 , TYPE_5 VAR_7 ) { super ( vm , VAR_3 , VAR_4 , VAR_5 , VAR_7 , new TYPE_6 ( ) ) ; this . VAR_6 = VAR_6 ; this . VAR_2 = VAR_2 ; METHOD_1 ( TYPE_7 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( ) ) ; METHOD_4 ( STRING_1 ) ; }
protected TYPE_8 ( TYPE_1 vm , TYPE_2 VAR_2 , Guid VAR_3 , TYPE_3 VAR_4 , ArrayList < TYPE_4 > VAR_5 , TYPE_4 VAR_6 , TYPE_5 VAR_7 ) { super ( vm , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_7 , new TYPE_6 ( ) ) ; this . VAR_6 = VAR_6 ; METHOD_1 ( TYPE_7 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( ) ) ; METHOD_4 ( STRING_1 ) ; }
please protected
<START> public TYPE_1 METHOD_1 ( ) { <END> if ( VAR_1 == null ) { VAR_1 = METHOD_2 ( ) . get ( getParameters ( ) . METHOD_3 ( ) ) ; } return VAR_1 ; }
protected TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = METHOD_2 ( ) . get ( getParameters ( ) . METHOD_3 ( ) ) ; } return VAR_1 ; }
constructors a bad place invoke DB operations - hard test command a simple lazy getter
public TYPE_1 ( T parameters ) { super ( parameters ) ; <START> VAR_2 = METHOD_1 ( ) . get ( getParameters ( ) . METHOD_2 ( ) ) ; <END> }
public TYPE_1 ( T parameters ) { super ( parameters ) ; }