fixed issue - rerun qa when update params

app.py

@@ -6,6 +6,7 @@ D.M. Theekshana Samaradiwakara
 """
 
 import os
+import time
 import streamlit as st
 from streamlit.logger import get_logger
 
@@ -33,70 +34,60 @@ def initialize_session_state():
         "dataset": DATASETS["DEFAULT"],
         "chat_history": None,
         "is_parameters_changed":False,
-        "show_source_files": False
+        "show_source_files": False,
+        "user_question":'',
     }
 
     for k, v in SESSION_DEFAULTS.items():
         if k not in st.session_state:
             st.session_state[k] = v
 
-
-def main():
-   
-    st.set_page_config(page_title="Chat with data",
-                       page_icon=":books:")
-    st.write(css, unsafe_allow_html=True)
-
-    initialize_session_state()
-    
-
-
-    st.header("Chat with your own data:")
-    
-    user_question = st.text_input(
-        "Ask a question about your documents:",
-        placeholder="enter question",
-    )
-    # Interactive questions and answers
-    if user_question:
-        with st.spinner("Processing"):
-            handle_userinput(user_question)
-
-
+def side_bar():
     with st.sidebar:
         st.subheader("Chat parameters")
 
-        chat_model = st.selectbox(
-            "Chat model",
-            MODELS,
-            key="chat_model",
-            help="Select the LLM model for the chat",
-            on_change=update_parameters_change,
-        )
-
-        # data_source = st.selectbox(
-        #     "dataset",
-        #     DATASETS,
-        #     key="data_source",
-        #     help="Select the private data_source for the chat",
-        #     on_change=update_parameters_change,
-        # )
-
-        st.session_state.dataset =  "DEFAULT"
-
-        show_source = st.checkbox(
-            label="show source files",
-            key="show_source",
-            help="Select this to show relavant source files for the query",
-            on_change=update_parameters_change,
-        )
-
-        
-        if st.session_state.is_parameters_changed:
-            st.button("Update", on_click=parameters_change_button, args=[chat_model, show_source])
-                
-             
-
+        with st.form('param_form'):
+
+            chat_model = st.selectbox(
+                "Chat model",
+                MODELS,
+                key="chat_model",
+                help="Select the LLM model for the chat",
+                # on_change=update_parameters_change,
+            )
+
+            # data_source = st.selectbox(
+            #     "dataset",
+            #     DATASETS,
+            #     key="data_source",
+            #     help="Select the private data_source for the chat",
+            #     on_change=update_parameters_change,
+            # )
+
+            st.session_state.dataset =  "DEFAULT"
+
+            show_source = st.checkbox(
+                label="show source files",
+                key="show_source",
+                help="Select this to show relavant source files for the query",
+                # on_change=update_parameters_change,
+            )
+
+            submitted = st.form_submit_button(
+                "Submit",
+                # on_click=update_parameters_change
+                )
+       
+            if submitted:
+                parameters_change_button(chat_model, show_source)
+
+
+            # if st.session_state.is_parameters_changed:
+            #     st.button("Update", 
+            #             on_click=parameters_change_button,
+            #             args=[chat_model, show_source]
+            #     )
+                    
         st.markdown("\n")
 
         # if st.button("Create FAISS db"):
@@ -108,8 +99,6 @@ def main():
         #         st.error(f"Error : {e}")#, icon=":books:")
         #         return
                 
-           
-
         st.markdown(
             "### How to use\n"
             "1. Select the chat model\n"  # noqa: E501
@@ -118,31 +107,70 @@ def main():
         )
 
 
+def chat_body():
+    st.header("Chat with your own data:")
+    
+    user_question = st.text_input(
+        "Ask a question about your documents:",
+        placeholder="enter question",
+        key='user_question',
+        on_change=submit_user_question,
+    )
+
+    # if user_question:
+    #     submit_user_question()
+    #     # user_question = False
+
+    
+
+def submit_user_question():
+    with st.spinner("Processing"):
+        user_question = st.session_state.user_question
+        # st.success(user_question)
+        handle_userinput(user_question)
+        st.session_state.user_question=''
+
+
+def main():
+   
+    st.set_page_config(page_title="Chat with data",
+                       page_icon=":books:")
+    st.write(css, unsafe_allow_html=True)
+
+    initialize_session_state()
+    
+    side_bar()
+    chat_body()
 
                 
 def update_parameters_change():
     st.session_state.is_parameters_changed = True
 
+
 def parameters_change_button(chat_model, show_source):
     st.session_state.model = chat_model
     st.session_state.dataset = "DEFAULT"
     st.session_state.show_source_files = show_source
-    st.success("chat parameters updated")
     st.session_state.is_parameters_changed = False
 
+    alert =  st.success("chat parameters updated")
+    time.sleep(1) # Wait for 3 seconds
+    alert.empty() # Clear the alert
 
+   
 def get_answer_from_backend(query, model, dataset):
     # response = qaPipeline.run(query=query, model=model, dataset=dataset)
     response = qaPipeline.run_agent(query=query, model=model, dataset=dataset)
     return response
 
+
 def show_query_response(query, response, show_source_files):
     docs = []
     if isinstance(response, dict):
         answer, docs = response['result'], response['source_documents']
     else:
         answer = response
- 
+
     st.write(user_template.replace(
                 "{{MSG}}", query), unsafe_allow_html=True)
     st.write(bot_template.replace(
@@ -158,6 +186,7 @@ def show_query_response(query, response, show_source_files):
                 st.markdown(source.page_content)
         
         # st.write(response)
+    
 
 def is_query_valid(query: str) -> bool:
     if (not query) or (query.strip() == ''):
@@ -165,6 +194,7 @@ def is_query_valid(query: str) -> bool:
         return False
     return True
 
+
 def handle_userinput(query):
     # Get the answer from the chain
     try:
@@ -188,5 +218,6 @@ def handle_userinput(query):
         st.error(f"Error : {e}")#, icon=":books:")
         return
 
+
 if __name__ == "__main__":
     main()

qaPipeline.py

@@ -145,7 +145,7 @@ class QAPipeline:
             You can have a general conversation with the users like greetings.
             But only answer questions related to banking sector like financial and legal.
             If you dont know the answer say you dont know, dont try to makeup answers.
-            each answer should start with code word BoardPac Conversation AI:
+            each answer should start with code word BoardPac AI (Conversation):
             Question: {question}
             """
         )
@@ -160,7 +160,7 @@ class QAPipeline:
             {context}
             Given this information, please answer the question with the latest information. 
             If you dont know the answer say you dont know, dont try to makeup answers. 
-            each answer should start with code word BoardPac Retrieval AI:
+            each answer should start with code word BoardPac AI (Retrieval):
             Question: {question}
             """
         )