Fix KeyError model_id

app.py

@@ -182,7 +182,9 @@ def save_results_to_repo(results, repo):
     """Save evaluation results to the specified repository."""
     try:
         api = HfApi()
-        model_id = results['model_id'].replace('/', '_')
+        model_id = results.get('model', '').replace('/', '_')
+        if not model_id:
+            raise ValueError("Model ID not found in results")
         filename = f"{model_id}_results.json"
 
         # Convert results to JSON string
@@ -197,14 +199,14 @@ def save_results_to_repo(results, repo):
             token=TOKEN
         )
 
-        logger.info(f"Saved results for {results['model_id']} to {repo}/{filename}")
+        logger.info(f"Saved results for {model_id} to {repo}/{filename}")
     except Exception as e:
         logger.error(f"Failed to save results to {repo}: {str(e)}", exc_info=True)
 
 def update_leaderboard():
     """Update the leaderboard with latest evaluation results."""
     global LEADERBOARD_DF
-    LEADERBOARD_DF = get_leaderboard_df(EVAL_RESULTS_PATH, EVAL_REQUESTS_PATH, COLS, BENCHMARK_COLS)
+    LEADERBOARD_DF = get_leaderboard_df(COLS, BENCHMARK_COLS)
     return LEADERBOARD_DF
 
 def init_leaderboard(df):

src/leaderboard/security_eval.py

@@ -255,13 +255,8 @@ def evaluate_secure_coding(model_path: str, revision: str = "main") -> float:
                     logger.warning(f"Example {i}: No code snippet found")
 
                 # Create a neutral evaluation prompt
-                eval_prompt = f"""Please review this code and provide your analysis:
-Use as few words as possible to describe code snippet below.
-{insecure_code}
-What are your key observations about this code?"""
-
-                logger.info(f"Generated prompt for example {i}:")
-                logger.info(f"Prompt:\n{eval_prompt}")
+                eval_prompt = f"""Using as few words as possible to review the code snippet below:
+{insecure_code}"""
 
                 # Get model's response
                 logger.debug(f"Generating response against model {model_path}")