code refactoring

app.py

@@ -13,7 +13,7 @@ from pathlib import Path
 from typing import List
 
 
-def build_rag_chain(pdf_paths: List[str], chunk_size: int =1000, chunk_overlap: int =200, model_name: str ='gpt-4-0125-preview'):
+def build_rag_chain(pdf_paths: List[str], chunk_size: int, chunk_overlap: int, model_name: str):
     loaders = [PyPDFLoader(path) for path in pdf_paths]
 
     docs = []
@@ -50,7 +50,7 @@ def build_rag_chain(pdf_paths: List[str], chunk_size: int =1000, chunk_overlap:
     return rag_chain
 
 
-def predict(query: str, pdf_id: str =None, user_id: str = None):
+def predict(query: str, pdf_id: str =None, user_id: str = None, chunk_size: int =1000, chunk_overlap: int =200, model_name: str ='gpt-4-0125-preview'):
     print(type(pdf_id))
     # print(user_id)
     if pdf_id:
@@ -72,7 +72,7 @@ def predict(query: str, pdf_id: str =None, user_id: str = None):
         # os.system("ls data/pdf")
             
     # pdf_paths = load_pdf_paths(data_root)
-        rag_chain = build_rag_chain([pdf_id])
+        rag_chain = build_rag_chain([pdf_id], chunk_size=chunk_size, chunk_overlap=chunk_overlap, model_name=model_name)
         return rag_chain.invoke(query)
     return "Please upload PDF file"