feat: Pass chunk to chunk component

lib/medical_transcription/classification_server.ex

@@ -35,7 +35,7 @@ defmodule MedicalTranscription.ClassificationServer do
   end
 
   @impl GenServer
-  def handle_info({:chunk_updated, result}, state) do
+  def handle_info({:chunk_updated, _result}, state) do
     {:chunk, chunk} = state
 
     %TranscriptionChunk{id: id} = chunk
@@ -73,7 +73,6 @@ defmodule MedicalTranscription.ClassificationServer do
     |> Coding.process_chunk()
     |> Enum.each(fn %CodeVectorMatch{
                       code: code,
-                      description: description,
                       cosine_similarity: cosine_similarity,
                       weighting: [weighting]
                     } ->

lib/medical_transcription/transcription_server.ex

@@ -41,17 +41,18 @@ defmodule MedicalTranscription.TranscriptionServer do
 
     %Transcription{id: id} = transcription
 
-    Transcriptions.create_chunk(%{
-      transcription_id: id,
-      text: result.text,
-      start_mark: result.start_mark,
-      end_mark: result.end_mark
-    })
+    {:ok, chunk} =
+      Transcriptions.create_chunk(%{
+        transcription_id: id,
+        text: result.text,
+        start_mark: result.start_mark,
+        end_mark: result.end_mark
+      })
 
     Phoenix.PubSub.broadcast(
       :medicode_pubsub,
       "transcriptions:#{id}",
-      {:transcription_updated, result}
+      {:transcription_updated, chunk}
     )
 
     {:noreply, state}

lib/medical_transcription/transcriptions.ex

@@ -92,6 +92,32 @@ defmodule MedicalTranscription.Transcriptions do
     Repo.get!(query, id)
   end
 
+  @doc """
+  Gets a single transcription chunk.
+
+  Raises `Ecto.NoResultsError` if the TranscriptionChunk does not exist.
+
+  ## Examples
+
+      iex> get_transcription_chunk!(123)
+      %TranscriptionChunk{}
+
+      iex> get_transcription_chunk!(456)
+      ** (Ecto.NoResultsError)
+
+  """
+  def get_transcription_chunk!(id, preload_transcription_chunk_associations \\ false) do
+    query =
+      if preload_transcription_chunk_associations do
+        TranscriptionChunk
+        |> preload([:keywords, :code_vectors])
+      else
+        TranscriptionChunk
+      end
+
+    Repo.get!(query, id)
+  end
+
   @doc """
   Creates a transcription.
 

lib/medical_transcription_web/components/transcription_text_component.ex

@@ -18,20 +18,16 @@ defmodule MedicalTranscriptionWeb.Components.TranscriptionTextComponent do
   def update(assigns, socket) do
     self_pid = self()
 
-    text = assigns.text
+    text = assigns.chunk.text
 
     initial_assigns = %{
       id: assigns.id,
-      start_mark: assigns.start_mark,
-      end_mark: assigns.end_mark,
-      text: assigns.text
+      chunk: assigns.chunk
     }
 
     socket =
       socket
       |> assign(initial_assigns)
-      |> assign_async(:tags, fn -> classify_text(text) end)
-      |> assign_async(:keywords, fn -> find_keywords(self_pid, text) end)
 
     {:ok, socket}
   end
@@ -43,60 +39,39 @@ defmodule MedicalTranscriptionWeb.Components.TranscriptionTextComponent do
     <div id={@id} class="flex gap-12 pb-10 border-b border-[#444444]/20">
       <div class="flex-1 flex flex-col gap-4">
         <p
-          :if={!is_nil(@start_mark) && !is_nil(@end_mark)}
+          :if={!is_nil(@chunk.start_mark) && !is_nil(@chunk.end_mark)}
           class="px-2 text-[32px] leading-normal font-semibold"
         >
-          <%= @start_mark %> - <%= @end_mark %>
+          <%= @chunk.start_mark %> - <%= @chunk.end_mark %>
         </p>
 
         <div class="flex-1 w-full text-[28px] leading-normal text-type-black-tertiary">
-          <.async_result :let={keywords} assign={@keywords}>
-            <:loading>
-              <p class="h-full min-h-full rounded p-2"><%= @text %></p>
-            </:loading>
-            <p
-              id={"#{@id}-transcription-text"}
-              contenteditable
-              role="textbox"
-              class="h-full min-h-full rounded p-2"
-              phx-hook="TranscriptionEditor"
-              phx-target={@myself}
-            >
-              <.highlight text={@text} keywords={keywords} />
-            </p>
-          </.async_result>
-        </div>
-
-        <div class="flex items-center gap-2 text-sm italic">
-          <.async_result assign={@keywords}>
-            <:loading>
-              <img src={~p"/images/loading.svg"} width="16" class="animate-spin" />
-              Finding keywords...
-            </:loading>
-            <:failed :let={reason}>There was an error finding keywords: <%= reason %></:failed>
-          </.async_result>
+          <p class="h-full min-h-full rounded p-2"><%= @chunk.text %></p>
+          <p
+            id={"#{@id}-transcription-text"}
+            contenteditable
+            role="textbox"
+            class="h-full min-h-full rounded p-2"
+            phx-hook="TranscriptionEditor"
+            phx-target={@myself}
+          >
+            <.highlight text={@chunk.text} keywords={@chunk.keywords} />
+          </p>
         </div>
       </div>
 
       <div class="flex-1 flex flex-col items-stretch gap-3">
-        <.async_result :let={tags} assign={@tags}>
-          <:loading>
-            <img src={~p"/images/loading.svg"} width="16" class="animate-spin" /> Finding codes...
-          </:loading>
-          <:failed :let={reason}>There was an error finding codes: <%= reason %></:failed>
-          <%= for %CodeVectorMatch{id: id, code: code, description: label, cosine_similarity: score, weighting: weighting} <- tags do %>
-            <.tag_result
-              code_vector_id={id}
-              code={code}
-              label={label}
-              score={score}
-              text={@text}
-              weighting={weighting}
-            />
-          <% end %>
-
-          <.live_component module={CodeSelect} id={"#{@id}-code-select"} text={@text} />
-        </.async_result>
+        <.tag_result
+          :for={code_vector <- @chunk.code_vectors}
+          code_vector_id={code_vector.id}
+          code={code_vector.code}
+          label={code_vector.label}
+          score={1.0}
+          text={@chunk.text}
+          weighting={[1.0]}
+        />
+
+        <.live_component module={CodeSelect} id={"#{@id}-code-select"} text={@chunk.text} />
       </div>
     </div>
     """
@@ -157,8 +132,4 @@ defmodule MedicalTranscriptionWeb.Components.TranscriptionTextComponent do
     # 2. A fast process finding the phrase closest in vector space to the whole text.
     KeywordFinder.find_most_similar_label(text, phrases, 2)
   end
-
-  defp code_selected?(code, finalized_codes) do
-    Enum.any?(finalized_codes, code)
-  end
 end

lib/medical_transcription_web/live/transcriptions_live/show.ex

@@ -4,7 +4,6 @@ defmodule MedicalTranscriptionWeb.TranscriptionsLive.Show do
   alias MedicalTranscription.Audio.RecordingPipeline
   alias MedicalTranscription.Repo
   alias MedicalTranscription.Transcriptions
-  alias MedicalTranscription.Transcriptions.TranscriptionChunk
 
   alias MedicalTranscriptionWeb.Components.TranscriptionTextComponent
 
@@ -50,16 +49,18 @@ defmodule MedicalTranscriptionWeb.TranscriptionsLive.Show do
 
       <main class="flex-1 pl-16 pr-16 pt-[25px]">
         <div class="flex flex-col h-full mx-auto max-w-5xl">
-          <.result_heading transcription={@transcription} summary_keywords={@summary_keywords} />
+          <.result_heading
+            status={@transcription.status}
+            transcription={@transcription}
+            summary_keywords={@summary_keywords}
+          />
 
           <div id="result_list" class="flex flex flex-col gap-14" phx-update="stream">
             <.live_component
               :for={{dom_id, chunk} <- @streams.chunks}
               module={TranscriptionTextComponent}
               id={dom_id}
-              start_mark={chunk.start_mark}
-              end_mark={chunk.end_mark}
-              text={chunk.text}
+              chunk={chunk}
               finalized_codes={@finalized_codes}
             />
           </div>
@@ -111,7 +112,9 @@ defmodule MedicalTranscriptionWeb.TranscriptionsLive.Show do
   end
 
   @impl true
-  def handle_info({:transcription_updated, chunk}, socket) do
+  def handle_info({:transcription_updated, %{id: chunk_id}}, socket) do
+    chunk = get_transcription_chunk(chunk_id)
+
     # The processing sends a message as each chunk of text is coded. See here for some background and potential
     # inspiration for this: https://elixirforum.com/t/liveview-asynchronous-task-patterns/44695
     {:noreply, stream_insert(socket, :chunks, chunk)}
@@ -178,9 +181,11 @@ defmodule MedicalTranscriptionWeb.TranscriptionsLive.Show do
   end
 
   defp get_transcription(id) do
-    id
-    |> Transcriptions.get_transcription()
-    |> Repo.preload(:chunks)
+    Transcriptions.get_transcription(id, true)
+  end
+
+  defp get_transcription_chunk(id) do
+    Transcriptions.get_transcription_chunk!(id, true)
   end
 
   defp list_transcriptions(user), do: Transcriptions.list_transcriptions(user)

test/medical_transcription/coding_test.exs

@@ -1,6 +1,8 @@
 defmodule MedicalTranscription.CodingTest do
   use MedicalTranscription.DataCase
 
+  import MedicalTranscription.TranscriptionChunksFixtures
+
   alias MedicalTranscription.Coding
   alias MedicalTranscription.Coding.CodeVector
   alias MedicalTranscription.Feedback.CodeFeedback
@@ -34,6 +36,9 @@ defmodule MedicalTranscription.CodingTest do
   end
 
   describe "process_chunk/2" do
+    @input_text "This 55-year-old man with known coronary artery disease comes for a follow-up visit today."
+    @feedback_text "A 42-year-old man arrived for a return check-up who had a past history of coronary artery disease."
+
     setup do
       create_code_vector!("74685", "Coronary artery anomaly")
       create_code_vector!("41412", "Dissection of coronary artery")
@@ -41,28 +46,28 @@ defmodule MedicalTranscription.CodingTest do
       create_code_vector!("V812", "Screening for other and unspecified cardiovascular conditions")
       create_code_vector!("V4589", "Other postprocedural status")
 
-      :ok
-    end
+      input_chunk = transcription_chunk_fixture(%{text: @input_text})
+      feedback_chunk = transcription_chunk_fixture(%{text: @feedback_text})
 
-    @input_text "This 55-year-old man with known coronary artery disease comes for a follow-up visit today."
-    @feedback_text "A 42-year-old man arrived for a return check-up who had a past history of coronary artery disease."
+      {:ok, input_chunk: input_chunk, feedback_chunk: feedback_chunk}
+    end
 
-    test "Codes can be weighted multiple times when multiple prior feedback items exist for a single code" do
+    test "Codes can be weighted multiple times when multiple prior feedback items exist for a single code", %{input_chunk: chunk} do
       # One negative feedback item moves the code from 1st to 4th (x0.9).
       # The net result of 2 negative and 1 positive (x0.891) is to remove the code from the results.
       create_code_feedback!(@feedback_text, false, "74685")
       create_code_feedback!(@feedback_text, true, "74685")
       create_code_feedback!(@feedback_text, false, "74685")
-      results = Coding.process_chunk(@input_text)
+      results = Coding.process_chunk(chunk)
 
       assert Enum.map(results, & &1.code) == ["41412", "V717", "V812"]
       assert Enum.all?(results, &(&1.weighting == [:none]))
     end
 
-    test "Weighting can cause codes to appear in results that wouldn't have been included from the initial similarity query" do
+    test "Weighting can cause codes to appear in results that wouldn't have been included from the initial similarity query", %{input_chunk: chunk} do
       # E.g. weighting up a code that isn't in the initial results
       create_code_feedback!(@feedback_text, true, "V4589")
-      results = Coding.process_chunk(@input_text)
+      results = Coding.process_chunk(chunk)
 
       assert Enum.map(results, & &1.code) == ["74685", "41412", "V717", "V812", "V4589"]
 
@@ -75,32 +80,32 @@ defmodule MedicalTranscription.CodingTest do
              ]
     end
 
-    test "Codes are unweighted when no prior feedback" do
-      results = Coding.process_chunk(@input_text)
+    test "Codes are unweighted when no prior feedback", %{input_chunk: chunk} do
+      results = Coding.process_chunk(chunk)
 
       assert Enum.map(results, & &1.code) == ["74685", "41412", "V717", "V812"]
       assert Enum.all?(results, &(&1.weighting == [:none]))
     end
 
-    test "Code is ranked higher when prior positive feedback" do
+    test "Code is ranked higher when prior positive feedback", %{input_chunk: chunk} do
       create_code_feedback!(@feedback_text, true, "V717")
-      results = Coding.process_chunk(@input_text)
+      results = Coding.process_chunk(chunk)
 
       assert Enum.map(results, & &1.code) == ["V717", "74685", "41412", "V812"]
       assert Enum.map(results, & &1.weighting) == [[:positive], [:none], [:none], [:none]]
     end
 
-    test "Code is ranked lower when prior negative feedback" do
+    test "Code is ranked lower when prior negative feedback", %{input_chunk: chunk} do
       create_code_feedback!(@feedback_text, false, "74685")
-      results = Coding.process_chunk(@input_text)
+      results = Coding.process_chunk(chunk)
 
       assert Enum.map(results, & &1.code) == ["41412", "V717", "V812", "74685"]
       assert Enum.map(results, & &1.weighting) == [[:none], [:none], [:none], [:negative]]
     end
 
-    test "Code with low similarity score is removed from result when prior negative feedback" do
+    test "Code with low similarity score is removed from result when prior negative feedback", %{input_chunk: chunk} do
       create_code_feedback!(@feedback_text, false, "V717")
-      results = Coding.process_chunk(@input_text)
+      results = Coding.process_chunk(chunk)
 
       assert Enum.map(results, & &1.code) == ["74685", "41412", "V812"]
       assert Enum.map(results, & &1.weighting) == [[:none], [:none], [:none]]

test/medical_transcription_web/live/transcriptions_live_show_test.exs

@@ -25,7 +25,7 @@ defmodule MedicalTranscriptionWeb.TranscriptionsLive.ShowTest do
       conn = get(conn, "/transcriptions/#{transcription.id}")
       assert html_response(conn, 200) =~ "Medical Code Transcriber"
 
-      {:ok, view, html} = live(conn)
+      {:ok, _view, html} = live(conn)
       assert html =~ "my-audio.mp3"
       assert html =~ "Foo"
       assert html =~ "Bar"

test/support/fixtures/code_vectors_fixtures.ex

@@ -7,7 +7,7 @@ defmodule MedicalTranscription.CodeVectorsFixtures do
   @doc """
   Insert code vectors from cached csv file.
   """
-  def insert_code_vector_fixtures(attrs \\ %{}) do
+  def insert_code_vector_fixtures() do
     code_vectors =
       "../../../code_vectors.csv"
       |> Path.expand(__DIR__)