refactor: Create shared `collect_errors` function for Ecto changesets

lib/medical_transcription/coding.ex

@@ -11,23 +11,14 @@ defmodule MedicalTranscription.Coding do
   alias MedicalTranscription.Coding.CodeVector
 
   def insert_vector(params) do
-    changeset =
-      %CodeVector{}
-      |> CodeVector.changeset(params)
+    changeset = CodeVector.changeset(%CodeVector{}, params)
 
     case Repo.insert(changeset) do
       {:ok, _} ->
         {:ok, "Success!"}
 
       {:error, changeset} ->
-        messages =
-          Ecto.Changeset.traverse_errors(changeset, fn {msg, opts} ->
-            Enum.reduce(opts, msg, fn {key, value}, acc ->
-              String.replace(acc, "%{#{key}}", to_string(value))
-            end)
-          end)
-
-        {:error, messages}
+        {:error, Repo.collect_errors(changeset)}
     end
   end
 

lib/medical_transcription/feedback.ex

@@ -1,22 +1,19 @@
 defmodule MedicalTranscription.Feedback do
+  @moduledoc """
+  Context for managing user feedback on transcribed text and codes.
+  """
   alias MedicalTranscription.Feedback.CodeFeedback
+  alias MedicalTranscription.Repo
 
   def track_response(params) do
     changeset = CodeFeedback.changeset(%CodeFeedback{}, params)
 
-    case MedicalTranscription.Repo.insert(changeset) do
+    case Repo.insert(changeset) do
       {:ok, _code_feedback} ->
         {:ok, "Success!"}
 
       {:error, changeset} ->
-        messages =
-          Ecto.Changeset.traverse_errors(changeset, fn {msg, opts} ->
-            Enum.reduce(opts, msg, fn {key, value}, acc ->
-              String.replace(acc, "%{#{key}}", to_string(value))
-            end)
-          end)
-
-        {:error, messages}
+        {:error, Repo.collect_errors(changeset)}
     end
   end
 end

lib/medical_transcription/repo.ex

@@ -2,4 +2,12 @@ defmodule MedicalTranscription.Repo do
   use Ecto.Repo,
     otp_app: :medical_transcription,
     adapter: Ecto.Adapters.Postgres
+
+  def collect_errors(changeset) do
+    Ecto.Changeset.traverse_errors(changeset, fn {msg, opts} ->
+      Enum.reduce(opts, msg, fn {key, value}, acc ->
+        String.replace(acc, "%{#{key}}", to_string(value))
+      end)
+    end)
+  end
 end