chore: Include atom for each weighting result

lib/medical_transcription/coding.ex

@@ -90,12 +90,11 @@ defmodule MedicalTranscription.Coding do
       Enum.reduce(relevant_feedbacks, code_vector_match, fn feedback, acc ->
         new_attributes = weight_code_vector_similarity(acc.cosine_similarity, feedback)
 
-        Map.merge(acc, new_attributes)
+        Map.merge(acc, new_attributes, &merge_code_vector_match_attributes/3)
       end)
     end
   end
 
-  # TODO: How to combine multiple weighting symbols into the result?
   defp weight_code_vector_similarity(_similarity, nil), do: %{weighting: :none}
 
   defp weight_code_vector_similarity(similarity, %{response: true}) do
@@ -112,6 +111,12 @@ defmodule MedicalTranscription.Coding do
     }
   end
 
+  defp merge_code_vector_match_attributes(:weighting, value1, value2) do
+    value1 ++ [value2]
+  end
+
+  defp merge_code_vector_match_attributes(_key, _value1, value2), do: value2
+
   # Remove matches that don't exceed a given threshold.
   defp filter_below_threshold(code_vector_matches, similarity_threshold) do
     Enum.filter(
@@ -135,7 +140,8 @@ defmodule MedicalTranscription.Coding do
           id: v.id,
           code: v.code,
           description: v.description,
-          cosine_similarity: 1 - cosine_distance(v.description_vector, ^search_vector)
+          cosine_similarity: 1 - cosine_distance(v.description_vector, ^search_vector),
+          weighting: []
         }
     )
   end
@@ -153,7 +159,8 @@ defmodule MedicalTranscription.Coding do
           id: v.id,
           code: v.code,
           description: v.description,
-          cosine_similarity: 1 - cosine_distance(v.description_vector, ^search_vector)
+          cosine_similarity: 1 - cosine_distance(v.description_vector, ^search_vector),
+          weighting: []
         }
     )
   end

test/medical_transcription/coding_test.exs

@@ -2,7 +2,7 @@ defmodule MedicalTranscription.CodingTest do
   use MedicalTranscription.DataCase
 
   alias MedicalTranscription.Coding
-  alias MedicalTranscription.Coding.{CodeVector, CodeVectorMatch}
+  alias MedicalTranscription.Coding.CodeVector
   alias MedicalTranscription.Feedback.CodeFeedback
 
   def create_code_vector!(code, description) do
@@ -65,7 +65,7 @@ defmodule MedicalTranscription.CodingTest do
       results = Coding.process_chunk(@input_text)
 
       assert Enum.map(results, & &1.code) == ["74685", "41412", "V717", "V812", "V4589"]
-      assert Enum.map(results, & &1.weighting) == [:none, :none, :none, :none, :positive]
+      assert Enum.map(results, & &1.weighting) == [:none, :none, :none, :none, [:positive]]
     end
 
     test "Codes are unweighted when no prior feedback" do
@@ -80,7 +80,7 @@ defmodule MedicalTranscription.CodingTest do
       results = Coding.process_chunk(@input_text)
 
       assert Enum.map(results, & &1.code) == ["V717", "74685", "41412", "V812"]
-      assert Enum.map(results, & &1.weighting) == [:positive, :none, :none, :none]
+      assert Enum.map(results, & &1.weighting) == [[:positive], :none, :none, :none]
     end
 
     test "Code is ranked lower when prior negative feedback" do
@@ -88,7 +88,7 @@ defmodule MedicalTranscription.CodingTest do
       results = Coding.process_chunk(@input_text)
 
       assert Enum.map(results, & &1.code) == ["41412", "V717", "V812", "74685"]
-      assert Enum.map(results, & &1.weighting) == [:none, :none, :none, :negative]
+      assert Enum.map(results, & &1.weighting) == [:none, :none, :none, [:negative]]
     end
 
     test "Code with low similarity score is removed from result when prior negative feedback" do