fix: bugs around debug mode

.gitignore

@@ -1,7 +1,8 @@
 *_secret.py
 *_secret.py*
-**test_result.pdf
-**letter.typ
+**/test_result.pdf
+**/letter.typ
+**/cover_letter_*.typ
 
 .local/
 .ruff_cache/

app.py

@@ -6,6 +6,7 @@ from util import mylogger
 from util import stream_together
 from util import checkAPI
 from taskNonAI import extract_url, file_to_html, compile_pdf
+from taskAI import TaskAI
 
 ## load data
 from _data_test import mock_jd, mock_cv
@@ -32,7 +33,7 @@ def init():
 ## Config Functions
 
 
-def set_same_cheap_strong(set_same: bool, cheap_base, cheap_key):
+def set_same_cheap_strong(set_same: bool, cheap_base, cheap_key, cheap_model):
     # setup_zone = gr.Accordion("AI setup (OpenAI-compatible LLM API)", open=True)
     if set_same:
         return (
@@ -92,9 +93,9 @@ def run_refine(api_base, api_key, api_model, jd_info, cv_text):
         yield result
 
 
-def run_compose(api_base, api_key, api_model, min_jd, min_cv):
+def run_compose(api_base, api_key, api_model, min_jd, min_cv, is_debug):
     strongAPI = {"base": api_base, "key": api_key, "model": api_model}
-    taskAI = TaskAI(strongAPI, temperature=0.6, max_tokens=4000)
+    taskAI = TaskAI(strongAPI, is_debug=is_debug, temperature=0.6, max_tokens=4000)
     info("Composing letter with CoT ...")
     result = ""
     for response in taskAI.compose_letter_CoT(jd=min_jd, resume=min_cv):
@@ -112,7 +113,7 @@ def finalize_letter_txt(api_base, api_key, api_model, debug_CoT):
         yield result
 
 
-def finalize_letter_pdf(api_base, api_key, api_model, jd, cv, cover_letter_text):
+def finalize_letter_pdf(api_base, api_key, api_model, jd, cv, cover_letter_text, is_debug):
     cheapAPI = {"base": api_base, "key": api_key, "model": api_model}
     taskAI = TaskAI(cheapAPI, temperature=0.1, max_tokens=100)
     meta_data = next(taskAI.get_jobapp_meta(JD=jd, CV=cv))
@@ -122,12 +123,13 @@ def finalize_letter_pdf(api_base, api_key, api_model, jd, cv, cover_letter_text)
         pdf_context,
         tmpl_path="typst/template_letter.tmpl",
         output_path=f"/tmp/cover_letter_by_{pdf_context['applicantFullName']}_to_{pdf_context['companyFullName']}.pdf",
+        is_debug=is_debug,
     )
 
 
 with gr.Blocks(
     title=DEMO_TITLE,
-    theme=gr.themes.Soft(primary_hue="blue", secondary_hue="sky", neutral_hue="slate"),
+    theme=gr.themes.Soft(primary_hue="sky", secondary_hue="emerald", neutral_hue="stone"),
 ) as app:
     intro = f"""# {DEMO_TITLE}
     > You provide job description and résumé. I write Cover letter for you!  
@@ -226,7 +228,7 @@ with gr.Blocks(
         outputs=[expert_zone, reformat_zone],
     ).success(
         fn=run_compose,
-        inputs=[strong_base, strong_key, strong_model, min_jd, min_cv],
+        inputs=[strong_base, strong_key, strong_model, min_jd, min_cv, is_debug],
         outputs=[debug_CoT],
     ).success(
         fn=lambda: gr.Accordion("Expert Zone", open=False),

config.py

@@ -14,7 +14,7 @@ STRONG_MODEL = os.getenv("STRONG_MODEL") or "gpt-4"
 IS_SHARE = bool(os.getenv("IS_SHARE")) or False
 IS_DEBUG = bool(os.getenv("IS_DEBUG")) or False
 
-DEMO_TITLE = "Cover Letter Generator"
+DEMO_TITLE = "CoverPilot: AI-Powered Cover Letter Generator"
 DEMO_DESCRIPTION = "This is a demo of the OpenAI API for generating cover letters. The model is trained on a dataset of cover letters and job descriptions, and generates a cover letter based on the job description and the applicant's CV. The model is fine-tuned on the OpenAI API, and is able to generate cover letters that are tailored to the job description and the applicant's CV. The model is able to generate cover letters for a wide range of jobs, and is able to generate cover letters that are tailored to the job description and the applicant's CV. The model is able to generate cover letters for a wide range of jobs, and is able to generate cover letters that are tailored to the job description and the applicant's CV. The model is able to generate cover letters for a wide range of jobs, and is able to generate cover letters that are tailored to the job description and the applicant's CV."
 
 CV_EXT = [".typ", ".tex", ".html", ".docx", ".rst", ".rtf", ".odt", ".txt", ".md"]

taskAI.py

@@ -37,7 +37,7 @@ JSON_API = ChatPromptTemplate(
     [
         ChatMessage(
             role="system",
-            content="You are a JSON API. Your mission is to convert user input into a JSON object exactly in this template: {template}",
+            content="You are a JSON API. Your mission is to convert user input into a valid and complete JSON object STRICTLY in this template: {template}. The output should be completely a plain json without nested structure. Never summerize, paraphrase or do anything else, just extract the information from the input and fill in the template.",
         ),
         ChatMessage(role="user", content="{content}"),
     ]
@@ -65,7 +65,8 @@ Before officially write the letter, think step by step. First, list what makes a
 
 ## tasks
 class TaskAI(OpenAILike):
-    def __init__(self, api: dict[str, str], is_debug: bool, **kwargs):
+    is_debug = False
+    def __init__(self, api: dict[str, str], is_debug=False, **kwargs):
         log = logger.info
 
         def guess_window_size(model=api["model"]):
@@ -82,8 +83,8 @@ class TaskAI(OpenAILike):
             log(f"use context window size: {window_size} for {model}")
             return window_size
 
-        checkAPI(api_base, api_key)
-        self.is_debug = is_debug
+        checkAPI(api_base=api["base"], api_key=api["key"])
+        
 
         super().__init__(
             api_base=api["base"],
@@ -93,6 +94,7 @@ class TaskAI(OpenAILike):
             context_window=guess_window_size(),
             **kwargs,
         )
+        self.is_debug = is_debug
 
     def _debug_print_msg(self, msg):
         if not self.is_debug:
@@ -114,7 +116,7 @@ class TaskAI(OpenAILike):
 
     def compose_letter_CoT(self, resume: str, jd: str):
         msg = LETTER_COMPOSE.format_messages(resume=resume, jd=jd)
-        _debug_print_msg(msg)
+        self._debug_print_msg(msg)
         return self.stream_chat(msg)
 
     def get_jobapp_meta(self, JD, CV):
@@ -136,7 +138,8 @@ class TaskAI(OpenAILike):
         try:
             meta_JD = json.loads(meta_JD.strip())
             meta_CV = json.loads(meta_CV.strip())
-        except:
+        except Exception as e:
+            print(e)
             raise ValueError(
                 f"AI didn't return a valid JSON string. Try again or consider a better model for CheapAI. \n{meta_JD}\n{meta_CV}"
             )
@@ -148,7 +151,7 @@ class TaskAI(OpenAILike):
     def purify_letter(self, full_text):
         return self.stream_chat(
             EXTRACT_INFO.format_messages(
-                to_extract="the cover letter section starting from 'Dear Hiring Manager' or similar to 'Sincerely,' or similar ",
+                to_extract="the cover letter section starting from 'Dear Hiring Manager' or similar to 'Sincerely,' or similar",
                 input=full_text,
             )
         )

taskNonAI.py

@@ -52,6 +52,12 @@ def _date() -> str:
 def _typst_escape(s) -> str:
     return str(s).replace("@", "\@").replace("#", "\#")
 
+def _ensure_no_signature_in_body(cover_letter_body: str) -> str:
+    if not cover_letter_body.strip().endswith(","):
+        # remove last line
+        cover_letter_body = "\n".join(cover_letter_body.split("\n")[:-1])
+        print(cover_letter_body)
+    return cover_letter_body
 
 def compile_pdf(
     context: dict, tmpl_path: str, output_path="/tmp/cover_letter.pdf", is_debug=False
@@ -62,6 +68,8 @@ def compile_pdf(
         tmpl = Template(f.read())
     context = {k: _typst_escape(v) for k, v in context.items()}
     context.update({"date_string": _date()})
+    context["letter_body"]=_ensure_no_signature_in_body(context["letter_body"])
+
     letter_typ = tmpl.safe_substitute(context)
     with open(letter_src_filepath, "w", encoding="utf8") as f:
         f.write(letter_typ)

util.py

@@ -36,16 +36,16 @@ def is_valid_url(url: str) -> bool:
 
 def is_valid_openai_api_key(api_base: str, api_key: str) -> bool:
     headers = {"Authorization": f"Bearer {api_key}"}
-
-    response = requests.get(api_base, headers=headers)
-
+    test_url = f"{api_base}/models"
+    response = requests.get(test_url, headers=headers)
+    print(response.json())
     return response.status_code == 200
 
 
 def checkAPI(api_base: str, api_key: str):
     if not is_valid_openai_api_key(api_base, api_key):
         raise ValueError(
-            "Invalid API key or less possibly OpenAI's (or AI provider's) fault. Did you setup your AI APIs properly? If you don't have any API key, try get one from https://beta.openai.com/account/api-keys"
+            "API not available. Maybe it's OpenAI's (or AI provider's) fault, or you setup your AI APIs icorrectly. If you don't have any API key, try get one from https://beta.openai.com/account/api-keys"
         )