Instructions fixed

app.py

@@ -1,9 +1,9 @@
 import gradio as gr
 import ast
 
-
 def grade(student_code):
     feedback = []
+    passed = True
     grade = 10  # Start with full points
 
     try:
@@ -11,11 +11,10 @@ def grade(student_code):
         tree = ast.parse(student_code)
 
         # Variables to track correctness
-        pin_setup = False
-        initial_delay = False
-        loop_found = False
-        blink_pattern = False
+        pin_setup = {"21": False, "22": False}
         sleep_times = []
+        loop_found = False
+        led_alternation = False
 
         # Analyze the AST
         for node in ast.walk(tree):
@@ -25,8 +24,9 @@ def grade(student_code):
                     if node.value.func.attr == "Pin":
                         args = node.value.args
                         if len(args) >= 2 and isinstance(args[0], ast.Constant):
-                            if str(args[0].value) == "21":
-                                pin_setup = True
+                            pin_num = str(args[0].value)
+                            if pin_num in pin_setup:
+                                pin_setup[pin_num] = True
             
             # Check for time.sleep() calls
             if isinstance(node, ast.Call) and isinstance(node.func, ast.Attribute):
@@ -40,74 +40,71 @@ def grade(student_code):
             # Check LED alternation
             if isinstance(node, ast.Expr) and isinstance(node.value, ast.Call):
                 if isinstance(node.value.func, ast.Attribute):
-                    if node.value.func.attr == "value" or node.value.func.attr == "on" or node.value.func.attr == "off":
-                        blink_pattern = True
+                    if node.value.func.attr == "value":
+                        led_alternation = True
 
         # Validate pin setup
-        if not pin_setup:
-            feedback.append("⛔️ Pin 21 must be correctly set as an output (-2 pts).")
-            grade -= 2
+        if not all(pin_setup.values()):
+            feedback.append("⛔️ Both pins 21 and 22 must be correctly set as outputs (-3 pts).")
+            passed = False
+            grade -= 3
         else:
-            feedback.append("✅ Correct pin setup detected (+2 pts).")
-
-        # Validate initial delay
-        if 3 in sleep_times:
-            initial_delay = True
-            feedback.append("✅ Initial delay of 3 seconds detected (+2 pts).")
-        else:
-            feedback.append("⛔️ The LED must stay ON for 3 seconds initially (-2 pts).")
-            grade -= 2
+            feedback.append("✅ Correct pin setup detected (+3 pts).")
 
         # Validate while loop
         if not loop_found:
-            feedback.append("⛔️ No `while True:` loop found! The LED must blink continuously (-2 pts).")
+            feedback.append("⛔️ No `while True:` loop found! The LEDs must blink continuously (-2 pts).")
+            passed = False
             grade -= 2
         else:
             feedback.append("✅ Infinite loop detected (+2 pts).")
 
-        # Validate blinking pattern
-        if 1 in sleep_times:
-            feedback.append("✅ Blinking delay of 1 second detected (+2 pts).")
+        # Validate time.sleep() usage
+        if not sleep_times:
+            feedback.append("⛔️ No `time.sleep()` found! The LEDs need a delay to blink (-2 pts).")
+            passed = False
+            grade -= 2
         else:
-            feedback.append("⛔️ The LED must blink every second after the initial delay (-2 pts).")
+            feedback.append("✅ Appropriate delay function detected (+2 pts).")
+
+        # Validate sleep time range
+        if any(t < 0.3 or t > 1 for t in sleep_times):
+            feedback.append("⛔️ Delay time should be between 0.3s and 1s for a realistic emergency light effect (-2 pts).")
             grade -= 2
+        else:
+            feedback.append("✅ Delay time is within a good range (+2 pts).")
 
         # Validate LED alternation
-        if not blink_pattern:
-            feedback.append("⛔️ The LED should alternate states in the loop (-2 pts).")
-            grade -= 2
+        if not led_alternation:
+            feedback.append("⛔️ The LEDs should alternate states in the loop (-1 pt).")
+            grade -= 1
         else:
-            feedback.append("✅ LED alternation detected (+2 pts).")
+            feedback.append("✅ LED alternation detected (+1 pt).")
 
     except Exception as e:
-        feedback = f"Error parsing code: {e}"
+        feedback = [f"Erreur d'analyse du code: {e}"]
 
     # Ensure the grade is not negative
     grade = max(0, grade)
-
     grade = f"{grade}/10"
     
     feedback = "\n".join(feedback)
-
-    # Return feedback
+    
     return grade, feedback
 
 # Interface Gradio seulement si le script est exécuté directement
 if __name__ == "__main__":
-    with gr.Blocks(gr.themes.Default(primary_hue="cyan")) as demo:
+    with gr.Blocks(gr.themes.Soft(primary_hue="cyan")) as demo:
         with gr.Row():
             instructions = gr.Markdown("""
                 ## Instructions
-                * Based on this [example]() , write a MicroPython code that will light up a red LED connected to pin `21` for 3 seconds. Once the 3 seconds have elapsed, make this LED blink every second (1 second off, then 1 second on) indefinitely!
-                
-                <img src="gradio_api/file/assets/blink.gif" alt="Level crossing light" width="64" style="margin-top: 16px; margin-bottom: 16px; margin-left: 50%; margin-right: 50%" />
-                
-                * You can use the [Vittascience simulator](https://fr.vittascience.com/esp32/?mode=code&console=bottom&toolbox=scratch&simu=1&board=basic-esp32) to test your code.
-                * Copy and paste your code into the code editor on the right.
-                * Click the 'Grade' button to get a grade and feedback.
-                * If you are not satisfied with your grade, you can improve your code and click the 'Grade' button again.
-                * You can click the 'Grade' button as many times as you want.
-            """)
+                1. Based on the examples you've seen so far, write a MicroPython code that follows the instructions above.                
+                2. You can use the [Vittascience simulator](https://fr.vittascience.com/esp32/?mode=code&console=bottom&toolbox=scratch&simu=1&board=basic-esp32) to test your code.
+                2. Click the "Grade" button to get a grade and feedback.
+                3. Make sure your code is well-structured and efficient.
+                4. When you're happy with your code, please upload your solution below to get graded.
+                6. Good luck!
+            """, container=True)
             code = gr.Code(label="MicroPython code", language="python", value='import machine\n\n# Your code here', lines=24)
         with gr.Row():
             feedback_output = gr.Textbox(label="Feedback", value="Click on the 'Grade' button to get feedback", interactive=False, scale=4)
@@ -115,4 +112,4 @@ if __name__ == "__main__":
         grade_btn = gr.Button("Grade", variant="primary")
         grade_btn.click(fn=grade, inputs=code, outputs=[grade_output, feedback_output], api_name="grade")
 
-    demo.launch(show_error=False, allowed_paths=["/assets", "assets"], show_api=False)
+    demo.launch(show_error=False)