Update app.py

app.py

@@ -35,9 +35,6 @@ if 'page_loaded' not in st.session_state:
     # Reset query state when returning to home page
     st.session_state.last_query = ""
     st.session_state.last_answer = None
-# Add placeholder initialization tracking
-if 'placeholders_initialized' not in st.session_state:
-    st.session_state.placeholders_initialized = False
 
 # THEN: Import your modules
 from rag_engine import process_query, load_model, cached_load_data_files
@@ -54,7 +51,7 @@ def navigate_to_sources():
         <script>
         // Wait for the page to fully load
         document.addEventListener('DOMContentLoaded', (event) => {
-            // This select the nav item for the Sources page in the sidebar
+            // This selects the nav item for the Sources page in the sidebar
             const sourcesLink = Array.from(document.querySelectorAll('a.css-z5fcl4')).find(el => el.innerText === 'Sources');
             if (sourcesLink) {
                 sourcesLink.click();
@@ -210,40 +207,13 @@ div.stInfo {
 .source-link:hover {
     color: #6a1b9a;
 }
-/* Prevent layout shifts during loading */
-.stApp {
-    min-height: 100vh;
-}
-/* Add smooth transitions to reduce perceived jerkiness */
-* {
-    transition: opacity 0.15s ease-in-out;
-}
-/* Fix heights for containers that might change during loading */
-div.stSpinner {
-    min-height: 50px;
-    display: flex;
-    align-items: center;
-    justify-content: center;
-}
-/* Ensure question and answer containers have consistent height */
-div.stInfo, .answer-container {
-    min-height: 30px;
-}
 </style>
 <div class="main-title">Spirituality Q&A</div>
 """, unsafe_allow_html=True)
 
-# Initialize placeholders at the start
-if not st.session_state.placeholders_initialized:
-    st.session_state.question_placeholder = st.empty()
-    st.session_state.slider_placeholder = st.empty()
-    st.session_state.answer_placeholder = st.empty()
-    st.session_state.sources_placeholder = st.empty()
-    st.session_state.placeholders_initialized = True
-
 # Centered button layout without columns
-_, center_col, _ = st.columns([1, 2, 1])  # Create a wider center column
-with center_col:  # Put everything in the center column
+_, center_col, _ = st.columns([1, 2, 1])
+with center_col:
     if st.session_state.show_acknowledgment:
         st.markdown('<div class="thank-you-button">', unsafe_allow_html=True)
         if st.button("Hide Thank You Note", on_click=toggle_acknowledgment, disabled=st.session_state.is_processing, use_container_width=True):
@@ -260,9 +230,8 @@ init_message = st.empty()
 if not st.session_state.initialized:
     init_message.info("Hang in there! We are setting the system up for you. 😊")
     try:
-        # Setup authentication and preload heavy resources
         setup_all_auth()
-        load_model()  # This uses cached_load_model via alias
+        load_model()  # Uses cached_load_model via alias
         cached_load_data_files()  # Preload FAISS index, text chunks, and metadata
         st.session_state.initialized = True
         st.session_state.init_time = time.time()
@@ -295,8 +264,6 @@ if st.session_state.show_acknowledgment:
     
     This application is merely a humble vessel for the ocean of wisdom they have shared with the world. We claim no ownership of these teachings - only profound gratitude for the opportunity to help make them more accessible.
     """)
-    
-    # Link to Sources using Streamlit's built-in way
     st.markdown('<div class="more-info-link">', unsafe_allow_html=True)
     st.write("For detailed information about our sources, please visit the *Sources* page in the navigation menu.")
     st.markdown('</div>', unsafe_allow_html=True)
@@ -304,13 +271,12 @@ if st.session_state.show_acknowledgment:
 
 # Function to handle query selection from the common questions buttons
 def set_query(query):
-    # If already processing, ignore further input
     if st.session_state.is_processing:
         return
     st.session_state.last_query = query
     st.session_state.submit_clicked = True
     st.session_state.is_processing = True
-    st.rerun()
+    # No explicit rerun here; widget interaction already triggers a re-run
 
 # Function to group questions into rows based on length
 def group_buttons(questions, max_chars_per_row=100):
@@ -318,7 +284,6 @@ def group_buttons(questions, max_chars_per_row=100):
     current_row = []
     current_length = 0
     for q in questions:
-        # Add some buffer for button padding/margins
         q_length = len(q) + 5
         if current_length + q_length > max_chars_per_row and current_row:
             rows.append(current_row)
@@ -331,7 +296,6 @@ def group_buttons(questions, max_chars_per_row=100):
         rows.append(current_row)
     return rows
 
-# All common questions in a single list
 common_questions = [
     "What is the Atman or the soul?",
     "Are there rebirths?",
@@ -345,10 +309,7 @@ common_questions = [
     "How can you attain self-realization?"
 ]
 
-# Display heading for common questions
 st.markdown("### Few questions to try:")
-
-# Group questions into rows and create buttons (disabled if processing)
 question_rows = group_buttons(common_questions, max_chars_per_row=80)
 for row_idx, row in enumerate(question_rows):
     cols = st.columns(len(row))
@@ -359,74 +320,47 @@ for row_idx, row in enumerate(question_rows):
 
 # Function to handle form submission
 def handle_form_submit():
-    # If already processing, ignore further input
     if st.session_state.is_processing:
         return
     if st.session_state.query_input and st.session_state.query_input.strip():
         st.session_state.last_query = st.session_state.query_input.strip()
         st.session_state.submit_clicked = True
         st.session_state.is_processing = True
-        # Increment the form key to force a reset
         st.session_state.form_key += 1
-        st.rerun()
 
-# Create a form with a dynamic key (to allow resetting)
 with st.form(key=f"query_form_{st.session_state.form_key}"):
     query = st.text_input("Ask your question:", key="query_input", 
                           placeholder="Press enter to submit your question", disabled=st.session_state.is_processing)
     submit_button = st.form_submit_button("Get Answer", on_click=handle_form_submit, disabled=st.session_state.is_processing)
 
-# Display the current question if available using placeholders
 if st.session_state.last_query:
-    with st.session_state.question_placeholder.container():
-        st.markdown("### Current Question:")
-        st.info(st.session_state.last_query)
-else:
-    st.session_state.question_placeholder.empty()
+    st.markdown("### Current Question:")
+    st.info(st.session_state.last_query)
 
-# Sliders for customization using placeholder
-with st.session_state.slider_placeholder.container():
-    col1, col2 = st.columns(2)
-    with col1:
-        top_k = st.slider("Number of sources:", 3, 10, 5)
-    with col2:
-        word_limit = st.slider("Word limit:", 50, 500, 200)
+col1, col2 = st.columns(2)
+with col1:
+    top_k = st.slider("Number of sources:", 3, 10, 5)
+with col2:
+    word_limit = st.slider("Word limit:", 50, 500, 200)
 
-# Process the query only if it has been explicitly submitted
 if st.session_state.submit_clicked and st.session_state.last_query:
     st.session_state.submit_clicked = False
-    
-    # Use the answer placeholder for the spinner and answer display
-    with st.session_state.answer_placeholder.container():
-        with st.spinner("Processing your question..."):
-            try:
-                result = process_query(st.session_state.last_query, top_k=top_k, word_limit=word_limit)
-                st.session_state.last_answer = result
-            except Exception as e:
-                st.session_state.last_answer = {"answer_with_rag": f"Error processing query: {str(e)}", "citations": ""}
-    
-    # Reset processing flag
-    st.session_state.is_processing = False
-    st.rerun()  # Still using rerun, but the layout is more stable now
+    with st.spinner("Processing your question..."):
+        try:
+            result = process_query(st.session_state.last_query, top_k=top_k, word_limit=word_limit)
+            st.session_state.last_answer = result
+        except Exception as e:
+            st.session_state.last_answer = {"answer_with_rag": f"Error processing query: {str(e)}", "citations": ""}
+    st.session_state.is_processing = False  # Reset processing flag
 
-# Display the answer if available using placeholders
 if st.session_state.last_answer is not None:
-    with st.session_state.answer_placeholder.container():
-        st.subheader("Answer:")
-        st.write(st.session_state.last_answer["answer_with_rag"])
-    
-    with st.session_state.sources_placeholder.container():
-        st.subheader("Sources:")
-        for citation in st.session_state.last_answer["citations"].split("\n"):
-            st.write(citation)
-else:
-    st.session_state.answer_placeholder.empty()
-    st.session_state.sources_placeholder.empty()
+    st.subheader("Answer:")
+    st.write(st.session_state.last_answer["answer_with_rag"])
+    st.subheader("Sources:")
+    for citation in st.session_state.last_answer["citations"].split("\n"):
+        st.write(citation)
 
-# Add helpful information
 st.markdown("---")
-
-# About section with enhanced explanations
 st.markdown("""
 ### About this app
 This application uses a Retrieval-Augmented Generation (RAG) system to answer questions about spirituality based on insights from Indian spiritual texts. It searches through a database of texts to find relevant passages and generates answers based on those passages.
@@ -442,7 +376,6 @@ We value your feedback to enhance this application. Please visit the *Contacts*
 For more information about the source texts used, see *Sources* in the navigation menu.
 """)
 
-# Citation note at the bottom - improved with support message
 st.markdown('<div class="citation-note">', unsafe_allow_html=True)
 st.markdown("""
 The answers presented in this application are re-presented summaries of relevant passages from the listed citations.