fix rerun render issue

visualization/logger.py

@@ -11,12 +11,15 @@ class SimulationLogger:
         rr.log("world", rr.ViewCoordinates.RIGHT_HAND_Y_UP, timeless=True)
 
     def log_metadata(self, instructions: List[Dict[str, Any]]) -> None:
+        if not instructions:
+            return
+
         rr.log("metadata/instructions", rr.TextDocument(
             "\n".join([
                 f"Instruction {i+1}:\n" +
-                f"  Movement: {inst['cameraMovement']}\n" +
-                f"  Easing: {inst['movementEasing']}\n" +
-                f"  Frames: {inst['frameCount']}\n" +
+                f"  Movement: {inst.get('cameraMovement', 'N/A')}\n" +
+                f"  Easing: {inst.get('movementEasing', 'N/A')}\n" +
+                f"  Frames: {inst.get('frameCount', 'N/A')}\n" +
                 f"  Camera Angle: {inst.get('initialCameraAngle', 'N/A')}\n" +
                 f"  Shot Type: {inst.get('initialShotType', 'N/A')}\n" +
                 f"  Subject Index: {inst.get('subjectIndex', 'N/A')}"
@@ -24,65 +27,85 @@ class SimulationLogger:
             ])
         ), timeless=True)
 
-    def log_subjects(self, subjects: List[Dict[str, Any]], selected_subject: int = None) -> None:
+    def log_subjects(self, subjects: List[Dict[str, Any]], selected_subject: Optional[int] = None) -> None:
+        if not subjects:
+            return
+
         for idx, subject in enumerate(subjects):
-            vertices, faces = create_subject_mesh(subject)
-            subject_color = [0.8, 0.2, 0.2, 1.0] if idx == selected_subject else [
-                0.8, 0.8, 0.8, 1.0]
+            try:
+                vertices, faces = create_subject_mesh(subject)
+                subject_color = [0.8, 0.2, 0.2, 1.0] if idx == selected_subject else [
+                    0.8, 0.8, 0.8, 1.0]
+
+                rr.log(
+                    f"world/subject_{idx}",
+                    rr.Mesh3D(
+                        vertex_positions=vertices,
+                        vertex_indices=faces,  # Changed from indices to vertex_indices
+                        colors=np.tile(subject_color, (len(vertices), 1))
+                    ),
+                    timeless=True
+                )
+
+                rr.log(f"world/subject_{idx}/class",
+                       rr.TextDocument(subject.get('objectClass', 'Unknown')),
+                       timeless=True)
+            except Exception as e:
+                print(f"Error creating mesh for subject {idx}: {str(e)}")
 
+    def log_camera_trajectory(self, camera_frames: List[Dict[str, Any]]) -> None:
+        if not camera_frames:
+            return
+
+        try:
+            camera_positions = np.array([
+                vector3_to_numpy(frame['position']) for frame in camera_frames
+            ])
             rr.log(
-                f"world/subject_{idx}",
-                rr.Mesh3D(
-                    vertex_positions=vertices,
-                    indices=faces,
-                    colors=np.tile(subject_color, (len(vertices), 1))
+                "world/camera_trajectory",
+                rr.Points3D(
+                    camera_positions,
+                    colors=np.full((len(camera_positions), 4),
+                                   [0.0, 0.8, 0.8, 1.0])
                 ),
                 timeless=True
             )
-
-            rr.log(f"world/subject_{idx}/class",
-                   rr.TextDocument(subject['objectClass']),
-                   timeless=True)
-
-    def log_camera_trajectory(self, camera_frames: List[Dict[str, Any]]) -> None:
-        camera_positions = np.array(
-            [vector3_to_numpy(frame['position']) for frame in camera_frames])
-        rr.log(
-            "world/camera_trajectory",
-            rr.Points3D(
-                camera_positions,
-                colors=np.full((len(camera_positions), 4),
-                               [0.0, 0.8, 0.8, 1.0])
-            ),
-            timeless=True
-        )
+        except Exception as e:
+            print(f"Error logging camera trajectory: {str(e)}")
 
     def log_camera_frames(self, camera_frames: List[Dict[str, Any]]) -> None:
+        if not camera_frames:
+            return
+
         for frame_idx, camera_frame in enumerate(camera_frames):
-            rr.set_time_sequence("frame", frame_idx)
+            try:
+                rr.set_time_sequence("frame", frame_idx)
 
-            position = vector3_to_numpy(camera_frame['position'])
-            rotation_q = euler_to_quaternion(camera_frame['angle'])
+                position = vector3_to_numpy(camera_frame['position'])
+                rotation_q = euler_to_quaternion(camera_frame['angle'])
 
-            rr.log(
-                "world/camera",
-                rr.Transform3D(
-                    translation=position,
-                    rotation=rr.Quaternion(xyzw=rotation_q)
+                rr.log(
+                    "world/camera",
+                    rr.Transform3D(
+                        translation=position,
+                        rotation=rr.Quaternion(xyzw=rotation_q)
+                    )
                 )
-            )
 
-            rr.log(
-                "world/camera/view",
-                rr.Pinhole(
-                    focal_length=camera_frame['focalLength'],
-                    width=1920,
-                    height=1080
+                rr.log(
+                    "world/camera/view",
+                    rr.Pinhole(
+                        focal_length=camera_frame.get(
+                            'focalLength', 50),  # Added default
+                        width=1920,
+                        height=1080
+                    )
                 )
-            )
 
-            rr.log(
-                "metadata/current_frame",
-                rr.TextDocument(
-                    f"Frame: {frame_idx + 1}/{len(camera_frames)}"),
-            )
+                rr.log(
+                    "metadata/current_frame",
+                    rr.TextDocument(
+                        f"Frame: {frame_idx + 1}/{len(camera_frames)}"),
+                )
+            except Exception as e:
+                print(f"Error logging camera frame {frame_idx}: {str(e)}")

visualization/mesh.py

@@ -13,7 +13,7 @@ def create_subject_mesh(subject: Dict) -> Tuple[np.ndarray, np.ndarray]:
         [-0.5, -0.5, 0.5], [0.5, -0.5, 0.5], [0.5, 0.5, 0.5], [-0.5, 0.5, 0.5]
     ]) * size.reshape(1, 3) + position.reshape(1, 3)
 
-    # Create cube faces
+    # Create cube faces (updated to use vertex_indices instead of indices)
     faces = np.array([
         [0, 1, 2], [0, 2, 3],  # front
         [1, 5, 6], [1, 6, 2],  # right

visualization/visualizer.py

@@ -8,13 +8,14 @@ import rerun as rr
 
 
 @spaces.GPU
-def visualize_simulation(file, simulation_index: int) -> Optional[str]:
-    if file is None:
+def visualize_simulation(file, simulation_index: Optional[int]) -> Optional[str]:
+    if file is None or simulation_index is None:
         return None
 
     try:
         simulations, _ = load_simulation_data(file)
-        if simulations is None or simulation_index >= len(simulations):
+        if not simulations or not isinstance(simulation_index, int) or simulation_index < 0 or simulation_index >= len(simulations):
+            print(f"Invalid simulation data or index: {simulation_index}")
             return None
 
         # Create temporary file for RRD