Update functions/PitchPlotFunctions.py

functions/PitchPlotFunctions.py

@@ -365,22 +365,22 @@ class PitchPlotFunctions:
         dict_colour, dict_pitch = self.pitch_colours()
         custom_theme, colour_palette = self.sns_custom_theme()
         
-        # Draw comparison ellipses first (if comparison data provided) - dashed lines, no fill
+        # Draw comparison ellipses first (if comparison data provided) - dashed lines with fill
         if compare_df is not None and len(compare_df) > 0:
             compare_labels = compare_df['pitch_type'].unique()
             for label in compare_labels:
                 subset = compare_df.filter(pl.col('pitch_type') == label)
                 if len(subset) > 4:
                     try:
-                        # Draw comparison ellipses with dashed lines and lighter color
+                        # Draw comparison ellipses with dashed lines and filled color
                         self.confidence_ellipse(
                             subset['hb'] * 1, 
                             subset['ivb'], 
                             ax=ax, 
                             edgecolor=dict_colour.get(label, '#888888'), 
                             n_std=2, 
-                            facecolor='none',  # No fill for comparison
-                            alpha=0.8,
+                            facecolor=dict_colour.get(label, '#888888'),  # Fill with alpha 0.2
+                            alpha=0.2,
                             linestyle='--',
                             linewidth=2.5
                         )
@@ -585,7 +585,7 @@ class PitchPlotFunctions:
         )
         return df
     
-    def final_plot(self, df: pl.DataFrame, pitcher_id: str, plot_picker: str, sport_id: int, game_type: list = ['R'], compare_df: pl.DataFrame = None):
+    def final_plot(self, df: pl.DataFrame, pitcher_id: str, plot_picker: str, sport_id: int, game_type: list = ['R'], compare_df: pl.DataFrame = None, compare_year: int = None):
         """
         Creates a final plot with player headshot, bio, logo, and pitch movement plots.
 
@@ -595,6 +595,7 @@ class PitchPlotFunctions:
         plot_picker (str): The type of plot to create ('short_form_movement', 'long_form_movement', 'release_point').
         sport_id (int): The sport ID to determine the plot title.
         compare_df (pl.DataFrame): Optional DataFrame for comparison data (draws only ellipses).
+        compare_year (int): The year being compared to (for display in the note).
         """
         # Set the theme for seaborn plots
         sns.set_theme(style="whitegrid", rc=self.sns_custom_theme()[0])
@@ -648,18 +649,18 @@ class PitchPlotFunctions:
         # Create custom legend handles with circles
         legend_handles = [mlines.Line2D([], [], color=color, marker='o', linestyle='None', markersize=5, label=label) for color, label in zip(ordered_colors, items_in_order)]
 
-        # Add comparison indicator to legend if comparison data is present
-        if compare_df is not None and len(compare_df) > 0:
-            # Add a dashed line legend entry to indicate comparison ellipses
-            compare_handle = mlines.Line2D([], [], color='gray', linestyle='--', linewidth=2, label='Comparison (dashed ellipse)')
-            legend_handles.append(compare_handle)
-
         # Add legend to ax_legend
         ncols = min(len(legend_handles), 6)
         if len(items_in_order) <= 5: 
-            ax_legend.legend(handles=legend_handles, bbox_to_anchor=(0.1, 0, 0.8, 0.7), ncol=ncols, fancybox=True, loc='center', fontsize=10, framealpha=1.0, markerscale=2, prop={'size': 10})
+            ax_legend.legend(handles=legend_handles, bbox_to_anchor=(0.1, 0.3, 0.8, 0.7), ncol=ncols, fancybox=True, loc='center', fontsize=10, framealpha=1.0, markerscale=2, prop={'size': 10})
         else:
-            ax_legend.legend(handles=legend_handles, bbox_to_anchor=(0.1, 0, 0.8, 0.7), ncol=ncols, fancybox=True, loc='center', fontsize=10, framealpha=1.0, markerscale=2, prop={'size': 10})
+            ax_legend.legend(handles=legend_handles, bbox_to_anchor=(0.1, 0.3, 0.8, 0.7), ncol=ncols, fancybox=True, loc='center', fontsize=10, framealpha=1.0, markerscale=2, prop={'size': 10})
+        
+        # Add comparison note below the legend if comparison data is present
+        if compare_df is not None and len(compare_df) > 0 and compare_year is not None:
+            ax_legend.text(0.5, -0.1, f'Dashed ellipses show comparison to {compare_year}', 
+                          ha='center', va='top', fontsize=11, fontstyle='italic', 
+                          transform=ax_legend.transAxes)
                     
         # Add footer text
         ax_footer.text(x=0.075, y=0, s='By: Thomas Nestico\n      @TJStats', fontname='Calibri', ha='left', fontsize=12, va='bottom')