Refactor player ID mapping in grab_contest_data for improved clarity and accuracy

- Updated the logic for combining player positions and IDs to map player names directly, enhancing the readability of the output.
- Removed the regex replacement for lineup strings, simplifying the data handling process.
- These changes contribute to ongoing efforts to improve data integrity and user experience within the application.

global_func/grab_contest_data.py

@@ -19,11 +19,11 @@ def grab_contest_data(sport, contest_name, contest_id_map, contest_date):
             print(f"Warning: Mismatch for hash {lineup_hash}. IDs: {len(player_ids)}, Positions: {len(positions)}")
             return lineup_hash
 
-        # Combine positions and player IDs
-        combined_parts = [pos + pid for pos, pid in zip(positions, player_ids)]
+        # Map each player ID to their name and combine with position
+        mapped_parts = [pos + pid_map.get(pid, pid) for pos, pid in zip(positions, player_ids)]
         
         # Join them into a single string
-        return "".join(combined_parts)
+        return "".join(mapped_parts)
 
     lineups_json = requests.get(lineups_url).json()
     data_json = requests.get(data_url).json()
@@ -65,7 +65,6 @@ def grab_contest_data(sport, contest_name, contest_id_map, contest_date):
     lineups_df = lineups_df.rename(columns={'index': 'Rank', 'points': 'Points', 'entryNameList': 'EntryName', 'lineupHash': 'Lineup'})
     lineups_df['EntryName'] = lineups_df['EntryName'] + ' (1/1)'
     lineups_df['Lineup'] = lineups_df['Lineup'].apply(lambda x: format_lineup_string(x, position_inserts))
-    lineups_df['Lineup'] = lineups_df['Lineup'].replace(pid_map, regex=True)  # Note: back to regex=True
     lineups_df = lineups_df[['Rank', 'EntryId', 'EntryName', 'TimeRemaining', 'Points', 'Lineup']]
 
     total_data = lineups_df.merge(players_df, how='left', left_index=True, right_index=True)