make sure we allow user to change model if clicking on a link with mo… (#172)

* make sure we allow user to change model if clicking on a link with model in url param

* typo

* avoid try/catch + abstract weird Zod enum

src/lib/utils/models.ts

@@ -1,4 +1,10 @@
 import type { Model } from "$lib/types/Model";
+import { z } from "zod";
 
 export const findCurrentModel = (models: Model[], name?: string) =>
 	models.find((m) => m.name === name) ?? models[0];
+
+export const validateModel = (models: Model[]) => {
+	// Zod enum function requires 2 parameters
+	return z.enum([models[0].name, ...models.slice(1).map((m) => m.name)]);
+};

src/routes/+layout.server.ts

@@ -1,14 +1,32 @@
+import { base } from "$app/paths";
+import { redirect } from "@sveltejs/kit";
 import type { LayoutServerLoad } from "./$types";
 import { collections } from "$lib/server/database";
 import type { Conversation } from "$lib/types/Conversation";
 import { UrlDependency } from "$lib/types/UrlDependency";
 import { defaultModel, models } from "$lib/server/models";
+import { validateModel } from "$lib/utils/models";
 
-export const load: LayoutServerLoad = async ({ locals, depends, url }) => {
+export const load: LayoutServerLoad = async ({ locals, depends, url, request }) => {
 	const { conversations } = collections;
+	const urlModel = url.searchParams.get("model");
 
 	depends(UrlDependency.ConversationList);
 
+	if (urlModel) {
+		const isValidModel = validateModel(models).safeParse(urlModel).success;
+
+		if (isValidModel) {
+			await collections.settings.updateOne(
+				{ sessionId: locals.sessionId },
+				{ $set: { activeModel: urlModel } },
+				{ upsert: true }
+			);
+		}
+
+		throw redirect(303, request.headers.get("referer") || base || "/");
+	}
+
 	const settings = await collections.settings.findOne({ sessionId: locals.sessionId });
 
 	return {
@@ -33,7 +51,7 @@ export const load: LayoutServerLoad = async ({ locals, depends, url }) => {
 		settings: {
 			shareConversationsWithModelAuthors: settings?.shareConversationsWithModelAuthors ?? true,
 			ethicsModalAcceptedAt: settings?.ethicsModalAcceptedAt ?? null,
-			activeModel: url.searchParams.get("model") ?? settings?.activeModel ?? defaultModel.name,
+			activeModel: settings?.activeModel ?? defaultModel.name,
 		},
 		models: models.map((model) => ({
 			name: model.name,

src/routes/conversation/+server.ts

@@ -6,6 +6,7 @@ import { base } from "$app/paths";
 import { z } from "zod";
 import type { Message } from "$lib/types/Message";
 import { defaultModel, models } from "$lib/server/models";
+import { validateModel } from "$lib/utils/models";
 
 export const POST: RequestHandler = async (input) => {
 	const body = await input.request.text();
@@ -16,9 +17,7 @@ export const POST: RequestHandler = async (input) => {
 	const values = z
 		.object({
 			fromShare: z.string().optional(),
-			model: z
-				.enum([models[0].name, ...models.slice(1).map((m) => m.name)])
-				.default(defaultModel.name),
+			model: validateModel(models).default(defaultModel.name),
 		})
 		.parse(JSON.parse(body));
 

src/routes/settings/+page.server.ts

@@ -3,6 +3,7 @@ import { collections } from "$lib/server/database";
 import { redirect } from "@sveltejs/kit";
 import { z } from "zod";
 import { defaultModel, models } from "$lib/server/models";
+import { validateModel } from "$lib/utils/models.js";
 
 export const actions = {
 	default: async function ({ request, locals }) {
@@ -12,7 +13,7 @@ export const actions = {
 			.object({
 				shareConversationsWithModelAuthors: z.boolean({ coerce: true }).default(true),
 				ethicsModalAccepted: z.boolean({ coerce: true }).optional(),
-				activeModel: z.enum([models[0].name, ...models.slice(1).map((m) => m.name)]),
+				activeModel: validateModel(models),
 			})
 			.parse({
 				shareConversationsWithModelAuthors: formData.get("shareConversationsWithModelAuthors"),