Fix regen: embed state in trigger value, remove seg_state from inputs

app.py

@@ -1421,9 +1421,13 @@ def _make_output_slots(tab_prefix: str) -> tuple:
                 label="",
                 show_label=False,
             ))
-            # State textbox: also CSS-hidden for same reason.
+            # State textbox: CSS-hidden, has elem_id so JS can READ current state
+            # and embed it in the trigger value (avoids having this component in
+            # both inputs AND outputs of the same .change() handler, which causes
+            # Gradio 5 SSR "Too many arguments" validation errors).
             seg_states.append(gr.Textbox(
                 value="",
+                elem_id=f"seg_state_{slot_id}",
                 elem_classes=["wf-hidden-input"],
                 label="",
                 show_label=False,
@@ -1547,9 +1551,21 @@ _GLOBAL_JS = """
 
   function fireRegen(slot_id, idx) {
     const el = document.getElementById('regen_trigger_' + slot_id);
-    if (!el) { console.warn('[fireRegen] element not found: regen_trigger_' + slot_id); return; }
+    if (!el) { console.warn('[fireRegen] regen_trigger element not found:', slot_id); return; }
     const input = el.querySelector('input, textarea');
-    if (!input) { console.warn('[fireRegen] no input inside regen_trigger_' + slot_id); return; }
+    if (!input) { console.warn('[fireRegen] no input inside regen_trigger:', slot_id); return; }
+
+    // Read current seg state JSON from the state textbox so we can embed it
+    // in the trigger value. This avoids having seg_state in BOTH inputs AND
+    // outputs of the .change() handler, which causes Gradio 5 SSR to reject
+    // the call with "Too many arguments provided for the endpoint".
+    const stEl = document.getElementById('seg_state_' + slot_id);
+    const stInput = stEl ? stEl.querySelector('input, textarea') : null;
+    const stateJson = stInput ? stInput.value : '';
+    if (!stateJson) {
+      console.warn('[fireRegen] seg_state is empty for slot', slot_id, '— skipping regen');
+      return;
+    }
 
     // Use native setter to bypass React's controlled-input tracking.
     // Clear to '' first so a repeat click on the same segment still fires .change().
@@ -1561,10 +1577,12 @@ _GLOBAL_JS = """
       input.dispatchEvent(new Event('input',  {bubbles: true}));
       input.dispatchEvent(new Event('change', {bubbles: true}));
     }
+    // Encode: "slot_id|seg_idx|{stateJSON}"
+    const triggerVal = slot_id + '|' + idx + '|' + stateJson;
     setNative('');
     setTimeout(function() {
-      setNative(slot_id + '|' + idx);
-      console.log('[fireRegen] fired', slot_id + '|' + idx);
+      setNative(triggerVal);
+      console.log('[fireRegen] fired trigger for', slot_id, 'seg', idx);
     }, 50);
 
     const lbl = document.getElementById('wf_seglabel_' + slot_id);
@@ -1667,17 +1685,19 @@ with gr.Blocks(title="Generate Audio for Video", css=_SLOT_CSS, js=_GLOBAL_JS) a
             for _i, _rtrig in enumerate(taro_slot_rtrigs):
                 _slot_id = f"taro_{_i}"
                 def _make_taro_regen(_si, _sid):
-                    def _do(trigger_val, video, seed, cfg, steps, mode, cf_dur, cf_db, state_json):
-                        print(f"[regen TARO] trigger_val={trigger_val!r} state_json_len={len(state_json) if state_json else 0} video={video!r}")
-                        if not trigger_val or not state_json:
-                            print(f"[regen TARO] early-exit: trigger_val empty={not trigger_val} state empty={not state_json}")
+                    def _do(trigger_val, video, seed, cfg, steps, mode, cf_dur, cf_db):
+                        print(f"[regen TARO] trigger_val_len={len(trigger_val) if trigger_val else 0} video={video!r}")
+                        if not trigger_val:
+                            print(f"[regen TARO] early-exit: trigger_val empty")
                             return gr.update(), gr.update(), gr.update(value="")
-                        parts = trigger_val.split("|")
-                        if len(parts) != 2 or parts[0] != _sid:
-                            print(f"[regen TARO] early-exit: parts={parts} expected slot={_sid}")
+                        # Trigger format: "slot_id|seg_idx|{stateJSON}"
+                        parts = trigger_val.split("|", 2)
+                        if len(parts) != 3 or parts[0] != _sid:
+                            print(f"[regen TARO] early-exit: parts[0]={parts[0]!r} expected={_sid!r}")
                             return gr.update(), gr.update(), gr.update(value="")
-                        seg_idx = int(parts[1])
-                        print(f"[regen TARO] slot={_sid} seg_idx={seg_idx} — acquiring lock")
+                        seg_idx    = int(parts[1])
+                        state_json = parts[2]
+                        print(f"[regen TARO] slot={_sid} seg_idx={seg_idx} state_json_len={len(state_json)}")
                         lock = _get_slot_lock(_sid)
                         with lock:
                             print(f"[regen TARO] slot={_sid} seg_idx={seg_idx} — lock acquired, showing spinner")
@@ -1702,7 +1722,7 @@ with gr.Blocks(title="Generate Audio for Video", css=_SLOT_CSS, js=_GLOBAL_JS) a
                 _rtrig.change(
                     fn=_make_taro_regen(_i, _slot_id),
                     inputs=[_rtrig, taro_video, taro_seed, taro_cfg, taro_steps,
-                            taro_mode, taro_cf_dur, taro_cf_db, taro_slot_states[_i]],
+                            taro_mode, taro_cf_dur, taro_cf_db],
                     outputs=[taro_slot_vids[_i], taro_slot_waves[_i], taro_slot_states[_i]],
                 )
 
@@ -1757,17 +1777,19 @@ with gr.Blocks(title="Generate Audio for Video", css=_SLOT_CSS, js=_GLOBAL_JS) a
             for _i, _rtrig in enumerate(mma_slot_rtrigs):
                 _slot_id = f"mma_{_i}"
                 def _make_mma_regen(_si, _sid):
-                    def _do(trigger_val, video, prompt, neg, seed, cfg, steps, cf_dur, cf_db, state_json):
-                        print(f"[regen MMA] trigger_val={trigger_val!r} state_json_len={len(state_json) if state_json else 0} video={video!r}")
-                        if not trigger_val or not state_json:
-                            print(f"[regen MMA] early-exit: trigger_val empty={not trigger_val} state empty={not state_json}")
+                    def _do(trigger_val, video, prompt, neg, seed, cfg, steps, cf_dur, cf_db):
+                        print(f"[regen MMA] trigger_val_len={len(trigger_val) if trigger_val else 0} video={video!r}")
+                        if not trigger_val:
+                            print(f"[regen MMA] early-exit: trigger_val empty")
                             return gr.update(), gr.update(), gr.update(value="")
-                        parts = trigger_val.split("|")
-                        if len(parts) != 2 or parts[0] != _sid:
-                            print(f"[regen MMA] early-exit: parts={parts} expected slot={_sid}")
+                        # Trigger format: "slot_id|seg_idx|{stateJSON}"
+                        parts = trigger_val.split("|", 2)
+                        if len(parts) != 3 or parts[0] != _sid:
+                            print(f"[regen MMA] early-exit: parts[0]={parts[0]!r} expected={_sid!r}")
                             return gr.update(), gr.update(), gr.update(value="")
-                        seg_idx = int(parts[1])
-                        print(f"[regen MMA] slot={_sid} seg_idx={seg_idx} — acquiring lock")
+                        seg_idx    = int(parts[1])
+                        state_json = parts[2]
+                        print(f"[regen MMA] slot={_sid} seg_idx={seg_idx} state_json_len={len(state_json)}")
                         lock = _get_slot_lock(_sid)
                         with lock:
                             print(f"[regen MMA] slot={_sid} seg_idx={seg_idx} — lock acquired, showing spinner")
@@ -1792,7 +1814,7 @@ with gr.Blocks(title="Generate Audio for Video", css=_SLOT_CSS, js=_GLOBAL_JS) a
                 _rtrig.change(
                     fn=_make_mma_regen(_i, _slot_id),
                     inputs=[_rtrig, mma_video, mma_prompt, mma_neg, mma_seed,
-                            mma_cfg, mma_steps, mma_cf_dur, mma_cf_db, mma_slot_states[_i]],
+                            mma_cfg, mma_steps, mma_cf_dur, mma_cf_db],
                     outputs=[mma_slot_vids[_i], mma_slot_waves[_i], mma_slot_states[_i]],
                 )
 
@@ -1848,17 +1870,19 @@ with gr.Blocks(title="Generate Audio for Video", css=_SLOT_CSS, js=_GLOBAL_JS) a
             for _i, _rtrig in enumerate(hf_slot_rtrigs):
                 _slot_id = f"hf_{_i}"
                 def _make_hf_regen(_si, _sid):
-                    def _do(trigger_val, video, prompt, neg, seed, guidance, steps, size, cf_dur, cf_db, state_json):
-                        print(f"[regen HF] trigger_val={trigger_val!r} state_json_len={len(state_json) if state_json else 0} video={video!r}")
-                        if not trigger_val or not state_json:
-                            print(f"[regen HF] early-exit: trigger_val empty={not trigger_val} state empty={not state_json}")
+                    def _do(trigger_val, video, prompt, neg, seed, guidance, steps, size, cf_dur, cf_db):
+                        print(f"[regen HF] trigger_val_len={len(trigger_val) if trigger_val else 0} video={video!r}")
+                        if not trigger_val:
+                            print(f"[regen HF] early-exit: trigger_val empty")
                             return gr.update(), gr.update(), gr.update(value="")
-                        parts = trigger_val.split("|")
-                        if len(parts) != 2 or parts[0] != _sid:
-                            print(f"[regen HF] early-exit: parts={parts} expected slot={_sid}")
+                        # Trigger format: "slot_id|seg_idx|{stateJSON}"
+                        parts = trigger_val.split("|", 2)
+                        if len(parts) != 3 or parts[0] != _sid:
+                            print(f"[regen HF] early-exit: parts[0]={parts[0]!r} expected={_sid!r}")
                             return gr.update(), gr.update(), gr.update(value="")
-                        seg_idx = int(parts[1])
-                        print(f"[regen HF] slot={_sid} seg_idx={seg_idx} — acquiring lock")
+                        seg_idx    = int(parts[1])
+                        state_json = parts[2]
+                        print(f"[regen HF] slot={_sid} seg_idx={seg_idx} state_json_len={len(state_json)}")
                         lock = _get_slot_lock(_sid)
                         with lock:
                             print(f"[regen HF] slot={_sid} seg_idx={seg_idx} — lock acquired, showing spinner")
@@ -1883,7 +1907,7 @@ with gr.Blocks(title="Generate Audio for Video", css=_SLOT_CSS, js=_GLOBAL_JS) a
                 _rtrig.change(
                     fn=_make_hf_regen(_i, _slot_id),
                     inputs=[_rtrig, hf_video, hf_prompt, hf_neg, hf_seed,
-                            hf_guidance, hf_steps, hf_size, hf_cf_dur, hf_cf_db, hf_slot_states[_i]],
+                            hf_guidance, hf_steps, hf_size, hf_cf_dur, hf_cf_db],
                     outputs=[hf_slot_vids[_i], hf_slot_waves[_i], hf_slot_states[_i]],
                 )