Update app.py

app.py

@@ -324,6 +324,8 @@ class DicomAnalyzer:
     def add_formulas_to_template(self, ws, row_pair, col_group, red_font):
         """
         Inserts SNR (first row) and CNR (second row) formulas with IFERROR.
+        SNR => row1
+        CNR => row2
         """
         try:
             base_col = col_group[1]  # Mean column
@@ -331,7 +333,7 @@ class DicomAnalyzer:
             
             row1, row2 = row_pair
             
-            # SNR formula
+            # SNR formula in row1
             formula1 = f"=IFERROR({base_col}{row1}/{std_col}{row1},\"\")"
             formula_col = get_column_letter(column_index_from_string(col_group[-1]) + 1)
             cell1 = ws[f"{formula_col}{row1}"]
@@ -339,7 +341,7 @@ class DicomAnalyzer:
             cell1.font = red_font
             cell1.alignment = openpyxl.styles.Alignment(horizontal='center')
             
-            # CNR formula
+            # CNR formula in row2
             formula2 = f"=IFERROR(({base_col}{row1}-{base_col}{row2})/{std_col}{row2},\"\")"
             cell2 = ws[f"{formula_col}{row2}"]
             cell2.value = formula2
@@ -371,27 +373,32 @@ class DicomAnalyzer:
                 ('BV', 'BW', 'BX', 'BY', 'BZ')
             ]
             
+            # Write main headers in each column group
             for cols in column_groups:
                 for i, header in enumerate(headers):
                     cell = ws[f"{cols[i]}1"]
                     cell.value = header
                     cell.alignment = center_alignment
 
+            # Pairs of rows for measurements
             row_pairs = [
                 (2, 3), (5, 6), (8, 9), (11, 12), (14, 15),
                 (17, 18), (20, 21), (23, 24), (26, 27), (29, 30)
             ]
 
+            # Phantom sizes (used for labeling)
             phantom_sizes = [
                 '(7mm)', '(6.5mm)', '(6mm)', '(5.5mm)', '(5mm)',
                 '(4.5mm)', '(4mm)', '(3.5mm)', '(3mm)', '(2.5mm)'
             ]
             
+            # Put phantom size labels in column A (row-1 from the first measurement row)
             for i, size in enumerate(phantom_sizes):
                 header_cell = ws.cell(row=row_pairs[i][0]-1, column=1, value=size)
                 header_cell.font = red_font
                 header_cell.alignment = center_alignment
 
+            # Write all self.results into the sheet, as in your original code
             result_idx = 0
             current_col_group = 0
             current_row_pair = 0
@@ -413,6 +420,7 @@ class DicomAnalyzer:
                     self._write_result_to_cells(ws, result, cols, rows[1])
                     result_idx += 1
                 
+                # Add SNR/CNR formulas for these two rows
                 self.add_formulas_to_template(ws, rows, cols, red_font)
                 
                 current_col_group += 1
@@ -420,6 +428,7 @@ class DicomAnalyzer:
                     current_col_group = 0
                     current_row_pair += 1
 
+            # Center-align all non-empty cells from row 2..30 in those columns
             for cols in column_groups:
                 for col in cols:
                     for row in range(2, 31):
@@ -427,11 +436,12 @@ class DicomAnalyzer:
                         if cell.value is not None:
                             cell.alignment = center_alignment
 
-            # الآن نضع جدول 1-AVG من الصف 35 إلى 45
+            # Now create the 1-AVG table at row 35..45
             start_row = 35
             ws['C35'] = "1-AVG"
             ws['C35'].alignment = center_alignment
             
+            # Merge 3 sets of headers in row 35
             ws.merge_cells('D35:E35')
             ws.merge_cells('F35:G35')
             ws.merge_cells('H35:I35')
@@ -446,14 +456,17 @@ class DicomAnalyzer:
                 ws[c_ref].font = red_font
                 ws[c_ref].alignment = center_alignment
             
+            # We will re-use the same 10 phantom sizes
             phantom_sizes2 = [
                 '(7.0mm)', '(6.5mm)', '(6.0mm)', '(5.5mm)', '(5.0mm)',
                 '(4.5mm)', '(4.0mm)', '(3.5mm)', '(3.0mm)', '(2.5mm)'
             ]
             
+            # For each phantom row, read the same row_pairs to gather data
             for i, p_size in enumerate(phantom_sizes2):
-                row = start_row + i + 1  # من 36..45
+                row = start_row + i + 1  # 36..45
                 
+                # Merge each row's 3 sets: (D-E), (F-G), (H-I)
                 ws.merge_cells(f'D{row}:E{row}')
                 ws.merge_cells(f'F{row}:G{row}')
                 ws.merge_cells(f'H{row}:I{row}')
@@ -472,33 +485,44 @@ class DicomAnalyzer:
                 stddev_values = []
                 cnr_values = []
                 
+                # We read from the same column groups. 
+                # But now for CNR, we'll read from the formula column (the one add_formulas_to_template uses).
                 for group in column_groups:
-                    mean_col = group[1]  # ex. 'C'
-                    std_col  = group[2]  # ex. 'D'
+                    mean_col = group[1]  # e.g. 'C'
+                    std_col  = group[2]  # e.g. 'D'
+
+                    # For MEAN, let's read row1 as before
+                    val_mean = ws[f"{mean_col}{raw_row1}"].value
+                    # For STDDEV, also row1 if you prefer
+                    val_std = ws[f"{std_col}{raw_row1}"].value
+
+                    # For CNR, the formula is placed in row2 in the "formula column" after group[-1].
+                    # So let's find that column letter:
+                    formula_col_index = column_index_from_string(group[-1]) + 1
+                    formula_col = get_column_letter(formula_col_index)
                     
-                    m1 = ws[f"{mean_col}{raw_row1}"].value
-                    m2 = ws[f"{mean_col}{raw_row2}"].value
-
-                    # في السابق كانت:
-                    # std2 = ws[f"{std_col}{raw_row2}"].value
-                    # لكنك تريد أخذ stddev من الصف الأول (raw_row1):
-                    std2 = ws[f"{std_col}{raw_row1}"].value  # <-- التعديل هنا
+                    # The formula was put in row2
+                    val_cnr = ws[f"{formula_col}{raw_row2}"].value
                     
+                    # Convert them to float if possible
                     try:
-                        m1   = float(m1)   if m1   not in [None,''] else None
-                        m2   = float(m2)   if m2   not in [None,''] else None
-                        std2 = float(std2) if std2 not in [None,''] else None
+                        val_mean = float(val_mean) if val_mean not in [None, ''] else None
+                        val_std  = float(val_std)  if val_std  not in [None, ''] else None
+                        val_cnr  = float(val_cnr)  if val_cnr  not in [None, ''] else None
                     except:
-                        m1,m2,std2 = None,None,None
-                    if (m1 is not None) and (m2 is not None) and (std2 is not None) and (std2!=0):
-                        mean_values.append(m1)
-                        stddev_values.append(std2)
-                        cnr_values.append((m1 - m2)/std2)
+                        val_mean,val_std,val_cnr = None,None,None
+                    
+                    if val_mean is not None:
+                        mean_values.append(val_mean)
+                    if val_std is not None:
+                        stddev_values.append(val_std)
+                    if val_cnr is not None:
+                        cnr_values.append(val_cnr)
                 
-                # نحسب المتوسط
-                final_mean = (sum(mean_values)/len(mean_values)) if mean_values else None
-                final_std  = (sum(stddev_values)/len(stddev_values)) if stddev_values else None
-                final_cnr  = (sum(cnr_values)/len(cnr_values)) if cnr_values else None
+                # Compute final averages
+                final_mean = sum(mean_values)/len(mean_values) if mean_values else None
+                final_std  = sum(stddev_values)/len(stddev_values) if stddev_values else None
+                final_cnr  = sum(cnr_values)/len(cnr_values) if cnr_values else None
                 
                 if final_mean is not None:
                     ws[f'D{row}'].value = final_mean
@@ -515,6 +539,7 @@ class DicomAnalyzer:
                     ws[f'H{row}'].alignment = center_alignment
                     ws[f'H{row}'].number_format = '0.0000'
 
+            # Finally, border around C35..I45
             thin_side = openpyxl.styles.Side(style='thin')
             border = openpyxl.styles.Border(
                 left=thin_side, right=thin_side, top=thin_side, bottom=thin_side
@@ -578,17 +603,14 @@ class DicomAnalyzer:
         return image, self.format_results()
 
     def undo_last(self, image):
-        if not self.results:  # لو مفيش نتائج أصلاً
+        if not self.results:  # لا توجد نتائج
             return self.update_display(), self.format_results()
             
         last_result = self.results[-1]
-        # نتحقق إذا كان آخر إجراء قياس حقيقي أم صف صفري
         is_measurement = last_result['Point'] != '(0, 0)'
         
-        # نمسح آخر نتيجة
         self.results.pop()
         
-        # لو كان قياس حقيقي، نمسح العلامة المقابلة له
         if is_measurement and self.marks:
             self.marks.pop()