fix: address CodeRabbit review feedback

- Move network reachability check to runtime in test_clinicaltrials.py
(avoids 5s delay at test collection time)
- Add explicit api_provider validation in app.py
(raises ValueError for unsupported providers instead of silent fallback)

src/app.py

@@ -68,9 +68,11 @@ def configure_orchestrator(
             if api_provider == "anthropic":
                 anthropic_provider = AnthropicProvider(api_key=user_api_key)
                 model = AnthropicModel(settings.anthropic_model, provider=anthropic_provider)
-            else:
+            elif api_provider == "openai":
                 openai_provider = OpenAIProvider(api_key=user_api_key)
                 model = OpenAIModel(settings.openai_model, provider=openai_provider)
+            else:
+                raise ValueError(f"Unsupported API provider: {api_provider}")
         judge_handler = JudgeHandler(model=model)
 
     return create_orchestrator(

tests/unit/tools/test_clinicaltrials.py

@@ -123,26 +123,21 @@ class TestClinicalTrialsTool:
                 await tool.search("metformin alzheimer")
 
 
-def _can_reach_clinicaltrials() -> bool:
-    """Check if ClinicalTrials.gov API is reachable."""
-    try:
-        resp = requests.get("https://clinicaltrials.gov/api/v2/studies", timeout=5)
-        return resp.status_code < 500
-    except (requests.RequestException, OSError):
-        return False
-
-
 class TestClinicalTrialsIntegration:
     """Integration tests (marked for separate run)."""
 
     @pytest.mark.integration
     @pytest.mark.asyncio
-    @pytest.mark.skipif(
-        not _can_reach_clinicaltrials(),
-        reason="ClinicalTrials.gov API not reachable (network/SSL issue)",
-    )
     async def test_real_api_call(self) -> None:
         """Test actual API call (requires network)."""
+        # Skip at runtime if API unreachable (avoids network call at collection time)
+        try:
+            resp = requests.get("https://clinicaltrials.gov/api/v2/studies", timeout=5)
+            if resp.status_code >= 500:
+                pytest.skip("ClinicalTrials.gov API not reachable (server error)")
+        except (requests.RequestException, OSError):
+            pytest.skip("ClinicalTrials.gov API not reachable (network/SSL issue)")
+
         tool = ClinicalTrialsTool()
         results = await tool.search("metformin diabetes", max_results=3)