Update app.py

app.py

@@ -19,19 +19,26 @@ class QuizApp:
         prompt = f"""Create exactly {num_questions} multiple choice questions based on this text:
         {text}
         
+        For each question:
+        1. Create a clear, concise question
+        2. Provide exactly 4 options
+        3. Mark the correct answer with the index (0-3)
+        4. Ensure options are concise and clear
+        
         Return ONLY a JSON array with this EXACT format - no other text:
         [
             {{
                 "question": "Question text here?",
                 "options": [
-                    "Option 1",
-                    "Option 2",
-                    "Option 3",
-                    "Option 4"
+                    "Brief option 1",
+                    "Brief option 2",
+                    "Brief option 3",
+                    "Brief option 4"
                 ],
                 "correct_answer": 0
             }}
         ]
+        Keep all options concise (10 words or less each).
         """
         
         try:
@@ -39,7 +46,7 @@ class QuizApp:
                 messages=[
                     {
                         "role": "system",
-                        "content": "You are a quiz generator. Respond only with a properly formatted JSON array."
+                        "content": "You are a quiz generator. Create clear questions with concise answer options."
                     },
                     {
                         "role": "user",
@@ -47,18 +54,15 @@ class QuizApp:
                     }
                 ],
                 model="llama-3.2-3b-preview",
-                temperature=0.3,  # Reduced temperature for more consistent formatting
-                max_tokens=2048,
-                stop=["\n\n", "```"]  # Stop generation at these tokens
+                temperature=0.3,
+                max_tokens=2048
             )
             
-            # Clean up the response
+            # Clean and parse response
             response_text = response.choices[0].message.content.strip()
-            
-            # Remove any markdown formatting
             response_text = response_text.replace("```json", "").replace("```", "").strip()
             
-            # Find the JSON array
+            # Extract JSON array
             start_idx = response_text.find("[")
             end_idx = response_text.rfind("]")
             
@@ -66,62 +70,42 @@ class QuizApp:
                 raise ValueError("No valid JSON array found in response")
                 
             response_text = response_text[start_idx:end_idx + 1]
+            questions = json.loads(response_text)
             
-            # Try to parse the JSON
-            try:
-                questions = json.loads(response_text)
-            except json.JSONDecodeError:
-                # If parsing fails, try to fix common JSON formatting issues
-                response_text = response_text.replace("'", '"')  # Replace single quotes with double quotes
-                response_text = response_text.replace("},]", "}]")  # Fix trailing comma
-                response_text = response_text.replace(",]", "]")  # Fix trailing comma
-                questions = json.loads(response_text)
-            
-            # Validate questions
+            # Validate and clean up questions
             validated_questions = []
             for q in questions:
-                if not isinstance(q, dict):
-                    continue
-                    
-                # Ensure all required fields are present
                 if not all(key in q for key in ["question", "options", "correct_answer"]):
                     continue
                     
-                # Ensure options is a list with exactly 4 items
-                if not isinstance(q["options"], list) or len(q["options"]) != 4:
-                    # Try to fix by padding with additional options if needed
-                    if isinstance(q["options"], list) and len(q["options"]) < 4:
-                        q["options"].extend([f"Additional option {i+1}" for i in range(4 - len(q["options"]))])
-                    else:
-                        continue
-                        
-                # Ensure correct_answer is valid
-                if not isinstance(q["correct_answer"], (int)) or q["correct_answer"] not in range(4):
-                    q["correct_answer"] = 0  # Default to first option if invalid
+                # Ensure options are strings and reasonably sized
+                clean_options = []
+                for opt in q["options"]:
+                    if isinstance(opt, str):
+                        # Limit option length and clean up formatting
+                        clean_opt = opt.strip()[:100]  # Limit length
+                        clean_options.append(clean_opt)
+                
+                if len(clean_options) != 4:
+                    continue
                     
-                validated_questions.append(q)
+                # Create clean question
+                clean_q = {
+                    "question": q["question"].strip(),
+                    "options": clean_options,
+                    "correct_answer": int(q["correct_answer"]) % 4  # Ensure valid index
+                }
+                validated_questions.append(clean_q)
             
             if not validated_questions:
-                return False, []
+                raise ValueError("No valid questions after validation")
                 
-            self.current_questions = validated_questions[:num_questions]  # Limit to requested number
+            self.current_questions = validated_questions[:num_questions]
             return True, self.current_questions
             
         except Exception as e:
             print(f"Error in question generation: {str(e)}")
-            # Create a single default question for testing
-            default_questions = [{
-                "question": "Default question (Error in generation - please try again)",
-                "options": [
-                    "Option A",
-                    "Option B",
-                    "Option C",
-                    "Option D"
-                ],
-                "correct_answer": 0
-            }]
-            self.current_questions = default_questions
-            return True, default_questions
+            return False, []
 
     def calculate_score(self, answers):
         if not answers or not self.current_questions:
@@ -130,11 +114,19 @@ class QuizApp:
         total = len(self.current_questions)
         correct = 0
         for i, (q, a) in enumerate(zip(self.current_questions, answers)):
-            if a is not None and q['correct_answer'] == int(a):
-                correct += 1
+            try:
+                if a is not None:
+                    # Find the index of the selected answer in the options list
+                    selected_index = q["options"].index(a)
+                    if selected_index == q["correct_answer"]:
+                        correct += 1
+            except (ValueError, TypeError) as e:
+                print(f"Error processing answer {i}: {e}")
+                continue
         
         return (correct / total) * 100
 
+
 def create_quiz_interface():
     quiz_app = QuizApp()
     
@@ -180,14 +172,30 @@ def create_quiz_interface():
             with gr.Tab("📝 Step 2: Take Assessment") as tab2:
                 questions_markdown = gr.Markdown("")
                 answers = []
-                for i in range(5):  # Pre-create radio buttons
-                    radio = gr.Radio(
-                        choices=[],
-                        label=f"Question {i+1}",
-                        visible=False
-                    )
-                    answers.append(radio)
-                submit_btn = gr.Button("Submit Assessment", variant="primary", size="lg")
+                for i in range(5):
+                    with gr.Group():
+                        radio = gr.Radio(
+                            choices=[],
+                            label=f"Question {i+1}",
+                            visible=False,
+                            interactive=True
+                        )
+                        answers.append(radio)
+                
+                submit_btn = gr.Button(
+                    "Submit Assessment", 
+                    variant="primary",
+                    size="lg"
+                )
+                
+                gr.Markdown("""
+                ### Instructions:
+                - Read each question carefully
+                - Select one answer for each question
+                - Click Submit Assessment when you're done
+                - You need 80% or higher to earn your certificate
+                """)
+            
             
             # Step 3: Get Certified
             with gr.Tab("🎓 Step 3: Get Certified") as tab3:
@@ -217,33 +225,35 @@ def create_quiz_interface():
                     0
                 )
             
-            # Update question display
+            # Update question display with answers immediately following each question
             questions_html = "# 📝 Assessment Questions\n\n"
             questions_html += "> Please select one answer for each question below.\n\n"
             
-            for i, q in enumerate(questions, 1):
-                questions_html += f"### Question {i}\n{q['question']}\n\n"
-            
             # Update radio buttons
             updates = []
-            for i in range(5):
-                if i < len(questions):
-                    updates.append(gr.update(
-                        visible=True,
-                        choices=questions[i]["options"],
-                        value=None,
-                        label=f"Select answer for Question {i+1}"
-                    ))
-                else:
-                    updates.append(gr.update(visible=False, choices=[]))
+            for i, q in enumerate(questions):
+                questions_html += f"### Question {i+1}\n{q['question']}\n\n"
+                # Create radio button update for this question
+                updates.append(gr.update(
+                    visible=True,
+                    choices=q["options"],
+                    value=None,
+                    label=f"Select your answer:"
+                ))
+                questions_html += "\n\n" # Add space between questions
+            
+            # Fill remaining radio buttons with hidden updates
+            for i in range(len(questions), 5):
+                updates.append(gr.update(visible=False, choices=[]))
             
-            return (gr.update(value=questions_html), *updates, questions, 1)        
+            return (gr.update(value=questions_html), *updates, questions, 1)
         
+     
         def submit_quiz(q1, q2, q3, q4, q5, questions):
             answers = [q1, q2, q3, q4, q5][:len(questions)]
             score = quiz_app.calculate_score(answers)
             return score, 2
-        
+
         # Event handlers
         generate_btn.click(
             fn=update_questions,