Question: how do i download all my music to my new iphone?
Answer: On the new iPhone, open the Settings app and tap Music.
Toggle 'Show Apple Music' and 'iCloud Music Library' on (make sure you have a decent Wi-Fi connection).
Your iCloud Music Library should then download on the iPhone.