sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: storybook
Issue: [Bug]: User cannot navigate any drop down box through keyboard
Labels: bug,good first issue,ui,accessibility,addon: toolbars,sev:S3

### Describe the bug

I cannot navigate any dropdown by the keyboard.

![image](https://user-images.githubusercontent.com/32093370/224757440-0e4b1c6f-75ea-41f4-be56-deec7c961b51.png)


### To Reproduce

1. Navigate to the theme button on the toolbar by the keyboard
2. Once the button has the focus, hit Enter.
3. I cannot navigate the dropdown to change the theme

### System

_No response_

### Additional context

I observed this bug is there for all the dropdown boxes.
For example,
1. Settings button on the sidebar
![image](https://user-images.githubusercontent.com/32093370/224764248-2cceeb40-80eb-49ae-9bc7-66817893d385.png)
2. Clear background button
![image](https://user-images.githubusercontent.com/32093370/224764477-7cf5a2f2-f42b-406d-a886-b102f47f0fb7.png)
3. Size of the preview
![image](https://user-images.githubusercontent.com/32093370/224764622-7324b380-540d-4a58-8fb0-32894ffa0569.png)
4. Change the language button 
![image](https://user-images.githubusercontent.com/32093370/224764823-f9242c87-0178-413f-9c05-2a02cc735199.png)
5. Dropdown when the dock is on the right side
![image](https://user-images.githubusercontent.com/32093370/224765824-4678c40e-5a6f-454d-a07c-3e1dbac25d26.png)
Repository: vscode
Issue: WorkspaceEdits with "isRefactoring: false" metadata show in "Refactor Preview" pane
Labels: polish,under-discussion,workspace-edit

There's a flag on `WorkspaceEditMetadata` for `isRefactoring`:

```
/**
 * Additional data about a workspace edit.
 */
export interface WorkspaceEditMetadata {
	/**
	 * Signal to the editor that this edit is a refactoring.
	 */
	isRefactoring?: boolean;
}
```

Setting it to false for an annotated edit like this:

```ts
const doc = await vs.workspace.openTextDocument(vs.Uri.parse("untitled:foo.txt"));
const editor = await vs.window.showTextDocument(doc);
const edit = new vs.WorkspaceEdit();
edit.insert(doc.uri, new vs.Position(0, 0), "test", { label: "This is my label", needsConfirmation: true });
vs.workspace.applyEdit(edit, { isRefactoring: false });
```

Results in the preview showing in a pane called "Refactor Preview":

![Screenshot 2023-03-13 at 16 41 43](https://user-images.githubusercontent.com/1078012/224768367-c3bf73e5-0d13-4a8d-8871-2c0f4da7619b.png)

This seems a little confusing. I think it would be better if this panel didn't contain "Refactor" in the name. Perhaps it's also worth the docs/comments being more clear about what `isRefactoring` really means/affects.
Repository: vscode
Issue: Workspace edits with metadata do not show labels that docs say are rendered prominently
Labels: feature-request,under-discussion,workspace-edit

In `WorkspaceEditEntryMetadata`, the `label` field says this:

```ts
/**
 * A human-readable string which is rendered prominent.
 */
label: string;
```

In LSP, it's slightly expanded:

```
	/**
	 * A human-readable string describing the actual change. The string
	 * is rendered prominent in the user interface.
	 */
	label: string;
```

This makes it seem like these labels will be visible in the UI by default. Yet if you run:

```ts
const doc = await vs.workspace.openTextDocument(vs.Uri.parse("untitled:foo.txt"));
const editor = await vs.window.showTextDocument(doc);
const edit = new vs.WorkspaceEdit();
edit.insert(doc.uri, new vs.Position(0, 0), "test1", { label: "This is my label", needsConfirmation: true });
edit.insert(doc.uri, new vs.Position(0, 0), "test2", { label: "This is my label2", needsConfirmation: true });
vs.workspace.applyEdit(edit, { isRefactoring: false });
```

It is rendered like this without the labels:

![Screenshot 2023-03-13 at 16 45 44](https://user-images.githubusercontent.com/1078012/224769252-64cf855d-1399-49c5-a19a-cfb8b999c5e7.png)

You have to right-click and tick "Group change by type" to see the labels:

![Screenshot 2023-03-13 at 16 46 10](https://user-images.githubusercontent.com/1078012/224769349-f5300ff8-d56e-4a42-8835-4048175f025d.png)

I think it would be better if the items were grouped by default (since the server went to lengths to provide the labels, which are not optional if they want to prompt for confirmation), but if not I think the API comments could be a little clearer (or even the label made optional).
Repository: PowerToys
Issue: unit converter: add all scientific prefixes
Labels: Idea-Enhancement,Run-Plugin

### Description of the new feature / enhancement

I noticed that for example TJ (tera joule) doesn't work. please add all metric prefixes (https://en.wikipedia.org/wiki/Metric_prefix)

### Scenario when this would be used?

whenever I am working with scientific data it could come up.

### Supporting information

_No response_
Repository: three.js
Issue: Renderer should resize before entering an XR session to facilitate responsive pages
Labels: Needs Investigation

### Description

I have a responsive page and a canvas in this page that resizes as the page size changes. All this works well. The aspect ratio of my 3D scene is maintained as the canvas is resized. 

When I enter XR mode, by using the VRButton class, things change. The canvas now occupies the whole device width and height, which makes sense. However the renderer has not been resized so my original 3D scene, when rendered in VR, gets stretched or squashed.

In the jsFiddle the screen height is divided into two equal parts and the scene, comprising just one sphere, is rendered in the lower half. Proportions are correct. Press the "Enter VR" button and the sphere is no longer spherical. It's so simple and basic I thought I must be doing something fundamentally wrong.

The problem can be avoided, sort of, by passing updateStyle = false to the original renderer.setSize function. But this destroys the responsiveness of the page. I'd like the canvas to continually resize as the screen size is changed. 

Would it not make sense to make a renderer.resize call once an xr session has been granted by the VRButton's onClick handler: 

`navigator.xr.requestSession( 'immersive-vr', sessionInit ).then( onSessionStarted );`

but before the session has been established by the VRButton's onSessionStarted() function: 

`await renderer.xr.setSession( session );`

After the session is established I can't resize since the session "isPresenting" flag is then true, inhibiting resize.

To fix this couldn't a resize call be added to onSessionStarted() function, something like this (but more general to account for the renderer.renderTarget) as in the snippet below?

### Reproduction steps

1. Create any page where the target for the renderer, in my case the canvas, does not take up the whole device  width and height.
2. Render a sphere on the canvas
3. Click the "Enter VR" button


### Code

     
    async function onSessionStarted( session ) {
       **renderer.setSize(window.innerWidth, window.innerHeight);**
       
       session.addEventListener( 'end', onSessionEnded );

       await renderer.xr.setSession( session );
       button.textContent = 'EXIT VR';

       currentSession = session;
    }
 

### Live example

https://jsfiddle.net/fume1k7a/3/



### Screenshots

Before:

![image](https://user-images.githubusercontent.com/35147130/224767559-19293c64-b147-4cb9-a556-828c0dd15905.png)

After:

![image](https://user-images.githubusercontent.com/35147130/224767626-73e406bd-9678-42ba-9c9c-96c6dbe68bbe.png)



### Version

r147

### Device

_No response_

### Browser

_No response_

### OS

_No response_
Repository: go
Issue: regexp: compiling incorrectly
Labels: NeedsInvestigation

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.20.2 darwin/amd64
</pre>

### Does this issue reproduce with the latest release?
yes
and with 1.19 on the Go Playground

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/andrew/Library/Caches/go-build"
GOENV="/Users/andrew/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/andrew/Go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/andrew/Go:/Users/andrew/Dropbox/suneido_tests"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.20.2"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/andrew/Dropbox/gsuneido/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/dc/0y3gfqnn56g6pd8d3_b5wz300000gn/T/go-build1311023722=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.20.2 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.20.2
uname -v: Darwin Kernel Version 22.3.0: Mon Jan 30 20:42:11 PST 2023; root:xnu-8792.81.3~2/RELEASE_X86_64
ProductName:		macOS
ProductVersion:		13.2.1
BuildVersion:		22D68
lldb --version: lldb-1400.0.38.17
Apple Swift version 5.7.2 (swiftlang-5.7.2.135.5 clang-1400.0.29.51)
</pre></details>

### What did you do?

	pat := regexp.MustCompile(`0A|0[aA]`)
	fmt.Println(pat.MatchString("0a"))

(https://go.dev/play/p/jCLPp8AXnJB)

### What did you expect to see?

true

### What did you see instead?

false

I tested on regex101 to confirm that this should match.
(Strangely, it shows golang matching)
It appears to compile incorrectly. Simplify doesn't seem to matter.

    syntax.Parse("0A|0[aA]", 0)
    fmt.Println(syntax.Compile(re))
      0	fail
      1*	rune1 "0" -> 2
      2	rune1 "A" -> 3
      3	nop -> 4
      4	match
    
    syntax.Parse("0a|0[aA]", 0)
    fmt.Println(syntax.Compile(re))
      0	fail
      1*	rune1 "0" -> 2
      2	rune "AAaa" -> 3
      3	match
Repository: create-react-app
Issue: Snyk Vulnerabilities on react-scripts@5.0.1
Labels: needs triage,issue: bug report

When our application was run through Snyk recently, We found couple of vulnerabilities. The details are as follows

Regular Expression Denial of Service (ReDoS) (High Severity)
Package Manager: npm
Vulnerable module: nth-check
Paths : react-scripts@5.0.1 › @svgr/webpack@5.5.0 › @svgr/plugin-svgo@5.5.0 › svgo@1.3.2 › css-select@2.1.0
› nth-check@1.0.2

MPL-2.0 license ( Medium Severity)
Package Manager: npm
Module: axe-core
Paths : react-scripts@5.0.1 › eslint-config-react-app@7.0.1 › eslint-plugin-jsx-a11y@6.5.1 › axe-core@4.4.1

Denial of Service (DoS) ( Medium Severity)
Package Manager: npm
Vulnerable module: nwsapi
Paths: react-scripts@5.0.1 › jest@27.5.1 › @jest/core@27.5.1 › jest-config@27.5.1 › jest-environment-jsdom@27.5.1 ›
jsdom@16.7.0 › nwsapi@2.2.0

We are already running latest version of react-scripts. Any remediations possible?
Repository: next.js
Issue: Docs: middleware and basePath combo
Labels: bug

### What is the improvement or update you wish to see?

Explicit note of a possibility to use the same path matching as in e.g. redirects (source, destination, has, ...) for middleware's matcher and some warning in basePath docs for middleware users

### Is there any context that might help us understand?

Not sure if this falls under the category of a bug or it's just missing pieces in the documentation of middleware or testing scenario, but I did struggle for a while to get it fixed - so having it documented would probably help others
The missing piece is an explicit note of a possibility to use the same path matching as in e.g. redirects (source, destination, has, ...) for middleware's matcher
Bumped into this while fixing my problem (bug?) of a combination of having both middleware and _basePath_ set.
The matcher's path matching array, e.g. the one in doc example (`'/((?!api|_next/static|_next/image|favicon.ico).*)'`) works fine until you start deploying the app to a system where _basePath_ is required
It affects only the root route (/) - which may be the most visited (or linked to) route in the entire app - and for both pages and appDir setups

So let's say we have the above matcher setup from docs in middleware 
```
export const config = {
  matcher: [
    '/((?!api|_next/static|_next/image|favicon.ico).*)',
 ]
}
```

That produces regex `'^(?:\/(_next\/data\/[^/]{1,}))?(?:\/((?!api|_next\/static|_next\/image|favicon.ico).*))(.json)?[\/#\?]?$'` against which the path is matched, where in case of a undefined _basePath_ root route is `'/'`
Works as it should
Then if we need _basePath_ updated for deployment to another system this regex is slightly updated
Let's say we use `basePath: 'withbase'` in next.config.js
then the regex is `'^\/withbase(?:\/(_next\/data\/[^/]{1,}))?(?:\/((?!api|_next\/static|_next\/image|favicon.ico).*))(.json)?[\/#\?]?$'`
Unfortunately the requested/rendered path is from the server's point of view `'/withbase'` and that does not match with this regex and/or the required rule 1 of matchers "_MUST start with /_", which ultimately translates to the `'/withbase/'` as a new root route
Changing _trailingSlash_ setup has no effect on this matching

So maybe another note in the _basePath_ docs should include a warning for middleware users that matcher needs modification, which for me was

```
export const config = {
  matcher: [
    '/((?!api|_next/static|_next/image|favicon.ico).*)',
    { source: '/' },
 ]
}
```
Tested with Next.js up to 13.2.4 (React 18, node v16 and v18)

### Does the docs page already exist? Please link to it.

_No response_
Repository: godot
Issue: Godot does not display the progress bar when importing assets on Mac
Labels: bug,platform:macos,topic:editor,topic:porting

### Godot version

4.0 Stable

### System information

MacOS (latest)

### Issue description

 I tested Godot versions for Windows and Mac.
 I added a bunch of importable resources (in this case, a folder full of SVG) and had the issue, the assets are imported, but no progress bar is displayed on Mac and the software does not respond while the import process does not finishes.
 The progress bar worked fine on Windows.

### Steps to reproduce

Create a new project and:
1- drag a folder with importable resources to the project. The (re) import asset dialog does not appear.
2- close the project, add more resources to the assets tree, and open the project. The (re) import asset dialog does not appear.


### Minimal reproduction project

I just wanted to let you know that there is no need for a minimal project. This happened on any project on Mac
Repository: godot
Issue: Improve error message for attempting to use an enum name as a function in GDScript for casting (instead of `as`)
Labels: enhancement,topic:gdscript

### Godot version

4.0.stable

### System information

Fedora 37, GeForce RTX 4090 (NVIDIA 525.85.05)

### Issue description

The following C-style way to cast an integer to an enum is incorrect:

```gdscript
get_viewport().screen_space_aa = Viewport.ScreenSpaceAA(1)
```

![image](https://user-images.githubusercontent.com/180032/224789551-618ea951-a395-4423-bc21-d0f5d8ed9e0f.png)

This is the correct way to do it in GDScript:

```gdscript
get_viewport().screen_space_aa = 1 as Viewport.ScreenSpaceAA
```

However, the error message doesn't hint that you can use `as` to do this. Wrapping in `int()` works, but gives you a warning:

![image](https://user-images.githubusercontent.com/180032/224789838-0b34d837-4724-4566-8ee1-97e785da31a9.png)

Therefore, using `as` should be preferred for type safety.

The code printing this error is here: https://github.com/godotengine/godot/blob/232ee50b55ba4b045115d2a6a9be98239cbd3065/modules/gdscript/gdscript_analyzer.cpp#L3090-L3095

I'm not sure how to detect whether the callee is an enum, so I'm opening an issue.

### Steps to reproduce

- Try to use an enum name as if it was a function name for casting an integer to an enum.

### Minimal reproduction project

N/A
Repository: pytorch
Issue: Harden composable fully_shard: Checklist
Labels: oncall: distributed,triaged,module: fsdp

### 🚀 The feature, motivation and pitch

The following are features that should be checked / hardened in order to roll out fully_shard as an alternative to class-based FSDP:

[ ] Test with ShardedGradScaler 
[ ] Test clip_grad_norm support
[ ] End to end and unittest for optimizer state checkpointing
[ ] support + API for summon_full_params
[ ] able to print to debug model wrapping structure like class-based FSDP
[ ] Any integration needed with torch.distributed.checkpoint

... more to be added as uncovered.

### Alternatives

_No response_

### Additional context

_No response_

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu
Repository: deno
Issue: variables can be lost in the repl ?
Labels: repl,needs investigation

I found a weird issue in the repl

If I input the following line in the repl `import {} from "https://deno.land/x/dax@0.24.1/mod.ts"; const URL = "aze";` (as one line)

I get an error:

```
Uncaught ReferenceError: URL is not defined
    at getWasmFileUrl (https://deno.land/x/dax@0.24.1/src/lib/mod.ts:7:15)
    at https://deno.land/x/dax@0.24.1/src/lib/mod.ts:63:14
```
Repository: go
Issue: x/build/internal/installer/darwinpkg: make the darwin/amd64 installer warn the user or fail when running on arm64
Labels: Builders,NeedsInvestigation,FeatureRequest

The download website makes it easy for all macOS users, even the ones running on Apple Silicon, to download the amd64 package. This is #52487.

As described in https://github.com/golang/go/issues/52487#issuecomment-1466854907, this *mostly* works, and users can go on quite a while not realizing that they're running the Go toolchain under emulation (and producing amd64 binaries which are also running under emulation). The problems that eventually arise can be very subtle.

Besides fixing the website download links, we should consider making the amd64 installer refuse to run on arm64 chips or at least warn the user that they are not installing the correct package for their architecture.
Repository: pytorch
Issue: [FSDP] Make FSDP support local optimizer state_dict
Labels: oncall: distributed,triaged,module: fsdp

### 🚀 The feature, motivation and pitch

The current FSDP support FULL_STATE_DICT, LOCAL_STATE_DICT, and SHARDED_STATE_DICT for model state_dict. However, for optimizer state_dict, FSDP only supports FULL_STATE_DICT and SHARDED_STATE_DICT -- the local state_dict version is missing. It is hard for users to do distributed checkpoint if the returned local state_dict is not wrapped with ShadedTensor or DTensor.

**Code pointer:**
1. Add the flag for local_state_dict version for `_optim_state_dict` in _optim_utils.py:
2. Adding a conversion from tensor to ShardedTensor wrapping in 
https://github.com/pytorch/pytorch/blob/31137a63a75b40d9721544cc22843ede6b12e79d/torch/distributed/fsdp/_optim_utils.py#L1464
The subsequent logic also needs to be adjusted for local_state_dict. 


### Alternatives

_No response_

### Additional context

_No response_

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu
Repository: godot
Issue: GPUParticles3D can't plot a different mesh at the front end of a trail
Labels: discussion,topic:particles

### Godot version

4.0

### System information

Linux

### Issue description

The video in the announcement of the GPUParticles feature in [this original PR](https://github.com/godotengine/godot/pull/48242#issue-869002754) suggests it should be possible to plot an different mesh at the front end of a trail mesh. 
![image](https://user-images.githubusercontent.com/677254/224816724-bdf94c96-32a7-4572-8a08-5d92f9b3c8c2.png)

Doing the obvious thing of assigning a mesh to the second Draw Pass results in a mess of extra objects, none of which are positioned at the front end of a trail.
![image](https://user-images.githubusercontent.com/677254/224816431-1734cc3d-800c-458d-b2cd-4ae1603d9acf.png)

(I've tried a lot of the less obvious combinations as well, and none of them work either.  I found this shortcoming as I was attempting to replicate quite a nice magic tinsel particle emitted that someone did in VRChat [unity 2019].)

### Steps to reproduce

Open the [3D/Particles Demo Project](https://github.com/godotengine/godot-demo-projects/tree/master/3d/particles), go to the **Testers/GPUParticlesTrails/GPUParticles3D** node and assign a small BoxMesh to `Pass 2` of `Draw Passes`

The following warning will appear on the node:

"Trails enabled, but one or more mesh materials are either missing or not set for trails rendering."

### Minimal reproduction project

N/A
Repository: flutter
Issue: [flutter_tools] flutter update-packages --force-upgrade should write contents of synthetic pub package as a checked in manifest file
Labels: tool,P2,team-tool,triaged-tool

This could be parsed from prepare_package.dart when determining all pub packages needed by a particular version of Flutter (see 829e1048bbeaf2c5d2ad3c6eb5a991f50f47be9331fbbbb538b2ce600494bd2aR194), as well as help code reviewing changes that roll pub packages.
Repository: deno
Issue: AbortSignal for client disconnect
Labels: ext/http

I'd like to cancel processing a request from a client if a client aborts the request.
Repository: angular
Issue: Formcontrol got dereferenced after parent form passed to child component
Labels: area: forms

### Which @angular/* package(s) are the source of the bug?

forms

### Is this a regression?

Yes

### Description

I've set up the test case here https://stackblitz.com/edit/angular-8q1ikv?file=src/app/form-field-label-example.ts

I attempted to setControl on a form control and the control stopped updating after this. It seems calling setControl dereference the form control (not updating anymore in parent component) when passing the parent form reference to the child component. However, tested the same for formarray, it works fine, it seems this only happens for formcontrols directly under parent form.



### Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/angular-8q1ikv?file=src/app/form-field-label-example.ts

### Please provide the exception or error you saw

```true
FormControl stopped updating after 2 seconds, you can see that when selecting different options of the radio button.
```


### Please provide the environment you discovered this bug in (run `ng version`)

```true
Angular 15.2.2
```


### Anything else?

_No response_
Repository: TypeScript
Issue: Document behavior, gotchas, etc, for public TypeChecker API
Labels: API,Docs

A common (valid) complaint about our public API is that we don't have any documentation for what the methods do, why to use them, why not to use them, the gotchas, etc.

In more recent API PRs (like #52467 and #52473), we've added descriptions, but we should do the same for the existing methods if possible.
Repository: flutter
Issue: Support `presubmit_properties` and `postsubmit_properties` in .ci.yaml targets
Labels: team-infra,P3,triaged-infra

The `postsubmit_properties` entry is supported in the ci.yaml, and also mentioned in the CI_YAM.md doc. However, real supporting backend logic is missing. This has caused confusion.

The logic should be supported in both Cocoon scheduling and the infra ci yaml roller logic.

At the same time, we can support `presubmit_properties` as well. (see context below).

Context: https://github.com/flutter/engine/pull/40260