sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: neovim
Issue: jobstart() does not set $NVIM environment variable if /run/user/1000 is not accessible
Labels: enhancement,environment,ux,job-control,complexity:low,filesystem,platform:wsl

### Problem

# Description

This issue originated from the discussion in [this bug report](https://github.com/NeogitOrg/neogit/issues/1124) when using the plugin 'neogit'. However, I believe the root cause to be a bug in neovim itself.

The documentation states that `vim.fn.jobstart(cmd)` creates a subprocess with the appended environment variable $NVIM pointing to `v:servername` (the parent nvim instance). As far as I can tell, this works fine on native Linux and macOS. On WSL Distros, the env var appears to be unset:

# Steps to reproduce
(0. Be on WSL)

1. Start nvim with minimal config
``` 
init.lua
---
vim.fn.jobstart("tail -f /dev/null")
```

2. Use a tool like htop to figure out the PID of the child process

3. Observe environment of the given process
```
$ cat /proc/<PID>/environ | tr '\0' '\n'
```

4. $NVIM is not set

I can reproduce this with the latest neovim stable and nightly builds. Personally, I use Ubuntu WSL, but my understanding from the comments in the original (neogit) issue is that this happens on several, if not all, WSL distros.

Please let me know if I can be of further assistance in debugging this issue!



### Steps to reproduce

(0. Be on WSL)

1. Start nvim with minimal config
``` 
init.lua
---
vim.fn.jobstart("tail -f /dev/null")
```

2. Use a tool like htop to figure out the PID of the child process

3. Observe environment of the given process
```
$ cat /proc/<PID>/environ | tr '\0' '\n'
```

4. $NVIM is not set

I can reproduce this with the latest neovim stable and nightly builds. Personally, I use Ubuntu WSL, but my understanding from the comments in the original (neogit) issue is that this happens on several, if not all, WSL distros.

Please let me know if I can be of further assistance in debugging this issue!


### Expected behavior

I expect $NVIM to be set to `v:servername`

### Neovim version (nvim -v)

NVIM v0.10.0-dev-2663+gc1c6c1ee1

### Vim (not Nvim) behaves the same?

-

### Operating system/version

Ubuntu WSL

### Terminal name/version

tmux

### $TERM environment variable

screen-256color

### Installation

 system package manager
Repository: go
Issue: go/ast,go/format: newline missing between modified comment and function
Labels: NeedsInvestigation

### Go version

go version go1.21.8 darwin/arm64

but same with 1.22 and Go dev branch on playground

### What did you do?

Mutating node.Comments.List.Text produces incorrect formatting if adding newlines to /* */ style comments:

https://go.dev/play/p/IoJy719eLRt

As part of breaking too long lines, I stepped on the issue that if I cut a multi line comment that is before a function, once output back a new line between the comment and the function is missing eg
```go
/*
 * multi
 * line comment.
 */func main() {
}
```
is produced


### What did you see happen?

```go
/*
 * multi
 * line comment.
 */func main() {
```

### What did you expect to see?

```go
/*
 * multi
 * line comment.
*/
func main() {
```
Repository: kubernetes
Issue: PodEvict API does not trigger Pod deletion callback when DeleteOptions is set to metav1.NewDeleteOptions(0)
Labels: kind/support,sig/api-machinery,triage/accepted

### What happened?

当我使用client-go组件的Evict API时，发现当设置了 DeleteOptions 为 metav1.NewDeleteOptions(0) 时，无法触发mutating webhook的Pod 删除回调, 当我不设置 DeleteOptions 时，可以正常触发

代码如下:
```golang
if err := cli.CoreV1().Pods("default").Evict(context.Background(), &policy.Eviction{
		TypeMeta: metav1.TypeMeta{
			Kind:       "Pod",
			APIVersion: "v1",
		},
		ObjectMeta: metav1.ObjectMeta{
			Name:      "pod-xxx",
			Namespace: "default",
		},
		DeleteOptions: metav1.NewDeleteOptions(0),
	}); err != nil {
		glog.Fatalf(err.Error())
	}
```

mutatingwebhookconfiguration:
```yaml
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
  name: my-webhook
webhooks:
- admissionReviewVersions:
  - v1beta1
  clientConfig:
    caBundle: xxxxx
    service:
      name: my-webhook-svc
      namespace: kube-system
      path: /delete/pod
      port: 443
  failurePolicy: Ignore
  matchPolicy: Exact
  name: delete-pod-webhook.test.org
  reinvocationPolicy: Never
  rules:
  - apiGroups:
    - ""
    apiVersions:
    - v1
    operations:
    - DELETE
    resources:
    - pods
    scope: '*'
  sideEffects: Unknown
  timeoutSeconds: 30
```

### What did you expect to happen?

我期望Evict API在设置了 DeleteOptions 为 metav1.NewDeleteOptions(0) 时，能够正常触发mutatingwebhook的Pod删除回调。

### How can we reproduce it (as minimally and precisely as possible)?

1. 使用 k8s.io/client-go v0.21.2 创建一个客户端。
2. 使用 Evict API 并设置 DeleteOptions 为 metav1.NewDeleteOptions(0)。
3. 观察到mutatingwebhook的Pod删除回调没有被触发。

### Anything else we need to know?

_No response_

### Kubernetes version

<details>

```console
$ cluster version
#  v1.20.6

$ client-go version
#  v0.21.2
```

</details>


### Cloud provider

<details>
Tencent Kubernetes Engine (TKE)
</details>

### OS version

_No response_

### Install tools

_No response_

### Container runtime (CRI) and version (if applicable)

_No response_

### Related plugins (CNI, CSI, ...) and versions (if applicable)

_No response_
Repository: material-ui
Issue: [system][Box] Set image explicit image width/height attribute without it being seen as a system property
Labels: package: system,component: Box

### Steps to reproduce

Link to live example: https://codesandbox.io/p/sandbox/distracted-almeida-6lmqcs?file=%2Fsrc%2FDemo.tsx%3A6%2C7

Steps:
1. Use a Box with component="img"
2. Set width and height attributes


### Current behavior

It sets the CSS width and height properties

![image](https://github.com/mui/material-ui/assets/7151485/d7c4e681-9e9b-4e6d-92e2-5b80f8071d8c)


### Expected behavior

It should set the width and height HTML attributes

![image](https://github.com/mui/material-ui/assets/7151485/d3611d9b-a52a-45fb-9f1b-c9b641d512b8)


### Context

I am trying to add dimensions to my images to optimize [Cumulative Layout Shift](https://web.dev/articles/optimize-cls#images-without-dimensions).

I understand the way it works now is caused by the props being treated as [system properties](https://mui.com/system/properties/), but I still need a way to set the explicit HTML attributes.

### Your environment

<details>
  <summary><code>npx @mui/envinfo</code></summary>

```
  System:
    OS: Windows 11 10.0.22631
  Binaries:
    Node: 18.17.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.6.7 - C:\Program Files\nodejs\npm.CMD
    pnpm: Not Found
  Browsers:
    Chrome: Not Found
    Edge: Chromium (122.0.2365.92)
  npmPackages:
    @emotion/react: latest => 11.11.4
    @emotion/styled: latest => 11.11.0
    @mui/base:  5.0.0-beta.37
    @mui/core-downloads-tracker:  5.15.11
    @mui/icons-material: latest => 5.15.11
    @mui/lab: latest => 5.0.0-alpha.166
    @mui/material: latest => 5.15.11
    @mui/private-theming:  5.15.11
    @mui/styled-engine:  5.15.11
    @mui/system:  5.15.11
    @mui/types:  7.2.13
    @mui/utils:  5.15.11
    @types/react: latest => 18.2.61
    react: latest => 18.2.0
    react-dom: latest => 18.2.0
    typescript: latest => 5.3.3
```
</details>


**Search keywords**: explicit width height
Repository: node
Issue: Recommend `node`/`default` conditions instead of `require`/`import` as a solution to the dual package hazard
Labels: doc,good first issue

### Affected URL(s)

https://nodejs.org/api/packages.html#dual-package-hazard

### Description of the problem

Publishing packages with dual CommonJS and ESM sources, while has the benefits of supporting both CJS consumers and ESM-only platforms, is known to cause problems because Node.js might load both versions. Example:

<table><tr>
<th><code>package.json</code></th>
<th><code>foo.cjs</code></th>
<th><code>foo.mjs</code></th>
</tr>
<tr><td>

```json
{
  "name": "foo",
  "exports": {
    "require": "./foo.cjs",
    "import": "./foo.mjs"
  }
}
```

</td><td>

```js
exports.object = {};     
```

</td><td>

```js
export const object = {};     
```

</td></tr></table>
<table><tr>
<th><code>package.json</code></th>
<th><code>bar.js</code></th>
</tr>
<tr><td>

```json
{
  "name": "bar",
  "main": "./bar.js"
}
```

</td><td>

```js
const foo = require("foo");
exports.object = foo.object;     
```

</td></tr></table>

```js
// my app

import { object as fooObj } from "foo";
import { object as barObj } from "bar";

console.log(fooObj === barObj); // false?????
```

The two suggested solutions boil down to "even when you have an ESM entrypoint, still use only CJS internallly". This solves the dual package hazard, but completely defeats the cross-platform benefits of dual modules.

If `foo` instead used these export conditions:
```json
{
  "name": "foo",
  "exports": {
    "node": "./foo.cjs",
    "default": "./foo.mjs"
  }
}
```

Then:
- there would be no dual-package hazard in Node.js, because it only ever loads the CommonJS version
- there would be no dual-package hazard in bundlers, because they would only ever load either the `node` version (if they are configured to target Node.js) or the `default` version (if they are configured to target other platforms).
- the package solves the dual-package hazard while still providing an ESM-only version

We have been using this `node/default` pattern in `@babel/runtime` for a couple years, because we wanted to provide an ESM-only version for browsers while still avoiding the dual-package hazard (`@babel/runtime` is _mostly_ stateless, but `@babel/runtime/helpers/temporalUndefined` relies on object identity of an object defined in a separate file).
Repository: storybook
Issue: [Bug]: `react-docgen` not correctly populating Description column if props are `Readonly`
Labels: bug,react,has workaround,docgen

### Describe the bug

After the latest major update, which brings the new autodocs package `react-docgen`, the doc table of all of my stories is missing pieces of information. Before it was populating the Description column with the JSDocs of component's props' interface:

```ts
interface Props {
  /**
   * Id used to compose ids of sub-components
   */
  id: string;
  /**
   * Name of the document
   */
  docName?: string;
  /**
   * Direct link to the resource
   */
  link: string;
  /**
   * Controls whether the responsive version is shown
   */
  isUnderBreakpoint?: boolean;
  /**
   * Controls whether the buttons are disabled
   */
  disabled?: boolean;
}
```

Resulted in:

<img width="1040" alt="image" src="https://github.com/storybookjs/storybook/assets/35468654/1792d900-d93a-4df4-b5ad-ec16c443b56b">

After the update it looks like this:

<img width="1056" alt="image" src="https://github.com/storybookjs/storybook/assets/35468654/e645eef0-dd5b-4899-9e9e-a4ba62ed6603">

As you can see the text I wrote in the JSDocs is missing and the type of the two props with a default is not correctly inferred.

While trying to create a repro I discovered that the issue lies in the use of utility type `Readonly<T>`. You can open the repro and see docs for Button are badly generated. Remove `Readonly` and restart sb, you'll see they'll be correctly generated.
As a workaround I switched to the old `react-docgen-typescript` which is handling `Readonly` correctly.



### To Reproduce

https://stackblitz.com/edit/github-inlxfv?file=src%2Fstories%2FButton.tsx

### System

```bash
Storybook Environment Info:

  System:
    OS: macOS 14.4
    CPU: (8) arm64 Apple M2
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    Yarn: 4.1.1 - ~/.nvm/versions/node/v20.11.1/bin/yarn <----- active
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
  Browsers:
    Safari: 17.4
  npmPackages:
    @storybook/addon-essentials: 8.0.2 => 8.0.2 
    @storybook/addon-interactions: 8.0.2 => 8.0.2 
    @storybook/addon-links: 8.0.2 => 8.0.2 
    @storybook/addon-mdx-gfm: 8.0.2 => 8.0.2 
    @storybook/preview-api: 8.0.2 => 8.0.2 
    @storybook/react: 8.0.2 => 8.0.2 
    @storybook/react-vite: 8.0.2 => 8.0.2 
    msw-storybook-addon: 2.0.0-beta.1 => 2.0.0-beta.1 
    storybook: 8.0.2 => 8.0.2
```


### Additional context

_No response_
Repository: rust
Issue: u64::saturating_div is useless
Labels: T-libs-api,C-discussion

`pub const fn saturating_div(self, rhs: u64) -> u64`

> This function will panic if rhs is 0.

This makes no sense.  The *only* way that `u64 / u64` could overfllow is if `rhs = 0`.

The same is true for the other unsigned integer types.  The signed types have the excuse that they wouldn't know whether to count division by zero as saturating to -ve or +ve maximum.
Repository: storybook
Issue: [Bug]: Webcomponents with no render function shows empty source code in Canvas
Labels: bug,needs triage

### Describe the bug

Using a webcomponent renderer, the source code on Canvas/Source block is not correctly generated.
The component is correctly rendered but the source code only shows an empty html element.

### To Reproduce

Create a webcomponent story with `component` and `args` without custom render.

https://stackblitz.com/edit/github-mqfend?file=src%2Fstories%2Fmy-element.stories.ts

```ts
export default {
  component: 'my-element',
  title: 'My Element',
} as Meta;

export const Default: StoryObj = {
  name: 'Default',
  args: {
    name: 'Lit',
  },
};
```

It shows this has source code
```html
<my-element></my-element>
```

The expected is 
```html
<my-element name="Lit"></my-element>
```

### System

```bash
Storybook Environment Info:

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm <----- active
    pnpm: 8.15.3 - /usr/local/bin/pnpm
  npmPackages:
    @storybook/addon-essentials: ^8.1.0-alpha.3 => 8.1.0-alpha.3 
    @storybook/addon-links: ^8.1.0-alpha.3 => 8.1.0-alpha.3 
    @storybook/blocks: ^8.1.0-alpha.3 => 8.1.0-alpha.3 
    @storybook/test: ^8.1.0-alpha.3 => 8.1.0-alpha.3 
    @storybook/web-components: ^8.1.0-alpha.3 => 8.1.0-alpha.3 
    @storybook/web-components-vite: ^8.1.0-alpha.3 => 8.1.0-alpha.3 
    storybook: ^8.1.0-alpha.3 => 8.1.0-alpha.3
```


### Additional context

The actual DOM node inserted inside the story block returns the right outerHTML 
![image](https://github.com/storybookjs/storybook/assets/137285/1aab3149-4a29-4e67-b5a8-c5b77ac18af9)
```
$0.outerHTML
'<my-element name="Lit"></my-element>'
```
Repository: flutter
Issue: [HTML renderer] size computed in `performLayout` is different than `computeDryLayout` in some cases
Labels: a: tests,framework,platform-web,e: web_html,P3,team-web,triaged-web

### Steps to reproduce

This appeared to be an issue https://github.com/flutter/flutter/pull/143932 after https://github.com/flutter/flutter/pull/144577.

Unfortunately, some reason the same tests don't reproduce the issue outside Flutter source code.

### Actual results

Test fails
Repository: terminal
Issue: Enhanced Tab Visibility: A Desire for Multiline Tabs in Terminal
Labels: Issue-Feature,Help Wanted,Needs-Tag-Fix,External-Blocked-WinUI3

# Description of the new feature/enhancement

I prefer being able to see all the tabs I have opened at a glance, rather than just a few displayed while the rest are hidden.

In VSCode, there is support for multiline tabs, and I expect the terminal to have a similar feature, but I haven't been able to find it.

# Proposed technical implementation details (optional)

Adding Optional Settings: Such as Multiline Tabs

<img width="711" alt="image" src="https://github.com/microsoft/terminal/assets/62206110/d51a0a7a-d261-42e2-bb54-32ec5b938dcc">
Repository: PowerToys
Issue: [Peek] Support for GrahPad, ChemDRAW, NMR
Labels: Idea-Enhancement,Needs-Triage,Product-Peek

### Description of the new feature / enhancement

The type of files that Peek can preview is very limited. For example, for the scientific research community it would be very useful if  Peek could also preview files from GrahPad, ChemDRAW, NMR (mnova file), among others.

### Scenario when this would be used?

Peek should be a quick and easy way to preview files on a Windows, which try to do the same thing as the Preview on MacOS (very very useful feature). However, as can be seen, there is almost no difference between Peek and the preview panel that we can already see on Windows, since the type of program thhat can be preview is almost the same.

### Supporting information

_No response_
Repository: ui
Issue: [Bug]: Progress bar not working for max prop value greater than 100
Labels: bug

### Describe the bug

The progress bar has a max prop that accepts a number and a value prop which also accepts a number. However, the current implementation does not support a max prop value greater than 100.

### Affected component/components

Progress

### How to reproduce

In the Progress component add `max` prop value greater than 100 and see the magic.

### Codesandbox/StackBlitz link

_No response_

### Logs

_No response_

### System Info

```bash
Every browser
```


### Before submitting

- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues
Repository: next.js
Issue: [QUIC protocol] To use middleware you must provide a hostname and port to the Next.js Server 
Labels: bug,Runtime

### Link to the code that reproduces this issue

https://github.com/Innei/next-env-symbol-reproduction

### To Reproduce

1. Next version next@14.1.4
2. Write a middleware
3. then call quic://<next-app-domain>/path

In prod case:

If the cdn enables QUIC protocol, and the cdn is sent back to the server. and the protocol is QUIC

The standalone server will throw an error, and return back a 500 response.

The server error `Error: To use middleware you must provide a hostnameandport to the Next.js Server`

I found the CDN source URL is  `quic://0.0.0.0:2323/favicon.ico?__nextDefaultLocale=` like this. But here's what the source code says

```ts
   if (!url.startsWith("http")) {
            throw new Error("To use middleware you must provide a `hostname` and `port` to the Next.js Server");
        }
```

So the QUIC protocol is not allowed to access next server



### Current vs. Expected behavior

Got error, expected not throw

### Provide environment information

```bash
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 23.4.0: Wed Feb 21 21:45:49 PST 2024; root:xnu-10063.101.15~2/RELEASE_ARM64_T6020
Binaries:
  Node: 20.8.1
  npm: 10.2.4
  Yarn: 1.22.21
  pnpm: 8.15.4
Relevant Packages:
  next: 14.1.4
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.4.3
Next.js Config:
  output: standalone
```


### Which area(s) are affected? (Select all that apply)

Middleware / Edge (API routes, runtime)

### Which stage(s) are affected? (Select all that apply)

next start (local), Other (Deployed)

### Additional context

_No response_
Repository: ollama
Issue: gemma accuracy down from 0.128 to 0.129
Labels: bug,question

### What is the issue?

Prompts that were producing the correct results are now producing different (false) outputs

### What did you expect to see?

Corretly formatted yaml with correct inputs based on custgom promt

-> Got a yaml with indentation issues and missing fields with wrong structure even though there are json schemas provided

Note that this has also happened on my collegue's pc as well as on a Remote Machine

### Steps to reproduce

Upgrade ollama using linux download command provided in website

ollama run gemma


After I rm the model then pull it becomes better for a bit then it get's worse after a while

### Are there any recent changes that introduced the issue?

Version Upgrade to 0.129

### OS

Linux

### Architecture

_No response_

### Platform

WSL2

### Ollama version

0.1.29

### GPU

Nvidia

### GPU info

Quadro P1000

### CPU

Intel

### Other software

Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz   2.59 GHz
Repository: yt-dlp
Issue: Proko.com
Labels: site-request,triage

### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field

### Checklist

- [X] I'm reporting a new site support request
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
- [X] I've checked that none of provided URLs [violate any copyrights](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#is-the-website-primarily-used-for-piracy) or contain any [DRM](https://en.wikipedia.org/wiki/Digital_rights_management) to the best of my knowledge
- [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)
- [X] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and am willing to share it if required

### Region

Finland

### Example URLs

https://www.proko.com/course/drawing-basics/overview


### Provide a description that is worded well enough to be understood

Site contains drawing lessons and more. They have free courses (and paid courses, too).
Please add an option to download them so people can enjoy them on other devices w/o internet access/offline.

### Provide verbose output that clearly demonstrates the problem

- [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [X] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below

### Complete Verbose Output

```shell
Microsoft Windows [Version 10.0.19045.4046]
(c) Microsoft Corporation. All rights reserved.

X:\>yt-dlp -vU
[debug] Command-line config: ['-vU']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version stable@2024.03.10 from yt-dlp/yt-dlp [615a84447] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
```