sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: rust
Issue: `refining_impl_trait` only fires on public traits
Labels: A-lints,A-trait-system,T-lang,F-return_position_impl_trait_in_trait,F-refine

The `refining_impl_trait` lint only fires for public traits. It does not fire without the `pub` keyword in the code sample below:

```rust
pub trait Foo {
//^ Required for lint to fire
    fn foo(self) -> impl Debug;
}

impl Foo for u32 {
    fn foo(self) -> String {
//                  ^^^^^^
//  warning: impl trait in impl method signature does not match trait method signature
        self.to_string()
    }
}
```

### Difference from `async_fn_in_trait` lint

Apparently I was part of the discussion of this at one point (see also the [zulip topic](https://rust-lang.zulipchat.com/#narrow/stream/315482-t-compiler.2Fetc.2Fopaque-types/topic/refining_impl_trait.20only.20on.20public.20traits) on this). I think it got lumped together with the discussion about the lint for `async fn` in traits, though, when there are some important distinctions:

* The `async fn` lint is only temporary to help avoid footguns created by missing language features, and we want to make non-footgunny uses more convenient.
* Refinement is a mechanism that will always exist and is fundamental to trait implementations.
* Refinement's ability to "punch through" abstraction boundaries can happen accidentally, even within a crate.

The second point is important, because as a user I would expect such a fundamental mechanism to behave independently of whether the trait happens to be crate-public or not. This can lead to false expectations being created about the behavior in the other case.

### Violating abstraction boundaries within a crate

As an example of the last point, let's say I as a user want to define a trait that my type implements ahead of actually generalizing my code:

```rust
trait Application {
    fn windows(&self) -> Vec<impl Window>;
}
trait Window {
    fn title(&self) -> Option<String>;
}

struct App;
struct Win;

impl Application for App {
    fn windows(&self) -> Vec<Win> { todo!() }
}
impl Window for Win {
    fn title(&self) -> Option<String> { todo!() }
}

fn all_windows(apps: &[App]) -> Vec<Win> {
    apps.iter().map(|a| a.windows()).flatten().collect()
}
```

Later on, I want to write a test for `all_windows`. But in order to do that, I have to change it to accept `impl Application`, which requires changing the output type to `impl Window + '_`, and possibly changing all the users of `all_windows` as well. This can get unwieldy quick.

We can say that the user should have used `impl Trait` from the beginning, but that might be inconvenient when prototyping. If they are leaning on traits to provide the outlines of an abstraction boundary, we should let them opt in before punching through said boundary, IMO.

cc @compiler-errors
Repository: kubernetes
Issue: Remove duplicate images used in e2e tests
Labels: kind/bug,priority/backlog,kind/cleanup,sig/storage,sig/node,sig/testing,sig/cloud-provider,triage/accepted

We have the following sets of images used in e2e tests, can we try to eliminate duplication?

(context: see https://github.com/kubernetes/kubernetes/pull/122565/files#diff-de4c32013b42db23b321a084234ce02f9671a8cd99875387d7d6a41ca1aad069)

In general, we should find the references of the older image and switch it to the newer version, unless there is a specific reason both versions of images are needed/used in the test harness.

References are here:
https://cs.k8s.io/?q=(gcp-compute-persistent-disk-csi-driver%7Cbusybox%7Ccuda-vector-add%7Chttpd%7Cnginx%7Ccsi-snapshotter%7Chostpathplugin)&i=nope&files=test%2F&excludeFiles=&repos=kubernetes/kubernetes

- [ ] gcp-compute-persistent-disk-csi-driver
  - registry.k8s.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver:v1.2.2
  - registry.k8s.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver:v1.4.0

- [ ] busybox
  - registry.k8s.io/e2e-test-images/busybox:1.29-2
  - registry.k8s.io/e2e-test-images/busybox:1.36.1-1

- [ ] cuda-vector-add
  - registry.k8s.io/e2e-test-images/cuda-vector-add:1.0
  - registry.k8s.io/e2e-test-images/cuda-vector-add:2.3

- [ ] httpd
  - registry.k8s.io/e2e-test-images/httpd:2.4.38-4
  - registry.k8s.io/e2e-test-images/httpd:2.4.39-4

- [ ] nginx
  - registry.k8s.io/e2e-test-images/nginx:1.14-4
  - registry.k8s.io/e2e-test-images/nginx:1.15-4

- [ ] csi-snapshotter
  - registry.k8s.io/sig-storage/csi-snapshotter:v5.0.1
  - registry.k8s.io/sig-storage/csi-snapshotter:v6.1.0

- [ ] hostpathplugin
  - registry.k8s.io/sig-storage/hostpathplugin:v1.11.0
  - registry.k8s.io/sig-storage/hostpathplugin:v1.9.0
Repository: deno
Issue: lsp_jsx_import_source_config_file_automatic_cache is flaky
Labels: flaky

Seems it hangs.

https://github.com/denoland/deno/actions/runs/7391702662/job/20108960669

Also hanged on a PR I opened.
Repository: PowerToys
Issue: Two Primary Mouse Button [Right] Options on computers connected through Mouse Without Borders act as double negative, causing apparent [Left] behavior in remote computer.
Labels: Issue-Bug,Needs-Team-Response,Product-Mouse Without Borders

### Microsoft PowerToys version

0.76.2

### Installation method

GitHub

### Running as admin

None

### Area(s) with issue?

Mouse Without Borders

### Steps to reproduce

With two windows machines, set the [Primary Mouse Button] option under windows's mouse settings to [Right] on both machines, then link the machines using Mouse Without Borders.

### ✔️ Expected Behavior

The mouse's primary button on both machines should be [Right] with its secondary button being [Left], matching those computer's settings.

### ❌ Actual Behavior

The mouse's primary button on the host machine is [Right] with its secondary button being [Left], as expected; but on the remote machine, the mouse's primary and secondary buttons are reversed relative to the expectation: 

The primary button is the [Left] button and the secondary button is the [Right] button.

### Other Software

If relevant one of my machines is running windows 10, and the other is running windows 11.
_No response_
Repository: node
Issue: ExperimentalWarning: Importing JSON modules
Labels: experimental,esm,loaders

### Version

20.9.0 & 20.10.0

### Platform

Darwin foobar.local 22.6.0 Darwin Kernel Version 22.6.0: Thu Nov  2 07:43:57 PDT 2023; root:xnu-8796.141.3.701.17~6/RELEASE_ARM64_T6000 arm64

### Subsystem

_No response_

### What steps will reproduce the bug?

1. Clone repo https://github.com/webdevnerdstuff/vuetify-drilldown-table/tree/dev
2. `git checkout dev`
3. `pnpm i`
4. `npx cross-env NODE_OPTIONS="--trace-warnings" pnpm test:dev` (same result with `npm run test:dev`)
5. Notice the console is throwing a warning that seems unrelated to the actual code in the project.

### How often does it reproduce? Is there a required condition?

Every time you run a package script it's throwing this warning in the console. 

### What is the expected behavior? Why is that the expected behavior?

It should not be throwing a warning if there is nothing that is being used in that warning. As it seems the trace shows the warnings coming from `node:internal`.

### What do you see instead?

```
(node:12542) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
    at emitExperimentalWarning (node:internal/util:275:11)
    at ModuleLoader.jsonStrategy (node:internal/modules/esm/translators:453:3)
    at callTranslator (node:internal/modules/esm/loader:285:14)
    at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:291:30)
```

### Additional information

There are places in the code where I am importing a json file, but I also tested by removing all of those imports, and the output of the warning is the same. So I'm not sure where and/or why it's throwing this warning. Is this a false positive?
Repository: next.js
Issue: Antd doesn't work
Labels: bug,Module Resolution

### Link to the code that reproduces this issue

https://github.com/xiaoqufengdi/mortgageCalculator.git

### To Reproduce

1、 add 'antd' into my project.
2、 I use a component of antd such as Layout 
3、 It's report a bug.




### Current vs. Expected behavior

It's doesn't work.
Internal error: Error: Could not find the module "~\node_modules\.store\antd@5.12.7\node_modules\antd\es\index.js#Layout#Footer" in the
 React Client Manifest. This is probably a bug in the React Server Components bundler.


### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
window 10
node 19.3.0
npm   9.4.1
// package.json
"antd": "^5.12.7",
"next": "14.0.4",
"react": "^18",
"react-dom": "^18"
```


### Which area(s) are affected? (Select all that apply)

Module resolution (CJS / ESM, module resolving)

### Which stage(s) are affected? (Select all that apply)

next dev (local)

### Additional context

_No response_
Repository: flutter
Issue: [Multi view] Allow runner app to pass initial data to a view
Labels: c: new feature,c: proposal,P3,a: multi window,team-framework,triaged-framework

### Use case

when create multi-view, in flutter side ,it needs to get the initData to know what to display, or which to display;
there is such mechanism in web https://github.com/flutter/engine/pull/49320, I think desktop also need it; @goderbauer

### Proposal

some thing as https://github.com/flutter/engine/pull/49320
Repository: neovim
Issue: Buffer options not when opening a file
Labels: bug-vim,netrw

### Problem

I've been banging my head against this for a few hours.  Figured i'd ask

Here is a small reproduction: https://github.com/eanyanwu/neovim-bug
Its a single `init.lua` file that creates a buffer and set some buffer local options

Here are the contents of the file for posterity:

```
local gb = vim.api.nvim_create_buf(false, false)
vim.api.nvim_buf_set_option(gb, "buftype", "nofile")
vim.api.nvim_buf_set_option(gb, "filetype", "alist")
vim.api.nvim_buf_set_option(gb, "modeline", false)
print(gb)
```


Open neovim like this: `nvim -u neovim-bug/init.lua .` (note the period at the end)


### Steps to reproduce

git clone https://github.com/eanyanwu/neovim-bug.git
nvim -u neovim-bug/init.lua .
:set filetype?
:set buftype?

### Expected behavior

I would expect that the newly created buffer should have the options that it set.

If i go to it using `buffer <id>`, then type `set filetype?`, i expect that to be "alist". But it is empty. Same for `set buftype?`

The odd thing is that if I just do `nvim -u neovim-bug/init.lua` instead (without the period) ... i get the results i'd expect.

Am i missing something obvious?

### Neovim version (nvim -v)

NVIM v0.9.5

### Vim (not Nvim) behaves the same?

Not sure. I don't know enough vimscript XD

### Operating system/version

Arch Linux

### Terminal name/version

wezterm

### $TERM environment variable

xterm-256color

### Installation

Archlinux official package
Repository: excalidraw
Issue: `convertToExcalidrawElements()` frame position not positioned as expected.
Labels: bug

When I try to insert frames into the scene, all the frames are positioned at the same position, even though I feed the frames an X and Y coordinate.

```tsx
<Excalidraw
  theme="dark"
  excalidrawAPI={(api) => setApi(api)}
  initialData={{
    elements: convertToExcalidrawElements([
      {
        id: "frame-1",
        type: "frame",
        children: [],
        name: "Frame #1",
        x: 0,
        y: 0,
        width: 1440,
        height: 810,
      },
      {
        id: "frame-1.1",
        type: "frame",
        children: [],
        name: "Frame #1.1",
        x: 0,
        y: 830,
        width: 1440,
        height: 810,
      },
      {
        id: "frame-2",
        type: "frame",
        children: [],
        name: "Frame #2",
        x: 1460,
        y: 0,
        width: 1440,
        height: 810,
      },
    ]),
  }}
/>
```
Repository: pytorch
Issue: `aten.upsample_nearest2d.vec` is in core ATen IR and should not be decomposed
Labels: triaged,onnx-needs-info,oncall: pt2,module: decompositions,oncall: export

### 🐛 Describe the bug

`aten.upsample_nearest2d.vec` is part of the Aten core IR (https://pytorch.org/docs/main/torch.compiler_ir.html). But it also appears in the decomposition and registered with "CompositeImplicitAutograd" key at here https://github.com/pytorch/pytorch/blob/3fe437b24ba70e0ac7af8b6664c66875cf91731b/torch/_decomp/decompositions.py#L2437.

This would break some backend compiler that expects `aten.upsample_nearest2d.vec` to be in the FX IR and has rules to work on it.

### Versions

PyTorch mainline version: 3fe437b24ba70e0ac7af8b6664c66875cf91731b

cc @ezyang @msaroufim @wconstab @bdhirsh @anijain2305 @zou3519 @SherlockNoMad @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4
Repository: godot
Issue: Changing mouse mode to confined from a tool script while in the editor makes the mouse unusable.
Labels: bug,topic:editor,topic:input

### Tested versions

- 4.2 stable, 4.1 stable.

### System information

Linux - Godot v4.2.stable.official [46dc27791]

### Issue description

Like the title says. I had set my mouse mode to `Input.MOUSE_MODE_CONFINED` in `ready()` within a tool script. Closing then reopening the project confined my mouse and hid it. Additionally, this only happens when the tool script is also attached to a node in the currently open scene. Using the mouse when this happens is completely impossible.

### Steps to reproduce

Create a new node in the currently open scene, attach a script and add the following lines.

```gdscript
@tool
extends Node

func ready():
	Input.mouse_mode = Input.MOUSE_MODE_CONFINED
```

Then reload project.

### Minimal reproduction project (MRP)

[confined_mouse_in_editor.zip](https://github.com/godotengine/godot/files/13816414/confined_mouse_in_editor.zip)
Repository: transformers
Issue: Allow gradient for generate()
Labels: Feature request

### Feature request

The generate function is decorated with @torch.no_grad() and thus can't be used for model training. It would be better to make calculating gradients optional, rather than impossible, so that the function can be used for tuning. The simplest solution is to remove the decorator altogether, as users can set no_grad themselves before calling if they need to. Are there reasons to disable such usage?

### Motivation

Allow using generate for tuning

### Your contribution

Removing the decorator is a very simple change. I can submit a PR
Repository: flutter
Issue: When using Container with ClipRRect, there are small gaps at the all four corners.
Labels: framework,d: api docs,has reproducible steps,P2,team-framework,triaged-framework,found in release: 3.16,found in release: 3.18

### Steps to reproduce

This issue is easy to reproduce.

### Expected results

The UI elements should have no gaps at the corners.

### Actual results

There are small gaps at the all four corners.

### Code sample

<details open><summary>Code sample</summary>

```dart
class Demo extends StatelessWidget {
  const Demo({super.key});

  @override
  Widget build(BuildContext context) {
    return Container(
      width: 206,
      height: 106,
      decoration: BoxDecoration(
        border: Border.all(color: Colors.red, width: 3.0),
        borderRadius: const BorderRadius.all(Radius.circular(20.0)),
      ),
      child: const ClipRRect(
        borderRadius: BorderRadius.all(Radius.circular(20.0)),
        child: ColoredBox(
          color: Colors.blue,
        ),
      ),
    );
  }
}
```

</details>


### Screenshots or Video

<details open>
<summary>Screenshots / Video demonstration</summary>

![Screenshot_20240103_160349](https://github.com/flutter/flutter/assets/25474810/fe241aa6-bcf9-42c5-bf9e-5311967b6ada)

</details>



### Logs

<details open><summary>Logs</summary>

```console
[Paste your logs here]
```

</details>


### Flutter Doctor output

<details open><summary>Doctor output</summary>

```console
 Flutter (Channel stable, 3.16.3, on macOS 13.2.1 22D68 darwin-x64, locale zh-Hans-CN)
    • Flutter version 3.16.3 on channel stable at /Users/mafanwei/fvm/versions/3.16.3
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b0366e0a3f (4 周前), 2023-12-05 19:46:39 -0800
    • Engine revision 54a7145303
    • Dart version 3.2.3
    • DevTools version 2.28.4

```

</details>
Repository: godot
Issue: Rename main node no change in the linked scene
Labels: discussion,topic:editor

### Tested versions

Godot v4.2.1.stable.mono.official (Forward+)

### System information

Windows 10 - Godot v4.2.1.stable.mono.official (Forward+)

### Issue description

Recognised only for control nodes. Do not know whether this is also the case for other nodes.
If you rename the main node in a scene and this scene is already linked in another scene. Then the new name is not adopted in the linking of the scene.

All changes to the child nodes are transferred in the linked scene.

**Idea**
If this is not desired. The system will not ask you whether you want to keep the old name or whether you want to update the name.
Perhaps it would be good to leave the choice to the developer. Update the name or keep the old one? The system starts a query or can even specify this in the settings - accept directly or ask beforehand.

### Steps to reproduce

1. Build a scene A as main node control with child nodes. Link this scene A to a scene B.
2. Change the name of the main node to scene A.
3. Save the scene A
4. Result: The main node of the linked scene A has not been renamed in scene B.

### Minimal reproduction project (MRP)

N/A
Repository: PowerToys
Issue: Keyboard Manager don't worked when reboot PC
Labels: Issue-Bug,Needs-Triage

### Microsoft PowerToys version

0.76.2

### Installation method

PowerToys auto-update

### Running as admin

Yes

### Area(s) with issue?

Keyboard Manager

### Steps to reproduce

I set Alt+W ->Ctrl+W in KM, and after setting it, the Edge tab can be closed normally.

1. My computer hasn't restarted for several days, and it worked normally before restarting.
2. Restart my computer (PowerToys will automatically start after restarting)
3. Open Edge and open multiple tab pages, try using Alt+W to close the tab page, but it's not working.

### ✔️ Expected Behavior

Close tab page normally

### ❌ Actual Behavior

no effect

### Other Software

_No response_
Repository: stable-diffusion-webui
Issue: [Bug]: 通过 API 生成的批量图像不会创建网格
Labels: bug-report

### Checklist

- [ ] The issue exists after disabling all extensions
- [x] The issue exists on a clean installation of webui
- [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
- [x] The issue exists in the current version of the webui
- [ ] The issue has not been reported before recently
- [ ] The issue has been reported before but has not been fixed yet

### What happened?

Batch images generated through the API do not create a grid
After batch_size=4 is set, no grid diagram is returned via api request
However, there is a grid diagram return on the webui
Parameter passing error or design

### Steps to reproduce the problem

![1704275435657](https://github.com/AUTOMATIC1111/stable-diffusion-webui/assets/23790100/b383c817-de73-4e2b-ad9c-08f2046f7968)


### What should have happened?

After batch_size=4 is set, no grid diagram is returned via api request
However, there is a grid diagram return on the webui

### What browsers do you use to access the UI ?

_No response_

### Sysinfo

none

### Console logs

```Shell
none
```


### Additional information

none
![1704275435657](https://github.com/AUTOMATIC1111/stable-diffusion-webui/assets/23790100/350ce466-d344-4344-ac2b-6c6b2bbc512f)
Repository: next.js
Issue: Next/Image is not getting copied in static media
Labels: bug,Image (next/image)

### Link to the code that reproduces this issue

https://github.com/algodomain/nextjs-image-issue

### To Reproduce

Use the public folder and copy any image under img folder

```
root
|_ public
       |_ img
             |_ test-img.png
```

inside your component 

`
              <Image src="/img/test-img.png" alt="Image" width="900" height="600" />
`

When I run the build, it creates a folder as `.next/static/media` but test-img.png (or test-img.[random_num].png file is missing
`
npm run build
`

So that you know, these files are being copied if we refer to the image via CSS file, which is strange behaviour.

```background-image: url ('../img/test-img.png')
// notice ../ before the url
```

Also note that if you use inline css via your nextjs server component, the image is again missing 
```
style={{ backgroundImage: 'url(/img/test-img.png)' }}
//or
style={{ backgroundImage: 'url(../img/test-img.png)' }}
```

However, when I deploy the public folder in my server, these images are getting served, therefore I believe this is indeed a bug and must be fixed, why images are not being copied when we are using <Image> component of nextjs.  




### Current vs. Expected behavior

Image must be copied inside `.next/static/media` directory which is not the case when using <Image> but being copied when referenced from css file (added in rootLayout) (but not inline css)

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 23.2.0: Wed Nov 15 21:55:06 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6020
Binaries:
  Node: 20.10.0
  npm: 10.2.3
  Yarn: 1.22.21
  pnpm: N/A
Relevant Packages:
  next: 14.0.4
  eslint-config-next: 14.0.4
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.3.3
Next.js Config:
  output: standalone
```


### Which area(s) are affected? (Select all that apply)

App Router, Image optimization (next/image, next/legacy/image)

### Which stage(s) are affected? (Select all that apply)

next build (local)

### Additional context

_No response_
Repository: pytorch
Issue: torch.distributed doesn't have is_nccl_available() as the documentation suggests
Labels: oncall: distributed,triaged

### 🐛 Describe the bug

This script fails:
```
import torch.distributed as td

print(f'is_nccl_available={td.is_nccl_available()}')
```
```
Traceback (most recent call last):
  File "/usr/ports/misc/py-monai/x.py", line 5, in <module>
    print(f'is_nccl_available={td.is_nccl_available()}')
AttributeError: module 'torch.distributed' has no attribute 'is_nccl_available'
```

The documentation suggests [here](https://pytorch.org/docs/stable/distributed.html) that this function should exist.


### Versions

pytorch-2.1.2
FreeBSD 14.0

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225