sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: svelte
Issue: [AST] Incorrect parsing of comments inside the callback scope
Labels: feature request

### Describe the bug

Sorry in advance, but I might be bringing a PITA with comments, again.

I noticed while working on updating `svelte-ast-print`, I've had inline snapshots mismatch _(thanks Vitest!)_.
There was a bug which I've overlooked before and noticed that something was off. I was able to narrow that there's a parsing difference between version `svelte@5.0.0-next.190` and `svelte@5.0.0-next.191`. Regardless, both versions parse it wrongly, including the latest one.

Possibly related PR: https://github.com/sveltejs/svelte/pull/12471

Piece of input inside the `<script>` tag that gets parsed wrong:

```js
beforeUpdate(() => {
  // determine whether we should auto-scroll
  // once the DOM is updated...
});

afterUpdate(() => {
  // ...the DOM is now in sync with the data
});
```


<table>
<thead>
    <tr>
      <th>

`svelte@5.0.0-next.190`
</th>
      <th>

`svelte@5.0.0-next.191`

</th>
    </tr>
</thead>
<tbody>
<tr>
<td>

```diff
-       beforeUpdate(() => {
-               // determine whether we should auto-scroll
+       beforeUpdate(() => {}); // determine whether we should auto-scroll
-               // once the DOM is updated...
+       // once the DOM is updated...
-       });
-
-       afterUpdate(() => {
-               // ...the DOM is now in sync with the data
-       });
+       afterUpdate(() => {}); // ...the DOM is now in sync with the data
```

</td>

<td>

```diff
-       beforeUpdate(() => {
+       beforeUpdate(() => {});
-               // determine whether we should auto-scroll
+       // determine whether we should auto-scroll
-               // once the DOM is updated...
+       // once the DOM is updated...
-       });
-
-       afterUpdate(() => {
+       afterUpdate(() => {});
+
-               // ...the DOM is now in sync with the data
+       // ...the DOM is now in sync with the data
-       });
-
```

</td>
</tr>
</tbody>
<table>

Below I will provide a simple reproduction where you can see that the comment inside the callback scope of `beforeUpdate()` gets wrongly parsed as `trailingComments`.

### Reproduction

https://svelte-5-preview.vercel.app/#H4sIAAAAAAAAE02OywrCMBBFf2WYTS0Uum-14D_oyriIyZQG8yIzFaT03yUI4vIezoG74ew8MQ63DaMOhAOec8YO5Z3r4Bd5IeyQ01pMJUc2xWWZVFTiQk5FYIMHzanQNVstBDvMJQVovm0zqljdf-VwaOE0wVa5kr6Hy-IYTAqBogAvafUWWPQbXGRnCYz2_qHNE9ikTDXb21HFY_87gx2GZN3syOIgZaX9vn8AcUwca90AAAA=

### Logs

_No response_

### System Info

```shell
next
```


### Severity

annoyance
Repository: ui
Issue: [feat]: Conform support for forms
Labels: area: request

### Feature description

It would be nice if there's a [Conform](https://conform.guide) version of `<Form />` alongside with the current react-hook-form one.

### Affected component/components

Form

### Additional Context

Additional details here...

### Before submitting

- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs
Repository: ollama
Issue: stella_en_400M_v5  model request
Labels: model request

Need help supporting
https://hf.rst.im/dunzhang/stella_en_400M_v5

since we have also https://ollama.com/Losspost/stella_en_1.5b_v5
Repository: vscode
Issue: Show raw json sync file doesn't open the file
Labels: bug,settings-sync

While trying to investigate why a sync happened:

![Recording 2024-08-27 at 08 35 26](https://github.com/user-attachments/assets/fded94b1-78f9-4c02-9cc6-5da1a4f4ed9b)
Repository: vscode
Issue: Imported file has a sha in the path
Labels: bug,typescript,javascript,web

Testing #226653

* open https://insiders.vscode.dev/github/microsoft/vscode-anycode/blob/main/anycode/client/src/node/main.ts#L7
* cmd+click on CommonLanguageClient from the imports
* observe complex URL



![Image](https://github.com/user-attachments/assets/db3e9bbe-ec89-4178-90c9-02b3515743a9)
Repository: deno
Issue: deno cache returns 133 error
Labels: needs info

Version: Deno 1.46.1

The `deno cache` command returns an error code of 133 when run with Deno 1.46.1 on my Macbook Pro (M2).

For instance, running this...

`deno cache --node-modules-dir=false --unstable-worker-options --unstable-ffi --unstable-temporal --config=./tsconfig.json --import-map=./import-map.json ./src/main.ts`

Causes this output...

`zsh: trace trap  deno cache --node-modules-dir=false --unstable-worker-options --unstable-ffi`

Further analysis shows the error code being returned is 133 (Trace/BPT trap: 5).
Repository: PowerToys
Issue: Power Toys Color Picker
Labels: Issue-Bug,Needs-Triage

### Microsoft PowerToys version

0.83.0

### Installation method

PowerToys auto-update

### Running as admin

Yes

### Area(s) with issue?

ColorPicker

### Steps to reproduce

Application Popup: PowerToys.ColorPickerUI.exe - Entry point not found: OpenGmm procedure entry point not found in the dynamic link library C:\WINDOWS\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_08c6076a1ac36ac6\igd9dxva64.dll. 

### ✔️ Expected Behavior

_No response_

### ❌ Actual Behavior

_No response_

### Other Software

update Intel Graphics Driver 31.0.101.2128
Repository: PowerToys
Issue: FancyZone layout editor not covering full screen
Labels: Issue-Bug,FancyZones-Editor,Product-FancyZones,Needs-Triage

### Microsoft PowerToys version

0.83.0

### Installation method

PowerToys auto-update

### Running as admin

Yes

### Area(s) with issue?

FancyZones Editor

### Steps to reproduce

Use a monitor with a resolution of 5120x1440, launch fancy zone editor.

### ✔️ Expected Behavior

The editor displays an overlay over the entire screen to allocate where to snap zones.

### ❌ Actual Behavior

A portion of the overlay is not covering the right half of the screen.
![image](https://github.com/user-attachments/assets/9feff816-5135-4836-825c-d1661f267a1c)


### Other Software

_No response_
Repository: godot
Issue: Broken icons in the gizmo visibility popup menu
Labels: bug,topic:editor

### Tested versions

Broken in v4.4.dev.custom_build [142d33211]
Broken in 4.3 stable

### System information

Godot v4.4.dev (142d33211) - macOS 14.5.0 - Metal (Forward+) - integrated Apple M1 Max (Apple7) - Apple M1 Max (10 Threads)

### Issue description

Default theme, fresh editor start:

<img width="1036" alt="s" src="https://github.com/user-attachments/assets/850096bb-6588-4d84-81c4-de18f2526556"><br>

They get fixed if you change the editor theme to something else until the next editor restart

### Steps to reproduce

Just creating a new project with the current master build should be enough

### Minimal reproduction project (MRP)

N/A
Repository: vscode
Issue: Unclear why I'd want to `Copy changed line` in notebook diff
Labels: bug,multi-diff-editor

Testing #226665

Testing on latest VS Code Insiders on Windows 11 Insiders

```
Version: 1.93.0-insider (user setup)
Commit: ff7a154d5e5e9034914f0466420f0f1407f0c95e
Date: 2024-08-27T05:04:20.235Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.25987
```

I notice a lightbulb will appear in every cell of the notebook diff view to `Copy changed line`:
![Image](https://github.com/user-attachments/assets/880b9378-6426-41b7-a6e6-d9e445606fb5)

I'm unclear what this does or why I'd want to do this in every entry of the diff view. I tried clicking on it, but it doesn't seem to then later paste anything?
Repository: vscode
Issue: Probably needs some padding at the botton where the scroll shows up
Labels: bug,multi-diff-editor

Testing #226665

![image](https://github.com/user-attachments/assets/4e125d1f-7f82-43c6-90a3-ad2cfe5226f5)
Repository: vscode
Issue: SCM Graph - Improve name/description of theme keys
Labels: scm,under-discussion

Testing #226648

It's not immediately clear what a group is here:

https://github.com/microsoft/vscode/blob/78f4b54aca1c0e9b0b86f2e650e22ceb7217ccba/src/vs/workbench/contrib/scm/browser/scmHistory.ts#L25-L27

I think it would be more clean if these were named:

- `scm.graph.localItemForeground`
  - Since the feature is called "source control graph", the history seems unneeded?
  - Foreground/background/border is normally a suffix of theme keys
- `scm.graph.remoteItemForeground`
- `scm.graph.mergeBaseItemForeground`
  - I think base means merge base here?
Repository: vscode
Issue: Diff view does not remember the scroll position
Labels: bug,polish,notebook-diff,multi-diff-editor

Testing #226665

Repro steps:
1. Open diff view with changes to many cells
2. Scroll down to the bottom most cell
3. Open a different diff view with another notebook
4. Come back to the first one
Repository: vscode
Issue: SCM Graph - What does historyItemGroupHoverLabelForeground do?
Labels: polish,scm

Testing #226648

Based on this screenshot after running the generated theme from current settings command, I would have expected something in the hover to have a white foreground color?

<img width="1226" alt="Screenshot 2024-08-27 at 9 53 52 AM" src="https://github.com/user-attachments/assets/a4562a28-1ee1-4a99-92dc-fd3a2c0c2481">
Repository: vscode
Issue: Multi File Diff Editor: Hover Messages are cut off
Labels: bug,multi-diff-editor

Testing #226665

Testing on latest VS Code Insiders on Windows 11 Insiders

```
Version: 1.93.0-insider (user setup)
Commit: ff7a154d5e5e9034914f0466420f0f1407f0c95e
Date: 2024-08-27T05:04:20.235Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.25987
```

I was surprised I could add a breakpoint. Additionally, the hover gets cut off:

![Image](https://github.com/user-attachments/assets/590f63cc-e3e3-4f97-9e6f-94506391446b)
Repository: vscode
Issue: SCM Graph - Should selecting an item in the scm graph highlight the lines similar to indent guides in the editor?
Labels: ux,scm,under-discussion

Testing #226648

Current:

<img width="483" alt="Screenshot 2024-08-27 at 10 09 04 AM" src="https://github.com/user-attachments/assets/00610c55-97b8-46a2-87fb-c3bafa9bdfa0">

Basic idea:

![image](https://github.com/user-attachments/assets/3283d138-0dcf-4ff6-ba6e-684bf5f91a52)

This will allow easier tracking of the line(s) when scrolling
Repository: vscode
Issue: Avoid inlining large types
Labels: bug,search,search-api

Testing #226669

This is just a personal pet peeve of mine- when you have a property like `folderOptions: { /* lots of properties */ }[]` then if I have a function where I want to refer to the type of a single `folderOptions` item, I don't have an interface that I can use as the type of that item. Like `function searchOneFolder(folderOptions: ???) { }` It's much nicer to give a name to that kind of thing and write something like `folderOptions: TextSearchFolderOptions[]`
Repository: vscode
Issue: SCM Graph - Should merging main use the same color?
Labels: scm,under-discussion

Testing #226648

Related: https://github.com/microsoft/vscode/issues/226821

Should the yellow here be blue since it represents the same thing at the vertical line until it's merged?

<img width="262" alt="Screenshot 2024-08-27 at 10 20 31 AM" src="https://github.com/user-attachments/assets/fdd7ad5c-3e36-44b7-ae24-f70f275d6489">

Proposal:

<img width="163" alt="Screenshot 2024-08-27 at 10 22 15 AM" src="https://github.com/user-attachments/assets/30f195ad-840d-4a1d-b182-30267a011c9a">
Repository: vscode
Issue: SCM Graph - Support collapsing commits belonging to merge commits
Labels: feature-request,scm

Testing #226648

I haven't used this sort of graph much, but it seems like collapsing these types of commits would be useful. Maybe even by default?

Current:

<img width="569" alt="Screenshot 2024-08-27 at 10 25 09 AM" src="https://github.com/user-attachments/assets/9be94889-de55-4c07-a53c-2a16451eca6d">

Proposal:

![image](https://github.com/user-attachments/assets/d09b8be5-7841-47ed-84c2-a79954cecc17)

Maybe with a > or + to expand them inline?
Repository: vscode
Issue: `FindFiles2OptionsNew.useIgnoreFiles` is quite complicated
Labels: api,under-discussion,search-api

Testing #226670

I'm not quite sure how to express this, but the `useIgnoreFiles` option is quite complex and I'm not sure if it's necessary to be so complex. If I understand its purpose correctly, the `findFiles2New` API will by default do some filtering on top of the disk. In other words, it will respect whatever settings are defined in the workspace or defined by the user w.r.t. ignoring files.

Then, `useIgnoreFiles` is a mechanism to ask the vscode API to ignore the settings and be 100% transparent and just return whatever the disk has.

My question is: how could an extension author know if they should set `useIgnoreFiles.parent` to false? How about `useIgnoreFiles.global`? These two settings seem to be extremely personal to the user that has decided to check out the repository in a folder where they define an ignore file. Or maybe they have a global ignore file. But how could an extension author know what kind of setup they're dealing with?

So I'd suggest simplifying the API, allow extension authors to either opt for the "on disk" no-filters file search or for the "user configured" filter. Also, I think a better name for such a simplified setting might be `respectUserDefinedFilters`, `respectConfigurationFilters` or `disableFilters`, `disableConfigurationFilters`...

**Edit**: Looking at `useExcludeSettings`, the same situation appears. How should I, as an extension author, know which value to use `ExcludeSettingOptions.FilesExclude` vs `ExcludeSettingOptions.SearchAndFilesExclude` and why isn't there a `ExcludeSettingOptions.SearchExclude`.

I feel that the API is quite complex and I'm not sure if such complexity is required. Maybe you have use-cases in mind for all these settings?
Repository: material-ui
Issue: [material-ui] defaultShouldForwardProp is not a function error in plasmo extension
Labels: external dependency,package: material-ui

### Steps to reproduce

Steps:
1. create a browser extension with plasmo `npm create plasmo --with-src`
2. add mui according to the docs `npm install @mui/material @emotion/react @emotion/styled`
3. add `Button` or `Typography` to `src/popup.tsx`
4. run `npm run dev`
5. open the extension and check console: 
```
Uncaught TypeError: defaultShouldForwardProp is not a function
    at createStyled (emotion-styled-base.esm.js:154:3)
    at styled (index.js:15:16)
    at styled (createStyled.js:141:26)
    at 7un50.react (Typography.js:40:9)
    at newRequire (popup.7d3dc21e.js:72:24)
    at localRequire (popup.7d3dc21e.js:85:35)
    at hctgw../Typography.js (index.js:3:1)
    at newRequire (popup.7d3dc21e.js:72:24)
    at localRequire (popup.7d3dc21e.js:85:35)
    at 2wxYu../colors/index.js (index.js:268:1)
```


### Current behavior

App doesn't render, blank screen is presented

### Expected behavior

Components being rendered

### Context

Render mui components in my browser extension

### Your environment

<details>
  <summary><code>npx @mui/envinfo</code></summary>

```
 Browser:
    Google Chrome
 System:
    OS: macOS 14.5
  Binaries:
    Node: 22.5.1 - /opt/homebrew/bin/node
    npm: 10.8.2 - /opt/homebrew/bin/npm
    pnpm: 9.6.0 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 123.0.6312.59
    Edge: Not Found
    Safari: 17.5
  npmPackages:
    @emotion/react: ^11.13.3 => 11.13.3
    @emotion/styled: ^11.13.0 => 11.13.0
    @mui/core-downloads-tracker:  6.0.0
    @mui/icons-material: ^6.0.0 => 6.0.0
    @mui/material: ^6.0.0 => 6.0.0
    @mui/private-theming:  6.0.0
    @mui/styled-engine:  6.0.0
    @mui/system:  6.0.0
    @mui/types:  7.2.16
    @mui/utils:  6.0.0
    @types/react: 18.2.48 => 18.2.48
    react: 18.2.0 => 18.2.0
    react-dom: 18.2.0 => 18.2.0
    typescript: 5.3.3 => 5.3.3

```
</details>


**Search keywords**: defaultShouldForwardProp is not a function error
Repository: go
Issue: go/format: possible internal error in format.Node when source contains //go:build directive
Labels: NeedsInvestigation

Reproducer:

```go
func TestBuildDirectiveFormat(t *testing.T) {
	const src = "package A\nimport()\nfunc A(){0//go:build\n0}"

	fs := token.NewFileSet()
	f, err := parser.ParseFile(fs, "test.go", src, parser.ParseComments|parser.SkipObjectResolution)
	if err != nil {
		t.Fatal(err)
	}

	if err := printer.Fprint(io.Discard, fs, f); err != nil {
		t.Fatal(err) // no error
	}

	if err := format.Node(io.Discard, fs, f); err != nil {
		t.Fatal(err) // format.Node internal error (8:5: expected ';', found 0 (and 1 more errors))
	}
}
```

`printer.Fprint` does not return an error for the same source, only the `format.Node` errors. It happens here:

https://github.com/golang/go/blob/994d1d446663873dd593846a0b94147410e5922a/src/go/format/format.go#L76-L80

CC @griesemer
Repository: flutter
Issue: Devtools release blocked because Flutter reports 0.0.0 version
Labels: team-infra,P1,triaged-infra,fyi-tool

(internal link) https://ci.chromium.org/ui/p/dart-internal/builders/flutter/devtools/975/infra

May be related to: https://github.com/flutter/flutter/issues/142521
Repository: vscode
Issue: SCM Graph - add support for async filtering
Labels: feature-request,scm

Testing #226648

If I open the scm graph and filter it, it ends up not showing anything for "terminal":

<img width="557" alt="Screenshot 2024-08-27 at 10 43 57 AM" src="https://github.com/user-attachments/assets/f1e5ba26-4047-4366-a906-98b1e2feee27">

I can remove the filter and scroll down a bunch to load it in which gives me some results, could we load in items when filtering if the viewport isn't full?
Repository: pytorch
Issue: DISABLED test_fused_sdp_choice_privateuseone (__main__.TestSDPAPrivateUse1Only)
Labels: triaged,skipped

Platforms: asan, dynamo, linux, rocm, win, windows, mac, macos











cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang
Repository: TypeScript
Issue: Bloomberg TS 5.6 Beta Feedback
Labels: Discussion

### Acknowledgement

- [X] I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.

### Comment

We are in the process of evaluating the impact of TS 5.6 beta on Bloomberg code. Below are preliminary findings.

Overall, the only new diagnostics produced by this release are the excellent improvements to nullish/truthy checks.

Change | Impacts | Release notes | Packages impacted
-- | -- | -- | --
New nullish/truthy diagnostics | Type checker | [Disallowed Nullish and Truthy Checks](https://devblogs.microsoft.com/typescript/announcing-typescript-5-6-beta/#disallowed-nullish-and-truthy-checks) | ~one dozen

### Stricter type-checking of partial objects

We observed new errors related to nullish/truthy checks, all of which look like correct diagnostics. A few simplified examples are below:

```ts
const err = "bar";

// Right operand of ?? is unreachable because the left operand is never nullish.(2869)
const errorMessage = "foo " + err ?? "Unknown error";
```

```ts
// Right operand of ?? is unreachable because the left operand is never nullish.(2869)
const isActive = !someCondition ?? true;
```

```ts
// This kind of expression is always truthy.(2872)
if (myCheck === "foo" || "bar") {

}
```
Repository: node
Issue: add `path.mimeType()` and `path.charset()` to `node:path`
Labels: path,feature request

### What is the problem this feature will solve?

Adding `path.mimeType()` and `path.charset` will solve the dependency on an external library, mime-types, to get the content type of a file based on its extension. This can be done with Node.js itself, just as Bun.js does with [`Bun.file(file).type`](https://bun.sh/docs/api/file-io#reading-files-bun-file).


### What is the feature you are proposing to solve the problem?

I am proposing to add two new methods to the path module:

- `mimeType` - returns the MIME type of a file based on its extension.
- `charset` - returns the charset of a MIME type.

```js
path.mimeType('file.js'); // returns 'application/javascript'
// or:
path.mimeType(path.extname('file.js')); // returns 'application/javascript'
```

And:

```js
path.charset('file.js'); // returns 'utf-8'
// or:
path.charset(path.mimeType('file.js')); // returns 'utf-8'
```


### What alternatives have you considered?

Alternatively, instead of being in `node:path`, it could be in `fs.stat`, but I think that in the end it can be extracted from the path without having to parse the file, besides it is better to use functions for this and the work is done only if they are executed individually.


CC: @vdeturckheim
Repository: vscode
Issue: `vscode.ExcludeSettingOptions.None` does not seem to work
Labels: bug,search,search-api


Test extension:

<details>

```
import * as vscode from 'vscode';
import * as fs from 'fs/promises';
import * as path from 'path';
import * as assert from 'assert';

export function activate(context: vscode.ExtensionContext) {
	const disposable = vscode.commands.registerCommand('extension.helloWorld', async () => {
		const wf = vscode.workspace.workspaceFolders![0].uri;
		await vscode.workspace.getConfiguration('files').update('exclude', {
			'**/*.fileexclude.*': true,
			'**/fileexclude/**': true,
		}, vscode.ConfigurationTarget.Workspace);
		await vscode.workspace.getConfiguration('search').update('exclude', {
			'**/*.searchexclude.*': true,
			'**/searchexclude/**': true,
		}, vscode.ConfigurationTarget.Workspace);

		makeAllFiles([
			{ name: '.gitignore', content: '**/bar.txt' },
			'foo.txt',
			'bar.txt',
			'fileexclude/foo.txt',
			'fileexclude/bar.txt',
			'searchexclude/foo.txt',
			'searchexclude/bar.txt',
			'nested1/foo.txt',
			'nested1/bar.txt',
			'nested2/foo.txt',
			'nested2/bar.txt',
		]);

		let output = '';


		output += assertUris(
			['foo.txt', 'fileexclude/foo.txt', 'nested1/foo.txt', 'nested2/foo.txt', 'searchexclude/foo.txt'],
			await vscode.workspace.findFiles2New([new vscode.RelativePattern(wf, '**/*.txt')], { useExcludeSettings: vscode.ExcludeSettingOptions.None })
		);

		const doc = await vscode.workspace.openTextDocument({
			content: output,
			language: 'plaintext',
		});
		await vscode.window.showTextDocument(doc);
	});

	function assertUris(expected: string[], uris: vscode.Uri[]) {
		try {
			const actual = uris.map(u => path.relative(vscode.workspace.workspaceFolders![0].uri.fsPath, u.fsPath));
			assert.deepStrictEqual(actual.sort(), expected.sort());
		} catch (e) {
			return String(e) + '\n\n';
		}

		return `Case OK (${JSON.stringify(expected)})\n`;
	}

	async function makeAllFiles(files: (string | {name: string, content: string})[]) {
		const wf = vscode.workspace.workspaceFolders![0].uri.fsPath;
		for (const file of files) {
			const name = typeof file === 'string' ? file : file.name;
			const content = typeof file === 'string' ? '' : file.content;
			const target = path.join(wf, name);
			await fs.mkdir(path.dirname(target), { recursive: true });
			await fs.writeFile(target, content);
		}
	}

	context.subscriptions.push(disposable);
}
```

</details>

Fails with:

```
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  [
+   'foo.txt',
+   'nested1/foo.txt',
+   'nested2/foo.txt'
-   'fileexclude/foo.txt',
-   'foo.txt',
-   'nested1/foo.txt',
-   'nested2/foo.txt',
-   'searchexclude/foo.txt'
  ]
```

I expected `{ useExcludeSettings: vscode.ExcludeSettingOptions.FilesExclude }` would not use my search exclude setting (only `SearchAndFilesExclude` would.)