sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: angular
Issue: [Ivy] ASSERTION ERROR: Should be run in update mode
Labels: freq2: medium,area: core,core: change detection,P3

<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅

Oh hi there! 😄

To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.

🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->


# 🐞 bug report

### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- ✍️edit: --> The issue is caused by package @angular/core (Ivy)


### Is this a regression?

<!-- Did this behavior use to work in the previous version? -->
<!-- ✍️--> 

Yes, works in non-Ivy.

### Description

I suspect this happens as a result of having an Input property that is set directly (`isExpanded="true"`) instead of using a binding (`[isExpanded]="true"`), and having the property setter call `changeDetectorRef.detectChanges()`. It should be noted that this works in non-ivy.

## 🔬 Minimal Reproduction

https://github.com/fr0/angular-test/tree/ivy

1. Clone repo
2. `git checkout ivy`
3. `npm install`
4. `npm start`
5. Open http://localhost:4200 in Chrome
6. View browser console log


## 🔥 Exception or Error
<pre><code>
core.js:5829 ERROR Error: ASSERTION ERROR: Should be run in update mode
    at throwError (core.js:1164)
    at assertEqual (core.js:1123)
    at refreshView (core.js:12425)
    at detectChangesInternal (core.js:13907)
    at ViewRef.detectChanges (core.js:15373)
    at ExpandableIfComponent.set isExpanded [as isExpanded] (expandable-if.component.ts:60)
    at setInputsFromAttrs (core.js:13579)
    at postProcessDirective (core.js:13335)
    at instantiateAllDirectives (core.js:13234)
    at createDirectivesInstances (core.js:12618)
</code></pre>


## 🌍  Your Environment

**Angular Version:**
<pre><code>
<!-- run `ng version` and paste output below -->
<!-- ✍️-->
Angular CLI: 9.0.0-next.5
Node: 12.6.0
OS: darwin x64
Angular: 9.0.0-next.7
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.0-next.5
@angular-devkit/build-angular     0.900.0-next.5
@angular-devkit/build-optimizer   0.900.0-next.5
@angular-devkit/build-webpack     0.900.0-next.5
@angular-devkit/core              9.0.0-next.5
@angular-devkit/schematics        9.0.0-next.5
@angular/cli                      9.0.0-next.5
@ngtools/webpack                  9.0.0-next.5
@schematics/angular               9.0.0-next.5
@schematics/update                0.900.0-next.5
ng-packagr                        5.5.1
rxjs                              6.5.3
typescript                        3.5.3
webpack                           4.40.2
    

</code></pre>
Repository: pytorch
Issue: Remove TensorOptions logic from generated code
Labels: module: internals,triaged

Scripts that are generating code are getting more and more complex and require a lot of domain knowledge in order to make any substantial changes. This is mostly due to logic around TensorOptions. We should eliminate it in order to significantly decrease complexity of the code.

Objectives: 

- Make is easy to add and remove parameters from Tensor Options. Ideally we want to have one place where we would add a new parameter with default value, if any, and the rest of code generation code should be able to take it from there.

- Clean up the dead code.
- Add documentation which explains the current flow of the code generation process. Explain what each generated file is responsible for and why we need Tensor Options in particular places.
- Remove all hardcoded hacks. For example handling lriu/tril.
- Fix default value processing.
- Fix discrepancy between some declarations and definitions.
Repository: kubernetes
Issue: migrate the leader election to use v1beta1 Events
Labels: priority/important-soon,sig/scalability,kind/feature,sig/instrumentation,do-not-merge/hold,lifecycle/frozen

the leader election code should be emitting events against the v1beta1 Events API. This change also concerns any kubernetes component (such as kube-scheduler or the controller-manager) that uses the `leaderelection` package.

Part of #76674

/kind feature
/sig scalability
/sig instrumentation
/priority important-soon
Repository: go
Issue: cmd/compile: use hashing for switch statements
Labels: help wanted,NeedsInvestigation,compiler/runtime

Currently we implement switch statements with binary search. This works well for values that fit into a register, but for strings it might be better to compute a hash function.

Some thoughts:

1. Even in the simple case of using a full hash function, exactly two passes over the switched value is probably better than O(log N) possible passes over it.

2. Since we have the expected keys statically, we can use a simple, cheap universal hash (e.g., FNV? djb2?) and keep trying different seeds until we get one without any collisions.

3. Instead of hashing all of the input bytes, we can hash just enough of them to avoid collisions.

4. We can try using a *minimal* (or near minimal) perfect hash to emit a jump table instead of binary search. (This might even be useful for sparse integer values too.)

If someone can help figure out code that can take a `[]string` and figures out an appropriate and cheap hash function to use, I can help wire it into swt.go.
Repository: go
Issue: cmd/go: 'go mod edit -replace' fails if the package's version in go.mod is not in semver format
Labels: NeedsInvestigation,GoCommand,modules

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.12 linux/amd64

</pre>

### Does this issue reproduce with the latest release?
Yes


### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code>
</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/rafael/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/rafael/Work/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go-1.12"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.12/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/rafael/Work/go/src/github.com/rafaelvanoni/kube-controllers-private/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build260011560=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### What did you do?

A simplified example suggested by @heschik is to run the following command twice:
<pre>go mod edit -replace golang.org/x/tools@latest=github.com/golang/tools@latest </pre>




<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->



### What did you expect to see?



### What did you see instead?
A "version must be of the form v1.2.3" error.
Repository: godot
Issue: [Bullet] Setting 3D gravity vector during runtime disables it instead
Labels: bug,topic:physics,topic:3d

**Godot version:**
3.1.1

**OS/device including version:**
Ubuntu 18.04

**Issue description:**
Calling `PhysicsServer.area_set_param` to update a world's gravity vector seems to disregard the provided value, instead setting it to 0. After some digging, I found this behaviour consistent with commit https://github.com/godotengine/godot/commit/d250ade37b1e74dd11c870be279318ba01a8ba70 (link kindly provided by a user in IRC), and I can confirm that the gravity vector behaves as expected after reverting the commit. However I am not sure if doing so reintroduced whatever bug it was fixing, thus this is not a pull request.

**Steps to reproduce:**
1. Add Camera and RigidBody (any shape works, needs some visible geometry as child node).
2. Extend RigidBody node with a script, and set world gravity vector within `_process` (to anything other than 0).
3. Play the project.

**Minimal reproduction project:**
[NoGravity.zip](https://github.com/godotengine/godot/files/3628811/NoGravity.zip)
Repository: pytorch
Issue: Avoid sending zero grads over the wire in distributed autograd backward pass
Labels: triaged,module: rpc

For the distributed backward pass, we pass zero grads over the wire for certain tensors which were not used in the forward pass (when we execute RecvRpcBackward). This is done for simplicity currently, but a potential performance enhancement is to send only gradients  that we need over the wire. For more context see: https://github.com/pytorch/pytorch/pull/25527#discussion_r321509898

cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini
Repository: material-ui
Issue: Verify correctiveness of theme during `createMuiTheme`
Labels: new feature,core

<!-- Provide a general summary of the feature in the Title above -->

<!--
  Thank you very much for contributing to Material-UI by creating an issue! ❤️
  To avoid duplicate issues we ask you to check off the following list.
-->

<!-- Checked checkbox should look like this: [x] -->

- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.

## Summary 💡

This feature will ensure correctiveness of theme's being verified during `createMuiTheme`.

Alternatively, a function to verify correctness of the theme could be helpful too. 

## Examples 🌈

```javascript
// This should throw an error during initialization
const theme = createMuiTheme({
  palette: {
    primary: 'random string'
  }
})
```

<!--
  Provide a link to the Material design specification, other implementations,
  or screenshots of the expected behavior.
-->

## Motivation 🔦

At the moment, Typescript can enforce the correctness of theme structure, but it can't verify the content of them. The content of theme seems to get verified during runtime when a component is consuming a part of it. 

This causes an issue that front-end page crashes when you navigate to a MUI component that consume an invalid part of theme via `decomposeColor ` function. For above example, you would see `Material-UI: unsupported XXXX color` and page crashes

At this moment, to ensure the theme is valid, we will have to either:

1. unit-test all components's behavior under custom theme (`renderWithTheme` etc..)
2. make a dedicated test scaffolding for theme to verify the content
3. manually check all components on UI

It'd be great if `createMuiTheme` can create a safety net for us.


<!--
  What are you trying to accomplish? How has the lack of this feature affected you?
  Providing context helps us come up with a solution that is most useful in the real world.
-->

## Alternative

Handle the error thrown by `decomposeColor` gracefully
Repository: youtube-dl
Issue: Could you add a extractor for amazon live: https://www.amazon.com/live
Labels: request

amazon live is a new live site: https://www.amazon.com/live
Repository: flutter
Issue: TextEditingController documentation should mention that it shouldn't be created in build
Labels: a: text input,framework,f: material design,a: internationalization,d: api docs,d: examples,P3,team-text-input,triaged-text-input

If you use Pinyin to input Chinese characters, the intermediate letters will also be treated as "changed" texts when using "onChanged" callback if you set texts for the text controller in the build function. 
This also affects Japanese Input method too. 
 
If you want to reproduce this issue, please clone this repo:
https://github.com/rockingdice/test_multistep_input.git

Tap the Text Field at the bottom of the screen, use any multi-step input method will reproduce this issue.

I could put the controller outside the build as a workaround, but I don't think this behavior is correct. 

@cbracken maybe knew this issue?

This image demos the issue:
I inputted "nihongo" but it gives out all the intermediate letters after each inputted letter.

![image](https://user-images.githubusercontent.com/3458134/65229656-3871ab80-daff-11e9-8fe2-beabd3b81413.png)
Repository: terminal
Issue: Feature Request: global hotkey to re-run last command
Labels: Issue-Feature,Help Wanted,Area-UserInterface,Product-Terminal

# Description of the new feature/enhancement

I would really like to see the ability to bind a global hotkey to repeat the last command in the visible terminal. In essence all it does is: `up arrow` and `enter` on the terminal that is visible. Should work even when terminal has no focus since I'm pressing this global hotkey when I'm not in the terminal.

Global hotkeys should be bindable to any key, including special keys such as Scroll Lock, Pause/Break and the Context Menu (the button next to the right CTRL). 

iTerm2 has this functionality and no other terminal emulator I've tried has this, on Linux or Windows. I'm sure this is achievable with AutoHotkey but I'd prefer native functionality.

Use case for me:
When testing or running experimental scripts, it is common to rerun your script every time you make a change. It is very productive for me if I don't need to take my hands off the keyboard for this. Personally I would bind this functionality to the "context menu" key (between CTRL and Windows), since I never use that button anyway.
Repository: create-react-app
Issue: Service worker: delete index.html from cache in onupdatefound event
Labels: issue: proposal,needs triage

### Is your proposal related to a problem?

<!--
  Provide a clear and concise description of what the problem is.
  For example, "I'm always frustrated when..."
-->

When the service worker in `registerServiceWorker.(js|ts )` is enabled it provides very useful PWA benefits.

However, in a production build it also caches the `index.html` file which references the names & hashes of the outputted JS chunks by the webpack build. When a new build is created, new chunks and hashes are generated, however, the service worker at the client keeps the old `index.html` and looks for the old chunks, which completely breaks the app as no JS can be obtained.

### Describe the solution you'd like

The registration of the service worker in `registerServiceWorker.ts` already detects new content available from the server and logs a prompt to refresh in the console. In the `onupdatefound` event [here](https://github.com/facebook/create-react-app/blob/a1afaa6376590f732d3f32e6ab9a6dcf8c8aafbc/packages/react-scripts/template-typescript/src/serviceWorker.ts#L77) there is an assumption that old content has been purged, when in fact even after closing all tabs and hard reloading I keep seeing this message and when I check the cache in DevTools and the network I see it's coming from the service worker. Other issues can be found here #7121 #4674 #5316 which can't get past this issue as well.

At the event handler as well as the console log of `New content is available; please refresh.`, it would be better if `index.html` is manually deleted from the cache using the `Cache` API, the cache key seems to be in the form of `workbox-precache-https://mysite.io/`.

### Describe alternatives you've considered

Turning the service worker off takes away a lot of benefits and PWA functionality, so it's not really an option as proposed in other issues related to this.

Many thanks :)
Repository: rust
Issue: Unit struct appears to be a NoType in pdb files
Labels: A-debuginfo,T-compiler,O-windows-msvc,C-bug

A unit struct has the following debug metadata:
"'()", DW_ATE_unsigned
and when reading the type data from generated pdb file I get a <no type> for it.
```rust
#[inline(never)]
fn foo(_: ()) { }

fn main() {
  let x = ();
  foo(x);
}
```

Compile it, read pdb data from the pdb file in target/debug :
```bash
llvm-pdbutil dump -symbols mycrate.pdb | rg 'mycrate::foo' -A2
```
and you'll get something like:
```bash
212 | S_LPROC32 [size = 52] `plop::foo`
         parent = 0, end = 324, addr = 0001:0352, code size = 3
         type = `0x101D (void (<no type>))`, debug start = 0, debug end = 0, flags = none
```
It's probably because the size of an unit struct is zero (am I correct ?) and then when dumping into pdb then it is converted into no type.

I think it would be better to have an empty struct instead of an unsigned.
Repository: flutter
Issue: Staggered GridView in Flutter
Labels: c: new feature,framework,a: fidelity,f: scrolling,would be a good package,c: proposal,P3,team-framework,triaged-framework

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill our the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case
Why isn't there in-built support for a staggered grid view in Flutter?
This is a basic use case that is covered by almost any mobile framework.
For example, Android has a `StaggeredGridLayoutManager` for `RecyclerView`.
I don't want to rely on a 3rd party library for this type of UI constructs.
<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->
Repository: flutter
Issue: Hot restart/reload for web should allow controlling invalidation of resources.
Labels: tool,c: performance,t: hot reload,platform-web,P2,team-web,triaged-web

We should know in the tool what resources have been invalidated when performing a hot restart.  In should be possible to, via some debugger connection, provide the list of invalidated resources and and preserve the rest.

This would remove the loading jank for applications with lots of fonts.
Repository: go
Issue: x/text/language: language Matcher does not properly support zh_HK (Hong Kong) 
Labels: NeedsInvestigation

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
1.13
</pre>

### Does this issue reproduce with the latest release?
Yes


### What operating system and processor architecture are you using (`go env`)?
Reproduces on all processors and architectures

### What did you do?
Tried to match the following language header from Google Chrome:
<pre>zh-HK,zh;q=0.9,zh;q=0.8,en-GB;q=0.7,en;q=0.6,ja;q=0.5,th;q=0.4,en-US;q=0.3</pre>

https://play.golang.org/p/hQ_FUehpgoZ


### What did you expect to see?
Language matcher returns the Hong Kong region and Traditional Chinese character set


### What did you see instead?
Language matcher is unaware of the Hong Kong region and falls back to the next language (Chinese or Taiwanese).  Does not return traditional character set unless zh-Hant or zh-TW is explicitly set in the language header.
Repository: go
Issue: proposal: cmd/doc: add "// Unstable:" prefix convention
Labels: Documentation,Proposal,Proposal-Hold

### What did you see today?
Many projects have different stability guarantees for the exported symbols in a package. Others rely on generated code that cannot, or will not, give stability guarantees. As such, most authors will document this pre-release or instability in doc strings, but the syntax and conventions are all over the place.

The standard library likes to reference the `Go compatibility promise` or `Go 1 compatibility guidelines`, since it is bound by them, however these do not work well for community packages. Other terms like `non-portable` and `EXPERIMENTAL` are descriptive and well explained in `unsafe` and `syscall/js` respectively.

Some community libraries have used terms like `// Alpha: ...`, `// Beta: ...`, and `// Unstable: ...`, which work as well. There could be an argument for not releasing pre-release features on a stable branch, but other times like with the [proto client/server `interfaces`](https://github.com/grpc/grpc-go/issues/2318), instability is a guarantee that must be [worked around](https://github.com/golang/protobuf/pull/785).

### What would you like to see?
Similar to [`// Deprecated: ...`](https://github.com/golang/go/issues/10909), I would like to see the stabilization of supported comment tags for unstable symbols.

They support the same three formats that same [three formats](https://github.com/golang/go/issues/10909#issuecomment-136492606) that deprecation has.

These tags should also allow such symbols to be excluded from the [`gorelease`](https://github.com/golang/go/issues/26420) tool.

A single tag should be sufficient:
```go
// Unstable: ...
```

When interacting with released, finalized symbol that cannot or will not be stabilized, the description can provide stability workarounds, alternatives, or what guarantees should be expected.

When interacting with pre-release features, a proposed timeline can be given or alternatives for customers requiring stability guarantees.

### What did not work?
The `// Alpha: ...` and `// Beta: ...` options looked promising, since they would only be used for temporary instability as part of the release process. The two terms overload one another (what is the difference between alpha, beta, and `// PreRelease: ...`?), leading to confusion. Furthermore, the programmatic benefits of knowing an API will stabilize in a future release is not that useful, "is it unstable now?" is more important.

The `// Experimental: ...` syntax used by the standard library implies the notion that the feature will eventually be stabilized. This further overloads it with alpha, beta, etc. and does not fit the needs of the above gRPC interfaces.

The `// NonPortable: ...` syntax is too domain specific to `unsafe` to make sense for purely semantic changes to packages. It makes sense for `unsafe`, but does not generalize
Repository: flutter
Issue: Do not create an onscreen surface when foregrounding if no FlutterViewController is visible
Labels: platform-ios,engine,a: platform-views,c: proposal,P2,team-ios,triaged-ios

Spin off from https://github.com/flutter/flutter/issues/38736 and https://github.com/flutter/engine/pull/12277#issuecomment-531987029

Right now when coming back into the foreground on iOS, the PlatformViewIOS will recreate the IOSSurface. This isn't necessary if the FlutterViewController isn't visible.
Repository: kubernetes
Issue: Cache CRD conversion results
Labels: sig/api-machinery,kind/feature,priority/important-longterm,area/custom-resources,lifecycle/frozen

**What would you like to be added**:

A cache of CRD conversion results.

Cache entries should be keyed by UID (namespace, name), GVK and resource version, I believe.

**Why is this needed**:

Based on the benchmarks data we gathered for the [CRD scalability targets](https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20180415-crds-to-ga.md#scale-targets-for-ga) this should significantly to reduce volume of CRD conversion webhook requests, improving scalability and reducing latency.

/sig api-machinery
/area custom-resources
/priority important-longterm

/cc @roycaihw @liggitt
Repository: flutter
Issue: Embedded platform views don't support Switch Access
Labels: platform-android,framework,a: accessibility,from: a11y review,a: platform-views,P2,team-android,triaged-android

/cc @amirh @goderbauer 

Switch Access appears to work fine with Flutter Gallery.