sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: rust
Issue: MSVC on x86-32 Windows fails to align variables to their required alignment
Labels: A-FFI,T-compiler,O-windows-msvc,I-unsound,C-bug,finished-final-comment-period,disposition-close,regression-untriaged,A-ABI

This is a regression from #98112. I suppose it's not possible to disable this specific check only while preserving debug assertions...

The core problem is that the x86 ABI on Windows doesn't guarantee the stack alignment above 4. See for example https://developercommunity.visualstudio.com/t/vs2017-64-bit-int-alignment-problem/294259

And while some types have an alignment reported of 8 (e.g. UINT64), in practice, the C compiler will happily not align them on the stack.

So for example, this C code, compiled by MSVC for 32-bits:
```
#include <cinttypes>
extern void hoge(uint64_t*);
void foo() {
    uint64_t a;
    hoge(&a);
}
```
will produce this assembly:
```
_a$ = -8                                                ; size = 8
void foo(void) PROC                                        ; foo
        push    ebp
        mov     ebp, esp
        sub     esp, 8
        lea     eax, DWORD PTR _a$[ebp]
        push    eax
        call    void hoge(unsigned __int64 *)                        ; hoge
        add     esp, 4
        mov     esp, ebp
        pop     ebp
        ret     0
void foo(void) ENDP
```
([on godbolt](https://godbolt.org/z/5eqKrn11j))

If the stack pointer is not 8-bytes aligned when entering the function, the pointer passed to `hoge` is not going to be 8-bytes aligned.

As mentioned in the linked community post above, adding `alignas(8)` to the type definition makes the compiler align the stack:
```
#include <cinttypes>
extern void hoge(uint64_t*);
void foo() {
    alignas(8) uint64_t a;
    hoge(&a);
}
```
becomes
```
_a$ = -8                                                ; size = 8
void foo(void) PROC                                        ; foo
        push    ebx
        mov     ebx, esp
        sub     esp, 8
        and     esp, -8                             ; fffffff8H
        add     esp, 4
        push    ebp
        mov     ebp, DWORD PTR [ebx+4]
        mov     DWORD PTR [esp+4], ebp
        mov     ebp, esp
        sub     esp, 8
        lea     eax, DWORD PTR _a$[ebp]
        push    eax
        call    void hoge(unsigned __int64 *)                        ; hoge
        add     esp, 4
        mov     esp, ebp
        pop     ebp
        mov     esp, ebx
        pop     ebx
        ret     0
void foo(void) ENDP
```
([on godbolt](https://godbolt.org/z/8zP7Pezen))

Now, what this means is that if that `hoge` function is a rust FFI function, and it uses that pointer, the "misaligned pointer dereference" check is hit and panic ensues.

Real life case, for the curious:
https://github.com/servo/dwrote-rs/blob/master/src/font_file_loader_impl.rs#L116-L123

That function is called from dwrite.dll (which comes with Windows).

**t-opsem [FCP comment](https://github.com/rust-lang/rust/issues/112480#issuecomment-1606326864)**

**Summary of the [MSVC alignment rules](https://github.com/rust-lang/rust/issues/112480#issuecomment-2410572444)**
Repository: godot
Issue: [4.1 (latest)] Web Editor crashes when opening a project that was converted to GL Compatibility rendering
Labels: bug,topic:editor,crash

### Godot version

4.1 [e188d61922], Web Editor

### System information

Firefox, Ubuntu 22.04

### Issue description

When opening a project **that was converted to GL Compatibility mode**, the Web Editor crashes when trying to open it.

It only happens when the project was converted to GL Compatibility rendering after it was created (with any other rendering mode). I found that in `project.godot`, the following line doesn't change when you change rendering modes:

`config/features=PackedStringArray("4.1", "Mobile")`

Replacing this line with the following (the line of a project created in GL Compatibility mode):

`config/features=PackedStringArray("4.1", "GL Compatibility")`

Fixes the problem.

### Steps to reproduce

Create an empty project with a rendering mode other than `GL Compatibility`. After creating it, change the rendering mode to `GL Compatibility`, and try to open the project in the Web Editor.

### Minimal reproduction project

[Empty41.zip](https://github.com/godotengine/godot/files/11711176/Empty41.zip)
Repository: go
Issue: proposal: runtime: deprecate `MemStats.Lookups`, possibly retroactively as of Go 1.11
Labels: Proposal

This `MemStats` field has been set to zero since the Go 1.11 release (https://github.com/golang/go/commit/41e6abdc61dd23ede4d3509aebf7b5a638f53712), or for about 5 years. However, this isn't documented.

Given that we now have the `runtime/metrics` package, I don't see a reason to try and define the field as anything other than "this value is always zero." Personally, I think we should mention this in the documentation just to be honest about what the state of the world is, and has been since Go 1.11. It certainly stopped working entirely in that release, and we have no plans to change that.

However, I am unsure what the best way to move forward is mechanically, hence I bring it to the proposal process which handles API deprecation.

Should this be formally retroactively deprecated in Go 1.11? (i.e. all supported releases have their `api/go1.11.txt` updated) Or is it policy to not change history in this way, and instead just deprecate it in the next release?

I don't really care either way, but I feel quite comfortable with documenting this field as zero going forward in perpetuity.
Repository: godot
Issue: Project converter doesn't convert JoystickList to JoyButton
Labels: enhancement,topic:editor,topic:input

### Godot version

v4.0.3.stable.official [5222a99f5]

### System information

Win 10

### Issue description

Usage of joystick buttons from the JoystickList enum in Godot 3.6 isn't converted to enum JoyButton.



Relevant change: #43591

### Steps to reproduce

Example:

```
var controls = {
            "jump":       [JOY_XBOX_A],
            "walk_left":  [JoyAxis(JOY_ANALOG_LX, 1)],
            "walk_right": [JoyAxis(JOY_ANALOG_LX, -1)],
            "walk_up":    [JoyAxis(JOY_ANALOG_LY, 1)],
            "walk_down":  [JoyAxis(JOY_ANALOG_LY, -1)],
        }
```

should convert to:

```
var controls = {
            "jump":       [JOY_BUTTON_A],
            "walk_left":  [JoyAxis(JOY_AXIS_LEFT_X, 1)],
            "walk_right": [JoyAxis(JOY_AXIS_LEFT_X, -1)],
            "walk_up":    [JoyAxis(JOY_AXIS_LEFT_Y, 1)],
            "walk_down":  [JoyAxis(JOY_AXIS_LEFT_Y, -1)],
        }
```

### Minimal reproduction project

Trivial repro
Repository: godot
Issue: Can't add svg as texture when it's opened in the script editor
Labels: bug,topic:editor

### Godot version

v4.0.3.stable.official [5222a99f5], v4.1.dev4.official [5c2295ff5]

### System information

Windows 11

### Issue description

I was generating some SVGs via ChatGPT and discovered that when the SVG is opened in the script editor for that specific file you can't set it as a texture (Including drag and drop into scene or texture property.) Try loading it for a texture property you will get this error message.

> The selected resource (TextFile) does not match any type expected for this property (Texture2D).

![image](https://github.com/godotengine/godot/assets/7538857/444ed684-e47f-4180-b58e-2ba1221d54b2)


### Steps to reproduce

1. Drag a .svg file from the file system into the Scripts panel in the Script screen
3. Add Sprite2D node (or anything with a Texture2D property) and load that same svg file

### Minimal reproduction project

[v4.0.3.stable.official [5222a99f5] project](https://github.com/godotengine/godot/files/11711721/Temp3.zip)
Repository: next.js
Issue: Using Link to Dynamic Route removes value passed from dynamic route in pathname from being used in query
Labels: bug

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 22.5.0: Mon Apr 24 20:52:24 PDT 2023; root:xnu-8796.121.2~5/RELEASE_ARM64_T6000
    Binaries:
      Node: 18.15.0
      npm: 9.5.0
      Yarn: N/A
      pnpm: N/A
    Relevant packages:
      next: 13.4.3
      eslint-config-next: N/A
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.0.4
```


### Which area(s) of Next.js are affected? (leave empty if unsure)

_No response_

### Link to the code that reproduces this issue or a replay of the bug

https://github.com/Radicitus/next-ecommerce/blob/dev/app/components/Product.tsx

### To Reproduce

- Use Link tag with pathname to dynamic route in NextJS
- Use variable in pathname to dynamic route in query as well
- The variable used does not exist when routed to dynamic route

### Describe the Bug

Obligatory I just graduated college and am still new to coding so apologies if I did this wrong.

Here is the code in question:

`return (
    <Link
      href={{
        pathname: `/product/${id}`,
        query: { name, image, unit_amount, id, description, features },
      }}
    >
`

For some reason when I try to access the id variable used in both the query and the pathname, it simply doesn't exist on the dynamic page being linked to, once it loads. Here is how I am trying to access the query params:

`
export default async function Product({ searchParams }: SearchParamType) {
     // example
     searchParams.id;
}
`

So in order to get around this, this is what I did:

`
const queryId = id;

  return (
    <Link
      href={{
        pathname: \`/product/${id}\`,
        query: { name, image, unit_amount, queryId, description, features },
      }}
    >


export default async function Product({ searchParams }: SearchParamType) {
     // example
     searchParams.queryId;
}
`

Not sure if this is a bug or I'm missing something, any help would be appreciated. This issue ONLY occurs on a live prod host on Vercel, I do not get this issue when running locally.

### Expected Behavior

Variable used in pathname and query on a Link element is available on the linked dynamic route page when it loads and query params are accessed.

### Which browser are you using? (if relevant)

_No response_

### How are you deploying your application? (if relevant)

Vercel
Repository: puppeteer
Issue: [Feature]: Invalid header error should show what is the problem
Labels: feature,confirmed

### Feature description

I try to serve a response from cache and I get:
```
Error: Protocol error (Fetch.fulfillRequest): Invalid header
    at new Callback (jsbot-auto\node_modules\puppeteer-core\lib\esm\puppeteer\common\Connection.js:58:35)
    at CallbackRegistry.create (jsbot-auto\node_modules\puppeteer-core\lib\esm\puppeteer\common\Connection.js:103:26)
    at Connection._rawSend (jsbot-auto\node_modules\puppeteer-core\lib\esm\puppeteer\common\Connection.js:215:26)
    at CDPSessionImpl.send (jsbot-auto\node_modules\puppeteer-core\lib\esm\puppeteer\common\Connection.js:422:78)
    at HTTPRequest._HTTPRequest_respond (jsbot-auto\node_modules\puppeteer-core\lib\esm\puppeteer\common\HTTPRequest.js:273:10)
    at HTTPRequest.respond (jsbot-auto\node_modules\puppeteer-core\lib\esm\puppeteer\common\HTTPRequest.js:184:100)
```
And cool, but which one? Which header is a problem? Is the header value invalid? Is the header name invalid? Is it a duplicate? Or what?...
Repository: deno
Issue: Deno REPL Returns Misleading Syntax Error Message
Labels: bug,repl

**Description:**

Upon using the Deno REPL, I've identified a potential issue with the typescript transpiler. Given the malformed input `const test = (i, 2 * i) => console.log(i);`, the REPL returns the error `Uncaught SyntaxError: Unexpected token '<'`. Although the input is incorrect, the error message does not seem to accurately reflect the nature of the problem.

Furthermore, when this faulty code is placed within a .ts file, the same error message is produced. This indicates that the issue is not limited to the REPL environment, but also occurs in broader contexts.

This appears to be related to an earlier issue [#12468](https://github.com/denoland/deno/issues/12468), where the REPL misinterpreted expressions starting with await Promise.resolve(...). However, it seems that the specific compile bug related to that issue has been addressed, whereas this one has not.

**Steps to reproduce:**

    Open the Deno REPL.
    Type const test = (i, 2 * i) => console.log(i);.
    Observe the syntax error message.
    Alternatively, place this code in a .ts file and observe the identical error message.

**Expected behavior:**

A more descriptive and accurate error message should be returned, indicating the nature of the syntax error.

**Actual behavior:**

A misleading syntax error message is returned: `Uncaught SyntaxError: Unexpected token '<'.`
**Environment:**

Deno REPL and .ts files

**Additional Information:**

This bug seems to reside in the typescript transpiler Deno uses, as noted by a developer during a discussion regarding this issue.

It would be greatly appreciated if this bug could be addressed for more accurate error debugging in the future.
Repository: PowerToys
Issue: PowerToysRun better layout.
Labels: Needs-Triage

### Description of the new feature / enhancement

Each result can be smaller, too large. More results can be shown if smaller.
I would like to have results sorted by type like in MacOs spotlight(Files, Apps, Documents).
Results will be more transparent to read.
![image](https://github.com/microsoft/PowerToys/assets/95977497/237cffde-7580-4046-9107-edcfc4da66f0)


### Scenario when this would be used?

In PowerToysRun everytime.

### Supporting information

_No response_
Repository: PowerToys
Issue: Global settings Sharing
Labels: Needs-Triage

### Description of the new feature / enhancement

If there will be better option to share settings with other pcs. At least option to save config file to desktop and apply that file in other pc.

### Scenario when this would be used?

If I want to share settings with my second pc.

### Supporting information

_No response_
Repository: terminal
Issue: impossible-to-move white boxes drawn all over taskbar and on desktop, outside of windows terminal
Labels: Issue-Bug,Product-Terminal,Area-Windowing

### Windows Terminal version

1.16.10261.0

### Windows build number

10.0.19045.2965

### Other Software

* running 4 monitors, 3 1080p + 1 VGA

* verified that the bug still works regardless of whether DisplayFusion window manager is running

### Steps to reproduce

Open multiple tabs.   

### Expected Behavior

Widows Terminal only draws inside of its own windows

### Actual Behavior

View it on youtube -> https://youtu.be/UfArtJ9bbB8

1) Windows Terminal draws a white box at the upper left of my primary monitor that is there at all times

2) Windows Terminal draws several white rectangles behind the taskbar (not visible when the taskbar is visible).   Approximately one per tab.  

3) The white rectangles behind the taskbar can be made to disappear and reappear by minimizing instances of windows terminal (easier to reproduce and view when done on another monitor).  I will make a youtube video of this.
![picture](https://github.com/microsoft/terminal/assets/789591/8687699b-8796-4964-aebd-70d2ec159597)

4) Typically, the white square-ish rectangle on the upper left of the primary monitor is drawn if the console windows **are not** minimized, and white wide rectangles in the taskbar are drawn if the console windows **are** minimized.

[![video]
(https://img.youtube.com/vi/UfArtJ9bbB8/maxresdefault.jpg)]
(https://www.youtube.com/watch?v=UfArtJ9bbB8)
Repository: stable-diffusion-webui
Issue: [Bug]: Compability-Setting for 'DPM++ SDE' behaves unexpected
Labels: bug-report

### Is there an existing issue for this?

- [X] I have searched the existing issues and checked the recent builds/commits

### What happened?

As I've learned here https://github.com/AUTOMATIC1111/stable-diffusion-webui/issues/11131

the Compability-Setting "Do not make DPM++ SDE deterministic across different batch sizes." aka "no_dpmpp_sde_batch_determinism" also affects single pictures of "DPM++ SDE" and "DPM++ SDE Karras" -> It makes them react heavily to Eta noise seed delta (ENSD), which it usually does not.

The simplest "solution" would be to rename the Setting to something like
 `Apply ENSD to "DPM++ SDE"-Variants AND make it non-deterministic across different batch sizes.`



### Steps to reproduce the problem

1. Generate single Image with "DPM++ SDE" and fixed seed.
2. Go to Settings -> Compatibility. Enable "Do not make DPM++ SDE deterministic across different batch sizes.", Apply Settings.
3. Generate same single Image with "DPM++ SDE" and same fixed seed. (different outcome)
4. Change ENSD
5. Generate same single Image with "DPM++ SDE" and same fixed seed. (different outcome)
6. Repeat 3-5 with "DPM++ SDE Karras"

### What should have happened?

Going by the description "Do not make DPM++ SDE deterministic across different batch sizes." I would not expect the Setting to make a difference for a _single_ generated picture. And since https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/cdac5ace1456ba779d5a0171ff8757f31955bfee I would not expect "DPM++ SDE (Karras)" to be affected by ENSD in the first place.

Also, if the ENSD makes a difference, as in this case, I would expect it to be saved in the meta-data, which it currently is not.

If you don't consider this a bug, please consider it a feature request to rename the Setting to something like
 `Apply ENSD to "DPM++ SDE"-Variants AND make it non-deterministic across different "DPM++ SDE" batch runs.`

### Commit where the problem happens

Probably forever, I just really noticed due to changes of cdac5ac

### What Python version are you running on ?

Python 3.10.x

### What platforms do you use to access the UI ?

Windows

### What device are you running WebUI on?

Nvidia GPUs (RTX 20 above)

### What browsers do you use to access the UI ?

Mozilla Firefox

### Command Line Arguments

```Shell
--opt-channelslast --opt-sdp-no-mem-attention --no-half-vae
```


### List of extensions

De-installed all  non built-in extensions

### Console logs

```Shell
Nothing that indicates problems
```


### Additional information

The simplest solution would be to rename the Setting to something like
 `Apply ENSD to "DPM++ SDE"-Variants AND make it non-deterministic across different "DPM++ SDE" batch runs.`
Repository: pytorch
Issue: RuntimeError: CUDA error: unknown error
Labels: oncall: distributed,triaged,module: fsdp

### 🐛 Describe the bug

![image](https://github.com/pytorch/pytorch/assets/39661319/da0f9a22-de47-4942-8319-d279c6a682a6)


### Versions

RuntimeError: CUDA error: unknown error
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 8193) of binary: /home/win10-ubuntu/anaconda3/envs/vicuna-7b/bin/python3.10
Traceback (most recent call last):
  File "/home/win10-ubuntu/anaconda3/envs/vicuna-7b/bin/torchrun", line 8, in <module>
    sys.exit(main())
  File "/home/win10-ubuntu/anaconda3/envs/vicuna-7b/lib/python3.10/site-packages/torch/distributed/elastic/multiprocessing/errors/__init__.py", line 346, in wrapper
    return f(*args, **kwargs)
  File "/home/win10-ubuntu/anaconda3/envs/vicuna-7b/lib/python3.10/site-packages/torch/distributed/run.py", line 794, in main
    run(args)
  File "/home/win10-ubuntu/anaconda3/envs/vicuna-7b/lib/python3.10/site-packages/torch/distributed/run.py", line 785, in run
    elastic_launch(
  File "/home/win10-ubuntu/anaconda3/envs/vicuna-7b/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 134, in __call__
    return launch_agent(self._config, self._entrypoint, list(args))
  File "/home/win10-ubuntu/anaconda3/envs/vicuna-7b/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 250, in launch_agent
    raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
============================================================
fastchat/train/train_mem.py FAILED
------------------------------------------------------------
Failures:
  <NO_OTHER_FAILURES>
------------------------------------------------------------
Root Cause (first observed failure):
[0]:
  time      : 2023-06-10_20:45:09
  host      : DESKTOP-LA7GLEG.localdomain
  rank      : 0 (local_rank: 0)
  exitcode  : 1 (pid: 8193)
  error_file: <N/A>
  traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
![image](https://github.com/pytorch/pytorch/assets/39661319/ab44828a-414b-4fe6-99ca-28c0f0fa2253)


cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu
Repository: go
Issue: crypto/elliptic: P256 ScalarBaseMult with order-34 yields point at infinity
Labels: NeedsInvestigation

### What version of Go are you using (`go version`)?

Latest Go development branch

### Does this issue reproduce with the latest release?

No. Tested latest using latest binary releases of Go 1.19 and 1.20; not affected, hence I'm creating a public bug report for this.

### What operating system and processor architecture are you using (`go env`)?

Linux x64

### What did you do?

```go
package main

import (
	"crypto/elliptic"
	"fmt"
	"math/big"
)

func main() {
	curve := elliptic.P256()
	priv, _ := new(big.Int).SetString("115792089210356248762697446949407573529996955224135760342422259061068512044335", 10)
	x, y := curve.ScalarBaseMult(priv.Bytes())
	fmt.Println(x, ",", y)
}
```

https://go.dev/play/p/aTrVUdp0SkH?v=gotip

### What did you expect to see?

`21538630073048560509735576007149539115526969787353231629118474871518563178910 , 60188232952792585766986390787318113745120282298037326219660563054891997721808`

### What did you see instead?

`0, 0`
Repository: pytorch
Issue: torchgen/gen_backend_stubs.py compatibility with DispatchStubs
Labels: triaged,module: dispatch,module: codegen,module: structured kernels

### 🚀 The feature, motivation and pitch

For our out-of-tree backend, I would like to support many structured kernels similar to how is done in CUDA, i.e. registering `DispatchStub` per operation, similar to how is done [here](https://github.com/pytorch/pytorch/blob/03101a227f6639d5a9ad628d1dc300f9f99a8812/aten/src/ATen/native/cuda/BinaryMulKernel.cu#L46), for `PrivateUse1`, the support for registering stubs was added in [this PR](https://github.com/pytorch/pytorch/pull/99611). 

This PR however, does not tackle how to implement structured kernels in the same manner. It would be nice if [`get_backend_stubs.py`](https://github.com/pytorch/pytorch/blob/03101a227f6639d5a9ad628d1dc300f9f99a8812/torchgen/native_function_generation.py) could support implementation paths of this form instead.

I'm not certain as to whether `torchgen` could support the reuse of these kernels with overridden headers, which is how we've implemented a method to redirect CUDA kernel launches from our backend successfully with various unstructured kernels.

### Alternatives

_No response_

### Additional context

_No response_

cc @ezyang @bhosmer @bdhirsh