sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: excalidraw
Issue: Shortcut to write[needed QOL feature]
Labels: enhancement,freedraw

SO if i want to quickly scribble something from my laptop it's hard to write while pressing the trackpad maybe add an option to write using shortcut key, maybe i am not being clear let me give you an example

"If i press suppose option key or command key on my mac with one hand then just swipe on my trackpad it should register that as a indication to listen for mouse's position and draw however i swiped, or when you sign a pdf from your mac using preview app, when you have to sign you just click once on the spot and draw your signature on trackpad without it being pressed down at all times while writing"

and i think this can be easily implemented so please do this it would make it so much easier to write on laptops
Repository: flutter
Issue: Textfied Editable text class  causing crashes
Labels: waiting for customer response,in triage

### Steps to reproduce

1. create text field with expand
2. enter long text init than directly scroll with selection up and down fast than you can see the crash

### Expected results

text field should not crash

### Actual results

```
EditableTextState._handleContextMenuOnScroll.<fn> (editable_text.dart:3880)
SchedulerBinding._invokeFrameCallback (binding.dart:1397)
SchedulerBinding.handleDrawFrame (binding.dart:1331)
SchedulerBinding._handleDrawFrame (binding.dart:1176)
```

### Code sample

<details open><summary>Code sample</summary>

```dart
[Paste your code here]
```

</details>


### Screenshots or Video

<details open>
<summary>Screenshots / Video demonstration</summary>

[Upload media here]

</details>


### Logs

<details open><summary>Logs</summary>

```console
[Paste your logs here]
```

</details>


### Flutter Doctor output

<details open><summary>Doctor output</summary>

```console
[Paste your output here]
```

</details>
Repository: pytorch
Issue: How to correctly asynchronously copy a GPU tensor to a CPU tensor in another process without introducing blocking?
Labels: needs reproduction,oncall: distributed,triaged

### 🐛 Describe the bug

I am developing a distributed PyTorch application designed to asynchronously transfer data from a GPU process to a CPU process, ensuring that GPU computations remain non-blocking. In my current implementation, I utilize the non-blocking copy_ method to transfer data from a GPU tensor to a CPU tensor and then employ dist.isend to send the data to another rank. However, under certain conditions, this setup leads to a deadlock.
```python
import torch
import torch.distributed as dist
import os

def gpu_to_cpu_and_send(rank, size):
    tensor = torch.randn(4096, 8192).cuda(rank)  # On specific GPU
    print(tensor[-1][-1])
    print(f"Rank {rank}: Created tensor on GPU")
    cpu_tensor = torch.zeros(4096, 8192)
    cpu_tensor.copy_(tensor, non_blocking=True)  # Non-blocking GPU to CPU copy
    print(f"Rank {rank}: Copied tensor to CPU (non-blocking)")

    if rank == 0:
        print(f"Rank {rank}: Sending tensor to rank 1")
        dist.isend(tensor=cpu_tensor, dst=1)  # Sending data to rank 1
        print(f"Rank {rank}: Data sent to rank 1")

def receive_data(rank, size):
    received_tensor = torch.zeros(4096, 8192)
    print(f"Rank {rank}: Waiting to receive data")
    dist.recv(tensor=received_tensor, src=0)  # Receiving data from rank 0
    print(f"Rank {rank}: Received data from rank 0")
    print(received_tensor[-1][-1])

def main():
    rank = int(os.environ['RANK'])
    size = int(os.environ['WORLD_SIZE'])
    dist.init_process_group(backend='gloo', rank=rank, world_size=size)

    if rank == 0:
        gpu_to_cpu_and_send(rank, size)
    elif rank == 1:
        receive_data(rank, size)

if __name__ == "__main__":
    main()
```

### Versions

torchrun --nproc_per_node=2 demo.py

Run with Nvidia GPU.

cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
Repository: neovim
Issue: Built-in which-key plugin
Labels: enhancement

### Problem

Currently, one of the barrier to keyboard-centric editor like Vim/Neovim is that there are too many keymappings to remember. And this is just worse when plugins also introduce their own mappings. 

Both Emacs and Helix has something like [which-key.nvim](https://github.com/folke/which-key.nvim) built-in. I don't know since when has Helix implemented it, but this is [the commit that added the package to Emacs](https://github.com/emacs-mirror/emacs/commit/fa4203300fde6820a017bf1089652fb95759d68c#diff-21241810a84cc186b99d148f58af8e3725198fd1bdad73a9ed5c44bb93b52e88R264). 


### Expected behavior

When users type a key, a floating window (like `which-key.nvim`) or a popup menu (like Helix) open to show users key bindings that start with the key(s) users have typed. 

#### How does it solve the problem?

This reduces the burden of having to remember too many keymaps, while also helping users remember them and use the keyboard more effectively. Also, it will make Neovim friendlier to beginners

An alternative would be just installing a plugin. But many people don't even know such plugins exist, or how they look like. 

#### Is it worth the cost?

I believe so. As long as Neovim and keyboard-centric modal editing exists, the problem would still exists, and the plugin would always be valuable.
Repository: rust
Issue: Tracking Issue for `int_from_ascii`
Labels: T-libs-api,C-tracking-issue

Feature gate: `#![feature(int_from_ascii)]`

This is a tracking issue for `int_from_ascii`, providing equivalent methods to `{usize,u8,u16,u32,u64,u128,isize,i8,i16,i32,i64,i128}::from_str()` and `from_str_radix()` that allow working directly on byte slices, in order to skip UTF-8 validation.

### Public API

For each integer type `T` (`usize`, `u8`, `u16`, `u32`, `u64`, `u128`, `isize`, `i8`, `i16`, `i32`, `i64`, `i128`):

```rust
// core::num

impl T {
    pub const fn from_ascii(src: &[u8]) -> Result<T, ParseIntError>;
    pub const fn from_ascii_radix(src: &[u8], radix: u32) -> Result<T, ParseIntError>;
}
```

### Steps / History

- [x] Abandoned implementation: #105206
- [x] API change proposal: https://github.com/rust-lang/libs-team/issues/469
- [ ] Implementation: #134824
- [ ] Final comment period (FCP)[^1]
- [ ] Stabilization PR

### Unresolved Questions

- None yet.

[^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html
Repository: PowerToys
Issue: PowerToys Run lost the acrylic effect again
Labels: Issue-Bug,Product-PowerToys Run,Area-User Interface

### Microsoft PowerToys version

0.87.1

### Installation method

Microsoft Store

### Running as admin

Yes

### Area(s) with issue?

As had already happened in May of last year, Run no longer shows the acrylic effect, maybe it is related to the recent fix "Ported the UI from WPF-UI to .NET 9 WPF".
[This](https://github.com/microsoft/PowerToys/issues/33135) is the last thread where the problem was investigated and the solution was found.

### Steps to reproduce

### ✔️ Expected Behavior

_No response_

### ❌ Actual Behavior

_No response_

### Other Software

_No response_
Repository: vscode
Issue: terminal title supports branch variable
Labels: feature-request,terminal-tabs

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

The `terminal.integrated.tabs.title` and `terminal.integrated.tabs.description` settings support the `${branch}` variable.

In the same workspace, using git worktree to check out different branches and displaying the branch name will make it easier to distinguish between different terminals.
Repository: TypeScript
Issue: Possible regression of intersection type inference in 5.7.2 compared to 5.6.3
Labels: Help Wanted,Possible Improvement

### 🔎 Search Terms

inference generic types

### 🕗 Version & Regression Information

- This changed between versions 5.6.3 and 5.7.2
- This changed in commit or PR https://github.com/microsoft/TypeScript/pull/52095


### ⏯ Playground Link

https://www.typescriptlang.org/play/?ts=5.7.2#code/MYGwhgzhAEBqYCcCWYBGICmAeAqgGmgGVoMAPAFwwDsATGCc5KgcwD5oBvAKGmmAHsqDBAFdg5fggAUABxHokwaBABcRAJSdoAXx7QRAQjU4A3F11cAZiKrikg6AFsA1gHFqGZMFwFiZSrT0jEgsrFKqGpx6CBjkIghU0FQYAO5wiCjo2PhEYRDq5lxc5ACeMhjQAKKkYOIAggjMAHJgjhgQWO7JXgAqZRgEAMKCwmAh5OwAvNBdnop95dAAZFG8ANoA0tAh0M4YJfyWMx69-QC6alv+1HS7+4fQw0KMY1Tk0AD8x93z-Ztn0DUyQAbp5CsV+tA6iAQPwUvBkGhMB0elN0oislgegQwFQSuwAD5aTbbRJ7A5HHoXdGZTBY-44vGE6A9f46IqlRY9drkBrMGDTbi8CD8Np8oEiRyoMEWTkVbkMPkQADqSHIAAsEQKoTC4Qjae0sTylawitZbOR7IlyGA9hBZl4sLASBQbjBobD4RkkYaFbzGhBWGEwGpqrV-c1WobYAQ-Sb1GpgfwkDQohZMO9gdBpja7Q7FFIOCKxY01C588ApAAiUhV9TadRmIA

### 💻 Code

```ts
class Variable<U, S extends string> {
  constructor(public s: S) { }
  u!: U;
}

function mkGeneric<U, S extends string>(s: S) {
  return new Variable<U, S>(s)
}

type ExactArgNames<GenericType, Constraint> = GenericType & {
  [K in keyof GenericType]: K extends keyof Constraint ? GenericType[K] : never
}

type AllowVariables<T> = Variable<T, any> | { [K in keyof T]: Variable<T[K], any> | T[K] }

type TestArgs = {
  someArg: number
}

type TestArgsWithVars = AllowVariables<TestArgs>

function takesGeneric<V extends AllowVariables<TestArgs>>(a: ExactArgNames<V, TestArgs>): void {
}

let v = takesGeneric({someArg: mkGeneric("x")});
```


### 🙁 Actual behavior

VVersion 5.7.2 of the compiler infers the variable type as Variable<uknown, "x"> and subsequently generates an error

### 🙂 Expected behavior

VVersion 5.6.3 of the compiler infers the variable type correctly as `Variable<number, "x">`

### Additional information about the issue

This is breaking most code that uses typed-graphql-builder https://github.com/typed-graphql-builder/typed-graphql-builder/issues/85
Repository: PowerToys
Issue: broken preview pane
Labels: Issue-Bug,Needs-Triage

### Microsoft PowerToys version

0.87.1

### Installation method

Microsoft Store

### Running as admin

No

### Area(s) with issue?

File Explorer: Preview Pane

### Steps to reproduce

fresh windows install, install powertoys preview breaks

### ✔️ Expected Behavior

to see any txt style preview

### ❌ Actual Behavior

cant be previewed, even a .txt

### Other Software

fresh win install to make sure no conflicts, twice!
Repository: tauri
Issue: [feat] Centralize mobile app configuration in Tauri configuration files
Labels: type: feature request

### Describe the problem

Today, a lot of mobile app configuration requires knowledge of editing mobile platform-specific configuration files for managing permissions, signing, etc.

### Describe the solution you'd like

As it does for desktop, Tauri would allow setting mobile configuration in Tauri's cross-platform configuration files.

### Alternatives considered

None

### Additional context

None

---
Thanks
Repository: langchain
Issue: Add "developer" role support to ChatPromptTempkate
Labels: Ɑ:  core

### Privileged issue

- [X] I am a LangChain maintainer, or was asked directly by a LangChain maintainer to create an issue here.

### Issue Content

Add support for 
```python
ChatPromptTemplate([("developer", "...")])
```
Repository: pytorch
Issue: The link for the source in page torch.Tensor.backward is broken.
Labels: module: docs,module: autograd,triaged,needs design

### 📚 The doc issue

The link for the source in page torch.Tensor.backward is broken.[link](https://pytorch.org/docs/stable/generated/torch.Tensor.backward.html)

### Suggest a potential alternative/fix

_No response_

cc @svekars @brycebortree @sekyondaMeta @AlannaBurke @ezyang @albanD @gqchen @pearu @nikitaved @soulitzer @Varal7 @xmfan
Repository: go
Issue: x/tools/gopls: revisit the set of 'quickfix' refactorings
Labels: gopls,Tools

Why can gopls@v0.16.2 do fill struct code action and gopls@v0.17.1 doesn't

feature or bug ?
<img width="633" alt="image" src="https://github.com/user-attachments/assets/82e11a15-603e-4eee-a4b1-0f2dababe2b1" />
gopls@v0.17.1 

<img width="311" alt="image" src="https://github.com/user-attachments/assets/7976b879-e6d9-4ae2-a7c4-fca583b9ba4d" />
gopls@v0.16.2
Repository: PowerToys
Issue: Workspaces Incorrect File error when running as admin
Labels: Issue-Bug,Needs-Triage,Product-Workspaces

### Microsoft PowerToys version

0.87.1

### Installation method

GitHub

### Running as admin

Yes

### Area(s) with issue?

Workspaces

### Steps to reproduce

 - run powertoys as an Admin user (ie, seperate account from the logged in user)
 - create new workspace with any configuration
 - try launching the workspace


### ✔️ Expected Behavior

It works

`<admin account>\AppData\...\workspaces.json` is the file that is written to when creating or editing a workspace in my scenario, but 
`<logged in user>\AppData\...\workspaces.json` is the file that is read when launching a workspace.

Either the admin account `workspaces.json` should be read (as that is the one that's written when creating/editing a workspace), OR the logged in user `workspaces.json` should be the one that is written (as that is the one that is read when the workspace is launched). 

As a workaround, I simply copied `<admin account>\AppData\...\workspaces.json` to `<logged in user>\AppData\...\workspaces.json`

### ❌ Actual Behavior

 ![Image](https://github.com/user-attachments/assets/e8fdc5fe-a10c-4087-8e61-be0626239f80)


### Other Software

_No response_
Repository: godot
Issue: CanvasItemMaterial Light Mode Only not working with lights
Labels: enhancement,discussion,topic:rendering,topic:2d

### Tested versions

4.3

### System information

Windows 11, Godot 4.3

### Issue description

You can add the CanvasItemMaterial to lights and set Light Mode Light Only but it doesn't work.

### Steps to reproduce

Add the CanvasItemMaterial to PointLight2d and set Light Mode Light Only, doesn't work.

### Minimal reproduction project (MRP)

N/A
Repository: pytorch
Issue: Set up Mac builds with clang >= 17 even though Xcode only has at most clang 16
Labels: module: binaries,module: ci,triaged,enhancement

### 🚀 The feature, motivation and pitch

This would enable a couple disparate improvements:
1) Our binary releases should include the latest compiler features and optimizations. The concrete motivating example is that the compiler used for Mac wheels apparently doesn't pass [`COMPILER_SUPPORTS_BF16_TARGET`](https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/cpu/ReducedPrecisionFloatGemvFastPathKernel.cpp#L161) (i.e., clang version greater than 15), which causes a slower bfloat16 gemv kernel to be used.
2) We should have test coverage for CPU bfloat16 support on Mac (#142703) -- clang 16 purports to be able to build it, but is buggy and we actually need 17+.

### Alternatives

do nothing until Apple gets around to releasing an Xcode with clang 17 or later and we get around to updating to it.

### Additional context

Xcode clang version history: https://gist.github.com/yamaya/2924292 . Latest at time of writing is Xcode 16.2 with `Apple clang version 16.0.0 (clang-1600.0.26.6)`

cc @seemethere @malfet @osalpekar @atalman @pytorch/pytorch-dev-infra
Repository: pytorch
Issue: RuntimeError: could not create an engine
Labels: module: windows,triaged,module: xpu

### 🐛 Describe the bug

Hi, I experienced the following error (the message before the exception):

File c:\Users\xiaoy\anaconda3\envs\llm2\Lib\site-packages\torch\nn\modules\linear.py:125, in Linear.forward(self, input)
124 def forward(self, input: Tensor) -> Tensor:
--> 125 return F.linear(input, self.weight, self.bias)

RuntimeError: could not create an engine

The code is running fine if I set the device to 'cpu'. But when I set it to 'xpu', I got the above error.

GPU: Intel ARC B580 (with the latest driver)
OS: Windows 11
Conda/Python: 3.12
PyTorch instance:
pip3 install --pre torch --index-url https://download.pytorch.org/whl/nightly/xpu

### Versions

PyTorch version: 2.6.0.dev20241222+xpu
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: Microsoft Windows 11 Pro (10.0.26100 64-bit)
GCC version: Could not collect
Clang version: Could not collect
CMake version: Could not collect
Libc version: N/A

Python version: 3.12.8 | packaged by Anaconda, Inc. | (main, Dec 11 2024, 16:48:34) [MSC v.1929 64 bit (AMD64)] (64-bit runtime)
Python platform: Windows-11-10.0.26100-SP0
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Name: Intel(R) Core(TM) i7-14700K
Manufacturer: GenuineIntel
Family: 198
Architecture: 9
ProcessorType: 3
DeviceID: CPU0
CurrentClockSpeed: 3400
MaxClockSpeed: 3400
L2CacheSize: 28672
L2CacheSpeed: None
Revision: None

Versions of relevant libraries:
[pip3] numpy==2.2.1
[pip3] torch==2.6.0.dev20241222+xpu
[conda] numpy                     2.2.1                    pypi_0    pypi
[conda] torch                     2.6.0.dev20241222+xpu          pypi_0    pypi

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @gujinghui @EikanWang @fengyuan14 @guangyey
Repository: flutter
Issue: Make _LocalizedShortcutLabeler public
Labels: framework,f: material design,c: proposal,P3,team-design,triaged-design

### Use case

Showing customizable shortcuts in the app could be a lot of code.
Making the built in public could simplify the code.

Additionally this could be useful to make my own menuitembutton with shortcuts.

### Proposal

Change the name of the class from `_LocalizedShortcutLabeler` to `LocalizedShortcutLabeler`.
https://github.com/flutter/flutter/blob/59e57437dba691e045dc417c705a9dc48db8acfb/packages/flutter/lib/src/material/menu_anchor.dart#L2292
Repository: vscode
Issue: Some sidebar items, such as Copilot Edits, select colors from unrelated elements
Labels: bug,cross-file-editing

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.96.2
- OS Version: Windows 10, Windows 11

Steps to Reproduce:

1. Activate any color theme with sidebars that use a different color scheme than the main editor window.
2. Open Copilot Edits.

Items in the sidebar may be invisible or difficult to see depending on the source elements use color. In this example, the main editor uses a light background with dark text, while the sidebars use a dark background with light text. The Copilot Edits file list uses the background of the main editor and the text color of the sidebars, causing its text to have almost no contrast against its background.

![Image](https://github.com/user-attachments/assets/49abdad6-3dea-4ea3-9855-ce891d0c7e08)

I suggest that sidebar widgets should select colors from a single source section that would use paired background/foreground. I.e., all from the editor settings, all from sidebar settings, etc.
Repository: PowerToys
Issue: Have setting for Screen Ruler to close on click
Labels: Needs-Triage

### Description of the new feature / enhancement

When this setting is enabled, then clicking anywhere on the screen whilst in ruler mode will:
1. Copy the measurement to the clipboard (as it does presently)
2. Close the ruler (_not done presently_)

The only ways to close the ruler currently are to move the mouse back to the top of the screen and close the utility, or to press ESC on the keyboard.

### Scenario when this would be used?

I have a button on my screen that calls an AutoHotkey script. This script in turn enters the necessary keyboard combination to open the ruler. I have created this button so that I can quickly make measurements with just the mouse. The current options of closing the utility are slower than just being able to click the mouse (where my hand and cursor already are) rather than having to move my hand to the ESC key or the cursor to the top of the screen.

### Supporting information

_No response_
Repository: vscode
Issue: Please add "Diff Editor: Render Side By Side" to the Command Palette or to the diff view's context menu, or to the both places
Labels: info-needed

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

When dealing with the diff view, sometimes it is more preferable to see the diff (changes) inline rather than side by side. It completely depends on the nature of changes in each particular file, so the option hidden somewhere under Settings -> Text Editor -> Diff Editor is not a good way to change this setting frequently, on-the-fly, by demand.
If such an option existed in the Command Palette or in the diff view's context menu, or in the both places, it would be much more handy.
Repository: next.js
Issue: Nested node_modules causes incorrect bundling
Labels: Upstream,Webpack,Turbopack

### Link to the code that reproduces this issue

https://github.com/Netail/repro-nested-modules

### To Reproduce

1. Install packages using `yarn install`
2. Run the web app `yarn dev`
3. Observe `[TypeError: this.getDefaultUrl is not a function]` being thrown

### Current vs. Expected behavior

The error itself seems to come from the file `OTLPExporterBase.js` in the `@opentelemetry/otlp-exporter-base` package.

In the `packages/client-observability` package we use `@grafana/faro-web-tracing`, which under water uses `@opentelemetry/otlp-exporter-base` version v0.53.0

In the `packages/server-observability` package we use `@opentelemetry/otlp-grpc-exporter-base`, which under water uses `@opentelemetry/otlp-exporter-base` version v0.57.0

Since v0.54.0 the getDefaultUrl has been removed / replaced. Each have their own version installed somewhere in the `node_modules`, so each should target their own version.

v0.53.0 is located directly node_modules folder (`node_modules/@opentelemetry/otlp-exporter-base`) and v0.57.0 is located in a nested node_modules folder (`node_modules/@opentelemetry/otlp-grpc-exporter-base/node_modules/@opentelemetry/otlp-exporter-base`). For some reason, bundling seems to be taking v0.57.0 in both cases. Throwing the error for the packages which should use v0.53.0.

If I revert the 0.57.0 versions in the server-observability package, the dev server starts without errors

### Provide environment information

```bash
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:15 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6000
  Available memory (MB): 32768
  Available CPU cores: 10
Binaries:
  Node: 22.11.0
  npm: 10.9.0
  Yarn: 1.22.22
  pnpm: 9.6.0
Relevant Packages:
  next: 15.1.3 // Latest available version is detected (15.1.3).
  eslint-config-next: N/A
  react: 19.0.0
  react-dom: 19.0.0
  typescript: 5.5.4
Next.js Config:
  output: N/A
```


### Which area(s) are affected? (Select all that apply)

Turbopack, Upstream, Webpack

### Which stage(s) are affected? (Select all that apply)

next dev (local), next start (local)

### Additional context

This happens for both Webpack & Turbopack, could possible be upstream?