Repository: pytorch
Issue: NNC failing opinfo accuracy tests
Labels: NNC

### 🐛 Describe the bug

These started failing after fixing the opinfo tests so that the NNC-fused kernels would actually run.

See https://github.com/pytorch/pytorch/runs/6070298059?check_suite_focus=true for the full logs.

Failing tests:
* [ ] test_nnc_correctness_addcmul_cpu_int16
* [ ] test_nnc_correctness_addcmul_cpu_int32
* [ ] test_nnc_correctness_addcmul_cpu_int64
* [ ] test_nnc_correctness_addcmul_cpu_int8
* [ ] test_nnc_correctness_bool_channels_last_cpu_int8
* [ ] test_nnc_correctness_bool_cpu_int8
* [ ] test_nnc_correctness_frac_cpu_float32
* [ ] test_nnc_correctness_frac_cpu_float64

logs:
```
======================================================================
FAIL [0.132s]: test_nnc_correctness_addcmul_cpu_int16 (__main__.TestNNCOpInfoCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
    result = test(self, **param_kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 773, in test_wrapper
    return test(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1097, in wrapper
    fn(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 930, in only_fn
    return fn(slf, *args, **kwargs)
  File "test_jit_fuser_te.py", line 2583, in test_nnc_correctness
    self.assertEqual(ref, val)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2203, in assertEqual
    msg=msg,
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1074, in assert_equal
    raise error_metas[0].to_error()
AssertionError: Tensor-likes are not equal!

Mismatched elements: 17 / 25 (68.0%)
Greatest absolute difference: 8 at index (3, 1)
Greatest relative difference: 0.047619047619047616 at index (4, 1)


======================================================================
FAIL [0.116s]: test_nnc_correctness_addcmul_cpu_int32 (__main__.TestNNCOpInfoCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
    result = test(self, **param_kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 773, in test_wrapper
    return test(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1097, in wrapper
    fn(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 930, in only_fn
    return fn(slf, *args, **kwargs)
  File "test_jit_fuser_te.py", line 2583, in test_nnc_correctness
    self.assertEqual(ref, val)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2203, in assertEqual
    msg=msg,
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1074, in assert_equal
    raise error_metas[0].to_error()
AssertionError: Tensor-likes are not equal!

Mismatched elements: 17 / 25 (68.0%)
Greatest absolute difference: 8 at index (3, 1)
Greatest relative difference: 0.047619047619047616 at index (4, 1)


======================================================================
FAIL [0.116s]: test_nnc_correctness_addcmul_cpu_int64 (__main__.TestNNCOpInfoCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
    result = test(self, **param_kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 773, in test_wrapper
    return test(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1097, in wrapper
    fn(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 930, in only_fn
    return fn(slf, *args, **kwargs)
  File "test_jit_fuser_te.py", line 2583, in test_nnc_correctness
    self.assertEqual(ref, val)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2203, in assertEqual
    msg=msg,
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1074, in assert_equal
    raise error_metas[0].to_error()
AssertionError: Tensor-likes are not equal!

Mismatched elements: 17 / 25 (68.0%)
Greatest absolute difference: 8 at index (3, 1)
Greatest relative difference: 0.047619047619047616 at index (4, 1)


======================================================================
FAIL [0.128s]: test_nnc_correctness_addcmul_cpu_int8 (__main__.TestNNCOpInfoCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
    result = test(self, **param_kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 773, in test_wrapper
    return test(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1097, in wrapper
    fn(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 930, in only_fn
    return fn(slf, *args, **kwargs)
  File "test_jit_fuser_te.py", line 2583, in test_nnc_correctness
    self.assertEqual(ref, val)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2203, in assertEqual
    msg=msg,
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1074, in assert_equal
    raise error_metas[0].to_error()
AssertionError: Tensor-likes are not equal!

Mismatched elements: 17 / 25 (68.0%)
Greatest absolute difference: 8 at index (3, 1)
Greatest relative difference: 0.1702127659574468 at index (3, 1)


======================================================================
FAIL [0.240s]: test_nnc_correctness_bool_channels_last_cpu_int8 (__main__.TestNNCOpInfoCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
    result = test(self, **param_kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 773, in test_wrapper
    return test(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1097, in wrapper
    fn(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 930, in only_fn
    return fn(slf, *args, **kwargs)
  File "test_jit_fuser_te.py", line 2583, in test_nnc_correctness
    self.assertEqual(ref, val)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2203, in assertEqual
    msg=msg,
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1074, in assert_equal
    raise error_metas[0].to_error()
AssertionError: Tensor-likes are not equal!

Mismatched elements: 31 / 36 (86.1%)
Greatest absolute difference: 254 at index (0, 2, 0, 1)
Greatest relative difference: 0.99[6078](https://github.com/pytorch/pytorch/runs/6070298059?check_suite_focus=true#step:9:6078)431372549 at index (0, 2, 0, 1)


======================================================================
FAIL [0.028s]: test_nnc_correctness_bool_cpu_int8 (__main__.TestNNCOpInfoCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
    result = test(self, **param_kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 773, in test_wrapper
    return test(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1097, in wrapper
    fn(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 930, in only_fn
    return fn(slf, *args, **kwargs)
  File "test_jit_fuser_te.py", line 2583, in test_nnc_correctness
    self.assertEqual(ref, val)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2203, in assertEqual
    msg=msg,
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1074, in assert_equal
    raise error_metas[0].to_error()
AssertionError: Scalars are not equal!

Absolute difference: 247
Relative difference: 0.9959677419354839


======================================================================
FAIL [0.033s]: test_nnc_correctness_frac_cpu_float32 (__main__.TestNNCOpInfoCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
    result = test(self, **param_kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 773, in test_wrapper
    return test(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1097, in wrapper
    fn(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 930, in only_fn
    return fn(slf, *args, **kwargs)
  File "test_jit_fuser_te.py", line 2583, in test_nnc_correctness
    self.assertEqual(ref, val)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2203, in assertEqual
    msg=msg,
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1074, in assert_equal
    raise error_metas[0].to_error()
AssertionError: Tensor-likes are not close!

Mismatched elements: 11 / 20 (55.0%)
Greatest absolute difference: 1.0 at index (0,) (up to 1e-05 allowed)
Greatest relative difference: 37.067545712442445 at index (14,) (up to 1.3e-06 allowed)


======================================================================
FAIL [0.033s]: test_nnc_correctness_frac_cpu_float64 (__main__.TestNNCOpInfoCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
    result = test(self, **param_kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 773, in test_wrapper
    return test(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1097, in wrapper
    fn(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 930, in only_fn
    return fn(slf, *args, **kwargs)
  File "test_jit_fuser_te.py", line 2583, in test_nnc_correctness
    self.assertEqual(ref, val)
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2203, in assertEqual
    msg=msg,
  File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1074, in assert_equal
    raise error_metas[0].to_error()
AssertionError: Tensor-likes are not close!

Mismatched elements: 14 / 20 (70.0%)
Greatest absolute difference: 1.0 at index (0,) (up to 1e-07 allowed)
Greatest relative difference: 35.59956005068432 at index (4,) (up to 1e-07 allowed)


----------------------------------------------------------------------
Ran 5295 tests in 1695.779s

FAILED (failures=8, skipped=821, expected failures=45)

Generating XML reports...
Generated XML report: test-reports/python-unittest/test_jit_fuser_te/TEST-TestNNCOpInfoCPU-20220419001401.xml
Generated XML report: test-reports/python-unittest/test_jit_fuser_te/TEST-jit.test_fuser_common.TestFuserCommon-20220419001401.xml
Generated XML report: test-reports/python-unittest/test_jit_fuser_te/TEST-TestLoopnestRandomizationCPU-20220419001401.xml
Generated XML report: test-reports/python-unittest/test_jit_fuser_te/TEST-TestTEFuserDynamic-20220419001401.xml
Generated XML report: test-reports/python-unittest/test_jit_fuser_te/TEST-TestTEFuserStatic-20220419001401.xml
Traceback (most recent call last):
  File "test/run_test.py", line 1058, in <module>
    main()
  File "test/run_test.py", line 1036, in main
    raise RuntimeError(err_message)
RuntimeError: test_jit_fuser_te failed!
```

### Versions

master, CI

cc @ZolotukhinM