sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: Allow switching to verbose mode without having to kill the flutter tool
Labels: c: new feature,tool,P3,team-tool,triaged-tool

It would be nice if verbose logging can be turned on via a keyboard shortcut:

r - hot reload
R - hot restart
v - enable/disable verbose logging

This is a minor FR. Motivation is to support users who either forget to pass the `-v` flag or use flutter tooling in build/run subsystems that wrap `flutter` tools where it might not be trivial to pass options through.
Repository: three.js
Issue: UniformUtils.cloneUniforms() does not clone arrays of objects.
Labels: Enhancement

##### Description of the problem

Right now in `UniformUtils.cloneUniforms` when a uniform is a THREE object, it properly clones it, and when it is an array of primitives, it properly slices it, but if the uniform is an array of THREE objects (say an array of Vector3), it does not clone the individual objects.

There needs to be another check within the `} else if ( Array.isArray( property ) ) {` condition that checks if the items in the array are THREE objects are just primitives. Since they all must be the same type because of GLSL restrictions, I suppose that only the first element needs to be checked.

##### Three.js version

- [x] Dev
- [x] r103
- [ ] ...

##### Browser

- [x] All of them
- [ ] Chrome
- [ ] Firefox
- [ ] Internet Explorer

##### OS

- [x] All of them
- [ ] Windows
- [ ] macOS
- [ ] Linux
- [ ] Android
- [ ] iOS

##### Hardware Requirements (graphics card, VR Device, ...)
Repository: flutter
Issue: Embedded Android views may send accessibility events before the accessibility bridge knows about them
Labels: platform-android,framework,a: accessibility,a: platform-views,P2,team-android,triaged-android

Right now the main problem with this is that it might result with the Android accessibility framework asking the accessibility bridge for an embedded node (we do generate the flutter<-->embedded ID mapping on the fly when an event is sent) and the bridge cannot create the node as the bounds of the embedded view are not yet known.

Right now we are not returning the node in this case.

Potential ways we could handle this better are either to communicate the bounds of the embedded view to the accessibility bridge earlier, or to delay view creation until it is in the semantics tree.
Repository: neovim
Issue: Cursorline has unwanted underline in DiffChange/DiffAdd regions
Labels: compatibility,bug-regression,display,core,highlight

- `nvim --version`: v0.3.4
- Vim (version: v8.1, patches 1-577) behaves differently?
- Operating system/version: macOS 10.13.6 (High Sierra)
- Terminal name/version: iTerm2
- `$TERM`: tmux-256color (but behavior is same outside tmux with xterm-256color)

### Steps to reproduce using `nvim -u NORC`

```
# Create two files to diff, a and b, containing some text with some differences, then:
nvim -u NONE -d a b
```

Turn on `'cursorline'` and define a highlight group for it that does not contain an underline.

```
:set cursorline
:hi clear CursorLine
:hi CursorLine gui=bold
```

### Actual behaviour

On moving the cursor through a changed region in the diff, the lines get underline styling applied, as though `CursorLine` had `gui=bold,underline`. Move the cursor onto a line outside the changed region and see the lines no longer have underline, only bold.

Doesn't happen if `CursorLine` has a fg color (eg. `guifg=#ff0000`), although in practice you probably don't ever want to assign a fg color to `CursorLine`.

Note the underlining on the cursor line in the left-hand pane visible in the screenshot:

<img width="1436" alt="diff" src="https://user-images.githubusercontent.com/7074/55116877-1ddaee80-50e9-11e9-8ad2-92b889654f79.png">

### Expected behaviour

The cursorline shouldn't have underline styling applied when within changed regions in diff mode, unless `CursorLine` actually has underline style turned on.
Repository: godot
Issue: Remember the last used folder for materials and others
Labels: enhancement,topic:editor,usability

**Godot version:**
3.1


**OS/device including version:**
Windows 10 x64 / NVIDIA GeForce GTX 1060 6GB / Intel Core i7 4790K


**Issue description:**
If I do repetitive tasks like insert materials that are in subfolders, Godot always returns to the `res://` folder, so for each operation, I have to repeat all steps until finding that folder again.


**Steps to reproduce:**
1) Load a material (which is located on a subfolder) to a mesh 
2) Repeat the process to other mesh and you'll have to repeat all steps to find the subfolder.
Repository: flutter
Issue: [Inspector] Widget mode tool tips don't respect SafeArea
Labels: framework,f: inspector,P2,team-framework,triaged-framework

From @willlarche 

Using inspector widget mode on iPhone X+, the notch occludes the tool tip for selected widgets in that general area.
![screen shot 2018-10-09 at 11 02 13 am](https://user-images.githubusercontent.com/1271525/46678627-0c417100-cbb3-11e8-8900-57e06b885855.png)

They should respect the MediaQuery padding (SafeArea).

Moving this from: https://github.com/flutter/flutter-intellij/issues/2677
Repository: go
Issue: x/build/cmd/gopherbot: doesn't close re-opened backport issues
Labels: help wanted,Builders,NeedsFix

Issue #29270 was filed about gopherbot being too aggressive about closing backport issues. It fought humans (more than one time) who tried to re-open a backport issue. /cc @bradfitz

The fix to that issue was to have gopherbot check for a `gi.HasEvent("reopened")` event and not consider any re-opened backport issues. It worked to resolve that issue, but it doesn't take into account a situation where a backport issue is re-opened (e.g., because the fix is reverted) and then resolved via another future CL.

This happened in #30266.

Until this is resolved, the workaround is to manually close a backport issue. This situation happens very infrequently, so this is not a high priority bug.
Repository: go
Issue: net/http/httputil: Reverse Proxy X-Forwarded-For include Port
Labels: help wanted,NeedsFix,FeatureRequest

In the reverse proxy the port is not being added to the header `X-Forwarded-For`. The port is not a requirement but optional. From RFC 7329 
```
If the server receiving proxied requests requires some
   address-based functionality, this parameter MAY instead contain an IP
   address (and, potentially, a port number).
```

As the port currently isn't being included by default, and it is something I need, I am explicitly setting the header. The result is I end up with `X-Forwarded-For: 123.34.567.89:9876, 123.34.567.89`. It would be great to either add an option to include the ports or do a check that the value about to be added doesn't already exist in the string (duplicate without the port).

https://github.com/golang/go/blob/3089d189569ed272eaf2bc6c4330e848a46e9999/src/net/http/httputil/reverseproxy.go#L249-L257
Repository: go
Issue: math/big: optimize amd64 asm shlVU and shrVU for shift==0 case
Labels: Performance,help wanted,NeedsFix

When `shift == 0`, `shlVU` and `shrVU` reduce to a memcopy. When `z.ptr == x.ptr`, it further reduces to a no-op. The pure Go implementation has these optimizations, as of https://go-review.googlesource.com/c/go/+/164967. The arm64 implementation has one of them (see https://github.com/golang/go/issues/31084#issuecomment-477406354). We should add both to the amd64 implementation.

cc @griesemer
Repository: TypeScript
Issue: [Design Policy] Consider JSDoc feature parity with Typescript
Labels: Meta-Issue

## Search Terms

jsdoc parity, jsdoc equivalence, jsdoc

## Suggestion

The JSDoc mode of TypeScript is very useful in cases where a build step (esp for node libraries for example) isn't desired or when other constraints prevent not writing in JS. However it can be annoying when trying to implement something that can't be expressed in JSDoc mode due to requiring Typescript syntax.

As such I would like to propose that TypeScript ensures that anything that can be written inside a `.ts` file can be expressed (in at least some way) within a pure javascript + jsdoc file.

In order to get an idea of the current scope needed for feature parity this is a list of issues and features that break parity between the two modes (if any are missing just say and I'll add to the list):

- 
[Bug?] No way to express the `object` type
  - Currently in JSDoc `/** @type {object} */` is equivalent to `/** @type {any} */`, there doesn't seem to be any way to represent `const x: object` purely in JS + JSDoc, this seems like a bug.
 Fixed
- `interface`
- `abstract class`
- 
`protected`/`private` members
 Fixed
- ~function overloading~ v5.0
  - ~[open issue](https://github.com/Microsoft/TypeScript/issues/25590)~
- ~defaults for generics~
  - ~[open issue](https://github.com/Microsoft/TypeScript/issues/29401)~
- `declare` syntax in it's various forms and declaration merging
  - `declare global { ... }`
  - `declare module "moduleName"`
  - `declare class Foo`
  - `declare interface`
  - `declare namespace`
- `namespace`
- `enum`
  - /** @enum */ is not quite equivalent
- ~`as const`~ v4.5
  - ~[open issue](https://github.com/Microsoft/TypeScript/issues/30445)~
- non-null assertion `expr!`

## Checklist

My suggestion meets these guidelines:

* [✓] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [✓] This wouldn't change the runtime behavior of existing JavaScript code
* [✓] This could be implemented without emitting different JS based on the types of the expressions
* [✓] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [✓] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Repository: TypeScript
Issue: Type narrowing on object properties lost in async IIFE
Labels: Suggestion,Experience Enhancement

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  3.4.0-dev.20190327

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
narrowing iife control flow

**Code**

```ts
declare const x: string | undefined;
declare const y: { z: string | undefined };
function needsString(it: string) { return it; }

function a() {
  if (!x) {
    throw new Error("Missing x");
  }
  const res1 = (() => needsString(x))(); // all good, per #8849
  const res2 = (async () => needsString(x))();  // ditto

  if (!y.z) {
    throw new Error("Missing z.")
  }

  const res3 = (() => needsString(y.z))();  // still good
  const res4 = (async () => needsString(y.z))();  // now things blow up  
}
```

**Expected behavior:**
The call to `needsString` in the expression for res4 succeeds, like the one in `res2` and `res3`. Even though the function is async, the code in it -- at least that's before an await -- runs immediately, I believe, and so should be subject to the narrowing (esp. given that `res2` works).

**Actual behavior:**
Error for `needsString(y.z)`: Argument of type 'string | undefined' is not assignable to parameter of type 'string'. 

**Playground Link:** https://www.typescriptlang.org/play/index.html#src=declare%20const%20x%3A%20string%20%7C%20undefined%3B%0Adeclare%20const%20y%3A%20%7B%20z%3A%20string%20%7C%20undefined%20%7D%3B%0Afunction%20needsString(it%3A%20string)%20%7B%20return%20it%3B%20%7D%0A%0Afunction%20a()%20%7B%0A%20%20if%20(!x)%20%7B%0A%20%20%20%20throw%20new%20Error(%22Missing%20x%22)%3B%0A%20%20%7D%0A%20%20const%20res1%20%3D%20(()%20%3D%3E%20needsString(x))()%3B%20%2F%2F%20all%20good%2C%20per%20%238849%0A%20%20const%20res2%20%3D%20(async%20()%20%3D%3E%20needsString(x))()%3B%20%20%2F%2F%20ditto%0A%0A%20%20if%20(!y.z)%20%7B%0A%20%20%20%20throw%20new%20Error(%22Missing%20z.%22)%0A%20%20%7D%0A%0A%20%20const%20res3%20%3D%20(()%20%3D%3E%20needsString(y.z))()%3B%20%20%2F%2F%20still%20good%0A%20%20const%20res4%20%3D%20(async%20()%20%3D%3E%20needsString(y.z))()%3B%20%20%2F%2F%20now%20things%20blow%20up%20%20%0A%7D

**Related Issues:**
https://github.com/Microsoft/TypeScript/pull/8849, which I think was supposed to fix IIFE issues like this, but appears to have missed a case (or I'm missing something).
Repository: godot
Issue: Can't use `new()` or reference own class name in static function (fixed in `master`)
Labels: bug,topic:gdscript,confirmed

IMO title is pretty self explanatory. I'll provide some code I used to write:
```gdscript
# @param  string|null   name
# @param  int|BaseType  type
static func build(name, type = 0):  # Argument|int
  # --- SOME CODE ---
  return new(name, type)
```
Now I get: Parser Error: Method 'new' is not declared in the current class.

Guess I could create an separate class but it when you have only 10 lines method in each class it may create a great overhead doubling loading that code chains.
Repository: rust
Issue: eventual goal: re-remove leak-check from compiler 
Labels: T-compiler,C-tracking-issue,S-tracking-unimplemented,T-types

PR #58592 re-added the so-called leak check.

Re-adding the leak-check masked a number of bugs, where you need to use `-Z no-leak-check` to observe them again.

We plan to eventually re-remove the leak check. But before doing so, we need to double-check that all of the aforementioned masked bugs are either fixed, or at the very least revisited in terms of determining their priority in a leak-check-free world.
Repository: flutter
Issue: Add shadow to an image or icon
Labels: c: new feature,framework,P3,team-framework,triaged-framework

Hi all! I searched for an answer on how to do this I didn't find it. I tried copying [this method](https://github.com/flutter/flutter/issues/3402) used for shadowing text, but couldn't make it work for my image.

Basically, I had an image of an icon (like the one below). I wanted to use it as a button (the iOS style), coloring it and then shadowing it so it would stand out.
I looked for shadows already in flutter, but I only found square or rounded shadows, but I wanted the shadow to copy the image content (when it wasn't transparent).
As I said I tried to copy the above method used for texts, but couldn't make it work correctly. The shadow didn't show in the correct place (I was using a Stack and two Positioned, one for the image and one for the shadow).

![close_icon](https://user-images.githubusercontent.com/12351004/55163691-016e9e80-5149-11e9-82c1-4ce9fccc25bd.png)

I think it would be great if this could be done directly by flutter as a new Widget or Decoration.
Repository: flutter
Issue: webview_flutter black screen
Labels: e: device-specific,framework,f: routes,p: webview,package,c: rendering,team-ecosystem,has reproducible steps,P2,found in release: 2.2,found in release: 2.5,triaged-ecosystem

![CDD7B8153903F755C5E9EC55AA58D1D6](https://user-images.githubusercontent.com/8424643/55165640-bedcae80-51a8-11e9-87de-4993a2cf7b15.gif)
Repository: flutter
Issue: Return data with popUntil 
Labels: c: new feature,framework,f: routes,P3,team-framework,triaged-framework

Navigator.pop supports returning data, I wonder why popUntil doesn't?

Ideally it should also accept a result argument, and pass it to the pop method it calls.

Would flutter team accept a such proposal?
Repository: react
Issue: Noscript tags no longer rendering components in 16.5.0
Labels: Type: Discussion

**Do you want to request a *feature* or report a *bug*?**

Bug

**What is the current behavior?**

Starting in version 16.4.3, the following code:

```
<noscript>
  <a href="/cat">Cat</a>
  <a href="/dog">Dog</a>
</noscript>
```

is being rendered in the browser as:

```
<noscript></noscript>
```

**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.**

Prior to 16.4.3: https://codesandbox.io/embed/5mww4nzpwp

After 16.4.3: https://codesandbox.io/embed/6v8m4yo303

(The changes are not visible, but if you `inspect element` you can see that, in the first example, the links are being rendered, and in the second example they're not being rendered.)

**What is the expected behavior?**

It should render in the browser the same as in the code:

```
<noscript>
  <a href="/cat">Cat</a>
  <a href="/dog">Dog</a>
</noscript>
```

**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**

See above, it was working in versions prior to 16.4.3. (I couldn't find a previous issue mentioning this bug. I think it could have been introduced in the fix for https://github.com/facebook/react/issues/11423)

**Why is this a problem?**

I use a snapshot tool with React to generate a set of static pages from a React project. These pages have less functionality than the full application, but they allow webcrawlers and users who have disabled JavaScript to use the site at a basic level. For example, the code might look like this:

```
<FancyInteractiveButton linksTo="page">link</FancyInteractiveButton>
<noscript>
  <a href="page">link</a>
</noscript>
```

Preventing components in `<noscript>` tags from rendering breaks this functionality for users with JavaScript disabled. The generated snapshots no longer contain the links. It also makes the site harder to navigate by webcrawlers, even if they have JavaScript enabled, because they have to be smart enough to use the fancy button instead of following the link.
Repository: opencv
Issue: custom deallocator
Labels: feature,category: core

##### Detailed description

The constructor for OpenCV matrices that takes user allocated memory should allow the user to provide a custom deallocator function that is called when the `cv::Mat` goes out of scope.

When a `cv::Mat` is cunstructed from a pointer to data and passed around, it is hard to keep track of the original object from whoes data the cv::Mat was created from. This becomes more difficult, if the data is part of another object and the object uses a custom deallocator, e.g. `delete_<object>()` instead of the usual `free()` call.
Repository: opencv
Issue: Mat::copyTo should not re-allocate existing data
Labels: category: core,RFC

follow up of the discussion in #14175.

Currently `Mat::copyTo` will re-allocate the `dst` storage if dimensions or type mismatch (e.g. if src is larger, but also if dst is larger).
This is typically not the desired behavior and should lead to an assertion, which was already implemented in 62ed6cdc742db2f3065f2c472dc8216970d130b9. However the respective code is currently defined out.

The implemented solution notably excludes creation of `dst` which *is* a typical use case for OutputArrays as in
> use the pre-allocated memory for output or allocate it initially

The other solutions discussed in #14175 are not desirable:
- > copyTo(): always allocate new dst

  same as clone(). Does not allow for the valid use-case described above

- > copyInto(): forbid allocation/re-allocation of dst

  too strict as discussed above. New API that basically is copyTo
Repository: TypeScript
Issue: If node_modules is excluded by default, it should not be part of a confusing documentation example
Labels: Docs

Hi, 
This is not a code issue but documentation that leads to confusion. By default node_modules folder is excluded for tsc. This is good (I guess), but the following documentation https://www.typescriptlang.org/docs/handbook/tsconfig-json.html has an example using node_modules as a folder to exclude. Personally I think this example was very badly picked because it leads to think that you need to exclude "node_modules" explicitly (which I was doind in all my projects for that reason). You need to read the full document to notice that. It is confusing.

PS: This led to confusion as you can see in other typescript project (https://github.com/TypeStrong/ts-loader/issues/278)

Thanks for the great typescript thing by the way!
Repository: flutter
Issue: FloatingActionButton tap recognition has clicking problems with Transform
Labels: framework,f: material design,f: gestures,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-design,triaged-design

I am building a complex action menu consisting of multiple FloatingActionButtons. Unfortunately if a FAB is using transform, there are problems with clicking. If the example below is executed you will see that the button can be pressed at the lower half of it, but not on the upper half of it. It seems to me, that you can only click in any area that is both inside of the "normal" FAB location and inside the current drawn FAB.

## Steps to Reproduce

Tested within android emulator:

```dart
import 'package:flutter/material.dart';

class TestView extends StatelessWidget {

    @override
    Widget build(BuildContext context) {
        return Scaffold(
            floatingActionButtonLocation: FloatingActionButtonLocation.centerDocked,
            floatingActionButton: Transform(
                transform: Matrix4.identity()
                    ..translate(0.0, -32.0),
                child: FloatingActionButton(
                    child: const Icon(Icons.add), onPressed: () => actionButtonPressed(),
                ),
            ),
            body: Text(''),
        );
    }

    void actionButtonPressed() {
        print('pressed');
    }

}
```

## Flutter Doctor

```
[√] Flutter (Channel stable, v1.2.1, on Microsoft Windows [Version 6.1.7601], locale de-DE)
    • Flutter version 1.2.1 at E:\flutter
    • Framework revision 8661d8aecd (6 weeks ago), 2019-02-14 19:19:53 -0800
    • Engine revision 3757390fa4
    • Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\T\AppData\Local\Android\android-sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = C:\Users\T\AppData\Local\Android\android-sdk
    • Java binary at: F:\androidstudio3\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 7.1.1 (API 25) (emulator)
```
Repository: TypeScript
Issue: `readonly` mapped type modifiers for `Map` / `ReadonlyMap`
Labels: Suggestion,In Discussion

## Search Terms

ReadonlyMap
ReadWrite
Writable

## Suggestion

3.4.0-rc introduced the ability to use readonly mapped type modifiers with arrays.

(https://devblogs.microsoft.com/typescript/announcing-typescript-3-4-rc/)

It would be useful if the same syntax worked on 

## Use Cases

This is useful in any library dealing with immutable versions of types. It would allow mapped types to easily convert between Map and ReadonlyMap.

## Examples

```
type ReadWrite<T> = { -readonly [P in keyof T]: T[P] };
const map: ReadWrite<ReadonlyMap<string, string>> = new Map();

map.put('a', 'c'); // this should work, since readonly has been removed.
```

```
type Readonly<T> = { readonly [P in keyof T]: T[P] };
const map: Readonly<Map<string, string>> = new Map();

map.put('a', 'c'); // this should not work, since readonly has been applied
```

Similar examples using `Array` instead of `Map` didn't work before 3.4 and did work afterwards.

## Checklist

My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).