sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: cmd/internal/testdir: Test failures
Labels: NeedsInvestigation,compiler/runtime

```
#!watchflakes
default <- pkg == "test" && test == "Test"
```

Issue created automatically to collect these failures.

Example ([log](https://build.golang.org/log/a13f935d085d8e207fba78416a1c39ba4f80148a)):

    --- FAIL: Test (0.03s)
        --- FAIL: Test/heapsampling.go (2.60s)
            testdir_test.go:142: exit status 2
                panic: main.allocSmall1:135 want objects in [45000: 55000], got [44892 44699 44957]
    
                goroutine 1 gp=0x8406128 m=2 mp=0x844a588 [running]:
                panic({0x80d5740, 0x8414030})
                	/workdir/go/src/runtime/panic.go:768 +0x130 fp=0x847cf9c sp=0x847cf48 pc=0x807cd50
                main.main()
                	/workdir/go/test/heapsampling.go:37 +0x75 fp=0x847cfac sp=0x847cf9c pc=0x80caf95
    ...
    
                goroutine 35 gp=0x8882248 m=nil [GC worker (idle)]:
                runtime.gopark(0x80ea5d4, 0x8880018, 0x1a, 0xa, 0x0)
                	/workdir/go/src/runtime/proc.go:402 +0x10c fp=0x8835794 sp=0x8835780 pc=0x80804dc
                runtime.gcBgMarkWorker()
                	/workdir/go/src/runtime/mgc.go:1310 +0xf7 fp=0x88357f0 sp=0x8835794 pc=0x805fab7
                runtime.goexit({})
                	/workdir/go/src/runtime/asm_386.s:1363 +0x1 fp=0x88357f4 sp=0x88357f0 pc=0x80abb21
                created by runtime.gcBgMarkStartWorkers in goroutine 1
                	/workdir/go/src/runtime/mgc.go:1234 +0x25


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: go
Issue: proposal: runtime: explicitly allow pinning of strings and slices
Labels: Proposal

The cgo pointer passing rules (and previously the `Pinner` documentation) states something like:
> [Only pointers that are] the result of calling new, taking the address of a composite literal, or taking the address of a local variable[ may be passed to C and/or pinned].

This wasn't really accurate in practice and also placed restrictions on the API that made it harder to allow new cases in the future (see #62356 and #63768).

Even still, the `Pinner` API explicitly rejects non-pointer types today, but there are ways to work around that for some common use-cases like strings and slices:
- For slices, simply passing `&s[0]` works.
- For strings, passing `unsafe.StringData(s)` works.

While strings require unsafe, it's particularly surprising that slice elements just work given the documentation. Also, given that Go strings can already be passed as `_GoString_` to C functions, it makes sense that they should be included as well.

I propose allowing both strings and slices as valid arguments to `Pinner`. The semantics are clear: pin the underlying memory for the string or the slice backing store. Callers are also able to pin any pointers inside the slice backing store (but `Pinner` will not do this for them automatically). We should make clear that C code is only allowed to access and manipulate the part of the slice backing store that has been pinned; going out-of-bounds on the slice passed to C is not OK.
Repository: react-native
Issue: TypeScript: Type "100vh" is not assignable to type `DimensionValue | undefined`
Labels: Needs: Triage :mag:,Needs: Attention,Type: Upgrade Issue,Never gets stale

### Old Version

0.71.0

### New Version

0.73.2

### Description

We distribute apps for the Android, iOS, and web platforms. After update we unable more to use the next styles:

```tsx
StyleSheet.create({
  root: { 
  // ^^^ TS Error: Type "100vh" is not assignable to type DimensionValue | undefined
    ...Platform.select({
      web: { height: '100vh'},
      default: { height: '100%' },
    }),
  },
});
```

`DimensionValue` type so strict and prevent developers use WEB CSS units like `rem,em,vm,vmax` 

### Steps to reproduce

1. Create the app `npx react-native init Rn73New --version 0.73.x`
2. cd Rn73New
3. add the next code
  ```tsx
  StyleSheet.create({
    root: {
       height: '100vh'
    },
  });
  ```
4. Run `yarn tsc`

### Affected Platforms

Runtime - Web

### Output of `npx react-native info`

```text
System:
  OS: macOS 14.2.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 6.30 GB / 32.00 GB
  Shell:
    version: 3.6.1
    path: /opt/homebrew/bin/fish
Binaries:
  Node:
    version: 18.19.0
    path: /usr/local/bin/node
  Yarn:
    version: 1.22.19
    path: /opt/homebrew/bin/yarn
  npm:
    version: 9.7.2
    path: /opt/homebrew/bin/npm
  Watchman:
    version: 2023.09.04.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.13.0
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - visionOS 1.0
      - watchOS 10.2
  Android SDK: Not Found
IDEs:
  Android Studio: Not Found
  Xcode:
    version: 15.2/15C500b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.8
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.2
    wanted: 0.73.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false
```


### Stacktrace or Logs

```text
style.ts:10:3 - error TS2322: Type '{ height: "100vh"; } | { height: "100%"; }' is not assignable to type 'ImageStyle | ViewStyle | TextStyle'.
  Type '{ height: "100vh"; }' is not assignable to type 'ImageStyle | ViewStyle | TextStyle'.
    Type '{ height: "100vh"; }' is not assignable to type 'TextStyle'.
      Types of property 'height' are incompatible.
        Type '"100vh"' is not assignable to type 'DimensionValue | undefined'.

10   root: {
     ~~~~

```



### Reproducer

[...](https://github.com/retyui/react-native-issues-42672)

### Screenshots and Videos

_No response_
Repository: flutter
Issue: [proposal] showModalBottomSheet adaptive
Labels: c: new feature,framework,f: material design,f: cupertino,c: proposal,P2,team-design,triaged-design

### Use case

Many times we need to implement Bottom Action Sheets and every time I need to do it, it's a lot of rework implementing both `showModalBottomSheet` and `showCupertinoModalPopup` depending on the Platform.

### Proposal

The same way we now have `AlertDialog.adaptive`, there could be a `showModalBottomSheet.adaptive`, this way we could have this way faster and easier implemented. The current way is totally counterproductive

I could not find this proposal around here, if this is a duplicate please feel free to close.
Repository: PowerToys
Issue: Fancy Zones:  Allow to drag item to "Virtual Desktop"
Labels: Needs-Triage

### Description of the new feature / enhancement

Lets say I have a physical monitor that I am using two virtual desktops on.  If I drag an application window to the edge, so the majority of the app windows can't be seen, it would be nice to have it snap to the virtual desktop that is not currently in view.  As it is now if I attempt this, it just snaps the app to the fancy zone in the active area that is viewable on the active  desktop.   

### Scenario when this would be used?

Enhancement to virtual desktops and fancy zones.  

### Supporting information

_No response_
Repository: flutter
Issue: [go_router] Add `restorable` parameter to `StatefulShellRoute` so branch would never save or restore its state
Labels: c: new feature,package,c: proposal,P3,p: go_router,team-go_router,triaged-go_router

### Use case

I have chat page in root of `StatefulShellBranch`
Chat works on websocket, and I want to close connection if nobody sees it and open if sees
It's easy to do in regular routes, but not in `StatefulShellBranch` routes
So I came up with something like
```dart
          GoRoute(
            onExit: (context) {
              final bloc = chatsKey.currentState?.bloc;
              bloc?.add(CloseChatsEvent());
              return true;
            },
            redirect: (_, __) {
              final bloc = chatsKey.currentState?.bloc;
              bloc?.add(RestoreChatsEvent());
              return null;
            },
           path: '/chat'
           ...
```
Which is meh

### Proposal

Instead I would propose option `restorable`
```dart
      StatefulShellBranch(
        restorable = false,
        routes: [
            path: '/chats',
```

so if I go away from branch - Bloc will close, and if I go in again - it will spawn.
non-restorable branch could keep track of its path, but not caching anything else
Repository: go
Issue: proposal: net: add QueryType to *DNSError
Labels: Proposal,NeedsInvestigation

### Go version

go version go1.21.6 linux/amd64

### Output of `go env` in your module/workspace:

```shell
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/scripts/.cache/go-build'
GOENV='/home/scripts/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='local'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.6'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='0'
GOMOD='/home/scripts/src/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1931870782=/tmp/go-build -gno-record-gcc-switches'
```


### What did you do?

https://go.dev/play/p/oN0gVQA4nm2

Please Note: On goplay lookups don't work. You have to run it locally.

### What did you see happen?

Host Lookup
 [208.73.7.224]
 <nil>
TXT  Lookup
 []
 lookup mail10476.emails3.rightmove.co.uk on 192.168.65.7:53: no such host

### What did you expect to see?

Instead of "no such host" I would hav expected "no TXT record"

### See also

https://stackoverflow.com/questions/77880685/golang-net-lookuptxt-returns-no-such-host
Repository: deno
Issue: Improve "exported symbol is missing JSDoc documentation" diagnostic message
Labels: feat,cli

1. "JSDoc documenation" is redundant (edit: actually, I guess it's ok)
2. This sometimes appears on symbol members and I got confused for a second when I saw this (I thought maybe the diagnostic was on the wrong thing):
   ```
   error[missing-jsdoc]: exported symbol is missing JSDoc documentation
      --> V:\dax\mod.ts:590:3
       | 
   590 |   extras?: TExtras;
       |   ^
   ```

We could probably improve it by having a separate diagnostic kind in deno_doc for members vs symbols.

Version: Deno 1.40.0
Repository: vscode
Issue: Incorrect role announced by screen reader on string parameter input box of a command in command center
Labels: bug,accessibility,quick-pick

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.85.2
- OS Version: Windows 11 Enterprise (Windows_NT x64 10.0.22631.3007)

```
Version: 1.85.2 (user setup)
Commit: 8b3775030ed1a69b13e4f4c628c612102e30a681
Date: 2024-01-18T06:40:10.514Z
Electron: 25.9.7
ElectronBuildId: 26354273
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22631
```

**Description**
We are building a VS Code extension. During the accessibility test, the tester reported that Narrator says "Combo edit expanded" on a pure text input of a string command parameter of a command in command center.

I go ahead and checked the role of the input box and I notice that the role is a "combobox". I feel it's improper to call a pure text input with helper text a combobox since it does not provide any options to choose from.
![image](https://github.com/microsoft/vscode/assets/5415452/3fa30e49-3f2b-4a43-b356-6b6f186aa727)
![image](https://github.com/microsoft/vscode/assets/5415452/63325cac-0824-4971-97bd-884b1583aa54)

Can we check if the role is intentionally set correctly?
Thanks.
Repository: TypeScript
Issue: Go To Definition / IntelliSense: Same name for value and type breaks "Go To Definition" of the declared variables.
Labels: Bug,Help Wanted

### 🔎 Search Terms

same name, type, intellisense, typescript, tooltips, go to definition, go to reference, vscode

### 🕗 Version & Regression Information
- This issue is present in 5.4.0-dev.20240125 and 3.3.3
- This is the behavior in every version I tried, and I reviewed the FAQ for entries about "same type" and "same" but no entries touched on the subject.

### ⏯ Playground Link

https://www.typescriptlang.org/play?ts=5.4.0-dev.20240125#code/PTAEHMHtQF2gTApgMwJYDtU1ZdoMyIA2RqAzouhaOpDKAO6QBOA1huAFCieIAeABxb0AxrjL0AwgFcJkALYB5dIlABeUAEYA3L0HDYATwGqZcpSvVGTkZKDNwLiXZzFUpsx8sQBlAIbyiAAqxogAXPaeCt5WOq7iHube-oEAan5E0qoaDtEqLiAQ0HCgSGiY2Lj46IQk5JTUTGwcnHpCzKIJkeZBTFYATLr87fQwod2OvZAhJlZjNna58lMubhITClMpwaERS1Mz2aCD8e4by0zb6ZlH+0zaQA

### 💻 Code

```ts
// go to definition intellisense not working
 
export const CustomOne = 1;
export type CustomOne = typeof CustomOne;

const CustomOneSameType: CustomOne = 1;
const CustomOneSameValue = CustomOne;

// go to definition intellisense working

export const CustomTwo = 2;
export type CustomTwoType = typeof CustomTwo;

const CustomTwoSameType: CustomTwoType = 2;
const CustomTwoSameValue = CustomTwo;
```


### 🙁 Actual behavior

Using the shortcut for "Go to definition" (Cmd+Click) doesn't show uses outside of the two declarations.

<img width="859" alt="Screenshot 2024-01-25 at 3 15 10 PM" src="https://github.com/microsoft/TypeScript/assets/71348224/cab1d8e4-7b9a-4dfe-b894-50e90d8e022f">


### 🙂 Expected behavior

It should show the uses below the declaration too. And it works if you name the value and the type differently.
<img width="835" alt="Screenshot 2024-01-25 at 3 16 03 PM" src="https://github.com/microsoft/TypeScript/assets/71348224/43b47ed5-7047-4c59-a373-40d782adf596">


### Additional information about the issue

It is a common pattern to have the same name for the value and type for many libraries and validators such as `zod` where declaring a named type of the same thing is useful.
Repository: godot
Issue: Crashing Mac on startup
Labels: bug,platform:macos,crash

### Tested versions

Tested in 4.2.stable.




### System information

Godot v4.2.stable - macOS 14.1.1 - Vulkan (Mobile) - integrated Intel(R) Iris(TM) Plus Graphics - Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz (8 Threads)

### Issue description

Godot launches. But every time I open my project or create a new one, I get:

- 50% time stuck on this view, and it crashes my Mac (I can move the mouse but can't do anything else like switch application). I have to force shutdown my Mac with the power button. This keeps happening. :(
<img width="1552" alt="image" src="https://github.com/godotengine/godot/assets/15923595/77d4a253-b7f8-4240-83ef-48524d07bd4f">

- 25% time stuck on that view, but can still close Godot.

- 25% time actually opens and I can work on my project.

Wondering if there's anything I can provide to help debug this?



### Steps to reproduce

Create new mobile project.

Can't get past that view. All UI is unresponsive.


### Minimal reproduction project (MRP)

Just creating a new project crashes Godot.
Repository: go
Issue: runtime: TestPingPongHog failures
Labels: NeedsInvestigation,compiler/runtime

```
#!watchflakes
post <- pkg == "runtime" && test == "TestPingPongHog"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/ui/b/8759355916257146769)):

    === RUN   TestPingPongHog
        proc_test.go:490: want hogCount/lightCount in [0.05, 20]; got 8000000/174000 = 45.97701149425287
    --- FAIL: TestPingPongHog (0.19s)


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: TypeScript
Issue: Add structure to diagnostics to enable nicer diagnostic output and interactivity in tooling such as IDEs
Labels: Suggestion,In Discussion

### 🔍 Search Terms

diagnostics, interactive errors, structured diagnostics, error formatting

### ✅ Viability Checklist

- [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
- [X] This wouldn't change the runtime behavior of existing JavaScript code
- [X] This could be implemented without emitting different JS based on the types of the expressions
- [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- [X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- [X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

### ⭐ Suggestion

change diagnostics to some structured data instead of plain strings.  At its simplest this would be including an array of the sources for the text that populates the substitution variables in the diagnostic message strings.  If we also keep a cache or recent sources and include a key into that cache in the diagnostic, then we can provide callback functionality for tools to get more information in both the TS api and tssserver. 

### 📃 Motivating Example

IDEs can provide much richer displays for error messages and even add interactivity.  Imagine having syntax highlighting for types or being able to click to "go to definition" in an error message.

A very rough proof of concept showing an enhancement to the problems view in VsCode 

https://github.com/microsoft/TypeScript/assets/84949734/25f8366d-a94e-44fb-bfd2-9f204be96097




### 💻 Use Cases

1. What do you want to use this for?
    a. Better display and interaction with error message
2. What shortcomings exist with current approaches?
    a.  Currently only possible by parsing error text.
    b. Advanced usages require traversing the AST to find the nodes and types that contribute to the error
3. What workarounds are you using in the meantime?
    a.  see 2.
Repository: pytorch
Issue: Further simplifying guards
Labels: triaged,oncall: pt2,module: dynamic shapes

### 🐛 Describe the bug

I have this function:
```
def f(x):
    assert x.shape[0] > 2
    assert 1 % (x.shape[0] // 2) != 0
    assert 32 * (x.shape[0] // 2) ** 2 - 16 * (x.shape[0] // 2) != 0
    return x.cos()
```

If I already know that x.shape[0] > 2, which in this case is from the first assertion, but in the actual case it’s a constraint, I believe that the following assertions should all be True through... math? And so I feel that the guards for the assertions afterwards should not be generated. However I still see the following guards, possibly because the symbolic reasoning is not strong enough to simplify them: 
```
Ne(Mod(1, (L['x'].size()[0]//2)), 0)
Ne(32*((L['x'].size()[0]//2))**2 - 16*(L['x'].size()[0]//2), 0)
```

### Versions

main

cc @ezyang @msaroufim @bdhirsh @anijain2305 @zou3519
Repository: godot
Issue: Dynamic objects do not receive SDFGI reflections when LightmapGI is used.
Labels: discussion,topic:rendering,topic:3d

### Tested versions

v4.2.1.stable.official [b09f793f5]

### System information

Godot v4.2.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated AMD Radeon RX 6700 XT (Advanced Micro Devices, Inc.; 31.0.23013.1023) - AMD Ryzen 7 5700X 8-Core Processor (16 Threads)

### Issue description

Exactly as the title said. Disabling probe generation does not fix the issue.

As a side note, because of an already existing bug, toggling the visibility of the lightmap causes SDFGI reflections to become visible until you reload the scene or move a dynamic object. This behavior is *almost* desirable if not for the fact that the object no longer receive indirect lighting from LightmapGI.

### Steps to reproduce

1. Open MRP
2. Reflections are not initially visible on the sphere
3. Disable LightmapGI
4. Reflections now appear properly on the sphere

### Minimal reproduction project (MRP)

[Lightmap.zip](https://github.com/godotengine/godot/files/14058886/Lightmap.zip)
Repository: rust
Issue: Provide a better error on anonymous parameters in unexpected locations
Labels: A-diagnostics,A-parser,T-compiler,D-terse

In edition 2015, the following is supposed to be legal ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2015&gist=94233755c6b1aca0b3a0b8961df6f87f)):

```rs
pub fn foo(&str) {}
```

It is essentially semantically equivalent to
```rs
pub fn foo(_: &str) {}
```

Unfortunately, even though edition 2015 is enabled, the following error is generated:

```
error: expected one of `:`, `@`, or `|`, found `)`
 --> src/lib.rs:1:16
  |
1 | pub fn foo(&str) {}
  |                ^ expected one of `:`, `@`, or `|`
  |
  = note: anonymous parameters are removed in the 2018 edition (see RFC 1685)
help: if this is a `self` type, give it a parameter name
  |
1 | pub fn foo(self: &str) {}
  |            +++++
help: if this is a parameter name, give it a type
  |
1 | pub fn foo(str: &TypeName) {}
  |            ~~~~~~~~~~~~~~
help: if this is a type, explicitly ignore the parameter name
  |
1 | pub fn foo(_: &str) {}
  |            ++
```
which explains that it was "removed in the 2018 edition". This should be irrelevant, as neither that edition, nor any later edition, is enabled.

[RFC 1685](https://rust-lang.github.io/rfcs/1685-deprecate-anonymous-parameters.html) does not appear to describe breaking this in edition 2015, so I believe this to be a bug.

It causes a good amount of (quite old) crates to be impossible to build for no reason, which is unfortunate.