sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: x/text: FAIL: TestCountMallocs
Labels: NeedsInvestigation

Hello !

### What version of Go are you using (`go version`)? 1.8


### Does this issue reproduce with the latest release? version 0.1.0

### What did you do?
I try to test message in the project github.com/golang/text/ in version 0.1.0 it fails with
--- FAIL: TestCountMallocs (0.00s)
        fmt_test.go:1443: Sprintf("%x"): got 3 allocs, want <=2
        fmt_test.go:1443: Sprintf("%s"): got 3 allocs, want <=2
        fmt_test.go:1443: Sprintf("%x %x"): got 4 allocs, want <=3
        fmt_test.go:1443: Sprintf("%g"): got 5 allocs, want <=2
        fmt_test.go:1443: Fprintf(buf, "%s"): got 2 allocs, want <=1
        fmt_test.go:1443: Fprintf(buf, "%x %x %x"): got 1 allocs, want <=0
FAIL
exit status 1
FAIL    golang.org/x/text/message       0.023s


Thank you for your help
Repository: go
Issue: cmd/compile: slicing can be improved on ARM
Labels: Performance,compiler/runtime

This code:

```go
func slice(s []int64, idx int) []int {
    return s[idx:]
}
```

generates this code on ARM:

```
CMP R0, R7           // bound check
B.GE panic
SUB R7, R0, R0       // len
SUB R7, R4, R4       // cap
RSB $0, R4, R9       // mask(cap)
ASR $31, R9, R9      // mask(cap)
AND R7<<$3, R9, R9   // delta&mask(cap)
ADD R5, R9, R5       // ptr+delta&mask(cap)
```

but it could be optimized this way:

```
SUBS R7, R0, R0
B.LS panic
SUBS R7, R4, R4
ADD.NE R7<<$3, R9, R5
```

which is much shorter and faster.
Repository: go
Issue: all: announce end of support for old macOS releases
Labels: Documentation,Builders,NeedsFix,release-blocker,recurring

**Note, Aug 2022: See https://github.com/golang/go/issues/23011#issuecomment-738395341 for the macOS deprecation schedule.**

- - -

Apple continues to put out new macOS releases. We can't run builders for all of them forever.

I propose we announce in the Go 1.10 release notes that Go 1.10 will be the last release to officially support macOS 10.8 (Mountain Lion).

macOS 10.8 was last updated Oct 3, 2013, over 4 years ago.

(macOS 10.9 was last updated Mar 21, 2016, 19 months ago, which is somewhat more recent)

Apple doesn't publish official End-of-Life dates for macOS versions, but I read that their security policy is that they issue security updates for the past 3 releases.

Given that they're on 10.13 now, that means 10.13, 10.12, and 10.11 are supported by them.

Our policy of additionally supporting 10.10 and 10.9 in Go 1.11 would be even more.

/cc @rsc @ianlancetaylor
Repository: react-native
Issue: Image component with local uri source (file://) does not render initially
Labels: Help Wanted :octocat:,Ran Commands,Platform: Android,Component: Image,Bug

Image components with local uri sources (file://) do not render initially. When a re-render of the component tree happens, the images get rendered.

### Environment

  Environment:
    OS:  macOS High Sierra 10.13.1
    Node:  8.9.1
    Yarn:  1.3.2
    npm:  5.5.1
    Watchman:  4.9.0
    Xcode:  9.1 (9B55)
    Android Studio:  3.0.1

  Packages: (wanted => installed)
    react-native: 0.51.0 (@sraka1 reports this is still an issue in 0.58.4)
    react: 16.0.0

  Target Platform: Android (5.0.0)

### Steps to Reproduce

```javascript
const image = {uri: 'http://my.bamps.online/cfs/files/images/D8Xg27puAiqjvKetD?store=normal'}
// image2 is cached version of image by react-native-cached-image
const image2 = {uri: 'file:///data/data/com.testcachedimage/cache/imagesCacheDir/my_bamps_online_e6d51c26611343fb5e8c3e493674423c3d3f3943/38baef384cbb5bcc5f6138ca0653884561f85fde.jpg'}
export default class App extends Component<{}> {
  render() {
    return (
      <View style={{backgroundColor:'#777'}}>
        <Image source={image2} style={{width: 100, height: 100}}/>
        <Image source={image2} style={{width: 300, height: 100}}/>
        <ImageBackground source={image2} style={{width: 100, height: 100}}/>
        <ImageBackground source={image2} style={{width: 300, height: 100}}/>
        <Image source={image} style={{width: 100, height: 100}}/>
        <Image source={image} style={{width: 300, height: 100}}/>
      </View>
    );
  }
}
```

### Actual Behavior

![2017-12-06_15-05-16](https://user-images.githubusercontent.com/1755384/33658641-e26bdec8-da96-11e7-9c30-729da4d7e5f5.png)
Repository: angular
Issue: View encapsulation is emulated when importing a file inside `::ng-deep`
Labels: type: bug/fix,freq1: low,area: core,core: CSS encapsulation,P5

<!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.

ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->

## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>

## Current behavior
<!-- Describe how the issue manifests. -->

The following .scss file with the default `Emulated` view encapsulation...

```
::ng-deep {
  @import '~some/file.css`
}
```

...results in `[_ngcontent-${id}]` attributes applied to its content.

## Expected behavior
<!-- Describe what the desired behavior would be. -->

They should not be added because it's inside `::ng-deep`.

## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->

I think the example above is pretty straightforward, but I can create a repro repo if requested.

## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->

Being able to include a third-party css file without view encapsulation being applied to it.

## Environment

<pre><code>
Angular version: 5.0.0
<!-- Check whether this is still an issue in the most recent Angular version -->
Repository: TypeScript
Issue: CFA should consider branch flags
Labels: Suggestion,Needs Proposal

This is a suggestion to improve the CFA. It would be good if TypeScript considered branch flags when analysing code paths.
```ts
function f() {
    let text: string;
    let hasTakenVerySpecificBranch = false;
    if (0.5 < Math.random()) {
        if (0.5 < Math.random()) {
            if (0.5 < Math.random()) {
                hasTakenVerySpecificBranch = true;
                text = '';
            }
        }
    }
    if (!hasTakenVerySpecificBranch) {
        text = ''
    }
    console.log(text); // Error 'text' is used before assigned.
}
```
We assign `text` on all possible code paths above. And it shouldn't error above.

A branch flag is simply a boolean variable that is considered when doing the control flow analysis.
Repository: angular
Issue: [Animations, Angular 5] inner element is not animated
Labels: type: bug/fix,area: animations,freq3: high,P4

<!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.

ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->

## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[x] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>

## Current behavior
<!-- Describe how the issue manifests. -->
When the animation is used for the parent element, the animation for the child element does not work.

## Expected behavior
<!-- Describe what the desired behavior would be. -->
I expect that the animation for the inner element will work at the same time with the animation of the parent, since it worked before.

## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
http://embed.plnkr.co/9JUga9LYw0NEDmdSempP/
it works as expected if set angular version ^4.2.0
(Also works as expected with the version set to 5.0.2, but breaks in 5.0.3. thx **jamesthurley**)

## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->
To animate nested elements.

## Environment

<pre><code>
Angular version: 5.0.5
<!-- Check whether this is still an issue in the most recent Angular version -->

Browser:
- [x] Chrome (desktop) version 62
 
For Tooling issues:
- Node version: 8.9.1  <!-- run `node --version` -->
- Platform:  Win 10 <!-- Mac, Linux, Windows -->

Others:
<!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->
</code></pre>
Repository: angular
Issue: Animation on query :leave does not apply on lazy-loaded children components
Labels: type: bug/fix,area: animations,freq2: medium,P3

<!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.

ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->

## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>

## Current behavior
<!-- Describe how the issue manifests. -->
query(':leave' animation has no effect on lazy loaded child components. The component simply disappears 

## Expected behavior
<!-- Describe what the desired behavior would be. -->
The leave query should take effect on lazy loaded child components. I appears that it was affected by changes made in 5.0.4
In 5.0.3 animation is happening, however with some sort of a slight delay 

## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
https://embed.plnkr.co/Nfj70L0RzFnAT8e4eC2I/
Animation on routing is in place. Notice that the lazyloaded components animation is not triggering onLeave

## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->


## Environment
5.0.4
<pre><code>
Angular version: X.Y.Z
<!-- Check whether this is still an issue in the most recent Angular version -->

Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  <!-- run `node --version` -->
- Platform:  <!-- Mac, Linux, Windows -->

Others:
<!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->
</code></pre>
Repository: rust
Issue: Confusing error message with mismatched `proc-macro-derive` dependencies
Labels: A-diagnostics,T-compiler,A-proc-macros,D-crate-version-mismatch

Not sure if this is that urgent, but it took me several hours to debug this simple compiler error with help from multiple people, so raising anyway...

Suppose you have a crate `foo` defining some trait `Foo`, and then a `foo-derive` crate of type `proc-macro-lib` that allows you to custom derive `Foo`.  `foo-derive` must then depend on `foo` in `Cargo.toml`, because it mentions the `Foo` trait.  If I then want to use the derivation I have to use *both* `foo` and `foo-derive` crates.  Fine.

The problem comes if the using crate (let's call it `bar`) uses a different version of `foo` from the one that `foo-derive` does.  So let's say that `foo-derive` 1.0 has in `Cargo.toml`:

```toml
[dependencies]
foo = "1.1"
```

Now, if in `bar`'s `Cargo.toml` I mistakenly add:
```toml
[dependencies]
foo = "1.0"
foo-derive = "1.0"
```

And then use the custom derive of `Foo` within `bar`:
```rust
`#[derive(foo)]`
struct BarStruct{ ... }
```
 I get the confusing error `the trait Foo is not implemented for BarStruct`.  Even though I can see using cargo-expand that the trait *is* implemented.  The point is that the derive code has implemented a *different version* of `Foo`, and the fix is to change `bar` to depend on `foo` version 1.1.   But the compiler error does not make that at all obvious!
Repository: pytorch
Issue: Feature request: Correlation module
Labels: triaged

This module was used by FlowNetC, it is described [here](https://arxiv.org/pdf/1504.06852.pdf) (in section 3.)
Here is the caffe implementation of the authors
https://github.com/lmb-freiburg/flownet2/blob/master/src/caffe/layers/correlation_layer.cu
Here is one tensorflow implementation
https://github.com/sampepose/flownet2-tf/tree/master/src/ops/correlation

And also NVIDIA recently released a custom pytorch operator here
https://github.com/NVIDIA/flownet2-pytorch/tree/master/networks/correlation_package
here is another attempt in pytorch (but only high level)
https://github.com/onlytailei/pytorch-flownet2/blob/master/nets/flownetC.py#L45

Would it be useful to add such a feature in functional pytorch library ?
Repository: rust
Issue: Result from format_args! cannot be center-aligned within another format string
Labels: C-enhancement,A-macros,T-libs-api

I can do `println!("{:=^80}", " TEST ")` to pretty-print a center-aligned header within equality signs.
However, the alignment is ignored when I do `println!("{:=^80}", format_args!(" TEST "))`.
I need the latter syntax to further write code like
`println!("{:=^80}", format_args!(" TEST {:#016X} ", some_integer))`.

I understand that a `format_args!` result is harder to center-align due to cases where the final width could be unknown. Nevertheless, it should be possible for the compiler to determine the string width in my example cases to let it be center-aligned.
Repository: vscode
Issue: Feature Request: Keybinding Overloading
Labels: feature-request,keybindings

<!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode. -->

I'm *not* asking for the ability to run multiple commands *in sequence*, as mentioned in

* https://github.com/Microsoft/vscode/issues/18621
* https://github.com/Microsoft/vscode/issues/871
* https://github.com/Microsoft/vscode/issues/171

or as addressed with the [macros extension](https://marketplace.visualstudio.com/items?itemName=geddski.macros)

I'd like to be able to assign a given keybinding to multiple different commands ***separately***, and if multiple commands are applicable in the current context when the keystroke is used, present the user with a menu of the options, *rather than considering it a conflict*, where only one can "win".

There are *many* ***significant*** benefits to this:

* You don't have to worry about keybindings from your multiple extensions conflicting with each other.
* All extension authors can add the keybinding they think makes the most sense, instead of telling you to manually add it in your own personal keybindings.json.
* You don't have to worry about your personal keybindings clobbering a default keybinding (this sort of conflict does not appear when you use "Show Conflicts"—at least it did not in my tests).
* You will never accidentally use the wrong command because of a conflict in which you expected another command to be triggered by your keybinding.
* You can purposefully add multiple related commands to the same keybinding, so that you have fewer bindings to memorize.  For example, 
  + you could assign all of your Git-related commands to <kbd>⌘</kbd><kbd>⌥</kbd><kbd>G</kbd>, or, for more focused groupings, 
  + you could assign all variations of Git commands related to adding files to <kbd>⌘</kbd><kbd>⌥</kbd><kbd>A</kbd>, and those related to commiting to <kbd>⌘</kbd><kbd>⌥</kbd><kbd>C</kbd>, and so forth.
* You can experiment with changed keybindings without having to change the whole world in order to accommodate the change you think you might prefer.

Since there may be people who have grown accustomed to existing conflicts in their keybindings (and accustomed to the current winner) it would make sense for this behavior to have a setting to turn it on or off, so that they are not presented with a menu containing what used to be considered "conflicts" but under the new behavior are simply alternate options assigned to the same keystroke.
Repository: angular
Issue: JIT Complier needed with AOT Build for Dynamic Component.
Labels: feature,area: core,area: compiler,feature: under consideration,compiler: jit

<!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.

ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->

## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[X ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>

## Current behavior
I have HTML templates which is loaded from database. It has Form Controls, which I need dynamically render.

Currently in Angular 4.0 it is working fine, but we are not able to update to Angular 5.0 since the feature is not available

## Expected behavior

I like to have the JIT Complier supported with AOT build. I am open to other option of displaying the controls. 


## Minimal reproduction of the problem with instructions

For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via

This is working example with uses the compiler to build.

The top template has the First Name and Last Name. 

<div #container></div>

This container is loaded dynamically with Controls Address, City, Radio options.

http://plnkr.co/edit/rELaWPJ2cDJyCB55deTF?p=preview

For this to work in AOT build I change the Complier to JIT Complier


## What is the motivation / use case for changing the behavior?


All our use case are dynamically generated and it comes from Database. All validation are dynamically configured. Love to have the feature back.


## Environment

<pre><code>
Angular version: Working in Version 4.0.0, not working in Angular 5.0.0
<!-- Check whether this is still an issue in the most recent Angular version -->

Browser:
- [X ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  <!-- run `node --version` -->
- Platform:  <!-- Mac, Linux, Windows -->

Others:
<!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->
</code></pre>
Repository: react
Issue: Consider removing XML compatibility from SSR or hiding it behind an option
Labels: Component: Server Rendering,Type: Breaking Change,React Core Team

See https://github.com/facebook/react/pull/11708#issuecomment-349953542.
Not sure if it's important but seems suboptimal to send extra markup if most people don't need XML.
Repository: go
Issue: go/ast: CommentMap heuristic sensitive to parentheses around unnamed result type
Labels: NeedsFix

**Background**

I want to use structured comments to associate metadata with function parameter types in Go source code, with the function bodies automatically generated by an external tool.

**Problem**

There is a bad interaction between `(*printer.Config).Fprint` and `ast.NewCommentMap` for comments on function results.

If a function returns only one result, has an associated trailing comment, and lacks a body (e.g., because it is implemented in assembly), `NewCommentMap` will only associate the comment with the result if both are enclosed in parentheses. (Otherwise, the algorithm of `NewCommentMap` instead associates the comment with the entire file.)

Unfortunately, `(*printer.Config).Fprint` omits those parentheses, so running `gofmt` on such a file breaks the association between the metadata and the function result.

Example: https://play.golang.org/p/ovMOY6e5pB

```go
package foo

func Foo() (error /*metadata*/)
```

formats to

```go
package foo

func Foo() error /*metadata*/
```

**Proposal**

The problematic check is here:
https://github.com/golang/go/blob/7c46b62d0a6e2353db68da963c390b094e359a92/src/go/printer/nodes.go#L344-L348

I suspect it would be fixed by weakening that condition to:
```go
if n == 1 && result.List[0].Names == nil &&
   (!result.Closing.IsValid() || !p.commentBefore(p.posFor(result.Closing)) {
```
Repository: TypeScript
Issue: In JSDocs notation for index signatures, Object and object should be treated as the same
Labels: Suggestion,In Discussion,Domain: JSDoc

<!-- BUGS: Please use this template. -->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  2.7.0-dev.201xxxxx

**Code**

```ts
/**
 * Test.
 *
 * @param {object.<string, number>} obj An object.
 */
function func(obj) {
	console.log(obj);
}
```

**Expected behavior:**

`obj` should have a index signature as in #15105 

**Actual behavior:**

`obj` is treated as `any`

**Additional Info:**

This was mentioned in the above issue, and it seems to be related to the way Typescript manage `Object` and `object`, but in JSDocs, they are treated similar.