sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: cmd/go: go generate should be more resilient to source changes
Labels: NeedsInvestigation

```
go version devel +3c0fbeea7d Tue Nov 5 05:22:07 2019 +0000 linux/amd64
```

When `go generate` runs, it's quite likely to add and remove source files.
This can result in errors which are inappropriate.

Here's a [testscript command](https://pkg.go.dev/github.com/rogpeppe/go-internal/cmd/testscript) script that demonstrates the issue. It's a pared-down version of some real code:

```
go generate ./...
cp names.new names
go generate ./...

-- names --
a
b
c
-- names.new --
a
b
d
-- gen.go --
// +build ignore

package main

import (
	"io/ioutil"
	"log"
	"os"
	"path/filepath"
	"strings"
)

func main() {
	os.RemoveAll("generated")
	testData, err := ioutil.ReadFile("names")
	if err != nil {
		log.Fatal(err)
	}
	for _, name := range strings.Fields(string(testData)) {
		if err := os.MkdirAll(filepath.Join("generated", name), 0777); err != nil {
			log.Fatal(err)
		}
		err := ioutil.WriteFile(filepath.Join("generated", name, "f.go"), []byte(`
// Code generated for this test. DO NOT EDIT.

package `+name+`

func F() {}
`), 0666)
		if err != nil {
			log.Fatal(err)
		}
	}
}
-- go.mod --
module m

go 1.14
-- main.go --
package main

//go:generate go run gen.go

func main() {
}
```
When I run it, I see this: 

```
% testscript goissue.txtar
> go generate ./...
> cp names.new names
> go generate ./...
[stderr]
generate: open $WORK/generated/c/f.go: no such file or directory

[exit status 1]
FAIL: /tmp/testscript089422577/0/script.txt:3: unexpected go command failure
error running tst.txtar in /tmp/testscript089422577/0
```

That is, the second time that `go generate` runs, it fails.
It seems that `go generate` is evaluating all the files when it runs, and not being resilient when they change (in this case a file changed name).

Perhaps it should be silent in cases like this.

There may also be other cases where `go generate` could be quieter about errors (for example when there's a package name mismatch in files in a package, which can be caused when a package is renamed and `go generate` is called again to regenerate the new files).

One possible approach might be for `go generate` to ignore any errors on files which contain the standard "DO NOT EDIT" comment.
Repository: godot
Issue: Spotlight Has An Un-wanted "Darkening Effect"
Labels: bug,topic:rendering

**Godot version:**
3.1.1 / 3.1.2

**OS/device including version:**
Windows 10 Version 1909

**Issue description:**
Spotlight darkens a radius around itself

**Steps to reproduce:**
Create a Spotlight

**Minimal reproduction project:**
Just that
Example :
https://www.reddit.com/r/godot/comments/e8c7sf/spotlight_creating_an_unwanted_darkening_effect/
Repository: TypeScript
Issue: Allow folding of JSDoc comments
Labels: Suggestion,Help Wanted,Effort: Moderate,Domain: Outlining

**VsCode version:** 1.40.2 (Oct 2019, 2) 
**OS:** Windows 10 v1709 os build 16299.847
**TypeScript Version:**  3.6.3


**Search Terms:** vs code fold "app.get" outlining jsdoc comment expressjs folding

**Code**

```ts

/**
 * @api {get} /ProjectsList/:projectId/ Get project
 *
 * @apiDescription Get a project by projectId.
 *
 * @apiName Get User Projects
 * @apiGroup Project
 * @apiVersion 1.0.0
 *
 */
app.get('/:retailUnit/:language/ProjectsList/:projectId/', retailUnit, (req, res) => {
    const projectListController = new ProjectListController();

  });
```

**Repro:**
* Create file foobar.js, copy paste the code from above.
* Try fold all.
**Expected behavior:** Comment and method fold
**Actual behavior:** method fold, comment does not

**Expected behavior:** I can fold the jsdoc comment above the app.get function

**Actual behavior:** I cannot fold the jsdoc comment, outlining not available.

**Related Issues:** Some (incorrectly?) for vs code, but these are the ones I found, but the first one is **very** similar to this one, but for arrow functions instead:
* https://github.com/microsoft/TypeScript/issues/26014
* https://github.com/Microsoft/vscode/issues/55249
* https://github.com/microsoft/vscode/issues/80186


_This is my first report here, I hope it is ok._ :-)
Repository: rust
Issue: Missed optimization on only used once allocation
Labels: A-LLVM,I-slow,C-enhancement,T-compiler,I-heavy,C-optimization

godbolt link: https://rust.godbolt.org/z/d_VvSo
Here are two snippets that I expect that they should have the same assembly:
```rust
pub fn foo(s: &str) -> bool {
    s != "FOOFOOLONGLONG"
}
```

```rust
pub fn foo(s: &str) -> bool {
     s.to_string() != "FOOFOOLONGLONG"
}
```

EDIT: For [C version](https://rust.godbolt.org/z/eTcTrchGq), gcc and clang also fails to optimized this case.
Repository: node
Issue: move things away from process.binding('util')
Labels: lib / src

`process.binding('util')` has been some kind of hotch-potch of "bindings the JS internals need but don't fall in the scope of a particular binding namespace". There is no compatibility guarantee about what's in this object and changes to it are completely at the whims of Node.js maintainers.

However `process.binding('util')` has been accessible in the user land and is abused by users (refs: https://github.com/nodejs/node/pull/29947#issuecomment-562996397 - considering how volatile it is, when touching this binding I had always been wondering if anyone actually abuses this, until I saw the issue). I propose we try creating a new, internal namespace (that is, a namespace that's not in [the whitelist here](https://github.com/nodejs/node/blob/28efa4fe953c0da6be25cd10e708b84deaada15f/lib/internal/bootstrap/loaders.js#L69)) and try moving everything away to that internal namespace to reduce the abuse.

On a side note, I think there should be a comment in `node_utils.cc` warning that any additions to the binding is at the risk of user-land abuse.
Repository: pytorch
Issue: MathJax too small in Firefox
Labels: module: docs,triaged

MathJax in your docs is by default rendered tiny (too small to read) in Firefox...

Example screenshot from: https://pytorch.org/tutorials/beginner/blitz/autograd_tutorial.html
<img width="862" alt="image" src="https://user-images.githubusercontent.com/464192/70542681-6d732480-1b69-11ea-8daf-e3fa3aa62822.png">

My guess is some CSS problem...
Repository: terminal
Issue: Rolling background image like Windows Themes
Labels: Help Wanted,Area-UserInterface,Area-Extensibility,Area-Settings,Product-Terminal,Issue-Task

# Description of the new feature/enhancement
What about a set of rolling background images instead of a single one that Windows Terminal currently supports?  Looking at the same background all the time gets boring.

I like [Windows Themes](https://www.microsoft.com/en-us/store/collections/windowsthemes?SilentAuth=1&wa=wsignin1.0) w/ the desktop backgrounds slideshow feature.  I download a theme and I get a set of rolling background images on my desktop.  What about that same concept w/ Windows Terminal? Thoughts? 💭

### Screenshot reference of Windows 10:
![image](https://user-images.githubusercontent.com/14079228/70549061-9b447300-1b41-11ea-8ec9-f700b95b8e8e.png)

# Proposed technical implementation details (optional)
add a `"backgroundImages" : [ "file1.jpg", "file2.jpg" ]` property to `profiles`.
Repository: flutter
Issue: Flutter process internals prone to flagging from antivirus on Windows
Labels: tool,dependency: dart,platform-windows,P2,team-tool,triaged-tool

## Steps to Reproduce

<!-- Please tell us exactly how to reproduce the problem you are running into. -->

1. Extract flutter release zip to a folder on a Windows machine with Carbon Black defense software installed
2. make sure flutter\bin is in the path
3. run "flutter doctor"
4. Nothing happens
5. Check Windows Application Event Logs
6. You will notice "CbDefense" detected the start of cmd.exe and killed the process

After looking at the dart.exe code online, I see that in many places there is a "runInShell" flag passed to process-related methods (In classes like ProcessImpl). When this flag is set, cmd.exe is used to execute these statements on Windows.  This is something that many anti-virus and intrusion detection applications look for on Windows.  Is there a reason we need to use the native shell for these operations on Windows?  Would Win32 process methods not be sufficient?

## Logs

<!--
      Include the full logs of the commands you are running between the lines
      with the backticks below. If you are running any "flutter" commands,
      please include the output of running them with "--verbose"; for example,
      the output of running "flutter --verbose create foo".
-->

After running "flutter doctor" I see this entry in the Windows application even log:

Source: CbDefense
Text: Information: The application <my flutter folder>\flutter\bin\cache\dart-sdk\bin\dart.exe invoked the application C:\Windows\System32\cmd.exe. The operation was blocked and the application terminated by Confer.

<!-- If possible, paste the output of running `flutter doctor -v` here. -->

No output results from "flutter doctor -v" as Carbon Black kills the process prematurely
Repository: flutter
Issue: FlexibleSpaceBar title doesn't remain vertically center when custom fontSize is given
Labels: framework,f: material design,has reproducible steps,found in release: 2.10,found in release: 2.13,team-design,triaged-design

## Steps to Reproduce
1. Set fontSize parameter to the text given as title to the `flexibleSpace` parameter in `SliverAppBar`.
2. After collapsing the title isn't vertically centered.

## Cause
Using fixed `bottomPadding` of `16.0` [here](https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/flexible_space_bar.dart#L378) and fixed `bottom***` alignment [here](https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/flexible_space_bar.dart#L248-L257). This results in increasing / decreasing top space in the appbar, if a fontSize less than / greater than 20 (default) is used respectively.

Also, changing the [alignment](https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/flexible_space_bar.dart#L390) property to anything other than `bottom***` doesn't work as expected
## Flutter Doctor
```
[√] Flutter (Channel stable, v1.9.1+hotfix.6, on Microsoft Windows [Version 10.0.18363.476], locale en-IN)
    • Flutter version 1.9.1+hotfix.6 at D:\Flutter
    • Framework revision 68587a0916 (3 months ago), 2019-09-13 19:46:58 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0


[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Users\rashedmyt\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at:
      C:\Users\rashedmyt\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\191.6010548\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[√] Android Studio (version 3.5)
    • Android Studio at C:\Users\rashedmyt\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\191.6010548
    • Flutter plugin version 40.2.2
    • Dart plugin version 191.8580
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] VS Code (version 1.40.2)
    • VS Code at C:\Users\rashedmyt\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.7.0

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)

• No issues found!
```
Repository: godot
Issue: Can't compile bindings MinGW or MSVC
Labels: bug,topic:buildsystem

**Godot version:** 3.1.2.stable.official

**OS/device including version:** Microsoft Windows 10 Pro 10.0.18362 compilation 18362

**Issue description:**

Well, this issue needs a little workaround before (two issues in one?) because _scons_ will ignore completely the flag **use_mingw**, the patched version is included in the issue.

After that, the step to generate the bindings with _MinGW_ will stop compiling at some point.

**Steps to reproduce:**

Before the patch I've run the godot command to generate the API file:

```
godot --gdnative-generate-json-api api.json
```

(Window flashes and api.json file appears).

After the patch, running:

```
scons platform=windows use_mingw=yes generate_bindings=yes use_custom_api_file=yes custom_api_file=api.json
```

Will start compiling as expected, until encounters this line:

```shell
g++ -o src\gen\CameraFeed.o -c -g -O3 -std=c++0x -Wwrite-strings -I. -Igodot_headers -Iinclude -Iinclude\gen -Iinclude\core src\gen\CameraFeed.cpp
```

Which yields:

```
src\gen\CameraFeed.cpp: In member function 'void godot::CameraFeed::_set_YCbCr_imgs(godot::Ref<godot::Image>, godot::Ref<godot::Image>)':
src\gen\CameraFeed.cpp:53:112: error: '___godot_icall_void_Object_Object' was not declared in this scope
  ___godot_icall_void_Object_Object(___mb.mb__set_YCbCr_imgs, (const Object *) this, y_img.ptr(), cbcr_img.ptr());
                                                                                                                ^
scons: *** [src\gen\CameraFeed.o] Error 1
scons: building terminated because of errors.
```

**Minimal reproduction project:**

While not a project, here is the patched version of SConstruct file: [https://pastebin.com/raw/MYducSmZ](https://pastebin.com/raw/MYducSmZ)

The rest of the project is a blank godot project, not involved at all in the process and godot-cpp is cloned following the tutorial.

Maybe I'm missing something, sorry in that case
Thanks!
Repository: flutter
Issue: Supporting the Turkmen language for Cupertino/Material widgets
Labels: c: new feature,framework,f: material design,a: internationalization,f: cupertino,P3,workaround available,team-design,triaged-design

Creating this issue to track interest for adding Turkmen as a supported language for Material/Cupertino widgets. 

Related to an [attempt to add Cupertino Turkmen translations](https://github.com/flutter/flutter/pull/44763) and an [attempt to add Material Turkmen translations](https://github.com/flutter/flutter/pull/44765).

cc/ @kea2288
Repository: TypeScript
Issue: Add more telemetry for ATA
Labels: Suggestion,Experience Enhancement

Currently ATA just fires an event with the list of packages to be installed, the success/failure and the typings installer version. Some more useful telemetry to gather would be per package success/failure, time for each package install, and the registry used (github vs. npm).

The event currently goes from typings installer to tsserver to whoever is listening to tsserver events (the editor). So adding the extra telemetry to the typings installer event seems like the best place (the other option is to calculate it in the tsserver based on the current event payload from the typing installer).
Repository: flutter
Issue: make it easier to use chained `Tween`s in `Hero.createRectTween`
Labels: c: new feature,framework,a: animation,P3,team-framework,triaged-framework

## Use case
When creating custom animations with a `Hero` widget, you will most likely get to use `createRectTween`, unfortunately it requires `Tween` as return value, not `Animatable`. This makes it difficult to use chains (you should create your own Tween and do it by hand).

This example couldn't work with current implementation:
```
Hero(
  createRectTween: (Rect begin, Rect end) {
    return RectTween(begin: begin, end: end).chain(
      CurveTween(
        curve: Curves.easeInOut,
      ),
    );
  },
  tag: tag,
  child: child,
);
```

## Proposal
~~Replace `Tween` => `Animatable` in Hero implementation.~~

~~The only blocker for this change is usage of `.begin` and `.end` which could be safely replaced with `.transform(0)` and `.transform(1)` respectively, since `Tween` implementation highly depends on these values as begin and end.~~

~~I can create pull request with these changes if my proposal seems reasonable.~~
Initial proposal was a bit confusing since for an `Animatable` it's not guaranteed that 1.0 is the end and 0.0 is the beginning. And it's not good to allow any `Animatable` to be returned from `createRectTween`. Discussion in this PR  #47657

Just override `Tween.chain` to return a `Tween` is not an option since we should be able to pass `Animatable` and return type wouldn't be `Tween` then. It's not possible to override non-generic method with generic one, so it's not possible to solve it like this either.

I have a few possible solutions:
- Add `Tween.chainTween` which would behave just like `Animatable.chain` but with `Tween` as arg/return type.
- Implement `TweenChain` class (like `TweenSequence`)

Would really appreciate any other suggestions!

I can create pull request with implementation of solution which seems most appropriate.
Repository: flutter
Issue: Example app and test code sharing between endorsed implementations
Labels: team,package,team-ecosystem,P2,triaged-ecosystem

Right now we're copy-pasting the example apps into the endorsed implementations. We should have a standard way to share example app code.
Repository: flutter
Issue: [web] re-enable modifier state for lock keys
Labels: framework,platform-web,P3,team-web,triaged-web

Sending the modifier state with lock keys was causing an issue for Flutter For Web flutter/flutter#45250

The ideal solution is having another API on Flutter Framework specifically for sending the locks.

After this [PR](https://github.com/flutter/engine/pull/14165), web engine will stop sending the modifier state for lock keys. we should re-enable them once the framework side is ready.
Repository: rust
Issue: #[link_section] is only usable from the root crate
Labels: A-linkage,A-attributes,E-needs-test,T-compiler,C-bug

Consider the following MNWE (minimal non-working example :smile:):
```bash
~ $ mkdir mwe
~ $ cd mwe
~/mwe $ cargo new a
     Created binary (application) `a` package
~/mwe $ cargo new --lib b
     Created library `b` package
~/mwe $ cat <<EOF > b/src/lib.rs 
> #[used]
> #[link_section = ".mysection"]
> static X: u32 = 0;
> EOF
~/mwe $ echo 'b = { path="../b" }' >> a/Cargo.toml 
~/mwe $ cat <<EOF > a/src/main.rs 
> extern crate b; // link the crate
> 
> fn main() {}
> EOF
~/mwe $ cd a
~/mwe $ cat <<EOF > link.x
> ENTRY(main)
> 
> SECTIONS {
>     .mysection : ALIGN(8) {
>         _START_ = .;
>         KEEP(*(.mysection))
>         _END_ = .;
>     }
> }
> 
> ASSERT(_END_ != _START_, "Section empty");
> EOF
~/mwe $ mkdir .cargo
~/mwe $ cat <<EOF > .cargo/config
> [build]
> rustflags = ["-C", "link-arg=-Tlink.x"]
> EOF
~/mwe/a $ cargo build
   Compiling a v0.1.0 (/home/jfrimmel/mwe/a)
error: linking with `cc` failed: exit code: 1
  |
  = note: "cc" [long output omitted (libb-<hash>.rlib included)] -T../link.x"
  = note: /usr/bin/ld: Section empty
```
The setup contains two crates: the binary `a` and the dependent crate `b`. A custom linker script is used in order to put the contents of `.mysection` in a section with the same name. The assert statement makes the error visible: the static variable `X` should be moved into that section, making the section 4 bytes in size, but the section is empty.

If the `static X` is defined in crate `a`, everything works fine:
```bash
~/mwe/a $ cat <<EOF > src/main.rs
#[used]

#[link_section = ".mysection"]

static X: u32 = 0;
fn main() {}
EOF
~/mwe/a $ cargo build
   Compiling a v0.1.0 (/home/jfrimmel/mwe/a)
    Finished dev [unoptimized + debuginfo] target(s) in 0.19s
```
So the behavior is different when the `#[used] #[link_section] static` is placed in a dependency or in the currently build crate.

Am I doing something wrong (in which case it should be documented more clearly) or is there really a bug in the linker?
Repository: flutter
Issue: TextEditingController.text docs miss a reason
Labels: a: text input,framework,d: api docs,a: first hour,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-framework,triaged-framework

`TextEditingController.text` docs say it shouldn't be updated in a `build` method, but it doesn't explain why, it just says the listeners will be called. Is this for performance reasons, so the listeners won't lock the `build` method? Or are there any other issues as well?

I think the docs should include a more explained reason on the side-effects, so devs could evaluate more the impacts of their code and their decisions, or facilitate fixing bugs.
Repository: rust
Issue: Test exit code should distinguish between failed test and bad args
Labels: C-enhancement,T-compiler,T-dev-tools,A-libtest

Today, if I run a test binary with bad args like `--foo-bar`, it prints an error message and exits with code 101. Similarly, if I run a test binary correctly but one of the tests fails, it logs the test failure and exits with 101.

It would be nice if we could distinguish between these cases using only the exit code.

Hopefully nothing depends on either of those cases being exactly 101 today, but if we change the code to distinguish between them, we should probably document it and keep it stable from then on.
Repository: pytorch
Issue: Common lookup of generic types across full script and mobile parsers
Labels: feature,triaged

## 🚀 Feature
Common lookup of generic types across full script and mobile parsers

## Motivation

To maximize the codes that can be shared between the two parsers.

## Pitch

As in the title. Build the lookup of generic types (especially Dict, Tuple, List and other composing types) and make it shared by both of the parsers. 

## Alternatives

## Additional context

In future the type part of script parsers can be pulled out so that it can be directly used by both full script and mobile interpreter.