sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: vscode
Issue: Feature request: change editor's commenting behavior in makefiles
Labels: feature-request,editor-core

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
The commenting function in makefiles can be improved in two manners.

1. Create a makefile and type of a few commands such as:
```
    clean:
    	rm -f *.exe *.o
```
2. When commenting the both lines via ctrl+/, all lines will receive `# ` as a prefix. Note the space.

3. When commenting only the shell script line, the lines will receive `#', on the first line of the shell script

The issue with that:
- the extra space on generic makefile lines is difficult because it is invisible. When removing the comments manually or in another editor, this introduces errors.
- For consistency, comments should always be on the makefile level itself, rather than on the shell script line.
Repository: terminal
Issue: Add new code sample for GUIConsole using WinUI 3 - Windows App SDK v1.1
Labels: Help Wanted,Issue-Docs,Area-TerminalControl,Product-Meta

# Description of the new feature/enhancement

I'm creating a WinUI 3 Desktop application (using VS 2022 17.3 **Blank App WinUI 3 in Desktop** template) where I'd like to use the Windows Terminal API to create a terminal window control to use inside my application.

I started by looking at your [GUIConsole.WPF](https://github.com/microsoft/terminal/tree/main/samples/ConPTY/GUIConsole) sample that is written in WPF for .NET Framework 4.6.1.

I tried to port the classes and the XAML window but I'm not able to let it work. I still have errors both on XAML and on code.

# Proposed technical implementation details

Can you please add a new version of the code sample that is written using the new Windows App SDK v1.1?
Repository: godot
Issue: RigidBody2D does not fall when its support point is removed
Labels: discussion,topic:physics

### Godot version

3.5.stable

### System information

Ubuntu 20.04.4 LTS 64 bits, Intel® HD Graphics 4400 (HSW GT2) GLES 3

### Issue description

There is a RigidBody2D supported by a KinematicBody2D.
The KinematicBody2D is destroyed.
The RigidBody2D does not fall (it is asleep)

I think when the RigidBody2D is not colliding with anything it should wake up.

Workaround: RigidBody2D.apply_central_impulse(Vector2.DOWN)

should there be a method to wake up the RigidBody2D?

### Steps to reproduce

New project
Add a Node2D
Add a KinematicBody2D into Node2D with a Rectangle CollisionShape
Add a RigidBody2D into Node2D with a Rectangle CollisionShape up to KinematicBody2D
Add code to KinematicBody2D.queue_free()

RigidBody2D does not fall.

See attachment project


### Minimal reproduction project

[RigidBody2D not fall.zip](https://github.com/godotengine/godot/files/9426345/RigidBody2D.not.fall.zip)
Repository: storybook
Issue: Issues with name length of react-docgen-typescript-plugin canary package 
Labels: bug,dependencies

**Describe the bug**
The package react-docgen-typescript-plugin in canary version https://github.com/storybookjs/storybook/blob/03b6c009026b7f04991854391141886708fef457/code/presets/react-webpack/package.json#L81

causes a problem with too long package name during install `ENAMETOOLONG: name too long`

**To Reproduce**
https://github.com/hipstersmoothie/react-docgen-typescript-plugin/issues/65

**System**
Environment Info:

  System:
    OS: Linux 5.15 Linux Mint 20.3 (Una)
    CPU: (12) x64 AMD Ryzen 5 5600H with Radeon Graphics
  Binaries:
    Node: 16.15.1 - ~/n/bin/node
    Yarn: 1.22.19 - ~/n/bin/yarn
    npm: 8.11.0 - ~/n/bin/npm
  Browsers:
    Chrome: 104.0.5112.79
    Firefox: 101.0.1
  npmPackages:
    @storybook/addon-a11y: 6.4.9 => 6.4.9 
    @storybook/addon-actions: 6.4.9 => 6.4.9 
    @storybook/addon-controls: 6.4.9 => 6.4.9 
    @storybook/addon-docs: 6.4.9 => 6.4.9 
    @storybook/addon-essentials: 6.4.9 => 6.4.9 
    @storybook/addon-knobs: 6.3.1 => 6.3.1 
    @storybook/addon-storysource: 6.4.9 => 6.4.9 
    @storybook/addons: 6.4.9 => 6.4.9 
    @storybook/preset-typescript: 3.0.0 => 3.0.0 
    @storybook/react: ^6.5.10 => 6.5.10 

**Additional context**
The fork should be updated and this pull request merged with shorten hash version for canary package https://github.com/storybookjs/react-docgen-typescript-plugin/pull/6
Repository: pytorch
Issue: Better error message for qlinear_prepack
Labels: oncall: quantization,triaged

### 🐛 Describe the bug

See https://discuss.pytorch.org/t/index-out-of-bounds-error-with-perchannel-quantization/159937
linear_prepack only works for per channel quantized weight with ch_axis=0, we should have a better error message.

### Versions

master

cc @jianyuh @raghuramank100 @jamesr66a @vkuzo
Repository: material-ui
Issue: Accessibility Issue: Screen Reader not properly announcing expanded Menu
Labels: accessibility,component: menu

### Duplicates

- [X] I have searched the existing issues

### Latest version

- [X] I have tested the latest version

### Current behavior 😯

If you create a menu and apply the proper aria properties, the screen reader does not properly announce when the menu is expanded.  The screen reader announces the menu is collapsed however.

I have verified with NVDA (Windows) and the OS X VoiceOver.

### Expected behavior 🤔

The screen reader should announce when menu is expanded by clicking the related button or pressing enter via the keyboard.

### Steps to reproduce 🕹

Steps:

1.  Go to https://mui.com/material-ui/react-menu/ and observe the Basic Menu example.
2. Use the CodeSandBox button to run the code associated with the button and menu (https://codesandbox.io/s/u2u8cx?file=/demo.js)
3. Using a Screen Reader (i.e. NVDA with Windows), you will notice the menu is initially announced as COLLAPSED (which is correct).
4. Click the button or press enter on the button.  You will notice the screen reader does not announce the menu as EXPANDED.  However, the aria-expanded property is properly set.


### Context 🔦

_No response_

### Your environment 🌎

<details>
  <summary><code>npx @mui/envinfo</code></summary>

```
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
```
</details>
Repository: rust
Issue: Automatically `s/use core::/use std::/` where applicable
Labels: A-diagnostics,T-compiler

Where a developer incorrectly uses `core::` to import a type/trait/module not available in `core::` but available in `std::`, the default (and only) diagnostic should be "Foo not found in core::path::to, did you mean std::path::to::Foo?"

Example:

```rust
use core::sync::RwLock;

fn main() {}
```

Playground link: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=610c8c7d885be88995c49a1b9a36fa91

The current output is:

```
error[[E0432]](https://doc.rust-lang.org/stable/error-index.html#E0432): unresolved import `core::sync::RwLock`
 --> src/main.rs:1:5
  |
1 | [use core::sync::RwLock;](https://play.rust-lang.org/#)
  |     ^^^^^^^^^^^^^^^^^^ no `RwLock` in `sync`
```

Ideally the output should look like:

```
error[[E0432]](https://doc.rust-lang.org/stable/error-index.html#E0432): unresolved import `core::sync::RwLock`
 --> src/main.rs:1:5
  |
1 | [use core::sync::RwLock;](https://play.rust-lang.org/#)
  |     ^^^^^^^^^^^^^^^^^^ no `RwLock` in `sync`
  |                        Did you mean `std::sync::RwLock`?
```

If compiling under `#![no_std]`, then perhaps the message can be adjusted (although this might need a separate issue) accordingly, for example:


```
error[[E0432]](https://doc.rust-lang.org/stable/error-index.html#E0432): unresolved import `core::sync::RwLock`
 --> src/main.rs:1:5
  |
1 | [use core::sync::RwLock;](https://play.rust-lang.org/#)
  |     ^^^^^^^^^^^^^^^^^^ `std::sync::RwLock` is not available under `#![no_std]`
```
Repository: pytorch
Issue: Move self.subtest calls in FSDP test suite to run_subtests utility
Labels: oncall: distributed,triaged,better-engineering,module: fsdp

### 🚀 The feature, motivation and pitch

As per the discussion in https://github.com/pytorch/pytorch/pull/83195#discussion_r952931023, we can use the `self.run_subtests` functionality which will require some refactoring of test code. 

### Alternatives

_No response_

### Additional context

_No response_

cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @SciPioneer @H-Huang @kwen2501 @ezyang
Repository: vscode
Issue: Support empty workspaces edit sessions
Labels: feature-request,cloud-changes

I opened insiders.vsocde.dev, created an image, and wanted to store my edit session. Currently, that's unsupported.
Repository: PowerToys
Issue: Drag to scroll for File Explorer
Labels: Idea-New PowerToy,Product-File Explorer,Needs-Triage

### Description of the new feature / enhancement

Drag the spaces between icons for scrolling in file explorer. 

### Scenario when this would be used?

When using a mouse without or with a broken scroll wheel. Or using a pentablet instead of a mouse (which is my case) and windows doesn't give you a proper working option.

### Supporting information

I'm using an extension named "Scroll Anywhere" by Fast Addons, with my internet browser. And it's really useful but also addictive. Give it a try. Maybe get in touch with the developer. He is a nice guy.
Repository: go
Issue: crypto/ecdsa: Verify signature after signing to prevent faults from leaking private key
Labels: NeedsDecision

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.19 linux/amd64
</pre>

### Does this issue reproduce with the latest release?

Yes.

### What did you do?

It has been well known for [quite some time](https://www.researchgate.net/publication/2247203_On_the_Importance_of_Checking_Cryptographic_Protocols_for_Faults) that a single signature fault (e.g. due to a bit-flip or truncation) can lead to leaking the private key producing that signature. The crypto/rsa package has [contained a defense](https://cs.opensource.google/go/go/+/refs/tags/go1.19:src/crypto/rsa/rsa.go;l=632-637;drc=0a52d80666ddaa557cec17ad9166e2514b0bb6d4) against just such circumstances [since 2015](https://go-review.googlesource.com/c/go/+/17862/).

However, it is also possible for signature faults to leak ECDSA private keys. In particular, it [has been shown](https://eprint.iacr.org/2017/1014) that ECDSA private keys can be leaked if the same message is signed twice and one of those two signatures suffers a fault. This attack was [recently demonstrated](https://www.usenix.org/system/files/sec22-sullivan.pdf) (PDF link) to be practical.

### What did you expect to see?

I expected that ECDSA signatures would be validated immediately after being produced, in order to prevent faulty signatures from being exposed to an outside attacker.

### What did you see instead?

I do not see any signature verification happening in [the](https://cs.opensource.google/go/go/+/refs/tags/go1.19:src/crypto/ecdsa/ecdsa.go;l=111;drc=ea5d7cbc2644643331bd675b1ebdf0aaac7419f1) [ecdsa](https://cs.opensource.google/go/go/+/refs/tags/go1.19:src/crypto/ecdsa/ecdsa.go;l=214;drc=8c8429fe4113b399355c11203e60e6b37bc823ba) [call](https://cs.opensource.google/go/go/+/refs/tags/go1.19:src/crypto/ecdsa/ecdsa_noasm.go;l=15;drc=8c8429fe4113b399355c11203e60e6b37bc823ba) [stack](https://cs.opensource.google/go/go/+/refs/tags/go1.19:src/crypto/ecdsa/ecdsa.go;l=283;drc=8c8429fe4113b399355c11203e60e6b37bc823ba).

### Additional information

I believe that the golang stdlib ecdsa implementation is not _actually_ vulnerable to the signature fault attack as described above. In particular, that attack relies on the fact that many ecdsa implementations skirted the issue of bad random nonce generators by adopting deterministic nonces. It appears that the ecdsa implementation here [uses true randomness](https://cs.opensource.google/go/go/+/refs/tags/go1.19:src/crypto/ecdsa/ecdsa.go;l=240-261;drc=8c8429fe4113b399355c11203e60e6b37bc823ba), and is therefore not vulnerable. However I do believe that the implementation today _could_ silently produce faulty signatures, which we may want to avoid as both a correctness and a defense-in-depth measure.
Repository: angular
Issue: Navigating to url with "/:pathVariable" with null unicode symbols causes History.PushState error on route change
Labels: area: router,P3

### Which @angular/* package(s) are the source of the bug?

router

### Is this a regression?

No

### Description

Navigating w/ path matched variables with weird/odd unicode input cause a `History.pushState` exception.

- Define a route that has a path-matched param

```
{ path: 'home/:id', component: HomeViewComponent },
```

- Navigate to that path with a very weird Unicode param containing unicode nulls `\u0000`

```
    <a routerLinkActive="active" 
       routerLink="/home/\u0000\u0000d\u0000\u0000\u0000\u0000Q\u0000\u0000\u0000\u0000">Break me</a> 
```

- Boom, Error!

```
ERROR Error: Uncaught (in promise): SecurityError: Failed to execute 'pushState' on 'History': A history state object with URL 'https://angular-router-basic-example-w9ecym.stackblitz.io/home/%00%00d%00%00%00%00Q%00%00%00%00' cannot be created in a document with origin 'https://angular-router-basic-example-w9ecym.stackblitz.io' and URL 'https://angular-router-basic-example-w9ecym.stackblitz.io/login'.
Error: Failed to execute 'pushState' on 'History': A history state object with URL 'https://angular-router-basic-example-w9ecym.stackblitz.io/home/%00%00d%00%00%00%00Q%00%00%00%00' cannot be created in a document with origin 'https://angular-router-basic-example-w9ecym.stackblitz.io' and URL 'https://angular-router-basic-example-w9ecym.stackblitz.io/login'.
    at history.pushState (preview-d88182ac6931a.js:2:16857)
    at BrowserPlatformLocation.pushState (browser_platform_location.ts:92:1)
    at PathLocationStrategy.pushState (path_location_strategy.ts:92:1)
    at Location.go (location.ts:107:1)
    at eval (router.ts:727:37)
    at SafeSubscriber.eval [as _next] (Observable.ts:267:11)
    at SafeSubscriber.__tryOrSetError (Subscriber.ts:263:10)
    at SafeSubscriber.next (Subscriber.ts:205:23)
    at Subscriber._next (Subscriber.ts:135:22)
    at Subscriber.next (Subscriber.ts:95:12)
    at resolvePromise (zone.js:770:31)
    at resolvePromise (zone.js:741:17)
    at eval (zone.js:818:17)
    at ZoneDelegate.invokeTask (zone.js:424:31)
    at Object.onInvokeTask (ng_zone.ts:288:1)
    at ZoneDelegate.invokeTask (zone.js:423:36)
    at Zone.runTask (zone.js:191:47)
    at drainMicroTaskQueue (zone.js:584:35)
    at ZoneTask.invoke (zone.js:490:25)

```

Note, you can dupe this on any webpage, by doing:

```
history.pushState('blah', 'blah', '\u0000\u0000d)\u0000\u0000\u0000\u0000Q\u0000\u0000\u0000\u0000');
```


### Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/angular-router-basic-example-e7nmkh

### Please provide the exception or error you saw

_No response_

### Please provide the environment you discovered this bug in (run `ng version`)

```true
Google Internal ref: b/239974353
```


### Anything else?

_No response_
Repository: vscode
Issue: Debt: better URI scheme transformation for edit sessions
Labels: debt,cloud-changes

Ideally we would not be hardcoding this transformation here https://github.com/microsoft/vscode/commit/74acf9c038931c7dabfabc13c14d607f17829e9c
Repository: neovim
Issue: Cannot copy the default global value of efm using lua opt_local API
Labels: bug,lua,options

### Neovim version (nvim -v)

NVIM v0.7.2

### Vim (not Nvim) behaves the same?

N/A

### Operating system/version

Red Hat Enterprise Linux 7.7

### Terminal name/version

GNOME Terminal 3.28.2 using VTE 0.52.2 +GNUTLS

### $TERM environment variable

screen-256color

### Installation

appimage

### How to reproduce the issue

nvim --clean

:lua vim.opt_local.efm = vim.opt_global.efm:get()
:lua vim.opt_local.efm = vim.o.efm
:lua vim.bo.efm = vim.o.efm
:lua vim.bo.efm = table.concat(vim.opt_global.efm:get(), ',')

### Expected behavior

Copy the exact value of the global efm to the local option

### Actual behavior

The first 2 options truncate the original value and sets an invalid string into the local efm
Repository: flutter
Issue: Infra test failure that is not marked as "Infra failure"
Labels: team-infra,P3,triaged-infra

Hello, I am having this test failure: 
https://ci.chromium.org/p/flutter/builders/staging/Mac_ios%20native_platform_view_ui_tests_ios/486

The error is: 

 [native_platform_view_ui_tests_ios] Process terminated with exit code 0. Task result: { "success": false, "reason": "Task failed: DeviceException: No connected physical iOS devices found." }

The next test passed tho: 

https://ci.chromium.org/p/flutter/builders/staging/Mac_ios%20native_platform_view_ui_tests_ios/487


So maybe it's just one time failure (maybe the device is temporarily not responding or something?)
Repository: godot
Issue: some transformations in 3d make check for translation value fail
Labels: bug,needs testing,topic:3d

### Godot version

3.4.4 stable

### System information

Windows 11, GLES3, Intel(R) UHD Graphics

### Issue description

If i use re-parenting to rotate a 3d node around the parent node´s origin by rotating and than parent back to root with keeping the global transforms, some checks for translation values fail.

The code function, that produces the bug:
```
func spin_y(offset, angle):
	for cubie in cubies:
		if int(cubie.translation.y) == offset:
			cube.remove_child(cubie)
			cube_core.add_child(cubie)
	
	cube_core.rotation_degrees.y += angle
	
	for cubie in cubies:
		if cubie.get_parent() == cube_core:
			var old_transform = cubie.global_transform
			cube_core.remove_child(cubie)
			cube.add_child(cubie)
			cubie.global_transform = old_transform
		print(cubie.name, \": \", offset, \" = \", cubie.translation.x, \" -> \", cubie.translation.x == offset)
	
	cube_core.rotation_degrees.y -= angle
```

### Steps to reproduce

1. Run the reproduction project in your godot environment
2. click on the yellow cube-face, where the cursor turns into a pointing finger to run the shown function
3. check the output in the console, that is made by the print command in the shown function
4. if the x translation is not changed by the function in one such try, the output says false while both values are the same.

### Minimal reproduction project

https://github.com/Drachenbauer/Rubiks_Cube_bug
Repository: TypeScript
Issue: Refactor inner function to module level
Labels: Suggestion,Awaiting More Feedback

Give the following code

```
function outer() {
  const outerVar = abc();
  function inner() {
     const innerVar = outerVar;
     rest();
  }
}
```

I'd like to right click on `inner()` and *refactor -> Extract inner method to module level*  that will do:

```
function outer() {
  const outerVar : Xyz = abc();
  const inner = createInner(outerVar);
}

function createInner(outerVar : Xyz) {
  return function inner() {
     const innerVar = outerVar;
     rest();
  }
}
```
Repository: terminal
Issue: Mark mode hyperlink navigation sometimes skips over entries
Labels: Help Wanted,Area-Interaction,Issue-Bug,Product-Terminal

Here's a bunch of bugs we found during our bug bash that are related to tab to hyperlink and mark mode

- [ ] If Shift+tab causes scroll and new selection is on multiple lines, we scroll to show the "end" (should show the whole thing)
- [ ] Shift+tab skips over hyperlink that is (end) partially included in top row of view 
- [x] If a selection exists, mark mode should happen on the existing selection (#13893)
- [x] Ctrl+enter on random selection clears selection. Maybe it should try to treat selection as a URL?
- [x] Mark mode --> move to middle of word --> ExpandSelectionToWord --> Shift+Right/Left --> weird updated selection (#13893 )
- [ ] https://github.com/microsoft/terminal/pull/13494#issuecomment-1234559792
- [ ] remove `_selectionIsTargetingUrl`, instead check if new selection matches old selection. If so, skip it.
Repository: flutter
Issue: Add an option to let GestureDetector/InkWell trigger onTap/onTapUp when doubleclick
Labels: framework,f: material design,customer: google,c: proposal,P2,team-design,triaged-design

## Use case

Currently, GestureDetector/InkWell:

- Does not trigger onTap/onTapUp on double tap, only onDoubleTap/onTapDown.
- If the onDoubleTap event is enabled, onTap/onTapUp is triggered with a delay(300ms?) on single tap, #50458.

This design may not be a big problem on mobile platforms, since double taps are not used very often.
But on desktop, it's everywhere and the user experience is poor due to the onTap latency.
onTapDown is not delayed, but it cannot replace onTap/onTapUp.

## Proposal

It's better to add a global option to:

- Trigger onTap/onTapUp without a delay on single tap no matter the onDoubleTap is enabled or not.
- Make GestureDetector/InkWell also trigger onTap/onTap(without a delay) on double tap.Take Microsoft's WPF framework as an example, on double tap, it triggers MouseLeftButtonDown/MouseLeftButtonUp twice and MouseDoubleClick once.
Repository: PowerToys
Issue: Request: An entire new feature: WindowSaver
Labels: Idea-New PowerToy,Product-Tweak UI Design,Product-FancyZones

### Description of the new feature / enhancement

What I'm requesting is a new feature that allows you to save the size and position of windows that will do the following:

- Save the currently open windows.
- Allow you to load window positions; it will load any windows that match and ignore any that don't.
- Set default size and / or position.
- Work with FancyZones and each new window will open in the next zone. (ok maybe this is a FancyZone request).
- Set it so that when you load an app or window, it will automatically load it in the saved setting for that specific app/window.

### Scenario when this would be used?

I use FancyZone extensively. Like... a LOT. I love it.

I'd love to be able to sort my open windows at the click of a button or press of a shortcut key, or even have it do it automatically.

Thanks for considering guys. 
I can't live without PowerToys!!!

### Supporting information

_No response_