sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: TypeScript
Issue: TS Spec doesn't match implementation re method signature definitions
Labels: Docs

[TS Spec § 3.9.5](https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#395-method-signatures) says:

> A method signature of the form
>```ts 
> f < T1, T2, ... > ( p1, p2, ... ) : R
>```
>is equivalent to the property declaration
>```ts
>f : { < T1, T2, ... > ( p1, p2, ... ) : R }
>```


But this is not the case with `--strictFunctionTypes`:
```ts
interface IFoo1 {
    bar(baz?: number): void
}
class Foo1 implements IFoo1 {
    bar: (baz: number) => void = (n) => void 0;
}

interface IFoo2 {
    bar: { (baz?: number): void }
}
class Foo2 implements IFoo2 {
    bar: (baz: number) => void = (n) => void 0; // err: Property 'bar' in type 'Foo2' is not assignable to the same property in base type 'IFoo2'.
}
```

I understand that the method bivarience in general is intentional as per the [PR](https://github.com/Microsoft/TypeScript/pull/18654):
>With this PR we introduce a --strictFunctionTypes mode in which function type parameter positions are checked contravariantly instead of bivariantly. *The stricter checking applies to all function types, except those originating in method or construcor declarations*

But it would be nice if the spec didn't state the syntaxes were equivalent when they aren't.
Repository: TypeScript
Issue: Default values for jsconfig.json override extended values
Labels: Bug

**TypeScript Version:**  3.8.0-dev.20200207

**Search Terms:** jsconfig extend override defaults

**Code**

```jsonc
// a/jsconfig.json
{
  "files": ["test.js"],
  "compilerOptions": {
    "maxNodeModuleJsDepth": 0
  }
}
```
```jsonc
// b/jsconfig.json
{
  "extends": "../a/jsconfig.json"
}
```
```javascript
// a/test.js
console.log("hello");
```


**Reproduce**

```bash
mkdir -p a b
echo '{"files":["test.js"],"compilerOptions":{"maxNodeModuleJsDepth":0}}' > a/jsconfig.json
echo '{"extends":"../a/jsconfig.json"}' > b/jsconfig.json
echo 'console.log("hello");' > a/test.js
```
```bash
npx tsc -p a/jsconfig.json --showConfig
npx tsc -p b/jsconfig.json --showConfig
```

**Expected behavior:**
Both implied configs A and B have `compilerOptions.maxNodeModuleJsDepth: 0`.

**Actual behavior:**
Implied config A has `compilerOptions.maxNodeModuleJsDepth: 0`.
Implied config B has `compilerOptions.maxNodeModuleJsDepth: 2`.
Output:
```json
{
    "compilerOptions": {
        "allowJs": true,
        "maxNodeModuleJsDepth": 0,
        "allowSyntheticDefaultImports": true,
        "skipLibCheck": true,
        "noEmit": true
    },
    "files": [
        "./test.js"
    ]
}
{
    "compilerOptions": {
        "allowJs": true,
        "maxNodeModuleJsDepth": 2,
        "allowSyntheticDefaultImports": true,
        "skipLibCheck": true,
        "noEmit": true
    },
    "files": [
        "../a/test.js"
    ]
}
```

Implied config B has `maxNodeModuleJsDepth: 2` despite it extending config A which explicitly sets `maxNodeModuleJsDepth: 0`.

**Possible cause**
This may be caused by the default values for config files named `jsconfig.json` overriding the values from the extended config. `maxNodeModuleJsDepth: 2` is one of the default values. See: [/src/compiler/commandLineParser.ts#L2459](https://github.com/microsoft/TypeScript/blob/master/src/compiler/commandLineParser.ts#L2690)

**Solution**
Default values for `jsconfig.json` config files should not override values **explicitly** defined by the extended configs.

**Workaround**
Explicitly set the following values in config files named `jsconfig.json` that extend other configs with non-default values:
- `allowJs`
- `maxNodeModuleJsDepth`
- `allowSyntheticDefaultImports`
- `skipLibCheck`
- `noEmit`
Repository: rust
Issue: Tests in panic=abort can hang if test spawns a subprocess
Labels: A-libtest,C-bug,T-libs

If a test (running in a subprocess, because panic=abort) spawns a sub-subprocess which inherits its stdout or stderr handles, and the sub-subprocess does not exit when the test does, the test framework will hang. This is because [`wait_with_output`](https://github.com/rust-lang/rust/blob/fb29dfcc9ada6ed10308b6e7f405569f61a9af0b/src/libstd/process.rs#L1469-L1491) waits for all stdio handles to be closed.

```
libtest runner         (waits for unit test stdio to close)
       |
       |  Stdio::piped
       |
unit test process      (exits, but stdio is now shared with subproc)
      ||
      ||  Stdio::inherit
      ||
"leaked" subprocess    (sticks around forever)
```

Some tests spawn subprocesses, and it can be hard (particularly with panic=abort) to ensure that they are all cleaned up when the test succeeds or fails. In these cases, it would be best not to hang. Hanging is unexpected, and hard to debug.
Repository: flutter
Issue: Web engine: find the best way to apply static CSS properties
Labels: engine,platform-web,c: proposal,c: rendering,P2,team-web,triaged-web

There are several CSS properties that we set on nearly every element we create, such as `position:absolute` and `transform-origin: 0 0 0`. Currently we do this in an ad hoc fashion. We also sometimes reassign these repeatedly to the same value (particularly `transform-origin`). For example, there are 13 places that set `transform-origin: 0 0 0`. Consider finding a more centralized method for setting up elements using the fastest method available. For example:

* Have a shared function that initializes newly elements.
* Use a style sheet that applies shared static properties.

/cc @mdebbar
Repository: go
Issue: x/pkgsite: README images should be proxied to protect user privacy
Labels: NeedsInvestigation,pkgsite,pkgsite/frontend

The overview page links directly to images referenced from the readme markdown.  These references allow third parties to track users on pkg.go.dev.

Github proxies images referenced from the readme to prevent such tracking.  See the following for more information:

- https://github.blog/2014-01-28-proxying-user-images/
- https://help.github.com/en/github/authenticating-to-github/about-anonymized-image-urls

pkg.go.dev should do the same.

### What is the URL of the page with the issue?

https://pkg.go.dev/github.com/labstack/echo?tab=overview and many other ?tab=overview pages.
  
### What did you do?
 
I visited the page. 
 
### What did you expect to see?
 
I expected to see requests to pkg.go.dev and it's trusted partners.

### What did you see instead?

I saw image requests to sourcegraph.com, img.sheilds.go and goreportcard.com.
Repository: flutter
Issue: Fix the discrepancy between WidgetTester.pumpWidget() and runApp()
Labels: a: tests,framework,P2,team-framework,triaged-framework

@yjbanov:
> The first frame of an app (launched via `runApp()`) is preceded by a `BuildOwner.buildScope()` without laying out the scene, while the first frame of a test (the first invocation of `WidgetTester.pumpWidget()`) does perform layout. Therefore, code that attempts to access layout information can fail depending on which environment it runs in.

For reference and more context, please see https://github.com/flutter/flutter/pull/48922
Repository: pytorch
Issue: Move the custom pass execution back to the beginning of runNondiffOptimization
Labels: oncall: jit,triaged

## 🐛 Bug

This is about the JIT compilation.

https://github.com/pytorch/pytorch/pull/29256 moved the execution of custom passes to the end of `runNondiffOptimization`.

This change has an adverse effect on a custom pass that we have been working on.  With this change, our custom pass cannot see the graph in the original form and can only see the nodes that are not taken by the fusion pass.  This limits the efficacy of our custom pass.

I believe that we are not the only one affected by this change.  And due to this issue, we have decided not to move to PyTorch 1.4.

## Environment

PyTorch version: 1.3.0a0+ee77ccb
Is debug build: No
CUDA used to build PyTorch: 10.1.243

OS: Ubuntu 18.04.4 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.14.0

Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: Quadro GV100
Nvidia driver version: 440.33.01
cuDNN version: Could not collect

Versions of relevant libraries:
[pip] numpy==1.16.4
[pip] torch==1.3.0a0+ee77ccb
[pip] torchvision==0.4.2
[conda] blas 1.0 mkl
[conda] mkl 2019.4 243
[conda] mkl-include 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.15 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] torch 1.3.0a0+ee77ccb dev_0
[conda] torchvision 0.4.2 pypi_0 pypi

cc @suo @apaszke
Repository: flutter
Issue: Add golden test for safe area with transparency
Labels: a: tests,platform-android,engine,e: embedder,c: proposal,P2,team-android,triaged-android

Create a framework golden test that launches an Android `FlutterActivity` with transparency enabled. The golden test should ensure that safe area is respected.

The embedding change that lead to this ticket is here:
https://github.com/flutter/engine/pull/16208
Repository: godot
Issue: Vsync with compositor causes FPS fluctuation when maximized on 144Hz monitor
Labels: bug,topic:rendering

**Godot version:**
3.2 (Mono)

**OS/device including version:**
- Windows 10
- NVidia GTX 1060 

**Issue description:**
After turning on VSync and VSync with compositor, the game sometimes stutters every ~2 seconds and gets stuck in a constant battle between 60 and 80-70 fps.

- I'm using one 144Hz monitor, and two 60Hz monitors
- The issue only seems to be present when the game is maximized on the 144Hz monitor, and as explained above causes the FPS to constantly switch between 60 and 80-70
- Running in fullscreen on the 144Hz monitor locks the FPS at 144Hz (which is to be expected)
- Running on any of the 60Hz monitors locks the FPS at 60Hz (which is to be expected)
- Running a debug or release build does not fix the issue

It's happening in every scene of my game, including the static title screen, which leads me to believe the game itself has minimal if any effect on the stutters.

![unknown](https://user-images.githubusercontent.com/7606171/74072599-94ce5c80-4a07-11ea-9e9c-26283a4ff9e9.png)
The FPS debugger as well as an in-game FPS label show the FPS fluctuating until I moved the game to a 60Hz monitor, after which the FPS is correctly locked at 60.

**Steps to reproduce:**
- Run game maximized on 144Hz monitor and observe stutters
- Run game maximized on 60Hz monitor and stutters won't be present
- Run game fullscreen on 144Hz monitor and stutters won't be present either
Repository: godot
Issue: Mono build crash on Android when ProjectSettings/mono/profiler/enabled is set to true
Labels: bug,platform:android,confirmed,topic:dotnet

**Godot version:**
Godot_v3.2-stable_mono_win64

**OS/device including version:**
Android

**Issue description:**
When exporting to Android (I did so using the little Android icon at the top right after connecting my device), the game won't start when ProjectSettings/mono/profiler/enabled is set true. Have confirmed this on an empty project

**Steps to reproduce:**
1. Create a new project
2. Set ProjectSettings/mono/profiler/enabled to true
3. Export for Android
4. Run on device

**Minimal reproduction project:**
Can be done with an empty project
Repository: pytorch
Issue: [RFC] Add ability to get all remote parameters when constructing DistributedOptimizer.
Labels: triaged,module: rpc

## 🚀 Feature
Currently with model parallel/RPC based training, the user is required to themselves pass in all parameters, as RRefs that participated in the backwards pass and pass those into the DistributedOptimizer. This requires the user to always add 1-2 boilerplate functions to their training code, see the tutorial by @mrshenli (https://pytorch.org/tutorials/intermediate/rpc_tutorial.html). This could be an even worse UX if it is recursive, such as if the forward pass went from node A --> B --> C and the Dist optimizer needs to be created on C.

After a discussion with @mrshenli , we think it might be feasible to provide this API ourselves. It would be tricky since we would need to know all RRefs that have parameters that need to be optimized, and discover those ourselves. The following design was proposed by @mrshenli : 

`get_all_remote_params(model: nn.Module)`
1. model.get_parameters() to create local rrefs
2. vars(model) to get all attributes and pick out all RRef attributes. Then we visit all OwnerRRefs to recursively do this.

With this the user could build the DistributedOptimizer without writing code that needs to discover all parameter RRefs themselves.

Interested in feedback on what this API/implementation could look like.

cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar
Repository: youtube-dl
Issue: Euscreen.eu
Labels: site-support-request

- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.01.24**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones

- Single video: http://euscreen.eu/item.html?id=EUS_C8664133069B4AC7B5AC68549FD44510
- Single video: http://euscreen.eu/item.html?id=EUS_3AB03731FD5070D4E118D8DB42BEF59D
- Playlist: http://www.euscreen.eu/search.html?activeFields={"provider":["RAI"]}

EUscreen is a website that provides free access to Europe's television heritage through videos, articles, images and audio from European audiovisual archives and broadcasters.

It's possible only one transfer per ip works simultaneously.
Also changing user agent to android might be required. 

Playlists (search results) seem to use javascript to load more results.

Later edit: I discovered that it uses multiple stream sources (found at least 2) depending on provider of media. For example one is this open directory: https://euscreen.orf.at/content/ hosted by the provider of media itself. Others use this more complicated one:

http://lod.euscreen.eu/data/EUS_3C6BD32E727B4B1E807C7CB976A22C8F.rdf ->  329493_03_20060412_Catastrophes_tschernobyl_EUscreen_4-3.mp4 - > http://euscreen.eu/item.html?id=EUS_3C6BD32E727B4B1E807C7CB976A22C8F -> stream10.noterik.com/progressive/stream10/domain/euscreen/user/eu_dw/video/199/rawvideo/1/raw.mp4?ticket=53388157

It's a custom ticket based file/streaming server, which is open source. You can find it here:
https://github.com/Noterik/Carl
https://www.slideshare.net/nisv_rd/html-5-a-security-solution-for-euxcreenxl - on page 9 of this slide you can see the basic outline of how it works.
The ticket uses a cookie/source ip combo probably, has an expiration, and is probably limited to one connection at time. Hope someone can get it to work.
Repository: godot
Issue: Script editor gets upset if an autoload singleton references itself explicitly by name
Labels: bug,topic:gdscript

**Godot version:**
3.2 stable

**OS/device including version:**
Windows 10 x64

**Issue description:**
When an autoload has a field element that is explicitly referred to within the autoload script, for example an autoload named `global` with a field `test`, and inside the script, it references itself like `global.test` (probably requires a design-time evaluation), this can eventually cause problems for other scripts which reference the value.  Scripts which reference this autoload by name in any way will all show the same error, an error similar to "Couldn't fully load the script (Possible cyclic reference?)".  Despite this, the game I observed this problem in could still run without issues.

This issue appeared when first opening my game in 3.2;  the last version of Godot the project was opened in was 3.1.1 stable.

**Steps to reproduce:**
Unfortunately, I was unable to reproduce this after fixing the initial problem described above and removing the reference to `global`  within my autoload.  In order to clear the error message, I had to close and re-open the project.  I imagine the issue occurs when first loading the project and may be more difficult to reproduce as a result.  

It's unclear if this is a bug or a feature.  It may still be considered undesired behavior if an autoload is *supposed* to understand explicit references to itself are to the singleton and not a cyclic reference.  If 3.2 implemented better cyclic resource checking, this may be a side effect of it, but it may also be a problem in the order of loading resources for the purpose of building a "map" of values for autocomplete / validation.
Repository: go
Issue: encoding/xml: decoding a>b>c decoration syntax should support namespaces
Labels: ExpertNeeded,NeedsInvestigation

<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version 1.13.5 windows/amd64
</pre>

### Does this issue reproduce with the latest release?
Yes, behaves same on 1.13.7

### What operating system and processor architecture are you using (`go env`)?
Windows/amd64 but this is repeatable at least on linux

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env

</pre></details>

### What did you do?
I set up a struct with

I set up this set of structures
```
type myGetValueResponseEnvelope struct {
	XMLName xml.Name `xml:"http://schemas.xmlsoap.org/soap/envelope/ Envelope"`
	Body    myGetValueResponseBody
}
type myGetValueResponseBody struct {
	XMLName xml.Name `xml:"http://schemas.xmlsoap.org/soap/envelope/ Body"`
	Value   string   `xml:"getValueResponse>getValueReturn"`
}
```
to decode this XML:
```
<?xml version="1.0" encoding="utf-8"?>
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
   <soapenv:Body>
      <getValueResponse soapenv:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
         <getValueReturn xsi:type="xsd:string">69.1</getValueReturn>
      </getValueResponse>
   </soapenv:Body>
</soapenv:Envelope>
```

but I wanted to eliminate the second object by using a>b>c syntax.   Note though that the soapenv namespace is as far as Body but not farther. So I attempted this

```
type myGetValueResponseEnvelope struct {
	XMLName xml.Name `xml:"http://schemas.xmlsoap.org/soap/envelope/ Envelope"`
	Value string `xml:"http//schemas.xmlsoap.org/soap/envelope Envelope>getValueResponse>getValueReturn"`
}
```

but it doesn't SEEM with a>b>c syntax that there's any way to have namespaces in all or (in my case) part of the xpath.

I can just eliminate the namespace requirement on Body and it actually decodes just fine, so this isn't an urgent issue at the moment, but some day I may want to be more selective.  Regardless it seems the answer would be to split on > then ' ' then process it as usual.
Repository: godot
Issue: FileDialog does not place its elements correctly with the theme used in Godot Editor (?)
Labels: bug,topic:editor,confirmed,topic:gui

**Godot version:** 3.2-stable
**OS/device including version:** Debian Buster amd64

**Issue description:**
This is a minor UI nitpick, but I guess it may cause other similar (theming?) problems.
When used in an editor plugin, FileDialog does not place its items correctly (depends on the theme?).

**Steps to reproduce:**
- Use FileDialog in an editor plugin
- Set mydialog.dialog_text to something
- Set mydialog.rect_size to something (or mydialog.set_size() - by the way, what's the difference and what should be used?)
- The last line of the dialog text will be obscured by the other window elements.
- If you make it resizable and resize it  with your mouse, the problem fixes itself.

**Workarounds**:
- Add a newline at the end of dialog_text
- Or use popup_centered(newsize) instead of set_size(newsize)

**Minimal reproduction project:**
Create an editor plugin and paste this into its main script:

```
tool
extends EditorPlugin

var button
var dialog

func _enter_tree():
	button = Button.new()
	button.text = "TEST"
	add_control_to_container(EditorPlugin.CONTAINER_TOOLBAR, button)
	
	dialog = FileDialog.new()
	dialog.dialog_text = "Enter a path to something:\n(Or don't. I don't care)"
	dialog.mode = FileDialog.MODE_OPEN_FILE
	dialog.resizable = true
	
	# Choose either one
	dialog.rect_size = Vector2(400, 300)
#	dialog.set_size(Vector2(400, 300))
	
	button.add_child(dialog)
	button.connect("pressed", dialog, "popup_centered")

func _exit_tree():
	button.queue_free()
```
And click the "TEST" button.
Expected result:
![expected](https://user-images.githubusercontent.com/16963337/74083627-80c24380-4a77-11ea-8197-dd7ae6cc0eaf.png)
Actual result:
![actual](https://user-images.githubusercontent.com/16963337/74083626-799b3580-4a77-11ea-9ca6-ade68103df2e.png)
But after we pull on it a little:
![pull](https://user-images.githubusercontent.com/16963337/74083678-07772080-4a78-11ea-8075-a9fe149bc83a.png)
Repository: rust
Issue: Audit src/rustllvm/RustWrapper.cpp for C APIs that are now in upstream LLVM.
Labels: C-cleanup,A-LLVM,T-compiler

Specifically, functions which are implemented in the oldest supported LLVM version.

- [x] LLVMRustSetComdat => Comdat.h https://github.com/rust-lang/rust/pull/131876
- [ ] LLVMRustModuleBuffer => Core.h::LLVMMemoryBufferRef
- [ ] LLVMRustDI* => Debuginfo.h::LLVMDI*

We can also consider to polyfill some functions that are available in our fork, but not in some older supported version, using the same name and signature, instead of our own.

cc @alexcrichton @nagisa @nikic @hanna-kruppe