sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: fmt: is %% a literal percent, or a degenerate conversion?
Labels: NeedsInvestigation

During the review of the printf format-string parser used by gopls (extracted from the one in vet's printf checker), the question arose as to whether %%  is nothing more than a literal percent sign, dealt with by the printf scanner, or a degenerate conversion supporting width, flags, precision, and so on. 

Empirically, the surprising answer is that it is very much a conversion. Observe that it accepts a width, even indirectly, and updates the argument index accordingly (though it doesn't actually left-pad the output):

https://go.dev/play/p/Z4s7oV2HIM7
```go
var unused any
width := 456
v := 789
fmt.Printf("%[2]*[4]% %v", unused, width, unused, v) // "% 789"
```
(Either way this seems wrong: the argument at index 4 should either be rejected or consumed by the %%; instead it becomes the operand of %v.)


Aside: I checked C for precedent, and found that it too empirically treats %% as a conversion:
```
$ cat a.c
#include <stdio.h>
int main() { printf("%10.2%%d\n", 4); }
$ gcc a.c && ./a.out
         %4
```
Notice the left-padding to ten spaces. However, this program has undefined behavior according to [POSIX.1](https://pubs.opengroup.org/onlinepubs/009695399/functions/printf.html):

> Print a '%' character; no argument is converted. The complete conversion specification shall be %%.


What is the intended behavior for Go?
Repository: rust
Issue: Tracking Issue for APC #316: In-place case change methods for String
Labels: T-libs-api,C-tracking-issue

<!--
Thank you for creating a tracking issue!

Tracking issues are for tracking a feature from implementation to stabilization.

Make sure to include the relevant RFC for the feature if it has one.

If the new feature is small, it may be fine to skip the RFC process. In that
case, you can use `issue = "none"` in your initial implementation PR. The
reviewer will ask you to open a tracking issue if they agree your feature can be
added without an RFC.
-->

Feature gate: `#![feature(string_make_uplowercase)]`

This is a tracking issue for [APC #316](https://github.com/rust-lang/libs-team/issues/316)

This APC proposes that a new API is added to String to change cases and do so efficiently by consuming self and reusing the buffer, not allocating in most cases.

The exact implementation remains to be discussed, but the idea would be that in cases where it is possible, the case change is done in place. Once that isn't possible, a auxiliary DE-queue can be used to store bytes temporarily.

### Public API


This would add the following methods (names to be determined)

```rust
impl String {
	fn into_uppercase(&mut self);
	fn into_lowercase(&mut self);
}
```

### Steps / History

<!--
For larger features, more steps might be involved.
If the feature is changed later, please add those PRs here as well.
-->

- [ ] Implementation: #135888
- [ ] Final comment period (FCP)[^1]
- [ ] Stabilization PR

<!--
Once the feature has gone through a few release cycles and there are no
unresolved questions left, the feature might be ready for stabilization.

If this feature didn't go through the RFC process, a final comment period
(FCP) is always needed before stabilization. This works as follows:

A library API team member can kick off the stabilization process, at which point
the rfcbot will ask all the team members to verify they agree with
stabilization. Once enough members agree and there are no concerns, the final
comment period begins: this issue will be marked as such and will be listed
in the next This Week in Rust newsletter. If no blocking concerns are raised in
that period of 10 days, a stabilization PR can be opened by anyone.
-->

### Unresolved Questions

<!--
Include any open questions that need to be answered before the feature can be
stabilised. If multiple (unrelated) big questions come up, it can be a good idea
to open a separate issue for each, to make it easier to keep track of the
discussions.

It's useful to link any relevant discussions and conclusions (whether on GitHub,
Zulip, or the internals forum) here.
-->

- None yet.

[^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html


<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"krtab"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
Repository: vscode
Issue: Extend VSIX options for downloading other versions
Labels: feature-request,extensions

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
You can since 1.96.4 download the VSIX from a plugin by RMB and then select Download VSIX or the pre-released version.
For example from Python.
Extend this menu to download also older VSIX versions
And then be able to select a specific older version.

Reason for asking is that our Linux environment is very strict and closed with no internet connection.
VSIX are allowed to install.
But our CODE version is not always the latest one.
So with 1.96.4 I would like to download the 1.89.1 version of the VSIX from Python.
This is currently not possible

So something like this:

![Image](https://github.com/user-attachments/assets/590ea7f6-5460-4037-bd79-85f604512fd1)
Repository: flutter
Issue: Allow depending on `ModalRoute.popDispositionOf(context)`
Labels: c: new feature,framework,f: routes,c: proposal,team-framework

### Use case

I want to implement a custom widget that can close the current route using a gesture. One of my requirements is that the gesture is not accepted, if the current route can't be popped using a gesture (aka its `popDisposition` is `.doNotPop`).

Unfortunately, I found no way to keep my widget updated, since depending on `ModalRoute.of(context)` doesn't trigger a rebuild when the `popDisposition` changes, and its Notifications bubble upwards, so the route's contents can't receive them.

### Proposal

Add `popDisposition` as an aspect to the respective `InheritedModel` so that we can depend on it reliably.
Repository: angular
Issue: Signals with custom change methods
Labels: area: core,canonical,core: reactivity,cross-cutting: signals

### Which @angular/* package(s) are relevant/related to the feature request?

core

### Description

By default a signal comes equipped with a generic `.set` / `.update` methods. However, many signals used in practice represent a piece of state that can / should only change in a particular way - as an example a counter can be incremented, decremented and reset. In other words, there are many cases where we want to _enforce constraints_ on the possible state changes.

Ideally we could collocate _state_ and _change methods_ in one cohesive unit. We do recognize the need in this area and see a couple of patterns used in practice. Opening this issue to capture the patterns we are aware of, judge interest, solicit more ideas etc.

### signal creation method with custom mutation methods on a getter

Example from https://github.com/angular/angular/issues/59615:

```typescript
export function createCounter(initialValue: number = 0): WritableSignal<number> & {increase: () => void; decrease: () => void; reset: () => void} {
  const c = signal(initialValue);
  
  return Object.assign(c, { 
    increase: () => {
       c.update(x => x + 1);
    },
    decrease: () => {
       c.update(x => x - 1);
    },
    reset: () => {
       c.set(initialValue);
    }
  })
}

// usage

@Component()
export class SomeCmp {
  c = createCounter();

  onClick() {
    this.c.increase();
    this.c.decrease();

    this.c.reset();
    this.c.set(100);
    this.c.update(x => x + 2);
  }
}
```

Pros:
* feels natural as have a similar API shape as a regular signal

Cons:
* somewhat awkward to write
* doesn't account for hiding / removing the default `set` / `update` methods

### signal wrapped in a class with custom mutation methods

Example: 

```typescript
class CounterState {
    private _state = signal(0);
    public state = this._state.asReadonly();
  
    increment() {
        this._state.update(v => v + 1);
    }

    decrement() {
        this._state.update(v => v - 1);
    }

    reset: () => {
      this._state.set(0);
    }
}

// usage

@Component()
export class SomeCmp {
  c = new CounterState();

  onClick() {
    this.c.increase();
    this.c.decrease();

    this.c.reset();
    // default mutation methods removed from the public API
    // this.c.set(100);
    // this.c.update(x => x + 2);
  }
}
```

Pros:
* fairly straightforward
* can control if default set / update mutations are exposed 

Cons:
* somewhat verbose to write
* requires additional property access (`c.state()` instead of `c()`) to get to the value
* doesn't account for hiding / removing the default `set` / `update` methods
Repository: vscode
Issue: Automatically zoom the window level
Labels: feature-request,zoom


Type: <b>Bug</b>

Automatically zoom the window to about 40-60% when I open a new instance of VS Code.

VS Code version: Code 1.96.4 (cd4ee3b1c348a13bafd8f9ad8060705f6d4b9cba, 2025-01-16T00:16:19.038Z)
OS version: Windows_NT x64 10.0.22631
Modes:


<!-- generated by issue reporter -->
Repository: material-ui
Issue: [Chip] Variant typescript error
Labels: component: chip,status: waiting for author,typescript

### Steps to reproduce


```jsx
 <Chip variant="outlined" color="warning" />
 ```


### Current behavior

No overload matches this call.
  Overload 1 of 2, '(props: { component: ElementType<any, keyof IntrinsicElements>; } & ChipOwnProps & CommonProps & Omit<any, "className" | ... 15 more ... | "variant">): Element | null', gave the following error.
    Type '"outlined"' is not assignable to type '"positive" | "negative" | undefined'.
  Overload 2 of 2, '(props: DefaultComponentProps<ChipTypeMap<{}, "div">>): Element | null', gave the following error.
    Type '"outlined"' is not assignable to type '"positive" | "negative" | undefined'.

### Expected behavior

no error

### Context

_No response_

### Your environment

  System:
    OS: Windows 10 10.0.19045
  Binaries:
    Node: 22.11.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.9.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: Not Found
  Browsers:
    Chrome: Not Found
    Edge: Chromium (127.0.2651.74)
  npmPackages:
    @emotion/react: ^11.13.5 => 11.13.5
    @emotion/styled: ^11.13.5 => 11.13.5
    @mui/base:  5.0.0-beta.40
    @mui/core-downloads-tracker:  5.16.14
    @mui/icons-material: ^5.16.14 => 5.16.14
    @mui/lab:  5.0.0-alpha.173
    @mui/material: ^5.16.14 => 5.16.14
    @mui/private-theming:  5.16.14
    @mui/styled-engine:  5.16.14
    @mui/system:  5.16.14
    @mui/types:  7.2.19
    @mui/utils:  5.16.14
    @mui/x-date-pickers:  5.0.20
    @types/react: ^18.3.12 => 18.3.12
    react: ^18.3.1 => 18.3.1
    react-dom: ^18.3.1 => 18.3.1
    typescript: ^4.9.5 => 4.9.5

**Search keywords**: chip
Repository: rust
Issue: Tracking Issue for `VecDeque::pop_front_if` & `VecDeque::pop_back_if`
Labels: T-libs-api,C-tracking-issue

Feature gate: `#![feature(vec_deque_pop_if)]`

Similar to #122741, but this time with `VecDeque` instead of `Vec`.

### Public API

```rust
impl<T> VecDeque<T> {
    pub fn pop_front_if(&mut self, predicate: impl FnOnce(&mut T) -> bool) -> Option<T>;
    pub fn pop_back_if(&mut self, predicate: impl FnOnce(&mut T) -> bool) -> Option<T>;
}
```

### Steps / History

- [x] ACP: https://github.com/rust-lang/libs-team/issues/208
- [ ] Implementation: #135890
- [ ] Final comment period (FCP)[^1]
- [ ] Stabilization PR

### Unresolved Questions

- ~`Vec::pop_if` uses an explicit generic parameter for the predicate. But that might change (https://github.com/rust-lang/rust/issues/122741#issuecomment-2607734786). If it does not, probably change these methods instead to be consistent.~


[^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html
Repository: langchain
Issue: Using LangChain's ContextualCompressionRetriever with Milvus and Voyage AI Models
Labels: Ɑ: vector store

### Checked other resources

- [x] I added a very descriptive title to this issue.
- [x] I searched the LangChain documentation with the integrated search.
- [x] I used the GitHub search to find a similar question and didn't find it.
- [x] I am sure that this is a bug in LangChain rather than my code.
- [x] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

### Example Code

```python
vector_store = Milvus(
    embedding_function=embedding,
    collection_name="test",
    connection_args={
        "uri": app.config['MILVUS_URI'],
        "db_name": "test",
        "token": app.config["MILVUS_TOKEN"]
    },
    enable_dynamic_field=True
)

retriever = vector_store.as_retriever(
    search_type="similarity",
    search_kwargs={"k": 20, "param": {"ef": 50}},
    consistency_level="Strong"
)

compressor = VoyageAIRerank(model="rerank-2", top_k=12)
compression_retriever = CustomContextualCompressionRetriever(base_compressor=compressor, base_retriever=retriever)
```

### Error Message and Stack Trace (if applicable)

_No response_

### Description

I'm currently working with LangChain's ContextualCompressionRetriever and leveraging the following setup:

1. Base Retriever: Milvus Database integrated with the Voyage AI Large 2 Instruct Model for embeddings.
2. Base Compressor: Voyage AI Re-Ranker 2 Model for document filtering and ranking.

This setup successfully retrieves relevant documents, and the results have been promising. However, I now need to analyze the token count for the following:
- Re-Ranker model token usage: How many tokens are processed during the re-ranking step?
- Query embedding token usage: How many tokens are used to generate the query embedding?

Questions:
1. Is there a straightforward way to track and calculate the token count in this setup?
2. Are there any specific LangChain utilities or Voyage model APIs that provide this information?

If anyone has insights or has faced a similar challenge, I’d greatly appreciate your guidance. Thank you!

### System Info

System Information
------------------
> OS:  Windows
> OS Version:  10.0.22631
> Python Version:  3.12.2 (tags/v3.12.2:6abddd9, Feb  6 2024, 21:26:36) [MSC v.1937 64 bit (AMD64)]

Package Information
-------------------
> langchain_core: 0.3.29
> langchain: 0.3.14
> langsmith: 0.2.10
> langchain_aws: 0.2.10
> langchain_milvus: 0.1.7
> langchain_text_splitters: 0.3.5
> langchain_voyageai: 0.1.4

Optional packages not installed
-------------------------------
> langserve

Other Dependencies
------------------
> aiohttp: 3.11.11
> async-timeout: Installed. No version info available.
> boto3: 1.35.99
> httpx: 0.28.1
> jsonpatch: 1.33
> langsmith-pyo3: Installed. No version info available.
> numpy: 1.26.4
> orjson: 3.10.14
> packaging: 24.2
> pydantic: 2.10.4
> pymilvus: 2.5.1
> PyYAML: 6.0.2
> requests: 2.32.3
> requests-toolbelt: 1.0.0
> SQLAlchemy: 2.0.37
> tenacity: 9.0.0
> typing-extensions: 4.12.2
> voyageai: 0.3.2
> zstandard: Installed. No version info available.
Repository: TypeScript
Issue: Design Meeting Notes, 1/21/2025
Labels: Design Notes

# Flag for Erasable Syntax Only

* Flag in light of strippable type support for TypeScript in Node.js.
* `--erasableSyntaxOnly`
* What is it?
    * No enums, namespaces, parameter properties.
* Allow all these in ambient contexts (`declare` keywords).
* Can we get it in in the next week?
    * Probably.
* `--verbatimModuleSyntax`?
    * Compilers can do this independently?
    * Module elision is not in line with what Node itself supports.
    * Also, purists might not really be into module elision in the first place.
    * Unclear
* What about uninstantiated namespaces?
    * They should be allowed...but Node.js disallows them.
    * ```ts
      // uninstantiated - should be allowed, currently is NOT in Node.js ⚠️
      export namespace foo1 {
          export interface I {}
      }
      
      // ambient - should be allowed, currently is in Node.js
      export declare namespace foo2 {
          export interface I {}
      }
      
      // instantiated - should *not* be allowed, and is currently disallowed in Node.js
      export namespace foo3 {
          export interface I {}
      
          1 + 2;
      }
      ```
    * Arguable that being forced to write `declare` is a bit of a footgun to force everyone to write: https://github.com/microsoft/TypeScript/issues/59601#issuecomment-2296958990
        * Nice that `declare` makes it clear there's no JS
        * On the other hand, `declare` implies something is a little bit odd about the surrounding environment.
    * We think we'll allow uninstantiated namespaces, may restrict more later if we really made a mistake. New usage of this code is fairly low regardless.
Repository: react
Issue: Bug: `Suspense` components rendered by `renderToReadableStream()` cause render abort when served with Bun
Labels: Status: Unconfirmed

React version: `19.0.0`

## Steps To Reproduce

1. Install [Bun](https://bun.sh/) and [Node](https://nodejs.org/en/download)
2. Clone my [reproduction repo](https://github.com/jmuzina/react-repro)
3. Install dependencies with Bun: `bun install`
4. Run React server with Node: `bun run ssr:node`. Open the [app](http://localhost:3000) and see that the suspended Button component resolves after 2 seconds and no errors are thrown in the serverside or clientside consoles. 
5. Run React server with Bun; `bun run ssr:bun`. Open the [app](http://localhost:3000) and see that the Button component remains suspended after 2 seconds, is resolved in the serverside console but not the clientside console, and the following error is thrown in the server console:

```
8169 |   try {
8170 |     var abortableTasks = request.abortableTasks;
8171 |     if (0 < abortableTasks.size) {
8172 |       var error =
8173 |         void 0 === reason
8174 |           ? Error("The render was aborted by the server without a reason.")
                   ^
error: The render was aborted by the server without a reason.
      at abort (/home/jmuzina/software/work/canonical/repos/react-repro/node_modules/react-dom/cjs/react-dom-server.bun.development.js:8174:13)
      at cancel (/home/jmuzina/software/work/canonical/repos/react-repro/node_modules/react-dom/cjs/react-dom-server.bun.development.js:8262:17)
      at close (3:17)
```
6. Cause an app re-render by clicking the "Increment" button. See that the lazy button is resolved after 2 seconds (the "click me" button is rendered and the clientside log reports the lazy component has been resolved).

Link to code example: https://github.com/jmuzina/react-repro

## The current behavior
- Node can stream responses compatible with React.Suspense by using `react-dom.renderToPipeableStream()`. 
- Bun can stream responses with `react-dom.renderToReadableStream()`, but any Suspense boundaries are not resolved until after a re-render, and the first render of a Suspense boundary is aborted on the serverside with no reason.

## The expected behavior
Node and Bun can both stream responses compatible with React.Suspense.
Repository: pytorch
Issue: flaky test issues should close themselves if the test doesn't exist anymore
Labels: module: ci,triaged,module: flaky-tests,module: infra

I've been going through the pt2 flaky test issues and some of the tests look like they've been deleted. It would be nice for this to be automated.

cc @seemethere @malfet @pytorch/pytorch-dev-infra @clee2000 @wdvr
Repository: pytorch
Issue: Windows Pytorch compiler crash some version of cl.exe. Fix provided
Labels: module: windows,triaged,oncall: pt2

### 🐛 Describe the bug

Hi.
In _cpp_builder.py / function 'check_compiler_exist_windows'_ you check for the existence of the cl C++ compiler by calling it with a '/help' option.

However for some versions of cl.exe, the header of the help message contains some invisible invalid utf8 char (here a single xff):

_Compilateur d\'optimisation Microsoft (R) C/C++ version\xff19.35.32216.1_

This causes the following crash:
```torch._dynamo.exc.BackendCompilerFailed: backend='inductor' raised:
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 54: invalid start byte'
```


The solution would to be to remove the decode line since this is only an existence test you don't need to process the help message

```
@functools.lru_cache(None)
def check_compiler_exist_windows(compiler: str) -> None:
    """
    Check if compiler is ready, in case end user not activate MSVC environment.
    """
    try:        
        output_msg = (
            subprocess.check_output(  [compiler,   "\help"  ]  , stderr=subprocess.STDOUT)
            .strip()
            #.decode(*SUBPROCESS_DECODE_ARGS)
        )
```

### Versions

not needed

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @chauhang @penguinwu
Repository: vscode
Issue: Code Not complete properly
Labels: info-needed


Type: <b>Performance Issue</b>

Response time need so time to fix it .. If the script have so many code AI stop working ..Fix It 


VS Code version: Code 1.96.4 (cd4ee3b1c348a13bafd8f9ad8060705f6d4b9cba, 2025-01-16T00:16:19.038Z)
OS version: Windows_NT x64 10.0.19045
Modes:

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|AMD Ryzen 5 3500X 6-Core Processor              (6 x 3593)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off|
|Load (avg)|undefined|
|Memory (System)|15.95GB (3.03GB free)|
|Process Argv|C:\\Users\\Asfack Nabil\\Desktop\\DDFW\\Server-Data\\resources\\[new]\\GZ-ChillCafe --crash-reporter-id 058810eb-24d8-45d7-89f0-d855b6c6c093|
|Screen Reader|no|
|VM|0%|
</details><details>
<summary>Process Info</summary>

```
CPU %	Mem MB	   PID	Process
    2	   122	 11732	code main
    0	   288	  9828	window [1] (cl_chillcafe.lua - GZ-ChillCafe - Visual Studio Code)
    0	   107	 11772	   gpu-process
    0	   103	 11912	ptyHost
    0	    78	 13540	fileWatcher [1]
    0	    28	 14252	   crashpad-handler
    0	   335	 15532	extensionHost [1]
    0	    95	 17612	shared-process
    0	    43	 20316	   utility-network-service
```

</details>
<details>
<summary>Workspace Info</summary>

```
|  Window (cl_chillcafe.lua - GZ-ChillCafe - Visual Studio Code)
|    Folder (GZ-ChillCafe): 31 files
|      File types: png(15) lua(11) md(1)
|      Conf files:;
```

</details>
<details><summary>Extensions (12)</summary>

Extension|Author (truncated)|Version
---|---|---
vscode-html-css|ecm|2.0.12
codespaces|Git|1.17.3
copilot|Git|1.257.0
copilot-chat|Git|0.23.2
discord-vscode|icr|5.8.0
cmake-tools|ms-|1.19.52
cpptools|ms-|1.22.11
cpptools-extension-pack|ms-|1.3.0
LiveServer|rit|5.7.9
code-snapshot|rob|0.2.1
cmake|twx|0.0.17
errorlens|use|3.22.0

(2 theme extensions excluded)

</details><details>
<summary>A/B Experiments</summary>

```
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
vscaac:30438847
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythonnoceb:30805159
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupyter:31046869
nativerepl1:31139838
pythonrstrctxt:31112756
nativeloc1:31192215
cf971741:31144450
iacca1:31171482
notype1cf:31157160
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530
3d9ag387:31215808
6074i472:31201624
dwoutputs:31217127
hdaa2157:31222309
copilot_t_ci:31222730

```

</details>

<!-- generated by issue reporter -->