sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: pytorch
Issue: Adding Infiniband to RDZV Backend for optimal torch run training
Labels: oncall: distributed,module: docs

### 📚 The doc issue

The documentation can include more information on optimally using infiniband for running ML trainings using torchrun. It would be helpful to add the bash commands for users to see how to set the RDZV host to be the the infiniband url. *For Nvidia GPUs*

**Infiniband URL**
One can run `ifconfig` and parse the list to look for a key starting with `ib` (for example ib0 with inet of 10.1.0.12).

**Mellanox Ports and Link Layer**
Run `ibstat` to get the list of mellanox ports and the link layer they are using.
To verify the Mellanox ports being active or not, run `ibv_devinfo`. 

**Ping the port**
If you do not have RDMA over Infiniband protocol set, run `ping 10.x.0.y` to see if you can reach the infiniband connection. If you have RDMA installed you can verify the write latency by using  `ib_write_lat 10.x.0.y` (to verify write run `ib_write_bw 10.x.0.y`).

**Understanding Mellanox configs**
Section 7.7.1 of the A100 manual states(https://docs.nvidia.com/dgx/pdf/dgxa100-user-guide.pdf) using mlx start and run `sudo mlxconfig -e query | egrep -e Device\|LINK_TYPE` to see if you're using Infiniband or Ethernet.
Run `sudo mlxconfig -y -d <device-path> set LINK_TYPE_P1=<config-number>` to change the link type to IB.

Finally, in your `~/.bashrc`, `export MASTER_ADDR="10.x.0.y"`. and set your RDZV_BACKEND to be $MASTER_ADDR:$MASTER_PORT. Our master port values are usually 8001, 5001 (similar to ones a react dev would use, just a personal preference).
```python
torchrun \
--nnodes 3 \
--nproc_per_node 8 \
--node_rank $NODE_RANK \
--max-restarts $NUM_ALLOWED_FAILURES \
--rdzv-id $RDZV_ID \
--rdzv-backend $RDZV_BACKEND \
--rdzv-endpoint $RDZV_ENDPOINT \
scripts/train/pretrain.py \
```

Maybe these can be incorporated into the documentation? Feel free to reach out to me personally to talk more about optimized trainings including setting FlashAttention, BFloat16, Webdatasets, reading directly from raid, FSDP etc. 


<img width="1052" alt="Image" src="https://github.com/user-attachments/assets/919664b1-ba40-4c6f-a7c9-280a8c3d275a" />

`https://pytorch.org/docs/stable/elastic/run.html`

### Suggest a potential alternative/fix

_No response_

cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @svekars @brycebortree @sekyondaMeta @AlannaBurke
Repository: vscode
Issue: The window terminated unexpectedly
Labels: info-needed,freeze-slow-crash-leak

Cannot start VS Code after the most recent apt upgrade. Always got "The window terminated unexpectedly (reason: 'crashed', code: '132')".

Already tried rebooting the machine and it did not work.

- VS Code Version: 
```bash
$ code --version
1.96.3
91fbdddc47bc9c09064bf7acf133d22631cbf083
x64
```

- OS Version: 
```bash
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 24.04.1 LTS
Release:	24.04
Codename:	noble
```
Repository: vscode
Issue: Notebook: NotebookEditorSelectionChangeEvent triggers twice
Labels: bug

Originally reported in https://github.com/microsoft/vscode-discussions/discussions/1911


> I’m encountering an issue where the NotebookEditorSelectionChangeEvent triggers twice, making it challenging to determine the current selection
Repository: godot
Issue: _make_custom_tooltip() without tooltip text doesn't take over when mouse_filter is Pass.
Labels: bug,topic:gui

### Tested versions

4.4.dev7

### System information

Godot v4.4.dev7 - Pop!_OS 22.04 LTS on X11 - X11 display driver, Multi-window, 1 monitor - OpenGL 3 (Compatibility) - Mesa Intel(R) Graphics (ADL GT2) - 12th Gen Intel(R) Core(TM) i5-1235U (12 threads)

### Issue description

https://github.com/godotengine/godot/pull/97961 was supposed to make it so `_make_custom_tooltip()` works even without custom tooltip text. But I found that this doesn't work if Mouse Filter is set to Pass. It even works with the same mouse filter when tooltip_text isn't an empty string. So the implementation of the aforementioned PR fails to work in this specific scenario.

### Steps to reproduce

Implement _make_custom_tooltip() of a control, say a Button, and have it not return null. Set mouse_filter to MOUSE_FILTER_PASS. It won't work.

### Minimal reproduction project (MRP)

[tooltipbug.zip](https://github.com/user-attachments/files/18414260/tooltipbug.zip)
Repository: PowerToys
Issue: [RegistryPreview] Keyboard shortcut for standalone mode
Labels: Idea-Enhancement,Needs-Triage,Product-Registry Preview

### Description of the new feature / enhancement

It is possible to use Registry preview in standalone mode. For example to previewing data pasted from clipboard or to opening a file from within the window.

A shortcut for opening Registry Preview would be cool.

### Scenario when this would be used?

Fast opening the app.

### Supporting information

_No response_
Repository: PowerToys
Issue: [Registry Preview] Save as behavior on save button for temp file
Labels: Idea-Enhancement,Area-User Interface,Cost-Small,Product-Registry Preview

### Description of the new feature / enhancement

Instead of showing a save error when clicking on the save button after opening the Regsitry preview **without file** 

![Image](https://github.com/user-attachments/assets/e3bbf6da-bf74-4475-a9c5-ed2a4d33f22c)

**the "Save" button should behaves like "Save as". (The same as MS Office or Notepad behaves.)**


### Scenario when this would be used?

Improve the user experience.

### Supporting information

_No response_
Repository: kubernetes
Issue: https://console.cloud.google.com/storage/browser/kubernetes-release/release/ does not have latest releases
Labels: kind/bug,needs-sig,needs-triage

### What happened?

I have noticed that only the alpha version of K8s 1.32.x is available on https://console.cloud.google.com/storage/browser/kubernetes-release/release/ and only up to K8s 1.31.0. Latest update to this bucket seems to have been months ago. Is this related to https://github.com/kubernetes/kubernetes/issues/127595 / https://github.com/kubernetes/kubernetes/issues/127350 ?

### What did you expect to happen?

Latest releases including up to K8s 1.31.4 and K8s 1.32.0 should be available at https://console.cloud.google.com/storage/browser/kubernetes-release/release/

### How can we reproduce it (as minimally and precisely as possible)?

visit https://console.cloud.google.com/storage/browser/kubernetes-release/release/ and see missing releases

### Anything else we need to know?

_No response_

### Kubernetes version

<details>

```console
$ kubectl version
# paste output here
```

</details>


### Cloud provider

<details>

</details>


### OS version

<details>

```console
# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
```

</details>


### Install tools

<details>

</details>


### Container runtime (CRI) and version (if applicable)

<details>

</details>


### Related plugins (CNI, CSI, ...) and versions (if applicable)

<details>

</details>
Repository: PowerToys
Issue: [RegistryPreview] Crash clicking save on message when closing
Labels: Issue-Bug,Priority-3,Status-Reproducible,Product-Registry Preview

### Microsoft PowerToys version

0.87.1

### Installation method

PowerToys auto-update, GitHub

### Running as admin

No

### Area(s) with issue?

Registry Preview

### Steps to reproduce

1. Open Registry Preview without file.
2. Create content for a file.
3. Close app window.
4. Click "save" button.

### ✔️ Expected Behavior

Error message or save as dialog.

### ❌ Actual Behavior

App crashes.

### Other Software

_No response_
Repository: PowerToys
Issue: [Registry Preview] Enhanced preview windows for value data
Labels: Idea-Enhancement,Area-User Interface,Needs-Triage,Product-Registry Preview

### Description of the new feature / enhancement

Currently you only have the value data preview in the data grid cell and #36631 implements a tool tip to have a better preview (especially for multi line data).

I would be great to have a button in the cell to show a content dialog with a read only text box. That supports copy paste the text form the preview and would be more accessibility conform.

### Scenario when this would be used?

When previewing registry value data and especially for REG_MULTI_SZ.

### Supporting information

The text box has to support line breaks only for `REG_MULTI_SZ`.
Repository: PowerToys
Issue: Mouse Without Borders mouse rubberbanding with 1000hz/polling rate for mouse and keyboards
Labels: Issue-Bug,Needs-Triage

### Microsoft PowerToys version

0.87.1

### Installation method

PowerToys auto-update

### Running as admin

No

### Area(s) with issue?

Mouse Without Borders

### Steps to reproduce

Mouse Without Borders does not seem to work well with high Hz (polling rate), mouse and possibly keyboards as well.

at 1000hz, my mouse gets laggy in Mouse Without Borders, but it works perfectly in 500hz and 125hz. 

I even did a mouse polling rate test on my 2nd PC, mouse set to 1000hz, and the highest (peak) it registered was 700hz.

if nothing else works, an easy fix could be a button in Mouse Without Borders: "Limit mouse polling rate" that limits polling rate to 125hz for both mouse and keyboard but returns to original when its closed.

also I am not 100% sure but I think a high polling rate for keyboards might make it a bit buggy at times when typing fast. 

### ✔️ Expected Behavior

gaming mouse with fairly normal gaming mouse-polling rate to be accurate and work well on my 2nd computer with mouse without borders

### ❌ Actual Behavior

rubber-banding mouse movements on desktop 2 when on 1000hz mouse polling rate, 125hz and 500hz seems to be fine, maybe 125hz slightly better than 500hz. 

### Other Software

_No response_
Repository: flutter
Issue: Reflecting Updates in the Changelog File (3.27.2)
Labels: team-release

### Steps to reproduce

Thank you very much for regularly releasing updates and addressing the existing issues. It seems that the [Changelog file](https://github.com/flutter/flutter/blob/stable/CHANGELOG.md) does not include the recent changes made in version 3.27.2 on the stable channel. Please include the list of these changes in the file if possible.

### Expected results

 N/A

### Actual results

 N/A

### Code sample


N/A

### Screenshots or Video




### Logs




### Flutter Doctor output


[✓] Flutter (Channel stable, 3.27.2, on macOS 15.2 24C101 darwin-arm64, locale en-CA)
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 16.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.2)
[✓] VS Code (version 1.96.3)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!
Repository: go
Issue: build: build failure on x_tools-go1.23-linux-arm64_c4as16-perf_vs_gopls_0_11
Labels: NeedsInvestigation

```
#!watchflakes
default <- builder == "x_tools-go1.23-linux-arm64_c4as16-perf_vs_gopls_0_11" && repo == "tools" && mode == "build"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/b/8725813899705243009)):

    go: downloading github.com/BurntSushi/toml v1.0.0
    go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
    2025/01/13 23:53:56 Load average: 0.71 0.67 0.28 1/400 1322
    2025/01/13 23:53:56 Waiting for load average to drop below 0.20...
    2025/01/13 23:54:26 Load average: 0.43 0.60 0.27 1/402 1323
    2025/01/13 23:54:26 Waiting for load average to drop below 0.20...
    2025/01/13 23:54:56 Load average: 0.26 0.55 0.26 1/402 1323
    2025/01/13 23:54:56 Waiting for load average to drop below 0.20...
    2025/01/13 23:55:26 Load average: 0.16 0.49 0.25 1/402 1323
    2025/01/13 23:55:26 Running sub-repo benchmarks for tools
    ...
    go: downloading golang.org/x/vuln v1.1.3
    go: downloading honnef.co/go/tools v0.5.1
    go: downloading mvdan.cc/xurls/v2 v2.5.0
    go: downloading golang.org/x/text v0.21.0
    go: downloading mvdan.cc/gofumpt v0.7.0
    go: downloading golang.org/x/exp/typeparams v0.0.0-20241210194714-1829a127f884
    go: downloading github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c
    2025/01/13 23:56:57 Error running subrepo tests: error running sub-repo tools benchmark "baseline" with toolchain baseline in dir /home/swarming/.swarming/w/ir/x/w/tools/gopls/internal/test/integration/bench: exit status 1
    2025/01/13 23:56:57 FAIL
    exit status 1


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: vscode
Issue: Tools enabled later via `when` clause don't show up in vscode.lm.tools API
Labels: bug,chat,chat-tools

The tool is available for `#referencing` in chat, but it's not available on the API if the when clause is not initially true
Repository: ant-design
Issue: Support only numeric input for InputNumber
Labels: unconfirmed

### Reproduction link

[![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/p/sandbox/basic-antd-5-23-1-forked-8jy68s)

### Steps to reproduce

1. type any letter
2. notice how the letter is typed when the input field only allows numbers

### What is expected?

that works like in chrome, that only shows numbers no letters.

### What is actually happening?

show letters that are not allowed.

| Environment | Info |
| --- | --- |
| antd | 5.23.1 |
| React | 18.0.0 |
| System | Sequoia 15.1.1 |
| Browser | 18.1.1 |

---
I commented the problem here
https://github.com/ant-design/ant-design/issues/49049#issuecomment-2590926724

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: rust
Issue: `no super in the root` in non-root module
Labels: A-diagnostics,T-compiler

### Code

```Rust
#![allow(unused)]
mod foo {
    use super::{};
}
```

### Current output

```Shell
error[E0432]: unresolved import `super`
 --> src/lib.rs:3:9
  |
3 |     use super::{};
  |         ^^^^^^^^^ no `super` in the root

For more information about this error, try `rustc --explain E0432`.
```

### Desired output

```Shell
No such error
```

### Rationale and extra context

_No response_

### Other cases

```Rust
The same error happens with `self::{}`, but not `crate::{}`.
```

### Rust Version

```Shell
stable 1.84.0
nightly 2025-01-12 48a426eca9df23b24b35
```

### Anything else?

_No response_
Repository: kubernetes
Issue: Support spec.MaxUnavailable=0  to use PDB with Jobs and prevent disruptions during node upgrades
Labels: kind/feature,needs-sig,needs-triage

### What would you like to be added?

Add support to the `spec.MaxUnavailable` setting when set to 0 (zero) for PDBs used in combination with jobs. 

### **Context**
Currently, the [documentation](https://kubernetes.io/docs/tasks/run-application/configure-pdb/#arbitrary-controllers-and-selectors) states that `spec.MaxUnavailable` should not be used for resources that do not support the scale subresource, and when deployed,  the PDB shows this warning:  

> Warning  CalculateExpectedPodCountFailed  75s  controllermanager  Failed to calculate the number of expected pods: jobs.batch does not implement the scale subresource

However, by setting `spec.MaxUnavailable=0` in the PDB and use it in combination with a selector label to point the PDB to the Scaled Jobs, our testing has confirmed that it effectively prevents disruptions of Keda Scaled Jobs during node upgrades. 

**The reasoning is that when `spec.MaxUnavailable` is set to 0, there is not need to know the number of Pods running at a given moment.** 

Behavior observed during testing:

1. Node is cordoned 
2. Kubernetes attempts to evict pods running a job, and eviction is prevented by the PDB.
3. Kubernetes keeps attempting to evict the pods.
4. Jobs finish execution.
5. Kubernetes evicts the pods.
6. The upgrade can proceed.

**Example PDB Used** 
```
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: agent-scaledjob-pdb
spec:
  maxUnavailable: 0
  selector:
    matchLabels:
      app: agent-scaledjobs
```
 The selector label is also included in the ScaledJob
```
..
spec:
  jobTargetRef:
    activeDeadlineSeconds: 1500
    template:
      metadata:
        name: agent-scaledjob
        labels:
          app: agent-scaledjobs
..
```

### Why is this needed?

To avoid disruptions of jobs during node image or Kubernetes upgrades
Repository: flutter
Issue: Flutter conductor must be updated to handle monorepo releases
Labels: P1,team-release
Repository: flutter
Issue: [web] Enable invalid_runtime_check_with_js_interop_types lint in web_ui code.
Labels: engine,c: tech-debt,team-web

Given the amount of bespoke JS-interop code that we have in the Flutter Web engine, I think it'd be nice to enable the `invalid_runtime_check_with_js_interop_types` lint. [Docs](https://dart.dev/tools/linter-rules/invalid_runtime_check_with_js_interop_types).

It got "disabled" (actually, not activated), here:

* https://github.com/flutter/flutter/pull/161560
Repository: pytorch
Issue: [fsdp2] maybe unreliable `set_unshard_in_backward(False)`
Labels: oncall: distributed

Hey Andrew @awgu,

As a big fan of FSDP2, I keep posting improvement 😄

This flag ([`set_unshard_in_backward(False)`](https://github.com/pytorch/pytorch/blob/aa57f0c6637d4377d2d86d377fdf41840498960a/torch/distributed/fsdp/_fully_shard/_fully_shard.py#L408)) is super helpful to skip `unshard()` in backward pass especially for unused backward pass of certain `nn.Module`. 

For valid example -- ZeRO3, these certain parameters are only used in forward, but not used in backward (skipped `unshard()`), so we keep those parameters in sharded state and keep gradient in None during backward pass, which saves allgather and reduce communication while being correct.

But in case of ZeRO2 or ZeRO++ (`reshard_after_forward=False or int`), this `set_unshard_in_backward(False)` results in misleading logic and potential bug.  For example, 
- these certain parameters are only used in forward, but not used in backward
- after forward, these parameters stay in unsharded state (ZeRO2) or [replicate, shard] state (ZeRO++)
- `set_unshard_in_backward(False)` skips `unshard` in pre-backward hook
- so in backward, these parameters stay in ZeRO2 and ZeRO++ state, which is misleading enough (i.e., by semantic, this flag `set_unshard_in_backward(False)` should mean that parameters stays in sharded state but in fact in ZeRO2 and ZeRO++ state)

As a suggestion, we can either ban ZeRO2 and ZeRO++ when using this flag`set_unshard_in_backward(False)` or figure out a more general way to support all ZeRO state.

How do you think 😁?






cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
Repository: terminal
Issue: Ctrl+Break can leave the WSL shell in an unusable state
Labels: Issue-Bug,Area-TerminalConnection,Product-Terminal

### Windows Terminal version

1.22.2702.0

### Windows build number

10.0.19045.5247

### Other Software

VIM 8.2.4919 (inside WSL)

### Steps to reproduce

1. Open the Settings, and set the *Profile termination behavior* to *Close only when process exits successfully*.
2. Start a WSL shell and run `vim`.
3. Enter `:set mouse=a` to enable mouse mode.
4. Press <kbd>Ctrl</kbd>+<kbd>Break</kbd> (possibly <kbd>Ctrl</kbd>+<kbd>ScrLock</kbd> depending on your keyboard).
5. When you see the `press Enter to restart` message, press <kbd>Enter</kbd>.
6. Once the shell restart, try clicking in the window to select some text.


### Expected Behavior

I'd expect mouse selection to work.


### Actual Behavior

When you click in the window, nothing can be selected, but a bunch of "random" characters get entered at the prompt. It seems that <kbd>Ctrl</kbd>+<kbd>Break</kbd> kills the session without giving the app a chance to exit gracefully, and then when we restart the session we don't reset any of the VT state either. As a result we're left with a mouse mode enabled which the shell wasn't expecting.

This mouse mode example was just the easiest to demonstrate, but you can see how it could be even more annoying if the app had enabled something like win32 input mode, or had selected a graphic character set.

Note that for Windows console apps this is less of a problem, because they can trap the break and block it, or at least shut down more gracefully. But I don't think there is anything that Linux apps can do about this, because it's the WSL session itself that is being aborted (at least that's what appears to be happening).
Repository: go
Issue: x/tools/gopls: CodeAction: an error in one CodeAction provider should not block another
Labels: FeatureRequest,gopls,Tools

See [CL 640395](https://go.dev/cl/640395) ([https://go-review.googlesource.com/c/tools/+/640395/comment/2b081fe5_fb1b18c3/](https://go-review.googlesource.com/c/tools/+/640395/comment/2b081fe5_fb1b18c3/)) for context.
Repository: electron
Issue: webContents.startDrag(item) behavior on macOS differs from that on Windows and Linux
Labels: platform/macOS,bug :beetle:,component/drag-and-drop,status/confirmed,has-repro-gist,33-x-y

### Preflight Checklist

- [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.

### Electron Version

33.3.0

### What operating system(s) are you using?

macOS

### Operating System Version

macOS Sequoia 15.2

### What arch are you using?

arm64 (including Apple Silicon)

### Last Known Working Electron version

18

### Expected Behavior

On macOS, webContents.startDrag(item) behaves the same as it does on Windows and Linux.

### Actual Behavior

We are using native drag-and-drop in our project. Our code is the same as described in the documentation: [Native File Drag & Drop](https://www.electronjs.org/docs/latest/tutorial/native-file-drag-drop)

The only difference from the docs is that we have custom logic that should run immediately after the drag ends. Here is a code example:
```
ipcMain.on('ondragstart', (event, filePath) => {
  console.log('drag start')
  event.sender.startDrag({
    file: path.join(__dirname, filePath),
    icon: iconName
  })
  console.log('drag end')

  // custom logic after drag end
  dragEndHandler(filePath)
})
```

On Windows and Linux, `console.log('drag end')` and `dragEndHandler` are not called until the file is dropped. We rely on this behavior because currently, there is no way to listen for the drag-end event when using native drag-and-drop.

Starting from [Electron 18.3.5](https://github.com/electron/electron/releases/tag/v18.3.5), we have observed different behavior on macOS. On macOS, `console.log('drag end')` and `dragEndHandler` are called immediately after `startDrag` and before the file is dropped. This behavior breaks our current logic.

### Testcase Gist URL

_No response_

### Additional Information

For our app, it is critical that `dragEndHandler` is called after the drag ends. The best solution would be to introduce a new drag-end event, similar to the [HTMLElement: dragend event](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dragend_event). However, if implementing this is too complex, it would also be acceptable to fix the differing `startDrag` behavior on macOS.