sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: vscode
Issue: Distribute VS Code ARM64 in the Windows Store
Labels: feature-request,install-update,windows

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: N/A

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.84.2
- OS Version: 23590 Arm64

Steps to Reproduce:

1. Open Store page for Visual Studio code https://apps.microsoft.com/store/detail/XP9KHM4BK9FZ7Q?ocid=pdpshare
2. Attempt to install

Expected:

1. Visual Studio Code installs

Actual:

1. Error dialog indicating that the app is only for x64:
```
---------------------------
Error
---------------------------
This program can only be installed on versions of Windows designed for the following processor architectures:

x64
---------------------------
OK   
---------------------------
```
Repository: flutter
Issue: I wish for a `test: rerun-failed` label
Labels: team-infra,P3,triaged-infra

### Is there an existing issue for this?

- [X] I have searched the [existing infra issues](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Ateam-infra)

### Type of Request

feature request

### Infrastructure Environment

I think Cocoon?

### What is happening?

It's often, especially in `flutter/engine`, that I create draft PRs and try to get configurations that are not easily testable (especially Windows, or certain post-submit builds like clang_tidy) run for me, using it more as a remote build server than true pre-merge testing.

When I do that, it's often that the [vast majority of checks are passing](https://github.com/flutter/engine/pull/48145/checks?check_run_id=18903125289), and I'm interested on iterating on the remaining 1-2:

<img width="792" alt="Screenshot 2023-11-21 at 10 26 08 AM" src="https://github.com/flutter/flutter/assets/168174/ca709202-2ef9-4330-a45f-96ec2e858246">

If I could add a label, say `test: rerun-failed`, I'd love if new commits only triggered re-running previously failed checks. This would not be safe to merge, but would reduce the amount of workers used (i.e. from 29 to ~3 in the above example).

### Steps to reproduce

_No response_

### Expected results

_No response_
Repository: rust
Issue: `-Dwarnings` cannot be overriden by later `-W` options, for both rustc and non-rustc lints
Labels: A-lints,T-compiler,A-docs,C-bug,A-CLI

Consider the following code:

```rust
fn main() {
    assert!(true);
}

fn dead() -> u32 {
    42
}
```

I would expect `cargo rustc -- -Dwarnings -Wdead-code` to merely warn about the dead code (because the `-W` comes after the `-D` and thus should "reset" the dead-code lint's level back to "warn"), but it actually ignores the `-W` option and treats the dead code as an error:

```
   Compiling linting v0.1.0 (/Users/jwodder/work/dev/tmp/linting)
error: function `dead` is never used
 --> src/main.rs:5:4
  |
5 | fn dead() -> u32 {
  |    ^^^^
  |
  = note: `-D dead-code` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(dead_code)]`

error: could not compile `linting` (bin "linting") due to previous error
```

Contrast with `cargo rustc -- -Dunused -Wdead-code`, which does treat the final lint level of dead-code as "warn" rather than "deny":

```
   Compiling linting v0.1.0 (/Users/jwodder/work/dev/tmp/linting)
warning: function `dead` is never used
 --> src/main.rs:5:4
  |
5 | fn dead() -> u32 {
  |    ^^^^
  |
  = note: requested on the command line with `-W dead-code`

warning: `linting` (bin "linting") generated 1 warning
    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
```

`-Dwarnings` even has the same effect on non-rustc warnings, such as from clippy.  For example, running `cargo clippy -- -Dwarnings -W clippy::style` on the code above causes the `assert!(true)` to be treated as an error rather than a warning; contrast with `cargo clippy -- -D clippy::all -W clippy::style`, which first denies everything in the style group (among others) and then sets the style group's lint level back to "warn", with an end result of the `assert!(true)` only producing a warning.

In addition, as far as I understand it, the `[lints]` table added to `Cargo.toml` in Rust 1.74 is implemented by converting the lint fields to command-line options for rustc, rustdoc, and clippy, and so anyone trying to deny all warn-by-default lints with some exceptions is up a creek.

### Meta

`rustc --version --verbose`:
```
rustc 1.74.0 (79e9716c9 2023-11-13)
binary: rustc
commit-hash: 79e9716c980570bfd1f666e3b16ac583f0168962
commit-date: 2023-11-13
host: x86_64-apple-darwin
release: 1.74.0
LLVM version: 17.0.4
```

`rustc +nightly --version --verbose`:
```
rustc 1.76.0-nightly (3a85a5cfe 2023-11-20)
binary: rustc
commit-hash: 3a85a5cfe7884f94e3cb29a606913d7989ad9b48
commit-date: 2023-11-20
host: x86_64-apple-darwin
release: 1.76.0-nightly
LLVM version: 17.0.5
```
Repository: flutter
Issue: [Impeller] Pipeline depth/stencil attachment descriptors must contain the pixel format.
Labels: P2,e: impeller,team-engine,triaged-engine

The pipeline needs to know the pixel formats of the depth and stencil attachments when it is setup. So we put setters for these formats on `impeller::PipelineDescriptor`. However, there is also a separate `impeller::DepthAttachmentDescriptor` and `impeller::StencilAttachmentDescriptor` which should ideally contain this field. Moreover, this deviate from the convention in `impeller::ColorAttachmentDescriptor` which does contain the pixel format.

This is an API defect in the C++ Impeller API and can be fixed by remove pixel format setters on the pipeline descriptor and moving them to the attachment descriptors (just for depth/stencil, color is already correct).
Repository: transformers
Issue: Allow passing 2D attention mask
Labels: Feature request

### Feature request

Allow passing a 2D attention mask in `model.forward`.

### Motivation

With this feature, it would be much easier to avoid cross-context contamination during pretraining and supervised finetuning when packing the sequences together for more efficient training.

Here is an example usecase discussed in (https://github.com/huggingface/trl/issues/805):

![](https://user-images.githubusercontent.com/26831266/272305004-93c690a8-7e9b-40ad-885f-d530996aa109.png)

### Your contribution

Upon investigation into the source code, I found the current logic of initializing attention masks is mostly a fixed code snippet encoded in each model:

```python
        if getattr(self.config, "_flash_attn_2_enabled", False):
            # 2d mask is passed through the layers
            attention_mask = attention_mask if (attention_mask is not None and 0 in attention_mask) else None
        else:
            # 4d mask is passed through the layers
            attention_mask = _prepare_4d_causal_attention_mask(
                attention_mask, (batch_size, seq_length), inputs_embeds, past_key_values_length
            )
```

To enable this behavior may require hacking into each model. I should be able to handle part of them and submit a draft PR. But before that, I want to know if this feature request is reasonable.
Repository: flutter
Issue: Flutter dashboard not clickable commit hash on dark mode
Labels: team-infra,P2,triaged-infra

### Is there an existing issue for this?

- [X] I have searched the [existing issues](https://github.com/flutter/flutter/issues)
- [X] I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)

### Steps to reproduce

When opening https://flutter-dashboard.appspot.com/#/build on dark mode the commit hash blue link is not clickable, rather the user needs to click the commit message to go to the github commit page

### Expected results

Commit hash clickable

### Actual results

Not Clickable

### Code sample

.


### Screenshots or Video

_No response_

### Logs

.


### Flutter Doctor output

.
Repository: pytorch
Issue: Recompilation triggered at each step of the loop involving array indexing
Labels: triaged,oncall: pt2,module: dynamic shapes

### 🐛 Describe the bug

Running the following in today's nightly (`2.2.0.dev20231121+cu121`) I see recompilation issued at each step of the loop. The shapes are static, is there a way to avoid recompilation? (parent [discussion](https://discuss.pytorch.org/t/compiling-for-loop-makes-it-run-25x-slower-than-uncompiled-version/191488))


```
import torch
torch._logging.set_logs(recompiles=True)

@torch.compile
def accumulate(X0, start, end):
    result = X0[start]
    for i in range(start+1, end):
        result += X0[i]
    return result


X0 = torch.randn(100, 100)

for i in range(10):
    print(i)
    accumulate(X0, i, i+10)
```

[colab](https://colab.research.google.com/drive/11OGjZmy8zeZpT0m0irkVCxzPY0st2dGD#scrollTo=8KmAKFH6Px9Q)



cc @ezyang @msaroufim @wconstab @bdhirsh @anijain2305 @zou3519
Repository: pytorch
Issue: Minifier doesn't work with dynamic shapes
Labels: triaged,oncall: pt2,module: dynamic shapes,module: minifier

### 🐛 Describe the bug

There are a few things going on here:

1. Writing out repros is buggy; we will print s0 but not bind it
2. We rely on make_fx tracing_mode="symbolic" to actually symbolify; we actually want to replicate policy in fidelity and get exactly the same symbols that we had before (and that includes guards that aren't captured at all)
3. The minifier will remove symint inputs, but this can violate the symint must be bound as argument invariant, so you end up with invalid graphs that fail for no good reason

### Versions

main

cc @msaroufim @wconstab @bdhirsh @anijain2305 @zou3519
Repository: pytorch
Issue: Compile pytorch for ppc64 redhat8
Labels: module: build,triaged,module: POWER

### 🐛 Describe the bug

I am making process for compile pytorch in ppc64le.. but magma-cuda mkl an d mkl-include no are in Conda repos.. and same triton

```
Install Dependencies
Common

conda install cmake ninja
# Run this command from the PyTorch directory after cloning the source code using the “Get the PyTorch Source“ section below
pip install -r requirements.txt
On Linux

conda install mkl mkl-include
# CUDA only: Add LAPACK support for the GPU if needed
conda install -c pytorch magma-cuda110  # or the magma-cuda* that matches your CUDA version from https://anaconda.org/pytorch/repo

# (optional) If using torch.compile with inductor/triton, install the matching version of triton
# Run from the pytorch directory after cloning
make triton
On MacOS

# Add this package on intel x86 processor machines only
conda install mkl mkl-include
# Add these packages if torch.distributed is needed
conda install pkg-config libuv
On Windows

conda install mkl mkl-include
# Add these packages if torch.distributed is needed.
# Distributed package support on Windows is a prototype feature and is subject to changes.
conda install -c conda-forge libuv=1.39
Get the PyTorch Source
git clone --recursive https://github.com/pytorch/pytorch
cd pytorch
# if you are updating an existing checkout
git submodule sync
git submodule update --init --recursive
Install PyTorch
On Linux

If you would like to compile PyTorch with [new C++ ABI](https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html) enabled, then first run this command:

export _GLIBCXX_USE_CXX11_ABI=1
If you're compiling for AMD ROCm then first run this command:

# Only run this if you're compiling for ROCm
python tools/amd_build/build_amd.py
Install PyTorch

export CMAKE_PREFIX_PATH=${CONDA_PREFIX:-"$(dirname $(which conda))/../"}
python setup.py develop

```
### Versions

v2.1.0 pytorch

cc @malfet @seemethere
Repository: godot
Issue: Low Processor Mode causes flicker in Android using Compatibility renderer
Labels: bug,platform:android,topic:rendering,needs testing

### Godot version

4.1.3.stable, 4.2.rc1

### System information

Android 9.0 - 4.1.3 stable/4.2rc1 - Sony Xperia XZ Premium - Snapdragon 835 - Adreno 540

### Issue description

In godot 4.1.3 and 4.2.rc1 on Android, using compatibility renderer and low processor mode activated the screen randomly flickers when there's a change on screen, this doesn't happen if using the mobile renderer or if using godot3.5.3.




https://github.com/godotengine/godot/assets/773845/82145c5d-85be-4055-9766-bd13973bdd5c



### Steps to reproduce

Use low processor mode with compatibility renderer in Android.
In the minimal reproduction code you can spawn sprites by touching the screen, you can cleanup the screen by pressing the button, randomly some sprites flicker when you are spawning them.

### Minimal reproduction project

[flickertest.zip](https://github.com/godotengine/godot/files/13430536/flickertest.zip)
Repository: material-ui
Issue: [code-infra] Configure Tailwind CSS for Argos CI
Labels: bug 🐛,test,scope: code-infra

### Steps to reproduce 🕹

Link to live example:

Steps:

1. Open https://app.argos-ci.com/mui/material-ui/builds/21080/65573032


### Current behavior 😯

<img src="https://github.com/mui/material-ui/assets/3165635/5fdc13e7-11da-4e2e-a16b-ea9ae4dbaff5" width="570" />


### Expected behavior 🤔

<img src="https://github.com/mui/material-ui/assets/3165635/41694cc5-5954-41e8-bc08-2db492dd1c2e" width="244" />

https://mui.com/base-ui/react-button/#custom-structure

### Context 🔦

_No response_

### Your environment 🌎

<details>
  <summary><code>npx @mui/envinfo</code></summary>

```
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
```
</details>
Repository: angular
Issue: Reconsider usefulness of flatModuleOutFile
Labels: area: packaging

### Which @angular/* package(s) are relevant/related to the feature request?

compiler-cli

### Description

The APF currently prescribes using the `flatModuleOutFile` to "generate a flattened ES Module index file". That file is just a re-export (cf code below) and it causes problems for projects trying to use `Node16` as module/moduleResolution option in order to get typescript to understand package exports (#46181).

https://github.com/angular/angular/blob/c62b2dae8c4653996969df992e8f88887e7c83c4/packages/compiler-cli/src/ngtsc/entry_point/src/generator.ts#L30-L35

The only benefit that I could find to adding `flatModuleOutFile` is that it triggers the compiler-cli package to check whether everything that is exposed from the package is exported from the package.

I want to streamline angular library compilation. We've got a proprietary library builder at work, and packages with multiple entry points currently require pretty annoying boilerplate and building is a slow process because every entry point is in its own source folder with its own `(ng-)package.json` file being built by its own typescript program.
Using `exports` this could be simplified quite a bit. Here's an example of where I'd like to end up:

```json
{
  "name": "some-package",
  "exports": {
    ".": "./src/index.ts",
    "./sub": "./src/sub.ts"
  }
}
```

-> Compiler detects entry points automatically based on the exports, builds the entire package in a single typecript run, generates the FESM files and voilà, done.

I've created a proof-of-concept compiler implementation and plugged it into [a small project](https://github.com/bgotink/ng-lazy) I was working on, in case you're interested. Building this compiler required removing the `flatModuleOutFile` from the typescript config in order to allow multiple rootNames in the project.

### Proposed solution

Support the "is everything that's exposed also exported?" check if there are multiple rootNames in the typescript project.
Remove the "use flatModuleOutFile" prescription in the APF document.

### Alternatives considered

- Keep the situation as is
- We could stop using multiple entry points.
  We're actually moving in the opposite direction. We have over 100 packages in our biggest library and we want to scale this down. Entry points are the smallest unit the application javascript can be split at, so we are looking at merging smaller packages into bigger packages with multiple entry points.
Repository: vscode
Issue: Explore using code mapping for pasted code
Labels: feature-request,api,languages-basic

I wonder if we could also use the new `mappedEditsProvider` proposed api when the user pastes code into a file. This would give code mappers a use case beyond copilot and may save users time cleaning up pasted code
Repository: go
Issue: net/http: unexplained timeout on `wasip1/wasm`
Labels: NeedsInvestigation,arch-wasm

```
#!watchflakes
default <- goarch == "wasm" && pkg == "net/http" && log ~ `panic: test timed out`
```

Issue created automatically to collect these failures.

Example ([log](https://build.golang.org/log/c8fc86fc4fd4a47a9f825128843b56e2e61db057)):

    panic: test timed out after 3m0s
    running tests:
    	TestClientRedirectNoLocation (2m49s)
    	TestClientRedirectNoLocation/h1 (2m20s)
    	TestClientRedirectNoLocation/h2 (2m20s)
    	TestConnContextNotModifyingAllContexts (2m48s)
    	TestContentEncodingNoSniffing (2m48s)
    	TestContentTypeWithVariousSources (2m48s)
    	TestDisableContentLength (2m48s)
    	TestDisableKeepAliveUpgrade (2m48s)
    ...
    net/http_test.run[...].func1()
    	/workdir/go/src/net/http/clientserver_test.go:85 +0xa fp=0x21ddf60 sp=0x21ddf10 pc=0x3407000a
    testing.tRunner(0x22e7380, 0x1ad8900)
    	/workdir/go/src/testing/testing.go:1682 +0xd fp=0x21ddfc8 sp=0x21ddf60 pc=0x1add000d
    testing.(*T).Run.gowrap1()
    	/workdir/go/src/testing/testing.go:1735 +0x2 fp=0x21ddfe0 sp=0x21ddfc8 pc=0x1ae30002
    runtime.goexit({})
    	/workdir/go/src/runtime/asm_wasm.s:434 +0x1 fp=0x21ddfe8 sp=0x21ddfe0 pc=0x151b0001
    created by testing.(*T).Run in goroutine 1250
    	/workdir/go/src/testing/testing.go:1735 +0x43


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: godot
Issue: Closing bracket of lambda function removed
Labels: bug,topic:gdscript,topic:editor

### Godot version

v4.1.3.stable.official [f06b6836a]

### System information

macOS 14.1 (23B74)

### Issue description

When you have an array.filter and use the lambda function, it removes the closing bracket if you wrap the return criteria in ()
Below how the code should look like
`
var inactiveInstances = mastodonInstance.peers.filter(func(instance):
			print(instance)
			return (instance.isQueried == true && instance.isOnline == false))
` 

Now remove the final bracket
`
var inactiveInstances = mastodonInstance.peers.filter(func(instance):
			print(instance)
			return (instance.isQueried == true && instance.isOnline == false)
`

place the cursor between the "e" and ")" and try to enter ")" to fix it again. You will see that the editor automatically removes the bracket again, producing a parser error because a bracket is still missing.
Place the cursor after "false)" and enter a new ")" and it is accepted.

### Steps to reproduce

see above

### Minimal reproduction project

N/A
Repository: go
Issue: net/http/pprof: timeout in `TestDeltaProfile` with running `mutexHog` goroutine
Labels: NeedsInvestigation,compiler/runtime

```
#!watchflakes
post <- pkg == "net/http/pprof" && log ~ `\s+TestDeltaProfile \(\d+m\d+s\)` && log ~ `goroutine \d+ .*\[running\]:\n(?:\s*.+\n)*created by net/http/pprof\.mutexHog`
```

Issue created automatically to collect these failures.

Example ([log](https://build.golang.org/log/bbee28dd8ac1189f3b2b21b2f064a324637c0499)):

    panic: test timed out after 15m0s
    running tests:
    	TestDeltaProfile (14m56s)
    
    goroutine 422 gp=0xc00009ba00 m=4 mp=0xc000069508 [running]:
    panic({0x13839c0?, 0xc000206060?})
    	C:/workdir/go/src/runtime/panic.go:779 +0x158 fp=0xc0000d5f10 sp=0xc0000d5e60 pc=0x10ca958
    testing.(*M).startAlarm.func1()
    	C:/workdir/go/src/testing/testing.go:2351 +0x374 fp=0xc0000d5fe0 sp=0xc0000d5f10 pc=0x1189494
    runtime.goexit({})
    ...
    net.(*TCPConn).Read(0x0?, {0xc000202041?, 0x0?, 0x0?})
    	<autogenerated>:1 +0x25 fp=0xc0002d7f80 sp=0xc0002d7f50 pc=0x126e6e5
    net/http.(*connReader).backgroundRead(0xc000202030)
    	C:/workdir/go/src/net/http/server.go:681 +0x37 fp=0xc0002d7fc8 sp=0xc0002d7f80 pc=0x132e837
    net/http.(*connReader).startBackgroundRead.gowrap2()
    	C:/workdir/go/src/net/http/server.go:677 +0x25 fp=0xc0002d7fe0 sp=0xc0002d7fc8 pc=0x132e765
    runtime.goexit({})
    	C:/workdir/go/src/runtime/asm_amd64.s:1695 +0x1 fp=0xc0002d7fe8 sp=0xc0002d7fe0 pc=0x10ffae1
    created by net/http.(*connReader).startBackgroundRead in goroutine 98
    	C:/workdir/go/src/net/http/server.go:677 +0xba


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: stable-diffusion-webui
Issue: [Feature Request]: Implement Stable Video Diffusion model (SVD)
Labels: enhancement

### Is there an existing issue for this?

- [X] I have searched the existing issues and checked the recent builds/commits

### What would your feature do?

Stability AI just dropped their new model [Stable Video Diffusion](https://stability.ai/stable-video)
Weights are already available for download.
[Here is the paper ](https://static1.squarespace.com/static/6213c340453c3f502425776e/t/655ce779b9d47d342a93c890/1700587395994/stable_video_diffusion.pdf)

It would be awesome to have it in the most popular SD UI

### Proposed workflow

1. Go to text-2-video tab
2. Enter the prompt
3. Click Generate
4. Enjoy the show


### Additional information

_No response_
Repository: stable-diffusion-webui
Issue: [Feature Request]: Expose the SD commands when running Generate on the webui
Labels: enhancement

### Is there an existing issue for this?

- [X] I have searched the existing issues and checked the recent builds/commits

### What would your feature do ?

Hello!

I would like a feature, perhaps a flag that turns it on/off, that would expose the commands sent to Stable Diffusion on the terminal when clicking Generate.

For example, on the webui, if I enter prompt "sunny beach" with sample steps at 15 using "foo" model and click generate, I would like to be able to see that command that is sent to the core stable diffusion. I don't know how this would look like but for example:

`stablediffusion -txt2img -model "foo" -prompt "sunny beach" -sampling-steps 15`

Why I think this would be useful is that this WebUI is amazingly helpful for trying, testing, prototyping, learning, especially for a new comer like myself. But once I'm happy with a particular workflow or settings, if I want to copy this over to a Google colab to share, or a cloud pod, there is no way that I know of, to run this easily as a python script, as one would run SD traditionally.

Thank you.

### Proposed workflow

1. Run stable-diffusion-webui with a parameter (similar to exposing the API via --api) such as --expose-command
2. Terminal opens up, then says the ui is running on port :7860. 
3. Go to the webui
4. Click generate and go back to terminal
5. The terminal would show the command and parameters sent to SD, such as `stablediffusion -txt2img -model "foo" -prompt "sunny beach" -sampling-steps 15`
6. Alternatively, it could be shown as JSON, so that if I use the API, I can use the same JSON.


### Additional information

_No response_