sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: yt-dlp
Issue: Get session cookies when using --cookies-from-browser
Labels: bug,core:cookies

### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

- [X] I understand that I will be **blocked** if I remove or skip any mandatory\* field

### Checklist

- [X] I'm reporting a bug unrelated to a specific site
- [X] I've verified that I'm running yt-dlp version **2022.11.11** ([update instructions](https://github.com/yt-dlp/yt-dlp#update)) or later (specify commit)
- [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
- [X] I've checked that all URLs and arguments with special characters are [properly quoted or escaped](https://github.com/yt-dlp/yt-dlp/wiki/FAQ#video-url-contains-an-ampersand--and-im-getting-some-strange-output-1-2839-or-v-is-not-recognized-as-an-internal-or-external-command)
- [X] I've searched the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)

### Provide a description that is worded well enough to be understood

While investigating #4514 I found a different behavior between `--cookies cookies.txt` and `--cookies-from-browser chrome`.
The first option injected all cookies into the request, while the latter one was missing the session cookies.

Session cookies have `expires=None` and `discard=True`. Taking a look into the codebase I see that session cookies imported from Chrome have `expires=0` and `discard=False`.

https://github.com/yt-dlp/yt-dlp/blob/d7b460d0e5fc710950582baed2e3fc616ed98a80/yt_dlp/cookies.py#L335-L339

Is this intended or possibly a bug?

### Provide verbose output that clearly demonstrates the problem

- [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below

### Complete Verbose Output

```shell
NA
```
Repository: godot
Issue: MSAA causes Lights to create a pixelated rim around Objects
Labels: discussion,topic:rendering,needs testing,topic:3d

### Godot version

4.0 Beta 4

### System information

Windows 11, Vulkan, GTX 1050 Ti 516.94

### Issue description

For some reason MSAA starts creating pixelated, out of place lighting on edges of objects, that shouldn't be lit

MSAA 8x
![msaa8x](https://user-images.githubusercontent.com/50302479/201702237-eef706ec-bea1-4687-b5b3-d6e5748f7b62.png)


MSAA Off
![msaaoff](https://user-images.githubusercontent.com/50302479/201702259-9e32d9cf-d8fd-44da-8540-d11b1d1dbc06.png)


### Steps to reproduce

Open MRP, toggle MSAA on and off. Objects with higher Aliasing tend to have more issues.

### Minimal reproduction project

[MSAA.zip](https://github.com/godotengine/godot/files/10003631/MSAA.zip)
Repository: pytorch
Issue: Incorrect version in the instructions on official website
Labels: module: docs,triaged

### 🐛 Describe the bug

![image](https://user-images.githubusercontent.com/30036289/201680260-31e7ee10-38d6-4f0f-a485-38f1c77fcead.png)

here https://pytorch.org/get-started/previous-versions/ in version 9.1 installation listed torchaudio of incomparable version

### Versions

9.1

cc @svekars @carljparker
Repository: terminal
Issue: [Voice Access][Windows PowerShell]: Two numbers as '5' and '6' appear for the PowerShell tab with 'Show numbers' command of Voice Access.
Labels: Issue-Bug,Area-Accessibility,Needs-Tag-Fix,HCL-E+D,A11yWCAG,HCL-WindowsTerminal,A11ySev3

### Windows Terminal version

1.17.3052.0

### Windows build number

Windows 11 Version 22H2 (OS Build 25206.1000)

### Other Software

_No response_

### Steps to reproduce

1. Open Windows Terminal.
2. Open Voice Access by 'Settings > Accessibility > Speech > Turn on Voice Access.
3. Give command as 'Show numbers' by Voice Access on the page.
4. Observe the issue.

**User Experience: -**
Voice Access users will be confused with two numbers that are shown for one interactive control and will be confused which is the correct number to access it.

**Guideline Reference:**
https://liquid.microsoft.com/Web/Object/Read/MS.Accessibility/Requirements/04.03.01

**Attachments:**
[[Windows PowerShell] Two numbers as '5' and '6' appears for the PowerShell tab with 'Show numbers' command of Voice Access..zip](https://github.com/microsoft/terminal/files/10003845/Windows.PowerShell.Two.numbers.as.5.and.6.appears.for.the.PowerShell.tab.with.Show.numbers.command.of.Voice.Access.zip)





### Expected Behavior

Only one number should appear for 'Windows PowerShell' tab control.

Refer this link: [Voice access – Commands List (office.com)](https://sway.office.com/Q5JvoIGBI5glyoKw?ref=Link)

### Actual Behavior

Two numbers as '5' and '6' appear for the PowerShell tab with 'Show numbers' command of Voice Access, which perform the same functionality. 

Simialr is the case for 'Settings > Startup > Launch size > Columns and Rows edit fields'.
Repository: vscode
Issue: VS Code regex referring to capture groups in replacement string does not work properly
Labels: search,editor-find,under-discussion

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.73.1
- OS Version: Windows 10 Pro 

Steps to Reproduce:

1. Add some text to a file, for instance "Hello world!".
2. Open up search & replace (Ctrl + Shift + H) and enable regex matching.
3. Use "(Hello world)" as the search string.
4. Try to replace the text in the file with "Hello world123!" by referring to capture group `$1`.
5. Realize that no backreference syntax seems to work when directly followed by a number (eg `$1123` or `${1}123`). The syntax is instead interpreted literally, resulting in the file containing "$1123!".

Related issue that was automatically closed: https://github.com/microsoft/vscode/issues/102221
Repository: flutter
Issue: TransformationController/InteractiveViewer should store its transformation into PageStorage
Labels: c: new feature,framework,f: material design,c: proposal,team-design,triaged-design

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case

In a program I'm playing around with flutter in, there are lots pan-and-zoom InteractiveViewers in elements that can be collapsed and expanded again later, destroying their state (and transformation) when collapsed, which I wish did not happen.

<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->

## Proposal

The problem described in the Use Case section is in my case easily solved by moving transformation controller to the parent widget and providing it to the child. However, SelectableText.rich and other scrollables can store its scroll offset into PageStorage, if appropriately configured. Thus, it made me wonder whether it would make sense for InteractiveViewer to have this behavior OOTB. Comparable behavior can be achieved using transformation controller and InteractiveViewer today as seen in the following snippet:
```
          var pageStorage = PageStorage.of(context);
          var transformationController = TransformationController(
              pageStorage.readState(context) as Matrix4?);
          return InteractiveViewer(
            transformationController: transformationController,
            onInteractionEnd: (details) {
              pageStorage.writeState(context, transformationController.value);
            },
            child: ...
          );
```
though this is less than ideal, as it saves the transformation once user stops, and there's still some influence from drag for a short while after

<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching something showing what you are imagining:
      * images
      * videos
      * code samples

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->
Repository: flutter
Issue: SelectableText should have a way to programmatically scroll it
Labels: a: text input,c: new feature,framework,f: material design,f: scrolling,c: proposal,P3,team-design,triaged-design

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case

In a program I'm working on, SelectableText is used to show snippets of code with some interactivity: for example clicking on a variable definition highlights all of its occurrences and clicking on the use of a variable should scroll the SelectableText so that the line with definition of that variable is visible.

<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->

## Proposal

In today's Flutter, I found at least two ways to achieve it: place WidgetSpans with GlobalKey-ed children that act as anchors and use Scrollable.ensureVisible, or hack/copy SelectableText to let the user provide a ScrollController, similar to the underlying EditableText widget. The first approach resulted in stray symbols when navigating cursor over text and second I feel is a little too clunky. It would be nice if SelectableText had a standard way to achieve scrolling to a particular line, e.g. user-provided scroll controller was made part of the API.

<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching something showing what you are imagining:
      * images
      * videos
      * code samples

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->
Repository: storybook
Issue: [Bug]: Vite runs `define` replacements in story-source
Labels: bug,addon: storysource,builder-vite

### Describe the bug

Vite is performing [define](https://vitejs.dev/config/shared-options.html#define) replacements on the code in story source, which is a problem for a few reasons:

1) The code that appears there should appear largely as-written by the developer, so environment variables should remain intact (probably?).
2) It replaces with double-quotes, which breaks syntax since the whole source string is inside double quotes.

### To Reproduce

```shell
See https://github.com/storybookjs/storybook/pull/19805#discussion_r1021023879
```


### System

_No response_

### Additional context

I've fixed this in the past with https://github.com/storybookjs/builder-vite/pull/364.  I wonder if this has started to break now with the change to story-source from a webpack loader to an unplugin.
Repository: flutter
Issue: [google_maps_flutter] GoogleMapsFlutter plugin is executing callbacks after the widget is disposed
Labels: p: maps,package,team-ecosystem,P2,has partial patch,customer: huggsy (g3),triaged-ecosystem

Internal: b/258950950

We're receiving error reports from production that indicate our `GoogleMap` instances are performing callbacks like `onCameraMove` and possibly even `onMapCreated` are being called after the widget has been disposed by the Flutter framework. For most callbacks, the issue is that `GoogleMapController` should disconnect its stream subscriptions in `dispose()`. Right now, the `listen()` calls are all fire-and-forget, which is problematic. The `onMapCreated` issue can be resolved by adding the line

```dart
if (!mounted) return;
```

to the implementation of `onPlatformViewCreated()` inside of `GoogleMap`.

Another problem is that the lifetime of the `GoogleMapController` is unclear. We retain the instance in a State object that builds the `GoogleMap` widget, but I don't think that guarantees that the state object will only ever encounter a single controller. It would theoretically be possible for the `GoogleMap` widget's state to be recreated without recreating our containing state. In this case, the old controller is leaked and invalid between the old widget being disposed and the new widget's `onMapCreated` callback. Any calls to the controller in this window with throw an exception, and there's no easy way to check for that. A simple fix would be to expose either an `isDisposed()` method on `GoogleMapController`, or a listenable API on either the controller or the `GoogleMap` widget to receive a callback when it gets disposed, so we can null out the reference.

Internal bug b/254913189
Repository: kubernetes
Issue: `wait.PollImmediate` timeout not respected when `ConditionFunc` takes a long time to execute
Labels: kind/bug,sig/api-machinery,triage/accepted

### What happened?

https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait#PollImmediate method has a timeout parameter, and is documented as:

> PollImmediate tries a condition func until it returns true, an error, or the timeout is reached. 

Under certain (realistic, non-artificial) conditions, the timeout is not respected and the method continues polling even after the timeout, only terminating much later. This happens when the `ConditionFunc` callback duration is close-ish to the timeout. We saw this happening when `ConditionFunc` contained network calls that were hitting multi-second timeouts:

```
$ cat poll-timeout.go
...
        wait.PollImmediate(3*time.Second, 4*time.Second, func() (bool, error) {
                fmt.Printf("Iteration at %fs\n", time.Since(start).Seconds())
                time.Sleep(5 * time.Second)
                return false, nil
        })
        fmt.Printf("Finished at: %f\n", time.Since(start).Seconds())
...
}

$ go run poll-timeout.go 
Iteration at 0.000000s
Iteration at 8.005522s << expected PollImmediate to terminate here
Iteration at 13.008506s
Finished at: 18.012517
```

### What did you expect to happen?

I expected `PollIteration` to terminate after `ConditionFunc` terminated for the first time after the timeout

### How can we reproduce it (as minimally and precisely as possible)?

```console
$ cd $(mktemp -d)
$ go mod init test
go: creating new go.mod: module test
$ cat << EOF > poll-timeout.go
package main

import (
        "fmt"
        "time"
        "k8s.io/apimachinery/pkg/util/wait"
)

func main() {
        start := time.Now()
        wait.PollImmediate(3*time.Second, 4*time.Second, func() (bool, error) {
                fmt.Printf("Iteration at %fs\n", time.Since(start).Seconds())
                time.Sleep(5 * time.Second)
                return false, nil
        })
        fmt.Printf("Finished at: %f\n", time.Since(start).Seconds())
}
EOF
$ go get k8s.io/apimachinery/pkg/util/wait
go: downloading k8s.io/apimachinery v0.25.4
...
$ go run poll-timeout.go 
Iteration at 0.000000s
Iteration at 8.005522s
Iteration at 13.008506s
Finished at: 18.012517
```

### Anything else we need to know?

_No response_

### Kubernetes version

k8s.io/apimachinery v0.25.4

### Cloud provider

N/A

### OS version

_No response_

### Install tools

_No response_

### Container runtime (CRI) and version (if applicable)

_No response_

### Related plugins (CNI, CSI, ...) and versions (if applicable)

_No response_
Repository: flutter
Issue: `flutter test integration_test` doesn't allow for specyfing a custom driver script
Labels: tool,framework,d: api docs,c: proposal,f: integration_test,P3,team-framework,triaged-framework

## Steps to Reproduce

I'm doing some not-so-usual things in my `test_driver/integration_test.dart` driver script (mainly, I'm registering a VM service extension). I run my tests with `flutter drive --driver test_driver/integration_test.dart --target <target test file>`, but because the recommended way to run integration tests for some time now has been `flutter test integration_test`, I'd like to use it instead. 

[The design doc](http://flutter.dev/go/tool-integration-test-support) for issue #66264 says:

> **Host-side Boilerplate**
This tool will make it no longer necessary for users to copy paste the placeholder driver file into the test_driver/ directory. For advanced use cases such as [handling screenshots](https://github.com/flutter/plugins/pull/2986#issuecomment-689189223), the --driver option will be supported so users can provide a custom driver script.

Unfortunately, the `--driver` options _is not_ available in the `flutter test` command, which makes it impossible to use a custom driver scripts while using `flutter test integration_test`.

Also, the [README of the integration_test](https://github.com/flutter/flutter/tree/master/packages/integration_test) package seems to be outdated, because it doesn't mention `flutter test integration_test` at all.

**Expected results:**

I need to be able to specify a custom driver script while running my app's integration tests with `flutter test integration_test`.
Repository: go
Issue: net/url: `unescape()` logic doesn't copy invalid bytes following % as expected by most recent spec
Labels: NeedsInvestigation

(This is a reopened version of https://github.com/golang/go/issues/11249 because the whatwg spec has changed.)

### What version of Go are you using (`go version`)?

Go 1.19

### Does this issue reproduce with the latest release?

Yes. 

### What operating system and processor architecture are you using (`go env`)?

All.

### What did you do?

Tried to parse a URL with an "invalid" percent escape.  (In this case, `%u0041`).

```
	u, err := url.ParseRequestURI("http://localhost/%u0041")
```

Playground link: https://go.dev/play/p/SqA0_6oLuo3

### What did you expect to see?

Printing the URL path as `/%u0041`

### What did you see instead?

That there was an error parsing the URL.

I'm reopening this bug because the current version of the URL spec for "Percent Encoded Bytes" ( https://url.spec.whatwg.org/#percent-encoded-bytes )

> Otherwise, if byte is 0x25 (%) and the next two bytes after byte in input are not in the ranges 0x30 (0) to 0x39 (9), 0x41 (A) to 0x46 (F), and 0x61 (a) to 0x66 (f), all inclusive, append byte to output.

The JavaScript and popular Rust parsers follow this model, which is making interoperability tricky.

JavaScript:

```
> new URL("http://localhost/%u0041").pathname
< '/%u0041'
```

Rust:

```
use url::Url;
use hyper::Uri;

fn main() {
    let uri = "https://localhost/%u0041".parse::<Uri>().unwrap();
    println!("path: {}", uri.path());

    let u = Url::parse("https://localhost/%u0041").unwrap();
    println!("path: {}", u.path());
}
```

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=f1134169d2851ebe07da4a45e03ff68e
Repository: go
Issue: encoding/json: add (*Decoder).SetLimit
Labels: Proposal,Proposal-Accepted

Typically, the advice to avoid reading excessively large values into memory when passing an untrusted io.Reader is to wrap the reader in a io.LimitedReader. For encoding/json.NewDecoder this is not necessarily a reasonable approach, since the Decoder may be intended to read from a long lived stream (i.e. a net.Conn) where the user may not want to limit the total amount of bytes read from the Reader across multiple reads, but does want to limit the number of bytes read during a single call to Decoder.Decode (i.e. reading 100 500 byte messages across the lifetime of the Decoder may be perfectly acceptable, but a single 50,000 byte read is not.)

A solution to this problem would be to add a method to Decoder, which allows limiting the amount read from the Reader into the internal Decoder buffer on each call to Decoder.Decode, returning an error if the number of bytes required to decode the value exceeds the set limit. Something along the lines of:

```
// LimitValueSize limits the number of bytes read from the wrapped io.Reader
// during a single call to dec.Decode. If decoding the value requires reading
// more than limit bytes, dec.Decode will return an error.
func (dec *Decoder) LimitValueSize(limit int)
```

cc @dsnet