sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: godot
Issue: OpenGL: FXAA antialiasing is not reimplemented yet
Labels: topic:rendering,topic:3d

### Godot version

4.0.beta7

### System information

Fedora 36, GL Compatibility, AMD Radeon RX 6900 XT

### Issue description

FXAA is missing in 3D rendering in the OpenGL renderer. In comparison, Godot 3.x's GLES3 renderer supports FXAA.

### Steps to reproduce

- Set Screen Space AA to FXAA in the advanced project settings.
- Run the project.

### Minimal reproduction project

[demo-fxaa.zip](https://github.com/godotengine/godot/files/10136206/demo-fxaa.zip)
Repository: flutter
Issue: [in_app_purchase] Use StoreKit 2 APIs
Labels: platform-ios,customer: crowd,p: in_app_purchase,package,c: proposal,P3,team-ios,triaged-ios

As you are aware Apple updated StoreKit and released StoreKit 2 last year which includes bunches of new features and some changes especially it uses JWT tokens so there is no need to make another call to Apple to verify receipts. 

I searched issues, PR's about Store Kit 2 but couldn't see anything so I wanted to ask is there are any plans about using StoreKit 2?
Repository: vscode
Issue: Editor find input controls are visually grouped but not programmatically associated / focus order inconsistent
Labels: accessibility,editor-find,under-discussion

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

Controls within the editor find dialog corresponding to the find input are visually grouped but not programmatically associated with one another. The "Match case", "Match word", and "Match regular expression" checkboxes are visually located within the input field. However, within the accessibility tree, they are not grouped, therefore there is no direct association between these controls and the "Find" input.

![Screen Shot 2022-11-29 at 10 35 26 AM](https://user-images.githubusercontent.com/13710580/205163712-d4ce140a-5eb1-45dc-88e5-d0a076972b10.png)

This is additionally complicated when the "Replace" toggle is expanded. When this occurs, the focus order of the controls change, and does not follow the visual structure of the page.

![Screen Shot 2022-12-01 at 2 38 04 PM](https://user-images.githubusercontent.com/13710580/205164668-2bfc8465-2948-4e87-befe-6cac38dd2eb9.png)

WCAG 2.1 1.3.1 Level A specifies that visual relationships perceivable by one set of users is preserved for all users. This can be achieved by [grouping related form controls](https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html). 

WCAG 2.4.3 specifies that focus order should allow a user to navigate through the content in a sequential and consistent order that reflects the logical relationships present on the page. When the "Replace" toggle is expanded, the focus order of the elements change so that the find input controls now occur after the replace input field, and the "Preserve Case" control follows this, with no indication that "Preserve Case" is a new control which relates to replace.

My recommendation is that find and replace toggles are programmatically grouped with their associated fields, and that focus order respects the visual grouping of these controls.

Persistent visual labels provided by FR #167870 can be used to label the groups.
Repository: terminal
Issue: Make sure that pty window ownership changes when root process exits
Labels: Product-Conpty,Area-Server,Issue-Bug

There's a TODO yet to be done: make sure that ownership changes when the root process exits. Terminal doesn't care about that right now, but other ConPTY clients don't have the same requirements as Terminal.

_Originally posted by @DHowett in https://github.com/microsoft/terminal/issues/14196#issuecomment-1276671408_
Repository: vscode
Issue: Allow extensions to change { ... } completion to { ... };
Labels: feature-request,editor-autoclosing

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
For C-like languages:

So the suggestion is to auto place semicolon after class, struct, enum and union definition. Since we have already autocompletion for the brackets, when struct A {| completes to struct A{ | } why not to put a semicolon after brackets to complete class, struct etc. definition like struct A{ | };. It really bugs me to put semicolon every time at the end of definition.

To Reproduce

Type struct A {|
Auto complete will do its job: struct A{ | }
Observe error squiggles - missing semicolon after struct definition!
Put semicolon by hand
Expected behavior
Autocomplete with semicolon at the end of class, struct, enum and union definition.

Now as I know there is no way for C/C++ extension to modify this. Extension needs to run its lexer to check if the tokens before the { belong to the start of a struct/class/etc. definition to determine if the "completion" for { should be } or };.

Visual Studio implements this scenario correctly.
Repository: rust
Issue: Vec::reserve(n) followed by n calls to push should only check capacity once
Labels: I-slow,A-codegen,T-compiler

<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->

I tried this code in compiler explorer (https://rust.godbolt.org/z/W35vT4osM):

```rust
pub fn push1(v: &mut Vec<u32>, x: u32) {
    v.reserve(1);
    v.push(x);
}

pub fn push2(v: &mut Vec<u32>, x: u32) {
    v.reserve(2);
    v.push(x);
    v.push(x);
}
```

I expected the generated assembly to only check the capacity once, and reallocate if needed, and then write the value. Instead, for each `push` there is another check of remaining capacity and potential call to `reserve_for_push`.

Adding explicit `assume` calls leads to much shorter code with only a single call to `do_reserve_and_handle`.

```rust
pub fn push2_assume(v: &mut Vec<u32>, x: u32) {
    v.reserve(2);

    unsafe {
        core::intrinsics::assume(v.len() < v.capacity());
    }
    v.push(x);

    unsafe {
        core::intrinsics::assume(v.len() < v.capacity());
    }
    v.push(x);
}
```

This seems similar to #82801 but that issue seems specific to the initial vector capacity and code for that case looks ok now.

### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->

`rustc --version --verbose`:
```
rustc 1.67.0-nightly (e0098a5cc 2022-11-29)
binary: rustc
commit-hash: e0098a5cc3a87d857e597af824d0ce1ed1ad85e0
commit-date: 2022-11-29
host: x86_64-unknown-linux-gnu
release: 1.67.0-nightly
LLVM version: 15.0.4
Compiler returned: 0
```
Repository: PowerToys
Issue: MouseXY Needed
Labels: Needs-Triage

### Description of the new feature / enhancement

It shows the position of the mouse on the screen

### Scenario when this would be used?

When I am writing program, I sometimes need it.

### Supporting information

_No response_
Repository: rust
Issue: Encountered a Stack Overflow Crash on stable compiled rust
Labels: A-diagnostics,T-compiler,C-bug

<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->

I tried this code:

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=3bc6e2fae27c0a45ec2fa59a087a291b

I expected to see this happen:
Print out a vector of dynamic trait objects

Instead, this happened:
a Stack Overflow error on the compiled output

### Meta
On the Rust Playground, using Debug, Stable on the 2nd of December 2022.

<!--
Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your
environment. E.g. `RUST_BACKTRACE=1 cargo build`.
-->
<details><summary>Backtrace</summary>
<p>

```
There isn't one here

thread 'main' has overflowed its stack
fatal runtime error: stack overflow
timeout: the monitored command dumped core
/playground/tools/entrypoint.sh: line 11:     7 Aborted                 timeout --signal=KILL ${timeout} "$@"

This is the error produced by the playground
```

</p>
</details>
Repository: go
Issue: cmd/go: 'build output "...." already exists and is not an object file' error after interrupted compilation
Labels: NeedsInvestigation,GoCommand


### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.19.3 linux/amd64
</pre>

### Does this issue reproduce with the latest release?
Unknown.

### What did you do?

Rough steps:

0) Interrupt a build with ^C
1) Make some changes that cause our build system to attempt to rebuild the binary (like `git rebase`)
2) Run the build

### What did you expect to see?
No error.

### What did you see instead?

```
go build go.fuchsia.dev/fuchsia/tools/fidl/fidlmerge: build output "../../../../fidlmerge" already exists and is not an object file
```

Upon inspection, the file starts with 4KB of `0x00`s, which definitely isn't an object file.  But the block of the file at 0x1000 _does_ match the contents of the file that's written by the compiler if I delete the "bad" file and re-run the build.
Repository: storybook
Issue: [Bug]: Can't render a vue component as child of IconItem
Labels: bug,needs triage

### Describe the bug

I'm using Vue 3 with webpack. And i think the doc about IconGallery don't really work for Vue

https://storybook.js.org/docs/vue/writing-docs/doc-block-icongallery


That's my code inside my **.mdx file** :

```
import { Meta, Title, IconGallery, IconItem } from '@storybook/addon-docs/';
import MyVueIconComponent from '../Component/MyVueIconComponent.vue';

<Meta title='All Icons' />

<IconGallery>
	<IconItem name='Delete'>
		<MyVueIconComponent name='Delete' />
	</IconItem>
</IconGallery>
```

Inside MyVueIconComponent.vue, there is a simple svg tag.

### To Reproduce

_No response_

### System

_No response_

### Additional context

_No response_
Repository: TypeScript
Issue: Type casting a variable to its own type should preserve literal widening information
Labels: Suggestion,Awaiting More Feedback

# Bug Report

### 🔎 Search Terms

literal widening typeof

### 🕗 Version & Regression Information

- [x] This is the behavior in every version I tried, and I reviewed the FAQ for entries

### ⏯ Playground Link

[Playground link with relevant code](https://www.typescriptlang.org/play?ts=5.0.0-dev.20221201#code/MYewdgzgLgBAZiEMC8MBECQFMCeaDcMMA9MTAO4CWAJlmJWAOYBQANlrDQIwryKGkKNOg0Yw2HGDQBMvTDACGEGFBwAHLCDh8QAsmHABaKrXpNmzbrzQALLK1Yg0JMiADWl6rNS37j54KqGjBYAE6hIKFAA)

### 💻 Code

```ts
const foo = "fooey";  // widening
let id1 = foo; // widening 
let id2 = foo as typeof foo; // non-widening

id1 = "hello" // ok
id2 = "hello" // type error
```

### 🙁 Actual behavior

Assigning to `id2` gives a type error, while assigning the same thing to `id1` does not.

### 🙂 Expected behavior

There should be absolutely no difference between `id1` and `id2`, because `foo as typeof foo` should be an identity cast/no-op.
Repository: terminal
Issue: Corrupted last error after deprecated/unsupported API calls
Labels: Product-Conhost,Help Wanted,Area-Server,Issue-Bug,Priority-3

### Windows Terminal version

_No response_

### Windows build number

10.0.19044.2006

### Other Software

_No response_

### Steps to reproduce

Basically the problem is nicely described in [this SO answer](https://stackoverflow.com/a/61475022).

https://github.com/microsoft/terminal/blob/3c78e01ab5a025290b8953a6dc0f2695c76c223e/src/server/ApiDispatchersInternal.cpp#L22
`ServerDeprecatedApi` uses `E_NOTIMPL` (0x80004001), which on its way to the caller suffers several transformations and becomes 0x00004001, which is not a valid Windows error code.

It is quite unfortunate, given that the whole idea is to make it clear to the caller that the call is deprecated/not implemented.

Perhaps the function could use a different code that won't get fubared beyond recognition?
Given that it is passed to `RtlNtStatusToDosError` on its way, it probably should be `NTSTATUS` in the first place, either just raw `STATUS_NOT_IMPLEMENTED` or packed into HRESULT as `HRESULT_FROM_NT(STATUS_NOT_IMPLEMENTED)`.





### Expected Behavior

After an unsupported call:
- `GetLastError()` should return a sensible value, e.g. `ERROR_INVALID_FUNCTION` or `ERROR_CALL_NOT_IMPLEMENTED`
- (optionally) `RtlGetLastNtStatus()` should return a sensible value, e.g. `STATUS_NOT_IMPLEMENTED`


### Actual Behavior

- `GetLastError()` returns 0x0004001, which is an invalid error code.
- `RtlGetLastNtStatus()` returns 0xC0074001, which is the same invalid win32 error code with `STATUS_SEVERITY_ERROR` and `FACILITY_NTWIN32` bits.
Repository: go
Issue: time: JSON marshaling/unmarshaling does not work reliably for zero Time value
Labels: NeedsInvestigation

<!--
Please answer these questions before submitting your issue. Thanks!
-->

### What version of Go are you using (`go version`)?

<pre>
$ go version go1.18.5 darwin/amd64

</pre>

### Does this issue reproduce with the latest release?

Yes

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/xxx/Library/Caches/go-build"
GOENV="/Users/xxx/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE="git.xxx.cn"
GOMODCACHE="/Users/xxx/Workspace/golib-common/pkg/mod"
GONOPROXY="git.xxx.cn"
GONOSUMDB="git.xxx.cn"
GOOS="darwin"
GOPATH="/Users/xxx/Workspace/golib-common"
GOPRIVATE="git.xxx.cn"
GOPROXY="https://goproxy.cn,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18.5"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/xxx/Workspace/xxx/src/git.xxx.cn/xxx/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/mh/05pw0l8d64s30wl_hl55bbc40000gn/T/go-build4224931359=/tmp/go-build -gno-record-gcc-switches -fno-common"

</pre></details>

### What did you do?

<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on go.dev/play is best.
-->
https://go.dev/play/p/Xsu1BBKI26i

```
package main

import (
	"fmt"
	"time"
)

func main() {

	loc, _ := time.LoadLocation("Asia/Shanghai")
	time.Local = loc
	tlocal := time.Time{}.Local()

        fmt.Println("----- Before MarshalJSON -----")
	fmt.Println(tlocal)
	fmt.Println(tlocal.Zone())
	fmt.Println(tlocal.IsZero())

	mal, _ := tlocal.MarshalJSON()
	recv := time.Time{}
	recv.UnmarshalJSON(mal)

	fmt.Println("----- After UnmarshalJSON -----")
	fmt.Println(recv)
	fmt.Println(recv.Zone())
	fmt.Println(recv.IsZero())
}
```

### What did you expect to see?

----- Before MarshalJSON -----
0001-01-01 08:05:43 +0805 LMT
LMT 29143
true
----- After UnmarshalJSON -----
0001-01-01 08:05:43 +0805 +0805
 29143     // should be 29143
true         //  IsZero() should return true 

### What did you see instead?
----- Before MarshalJSON -----
0001-01-01 08:05:43 +0805 LMT
LMT 29143
true
----- After UnmarshalJSON -----
0001-01-01 08:05:43 +0805 +0805
 29100   // lost 43 seconds
false      // then IsZero() == false
Repository: ant-design
Issue: Descriptions 嵌套 Descriptions 时，内部的 Descriptions 样式异常
Labels: help wanted,Inactive

### Reproduction link

[![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/antd-reproduction-template-forked-57i7nq?file=/index.js)

### Steps to reproduce

无

### What is expected?
<img width="858" alt="image" src="https://user-images.githubusercontent.com/37385554/205220297-d24e46fa-62c9-4df9-a42e-a53efc99d23c.png">



### What is actually happening?
<img width="874" alt="image" src="https://user-images.githubusercontent.com/37385554/205220326-420d953b-7ba0-4c31-acec-87e02207f355.png">


| Environment | Info |
| --- | --- |
| antd | 5.0.3 |
| React | react@18.2.0 |
| System | macOS 13 |
| Browser | chrome 107.0.5304.110 |

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->

相关代码
https://github.com/ant-design/ant-design/blob/0baab01c39d3818f36bd17584893dfd1053738cf/components/descriptions/style/index.tsx#L156-L163
Repository: flutter
Issue: Add ability to provide default values for animation duration and curve
Labels: c: new feature,framework,a: animation,a: quality,c: proposal,P3,team-framework,triaged-framework

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case
Every time we use `AnimatedContainer`, `AnimatedSize`, and other animated widgets, we have to set the duration for each of them (like `duration: Duration(milliseconds: 500), curve: Curves.fastOutSlowIn` (these are my favorites)). I'm too lazy to do that though.
<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->

## Proposal
It'll be good if we can set the default value for animation duration and curve. We can probably add `animationDuration: ` and `animationCurve: ` to `ThemeData`.
<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching something showing what you are imagining:
      * images
      * videos
      * code samples

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->
Repository: java-design-patterns
Issue: Vertical slice architecture
Labels: info: help wanted,epic: pattern,type: feature

**Description:**
The Vertical Slice Architecture (VSA) design pattern focuses on organizing code by features rather than layers, promoting a more modular, maintainable, and scalable architecture. This approach ensures that each vertical slice contains all necessary components, such as data access, business logic, and user interface, which are isolated from other slices.

Main elements of the Vertical Slice Architecture include:
- **Feature-based Structure:** Each feature is a self-contained module with its own domain logic, data access, and user interface.
- **Single Responsibility:** Each slice is responsible for one specific functionality or feature, reducing dependencies between different parts of the application.
- **Encapsulation:** Each slice encapsulates its logic, making the application more modular and easier to test.
- **CQRS (Command Query Responsibility Segregation):** Often used in conjunction with VSA to separate read and write operations, enhancing performance and scalability.

**References:**
- [Jimmy Bogard on Vertical Slice Architecture](https://www.jimmybogard.com/vertical-slice-architecture/)
- [Gary Woodfine on Implementing Vertical Slice Architecture](https://garywoodfine.com/implementing-vertical-slice-architecture/)

**Acceptance Criteria:**
1. Implement a new feature using the Vertical Slice Architecture pattern, ensuring it includes all necessary components (domain logic, data access, user interface) within the slice.
2. Ensure the feature follows the single responsibility principle, isolating its functionality from other parts of the application.
3. Provide documentation and examples within the codebase to illustrate how the Vertical Slice Architecture is implemented and how it benefits the overall project structure.
Repository: TypeScript
Issue: Type detection for dynamic imports with template strings
Labels: Suggestion,In Discussion

# Suggestion

## 🔍 Search Terms

dynamic imports template string typed

## ✅ Viability Checklist

My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).

## ⭐ Suggestion

Dynamic imports using a simple template string could be matched against wildcard module declarations.

## 📃 Motivating Example

I am using the Rollup plugin [dynamic-import-vars](https://www.npmjs.com/package/@rollup/plugin-dynamic-import-vars) to handle import expressions with variable module names, for example to load image files as encoded strings:

```ts
const module = await import(`./images/${name}.png`);
```

There is a wildcard declaration for these files in the project:

```ts
declare module "*.png" {
    const data: string;
    export default data;
}
```

It would be great if the compiler tries to match such wildcard module declarations against template strings, maybe in a strict limited way such as:

- only module declarations with a single leading or trailing asterisk
- only against import expressions with a single template string containing leading/trailing matching characters (or string concatenation with matching string literals at beginning/end)

## 💻 Use Cases

See example above. The workaround in this situation is to explicitly write a type assertion:

```ts
const module = await import(`./images/${name}.png`) as typeof import("*.png");
```
Repository: ant-design
Issue: upload directory 文件夹中文件数量过多，导致页面无响应，目前测试为500张图片
Labels: Inactive

### Reproduction link

[https://4x.ant.design/components/upload-cn/#components-upload-demo-directory](https://4x.ant.design/components/upload-cn/#components-upload-demo-directory)

### Steps to reproduce

1.创建包含500张图片的文件夹
2.点击上传，选择该文件夹
3.页面无响应

### What is expected?

期望能够正常读取本地文件夹中的文件

### What is actually happening?

操作为手动上传，但仍然卡在获取本地文件，页面无响应

| Environment | Info |
| --- | --- |
| antd | 4.22.5 |
| React | 16.14.0 |
| System | mac 11.7 |
| Browser | chrome 107.0.5304.121 |

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->