sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: Tool: Consolidate test-only code into the test/ folder, per-test if able
Labels: tool,P3,c: tech-debt,team-tool,triaged-tool

In https://github.com/flutter/flutter/pull/132346, @reidbaker suggested added a `@visibleForTesting` annotation to [`Artifact`](https://github.com/flutter/flutter/blob/0a10359f6a20a1807d0299080d1960ad2097d370/packages/flutter_tools/lib/src/artifacts.dart#L305-L311):
```dart
factory Artifacts.test({String? localEngine, FileSystem? fileSystem})
```

It wasn't as easy as expected, because it's also used by [`IMobileDevice`](https://github.com/flutter/flutter/blob/0a10359f6a20a1807d0299080d1960ad2097d370/packages/flutter_tools/lib/src/ios/mac.dart#L73-L80):
```dart
factory IMobileDevice.test({ required ProcessManager processManager }) {
  return IMobileDevice(
    artifacts: Artifacts.test(),
    cache: Cache.test(processManager: processManager),
    processManager: processManager,
    logger: BufferLogger.test(),
  );
}
```

After discussing with @christopherfujino on Discord:

> yeah, i don't know the history, but i suspect that's the origin of the [Class].test() factories. For `Artifacts.test()` in particular, it references a private function, so that function will have to be made `@visibleForTesting`.
>
> So, we have a `fakes.dart` file under `test/`, however, a lot of those are hard-coded to specific behavior, or have tons of configuration constructor parameters. Thus, at least for myself, when I need a new test type, I don't default to importing that library and trying to re-use. I'm not sure the right way to organize things so that we have good discoverability of general purpose test constructors.
>
> maybe the answer is to migrate those classes under `fakes.dart` that are pretty specific to a specific set of tests just to the test library that uses it

So, in other words:

- [ ] Migrate classes in `fakes.dart` that are only used by a specific test(s) to those tests
- [ ] Move general testing utilities in `lib/**` to `test/fakes.dart`
- [ ] Consider updating documentation so folks have a chance in finding out how fakes should be setup in the tool

_(I'm happy to contribute here, but it might take some time for this to rise to the top of the stack)_
Repository: pytorch
Issue: Conda configuration shouldn't pollute $PATH variable
Labels: oncall: releng,module: ci,triaged

### Description

In the `install_conda.sh`, the environmental path is exported to include a conda path. This has caused rocMLIR as a dependency (MIOpen, and therefore) to Pytorch to fail the build.

https://github.com/pytorch/pytorch/blob/e1ee10e6f59d43cd7c0fc830954220558beb76f4/.ci/docker/common/install_conda.sh#L40

### Analysis

Our component (rocMLIR) is dependent on `lld`, and we clone a local copy to lld. In the build time, we would build and link with lld shipped in our component. However, under `/opt/conda`, Pytorch also ship with a `lld`. And since Pytorch has added the conda path to the environmental PATH variable, this implicitly impacted all cmake based build as `find_path` make its decisions based on the system environment variable (according to [here](https://cmake.org/cmake/help/latest/command/find_path.html)). This caused the build of every object file in our component to compile with a `-isystem /opt/conda/include`. Eventually it becomes a compilation failure because the conda `lld` is of different version than our locally shipped lld.

There is no good way for us as a dependency to fix this issue as this `/opt/conda` was incorrectly set to PATH and become a global setting.

### Recommended fix

I recommend one of the following ways to address this:
 - Encode the conda path to `CONDA_PREFIX`. This way, the successive build can reference this variable for conda related dependencies, and we also have a way to ignore this path in our build.
 - Use the officially shipped bash script to turn on and off the conda related environment variables. Don't use `activate/deactivate` pair when a certain dependency doesn't require conda dependencies.
    - Before build a component that depend on conda: `bash /opt/conda/bin/activate`
    - After build completes, deactivate the environment: `bash /opt/conda/bin/deactivate`

References:
[1] "CMake in unrelated projects pick up anaconda path" https://github.com/conda/conda/issues/4552
[2] "Cmake ignore anaconda libs" https://www.scivision.dev/cmake-ignore-anaconda-libs/



cc @seemethere @malfet @pytorch/pytorch-dev-infra
Repository: rust
Issue: E0609 is (sometimes?) masked by E0277
Labels: A-diagnostics,T-compiler

### Code

```Rust
trait ExampleMarkerTrait {}

trait ExampleTrait: ExampleMarkerTrait {
    fn blah();
}
// Error: ExampleStruct has impl for ExampleTrait without impl for ExampleMarkerTrait
struct ExampleStruct {
    
}

impl ExampleTrait for ExampleStruct {
    fn blah() {
        println!("blah");
    }
}

struct SecondaryStruct {
    pub field_one: u32
}
impl SecondaryStruct {
    fn this_should_err_too(&mut self, arg: i16) {
        // Error: reference to nonexistent field
        self.field_two = arg;
    }
}
```


### Current output

```Shell
Compiling playground v0.0.1 (/playground)
error[E0277]: the trait bound `ExampleStruct: ExampleMarkerTrait` is not satisfied
  --> src/lib.rs:11:23
   |
11 | impl ExampleTrait for ExampleStruct {
   |                       ^^^^^^^^^^^^^ the trait `ExampleMarkerTrait` is not implemented for `ExampleStruct`
   |
note: required by a bound in `ExampleTrait`
  --> src/lib.rs:3:21
   |
3  | trait ExampleTrait: ExampleMarkerTrait {
   |                     ^^^^^^^^^^^^^^^^^^ required by this bound in `ExampleTrait`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `playground` (lib) due to previous error
```


### Desired output

```Shell
Commenting out ExampleStruct and the example traits produces the output below. E0609 should also be signaled at the same time as E0277.

  Compiling playground v0.0.1 (/playground)
error[E0609]: no field `field_two` on type `&mut SecondaryStruct`
  --> src/lib.rs:23:14
   |
23 |         self.field_two = arg;
   |              ^^^^^^^^^ help: a field with a similar name exists: `field_one`

For more information about this error, try `rustc --explain E0609`.
error: could not compile `playground` (lib) due to previous error
```


### Rationale and extra context

_No response_

### Other cases

```Rust
In the above code, E0609 is missing from stable 1.71.1, beta 1.72.0-beta.8 (2023-08-12 598a0a3cb36343e08bc6), and nightly 1.73.0-nightly (2023-08-14 180dffba142c47240ca0), as tested on the Rust Playground.
```


### Anything else?

_No response_
Repository: next.js
Issue: router.query does not contain path parameters if a middleware is used
Labels: bug,Navigation,Runtime

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
      Platform: linux
      Arch: x64
      Version: #1 SMP Fri Jan 27 02:56:13 UTC 2023
    Binaries:
      Node: 18.17.0
      npm: 9.6.7
      Yarn: N/A
      pnpm: N/A
    Relevant Packages:
      next: 13.4.16
      eslint-config-next: N/A
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.6
    Next.js Config:
      output: N/A
```


### Which area(s) of Next.js are affected? (leave empty if unsure)

Middleware / Edge (API routes, runtime), Routing (next/router, next/navigation, next/link)

### Link to the code that reproduces this issue or a replay of the bug

https://github.com/ferenckv/next-router-bug

### To Reproduce

1. Clone the repo
`git clone https://github.com/ferenckv/next-router-bug`

2. Go to 13.4.16
`cd 13.4.16`

3. Install dependencies
`npm install`

4. Run the app in dev mode
`npm run dev`

5. Go to [http://localhost:3002](http://localhost:3002)

6. Click on `Click Here!!`

7. You should see a text that says `Test: user1`

8. Click on `Action`

9. You should see the url change to `http://localhost:3002/users/user1/test?step=1`

10. Stop the app

11. Run the app in production mode
`npm run start`

12. Repeat steps 5 & 6

13. Instead of `Test: user1` you only see `Test:`

14. Refresh the page

15. Now the text is correct: `Test: user1`

16. Repeat steps 5 & 6

17. Click on `Action`

18. The url changes to `http://localhost:3002/users/[userId]/test?step=1` instead of `http://localhost:3002/users/user1/test?step=1`


### Describe the Bug

Given that these conditions are met:
1. You are using the Page Router
2. You are using a middleware
3. You are rewriting the route

When you do something like this
```
    const router = useRouter();

    router.push({
      pathname: router.pathname,
      query: {
        ...router.query,
        ...newQuery
      },
    });
```

Then `router.query` does not contain the values of the path parameters.

### Expected Behavior

`router.query` must contain the values of the path parameters.

### Which browser are you using? (if relevant)

Chrome 115.0.5790.171

### How are you deploying your application? (if relevant)

_No response_
Repository: flutter
Issue: Ability to pick specific checks to be run against a PR
Labels: c: new feature,team,c: proposal,team-infra,P3,triaged-infra

Add the ability for a developer to select a subset of checks to be run against a PR.
Repository: flutter
Issue: Avoid running all checks when only a small portion of the codebase is impacted
Labels: engine,c: proposal,P2,team-engine,triaged-engine

For example, If I make a change to an Android specific file, I do not need to build for Linux/Windows/MacOS and running those checks is wasteful (and slows down other developers)

ninja's dependency graph could be queried for the set of "impacted" targets and then test targets could be filtered based on that.
Repository: flutter
Issue: I wish for a more aggressive "autosubmit" label
Labels: team-infra,P3,triaged-infra

As written, `autosubmit` is only suitable when the only blocker is the tree is red.

I'd love to be able to use it as a "submit this once I have approval(s) and all checks are green". For example, I might be iterating on a clang tidy issue, or might be waiting for an explicit LGTM - I'd love to not have to manually remember to merge (when the tree is green).
Repository: godot
Issue: VIEWPORT_SIZE uniform does not match the render target size while rendering to ReflectionProbe
Labels: bug,discussion,topic:rendering,topic:3d

### Godot version

3.5.2 Stable, 4.1.1 Stable

### System information

Godot v4.1.1.stable - Ubuntu 20.04.6 LTS (Focal Fossa) - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3050 Laptop GPU () - 12th Gen Intel(R) Core(TM) i7-12700H (14 Threads)

### Issue description

https://github.com/godotengine/godot/blob/3.5/drivers/gles3/rasterizer_scene_gles3.cpp#L4153 sets the VIEWPORT_SIZE uniform to the size of the viewport, but there is no way to get the size of the render target when rendering a ReflectionProbe

### Steps to reproduce

Create a reflection probe, then use the VIEWPORT_SIZE in a shader that relies on the VIEWPORT_SIZE to generate the POINT_SIZE based on the Viewport (render target) resolution. In reflection probe textures the VIEWPORT_SIZE does not match the render target's resolution so the POINT_SIZE is wrong.

See attached minimal reproduction for godot3 and godot4

The minimal reproduction has 3 'Subject' meshinstances with PointMesh meshes and a shader that uses the VIEWPORT_SIZE to calculate the POINT_SIZE so that when the camera moves a way the 'voxel' gets smaller.

4.1.1 Vulkan (Forward+)
![Screenshot from 2023-08-15 16-22-37](https://github.com/godotengine/godot/assets/682658/adb03fd1-91e9-4582-b121-e5252053e9ae)
3.5.2 GLES3
![Screenshot from 2023-08-15 16-23-12](https://github.com/godotengine/godot/assets/682658/8bd94391-ddb0-402d-bb50-1e2f8da0fcbb)


If you look at the reflections in the minimal reproduction the voxels from the reflection probe texture are overlapping and you can't see the middle one because they use the wrong VIEWPORT_SIZE (assuming that it is equivelant to the render target size)

### Minimal reproduction project

[shader-viewport-size-uniform-refprobe.zip](https://github.com/godotengine/godot/files/12353689/shader-viewport-size-uniform-refprobe.zip)
Repository: transformers
Issue: Add FastViT model
Labels: New model

### Model description

FastViT is a hybrid vision transformer that uses structural reparameterization to obtain lower memory access cost and increased capacity, achieving stateof-the-art accuracy-latency trade-off. Highly efficient on multiple compute fabrics: mobile devices and desktop grade GPUs.



### Open source status

- [X] The model implementation is available
- [X] The model weights are available

### Provide useful links for the implementation

Paper: https://arxiv.org/pdf/2303.14189.pdf
Github(code and weights): https://github.com/apple/ml-fastvit
Authors: @anuragranj, @pavank-apple
Repository: rust
Issue: Assigning to variable causes type inference to fail
Labels: A-inference

_Prompted by @SkiFire13's suggestion in https://github.com/google/zerocopy/issues/196#issuecomment-1678578694._

I have the following code (minimized from the code linked above, so names will seem weird out of context; that doesn't have any bearing on the example):

```rust
use core::mem::MaybeUninit;

pub trait Projectable<F> {
    type Inner;
}

impl<T, F> Projectable<F> for MaybeUninit<T> {
    type Inner = T;
}

pub fn project<P, F, InnerToField>(
    _outer: &P,
    _inner_to_field: InnerToField,
)
where
    P: Projectable<F>,
    InnerToField: Fn(*const P::Inner) -> *const F,
{}

macro_rules! project {
    (&$c:ident $($f:tt)*) => {{
        unsafe {
            project(
                $c,
                |inner| ::core::ptr::addr_of!((*inner) $($f)*),
            )
        }
    }};
}

pub fn project_maybe_uninit_tuple(m: &MaybeUninit<(u8, u16)>) {
    project!(&m.1)
}
```

This compiles fine. However, if I move the `|inner| ...` closure to first be assigned to a variable:

```rust
macro_rules! project {
    (&$c:ident $($f:tt)*) => {{
        let inner_to_field = |inner| ::core::ptr::addr_of!((*inner) $($f)*);
        unsafe {
            project(
                $c,
                inner_to_field,
            )
        }
    }};
}
```

...it results in a type inference failure:

```text
error[[E0282]](https://doc.rust-lang.org/stable/error_codes/E0282.html): type annotations needed
  --> src/lib.rs:22:60
   |
22 |         let inner_to_field = |inner| ::core::ptr::addr_of!((*inner) $($f)*);
   |                                                            ^^^^^^^^ cannot infer type
...
34 |     project!(&m.1)
   |     -------------- in this macro invocation
   |
   = note: this error originates in the macro `project` (in Nightly builds, run with -Z macro-backtrace for more info)
```

This is surprising to me, as the type constraints haven't changed at all. I'd assume that, if type inference had enough information to succeed with the first version of the code, it'd have enough information to succeed with the second version of the code.

Reporting this in case it's an inference bug.
Repository: vscode
Issue: keybinding for period displays as less-than in table view
Labels: bug,keybindings-editor

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->

Version: 1.81.1
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:18:39.991Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Linux x64 6.2.0-26-generic
Steps to Reproduce:

1. Open Keyboard Shortcuts
2. Double-click some command to add a new shortcut
3. Press `Ctrl + Shift + .`  (On my keyboard the "greater-than" key is the `>` / `.`  key)
![image](https://github.com/microsoft/vscode/assets/123908/aca3b627-0f51-46e4-a3da-b7165b9596f9)

4. Press Enter to save the new keyboard shortcut
5. Look at the setting in keybindings.json (it appears correct)

        {
                "key": "ctrl+shift+.",
                "command": "chat.action.acceptInput",
                "when": "inChatInput && textInputFocus"
        },

6. Look at the setting in the Keyboard Shortcuts panel (it shows `Ctrl + Shift + <` which is incorrect)
![image](https://github.com/microsoft/vscode/assets/123908/2ea7848f-307c-4948-877f-9c49f7578e59)

In case you missed it, less-than is wrong; it should be greater-than or dot.
Repository: pytorch
Issue: DISABLED test_find_or_create_pg (__main__.TestPgTag)
Labels: oncall: distributed,module: flaky-tests,skipped

Platforms: linux, rocm

This test was disabled because it is failing in CI. See [recent examples](https://hud.pytorch.org/flakytest?name=test_find_or_create_pg&suite=TestPgTag) and the most recent trunk [workflow logs](https://github.com/pytorch/pytorch/runs/15924471388).

Over the past 3 hours, it has been determined flaky in 2 workflow(s) with 2 failures and 2 successes.

**Debugging instructions (after clicking on the recent samples link):**
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:
1. Click on the workflow logs linked above
2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
3. Grep for `test_find_or_create_pg`
4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.


Test file path: `distributed/test_functional_api.py`

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu
Repository: next.js
Issue: Intercepting doesn't refresh correctly when a server mutation is triggered
Labels: bug,Parallel & Intercepting Routes

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 22.5.0: Thu Jun  8 22:22:20 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6000
    Binaries:
      Node: 20.5.0
      npm: 9.8.0
      Yarn: 1.22.18
      pnpm: N/A
    Relevant Packages:
      next: 13.4.16-canary.1
      eslint-config-next: 13.4.16
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.6
    Next.js Config:
      output: N/A
```


### Which area(s) of Next.js are affected? (leave empty if unsure)

App Router

### Link to the code that reproduces this issue or a replay of the bug

https://github.com/votrungquan1999/server-mutation-in-intercepting-modal-error

### To Reproduce

1. create an intercepting modal for a route
2. navigate to that route using `Link` or  `router.push`
3. trigger any server mutation [(docs here)](https://nextjs.org/docs/app/building-your-application/data-fetching/server-actions#server-mutations)

### Describe the Bug

The app crashes after triggering the server mutation

### Expected Behavior

After triggering a server mutation, the client should be refreshed and new data should be loaded

### Which browser are you using? (if relevant)

Chrome 115.0.5790.170 (Official Build) (arm64)

### How are you deploying your application? (if relevant)

Vercel (https://server-mutation-in-intercepting-modal-error-sybd.vercel.app/home)
Repository: terminal
Issue: Background image alignment relative to desktop
Labels: Issue-Feature,Area-TerminalControl,Area-Extensibility,Area-Settings,Product-Terminal

# Description of the new feature/enhancement

A background image alignment mode that's relative to the desktop. As you move the terminal around the image remains aligned with the desktop like wallpaper, eg:

![cap](https://user-images.githubusercontent.com/1146032/37075730-06c978f6-2188-11e8-8320-0e264dfda1a5.gif)
..choose an image that complements the wallpaper for a pleasant effect
![cap2](https://user-images.githubusercontent.com/1146032/37075736-0c491174-2188-11e8-8b96-ba867d645c99.gif)

Ideally we could also configure the background image to follow a convention for when the desktop wallpaper is in slideshow mode. (disclaimer this is a feature in [ConsoleZ](https://github.com/cbucher/console/issues/468))

Similar to issue #6497
Repository: go
Issue: x/pkgsite: examples in external test packages are not runnable
Labels: NeedsInvestigation,pkgsite

<!--
Please answer these questions before submitting your issue. Thanks!

If you would like to have your package removed, please file an issue at https://golang.org/s/pkgsite-package-removal.
-->

### What is the URL of the page with the issue?
https://pkg.go.dev/github.com/urfave/cli/v3@v3.0.0-alpha4#example-Command.Run-NoAction

This reports a bug that renders some testable examples without a `main` block, making them not runnable. It seems to happen anytime the import path ends with a `vN` major version suffix that doesn't match the package name.

See the corresponding testable example code [here](https://github.com/urfave/cli/blob/v3.0.0-alpha4/examples_test.go#L191-L210) and the import that ends in `/v3` [here](https://github.com/urfave/cli/blob/v3.0.0-alpha4/examples_test.go#L10). Using an import alias that matches the package name resolves the issue. For example:
```go
import cli "github.com/urfave/cli/v3"
```

### What is your user agent?
```
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/113.0
```

### Screenshot
<img width="1212" alt="Screenshot 2023-08-05 at 4 37 42 PM" src="https://github.com/golang/go/assets/9760375/94c0c4d4-3bd1-4b31-bba2-2235109284dc">

### What did you do?
Go to https://pkg.go.dev/github.com/urfave/cli/v3@v3.0.0-alpha4#example-Command.Run-NoAction and try to run the "NoAction" example (or any example for the `github.com/urfave/cli/v3` package).
 
### What did you expect to see?
A runnable code example with a `main` block and a "Run" button.

### What did you see instead?
A code example with no `main` block and no "Run" button.
Repository: ant-design
Issue: Gray palette doesn't reflect the documentation
Labels: Inactive,unconfirmed

### Reproduction link

[![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/antd-reproduction-template-forked-j8jqzx?file=/index.js)

### Steps to reproduce

import gray from :
import { gray } from "@ant-design/colors";
Try and use lighter gray colors.

### What is expected?

Gray array should go from #ffffff to #000000

### What is actually happening?

Gray array is ["#a6a6a6", "#999999", "#8c8c8c", "#808080", "#737373", "#666666", "#404040", "#1a1a1a", "#000000", "#000000"]

| Environment | Info |
| --- | --- |
| antd | 5.8.2 |
| React | 18.2 |
| System | macOS 13.4.1 |
| Browser | Safari 16.5.1 |

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->