sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: TypeScript
Issue: Missing excess property error for discriminated union
Labels: Bug

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the *entire* template below.
-->

<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:**  3.9.5

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**

**Code**

```ts
type Params = ({ shouldApplyStyles?: true } | { shouldApplyStyles: false }) &
    (
        | {
              internal: false;
          }
        | {
              internal: true;
              internalProp: string;
          }
    );

declare const fn: (params: Params) => void;

fn({
    internal: false,
    internalProp: 'foo', // ✅ Errors as expected
    shouldApplyStyles: true,
});
fn({
    internal: false,
    internalProp: 'foo', // ✅ Errors as expected
    shouldApplyStyles: false,
});
fn({
    internal: false,
    internalProp: 'foo', // ✅ Errors as expected
    shouldApplyStyles: undefined,
});
fn({
    internal: false,
    internalProp: 'foo', // Expected error but got none ❌
});
```

**Expected behavior:** See code comments

**Actual behavior:** See code comments

**Playground Link:** [Link](https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=31&pc=1#code/C4TwDgpgBACghgJzgWwM5QLxQBQG8qoAWA9gK4A2AJgIJhjkgDKo5EqA-AFxTAKnQBfKAB8o+ImSq16TFm24AzOOVSCAlFABkAKCh6cu-UdG5DR8-oCWAO2AQE15YuWqA3GYtQBH42J+e9GzsHJx4+CHcAiyD7R3IYBGIwblReGwBzSKjvIzV3bUoIAGNyRGgi4mtUqAVrbmwwRBRUbngkNA0MAD4oADdiS0p82rwPGJDyZxUIABox21jlBKTuAHIFYmJVmagAel2oQFByKABRBESEdDh0CAAPSCK7Sg8JCho6BmYQVhaw-jmBHltCNTEZxnEpqo5mCFhNlskoOtNts9gdjmcLlcbvdik8XiQ3tJPnJfkppgCgSD5sEITUXLNqYt4okEUitjt9kdTudiJcoNcoHcHnijK8pB9ZN95FBSNZCgobBBKBT3FSYTTQmSoYy4Sy1ht2ajTjjHkrBTyEFAAEakYBQdLEO3WSrQQAy5NpAe4gA)

**Related Issues:** 
- https://github.com/Microsoft/TypeScript/issues/30631
- https://github.com/microsoft/TypeScript/issues/20863
- https://stackoverflow.com/questions/52677576/typescript-discriminated-union-allows-invalid-state/52678379#52678379

I looked at https://github.com/microsoft/TypeScript/issues/20863 but I don't think this is exactly the same, because in this case we have a tagged aka discriminated union, whereas that issue describes behaviour for unions without tags aka discriminant properties.
Repository: pytorch
Issue: Different max_pool2d cpp signatures due to indices. 
Labels: triaged,better-engineering,module: pooling

We currently have two cpp signatures for `max_pool2d` in cpp:
```
max_pool2d(Tensor self, int[2] kernel_size, int[2] stride=[], int[2] padding=0, int[2] dilation=1, bool ceil_mode=False) -> Tensor

max_pool2d_with_indices(Tensor self, int[2] kernel_size, int[2] stride=[], int[2] padding=0, int[2] dilation=1, bool ceil_mode=False) -> (Tensor, Tensor)
```

And to handle these we have this weird dispatch in our python code to make it compatible with torchscript: https://github.com/pytorch/pytorch/blob/master/torch/nn/functional.py#L578

In cpp land we always call the with_indices version even when we don't return them for max_pool2d (backward uses it).  

I wonder is it a better we just break BC and have one single API looks like 
```
max_pool2d(Tensor self, int[2] kernel_size, int[2] stride=[], int[2] padding=0, int[2] dilation=1, bool ceil_mode=False, bool return_indices=false) -> (Tensor, Tensor)
```
We currently do this trick to a few more ops so it'll be great to have a solution to for this. 

From @dzhulgakov : the proper composibility fix for it is to have "hidden outputs for backward" that don't get exposed in user API but get recorded by autograd::Function

From @ngimel : Hidden outputs for backward already exist at the user level (maxpool, *norm etc don't have user-facing indices/means/ etc). But implementations still produce them, and figuring out how not to do it if not needed is important

From @ailzhang: short term XLA will have to use `XLAPreautograd` key to register both fwd + bwd to avoid materializing indices when it's not needed. We should move back to a normal registration once we have a solution for this.
Repository: kubernetes
Issue: Security contacts for api not specified or out of date
Labels: priority/important-soon,area/security,kind/cleanup,lifecycle/frozen,committee/security-response


The purpose of the `SECURITY_CONTACTS` file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes [Product Security Committe](https://github.com/kubernetes/community/tree/master/committee-product-security) in the event that a security issue related to the repository is discovered or disclosed.  As described in the file, those on the list should agree to our [Embargo Policy](https://git.k8s.io/security/private-distributors-list.md#embargo-policy).

Please update the [`/staging/src/k8s.io/api/SECURITY_CONTACTS`](/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/SECURITY_CONTACTS) file for the api repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user.

The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo.

See https://github.com/kubernetes/security/issues/92 for more information

/area security
/committee product-security
/kind cleanup
/lifecycle frozen
/priority important-soon
Repository: kubernetes
Issue: Security contacts for cri-api not specified or out of date
Labels: priority/important-soon,area/security,kind/cleanup,sig/node,lifecycle/frozen,committee/security-response,needs-triage


The purpose of the `SECURITY_CONTACTS` file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes [Product Security Committe](https://github.com/kubernetes/community/tree/master/committee-product-security) in the event that a security issue related to the repository is discovered or disclosed.  As described in the file, those on the list should agree to our [Embargo Policy](https://git.k8s.io/security/private-distributors-list.md#embargo-policy).

Please update the [`/staging/src/k8s.io/cri-api/SECURITY_CONTACTS`](/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cri-api/SECURITY_CONTACTS) file for the cri-api repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user.

The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo.

See https://github.com/kubernetes/security/issues/92 for more information

/area security
/committee product-security
/kind cleanup
/lifecycle frozen
/priority important-soon
/sig node
Repository: kubernetes
Issue: Security contacts for csi-translation-lib not specified or out of date
Labels: priority/important-soon,area/security,kind/cleanup,lifecycle/frozen,committee/security-response


The purpose of the `SECURITY_CONTACTS` file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes [Product Security Committe](https://github.com/kubernetes/community/tree/master/committee-product-security) in the event that a security issue related to the repository is discovered or disclosed.  As described in the file, those on the list should agree to our [Embargo Policy](https://git.k8s.io/security/private-distributors-list.md#embargo-policy).

Please update the [`/staging/src/k8s.io/csi-translation-lib/SECURITY_CONTACTS`](/kubernetes/kubernetes/blob/master/staging/src/k8s.io/csi-translation-lib/SECURITY_CONTACTS) file for the csi-translation-lib repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user.

The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo.

See https://github.com/kubernetes/security/issues/92 for more information

/area security
/committee product-security
/kind cleanup
/lifecycle frozen
/priority important-soon
Repository: kubernetes
Issue: Security contacts for kube-controller-manager not specified or out of date
Labels: priority/important-soon,area/security,kind/cleanup,lifecycle/frozen,committee/security-response


The purpose of the `SECURITY_CONTACTS` file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes [Product Security Committe](https://github.com/kubernetes/community/tree/master/committee-product-security) in the event that a security issue related to the repository is discovered or disclosed.  As described in the file, those on the list should agree to our [Embargo Policy](https://git.k8s.io/security/private-distributors-list.md#embargo-policy).

Please update the [`/staging/src/k8s.io/kube-controller-manager/SECURITY_CONTACTS`](/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-controller-manager/SECURITY_CONTACTS) file for the kube-controller-manager repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user.

The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo.

See https://github.com/kubernetes/security/issues/92 for more information

/area security
/committee product-security
/kind cleanup
/lifecycle frozen
/priority important-soon
Repository: kubernetes
Issue: Security contacts for kubelet not specified or out of date
Labels: priority/important-soon,area/security,kind/cleanup,lifecycle/frozen,committee/security-response


The purpose of the `SECURITY_CONTACTS` file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes [Product Security Committe](https://github.com/kubernetes/community/tree/master/committee-product-security) in the event that a security issue related to the repository is discovered or disclosed.  As described in the file, those on the list should agree to our [Embargo Policy](https://git.k8s.io/security/private-distributors-list.md#embargo-policy).

Please update the [`/staging/src/k8s.io/kubelet/SECURITY_CONTACTS`](/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubelet/SECURITY_CONTACTS) file for the kubelet repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user.

The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo.

See https://github.com/kubernetes/security/issues/92 for more information

/area security
/committee product-security
/kind cleanup
/lifecycle frozen
/priority important-soon
Repository: kubernetes
Issue: Security contacts for kube-scheduler not specified or out of date
Labels: priority/important-soon,area/security,kind/cleanup,lifecycle/frozen,committee/security-response


The purpose of the `SECURITY_CONTACTS` file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes [Product Security Committe](https://github.com/kubernetes/community/tree/master/committee-product-security) in the event that a security issue related to the repository is discovered or disclosed.  As described in the file, those on the list should agree to our [Embargo Policy](https://git.k8s.io/security/private-distributors-list.md#embargo-policy).

Please update the [`/staging/src/k8s.io/kube-scheduler/SECURITY_CONTACTS`](/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-scheduler/SECURITY_CONTACTS) file for the kube-scheduler repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user.

The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo.

See https://github.com/kubernetes/security/issues/92 for more information

/area security
/committee product-security
/kind cleanup
/lifecycle frozen
/priority important-soon
Repository: kubernetes
Issue: Security contacts for legacy-cloud-providers not specified or out of date
Labels: priority/important-soon,area/security,kind/cleanup,area/cloudprovider,lifecycle/frozen,sig/cloud-provider,committee/security-response


The purpose of the `SECURITY_CONTACTS` file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes [Product Security Committe](https://github.com/kubernetes/community/tree/master/committee-product-security) in the event that a security issue related to the repository is discovered or disclosed.  As described in the file, those on the list should agree to our [Embargo Policy](https://git.k8s.io/security/private-distributors-list.md#embargo-policy).

Please update the [`/staging/src/k8s.io/legacy-cloud-providers/SECURITY_CONTACTS`](/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/SECURITY_CONTACTS) file for the legacy-cloud-providers repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user.

The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo.

See https://github.com/kubernetes/security/issues/92 for more information

/area cloudprovider
/area security
/committee product-security
/kind cleanup
/lifecycle frozen
/priority important-soon
/sig cloud-provider
Repository: kubernetes
Issue: Security contacts for metrics not specified or out of date
Labels: priority/important-soon,area/security,kind/cleanup,sig/instrumentation,lifecycle/frozen,committee/security-response


The purpose of the `SECURITY_CONTACTS` file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes [Product Security Committe](https://github.com/kubernetes/community/tree/master/committee-product-security) in the event that a security issue related to the repository is discovered or disclosed.  As described in the file, those on the list should agree to our [Embargo Policy](https://git.k8s.io/security/private-distributors-list.md#embargo-policy).

Please update the [`/staging/src/k8s.io/metrics/SECURITY_CONTACTS`](/kubernetes/kubernetes/blob/master/staging/src/k8s.io/metrics/SECURITY_CONTACTS) file for the metrics repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user.

The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo.

See https://github.com/kubernetes/security/issues/92 for more information

/area security
/committee product-security
/kind cleanup
/lifecycle frozen
/priority important-soon
/sig instrumentation
Repository: flutter
Issue: Consider using `late` for lazy initialized singletons in the engine
Labels: team,engine,a: null-safety,P2,team-engine,triaged-engine

The first pass of NNBD conversion does not include converting lazy initialized variables into `late final` ones. However, some of these (those that do not require null check prior to initialization) can be converted to `late final`. Let's revisit the code and convert these instances where possible.
Repository: pytorch
Issue: Port old registration API to new one
Labels: triaged,better-engineering

There aren't many places left where we use the old registration API. The following commits should touch most of those:

- https://github.com/pytorch/pytorch/pull/39823/commits/66cfbfce33c2f57d30fa6510ab9014c197ee134a
- https://github.com/pytorch/pytorch/pull/39823/commits/750f46fdd56575eada5e4a28970b5da204b308c7
- https://github.com/pytorch/pytorch/pull/39823/commits/57a0c6609b0212f91c4ea367c92eafa98ccb47db

We should port those to the new registration API.

Note that we should not forget to add `TORCH_FN` to them after porting because `TORCH_FN` will allow the kernels to get inlined into the wrappers.
Repository: godot
Issue: Changing scenes on an exported android game glitches
Labels: bug,platform:android,topic:core,topic:porting

<!-- Please search existing issues for potential duplicates before filing yours:	
https://github.com/godotengine/godot/issues?q=is%3Aissue	
-->

**Godot version:**
Godot 3.2


**OS/device including version:**
<Any android phone (GLES2) -->


**Issue description:**
I am trying to change some scenes by using the simple get_tree().change_scene(path)
 and it worked on my first scenes until now. I made a scene with my 4 chapters and a back button. Whenever I try to go on a chapter button (which is a TouchScreenButton btw) it glitches by going back and fourth the scenes. It is strange that it doesn't happen on other scenes that use the same code but happens on this new one.


**Steps to reproduce:**
 use 
get_tree().change_scene(another scene) on gles2 android project
and then try exporting it. I said that I happened to some of my scenes so it might not happen to you.


**Minimal reproduction project:**

couldn't make it less than 10mb

https://drive.google.com/file/d/1mKX8A-E4swGkVy4TQZYAJyirvydjz3ed/view

export it to android
and try pressing the earth
it works on desktop so you have to export it
Repository: godot
Issue: Saving resources is finnicky
Labels: enhancement,topic:editor

I'm coming from a couple hours long session of editting resources and having lost my work because the tres files didn't save.

I have quite a few scriptable objects / resources, with an exported property.
the property being an Array of Resources, (These objects link between each other) 

Anyway the crux of the matter is that I was dragging and dropping resources into the "value rectangles" (idk what they're called). but didn't hit save, as I thought the resources were saved automatically since the changes were outputted in the output console. but unfortunately I was wrong.

When I closed out of Godot I was prompted to save changes to my scene, but I didn't change my scene so I thought I'd discard some irrelevant changes, which turned out to be my big mistake.

I realised my mistake and I was sad, because it was a long grind.

but re-editting the resources' properties I see that I resource being editted is not clearly displayed.
E.g. when a scene is editted, an asterix appears next to the scene name, but when a resource is editted, an asterix doesn't appear next to the resource name, it instead appears next to the scene name. Which is odd because the resources and scenes are unrelated / independent of one another.

and when I hit ctrl+s in the scene edittor I get an alert saying that I've saved x number of editted resources. That happens even when I press the save button under the resource editor.

It all seems a bit finicky to me.
I'd like that if I close out of godot that I'm alerted that I have unsaved resources.
and that unsaved resources be represented with an asterix next to the resource name in the resource editor.

**Operating system**
linux mint 19.3

**Hardware**
Fujitsu Lifebook AH530

**Godot version**
v3.2.1.stable.flathub

**How to reproduce the bug**
open an empty / new scene
create a resource with an exported property.
edit the property (you see here that the scene name gets an asterix)
press the save button under the resource editor. (you see here that the asterix doesn't go away)
then press ctrl + s (to get a message that your resource has been saved, even though you've already saved the resource. Even now the asterix doesn't go away)
Repository: PowerToys
Issue: Move mocked input handling from KeyboardManagerTest projects to common
Labels: Area-Tests

Move the mocked input and low level keyboard logic introduced in #4004 to common, as the classes/interfaces can be re-used for testing any low level keyboard hook and or anything involving keyboard input.
This comment mentions all the files that can be re-used https://github.com/microsoft/PowerToys/pull/4004#issuecomment-638511992