sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: godot
Issue: caret on LineEdit is sometimes invisible when app is scaled, solution of caret size=2 looks ugly as width keeps changing
Labels: bug,topic:rendering,needs testing,topic:gui,topic:2d

### Tested versions

- Reproducible in v4.2.2.stable.official [15073afe3]

### System information

Godot v4.2.2.stable - Windows 10.0.19045 - GLES3 (Compatibility) - AMD Radeon RX 6600 (Advanced Micro Devices, Inc.; 31.0.24033.1003) - Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 Threads)

### Issue description

My project has the following settings:
Viewport Width: 1920
Wiewport Height: 1080
Stretch Mode: canvas_items
Stretch Aspect: keep
Scale: 1

When I run the project, it's scaled to my monitor: 1680x1050
The problem is that in a LineEdit the cursor is sometimes invisible, as the scale is <1

The workaround I found elsewhere (https://github.com/godotengine/godot/issues/58133) was to make the caret width = 2.
This does indeed fix the problem, but I find it ugly that the cursor changes width while typing.

![godot caret issue](https://github.com/user-attachments/assets/8ff04969-271d-4cc2-bcb1-1d6899ea1923)

A better solution would be for Godot to always show the cursor as at least 1 pixel wide.

### Steps to reproduce

Create a project and set project settings to:
* Viewport Width: 1920
* Wiewport Height: 1080
* Stretch Mode: canvas_items
* Stretch Aspect: keep
* Scale: 1

Create a LineEdit
Run project and resize screen to be smaller than project Width/Height
Type a line of "i" and at some point the cursor will disappear.
Change the default theme so the caret width = 2
Run project again, resize screen again, type "i"s and at some point the cursor will become thinner.


### Minimal reproduction project (MRP)

N/A
Repository: godot
Issue: TextureLod mipmap broken in FSR 2.2
Labels: bug,topic:rendering,needs testing

### Tested versions

- Reproducible in 4.2.2 stable and v4.3.rc.custom_build [3978628c6]

### System information

Ubuntu 24.04 LTS 24.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 (nvidia; 550.90.07) - AMD Ryzen 5 7600 6-Core Processor (12 Threads)

### Issue description

Setting Scaling 3D to FSR 2.2 and using a scale of less than 1.0 breaks textureLod blurring. It doesn't happen with FSR 1.0 or Bilinear mode.

### Steps to reproduce

- Create new shader and use textureLod(screen_sampler, SCREEN_UV, 4.0)
- In Scaling 3D, set mode to FSR 2.2 and drop the scale factor to less than one

### Minimal reproduction project (MRP)

[blur_testing.zip](https://github.com/user-attachments/files/16458745/blur_testing.zip)
Repository: vscode
Issue: Ship newer version of conpty
Labels: feature-request,windows,terminal-conpty

We currently depend on conpty as shipped by Windows. Unfortunately this means that fixes in conpty can take 1-2 years to make it to the user, provided they update to it. We want to ship conpty.dll similar to how Windows Terminal/wezterm does so we get all the latest improvements.

Many issues get closed as duplicates of this one as updating to conpty v2 will fix many problems in Windows terminals.

node-pty issue: https://github.com/microsoft/node-pty/issues/490
Repository: pytorch
Issue: Automatic dynamic unexpectedly triggering when make_fx'ing through HOPs
Labels: triaged,oncall: pt2,module: ProxyTensor,module: dynamic shapes,module: higher order operators

### 🐛 Describe the bug

Steps to reproduce:

```
TORCH_LOGS=+dynamo python test/test_proxy_tensor.py TestProxyTensorOpInfoCPU.test_make_fx_exhaustive_cond_simple_cpu_float32 TestProxyTensorOpInfoCPU.test_make_fx_fake_exhaustive_flex_attention_backward_simple_cpu_float32
```
 
Note that cond and flex attention are both HOPs, so they trigger Dynamo when make_fx'ed through.

Sample log: https://gist.github.com/ezyang/a2e11076d4213fcb8f3fad463ff6eda7

Two key things to notice:

1. All the compilations are on the same code object (0/0, 0/1, 0/2)
2. Automatic dynamic triggers here:

https://gist.github.com/ezyang/a2e11076d4213fcb8f3fad463ff6eda7#file-baseline-log-L1562

In fact, it was triggered from cond to flex attention.

Is this expected? It seems to me that there shouldn't be any cross-talk between Dynamo instances.

The automatic dynamic is not /necessarily/ problematic but it is a contributing factor to a bug when I patch this in: https://gist.github.com/ezyang/834307e1b030abc67f1cf15677455e1e (stack it on https://github.com/pytorch/pytorch/pull/132407), which I haven't finished diagnosing.

### Versions

main

cc @chauhang @penguinwu @zou3519 @ydwu4
Repository: node
Issue: Buffer.from offsets
Labels: buffer

### Version

v20.15.0

### Platform

```text
Microsoft Windows NT 10.0.19045.0 x64
```


### Subsystem

_No response_

### What steps will reproduce the bug?

Use following example, the complete buffer is copied, `byteOffset` and `length` are ignored as near as I can prove.

```js
const buff = Buffer.alloc(32);
for (let i = 0; i < 32; i++) {
    buff[i] = i;
}
const buff2 = Buffer.from(buff, 5, 5);
console.log(buff2);
```

### How often does it reproduce? Is there a required condition?

Always.

### What is the expected behavior? Why is that the expected behavior?

Expect a partial buffer copy like
`<Buffer 05 06 07 08 09>`

### What do you see instead?

`<Buffer 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f>`

### Additional information

If this is supposed to work, it should be fixed, but if not, improve the docs.
Repository: vscode
Issue: Merge editor shows strange characters when doing cherry pick merge
Labels: bug,merge-editor

Type: <b>Bug</b>

Repro steps:
1. Have conflicting changes in two branches.
2. Cherry pick commit from one branch into another.
3. Use merge editor to handle conflict

<img width="1277" alt="image" src="https://github.com/user-attachments/assets/a7579930-731e-48fa-8dae-ad2dc6d58cd6">


VS Code version: Code - Insiders 1.92.0-insider (3bb157866cdb10b90e5f5999e1d9855c294aa7c7, 2024-07-31T12:31:58.409Z)
OS version: Windows_NT x64 10.0.22621
Modes:

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|Intel(R) Xeon(R) W-2133 CPU @ 3.60GHz (12 x 3600)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off|
|Load (avg)|undefined|
|Memory (System)|31.73GB (16.85GB free)|
|Process Argv|. --log ms-python.python=info --crash-reporter-id 14c3c992-da76-47b9-9893-1c07c5999093|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (18)</summary>

Extension|Author (truncated)|Version
---|---|---
tsl-problem-matcher|amo|0.6.2
ruff|cha|2024.36.0
vscode-eslint|dba|3.0.10
gitlens|eam|15.2.3
EditorConfig|Edi|0.16.4
prettier-vscode|esb|10.4.0
copilot|Git|1.219.1019
copilot-chat|Git|0.19.2024073102
vscode-github-actions|git|0.26.3
vscode-pull-request-github|Git|0.93.2024072609
vscode-docker|ms-|1.29.1
debugpy|ms-|2024.10.0
python|ms-|2024.13.2024073102
vscode-pylance|ms-|2024.7.104
remote-containers|ms-|0.381.0
remote-wsl|ms-|0.88.2
rust-analyzer|rus|0.3.2053
vscode-lldb|vad|1.10.0


</details><details>
<summary>A/B Experiments</summary>

```
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593cf:30376535
py29gd2263:31024238
c4g48928:30535728
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythonregdiag2:30926734
pythonmypyd1:30859725
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
945dj816:31013170
a69g1124:31018687
dvdeprecation:31040973
dwnewjupyter:31046869
2f103344:31071589
nb_pkg_only:31057982
nativerepl1:31104042
refactort:31084545
pythonrstrctxt:31093868
1iic9185:31091668
flighttreat:31105043
nativeloc1:31106922

```

</details>

<!-- generated by issue reporter -->
Repository: rust
Issue: Inconsistent behavior when indexing slice/BTreeSet with `1..=0`
Labels: T-libs-api,C-bug

<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->

I tried this code:

```rust
use std::collections::BTreeSet;

fn main() {
    assert_eq!(&[123][1..=0], []);
    
    let set = BTreeSet::from_iter([123]);
    assert_eq!(set.range(1..=0).copied().collect::<Vec<i32>>(), &[]);
}
```

I expected to see this happen: Either both should panic since the range start is greater than the range end, or both should yield 0 items.

Instead, this happened: The slice indexing assertion passes, but the `BTreeSet` operation panics:

```
range start is greater than range end in BTreeSet
```

### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->

Reproduces on stable 1.80 and current nightly.
Repository: PowerToys
Issue: Inability to rename file extensions of files that prior had no extensions
Labels: Issue-Bug,Product-PowerRename,Needs-Triage

### Microsoft PowerToys version

0.82.1

### Installation method

GitHub

### Running as admin

No

### Area(s) with issue?

PowerRename

### Steps to reproduce

User cannot batch rename the file extensions of **files that have no extensions.**
1. Select the files, right click and choose rename with power rename, check extensions only and you are stuck. You can do nothing
![image](https://github.com/user-attachments/assets/82e02b9a-4411-49ab-b5cf-266ede0b2d74)


### ✔️ Expected Behavior

I was expecting to be able to replace the extension without typing anything in the search box since there is no extension

### ❌ Actual Behavior

The Apply button is always greyed and hence process does not get completed

### Other Software

_No response_
Repository: godot
Issue: NavigationRegion3D with multiple floor levels bakes polygons with wrong height
Labels: topic:navigation

### Tested versions

- Reproducible in: 4.3.rc1, 4.2.2.stable

### System information

Linux - Godot v4.3.rc1.official.e343dbbcc - Vulkan (Forward+)

### Issue description

With specific geometry, like map with bridges or multiple connected height levels (floors), NavigationRegion3D may create polygons using height from wrong level.
![nav_bake_3d](https://github.com/user-attachments/assets/75b8cb97-1223-4c98-a3dd-0cc7119e9438)
Current example bugs with sample_partition_type `Monotone` or `Layers`

### Steps to reproduce

1. Open MRP
2. Select NavigationRegion3D node
3. Click `Clear NavigationMesh`
4. Click `Bake NavigationMesh`

### Minimal reproduction project (MRP)

[nav-bake-3d.zip](https://github.com/user-attachments/files/16459379/nav-bake-3d.zip)
Repository: vscode
Issue: Word wrapping computations are inaccurate
Labels: bug,editor-wrapping

Type: <b>Bug</b>

The algorithm for word wrapping in VS Code seems to be based on the assumption that all Unicode characters are the exact same width.  This is an invalid assumption -- even with so-called fixed-width fonts (which are a myth; emojis, kanji, and ﷽ are here to stay).  Anyway, after we all stopped making console apps and began coding to the web, fixed width fonts stopped being the only way to code -- especially since web apps predominantly render variable-width fonts.

For "statistically typical" English strings, the pedestrian "character counting" method of word wrapping results in overly aggressive word wrapping on-screen, causing a single line to occupy two lines, even when the entire text easily fits on a single line.

VS Code version: Code 1.91.1 (f1e16e1e6214d7c44d078b1f0607b2388f29d729, 2024-07-09T22:06:49.809Z)
OS version: Windows_NT x64 10.0.22631
Modes:

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|AMD Ryzen 9 8945HS w/ Radeon 780M Graphics (16 x 3992)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled|
|Load (avg)|undefined|
|Memory (System)|31.29GB (17.50GB free)|
|Process Argv|anki-import.tsv --crash-reporter-id d432f953-7c41-4022-ab3e-5a417a575ede|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (2)</summary>

Extension|Author (truncated)|Version
---|---|---
rainbow-csv|mec|3.12.0
remote-wsl|ms-|0.88.2


</details><details>
<summary>A/B Experiments</summary>

```
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
bdiig495:31013172
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
impr_priority:31102340
nativerepl1:31104043
refactort:31108082
ccplti:31103428
pythonrstrctxt:31103193

```

</details>

<!-- generated by issue reporter -->
Repository: terminal
Issue: Known unresolved issues after removing VtEngine / adding VT passthrough
Labels: Product-Conpty,Area-VT,Issue-Bug

```[tasklist]
### Tasks
- [x] Reflowing a long line until it wraps results in the cooked read prompt to be misaligned vertically.
- [x] Move the `OSC 0 ; P t BEL` sequence to `WriteWindowTitle` and swap the `BEL` with the `ST` (`ESC \`).
- [x] PowerShell on Windows 10 ships with PSReadLine 2.0.0-beta2 which emits SGR 37/40 instead of 39/49. This results in black spaces when typing and there's no good way to fix that.
- [ ] Translation of `COMMON_LVB_GRID_HORIZONTAL` to `SGR 53` was dropped and may be reintroduced alongside `UNDERSCORE` = `SGR 4`.
- [x] `ScrollConsoleScreenBuffer` destroys grapheme clusters and extended (VT) attributes and could be translated to `DECCRA` and `DECFRA` in the near term. This is important because otherwise `vim` output may loose its extended attributes during scrolling.
- [x] In cmd: `echo ^[[=c` (should return a DA3 report like `^[P!|00000000^[\`, but we now just get `P!|\`).
- [ ] #17817
- [ ] `VtIo::Writer::WriteInfos` should properly verify the width of each individual character.
- [ ] Using `SetConsoleActiveScreenBuffer` destroys grapheme clusters and extended (VT) attributes. It could be translated to VT pages in the long term.
- [ ] A test is missing that ensures that `FillConsoleOutputCharacterW` results in a `CSI n J` during the PowerShell shim.
- [ ] A test is missing that ensures that `PtySignal::ClearBuffer` does not result in any VT being generated.
- [ ] Port the tests over from https://github.com/microsoft/terminal/issues/17801
- [ ] https://github.com/microsoft/terminal/issues/17737
- [x] https://github.com/microsoft/terminal/issues/17709
- [x] https://github.com/microsoft/terminal/issues/17801
- [ ] https://github.com/microsoft/terminal/issues/17874
```
Repository: stable-diffusion-webui
Issue: [Feature Request]: Flux
Labels: enhancement

### Is there an existing issue for this?

- [X] I have searched the existing issues and checked the recent builds/commits

### What would your feature do ?

Today https://blackforestlabs.ai/ (from the same people that created Stable Diffusion) introduced their first new modes: FLUX

Weights: https://huggingface.co/black-forest-labs/FLUX.1-dev
Code to run: https://github.com/black-forest-labs/flux

It would be great to use it with the stable-diffusion-webui as well

### Proposed workflow

1. Open WebUI
2. Select FLUX
3. Be happy


### Additional information

_No response_
Repository: material-ui
Issue: Hover Menu - Menu Item getting focused and follows cursor
Labels: on hold,component: menu,package: joy-ui

### Steps to reproduce

Mostly similar code to documentation
https://mui.com/joy-ui/react-menu/#side-navigation-icons


Link to live example: [(required)]
https://codesandbox.io/p/sandbox/laughing-glitter-n6zqzf?file=%2Fsrc%2FProfileButton.tsx%3A98%2C17

Steps:
1. Hover over menu button
2.Hover over menu items and "focus ring" will also follow
3.Clicking test button to get focus away will now prevent focus from showing up on menu items

### Current behavior

Menu item gets focused when menu is opened via hover action on the MenuButton , and focus follows my cursor.
The focus goes away if I navigate through my site and go to the page with this menu and hover on it. 

It can also be removed by pressing tab or click on other elements.

It is 100% replicable when i refresh my page on where the menu is and hover on it.

https://github.com/user-attachments/assets/50fcffda-afec-4abb-82ee-d4c62d216124
.

### Expected behavior

No focus on Menu Items , focus doesnt follow cursor.

### Context

I read a similiar issue with Select https://github.com/mui/material-ui/issues/23747, I assume it is using the same components and causing a similar issue. 

I also noticed the first MenuItem has a tabindex of 0 and the rest have -1.

Pressing tab removes the blue focus , navigating around on my page/website before going to the menu prevents this issue also , but everytime when i refresh on the page and go to the hovermenu , a blue focus ring will follow my cursor.
 

### Your environment

<details>
  <summary><code>npx @mui/envinfo</code></summary>

```
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
```
System:
    OS: Windows 10 10.0.19045
  Binaries:
    Node: 20.11.1 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
    pnpm: Not Found
  Browsers:
    Chrome: Version 127.0.6533.89 (Official Build) (64-bit)
    Edge: Chromium (127.0.2651.74)
  npmPackages:
    @emotion/react: ^11.11.4 => 11.11.4
    @emotion/styled: ^11.11.5 => 11.11.5
    @mui/base:  5.0.0-beta.42
    @mui/core-downloads-tracker:  6.0.0-dev.240424162023-9968b4889d
    @mui/icons-material: ^5.15.20 => 5.15.20
    @mui/joy: ^5.0.0-beta.36 => 5.0.0-beta.36
    @mui/material: ^5.15.20 => 5.15.20
    @mui/private-theming:  6.0.0-dev.20240529-082515-213b5e33ab
    @mui/styled-engine:  6.0.0-dev.20240529-082515-213b5e33ab
    @mui/system:  6.0.0-dev.240424162023-9968b4889d
    @mui/types:  7.2.14
    @mui/utils:  6.0.0-dev.20240529-082515-213b5e33ab
    @mui/x-date-pickers: ^7.9.0 => 7.9.0
    @types/react: ^18.3.3 => 18.3.3
    react: ^18.3.1 => 18.3.1
    react-dom: ^18.3.1 => 18.3.1
    typescript: ^5.4.3 => 5.4.5

</details>


**Search keywords**: Menu Focus Item Hover
Repository: vscode
Issue: Can the types for these string dictionaries be fixed to catch this at compile time? Something like this?
Labels: tasks,debt

              Can the types for these string dictionaries be fixed to catch this at compile time? Something like this?

```
private _activeTasks: IStringDictionary<IActiveTerminalData | undefined>;
private _busyTasks: IStringDictionary<Task | undefined>;
private _terminals: IStringDictionary<ITerminalData | undefined>;
```

_Originally posted by @Tyriar in https://github.com/microsoft/vscode/pull/224435#discussion_r1700543346_
Repository: godot
Issue: Tab crashes when using "Performance" debugger in Chrome
Labels: bug,platform:web,topic:porting,crash

### Tested versions

- Reproducible in: 4.3.rc 

### System information

Godot v4.3.rc (2f2d1a7e6) - macOS 14.5.0 - GLES3 (Compatibility) - Apple M2 - Apple M2 (8 Threads)

### Issue description

When using the "Performance" tool in Chrome to create a recording, the running game will crash after stoping the recording:

<img width="1166" alt="Screenshot 2024-08-01 at 10 58 31 AM" src="https://github.com/user-attachments/assets/ba708e30-f64e-4d02-8054-a373de9f5f74">

*Note, I have only tested on Chrome.*

It seems like the crash does not happen for all web games. Consider the following example projects that I tested on my system: 

- https://snowhex.itch.io/nefarius-the-last-wizard (crashes)
- https://adamscott.github.io/catburglar-main-thread-samples/ (does not crash)

### Steps to reproduce

1. Open a game exported for web in a new browser tab (I have only tested Chrome)
2. With the game running, open up the [Performance tool](https://developer.chrome.com/docs/devtools/performance) and start a new recording
3. Stop the recording (the length of the recording doesn't seem to matter)
4. Observe the crash

### Minimal reproduction project (MRP)

Exporting an empty project for web will cause this issue.
Repository: pytorch
Issue: MultiProcTest Exception "None is not -6"
Labels: oncall: distributed,triaged

https://github.com/pytorch/pytorch/actions/runs/10117704483/job/28178859665
<img width="960" alt="image" src="https://github.com/user-attachments/assets/61dcdaa8-5d7a-4810-9f7d-719b50204a83">

A few tests related to the Flight Recorder have begun failing recently.
 * first reported by @ZainRizvi as part of a new AMI upgrade (not on trunk)
 * noticed by @wconstab on trunk as flaky test as of 8/1, not sure how long it's been happening

After debugging via SSH on the new AMI via this PR (#131946), I confirmed that the Flight Recorder functionality seems fine, and the test code and pytorch code seems to behave as expected.  Namely, the test intentionally hangs a collective.  One rank first notices this and sets a global flag in TCPStore. The other rank notices this flag.  Both flags raise a timeout error, dump their flight logs, and then raise a SIGABRT with an exception about the timeout.

But after raising the SIGABRT, the pytorch processes (rank0, rank1) do not exit.  The parent (test launcher) waits on .join() call until the join timeout, and then finds a None exitcode.

Attaching GDB to the rank0 or rank1 process can sometimes cause the process to exit immediately, and the test to pass.

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @d4l3k @c-p-i-o @zdevito @ZainRizvi @malfet
Repository: flutter
Issue: [google_maps_flutter] Consider testing both display modes on Android
Labels: a: tests,platform-android,p: maps,package,P2,team-android,triaged-android

(See https://github.com/flutter/packages/pull/7282 for context)

We have two display modes that we support for `google_maps_flutter` on Android, and have for a while, but we only test one of them in the integration tests that run in our example app. The PR referenced above will make the mode we test the mode we recommend to clients, which is an improvement, but if we support two modes we should really be testing both. (This is especially true given that our platform view testing in the engine isn't very comprehensive, so flutter/packages is where we often catch issues in practice; if we aren't testing `google_maps_flutter` with HC, we're less likely to find engine HC regressions.)
Repository: flutter
Issue: [iOS] Remove presentsWithTransaction and CAMetalLayer usage
Labels: P3,team-engine,triaged-engine

Now that we've opted into FlutterMetalLayer, we could remove the old code path and dependencies like tracking presentsWithTransaction.