sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: path/filepath: Join documentation inconsistencies with path.Join
Labels: Documentation,NeedsInvestigation

This is a follow-up to #29875, which is closed.

Problems:
1) The fix was only applied to `path.Join` docs, but `filepath.Join` has the same problem and should be fixed too.
2) The new wording drops the sentence "all empty strings are ignored", leaving no clue that `path.Join("", "foo")` results in `"foo"` rather than `"/foo"`.

New:
> Join joins the argument's path elements into a single path, separating them with slashes. The result is Cleaned. However, if the argument list is empty or all its elements are empty, Join returns an empty string.

Old:
> Join joins any number of path elements into a single path, adding a separating slash if necessary. The result is Cleaned; in particular, all empty strings are ignored.

I think it should be clear that `Join` can return the empty string, but it should be also clear that empty strings at the beginning don't make the path absolute.

While I'm at it, I'm also confused by `path.Dir`:
> Dir returns all but the last element of path, typically the path's directory. After dropping the final element using Split, the path is Cleaned and trailing slashes are removed. If the path is empty, Dir returns ".". If the path consists entirely of slashes followed by non-slash bytes, Dir returns a single slash. In any other case, the returned path does not end in a slash.

It should probably read "If the path consists entirely of slashes *possibly* followed by non-slash bytes" or "If the path consists entirely of slashes followed by *zero or more* non-slash bytes", otherwise the last sentence ("In any other case ...") is false.
Repository: pytorch
Issue: Move the attributes of a module to the given device
Labels: oncall: jit,triaged

## 🚀 Feature
In the current implementation of *[Module](https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/script/module.h#L289-L313)*, there are methods ([torch::jit::script::Module::to(...)](https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/script/module.cpp#L138-L150)) to move all the parameters to the given device (e.g. from CPU to GPU). However, there is no corresponding method to move the attributes in the same way.

## Motivation
Parameters and attributes are both organic parts of the module, when moving the module to a given device, both of these two components should be moved.

A concrete use case would be remote execution, where the inputs (in form of IValue) are assembled on the client side and are sent over RPC to the server side. Usually the clients only have CPUs but the servers have GPUs.  

As we haven't been able to directly serialize/deserialize the IValue (see #25591 for context), a workaround is to leverage the [serialization methods](https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/script/module.h#L331-L339) of Module as follows: 1) create a container module; 2) pack the IValue inside this container module; 3) serialize the module to bytes and send via PRC to the server side; 4) deserialize and then move the received module to GPU and unpack the IValue. 

## Pitch
When a user move the module to the given device, both its attributes and parameters should be moved.

## Alternatives
A more general solution would be implementing IValue::to(device) or some IValue pickle function and make Module::to to leverage the API of Ivalue.

## Additional context
The relevant IValue serialization issues are #25109, #25502, #25591.



cc @suo
Repository: flutter
Issue: Screen turns black after attempting to lock the screen, while launching app
Labels: platform-android,engine,a: existing-apps,P3,team-android,triaged-android

## Flutter doctor
```
[√] Flutter (Channel unknown, v1.10.6, on Microsoft Windows [Version 10.0.18362.476], locale zh-CN)
    • Flutter version 1.10.6 at G:\Softwares\flutter-sdk
    • Framework revision cc3ca9a916 (8 weeks ago), 2019-09-25 10:57:58 -0400
    • Engine revision 63949eb0fd
    • Dart version 2.6.0 (build 2.6.0-dev.2.0 69b5681546)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Users\Lenovo\AppData\Local\Android\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = C:\Users\Lenovo\AppData\Local\Android\Sdk
    • Java binary at: G:\Softwares\AndroidStudio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] Android Studio (version 3.5)
    • Android Studio at G:\Softwares\AndroidStudio
    • Flutter plugin version 41.1.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] IntelliJ IDEA Community Edition (version 2019.2)
    • IntelliJ at G:\Softwares\IntelliJ IDEA Community Edition 2019.2.4
    • Flutter plugin version 41.1.4
    • Dart plugin version 192.7402

[√] Connected device (2 available)
    • SM G960F • 221d64242a0c7ece • android-arm64 • Android 8.1.0 (API 27)
    • BTV DL09 • K6T6R17322001986 • android-arm64 • Android 7.0 (API 24)
```
## Steps to Reproduce

When I touch app icon to launch app in desk, when it launching, I press the power button to lock Screen, after a while. Then, app is locking on black screen (the device SM G960F) or can load some `Text Widget`, but it's not possible to click (the device BTV DL09). This happens not only the debug, but also the release mode.

When I operate normally, no exceptions occur. 
This also happen when I press back button to desk, and re-enter to app. So I added some logic to kill app when press back.
Repository: opencv
Issue: Add OpenCL events support
Labels: feature,category: ocl

Initial solution: https://github.com/opencv/opencv/pull/14600/
Repository: tensorflow
Issue: tf.io.gfile.glob does not list all files in a Google Cloud Storage bucket
Labels: stat:awaiting tensorflower,type:bug,comp:ops

**System information**
- Have I written custom code (as opposed to using a stock example script provided in TensorFlow): ?
- OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
- Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: /
- TensorFlow installed from (source or binary): binary
- TensorFlow version (use command below): 2.0.0
- Python version: 3
- Bazel version (if compiling from source): /
- GCC/Compiler version (if compiling from source): /
- CUDA/cuDNN version: /
- GPU model and memory: /

**Describe the current behavior**
When listing file with `tf.io.gfile.glob` not all images are returned. It seems it is not resolving the folders recursively. 
When using the same path with gsutils  we get the correct image count.


**Describe the expected behavior**
When using the same gs:// path with **gsutils** we get the correct amount of images. 

**Code to reproduce the issue**
In order to reproduce the behavior I prepared a Google Bucket with the following structure. The bucket is public accessible, please feel free to use it to reproduce the behavior on your end: `gs://tensorflow-issue-reproduction`

![level0](https://user-images.githubusercontent.com/1991664/69040135-93375e80-09ed-11ea-927f-da445d2bae10.png)
![level1](https://user-images.githubusercontent.com/1991664/69040139-94688b80-09ed-11ea-9e19-28af47c3bcee.png)
![level2](https://user-images.githubusercontent.com/1991664/69040146-96cae580-09ed-11ea-8894-c69a82acbbaa.png)
![level3](https://user-images.githubusercontent.com/1991664/69040150-9894a900-09ed-11ea-94dc-49fb2d9b3b9b.png)

In summary we have 4 jpg images nested in different folder levels.

TensorFlow 2 code to reproduce
```
files = tf.io.gfile.glob('gs://tensorflow-issue-reproduction/**/*.jpg')
print('file count: ', len(files))
# found files 1
```

gsutil command which works properly
```
gsutil du gs://tensorflow-issue-reproduction/**/*.jpg | wc -l
# found files 4
```

**Other info / logs**
/

Best regards
Sascha
Repository: godot
Issue: GI Probe streaking artifacts
Labels: bug,topic:rendering,confirmed

**Godot version**
3.1.1 
**OS/device including version:**
Windows 10(64 bit)
Running on a laptop with a 1060, i7-8750H @ 2.20GHz and 16 GB ram
**Issue description:**
Building lighting with a GI probe produces weird streaks on most models in the scene:

![Capture](https://user-images.githubusercontent.com/19321972/69044078-5f3d5700-0a48-11ea-803a-bf9dc2d9ac4f.PNG)

**Steps to reproduce:**
Model and unwrap a medium sized scene in blender and export to Godot as a GLB. 
Import it as a scene. 
Add directional light, environment light and GI probe. 
Build GI with maximum GI subdiv. 

**Minimal reproduction project:**
[GiProbeIssue.zip](https://github.com/godotengine/godot/files/3858165/GiProbeIssue.zip)
Repository: go
Issue: gccgo: compiling cmd/internal/obj/x86 on ppc64le takes 14.5GB of RAM and 20 minutes of CPU
Labels: NeedsInvestigation

Bootstrapping the golang.org Go distribution using this version of gccgo takes an excessive amount of time:

```
$ go version
go version go1.12.2 gccgo (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1) linux/ppc64le
```

Specifically, while compiling cmd/internal/obj/x86, `go1` seems to take nearly 20 minutes and uses 14.5GB of RAM for the first 8.5 minutes (after that, it drops to 3GB of RAM). For comparison, make.bash in its entirety takes about 24 minutes of wall clock time and 33 minutes of CPU time.

It seems like the large arrays/slices in that package are hitting some super-linear complexity.

/cc @ianlancetaylor
Repository: go
Issue: x/tools/cmd/present: support play snippets in module mode
Labels: NeedsInvestigation,modules,Tools

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version devel +9325bec899 Wed Nov 13 11:59:24 2019 +0100 darwin/amd64
</pre>

### Does this issue reproduce with the latest release?


### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/elias/Library/Caches/go-build"
GOENV="/Users/elias/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/elias/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/elias/go-tip"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/elias/go-tip/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/elias/proj/gophercon-2019-talk/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/_7/lnt35k555hl2bs7fjygkhgx00000gp/T/go-build183530635=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version devel +9325bec899 Wed Nov 13 11:59:24 2019 +0100 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +9325bec899 Wed Nov 13 11:59:24 2019 +0100
uname -v: Darwin Kernel Version 18.7.0: Sat Oct 12 00:02:19 PDT 2019; root:xnu-4903.278.12~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.14.6
BuildVersion:	18G1012
lldb --version: lldb-1100.0.28.19
Apple Swift version 5.1 (swiftlang-1100.0.270.13 clang-1100.0.33.7)
</pre></details>

### What did you do?

```
$ git clone https://github.com/eliasnaur/gophercon-2019-talk
$ cd gophercon-2019-talk
$ GO111MODULE=on present
```

Then, I opened http://127.0.0.1:3999/gophercon-2019.slide#7 in a browser and pressed "run".


### What did you expect to see?
The program running locally.


### What did you see instead?
```
compile1.go:7:5: cannot find module providing package gioui.org/app: working directory is not part of a module

Program exited: exit status 1
```

`present` used to work with `GO111MODULE=on`. I believe the fix for #32027 broke it.
Repository: bitcoin
Issue: gen-manpages output depends on build options, so needs to check them
Labels: Scripts and tools,good first issue

The [gen-manpages.py](https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/gen-manpages.py) generates UNIX manual pages based on the `-help` output from the binairies that result from the build.

This means that the options documented vary based on the build system settings. In the manual pages that are checked in, we would like to document as many options as possible.

Ideally the script needs to check for:

- `HAVE_SYSTEM` so that `-alertnotify` and other notifications are documented
- `ENABLE_WALLET` so that wallet specific arguments are documented
- `USE_UPNP` so that UPnP arguments are documented
- `ENABLE_ZMQ` so that ZMQ arguments are documented

An alternative would be to generate the manual page from the source code instead (e.g. pick up and parse `AddArg`). This is much more complicated, though, due to use of `strprintf` and such.

## Good first issue

The purpose of the `good first issue` label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.

Useful skills: *shell scripting*


Want to work on this issue?

You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.

For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
Repository: godot
Issue: [Bullet] Angular limits in Generic6DOFJoint doesn't work
Labels: bug,confirmed,topic:physics,topic:3d

**Godot version:**
3.1.1

**OS/device including version:**
Win 7

**Issue description:**
Im trying to use rigid body physics for car simulation with 6DOF Joint
Angular limits in Y/Z axis enabled, but wheel still can rotate around Y/Z axis.
This parameters doesnt work for me:
angular_limit_x/softness
angular_limit_x/restitution
angular_limit_x/damping
angular_limit_x/force_limit

**Steps to reproduce:**
Arrow keys - control vehicle.
Accelerate, turn in any direction - rear wheels will be rotated in Y/Z axis, despite of angular limits
![bug1](https://user-images.githubusercontent.com/6958185/69060534-eaaaee00-0a30-11ea-9909-a6d102325d42.png)

**Minimal reproduction project:**
[Car Using Physics.zip](https://github.com/godotengine/godot/files/3859023/Car.Using.Physics.zip)
Repository: go
Issue: testing: t.Parallel in a subtest masks races with the outer test function
Labels: NeedsInvestigation

The following test should reliably fail when run with `-race`, because it has multiple goroutines (via `t.Parallel()`) that all read from the (unsynchronized, changing) loop variable.

https://play.golang.org/p/nHo8MaTpS3o
```go
func TestParallelRace(t *testing.T) {
	testCases := []struct {
		i int
	}{
		{0},
		{1},
		{2},
	}

	for _, tc := range testCases {
		t.Run(fmt.Sprint(tc.i), func(t *testing.T) {
			t.Parallel()
			t.Log(tc.i)
		})
	}
}
```

However, because `t.Parallel` blocks the goroutine until the main test function returns, the race goes undetected: as far as the race detector is concerned, the program unambiguously meant to use only the last value of the loop variable.

This unintended synchronization masks real bugs, such as the one reported in #35632.

#16520 requests a `vet` check that would detect this and similar cases, but perhaps there is something we can do within the implementation of `t.Parallel` in order to expose these races too.

```
$ go version
go version devel +2bde3c13 Mon Nov 18 05:26:46 2019 +0000 linux/amd64
```

CC @ianthehat @matloob @randall77
Repository: bitcoin
Issue: Simpler settings interpretation
Labels: Utils/log/libs

Settings code cleanup in #15934 uncovered some surprising ways settings are being interpreted.

Most or all of unexpected behaviors should be possible to simplify in some followup changes, and this issue tracks the followups:

| Bug | Fix | Notes
| - | - | - |
| [Ignored network-qualified arguments](https://github.com/bitcoin/bitcoin/blob/397c6d32c8f8a20a3605ef0d51d159adc21fd125/src/util/system.cpp#L334-L337) | #17482 | [Release notes (Command line)](https://github.com/ryanofsky/bitcoin/blob/pr/wdqual/doc/release-notes.md#command-line)
[Ignored chain arguments](https://github.com/bitcoin/bitcoin/blob/397c6d32c8f8a20a3605ef0d51d159adc21fd125/src/util/settings.cpp#L73-L78) | _tbd_
[Reversed config precedence](https://github.com/bitcoin/bitcoin/blob/397c6d32c8f8a20a3605ef0d51d159adc21fd125/src/util/settings.cpp#L66-L71) | #17581 | [Release notes (Configuration file)](https://github.com/ryanofsky/bitcoin/blob/pr/wdmult/doc/release-notes.md#configuration-file). PR depends on #17493 to disallow multiple config assignments, which depends #17556 to fix a fragile python test and #17580 to apply `ALLOW_LIST` flags, which depends on #16545 to implement `ALLOW_LIST` flags
[Misapplied default section config values](https://github.com/bitcoin/bitcoin/blob/397c6d32c8f8a20a3605ef0d51d159adc21fd125/src/util/settings.cpp#L60-L63) | _tbd_
[Zombie config values](https://github.com/bitcoin/bitcoin/blob/397c6d32c8f8a20a3605ef0d51d159adc21fd125/src/util/settings.cpp#L107-L114) | _tbd_
Repository: flutter
Issue: Dark Theme for google maps flutter plugin: https://pub.dev/packages/google_maps_flutter
Labels: c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem

Hi Guys,

Is there a dark theme for the google_maps_flutter package?
Repository: go
Issue: x/tools/cmd/present: remove/hide/disable Native Client for Go 1.14 or newer
Labels: help wanted,NeedsInvestigation,Tools

Go 1.13 is the last release that runs on Native Client (NaCl), as mentioned at https://golang.org/doc/go1.13#ports.

`present` has a flag and mode to use Native Client:

```
$ present -help
...
  -nacl
    	use Native Client environment playground (prevents non-Go code execution) when using local WebSocket transport
...
```

It won't work with Go 1.14 and newer, so we need to deal with that. First step is coming up with a plan.
Repository: go
Issue: encoding/xml: struct tag "a>b>c" not valid on XMLName fields
Labels: Documentation,NeedsInvestigation

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.13.4 windows/amd64
</pre>

### Does this issue reproduce with the latest release?
Yes.

### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOOS=windows
GOARCH=amd64
</pre></details>

### What did you do?
```go
package main

import (
	"encoding/xml"
	"fmt"
)

type NestedField struct {
	Field string `xml:"a>b>c"`
}

type NestedNameStructTag struct {
	XMLName xml.Name `xml:"a>b>c"`
}

type NestedNameValue struct {
	XMLName xml.Name
}

func main() {
	nf := NestedField{}
	xmlBytes, _ := xml.MarshalIndent(nf, "", "    ")
	fmt.Println(string(xmlBytes))

	fmt.Println()

	nnst := NestedNameStructTag{}
	xmlBytes, _ = xml.MarshalIndent(nnst, "", "    ")
	fmt.Println(string(xmlBytes))

	fmt.Println()

	nnv := NestedNameValue{XMLName: xml.Name{Local: "a>b>c"}}
	xmlBytes, _ = xml.MarshalIndent(nnv, "", "    ")
	fmt.Println(string(xmlBytes))
}
```

Output:
```xml
<NestedField>
    <a>
        <b>
            <c></c>
        </b>
    </a>
</NestedField>

<a>b>c></a>b>c>

<a>b>c></a>b>c>

```

### What did you expect to see?
Nested struct tags on XMLName fields should produce nested elements as shown in the "NestedField" example above.

Unless I've missed an exception in the documentation, this is what I expected.

### What did you see instead?
The element name used the provided struct tag verbatim without escaping invalid characters or nesting elements as expected.

I think it's probably reasonable for marshal to behave this way, but the documentation should be updated to match.

### Related issue:
https://github.com/golang/go/issues/2119 encoding/xml: Marshal doesn't understand "parent>child" struct tags
Repository: kubernetes
Issue: Add Conformance kubectl test for cluster urls not in the form of <ip>:<port>
Labels: kind/feature,sig/testing,area/conformance,lifecycle/frozen

**What would you like to be added**:

kubectl supports a "server" argument where the value could be a base URL/IP address (<ip_addr>:443) or an URL with a path attached (<ip_addr>:443/clusterA). Our e2e tests rely on the former scheme, and we have no e2e tests testing the latter.

kubectl already has a unit test for the "<ip_addr>:443/clusterA" format (https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/pkg/cmd/config/config_test.go#L165)

It'd be beneficial to have this as a Conformance test.

**Why is this needed**:

This is useful in scenarios where the master is behind a load balancer, and cannot be represented via a base URL/IP address. Even though this currently works out of the box, it'd be useful having a Conformance test to validate this.

/sig testing
/area conformance
/cc @johnbelamaric 
/cc @ianchakeres
Repository: You-Dont-Know-JS
Issue: numbersCloseEnoughToEqual function is not valid for all numbers
Labels: for second edition

`numbersCloseEnoughToEqual` function is not valid for all numbers.
Try this example
```js
numbersCloseEnoughToEqual(2.02 + 1.135, 3.155); // false
```
Please see snippit in the end of this commet
https://stackoverflow.com/a/56967003
Repository: flutter
Issue: A widget that skips / stops / prevents rebuilding it's child(ren)
Labels: c: new feature,framework,P3,team-framework,triaged-framework

## Use case

In some specific cases it would be great to be able to decide if a specific child should rebuild or not. 

E.g. I have a widget tree in which I embed another widget from a library or package. This widget itself can be composed out of a lot of different widgets that again can listen to specific events and then react / modify their layout regarding those. 

Take [MediaQuery](https://api.flutter.dev/flutter/widgets/MediaQuery-class.html) for example. If someone inherits MediaQuery in their widget and then reacts to the change in window insets (e.g. when a keyboard pops up), it may push its contents up on the screen - even when the actual content is not covered by the keyboard. So if I would use the widget in a way the creator did not have in mind (assuming it would always be at the very bottom of the screen so it will pop up when the keyboard is pressed), it may destroy my layout.

In order to help with that it would be cool to have a more fine-grained control on what gets rebuilt in some specific cases. It could be a widget that 'locks down' the current state of a specific subtree and skips re-drawing of that child(ren). There's already [TickerMode](https://api.flutter.dev/flutter/widgets/TickerMode-class.html) which prevents animations from playing in the subtree, so why not have a widget that completely skips rebuilding of it's child(ren)?

## Proposal

Creating a widget (called 'Freeze, 'Skip', 'Stop' or maybe add the functionality to [RepaintBoundrary](https://api.flutter.dev/flutter/widgets/RepaintBoundary-class.html)?) that will completely skip the 're-layouting' / redrawing of it's child(ren) if the corresponding parameter is set to true, e.g.

```dart
_shouldSkipDrawing = true;

Freeze(
  frozen: _shouldSkipDrawing;
  child: Container(
    child: // beautiful widget tree in here
  ),
)
```