sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: go/types: panic("t.fromRHS = %s, typ = %s") in setDefType
Labels: NeedsInvestigation,gopls,Tools,gopls/telemetry-wins

```
#!stacks
"runtime.gopanic" && "setDefType:+7"
```
Issue created by [stacks](https://pkg.go.dev/golang.org/x/tools/gopls/internal/telemetry/cmd/stacks).
```go
func setDefType(def *TypeName, typ Type) {
	if def != nil {
		switch t := def.typ.(type) {
		case *Alias:
			// t.fromRHS should always be set, either to an invalid type
			// in the beginning, or to typ in certain cyclic declarations.
			if t.fromRHS != Typ[Invalid] && t.fromRHS != typ {
				panic(sprintf(nil, nil, true, "t.fromRHS = %s, typ = %s\n", t.fromRHS, typ))
			}
			t.fromRHS = typ
		case *Basic:
			assert(t == Typ[Invalid])
		case *Named:
			t.underlying = typ
		default:
			panic(fmt.Sprintf("unexpected type %T", t))
		}
	}
}
```
This stack `PrtfKQ` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2024-12-25.json):

- `crash/crash`
- [`runtime.gopanic:+69`](https://cs.opensource.google/go/go/+/go1.23.4:src/runtime/panic.go;l=804)
- [`go/types.(*Checker).handleBailout:+7`](https://cs.opensource.google/go/go/+/go1.23.4:src/go/types/check.go;l=404)
- [`go/types.(*Checker).Files.deferwrap1:+0`](https://cs.opensource.google/go/go/+/go1.23.4:src/go/types/check.go;l=421)
- [`runtime.gopanic:+50`](https://cs.opensource.google/go/go/+/go1.23.4:src/runtime/panic.go;l=785)
- [`go/types.setDefType:+7`](https://cs.opensource.google/go/go/+/go1.23.4:src/go/types/typexpr.go;l=422)
- [`go/types.(*Checker).typInternal:+175`](https://cs.opensource.google/go/go/+/go1.23.4:src/go/types/typexpr.go;l=411)
- [`go/types.(*Checker).definedType:+1`](https://cs.opensource.google/go/go/+/go1.23.4:src/go/types/typexpr.go;l=201)
- [`go/types.(*Checker).typeDecl:+55`](https://cs.opensource.google/go/go/+/go1.23.4:src/go/types/decl.go;l=610)
- [`go/types.(*Checker).objDecl:+141`](https://cs.opensource.google/go/go/+/go1.23.4:src/go/types/decl.go;l=191)
- [`go/types.(*Checker).packageObjects:+59`](https://cs.opensource.google/go/go/+/go1.23.4:src/go/types/resolver.go;l=710)
- [`go/types.(*Checker).checkFiles:+29`](https://cs.opensource.google/go/go/+/go1.23.4:src/go/types/check.go;l=459)
- [`go/types.(*Checker).Files:+13`](https://cs.opensource.google/go/go/+/go1.23.4:src/go/types/check.go;l=422)
- [`golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).checkPackage:+73`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=1543)
- [`golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getPackage.func1:+49`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=420)
- `golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32`
- [`golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getPackage:+1`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=371)
```
golang.org/x/tools/gopls@v0.17.1 go1.23.4 linux/amd64 vscode (1)
```

cc @timothy-king
Dups: FBA0bw RBzqiQ ucULZw Ct75kw kiWqdA NSTQeg fHIAHw --O60g LRZG_A ToWwaw
Repository: kubernetes
Issue: Transparent Huge Pages (THP)
Labels: kind/support,needs-sig,needs-triage

### What would you like to be added?

Transparent Huge Pages (THP)

### Why is this needed?

Go language has some memory-related optimizations, as outlined in [this guide](https://tip.golang.org/doc/gc-guide), which includes Linux Transparent Huge Pages (THP).

Is it recommended to enable Transparent Huge Pages (THP) on the master node when installing the core components of Kubernetes (K8s)?

Relevant materials:

Oracle recommends disabling transparent huge pages:
[Disabling Transparent HugePages](https://docs.oracle.com/en/database/oracle/oracle-database/19/cwlin/disabling-transparent-hugepages.html#GUID-02E9147D-D565-4AF8-B12A-8E6E9F74BEEA)
Redis recommends disabling transparent huge pages:
[Redis Documentation on Transparent Huge Pages](https://redis.io/docs/latest/operate/oss_and_stack/management/optimization/latency/)
Repository: rust
Issue: Target feature implications for negative features are handled inconsistently between codegen and `cfg(target_feature)`
Labels: T-compiler,C-bug,A-target-feature

The logic that computes `cfg(target_feature)` takes into account target feature implications when handling something like `-sse`: it will also remove `avx` from the list of enabled target features in that case. However, the logic that computes which flags we set for codegen (which, unfortunately, is completely separate), does not do the same: it will add `-sse` to LLVM's target feature list, but does not do anything about Rust-level target feature implications.

This can't be correct -- either negative target features also imply that their "reverse dependencies" get disabled, or they do not. We shouldn't do one thing in codegen and a different thing for `cfg`. Or is there some good reason for this?

The logic for this was added in https://github.com/rust-lang/rust/pull/128221.

Cc @calebzulawski @Amanieu @workingjubilee
Repository: pytorch
Issue: Adaptive pool MPS
Labels: triaged,enhancement,module: pooling,module: mps

### 🚀 The feature, motivation and pitch

Hello, I've been trying to train a VGG architecture over a M3 chip.

I have this mistake:

RuntimeError: Adaptive pool MPS: output sizes must be divisible by input sizes. Non-divisible input sizes are not implemented on MPS device yet. For now, you can manually transfer tensor to cpu in this case. Please refer to [this issue](https://github.com/pytorch/pytorch/issues/96056)


### Alternatives

_No response_

### Additional context

_No response_

cc @mikaylagawarecki @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen
Repository: create-react-app
Issue: there should be a single place that holds the dependencies
Labels: issue: proposal,needs triage

### Is your proposal related to a problem?
Yes, I was checking the comments where I saw it is mentioned in TODO, to have a single place to hold dependencies instead of hard-coding the values during declaration.
<!--
  Provide a clear and concise description of what the problem is.
  For example, "I'm always frustrated when..."
--> no, it's not a problem just checking comments

(Write your answer here.)

### Describe the solution you'd like
// dependencies.js
module.exports = ['react', 'react-dom', 'react-scripts'];

//createReactApp.js
const dependencies = require('./dependencies').sort();
<!--
  Provide a clear and concise description of what you want to happen.
--> Instead of hardcoding the values in a place, I think we can have a single dependencies file which holds the dependencies array

(Describe your proposed solution here.)

### Describe alternatives you've considered

<!--
  Let us know about other solutions you've tried or researched.
-->

(Write your answer here.)

### Additional context
  // TODO: there should be a single place that holds the dependencies
  const dependencies = ['react', 'react-dom', 'react-scripts'].sort();
  if (dependencies.includes(appName)) {
    console.error(
      chalk.red(
        `Cannot create a project named ${chalk.green(
          `"${appName}"`
        )} because a dependency with the same name exists.\n` +
          `Due to the way npm works, the following names are not allowed:\n\n`
      ) +
        chalk.cyan(dependencies.map(depName => `  ${depName}`).join('\n')) +
        chalk.red('\n\nPlease choose a different project name.')
    );
    process.exit(1);
  }
}

I thought I will give it a try, could you please take a look once you are free.
<!--
  Is there anything else you can add about the proposal?
  You might want to link to related issues here, if you haven't already.
-->

(Write your answer here.)
Repository: vscode
Issue: VSCode does not inherit command prompt environment variables when launched using code.exe
Labels: feature-request,terminal-process

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.97.0 insiders
- OS Version: Windows 10 (build 19045)

Steps to Reproduce:

1. Open command prompt and launch vscode with the following commands:
  ```
  set PATH=C:\msys64\mingw64\bin
  start /d "C:\path\to\vscode\install\directory\" Code.exe -n
  ```
2. In the VSCode instance, open a Command Prompt terminal and execute `echo %PATH%`
3. Open a new command prompt window and launch vscode with the following commands:
  ```
  set PATH=C:\msys64\ucrt64\bin
  start /d "C:\path\to\vscode\install\directory\" Code.exe -n
  ```
4. In the new VSCode instance, open a Command Prompt terminal and execute `echo %PATH%`

Expected behavior: The second instance of VSCode will echo `C:\msys64\ucrt64\bin`.
Actual behavior: The second instance of VSCode echos `C:\msys64\mingw64\bin`.

Related to the following closed issues: #15452 #109238. After reviewing these issues, I do believe this is a bug and not the intended design. I wasn't able to find any open issues regarding this topic.

I also read the loosely related open feature-request #47816, but it doesn't capture this issue specifically since it is talking about updating the environment for new terminal instances within an already open instance of VSCode.
Repository: transformers
Issue: DeepSeek V3 Support
Labels: New model

### Model description

#### Transformer model

DeepSeek V3 is a Transformer model that utilizes Mixture of Experts (similar to Qwen2 MoE) and Multi-head Latent Attention (MLA).

![image](https://github.com/user-attachments/assets/351e5e4b-63c5-47c0-888d-109c90a78549)

#### Multi-token Prediction

The model is able to predict multiple tokens sequentially at each step through the MTP modules. The first token is generated by the causal LM which feeds the output token into what I would describe as a "Transformer head" to generate additional tokens for the current step. DeepSeek notes in their release that *"MTP support is currently under active development within the community, and we welcome your contributions and feedback."* (i.e. code for this is not released).

![image](https://github.com/user-attachments/assets/35bce43f-9b7a-4a95-9062-35ae072e9771)


### Open source status

- [X] The model implementation is available
- [X] The model weights are available

### Provide useful links for the implementation

Transformers Code: https://huggingface.co/deepseek-ai/DeepSeek-V3
GitHub Code (minimal implementation): https://github.com/deepseek-ai/DeepSeek-V3/tree/main/inference
Paper: https://github.com/deepseek-ai/DeepSeek-V3/blob/main/DeepSeek_V3.pdf
Repository: flutter
Issue: [infra] Should Cocoon be able to backfill broken engine builds?
Labels: team-infra,P2,triaged-infra,monorepo

## Problem?

Occasionally the engine could fail to build in the MQ due to infra issues. For example, recently we hit an issue with LUCI bots checking out a wrong engine revision:

* https://github.com/flutter/flutter/issues/160704
* https://github.com/flutter/flutter/issues/160795

Other possible scenarios could include files lost in transmission to GCS, failed sync to Google CDN (gstatic), etc.

If such git revision lands on `master` it will stay in a forever broken state. However, the _code_ isn't broken, only infra is. After the infra is fixed, it would be nice to be able to reset the status of that commit in `master` and backfill it along with all the engine artifacts. However, right now we don't have a way to do this in post-submit. There's no way to tell the infra to build the engine after the commit lands in `master`.

A workaround is to push a new PR, have it land normally, and then ask everyone to skip the "broken" one (like I did [here](https://github.com/flutter/flutter/issues/160795#issuecomment-2563008883)). This method is OK, but it requires that everyone get the message.

## What we could do

Have a button on the dashboard (perhaps available to admins only), which would do two things:

* Reset the statuses of all tasks to "New".
* Tag the commit as one needing an engine build.
* Kick off a special post-submit build that runs both the engine and framework CI stages for that commit.

If the code and the infra are indeed in good shape then that should fix the respective Flutter revision.

## Why not do this

Ideally if broken infra leads to a failed engine build, it should result in the MQ check failing, and the PR should be kicked back into pre-submit. Failed infra that results in the MQ landing the commit to post-submit is a serious issue. One could reasonably argue that such things should _never_ happen, and instead of providing a way to backfill post-submit commits, we should just make our infra more robust.
Repository: pytorch
Issue: [Performance] Simple arithemtic operations are slower using MPS than Metal
Labels: module: performance,triaged,module: mps

### 🐛 Describe the bug

Reported by @swolchok and could be confirmed by running something like the following
```python
import torch

from timeit import default_timer
from torch.utils.benchmark import Measurement, Timer

def bench_binary(
    n,
    binary_func,
    dtype=torch.float32,
) -> Measurement:
    t = Timer(
        stmt=f"f(x, y);f(x, y); f(x, y); torch.mps.synchronize()",
        setup=f"x, y=torch.rand((2, {n}), dtype={dtype}, device='mps').unbind(0)",
        globals = {'f': binary_func},
        language="python", timer=default_timer
    )
    return t.blocked_autorange()


mps_lib = torch.mps._compile_shader("""
#include <metal_stdlib>
using namespace metal;
template<typename T>
kernel void add(constant T* x,
                constant T* y,
                device   T* out,
                uint index [[thread_position_in_grid]])
{
    out[index] = static_cast<T>(x[index] + y[index]);
}

template [[host_name("add_float")]] kernel void add(constant float*, constant float*, device float*, uint);
template [[host_name("add_half")]] kernel void add(constant half*, constant half*, device half*, uint);
template [[host_name("add_bfloat")]] kernel void add(constant bfloat*, constant bfloat*, device bfloat*, uint);
""")

def metal_add(x, y):
    rc = torch.empty_like(x)
    { torch.float: mps_lib.add_float,
      torch.half: mps_lib.add_half,
      torch.bfloat16: mps_lib.add_bfloat }[x.dtype](x, y, rc)
    return rc


if __name__ == "__main__":
    n = 1024**2
    for dtype in [torch.float32, torch.float16, torch.bfloat16]:
        # Validate correctness first
        inp = torch.rand(2, n, dtype=dtype, device="mps").unbind(0)
        out = torch.add(*inp)
        out_metal = metal_add(*inp)
        if not torch.allclose(out, out_metal):
            raise RuntimeError(f"out-out_metal.abs().max() is {(out-out_metal).abs().max().item()} for {dtype}")
        eager_t = bench_binary(n, torch.add, dtype)
        metal_t = bench_binary(n, metal_add, dtype)
        use_msec = eager_t.mean > 1e-4 or metal_t.mean > 1e-4
        multiplier = 1e3 if use_msec else 1e6
        uname = "msec" if use_msec else "usec"
        print(f"torch.add()x3 {str(dtype):>14} {eager_t.mean*multiplier:>7.2f} {uname} metal_add()x3: {metal_t.mean*multiplier:>7.2f} {uname} speedup: {eager_t.mean/metal_t.mean:>7.2f}")
```

On M1 pro Metal implementation of the same shader runs 20% faster than MPS one for 1 million elements
```
torch.add()x3  torch.float32    0.53 msec metal_add()x3:    0.42 msec speedup:    1.27
torch.add()x3  torch.float16    0.45 msec metal_add()x3:    0.37 msec speedup:    1.21
torch.add()x3 torch.bfloat16    0.44 msec metal_add()x3:    0.37 msec speedup:    1.19
```
More involved example can be seen here: https://github.com/pytorch/pytorch/pull/143656
### Versions

2.5.1, nightly

cc @msaroufim @kulinseth @albanD @DenisVieriu97 @jhavukainen
Repository: pytorch
Issue: `aten._assert_scalar` can hard error the partitioner
Labels: triaged,oncall: pt2,module: dynamic shapes,module: aotdispatch,module: pt2-dispatcher

internal xref: https://fb.workplace.com/groups/1075192433118967/permalink/1567692087202330/

(second xref: https://fb.workplace.com/groups/1075192433118967/posts/1574136133224592/?comment_id=1575214129783459&reply_comment_id=1577334836238055)

I haven't been able to run the internal repro properly, but I did make a (hopefully representative) tiny OSS repro:
```
import torch

torch._dynamo.config.capture_dynamic_output_shape_ops = True

from torch._functorch import config
config.ban_recompute_not_in_allowlist = False

@torch.compile(backend="aot_eager")
def f(x):
    y = x.nonzero()
    tmp = torch.ones_like(y)
    return x.sum() + tmp.sum()

x = torch.ones(4, requires_grad=True)
out = f(x)
```

cc @chauhang @penguinwu @ezyang @bobrenjc93 @zou3519 @yf225
Repository: ui
Issue: [feat]: add display icons on mobile too
Labels: area: request

### Feature description

Add a functionality to display icons into sidebar on mobile screen.

### Affected component/components

sidebar

### Additional Context

_No response_

### Before submitting

- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs
Repository: svelte
Issue: `Spring` isn't deeply reactive (`target` cannot be mutated)
Labels: transition/animation

### Describe the bug

I have something like this in my app:

```ts
export class BrokenCounter {
  #spring = new Spring({ value: 0 });

  get count() { return this.#spring.current.value }

  incr() { this.#spring.target.value++ }
  decr() { this.#spring.target.value-- }
}
```

**Rather than re-assigning `target` to a new object, I directly mutate the `target` object.**

Doing `target.value++` instead of `target = { value: target.value + 1 }` causes the `Spring` to "miss" the update. It surprised me because I assumed `target` would be proxied by the `Spring` (to make it deeply reactive), just like `$state`. Plus, `Spring` already "looks deeply" into the `target` value (to animate individual properties and array items).

Creating a new object and assigning it to `target` makes for a quick workaround, but it is a bit inefficient and in some situations will lead to a lot of unnecessary garbage being created! This might be a regression from `spring`, which allowed mutating its target through the `update` method/function (I think?).

I see three potential solutions to this issue:

1. Make `Spring` (and maybe others?) deeply reactive just like `$state`
2. Warn against this in the documentation and hope people read it
3. Somehow detect mutations to `target` and issue a warning in the console (probably just in development)

### Reproduction

https://svelte.dev/playground/b9defdca3842490bb907fcfadaedfecc?version=5.16.0

### Logs

_No response_

### System Info

```shell
System:
    OS: macOS 15.1.1
    CPU: (8) arm64 Apple M2
    Memory: 72.67 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.11.0 - ~/Library/pnpm/node
    Yarn: 1.22.22 - ~/Library/pnpm/yarn
    npm: 10.9.0 - ~/Library/pnpm/npm
    pnpm: 9.14.2 - ~/Library/pnpm/pnpm
    bun: 1.1.2 - ~/.bun/bin/bun
  Browsers:
    Safari: 18.1.1
```


### Severity

annoyance
Repository: flutter
Issue: Decide if `.ci.yaml` parser should infer "required" `runIf` deps
Labels: c: proposal,team-infra,P2,c: tech-debt,triaged-infra,monorepo

This is a TODO to discuss with @jtmcdole and @christopherfujino after the holidays as a part of https://github.com/flutter/cocoon/pull/4137.

As of https://github.com/flutter/cocoon/pull/4137, if `runIf` is used, both:

- `DEPS`
- `.ci.yaml` (or `engine/src/flutter/.ci.yaml`)

... are required entries. @yjbanov asked in https://github.com/flutter/cocoon/pull/4137 if it would be possible to have the `.ci.yaml` parser auto-infer these entries, instead of requiring them explicitly for each task. I can see PROs and CONs to both approaches, so we should discuss this informally before making a decision.
Repository: godot
Issue: External Editor line flag differs in behavior from internal editor
Labels: bug,topic:editor,needs testing

### Tested versions

- Tested in Godot v4.3.stable.official [77dcf97d8]
- Reproducible in both VSCode and SublimeText
- Unsure if it applies to any other editor

### System information

Godot v4.3.stable - Windows 10.0.19045 - GLES3 (Compatibility) - AMD Radeon(TM) Vega 8 Graphics (Advanced Micro Devices, Inc.; 31.0.12027.9001) - AMD Ryzen 3 3200G with Radeon Vega Graphics (4 Threads)

### Issue description

When using a external editor, files open 1 line before the expected line while debugging. Compare:

![Image](https://github.com/user-attachments/assets/5682ed17-27d3-414d-9aa8-b00e66f50b9c)

![Image](https://github.com/user-attachments/assets/871bca5c-43c3-410e-a6be-ead5c1201764)

This happens with the official VSCode settings as well, which is why I tried a different one here.

I'm unfamiliar with how this works internally, but this seems to be the line that replaces the flag for the external editor:

https://github.com/godotengine/godot/blob/99a8ab795d65e816ea7c452aa0fb55d02385c048/editor/plugins/script_editor_plugin.cpp#L2508

And I found this case where it is being modified:

https://github.com/godotengine/godot/blob/99a8ab795d65e816ea7c452aa0fb55d02385c048/editor/plugins/script_editor_plugin.cpp#L617

It didn't seem like it was possible to modify the line flag directly in the editor settings in way (like adding a +1)



### Steps to reproduce

- Configure a project with an external editor, like VSCode
- Use External Editor for Debugging
- insert a breakpoint at any line
- see the wrong line being open

### Minimal reproduction project (MRP)

N/A
Repository: flutter
Issue: [Android] Investigate implementing `autoSensitive` sensitive content mode
Labels: platform-android,P2,team-android,triaged-android

The initial implementation of sensitive content support on Android (to address https://github.com/flutter/flutter/issues/150218) will not implement the `autoSensitive` mode, where Android uses a heuristic based on autofill hints to detect sensitive content, see https://developer.android.com/reference/android/view/View#CONTENT_SENSITIVITY_AUTO. Once the initial implementation lands, we should consider implementing this mode, which may require usage of additional APIs.

@gmackall has already done some investigation as to how this may be done in https://github.com/flutter/engine/compare/main...gmackall:engine:content_sensitivity_auto_poc.