sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: Add video_player value isDone
Labels: c: new feature,p: video_player,package,c: proposal,team-ecosystem,P3,r: duplicate,triaged-ecosystem

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill our the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->


<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->
Using the example code provided, the FloatingActionButton shows whether the video is paused or playing *unless the video has completed*.  Then tapping it neither restarts the video, nor does anything else.  I can implement some state tracking that tells me whether it was started and paused, or started and never paused, inferring from the latter that if !isPlaying then it completed.
## Proposal

<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching images showing what you are imagining.

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->
Add a VideoPlayerController.value.{isTheEnd | isDone | isFinished) to indicate that the video has finished playing, and is not paused.
Repository: terminal
Issue: Feature Request: Show tab number in tab
Labels: Issue-Feature,Area-UserInterface,Product-Terminal

<!-- 
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed!
-->

# Summary of the new feature/enhancement

<!-- 
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->

Show tab number in tab. As we have hotkey `alt+number` to switch between tabs, it would be nice if we can see in advance the tab number displayed in the tab bar. #1147 asked for panes number inside a tab. This request is for the tab number.

# Proposed technical implementation details (optional)

<!-- 
A clear and concise description of what you want to happen.
-->

Show the tab number in tab before the tab icon.

![image](https://user-images.githubusercontent.com/13083856/60688911-8c81d200-9eb8-11e9-8eb3-3d82085a12dd.png)



My terminal version is :  0.2.1831.0
Repository: vscode
Issue: Update detects code.exe instances from other users with seperate install folders
Labels: bug,install-update,windows

Two users on the same Windows machine each with their own version of VS Code installed in different folders.
Both users run VS Code, the update now button is pressed by one user and that user closes his VS Code to finish update.
Error message pops up saying that VS Code is still running, although all instances of that user's VS Code are terminated.
Confirmed that the each user's instances all originate from their own user's install folder.

Expected Results:
Users in multiple user environment with separate install folders can update normally, by checking only for running instances of code.exe that originate from the respective install location.
Repository: flutter
Issue: AnimatedList moveItem() Function.
Labels: c: new feature,framework,a: animation,P3,team-framework,triaged-framework

## Use case
When a single item changes index within an AnimatedList, the animations are janky due to the item getting removed, then inserted at another location. Instead of the item performing  hero's like animation to fly to its new index.

## Proposal
I propose a method on AnimatedListState.currentState with the following signature.

moveItem(
oldIndex: 
newIndex:
itemBuilder
)

oldIndex and newIndex are self explanatory. Item Builder would allow the user to rebuild the item as it is in flux between indexes, for example, to render it at decreased opacity.

The inbuilt main Item Builder could be called once settled in the new Index. Perhaps the Animation parameter could be Zeroed or an optional parameter wasMoved provided to the main itemBuilder to allow it to know When the Animation does not need to be driven..

I will be trying to implement this on top of AnimatedList soon. So hopefully will be able to update with a clearer idea of the implementation and possible pit falls
Repository: go
Issue: runtime: raising the number of GOMAXPROCS cause oom
Labels: NeedsInvestigation,compiler/runtime

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.12.1 linux/amd64
</pre>

### Does this issue reproduce with the latest release?
yes


### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
$ go env
GOARCH="amd64"
GOBIN="/home/zhoudazhuang/gobin/"
GOCACHE="/home/zhoudazhuang/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/zhoudazhuang/db11/jm/pro"
GOPROXY=""
GORACE=""
GOROOT="/home/zhoudazhuang/usr/local/go1.12.1/go"
GOTMPDIR=""
GOTOOLDIR="/home/zhoudazhuang/usr/local/go1.12.1/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build631445118=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### What did you do?
Raising the number of GOMAXPROCS from 32 to 512.
I have 32 pysical cpu cores.
Because the gc make my server cosing lots of the time. And the idle cpu is much. 
So I want to improve the gc performance throught GOMAXPROCS.
But I faild, I got the result that gc cost more time and the server cost more memory. 
Even oom finally.
And it seem a long time stw but not from the gc.
runtime scheduler also cause the stw?
Why the memory is rasing ,finnally oom ? 
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->



### What did you expect to see?
no oom


### What did you see instead?
oom
Repository: rust
Issue: allow(deprecated) is too coarse-grained, should take a path
Labels: A-frontend,A-attributes,A-lints,T-lang,C-feature-request,needs-rfc,L-deprecated

https://github.com/rust-lang/rust/commit/007d87f1719e2fcf2ff36aef8b6dc866fa276386 added `allow(deprecated)` in a few places because `mem::uninitialized` is still used. Unfortunately, this allows *all* deprecated items, so by the time someone gets around to fix that, other uses of deprecated items could have crept in.

It would be much better if that could be `allow(deprecated(mem::uninitialized))` or so, to *only* allow the one method without also allowing everything else.

The same applies to `deprecated_in_future`.

I think I saw @Mark-Simulacrum ask for this somewhere recently? Or was it someone else?
Repository: create-react-app
Issue: react-scripts test --onlyChanged always runs ALL tests instead of only the changed tests, yarn jest --onlyChanged works as expected.
Labels: issue: bug,issue: needs investigation

###  Describe the bug

If I run **yarn jest -o**, jest attempts to run 18 tests (out of the 158 in total).

If I run **yarn react-scripts test -o**, jest attempts to run all tests.

If I edit /node_modules/react-scripts/scripts/test.js so that only the following options are passed to Jest: "argv [ '-o' ]" Jest will still attempt to run all the tests so this doesn't seem like a configuration issue.

### Did you try recovering your dependencies?

Yes, 1.16.0

### Which terms did you search for in User Guide?

Jest, --watch, --onlyChanged, -o

### Environment

```
Environment Info:

  System:
    OS: macOS High Sierra 10.13.6
    CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
  Binaries:
    Node: 12.5.0 - ~/.nvm/versions/node/v12.5.0/bin/node
    Yarn: 1.16.0 - /usr/local/bin/yarn
    npm: 6.9.2 - ~/.nvm/versions/node/v12.5.0/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
    Safari: Not Found
  npmPackages:
    babel-plugin-named-asset-import:  0.3.2
    babel-preset-react-app:  9.0.0
    confusing-browser-globals:  1.0.7
    create-react-app:  3.0.1
    eslint-config-react-app:  4.0.1
    react: 16.8.6 => 16.8.6
    react-app-polyfill: ^0.2.2 => 1.0.1
    react-dev-utils:  9.0.1
    react-dom: 16.8.6 => 16.8.6
    react-error-overlay:  5.1.6
    react-scripts: 3.0.1
  npmGlobalPackages:
    create-react-app: Not Found
```
We're using Typescript.

### Steps to reproduce

I understand that this is hard to reproduce, I'm willing to debug this issue if someone could help me to get started with this issue.

### Expected behavior

If I run **yarn react-scripts test -o**, runs only the relevant tests.

### Actual behavior

If I run **yarn react-scripts test -o**, jest attempts to run all tests.

### Reproducible demo

Will attempt to create one.
Repository: TypeScript
Issue: False positive error report for interface type missing index signature, thus not assignable to object type with `unknown` values.
Labels: Docs

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the *entire* template below.
-->

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  3.6.0-dev.20190704 (`3.4.3` doesn't have this bug)

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
index signature, unknown, assignable, interface

**Code**

```ts
interface A {
  properties?: { [Key: string]: unknown };
}

type Bar = {
  key?: "value";
};

interface Baz {
  key?: "value";
}

interface B extends A { // ok
  properties?: Bar;
}

interface C extends A { // error: Baz is not assignable to { [Key: string]: unknown } -> Index signature is missing
  properties?: Baz;
}
```

**Expected behavior:**
No error expected, interface C extends A correctly.

**Actual behavior:**
Error because interface C does not extend interface A

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
http://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgILIN4ChnIA5QD2e0YwEAzgPwBcmyA2gNIQCedFYUoA5gLp0AriADWIQgHcQyAL4BuLDKxYwrEsgBCcKMgC8mHMhFtayAEQA3OABtBEMwvnLQkWIhRaAXgdzHWpyxs7B0VncGh4JE1kCAAPSBAAEwo0egB6NORCEUMCYlJyajotKEcw10iUAGEY+IgklPQMZAyYqCIoYrhvYBTxMGQ4CgpgHhA4ACNrFDBCemY2Di5eAWRhMUlpGWQAWgA+ZABJJLjkEbG4MEEoFF7kAFtekZAeXKISKDJKUy8yoA

**Related Issues:** <!-- Did you find other bugs that looked similar? -->
#30977 (this one is specifically for `enums`)
Repository: rust
Issue: `const fn` allows unreachable calls to non-`const` fns
Labels: T-lang,T-compiler,C-bug,A-const-eval

E.g. the following compiles on stable:
```rust
const fn f() {
    return;
    fn f() {}
    f();
}
```

@eddyb notes that this is because we do a "semantic check" and that `f();` is not linked in the CFG.

However, it seems to me that the basic blocks should be there (tho I haven't checked yet...) so you can visit the call to `f();` and ban it.

cc @oli-obk
Repository: go
Issue: cmd/go/internal/modfetch: treat malformed versions as “not found” on the proxy path
Labels: NeedsDecision,modules

For Go 1.11 and 1.12, I have in my `go.mod` something like:

```go
replace (
        github.com/lxn/walk => golang.zx2c4.com/wireguard/windows pkg/walk
        github.com/lxn/win => golang.zx2c4.com/wireguard/windows pkg/walk-win
)
```

I use this to indicate that usage of `github.com/lxn/walk` should be replaced with the latest contents of a branch called `pkg/walk` from `golang.zx2c4.com/wireguard/windows`.

With 1.13beta1, this now breaks with a message:

```
/home/zx2c4/Projects/wireguard-windows/go.mod:16: replace golang.zx2c4.com/wireguard/windows: version "pkg/walk" invalid: version "pkg/walk" invalid: disallowed version string
/home/zx2c4/Projects/wireguard-windows/go.mod:17: replace golang.zx2c4.com/wireguard/windows: version "pkg/walk-win" invalid: version "pkg/walk-win" invalid: disallowed version string
```

This poses a significant problem.
Repository: flutter
Issue: Flutter Material Tree Widget
Labels: c: new feature,framework,f: material design,P2,team-design,triaged-design

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill our the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case

<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->

I would like to see Flutter Material Tree Widget officially supported.
A tree that can be used to display hierarchy data.

## Proposal

<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching images showing what you are imagining.

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->

https://material.angular.io/components/tree/examples
Repository: rust
Issue: O(1) time {Vec,VecDeque}::truncate for trivial drop types and VecDeque::truncate_front
Labels: I-slow,C-enhancement,T-libs-api,C-optimization

Currently both `Vec`s and `VecDeque`s `truncate` implementations just call `pop_back()` in a loop. When `std::mem::needs_drop::<T>()` is `false` this is pretty inefficient.

Now LLVM *does* [optimize away the loop on `-O3` for `Vec::truncate`](https://rust.godbolt.org/z/WBV3MA), however [this does not happen for `VecDeque::truncate`](https://rust.godbolt.org/z/80GGwx).

Despite [previous complaints](https://github.com/rust-lang/rust/issues/17633#issuecomment-451707138), this exact issue has been [wont-fix](https://github.com/rust-lang/rust/pull/57949#issuecomment-458286725)'d under the unofficial policy that we do not include -O0 exclusive optimizations in rust.

I would like to re-open the discussion with the following observations, in the hope that @alexcrichton might change his mind:

1. No matter the optimization level, the optimization *never* happens for `VecDeque::truncate`.

2. The optimization is not just a constant factor speedup, it's an asymptotic speedup changing an O(n) time operation into O(1) where O(1) could easily be guaranteed. The difference in speed could literally be several orders of magnitude.

3. The optimizer is always fickle and ever-changing. Someone designing an algorithm using default Rust building blocks needs to rely on at least asymptotic complexities not suddenly regressing due to the optimizer not catching some pattern. Updating your Rust compiler should never have a chance to turn an O(n) algorithm into an O(n^2) one.

4. It pushes people towards unsafe code. In the linked complaint above the user ended up using the unsafe `set_len` when the safe `truncate` could've exactly done the job.

In addition to the above, `VecDeque` has `truncate`, but is missing `truncate_front`. If we make these truncate operations O(1) time it should also get a `truncate_front` operation.

Without these changes it is impossible to implement certain algorithms using the default Rust collections for no particular good reason. For example, if I have a `v: VecDeque<f64>` that keeps its elements sorted, it is currently impossible to write a O(log n) time routine that removes all elements less than `x` in `v`. We can find how many elements we need to remove from the front in O(log n) time, but removing them needlessly take O(n) time.
Repository: rust
Issue: Add a way to signal that a snippet is UB/bad in rustdoc
Labels: T-rustdoc,C-enhancement,C-feature-request

Reading the docs for [MaybeUninit](https://doc.rust-lang.org/std/mem/union.MaybeUninit.html) I noticed that the code snippets that contain code that lead to UB are only identified by comments inside the snippet. This feels like a potential source of copy-paste errors. Maybe there could be a way to highlight a code snippet in a bright red or something to make readers wary that this code should never be used?
Repository: flutter
Issue: MethodChannel - introduce a way to test it
Labels: a: tests,engine,dependency: dart,a: platform-views,c: proposal,P2,team-engine,triaged-engine

## Use case
Writing some tests for a plugin i found that is impossible to test methods that make uses of MethodChannel class.
Looking through Flutter MethodChannel documentation i found that  

> Method calls are encoded into binary before being sent, and binary results received are decoded into Dart values.

   

So i think that the impossibility to test these methods, that uses MethodChannel class, is because the binary is not available while executing test cases.    
Test case result will be something like this:  
```
package:flutter/src/services/platform_channel.dart 314:7  MethodChannel.invokeMethod
===== asynchronous gap ===========================
dart:async                                                _AsyncAwaitCompleter.completeError
package:flutter/src/services/platform_channel.dart        MethodChannel.invokeMethod
===== asynchronous gap ===========================
dart:async                                                _asyncThenWrapperHelper
package:flutter/src/services/platform_channel.dart        MethodChannel.invokeMethod
package:flutter_opencv/src/core/scalar.dart 34:34         Scalar.set

MissingPluginException(No implementation found for method set on channel flutter_opencv)
```   
I tried running the app while executing tests in debug mode with no success.  
I tried duplicating the plugin, changing his name and importing it in the original plugin but it doesn't work.
I found that we can mock method channel method but is not always easy replicating the result of the Method call.
## Proposal
I have no idea how to solve this, but it would be nice if we can achieve, in some way this feature, to make the plugin code more strong and stable.
Repository: pytorch
Issue: Eigen Tensor library for convolutions on CPU
Labels: module: performance,module: cpu,module: convolution,triaged,module: arm,function request

## 🚀 Feature
Add option of Eigen Tensor library implementation of convolution on ARM CPU

## Motivation

While convolutions on Intel CPUs are quite fast, there are issues on ARM processors. I tried NNPack which speeds up the default implementation. However TensorFlow is much faster on Raspberry, and also NNabla. The underlying library is Eigen Tensor library which often is even better than ARM compute library.



cc @VitalyFedyunin @ngimel @mruberry
Repository: node
Issue: Missing lines when using readline Interface as AsyncIterable
Labels: readline

<!--
Thank you for reporting a possible bug in Node.js.

Please fill in as much of the template below as you can.

Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify the affected core module name

If possible, please provide code that demonstrates the problem, keeping it as
simple and free of external dependencies as you can.
-->

* **Version**: v12.6.0
* **Platform**: Darwin Admins-MacBook-Pro-6.local 18.6.0 Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64
* **Subsystem**: readline

<!-- Please provide more details below this comment. -->
We were using `readline` to convert a stream that gives bytes to an `AsyncIterable` of lines. We did this by using something like: 
```ts
const iterableOfLines = readline.createInterface({ input: streamOfBytes })
```

We would then use this as an `AsyncIterable` (which looks like it [should be supported](https://github.com/nodejs/node/commit/2a7432dadec08bbe7063d84f1aa4a6396807305c)) and write it to a file, but there would sometimes be lines missing. The number of lines missing was inconsistent and we couldn't identify any patterns relating the lines that were missing. They were not different from the rest in any way, they were not always the first or last lines, etc.

Unfortunately, it's hard for me to tell you more because we were unable to write an isolated test that would reliably show this behavior (we noticed it in production).

We are confident that the bug is in `readline` because we replaced the use of it with our own custom function that would convert the bytes to lines, and we consistently get all of the lines every time.
Repository: flutter
Issue: Create public getter for the "messenger" field of methodChannel java class.
Labels: c: new feature,engine,a: platform-views,c: proposal,P3,team-engine,triaged-engine

## Use case
We are trying to move from full native to full flutter.

We have a feature that work on android by using foreground service, the ios guy might have the same issue.

While the app's in use i register the plugin with the current flutter native view, pluginRegistry.

When the app is in background i create a flutter native view with background parameter as true.

my method channels are inside of a list, because i may want to have a foreground callback and background callback handling result from the native side.

## Proposal

when i receive the onViewDestroyed callback from PluginRegistry.ViewDestroyListener, i want to get the messenger field of the methodChannel so i can remove the method channel that's no longer of use. but the messenger field is private.

Can we make it public ?