sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: x/net/http2: move frame operations to x/net/http2/http2frame
Labels: Proposal,Proposal-Accepted

This issue is part of a project to move `x/net/http2` into `std`: #67810

The [`golang.org/x/net/http2`](https://pkg.go.dev/golang.org/x/net/http2) package includes support for reading and writing HTTP/2 frames. The [`http2.Framer`](https://pkg.go.dev/golang.org/x/net/http2#Framer) type reads and writes frames, and a number of additional types represent specific frames.

Frame support adds a large amount of API surface that few users need. Users who send and receive HTTP/2 requests operate at a higher level than framing, which is an internal protocol detail.

I propose moving `Framer` and all of its ancillary types into a new `golang.org/x/net/http2/http2frame` package and eventually deprecating the versions in `http2`.

Specifically, the following types will move into the new package:

- `ContinuationFrame`
- `DataFrame`
- `Frame`
- `FrameHeader`
- `FrameType`
- `FrameWriteRequest`
- `Framer`
- `GoAwayFrame`
- `HeadersFrame`
- `HeadersFrameParam`
- `MetaHeadersFrame`
- `PingFrame`
- `PriorityFrame`
- `PriorityParam`
- `PushPromiseFrame`
- `PushPromiseParam`
- `RSTStreamFrame`
- `SettingsFrame`
- `UnknownFrame`
- `WindowUpdateFrame`
Repository: pytorch
Issue: Ability to do aot/inductor compilation from a jit model (or torch.exported model)
Labels: triaged,topic: new features,oncall: pt2,oncall: export,module: aotinductor

### 🚀 The feature, motivation and pitch

Hi there, we'd like to know if this is feasible. Some workflows have old exported jit models, without easy access to the original source code.

Is it possible ?
Is it completely impossible?
Is it possible if we have an 'exported model instead' ?

Here is how we do it today ?

```
            so_path = torch._export.aot_compile(
                model.inference, # method name
                (example_inputs,),
                dynamic_shapes=dynamic_shapes,
                options={"aot_inductor.output_path": so_path},
            )
```

### Alternatives

Just do it from a normal model.

### Additional context

_No response_

cc @ezyang @chauhang @penguinwu @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4 @desertfire @chenyang78 @anijain2305 @msaroufim @bdhirsh
Repository: pytorch
Issue: Add SinusoidalPositionalEmbedding module for use in Transformers and Diffusion models
Labels: module: nn,triaged,needs research

### 🚀 The feature, motivation and pitch

Current state of the art algorithms in generative AI (namely transformers and diffusion algorithms) make use of positional embeddings. In pytorch, this functionality is not yet implemented as a separate module, which would be useful for developers trying to create stand alone versions of these algorithms or simply trying to use the concept of positional embeddings in general. 

### Alternatives

There was some discussion about adding a positional embedding layer directly to the transformer model [here](https://github.com/pytorch/pytorch/issues/24826). I believe that creating a separate module for the positional embedding would allow for its use in other models as well (such as diffusion models)

cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki
Repository: PowerToys
Issue: Automatically resize the window when minimised
Labels: Needs-Triage

### Description of the new feature / enhancement

When you have 2-4-6-8 windows open simultaneously on one screen, the scale becomes too small and you have to change it manually for each window and moreover, when you open a new tab in one window, the scale again goes astray and you have to adjust the scale for each window and for each separate browser tab. In other words, when you are actively working, it is endless. It is necessary to make automatic adjustment of new windows under the given parameters (set by the user) or to make adaptive adjustment automatically. 

### Scenario when this would be used?

When you use many windows on one screen and work in a browser and you either have a very large and impossible to work or you need to change resolutions 1000 times during work and work becomes unbearable and impossible).

### Supporting information

Probably not every browser is scaled, but I think it can be a useful feature not only for browsers, but for everything in general, besides, apparently there are browsers that configure permissions for each window separately.... and there is no option to stop using them. 
![Screenshot_1](https://github.com/microsoft/PowerToys/assets/52918574/3b8c6c27-0625-45d6-aef4-12249f596ab6)
Repository: go
Issue: x/tools/gopls: enable telemetry prompting for all gopls-backed editors
Labels: gopls,Tools

Gopls's telemetry prompting is currently disabled by default.
Client should enable by either setting an internal setting or by calling the prompt command.
VS Code Go extension calls the command for the user selected based on
the hash of vscode client id, after at least a week has passed since a telemetry-enabled
gopls version runs. We now want to move this sampling and decision making to gopls, too,
and enable the prompting in all editors, not only in vscode.

That means we need to record more info in the prompt file in the gopls config directory.

Requirement:
 * Preserve the info recorded in the prompt file and avoid prompting users again.
 * Do not prompt if the user just started to use gopls. Wait for 1 week.
 
Some nice-to-haves:
 * VS Code Go extension had been running it for awhile. For consistency in sampling, let gopls use the same hash for vs code users.
 * If possible, migrate the telemetry start time recorded in the VS Code Go extension's memento.
Repository: godot
Issue: Regression: owner variable is unset before tree_exiting signal
Labels: bug,topic:core,regression

### Tested versions

- Reproducible in: 4.2.dev [ba23081eb], 4.2.1-stable, 4.3-beta1
- Not reproducible in: 4.0.4-stable


### System information

Linux Mint 21.3 (Virginia)

### Issue description

This is a regression from #56498 which was fixed with #55512.
As that PR states, 
> Regarding preservation of owner, free() and remove_child() now behave the same: owner is kept during tree_exiting signal and null during tree_exited.

Instead, since commit ba23081eb the behaivour of free() and remove_child() differs, and owner is deleted prematurely when using free() 

### Steps to reproduce

Using an updated version of the minimal project provided in #55512 

**Sample scene**

![image](https://github.com/godotengine/godot/assets/51717357/3c8f702a-bb88-4b0c-9088-494069de7ee1)

**Code**
```gdscript
extends Node2D

func _ready():
	var se1f = self
	$A.connect("tree_exiting", Callable(se1f, "exiting").bind($A))
	$A.connect("tree_exited", Callable(se1f, "exited").bind($A))
	$A/Node.connect("tree_exiting", Callable(se1f, "exiting").bind($A/Node))
	$A/Node.connect("tree_exited", Callable(se1f, "exited").bind($A/Node))
	$A/Node/B.connect("tree_exiting", Callable(se1f, "exiting").bind($A/Node/B))
	$A/Node/B.connect("tree_exited", Callable(se1f, "exited").bind($A/Node/B))
	$A/Node/B/B2.connect("tree_exiting", Callable(se1f, "exiting").bind($A/Node/B/B2))
	$A/Node/B/B2.connect("tree_exited", Callable(se1f, "exited").bind($A/Node/B/B2))
	$A/Node/B/C.connect("tree_exiting", Callable(se1f, "exiting").bind($A/Node/B/C))
	$A/Node/B/C.connect("tree_exited", Callable(se1f, "exited").bind($A/Node/B/C))
	#remove_child($A) # this works
	$A.free() # this doesn't

func exiting(node):
	prints("exiting", node.name, node.owner) #prints node; before it was null

func exited(node):
	prints("exited", node.name, node.owner) #prints null
```

Using remove_child($A) works as expected:
```
exiting C Node2D:<Node2D#26809992391>
exiting B2 B:<Node2D#26860324043>
exiting B Node2D:<Node2D#26809992391>
exiting Node A:<Node2D#26826769610>
exiting A Node2D:<Node2D#26809992391>
exited C <Object#null>
exited B2 B:<Node2D#26860324043>
exited B <Object#null>
exited Node A:<Node2D#26826769610>
exited A <Object#null>
```

While using `$A.free()`
```
exiting C Node2D:<Node2D#26809992391>
exiting B2 B:<Node2D#26860324043>
exiting B Node2D:<Node2D#26809992391>
exiting Node <Object#null>  # Bug
exiting A <Object#null>  # Bug
exited C <Object#null>
exited B2 B:<Node2D#26860324043>
exited B <Object#null>
exited Node <Object#null>
exited A <Object#null>
```




### Minimal reproduction project (MRP)

[minimal_4.2.zip](https://github.com/user-attachments/files/15569416/minimal_4.2.zip)
Repository: pytorch
Issue: Ensuring reliability of PT2 with TorchRec on PRs
Labels: module: ci,triaged,oncall: pt2

### 🚀 The feature, motivation and pitch

Changes to torch.compile/export can break unit tests for components like TorchRec that that use torch.compile/export, for example https://github.com/pytorch/torchrec/actions/runs/9366338936/job/25783538990. The proposal here is to include some general TorchRec <> PT2 testing in the PyTorch CI to ensure changes don't break compatability.

### Alternatives

_No response_

### Additional context

_No response_

cc @seemethere @malfet @pytorch/pytorch-dev-infra @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang
Repository: excalidraw
Issue: MP4 embed , links to local files
Labels: enhancement

Since no perfect whiteboard or planning software exists in 2024 im asking here ... 

im still searching for the perfect whiteboard for movie productions  where i can embed 
-storyboards , 
- animated storyboards, - 
- sound effects , - 
- tutorials from the web, 
- and natively open my blender and aftereffects files or the folders in explorer directly from the whiteboard where i planned the camerashot and everything i need for it
Repository: rust
Issue: rustdoc: Consider ways to make UI development cycle faster
Labels: T-rustdoc,A-rustdoc-ui

EDIT: see the below comments instead https://github.com/rust-lang/rust/issues/125991#issuecomment-2148339854 https://github.com/rust-lang/rust/issues/125991#issuecomment-2148417125

---

The current situation can cause mistakes:

> It allows to underline a serious issue when I work on rustdoc front-end: I modify the generated file and not our `main.js` file, meaning that sometimes, I forget to put all the changes... Thanks for this one!

_Originally posted by @GuillaumeGomez in https://github.com/rust-lang/rust/pull/125779#discussion_r1626538444_
Repository: rust
Issue: Very bad performance of `cargo check` on generic code
Labels: A-trait-system,I-compiletime,T-compiler,C-bug,T-types

I'm writing a parser crate. Yesterday as I fixed some code I ran into a serious performance issue with type checking in the rust compiler. The code linked below takes 50 seconds to run `cargo check` on my Macbook Pro (M2 Pro).

I've tried to make a minimal reproduction by reducing the code a lot and simplifying it a little. It's still a little big at 575 lines (sorry), but the problematic code is at the start. The function at the beginning is a test function from my crate that tests functionality of combining certain parsers. This function is responsible for the slowness. The two trait implementations following that are traits that implement the functionality that is tested by that function, that I wrote yesterday. The rest of the code is dependencies.

I have a function that tests the same thing with simpler kind of parser that lacks the State associated type (not included). That one compiles in a fraction of a second.

I've hosted the example code on the rust playground, but compile fails there (I assume it times out). To reproduce, make a new library crate, copy the code to lib.rs and run `cargo check` to see the problem. (The compiled code doesn't work because everything is stubbed out. The issue is the time to check/compile)

Here's the code:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=1c6bb86548e817430c28ce83d51bc65d

```
% cargo clean && cargo check
     Removed 14 files, 2.9MiB total
    Checking parse v0.0.2 (/Users/maia/Dev/parse)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 50.10s

% cargo clean && cargo +nightly check
     Removed 13 files, 3.4MiB total
    Checking parse v0.0.2 (/Users/maia/Dev/parse)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 52.29s
```

`rustc --version --verbose`:
```
% rustc --version --verbose
rustc 1.78.0 (9b00956e5 2024-04-29)
binary: rustc
commit-hash: 9b00956e56009bab2aa15d7bff10916599e3d6d6
commit-date: 2024-04-29
host: aarch64-apple-darwin
release: 1.78.0
LLVM version: 18.1.2

% cargo +nightly rustc -- --version --verbose
   Compiling parse v0.0.2 (/Users/maia/Dev/parse)
rustc 1.80.0-nightly (c987ad527 2024-05-01)
binary: rustc
commit-hash: c987ad527540e8f1565f57c31204bde33f63df76
commit-date: 2024-05-01
host: aarch64-apple-darwin
release: 1.80.0-nightly
LLVM version: 18.1.4
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.01s
```
Repository: next.js
Issue: Custom events don't work in custom elements
Labels: examples

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
  Platform: win32
  Arch: x64      
  Version: Windows 10 Pro
  Available memory (MB): 8103
  Available CPU cores: 8
Binaries:
  Node: 20.12.1
  npm: N/A
  Yarn: N/A
  pnpm: N/A
Relevant Packages:
  next: 15.0.0-rc.0 // Latest available version is detected (15.0.0-rc.0).
  eslint-config-next: 15.0.0-rc.0
  react: 19.0.0-rc-bf3a29d097-20240603
  react-dom: 19.0.0-rc-bf3a29d097-20240603
  typescript: 4.9.5
Next.js Config:
  output: N/A
```


### Which example does this report relate to?

hello-world

### What browser are you using? (if relevant)

_No response_

### How are you deploying your application? (if relevant)

next dev

### Describe the Bug

Custom events don't work in custom elements

### Expected Behavior

The `handleClick` never called

### To Reproduce

1. Create a next project
2. run `npm i next@rc react@rc react-dom@rc` command
3. Create a custom element that includes a custom event
4. Use the custom element in a nextjs page
```
<my-element onMyClick={handleClick}></my-element>
```
Repository: vscode
Issue: `baseUri` of `exclude` in `findTextInFiles` and `findFiles2` is ignored
Labels: bug,api,search,search-api

1. Create an extension
2. Use the proposed `findTextInFiles` and/or `findFiles2` api, setting the `exclude` option to a `RelativePattern`
3. Use the API to search.
4. Notice that the `baseUri` on the `RelativePattern` gets ignored. :bug:
Repository: go
Issue: x/tools/cmd/deadcode: Test failures
Labels: NeedsInvestigation,Tools

```
#!watchflakes
default <- pkg == "golang.org/x/tools/cmd/deadcode" && test == "Test"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/b/8746498869372910689)):

    === RUN   Test
        deadcode_test.go:27: go tool not available: exec: "go": executable file not found in $path
    --- FAIL: Test (0.14s)


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: rust
Issue: Suggest changing `main`s return type on E0277 (`?` / `from_residual`)
Labels: C-enhancement,A-diagnostics,T-compiler

### Code

```Rust
use std::fs::File;
use std::io::prelude::*;

fn main() {
    let mut file = File::create("foo.txt")?;
    file.write_all(b"Hello, world!")?;
}
```


### Current output

```Shell
error[E0277]: the `?` operator can only be used in a function that returns `Result` or `Option` (or another type that
implements `FromResidual`)
 --> cargo-14007.rs:5:43
  |
4 | fn main() {
  | --------- this function should return `Result` or `Option` to accept `?`
5 |     let mut file = File::create("foo.txt")?;
  |                                           ^ cannot use the `?` operator in a function that returns `()`
  |
  = help: the trait `FromResidual<Result<Infallible, std::io::Error>>` is not implemented for `()`

error[E0277]: the `?` operator can only be used in a function that returns `Result` or `Option` (or another type that
implements `FromResidual`)
 --> cargo-14007.rs:6:37
  |
4 | fn main() {
  | --------- this function should return `Result` or `Option` to accept `?`
5 |     let mut file = File::create("foo.txt")?;
6 |     file.write_all(b"Hello, world!")?;
  |                                     ^ cannot use the `?` operator in a function that returns `()`
  |
  = help: the trait `FromResidual<Result<Infallible, std::io::Error>>` is not implemented for `()`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `cargo-14007` (bin "cargo-14007") due to 2 previous errors
```



### Desired output

To suggest changing
```rust
fn main() {
    // ...
}
```
to
```rust
fn main() -> Result<(), Box<dyn Error>> {
    // ...
    Ok(())
}
```


### Rationale and extra context

In rust-lang/cargo#14007, concern was raised over people generating a trivial `fn main() {}` with `cargo new` and copy/pasting example code that uses `?` (which is encouraged in API guidelines).  Regardless of the decision made for `cargo new`, this applies just as well to users hand writing a trivial `fn main() {}`.  These are likely new users who would be intimidated by the current message and wouldn't know what next steps to take

### Other cases

_No response_

### Rust Version

```Shell
rustc 1.78.0 (9b00956e5 2024-04-29)
binary: rustc
commit-hash: 9b00956e56009bab2aa15d7bff10916599e3d6d6
commit-date: 2024-04-29
host: x86_64-unknown-linux-gnu
release: 1.78.0
LLVM version: 18.1.2
```

### Anything else?

_No response_

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"surechen"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
Repository: opencv
Issue: Max/Min pool
Labels: feature,category: dnn

### Describe the feature and motivation

It would be great to have a max/min pooling operation similar to pytorch's MaxPool layer. I'd imagine max and min pooling function that takes a kernel size, stride and operates on arbitrary number of channels.

### Additional context

I specifically use this to extract foreground/background in a grayscale image. Would be great to have every sub function in one image processing library instead of using torch/scikit-image (I use openCV in python)
Repository: godot
Issue: Animated BoneAttachment3D Performance Impact
Labels: enhancement,needs testing,topic:animation,topic:3d,performance

### Tested versions

- Reproducible in 4.3.beta1, 4.2-stable

### System information

Godot v4.3.beta1 - NixOS #1-NixOS SMP PREEMPT_DYNAMIC Fri May 17 10:18:09 UTC 2024 - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7900 XTX () - AMD Ryzen 5 7600X 6-Core Processor (12 Threads)
### Issue description

Spawning multiple animated Skeleton3D nodes with BoneAttachment3D nodes inside, performance drops way more than it should. (about 50-80% on my rig with 20 skeletons)
I'd expect the FPS impact to be less significant than that. 

### Steps to reproduce

- have multiple characters with BoneAttachment3D nodes inside their skeletons
- free attachments (see MRP)
- watch FPS increase

### Minimal reproduction project (MRP)

https://github.com/fabius/tps-demo

press space to free all attachments
Repository: vscode
Issue: Disable notebook chat hint permanently when the user has triggered ctrl+i
Labels: under-discussion

Similar to https://github.com/microsoft/vscode/issues/213820.
Repository: pytorch
Issue: [pipelining] Supporting skip connections in 1F1B schedules
Labels: triaged,module: pipelining

Currently `Schedule1F1B` and `ScheduleInterleaved1F1B` do not support skip connections because:

1. `ManualPipelineStage` is always assuming that it receives from its neighbor ranks (-1 / +1) which is not the case with skip connections.
2. `PipelineScheduleInterleaved1F1B` and by extension `LoopedBFS` through `step_microbatches` does operate across all the ranks it will be connected in skip connections
3. We do not support batch_isend_irecv in schedules

For point 1 and point 2 we want to fix.

Point 3 may need some investigation if we can even support sorted_batch_isend_irecv or need a different utility
Repository: terminal
Issue: Menu item accelerator does not get set for f1-f12 keys
Labels: Issue-Bug,Area-UserInterface,Product-Terminal

### Windows Terminal version

_No response_

### Windows build number

_No response_

### Other Software

_No response_

### Steps to reproduce

You need a build of terminal that has #17281 in it to repro this

- Add an action to your new tab dropdown with `f1` as the keybinding
- Open the new tab dropdown
- The action shows up, but the accelerator does not (there should be an accelerator that says the keybinding is `f1`)

Example json snippet to test this:
```
"keybindings": [
        {
            "id": "Terminal.CopyToClipboard",
            "keys": "f1"
        }
],
    "newTabMenu": 
    [
        {
            "type": "action",
            "id": "Terminal.CopyToClipboard"
        }
    ],
```

Preliminary investigation shows that `MapVirtualKeyW` (called in `TerminalPage::_SetAcceleratorForMenuItem`) returns `0` for any of the keys `f1` through `f12`, and that's the issue

### Expected Behavior

Accelerator should show up with `f1` in it

### Actual Behavior

There is no accelerator
Repository: terminal
Issue: 1.22: Window resize doesn't snap to cell when we have a non-terminal pane open 
Labels: Help Wanted,Issue-Bug,Area-UserInterface,Product-Terminal,Priority-3

`1.22.240604001-selfhost1.22bugbash2`

(are we using min() on the snap granularities?)
Repository: pytorch
Issue: Symbolic shape fails symbol_to_source when caching is enabled
Labels: triaged,module: nestedtensor,tensor subclass,oncall: pt2,module: dynamic shapes,module: inductor

### 🐛 Describe the bug

There's two issues here:
- [ ] First, NT/PT2 stack should "lift" these symints as inputs to the fx graph (@bdhirsh )
- [ ] Next, this issue only repros w/ caching - we should make it so that caching path doesn't require this, since the non-caching path also doesn't need it (@masnesral / @oulgen)


Repro:
```python
import torch
import torch._inductor.config

# or as an environment variable, TORCHINDUCTOR_FX_GRAPH_CACHE=1
torch._inductor.config.fx_graph_cache = True

def gen_nt(r):
    values = torch.randn(r, 16)
    offsets = torch.tensor([0, 2, 3, 6, 13, r])
    return torch.nested.nested_tensor_from_jagged(values, offsets)

def fn(nt):
    if nt.values().size(0) % 16 == 0:
        return nt.sin()
    return nt.cos()

torch.compile(fn)(gen_nt(19))
torch.compile(fn)(gen_nt(20))
```

### Versions

pytorch main branch ~jul 3

cc @cpuhrsch @jbschlosser @bhosmer @drisspg @soulitzer @ezyang @msaroufim @albanD @bdhirsh @anijain2305 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire
Repository: pytorch
Issue: torch.addr outputs NaN when computing on inf vectors
Labels: needs reproduction,triaged,module: complex,module: NaNs and Infs

### 🐛 Describe the bug

Here is the code to reproduce

```
import torch
import numpy as np
input = torch.tensor(1.10, dtype=torch.complex64)
vec1 = torch.tensor([np.inf])
vec2 = torch.tensor([1,2], dtype=torch.float32)
print(vec1, vec2, torch.outer(vec1, vec2))  # tensor([inf]) tensor([ 1, 2]) tensor([[inf, inf]])
print(input)  # tensor(1.1000+0.j)
print(input + torch.outer(vec1, vec2))  # tensor([[inf+nanj, inf+nanj]])
out = torch.addr(input,vec1,vec2)
print(out)  # tensor([[nan+nanj, nan+nanj]])
```

According to the equation (https://pytorch.org/docs/stable/generated/torch.addr.html): `out = beta*input + alpha*torch.outer(vec1, vec2)`, `out` should not be `NaN` when vec1 is `inf`. The expected result seems to be `[[inf+infj, inf+infj]]`

### Versions

[pip3] numpy==1.26.2
[pip3] torch==2.3.0
[conda] numpy 1.26.2 pypi_0 pypi
[conda] torch 2.3.0 pypi_0 pypi

cc @ezyang @anjali411 @dylanbespalko @mruberry @Lezcano @nikitaved @amjames