sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: runtime: use register instead of TLS for G pointer for darwin/arm and darwin/arm64
Labels: OS-Darwin,compiler/runtime

Need to decide how to handle TLS on darwin/arm.  On x86, TLS was moved from a pthread_get/setspecific implementation to a reserved (by Apple) slot in the TLS (see #23617).  That's not possible for arm/arm64 so we still use the old method.  Since these archs have more registers, we should probably just reserve a register for the G pointer.

Reserving a register might invalidate some existing assembly code.  Kind of a wrench in the plan, need to investigate how bad it might be.

Or maybe someone can think of a better solution.

We might need a solution before we can do #17490 for arm.
Repository: flutter
Issue: Improve error message for CocoaPods error "The sandbox is not in sync with the Podfile.lock"
Labels: tool,t: xcode,P2,a: plugins,team-tool,triaged-tool

See the transcript below for full details, but briefly:

  flutter run on examples/flutter_view failed with this error message:

```
    error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.
```

`pod install` in the current directory fails.  You appear to need to `cd ios; pod install`.

It would be more helpful if the error message could indicate that in some way.

```
leafp-macbookpro:flutter_view leafp$ ../../bin/flutter run 
Launching lib/main.dart on iPhone X in debug mode...
Running Xcode clean...                                       1.0s
Starting Xcode build...                                          
Xcode build done.                                            1.0s
Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **
    
Xcode's output:
↳
    === BUILD TARGET Runner OF PROJECT Runner WITH CONFIGURATION Debug ===
    Debug.xcconfig line 2: Unable to find included file "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
    Debug.xcconfig line 2: Unable to find included file "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
    === BUILD TARGET Runner OF PROJECT Runner WITH CONFIGURATION Debug ===
    diff: /Podfile.lock: No such file or directory
    diff: /Manifest.lock: No such file or directory
    error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.
Could not build the application for the simulator.
Error launching application on iPhone X.
leafp-macbookpro:flutter_view leafp$ pod install
[!] No `Podfile' found in the project directory.
leafp-macbookpro:flutter_view leafp$ ls
README.md	assets		ios		pubspec.lock
android		build		lib		pubspec.yaml
leafp-macbookpro:flutter_view leafp$ cd ios/
leafp-macbookpro:ios leafp$ ls
Flutter			Podfile			Runner.xcodeproj	ServiceDefinitions.json
Frameworks		Runner			Runner.xcworkspace
leafp-macbookpro:ios leafp$ pod install
Analyzing dependencies
Downloading dependencies
Installing MaterialControls (1.2.2)
Generating Pods project
Integrating client project
Sending stats
Pod installation complete! There is 1 dependency from the Podfile and 1 total pod installed.
```
Repository: go
Issue: x/build/cmd/relui: occasionally see TLS timeouts when fetching source archive
Labels: Builders,NeedsInvestigation

When recently building on windows-amd64 and also during the 1.10.1 release:

```
2018/04/10 14:14:48 windows-amd64: Error: 500 Internal Server Error; body: fetching URL https://go.googlesource.com/go/+archive/master.tar.gz: Get https://go.googlesource.com/go/+archive/master.tar.gz: net/http: TLS handshake timeout
```

@bradfitz @FiloSottile
Repository: rust
Issue: compiletest: compare-mode cannot handle mixed success + failure
Labels: A-testsuite,C-enhancement,T-bootstrap,A-compiletest,E-needs-design,E-needs-investigation

Sub-issue of #48879

Currently, if you have a ui test `src/test/ui/foo.rs` that signals a diagnostic error under the AST borrowck, but has no error under the NLL borrowck, then there is no way to make a `foo.nll.stderr` or `foo.nll.stdout` such that running `compiletest --compare-mode=nll` will accept it.

The reason: `compiletest` complains that the compilation itself was successful, and by default, all ui tests are assumed to signal a compilation failure.

The usual way such a case (of a test that compiles without an error) is handled in `compiletest` is to add a comment of the form `// run-pass` in the test itself. But we do not want the tests to be marked as always passing; they *only* pass under the special mode (NLL in this case) that is still under development in the compiler itself.

There are a number of reasonable ways of addressing this.
 1. We could modify such tests to ensure that ~~they end with a function~~ *their `fn main`* is tagged with `#[rustc_error]`, so that they will *never* successfully compile.
 2. We could attempt to have some way to encode a mode-predicated run-pass marker, e.g. `// [nll] run-pass`.
 3. We could have `compiletest` *infer* that a test, when running under compare-mode, must have an implicit `// run-pass` marker, if there exists a `foo.mode.stdout` file (even an empty one).

 I'm not such a big fan of options 1 or 2 because I like the fact that (so far) compare-mode does not have to impact the existing `.rs` nor `.stderr`/`.stdout` files; you just add your alternative `.nll.stderr` file and no one else is the wiser.

So currently I would like us to adopt option 3 (or some other option I haven't thought of yet) that allows the `.rs`/`.stderr`/`.stdout` to go on oblivious to the existence of compare-mode.

**But**, in the short term, to let us get work done, I plan to follow option 1 for all existing `ui/` tests. (This is intended to be a **temporary hack**; all such uses of this hack should point back to this issue.)
Repository: flutter
Issue: Text overflow handling is inconsistent and sometimes wrong.
Labels: framework,a: typography,has reproducible steps,P2,found in release: 3.7,found in release: 3.9,team-framework,triaged-framework

It looks like our overflow handling is pretty weird (if not just downright broken).

For instance, the following doesn't result in any overflow handling other than "clip", regardless of the overflow mode:
```dart
new Text(
  '''Lorem ipsum dolor sit amet, consectetur adipiscing elit.\n Phasellus sodales eros nec tortor maximus molestie.\nSed metus metus, viverra vel libero sed, commodo consequat ipsum. Sed commodo ultricies ligula, sed ultricies diam dignissim vitae. ''',
  softWrap: true,
  maxLines: 2,
  textAlign: TextAlign.start,
  overflow: TextOverflow.ellipsis,
),
```
I would expect that since there is more text to be displayed than the `maxLines`, that we do show the ellipsis at the end of the second line.

Also, if I remove the hard newlines, then the ellipsis does appear at the end of the second line, which is correct, but inconsistent. And if I then switch to overflow to fade, it fades the first line and the second, instead of just the second.
Repository: angular
Issue: Parent ngIf not respecting child's animation to finish before parent is removed from DOM
Labels: type: bug/fix,area: animations,freq2: medium,P3

<!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.

ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->

## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>

## Current behavior
Parent ngIf does not wait for child animation to finish before killing it, apparently only if child's animation does not use :leave.
Issue [#15798](https://github.com/angular/angular/issues/15798) and [#18305](https://github.com/angular/angular/issues/18305) are about the same thing. The user [dharders](https://github.com/dharders) said:

> I should have specified that animateChild() is needed only if you have :leave animations in a child component and the parent is removed from the DOM.

but I would like to have the usage of that method for custom states.



## Expected behavior
Parent ngIf waits for child's animation to finish before removing it form the DOM.


## Minimal reproduction of the problem with instructions
I have this for my child component
```
animations: [
    trigger('slideUpDown', [
      state('hide', style({transform: 'translateY(100%)'})),
      state('show', style({transform: 'translateY(0)'})),
      transition('hide <=> show', animate('500ms ease-in-out'))
    ])
 ]

...

state: 'show'|'hide' = 'hide';
toggleView() {
    this.state = this.state === 'show' ? 'hide' : 'show';
}
```
and for my parent component
- html:
```
<button (click)="toggle()">Click</button>
<div *ngIf="isVisible">
    <child #childComponent></child>
</div>
```
- ts
```
@ViewChild('childComponent') childComponent: ChildComponent;
toggle() {
    this.childComponent.toggleState();
}
```

## What is the motivation / use case for changing the behavior?
So child animations are respected when parent is about to be hidden.

## Environment

<pre><code>
Angular version: Angular-CLI 1.7.4 - "@angular/core": "^5.2.0"
<!-- Check whether this is still an issue in the most recent Angular version -->

Browser:
- [X] Chrome (desktop) version 65.0.3325.181
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: v8.11.1
- Platform:  Windows 10 64bit

Others:
</code></pre>
Repository: pytorch
Issue: [Caffe2] Boolean Tensor not supported for mobile_exporter.Export
Labels: caffe2

The following sample results in an error.

# Code
```python
#!/usr/bin/env python
import onnx
import numpy as np
import caffe2.python.onnx.frontend as oc2f
import caffe2.python.predictor.predictor_exporter as pe
import caffe2.python.predictor.mobile_exporter as c2me
from caffe2.python import model_helper, workspace, brew, utils
IN_DATA_NAME = "in_data"
OUT_DATA_NAME = "out_data"
DATA_SHAPE = (1, 3, 3, 3)

model = model_helper.ModelHelper(name="not_net")
model.net.Not(IN_DATA_NAME, OUT_DATA_NAME)
val = (np.random.standard_normal(DATA_SHAPE) > 0).astype(np.bool)
model.param_init_net.GivenTensorBoolFill([], IN_DATA_NAME, values=val, shape=DATA_SHAPE)
workspace.RunNetOnce(model.param_init_net)

init_net, predict_net = c2me.Export(workspace, model.net, [IN_DATA_NAME])

value_info = {
}

onnx_model = oc2f.caffe2_net_to_onnx_model(
        predict_net,
        init_net,
        value_info)
onnx.checker.check_model(onnx_model)
print(onnx_model)
with open("not.onnx", 'wb') as f:
    f.write(onnx_model.SerializeToString())
```

# Error
```
Traceback (most recent call last):
  File "./gen_not.py", line 33, in <module>
    init_net, predict_net = c2me.Export(workspace, model.net, [IN_DATA_NAME])
  File "/home/masato/repo/pytorch/build/caffe2/python/predictor/mobile_exporter.py", line 70, in Export
    add_tensor(init_net, blob_name, blob)
  File "/home/masato/repo/pytorch/build/caffe2/python/predictor/mobile_exporter.py", line 35, in add_tensor
    kTypeNameMapper[blob.dtype],
KeyError: dtype('bool')
```

I am able to finish properly by adding the following line to mobile_exporter.py, but I'm not sure if this is the correct fix.

```diff
diff --git a/caffe2/python/predictor/mobile_exporter.py b/caffe2/python/predictor/mobile_exporter.py
index 07f88def0..9095f9c10 100644
--- a/caffe2/python/predictor/mobile_exporter.py
+++ b/caffe2/python/predictor/mobile_exporter.py
@@ -20,6 +20,7 @@ def add_tensor(net, name, blob):
         np.dtype('int32'): "GivenTensorIntFill",
         np.dtype('int64'): "GivenTensorInt64Fill",
         np.dtype('uint8'): "GivenTensorStringFill",
+        np.dtype('bool'): "GivenTensorBoolFill",
     }

     shape = blob.shape
```



# Environment
- OS: Ubuntu 16.04.4 x86_64
- Python: 3.5.2
- Pytorch version: 2e156f3eabb6fa4ae88c2e831aea7da344cf43a3
- onnx version: b8c423889b3d15825e90fd5bd8fa1766ba2200ce
Repository: scrcpy
Issue: Set envvar on device, so other tools can react to scrcpy
Labels: feature request

I use Tasker for device automation and other neat little gimmicks.

I wonder if it's possible to have scrcpy set an envvar when connecting to the device so I can have tasker do stuff like disabling display timeout and such.
Repository: vscode
Issue: Allow maximizing/restoring a single terminal or editor pane
Labels: feature-request,workbench-views

I'd be surprised if this hasn't been asked before, but tmux supports a thing it calls "pane zooming", if I recall correctly. 

Basically once you start splitting a window, vertically, horizontally, it doesn't matter, you press a certain keyboard shortcut and the current pane is "maximized", hiding all the other panes. Text is reflowed, so you actually see the former pane as a full window. This is incredibly useful once you launch some command that has a ton of unexpected output that you want to check out.

When you're done you press the same keyboard shortcut and the pane "reverts", showing the previous layout. The text in the pane is reflowed again to make it fit in the smaller pane size.

Very, very handy when you're moving through terminals quickly and you want to check out something.
Repository: pytorch
Issue: [Caffe2] Onnx to Caffe2 Blob error
Labels: caffe2

Trying to convert a model from PyTorch to Caffe2. I have the model in Onnx form, however when I try to go from Onnx to Caffe2 using the tool in caffe2.python.onnx.bin.conversion, I get an output but running them in Caffe2 produces:

'W0411 14:04:06.918320 13911 workspace.cc:174] Blob 1 not in the workspace.
WARNING:caffe2.python.workspace:Original python traceback for operator `1647504248` in network 
torch-jit-export_predict^
0
1
25"Conv*
strides00*
	dilations00*
group*
kernels00*
pads00003
56PadImage*
pads0000*
mode"reflect^
6
3
47"Conv*
strides00*
	dilations00*
group*
kernels00*
pads0000
78"Relu:0:1:2:3:4B8` in exception above (most recent call last):
Traceback (most recent call last):
  File "Caffe2WCT.py", line 32, in <module>
    workspace.RunNetOnce(predict_net)
  File "/usr/local/lib/python2.7/dist-packages/caffe2/python/workspace.py", line 199, in RunNetOnce
    StringifyProto(net),
  File "/usr/local/lib/python2.7/dist-packages/caffe2/python/workspace.py", line 178, in CallWithExceptionIntercept
    return func(*args, **kwargs)
RuntimeError: [enforce fail at operator.cc:42] blob != nullptr. op Conv: Encountered a non-existing input blob: 1'

OS: Ubuntu 16.04
Caffe2: Built from source this morning
Python: 2.7
Repository: flutter
Issue: Support drawing text along a curved path and on a mesh
Labels: c: new feature,engine,a: typography,P3,team-engine,triaged-engine

I would like to be able to draw text on a non-linear path, e.g. like so: https://fiddle.skia.org/c/@draw_text_on_path

It doesn't appear to be possible to do that today - the `Paragraph` and `Canvas.drawParagraph()` classes/methods only appear to support drawing text baselined on a straight line (and paragraph in particular is heavily geared to laying out potentially multi-line text in straight lines).

As linked above, Skia has a method for drawing text on a path, but that seems to fall outside of the text/paragraph painting model used by Flutter and I'm not entirely sure it'd be appropriate for Flutter's design - however, it seems like it would be fairly easy to implement if it could fit in with the design.

It would be nice to have the ability to apply various styles to the text along the path, if that can be done cheaply (I have some doubts that it could be done cheaplym and I could live without it).

This would help to support #1831 and possibly #15501
Repository: kubernetes
Issue: Realtime process inside container
Labels: sig/node,kind/feature,lifecycle/frozen

/kind feature


I want to run  RT process inside container as it is a requirement for my application. I am able to do this in docker/container using --cpu-rt-runtime=95000 --ulimit rtprio=99  but it doesn't work with k8s as I did not find a parameter to pass the same from YAML file.

**Environment**:
- Kubernetes version (use `kubectl version`):
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.1+2.0.2.el7"
- OS (e.g. from /etc/os-release):
Oracle Linux Server release 7.4
- Kernel (e.g. `uname -a`):
4.1.12-112.14.15.el7uek.x86_64 #2 SMP Thu Feb 8 09:58:19 PST 2018 x86_64 x86_64 x86_64 GNU/Linux
- Install tools:
- Others:
Repository: angular
Issue: Elements adds ng-version attribute to every Angular element on the page
Labels: type: bug/fix,freq3: high,area: server,area: elements,state: confirmed,P4

Currently every top-level custom element tag gets a ng-version attribute

Ex.
```
...
<my-element name="Hello World!!" ng-version="6.0.0-rc.1" >
  <div>Hello World!!</div>
</my-element>
...
```

For server side rendered custom elements this adds extra bytes for every custom element on the page.
Repository: rust
Issue: Comparison of Option<NonZeroU*> is not fully optimized
Labels: A-LLVM,I-slow,C-enhancement,T-compiler,WG-llvm,C-optimization

Compare:

```rust
#![feature(nonzero)]
use std::num::NonZeroU32;

pub fn f(a: Option<NonZeroU32>, b: Option<NonZeroU32>) -> bool {
    a < b
}
pub fn g(a: u32, b: u32) -> bool {
    a < b
}
```

The functions `f` and `g` have equivalent effect, and should compile to the same code. However, the translated `f` is much more complex, involving needless comparison of the discriminant.

<details><summary>LLVM IR and ASM (in release mode)</summary>

```llvm
; playground::f
; Function Attrs: norecurse nounwind readnone uwtable
define zeroext i1 @_ZN10playground1f17hd628eff49d2ff60dE(i32, i32) unnamed_addr #0 {
start:
  %2 = icmp ne i32 %0, 0
  %3 = icmp ne i32 %1, 0
  %4 = xor i1 %2, %3
  br i1 %4, label %bb7.i, label %bb6.i

bb6.i:                                            ; preds = %start
  %5 = icmp ult i32 %0, %1
  %spec.select = and i1 %2, %5
  ret i1 %spec.select

bb7.i:                                            ; preds = %start
  %6 = xor i1 %2, true
  %7 = and i1 %3, %6
  ret i1 %7
}

; playground::g
; Function Attrs: norecurse nounwind readnone uwtable
define zeroext i1 @_ZN10playground1g17hea1c394facd055aeE(i32 %a, i32 %b) unnamed_addr #0 {
start:
  %0 = icmp ult i32 %a, %b
  ret i1 %0
}
```

```asm
playground::f:
	test	edi, edi
	setne	al
	test	esi, esi
	setne	cl
	xor	cl, al
	je	.LBB0_1
	test	esi, esi
	setne	cl
	test	edi, edi
	sete	al
	and	al, cl
	ret

.LBB0_1:
	test	edi, edi
	setne	cl
	cmp	edi, esi
	setb	al
	and	al, cl
	ret

playground::g:
	cmp	edi, esi
	setb	al
	ret
```

</details>

Note that specializing `PartialOrd` etc for `Option<NonZero*>` is not a valid solution, since custom wrapper types of NonZero* will still have the same problem.

```rust
#[derive(PartialOrd, PartialEq)]
pub struct S(NonZeroU32);
pub fn f(a: Option<S>, b: Option<S>) -> bool {
    a < b
}
```

cc #49137.

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"veera-sivarajan"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
Repository: flutter
Issue: iOS double-tap reachability under Flutter
Labels: c: new feature,platform-ios,framework,a: accessibility,customer: mulligan (g3),P2,team-ios,triaged-ios

iOS has a reachability feature where you can double-tap the home button to shift the entire screen contents down within thumb reach: ![iOS reachability](https://i.stack.imgur.com/uygr9.jpg)

Under Flutter, the double-tapping works fine to shift the screen down, but unlike in other apps, the screen doesn't immediately shift back up once you tap to navigate within the app. Is there a way to push the screen back up when the Navigator changes routes?

I couldn't find any relevant Apple methods other than some private API in UIApplication https://github.com/nst/iOS-Runtime-Headers/blob/master/Frameworks/UIKit.framework/UIApplication.h#L323

Note that there does seem to be a timer which triggers the screen to shift up a few seconds following the last tap; however, in other apps the shift occurs immediately upon tapping/navigating to a different screen.
Repository: flutter
Issue: Flutter Doctor Error - SocketException: Write failed (OS Error: Broken pipe, errno = 32)
Labels: tool,t: flutter doctor,a: first hour,P2,team-tool,triaged-tool


I followed the "Get Started Tutorial" and when I run the ‘Flutter: New Project’ show this message:
```
$ flutter doctor -v
[✓] Flutter (Channel beta, v0.2.8, on Linux, locale en_US.UTF-8)
    • Flutter version 0.2.8 at /home/raulino/.development/flutter
    • Framework revision b397406561 (9 dias atrás), 2018-04-02 13:53:20 -0700
    • Engine revision c903c217a1
    • Dart version 2.0.0-dev.43.0.flutter-52afcba357

-Unhandled exception:
SocketException: Write failed (OS Error: Broken pipe, errno = 32), port = 0
#0      _rootHandleUncaughtError.<anonymous closure> (dart:async/zone.dart:1114)
#1      _microtaskLoop (dart:async/schedule_microtask.dart:41)
#2      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
#3      _Timer._runTimers (dart:isolate-patch/dart:isolate/timer_impl.dart:391)
#4      _Timer._handleMessage (dart:isolate-patch/dart:isolate/timer_impl.dart:416)
#5      _RawReceivePortImpl._handleMessage (dart:isolate-patch/dart:isolate/isolate_patch.dart:165)

```
Otherwise when I run the 'flutter doctor' in terminal runs normal like this:

```
$ flutter doctor -v
[✓] Flutter (Channel beta, v0.2.8, on Linux, locale pt_BR.UTF-8)
    • Flutter version 0.2.8 at /home/raulino/.development/flutter
    • Framework revision b397406561 (9 dias atrás), 2018-04-02 13:53:20 -0700
    • Engine revision c903c217a1
    • Dart version 2.0.0-dev.43.0.flutter-52afcba357

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /home/raulino/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • ANDROID_HOME = /home/raulino/Android/Sdk
    • Java binary at: /home/raulino/.development/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] Android Studio (version 3.1)
    • Android Studio at /home/raulino/.development/android-studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] VS Code (version 1.22.1)
    • VS Code at /usr/share/code
    • Dart Code extension version 2.11.2

[!] Connected devices
    ! No devices available

! Doctor found issues in 1 category.

```