sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: all: replace reflect.DeepEqual for error comparisons in test files
Labels: NeedsInvestigation

### Proposal Details

## Description

Currently, several test files across the codebase use `reflect.DeepEqual` to compare errors. This is not the recommended way to compare errors in Go, as it can be both inefficient and potentially fragile. We should replace these comparisons with proper error comparison methods.

## Affected Files

At least the following:

- `src/strconv/atof_test.go`
- `src/strconv/atoi_test.go`
- `src/errors/join_test.go`
- `src/fmt/errors_test.go`
- `src/net/iprawsock_test.go`
- `src/net/mac_test.go`
- `src/net/tcpsock_test.go`
- `src/net/udpsock_test.go`
- `src/encoding/asn1/asn1_test.go`
- `src/encoding/base64/base64_test.go`
- `src/go/build/build_test.go`

## Proposed Solution

Replace `reflect.DeepEqual` error comparisons with either:
1. Direct error string comparison using `err.Error()` for simple cases
2. Custom error comparison functions that handle nil cases and string comparison
3. Use of `errors.Is()` where appropriate

## Implementation Plan

The changes will be submitted as separate PRs grouped by package to make reviews more manageable.

Each PR will:
- Remove usage of `reflect.DeepEqual` for error comparisons
- Add appropriate error comparison functions where needed
- Maintain existing test coverage and functionality
- Include only the changes related to error comparison

## Benefits

- More idiomatic error comparison in tests
- More maintainable and clearer error comparison logic
Repository: PowerToys
Issue: Host File Editor - support for SSH client files
Labels: Needs-Triage

### Description of the new feature / enhancement

It would be nice if Host File Editor provides one-click editing of Windows' SSH client configuration files:
%USERPROFILE%\.ssh\known_hosts
%USERPROFILE%\.ssh\config

### Scenario when this would be used?

Embedded developers often change / reflash targets, which leads to change of SSH keys. Windows' ssh.exe just refuses to connect if the keys don't match. Editing these files requires either going thru CMD, or navigating to user' profile folder.

### Supporting information

_No response_
Repository: vscode
Issue: Gear Icon Recommended Update Resulted In Loss of All Extensions
Labels: info-needed


Type: <b>Bug</b>

Top-Right gear icon had blue subicon with a 1 .
Clicked and saw recommendation to restart to update.
Clicked to restart to update.
When restarting, all extensions were gone.

VS Code version: Code 1.96.2 (fabdb6a30b49f79a7aba0f2ad9df9b399473380f, 2024-12-19T10:22:47.216Z)
OS version: Darwin arm64 24.0.0
Modes:

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|Apple M2 Max (12 x 2400)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off|
|Load (avg)|1, 2, 2|
|Memory (System)|32.00GB (0.04GB free)|
|Process Argv|--crash-reporter-id fedf72f0-71db-42ab-97d2-e4f289d52194|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (4)</summary>

Extension|Author (truncated)|Version
---|---|---
codespaces|Git|1.17.3
debugpy|ms-|2024.14.0
python|ms-|2024.22.2
vscode-pylance|ms-|2024.12.1


</details><details>
<summary>A/B Experiments</summary>

```
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythonnoceb:30805159
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupytercf:31046870
nativerepl1:31139838
pythonrstrctxt:31112756
nativeloc1:31192215
cf971741:31144450
iacca1:31171482
notype1cf:31157160
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530
6074i472:31201624

```

</details>

<!-- generated by issue reporter -->
Repository: vscode
Issue: Command to install local workspace extension
Labels: feature-request,extensions

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
There are existing commands to install extension from either a given location or from a vsix file. However those commands install the extension globally. Currently there is an option to install extensions under .vscode/extensions in the local workspace without installing them globally, however it is currently only available through the UI. Please expose the command to install local workspace extensions.
Repository: PowerToys
Issue: Text Extractor Does NOT Recognize Single Letters or Simple 2-letter Words
Labels: Issue-Bug,Needs-Triage

### Microsoft PowerToys version

0.87.1

### Installation method

PowerToys auto-update

### Running as admin

Yes

### Area(s) with issue?

TextExtractor

### Steps to reproduce

1. Open any picture with words that have plenty of white space around them - ( I worked with https://www.nytimes.com/games/connections )
2. Ensure that the picture has single letters surrounded by white space ( e.g.       I        A   )
3. Ensure that the picture has 2-letter words surrounded by white space ( e.g.     IT       OF        IN         AT       )
4. Ensure that the picture has other larger words
5. Activate Text Extractor
6. Select all of the text for extraction
7. Paste into Notepad or other text based app
8. Notice that the single letter and or 2-letter words are completely missing
9. This seems to happen more with larger fonts. For example, if you copy the above samples in items 2 and 3, and paste them into a Word document, then enlarge the font (Calibri) to 36, you will see that using Text Extractor against that enlarged font will miss some of the letters (in particular "e.g." ) whereas the smaller font is better interpreted.

### ✔️ Expected Behavior

I was expecting single letter and 2-letter words to be recognized

### ❌ Actual Behavior

Single letter and or 2-letter words are completely missing from the extraction.

This is an issue that has happened for YEARS, which I would have expected someone would have reported by now.
If you can extract every letter of a word, then why can't you recognize individual letters or 2-letter words with the SAME letters in the SAME font????

### Other Software

N/A
Repository: flutter
Issue: [packages] Migrate package groupings to use workspaces
Labels: team,package,team-ecosystem,P3,triaged-ecosystem

Now that the [workspace](https://dart.dev/tools/pub/workspaces) feature is stable, it makes sense to start using it. Sub-groupings of packages in the packages repo should be migrated to workspaces.

This migration will enable the following benefits:
- Dependency overrides will no longer be necessary during development of package updates
- Only one pub get will be necessary per workspace
- More efficient code analysis

Justification:
- Other Google-owned packages have already been migrated. See [json_serializable](https://github.com/google/json_serializable.dart)

These are the groupings that should be consolidated into workspaces:
- [x] camera
- [x] file_selector
- [x] google_maps_flutter
- [x] google_sign_in
- [x] image_picker
- [x] in_app_purchase
- [x] local_auth
- [x] path_provider
- [x] pointer_interceptor
- [x] quick_actions
- [x] shared_preferences
- [x] url_launcher
- [x] video_player
- [x] webview_flutter
Repository: neovim
Issue: Inconsistent behavior of registers when clipboard provider not found
Labels: bug,clipboard

### Problem

When clipboard provider not found, trying to write to registers `"+` and `"*` shows error, but still this registers gets created and new content gets written to them. We can prove this by checking `:registers` output. But trying to paste from this registers results in pasting from `""`.

### Steps to reproduce

(`PATH=` used to avoid detecting clipboard provider. But better to also check manually that it is not set: `:checkhealth provider.clipboard`)

```
echo -e 'aaa\nbbb' | PATH= /bin/nvim --clean
"+yy
j
yy
"+p
:registers
```

At then end `:registers` shows that `"+` contains `aaa` but we clearly see that when we did `"+p`, it pasted content of `""`, not `"+`.

### Expected behavior

#### Solution 1

Make `"+` and `"*` registers act as any other named register if clipboard provider not found. So it will write and read registers without falling back to `""` as it does now.

#### Solution 2

Prevent creating (and writing to) registers `"+` and `"*` when clipboard provider not found. So, after `"+yy`, doing `"+p` should not paste anything.


### Nvim version (nvim -v)

v0.10.3

### Vim (not Nvim) behaves the same?

no, vim 9.1 (with +clipboard compiled feature)

### Operating system/version

archlinux

### Terminal name/version

kitty

### $TERM environment variable

xterm-kitty

### Installation

pacman
Repository: flutter
Issue: [tech debt] unify/simplify engine golden tests
Labels: engine,P3,c: tech-debt,team-engine,triaged-engine

We have two separately maintained golden test suites in the engine:

- Impeller goldens.
- Web engine goldens.

This reduces test coverage as some web cases are not covered by Impeller and vice versa. The barrier to adding new goldens is higher due to the bespoke nature of engine golden infra.

The vast majority (if not all) of these tests can be expressed as normal `flutter test` widget tests that just import `dart:ui` and use the framework's existing golden infra for taking and submitting goldens.

## Proposal

We unify as many engine goldens as possible by putting them all into one test suite that uses the framework golden infra. This is now possible with the monorepo. Ideally, we would be able to remove all the engine-specific golden infra.
Repository: next.js
Issue: Wrong page when navigating from pages router to app router
Labels: Navigation

### Link to the code that reproduces this issue

https://github.com/pomber/bug-pages-router-to-app-router

### To Reproduce

In this app:
```
web/
├─ pages/
│  ├─ index.js
│  └─ [...slug].js
└─ app/
   └─ [lang]/
      └─ page.js
```


1. `npm run dev`
2. from `localhost:3000` click the `Go to App router` link (`href="/hello"`)



### Current vs. Expected behavior

It renders `pages/[...slug].js` instead of rendering `app/[lang]/page.js`.

If instead we refresh the page with the same URL (`localhost:3000/hello`) it renders `app/[lang]/page.js` as expected.

### Provide environment information

```bash
Operating System:
  Platform: win32
  Arch: x64
  Version: Windows 11 Home
  Available memory (MB): 16254
  Available CPU cores: 8
Binaries:
  Node: 22.11.0
  npm: 10.9.0
  Yarn: 1.22.18
  pnpm: 9.7.1
Relevant Packages:
  next: 15.1.4 // Latest available version is detected (15.1.4).
  eslint-config-next: N/A
  react: 19.0.0
  react-dom: 19.0.0
  typescript: N/A
Next.js Config:
  output: N/A
```


### Which area(s) are affected? (Select all that apply)

Navigation

### Which stage(s) are affected? (Select all that apply)

next dev (local), next start (local)

### Additional context

_No response_
Repository: terminal
Issue: Autocomplete doesn't remove parenthesis before completing
Labels: Product-Cmd.exe,Issue-Bug,Needs-Tag-Fix,Priority-3,zInbox-Bug

### Windows Terminal version

_No response_

### Windows build number

_No response_

### Other Software

_No response_

### Steps to reproduce

https://github.com/user-attachments/assets/dbf4e89f-d673-48bd-8af6-d64d29fdec78

1. Create a folder starting with a (
2. Type `cd (`
3. Hit tab

### Expected Behavior

Autocompletes to `cd "<folder name>"`

### Actual Behavior

Autocompletes to `cd ("<folder name>"`
Repository: flutter
Issue: [in_app_purchase_storekit] StoreKit2 introductory pricing data is not available
Labels: platform-ios,p: in_app_purchase,package,P2,team-ios,triaged-ios

### Steps to reproduce

1. InAppPurchaseStoreKitPlatform.enableStoreKit2();
2. Configure introductory pricing in AppStore
3. After calling this code `final productDetailsResponse = await _inAppPurchase.queryProductDetails({productIds}); ` if we take a look at ProductDetails data from productDetailsResponse we can't see any 'introductory pricing' data. We only have `sk2Product.subscription?.promotionalOffers`.

This code does not retrieve introductory pricing offers
```
sk2Product.subscription?.promotionalOffers.firstWhereOrNull(
        (promotionalOffer) =>
            promotionalOffer.type == SK2SubscriptionOfferType.introductory,
      )
```
 We only see promotional offers with the current implementation.

The native IOS modal shows the introductory pricing amount but the code mentioned at the top used to show the in-app modal does not contain the introductory pricing data.

I'm using 
`in_app_purchase_storekit: ^0.3.20+3`

### Expected results

sk2Product.subscription should have an introductoryPricingOffers list

### Actual results

sk2Product.subscription does not provide an introductoryPricingOffers list

### Code sample

<details open><summary>Code sample</summary>

```dart
[Paste your code here]
```

</details>


### Screenshots or Video

<details open>
<summary>Screenshots / Video demonstration</summary>

[Upload media here]

</details>


### Logs

<details open><summary>Logs</summary>

```console
[Paste your logs here]
```

</details>


### Flutter Doctor output

<details open><summary>Doctor output</summary>

```console
[✓] Flutter (Channel stable, 3.27.1, on macOS 15.1.1 24B2091 darwin-arm64, locale en-AR)
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 16.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.96.2)
[✓] Connected device (5 available)
[✓] Network resources

• No issues found!
```

</details>
Repository: godot
Issue: Theme editor opens when saving a script in a external editor.
Labels: bug,topic:editor

### Tested versions

- Reproducible in: 4.3.stable

### System information

Godot v4.3.stable (77dcf97d8) - Arch Linux #1 SMP PREEMPT_DYNAMIC Thu, 02 Jan 2025 22:52:26 +0000 - Wayland - Vulkan (Forward+) - integrated Intel(R) HD Graphics 5500 (BDW GT2) - Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 Threads)

### Issue description

After saving a script in an external editor the theme editor will open, this does not happen with the built-in editor.  

### Steps to reproduce

- Create a custom theme for a Control node, and add a script to it;
- Open a script in an external editor and save it, the theme editor will open.

### Minimal reproduction project (MRP)

N/A
Repository: go
Issue: x/crypto/acme/autocert: Manager.GetCertificate should check host policy before consulting cache
Labels: Security,NeedsFix

Manager.GetCertificate doesn't check the host policy if the request is a challenge, probing the cache if there isn't an entry in the certTokens map. While cache probes _should_ be cheap, an attacker may exploit any latency introduced by these probes by forcing repeated cache misses.

This can be fixed by simply moving the host policy check above the cache probe, which is likely to be cheaper, if implemented, than a cache probe.

This is a [PUBLIC track](https://go.dev/security/policy#public) security issue, due to its minimal impact.

Thanks to Dimitri Stiliadis for reporting this issue.
Repository: flutter
Issue: Make it clear `Merge Queue Guard` is really building (required) engine artifacts to run the tests
Labels: team-infra,P2,monorepo

One issue that comes up frequently when discussing pain points of the mono-repo is the "merge queue is slow".

There are lots of different ways to discuss that, and some optimizations that could happen. 

_One_ concrete thing is a confusion (from at least me and @jmagman) that the `Merge Queue Guard` check, that runs on presubmit, is _part_ of the merge queue. From talking to @jtmcdole, what is _actually_ happening is we are building (local) engine artifacts (from source) so that we can actually run the presubmit.

We expect this to be fairly fast (i.e. RBE builds and what not).

It would be a nice qualify of life change to rename this to `Building Engine Artifacts` to reflect what is actually happening, and if that is a problem, we can discuss "Building Engine Artifacts is too slow" instead of merging (heh) this with the concept of the Merge Queue.

/cc @zanderso
Repository: ui
Issue: [bug]: Not able to resize icons inside buttons
Labels: bug

### Describe the bug

Because of this change: 
![image](https://github.com/user-attachments/assets/1d4e8312-f6a8-44f9-8a8a-ce9ebe976a9e)
I am not able to change the size of the icon inside the button

### Affected component/components

Button

### How to reproduce

```
Button variant="outline" className='text-white bg-red-400 rounded-full ' size={'icon'} >
                <HandIcon size={36} />
</Button>
```

### Codesandbox/StackBlitz link

_No response_

### Logs

_No response_

### System Info

```bash
Windows 11, Edge browser
```


### Before submitting

- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues
Repository: tauri
Issue: [bug] Cannot deploy to physical iOS device
Labels: type: bug,status: needs triage

### Describe the bug

When attempting to debug a Tauri app on a physical iOS device, the build fails with:
`error: exportArchive No signing certificate "iOS Distribution" found`

![image](https://github.com/user-attachments/assets/42c36529-7e2a-4b6c-961c-b336f8aac96e)


A development profile is installed with a valid certificate and the device UDID is included in the profile.
Debugging to the same device from a native Xcode project works without any issues.

### Reproduction

Clone the example app in the plugins-workspace [repository](https://github.com/tauri-apps/plugins-workspace).
Confirm the app builds/deploys using the CLI to an iOS simulator.
Change the bundle ID to match an installed development profile.

Run the following command:
`pnpm tauri ios dev`

### Expected behavior

App should build and deploy to the physical iOS device.

### Full `tauri info` output

```text
[✔] Environment
    - OS: Mac OS 15.2.0 arm64 (X64)
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.83.0 (90b35a623 2024-11-26)
    ✔ cargo: 1.83.0 (5ffbef321 2024-10-29)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-aarch64-apple-darwin (default)
    - node: 22.12.0
    - pnpm: 9.15.2
    - npm: 10.9.0

[-] Packages
    - tauri 🦀: 2.1.1
    - tauri-build 🦀: 2.0.3
    - wry 🦀: 0.47.2
    - tao 🦀: 0.30.8
    - @tauri-apps/api : 2.1.1 (outdated, latest: 2.2.0)
    - @tauri-apps/cli : 2.1.0 (outdated, latest: 2.2.1)
```


### Stack trace

_No response_

### Additional context

#10668
#11147
Repository: PowerToys
Issue: [Settings] Deep link into Settings for a PowerToys Run Plugin
Labels: Product-PowerToys Run,Needs-Triage,Run-Plugin

### Description of the new feature / enhancement

It is possible to deep link into settings for a specific utility:

https://github.com/microsoft/PowerToys/blob/5ef918750d384b76d4db3b82fde8942396c6f3d5/src/common/Common.UI/SettingsDeepLink.cs#L90

Or via:

```
PowerToys.exe --open-settings=<SettingsWindowName>
```

As a PowerToys Run community plugin author, it would be nice to be able to deep link directly in to the settings of a plugin.

For example with:

```
PowerToys.exe --open-settings=Run --plugin-id=CEA0FDFC6D3B4085823D60DC76F28855
```


### Scenario when this would be used?

A plugin could display a result to the user to open the Settings and edit the plugin configuration.

This would be useful for:
- A newly installed plugin that require configuration
- A plugin that is in an invalid configuration state
- A plugin that has a specific query for settings

If the plugin settings are opened, the plugin should be scrolled into position, expanded and focused:

![Image](https://github.com/user-attachments/assets/c2d4b532-f3a8-4ffc-a3f2-3e337fc9a580)


### Supporting information

I would like to use this feature here:

- https://github.com/hlaueriksson/Community.PowerToys.Run.Plugin.Install/blob/e6610898a773456e9805222535dfeb439e1fe447/src/Community.PowerToys.Run.Plugin.Install/Main.cs#L103
- https://github.com/hlaueriksson/Community.PowerToys.Run.Plugins/blob/fff45bb452dcf3c4c5b0bcf68022c9ab71b4f2de/src/Community.PowerToys.Run.Plugin.Twitch/Main.cs#L185
Repository: flutter
Issue: Consider increasing `runDartTest` parallelization past `2` cores
Labels: a: tests,team-infra,P3

In https://github.com/flutter/flutter/pull/161392, I remove the (now unused) `CPU` environment variable parsing.

For now, we'll continue to do what we did before - default to `2` concurrent tasks unless multi-core is explicitly disabled. At one point though this number was higher - we should experiment with trying `Platform.numberOfProcessors` (or some fraction of that number).
Repository: pytorch
Issue: c10/util/BFloat16-math.h has undefined behavior
Labels: module: build,triaged,module: core aten

### 🐛 Describe the bug

Per https://en.cppreference.com/w/cpp/language/extending_std:
> It is undefined behavior to add declarations or definitions to namespace std or to any namespace nested within std, with a few exceptions noted below.

The "exceptions noted below" do not seem to include what we're doing in [BFloat16-math.h](https://github.com/pytorch/pytorch/blob/main/c10/util/BFloat16-math.h), and specifically don't include adding overloads of functions that take program-defined types. 

This problem is currently "theoretical" in that I am not aware of practical issues resulting from this header at this time.

To fix this, we would need to at least put the functions in BFloat16-math.h into a namespace other than `std` (either `c10` or a new one, like say `c10_math`). Then, we could either:
- have callers do `using std::pow` and all the other cmath functions, and rely on [ADL](https://quuxplusone.github.io/blog/2019/04/26/what-is-adl/) to select the c10/c10_math version for half/BFloat16
- `using` all the std:: functions into our namespace (which IMO argues toward that namespace being a new one like `c10_math`).

### Versions

N/A

cc @malfet @seemethere @manuelcandales @SherlockNoMad @angelayi