sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: angular
Issue: Nested FormGroup with 3 or more levels may cause ExpressionChangedAfterItHasBeenCheckedError
Labels: type: bug/fix,freq2: medium,area: forms,state: confirmed,P3

<!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.

ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->

## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>

## Current behavior
I have a nested FormGroup set up in the structure below:

```
formGroup1 : FormGroup {
   control1: FormControl;
   formGroup2: FormGroup {
      control2: FormControl;
      formGroup3: FormGroup {
         control3: FormControl;
      }
   }
}
```

If formGroup1 and formGroup2 are valid, and formGroup3 is invalid by default, an ExpressionChangedAfterItHasBeenCheckedError is thrown.

However, if formGroup2 is invalid, there are no errors.

## Expected behavior
The nested form should be invalid with no errors.


## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).
-->
Please see below Plunker for more details:
https://plnkr.co/edit/Pz4js1r6TzSv3LgEsYW5

## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->
Making nested formGroups work.

## Environment

<pre><code>
Angular version: 5.2.6
<!-- Check whether this is still an issue in the most recent Angular version -->

Browser:
All
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  <!-- run `node --version` -->
- Platform:  <!-- Mac, Linux, Windows --> All

Others:
<!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->
</code></pre>
Repository: rust
Issue: libtest: utilize jobserver
Labels: T-libs-api,C-feature-request,A-libtest

Tests are normally CPU consuming tasks, and we can transparently utilize jobserver to achieve efficient core utilization.

Some usecases I can think of:

- Tests which may spawn threads (including rustc `codegen-units`, but not limited to)
- Using a parent make somewhere
Repository: rust
Issue: Extend `rustc_on_unimplemented` to query for closures
Labels: C-enhancement,A-diagnostics,A-closures,T-compiler

Add a filter to `rustc_on_unimplemented` to allow the querying for [the existence of a closure in the requirement chain](https://github.com/rust-lang/rust/pull/48138/files#r169475454). This should allow handling #24909 and #33307 by providing a specific message recommending marking the closure as `move`.
Repository: rust
Issue: 🔬 implement "always applicable impls"
Labels: C-enhancement,A-trait-system,T-compiler,A-specialization,F-specialization,T-types,S-types-deferred

Part of https://github.com/rust-lang/rust/issues/31844: In order to eventually stabilize specialization, we need to make it sound. The current plan for doing so is called "always applicable impls", and is explained [in this blog post](http://smallcultfollowing.com/babysteps/blog/2018/02/09/maximally-minimal-specialization-always-applicable-impls/). This issue exists to track the implementation of that proposal.

This does not yet have any mentoring instructions. Ping me if you are interested though and we can talk it over! Or maybe I'll get to it before then.
Repository: go
Issue: testing: start test log for caching before TestMain
Labels: NeedsDecision

### What version of Go are you using (`go version`)?
`go version go1.10 windows/amd64`

### Does this issue reproduce with the latest release?
Yes

### What operating system and processor architecture are you using (`go env`)?
```
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\ben\AppData\Local\go-build
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\ben\dev\go
set GORACE=
set GOROOT=C:\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\ben\AppData\Local\Temp\go-build167965298=/tmp/go-build -gno-record-gcc-switches
```

### What did you do?
1. Create a `test_something.go` file whose tests require a `main_test.go` file for setup/teardown
2. Create several tests in `test_something.go`
2. Run all of the tests
3. Observe that the code in `main_test` is executed
4. Change a non-go file that the test depends on


### What did you expect to see?
`main_test` is executed again and a cache miss occurs.

### What did you see instead?
`main_test` is not executed again and a cache hit occurs. See https://github.com/bakatz/golangissue21422 for more info.
Repository: pytorch
Issue: scatter_add_ should support scalar source (including Python scalar)
Labels: triaged,module: scatter & gather ops

I was looking to use `scatter_add_` to do `bincount`.
```python
import torch
a = torch.LongTensor([2, 0, 3, 3])
r = torch.LongTensor(5)

# works
r.zero_().scatter_(0, a, 1)
# 1
# 0
# 1
# 1
# 0
# [torch.LongTensor of size 5]

# scalar source doesn't work
r.zero_().scatter_add_(0, a, 1)
#Traceback (most recent call last):
#  File "<stdin>", line 1, in <module>
#TypeError: scatter_add_ received an invalid combination of arguments - got (int, torch.LongTensor, int), #but expected (int dim, torch.LongTensor index, torch.LongTensor src)

# no broadcasting? but no checking for memory bounds either?
r.zero_().scatter_add_(0, a, torch.LongTensor([1]))
#1.4033e+14
# 0.0000e+00
# 1.0000e+00
# 5.4931e+18
# 0.0000e+00
# [torch.LongTensor of size 5]

# works ok
r.zero_().scatter_add_(0, a, torch.LongTensor([1]).expand_as(a))
# 1
# 0
# 1
# 2
# 0
# [torch.LongTensor of size 5]

```
at `0.4.0a0+1fdb392`


cc @mikaylagawarecki
Repository: angular
Issue: Invalid return type of "DebugElement.query"
Labels: type: bug/fix,area: testing,freq2: medium,state: confirmed,cross-cutting: types,P4

## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
</code></pre>

## Current behavior
[`DebugElement.query` declares `DebugElement` as the return type](https://github.com/angular/angular/blob/master/packages/core/src/debug/debug_node.ts#L108).

## Expected behavior
`DebugElement.query` declares `DebugElement | null` as the return type.

## Minimal reproduction of the problem with instructions
```
let debugElement: DebugElement = ...;
let el = debugElement.query(By.CSS('not existent')).nativeElement;  // explodes
```

## What is the motivation / use case for changing the behavior?
The result of `DebugElement.query` [can actually be `null`](https://github.com/angular/angular/blob/master/packages/core/src/debug/debug_node.ts#L110).

The error should be caught by the compiler since the programmer should assert that the element was found. This is especially true for `By.CSS` predicate as it seems that the likelihood of typos and mistakes is pretty high.

The reason why [this compiles without errors](https://github.com/angular/angular/blob/master/packages/core/src/debug/debug_node.ts#L110) is that the return type of array indexing is `T`, not `T | undefined`. This seems to be the [intended behaviour of the TypeScript compiler](https://github.com/Microsoft/TypeScript/issues/13778).

## Environment
<pre><code>Angular version: latest
Browser: all
</code></pre>
Repository: vue
Issue: Use better types to model prop type
Labels: typescript

### Version
2.5.13

### Reproduction link
[https://github.com/zsky/vue-date-type-issue](https://github.com/zsky/vue-date-type-issue)

### Steps to reproduce
```
npm i
npm run build
```

### What is expected?
No typescript error

### What is actually happening?
Typescript report error: Property 'getTime' does not exist on type 'string'

***
I use vue with typescript, I want to set a component prop type as Date, so I do this:
```typescript
Vue.extend({
  props: { start: Date },
  created() { 
     this.start;  // Expect type Date, but String
  }
});
```

Then I find something could be userful:
In options.d.ts,
```typescript
export type Prop<T> = { (): T } | { new (...args: any[]): T & object }
```
Make a simple test:
```typescript
function test<T>(opts: { p1: Prop<T> }): T {
    return {} as T;
}
let result = test({ p1: Date });  // Expect type Date, but String
```
But I still don't know how to solve it, thanks for any suggestion.

<!-- generated by vue-issues. DO NOT REMOVE -->
Repository: go
Issue: runtime/race: simplify meta shadow mapping
Labels: RaceDetector,help wanted,NeedsFix,compiler/runtime

Currently, the race detector runtime for Go assumes that the heap is contiguous and grows up. In particular, [`MapShadow`](https://github.com/llvm-mirror/compiler-rt/blob/5551897294887d632c71275cf11c5654fd80cda7/lib/tsan/rtl/tsan_rtl.cc#L242) always maps the meta shadow contiguously. According to @dvyukov's [comment](https://github.com/golang/go/issues/23900#issuecomment-367410078), this was done to deal with the fact that the Go heap grew irregularly and the meta shadow mapping has large alignment constraints.

As of 2b415549, the Go heap is no longer contiguous and doesn't necessarily grow up. However, it also now grows in large, aligned blocks (as of 78846472, 4MB on Windows, 64MB elsewhere). This easily satisfies the alignment constraints on the meta shadow. Hence, the meta shadow mapping code can be simplified to take advantage of this while at the same time adding support for Go's new sparse heap layout.
Repository: go
Issue: regexp/syntax: add examples for flag parsing
Labels: Documentation,help wanted,NeedsInvestigation

Reading the description of grouping and flags, I'm confused about how those flags would apply to theoretical strings. An example or two would be good to demonstrate the use and placement of flags, as well as the resulting capture groups.
Repository: go
Issue: net/http: make default configs have better timeouts
Labels: NeedsInvestigation

See https://github.com/golang/go/issues/23459.

Client, Server, and Transport may all have timeout fields in which zero = infinity. Instead it should be a reasonable default.
Repository: go
Issue: x/review/git-codereview: do not mail CLs with editor temp files, binaries
Labels: help wanted,NeedsFix

Motivated by #23800, git-codereview should probably refuse to mail CLs with editor temp files and binaries.
Repository: godot
Issue: Allow drag and dropping audio effects on an audio bus
Labels: enhancement,topic:editor,usability

**Godot version:** 3

It would be convenient to be able to drag and drop a saved AudioEffect file on top of an audio bus to add the effect to it, see: 
![audioeffect](https://user-images.githubusercontent.com/35355161/36702001-5f271172-1b23-11e8-8db4-dbfaf9e0eda0.png)

I haven't found a way to add a saved effect to the bus layout using the editor, so drag and dropping would be the most intuitive way to add this functionality.
Repository: flutter
Issue: SliverGeometry documentation needs a diagram or an example
Labels: framework,f: scrolling,d: api docs,P2,team-framework,triaged-framework

Hard to visualize all the various fields but can likely be easily explained with a picture.
Repository: opencv
Issue: a bug in cuda detectMultiScale
Labels: feature,category: gpu/cuda (contrib)

##### System information (version)
<!-- Example
- OpenCV => 3.4
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->

##### Detailed description

https://github.com/opencv/opencv/blob/cfe84b953cd4218df88144e1d58c2580540c6972/modules/cudaobjdetect/src/cascadeclassifier.cpp

an assertion bug in line 179

##### Steps to reproduce

![image](https://user-images.githubusercontent.com/6119906/36736025-8ed0a280-1ba5-11e8-81c2-5b67c497a4da.png)
Repository: vscode
Issue: Allow extensions to add coloured markers in the gutter similar to source control
Labels: feature-request,api,editor-api

The source control functionality currently renders nice coloured markers down the gutter. It'd be nice if this functionality was available to extensions that aren't source control (for example code coverage).
Repository: vscode
Issue: [razor] comment out razor code with @* *@
Labels: feature-request,languages-basic,editor-comments

Issue Type: <b>Bug</b>

1. Edit a cshtml file
2. Select html code to comment out
3. Use comment out keymap (CTRL K + C)

Expected Behavior: 
Proper comment is used based on syntax

Select Html only line should use `<!-- -->`
Select Razor should use `@* *@`

Actual Behavior:
After comment out keymap is pressed, the selected area has // at beginning of each line. 
https://www.screencast.com/t/mxAOaHv7qV


VS Code version: Code - Insiders 1.21.0-insider (1a84a882737184488d965426747a05474f54a759, 2018-02-27T09:01:48.555Z)
OS version: Windows_NT x64 10.0.16299

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-4700MQ CPU @ 2.40GHz (8 x 2394)|
|Memory (System)|15.88GB (3.92GB free)|
|Process Argv|C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe|
|Screen Reader|no|
|VM|0%|

</details><details><summary>Extensions (8)</summary>

Extension|Author (truncated)|Version
---|---|---
gitlens|eam|8.0.2
mssql|ms-|1.3.0
python|ms-|2018.1.0
csharp|ms-|1.14.0
PowerShell|ms-|1.6.0
vs-keybindings|ms-|0.1.7
team|ms-|1.122.0
vscode-icons|rob|7.20.0


</details>
Reproduces only with extensions
<!-- generated by issue reporter -->
Repository: pytorch
Issue: Gaussian Sampling
Labels: feature,module: nn,triaged

In the release phase of the code of our article : Deep Learning for Physical Processes: Incorporating Prior Scientific Knowledge ( https://openreview.net/pdf?id=By4HsfWAZ ) we have implemented a Gaussian grid sampling scheme :  
https://github.com/pajotarthur/pytorch/blob/master/aten/src/THNN/generic/SpatialGridSamplerGaussian.c
https://github.com/pajotarthur/pytorch/blob/master/aten/src/THCUNN/SpatialGridSamplerGaussian.cu

Does it make sense to add it to the main pytorch repo ? 

cc @albanD @mruberry
Repository: flutter
Issue: Calendar, and Datepicker does not support Jalali Calendar
Labels: c: new feature,framework,f: material design,f: date/time picker,a: internationalization,customer: crowd,P3,team-design,triaged-design

Hello and good day

Recently I'm using Flutter, and unfortunately I cannot use its calendar and **date picker**, the problem is clear, it does not support **Persian Calendar**

How can I use Persian calendar?

Do you have any plan to support **Persian Jalali Calendar**?
Repository: TypeScript
Issue: Improve error when parameter is missing a name
Labels: Suggestion,Help Wanted,Domain: Error Messages

**TypeScript Version:**  2.8.0-dev.20180227
**Code**

```ts
declare class C {
    f({ x?: number }): void;
    g(): void;
}
```

**Expected behavior:**

At the `?`, `property in destructuring may not be marked optional`.

**Actual behavior:**

```
src/a.ts(2,10): error TS1005: ',' expected.
src/a.ts(2,20): error TS1005: ',' expected.
src/a.ts(2,21): error TS1128: Declaration or statement expected.
src/a.ts(2,22): error TS1128: Declaration or statement expected.
src/a.ts(2,28): error TS1109: Expression expected.
src/a.ts(3,8): error TS1005: ';' expected.
src/a.ts(3,14): error TS1109: Expression expected.
src/a.ts(4,1): error TS1128: Declaration or statement expected.
```
Repository: go
Issue: crypto/x509: ensure CreateCertificate won't generate unparsable certificates
Labels: Testing,help wanted,NeedsFix

CreateCertificate should return an error instead of generating a certificate that will fail ParseCertificate. We should check that's the case and maybe test or enforce this.

See #23995.
Repository: kubernetes
Issue: Missing validation in HPA
Labels: kind/bug,priority/important-soon,sig/autoscaling,lifecycle/rotten


**Is this a BUG REPORT or FEATURE REQUEST?**:

> Uncomment only one, leave it on its own line: 
>
/kind bug
> /kind feature


**What happened**:
It looks like validation of HPA is insufficient:
- metric name in pods and object metrics should be checked using IsValidPathSegmentName as they're used as part of request to custom metrics API (this is analogous to https://github.com/kubernetes/kubernetes/pull/60433).
- ValidateCrossVersionObjectReference allows for empty apiVersion, leading to non-functional HPA.
Repository: TypeScript
Issue: Support find-all-references for module.exports
Labels: Suggestion,In Discussion

**Code**

```ts
/// <reference path='fourslash.ts' />

// @allowJs: true

// @Filename: /a.js
////module.exports = 0;

// @Filename: /b.js
////const [|a|] = require("./a");

verify.noErrors();
const [r0] = test.ranges();
verify.referenceGroups(r0, []);
```

This would involve modifying `importTracker` to support `module.exports =` and `const x = require("...")` better.
Repository: rust
Issue: Document minimum size for `usize` and `isize`
Labels: P-medium,T-lang,A-docs,C-feature-request,WG-embedded

Right now, `usize` and `isize` are "guaranteed" to be at least a byte long, but nothing more. It seems unlikely that Rust will support 8-bit targets in the future, but this is what the `TryFrom` implementations indicate.

A lot of people assume that `usize` will be at least 32 bits but this is not true for all platforms. I think that the docs should be clarified to make people more aware of this behaviour.
Repository: go
Issue: proposal: crypto/rand: guard against mutation of Reader variable
Labels: v2,Proposal

`crypto/rand` exposes an `io.Reader` variable `Reader` as "a global, shared instance of a cryptographically strong pseudo-random generator." Furthermore, `crypto/rand.Read` implicitly uses `Reader` for its crypto source.

This seems problematic to me because then any package can just overwrite `crypto/rand.Reader` to point to some other object, affecting the security of any packages that rely on `crypto/rand.Read` or `crypto/rand.Reader` for security, e.g. `x/crypto/nacl`.

One can say that a language can never ultimately defend against code running in your same process, but I think it should be possible to write something that depends on `crypto/rand` for security that wouldn't require auditing other packages for a single malicious variable write.[1]

The main API flaw here, IMO, is that `Reader` is an `io.Reader` variable, whereas it should be a function that returns an `io.Reader`. A new API would look something like:

```
// Reader returns an io.Reader that reads from a cryptographically strong pseudo-random number generator.
func Reader() io.Reader

// Read is a helper function that calls Reader() and then passes it to io.ReadFull. 
func Read(b []byte) (n int, err error)
```

Alas, with the Go 1 compatibility guarantee `Reader` would have to remain, and `Read` would still have to use `Reader`. But the above could be added as new functions, say `MakeReader()` and `SafeRead()`. And the standard library (and other important external packages like `x/crypto/nacl`) could be changed to use those safe functions.

[1] Without this flaw, a malicious package would have to use the unsafe package to poke around in the internals of `crypto/rand`, or call out to the external OS to e.g. try to redirect access to the random device, which seems easier to audit for than a write to `crypto/rand.Reader`. Of course, I'm already assuming that a project worried about this is vendoring all of its dependencies.
Repository: TypeScript
Issue: Type guards not working for indexed types with generics
Labels: Bug

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  2.7

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** indexed type guard

**Code**

```ts
function f<T extends string>(q: {[k:string]: number | string}, t: T) {
    const v= q[t];
    if (typeof(v)!=="string") {
        const vv: number = v;
    }
}
```

**Expected behavior:**
Type of `v` is `string|number`, and in the `if` it is just number. Compiles.

**Actual behavior:**
Assignment to `vv` doesn't compile: string not assignable to number. When hovering, type of `v` is `{ [k: string]: string | number; }[T]`, so eliminating string from it does not change the type, it is still the same, and only when assigning to `vv` it gets resolved to `string|number` which then causes compilation error.

Changing type of `t` to string fixes the problem. The problem also appears if `q` has type keyed by `[k in T]`.

**Playground Link:** [link](https://www.typescriptlang.org/play/index.html#src=function%20f%3CT%20extends%20string%3E(q%3A%20%7B%5Bk%3Astring%5D%3A%20number%20%7C%20string%7D%2C%20t%3A%20T)%20%7B%0D%0A%20%20%20%20const%20v%3D%20q%5Bt%5D%3B%0D%0A%20%20%20%20if%20(typeof(v)!%3D%3D%22string%22)%20%7B%0D%0A%20%20%20%20%20%20%20%20const%20vv%3A%20number%20%3D%20v%3B%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A)

**Related Issues:**
Repository: vscode
Issue: Feature request: Add support for modifier keys like right ctrl and right alt
Labels: feature-request,editor-core

### Issue Type
Feature Request

### Description

Currently VS Code treats left and right modifier keys as the same one (<kbd>ctrl</kbd>, <kbd>alt</kbd> and <kbd>shift</kbd>).

I want to define different keyboard shortcuts for left and right modifier keys (e.g. <kbd>left ctrl</kbd> + <kbd>s</kbd> for saving files, and <kbd>right ctrl</kbd> + <kbd>s</kbd> for something else), but unfortunately this cannot be done.

### VS Code Info

VS Code version: Code 1.20.0 (c63189deaa8e620f650cc28792b8f5f3363f2c5b, 2018-02-07T17:10:15.949Z)
OS version: Linux x64 4.14.16-300.fc27.x86_64
Repository: vscode
Issue: Provide activation reason to extensions in activate call
Labels: feature-request,api

It would be useful to know if the extension is being activated due to a command (in my case I want to a show a more specific message if the extension fails to activate due to a missing SDK, and the command gives me more context to tailor this message to the user).