sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: x/build/cmd/gopherbot: when closing backport issues, ignores "Fixes" vs "For"/"Updates" verb before issue mention
Labels: Builders,NeedsFix

Gopherbot closes backport issues once it detects that an associated commit has been merged. This works well if the backport only requires one commit, but causes issues when there are multiple. Gopherbot should only close the issue if the "Fixes #" label exists in the commit message.

See #29565 for an example of Gopherbot in action.

One possible solution would be to add a new field to the [GerritCL](https://godoc.org/golang.org/x/build/maintner#GerritCL) type that indicates whether or not this CL "fixes" the issue, or just updates/relates to it.

@golang/osp-team
Repository: TypeScript
Issue: Option to disable decorator transform
Labels: Suggestion,Awaiting More Feedback

## Search Terms

decorator output

<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->

## Suggestion

Decorators are always transformed. In some cases we critically need to preserve decorators in the output to feed into other tools, such as Babel.

All the other issues around this are closed, so I can't see what the plan is here. Adding a new flag to disable decorator transformation should be forward and backward compatible with any other implementation of decorators, old or new proposal.

## Use Cases

- Use Babel 7 decorator support to compile the current decorator proposal
- Feed tsc output into other analysis tools that expect decorators in JS source.

## Examples

<!-- Show how this would be used and what the behavior would be -->

## Checklist

My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Repository: rust
Issue: `&mut &T` coerced to `&T` suggests `&mut mut x`
Labels: T-compiler,A-NLL,A-suggestion-diagnostics,D-confusing

This code ([play](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=6c08c4287f618e5377a8443c41982863)):

```rust
struct X;
impl X {
    fn mutate(&mut self) {}
}

fn main() {
    let term = Some(X);
    let term = match &term {
        Some(term) => &mut term,
        None => term.as_ref().unwrap(),
    };
    term.mutate();
}
```

Produces these errors:
```
error[E0596]: cannot borrow `term` as mutable, as it is not declared as mutable
 --> src/main.rs:9:23
  |
9 |         Some(term) => &mut term,
  |                       ^^^^^^^^^
  |                       |
  |                       cannot borrow as mutable
  |                       try removing `&mut` here

error[E0596]: cannot borrow `*term` as mutable, as it is behind a `&` reference
  --> src/main.rs:12:5
   |
9  |         Some(term) => &mut term,
   |                       --------- help: consider changing this to be a mutable reference: `&mut mut term`
...
12 |     term.mutate();
   |     ^^^^ `term` is a `&` reference, so the data it refers to cannot be borrowed as mutable

error: aborting due to 2 previous errors
```

Note that the second error suggests changing `&mut term` to `&mut mut term`, which obviously won't fix the issue.
Repository: neovim
Issue: sockconnect: add support for connecting to FIFO
Labels: enhancement,channels-rpc

<!-- Before reporting: search existing issues and check the FAQ. -->

- `nvim --version`: 0.3.2
- Vim (version: ) behaves differently? N/A
- Operating system/version: macOS 10.13.6
- Terminal name/version: Kitty 0.13.2
- `$TERM`: screen-256color

### Steps to reproduce using `nvim -u NORC`

1) `mkfifo /tmp/myfifo`
2) Open `nvim -u NORC test.vim` and save the buffer
3) Copy the following script and the source the buffer

```vim
function! s:OnData(id, data, event)
    echo join(a:data, '\n')
endfunction

let id = sockconnect('pipe', '/tmp/myfifo', { 'on_data': function('s:OnData') })
```

The pipe works as expected when running the following from a shell.

```shell
echo "hello" > /tmp/myfifo &
cat /tmp/myfifo
```

### Actual behaviour

Neovim throws this error: `connection failed: connection refused`

### Expected behaviour

Be able to connect to the named pipe.
Repository: pytorch
Issue: Possible regression in incremental build
Labels: module: build,triaged

## 🐛 Bug

Running `python setup.py rebuild develop` constantly re-installs PyTorch. This regresses the time of our no-op build. I just noticed this today. It might be a regression.

## To Reproduce
Directly run ninja install in the build directory. Observe it always thinks something is dirty:

```
(base) [zdevito@devgpu172.prn2 /data/users/zdevito/pytorch] cd build
(base) [zdevito@devgpu172.prn2 /data/users/zdevito/pytorch/build] ninja install
[0/1] Install the project...
-- Install configuration: "RelWithDebInfo"
(base) [zdevito@devgpu172.prn2 /data/users/zdevito/pytorch/build] ninja install
[0/1] Install the project...
-- Install configuration: "RelWithDebInfo"
(base) [zdevito@devgpu172.prn2 /data/users/zdevito/pytorch/build] ninja -d explain install
ninja explain: output CMakeFiles/install.util doesn't exist
ninja explain: CMakeFiles/install.util is dirty
[0/1] Install the project...
-- Install configuration: "RelWithDebInfo"
```

cc @malfet @seemethere @walterddr
Repository: scrcpy
Issue: Any ability to send, e.g., ctrl+c as key entry?
Labels: feature request

First, this is awesome; thanks for your contribution. I use Termux (terminal emulator and linux app). Is there a way to send control key combinations as keystrokes? E.g., so I can ctrl+C to kill a program from the command line in Termux?

Thanks again.
Repository: pytorch
Issue: No test coverage for kwargs of AvgPool2d and AvgPool3d
Labels: module: bootcamp,module: nn,triaged,module: pooling

`ceil_mode` and `count_include_pad` are not tested at all.

cc @albanD @mruberry
Repository: pytorch
Issue: AvgPool2d doesn't test if kernel is smaller than input size
Labels: module: bootcamp,module: error checking,triaged,better-engineering,module: pooling

AvgPool3d is OK

```
>>> import torch
>>> m = torch.nn.AvgPool2d(3)
>>> x = torch.zeros(1,2,2)
>>> m(x)
tensor([[[0.]]])
>>> m = torch.nn.AvgPool3d(3)
>>> x = torch.zeros(1,2,2,2)
>>> m(x)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/ezyang/Dev/pytorch-tmp/torch/nn/modules/module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "/Users/ezyang/Dev/pytorch-tmp/torch/nn/modules/pooling.py", line 638, in forward
    self.padding, self.ceil_mode, self.count_include_pad)
RuntimeError: invalid argument 2: input image (T: 2 H: 2 W: 2) smaller than kernel size (kT: 3 kH: 3 kW: 3) at ../aten/src/THNN/generic/VolumetricAveragePooling.c:58
```
Repository: pytorch
Issue: computing  entropy of a tensor 
Labels: high priority,triaged,function request

I think it is very useful if we can have feature enhancement that we can compute the entropy of a tensor, the similar way that we can do it for mean, std, etc


in more details:
It would be super useful to have a function that compute the entropy of a tensor. well, saying that, it is good if that function can compute the entropy in different ways depending on our desire; meaning that we can define a dimension and compute the entropy based on that, e.g. computiong the entropy of a tensor channel wise, or etc

This request was first made [Here](https://github.com/pytorch/vision/issues/662#issuecomment-442036469) and then [here](https://github.com/pytorch/contrib/issues/16), but I am told that it will be more useful to open it here

cc @ezyang @gchanan @zou3519 @bdhirsh @jbschlosser
Repository: go
Issue: gccgo: incorrect call stack from runtime.CallersFrames
Labels: NeedsInvestigation

Stack traces are not quite right for gccgo with optimizations on (mid-stack inlining, particularly).

```
package main

import (
	"fmt"
	"runtime"
)

func main() {
	f()
}
func f() {
	g()
}

//go:noinline
func g() {
	for i := 0; i < 4; i++ {
		var pcs [1]uintptr
		runtime.Callers(i+1, pcs[:])
		f, _ := runtime.CallersFrames(pcs[:]).Next()
		fmt.Printf("%x %s %s:%d\n", f.PC, f.Function, f.File, f.Line)
	}
}
```
Running under gc, I get:
```
48683c main.g /usr/local/google/home/khr/gowork/tmp5.go:19
48678f main.f /usr/local/google/home/khr/gowork/tmp5.go:12
48675f main.main /usr/local/google/home/khr/gowork/tmp5.go:9
428846 runtime.main /usr/local/google/home/khr/go1.11/src/runtime/proc.go:201
```
Running under gccgo -O3, I get:
```
56261c5ebc19 main.g /usr/local/google/home/khr/gowork/tmp5.go:19
56261c5ebeb3 main.f /usr/local/google/home/khr/gowork/tmp5.go:12
56261c5ebeb3 main.f /usr/local/google/home/khr/gowork/tmp5.go:12
7f9974ede51c runtime_main ../../../src/libgo/runtime/proc.c:606
```
Note the third line - that should be `main.main`, not a second copy of `main.f`.
gccgo works without -O3.

Mid-stack inlining is happening with -O3, `main.main` calls `main.g` directly. `main.f` isn't even in the binary.

It doesn't help to provide `runtime.Callers` a larger buffer.

Note that this code does work, calling `runtime.Callers` just once and using the `runtime.CallersFrames` iterator:
```
package main

import (
	"fmt"
	"runtime"
)

func main() {
	f()
}
func f() {
	g()
}

//go:noinline
func g() {
	var pcs [10]uintptr
	n := runtime.Callers(1, pcs[:])
	iter := runtime.CallersFrames(pcs[:n])
	for {
		f, more := iter.Next()
		fmt.Printf("%x %s %s:%d\n", f.PC, f.Function, f.File, f.Line)
		if !more {
			break
		}
	}
}
```
```
55bb3972acd4 main.g /usr/local/google/home/khr/gowork/tmp6.go:18
55bb3972afc3 main.f /usr/local/google/home/khr/gowork/tmp6.go:12
55bb3972afc3 main.main /usr/local/google/home/khr/gowork/tmp6.go:9
7fa2706d451c runtime_main ../../../src/libgo/runtime/proc.c:606
```
@ianlancetaylor
Repository: vscode
Issue: Allow more powerful onEnterRules for cursor alignment
Labels: feature-request,editor-input,editor-autoindent

In the Python extension, we'd like to add support for variable-length indents on enter to better support PEP8 formatting (Microsoft/vscode-python#481 and others). For example:

```python
def func(a,
         |
```

Hitting enter on the first line should stick the cursor where `|` is, not just a single indent. In this second case, it should do a single indent:

```python
def func(
    |
```

There appears to only be two ways to handle this:

- `onEnterRules`
- On-type formatting

We'd like to avoid the latter, as we currently support both Jedi and our own language server, which means implementing on-type formatting in two different places (since a single language cannot have multiple on-type formatting providers). Plus, on-type formatting is not enabled by default nor is very popular (and enables a slew of formatting rules other than cursor alignment), so forcing users to enable on-type formatting as a whole would be good to avoid.

The other candidate is `onEnterRules`, but it's not powerful enough to be able to do something like this, as:

- The "actions" work in terms of indents, whereas these cursor positions may not be a round multiple of an indent, meaning `appendText` would be required, but...
- `appendText` is only allowed to be a static string, and cannot be generated on the fly.
- Rules are applied using regex to deduce context, which gets unweildy, and even more difficult without #50952.
- Even with something like #17281, there wouldn't be a way to convert a capture group to "whitespace of the same length of the capture group" (plus the issue of tab indents).


My initial thought was to allow a function to be provided in `onEnterRules` instead of just specifying `appendText`. For example, something like:

```ts
{
    beforeText: /\s+def\s+\w+\(\w+/,  /* not the real regex */
    action: {
        indentAction: IndentAction.None,
        appendText: (document, position, formatOptions, ... /* something */) => calculateIndent(...) // returns a string
    }
}
```

However, on closer inspection of how `onEnterRules` works, it appears that it needs to be serializable, so I'm not sure it'd be able to have a callback like the above.

Is there something that can be added to allow more powerful rules on-enter? Or, is there something that already exists that we've missed?
Repository: godot
Issue: Issues with new Polygon2D UV Editor features
Labels: bug,enhancement,topic:editor,confirmed

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
 e46f28e


**Issue description:**
@reduz
- The new internal vertex feature seems unintuitive, at least to me.
- When a internal vertex is present, the polygon editor in the 2D editor will treat the polygon as having no points.
- 
You can't undo internal vertex creation, or custom polygon removal via UndoRedo.
 Fixed by #24899.
- 
The lines of the actual polygon are hidden when any custom polygon is present.
 Fixed by 7f69da488e971b035fbdf044536db1ce9a100d50.
- Polygon creation with 
either internal vertexes or
 custom polygons present is buggy. Partially fixed by 96445cd.
Repository: pytorch
Issue: DataLoader with option to re-use worker processes
Labels: high priority,feature,module: dataloader,triaged

## 🚀 Feature
Currently after an epoch is ended dataloader spawns a new process to read data. This means if processes have cached some internal state (db connection, indexing, ...) they will be lost and the new process will have the overhead of creating the connection or indexing.

## Motivation

I have a custom dataset (that indexes data for fast retrieval) and only part of the dataset is used in training. If I have a training with longer epochs, training will be faster than shorter epochs because when an epoch ends a new process will have to re-read and index the custom dataset.

## Pitch

A flag to tell dataloader to re-use the worker processes. If the process pool has the re-use option ([Loky from joblib](https://github.com/tomMoral/loky) does) that would be enough.

## Alternatives

Documentation should specify this issue. Option to use [Loky](https://github.com/tomMoral/loky) for all multi-processing backend will be also great.

## Additional context

Started a discussion [here](https://discuss.pytorch.org/t/dataloader-re-use-worker-processes/34071)


cc @ezyang @gchanan @SsnL
Repository: angular
Issue: Animation: Automatic property calculation ('!') not working when using AnimationPlayer/AnimationBuilder
Labels: type: bug/fix,area: animations,freq3: high,P3

<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅

Oh hi there! 😄

To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.

🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->


# 🐞 bug report

### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- ✍️edit: --> The issue is caused by package: @angular/animations


### Is this a regression?

<!-- Did this behavior use to work in the previous version? -->
<!-- ✍️--> I'm not sure


### Description

Given the following animation, for expanding an element:
```
animate(300, style({
    height: '!'
}))
```
it fails when consuming it with AnimationBuilder and trying to run it using AnimationPlayer (while it works perfectly fine using triggers with state & transition).


## 🔬 Minimal Reproduction
https://stackblitz.com/edit/angular-issue-repro2-3gdmsb?file=src%2Fapp%2Fapp.component.html

<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue. Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.

Issues that don't have enough info and can't be reproduced will be closed.

You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->

## 🔥 Exception or Error
<pre><code>
Invalid keyframe value for property height: undefined.

ERROR DOMException: Failed to execute 'animate' on 'Element': Partial keyframes are not supported.
    at WebAnimationsPlayer._triggerWebAnimation
</code></pre>


## 🌍  Your Environment

**Angular Version:**
<pre><code>
Angular CLI: 7.2.0
Node: 10.15.0
OS: win32 x64
Angular: 7.2.0
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.12.0
@angular-devkit/build-angular     0.12.0
@angular-devkit/build-optimizer   0.12.0
@angular-devkit/build-webpack     0.12.0
@angular-devkit/core              7.2.0
@angular-devkit/schematics        7.2.0
@angular/cli                      7.2.0
@ngtools/webpack                  7.2.0
@schematics/angular               7.2.0
@schematics/update                0.12.0
rxjs                              6.3.3
typescript                        3.1.6
</code></pre>
Repository: pytorch
Issue: Deformable Convolution
Labels: feature,triaged,module: vision

## 🚀 Feature
Exactly as introduced in Microsoft paper : https://arxiv.org/pdf/1703.06211.pdf

## Motivation
This operator has great advantages and abilities, and his popularity is increasing.

I don't think that any further explanation is needed.

BTW, other frameworks already have this operator, and I'm not talking about private people githubs..
Repository: pytorch
Issue: RuntimeError: [enforce fail at pybind_state.cc:1111] success. Error running net train
Labels: caffe2

Learn caffe2 to train MNIST-dataset. This network error occurs. Why?

[E prefetch_op.h:110] Prefetching error Unknown data type.
[E prefetch_op.h:83] Prefetching failed.
[E net_simple.cc:68] Operator failed: input: "dbreader_/home/tcl/caffe2_notebooks/tutorial_data/mnist/mnist-train-nchw-lmdb" output: "data_uint8" output: "label" name: "" type: "TensorProtosDBInput" arg { name: "batch_size" i: 64 } device_option { device_type: 0 device_id: 0 }
WARNING:caffe2.python.workspace:Original python traceback for operator `-1818544912` in network `train` in exception above (most recent call last):
Traceback (most recent call last):
  File "/home/tcl/PycharmProjects/caffe2/mnist_caffe2.py", line 285, in <module>
    workspace.RunNet(train_model.net.Proto().name)
  File "/usr/local/lib/python2.7/dist-packages/caffe2/python/workspace.py", line 236, in RunNet
    StringifyNetName(name), num_iter, allow_fail,
  File "/usr/local/lib/python2.7/dist-packages/caffe2/python/workspace.py", line 197, in CallWithExceptionIntercept
    return func(*args, **kwargs)
RuntimeError: [enforce fail at pybind_state.cc:1111] success. Error running net train
frame #0: c10::ThrowEnforceNotMet(char const*, int, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, void const*) + 0x78 (0x7f1208875408 in /usr/local/lib/python2.7/dist-packages/caffe2/python/../../torch/lib/libc10.so)
frame #1: <unknown function> + 0x424df (0x7f120baa54df in /usr/local/lib/python2.7/dist-packages/caffe2/python/caffe2_pybind11_state.so)
frame #2: <unknown function> + 0x86831 (0x7f120bae9831 in /usr/local/lib/python2.7/dist-packages/caffe2/python/caffe2_pybind11_state.so)
frame #3: PyEval_EvalFrameEx + 0x695b (0x558f90aa78db in /usr/bin/python2.7)
frame #4: PyEval_EvalCodeEx + 0x6da (0x558f90a9ed0a in /usr/bin/python2.7)
frame #5: PyEval_EvalFrameEx + 0x5cb8 (0x558f90aa6c38 in /usr/bin/python2.7)
frame #6: PyEval_EvalCodeEx + 0x6da (0x558f90a9ed0a in /usr/bin/python2.7)
frame #7: PyEval_EvalFrameEx + 0x567e (0x558f90aa65fe in /usr/bin/python2.7)
frame #8: PyEval_EvalCodeEx + 0x6da (0x558f90a9ed0a in /usr/bin/python2.7)
frame #9: PyEval_EvalCode + 0x19 (0x558f90a9e629 in /usr/bin/python2.7)
frame #10: <unknown function> + 0x12461f (0x558f90acf61f in /usr/bin/python2.7)
frame #11: PyRun_FileExFlags + 0x82 (0x558f90aca322 in /usr/bin/python2.7)
frame #12: PyRun_SimpleFileExFlags + 0x18d (0x558f90ac967d in /usr/bin/python2.7)
frame #13: Py_Main + 0x68b (0x558f90a781ab in /usr/bin/python2.7)
frame #14: __libc_start_main + 0xe7 (0x7f122ad02b97 in /lib/x86_64-linux-gnu/libc.so.6)
frame #15: _start + 0x2a (0x558f90a77a2a in /usr/bin/python2.7)
Repository: flutter
Issue: Please add automatic HashSet to Set type conversion to platform-channels.
Labels: c: new feature,framework,engine,P2,a: plugins,team-engine,triaged-engine

Right now I have to convert from a `HashSet<T>` to an `ArrayList<T>` in Java and from a `List` back to a `Set` in dart.

Is it reasonable to add `Set` support to platform channels?

I am not an Objective-C programmer, but there is also `NSSet`, which seems to do the same thing.

Here are the references:
https://docs.oracle.com/javase/7/docs/api/java/util/Set.html
https://developer.apple.com/documentation/foundation/nsset
https://developer.apple.com/documentation/swift/set
Repository: godot
Issue: iOS export configuration needs better validation
Labels: enhancement,platform:ios,topic:editor,usability

**Godot version:**
3.1 beta

**OS/device including version:**
macOS Mojave, Xcode 

**Issue description:**
I've got a project that I'd like to export to iOS. The project can be found here: https://github.com/Krumelur/GodotTesting/tree/godot31_issue_24866
The export itself succeeds and I end up with an Xcode project file.
Deploying the project to a device fails with an error saying:

"App installation failed - No code signature found."

The reason is that no signing certificate is selected but *cannot* be selected. My assumption is that there is some Xcode project file compatibility issues. See video for details.

**Steps to reproduce:**

See videos for details. It will show exactly what I'm doing:

https://www.youtube.com/watch?v=5tXRo7uRPFE

* Open the project referenced above
* Export to iOS
* Try to deploy in Xcode

**Minimal reproduction project:**
see above
Repository: TypeScript
Issue: --noImplicitAny codefixes infer methods returning void instead of any
Labels: Suggestion,In Discussion

**TypeScript Version:**  3.3.0-dev.20190108

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** noimplicitany infer code fix codefix quick suggested return void any

**Code**

```ts
function curryThrough(callback) {
  return callback("turtle");
}
```

**Expected behavior:**

`--noImplicitAny` suggested fix on the `callback` parameter:

```typescript
function curryThrough(callback: (arg0: string) => any) {
```

**Actual behavior:**

```typescript
function curryThrough(callback: (arg0: string) => void) {
```

**Related Issues:** #13243 _(parent tracking quick fixes)_

`void` seems like an odd default choice for the unknown return value of a method. If the type can't be inferred from usage, shouldn't it be `any`?