sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: youtube-dl
Issue: Add option to prevent transcoding of audio files
Labels: request

<!--

######################################################################
  WARNING!
  IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################

-->


## Checklist

<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2021.01.24.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->

- [x] I'm reporting a feature request
- [x] I've verified that I'm running youtube-dl version **2021.01.24.1**
- [x] I've searched the bugtracker for similar feature requests including closed ones


## Description

<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->

Downloading a lossless audio file (tested with .wav and .aiff) with the `-x` flag causes the audio to be transcoded into mp3. For archiving purposes, having the option to prevent all (audio) transcoding would be ideal.

Examples links:
https://soundcloud.com/caleesi-sarahkreis/caleesi-sarahkreis-mbr-sao-paulo
https://soundcloud.com/caleesi/arutani-caleesi-ennui-original-mix
Repository: rust
Issue: Confusing diagnostic when using closures
Labels: A-diagnostics,A-lifetimes,A-closures,T-compiler,C-bug,D-newcomer-roadblock

When trying to compile [this code (Rust stable 1.49.0)](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=0f9ee2a30d35a24d0512885e94fbadf9)

```rust
fn my_function(callback: impl FnMut(&str) + Send + 'static){}

fn main(){
    let closure_consumer = |data| {};
    my_function(closure_consumer);
}
```
I expected it to compile fine,

Instead, we get this funny nonsensical error : 

```
  |
  |     my_function(closure_consumer);
  |     ^^^^^^^^^^^ one type is more general than the other
  |
  = note: expected type `FnOnce<(&str,)>`
             found type `FnOnce<(&str,)>`
```

The code compiles fine if we add a type annotation to the closure (notice the `|data: &str|`)

```rust
fn my_function(callback: impl FnMut(&str) + Send + 'static){}

fn main(){
    let closure_consumer = |data: &str| {};
    my_function(closure_consumer);
}
```

This may be a type inference bug (because closure are supposed to work even without type annotations) but it's also (and most importantly IMHO) a diagnostic bug, because the error gives me zero information about what is going on. 

When compiling with the latest nightly (1.51.0-nightly (2021-01-28 c0b64d97beebb09325b5)), we have a more detailed error, but it doesn't make a better job at explaining what we are supposed to do to make this code run : 

```
  |
6 |     my_function(closure_consumer);
  |     ^^^^^^^^^^^ lifetime mismatch
  |
  = note: expected type `FnOnce<(&str,)>`
             found type `FnOnce<(&str,)>`
note: this closure does not fulfill the lifetime requirements
 --> src/main.rs:5:28
  |
5 |     let closure_consumer = |data| {};
  |                            ^^^^^^^^^
note: the lifetime requirement is introduced here
 --> src/main.rs:2:31
  |
2 | fn my_function(callback: impl FnMut(&str) + Send + 'static){}
```
Repository: godot
Issue: Running C# project can crash after editing it with VS 2019
Labels: bug,topic:editor,topic:dotnet,crash

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
<!-- Specify commit hash if using non-official build. -->
3.2.4.rc (- 3.2.3)
VS2019 + [godot-csharp-visualstudio](https://github.com/godotengine/godot-csharp-visualstudio)

**OS/device including version:**
<!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. -->
windows 10 GeForce GTX 1060 6GB/PCIe/SSE2

**Issue description:**
<!-- What happened, and what was expected. -->
godot Programs sometimes crash

**Steps to reproduce:**

Two cases

1 modify code in VS2019
2  VS2019 Press F5 
mono_logs The last two lines
`Requesting loading reference 0 (of 2) of D:/Projects/Godot/godot/bin/GodotSharp/Tools/GodotTools.IdeMessaging.dll (in domain Mono, info)
Loading reference 0 of D:/Projects/Godot/godot/bin/GodotSharp/Tools/GodotTools.IdeMessaging.dll asmctx DEFAULT, looking for netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 (in domain Mono, info)`
![Running in VS](https://user-images.githubusercontent.com/14800320/106270655-485bdc80-6269-11eb-8f37-47311a2a08b4.png)

1 modify code in VS2019
2 Godot Press F5
mono_logs The last two lines
`Requesting loading reference 0 (of 2) of D:/Projects/Godot/godot/bin/GodotSharp/Tools/GodotTools.IdeMessaging.dll (in domain Mono, info)
Loading reference 0 of D:/Projects/Godot/godot/bin/GodotSharp/Tools/GodotTools.IdeMessaging.dll asmctx DEFAULT, looking for netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 (in domain Mono, info)
Assembly Ref addref GodotTools.IdeMessaging[000001F5957F34E0] -> netstandard[000001F5957F27F0]: 4 (in domain Mono, info)`
`* Assertion at ..\mono\mini\mini-runtime.c:1841, condition `is_ok (error)` not met, function:lookup_method, VAR 0 (T) cannot be expanded in this context with 0 instantiations
 (in domain , error)`
![Running in Godot](https://user-images.githubusercontent.com/14800320/106270644-4560ec00-6269-11eb-8d6e-214abf7f583f.png)
Repository: neovim
Issue: Using neovim as $MANPAGER fails when stderr is redirected
Labels: bug,plugin,runtime

Hey there!

I'm using neovim as manpager (as described in `:h man` -> `MANPAGER='nvim +Man!'`) and while it works great, I ran into an issue using fish-shells' `Alt+h`/`F1` functionality. This shortcut jumps directly into the man page of the command under the cursor. Using it, neovim flashes up and it seems it tries to execute a lot of commands (they're all failing with `E21: Cannot make changes, 'modifiable' is off`, which is expected with `+Man!`).

After looking at the [fish function](https://github.com/fish-shell/fish-shell/blob/master/share/functions/__fish_man_page.fish) I pinned it down to using `man` with a redirection: `man ls 2>/dev/null`, or more generally: `echo "foo" | nvim -u NORC 2>/dev/null`.

stderr of `man ls 2>./log`:
```
Vim: Error reading input, exiting...

Vim: Finished.
man: command exited with status 1: sed -e '/^[[:space:]]*$/{ N; /^[[:space:]]*\n[[:space:]]*$/D; }' | LESS=-ix8RmPm Manual page ls(1) ?ltline %lt?L/%L.:byte %bB?s/%s..?e (END):?pB %pB\%.. (press h for help or q to quit)$PM Manual page ls(1) ?ltline %lt?L/%L.:byte %bB?s/%s..?e (END):?pB %pB\%.. (press h for help or q to quit)$ MAN_PN=ls(1) nvim +Man!
```

stderr of `echo "foo" | nvim -u NORC 2>./log`:
```
Vim: Error reading input, exiting...

Vim: preserving files...
Vim: Finished.
```

With vim as manpager (`MANPAGER="vim -M +MANPAGER -"`) it behaves more or less the same, but outputs some errors/warnings to stdout, too.

- `nvim --version`: NVIM v0.5.0-dev+1055-g8950f4e94
- `vim -u DEFAULTS` (version: 8.2) behaves differently? very similar
- Operating system/version: Arch Linux
- Terminal name/version: alacritty
- `$TERM`: tmux-256color

### Steps to reproduce

```sh
# set nvim as manpager
# bash: `export MANPAGER='nvim +Man!'`
# fish: `set -x MANPAGER "nvim +Man!"`
man ls 2>/dev/null
# or
echo "foo" | nvim -u NORC 2>/dev/null
```

### Actual behaviour

* nvim starts
* nvim tries to execute commands, failing with `E21: Cannot make changes, 'modifiable' is off`
* nvim closes

### Expected behaviour

* nvim opens man page/piped text
* errors are redirected
Repository: vscode
Issue: Git - clicking on a path segment for a file on git index opens empty picker
Labels: bug,git,confirmed

Steps to Reproduce:

1. stage file to index
2. click on path segment in breadcrumb

![image](https://user-images.githubusercontent.com/900690/106276971-a45a3d00-6238-11eb-8df4-76393c33fce8.png)
Repository: vscode
Issue: Feature Request : Mark files as sensibles (like files with passwords)
Labels: feature-request

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
I'd love a feature where we can right click on a file and mark it as "Sensitive", so everytime we open it there is a confirmation button to click which unlock the contents.
It's pretty useful when we are streaming our screen or people are next to the computer, and we click inadvertently on a file containing credentials.
Repository: create-react-app
Issue: Some packages within node_modules are not watched by Webpack while others are on macOS
Labels: needs triage,issue: bug report

### Describe the bug

Some packages within `node_modules` are not watched by Webpack while others are on macOS.

### Did you try recovering your dependencies?

Yes

### Which terms did you search for in User Guide?

I searched issues on create-react-app, webpack-dev-server and chokidar.

I also created an [issue](https://github.com/paulmillr/chokidar/issues/1071) on chokidar's repo (given I am not sure the issue is downstream, creating an issue here too).

### Environment

Environment Info:

  current version of create-react-app: 4.0.1
  running from /Users/sunknudsen/.npm/_npx/14520/lib/node_modules/create-react-app

  System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
  Binaries:
    Node: 14.15.1 - /usr/local/opt/node@14/bin/node
    Yarn: Not Found
    npm: 6.14.11 - /usr/local/bin/npm
  Browsers:
    Chrome: Not Found
    Edge: Not Found
    Firefox: 85.0
    Safari: 14.0.1
  npmPackages:
    react: ^17.0.1 => 17.0.1
    react-dom: ^17.0.1 => 17.0.1
    react-scripts: 4.0.1 => 4.0.1
  npmGlobalPackages:
    create-react-app: Not Found

### Steps to reproduce

#### Step 1: create a fresh [create-react-app](https://www.npmjs.com/package/create-react-app) project using `npx create-react-app my-app --template typescript`

#### Step 2:  install `react-router-dom` using `npm install react-router-dom` and `npm install --save-dev @types/react-router-dom`.

#### Step 3: edit `App.tsx`

```tsx
import React, { FunctionComponent } from 'react';
import { BrowserRouter, Route, RouteComponentProps, Switch } from 'react-router-dom'
import logo from './logo.svg';
import './App.css';

const defaultRoute: FunctionComponent<RouteComponentProps> = function(props) {
  return <div className="App">
  <header className="App-header">
    <img src={logo} className="App-logo" alt="logo" />
    <p>
      Edit <code>src/App.tsx</code> and save to reload.
    </p>
    <a
      className="App-link"
      href="https://reactjs.org"
      target="_blank"
      rel="noopener noreferrer"
    >
      Learn React
    </a>
  </header>
</div>
}

function App() {
  return (
    <BrowserRouter>
      <Switch>
        <Route component={defaultRoute}></Route>
      </Switch>
    </BrowserRouter>
  );
}

export default App;
```

#### Step 4: run `npm start`

#### Step 5: add `console.log("BOOM");` under the `import` statements of `node_modules/react-router/esm/react-router.js` and save

### Expected behavior

Editing `react-router.js` should consistently trigger "Compiling..." and browser reload.

### Actual behavior

Editing `react-router.js` doesn't consistently trigger "Compiling..." and browser reload.

### Reproducible demo

The above steps generate reproducible demo.

Thanks for your help!
Repository: vscode
Issue: Settings editor: Support .enabled to hide other settings in the namespace by convention 
Labels: feature-request,settings-editor,under-discussion

Related/parent issue: #70589

@eamodio suggested the idea of special settings that would hide other settings, that got me thinking we have this pattern already but don't hide them. In the screenshot below, only the top setting means anything unless it's checked, so we could hide them to reduce the overwhelming number of settings available:

![image](https://user-images.githubusercontent.com/2193314/106285208-0abf6b00-61f9-11eb-8c8a-5103e41c53c5.png)

This is similar to how most GUIs would disable settings when the feature is disabled. I'm not sure whether they should show up when searching, maybe they should but be faded/disabled out or something and point to the parent `.enabled` setting?
Repository: flutter
Issue: EdgeInsets.only or BorderRadius.only to accept an optional default parameter.
Labels: c: new feature,framework,c: proposal,P3,team-framework,triaged-framework

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case

Currently to specify a padding different only on 1 side or 2 sides you have to type more than I think you should. This change will make the code less verbose and easier to follow. The change would be useful also in specifying a borderRadius, where the amount of repeated code is even greater (or to any `.only` method).

<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->

## Proposal

**EdgeInsets**
`const EdgeInsets.only(top: 20.0, all: 10.0)`  will work the same as
`const EdgeInsets.only(top: 20.0, left: 10.0, right: 10.0, bottom: 10.0)`
or
`const EdgeInsets.only(top: 20.0, bottom: 30.0, all: 10.0)` will work the same as
`const EdgeInsets.only(top: 20.0, bottom: 30.0, left: 10.0, right: 10.0)`

**BorderRadius**
```
BorderRadius.only(
  topLeft: Radius.circular(0),
  all: Radius.circular(20.0)
)
``` 
will work the same as
```
BorderRadius.only(
  topLeft: Radius.circular(0),
  bottomLeft: Radius.circular(20.0),
  bottomRight: Radius.circular(20.0),
  topRight: Radius.circular(20.0)
)
```


<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching images showing what you are imagining.

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->
Repository: go
Issue: cmd/vet: warn about using reflect.DeepEqual and == on reflect.Value
Labels: Proposal,Proposal-Accepted,Analysis

This code doesn't do what you think it does:
```
func f(x, y reflect.Value) bool {
    return reflect.DeepEqual(x, y)
}
```

It compares the internal details of the two `reflect.Value` structs, not their contents. The correct code would be `reflect.DeepEqual(x.Interface(), y.Interface())`.

I don't see any reason why you'd ever want to use `DeepEqual` on a `reflect.Value`. Hence no false positives.

If you really wanted to compare two `reflect.Value`s (but you shouldn't), `==` is equivalent to `DeepEqual`.

Seems like an easy mistake to make (see #43986 ). Not sure how common it might be, but I suspect it might be common enough to warrant a check.
Repository: go
Issue: x/tools/gopls: unkeyed struct literals are not returned by Reference
Labels: NeedsInvestigation,FeatureRequest,gopls,Tools

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version devel +c8bd8010ff Thu Jan 28 16:45:43 2021 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.1.0
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.0.0-20210119222503-fe37c9e135b9
</pre>

### Does this issue reproduce with the latest release?

Yes

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/myitcv/gostuff/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel +c8bd8010ff Thu Jan 28 16:45:43 2021 +0000"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build884615165=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### What did you do?

Consider the input:

```
package main

type blah struct {
	f1 int
	f2 int
}

func main() {
	b := blah{1, 2}
	b.f2 = 10
}
```

With the cursor on the `f2` of `b.f2` on line 10, issuing a `Reference` call gives two locations: the declaration on line 5, and the usage under the cursor on line 10. The implicit reference to that field on line 9 is not included.


### What did you expect to see?

The implicit reference on line 9 to also be returned.

### What did you see instead?

As above.

Logs:

* [gopls.log](https://github.com/golang/go/files/5895125/gopls.log)
* [govim.log](https://github.com/golang/go/files/5895126/govim.log)

Ref: https://github.com/govim/govim/issues/1016

---

cc @stamblerre

FYI @leitzler @eliasnaur
Repository: rust
Issue: Suggestion is placed at the wrong scope with nested IntoIter requirement
Labels: C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics,D-invalid-suggestion,D-incorrect,S-needs-repro

rustc 1.49.0 and rustc 1.51.0-nightly (a2f8f6281 2021-01-27)
```rust
use std::borrow::Borrow;

fn accepts_intoiter_iter<OuterIter, Iter, T>(items: OuterIter)
where
    OuterIter: IntoIterator<Item = Iter>,
    Iter: IntoIterator<Item = T>,
    T: Borrow<u8>,
{
}

fn main() {
    let items: Vec<u16> = Vec::new();
    accepts_intoiter_iter(items.iter().map(|c| c.to_be_bytes()));
}
```
```
error[E0277]: `[u8; 2]` is not an iterator
  --> src/lib.rs:13:27
   |
3  | fn accepts_intoiter_iter<OuterIter, Iter, T>(items: OuterIter)
   |    --------------------- required by a bound in this
...
6  |     Iter: IntoIterator<Item = T>,
   |           ---------------------- required by this bound in `accepts_intoiter_iter`
...
13 |     accepts_intoiter_iter(items.iter().map(|c| c.to_be_bytes()));
   |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |                           |
   |                           expected an implementor of trait `IntoIterator`
   |                           help: consider borrowing here: `&items.iter().map(|c| c.to_be_bytes())`
   |
   = note: the trait bound `[u8; 2]: IntoIterator` is not satisfied
   = note: required because of the requirements on the impl of `IntoIterator` for `[u8; 2]`
```
Repository: godot
Issue: 3.2.4-rc1: undo broken when editing tilemap
Labels: bug,topic:editor

**Godot version:**
3.2.4-rc1

**OS/device including version:**
Ubuntu Linux 20.04

**Issue description:**
Undo doesn't work on a tilemap. Whenever Ctrl+Z is pressed, the console outputs:

```
 core/undo_redo.cpp:373 - Condition "action_level > 0" is true. Returned: ""
 core/undo_redo.cpp:346 - Condition "action_level > 0" is true. Returned: false
Nothing to undo.
```

**Steps to reproduce:**
Draw a tile to a tilemap, then press Ctrl+Z.

**Minimal reproduction project:**
Probably not necessary here
Repository: TypeScript
Issue: Better printing of `T & U` where this is equivalent to `Extract<T, U>`
Labels: Suggestion,Experience Enhancement

# Suggestion

<!--
  Please fill in each section completely. Thank you!
-->

## 🔍 Search Terms

Extract intersection union ide editor printing

## ✅ Viability Checklist

<!--
   Suggestions that don't meet all these criteria are very, very unlikely to be accepted.
   We always recommend reviewing the TypeScript design goals before investing time writing
   a proposal for ideas outside the scope of the project.
-->
My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).


## ⭐ Suggestion

There are many cases where `T & U` is equivalent to `Extract<T, U>`. However, the former has much worse type printing in these cases than the latter, leading to a much worse developer experience for this case.

I initially raised this as an eslint rule, but it would be very difficult to do do from that side (as explained in the comments of https://github.com/typescript-eslint/typescript-eslint/issues/2983

## 📃 Motivating Example

```typescript
type A = Action & { type: 'action1' | 'action2' } 
// ({
//     type: 'action1';
//     a: number;
// } & {
//     type: 'action1' | 'action2';
// }) | ({
//     type: 'action2';
//     b: string;
// } & {
//     type: 'action1' | 'action2';
// })

type B = Extract<Action, { type: 'action1' | 'action2' }>
// {
//     type: 'action1';
//     a: number;
// } | {
//     type: 'action2';
//     b: string;
// }
```

https://www.typescriptlang.org/play?#code/C4TwDgpgBAggxsAlgewHZQLwCgoB8oDeUokAXFAOQCGCKqAjBQDRRXmoCuAtgEYQBOUAL458REhHLVaaAEzMoPcgGdg-RKgDmw0YWLhJlGkjQBmBXBVqN2kViwTYmWDPQAyPRKnG6jPEdd5YSgHAygAIWcAUQAPNWMAHngTVBZxA29XP3xpFKChAD4gA

## 💻 Use Cases

Improve developer experience, error messages, and IDE support.