sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: Improve FittedBox docs to suggest forcing the parent to a particular size
Labels: framework,d: api docs,a: quality,P2,team-framework,triaged-framework

I know FittedBox will create RenderFittedBox，but I can not understand ''performLayout'' function that compute the size:
```
@override
  void performLayout() {
    if (child != null) {
      child.layout(const BoxConstraints(), parentUsesSize: true);
      size = constraints.constrainSizeAndAttemptToPreserveAspectRatio(child.size); //keep the same aspect ratio with child?
      _clearPaintData();
    } else {
      size = constraints.smallest;
    }
  }
```
The ''constrainSizeAndAttemptToPreserveAspectRatio'' function will keep the size has same aspect ratio with the child's size，so after that it simply scale up/down child's size to fit FittedBox's size.
Because that reason, the parameter 'fit' has no effect.
If the code update with that, here all is right.
```
@override
  void performLayout() {
    if (child != null) {
      child.layout(const BoxConstraints(), parentUsesSize: true);
      size = constraints.biggest;
      _clearPaintData();
    } else {
      size = constraints.smallest;
    }
  }
```
My demo code:
```
Widget build(BuildContext context) {
    return new Container(
      color: Colors.white,
      alignment: Alignment.center,
      child: new Container(
        width: 200.0,
        height: 100.0,
        color: Colors.black,
        alignment: Alignment.topLeft,
        child: new FittedBox(
          fit: BoxFit.fitWidth,
          alignment: Alignment.topLeft,
          child: new Container(
            color: Colors.red,
            width: 300.0,
            height: 240.0,
            alignment: Alignment.center,
            child: new Text('AAA'),
          ),
        )
      )
    );
```
Repository: flutter
Issue: Display Progress Indicator for Flutter Upgrade
Labels: c: new feature,tool,P3,team-tool,triaged-tool

When doing `flutter upgrade`, the only messages we get are `Downloading X tools...`. It happened many times that I wonder whether the download has stalled or if there's still progress going on.

Can we have a progress indicator for when the tools are being downloaded?
Repository: youtube-dl
Issue: ESPN broken
Labels: tv-provider-account-needed

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['http://www.espn.com/watch/player?id=3211683', '--ap-mso', 'DTV', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '--hls-prefer-native', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.11.06
[debug] Python version 3.4.4 - Windows-2012ServerR2-6.3.9600
[debug] exe versions: ffmpeg N-71320-gc4b2017, ffprobe N-80912-gce466d0
[debug] Proxy map: {}
[ESPN] 3211683: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 400: Bad Request (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp1ogvhjus\build\youtube_dl\extractor\common.py", line 506, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp1ogvhjus\build\youtube_dl\YoutubeDL.py", line 2195, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default
Repository: TypeScript
Issue: JSDoc refactor doesn't add type parameters
Labels: Bug,Domain: Quick Fixes

<!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  typescript@next

**Code**

```ts
/**
 * @template T
 * @param {function(T): boolean} g
 */
function f(/*1*/g) {
}
```

Run the inline-jsdoc-types refactor at `/*1*/`.

**Expected behavior:**

`f<T>(g: (arg0: T) => boolean)`

**Actual behavior:**

`f(g: (arg0: any) => boolean)`
Repository: pytorch
Issue: Proposal: combine requires_grad and retain_grad()
Labels: module: autograd,triaged

Currently, requires_grad means two things: 
1) That we should compute gradients for this variable and functions of this variable
2) On a "leaf" variable, it means we should store the gradient to the "grad" attribute

The `retain_grad()` functions is used to signify that we should store the gradient on non-"leaf" variables to the "grad" attribute.

We should change `requires_grad` so that it signifies that we should store the "grad" attribute on all variables (leaf and non-leaf). We should add a new read-only attribute, `compute_grad`, which serves the first purpose (whether or not we should compute gradients).

 `retain_grad()` can be deprecated and simply set requires_grad=True for backwards compatibility.

cc @ezyang @SsnL @albanD @zou3519 @gqchen
Repository: go
Issue: cmd/internal/src: do we need to carry around absFilename (and symFilename) ?
Labels: NeedsInvestigation,compiler/runtime

pos.go defines a PosBase which carries an andFilename. absFilenames are produced from the regular filename when the PosBase is created and then don't change. It seems that we could just as well produce the absFilename only at the end, when we need it (to flow into the compiler's generated binary). Investigate.

Reminder issue.

(See also #22660.)
Repository: kubernetes
Issue: Deprecate kubelet "enable-controller-attach-detach" option
Labels: sig/storage,kind/feature,lifecycle/frozen

<!-- This form is for bug reports and feature requests ONLY! 

If you're looking for help check [Stack Overflow](https://stackoverflow.com/questions/tagged/kubernetes) and the [troubleshooting guide](https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/).
-->

**Is this a BUG REPORT or FEATURE REQUEST?**:
/kind feature
@kubernetes/sig-storage-feature-requests 

**What happened**:
Are there any use cases where we still need to support kubelet doing the attach/detach?  If not, let's deprecate this field and eventually remove it.
Repository: flutter
Issue: Add a flutter project validation mechanism
Labels: tool,t: flutter doctor,a: first hour,a: build,P2,team-tool,triaged-tool

Sister bug to #12573

Currently, once a project is created, flutter loses the ability to sanitize the project build configuration (e.g. gradle and the various Xcode project configurations). If the user alters those configurations too much, it becomes very difficult to go back to a working state. 

We currently only have indirect signals when the build output based on the build configurations are bad but it's too indirect. We should directly assert against the build configurations things such as:

Is the target API level too low, is generated.xcconfig transitively included, are schemes/build configs named a particular way, are you trying to build for 32-bit iOS etc. 

----
From #14974:
> It'd be good if we gave users a way to check "is my project in a healthy state?".  Things this might check:

- [ ] Are the Gradle files up to date?
- [ ] Are the Xcode project files up to date?
- [ ] Are there any errors in my pubspec.yaml?
    - For example, the user should be depending on `flutter_test: sdk: flutter`, not `test` directly (or at least not without depending on `flutter_test`)
Repository: vscode
Issue: SCM - Support keyboard shortcuts for inline change review commands
Labels: help wanted,feature-request,scm

Steps to Reproduce:

1. Set this in keybindings

```json
{
    "key": "alt+cmd+z",
    "command": "git.revertChange"
}
```

2. 
![revert-changes](https://user-images.githubusercontent.com/8818340/32689259-66f17cc6-c6e1-11e7-929b-6e14a16de720.gif)


<!-- Launch with `code --disable-extensions` to check. -->
Reproduces without extensions: Yes
Repository: godot
Issue: Transform lock is not saved for scenes instanced in editor
Labels: enhancement,topic:editor,confirmed

**Operating system or device, Godot version, GPU Model and driver (if graphics related):**
35e7f992993a69a1e25cc12109ef7cf885e18260

**Issue description:**
When setting transform lock on subscene and saving the scene the lock should be saved as well. Unfortunately that's not the case: 
![not_pernament_lock](https://user-images.githubusercontent.com/6129594/32689984-0935375e-c6ef-11e7-8dd4-16886f04f97a.gif)

Saving the lock works well for 'normal'  (not subscene) nodes.

**Steps to reproduce:**
1. Create scene with node2d as root. Save it as `Scene2D`
2. Create another scene, add some node, instance `Scene2D` in editor as child of that node. 
3. Set transform lock on `Scene2D` 
4. Save the scene
5. Close and reopen the scene

**Link to minimal example project:**
Repository: vscode
Issue: [Extensions] Bind package.config's activation onLanguage to configuration
Labels: feature-request,api

- VSCode Version: 1.18.0 dcee22
- OS Version: macOS 10.13.1

Steps to Reproduce:

1. Have an extension that has `"activationEvents": [ "onLanguage:markdown" ]` but allow users to [override the languages it works for via configuration](https://github.com/TravisTheTechie/vscode-write-good/blob/master/package.json#L22), e.g. adding text
2. The user now must load a markdown file before it will activate for text files

It would be awesome if I could bind activation to whatever languages the user has configured instead of having to bind it to [every event](https://code.visualstudio.com/docs/extensionAPI/activation-events#_activationevents). Is this possible in some way that I can't find?  

Reproduces without extensions: No, it's extension related
Repository: vscode
Issue: [icons] allow name specific root folder icons
Labels: feature-request,themes,workbench-multiroot

- VSCode Version: 1.18.1
- OS Version: Windows 10

I use muli-root workspace, and lost the specific icon defined for some folders:

![image](https://user-images.githubusercontent.com/16486407/32697388-caffcc5a-c78f-11e7-8b12-f2fa956e1e9f.png)

I use my own icon theme and specify
```
    "folderNames": {
        "db": "_fd_red",
        "server": "_fd_green"
    }
```
Now, with multi-workspace, they are no longer used.

There is a setting `rootFolder` but no` rootFolderNames`. 

I would like a setting taking account **name of folder** or **name defined in .code-workspace.** to get something like this:
![image](https://user-images.githubusercontent.com/16486407/32697563-54be0c38-c793-11e7-8f08-b029157b792c.png)
Repository: vscode
Issue: [folding] Hover can show region description on `#endregion`
Labels: feature-request,editor-folding

It would be great if the description of `region` pops up when mouse hovering on `#endregion`. To clarify, in `#region Great Stuff`, the description text is `Great Stuff`.
Repository: angular
Issue: Possibility to add multiple updateOn events
Labels: feature,help wanted,freq2: medium,area: forms,feature: under consideration

[x] Feature request

It would be nice to add support for multiple updateOn: events. e.g updateOn: "blur submit".

There is scenario where single "blur" is not enough.

For example:
1. we have simple form with 2 fields and one submit button
2. user enters value for the first field and navigates to the second one
3. user enters value for the second field and submit form by pressing enter key

In my example, the form will be submitted with empty value in the second filed.
Repository: TypeScript
Issue: SourceFile.ambientModuleNames is undefined after transform()
Labels: Bug,Help Wanted,API


<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  2.4.2 (stuck to this TypeScript version because of Angular 5.0.1)

**Code**

```ts
import * as ts from 'typescript';

  // transform typescript AST prior to compilation
  const transformationResult: ts.TransformationResult<ts.SourceFile> = ts.transform(
    tsProgram.getSourceFiles(),
    [ /* customTransformers */ ],
    options
  );

  // Wraps a CompilerHost reading SourceFile's from the previous TransformationResult
  function wrapCompilerHost({transformation, options}): ts.CompilerHost {
    const wrapped = ts.createCompilerHost(options);

    return {
      ...wrapped,
      getSourceFile: (fileName, version) => {
        const inTransformation = transformation.transformed.find((file) => file.fileName === fileName);

        if (inTransformation) {
          return inTransformation;
        } else {
          return wrapped.getSourceFile(fileName, version);
        }
      }
    }
  }

  // then, do another compilation
  const wrappingCompilerHost = wrapCompilerHost(transformationResult, options);
  ts.createProgram(/*..*/, wrappingCompilerHost).emit(/* .. */);
```


**Expected behavior:**

Should "ambientModuleNames" not be copied/applied to the transformed `SourceFile`?

**Actual behavior:**

After `ts.transform(..)`, the "ambientModuleNames" of `SourceFile` is undefined, resulting in the following error:

```
"TypeError: Cannot read property 'length' of undefined
    at resolveModuleNamesReusingOldState (~ng-packagr/node_modules/typescript/lib/typescript.js:69409:80)
    at processImportedModules (~ng-packagr/node_modules/typescript/lib/typescript.js:70364:35)
    at findSourceFile (~ng-packagr/node_modules/typescript/lib/typescript.js:70274:17)
    at processImportedModules (~ng-packagr/node_modules/typescript/lib/typescript.js:70393:25)
    at findSourceFile (~ng-packagr/node_modules/typescript/lib/typescript.js:70274:17)
    at args (~ng-packagr/node_modules/typescript/lib/typescript.js:70200:85)
    at getSourceFileFromReferenceWorker (~ng-packagr/node_modules/typescript/lib/typescript.js:70173:34)
    at processSourceFile (~ng-packagr/node_modules/typescript/lib/typescript.js:70200:13)
    at processRootFile (~ng-packagr/node_modules/typescript/lib/typescript.js:70055:13)
    at ~ng-packagr/node_modules/typescript/lib/typescript.js:69312:60"
```

Original `SourceFile` has `ambientModuleName`. The transformed source file hasn't:

![screen shot 2017-11-12 at 21 27 38](https://user-images.githubusercontent.com/901354/32703146-f2fe979c-c7f1-11e7-8d43-6cacf20aec5c.png)
Repository: neovim
Issue: SIGINT forwarding for RPC / ctrl-c interrupt rpcrequest()
Labels: enhancement,ux,channels-rpc,remote-plugin

It would be useful to have either:
1. SIGINT forwarding
2. Subscribe to SIGINT on RPC

Each have trade-offs, perhaps being strongly down to a language-by-language interface.

This would allow for the interruption of long-running commands. Much like the old-style python interface can do.
Repository: godot
Issue: RichTextLabel's bbcode_text property is not tag-stack-aware.
Labels: bug,confirmed,topic:gui

**Operating system or device, Godot version, GPU Model and driver (if graphics related):**
Windows 10
Godot master

**Issue description:**
If you manually add content to `RichTextLabel`'s internal tag stack using `append_bbcode` and the `push_*`/`pop` functions, I would expect to be able to print `bbcode_text` and see the corresponding opening and closing tags visible in the output (at least, as much as is possible. I know you can't perfectly do that with `push_meta(Variant)`, but for most you could). To the end user, they don't even see the internal tag stack, so when they use `append_bbcode`, they THINK that they are in fact editing `bbcode_text`...except that they aren't...<_< We should try to maintain that illusion.

**Steps to reproduce:**
Start a new scene with RichTextLabel as the root. Toggle on the bbcode bool. Add a script:

    # RichTextLabel.gd
    func _ready():
        add_text("hello")
        print(bbcode_text) # prints nothing to the screen

I would have expected to see "hello" printed as a result of this.

Also, fixing this Issue would probably also fix #12881.
Repository: opencv
Issue: Kalman filter OpenCL version
Labels: priority: low,category: ocl

Hi everyone

I want to contribute to OpenCV but I want to make sure that I'm in the right way

Recently, I'm working on prediction and updating stage matrix parallel processing with OpenCL kernel

My Question is why there is no Kalman filter with OpenCL version?

Is it because it's not that fast for small matrix size? ex. matrix size under 100 * 100

Thx everyone
Repository: flutter
Issue: ColorFilter doesn't handle transparency of images
Labels: framework,d: api docs,customer: crowd,a: images,c: proposal,P2,a: gamedev,team-framework,triaged-framework

**Scenario**
Using ColorFilter to increase the brightness of an image when receiving focus from the user. For example a button.

**Issue**

1. Color is a required field. 
2. Transparent areas are filled with the color.

**Desired**
ColorFilter should ignore transparent bits.
Repository: flutter
Issue:  Widget got rebuilt due to outdated dependencies
Labels: framework,c: performance,d: api docs,P3,team-framework,triaged-framework

Suppose widget `W` depends on `InheritedWidget` `D` based some `condition` be true. After a asynchronous operation, `condition` changed from `true` to `false`. From now on, `W` doesn't depend on `D` actually, but `W` still got rebuilt due to changes in `D`. `condition` can be internal state of `W` or information from other `InheritedWidget`.

I post a test [gist](https://gist.github.com/kezhuw/3ff4cf46d2d60565960caf2257cd1242) to show this.
Repository: pytorch
Issue: Exposing CuDNN benchmark strategy selection 
Labels: module: cudnn,module: bootcamp,feature,triaged

It would be very convenient to have an option to set the convolution algorithm preference to prefer memory over speed when enabling the cuDNN benchmark. For a lot of applications memory efficient convolutions are preferred to the fastest approach. So having a way to set this would be welcome.

`torch.backends.cudnn.benchmark = True`

The [cudnnConvolutionFwdPreference](https://docs.rs/cudnn-sys/0.0.3/cudnn_sys/enum.cudnnConvolutionFwdPreference_t.html) during the benchmark knows several settings: 
* CUDNN_CONVOLUTION_FWD_NO_WORKSPACE		
* CUDNN_CONVOLUTION_FWD_PREFER_FASTEST		
* CUDNN_CONVOLUTION_FWD_SPECIFY_WORKSPACE_LIMIT

Yet, in the current [implementation](https://github.com/pytorch/pytorch/blob/8fbe003d4ed946804d67a6d3bcd84eb6c3df9a4a/torch/csrc/cudnn/Conv.cpp) this appears to be fixed to: CUDNN_CONVOLUTION_FWD_PREFER_FASTEST

This is of course similar for:
* cudnnConvolutionBwdDataPreference_t
* cudnnConvolutionBwdFilterPreference_t 
* cudnnConvolutionFwdPreference_t


My initial proposal would be to include a property to the `torch.backends.cudnn` which can be set to pick a different preference, i.e.:
`torch.backends.cudnn.benchmark_memory_limit = None` (FASTEST / default value)
`torch.backends.cudnn.benchmark_memory_limit = 0` (NO_WORKSPACE)
`torch.backends.cudnn.benchmark_memory_limit = 12` (SPECIFY_WORKSPACE_LIMIT)

The numbers could represent GPU memory in GB/MB or even bytes.





cc @ezyang @gchanan @zou3519 @bdhirsh @heitorschueroff @csarofeen @ptrblck
Repository: godot
Issue: Change `make_function` API to work well with different script languages
Labels: enhancement,topic:core,topic:editor,confirmed

**Issue description:**
Currently, the API to add a function to scripts, which is used by the connections dialog, is `ScriptLanguage::make_function(class, name, args)`.
This method is expected to return a string with the function's declaration and body. The returned string is appended to the end of the script's source. This may be fine for languages like GDScript, but it won't work for other languages.

This API should be changed to receive `Ref<Script>` and either be expected to modify it or to return its full source code with the newly added function.
Repository: go
Issue: runtime:  fractional worker preemption causes performance degradation for single cpu
Labels: Performance,NeedsInvestigation,compiler/runtime

What version of Go are you using (go version)?
```
go version devel +ef0e2af Mon Nov 6 15:55:31 2017 +0000 linux/amd64
```

What operating system and processor architecture are you using (go env)?
```
GOARCH="amd64"
GOBIN=""
GOCACHE="/nfs/site/home/itocar/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/localdisk/itocar/gopath/"
GORACE=""
GOROOT="/localdisk/itocar/golang"
GOTMPDIR=""
GOTOOLDIR="/localdisk/itocar/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build447443283=/tmp/go-build -gno-record-gcc-switches"
```
/proc/cpuinfo:
model name : Intel(R) Xeon(R) CPU E5-2609 v3 @ 1.90GHz

What did you do?

I've compared performance of 1.9 vs trunk on builtin benchmarks with -cpu=1 and found that  some of them have regressed. Changes in performance were bisected to  28e1a8e47aa089e781aa15bdd16e15265a5180bd  which caused:

cmd/compile/internal/ssa/Fuse/10000      33.2ms Â± 2%     38.1ms Â± 2%     +14.62%
text/template/parse/ParseLarge     43.2ms Â± 1%     49.1ms Â± 2%     +13.60%  (p=0.000 n=8+8)  

This is reproducible only with go test -cpu=1 -bench=......
I doubt that -cpu=1 case is important, but CL message didn't mention performance impact, so I'm opening this.
Repository: go
Issue: database/sql/v2: what would a Go 2 version of database/sql look like?
Labels: v2,NeedsInvestigation

We're wondering what the story for database/sql might be for Go 2. We agree it's clearly important to be maintained (including ongoing maintenance including but definitely not limited to Google support).

Whether the package lives in std or x/foo is out of scope for this bug. (We'll wait until package management is figured out more first.)

But given what we know now, what would a fresh database/sql look like for Go 2?

Experience reports, docs, API proposals welcome.

@kardianos, could you write up your wishlist?
Repository: TypeScript
Issue: JSDoc Object literal not parsed ignoring leading star, leading to parse error
Labels: Bug,Domain: JSDoc,Domain: JavaScript

**Code**
`allowJs` and `checkJs` are on.
```ts
/** @typedef {{
 *     type: string,
 *     header: {text: string},
 *     longestChain: {duration: number, length: number, transferSize: number},
 *     chains: !Object<string, !CriticalRequestChainRenderer.CRCNode>
 * }}
 */
CriticalRequestChainRenderer.CRCDetailsJSON; // eslint-disable-line no-unused-expressions
```

**Expected behavior:**
A strongly typed `CriticalRequestChainRenderer.CRCDetailsJSON`

**Actual behavior:**
```
front_end/audits2/lighthouse/renderer/details-renderer.js(294,2): error TS1131: Property or signature expected.
```
(An error on the first leading `*` in the comment-embedded object literal.)