sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: terminal
Issue: Enable ClearType by default
Labels: Area-Rendering,Area-Settings,Product-Terminal,Issue-Task

# Description of the new feature/enhancement

In testing I found absolutely no difference in visual appearance on my 27" 4K display (163ppi), but a noticeable improvement in clarity/readability on my 27" 1440p display (109ppi).

# Proposed technical implementation details (optional)

There's two ways we can go about this:
* Enable ClearType for everyone under all circumstances
  * Pro: A single line change in our settings model.
  * Con: Uses 4x more memory for glyphs (4MB -> 16MB @ 2048x2048).
    But this could be a future-us concern, since right now we always use such a 16MB texture.
* Enable ClearType only at 100% display scale
  * Pro: Less memory usage in the future.
  * Con: Another "default" setting is needed in the settings model.
Repository: rust
Issue: Tidy check for io::ErrorKind::Other in std code
Labels: A-testsuite,T-infra

We have a note in the ErrorKind [documentation](https://doc.rust-lang.org/nightly/std/io/enum.ErrorKind.html#variant.Other):

> This [ErrorKind](https://doc.rust-lang.org/nightly/std/io/enum.ErrorKind.html) is not used by the standard library.

but in practice, there are cases were we do make use of it, whether in tests or by accident. We should add a check in tidy that the ErrorKind::Other string doesn't show up in std code, with an ability to opt-out similar to style checks (probably on the same line only would be best).

The ideal of course is a compiler check but I don't think there's much we can do there without a custom lint, which seems like way too much effort. The tidy check can miss things (e.g., glob imports), but that's OK.
Repository: pytorch
Issue: Cannot index into a tensor using indices from another device - regression from 1.12
Labels: triaged,module: regression,module: advanced indexing

### 🐛 Describe the bug

This code works on MPS in pytorch stable `1.12.1`, and also I presume in CUDA (this comes from the [stable-diffusion model](https://github.com/CompVis/stable-diffusion/blob/69ae4b35e0a0f6ee1af8bb9a5d0016ccb27e36dc/ldm/models/diffusion/ddpm.py#L1030), which was trained on CUDA originally).
_Note: you will need to launch python with `PYTORCH_ENABLE_MPS_FALLBACK=1` to get a CPU fallback for `aten::index.Tensor`. that might also explain why it works in stable._

```python
from torch import tensor
tensor([1.], device='cpu')[tensor([0], device='mps')]
# result: tensor([1.])
```

fails in nightly `1.13.0.dev20220917` with:

```
RuntimeError: indices should be either on cpu or on the same device as the indexed tensor (cpu)
```

I was able to [change the model code to fix it](https://github.com/Birch-san/stable-diffusion/commit/46f793b5ecd5bdd70ee8c9da9c6f379aa566afc5). but since this worked on CUDA and it's a pattern people are using in the wild: other models may be affected.

### Versions

```
PyTorch version: 1.13.0.dev20220917
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: macOS 12.5 (arm64)
GCC version: Could not collect
Clang version: 13.0.0 (clang-1300.0.29.30)
CMake version: version 3.22.1
Libc version: N/A

Python version: 3.10.4 (main, Mar 31 2022, 03:37:37) [Clang 12.0.0 ] (64-bit runtime)
Python platform: macOS-12.5-arm64-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

Versions of relevant libraries:
[pip3] numpy==1.22.4
[pip3] pytorch-lightning==1.7.5
[pip3] torch==1.13.0.dev20220917
[pip3] torch-fidelity==0.3.0
[pip3] torchdiffeq==0.2.3
[pip3] torchmetrics==0.9.3
[pip3] torchtyping==0.1.4
[pip3] torchvision==0.14.0.dev20220917
[conda] numpy                     1.22.4                   pypi_0    pypi
[conda] pytorch-lightning         1.7.5                    pypi_0    pypi
[conda] torch                     1.13.0.dev20220917          pypi_0    pypi
[conda] torch-fidelity            0.3.0                    pypi_0    pypi
[conda] torchdiffeq               0.2.3                    pypi_0    pypi
[conda] torchmetrics              0.9.3                    pypi_0    pypi
[conda] torchtyping               0.1.4                    pypi_0    pypi
[conda] torchvision               0.14.0.dev20220917          pypi_0    pypi
```

cc @kulinseth @albanD
Repository: go
Issue: x/pkgsite: present GOOS/GOARCH info of a vulnerability if relevant
Labels: pkgsite,vulncheck or vulndb

For example, https://pkg.go.dev/vuln/GO-2021-0098 is a vulnerability report that is relevant on windows.
As `govulncheck` now present GOOS/GOARCH info, consider to include this platform info in the vulnerability detail page.
Repository: opencv
Issue: imread can't read usgs ascii dem file
Labels: category: 3rdparty

Hello, 
  Now I read usgs ascii dem file using the **imread** function, which failed, so  i also debug the example gdal-image, and it also raised the following error, and i google the fuctionality about if can distinguish that format, maybe it is.

So, i would like to know if the **imread** can load USGS ascii dem file?


- OpenCV => pencv-4.5.5
- Operating System / Platform => Ubuntu 20.04
- Compiler =>gcc

Error on **grfmt_gdal.cpp: 396**
/**
 * read data
*/
bool GdalDecoder::readData( Mat& img ){
...
        **switch (band->GetColorInterpretation()) {** 
...
        **default:  --> **go into this error**
            CV_Error(cv::Error::StsError, "Invalid/unsupported mode");
        }**

**GDAL information:**
$ gdalinfo xxx/DEM.dem
Driver: AAIGrid/Arc/Info ASCII Grid
Files: xxx/DEM.dem
       xxx/DEM.dem.aux.xml
Size is 10, 10
Origin = (5000.000000000000000,1100.000000000000000)
Pixel Size = (10.000000000000000,-10.000000000000000)
Corner Coordinates:
Upper Left  (    5000.000,    1100.000) 
Lower Left  (    5000.000,    1000.000) 
Upper Right (    5100.000,    1100.000) 
Lower Right (    5100.000,    1000.000) 
Center      (    5050.000,    1050.000) 
Band 1 Block=10x1 Type=Int32, ColorInterp=Undefined
  Min=-2.402 Max=71.305 
  Minimum=-2.402, Maximum=71.305, Mean=7.910, StdDev=13.143
  NoData Value=-9999
  Metadata:
    STATISTICS_MAXIMUM=71.305
    STATISTICS_MEAN=7.909708585886
    STATISTICS_MINIMUM=-2.402
    STATISTICS_STDDEV=13.143031186516
    STATISTICS_VALID_PERCENT=97.39


The DEM file: 
[usgs-ascii-dem.txt](https://github.com/opencv/opencv/files/9621585/usgs-ascii-dem.txt)


Regards
Repository: go
Issue: x/net/webdav: cannot handle symbolic link that points to a non existed file
Labels: NeedsInvestigation

### What version of Go are you using (`go version`)?

<pre>
$ go version
go1.18

</pre>

### Does this issue reproduce with the latest release?



### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jjm/Library/Caches/go-build"
GOENV="/Users/jjm/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/jjm/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jjm/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Volumes/data/src/gowebdav/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/7b/lr1hrhyd3ts3v_d8m7bjngdh0000gn/T/go-build747360344=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>

### What did you do?
I have build a [webdav server](https://github.com/jjm2473/gowebdav/tree/7d9a2b72040dbbcafd5ccda8364e0b1f2c8d5a59) and run it on a router, serve router's `/mnt` as webdav root, then mount it on macOS. When I create a symbol link in /mnt `ln -s /tmp/noexist /mnt/noexist` (`/tmp/noexist` does not existed)，then `PROPFIND /` with `Depth=1` will get a `Internal Server Error` (Wireshark capture below).

```
===== Request =====
PROPFIND / HTTP/1.1
Host: 192.168.31.1:6086
Content-Type: text/xml
Depth: 1
Accept: */*
User-Agent: WebDAVFS/3.0.0 (03008000) Darwin/21.6.0 (x86_64)
Authorization: Basic ***
Content-Length: 179
Connection: keep-alive

<?xml version="1.0" encoding="utf-8"?>
<D:propfind xmlns:D="DAV:">
<D:prop>
<D:getlastmodified/>
<D:getcontentlength/>
<D:creationdate/>
<D:resourcetype/>
</D:prop>
</D:propfind>

===== Response =====
HTTP/1.1 207 Multi-Status
Content-Type: text/xml; charset=utf-8
Date: Thu, 22 Sep 2022 06:12:53 GMT
Content-Length: 516

<?xml version="1.0" encoding="UTF-8"?><D:multistatus xmlns:D="DAV:"><D:response><D:href>/</D:href><D:propstat><D:prop><D:getlastmodified>Thu, 22 Sep 2022 06:12:32 GMT</D:getlastmodified><D:resourcetype><D:collection xmlns:D="DAV:"/></D:resourcetype></D:prop><D:status>HTTP/1.1 200 OK</D:status></D:propstat><D:propstat><D:prop><D:getcontentlength></D:getcontentlength><D:creationdate></D:creationdate></D:prop><D:status>HTTP/1.1 404 Not Found</D:status></D:propstat></D:response></D:multistatus>Internal Server Error

```



### What did you expect to see?
List root dir


### What did you see instead?
Internal Server Error
Repository: PowerToys
Issue: Auto moving windows during keyboard shortcut trigger
Labels: Needs-Triage

### Description of the new feature / enhancement

What I mean by the title is - currently I can set the windows key to trigger a window to snap into a zone by using windows+arrow keys.

Awesome.

If I have three columns and am trying to move my third column window over to the middle column, I end up having two programs in the same column and now my third column is empty.

It would be nice to have the app that was originally in the middle column move to an empty column snapping zone during my moving a third column app to a middle column position.



### Scenario when this would be used?

Think of it like an auto window manager, instead of me having to manually move the other window that was already in the middle column.
![the current challenge of manually moving windows](https://user-images.githubusercontent.com/29111183/191692469-f9258841-2d45-4a1b-9485-c7375dbaa739.gif)


### Supporting information

_No response_
Repository: TypeScript
Issue: Cannot Omit specific fields of react polymorphic components
Labels: Needs Investigation,Rescheduled

# Bug Report

### Versions

"@types/react": "18.0.17",
"@types/react-dom": "18.0.6",
"typescript": "4.6.2"

### ⏯ Playground Link

[Playground link with relevant code](https://www.typescriptlang.org/play?#code/FAFwngDgpgBAggZwAoCcD2EA8BhGUAeIUAdgCYIwBKUAhgMYgB0AogDZQC2JIAKpFAD4YAXhgBvYDBgB6AFSzJU2fGIw0ANygoUAS1Kw0AMxggAFrH2GaAV1YgYACR4BZADImaAc0aKYy7DSqNKwIaDAARrCBaGZaVLQMMHRoHBBoxNw+Un7SijQIAPwAXDDYANzAAL4VwHIKfvCsrGgA7hSGaChqmtp6UTAIUPZGMBDoEBQAFAAGzNMAlBFgMIHdWrqkOsSeA0NqxmMYCJLKMwDyCwA0eMQI1rrbJqY09oHLpNYQrDp0L1AUNBQBh6G30qnCy1ia16m22J12wwO4wQWVkuXA0BgZxBeho4XYqCOmGYInElWuZ1JYkqQlElIAZFiODoQMTrgBrKBgEZnAQ1OrwuBNVrtTowLbmXQgLY7KGHCYwQzoDhPWAIaB0HSGHRQUh4dhcYj2DFqsJmF7w+UUb6cpKmHSsUhA4jXOisfIIAByNC4MEZCHA7BgLU67Ou+WDUCaKwoUc43AAtOqoJrtXR4S8QLpwtYiNadLbAToaDB0OwUTAeOYkik0hkjTAZtgFjAONYAxFYBAPbrxcRUej+DAAJLESUsvHsNjxo2EiaYRS4AhEMgUaj0JjTw28fiXRRIKmVRTSaSlqBfeiwEBhdcMRjYWvpbhzhAAdRZpmoxhaDtYAx9UDALSWI4qQk5QC+mC3kwD6pE+s7Iu+ZhoLmX44AI1xIHywC1PIgqtp0poQPaAY-H8eo9AgOjpPsMDTKO44gOBW7Psi0zBpKgENHKPZ6lsdH5Ox8rBr+MD6EQKDMhkHE-KYozIkkqyRH2brWPopAnIOmJIGgrBgBwnTET8sF1qxRKLnghAkOQ8QbiwBrcHw0B7lIB6iNSQGkgxWgTviUAsQhRLYJhfrwMg4zodhOE6HBKD2NBirKjAABEQIbslNQmjAzi0HcQIoC+h41Mktz2Dl+T3HEoiYDwlkrjZ0H2TOO6YqIyWbOoyUCJMEhSHQ9qOs6LkxsNjBjUxnhwCAWZVCUZzMqyOl6QZKBGXQJnwSAkE8Nc5V5VoL4YSlQKGF1izCEIvU1qVlZeKSEYAD4PSlHUZYoJUdidpKNe2UBoY1G31ltyI1QIADaqVQKdAC63XzDUUhAiA9yqDVd1iGNjATVNWaVGehjCGIJ00pg0g8F42HVDhBBpHFYlQzYdjZbllUoBUQA)

### 💻 Code

```ts

type AsProp<C extends React.ElementType> = {
  /**
   * An override of the default HTML tag.
   * Can also be another React component.
   */
  as?: C;
};

type OverridableProps<E = {}, O = {}> = O & Omit<E, keyof O>;

type InheritableElementProps<
  C extends React.ElementType,
  P = {}
  // replace to React.ComponentPropsWithRef will same error
> = OverridableProps<React.ComponentPropsWithoutRef<C>, P>;

type PolymorphicComponentProps<
  C extends React.ElementType,
  P = {}
> = InheritableElementProps<C, P & AsProp<C>>;

import React from "react";

type MeasurerProps = {};

const Measurer = <T extends React.ElementType = "div">({
  children,
  as,
  ...tagAttr
}: Omit<PolymorphicComponentProps<T, MeasurerProps>, "ref">) => {
  const Tag = as || "div";
  const ref = React.useRef<React.ComponentProps<T>["ref"]>();

  // ts error: JSX element type 'Tag' does not have any construct or call signatures.ts(2604)
  return <Tag {...tagAttr} ref={ref}></Tag>;
};

export default Measurer;
```

### 🙁 Actual behavior

<!-- What happened, and why it was wrong -->
ref cannot omit from props

### 🙂 Expected behavior

refs (generic props) should be omited correctly, and the `Tag` should not report errors
<!-- What you expected to happen instead, and why -->
Repository: three.js
Issue: Transfer the ownership of this repo to an organization account
Labels: Suggestion

<!-- Ignoring this template may result in your feature request getting deleted -->

**Is your feature request related to a problem? Please describe.**

This repo is currently under a personal account.  Under some unfortunate situations, this might be disadvantageous for this project's development.

> Projects maintained and managed by one sole organization owner can easily become inaccessible if the organization owner is unreachable. We recommend an organization have at least two people with owner permissions to ensure no one will lose access to a project. For more information, see "[Maintaining ownership continuity for your organization](https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/maintaining-ownership-continuity-for-your-organization)."
> [*About organizations* -- GitHub Docs][1]

**Describe the solution you'd like**

1. Open an [organization account][1] with a name like "three.js".
2. Name another active collaborator as an owner.

**Describe alternatives you've considered**

N/A

**Additional context**

N/A

[1]: https://docs.github.com/en/organizations/collaborating-with-groups-in-organizations/about-organizations
Repository: storybook
Issue: 'children' does not exist on Canvas element from addon-docs
Labels: bug,needs triage

**Describe the bug**
ERROR in C:/Users/G024837/IdeaProjects/builders-core/storybook/src/theme/layout.tsx(80,14):
TS2322: Type '{ children: Element; className: string; withSource: SourceState.NONE; }' is not assignable to type 'IntrinsicAttributes & PreviewProps & { withSource?: SourceState; mdxSource?: string; }'.
  Property 'children' does not exist on type 'IntrinsicAttributes & PreviewProps & { withSource?: SourceState; mdxSource?: string; }'.
  
Receiving this type error when trying to ugrade project to React 18. 

![image](https://user-images.githubusercontent.com/14996120/191704452-ae482020-9766-4b8d-8e85-dbf8e7c6d898.png)


**System**
Environment Info:

  System:                                                  
    OS: Windows 10 10.0.19042                              
    CPU: (12) x64 Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
  Binaries:
    Node: 16.17.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.15.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 103.0.5060.134
    Edge: Spartan (44.19041.1266.0), Chromium (105.0.1343.27)


**Additional context**
Add any other context about the problem here.
Repository: material-ui
Issue: ListItem checkbox not spoken by screenreader (WCAG)
Labels: docs,accessibility,component: list

### Duplicates

- [X] I have searched the existing issues

### Latest version

- [X] I have tested the latest version

### Steps to reproduce 🕹

Steps:

1. install screenreader extension in chrome browser
2. surf to https://v4.mui.com/components/lists/
3. scroll down to List Controls - Checkbox example
4. start screenreader extension
5. use tab key to move up and down list. screenreader sais "Line item 1" but nothing about checkbox
6. use space key to set/unset checkbox. screenreader is quiet


### Current behavior 😯

screenreader sais nothing about checkbox in listitem

### Expected behavior 🤔

screenreader should inform user of checkbox state

### Context 🔦

WCAG compliance

### Your environment 🌎

<details>
  <summary><code>npx @mui/envinfo</code></summary>

```
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
```
</details>
Repository: rust
Issue: Duplicated WASM `unreachable` instructions
Labels: A-LLVM,A-codegen,T-compiler,C-bug

Targets: `wasm32-unknown-unknown`, `wasm32-wasi`

When calling `core::arch::wasm32::unreachable()`, the generated WASM contains two `unreachable` instructions instead of only one.

Example:
```rust
pub fn main(){
    core::arch::wasm32::unreachable();
}
```

Output (from Godbolt):
```
example::main:
        unreachable
        unreachable
        end_function
```

Godbolt link: https://rust.godbolt.org/z/Yqz6Kh9eq

This is mostly noticeable when using `build-std-features=panic_immediate_abort` (which I know is unstable), as all instances of `panic!()` are basically replaced with `unreachable()`, and then compile down to two `unreachable` instructions.

This behavior appears to have been present since `core::arch::wasm32::unreachable()` was made available, so this is not a regression.
Repository: PowerToys
Issue: [FancyZones Editor] editer looks blur on multi monitor/dpi-scaling system
Labels: Issue-Bug,Needs-Triage

### Microsoft PowerToys version

0.62.1

### Running as admin

- [X] Yes

### Area(s) with issue?

FancyZones Editor

### Steps to reproduce

1. setup a multi monitor/dpi-scaling system
    * monitor 0: 2560x1440 150% (primary)
    * monitor 1: 3840x2160 200%
2. open FancyZones Editor on monitor 1

### ✔️ Expected Behavior

Clear text and interface.

### ❌ Actual Behavior

![image](https://user-images.githubusercontent.com/57629614/191731598-bc740ab7-5401-4e1a-80ed-7f51669eef16.png)


### Other Software

System Information:
* 版本	Windows 11 专业版
* 版本	22H2
* 安装日期	‎2022/‎9/‎21
* 操作系统版本	22621.521
* 体验	Windows Feature Experience Pack 1000.22634.1000.0
Repository: neovim
Issue: Bad perf for large file using treesitter with injections query
Labels: bug,performance,treesitter

### Neovim version (nvim -v)

NVIM v0.8.0-dev-1137-g7fc5f6605

### Vim (not Nvim) behaves the same?

no

### Operating system/version

ArchLinux

### Terminal name/version

Alacritty

### $TERM environment variable

alacritty

### Installation

build from repo

### How to reproduce the issue

1. `curl "https://raw.githubusercontent.com/tree-sitter/tree-sitter-javascript/936d976a782e75395d9b1c8c7c7bf4ba6fe0d86b/src/parser.c" | nvim --clean +'set ft=c'`
2. `:lua vim.treesitter.start()`

### Expected behavior

Don't hang.

### Actual behavior

Hang.


The culprit is injection. Only empty `/queries/c/injections.scm` can stop using injection. `lua vim.treesitter.set_query('c', 'injections', '')` still create a object to enable injection.
Repository: godot
Issue: Conversion Tool Problem
Labels: bug,topic:editor

### Godot version

4 Beta 1

### System information

Windows 10

### Issue description

I converted my 3.5 project to 4
there is a "world" folder in the res where i store some of my stuff
the conversion tool exchanged all references from world to world3d wich broke plenty of links and references

### Steps to reproduce

convert a 3.5 project with a world folder in res

### Minimal reproduction project

_No response_
Repository: PowerToys
Issue: PowerRename - easy way to rename blank / space, also add example to documentation
Labels: Needs-Triage

### Description of the new feature / enhancement

I am looking for an easy way to replace spaces in filenames with something, for example '_' or '-'.

Most of the time it works with `\s` (but somehow not always). And if you don't do it that often, you have to remember it or search for it again and again.

I am not a regex specialist. And maybe you can implement this in a user-friendly way so that there is an explicit option: "Replace space with: ...". Then you don't need to worry about the regex syntax.

Even if the feature should not exist as an explicit option, a short addition of an example in the PowerRename documentation on how to replace spaces with the existing implementation would be helpful.

### Scenario when this would be used?

Spaces in file names sometimes cause problems. There is often a need to avoid spaces.

### Supporting information

_No response_
Repository: ant-design
Issue: Hide Upload button if maxCount was reached
Labels: Inactive

### What problem does this feature solve?

Extra space in the forms

### What does the proposed API look like?

<Upload maxCount={1} hideUploadButtonOnMaxCount></Upload>

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: deno
Issue: Runtime API to check whether in self-contained exe
Labels: good first issue,feat,compile

I couldn't find a runtime API to check whether the current code is running inside a self-contained exe.

This would make it easy to distinguish between the "production" (compiled) version and testing via `deno run`.

I was thinking about something like `Deno.standalone` or maybe something more descriptive like `Deno.selfContainedExe`.
Repository: flutter
Issue: [go_router] NavigatorObserver route.settings is null for pageBuilder routes in 5.0.1
Labels: package,has reproducible steps,P2,p: go_router,found in release: 3.3,found in release: 3.4,team-go_router,triaged-go_router

## Steps to Reproduce

You can run the app at https://github.com/jonmountjoy/bug_nav

If you navigate to any route that is constructed with a `builder`, such as:
```dart
GoRoute(
            name: 'page2',
            path: 'page2/:p1',
            builder: .... )
```

Then a navigation observer `didPush` has the `route.settings` setup just fine, and you can determine the name of the route, and other details.

If you navigate to any route that is constructed with a `pageBuilder`, such as:
```dart
GoRoute(
            name: 'page2alternative',
            path: 'page2alternative/:p1',
            pageBuilder: (BuildContext context, GoRouterState state) =>
                const NoTransitionPage<void>(
                    child: Page2Screen(name: "alternative")),
          ),
```

Then a navigation observer `didPush` has the `route.settings` set to null. 

**Expected results:** 

I expect the navigation observer to allow me to observe all routes.
My intent is to send all navigated routes to Google Analytics.


**Actual results:**

There's not enough information in the navigation observer.