sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: x/mobile: Binding go mobile framework on windows with $GOPATH that contains whitespace fails
Labels: OS-Windows,mobile

Please answer these questions before submitting your issue. Thanks!


### What version of Go are you using (`go version`)?
go version go1.10.2 windows/amd64

### Does this issue reproduce with the latest release?
Yes

### What operating system and processor architecture are you using (`go env`)?
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Jakub Tomana\AppData\Local\go-build
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\Jakub Tomana\go
set GORACE=
set GOROOT=C:\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\tmp\go-build226750162=/tmp/go-build -gno-record-gcc-switches

### What did you do?

Run ```gomobile bind -target=android projectName```command, with ```$GOPATH``` set to directory that contains whitespace 

### What did you expect to see?
Generated .aar file

### What did you see instead?
```
gomobile: go build -buildmode=c-shared -o=C:\tmp\gomobile-work-583627471\android\src\main\jniLibs\armeabi-v7a\libgojni.so gobind failed: exit status 2
# runtime/cgo
exec: "C:\\Users\\My": file does not exist
```
In this example user path is `C:\\Users\My Name`
Repository: vscode
Issue: Feature Request: Enable valueSelection for InputBox
Labels: feature-request,api,quick-pick

<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
# Description
Enable the [`valueSelection`](https://code.visualstudio.com/docs/extensionAPI/vscode-api#InputBoxOptions) option of the `winddow.showInputBox` command for the more extensive [`InputBox`](https://code.visualstudio.com/docs/extensionAPI/vscode-api#InputBox) API, too.
Repository: godot
Issue: Tree minimum column width completely hides text if set below 13 pixels, even if the text is set to expand
Labels: bug,confirmed,topic:gui

Godot 3 master ff8e6f920cd99954c3394412713950c1195199f2

I made a tree with 2 levels:
The first level shows files in a single expanding column.
The second level shows empty cells as the first column (they are conditionally sized), and text as the second column.

In order for the first column of the second level to not expand to half of the width, I usually set the minimum width to 32 and tell them to not expand, but if I want them hidden I set their minimum width to 1 so I don't have to change indexes in my code all over the place (it's a good hack IMO because it's theoretically legit).
Due to this, I also tell the first-level individual items to actually `expand_right`, so I can get this:

![image](https://user-images.githubusercontent.com/1311555/44310265-3bb1d980-a3cb-11e8-99fe-c28ef2929f1b.png)

But I found a problem:
I ended up in a situation where, if I set the minimum size of the first column below 13, the first-level text completely hides. This is NOT expected, because as said above I've set it to `expand_right` anyways, and 12 is not zero yet it still hides it all.

![image](https://user-images.githubusercontent.com/1311555/44310268-479d9b80-a3cb-11e8-8c68-acbac2651f76.png)

I haven't tested further, maybe the issue is actually simpler than it looks and minimum width breaks it in any case? Is this all because of the arrow?

Found this while improving #21166, I will have to workaround this by actually changing the amount of columns dynamically.

test project:
[SearchResultsList.zip](https://github.com/godotengine/godot/files/2300412/SearchResultsList.zip)
Go to `tree.gd` and play with the value at line 9
Repository: godot
Issue: Weird behaviours with soft body node under kinematic parent
Labels: bug,topic:physics

**Godot version:**
`master` / c93888ae71b

**OS/device including version:**
Manjaro Linux 17.1

**Issue description:**
When adding a soft body node under a rigid/kinematic parent, it would act like there's an invisible collider which roughly matches the node's visible position.

Also, if I move the parent kinematic node, the soft body child moves in the opposite direction from its parent, as if it uses a different transform coordinates.

In fact, I found that transform related values returned by the soft body node to be rather off. For instance, if I print the distance from the camera position to such a node, it returns a larger number than that which is returned from a non-soft body mesh instance located further from the camera.

And it also returns a wrong AABB value, apparently.

You can watch a video which shows some of the above mentioned problems from the link below:
 * https://youtu.be/YOgK8xNaLns
Repository: rust
Issue: Sort-of RFC: add `min!`, `max!` macros once namespacing lands
Labels: T-libs-api,C-feature-request

Since you can namespace macros in rust 2018, maybe consider including min and max macros in `std::cmp`?

From [a post about gamedev on rust](https://users.rust-lang.org/t/my-gamedever-wishlist-for-rust/2859?u=erlend_sh)

> > There’s no min! and max! macro. You need to write max(max(max(max(max(max, a), b), c), d), e) for example. I have a code with 15 max like this.
>
> This seems like a macro you can write yourself easily enough. Is there something I’m missing?
>
> ```
> macro_rules! max {
>      ($e: expr) => { $e };
>      ($e: expr, $($rest: tt)*) => { max($e, max!($($rest)*)) }
> }
>```
Repository: go
Issue: cmd/go: 'go test --race' needs gcc for main packages on windows
Labels: RaceDetector,OS-Windows,NeedsInvestigation

### What version of Go are you using (`go version`)?

go version go1.11rc1 windows/amd64

### Does this issue reproduce with the latest release?

- Yes, reproduces with `go 1.11rc1`
- No, doesn't reproduce with `go 1.10.3`

### What operating system and processor architecture are you using (`go env`)?

```
windows/amd64
```

```
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\jud_white\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Projects\Go
set GOPROXY=
set GORACE=
set GOROOT=C:\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\JUD_WH~1\AppData\Local\Temp\go-build672193350=/tmp/go-build -gno-record-gcc-switches
```

### What did you do?

```
$ go test -cpu 1,2,4 -count 1 --race ./hello/...
# runtime/cgo
exec: "gcc": executable file not found in %PATH%
FAIL    git.xyz.com/{org}/{repo}/cmd/hello [build failed]

$ go test -cpu 1,2,4 -count 1 ./hello/...
ok      git.xyz.com/{org}/{repo}/cmd/hello   0.105s
```

It doesn't happen for non-main packages:

```
$ go test -cpu 1,2,4 -count 1 --race ./hellopkg/...
ok      git.xyz.com/{org}/{repo}/pkg/hellopkg      10.220s
```

`--race` by itself is sufficient to repro, you don't need to set the CPU count or disable caching.

### What did you expect to see?

```
ok      git.xyz.com/{org}/{repo}/cmd/hello   0.XYZs
```

### What did you see instead?

```
# runtime/cgo
exec: "gcc": executable file not found in %PATH%
FAIL    git.xyz.com/{org}/{repo}/cmd/hello [build failed]
```
Repository: pytorch
Issue: GenerateProposals CUDA implementation
Labels: caffe2

Hi, Would you please support GenerateProposals CUDA implementation? 
thanks.
Repository: godot
Issue: Implicit type conversion from Real to Int differs between branch statements
Labels: discussion,topic:gdscript

**Godot version:**
faa49c1

**Issue description:**
Reals with integral values seem to be implicitly converted to int for comparisons in `if` blocks, but not with `match` blocks.  This probably also affects 3.0.x, but I haven't tested it.

**Steps to reproduce:**
Using parse_json() to produce TYPE_REAL values that match whole number values.

```gdscript
enum matchType { A,B,C }
var chunk = parse_json("[0,1,2]")

func _ready():
	match chunk[0]:
		matchType.A:
			print ("This should be the proper response.")
		0:
			print("This should also work, but short-circuiting failed?")
		_:
			print("This shouldn't happen.", matchType.A)

	if chunk[0] == 0:  print("Implicit conversion to int works with Ifs, though.")
```

Workaround:  Explicitly cast `match` value to Int, where applicable.
Repository: three.js
Issue: three.js documentation Chinese version
Labels: Documentation

Hi, We are a team from china who love open source.We want to translate the documentation into 
Chinese. About now our plan is to translate pages and convert them into static pages. 
So I want to know how we can put these pages into this repo , or merge them into the threejs.org documentation part?
Pleased to hear reply.
Repository: create-react-app
Issue: Move launch-editor logic to react-error-overlay
Labels: issue: proposal

### Request

It would be awesome if we could move all react-error-overlay logic into the [react-error-overlay](https://github.com/facebook/create-react-app/tree/next/packages/react-error-overlay) package.

### Reason

Currently it is not possible to use all features [react-error-overlay](https://github.com/facebook/create-react-app/tree/next/packages/react-error-overlay) without installing [react-dev-utils](https://github.com/facebook/create-react-app/tree/next/packages/react-dev-utils). 

### Files that should be migrated:

- [react-dev-utils/errorOverlayMiddleware.js](https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/errorOverlayMiddleware.js)
- [react-dev-utils/launchEditor.js](https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/launchEditor.js)
- [react-dev-utils/launchEditorEndpoint.js](https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/launchEditorEndpoint.js)

### Related

https://github.com/zeit/next.js/pull/4979#discussion_r211121346

###  ~~Alternative~~

Solved by https://github.com/yyx990803/launch-editor/

~~As an alternative it would also make sense to move the [react-dev-utils/launchEditor.js](https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/launchEditor.js) into its own package. The electron community might appreciate it.~~

~~Since there is already an [open-editor](https://www.npmjs.com/package/open-editor) package on npm this would be a great place. (https://github.com/sindresorhus/open-editor/issues/4)~~
Repository: godot
Issue: TabContainer: switching tabs while editing by clicking on the tab
Labels: enhancement,topic:editor,topic:gui

Minor enhancement.
When editing controls inside a _TabContainer_, it's annoying to have to click the _TabContainer_ and changing the _Current Tab_ property to switch the tab. It should be possible to directly click on the tabs and make the _Current Tab_ property automatically change. I've seen this feature in some GUI widgets editors.

Bonus: tabs' content controls that are not the currently selected, are set to visible=false. Clicking on the eye icon near the node should change the currently selected tab too.
Repository: pytorch
Issue: Tensor.register_hook is not passing the tensor object to the hook function
Labels: module: bc-breaking,triaged,enhancement

I am currently working with `Tensor.register_hook` and I want to manipulate the gradients of a parameter with respect to the values of its data, i.e., the weights or bias itself. This would be very easy if `self` is also passed to the hook function such as for the hooks registered with `Module.register_backward_hook `. Is there a reason why this is not done? This could be achieved by adding:
```
wrapper = functools.partial(hook, self)
functools.update_wrapper(wrapper, hook)
```
to the `register_hook` method.

cc @ezyang @gchanan
Repository: angular
Issue: SelectControlValueAccessor overwriting NativeElement's value if using custom control value accessor
Labels: type: bug/fix,freq2: medium,area: forms,state: confirmed,state: needs more investigation,P4

<!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.

ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->

## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:
</code></pre>

## Current behavior
<!-- Describe how the issue manifests. -->
I'm using custom control value accessor UseValueAsNumber with ReactiveForms on SELECT element but default SelectControlValueAccessor from Angular is overwriting values set by UseValueAsNumber.

The problem seems to be following:
1. UseValueAsNumber sets NativeElement value through:
`this.renderer.setProperty(
      this.elementRef.nativeElement,
      'value',
      this.value
    );
`
2. After the value is set correctly, the `NgSelectOption.setValue()` method is fired which internally calls `if (this._select) this._select.writeValue(this._select.value);`. However `this._select.value` is `undefined` (as there is only 1 ControlValueAccessor allowed per FormControl) but `this._select` (which is in fact SelectControlValueAccessor instance) overwrites NativeElement's value to `undefined` and in HTML the correct value is never selected.


## Expected behavior
<!-- Describe what the desired behavior would be. -->
Do not overwrite NativeElement's value property in order to display correct value in HTML.

## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).
-->
https://stackblitz.com/edit/angular-gitter-marugk

## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->


## Environment

<pre><code>
Angular version: 6.1.3
<!-- Check whether this is still an issue in the most recent Angular version -->

Browser:
- [x ] Chrome (desktop) version 68.0.3440.106
Repository: pytorch
Issue: make install error： [third_party/gloo/gloo/CMakeFiles/gloo.dir/all] Error 2
Labels: module: build,triaged,module: third_party

when complile at linux: I meet this error,thanks!

In file included from /disk1/g201708021059/gg/pytorch/third_party/gloo/gloo/context.cc:12:0:
/disk1/g201708021059/gg/pytorch/third_party/gloo/gloo/common/error.h:25:46: error: expected class-name before ‘{’ token
/disk1/g201708021059/gg/pytorch/third_party/gloo/gloo/common/error.h: In constructor ‘gloo::Exception::Exception(const string&)’:
/disk1/g201708021059/gg/pytorch/third_party/gloo/gloo/common/error.h:27:66: error: expected class-name before ‘(’ token
/disk1/g201708021059/gg/pytorch/third_party/gloo/gloo/common/error.h:27:66: error: expected ‘{’ before ‘(’ token
make[2]: *** [third_party/gloo/gloo/CMakeFiles/gloo.dir/context.cc.o] Error 1
make[1]: *** [third_party/gloo/gloo/CMakeFiles/gloo.dir/all] Error 2
make: *** [all] Error 2


If you have a question or would like help and support, please ask at our
[forums](https://discuss.pytorch.org/).

If you are submitting a feature request, please preface the title with [feature request].
If you are submitting a bug report, please fill in the following details.

## Issue description

Provide a short description.

## Code example

Please try to provide a minimal example to repro the bug.
Error messages and stack traces are also helpful.

## System Info
Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).

You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
```

- PyTorch or Caffe2:
- How you installed PyTorch (conda, pip, source):
- Build command you used (if compiling from source):
- OS:
- PyTorch version:
- Python version:
- CUDA/cuDNN version:
- GPU models and configuration:
- GCC version (if compiling from source):
- CMake version:
- Versions of any other relevant libraries:


cc @malfet @seemethere @walterddr
Repository: vue
Issue: Property 'X' does not exist on type CombinedVueInstance using TypeScript   Prop Validator
Labels: typescript

### Version
2.5.16

### Reproduction link
[https://codepen.io/muhammadrehansaeed/pen/XPWKyJ](https://codepen.io/muhammadrehansaeed/pen/XPWKyJ)





### Steps to reproduce
Use Typescript to build this component:

```
export default Vue.extend({
  props: {
    delay: {
      default: 600,
      type: Number,
      validator: function(value: number) {
        return value >= 0;
      }
    },
    minValue: {
      default: 0,
      type: Number
    }
  },
  data() {
    return {
      valueInternal: 0
    };
  },
  methods: {
    reset(): void {
      this.valueInternal = this.minValue; <----THIS LINE ERRORS
    }
  }
});
```

### What is expected?
The component builds.

### What is actually happening?
The following error is thrown:

```
Property 'minValue' does not exist on type 'CombinedVueInstance<Vue, { isVisibleInternal: boolean; valueInternal: number; }, { reset(): void; }, {}, Readonly<{}>>'.
methods: {
  reset(): void {
    this.valueInternal = this.minValue;
                                               ^
  }
}
````

If I remove the validator from the prop, the error goes away. If I remove the data section, the error also goes away.

<!-- generated by vue-issues. DO NOT REMOVE -->
Repository: pytorch
Issue: [feature request] convtbc with group convolution
Labels: feature,module: convolution,triaged

see title
Repository: vscode
Issue: Show file picker for 'path' string settings
Labels: feature-request,settings-editor

https://github.com/Microsoft/vscode/issues/50249#issuecomment-414362277
Repository: flutter
Issue: Need to provide a hook to prevent tests from timing out when debugging
Labels: a: tests,tool,P2,team-tool,triaged-tool

When debugging flutter tests with IntelliJ or another IDE, test timeouts still trigger which makes it frustrating to setbreakpoint within tests. As soon as you resume the debugger after hitting a breakpoint, the test you were trying to debug times out ending your debug session. 
The recently added `--pause-after-load` in `package:test` handles this case ignoring timeouts when the flag is set. For consistency it would be nice if the same flag also worked with `flutter test` causing timeouts to be ignored. Currently the workaround is to delete the body of the `_checkTimeout` method in `flutter_test/lib/src/binding.dart` 

See
https://github.com/dart-lang/test/pull/876
for the change to `package:test` to implement `--pause-after-load`
@grouma who implemented the feature for `package:test`
Repository: kubernetes
Issue: Make creationTimestamp a pointer
Labels: sig/api-machinery,lifecycle/frozen

Context: https://github.com/kubernetes/kubernetes/pull/67562#discussion_r211267314.

`creationTimestamp` is a struct (metav1.Time) right now:

https://github.com/kubernetes/kubernetes/blob/6d51311735705ecf30025df91216a82f397c9cfb/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/types.go#L175

However, it also has the `omitempty` json tag. The current behaviour at various places is to remove the field if it is an empty value.

From the [official docs](https://golang.org/pkg/encoding/json/#Marshal),

>  The "omitempty" option specifies that the field should be omitted from the encoding if the field has an empty value, defined as false, 0, a nil pointer, a nil interface value, and any empty array, slice, map, or string. 

This means that `omitempty` holds no meaning for structs. No matter what value `creationTimestamp` has, it should persist in the object. To truly adapt to it's intended behaviour, it should be a pointer (*time.Time), like `deletionTimestamp`. It also makes sense to have `creationTimestamp` as optional logically.

Right now, we don't allow an empty `creationTimestamp` to persist anyway, so it doesn't create a problem per se.

/sig api-machinery
/cc @sttts @liggitt @deads2k @lavalamp
Repository: go
Issue: x/tools/go/packages: test fails on plan9
Labels: Tools

golang.org/x/tools/go/packages tests are failing on Plan9:
https://build.golang.org/log/a8439e96692e223503e21df34d690fdc2bc75625
Specifically, when TestLoadImportsC loads syscall and net, the package "net [syscall.test]" is not among the loaded set. Disabling test for now. The task of this issue is a principled fix.
Repository: pytorch
Issue: Build system doesn't prevent ATen/core from including non-core files
Labels: module: build,triaged

Instead, you'll probably only see the failure as a linker error if you build, e.g., a Caffe2 only build.

CC @gchanan

cc @malfet @seemethere @walterddr
Repository: vue
Issue: Cache access to process.env
Labels: feature request

### What problem does this feature solve?
Access to `process.env` is a slow, system-bound call.

After react restructured their project to cache access to `process.env`, they had a 2.4x - 3.8x performance improvement for server-side rendering,

https://github.com/facebook/react/issues/812

This should also be done for vue, vue-server-renderer, vuex ... anything that accesses `process.env`.

### What does the proposed API look like?
An easy strategy might be to replace references to `process.env.NODE_ENV` with a reference to a singleton that checks process.env.NODE_ENV.

```
// foo.js
if (process.env.NODE_ENV !== 'production') {
  // do stuff
}
```

becomes

```
// isDevEnv.js
export default process.env.NODE_ENV !== 'production';

// foo.js
import isDevEnv from './isDevEnv';

if (isDevEnv) {
  // do stuff
}
```

<!-- generated by vue-issues. DO NOT REMOVE -->