sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: react
Issue: [Portals] DOM order accessibility
Labels: Status: Unconfirmed,Type: Discussion

**Components built with Portals include accessibility defects leading to poor usability/task abandonment.**

During accessibility audits and usability testing of Shopify components, we’ve noticed a prominent defect with components built with Portals; DOM structure.

Portals sets dynamically generated content containers at the bottom of the DOM. This is fine for modal window components since keyboard focus is explicitly placed on/within the modal container. The Portals documentation even calls this out and links to APG for more documentation.

The issue lies with other component patterns; [disclosures](https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/) (popovers, drop-down navigation, etc,) [comboboxes](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/), [tooltips](https://www.w3.org/WAI/ARIA/apg/patterns/tooltip/), etc. The expectation for these components is for focus to **remain** on the activator and for dynamic content containers to appear **next** in the DOM, a direct sibling to the related activator control.

For example, during usability testing, testers struggled to use one such component which was built using Portals. When the dynamic container appeared after interacting with the activator, testers would move their screen reader virtual cursor forward from the activator, expecting to interact with the dynamic content. Instead, the cursor moved "underneath" the container, bypassing the content, to the next (unrelated) item in the DOM. This led to a confusing user experience.

In addition, this issue is a violation of WCAG [1.3.2: Meaningful Sequence](https://www.w3.org/WAI/WCAG21/Understanding/meaningful-sequence.html) (Level A.) Specifically, [Failure of Success Criterion 1.3.2 due to changing the meaning of content by positioning information with CSS](https://www.w3.org/WAI/WCAG21/Techniques/failures/F1).

**Is it possible to adjust the position of the dynamic content container to be a sibling of the activator?**

This would be a big win for accessibility, not only for Shopify components built with Portals, but for all platforms.
Repository: rust
Issue: Linking to a static library does not always include exported symbols
Labels: A-linkage,T-compiler,C-discussion

Similarly to https://github.com/rust-lang/rust/issues/47384, statics in a static library that are marked as `used` are not included in the resulting binary if a non-inlined function is used in the same module.

## Example

This code can be found at [`mkroening/rust-issue-99721`](https://github.com/mkroening/rust-issue-99721).

`staticlib.rs`:

```rust
mod note {
    #[used]
    #[link_section = ".note.my-note"]
    static MY_NOTE: u8 = 0;

    #[inline(always)]
    pub fn dummy() {}
}

#[no_mangle]
pub extern "C" fn staticlib() {
    note::dummy();
}
```

`bin.rs`:

```rust
fn main() {
    extern "C" {
        fn staticlib();
    }

    unsafe {
        staticlib();
    }
}
```

Build using:

```
rustc --crate-type staticlib staticlib.rs
rustc -L native=. -l static=staticlib bin.rs
```

Display static library notes:

```
$ readelf -Wn libstaticlib.a
[...]
File: libstaticlib.a(staticlib.staticlib.68b5aa53-cgu.0.rcgu.o)

Displaying notes found in: .note.my-note
  Owner                Data size 	Description
readelf: Warning: Corrupt note: only 1 byte remains, not enough for a full note
[...]
```

Display binary notes:

```
$ readelf -Wn bin
Displaying notes found in: .note.gnu.property
  Owner                Data size 	Description
  GNU                  0x00000010	NT_GNU_PROPERTY_TYPE_0	      Properties: x86 ISA needed: x86-64-baseline

Displaying notes found in: .note.gnu.build-id
  Owner                Data size 	Description
  GNU                  0x00000014	NT_GNU_BUILD_ID (unique build ID bitstring)	   Build ID: 258d83311faf1a32cb84dd090ccc57abdbb1cb38

Displaying notes found in: .note.ABI-tag
  Owner                Data size 	Description
  GNU                  0x00000010	NT_GNU_ABI_TAG (ABI version tag)	    OS: Linux, ABI: 4.4.0
```

If `note::dummy` is made `inline(never)`, the symbol is included in the resulting binary:

```
$ readelf -Wn bin
Displaying notes found in: .note.gnu.property
  Owner                Data size 	Description
  GNU                  0x00000010	NT_GNU_PROPERTY_TYPE_0	      Properties: x86 ISA needed: x86-64-baseline

Displaying notes found in: .note.gnu.build-id
  Owner                Data size 	Description
  GNU                  0x00000014	NT_GNU_BUILD_ID (unique build ID bitstring)	   Build ID: 72d6efcf61e2b33563094c3f179ebcc511db7485

Displaying notes found in: .note.ABI-tag
  Owner                Data size 	Description
  GNU                  0x00000010	NT_GNU_ABI_TAG (ABI version tag)	    OS: Linux, ABI: 4.4.0

Displaying notes found in: .note.my-note
  Owner                Data size 	Description
readelf: Warning: Corrupt note: only 1 byte remains, not enough for a full note
```
Repository: terminal
Issue: The input speed of ConPTY / ConHost is very slow.
Labels: Help Wanted,Product-Conpty,Area-Input,Area-VT,Issue-Bug

### Windows Terminal version

1.12.10982.0

### Windows build number

10.0.19043.0

### Other Software

https://github.com/UserExistsError/conpty v0.1.0

https://github.com/trzsz/trzsz-go v0.1.9

### Steps to reproduce

1. Install [trzsz-go](https://github.com/trzsz/trzsz-go), download [trzsz_0.1.9_windows_x86_64.zip](https://github.com/trzsz/trzsz-go/releases/download/v0.1.9/trzsz_0.1.9_windows_x86_64.zip) and unzip, you will get `trzsz.exe`, `trz.exe` and `tsz.exe`.

2. open `cmd`

3. execute `trzsz cmd`

4. execute `trz`, a dialog will pop up.

5.  choose a file in the dialog, the file will be uploaded to the current directory.

### Expected Behavior

The `trzsz` create a `ConPTY` process ( `cmd` ), and send the file content as keystrokes.

The `trz` receive the file content and save to the current directory.

The upload speed should be `2MB/s` at least. Same as the download speed.

### Actual Behavior

The upload speed is only about `128KB/s`. Looks like the keystrokes are speed limited.
Repository: frp
Issue: [Feature Request] Allow frpc config update via frps
Labels: todo

### Describe the feature request

Thank you for this superb tool. 
We already have the functionality to update the config of a frpc instance via the adminUI, which is great! But you need to have direct access to the frpc server or you need to setup a proxy configuration to each frpc you have
It would be awesome if we could have a feature to execute a configuration update from the frps dashboard (or some other adminUI on frps). It would reduce the number of ports that need to be actively mananged.

### Describe alternatives you've considered

Setup a proxy configuration to each frpc to update the configuration.

### Affected area

- [ ] Docs
- [ ] Installation
- [X] Performance and Scalability
- [ ] Security
- [X] User Experience
- [ ] Test and Release
- [ ] Developer Infrastructure
- [ ] Client Plugin
- [ ] Server Plugin
- [ ] Extensions
- [ ] Others
Repository: godot
Issue: SoftDynamicBody3D disappears when time_scale is set to 0.0
Labels: bug,topic:physics,topic:3d

### Godot version

v4.0.alpha12.official [2c11e6d9e]

### System information

Windows 10, Nvidia GTX 1080 Ti

### Issue description

SoftDynamicBody3D disappears when time_scale is set to 0.0

### Steps to reproduce

1. Open attached project
2. Press the spacebar to alternatively set time_scale to 0.0 or 1.0
3. SoftDynamicBody3D simply disappears

### Minimal reproduction project

[TestSoftBody.zip](https://github.com/godotengine/godot/files/9183001/TestSoftBody.zip)
Repository: vscode
Issue: Git - Enable AI extensions to suggest a branch name (given the commit message)
Labels: feature-request,git

Copilot is able to nicely predict/suggest a branch name given the last commit message:

![image](https://user-images.githubusercontent.com/2931520/180827943-cb310f6d-1e13-450a-9dab-82c0a8d6e81a.png)

It would be awesome if the branch picker could enable copilot to provide the default branch name:

![](https://user-images.githubusercontent.com/2931520/180432353-8e5d745d-a49e-4efd-ba0d-93f2c947fa4d.png)

What do you think of this idea? @hsenag @kimadeline
Repository: go
Issue: x/vulndb: don't create duplicate issues via worker
Labels: NeedsFix,vulncheck or vulndb

Modify the worker to check if a CVE ID already has a vulndb issue associated with it, and don't create a new one if so
Repository: pytorch
Issue: External libraries cannot have a requirements.txt that needs to install a cpp_extension
Labels: module: cpp-extensions,triaged

### 🐛 Describe the bug

If an external library (e.g. pytorch/tutorials) has a requirements.txt with the following:
```
torch
git+https://github.com/pytorch/functorch.git@v0.2.0
```
then `pip install -r requirements.txt` errors out with "module torch not found". Here's why:
1. pip reads requirements.txt
1. pip tries to determine each package's dependencies before installing anything
1. pip tries to read functorch's dependencies by running its setup.py
1. functorch's setup.py imports torch to get the cpp_extension
1. torch does not exist, so python throws an error

This was discovered in https://github.com/pytorch/tutorials/pull/1968

## Pitch

People might need to pin libraries like this (I'm surprised this is the first time we've run into it). So it would be cool if we could offer a way for pip to read the torch dependency in a c++ extension library (e.g. functorch) without actually importing torch.

I am not sure if this is actually possible, since we need to pass setup.py a BuildExtension object somehow

### Versions

main

cc @malfet @zou3519
Repository: flutter
Issue: Remove stateful attribute interfaces from DisplayListBuilder
Labels: engine,P3,team-engine,triaged-engine

DisplayListBuilder has similar stateful interfaces like the clip and transform methods similar to other graphics packages, but it also has stateful interfaces for attributes (color, filters, alpha, stroke parameters, etc.) which are much less common. The clip and transform states are typically things you want to inherit across an entire rendering cycle, the attributes - much less so.

As of https://github.com/flutter/engine/pull/32860 the Builder class now has optional rendering operations that are stateless with respect to the rendering attributes.

Given the relative ease of use for the stateless interface (in that you don't have to worry about the previous state for many attributes that you don't want to accidentally inherit), it would probably be best if we deleted the attribute-stateful methods from DisplayListBuilder, leaving only clip and transform as remaining state.

Note that this would not require the actual DisplayList storage mechanism to embrace stateless attributes, but the synchronization of the attributes between calls made on Builder would be handled behind the scenes for the convenience of the developers using the Builder interface.
Repository: TypeScript
Issue: Unexpected circularity error when indirectly observing value in `while` loop
Labels: Bug

# Bug Report

So, this is a weird one and apologies for a convoluted repro (I couldn't simplify it any further).

### 🔎 Search Terms

Inference, any, unions, nested objects

### 🕗 Version & Regression Information

- This changed between versions 4.6.4 and 4.7.4
- This is broken on nightly

### ⏯ Playground Link

<!--
  A link to a TypeScript Playground "Share" link which shows this behavior

  The TypeScript Workbench can be used for more complex setups, try
  https://www.typescriptlang.org/dev/bug-workbench/

  As a last resort, you can link to a repo, but these will be slower for us to investigate.
-->
[Playground link with relevant code](https://www.typescriptlang.org/play?ts=4.8.0-beta#code/CYUwxgNghgTiAEYD2A7AzgF3kgRgKwC54BveAMwEsQJgiBlJAWxAFUULV4BfAbgFgAUIIwBPAA4IGzNhxTwAvPBmoAsiEY4QMAIzwAPkvar1mmACZ+QgRRQYtZKGATKUajVt3FB8H-FESiACJtQMtfeAA3KAgAVxAiFBj3GEsuQUEbOxgHJ0NZN1MzEm9ff3j4QLNQkp8o2PLE5NT06zJ4AApcPAA6SmpgbrKFeUVgwIBKYoFwgHcACwoIBHaMGDjJr2nw32R0LDq4hWx8XqoaboOQMO2fAHpb8IA9AH4a7d3MSOi4osVL65uHywjCgYiIpAA2gBrEAiBJJUwAXXhyW4R2IvDe4RBYghlzMiKO2h48Hu8AAwkxmLY-As0NgYlgoChgLSEFoYEgYPAZosIPBgBQ0KCJLA3mkBBKgA)

### 💻 Code

<!-- Please post the relevant code sample here as well-->
```ts
declare const obj: { field: SomeUnion };

type SomeUnion = UnionMember1 | UnionMember2;

interface UnionMember1 {
    type: "1";
    value: number;
}

interface UnionMember2 {
    type: "2";
    value: number;
}

if (obj.field.type === "1") {
    while (true) {
        const value = obj.field.value;
        //    ^?
        const value2 = value;
        const map: { [key: number]: number } = {};
        map[value2] = 1; // Comment this out and the error will disappear
    }
}
```

### 🙁 Actual behavior

`value` is of type `any`, unless the line `map[value2] = 1` is commented out.

### 🙂 Expected behavior

`value` should be of type `number`
Repository: go
Issue: x/pkgsite: inconsistent ID remapping with headers as HTML links
Labels: pkgsite,pkgsite/frontend

### What is the URL of the page with the issue?

(Self-hosted.)

### What is your user agent?

(Any; the issue is with the Markdown renderer.)

### Screenshot

![Screenshot 2022-07-25](https://user-images.githubusercontent.com/4964986/180835077-753616ac-b6c4-41c3-a83d-4a767ead32a2.png)

(Personal information removed.)

### What did you do?

1.  Init an empty Go module.

2.  Add a readme with the following content:

    ```md
     #  Test

    ##  Table Of Contents

     *  [Section](#my-section-id)
         *  [Subsection](#my-subsection-id)

    ##  <a href="#my-section-id" id="my-section-id">Section</a>

       ###  <a href="#my-subsection-id" id="my-subsection-id">Subsection</a>
    ```

3.  Launch `pkgsite`, navigate to the page of the module, and expand the documentation.

### What did you expect to see?

Either HTML IDs being remapped in both the ToC and the headers or no remapping at all.

### What did you see instead?

The ToC links are remapped to `#readme-my-section-id` and `#readme-my-subsection-id` respectively, while the IDs in headers stay the same, which makes the table of contents links useless.

### Additional notes

The ultimate goal is to have a Markdown file with a table of contents and clickable headers that has the same interactive functionality in all Markdown renderers that matter.  Which includes most Git hosting sites as well as pkg.go.dev.  The former all work, but the latter has HTML ID issues.
Repository: go
Issue: x/pkgsite: `golang.org/x/tools/gopls/internal/regtest@master` resolves to wrong module
Labels: pkgsite

### What is the URL of the page with the issue?
 
https://pkg.go.dev/golang.org/x/tools/gopls/internal/regtest@master
 
### What is your user agent?
 
```
Mozilla/5.0 (X11; CrOS x86_64 14909.79.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36
```
 
### Screenshot
 
![image](https://user-images.githubusercontent.com/5200974/180840022-ee39e648-a270-4e15-ad84-08c299bc7b1f.png)
 
 
### What did you do?
 
Navigate to the aforementioned URL. 
 
### What did you expect to see?

A documentation node for the directory `internar/regtest` (which contains test-only Go packages but is not itself a Go package) in module `golang.org/x/tools/gopls` on the `master` branch:
https://cs.opensource.google/go/x/tools/+/master:gopls/internal/regtest/;drc=178fdf98da63010b55ff90c04614e0ca9a69a2cd
 
Ideally, the documentation node would provide the option to view the doc comments for exported identifiers within the nested tests.

### What did you see instead?

A redirect to the `master` branch of a parent module hosted in the same repository (https://pkg.go.dev/golang.org/x/tools/gopls@v0.0.0-20220725165529-005c07ac5af6/internal/regtest), with an “Oops!” page showing that that module indeed does not contain the requested path.
Repository: pytorch
Issue: Re-enable DynamicQuantModule in iOS simulator tests
Labels: module: ci,triaged,module: ios

See https://github.com/pytorch/pytorch/pull/82027 and https://github.com/pytorch/pytorch/issues/81613 for details

cc @seemethere @malfet @pytorch/pytorch-dev-infra
Repository: go
Issue: html/template: default missingkey behavior does not match documentation
Labels: Documentation,help wanted,NeedsInvestigation

<!--
Please answer these questions before submitting your issue. Thanks!
-->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.17.12 darwin/amd64
</pre>

### Does this issue reproduce with the latest release?

Yes.

### What did you do?

https://go.dev/play/p/i3N0a5PATuI

### What did you expect to see?

`<b><no value></b>`

This would align with the documented behavior of `Template.Option`.
> "missingkey=default" or "missingkey=invalid"
	The default behavior: Do nothing and continue execution.
	If printed, the result of the index operation is the string
	"<no value>".

This is what text/template outputs.

### What did you see instead?

`<b></b>`
Repository: pytorch
Issue: Stop manually binding sparse factory functions
Labels: module: sparse,triaged

### 🐛 Describe the bug

The current binding code is very repetitive and I think our codegen can handle it (it can handle regular factory functions, after all.)

### Versions

master

cc @nikitaved @pearu @cpuhrsch @amjames @bhosmer
Repository: pytorch
Issue: set_grad_enabled not respected when running on a web server
Labels: module: dependency bug,module: autograd,triaged,actionable

### 🐛 Describe the bug

The `torch.set_grad_enabled` flag is not respected when torch is being run as part of a web server (flask/fastapi).

Repro

```python
import torch
from fastapi import FastAPI
import uvicorn
import requests

torch.set_grad_enabled(False)


def grad_enabled():
    x = torch.tensor([1.], requires_grad=True)
    y = x * 2
    return y.requires_grad


app = FastAPI()

@app.get("/")
def predict():
    return grad_enabled()



if __name__ == "__main__":
    assert not grad_enabled()
    uvicorn.run(app, host="0.0.0.0", port=8000)
```

Run `python <filename>`. And go to localhost:8000, you should see `true` even though `set_grad_enabled` is set to `False`. `set_grad_enabled` does work outside the context of a web server though, as shown by the assert statement.


Is this a bug or user error? 

Seeing it in such a condensed code block, I can try to convince myself that this is not how `set_grad_enabled` is supposed to work but I'm not exactly sure why that would be the case.

Certainly this can bite someone else in the butt like it did me and lead to very mysterious CUDA out of memory errors so I think there will be value in helping users by either preventing this from happening or educating users that this can happen.

### Versions

```
Collecting environment information...
PyTorch version: N/A
Is debug build: N/A
CUDA used to build PyTorch: N/A
ROCM used to build PyTorch: N/A

OS: macOS 12.2.1 (arm64)
GCC version: Could not collect
Clang version: 13.0.0 (clang-1300.0.27.3)
CMake version: Could not collect
Libc version: N/A

Python version: 3.9.12 (main, Apr  5 2022, 01:52:34)  [Clang 12.0.0 ] (64-bit runtime)
Python platform: macOS-12.2.1-arm64-arm-64bit
Is CUDA available: N/A
CUDA runtime version: Could not collect
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: N/A

Versions of relevant libraries:
[pip3] numpy==1.22.4
[conda] numpy                     1.22.4                   pypi_0    pypi
```

cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @soulitzer @Lezcano @Varal7
Repository: godot
Issue: [X11] Project sometimes takes a full second to terminate when quitting on first frame
Labels: bug,topic:core,performance

This is caused by an X11 event timeout, see the linked PR for related code, although it wasn't a good fix/workaround.

### Godot version

3.4.4.stable, v3.5-rc7
Not reproducible on Godot 4 alpha 12

### System information

Arch on 5.18.14-arch1-1

### Issue description

| Trial  | Time 3.4.4 with `--quit` | Time 3.5-rc7 with `--quit` | Time 4.0a12 with `--quit`
| - | - | - | - |
| 1  | 0m0.252s  | 0m0.346s | 0m0.995s |
| 2  | 0m0.212s  | 0m1.231s | 0m0.382s |
| 3  | 0m1.233s  | 0m0.235s | 0m0.371s |
| 4  | 0m0.213s  | 0m0.210s | 0m0.630s |
| 5  | 0m0.253s | 0m0.229s | 0m1.370s |
| 6  | 0m1.226s | 0m0.230s | 0m1.365s |
| 7  | 0m0.229s  | 0m0.242s | 0m0.452s |
| 8  | 0m0.229s  | 0m0.625s | 0m1.356s |
| 9  | 0m0.219s  | 0m0.646s | 0m0.534s |
| 10  | 0m0.231s  | 0m0.224s | 0m1.364s |

* When running with `--verbose`, the last thing to be printed before the 1 second "freeze" is `PulseAudio: context terminated`. ~~Could be a problem with pulse~~, I'll need some other people to test (Note issue is still reproducible with `--audio-driver Dummy`).

### Steps to reproduce

1) Start the editor in quick succession.
    `time godot --path ~/workspace/test/empty3 --quit | grep real` multiple times
    or
    `time godot4 --path ~/workspace/test/empty --quit | grep real` multiple times

### Minimal reproduction project

[empty3.zip](https://github.com/godotengine/godot/files/9184132/empty3.zip)
[empty.zip](https://github.com/godotengine/godot/files/9184248/empty.zip) (4)
Repository: kubernetes
Issue: Two names for one thing: flowcontrol and API Priority and Fairness
Labels: kind/bug,sig/api-machinery,triage/accepted

### What happened?

In the rush to alpha, we merged the code with an inconsistency: we used the term "flow control" in some places, "API Priority and Fairness" in others.  These two terms are used interchangeably for the same thing.  This is unnecessarily confusing.

### What did you expect to happen?

I expected to use one term consistently.

I think "API Priority and Fairness" is the better choice.  The term "flow control" is broad and misleading. I did a web search for "flow control". The first hit was https://en.wikipedia.org/wiki/Flow_control_(data) . As you would expect from the words, the concepts there are around controlling rate rather than concurrency. The techniques listed on that web page do not include things like APF. While it is true that the two are connected, so controlling either has an effect on the other, the problem with the term "flow control" is that it suggests that rate rather than concurrency is being directly controlled.

### How can we reproduce it (as minimally and precisely as possible)?

Look at the name of the feature gate.  Look at the user-facing documentation.  Look at the API group name.  Look at the code directory structure.

### Anything else we need to know?

The latest case where this inconsistency causes pain is #111222 , but this is hardly the first.  The inconsistency has been present from the start.

### Kubernetes version

<details>

This pain has been present from the start of this feature.

</details>


### Cloud provider

<details>
N/A
</details>


### OS version

<details>

N/A

</details>


### Install tools

<details>
N/A
</details>


### Container runtime (CRI) and version (if applicable)

<details>
N/A
</details>


### Related plugins (CNI, CSI, ...) and versions (if applicable)

<details>
N/A
</details>