sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: react-native
Issue: ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:132:1: Property with 'retain (or strong)' attribute must be of object type
Labels: Platform: iOS,Help Wanted :octocat:,Resolution: PR Submitted,Needs: Repro

iOS Xcode build fails with this Syntax error "**ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:132:1: Property with 'retain (or strong)' attribute must be of object type**"

## Description
I am using this **RCTBridgeModule** to create my own custom bridge module for one of my application. Recently i migrated the app to latest react-native version 0.61.5. Now the iOS xcode build and `react-native run ios` command build gives me the error "**ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:132:1: Property with 'retain (or strong)' attribute must be of object type**". The build works fine when i removed the strong keyword from this line below. The strong or retain keyword is not required here as i see the variable methodQueue here is not an object. 
https://github.com/facebook/react-native/blob/75a617827963fd53f5f36987677a992e137eaebf/React/Base/RCTBridgeModule.h#L146

See this link for more details on declaring dispatch_queue as a property after ARC - https://stackoverflow.com/questions/8904206/what-property-should-i-use-for-a-dispatch-queue-after-arc

## React Native version:
info Fetching system and libraries information...
**System:**
    **OS:** macOS 10.15.2
    **CPU:** (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    **Memory:** 2.77 GB / 16.00 GB
    **Shell:** 5.7.1 - /bin/zsh
  **Binaries:**
    **Node:** 12.14.1 - /usr/local/bin/node
    **Yarn:** 1.21.1 - /usr/local/bin/yarn
    **npm:** 6.13.4 - /usr/local/bin/npm
  **SDKs:**
    **iOS SDK:**
      **Platforms:** iOS 13.6, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    **Android SDK:**
      **API Levels:** 23, 25, 26, 28, 29
      **Build Tools:** 28.0.3, 29.0.2
      **System Images:** android-28 | Google APIs Intel x86 Atom
  **IDEs:**
    **Android Studio:** 3.6 AI-192.7142.36.36.6392135
    **Xcode:** 11.6/11E708 - /usr/bin/xcodebuild
  **npmPackages:**
    **react:** 16.9.0 => 16.9.0 
    **react-native:** 0.61.5 => 0.61.5 
  **npmGlobalPackages:**
    **react-native-cli:** 2.0.1

## Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

1. Use RCTBridgeModule to create some custom bridge module for a react-native application
2. Build the iOS project after integrating the above custom module
3. Xcode build fails with above syntax error

## Expected Results
Xcode build should work fine without any syntax error 

## Snack, code example, screenshot, or link to a repository:
Please provide a Snack (https://snack.expo.io/), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
You may provide a screenshot of the application if you think it is relevant to your bug report.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve
Repository: rust
Issue: Clarify use cases for Option is_some and is_none
Labels: C-enhancement,A-docs

Bringing this from a [Reddit comment on Beginner's critiques of Rust](https://www.reddit.com/r/rust/comments/hzx1ak/beginners_critiques_of_rust/fzn8exa):

> `is_some()` and `is_none()` are more of an end goal. You use it when you want to know whether or not an `Option` has a value but don't actually need to use the value. You should be pattern matching or using something like `.map()` or `.unwrap_or()` if you need to use the value.

Maybe the documentation could include something along the lines of showing the moral equivalent:

> This method is the moral equivalent of pattern-matching on the `Option` and turning into a `bool` without caring about the value:
> 
> ```rust
> let has_item = if let Some(_value) = option { true } else { false };
> // becomes
> let has_item = option.is_some();
> ```
> 
> If you don't care about whether it has a value but rather about the value itself if any, consider pattern-matching instead.

Personally I think this is a bit long-winded, but it might help people coming to the language with a different mindset. Definitely needs better wording than what I put here.

In the thread there are more examples of good and bad that might be worth borrowing, or perhaps the documentation could link t the book with more examples if this becomes too much of a guide?

The same reasoning applies to `Result`'s `is_ok` and `is_err`.
Repository: react
Issue: Portal Event Bubbling Use Cases
Labels: Type: Discussion

This is a spillover from https://github.com/facebook/react/issues/11387.

The goal of this issue is **not** to argue about whether the current React's behavior makes sense in all situations. Rather, it is **collect a list of use cases, both when the current behavior works well, and when it doesn't**, so that they can inform the next iteration of the related APIs. We can't commit to any concrete timeframe on this at the moment, but a list like this will definitely reduce the amount of time that we'd need to spend to get up to speed on the problem space when we're ready to approach it.

If you'd like to contribute a use case, please comment with:

- A name for your pattern (come up with something unique so we can refer to it later)
- A brief description of the UI (but a screenshot is worth a thousand words)
- A small CodeSandbox demo, if you want to make a stronger case
- How React event bubbling behavior breaks (or helps) your case
  - Include any information about other pitfalls you encountered, be very specific
- A workaround you are currently using, if any
  - If you tried some workarounds but they cause issues, let us know which ones

Please keep this thread on topic and let's keep general discussion in https://github.com/facebook/react/issues/11387. This is not a good thread for "+1" or requests to solve this faster — it's a thread for gathering research.

Thank you!
Repository: rust
Issue: "-A warnings" cannot be overwritten later by `#[warn]` (but other "-A lint" can)
Labels: A-lints,C-bug

Given the following code
```rust
#![warn(warnings, unused)]

fn main() {
    let x = 13;
}
```
running `rustc -A unused test.rs` shows a warning that `x` is unused as expected (since the module scope takes precedence over the command-line arguments). However, `rustc -A warnings` prints nothing.

This is caused by the following special handling:

https://github.com/rust-lang/rust/blob/01ffbcbeed39b71c9939c7e67e39e59a5a09b254/src/librustc_session/session.rs#L1178-L1189

The FIXME already describes the problem, but I haven't found an open issue for this.

The special case was introduced by [this commit](https://github.com/rust-lang/rust/commit/abc56a011a0c00ac85a896957ff6182d3d86f4aa) as part of https://github.com/rust-lang/rust/pull/21248. Looks like it is a hack needed to silence some otherwise unsilenceable warnings -- but I am not sure if the hack is still needed, or if there isn't a better way to do this.
Repository: rust
Issue: Rustdoc shouldn't collect all attributes into a single string when parsing markdown
Labels: T-rustdoc,I-compiletime,I-compilemem,S-blocked,A-doctests,A-markdown-parsing

Unfortunately, the API seems pretty limited: https://docs.rs/pulldown-cmark/0.7.2/pulldown_cmark/struct.Parser.html

So until it's being extended, I guess we're kinda stuck with this extra allocation...

_Originally posted by @GuillaumeGomez in https://github.com/rust-lang/rust/pull/75665_
Repository: go
Issue: x/tools/gopls: add codelens to show number of references to each symbol
Labels: Thinking,help wanted,FeatureRequest,gopls,Tools

Issue Type: <b>Feature Request</b>

it would be nice to see if a function is referenced in the code or not.
click on the codelens and see all the places the variable, function being referenced.

variable: 
![image](https://user-images.githubusercontent.com/9264813/90341929-8f3e7880-e021-11ea-9050-735f0fed3e49.png)

functions: 
![image](https://user-images.githubusercontent.com/9264813/90341944-a715fc80-e021-11ea-89d1-6e35e116c3ca.png)


Extension version: 2020.8.1301
VS Code version: Code - Insiders 1.49.0-insider (bd08768fd310d34cdd4423a53e5f3ca77340fea5, 2020-08-14T05:56:40.601Z)
OS version: Windows_NT x64 10.0.18363


<!-- generated by issue reporter -->
Repository: angular
Issue: Directive matching with `attr.` is not working with Ivy
Labels: area: core,area: compiler,state: confirmed,core: directive matching,P3

<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅

Oh hi there! 😄

To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.

🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->


# 🐞 bug report

### Affected Package
The issue affects the @angular/core/Directive when Ivy is enabled on the project.


### Is this a regression?

<!-- ✍️--> Yes, the previous version in which this bug was not present was: 7.2.15. When Ivy is disabled in Angular 9.x and 10.x the issue is also not present.


### Description

<!-- ✍️--> We have a directive with two selectors <code>[data-dl],[attr.data-dl]</code> that creates a mousedown event on the HTML element. When Ivy is enabled on the project, the <code>attr.data-dl</code> version of the directive does not properly fire the mousedown event while just <code>data-dl</code> does fire correctly.


## 🔬 Minimal Reproduction
Right click on the links in the projects below to see the message being logged to the console.
- Version with Ivy enabled that has the issue: https://stackblitz.com/edit/angular-w9bhzc
- Version with Ivy disabled that works fine: https://stackblitz.com/edit/angular-8d6qq9

<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.

Issues that don't have enough info and can't be reproduced will be closed.

You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->

## 🔥 Exception or Error
No Exception


## 🌍  Your Environment

**Angular Version:**
9.1.12

**Anything else relevant?**
<!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->
Seems to be broken uniformly across all browsers and operating systems from what we have seen.
<!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
Repository: godot
Issue: Light Size slider is creating artifacts
Labels: bug,topic:rendering

**Godot version:**
<!-- Specify commit hash if using non-official build. -->
f97280a0127950f5ae7d2e38f239ab9633afb041

**OS/device including version:**
Pop OS 19, gtx1080ti


**Issue description:**
Light size slider creates weird artifacts on highlights, doesn't really soften shadows. 

Light size 0, Godot:
![godot1](https://user-images.githubusercontent.com/44336181/90537228-c0d05480-e185-11ea-8163-8f0542b9b971.png)
Light size 2 Godot:
![godot2](https://user-images.githubusercontent.com/44336181/90537261-cc238000-e185-11ea-968e-9e4c84faccda.png)


Light size 0.25 Blender Eevee:
![eevee1](https://user-images.githubusercontent.com/44336181/90537309-dc3b5f80-e185-11ea-92ff-769d4f8801bd.png)
Light size 2 Blender Eevee
![eevee2](https://user-images.githubusercontent.com/44336181/90537368-ec533f00-e185-11ea-8c39-a2837277854e.png)
 
As you can see, there are some pretty ugly white spots all over the model in Godot for whatever reason, while in Eevee it just dims the light and softens the shadows.



**Steps to reproduce:**
1. Import the attached gltf file:
https://mega.nz/file/qc11CJII#zL8LjZSjnwY_4uf8o170JjBS5Q6pilNTLMXQZU9bjzQ
2. Add a Omni Light in front of the hand
3. Set the specular to 1 (like it probably should be by default)
4.Set size to something other than 0 and notice the artifacts.
Repository: create-react-app
Issue: Error: Cannot find module 'react-scripts/scripts/init.js'
Labels: needs triage

When creating a brand new react app using the new way: "npx create-react-app my-app" i get the an error and seems to not be a way to fix it easy, I've found a way but I'm curios if the problem is from my pc or something else... 

I hope someone can help me understand what is happening 👍
Repository: go
Issue: x/tools/gopls: add insert-replace support (insertReplaceEdit)
Labels: help wanted,FeatureRequest,gopls,Tools

Currently gopls is overwriting the surrounding suffix (in addition to prefix) when inserting candidates:

```
// completing to "food" currently results in "food" instead of "foodoo"
f<>oo
```

I think it's from https://go-review.googlesource.com/c/tools/+/208501 changing the surrounding's range from `[ident.Pos(), c.pos]` to `[ident.Pos(), ident.End()]`.

/cc @heschik
Repository: flutter
Issue: Sliver version for AnimatedSwitcher
Labels: framework,a: animation,f: material design,c: proposal,P3,team-design,triaged-design

## Use case

I want to replace `CustomScrollView` item with fade transition

## Explanation

To show/hide an item with transition, there exists `AnimatedOpacity` for regular `ListView` and `SliverAnimatedOpacity` for `CustomScrollView`.

To replace an item with transition, there exists `AnimatedSwitcher` for regular `ListView`, but it seems it has not sliver analog.
Repository: go
Issue: x/build/cmd/gerritbot: support continuing to work with PRs that are closed and re-opened
Labels: Builders,NeedsInvestigation,FeatureRequest

We saw this in CL 239710, where a contributor accidentally closed a PR, reopened it, and was unable to get further updates into gerrit.
@dmitshur @FiloSottile @qingyunha
Repository: flutter
Issue: [google_maps_flutter_web] Add "My Location" Widget.
Labels: c: new feature,p: maps,platform-web,package,P3,has partial patch,team-web,triaged-web

The current version of the Google Maps Flutter Web plugin does not have the "My Location" functionality.

This means there are two Map options that are not implemented:

* `myLocationButtonEnabled` ([seems doable](https://developers.google.com/maps/documentation/javascript/examples/control-custom))
* `myLocationEnabled` ([seems doable](https://api.dart.dev/stable/2.8.4/dart-html/Geolocation-class.html))

Implement those!
Repository: go
Issue: x/build: add builder that tests usage of gccgo to bootstrap go gc
Labels: Builders,NeedsInvestigation,new-builder

There have been issues now and in the past about bootstrapping Go gc from gccgo being broken #40855, #30771.

Documentation at https://golang.org/doc/install/source#bootstrapFromGccgo suggests that bootstraping from gccgo is supported.

If this is the case I suggest we add a builder for that. To not be blocked on ressources I would assume a build only linux/amd64 builder would suffice to catch bootstrap issues.

/cc @ianlancetaylor @dmitshur
Repository: create-react-app
Issue: Option --no-git
Labels: issue: proposal,needs triage

### Is your proposal related to a problem?

<!--
  Provide a clear and concise description of what the problem is.
  For example, "I'm always frustrated when..."
-->

Create react app starts with a git repository, but I wish I could start a react app with no git startup

### Describe the solution you'd like

<!--
  Provide a clear and concise description of what you want to happen.
-->

When starting a react app with CRA and a flag (ex: `--no-git`), do not start a git repository.
Repository: rust
Issue: Confusing error message combining when arrays, size_of in a container
Labels: A-diagnostics,T-lang,T-compiler,C-bug,A-const-generics,D-confusing

Playground: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=ff721dd90338cf7cfa30b9fe7198db36
This code tries to use  `[u8; std::mem::size_of::<T>()]`, where T is generic parameter. This is currently not supported, so for
`good` function compiler gives helpful error: `constant expression depends on a generic parameter`.
However, for functions `bad1` and `bad2` (where ill-formed array declaration is wrapped into other type), compiler gives error `the size for values of type `T` cannot be known at compilation time`. Furthermore, it suggests to add `Sized` bound, while it is already specified. I think this message and suggestion can be confusing.

### Meta
I used rust v1.45.2 on the Rust Playground.
Repository: flutter
Issue: [google_maps_flutter_web] Handle `consumeTapEvents: false` correctly in Geometry controllers
Labels: p: maps,platform-web,package,P3,c: parity,team-web,triaged-web

Should the `consumeTapEvents` property on Geometry controllers prevent events from being added to the shared Stream? Do we need to prevent propagation of these events differently?

Thanks @Sammius for chiming in with the [expected behavior](https://github.com/flutter/flutter/issues/64084#issuecomment-822660276).
Repository: flutter
Issue: Tree shake unused assets
Labels: c: new feature,tool,a: assets,a: size,a: build,P3,team-tool,triaged-tool

In theory, we could probably shake out assets (e.g. fonts, images) from packages that a user isn't using.

In practice, this is actually pretty hard because of the way strings are used in this and level of detection we can use when assets are used dynamically (e.g. get the name of an asset to show from your service, then show it).

This is difficult even for icon fonts, because if you don't have a const reference to the font using IconData, we may not know if you're using it as a regular font or not.

Today, the work around is to just not use packages that have assets you do not need - or, to re-package them to your liking before shipping thea pp.

See also: b/146889328
Repository: TypeScript
Issue: Intellisense not working for nested npm modules in node project with typings
Labels: Needs Investigation

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.48.0
- Node.js: 12.8.1
- OS Version: Windows_NT x64 10.0.18362

Steps to Reproduce:

1. Git clone project from https://github.com/owenallenaz/vscode-test-project .
2. Open project root folder in vscode .
2. Go to nested containers/shared folder and npm install.
3. Open containers/graphql/lib/testLib.js in vscode.
4. Type hinting will exist for `fs` but not for `lodash` even though both are installed via their respective @types. Type hinting will work for `p-memoize`, but that project uses embedded d.ts files within the npm package itself, not provided via @types.

If you move the package.json down to the root of the project and delete `typeRoots` and `paths`, then the type hinting works perfect. The interesting thing you will note is that `lodash` will be listed as a found module. In example if you remove the "paths" block from tsconfig, then you will get the red squiggly under lodash. In addition, if you remove @types/node from package.json and npm install, you will find that the `fs` will no longer have type hinting. So the @types modules are working... but some aren't. I have observed this behavior for nearly every npm module I've tried, be it `mongodb`, `express`, `lodash`, none of them receive type hinting in this setup.

For technical reasons I cannot move the package.json to the project root because it's a multi-container Kubernetes project and the shared container does all of the NPM installs for the other containers.

<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
Repository: pytorch
Issue: [jit] remove shape/device specialization from tracing after ONNX done with its own shape inference
Labels: oncall: jit,weeks

PR: https://github.com/pytorch/pytorch/pull/40628/

ONNX is doing its own shape inference, we should remove the shape/device info from tracing for better UX experience and avoid confusions of the weird encodings.

cc @suo @gmagogsfm
Repository: pytorch
Issue: Expose counters for torch.distributed to report communication overhead within a block.
Labels: oncall: distributed,triaged

## 🚀 Feature
Similar to `torch.cuda.memory_stats()`, `torch.distributed` should provide functionality in order to report the total communication overhead within a scope, e.g. within a model's forward/backward pass. For example, a counter that reports the total inter-rank communication latency within a block and provides a way to reset that counter would be quite useful.


## Motivation
This feature request comes @vreis. This will allow performance profiling and debugging such as evaluating the comm. overhead of different algorithms, and gauging the amount of overlap between comm. and backwards computation, for example in DDP's backwards pass. 

## Pitch

Since this should probably not be "always-on" due to the possible extra overhead, a context manager such as `with torch.distributed.collect_comm_stats() as comm_stats` could be useful. We could then aggregate the comm. time for any `torch.distributed` collectives called under this context manager. Something like `comm_stats.get_total_comm_overhead()` could return the total communication overhead within the block. 

In order to make this work as expected, with the above proposal the user would most likely have to `wait()` on all async work, such as allreduce, that was created to finish (and synchronize in the case of nccl operations). If this requires too much change to user code to be convenient to use, we may want to eventually provide a `block_until_outsanding_work_complete` or similar flag in the context manager, where we will record all work created and wait on it when exiting (this is similar to the `rpc.wait_all()`: https://github.com/pytorch/pytorch/pull/41807

This work will need to be done in conjunction with https://github.com/pytorch/pytorch/issues/43231 to avoid duplicated efforts.


cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar @jiayisuse @agolynski
Repository: storybook
Issue: add on control enum data type not support object values
Labels: bug,addon: controls

**Describe the bug**

For the enum data type, The options value object can be injected to component properties （take effect on preview）
but the control  panel value is 'empty', and the multi-select array of object can't be injected to preview component

**To Reproduce**
Steps to reproduce the behavior:

Story like this:

```
export default {
  title: 'Example/Button',
  component: Button,
  argTypes: {
    backgroundColor: { control: 'color' },
    loadingState: {
      control: {
        type: 'select',
        options: {
          'loading': {
            state: 'loading',
            // some additional data
          },
          'pending': {
            state: 'pending',
           // some additional data
          }
        },
      },
    }
  },
};
```

select control loadingState to loading or pending ,the select won't change.
Repository: pytorch
Issue: mp.spawn 'args' are not clear
Labels: module: docs,module: multiprocessing,triaged

## 📚 Documentation

It is not clear what I can pass as args in `torch.multiprocessing.spawn()`
Can I pass the model, dataset, optimizer, scheduler, etc. through the args? Is it just primitives or perhaps objects which can be pickled?

It would be great if a more concrete explanation was available.


cc @jlin27