sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: excalidraw
Issue: Embedding share links
Labels: enhancement

Hey everyone 👋  – love the project and I've been looking at supporting embedding Excalidraw(ings) inside [Outline](https://github.com/outline/outline), the embed setup is easy on Outline's side and I had something [hooked up in 10 minutes](https://github.com/outline/outline/commit/7af2d382cb0561eef5f8317561cae19121b5be50), however the way that Excalidraw loads data leads to a very confusing user experience.

### Example Scenario

- I create a drawing on excalidraw.com
- Go to "Export -> Get shareable link…"
- Paste link into [tool] that embeds an iframe version
- Looks good locally

### Problem…
- I'm able to make edits in the iframe but they are not reflected to anyone else that views it on another browser
- If two iframes are on the same page they will both show the same drawing, regardless of the `json=` share string

---

I'd imagine this will be an issue with any other tools that embed Excalidraw in an iframe so thought it worth filing for discussion on approach. Some possible suggestions:

- Implement a "read-only" mode (via query string?) to optionally prevent edits being made in an iframe as they won't be reflected to other viewers
- Always prefer loading the `json=` data
- In a perfect world edits would be possible and linked back to the original share string for anyone that views it, however I understand if this is antithetical to the current data model.
Repository: pytorch
Issue: Multinomial without replacement produces samples that have zero probability
Labels: module: distributions,triaged,module: numpy,module: random,module: ux

## 🐛 Bug

Since moving to more efficient algorithm for sampling multinomial without replacement, we don't check if probability tensor has enough non-zero elements to sample the requested number of samples. We only check if at least one of the probabilities is positive, and that number of samples is less than number of classes.  

## To Reproduce
Below, probability tensor has 3 non-zero element, so we should be able to generate at most 3 samples without replacement. When requesting 4, numpy errors out, but pytorch produces a sample with 0 probability (`4`).
Steps to reproduce the behavior:
```
In [4]: np.random.choice(5, 4, p=[0.1, 0, 0.3, 0.6, 0], replace=False)                                                                                                                                                              
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-4-e39b22db940b> in <module>
----> 1 np.random.choice(5, 4, p=[0.1, 0, 0.3, 0.6, 0], replace=False)

mtrand.pyx in numpy.random.mtrand.RandomState.choice()

ValueError: Fewer non-zero entries in p than size

In [7]: torch.multinomial(torch.tensor([0.1, 0, 0.3, 0.6, 0]), 4, replacement=False)                                                                                                                                                
Out[7]: tensor([2, 3, 0, 4])
```

Checking the number of non-zeros in the probability tensor is an additional perf penalty (already in many cases checking the probability array is longer than actual sampling), so we should decide if we want this, or if we should have "unsafe" API avoiding checks. 

cc @fritzo @neerajprad @alicanb @vishwakftw @nikitaved @mruberry @rgommers @heitorschueroff @pbelevich @t-vi 
cc @fritzo @neerajprad @alicanb @vishwakftw @nikitaved @mruberry @rgommers @heitorschueroff @pbelevich
Repository: PowerToys
Issue: [Run] Search results should be more categorized
Labels: Idea-Enhancement,Product-PowerToys Run,Area-User Interface

Powertoys Run should categorize search results how KDE Krunner does.

![KRunner](https://user-images.githubusercontent.com/6332266/103514099-9ea94b80-4e74-11eb-83dc-eb84e5d52ffe.png)
Repository: godot
Issue: Three layers of Viewports for post processing leads to previous frames being drawn
Labels: bug,topic:rendering,confirmed

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
<!-- Specify commit hash if using non-official build. -->
3.2.3 Stable

**OS/device including version:**
<!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. -->
GLES 3, GTX 1050, Linux with 5.10.3 Kernel.

**Issue description:**
<!-- What happened, and what was expected. -->
I was making a glow effect for a 2D game using a chain of Viewports as follows:
-Scene
|-SceenViewportContainer
||-Viewport
|||-Camera + World
|-GlowViewportContainer (for additive blending)
||-Viewport
|||-BlurHorizontalViewportContainer
||||-Viewport
|||||-BlurVerticalViewportContainer
||||||-Viewport
|||||||-Sprite (showing the ScreenViewportContainer as a texture)

When testing this, I noticed the glow seemed to lag behind the scene so I changed the shaders of the Viewport Containers to just pass the color through and applied subtractive blending mode to the top most Viewport. If everything works as expected this would just show a black picture (since the images would be the same). However, when there was motion, there was indeed pixels lighting up (showing that the triple-layered Viewports are lagging a frame behind). Just using 2 layers of Viewports does not have this issue.


**Steps to reproduce:**
Apply three layers of Viewports, the third layer will have a delay of a frame. In the attached project there is a particle effect showing the movement and a still object to show that the layers are not just misaligned.

**Minimal reproduction project:**
<!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. -->
[project.zip](https://github.com/godotengine/godot/files/5764067/project.zip)
Repository: create-react-app
Issue: PWA New Updates not reflecting
Labels: needs triage

Hi, 

I am using cra pwa in my project. I am having 2 issues.
1) The add to home screen is not being asked in all devices but works fine for others
2) If a change is made and deployed it is not being reflected in the app, this also works well for some devices and not for others
Repository: pytorch
Issue: Torch quantized_lstm_cell op out-of-bounds access
Labels: module: crash,oncall: quantization,low priority,triaged

## 🐛 Bug

<!-- A clear and concise description of what the bug is. -->

## To Reproduce

Steps to reproduce the behavior:

```python
import torch
print(torch.__version__)
#'1.7.0'
from torch import tensor
torch.quantized_lstm_cell(tensor([1,2,3]),[tensor([True, True])], tensor([1,2,3]), tensor([1,2]), tensor([1,2,3,4]), tensor([1,2,3,4]),tensor([1,2,3,4]),tensor([1,2,3,4]),tensor([1]),tensor([False]),1, 1, 1, 1)
```
Crash [Detail.](https://github.com/aivul/crashes/blob/main/quantized_lstm_cell.txt)

<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->

## Expected behavior

<!-- A clear and concise description of what you expected to happen. -->
The second parameter `[tensor([True, True])]` is expected to be a Tensor array with 2 elements. A check is need here.

## Environment
```
Collecting environment information...
PyTorch version: 1.7.0
Is debug build: True
CUDA used to build PyTorch: 10.2
ROCM used to build PyTorch: N/A

OS: Ubuntu 18.04.2 LTS (x86_64)
GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Clang version: 9.0.0 (https://github.com/llvm-mirror/llvm c62b24f070c9a4bb1a76409e623042a740cac4cd)
CMake version: version 3.10.2

Python version: 3.6 (64-bit runtime)
Is CUDA available: False
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] numpy==1.19.4
[pip3] torch==1.7.0
[pip3] torchvision==0.8.1
[conda] Could not collect

```

## Additional context

<!-- Add any other context about the problem here. -->
We discoverd the vulnerability by **QSand**, a fuzzing tool designed by 360 AIVUL. Taking the risk of vulns into consideration, we believe that the security issues are not suitable for direct disclosure on Github until they are fixed. So we suggest establishing a vulnerability response and handling process in the same way as [Tensorflow.](https://github.com/tensorflow/tensorflow/security/advisories)


cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel @ezyang @gchanan @zou3519 @bdhirsh @jbschlosser @dzhulgakov
Repository: pytorch
Issue: Torch  _remove_batch_dim OP out-of-bounds access
Labels: module: crash,triaged,module: vmap

## 🐛 Bug

<!-- A clear and concise description of what the bug is. -->

## To Reproduce

Steps to reproduce the behavior:

```python
import torch
from torch import tensor
torch._remove_batch_dim(tensor([272.2390, 136.4415,  18.3361]), 280, 994, 57)
```
Crash [details](https://github.com/aivul/crashes/blob/main/_remove_batch_dim.txt)
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->

## Expected behavior

<!-- A clear and concise description of what you expected to happen. -->
The 4th param `out_dim` is supposed to be checked before executing.
## Environment

```
Collecting environment information...
PyTorch version: 1.7.0
Is debug build: True
CUDA used to build PyTorch: 10.2
ROCM used to build PyTorch: N/A

OS: Ubuntu 18.04.2 LTS (x86_64)
GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Clang version: 9.0.0 (https://github.com/llvm-mirror/llvm c62b24f070c9a4bb1a76409e623042a740cac4cd)
CMake version: version 3.10.2

Python version: 3.6 (64-bit runtime)
Is CUDA available: False
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] numpy==1.19.4
[pip3] torch==1.7.0
[pip3] torchvision==0.8.1
[conda] Could not collect
```
Repository: go
Issue: runtime: unexpected return pc for runtime.sigpanic called from 0x1
Labels: NeedsInvestigation,compiler/runtime

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.15.6 linux/amd64
</pre>

### Does this issue reproduce with the latest release?

Unable to reproduce.

### What operating system and processor architecture are you using (`go env`)?

It's using `golang:1.15.6` docker image as the base for CI testing.

### What did you do?

We have automated tests running for changes and one of them failed with a crash.
The race-detector is enabled for the tests.

The relevant part of the crash seems to be:

```
unexpected fault address 0x20000e25d000
fatal error: fault
runtime: unexpected return pc for runtime.sigpanic called from 0x1
stack: frame={sp:0x7fff71c22dd0, fp:0x7fff71c22e00} stack=[0xc0016e4000,0xc0016e8000)

fatal error: unknown caller pc

runtime stack:
runtime.throw(0x21593f2, 0x11)
	/usr/local/go/src/runtime/panic.go:1116 +0x72
runtime.gentraceback(0x4672b3, 0x7fff71c22dd0, 0x0, 0xc00059af00, 0x0, 0x0, 0x7fffffff, 0x7fff71c22ed8, 0x0, 0x0, ...)
	/usr/local/go/src/runtime/traceback.go:273 +0x1aec
runtime.addOneOpenDeferFrame.func1()
	/usr/local/go/src/runtime/panic.go:721 +0x91
runtime.systemstack(0x487db4)
	/usr/local/go/src/runtime/asm_amd64.s:370 +0x66
runtime.mstart()
	/usr/local/go/src/runtime/proc.go:1116


goroutine 8278 [running]:
runtime: unexpected return pc for runtime.systemstack_switch called from 0x0
stack: frame={sp:0x7fff71c22cc0, fp:0x7fff71c22cc8} stack=[0xc0016e4000,0xc0016e8000)

runtime.systemstack_switch()
	/usr/local/go/src/runtime/asm_amd64.s:330 fp=0x7fff71c22cc8 sp=0x7fff71c22cc0 pc=0x487ee0
created by golang.org/x/sync/errgroup.(*Group).Go
	/go/pkg/mod/golang.org/x/sync@v0.0.0-20200625203802-6e8e738ad208/errgroup/errgroup.go:54 +0x74


goroutine 1 [chan receive]:
testing.(*T).Run(0xc000500600, 0x214ec46, 0x9, 0x223ef60, 0x0)
	/usr/local/go/src/testing/testing.go:1169 +0x5f4
testing.runTests.func1(0xc000500600)
	/usr/local/go/src/testing/testing.go:1439 +0xa7
testing.tRunner(0xc000500600, 0xc000121ce0)
	/usr/local/go/src/testing/testing.go:1123 +0x203
testing.runTests(0xc0001b6d80, 0x2daffe0, 0xc, 0xc, 0xbff39cd96b1b208f, 0x1179127ca7c, 0x2e3c840, 0xc0004219b0)
	/usr/local/go/src/testing/testing.go:1437 +0x613
testing.(*M).Run(0xc0001ac300, 0x0)
	/usr/local/go/src/testing/testing.go:1345 +0x3b4
main.main()
	_testmain.go:67 +0x237

...
```
Repository: create-react-app
Issue: jest.config.js
Labels: needs triage

Can i use jest.config.js instead of package.json "jest" area for additional config ?

react-scripts test -- --config=jest.config.js with empty {} fails
Repository: opencv
Issue: DNN unsupported Layer reorg3d
Labels: feature,category: dnn

##### System information (version)

- OpenCV => 4.5.0
- Operating System / Platform => Ubuntu 18.04
- Compiler => g++ (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0


##### Detailed description

I followed a custom network architecture from a paper that is specialized on small objects.

The network loads and works fine using plain darknet (https://github.com/AlexeyAB/darknet)

But if I import the network in OpenCV DNN it throws an exception:

```
terminate called after throwing an instance of 'cv::Exception'
  what():  OpenCV(4.5.0) .../modules/dnn/src/darknet/darknet_io.cpp:865: error: (-212:Parsing error) Unknown layer type: reorg3d in function 'ReadDarknetFromCfgStream'

Aborted (core dumped)
```
Looks like the layer `reorg3d` is yet not implemented. https://docs.opencv.org/master/d6/d87/group__dnnLayerList.html also does not list the layer.
Repository: storybook
Issue: Controls: ReactNode type prop crashes Storybook when trying to enter arbitrary values in the corresponding control
Labels: bug,react,addon: controls

**Describe the bug**
I have a component, which exposes a prop like `footer: React.ReactNode`. This prop is rendered as a text control with some JSON values populated if I pass any JSX as an argument. This the first problem. The second problem is if I try to remove all the text in the control and type something of my own, then Storybook crashes and shows me this error message.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to `https://github.com/thesobercoder/Graphite` and clone the repo
2. Run `yarn && yarn sb`
3. Navigate to `./apps/explorer/src/stories/GCard.stories.tsx` to view the sourcecode if needed
4. Visit `http://localhost:4400/?path=/story/card--with-footer`
5. Find the `footer` control and delete the text and try to write some HTML/text. 
6. Then delete the entire text and see the error popup

**Expected behavior**
The error shouldn't be thrown and there should be a better way to represent props of type `ReactNode` instead of a complex JSON.

**Screenshots**
![image](https://user-images.githubusercontent.com/1915249/103556772-4441d680-4ed8-11eb-871d-85a7c37597fa.png)

**Code snippets**
Included in the repo `https://github.com/thesobercoder/Graphite`

**System**
```
System:
    OS: Linux 4.19 Ubuntu 20.04.1 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
  Binaries:
    Node: 15.4.0 - /usr/bin/node
    Yarn: 1.22.5 - /usr/bin/yarn
    npm: 7.0.15 - /usr/bin/npm
  npmPackages:
    @storybook/addon-controls: ^6.1.11 => 6.1.11
    @storybook/addon-docs: ^6.1.11 => 6.1.11
    @storybook/addon-essentials: ^6.1.11 => 6.1.11
    @storybook/addon-knobs: ^6.1.11 => 6.1.11
    @storybook/addon-storysource: ^6.1.11 => 6.1.11
    @storybook/react: ^6.1.11 => 6.1.11
```

**Additional context**
The project is bootstrapped with `nx`.
Repository: excalidraw
Issue: Double-clicking and dragging goes into unexpected text mode
Labels: bug

See below for reproduction:

![excalidraw-bug](https://user-images.githubusercontent.com/1093738/103563918-9f011100-4e8b-11eb-82bf-b04f61b0ed04.gif)

1. Double-click anywhere
2. Start dragging
3. Release mouse

**Expected:** Double-click ignored; in "selection mode"
**Actual:** Double-click registered; in "text insertion mode"
Repository: excalidraw
Issue: Show changes made after last visit in collaboration mode
Labels: enhancement

When collaborating with others, it would be very handy to know, what changes did occur after one's last visit. Therefore, I propose to somehow highlight the modified elements on the whiteboard, when opening a whiteboard in collaboration mode.
Repository: rust
Issue: Mismatched lifetime on trait impl shows a misleading error
Labels: A-diagnostics,A-lifetimes,A-trait-system,T-compiler,C-bug,D-confusing,D-papercut

The rust compiler gives a very poor error message when there is a lifetime expectation mismatch on trait usage.

I used this code: (playground link: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=581fa159f8ff99f2df447308fccd4bbc )

```rust
use std::cell::*;

#[derive(Default)]
struct Test {
    pub foo: u32,
}

trait FooSetter {
    fn set_foo(&mut self, value: u32);
}

impl FooSetter for Test {
    fn set_foo(&mut self, value: u32) {
        self.foo = value;
    }
}

trait BaseSetter{
    fn set(&mut self, value: u32);
}
impl BaseSetter for dyn FooSetter{
    fn set(&mut self, value: u32){
        self.set_foo(value);
    }
}

struct TestHolder<'a> {
    pub holder: Option<RefCell<&'a mut dyn FooSetter>>,
}

impl <'a>TestHolder<'a>{
    pub fn test_foo(&self){
       self.holder.as_ref().unwrap().borrow_mut().set(20); 
    }
}



fn main() {
    let mut test = Test::default();
    test.foo = 10;
    {
        let holder = TestHolder { holder: Some(RefCell::from(&mut test))};
        
        holder.test_foo();
    }
    test.foo = 30;
}

```

I expected to see a useful error message, such as "expected trait `BaseSetter<'a>`, found trait: `BaseSetter<'static>`"

Instead, I was greeted with this almost useless error message: "expected trait `BaseSetter`, found trait `BaseSetter`"

The same error occurs on stable and nightly compilers
Repository: TypeScript
Issue: [JS] Incorrectly identifying what "this" is
Labels: Suggestion,Awaiting More Feedback

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.52.1
- OS Version: Windows 10 19042.685

`this` on debugger (`Command` class instance, has `checkPermissions` function)
![image](https://user-images.githubusercontent.com/20730142/103157047-f3bad280-478d-11eb-88c1-e34a59978d57.png)

`this` on IDE (Constructor object params, doesn't have `checkPermissions` function)
![image](https://user-images.githubusercontent.com/20730142/103157067-3aa8c800-478e-11eb-8e34-1de594ac5562.png)

Steps to Reproduce:

1. Instantiate a Class which uses object destructuring on its constructor)
2. Use `this` inside a function that is a property of the constructor object

<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
Repository: pytorch
Issue: Magma functions that don't have queue argument create cublas handles for each call
Labels: module: performance,triaged,module: linear algebra

E.g. in `magmaCholeskySolve`, magma_<t>potrs_gpu is called which does not have queue argument. Magma implementation creates a queue argument with `magma_queue_create` which creates new cublas handle (that's bad in itself), sets a stream to a newly created stream (also bad, but we insert necessary synchronizations which we'd rather not do). Then magma implementation proceeds to call cublas<t>trsm. Link to zpotrs_gpu function https://github.com/maxhutch/magma/blob/e63a6c0fde9170896125de3b6437f7ce0f96837a/src/zpotrs_gpu.cpp#L62, it's an older version, but implementation did not change for the new magma versions. 
This function is a thin wrapper over cublas, and we should not depend on magma for it. 

A better (but still not ideal) situation exists with magma triangular solve (magma_<t>trsm) where luckily magma has a queue argument so it doesn't create cublas handle every time, but still, this function is a wrapper over cublas function, and we don't need magma for this. 

It's possible that there are other magma functions in this category. 
cc @jianyuh @nikitaved @pearu @mruberry @heitorschueroff @walterddr @IvanYashchuk @VitalyFedyunin @ngimel @zasdfgbnm
cc @xwang233
Repository: excalidraw
Issue: Text is blurry when rendered on canvas
Labels: bug,font

**Problem**

When the text isn't focused or highlighted, it is fuzzy. 
When I highlight the font with my cursor it isn't fuzzy. 

<img width="254" alt="image" src="https://user-images.githubusercontent.com/71530103/103586497-30d04480-4eb3-11eb-8a01-1da81e15dc00.png">