sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: runtime: test failures introduced on ppc64le with change to improve fastrand
Labels: NeedsInvestigation

### What version of Go are you using (`go version`)?
tip

### Does this issue reproduce with the latest release?
intermittently, only seen on the golang build page so far

### What operating system and processor architecture are you using (`go env`)?
ppc64le

### What did you do?
When the fastrand change was merged https://github.com/golang/go/commit/e7e4a4ffa3330518250c4075e1f16a8ba62414df runtime failures started to happen intermittently for ppc64le on the build page. Another change was merged after that resulting in consistent failures on ppc64le that hid this one for a while, but that one has now been fixed.

### What did you expect to see?
ok for the ppc64le build on the build page

### What did you see instead?
fail for the ppc64le build on the build page intermittently

Here is an example of when it fails https://build.golang.org/log/8552765394dde8879c15b4e35b2f995606b8ed1b.

Looks like the tests are all parked waiting to run and it times out.

If I look at the change where this started happening, the only thing that looks like it could affect this is the code that was moved in mcommoninit to be under control of a lock where it wasn't before, but I can't say that is wrong, just different.

I have not been able to reproduce this anywhere else.
Repository: TypeScript
Issue: Strict variance and read-only versions of types
Labels: Suggestion,In Discussion

I feel like we should have an open "suggestion" issue with a meaningful title to track the work on stricter variance and read-only versions of types that the TypeScript team is considering, especially as other issues are being duped against it.  The initial design sketch and a few comments are in #17502.

After a little more searching, should this be merged with #10725?
Repository: electron
Issue: Support REPL on Windows
Labels: enhancement :sparkles:,platform/windows

The `electron --interactive` option [supposedly](https://electron.atom.io/docs/tutorial/repl/) only works on macOS and Linux. What would it take to add Windows support?
Repository: material-ui
Issue: Tooltip doesn't work for <IconButton disabled>
Labels: component: tooltip,enhancement

<!-- Checked checkbox should look like this: [x] -->
- [x] I have searched the [issues](https://github.com/callemall/material-ui/issues) of this repository and believe that this is not a duplicate.

## Expected Behavior
Tooltip is visible for hover

## Current Behavior
Tooltip is hidden for hover

## Steps to Reproduce (for bugs)
```jsx
<Tooltip title="Tooltip" placement="bottom">
  <IconButton disabled>
  <Done/>
  </IconButton>
</Tooltip>
```

## Your Environment

| Tech         | Version |
|--------------|---------|
| Material-UI  |    v1.0.0-beta.12     |
Repository: react
Issue: Multiple onFocus events fired on single focus in Safari
Labels: Type: Bug,Component: DOM

I'd like to report a possible bug.

1. Brief description
OnFocus synthetic event is fired multiple times on single focus occurrence in Safari. Expected behaviour is for it to be fired only once per focus.

2. Live demo: https://codesandbox.io/s/101pnjxq27

3. Minimal steps to reproduce
- install create-react-app
`$ npm install -g create-react-app`

- create an example application
`$ create-react-app input-focus-test`
`$ cd input-focus-test`

- edit application file and add input with onFocus event handler
`$ vi src/App.js`

```javascript
import React, { Component } from 'react';
import logo from './logo.svg';
import './App.css';

class App extends Component {
  handleOnFocus = evt => {
        console.log('handleOnFocus', evt);
  }

  render() {
    return (
      <div className="App">
        <header className="App-header">
          <img src={logo} className="App-logo" alt="logo" />
          <h1 className="App-title">Welcome to React</h1>
        </header>
        <p className="App-intro">
          To get started, edit <code>src/App.js</code> and save to reload.
        </p>
        <p>
          Input
          <input onFocus={this.handleOnFocus}/>
        </p>
      </div>
    );
  }
}

export default App;
```

- start application
`$ npm run start`

- open up locahost:3000 in Safari
- click on the input field with developer’s console opened
- notice focus event fired multiple times

4. Additional info
This issue has been found in the following environment:
- macOS Sierra version 10.12.6 (also tested and found on High Sierra)
- Safari 10.1.2 (also tested and found in Safari 10.0 and Safari 11, seems to work on latest Safari mobile, Chrome and Firefox)
- React JS 15.5.4 (also tested and found in React 16)
- example steps to reproduce above generated with create-react-app version 1.4.1

Some of our observations that might come in handy:
- this issue seems to behave randomly to some extent
- event is usually fired twice when changing focus from input to input (so first click on input fires two events, consequential fire only one, but when changing focus to a different input field it fires twice again)
- additional interesting behavior happens with multiple input fields; for instance with input fields 1 and 2, first focus on input 1 generates two events onFocus with input 1, but then focus on input 2 sometimes generates three events: onFocus with input 1, then input 2, then input 1 again as targets.
Repository: flutter
Issue: Document why Opacity is inconsistent about hit testing vs accessibility when opacity is 0.0
Labels: framework,a: accessibility,d: api docs,P2,team-framework,triaged-framework

This will prevent stacked items which are not visible from blocking items which are nevertheless "behind" them.
Repository: flutter
Issue: need to be able to write a11y integration tests
Labels: a: tests,framework,a: accessibility,P2,team-framework,triaged-framework

We should have a way to write integration tests for assistive technologies. These tests should assert that an app is usable with TalkBack (Android) and VoiceOver (iOS) just like they are supposed to.

A framework that enables that is useful for
* ourselves to verify that our a11y implementation interacts correctly with TalkBack and VoiceOver
* all Flutter apps developers to ensure that their support for assistive technologies in their apps doesn't break.
Repository: godot
Issue: Visualscript connection lines get drawn over or below the nodes each time a node gets selected
Labels: enhancement,topic:editor,confirmed,usability,topic:visualscript,topic:gui

**Operating system or device, Godot version, GPU Model and driver (if graphics related):**
Godot 3.0 master https://github.com/godotengine/godot/commit/da144fed4c49133a93b3b83cfc665352c0af351a

**Issue description:**
<!-- What happened, and what was expected. -->
![https://i.imgur.com/zJhmmrO.gifv](https://i.imgur.com/zJhmmrO.gif)

**Steps to reproduce:**
1. Add nodes to a visualscript
2. Make lines overlap nodes to better see the issue
3. Start selecting different nodes (or the same sometimes)
4. Lines get drawn over and below the overlapping node each time you select a node
Repository: godot
Issue: Visualscript disconnecting lines which node changes size cause some issues
Labels: bug,topic:editor,confirmed,topic:visualscript

**Operating system or device, Godot version, GPU Model and driver (if graphics related):**
Godot 3.0 master https://github.com/godotengine/godot/commit/da144fed4c49133a93b3b83cfc665352c0af351a

**Issue description:**
<!-- What happened, and what was expected. -->
![https://i.imgur.com/AvO24Sx.gifv](https://i.imgur.com/AvO24Sx.gif)

**Steps to reproduce:**
1. Disconnect a line which node changes size
2. Enjoy issues
Repository: godot
Issue: Visualscript selecting an input/output doesn't focus the node
Labels: enhancement,confirmed,usability,topic:visualscript

**Operating system or device, Godot version, GPU Model and driver (if graphics related):**
Godot 3.0 master https://github.com/godotengine/godot/commit/da144fed4c49133a93b3b83cfc665352c0af351a

**Issue description:**
<!-- What happened, and what was expected. -->
![https://i.imgur.com/7B7mHZt.gifv](https://i.imgur.com/7B7mHZt.gif)

Two options:
- It shouldn't happen
- The `_ready` Function node should be focused

**Steps to reproduce:**
1. Make two nodes overlap
2. Try to link an input/output line from the node underneath
Repository: rust
Issue: Documentation for new stable features can be hard to find (e.g. for associated const)
Labels: C-enhancement,P-low,A-docs

### Background

I was just changing some code to use associated consts for a struct. I wasn't sure what the exact syntax was, so I was looking for the documentation about it. I remembered that it was recently stabilized, so I googled for "rust associated constants". Here's the top results:

<img width="654" alt="screen shot 2017-09-28 at 11 44 54" src="https://user-images.githubusercontent.com/16778/30945591-826dff54-a442-11e7-919a-941f594cdeff.png">

[The first result](https://doc.rust-lang.org/1.7.0/book/associated-constants.html) looked good, but because it had "1.7.0" in the URL and it was in a "Nightly Rust" section, I wasn't sure whether this feature had changed in the time that it was stabilized, so I continued my search.

[The next result](https://github.com/rust-lang/rust/issues/29646) was the tracking issue. I tried to find a definitive statement there as to when it was actually stabilized, but couldn't find one. Also there were no links to the documentation.

So then I went looking for the [Rust 1.20 announcement post](https://blog.rust-lang.org/2017/08/31/Rust-1.20.html), and it had some documentation. That helped. But I was still looking for something that is not a blog post, something better to link to.

So I went back to the tracking issue and found a link to an issue to add documentation to the reference. Finally, I dug up this: https://doc.rust-lang.org/stable/reference/items.html#associated-constants That's what I wanted to find in the beginning!

### Possible improvements

I think there are a couple of things that could have helped me find this quicker:

1. The first google result (the nightly rust feature page) could be updated to have a big notice with a link to the stable docs for that feature and a mentioning in which Rust version it was stabilized. (You could make an argument that old docs should not be changed, but I think it's better to be pragmatic if that's what the first search result is.)
2. The blog post could link to the documentation.
3. The tracking issue description could be updated to clearly state in which stable release that feature was included and link to the documentation.

All these things would make it more likely for people to find the right documentation and not have to wonder about when a feature was stabilized.

What do you think? I'm not sure if that's something that warrants an RFC or if there are any existing checklists in place for what to do when stabilizing a feature (which we could add the above things to).
Repository: neovim
Issue: 'joinspaces' should be buffer-local
Labels: enhancement,options

### Actual behaviour

The 'joinspaces' option is global, meaning you can't set this option differently for text files and code.

### Expected behaviour

This option should be buffer-local, with a fallback to the global setting, just like many others. See 'global-local'.
Repository: neovim
Issue: :terminal should clear history on `reset`
Labels: enhancement,terminal

I think embedded terminal should behave like external one and clear the `:terminal` buffer history if type `reset` in it.
Repository: go
Issue: cmd/compile: avoid allocations for some return values
Labels: Performance,NeedsInvestigation,compiler/runtime

A non-inlinable function that returns new memory always allocates it on the heap. For example, in the base64 package the `DecodeString` method returns a heap-allocated byte slice:

```func (enc *Encoding) DecodeString(s string) ([]byte, error)```

It is common for this return value to have limited life, easily scoped to the stack:

```
b, err := enc.DecodeString(s)
if err != nil { ... }
data = append(data, b...)
```

For cases like this, the `DecodeString` method could have been made more efficient by writing in a style where the `[]byte` was passed as an argument:

```func (enc *Encoding) AppendDecodeString(out []byte, s string) ([]byte, error)```

No heap allocation is necessary for calling this version. This transformation has been manually applied in many places in the standard library, from the `Append*` functions in strconv to `io.Reader` itself.

The compiler could do this automatically.

For concrete methods, the original function signature can be satisfied by a wrapper function, that allocates the value on the heap and calls a variant where return values containing pointers are passed as "out" arguments. When compiling code that can keep the output on the stack, the caller can be modified to use the generated functions.

For example, the implementation of `DecodeString` is:

```
func (enc *Encoding) DecodeString(s string) ([]byte, error) {
        dbuf := make([]byte, enc.DecodedLen(len(s)))
        n, _, err := enc.decode(dbuf, []byte(s))
        return dbuf[:n], err
}       
```

Currently, escape analysis determines that `dbuf` escapes to the heap without ever seeing how the value is used. Instead, the compiler can split this function in two, an inlinable allocation function, and a body:

```
func (enc *Encoding) ΨDecodeString(s string) []byte {
        return make([]byte, enc.DecodedLen(len(s)))
}

func (enc *Encoding) ΦDecodeString(s string, dbuf *[]byte) error {
        n, _, err := enc.decode(*dbuf, []byte(s))
        *dbuf = dbuf[:n]
        return err
}

func (enc *Encoding) DecodeString(s string) ([]byte, error) {
        out := enc.ΨDecodeString(s) // inlined
        err := enc.ΦDecodeString(s, &out)
        return out, err
}
```

Then the compiler can transform callers of `DecodeString` where the return value would fit on the stack to two calls to `ΨDecodeString` and `ΦDecodeString`. The first is inlined, determined not to escape and so `dbuf` lives on the stack.

The general analysis of can the Ψ allocation function be inlined, and how does it pass data dependencies to the Φ function could get complicated.
Repository: vscode
Issue: Add control to open file shown in "replace preview" editor when performing project-wide find/replace
Labels: help wanted,feature-request,search

While performing a project-wide find/replace, opening an occurrence from the search sidebar opens a "replace preview" diff editor. This view is not editable, so if the user would like to edit the displayed file, the only current way to do so is manually either from the explorer sidebar or the quick-open palette.

Per @roblourens' suggestion in #35323, "There should be a working Open File button that always appears, git repo or not, in the replace diff editor."
Repository: angular
Issue: Form validators re-run on view (re)creation
Labels: type: bug/fix,freq2: medium,area: forms,state: confirmed,forms: validators,P4

<!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.

ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->

## I'm submitting a...
<!-- Check one of the following options with "x" -->
<pre><code>
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
</code></pre>

## Current behavior
<!-- Describe how the issue manifests. -->

When the directive associated with a form control is created in the view, validators are triggered.

## Expected behavior
<!-- Describe what the desired behavior would be. -->

Validators should **not be triggered when the view changes**. Reactive forms should not be tied to the way they are represented in the view. Their source of truth should be the **model**.

## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->

https://stackblitz.com/edit/angular-reactive-forms-issue?file=app/app.component.ts

1. Open console.
2. Use the _Toggle visiblity_ button to confirm that validators are running on each control directive creation.

## What is the motivation / use case for changing the behavior?
<!-- Describe the motivation or the concrete use case. -->

3. Continue from above steps.
4. Press _set errors manually_ to insert an error manually (this is mocking manually setting an error after validation is returned from backend)
5. Press _Toggle visiblity_ to make it disappear. Nothing happens in console.
6. Press it again to make the control appear. Notice that console logs, which means that validators is running.

Observe the fact that **error message is now gone**. Toggling the view is mocking the use-case of having a mulitpart form.

---

If this is by design, I don't see a reason for it. We're creating a view where we write data form model to view. The action of reading from model should not trigger validators, as far as I understand. As I see it, validators should be run when the `FormControl` instances are created in the model. _Why are validators triggered when value did not change?_

## Environment

<pre><code>
Angular version: 4.3.6
<!-- Check whether this is still an issue in the most recent Angular version -->
Repository: go
Issue: net/http: document security considerations for serving internet traffic
Labels: Documentation,NeedsFix

The `net/http/pprof` package _implicitly_ registers HTTP handlers through its `init()` function. I argue this implicit behavior is too subtle and may contribute to people inadvertently leaving such endpoints open. Some IPv4 scans reveal a non-trivial number of pprof endpoints exposed (http://mmcloughlin.com/posts/your-pprof-is-showing). Since Go 1.9 an exposed pprof endpoint leaks source code.

I would like to spark a discussion on the possibility of moving to an _explicit_ handler registration model. It is not clear to me that this would qualify for the Security exemption of the Go 1 compatibility guarantee, but I thought it was worthy of mention. Perhaps a warning in documentation would be enough.
Repository: rust
Issue: Crate naming confusion - use underscores always. E.g. tokio-core and serde_derive
Labels: T-compiler,C-feature-request

We need to make things a bit more consistent: 'extern' crate name _should equal_ crate name in the toml file.

For example: tokio-core and serde_derive are both valid crate names.

But 
> extern crate tokio-core; 

is a compile error as it's not a valid rust name. Instead we have to use underscore:

> extern crate tokio_core;

Can we ban new crates being published on crates.io with hyphens so that we _only_ have underscores. (Or alternatively ban underscores and only have hyphens). Worst case, can we ensure that no one can publish a crate called tokio_core if there is already a tokio-core as this is a security risk of someone publishing a malicious crate.
Repository: rust
Issue: Make or (|) patterns work with match default binding modes
Labels: C-enhancement,T-compiler

Consider the following example which (at the time of writing, i.e. #44614) fails:

```rust
pub fn main() {
    let x = &Some((3, 3));
    let _: &i32 = match x {
        // Here, each of the patterns are treated independently
        //
        // FIXME(tschottdorf): make this compile without the actual `|`.
        // @nikomatsakis suggested perhaps just removing the code which
        // complains but wasn't sure whether it's still required for anything.
        // Opinions?
        //
        //          Some((x, 3)) | &Some((ref x, 5)) => x,
        //                - first binding     ^ bound in different ways
        /*Some((x, 3)) |*/ &Some((ref x, 5)) => x,
        _ => &5i32,
    };
}
```

It's not clear whether the rule that prevents this from compiling is still worthwhile.

@nikomatsakis had this to say:

> I suspect we can just remove it but it may be used by some code somewhere
i.e., I'm pretty sure the old trans code (obviated by MIR now) used to rely on that (that each binding had a single "mode") but...
well, maybe MIR builder does too, who knows
honestly maybe not worth supporting
(well, I guess that if we keep the check, we would want to check the inferred mode -- probably better if we ditch it and figure out if we have to change anything else as a result)
Repository: vscode
Issue: File extension specific settings
Labels: feature-request,config

This was discussed here:
https://github.com/Microsoft/vscode/issues/1587

but instead what was implemented was language specific settings. That doesn't help us where we have the same language in files with different extensions but what to impose different settings on them.

(ex. I have a DSL like language that looks like JS, I want to make it syntax highlight as JS, but disable validation because some things aren't quit right. Having to fork the JS language bindings for that and maintain it is unfortunate.)
Repository: angular
Issue: animations: query is not working when querying for animations inside ng-content that are not first descendant node 
Labels: type: bug/fix,area: animations,freq1: low,P3

## I'm submitting a...
<pre><code>
[x] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
</code></pre>

## Current behavior
`query` doesn't work properly in a particular case, it's best to check the [stackblitz example](https://stackblitz.com/edit/animations-ng-content-query-bug?file=app%2Fdummy.component.ts), it seems that when 

1) animation you query is inside a component using `ng-content`
2) animation inside that component is not the FIRST child node of said component

query + stagger is not working, which I assume means query is not catching them at all.. it works fine if you use a div instead of component with ng-content OR or the child animation is the first descendant


## Minimal reproduction of the problem with instructions
click the button - https://stackblitz.com/edit/animations-ng-content-query-bug?file=app%2Fdummy.component.ts 

## Environment
5.0.0-rc.0


cc @matsko
Repository: go
Issue: x/crypto/ssh/agent: Accept Flags in Agent.Sign()
Labels: NeedsDecision

I was trying unsuccessfully to get ssh-agent to sign a JWT via the x/crypto/ssh/agent.Agent::Sign() interface.

In https://github.com/golang/crypto/blob/master/ssh/agent/client.go#L371, the Flags in signRequestAgentMsg was left as default (0).

	req := ssh.Marshal(signRequestAgentMsg{
		KeyBlob: key.Marshal(),
		Data:    data,
	})

In OpenSSH ssh-agent, https://github.com/openssh/openssh-portable/blob/master/ssh-agent.c#L262, the signing algorithm is being determined by parsing the flags sent in the signRequestAgentMsg - 2 for rsa-sha2-256 and 4 for rsa-sha2-512, and sending 0 probably defaults the algorithm to SHA1.

It seems that allowing the caller to specify flags, or at a higher level, an algorithm name, would be able to resolve this, but I'm not sure what is the best way to implement this.