sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: electron
Issue: Create an alwaysOnTopOfWindow browser option to allow windows to be always on top of specific windows
Labels: enhancement :sparkles:

### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->

* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

### Problem Description
I want a window that's opened by window.open (or other windows I suppose) to be always on top of the main window, but I don't want them to be on top of all windows on the OS, which is how the `alwaysOnTop` flag currently works.

Making the window a child of the other window gets me that behavior, but it also gets me other behavior that I don't want. For example, I don't get a separate taskbar icon for the window.

### Proposed Solution
Could we get a new flag `alwaysOnTopOfWindow` that's assigned to the specific window that I want this to be on top of? (also an API for toggling this would be nice).
```
const win = new BrowserWindow({
    alwaysOnTopOfWindow: mainWindow
});
```

### Alternatives Considered
Right now, I have to use the `parent` option to make the window a proper child of the other window, but this comes with other behavior that I don't really want.
Repository: flutter
Issue: No link local adapter when personal hotspot is enabled on iOS
Labels: c: new feature,platform-ios,tool,a: quality,customer: crowd,P2,team-ios,triaged-ios

This sometimes causes mDNS to fail when host and device are connected to public wifi.

From: https://github.com/flutter/flutter/issues/46698 @dnfield says:

> When hotspot is enabled, we don't get a link local adaptor. And by default, when I'm otherwise connected, that adaptor is disabled. We should look to see if there's some way we can enable that adapator (I'm thinking something like either `ifconfig up` or `defaults` should be able to control that somehow).
Repository: go
Issue: x/build: report failures fast but still make all test results available
Labels: Builders,NeedsInvestigation,FeatureRequest

(This feature request/enhancement is related to issue #34119, the goal is to improve developer experience at the expense of using more computational resources.)

In https://github.com/golang/go/issues/14305#issuecomment-565093254, there is discussion of whether to use -k on which branches, and on post-submit only vs trybots too. There is a trade-off in that the flag improves information that a failed build reports, but makes the test failure get reported more slowly.

A more ideal (for user developer experience) solution is to report a failure fast, as soon as the first test fails, but keep going and make all test results available for later viewing by interested parties.

See the [fast-finish builds](https://blog.travis-ci.com/2013-11-27-fast-finishing-builds) feature of Travis CI for some related precedent.

/cc @bradfitz @bcmills @toothrot @cagedmantis
Repository: terminal
Issue: Code Health: Update existing winrt properties to use `GETSET_PROPERTY` when possible
Labels: Help Wanted,Product-Terminal,Issue-Task,Area-CodeHealth

Pretty self explanatory. Classes with a bunch of
```c++

    uint32_t TerminalSettings::DefaultForeground()
    {
        return _defaultForeground;
    }

    void TerminalSettings::DefaultForeground(uint32_t value)
    {
        _defaultForeground = value;
    }
```

Is an enormous amount of boilerplate we don't need.

```c++
GETSET_PROPERTY(uint32_t, DefaultForeground, DEFAULT_FOREGROUND_WITH_ALPHA);
```

is better.
Repository: terminal
Issue: Add a setting to disable mouse-wheel scrolling
Labels: Help Wanted,Area-TerminalControl,Area-Settings,Product-Terminal,Issue-Task,good first issue

This is in lieu of having actual mouse bindings. Some people might actually want the mouse to not scroll, or might want to pass the mouse scrolling through.

Until we have proper mouse bindings, this settings should suffice.

###### note 11/8/2021

This task is a "instead of #1553" task. If we just do #1553, then this isn't relevant. 

###### note 2/22/2022

I'd add this as a profile setting, `experimental.mouseWheelScrolling: bool`. Probably just the same as #11710. Since we're using this as an "escape hatch" issue while we wait for the architecture to do #1553 right, I'd just go ahead and disable all wheel scrolling with this setting - including opacity scrolling and zooming.
Repository: terminal
Issue: Use an indeterminate progress ring on the tab before a tab is "connected"
Labels: Help Wanted,Area-UserInterface,Product-Terminal,Issue-Task


Browsers will often use a little spinning animation to indicate that a tab is loading before displaying the favicon. For shells like wsl and the Azure connector, we could maybe do something similar, where we keep it on the spinner until we get the first byte.

This would probably require support from WinUI for progress wheels in tabs first
Repository: terminal
Issue: Add support for pane switching via tab switcher
Labels: Area-UserInterface,Product-Terminal,Issue-Task

As brought up in the tab switcher spec, we probably also want people to be able to navigate panes with that switcher.

cc @leonMSFT since I stole this idea straight from his spec.
Repository: terminal
Issue: Make `Pane` a proper WinRT type
Labels: Product-Terminal,Issue-Task,Area-CodeHealth,Priority-2


Pretty self explanatory. Right now they're plain c++ types, but in reality they should be exposed as projected WinRT types, so they can be used across binary boundaries.
Repository: pytorch
Issue: `clip_grad_norm` allows negative `max_norm` values
Labels: module: nn,triaged,enhancement

## 🚀 Feature
<!-- A clear and concise description of the feature proposal -->

Hello,

This is not really a feature request, nor a bug report, more a "additional check" proposal.

## Motivation

<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->

The current implementation of [nn.utils.clip_grad_norm](https://pytorch.org/docs/stable/_modules/torch/nn/utils/clip_grad.html) allows to pass negative `max_norm`.
If you do so, it will fail silently and even worse, reverse all the gradients... 
## Pitch

<!-- A clear and concise description of what you want to happen. -->

It would be good to have a sanity check or to avoid doing anything if negative values are passed.


## Alternatives

<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->

## Additional context

<!-- Add any other context or screenshots about the feature request here. -->
Repository: flutter
Issue: Add color gradient support to polygon in google_maps_flutter
Labels: c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill our the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case

Gradient Support?

I was thinking of this between 3 points **A, B & C**

From *A(Red) to B(green) to C(blue)*

![Screenshot from 2019-12-17 22-21-07](https://user-images.githubusercontent.com/34790378/71016748-9d976600-211b-11ea-8462-bbdcc1a879e6.png)
![Screenshot from 2019-12-17 22-23-58](https://user-images.githubusercontent.com/34790378/71017035-ff57d000-211b-11ea-961c-d5826ecab982.png)

## Proposal

If the polygon function could take colors as prop, it would be better isn't it?

Like the support in https://github.com/react-native-community/react-native-maps/pull/1911 ?

![](https://camo.githubusercontent.com/61a0639364bb4f6634b44a87bacbd8fc525c4c44/68747470733a2f2f692e696d6775722e636f6d2f5a61344465766d2e706e673f31)
Repository: terminal
Issue: Create a connection for simple testing Windows Terminal performance
Labels: Area-Performance,Area-TerminalConnection,Product-Terminal,Issue-Task

Right now, the Windows Terminal's perf is pretty tightly bound to the perf of conpty. It might be a little hard for us to be able to really analyze the performance bottlenecks of the Terminal, if we're also hitting the bottlenecks of conpty in another thread.

To aid in debugging, I think we should add another connection implementation. This connection should only be valuable for debugging and perf testing. I'm imagining something where it can be configured to emit some number of lines of text, either in monochrome, 16 color, or 256/rgb color, and then it just times how long it takes to emit that sequence. It'll emit all that text, then just print statistics on how long it took to emit all that text.


Ideas for settings: (though I'm not sure if this is too much work)
```jsonc
{
    "name": "Perf test",
    "connectionType": "some guid",
    "linesToTest": 10000, // or -1 for run without stopping
    "colors": "monochrome", // or "16color", "256color"
    "style": "ascii" // or unicode for CJK/emoji
},
```

This way, we can get traces on _just_ the Terminal, isolated from conpty.
Repository: PowerToys
Issue: Improve test coverage for Runner
Labels: Area-Tests,Area-Quality

# Summary of the new feature/enhancement

There is currently no test coverage for the runner project.

# Proposed technical implementation details (optional)

1.  Identify business logic and test cases that should be applied for the runner. 
2.  Provide unit tests that can be applied without a redesign of the runner code. 
3.  Propose refactoring/redesign of the runner code that may improve the testability of the codebase.
Repository: terminal
Issue: Design a way for TerminalConnections to receive arbitrary (JSON?) arguments
Labels: Issue-Feature,Area-TerminalConnection,Area-Settings,Product-Terminal

This will allow a connection type to peer into the _profile_ that spawned it to get more information out of it, like a `port` from a telnet profile and a `username` from an SSH profile.
Repository: deno
Issue: Default timeouts and size limits for `Deno.serve`
Labels: feat,ext/http

Deno tries to have similar standard library as Go which is great, but... Keep in mind that event Go authors made some mistakes when initially developed std. For example by default HTTP server and client doesn't add any timeouts. In order to have production ready HTTP server in Go you would want to add Read/Write timeouts.

```go
s := &http.Server{
	Addr:           ":8080",
	Handler:        myHandler,
	ReadTimeout:    10 * time.Second,
	WriteTimeout:   10 * time.Second,
	MaxHeaderBytes: 1 << 20,
}
log.Fatal(s.ListenAndServe())
```

Back to deno. For now there is only few options available.

```ts
interface ServerConfig {
  port: number;
  hostname?: string;
}
```


Example for slow client attack which creates new TCP connections on the server and by slowly reading response body doesn't close it which would eventually lead to server out of file descriptors errors.

Deno server

```ts
import { serve } from "https://deno.land/std@v0.24.0/http/server.ts";
const s = serve({ port: 8000 });
console.log("http://localhost:8000/");

async function main() {
    for await (const req of s) {
        console.log('request:', req);
        const body = new TextEncoder().encode(`Hello World ${Date.now()}\n`);
        req.respond({ body });
        console.log('response:', body.length);
    }
}

main()
```

Go test client
```go
package main

import (
	"fmt"
	"net/http"
	"time"
)

func main() {
	client := &http.Client{}
	for {
		go func() {
			req, err := http.NewRequest("POST", "http://localhost:8000", nil)
			if err != nil {
				panic(err)
			}
			res, err := client.Do(req)
			if err != nil {
				panic(err)
			}
			defer res.Body.Close()
			// Simulate slow clean attack by reading response body slowly.
			buf := make([]byte, 1)
			for {
				_, err := res.Body.Read(buf)
				if err != nil {
					fmt.Println(err)
					break
				}
				time.Sleep(100 * time.Second)
			}
		}()

		time.Sleep(1 * time.Second)
	}
}
```

Check established connections with `lsof -p <PID>`

```
// 53
deno    19997 anjmao  177u    IPv4 0x35f50d8024691719      0t0      TCP localhost:irdmi->localhost:61961 (ESTABLISHED)
deno    19997 anjmao  178u    IPv4 0x35f50d80249ec3b1      0t0      TCP localhost:irdmi->localhost:61963 (ESTABLISHED)
deno    19997 anjmao  179u    IPv4 0x35f50d80249eb0a1      0t0      TCP localhost:irdmi->localhost:61965 (ESTABLISHED)
deno    19997 anjmao  180u    IPv4 0x35f50d8024a4a0a1      0t0      TCP localhost:irdmi->localhost:61967 (ESTABLISHED)
// 58 
// ...
// 209
```
Repository: rust
Issue: Cargo fix generates broken code for type names passed to derives
Labels: A-lints,A-macros,T-compiler,C-bug,A-suggestion-diagnostics,E-needs-mcve,D-invalid-suggestion,A-edition-2018

When a type is given to a proc macro as a string, such as in https://github.com/diesel-rs/diesel/blob/6e2d467d131030dc0bbce4e4801c7bee7bcbf0dd/diesel/src/type_impls/primitives.rs#L20, `cargo fix --edition` will incorrectly generate `crate::"::old_type::Path"`. If there are nested types inside, such as https://github.com/diesel-rs/diesel/blob/6e2d467d131030dc0bbce4e4801c7bee7bcbf0dd/diesel/src/type_impls/primitives.rs#L42, they won't be touched at all.
Repository: react-native
Issue: Nested Text with onPress / TouchableOpacity Bug
Labels: Component: TouchableOpacity,Bug,Never gets stale

Hey there. I found an issue when rendering nested Text elements. It's almost the exact same as this ticket: https://github.com/facebook/react-native/issues/1030

I was able to get it to sort of work. I had to add an `onPress` to the Text component.

Problems:
- TypeScript says there isn't an `onPress` on Text elements. But it does in fact work. This should probably be fixed in the type definitons.
- Not possible to use TouchableOpacity, so it doesn't feel good when pressing on these items. 

When using TouchableOpacity like this:

```js
<Text>
  <Text>first part</Text>
  <TouchableOpacity><Text>Second part</Text></TouchableOpacity>
</Text>
```
Second part doesn't get rendered at all.

Before you suggest using a `<View>` around the `<Text>` instead, please look at the referenced issue. When you do that, the text runs off screen, or wraps weirdly.

TLDR; I need to add a touchable opacity inside a nested Text component. Our api returns text in blocks, the RN app needs to parse it and render an array of text elements together with different styling.

React Native version:

0.61.4
Repository: angular
Issue: ExpressionChangedAfterChecked error improvements for Ivy
Labels: feature,hotlist: error messages,freq3: high,area: core,core: change detection,feature: in backlog

PR #34381 improves `ExpressionChangedAfterChecked` error by adding property name for property bindings and also the content of the entire property interpolation. There are few more things that we can improve:

- [x] ~~for attribute bindings and interpolations, include attribute name and the entire expression (similar to property bindings and interpolations)~~. Implemented in PR #34505.

- [x] ~~for text interpolations (like `Some exp {{ exp1 }} and {{ exp2 }}`), we can store metadata in `tView.data` and display the whole block when we throw an error (making sure we limit the length of the output from interpolation)~~. Implemented in PR #34520.

- [x] ~~when expression value is an object, the `[Object object]` is printed, we can `JSON.stringify` it (or smth similar) and limit it to 1000 chars or so~~.

- [ ] for i18n attributes (like `<div i18n-title title="Some exp {{ exp1 }}"></div>`) we can extract property name from i18n metadata (stored in `tView.data`, but using a different format). Currently property name for such cases are not be included into `ExpressionChangedAfterChecked` error.

- [x] ~~Include component's name into the error message, so that it's easier to find the template where the problem happened~~. Implemented in #50286.

- [ ] Consider including an expression that caused the problem (should work for text interpolations at least). However this is not trivial, since it'd require changes to the generated code and including the `ngDevMode` flag, so that this extra debug info doesn't make it into prod bundles.
Repository: go
Issue: go/doc: Examples includes example functions with returns
Labels: NeedsDecision

As documented at https://golang.org/pkg/testing#hdr-Examples, an example function is expected to have no parameters and no returns. `doc.Examples` considers [functions with parameters](https://github.com/golang/go/blob/4b21702fdcd17aee6a52a74cc68c7c9b0ed1b7e3/src/go/doc/example.go#L65-L67) as invalid examples and skips them.

Unlike the `vet` pass, `doc.Examples` does not check if there are results.

That means both of these are recognized as examples by `doc.Examples`:

```Go
func ExampleHello() {
	fmt.Println("hello")
	// Output: hello
}

func ExampleHi() int {
	fmt.Println("hi")
	return 42
	// Output: hi
}
```

It means `x/tools/cmd/godoc` and other tools that display documentation may show such invalid examples:

<details><summary>godoc screenshot</summary><br>

![image](https://user-images.githubusercontent.com/1924134/71032546-918fb200-20e3-11ea-83dc-21c96c3d5a04.png)

</details>

`go vet` catches this problem:

```
# example.org/p
./style_test.go:131:1: ExampleHi should return nothing
```

Perhaps `doc.Examples` should be changed to treat functions with returns as invalid examples, like it does for functions with parameters, and not include them in its output.

/cc @griesemer @jayconrod @matloob @bcmills

(This is somewhat related to issue #36184 and [CL 211598](https://golang.org/cl/211598).)
Repository: pytorch
Issue: [jit] Python type hints in TorchScript classes don't work
Labels: oncall: jit,triaged

The `self.s` assignments should be equivalent, but only the `torch.jit.annotate` one actually works

```python
@torch.jit.script
class SimpleNulls:
    def __init__(self):
        self.a = None
        # self.s = torch.jit.annotate(Optional[str], None)
        self.s : Optional[str] = None
        self.b = False
        self.f = 0


@torch.jit.script
def foo():
    options = SimpleNulls()
    options.s = "bar"
    return options.s
```

cc @suo
Repository: flutter
Issue: `testWidgets` should assert that all SystemChannels are in the same state as at the start of the test
Labels: a: tests,framework,c: API break,c: proposal,P3,team-framework,triaged-framework

We should do this before https://github.com/flutter/flutter/issues/47233

Currently, tests can do things like `setMockMethodCallHandler` on various system channels.  This actually changes global state, and the test is not held accountable for resetting it. This can cause problems for other tests, particularly if the handler is set up in a way that survives the execution of an individual test - such as how `TestTextInput` manages the handler of `SystemChannels.textInput`.

I believe we cannot do this without making it a breaking change (at least for our current definition of breaking changes).  We need to:

- [ ] Create a way to assert that message handlers (and mock message handlers) are the same from the start to finish of the test
- [ ] Update all tests to use this
- [ ] Publish a migration guide on how to do this for others.

/cc @goderbauer who I've talked about this with offline.
Repository: vscode
Issue: Add a command to add multicursors to all Highlight Occurences
Labels: feature-request,editor-multicursor,editor-symbols

One issue with F2 to rename is it doesn't "update as you type". That's the main reason I went for the current multi-cursor approach to do auto rename tag.

@aeschli and me talked a bit about having a `mirrorCursorProvider`, so this functionality can be available to more languages...But now I'm wondering if we can easily achieve this by adding a command that would put a cursor in all matching positions:

### Before

```js
function add(fir|st, second) {
  console.log(first)
  return first + second
}
```

### After command

```js
function add(fir|st, second) {
  console.log(fir|st)
  return fir|st + second
}
```

@jrieken What do you think? I think this goes together with our approach of adding structured editing (expandSelection) by leveraging language server knowledge.
Repository: TypeScript
Issue: "Did you mean parent object or child property?" in error messsages
Labels: Suggestion,Help Wanted,Effort: Moderate,Domain: Error Messages,Experience Enhancement

Discussed with @RyanCavanaugh from his personal dev experience.

It's common to get an error message when accidentally using an inner property of an object. Similarly, we might forget to actually fetch an inner property of an object.

```ts
// @strict: true

interface Person {
  residence: House;
}

interface House {
  isHouseOfPain: boolean;
}

declare let home: House;
declare let person: Person;

   home = person.residence.isHouseOfPain;
// ~~~~
// error: Type 'boolean' is not assignable to type 'House'.

   home = person;
// ~~~~
// error: Property 'isHouseOfPain' is missing in type 'Person' but required in type 'House'.
//   related: 'isHouseOfPain' is declared here.
```

It'd be nice if we could hint to the user "hey, you might have dotted too far into this object" or "hey, did you mean to grab the `residence` property?"