sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: PowerToys
Issue: [FancyZones] add "Zone ID text color" to Appearance Settings
Labels: Idea-Enhancement,Product-FancyZones

### Description of the new feature / enhancement

The Zone ID text color is rgb 0,0,0 black no matter what. Please add a Zone ID text color to FancyZones Appearance Settings to resolve the concerns in the scenario described below and enhance customizability. Thank you!

![image](https://user-images.githubusercontent.com/15337230/128613492-09491e33-f7ab-4d7b-9167-365a14be4931.png)
![image](https://user-images.githubusercontent.com/15337230/128613497-2fc40dfd-5ed6-48f0-80a7-1186d42b5dcb.png)


### Scenario when this would be used?

The currently color limitation to black makes the ID text extremely hard to read while having a low Zone opacity, (which is desirable to not obscure everything on the screen while dragging windows into zones.) Also whenever using dark mode & attempting to achieve dark Zone colors cohesive with dark mode, is it not possible. Dark text on a dark background is undesirable, harder to read and against / inconsistent with Windows design principles for dark mode UI.

### Supporting information

This feature would allow for FancyZones to be with aligned with the emergent & dominant UI principles for Windows, i.e. cohesive with dark mode UI/UX guidelines (light text on dark background.) 
https://docs.microsoft.com/en-us/windows/apps/design/signature-experiences/design-principles
Repository: vscode
Issue: GitHub - Add Github Enterprise support for Git VCS provider
Labels: feature-request,github

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

In #112043 and #115940, the Github auth provider gained the ability to auth against Github Enterprise.

However, the Git extension has its own credential mechanism, and the Github extension needs to be updated to provide it credentials for Github Enterprise.

Here the github extension is hardcoded for github.com and does not support github enterprise.
https://github.com/microsoft/vscode/blob/b52b00ce58765c4f69c8fa3b73cca9135f5ab36e/extensions/github/src/credentialProvider.ts#L14-L22

It is registered with the git extension here: https://github.com/microsoft/vscode/blob/b52b00ce58765c4f69c8fa3b73cca9135f5ab36e/extensions/github/src/credentialProvider.ts#L38

It requires 'workflow' OAuth scope.  However, that is a newer feature not available on all GH Enterprise versions, so you may not be able to require it always.
https://github.com/microsoft/vscode/blob/b52b00ce58765c4f69c8fa3b73cca9135f5ab36e/extensions/github/src/auth.ts#L27
Repository: TypeScript
Issue: unused local not detected on recursive functions
Labels: Bug

# Bug Report

<!--
  Please fill in each section completely. Thank you!
-->

### 🔎 Search Terms

unused local recursive function

### 🕗 Version & Regression Information

v4.5.0-dev.20210807

### ⏯ Playground Link

<!--
  A link to a TypeScript Playground "Share" link which shows this behavior

  The TypeScript Workbench can be used for more complex setups, try
  https://www.typescriptlang.org/dev/bug-workbench/

  As a last resort, you can link to a repo, but these will be slower for us to investigate.
-->
[Playground link with relevant code](https://www.typescriptlang.org/play?noUncheckedIndexedAccess=true&noUnusedLocals=true&noUnusedParameters=true&jsx=0&module=1&noFallthroughCasesInSwitch=true&noImplicitOverride=true&noPropertyAccessFromIndexSignature=true&ts=4.5.0-dev.20210807#code/KYDwDg9gTgLgBAbwL4FgBQ6D0mB2E7BRTQEBuwOcMAFhAK4Dm1cAZhPgJYDOcOw5UOFGABDACboAxhBxd4bfAF44ACgCUcRQD5E6OPtbt16VBjTZCxKAC44AcgBGIqHbjc4Y4JIA2z4GLgHOngOGB5SEW86YDcePgEhUTEAOhUANgBGAGYstSkZOUDnTVUNbUQkIA)

### 💻 Code

<!-- Please post the relevant code sample here as well-->
```ts
export {}

//no error even though foo is never read
const foo = () => {
    foo()
}

//error: 'bar' is declared but its value is never read.(6133)
const bar = () => {}
```

### 🙁 Actual behavior

no error even though foo is never read

### 🙂 Expected behavior

```
'foo' is declared but its value is never read.(6133)
```
Repository: rust
Issue: `rustdoc::missing_doc_code_examples` inconsistent with Rust API Guidelines
Labels: T-rustdoc,A-lints,C-discussion

When the `rustdoc::missing_doc_code_examples` lint is enabled, `rustdoc` reports that doc comments which reference another example is missing an example. This is inconsistent with the [Rust API Guidelines](https://rust-lang.github.io/api-guidelines/documentation.html#all-items-have-a-rustdoc-example-c-example).

> A link to an applicable example on another item may be sufficient. For example if exactly one function uses a particular type, it may be appropriate to write a single example on either the function or the type and link to it from the other.

Given the following:

```rust
/// Does the thing.
///
/// # Example
///
/// See [`crate::bar`].
pub fn foo() {}
```

I expected to see no warnings.

Instead, this happened:

```
warning: missing code example in this documentation
45 | / /// Does the thing.
46 | | ///
47 | | /// # Example
48 | | ///
...  |
54 | | ///
   | |__________________________^
```

### Meta

`rustc --version --verbose`:
```
rustc 1.56.0-nightly (a6ece5615 2021-08-03)
binary: rustc
commit-hash: a6ece56152d8eb11e049e9fcce147b2859e12c92
commit-date: 2021-08-03
host: x86_64-unknown-linux-gnu
release: 1.56.0-nightly
LLVM version: 12.0.1
```
Repository: vscode
Issue: Custom Webview in explorer view placed at wrong position
Labels: bug,help wanted,webview

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.59.0
- OS Version: macOs 11.4

Steps to Reproduce:

1. Install the "asm-code-lens" extension from market place (v1.8.1). It will add a custom view to the explorer view.
2. Load some project, e.g. a type script project, but it should not matter what.
3. Got to explorer view 
4. You should see the "HEXADECIMAL CALCULATOR" pane there.
5. Make sure there is some other pane **below** and expand it
6. Expand the "HEXADECIMAL CALCULATOR" pane. You will see the calculator contents.
7. Now expand the pane **above** the "HEXADECIMAL CALCULATOR"
8. This makes the "HEXADECIMAL CALCULATOR" pane to be moved down

Result:
The contents of the "HEXADECIMAL CALCULATOR" pane is not moved. It stays in the same position, i.e. it is now overlapping the pane above the "HEXADECIMAL CALCULATOR".


I have a screen cast which shows the behavior:
![webview](https://user-images.githubusercontent.com/3081973/128627670-2b481c7e-8978-4b5c-89f9-5378604273b1.gif)

I also noticed that everything goes fine if the pane below the "HEXADECIMAL CALCULATOR" is not expanded. See here:
![webview2](https://user-images.githubusercontent.com/3081973/128627690-0a6b6ef1-e989-48c5-afa1-1056e7c5a000.gif)
Repository: flutter
Issue: [Proposal] FutureBuilder: better distinguish between UI logic and business logic
Labels: c: new feature,framework,f: material design,c: proposal,team-design,triaged-design

Hi there,

this proposal is a consequence of the discussion on another thread, a `FutureBuilder` rework proposal, #87399, in which we discussed how `FutureBuilder` should be reworked (with some breaking changes).

**TLDR**: `FutureBuilder` actual implementation forces the user to mix business logic and UI logic. Introducing a new business logic callback property `listen`, along with `onError` and `onPending` builder methods bring better clarity to `FutureBuilder` usage, allowing us to distinguish between Business Logic and UI Logic. This also solves #16218.

## Use case
As of when I'm writing this, `FutureBuilder<T>` has only one `builder` method, that accepts an `AsyncSnapshot<T>` and allows to react to different state of the snapshot. Unluckily, this means to have mixed business logic and UI logic in the same method.

## Proposal
`FutureBuilder` should have a `listen` callback, that reacts to the `snapshot` 's events. Furthermore, this class should have three different `builder` properties, each for one of the future's state, i.e. `builder` (when the snapshot is on a "done" state), `onError` (when something went wrong) and `onPending` (when the snapshot is not yet done).
Here's the use-case proposal described by @iapicca:
```
return FutureBuilder<String>(
      future: myFuture,
      child :  const Center(child: CircularProgressIndicator()); /// like in "ValueListenableBuilder"
      listen: (context, snapshot) {
        /// this is a VoidCallback
        /// maybe show a snackbar on error or stuff...
      },
      onPending: (context) {
          return child!;
      },
      builder: (context, snapshot) {
          return Center(child: Text(snapshot.data!));
      },
      onError: (context, error) {
          return const Center(child: Icon(Icons.error));
      },
    );
```
Note how this proposal is not breaking the current implementation, as the builder method still accepts a snapshot.
@pstromberg98 already offered an implementation on #87672.

We should address the possibility to deprecate the `builder` property and introduce a `onComplete` builder method for more clarity.
Repository: angular
Issue: Angular renders Html Template  content before creating any clone
Labels: area: core,core: DOM rendering,cross-cutting: custom elements,P3

### Which @angular/* package(s) are the source of the bug?

compiler

### Is this a regression?

No

### Description

According to this specification [The Content Template element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/template)
The <template> HTML element is a mechanism for holding HTML that is not to be rendered immediately when a page is loaded but maybe instantiated subsequently during runtime using JavaScript.

But Angular renders and instantiates **Html Template Content**  tag during rendering Angular Components.


For example for this [repo](https://github.com/abadakhshan/test-html-template-in-angular), Angular render
`editable-list`  webComponent while it is inside Html Tag.

When I Use this template in a general HTML template outside of Angular, `editable-list`  does not render.




### Please provide a link to a minimal reproduction of the bug

https://github.com/abadakhshan/test-html-template-in-angular

### Please provide the exception or error you saw

_No response_

### Please provide the environment you discovered this bug in

```true
Angular: 12.2

Webpack: 4.3.5
```


### Anything else?

_No response_
Repository: rust
Issue: docs: clarify pointer provenance of `Rc::as_ptr()`
Labels: C-enhancement,A-docs,T-libs,A-raw-pointers,A-strict-provenance,T-opsem

It is unclear whether it is valid to mutate the `*const T` returned by `Rc::as_ptr()` without looking at or relying on implementation details (edit: assuming there is no other `Rc` or `Weak` to the same `T`, aka. strong count is 1 and weak count is 0).
A quick look at the function signature in the documentation may suggest that, given it takes a `&Rc<T>` and returns a `*const T`, it should be UB to mutate. However, `Rc<T>` itself does not own the T, so `&Rc<T>` ≠ `&T`. 
`RcBox<T>` (private, impl. detail) does own the T, and `Rc<T>` always contains a mutable pointer to the `RcBox`, so the type of reference in the receiver (`&Rc<T>` vs `&mut Rc<T>`) should be irrelevant as to whether it is valid to mutate the `*const T`.
I believe it *is* valid to mutate the `*const T` as Rc is currently implemented, despite only having a shared reference to `Rc<T>` and the pointer being const (AFAIK `*const` vs `*mut` is just "cosmetic", what matters is *how* the pointer was obtained)
This relies on implementation details of `Rc<T>` and I feel like this situation should be documented.

(The same applies to `Arc::as_ptr()`)

```rs
use std::rc::Rc;

let foo = Rc::new(1u8);

unsafe {
  // Valid? Relies on implementation details
  let foo_ref = &mut *(Rc::as_ptr(&foo) as *mut u8);
  *foo_ref += 1;
};

println!("{}", foo);
```
Repository: godot
Issue: [TRACKER] Command line-related issues
Labels: bug,topic:core,topic:editor,tracker

This issue tracks bugs related to command line support in Godot.

```[tasklist]
### Command-line argument handling
- [ ] https://github.com/godotengine/godot/issues/17778
- [ ] https://github.com/godotengine/godot/issues/81080
```

```[tasklist]
### Command-line debugger
- [ ] https://github.com/godotengine/godot/issues/19775
- [ ] https://github.com/godotengine/godot/issues/32693
- [ ] https://github.com/godotengine/godot/issues/32713
- [ ] https://github.com/godotengine/godot/issues/50170
- [ ] https://github.com/godotengine/godot/issues/51387
```

```[tasklist]
### Pull requests
- [ ] https://github.com/godotengine/godot/pull/36252
- [ ] https://github.com/godotengine/godot/pull/40627
- [ ] https://github.com/godotengine/godot/pull/44594
- [ ] https://github.com/godotengine/godot/pull/49362
- [ ] https://github.com/godotengine/godot/pull/51028
- [ ] https://github.com/godotengine/godot/pull/55696
- [ ] https://github.com/godotengine/godot/pull/55703
```
Repository: terminal
Issue: Resizing terminal clears selection
Labels: Help Wanted,Issue-Bug,Area-TerminalControl,Product-Terminal,Priority-2

### Windows Terminal version (or Windows build number)

Dev - latest

### Other Software

_No response_

### Steps to reproduce

1. Select text.
2. Resize the terminal vertically
3. Select text
4. Resize terminal horizontally


### Expected Behavior

- After 2: the selection should be preserved (both block and non-block selection)
- After 4: probably, non-block selection should remain adjusted to the new position of the selected text

### Actual Behavior

Selection is cleared both after 2 and 4 (inside _doResizeUnderLock)
Repository: youtube-dl
Issue: Enable outputting both to stdout and another file
Labels: request

<!--

######################################################################
  WARNING!
  IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################

-->


## Checklist

<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2021.06.06. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->

- [x] I'm reporting a feature request
- [x] I've verified that I'm running youtube-dl version **2021.06.06**
- [x] I've searched the bugtracker for similar feature requests including closed ones


## Description

\(Sorry for my bad English and Markdown.\)
<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->

### Problem

Outputting to stdout `$ youtube-dl -o - URL` prevents outputting to youtube-dl's \(default\) output file\(s\) \(`%(title)s-%(id)s.%(ext)s`\). [Streaming](https://github.com/ytdl-org/youtube-dl/issues/765) can be done e.g. `$ youtube-dl -o - URL | mpv -`. However, it only plays the file instead of also writing it. For single files I came up with this workaround: `$ youtube-dl -o - URL | tee >(mpv -) filename`. This prevents using youtube-dl's output templates for file naming and gets even more problematic with playlists. I.e., how to download/write a playlist and play it while it downloads?

### Possible solutions

Make `--output -` result in default output \(`%(title)s-%(id)s.%(ext)s`\). AND

1. Add a separate flag \(e.g. `--stdout`\) for stdout. If the user specifies `--stdout` but not `--output`, the only output is to stdout. If both flags are used, the output goes to both. Examples:

\# only to stdout
`$ youtube-dl --stdout URL`

\# to both, default and stdout
`$ youtube-dl --stdout --output -  URL`

\# to TEMPLATE and stdout
`$ youtube-dl --output TEMPLATE --stdout URL`

  OR
2. Enable giving several "--output" flags or arguments. Examples:

\# only to stdout
`$ youtube-dl --output /dev/stdout`

\# to default and stdout
`$ youtube-dl --output - --output /dev/stdout`
Repository: node
Issue: SRI should be checked before Unicode conversion
Labels: security,policy

### Version

v16.6.1

### Platform

Any

### Subsystem

policy

### What steps will reproduce the bug?

1. Create a file `index.js` such that its contents change after Unicode processing. For example, use

   ```sh
   $ xxd -groupsize 1 index.js 
   00000000: 2f 2f 20 c0 af 0a 0a                             // ....
   ```

2. Compute the SRI value, e.g., using OpenSSL:

   ```sh
   $ echo "sha384-$(cat index.js | openssl dgst -sha384 -binary | openssl base64 -A)"
   sha384-Z8NoAR4bc95cOnD/QrsnPsgs5pmETQ3ke3NpAVI0Ve08aqCW6aaHFRNVrhcsBCua
   ```

3. Test the SRI value in a browser:

   ```html
   <script src="index.js" integrity="sha384-Z8NoAR4bc95cOnD/QrsnPsgs5pmETQ3ke3NpAVI0Ve08aqCW6aaHFRNVrhcsBCua"></script>
   ```

4. Create `policy.json`:

   ```json
   {
     "resources": {
       "./index.js": {
         "integrity": "sha384-Z8NoAR4bc95cOnD/QrsnPsgs5pmETQ3ke3NpAVI0Ve08aqCW6aaHFRNVrhcsBCua"
       }
     }
   }
   ```

5. Run the script with the policy file:

   ```
   node --experimental-policy=policy.json index.js
   ```

### How often does it reproduce? Is there a required condition?

Always.

### What is the expected behavior?

No output, unless `index.js` contains code. In the example above, `index.js` contains a comment only.

This behavior can be observed in Chrome and Firefox.

### What do you see instead?

```
Error [ERR_MANIFEST_ASSERT_INTEGRITY]: The content of "file:///home/tniessen/dev/policy-test/index.js" does not match the expected integrity. Integrities found are: sha384-s+/FLC70SKA4cOtWba1RQAhBoGcQoMRXt/kU5mp0oDnO+hQVqm5/zQkIaG26qVa0
```

### Additional information

It seems unlikely that this could cause any real security issues, but it does allow hash collisions. Different byte sequences can result in the same Unicode character sequences, which, when hashed, result in the same digests.

The issue arises from the fact that Node.js loads a byte sequence from the resource, converts the byte sequence to a Unicode string, and then converts the string back to a byte sequence for the SRI check.

Refs: https://github.com/nodejs/node/pull/37248
Repository: vscode
Issue: Enable consuming of ES modules in extensions
Labels: feature-request,extensions,extension-host

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
When developing extensions and using either JavaScript or TypeScript we are unable to consume ES modules, only somewhat legacy CommonJS modules, setting the `type` to `module` and rewriting the extension to use `import` instead of `require` breaks the extension, generating an exception that states that all modules should use `import` instead of `require` in internal VS Code JavaScript files, I conclude it's caused by the `type: module` that forces Node to treat all `.js` files as ES modules. Tried using TypeScript which transpiles its own syntax to CommonJS module - so that's a no, I have also tried using just `.mjs` extension, again the same issue.

What is the status of this issue and are there plans to enable using of ES modules in extension development? That (could) bring somewhat big performance gains when bundling extensions with, for example, [`esbuild`](https://github.com/evanw/esbuild) because it would enable tree-shaking - dead code removal, thus loading only necessary code. But I think this is not an extension API only issue, right? This needs to be done for VS Code itself?
Repository: flutter
Issue: Flutter Web : GoogleMap Marker.icon color not changing with BitmapDescriptor.defaultMarkerWithHue
Labels: c: new feature,p: maps,platform-web,package,has reproducible steps,P2,c: parity,found in release: 2.2,team-web,triaged-web

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Steps to Reproduce

<!-- You must include full steps to reproduce so that we can reproduce the problem. -->

1. Create `GoogleMap` widget
2. Create a set of Marker with custom hue
```
Marker marker = Marker(
  ...
  icon: BitmapDescriptor.defaultMarkerWithHue(hue),
  ...
);
```

**Expected results:** <!-- what did you want to see? -->

Marker color change based on hue value

**Actual results:** <!-- what did you see? -->

Marker color always use default hue value

<details>
  <summary>Logs</summary>

<!--
      Run your application with `flutter run --verbose` and attach all the
      log output below between the lines with the backticks. If there is an
      exception, please see if the error message includes enough information
      to explain how to solve the issue.
-->

```
```

<!--
     Run `flutter analyze` and attach any output of that command below.
     If there are any analysis errors, try resolving them before filing this issue.
-->

```
```

<!-- Finally, paste the output of running `flutter doctor -v` here. -->

```
```

</details>