sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: Add --min-coverage option to flutter test --coverage
Labels: a: tests,c: new feature,tool,P2,team-tool,triaged-tool

I think in test_coverage 0.4.2, we will have a --min-coverage option, so I can add to my CI script for example, `pub run test_coverage --min-coverage 100`.

Please add a similar feature to `flutter test --coverage`, so that CI scripts can easily error out if coverage drops below a threshold.
Repository: TypeScript
Issue: feature request: public the TransformationContext.addDiagnostic and read them in the compiler and transpileModule
Labels: Suggestion,In Discussion

## Search Terms

custom transformer diagnostic

## Suggestion

mark the method `addDiagnostic` in `TransformationContext` as public and read the diagnostic result in the compiler

## Use Cases

I'm writing a custom transformer. In some cases, the transform will fail but I don't want to throw an Error. I want to add my error to the diagnostics.

## Examples


I have tried to call the `addDiagnostic` by as any

```ts
function createDiagnosticForNodeInSourceFile(
    ts: ts,
    sourceFile: SourceFile,
    node: Node,
    message: DiagnosticMessage,
    arg0?: string | number,
    arg1?: string | number,
    arg2?: string | number,
    arg3?: string | number,
): DiagnosticWithLocation | undefined {
    return (ts as any).createDiagnosticForNodeInSourceFile?.(sourceFile, node, message, arg0, arg1, arg2, arg3)
}
function appendDiagnosticMessageForNode(context: TransformationContext, diag: DiagnosticWithLocation | undefined) {
    if (!diag) return false
    const _context = internalTransformationContext(context)
    if (!_context.addDiagnostic) return false
    _context.addDiagnostic(diag)
    return true

    function internalTransformationContext(
        context: TransformationContext,
    ): TransformationContext & { addDiagnostic?(diag: DiagnosticWithLocation): void } {
        return context as any
    }
}
```

But that doesn't work. After digging into the source code, I found that it seems like the diagnostics only read in the `dts` generating.

## Checklist

My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Repository: vscode
Issue: Add ability for before decorations to indent (stretch across) word wrapped lines
Labels: feature-request,editor-wrapping

Refs: https://github.com/eamodio/vscode-gitlens/issues/930

I've gotten this report numerous times with GitLens' "gutter" blame annotations and there really isn't much I can do to fix/deal with this.

![image](https://user-images.githubusercontent.com/641685/74216656-183fb600-4c73-11ea-9e31-4dc26348fff3.png)

Can anything be done here?
Repository: terminal
Issue: Screen flicker when Terminal is opened on top of Skype window
Labels: Area-Rendering,Issue-Bug,Area-UserInterface,Product-Terminal,Priority-3

<!-- 
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed!
-->

<!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.

**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue.

If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link.

Please use this form and describe your issue, concisely but precisely, with as much detail as possible.

-->

# Environment

```none
Windows build number: 10.0.18363 (Windows 10 1909)
Windows Terminal version (if applicable): 0.8.10261.0 (latest Windows Store release)
Built-in Skype app: 14.56.102.0
GPU: Intel HD 530 (desktop skylake) using drivers 100.7463-100.7755, running dual-monitor setup at 1080p each
```

# Steps to reproduce
Open Skype and maximize the window, open Windows Terminal with any profile that is using acrylic effect (I have it set at 0.75 for cmd, for example), observe flicker on repaint.

Not sure if relevant, but I have animated emojis visible in the skype window.

You can also have other legacy windows between skype and terminal (placing some modern app in-between can stop this issue)

# Expected behavior
Repaint is unnoticeable

# Actual behavior
Screen flickers
Repository: rust
Issue: `r#` stripped from raw idents in lint and `type annotations needed` error
Labels: A-diagnostics,T-compiler,C-bug,D-papercut,D-incorrect

This code

```rust
fn r<r#trait>() {}

fn main() {
    r();
}
```

([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=a12ec17055cf3c08f4b6d59b31969dfc))

Gives incorrect warning and error for type declared using raw identifiers:

```
warning: type parameter `trait` should have an upper camel case name
 --> src/main.rs:1:6
  |
1 | fn r<r#trait>() {}
  |      ^^^^^^^ help: convert the identifier to upper camel case: `Trait`
  |
  = note: `#[warn(non_camel_case_types)]` on by default

error[E0282]: type annotations needed
 --> src/main.rs:4:5
  |
4 |     r();
  |     ^ cannot infer type for type parameter `trait`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0282`.
error: could not compile `playground`.
```

NOTE: This is about the diagnostics not including the `r#` in each case.
Repository: rust
Issue: Incorrect help message for type declared on struct using raw identifier
Labels: C-enhancement,A-diagnostics,T-compiler

This code
```rust
struct r#struct<r#fn>;

fn main() {}

```

([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=67fec620c3f519c8b8f8b13f209b0a1e))

Produces incorrect help message:

```
   Compiling playground v0.0.1 (/playground)
warning: type `struct` should have an upper camel case name
 --> src/main.rs:1:8
  |
1 | struct r#struct<r#fn>;
  |        ^^^^^^^^ help: convert the identifier to upper camel case: `Struct`
  |
  = note: `#[warn(non_camel_case_types)]` on by default

warning: type parameter `fn` should have an upper camel case name
 --> src/main.rs:1:17
  |
1 | struct r#struct<r#fn>;
  |                 ^^^^ help: convert the identifier to upper camel case: `Fn`

error[E0392]: parameter `fn` is never used
 --> src/main.rs:1:17
  |
1 | struct r#struct<r#fn>;
  |                 ^^^^ unused parameter
  |
  = help: consider removing `fn`, referring to it in a field, or using a marker such as `std::marker::PhantomData`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0392`.
error: could not compile `playground`.

To learn more, run the command again with --verbose.

```
Repository: pytorch
Issue: [feature request] [dataloader] Introduce Dataset.__collate__
Labels: module: dataloader,triaged,enhancement,needs research

And use it if `collate_fn` is unspecified and `dataset.__collate__` is specified. This makes sense, because batch collation logic is very often tied to `__getitem__` return values interface

(As a workaround I currently create separately a `dataset` instance and then pass `collate_fn = dataset.collate_fn`. This prevents from creating `DataLoader(MyDataset())` in a single line)

cc @SsnL
Repository: godot
Issue: Outputs of multiple instances of Godot get mixed up
Labels: bug,topic:editor

**Godot version:**
3.2-stable

**OS/device including version:**
Windows 10 (10.0.18362 Build 18362)

**Issue description:**
When at least two instances of Godot are open, and you run both instances with the debugger attached, one will always have its debugger removed and there is a chance that the output shows the output from the other instance. (~10% of the time).

**Steps to reproduce:**
Open 2 different projects at once with different print statements. Run both projects in a reasonably close timescale and observe both outputs.
Repository: vue-element-admin
Issue: Vue.js 3.0 future support
Labels: in plan

I am looking to begin using this project but would like some clarification on how the project will evolve when vue 3.0 is released.

Will the project update its vue version? Do you foresee any breaking changes?
How hard would you see the migration/update effort being for those who build on this template now but want to adopt vue 3.0 in the future?
Repository: flutter
Issue: Android: Extend WidgetsBindingObserver to allow listening on onWindowFocusChanged
Labels: c: new feature,platform-android,framework,would be a good package,c: proposal,P3,team-android,triaged-android

## Use case

On the Dart side I would like to know if the user pulled down the statusbar on Android. According to [this SO answer](https://stackoverflow.com/a/50662025/1800695) this can be achieved with [`onWindowFocusChanged`](https://developer.android.com/reference/android/app/Activity.html?is-external=true#onWindowFocusChanged(boolean)).

I searched for the Flutter equivalent, but could not find any resources on this. I was hoping the [`WidgetsBindingObserver`](https://api.flutter.dev/flutter/widgets/WidgetsBindingObserver-class.html) had this implemented, but unfortunately not. And I can't find any pub.dev package either.

## Proposal

I would propose that the [`WidgetsBindingObserver`](https://api.flutter.dev/flutter/widgets/WidgetsBindingObserver-class.html) also has a method to listen to the [`onWindowFocusChanged`](https://developer.android.com/reference/android/app/Activity.html?is-external=true#onWindowFocusChanged(boolean)). For example like `didChangeAppLifecycleState` add a new method `didChangeWindowFocus`.
Repository: rust
Issue: Non-deterministic perf.rust-lang.org runs (e.g. syn-opt).
Labels: T-compiler,C-bug,A-reproducibility

https://perf.rust-lang.org/detailed-query.html?commit=e369f6b617bc5124ec5d02626dc1c821589e6eb3&base_commit=4d1241f5158ffd66730e094d8f199ed654ed52ae&benchmark=syn-opt&run_name=patched%20incremental:%20println

This perf run was expected to be a no-op, but appears to have resulted in slightly less queries being run (2 def_span and 2 metadata reads). 

cc @eddyb
Repository: terminal
Issue: Add Toolbar for WSL OS instances
Labels: Issue-Feature,Area-UserInterface,Area-Extensibility,Product-Terminal

Please add a left toolbar ([for example like Opera browsers' toolbar](https://cdn-production-opera-website.operacdn.com/staticfiles/assets/images/main/computer/computer-hero.00fc91be943c.png)) to open WSL OS in single click.
Repository: godot
Issue: iOS uses more RAM than other platforms when using large AtlasTextures
Labels: bug,platform:ios,topic:porting,needs testing

**Godot version:** 3.2

**OS/device including version:** IOS (iphone 6, iphone x)

**Issue description:**
Im use big atlas 2048x2048, LOSSY 0.7
IOS uses too much memory.
More than android and windows
I do not like the fact that applications on iOS (arm, arm64, x86, x86_64) weigh minimum ~40 mb
(*.a file weight 193mb, all arch)
p.s. andoid apk size min ~15-20mb


android ~200mb peak (Im used cat /adb shell "cat /proc/meminfo")

windows ~190mb
![image](https://user-images.githubusercontent.com/12483173/74248593-8ba8fc80-4d33-11ea-9829-8195ffbf4f36.png)

apple in xcode ~300mb (Memory warnings appear)
Repository: rust
Issue: Lifetime elision doesn't work right with nested self receivers. 
Labels: A-lifetimes,T-lang,T-compiler,C-bug

<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
Seems like lifetime elision doesn't work quite right with nested self receivers. The error messages are also misleading. Of course this can be worked around by providing the annotation in the code


```rust
use std::rc::Rc;

struct S {
    val: String,
}

impl S {
    // error[E0623]: lifetime mismatch
    //  --> src/lib.rs:9:9
    //   |
    // 8 |     fn rc1(self: &Rc<Self>, _s: &str) -> &str {
    //   |                  ---------               ----
    //   |                  |
    //   |                  this parameter and the return type are declared with different lifetimes...
    // 9 |         self.val.as_ref()
    //   |         ^^^^^^^^^^^^^^^^^ ...but data from `self` is returned here
    fn rc1(self: &Rc<Self>, _s: &str) -> &str {
        self.val.as_ref()
    }

    //     error[E0106]: missing lifetime specifier
    //   --> src/lib.rs:11:32
    //    |
    // 11 |     fn rc2(self: &Rc<Self>) -> &str {
    //    |                                ^ help: consider giving it a 'static lifetime: `&'static`
    //    |
    //    = help: this function's return type contains a borrowed value, but there is no value for it to be borrowed from
    fn rc2(self: &Rc<Self>) -> &str {
        self.val.as_ref()
    }


    // Compiles fine
    fn ref1(&self, _s: &str) -> &str {
        self.val.as_ref()
    }

    // Compiles fine
    fn ref2(&self) -> &str {
        self.val.as_ref()
    }
}
```

#64325
Repository: rust
Issue: Confusing E0495 error explanation
Labels: C-enhancement,A-diagnostics,A-lifetimes,T-compiler

Consider example.
The error explanation is very confusing for me:
1. Its not obvious what is the problem and what I can do for solving it
2. There are confusing why Rust explains that '&&Foo' is both expected and found:
~~~
   = note: expected  `&&Foo`
              found  `&&Foo`
~~~

```rust
#![feature(trait_alias)]
#![feature(generator_trait)]
#![feature(generators)]

use std::ops::Generator;

trait MyGenerator = Generator<Yield = (), Return = ()>;
trait Bar {
    fn bar(&self) -> Box<dyn MyGenerator>;
}

struct Foo;

impl Bar for Foo {
    fn bar(&self) -> Box<dyn MyGenerator> {
        Box::new(|| {
            let _x = self;
            yield;
        })
    }
}

```

([Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=32ff6f1912ba199046ac323a7613fbc1))

Errors:

```
   Compiling playground v0.0.1 (/playground)
error[E0495]: cannot infer an appropriate lifetime due to conflicting requirements
  --> src/lib.rs:16:18
   |
16 |           Box::new(|| {
   |  __________________^
17 | |             let _x = self;
18 | |             yield;
19 | |         })
   | |_________^
   |
note: first, the lifetime cannot outlive the anonymous lifetime #1 defined on the method body at 15:5...
  --> src/lib.rs:15:5
   |
15 | /     fn bar(&self) -> Box<dyn MyGenerator> {
16 | |         Box::new(|| {
17 | |             let _x = self;
18 | |             yield;
19 | |         })
20 | |     }
   | |_____^
note: ...so that the types are compatible
  --> src/lib.rs:16:18
   |
16 |           Box::new(|| {
   |  __________________^
17 | |             let _x = self;
18 | |             yield;
19 | |         })
   | |_________^
   = note: expected  `&&Foo`
              found  `&&Foo`
   = note: but, the lifetime must be valid for the static lifetime...
note: ...so that the expression is assignable
  --> src/lib.rs:16:9
   |
16 | /         Box::new(|| {
17 | |             let _x = self;
18 | |             yield;
19 | |         })
   | |__________^
   = note: expected  `std::boxed::Box<(dyn std::ops::Generator<Yield = (), Return = ()> + 'static)>`
              found  `std::boxed::Box<dyn std::ops::Generator<Yield = (), Return = ()>>`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0495`.
error: could not compile `playground`.

To learn more, run the command again with --verbose.

```
Repository: go
Issue: cmd/go: error not reported for packages in vendor/ in module mode, without vendoring
Labels: NeedsFix,GoCommand,modules

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.13.7 darwin/amd64
</pre>

### Does this issue reproduce with the latest release?

Yes, also reproduces with 1.14rc1.

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayconrod/Library/Caches/go-build"
GOENV="/Users/jayconrod/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayconrod/go"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/opt/go/installed"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/go/installed/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayconrod/Code/test/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build248121802=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>

### What did you do?

Created a regular package in a directory named `vendor`, not created with `go mod vendor`, not using `-mod=vendor`.

```
! go list -deps example.com/m

-- go.mod --
module example.com/m

go 1.14
-- use.go --
package use

import (
	_ "example.com/m/vendor"
	_ "example.com/m/vendor/x"
)
-- vendor/vendor.go --
package vendor
-- vendor/x/x.go --
package x
```

### What did you expect to see?

Errors reported for packages in `vendor/` when `-mod=vendor` is not active.

These are being treated as regular packages. Other modules won't be able to import these packages, since vendor directories are excluded from module zip files.

### What did you see instead?

`go list` treats these like regular packages:

```
$ go list -deps example.com/m
example.com/m/vendor
example.com/m/vendor/x
example.com/m
```

cc @matloob @bcmills
Repository: scrcpy
Issue: Icon/Favicon/Logo for scrcpy?
Labels: icon

Is there a logo for scrcpy that I can use on [the subreddit](https://www.reddit.com/r/scrcpy)?
Repository: rust
Issue: arbitrary self types causes unexpected error messages
Labels: C-enhancement,A-diagnostics,T-compiler,F-arbitrary_self_types,D-confusing,D-papercut

This example:

```rust
#![feature(arbitrary_self_types)]
trait Test<T: core::ops::Deref<Target = Self>> {
    fn is_some(self: T);
}

fn f() {
    let x = Some(2);
    if x.is_some() {
        println!("Some");
    }
}
```
[Playground link](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=83f8fd48766d3bcd61212a70b6db86df)

gives the error 

```
error[E0277]: the trait bound `std::option::Option<{integer}>: std::ops::Deref` is not satisfied
 --> src/lib.rs:8:10
  |
8 |     if x.is_some() {
  |          ^^^^^^^ the trait `std::ops::Deref` is not implemented for `std::option::Option<{integer}>`

error[E0308]: mismatched types
 --> src/lib.rs:8:8
  |
8 |     if x.is_some() {
  |        ^^^^^^^^^^^ expected `bool`, found `()`

error: aborting due to 2 previous errors

```

rather than an error because the `Test` trait is not implemented.

This is presumably just a case where improved diagnostics would be good. The [inherent `is_some` method](https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some) winds up not triggering because it requires auto-ref rather than being passed "by value".

_Originally posted by @tguser402 in https://github.com/rust-lang/rust/issues/66312#issuecomment-568805751_
Repository: rust
Issue: Clarify "cannot find macro `X` in this scope"
Labels: C-enhancement,A-diagnostics,A-resolve,A-macros,T-compiler

I always forget that program order matters for macro definitions.  In the [example](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=0e2900e51a17037b753c2c451e12146b), I get the error:

```
error: cannot find macro `five_times` in this scope
```

And inevitably I spend a long time trying to debug it when I eventually remember that for `macro_use`, program order matters.  If the compiler error message provided a hint like "macro `five_times` exists but is defined after the code attempting to use it.  try reordering the use statements" (or choose better phrasing), that'd save a lot of time.
Repository: flutter
Issue: [web][safari] unskip safari semantics tests
Labels: a: tests,team,framework,engine,a: accessibility,platform-web,browser: safari-macos,P2,team-web,triaged-web

Bunch of tests are skipped for semantics in Safari in the following files. We should either skip them or change them to work in in Safari. (note: there is a chance that the browser has a bug for the tests methods use case)

semantics_test.dart
semantics_helper_test.dart