sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: godot
Issue: Disabling/removing an editor plugin defining custom types doesn't reverts custom icons
Labels: bug,topic:editor

Godot 3.0.2 stable
Windows 10 64 bits

I disabled one of my plugins, but I noticed that the custom node it defined still had its custom icon.
I closed the editor, deleted the `plugin.cfg` file, restarted the editor: the scene still shows the custom icon.
I tried removing the script on that node, closed the scene, and reopened: the node still has the custom icon.

![image](https://user-images.githubusercontent.com/1311555/37117908-d4373402-2252-11e8-8324-c3774a993377.png)

Changing the type of the node to `Spatial` reverted its icon, even though the node was a `Spatial` already.

Before fixing the icon, those two errors were printed each time I reloaded the scene, though it might be unrelated:
```
ERROR: PopupMenu::get_item_text: Index p_idx=-1163005939 out of size (items.size()=4)
   At: scene\gui\popup_menu.cpp:732
ERROR: PopupMenu::set_item_checked: Index p_idx=-1163005939 out of size (items.size()=4)
   At: scene\gui\popup_menu.cpp:680
```
Repository: go
Issue: cmd/compile: esc.go fails to mark anonymous receiver parameters as non-escaping
Labels: NeedsFix,compiler/runtime

    package p

    type T struct { x int }

    //go:noinline
    func (*T) M() {}  

    //go:noinline
    func (_ *T) N() {}

    func f() {
            var t T
            t.M()
            t.N()
            (*T).M(&t)
            (*T).N(&t)
    }

Compiling the above code with "go tool compile -m" outputs:

    a.go:13:3: t escapes to heap
    a.go:12:6: moved to heap: t
    a.go:14:3: t escapes to heap
    a.go:15:9: &t escapes to heap
    a.go:16:9: &t escapes to heap

This doesn't happen if the receiver parameters are given a proper name, or if the receiver parameters are turned into normal parameters (i.e., changing the methods into functions).

The direct calls (`t.M()` and `t.N()`) are because `(*EscState).esctag`'s unnamed parameter loop only touches `fn.Type.Params()`, not `fn.Type.Recvs()`.

The indirect calls (`(*T).M(&t)` and `(*T).N(&t)`) appear to be because esc.go just doesn't look for esc tags for methods called as functions.
Repository: rust
Issue: Use apple's version of clang to compile iOS targets by default
Labels: O-macos,O-ios,T-bootstrap,C-feature-request

In Xcode, Apple ships a closed-source version of clang, which in turn has a closed-source version of LLVM (it seems like Xcode 9's LLVM forks off of LLVM 5?). Apple's clang/LLVM generally includes stability enhancements that would otherwise potentially cause problems for developers. I'm not sure what the benefits are of using Rust's current LLVM, e.g. it can be newer than Apple's, but Apple's clang is a really safe bet and seems a good thing to use by default. Some of these platform-specific issues can manifest in weird and very difficult to diagnose ways, e.g. random restarts, that it would be good to save developers from.

We could just give users a bitcode file for them to compile with clang themselves (#35968), or maybe there's some way to have the user specify which version of clang they want.
Repository: TypeScript
Issue: generate function declaration from function type in TypeScript
Labels: Suggestion,In Discussion,VS Code Tracked,Domain: Quick Fixes,Experience Enhancement

_From @unional on October 5, 2017 18:52_

```ts
type MyCallback = (a: number, b: string) => void

function foo(callback: MyCallback) {
  // ...
}

// case 1
foo((a, b) => { ... })

// case 2
foo(function (a, b) { ... })

// case 3
function cb(a: number, b: string) { ... }
foo(cb)
```

Above are 3 common ways to write a callback.
TypeScript is great at inferring the argument types in the implemented callbacks.
`a`, and `b` are typed accordingly in the callbacks above.

However, the tooltip is not useful when we are implementing the callbacks:

![image](https://user-images.githubusercontent.com/3254987/31246264-a0feb286-a9c1-11e7-9bb7-8cf36457bc1b.png)

If I change `foo()` to not using type alias, it helps in case 1 and 2:

```ts
function foo(callback: (a: number, b: string) => void) { ... }
```
![image](https://user-images.githubusercontent.com/3254987/31246351-fbbbd550-a9c1-11e7-8d7f-f4ab873fd023.png)

But that doesn't help in case 3 and actually demotes type alias.

One solution I can think of is using [ctrl+.] to fill in the callback:

```ts
foo(/* caret */)

// [ctrl+.] and choose "implement callback as arrow function":
foo((a: number, b: string) => { /* caret */ })

// [ctrl+.] and choose "implement callback as function declaration":
foo(function (a: number, b: string) { /* caret */ })

// caret anywhere on the type alias below
MyCallback

// [ctrl+.] and choose "implement function declaration" will expand to snippet:
function ${1:functionName}(a: number, b: string): void { ${0} }
```

_Copied from original issue: Microsoft/vscode#35635_
Repository: TypeScript
Issue: Need a version of getSupportedCodeFixes that only returns codes that support fix-all
Labels: Suggestion,Experience Enhancement

VS needs it in order to implement this API:
http://source.roslyn.io/#Microsoft.CodeAnalysis.Workspaces/CodeFixes/FixAllOccurrences/FixAllProvider.cs,8a74cdbcb24c6dcb,references

Without it, VS will offer fix-all for all code fixes.  This is relatively low impact.
Repository: flutter
Issue: Support user-supplied project templates for `flutter create`
Labels: c: new feature,tool,P3,team-tool,triaged-tool

### Proposal

I stumbled upon [a boilerplate project](https://github.com/anilcancakir/flutter-boilerplate) today and realized that I'd have to manually clone this and change values in different files and whatnot to get started with it.

Here I propose allowing users to specify a custom template at project creation time.

### User Interface

Users creating a new project can specify a template as follows:

```
# from pub
$ flutter create my-project-name --template package-name-on-pub

# or from a git host
$ flutter create my-project-name --template https://somegithost.com/username/projectname

# or from the local filesystem
$ flutter create my-project-name --template /path/to/project/root
```

### Unanswered Questions

1) Are substitutions (author name, project name, description, etc) limited to a know set of files?
2) <your questions / concerns here>

#### If the answer to 1 is "no" then how will the templating system know which files to modify?

Should it scan *all* files looking for use of template context data?

Or should the template author explicitly list the files in some form of a manifest?

### Alternatives

1) We don't do this

2) The `flutter` CLI could grow a `flutter template install` (or similar) command.

This would mean creating a directory to house templates (such as `~/.flutter/templates`, although `~/.flutter` is already a textual file but this could be moved I imagine) and augmenting [the template "discovery" code](https://github.com/flutter/flutter/blob/20004357288389829df79a3af5308d4c5819aecf/packages/flutter_tools/lib/src/template.dart#L166-L170).

3) <your idea here!>
Repository: opencv
Issue: OE-28 "Image Stitching" Module
Labels: category: stitching,evolution

## Stitching Module

* Author: Jiri Horner
* Link: https://github.com/opencv/opencv/wiki/OE-28.-Image-Stitching
* Status: Open
* Platforms: **All**
* Complexity: 1-2 man-weeks

## Introduction and Rationale

Stitching module has been around for quite some time and hasn't been refreshed to match changes in rest of the OpenCV.

Stitcher interface is widely used from Python, but lots of features can't be controlled from Python. User experience should be improved.

There is no interoperability with features2d module, all feature finders need to be wrapped manually for stitching module.

Dependencies on legacy CUDA stuff in stitching module let to some compilation problems recently.

Dependencies on xfeatures2d makes it impossible for distributions to provide patent-free stitching module while offering patented algorithms to use with  for users that need them.

## Proposed solution

* remove `detail::FeaturesFinder` and `detail::FeaturesMatcher` wrapper classes. Use `cv::Feature2D` and `cv::DescriptorMatcher` from features2d module. This will allow to use all features and descriptors with stitching modules. Move all estimation code from `detail::FeaturesMatcher` to `detail::Estimator`. This also solves problems with dependencies on xfeatures2d.

* allow user to explicitly set `detail::Estimator`

* consolidate creation methods for stitcher. Keep only `Stitcher::create`, wrap this method for Python. Drop `try_use_gpu` flag, rely on T-API or user explicitly setting CUDA classes to use.

* allow users to set FeaturesFinder, DescriptorMatcher, BundleAdjuster etc. from Python

* drop legacy usage of legacy Levenberg–Marquardt API from bundle adjusters. Replace with new LevMarq API.

* remove direct usage of CUDA from stitching module (OpenCL alternatives are already available). Move to CUDA modules where it makes sense.

## Impact on existing code, compatibility

Changes in Stitcher interface might require some changes in user code. We could introduce some wrapper classes and aliases to ease transition towards using new API with classes from features2d.

## Possible alternatives

Keep as is.

## References

https://github.com/opencv/opencv/issues?utf8=%E2%9C%93&q=is%3Aissue+label%3A%22category%3A+gpu+%28cuda%29%22+stitching

cc @vpisarev
Repository: go
Issue: net: TestLookupGoogleSRV and TestLookupGmailMX flaky on builders
Labels: Testing,Builders,NeedsInvestigation

During [CL98775](https://go-review.googlesource.com/c/go/+/98775): [build742ae1bd](https://storage.googleapis.com/go-build-log/742ae1bd/linux-amd64-race_65be7a03.log)

```
--- FAIL: TestLookupGoogleSRV (5.01s)
	lookup_test.go:76: lookup _xmpp-server._tcp.google.com on 10.3.240.10:53: read udp 10.0.7.69:46483->10.3.240.10:53: read: connection refused
--- FAIL: TestLookupGmailMX (10.01s)
	lookup_test.go:113: lookup gmail.com on 10.3.240.10:53: read udp 10.0.7.69:41650->10.3.240.10:53: read: connection refused
FAIL
FAIL	net	29.755s
```
The failure disappeared during second try-bots run.

Most likely a temporary network issue on builder.
Filling this in case this pops up again in near time.
Repository: puppeteer
Issue: Scripts are not evalutated in header and footer HTML templates for PDFs.
Labels: feature,upstream,chromium,confirmed

### Steps to reproduce

* Puppeteer version: 1.1.1
* Platform / OS version: Windows 10, version 1709, build 16299.248
* Node.js version: v7.9.0

**What steps will reproduce the problem?**

First, I setup a basic test page like this:

```jsx
const browser = await puppeteer.launch({ignoreHTTPSErrors: true})
const page = await browser.newPage()
await page.setContent(`
<html>
  <head>
    <title>Test Page</title>
    <style>
      body{
        background: yellow;
        min-height: 6000px;
      }
    </style>
  </head>
  <body>
    I'm an HTML page.
  </body>
</html>
`)
const pdf = await page.pdf({
  format: 'Letter',
  printBackground: true,
  headerTemplate: headerTemplate,
  displayHeaderFooter: true,
  margin: {
    top: '1in',
    right: '0in',
    bottom: '1in',
    left: '0in'
  }
})
await browser.close()
```

The `headerTemplate` looks like this:
```jsx
const headerTemplate = `
<div style="font-size: 10px; display: flex; flex-direction: row; justify-content: space-between; width: 100%" id='template'>
  <div class='pageNumber' id='num' style="font-size: 10px;">Page number</div>
  <div class='date' style="font-size: 10px;"></div>
  <div class='title' style="font-size: 10px;"></div>
  <div class='url' style="font-size: 10px;"></div>
  <div class='totalPages' style="font-size: 10px;"></div>
  <script>
    var pageNum = document.getElementById("num");
    pageNum.remove()
    var template = document.getElementById("template")
    template.style.background = 'red';
  </script>
</div>`
```

**What is the expected result?**
The docs don't mention whether or not script tags are supported in the header and footer templates. I would expect then that the code above would render a header with a red background and remove the page number node. (The code above was just for testing purposes).

**What happens instead?**
The script appears not to evaluate. Instead the resulting PDF has no background, and a page number div.

If evaluating scripts in these templates is not supported, might I suggest updating the PDF section of the docs to state as much. Thanks for all the hard work the Puppeteer team has put into this project!
Repository: vscode
Issue: Settings editor should search known keys in object type settings
Labels: feature-request,settings-editor

Issue Type: <b>Settings Search Issue</b>

I would have expected to find this as a sub-section of workbench color customizations.

VS Code version: Code - Insiders 1.22.0-insider (a9dcb2c3159367e347271d88c399e1f6ca88c23d, 2018-03-08T22:21:18.293Z)
OS version: Darwin x64 16.7.0

<details><summary>Extensions (21)</summary>

Extension|Author (truncated)|Version
---|---|---
vsc-material-theme|Equ|1.5.0
material-icon-theme|PKi|3.2.3
vscode-docker|Pet|0.0.25
code-settings-sync|Sha|2.9.0
solargraph|cas|0.13.0
npm-intellisense|chr|1.3.0
githistory|don|0.4.0
gitlens|eam|8.1.0
tslint|eg2|1.0.28
vscode-npm-script|eg2|0.3.3
git-project-manager|fel|1.4.0
svgpreview|kis|0.2.0
Go|luk|0.6.77
vscode-azurestorage|ms-|0.2.0
mssql|ms-|1.3.0
python|ms-|2018.2.0
azure-account|ms-|0.3.1
vsliveshare|ms-|0.2.206
printcode|nob|2.0.4
Ruby|reb|0.17.0
vscode-open-in-github|ziy|1.3.1


</details><details><summary>Results</summary>

Setting|Extension|Score
---|---|---
mssql.query.displayBitAsNumber|ms-mssql.mssql|0.478
openInGitHub.requireSelectionForLines|ziyasal.vscode-open-in-github|0.394
openInGitHub.gitHubDomain|ziyasal.vscode-open-in-github|0.136
openInGitHub.providerType|ziyasal.vscode-open-in-github|0.133
mssql.format.placeSelectStatementReferencesOnNewLine|ms-mssql.mssql|0.122
npm-intellisense.importLinebreak|christian-kohler.npm-intellisense|0.064
printcode.webServerPort|nobuhito.printcode|0.057
gitHistory.pageSize|donjayamanne.githistory|0.052
gitHistory.showEditorTitleMenuBarIcons|donjayamanne.githistory|0.047
printcode.tabSize|nobuhito.printcode|0.036
gitProjectManager.recentProjectsListSize|felipecaputo.git-project-manager|0.030
npm.bin|eg2.vscode-npm-script|0.019
gitHistory.hideCommitViewExplorer|donjayamanne.githistory|0.013
mssql.format.datatypeCasing|ms-mssql.mssql|0.011
mssql.format.keywordCasing|ms-mssql.mssql|0.011
npm-intellisense.showBuildInLibs|christian-kohler.npm-intellisense|0.010
azureStorage.file.showSavePrompt|ms-azuretools.vscode-azurestorage|0.007
mssql.format.alignColumnDefinitionsInColumns|ms-mssql.mssql|0.007
gitProjectManager.warnIfFolderNotFound|felipecaputo.git-project-manager|0.007
mssql.format.placeCommasBeforeNextStatement|ms-mssql.mssql|0.006

</details>

Query: editor active line number
Literal matches: 0
<!-- generated by issue reporter -->
Repository: vscode
Issue: Emmet completions disappear when using bem in the presence of other snippets
Labels: bug,emmet,confirmed

<!-- Do you have a question? Please ask it on https://stackoverflow.com/questions/tagged/vscode. -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.22.0-ins
- OS Version: win7x64

Bootstrap 4+ snippets extensions are installed.

Well, first of all, I'm a little confused how "**bem**" matches with **b**4-**me**dia-....

![emmet - priority](https://user-images.githubusercontent.com/24613274/37188977-a8ccdf70-235a-11e8-9b3b-158d7cacec7d.gif)

But even if so, do we have an option for Emmet to have higher priority on every other extension?
Repository: rust
Issue: Unsize isn't implemented for unions
Labels: C-enhancement,T-compiler,needs-rfc

This came up in the fix for #48493. It seems like unions should have unsize impls for all of their fields?

```rust
#![feature(untagged_unions, unsize, coerce_unsized)]
use std::marker::Unsize;
use std::ops::CoerceUnsized;

union Data<T: ?Sized> {
    v: T,
    u: (),
}

struct Pointer<T: ?Sized>(Box<Data<T>>);

impl<T: ?Sized + Unsize<U>, U: ?Sized> CoerceUnsized<Pointer<U>> for Pointer<T> {}

fn main() {}
```

```
error[E0277]: the trait bound `Data<T>: std::marker::Unsize<Data<U>>` is not satisfied
  --> src/main.rs:12:1
   |
12 | impl<T: ?Sized + Unsize<U>, U: ?Sized> CoerceUnsized<Pointer<U>> for Pointer<T> {}
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::marker::Unsize<Data<U>>` is not implemented for `Data<T>`
   |
   = note: required because of the requirements on the impl of `std::ops::CoerceUnsized<std::boxed::Box<Data<U>>>` for `std::boxed::Box<Data<T>>`

error: aborting due to previous error

If you want more information on this error, try using "rustc --explain E0277"
error: Could not compile `playground`.

To learn more, run the command again with --verbose.
```
Repository: rust
Issue: Spurious "note: downstream crates may implement trait `Foo` for type `&_`"
Labels: C-enhancement,A-diagnostics,T-lang,T-compiler

The following code:
```rust
trait Foo {}

impl<T: Foo> std::fmt::Display for T {
    fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
        Ok(())
    }
}
```
produces the following compiler output:
```
error[E0119]: conflicting implementations of trait `std::fmt::Display` for type `&_`:
 --> src/main.rs:3:1
  |
3 | impl<T: Foo> std::fmt::Display for T {
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: conflicting implementation in crate `core`:
          - impl<'a, T> std::fmt::Display for &'a T
            where T: std::fmt::Display, T: ?Sized;
  = note: downstream crates may implement trait `Foo` for type `&_`

error[E0210]: type parameter `T` must be used as the type parameter for some local type (e.g. `MyStruct<T>`); only traits defined in the current crate can be implemented for a type parameter
 --> src/main.rs:3:1
  |
3 | / impl<T: Foo> std::fmt::Display for T {
4 | |     fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
5 | |         Ok(())
6 | |     }
7 | | }
  | |_^

error: aborting due to 2 previous errors
```

While there might be legitimate reasons why this is not allowed, the note is wrong: the trait `Foo` is not public, a downstream can't possibly implement it for some type.
Repository: flutter
Issue: Installation failed when a path includes special characters
Labels: c: crash,tool,dependency: dart,P2,team-tool,triaged-tool

## Steps to Reproduce

```
$ pwd
/Volumes/Hard disk drive #1/Code

$ git clone -b beta https://github.com/flutter/flutter.git
Cloning into 'flutter'...
remote: Counting objects: 114951, done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 114951 (delta 0), reused 0 (delta 0), pack-reused 114948
Receiving objects: 100% (114951/114951), 34.72 MiB | 1.40 MiB/s, done.
Resolving deltas: 100% (85931/85931), done.

$ export PATH=`pwd`/flutter/bin:$PATH

$ flutter doctor
Downloading Dart SDK from Flutter engine ead227f118077d1f2b57842a32abaf105b573b8a...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 43.3M  100 43.3M    0     0  8075k      0  0:00:05  0:00:05 --:--:-- 9352k
Building flutter tool...
vm-service: Error: Unhandled exception:
Unsupported operation: Cannot extract a file path from a URI with a fragment component
#0      _Uri.toFilePath (dart:core/uri.dart:2597)
#1      _loadFile (loader.dart:427:26)
#2      _handleResourceRequest (loader.dart:512:7)
#3      _processLoadRequest (loader.dart:1017:9)
#4      _RawReceivePortImpl._handleMessage (dart:isolate-patch/dart:isolate/isolate_patch.dart:165)
```
![screen shot 2018-03-09 at 11 25 38](https://user-images.githubusercontent.com/4836709/37198542-bb47c82e-238f-11e8-80f6-7066998e81c5.png)
Repository: scrcpy
Issue: Add On Screen buttons
Labels: feature request

My phone has capacitive buttons, and because of that i don't have on-screen buttons. A command line argument for showing the buttons would be nice.
Repository: vscode
Issue: Double-click selection matches some escaped characters
Labels: feature-request,under-discussion,editor-wordnav

Issue Type: <b>Bug</b>

If you have a string with the "\t", "\n", etc. sequences followed by a word, double-clicking the word will select the escaped character as well:
![screenshot from 2018-03-09 10-10-29](https://user-images.githubusercontent.com/3611993/37202410-5a081d50-2382-11e8-8683-0532839a4f75.png)

VS Code version: Code 1.21.0 (9a199d77c82fcb82f39c68bb33c614af01c111ba, 2018-03-07T11:01:43.521Z)
OS version: Linux x64 4.10.0-42-generic

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3142)|
|Load (avg)|0, 1, 1|
|Memory (System)|15.56GB (3.82GB free)|
|Process Argv|/usr/share/code/code --unity-launch|
|Screen Reader|no|
|VM|0%|

</details><details><summary>Extensions (7)</summary>

Extension|Author (truncated)|Version
---|---|---
vscode-icontheme-nomo-dark|be5|1.3.5
vscode-eslint|dba|1.4.7
githistory|don|0.4.0
auto-close-tag|for|0.5.6
docthis|joe|0.6.0
python|ms-|2018.2.0
color-highlight|nau|2.3.0

(1 theme extensions excluded)

</details>
Reproduces without extensions
<!-- generated by issue reporter -->
Repository: neovim
Issue: option: use numbered registers for smaller deletions
Labels: enhancement,options

Once upon a time, there was a [bug that was causing small deletions appear in the numbered registers](
https://groups.google.com/d/msg/vim_dev/pbN4rAw8LmI/jR54qQjvuOsJ) under some conditions. Then it was fixed.
And now there's no way to use such a useful bugfeature.
Ingo Karkat who reported this bug also proposed a super-useful option `smalldeletethreshold`, which I'm dying without.
I hope that Neovim development is not so sluggish as Vim development and this feature-request can survive. I even ready to try implementing it...

### Actual behaviour
Deletions like `d5w` has no history, though it's a kind of a large amount of text. If I use `d5w`, then jump to the insertion place and use `x` to fix a small thing, I'll lose the `d5w`'d text completely.

### Expected behaviour
I want to set a (non-existing) `smalldeletethreshold` option to 2 so that all deletions larger than `x` are pushed into the numbered registers "1.."9.
Repository: rust
Issue: Value returned by `to_owned` doesn't always *own* the data
Labels: C-enhancement,T-libs-api

For example:

```
let a = vec![1, 2];
let s = Some(&a);
let r = vec![];
if let Some(ref v) = s {
    r = v.to_owned();
}
```
This doesn't compile:
```
error[E0308]: mismatched types
 --> src/main.rs:6:13
  |
6 |         r = v.to_owned();
  |             ^^^^^^^^^^^^ expected struct `std::vec::Vec`, found reference
  |
  = note: expected type `std::vec::Vec<_>`
             found type `&std::vec::Vec<{integer}>`
```

Relates to #43236.
Repository: go
Issue: cmd/link: silently performs incorrect relocations when linking foreign objects
Labels: NeedsInvestigation

For example, [when linking syso files](https://github.com/FiloSottile/ed25519-dalek-rustgo/pull/1#issuecomment-371611831).

Adding `go:cgo_import_dynamic` helps but (1) it was recently disabled for security reasons for non-cgo files, then reenabled because solaris needs it, so it's unclear if this policy will persist in the long-run for all architectures, and (2) you need to specify it for specific symbols rather than for all symbols. In any case, an error should be raised with a hint on what to do, rather than succeeding silently with invalid output.

The equivalent thing in Haskell [Just Works](https://github.com/infinity0/ed25519-dalek-rustgo/commit/31f4ed2feccd87c2ecefc805cfe11264e0d2394c) with no extra annotations.