sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: pytorch
Issue: FSDP do not support `ignored_parameters` when `auto_wrap_policy` is specified
Labels: oncall: distributed,triaged,module: fsdp

### 🐛 Describe the bug

I have a model which contains some params need to be ignored ( else flat_param will raise an error), the construction code is like:

```
        not_trainable = []
        for name, p in model.named_parameters():
            if p.requires_grad == False:
                not_trainable.append(p)
        sharding_strategy=torch.distributed.fsdp.ShardingStrategy._HYBRID_SHARD_ZERO2
        model = FSDP(model, sharding_strategy=sharding_strategy,
                     ignored_parameters = not_trainable,
                     auto_wrap_policy=size_based_auto_wrap_policy)

```
I came across an error: the params in `not_trainable ` would cause error when executing `_init_flat_param`.

If `auto_wrap_policy` is not passed, the code works.

### Versions

PyTorch version: 2.0.1+cu117
Is debug build: False
CUDA used to build PyTorch: 11.7
ROCM used to build PyTorch: N/A

OS: CentOS Linux 7 (Core) (x86_64)
GCC version: (GCC) 10.2.0

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin
Repository: vscode
Issue: [Bug] Opening new editor from a diff editor resets the location
Labels: feature-request,diff-editor

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
Version: 1.82.0 (system setup)
Commit: 8b617bd08fd9e3fc94d14adb8d358b56e3f72314
Date: 2023-09-06T22:07:07.438Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.19044

When you hightlight some text in a diff, or navigate to a section of code that you want to see in the context of the full file, you can select Ctrl/Cmd + k, Shift + o to go to the full file. However the file always opens from the very top rather than the location you were on.

Steps to Reproduce:

1. I'm using [Github Pull Requests and Issues extension](https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github)
2. Go to a pull request
3. Select a line
4. Ctrl + k, Shift + o (to open the file fully)

### Expectation
The file should open at the same line number I was at before

### Actual
The file always opens from the top

## Screencast
In this gif I am in the VSCode repo, I have opened pull requests and navigated to an open PR.
I then scroll down to a change and try to open the file fully (in this case i'm looking at the state of the file **before** the changes have been made)

![opening file](https://github.com/microsoft/vscode/assets/936006/e1ff5914-a398-4876-916b-35bf785e0dc5)

## Code Location
The opening of the file happens here:
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/browser/parts/editor/editorCommands.ts#L1373-L1398

I guess there needs to be some extra data passed to the openEditor command to know _where_ in the file to open

## Related
- https://github.com/microsoft/vscode/issues/166805
- https://github.com/microsoft/vscode/issues/153786
Repository: bitcoin
Issue: consensus: Better document ComputeMerkleRoot & add test for return value
Labels: Docs,Tests,Validation

At least twice we've had attempts to refactor [`ComputeMerkleRoot`](https://github.com/bitcoin/bitcoin/blob/fd69ffbbfb3e08b474b33540e56cf4f81e5c21d4/src/consensus/merkle.cpp#L45) (#22046 & #22046). While the value of any sort of refactor is dubious, it may also come with subtle, unintended side-effects, [see review comment here](https://github.com/bitcoin/bitcoin/pull/28430#issuecomment-1714504535):

> 1) The added `break`  only saves time if we receive a mutated block with repeated transactions. So this change isn't relevant unless a peer send us a block they mutated on purpose, in which case they get disconnected for that. So it really shouldn't change anything in a  non-adversarial scenario.

> 2) If we break early and don't compute the full merkle root anymore, the return value of `BlockMerkleRoot()` changes. As a result, [code calling BlockMerkleRoot()](https://github.com/bitcoin/bitcoin/blob/8f7b9eb8711fdb32e8bdb59d2a7462a46c7a8086/src/validation.cpp#L3534-L3542) https://github.com/bitcoin/bitcoin/blob/8f7b9eb8711fdb32e8bdb59d2a7462a46c7a8086/src/validation.cpp#L3534-L3542  would now return "bad-txnmrklroot" as an error instead of "bad-txns-duplicate", because now the first check already fails. This seems incorrect.

It might be good to better document this code, and add a test that would fail if a similar refactor is attempted in future.
Repository: vscode
Issue: Git - Trying to add a disposable to a DisposableStore
Labels: bug,git

@hediet I still have this issue. it's consistently reproducible when you try to merge a remote branch into some local branch and have merge conflicts. In this case diff either does not open at all or takes ages to show. This applies to both merge changes and staged changes.
Here's the console
<img width="557" alt="image" src="https://github.com/microsoft/vscode/assets/6418145/d3f43ceb-c094-409e-9945-fa61fe0b81b9">

_Originally posted by @ivanvoznyakovsky in https://github.com/microsoft/vscode/issues/192580#issuecomment-1715349821_
Repository: godot
Issue: RichTextLabel: `push_context()` and `pop_context()` can't surround a cell
Labels: bug,topic:gui

### Godot version

4.2.dev4

### System information

Godot v4.2.dev4 - Pop!_OS 22.04 LTS - X11 - Vulkan (Forward+) - integrated Intel(R) Graphics (ADL GT2) () - 12th Gen Intel(R) Core(TM) i5-1235U (12 Threads)

### Issue description

```gdscript
func _ready():
	#A()
	#B()

func A() -> void:
	push_indent(1)
	push_table(3)
	set_table_column_expand(1, true, 1)
	for i in 7:
		push_context()
		push_cell()
		push_paragraph(HORIZONTAL_ALIGNMENT_RIGHT, Control.TEXT_DIRECTION_AUTO, "")
		add_text("lmofa" + str(i))
		pop_context()

func B() -> void:
	push_indent(1)
	push_table(3)
	set_table_column_expand(1, true, 1)
	for i in 7:
		push_cell()
		push_paragraph(HORIZONTAL_ALIGNMENT_RIGHT, Control.TEXT_DIRECTION_AUTO, "")
		add_text("lmofa" + str(i))
		pop()
		pop()
```

I put these two functions on a RichTextLabel, expecting them to do the same, but it turns out tables are hardcoded to only accept cells to be pushed, so the new `push_context()` in the first function won't work. This is unexpected, since regular `pop()` works without treating `push_cell()` differently.

### Steps to reproduce

Add a RichTextLabel, extend it with a script, and add the code above.

### Minimal reproduction project

N/A
Repository: godot
Issue: GLTF exporter fails to Export Normal Map properly
Labels: bug,topic:3d,topic:export

### Godot version

v4.2.dev.custom_build [d015905c0]

### System information

Godot v4.2.dev (d015905c0) - Windows 10.0.22621 - Vulkan (Forward+) - dedicated AMD Radeon RX 6600 (Advanced Micro Devices, Inc.; 31.0.21031.1005) - Intel(R) Core(TM) i3-10105F CPU @ 3.70GHz (8 Threads)

### Issue description

I created a Normal Map using Noise Textures, set it on a mesh as a Normal Map, exported scene with GLTF exporter, and the Normal Map got absolutely wrecked. Exporting that same texture when using Albedo resulted in a Proper texture.

### Steps to reproduce

Set a texture as Normal Map
Export Scene with the texture as GLTF
Open GLTF
Normal Map is broken

### Minimal reproduction project

N/A
Repository: opencv
Issue: Cannot read multi spectral tiff images
Labels: feature,priority: low,category: imgcodecs

<!--
If you have a question rather than reporting a bug please go to https://forum.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).

This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->

##### System information (version)

- OpenCV => 4.8.0
- Operating System / Platform => Ubuntu 18.04
- Compiler => GNU 7.5.0

##### Detailed description

Hi, is there any news about this issue ? I cannot read my tiff files.
The identify command on a single image returns

`TIFF 4096x4096 4096x4096+0+0 64-bit Grayscale Gray".`

When trying this

`cv::Mat inputMat = cv::imread(imagePath, cv::IMREAD_UNCHANGED);`

I get

`
[ERROR:0@4.849] global loadsave.cpp:440 imread_ imread_('/path/to/file/467370-5243100_32720_PHISAT2-BANDS-GRID_0_2020-09-23T14-14-39_MOSAIC.tiff'): can't read header: OpenCV(4.8.0-dev) /opt/opencv/modules/imgcodecs/src/grfmt_tiff.cpp:155: error: (-2:Unspecified error) in function 'int cv::TiffDecoder::normalizeChannelsNumber(int) const'
Unsupported number of channels: 'channels >= 1 && channels <= 4' where 'channels' is 8
`

I played with many options (IMREAD_UNCHANGED, IMREAD_LOAD_GDAL, .. ) and both reading functions (imread, imreadmulti) but cannot read my tiff files without error.

An example of 10-bands tif file returning the same error
[LC82260732013357LGN00_32_data.zip](https://github.com/opencv/opencv/files/12596036/LC82260732013357LGN00_32_data.zip)
Repository: angular
Issue: Angular Devtools don't work when launching from VSCode with "--user-data-dir"
Labels: area: devtools

### Which @angular/* package(s) are the source of the bug?

Don't known / other

### Is this a regression?

Yes

### Description

I am running a debugging Chrome instance from a Remote Docker Devcontainer from VSCode. When I specify the user data directory through "userDataDir" in launch.json, and install the devtools in the resulting profile, the devtools appear with a broken UI and quickly crash with the error `Uncaught Error: Extension context invalidated" (at ng_validate_bundle.js).`. However, if I install the devtools in my normal profile or run the debug instance with the "userDataDir": false option, the extension works. (Note: "userDataDir" is the equivalent to the commandline Chrome flag `--user-data-dir=`.

### Please provide a link to a minimal reproduction of the bug

_No response_

### Please provide the exception or error you saw

```true
Uncaught Error: Extension context invalidated" (at ng_validate_bundle.js).
```


### Please provide the environment you discovered this bug in (run `ng version`)

```true
Angular CLI: 16.1.4
Node: 16.20.2
Package Manager: npm 8.19.4
OS: linux x64

Angular: 16.1.4
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, platform-browser, platform-browser-dynamic, router
... service-worker
                                
Package                         Version                        
---------------------------------------------------------
@angular-devkit/architect       0.1601.4
@angular-devkit/build-angular   16.1.4
@angular-devkit/core            16.1.4
@angular-devkit/schematics      16.1.4
@schematics/angular             16.1.4
rxjs                            7.8.1
typescript                      5.1.6
```


### Anything else?

_No response_
Repository: pytorch
Issue: Cannot construct `torch.sparse_coo_tensor` (but `scipy.sparse.coo_matrix` works fine): `TypeError: only integer tensors of a single element can be converted to an index`
Labels: module: sparse,triaged,module: scipy compatibility

### 🐛 Describe the bug

Also, note the strange warning when using `weights_only=True`.
[bug.pt.gz](https://github.com/pytorch/pytorch/files/12586855/bug.pt.gz)

```python
import gzip
import torch
import scipy

bug = torch.load(gzip.open('bug.pt.gz', 'rb'), weights_only=True)
#  /home/vadimkantorov/.local/lib/python3.8/site-packages/torch/_utils.py:841: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
#  return self.fget.__get__(instance, owner)()

scipy.sparse.coo_matrix((bug['values'], (bug['rowinds'], bug['colinds'])), shape=bug['shape'])
# ok

torch.sparse_coo_tensor((bug['rowinds'], bug['colinds']), bug['values'], size=bug['shape'])
# TypeError: only integer tensors of a single element can be converted to an index
```

Same error appears in https://github.com/pytorch/pytorch/issues/43949 in a completely different context. This error is extremely mysterious and weird.

### Versions

2.1.0.dev20230802+cpu

cc @alexsamardzic @nikitaved @pearu @cpuhrsch @amjames @bhosmer
Repository: rust
Issue: regression: import resolution ambiguity
Labels: P-medium,T-compiler,regression-from-stable-to-stable

https://crater-reports.s3.amazonaws.com/beta-1.73-1.2/beta-2023-09-10/reg/otter-1.2.1/log.txt
Repository: rust
Issue: regression: ty/closure index out of bounds ICE
Labels: I-ICE,P-medium,T-compiler,regression-from-stable-to-stable

```
[INFO] [stderr] thread 'rustc' panicked at compiler/rustc_middle/src/ty/closure.rs:180:56:
[INFO] [stderr] index out of bounds: the len is 1 but the index is 1
```

https://crater-reports.s3.amazonaws.com/beta-1.73-1.2/beta-2023-09-10/reg/mononym-0.1.0/log.txt
Repository: vscode
Issue: Support two variants of `LanguageStatusItem#text`
Labels: feature-request,languages-basic,ux,api-proposal

The [LanguageStatusItem#text](https://github.com/microsoft/vscode/blob/07fcfc80c37e56fd35fc125e225c7dde7029f858/src/vscode-dts/vscode.d.ts#L6854) properties is the text that shows when an item is pinned _and_ when an item is rendered in the hover (as [<text> <detail>]). There are cases in which it is hard to find a short text that works well for the pinned and unpinned case. We should explore to extend the API to `text: string | { value:string, shortValue: string}` so that both cases can be caters for
Repository: go
Issue: proposal: go/analysis/passes/printf: disallow %d formatting of pointers
Labels: Proposal,Analysis

`fmt.Sprintf("%d", new(int))` prints a string of decimal digits, which appears in practice to be almost always a mistake caused by forgetting to dereference a pointer to an integer. (Is there ever a good reason to print a pointer value in decimal?)

In this case the vet check is consistent with the behavior of fmt, but arguably the vet check should be intentionally stricter than fmt (since we can't change fmt). I propose to make vet report the use of %d with a pointer as an error.

It could additionally hint the user to either dereference the pointer (if it's a pointer-to-int), or use "%d" on uintptr(unsafe.Pointer(ptr)), if the decimal string really was wanted.
Repository: material-ui
Issue: [joy-ui][List] Support responsive orientation values
Labels: waiting for 👍,component: list,package: joy-ui,enhancement

### Duplicates

- [X] I have searched the existing issues

### Related page

https://mui.com/joy-ui/react-radio-button/

### Kind of issue

Unclear explanations

### Issue description

I was looking for list orientation to be based on viewport width

e.g.

```jsx

<List
    component="div"
    size='sm'
    variant="outlined"
    orientation={{ xs: 'vertical', md: 'horizontal' }}
    sx={{
        borderRadius: 'sm',
        boxShadow: 'sm',
        justifyContent: 'flex-start'
    }}>
...
</List>

```

 and it appears that `orientation` value expects only either `["horizontal","vertical"]`



### Context 🔦

_No response_
Repository: transformers
Issue: NLLB-CLIP model implementation
Labels: New model,Model on the Hub

### Model description

Hi!

I recently trained a CLIP model with an NLLB text encoder to extend CLIP capabilities to 201 languages of the Flores-200 dataset. As far as the implementation goes, it is HF CLIP implementation with an M2M100 encoder from NLLB models. I'm wondering if you'd be interested in having NLLB-CLIP in the library? If yes, I can bring my implementation in accordance with other CLIP models and create a PR.

The link to the paper with description and results - https://arxiv.org/abs/2309.01859

### Open source status

- [x] The model implementation is available
- [x] The model weights are available

### Provide useful links for the implementation

_No response_
Repository: flutter
Issue: FontStyle.italic is not possible to combine with FontFeature.enable('smcp')
Labels: framework,engine,dependency: skia,a: typography,has reproducible steps,P2,team-engine,triaged-engine,found in release: 3.13,found in release: 3.14

### Is there an existing issue for this?

- [X] I have searched the [existing issues](https://github.com/flutter/flutter/issues)
- [X] I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)

### Steps to reproduce

1. Add `fontStyle: FontStyle.italic` to a text
2. Add `fontFeatures: [FontFeature.enable('smcp')]` to a text

### Expected results

The text should be both small caps and italic

### Actual results

The italic option seems to overwrite the small caps feature

### Code sample

<details><summary>Code sample</summary>

```dart
import 'dart:ui';

import 'package:flutter/material.dart';

void main() async {
  runApp(const FontFeatureTestApp());
}

class FontFeatureTestApp extends StatelessWidget {
  const FontFeatureTestApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Font Feature Test',
      home: Scaffold(
        appBar: AppBar(title: const Text('Font Feature Test')),
        body: const Center(
          child: Text.rich(
            TextSpan(
              children: [
                TextSpan(text: 'Hello '),
                TextSpan(
                  text: 'World',
                  style: TextStyle(
                    fontStyle: FontStyle.italic,
                    fontFeatures: [FontFeature.enable('smcp')],
                  ),
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}
```

</details>


### Screenshots or Video

<details>
<summary>Screenshots / Video demonstration</summary>

![font-bug](https://github.com/flutter/flutter/assets/44020490/bae3e2e5-060a-49ef-bff8-4a9439edc5e1)
</details>


### Logs

<details><summary>Logs</summary>

```console
[Paste your logs here]
```

</details>


### Flutter Doctor output

<details><summary>Doctor output</summary>

```console
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.3, on macOS 13.1 22C65 darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.81.1)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!
```

</details>
Repository: ant-design
Issue: 希望 Anchor 组件能提供受控模式
Labels: Inactive

### What problem does this feature solve?

我想编写一个 `AnchorFoldableTitle` 组件用于实现目录折叠功能， `Anchor` 目前只提供了一个 `getCurrentAnchor` 被动的处理 `activeLink` 而不能由外部主动设值，但是不更新 `activeLink` 的话 `Ink` 滑块的位置就不对了。

![image](https://github.com/ant-design/ant-design/assets/21048878/6c00f233-91dc-4775-9427-6403abe892bf)


### What does the proposed API look like?

受控模式下 `onChange` 可以代替 `getCurrentAnchor` 

```ts
type AnchorProps = {
value?: string
onChange?: (currentActiveLink: string) => void;

/**
   * @deprecated
   */
getCurrentAnchor?: (activeLink: string) => string;
}
```

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: pytorch
Issue: Unable to install the latest version of PyTorch using mamba.
Labels: module: binaries,triaged

### 🐛 Describe the bug

I am encountering an issue while using mamba to install the latest version of PyTorch. The problem is that after mamba completes the download of the PyTorch package, it automatically terminates the current terminal process, causing it to switch to another terminal.

![image](https://github.com/pytorch/pytorch/assets/96970081/c39a0d62-136b-4dca-a545-d73e4dca2f5a)


### Versions

conda 23.3.1

cc @seemethere @malfet @osalpekar @atalman
Repository: flutter
Issue: When using SliverMainAxisGroup, SliverAppBar should push out SliverPersistentHeader
Labels: c: new feature,framework,f: scrolling,c: proposal,P2,team-framework,triaged-framework

### Is there an existing issue for this?

- [X] I have searched the [existing issues](https://github.com/flutter/flutter/issues)
- [X] I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)

### Use case

![not push](https://github.com/flutter/flutter/assets/57101477/cead845c-f6fc-4292-ba00-2cb58ee03cda)

https://dartpad.dev/?id=6e2b7245063001576a3a83adb23f1121

I created SliverMainAxisGroup by referring to the example code above, but the behavior of SliverAppbar is awkward.

You can reproduce it by modifying the example code like this.

```
class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: CustomScrollView(
        slivers: <Widget>[
          SliverAppBar(
            title: Text(widget.title),
            pinned: false,
            snap: false,
            floating: true,
          ),
...
```




### Proposal

![push](https://github.com/flutter/flutter/assets/57101477/c9f07eab-fe18-4cf2-b262-7fa0982d5145)

As shown above, AppBar should push the header.
The above operation was implemented with the https://pub.dev/packages/sliver_tools package.
Repository: rust
Issue: Debug info for const generics is hashes rather than something nice
Labels: A-debuginfo,T-compiler,A-const-generics,F-const_generics,F-adt_const_params,T-types

In https://github.com/rust-lang/rust/pull/115748 I got a test failure in tests/debuginfo/function-names.rs: `function_names::const_generic_fn_non_int<{CONST#ad91263f6d2dd96e}>` changed to `static fn function_names::const_generic_fn_non_int<{CONST#73a38766b652ae7d}>`. That PR leads to some new AllocIds being generated which shifts some IDs around, so it seems like the AllocId are affecting the function name here. @oli-obk was confused by this since with valtrees, shouldn't our function names be stable now? Indeed AllocId are not very stable at all so it seems potentially problematic if they are relevant for function names. The underlying function call is `const_generic_fn_non_int::<{ () }>` so this is not a very complicated valtree. ;)

Cc @rust-lang/project-const-generics