sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: kubernetes
Issue: Static Pods never get evicted when under Node Pressure
Labels: kind/bug,sig/node,sig/docs,triage/accepted

### What happened?

Static Pods are considered critical by [this code] (https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/eviction/eviction_manager.go#L597) and hence never get evicted.

### What did you expect to happen?

The [doc](https://kubernetes.io/docs/concepts/scheduling-eviction/node-pressure-eviction/#pod-selection-for-kubelet-eviction) says 

> If you are running a [static pod](https://kubernetes.io/docs/concepts/workloads/pods/#static-pods) and want to avoid having it evicted under resource pressure, set the priority field for that Pod directly. Static pods do not support the priorityClassName field.

At least, we should fix the inconsistency between code and doc.

### How can we reproduce it (as minimally and precisely as possible)?

1. Run a kubelet with fs eviction and static pods
```
apiVersion: kubelet.config.k8s.io/v1beta1
staticPodPath: /home/k8s/manifests
evictionHard:
  imagefs.available: "2Gi"
```

2. Create a static pod spamming disk
```
apiVersion: v1
kind: Pod
metadata:
  name: disk
spec:
  priority: 0
  - name: disk
    image: docker.io/busybox
    command: ["/bin/sh",  "-c", "/bin/dd if=/dev/zero of=/bigfile bs=1G count=102 && sleep 10000"]
```

3. check kubelet logs
> "Eviction manager: cannot evict a critical pod" pod="default/disk"

### Anything else we need to know?

_No response_

### Kubernetes version

<details>

```console
$ kubectl version
# paste output here
```

</details>


### Cloud provider

<details>
GCP
</details>


### OS version

<details>

```console
# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
```

</details>


### Install tools

<details>

</details>


### Container runtime (CRI) and version (if applicable)

<details>

</details>


### Related plugins (CNI, CSI, ...) and versions (if applicable)

<details>

</details>
Repository: tauri
Issue: How to reference bundle identifier value in Wix fragment?
Labels: type: feature request,platform: Windows

I want to customize the MSI installer with a Wix fragment, but I don't want to have to edit this file if I later decide to change the name of my app. 

So with that in mind, is there a way to reference the full bundle identifier value in a Wix fragment without having to hardcode it, much like how "MyCompany" and "MyApplicationName" works?

Example:

```
<RegistryKey Root="HKCU" Key="Software\MyCompany\MyApplicationName" Action="createAndRemoveOnUninstall">
     <RegistryValue Name="AppDataFolder" Type="string" Value="[AppDataFolder]com.bundleidentifier.app" />
</RegistryKey>
```
Repository: puppeteer
Issue: [Feature]: Support chromedriver with WebDriver BiDi
Labels: feature,P2

### Feature description

- it should be possible to connect to a ChromeDriver instance
- there should be test coverage testing the puppeteer.connect to chromedriver
- we should see if we want to support it in launch but it is a bit redundant since we can talk bidi directly.
Repository: storybook
Issue: Remove vitest 2.0 backwards compatible workarounds
Labels: BREAKING CHANGE

Remove the following lines:
https://github.com/storybookjs/storybook/blob/6a4e7b7b7684478b451ec65d117f3128e2375889/code/lib/test/src/spy.ts#L36-L57
Repository: PowerToys
Issue: Save as Recent
Labels: Idea-New PowerToy,Needs-Triage

### Description of the new feature / enhancement

Throughout the day I have to download many, many files from different sources, so I need to organize them in the recent folders that are not in the pro modules, so it would be very necessary for a secondary mouse menu to open a link to go to the recent folders or recent files

### Scenario when this would be used?

Any save as module

### Supporting information

_No response_
Repository: ui
Issue: [bug]: Combobox on docs doesn't work
Labels: bug

### Describe the bug

When trying to open the component, the site issues a client side exception (https://ui.shadcn.com/docs/components/combobox)

### Affected component/components

Combobox

### How to reproduce

1. Go to Combobox. 2. Open Combobox with placeholder 'Select framework...'. 3. See error

### Codesandbox/StackBlitz link

https://ui.shadcn.com/docs/components/combobox

### Logs

_No response_

### System Info

```bash
Google Chrome Version 127.0.6533.89 (Official Build) (64-bit)
```


### Before submitting

- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues
Repository: storybook
Issue: [Bug]: Infinite loop rendering on `unboundStoryFn`
Labels: bug,needs triage

### Describe the bug

Hello,
I've recently migrated storybook from v7 to v8 using the migration script.
Since, there is an infinite loop on `unboundStoryFn` that causes re-rendering all my stories
![Screenshot 2024-08-05 at 14 19 36](https://github.com/user-attachments/assets/445de0e9-b858-4acb-a86b-b549017ae82b)
You can find my config right [here](https://github.com/centreon/centreon/blob/develop/centreon/packages/ui/.storybook/main.ts)

Is there something related to my configuration?

Thanks

EDIT: When I open the canvas in a new tab, it does not render infinitely.

### Reproduction link

https://github.com/centreon/centreon/blob/develop/centreon/packages/ui/.storybook/main.ts T

### Reproduction steps

1. Install dependencies using pnpm
2. run pnpm storybook
3. Go to a story then run the profiler

### System

```bash
Storybook Environment Info:

  System:
    OS: macOS 14.5
    CPU: (8) x64 Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
    pnpm: 8.15.7 - ~/.nvm/versions/node/v20.11.1/bin/pnpm <----- active
  Browsers:
    Chrome: 127.0.6533.89
    Safari: 17.5
  npmPackages:
    @storybook/addon-a11y: ^8.2.7 => 8.2.7 
    @storybook/addon-docs: ^8.2.7 => 8.2.7 
    @storybook/addon-essentials: ^8.2.7 => 8.2.7 
    @storybook/addon-interactions: ^8.2.7 => 8.2.7 
    @storybook/addon-themes: ^8.2.7 => 8.2.7 
    @storybook/blocks: ^8.2.7 => 8.2.7 
    @storybook/manager-api: ^8.2.7 => 8.2.7 
    @storybook/mdx2-csf: ^1.1.0 => 1.1.0 
    @storybook/preview-api: ^8.2.7 => 8.2.7 
    @storybook/react: ^8.2.7 => 8.2.7 
    @storybook/react-vite: ^8.2.7 => 8.2.7 
    @storybook/test: ^8.2.7 => 8.2.7 
    @storybook/test-runner: ^0.19.1 => 0.19.1 
    @storybook/theming: ^8.2.7 => 8.2.7 
    msw-storybook-addon: ^2.0.3 => 2.0.3 
    storybook: ^8.2.7 => 8.2.7 
    storybook-addon-mock: ^5.0.0 => 5.0.0 
    storybook-dark-mode: ^4.0.2 => 4.0.2
```


### Additional context

_No response_
Repository: react-native
Issue: FlatList re-mount all the row when using columns
Labels: Issue: Author Provided Repro,Component: FlatList,Newer Patch Available

### Description

Regardless of the use of optimization techniques, such as React.memo or useCallback, when a FlatList with columns (numColumns > 1) is created and an element is added or removed from the list, this causes all components of the row where the element was added or removed to be re-mounted. This is easily noticeable if entry animations are used (but it has other serious repercussions). I'm currently stuck in development on this issue (and switching to unsare scroll view would make the app unusable). There are many similar issues by now, all closed without any discussion or solution, and since it has been years now I think it is time to take the problem into consideration. 

### Steps to reproduce

1) configure a Flatlist with numColumns > 1 2) add dynamically a new item or remove an item 3) all the items of the row addicted are re-mounted

### React Native Version

0.74.3

### Affected Platforms

Runtime - Android, Runtime - iOS

### Output of `npx react-native info`

```text
System:
  OS: macOS 14.5
  CPU: (8) arm64 Apple M2
  Memory: 127.25 MB / 8.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 22.4.1
    path: /opt/homebrew/bin/node
  Yarn:
    version: 1.22.19
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.8.2
    path: /opt/homebrew/bin/npm
  Watchman:
    version: 2024.07.01.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/niccolocaselli/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK:
    Android NDK: 22.1.7171670
IDEs:
  Android Studio: 2023.2 AI-232.10300.40.2321.11567975
  Xcode:
    version: 15.4/15F31d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.11
    path: /usr/bin/javac
  Ruby:
    version: 2.7.6
    path: /Users/niccolocaselli/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.3
    wanted: 0.74.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false
```


### Stacktrace or Logs

```text
no crash
```


### Reproducer

https://snack.expo.dev/@niccolocase/0aa680

### Screenshots and Videos


https://github.com/user-attachments/assets/891e73d0-d77f-4b3e-8beb-5a1fe60c5a82
Repository: PowerToys
Issue: Settings & certain folders PT Run doesn't act 1:1 w/ WSB
Labels: Issue-Bug,Product-PowerToys Run,Needs-Triage

### Microsoft PowerToys version

0.81.1

### Installation method

GitHub

### Running as admin

No

### Area(s) with issue?

PowerToys Run

### Steps to reproduce

PowerToys Run does not find some entries found by the default Windows Launcher.
PowerToys Run seems to be less powerfull than the default Windows Launcher when searching for locations / programs.

By example, as a french, I can find the Downloads folder by typing "téléchargements" in the Windows Launcher.
But I am forced to search it in english in PowerToys Run by typing "downloads".

![launcher](https://github.com/user-attachments/assets/c7902e1f-c2f6-48ee-96ff-1e3ecc190cc0)
![run](https://github.com/user-attachments/assets/0d21bdf9-4ab9-488b-ab02-5775fd0e0798)

I speak english and french, and I would like PowerToys run to find the Downloads folder whether I type it in english or in french.
(For context, french people heavily use english words when it relates to IT, so it is nice to be able to search in english and in french.)

---

The same is true for the screen resolution.
I can access the settings from the native Windows Launcher, but not from PowerToys Run.

![launcher-2](https://github.com/user-attachments/assets/15babab2-db21-40b7-b8e5-169cdb6d274a)
![run-2](https://github.com/user-attachments/assets/48d0634e-8e5f-4402-8a85-ca1decabe5ce)


### ✔️ Expected Behavior

PowerToys Run should display the menu entries that appear in the native Windows Launcher.

### ❌ Actual Behavior

Some options appear in the native Windows Launcher, but not in PowerToys Run.

### Other Software

_No response_
Repository: rust
Issue: Debug implementation of fat pointers doesn't show metadata
Labels: C-bug,T-libs

I tried this code:

```rust
fn main() {
    let mut x = *b"hello";
    let p: &mut [u8] = &mut x;
    let q: *mut [u8] = &mut p[..3];
    assert_eq!(p as *mut [u8], q);
}
```

I expected to see this happen:

```
assertion `left == right` failed
  left: { ptr: 0x7ffdd41d89f3, meta: 5 }
 right: { ptr: 0x7ffdd41d89f3, meta: 3 }
```

Instead, this happened:

```
assertion `left == right` failed
  left: 0x7ffdd41d89f3
 right: 0x7ffdd41d89f3
```

Note: The pointer address is non-deterministic, so the output may differ. What matters is that the pointer address is the same, only the metadata differ.

### Meta

`rustc --version --verbose`:

```
rustc 1.82.0-nightly (f8060d282 2024-07-30)
binary: rustc
commit-hash: f8060d282d42770fadd73905e3eefb85660d3278
commit-date: 2024-07-30
host: x86_64-unknown-linux-gnu
release: 1.82.0-nightly
LLVM version: 18.1.7
```

<details><summary>Backtrace</summary>
<p>

```
thread 'main' panicked at src/main.rs:5:5:
assertion `left == right` failed
  left: 0x7ffca57ef663
 right: 0x7ffca57ef663
stack backtrace:
   0: rust_begin_unwind
             at /rustc/f8060d282d42770fadd73905e3eefb85660d3278/library/std/src/panicking.rs:662:5
   1: core::panicking::panic_fmt
             at /rustc/f8060d282d42770fadd73905e3eefb85660d3278/library/core/src/panicking.rs:74:14
   2: core::panicking::assert_failed_inner
             at /rustc/f8060d282d42770fadd73905e3eefb85660d3278/library/core/src/panicking.rs:412:17
   3: core::panicking::assert_failed
             at /rustc/f8060d282d42770fadd73905e3eefb85660d3278/library/core/src/panicking.rs:367:5
   4: foo::main
             at ./src/main.rs:5:5
   5: core::ops::function::FnOnce::call_once
             at /rustc/f8060d282d42770fadd73905e3eefb85660d3278/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
```

</p>
</details>


<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"Enselic"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
Repository: godot
Issue: Crash when `EditorNode::_resource_saved` called from different threads
Labels: bug,topic:editor,needs testing,crash

### Tested versions

Reproducible in 4.3rc2

### System information

Any

### Issue description

Asan from commit https://github.com/gamelessone/godot/commits/1488cf50e9eac100196962a8455b38fd29c2cc96/ (4.3rc2 + 1 unrelated commit)
[crash-2.txt](https://github.com/user-attachments/files/16498561/crash-2.txt)


### Steps to reproduce

It looks like a hard to reproduce issue where one thread is reading `EditorFileSystem::late_update_files` and the other is reallocating memory.

### Minimal reproduction project (MRP)

N/A
Repository: kubernetes
Issue: Impossible to notice without major delay when a container exits while the POD is in terminating state
Labels: kind/bug,sig/network,sig/node,triage/accepted

### What happened?

When a POD which is part of a service starts graceful termination, and the main container exits the related endpoint in endpointslice does not go to serving=false. Only after readiness probe fails will the endpoint enter serving=false state. Which doesn't make sense in my opinion.

I also tried watching for POD changes and determine that the container exited based on container_statuses list. But there I hit this issue: https://github.com/kubernetes/kubernetes/issues/106896

Then I tried to remove the label which selects the POD as an endpoint by the service, but then I experienced ~5s delay till kubernetes notified that the endpoint has disappeared.

### What did you expect to happen?

The endpoint should go to serving=false when any container exits in a POD which is under graceful termination.
Also the alternatives I tried should have worked I think.

### How can we reproduce it (as minimally and precisely as possible)?

Create a POD with 2 containers, 1 which exits immediately after receiving SIGTRERM, the other doesn't so it is killed by SIGKILL after termination grace period. The first container should also have a readiness probe which doesn't fail quick. ex.: period 5s, failureThreshold 3. Make the POD be part of a service. Delete the pod. Check the endpoint in the endpointslice only going to serving=false, after the readiness probe fails. 

### Anything else we need to know?

_No response_

### Kubernetes version

kubectl version
Client Version: v1.28.1
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.1

### Cloud provider

N/A

### OS version

<details>

```console
# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
```

</details>


### Install tools

<details>

</details>


### Container runtime (CRI) and version (if applicable)

<details>

</details>


### Related plugins (CNI, CSI, ...) and versions (if applicable)

<details>

</details>
Repository: pytorch
Issue: fix unnecessary re-trace in AOTDispatcher in subclass code path
Labels: triaged,module: __torch_dispatch__,tensor subclass,oncall: pt2,module: aotdispatch,module: startup-tracing-compile,module: pt2-dispatcher

The normal flow in AOTDispatcher involves two rounds of tracing the input GraphModule from dynamo:

(1) Execute the graph from dynamo with functionalization turned on, to gather metadata about the inputs/outputs of the graph (which outputs require grad, which inputs are mutated, etc), by calling `run_functionalized_fw_and_collect_metadata`.

(2) Use that info to properly trace an [inference|joint] graph

Sometimes though, we invoke `run_functionalized_fw_and_collect_metadata` twice. In these cases, AOTDispatcher will take ~50% longer to compile since we are in net tracing the graph 3 times instead of 2 times.

Why do we re-run `run_functionalized_fw_and_collect_metadata` today?

(1) `run_functionalized_fw_and_collect_metadata()` accepts an `is_train` argument (specifying if we are generating an inference vs training graph), that impacts what the final` ViewAndMutationMeta` it produces looks like.
(2) However - in order to know if we are generating an inference vs. training graph, we need to know whether any of the outputs require grad. Today, we get this info by first running `run_functionalized_fw_and_collect_metadata`! We pass in our "guess" for is_train, by [checking](https://github.com/pytorch/pytorch/blob/main/torch/_functorch/aot_autograd.py#L580) to see if any inputs `require_grad`
(3) Once we run `run_functionalized_fw_and_collect_metadata` and figure out if any outputs require grad, we manually fix up the `ViewAndMutationMeta` given the new value of `is_train`. In the non-subclass codepath, we do it manually [here](https://github.com/pytorch/pytorch/blob/main/torch/_functorch/aot_autograd.py#L654). In the subclass code-path, instead of fixing it up manually we just regenerate it with another call to `run_functionalized_fw_and_collect_metadata`

Why is it harder to fix up the `ViewAndMutation` meta in the subclass codepath? There is some more info in this [comment](https://github.com/pytorch/pytorch/blob/main/torch/_functorch/_aot_autograd/collect_metadata_analysis.py#L690): we store a `ViewAndMutationMeta.subclass_fw_graph_out_meta` attribute that tells us "for each output of the fw graph, what subclass metadata do we need to know". However, the number of outputs to the forward graph is dependent on if we are doing inference or training, so this value gets specialized to the `is_train` flag.

One nice fix would be: instead of baking in `subclass_fw_graph_out_meta` directly into the `ViewAndMutationMetadata` class (which is hardcoded to whether we are doing inference or training), make it a read-only property that is generated based on the value of `is_train`. Then the codepath [here](https://github.com/pytorch/pytorch/blob/main/torch/_functorch/aot_autograd.py#L654) would work in both the sublcass and non-subclass codepath.

cc @Chillee @ezyang @zou3519 @albanD @samdow @chauhang @penguinwu @oulgen @jamesjwu @aorenste @anijain2305 @laithsakka
Repository: godot
Issue: Volumetric Fog overlaps over Distance Fog
Labels: discussion,topic:rendering,topic:3d

### Tested versions

- Reproducible in 4.3.4, 4.3rc2

### System information

Godot v4.3.rc2 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1650 (NVIDIA; 32.0.15.5612) - AMD Ryzen 3 2200G with Radeon Vega Graphics (4 Threads)

### Issue description

When you enable both Volumetric fog and Distance fog, any point where both fogs overlap, the volumetric fog will lit up/uncover any surface that are expected to be covered by the distance fog. My expected outcome is for the distance fog to always cover the surfaces that are meant to be hidden by it. Not sure if theres a perspective where the expected outcome is the current one.

![Captura de pantalla 2024-08-05 090654](https://github.com/user-attachments/assets/ceafcb09-d01b-4a68-a58e-372f18b2266d)
Windows to black background at end of hallway.

![Captura de pantalla 2024-08-05 093252](https://github.com/user-attachments/assets/3d594af4-5c7f-4b82-ab63-de64428b2e19)
Window completely hidden by fog at end of hallway

![Captura de pantalla 2024-08-05 090634](https://github.com/user-attachments/assets/96365674-7908-40e4-95ff-2b744f7f5aa5)
Volumetric fog being lit up by the indirect lighing (SDFGI), overlapping the distance fog, lighting up the surfaces previously covered by the distance fog

![Captura de pantalla 2024-08-05 090745](https://github.com/user-attachments/assets/58658129-002a-4ec8-be1a-e9f6b62266f8)
Volumetric fog being lit up by a spotlight with volumetric enabled, overlapping the distance fog, lighting up the surfaces previously covered by the distance fog


### Steps to reproduce

1. Open the project and the TestScene.tscn
2. Move the camera behind SpotLight3D1, looking towards the window
3. Observe the wall and windows, previously covered by fog, become visible
4. Enable SDFGI in the WorldEnviroment node
5. Move the camera behind SpotLight3D2, looking towards the window
6. Observe the wall and windows, previously covered by fog, become visible

### Minimal reproduction project (MRP)

[MultiFogTest.zip](https://github.com/user-attachments/files/16499249/MultiFogTest.zip)
Repository: PowerToys
Issue: Screen Ruler Functionality
Labels: Idea-New PowerToy,Needs-Triage

### Description of the new feature / enhancement

As a developer who creates mockups and web pages I can see the benefit of screen ruler but it's basically useless to me without the ability to take screenshots. If the snipping tool just incorporated all the features of screen ruler into it I'd use it every single day.

### Scenario when this would be used?

When taking a snip with he snipping tool, I oftentimes want the dimensions to be exact or at least close to certain aspect ratios and being able to see the exact bounds in pixel count while I am taking a screenshot would be a game changer for me.

### Supporting information

I like screen ruler and snipping tool but It's usually easier for me to just use a browser extension or eyeball things with snipping tool for the sake of time.
Repository: kubernetes
Issue: Add modify volume negative case e2e csi-mock tests
Labels: sig/storage,kind/feature,triage/accepted

### What would you like to be added?

Test cases to test with csi-mock driver in `/test/e2e/storage/csimock`:

- [ ] should not modify volume when target VAC not found 
- [ ] should not modify volume when target VAC yields InvalidArgument
- [ ] should recover from invalid target VAC by updating PVC to new valid VAC
- [ ] should recover from invalid target VAC by rolling back PVC to previous VAC
- [ ] should not create volume with VAC when csi driver does not support volume modification
- [ ] should not modify volume when csi driver does not support volume modification

### Why is this needed?

These negative tests would mainly test Kubernetes and therefore should not belong in the `test/e2e/storage/testsuites`. See older commit of #126423 for outlines for these tests.

/sig storage

/assign