sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: rust
Issue: Bad location of `#[must_use = "message"]` note in the output.
Labels: C-enhancement,A-lints,A-diagnostics,T-compiler

<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.

If you cannot produce a minimal reproduction case (something that would work in
isolation), please provide the steps or even link to a repository that causes
the problematic output to occur. 
-->

Given the following code: <!-- Please provide a link to play.rust-lang.org -->

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=80439b95abcd8f9457d87fd7779b9b48

```rust
#![deny(unused_must_use)]

fn main() {
    init();
}

#[must_use = "init() returns a drop guard"]
fn init() -> impl Drop {
    ...
}
```

The current output is:

```
error: unused return value of `init` that must be used
 --> src/main.rs:4:5
  |
4 |     init();
  |     ^^^^^^^
  |
note: the lint level is defined here
 --> src/main.rs:1:9
  |
1 | #![deny(unused_must_use)]
  |         ^^^^^^^^^^^^^^^
  = note: init() returns a drop guard
```

The problem is that the `note: init() returns a drop guard` looks like it's attached to the note about the lint level and not to the error what makes it easy to miss.

<!-- The following is not always necessary. -->
Ideally the output should look like:

```
error: unused return value of `init` that must be used
 --> src/main.rs:4:5
  |
4 |     init();
  |     ^^^^^^^
  | note: init() returns a drop guard
  |
note: the lint level is defined here
 --> src/main.rs:1:9
  |
1 | #![deny(unused_must_use)]
  |         ^^^^^^^^^^^^^^^
```

<!--
If the problem is not self-explanatory, please provide a rationale for the
change.
-->

<!--
If dramatically different output is caused by small changes, consider also
adding them here.

If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions. The output might also be
different depending on the Edition.
-->
Repository: rust
Issue: Rustc should warn if you have a stability attribute on a non-public item
Labels: A-stability,T-libs,A-contributor-roadblock

_Originally posted by @ijackson in https://github.com/rust-lang/rust/issues/83372#issuecomment-804135923_

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"gimbles"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
Repository: vscode
Issue: Data breakpoints: support modifying current breakpoint access type
Labels: feature-request,debug

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
Related: https://github.com/microsoft/vscode/issues/83649
<!-- Describe the feature you'd like. -->
Hi, 
Since VS Code will support data breakpoints creation based on `accessTypes` (https://github.com/microsoft/vscode/issues/113922), it would be great if we also can have a GUI to update them, based on this same response.

Regards.
Repository: go
Issue: proposal: cmd/go: 'go get', 'go mod tidy' should update the vendor directory when present
Labels: Proposal,FeatureRequest,GoCommand,modules

This is basically the same issue as #29058, but the default behavior has changed, so it may be worth reopening the discussion.

Since 1.14, the go command may use the vendor directory by default (without the `-mod=vendor` flag) if the `go` version in `go.mod` is 1.14 or higher and `vendor/modules.txt` is present. The go command reports an error if `go.mod` and `vendor/modules.txt` are out of sync.

Two commands primarily change `go.mod`: `go mod tidy` and `go get`. When these commands make changes, they break vendor builds until `go mod vendor` is run again.

We've avoided rebuilding the vendor directory implicitly, since the go command currently deletes the entire folder, loads the import graph, and recreates it from scratch. That may cause developers to lose local changes (like a patch being prepared for a dependency).

I propose some new behavior:

* We need a mechanism to detect local changes to `vendor`. That probably means comparing the contents of each package directory to the corresponding directory in the module cache. That would help us implement #27348.
* `go get` would add or update packages in the vendor directory automatically if it's present. Only packages needed to build the packages named on the command line would be affected.
* `go mod tidy` would implicitly rebuild the vendor directory. `go mod vendor` would be a no-op after `go mod tidy`.
* Any command that modifies the vendor directory would report an error if local changes would be overwritten. We might want a flag to force overwrite, or the developer could run `git checkout` or `rm -rf vendor` first.
* No change to `go build` and other commands. `-mod=readonly` and `-mod=mod` would continue to ignore the vendor directory.

cc @bcmills @FiloSottile @matloob
Repository: PowerToys
Issue: FanzyZones: Spacing always applied (even if disabled) to Grid after latest update
Labels: Issue-Bug,FancyZones-Layouts,Product-FancyZones,Status-Reproducible

## ℹ Computer information

- PowerToys version: v0.33.1
- PowerToy Utility: FanzyZones
- Running PowerToys as Admin: No
- Windows build number: 20H2 (OS Build 19042.867)

## 📝 Provide detailed reproduction steps (if any)

1. Launch layout editor
2. Edit layout (Grid)
3. Disable spacing
![image](https://user-images.githubusercontent.com/26607885/112019485-b8aa1000-8aec-11eb-9fae-cdfe6669159c.png)
Note that visible does disappear in ghosted layout preview
4. Save
5. Move windows around in snapping mode (e.g. hold shift), note that spacing is still visible and still applied to windows napping

### ✔️ Expected result

Window takes full available space

### ❌ Actual result

I lose 40 pixels vertically and horizontally around all my windows, and my monitor isn't that big so I'm grumpy :/

Note, this worked just fine until I took the latest PowerToys update.

Related to #9713?

Does not repro for Column. Most obvious cause would be the Grid refactor? #10116

Doesn't matter if I change the Spacing to another value either (e.g. 2).
Repository: rust
Issue: Bad compiler error messages while using diesel
Labels: A-diagnostics,A-trait-system,T-compiler,D-confusing,D-newcomer-roadblock

<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.

If you cannot produce a minimal reproduction case (something that would work in
isolation), please provide the steps or even link to a repository that causes
the problematic output to occur. 
-->
Following [this request on twitter](https://twitter.com/ekuber/status/1373305373197623299) I've put together a "best of" of some compiler errors that can occur if something went wrong while using diesel. The test cases are mostly taken out of our issue tracker, containing things our users have encountered in the past. So cc @estebank 

See [this repository](https://github.com/weiznich/bad_rustc_messages_for_diesel) for the code examples with some explanation what's going wrong there and what would be more helpful in my opinion. Feel free to contact me for any diesel related question about those error messages.
Repository: go
Issue: crypto/tls: Conn.Close should not override user's write deadline
Labels: NeedsInvestigation

<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.16.2 darwin/amd64

</pre>

### Does this issue reproduce with the latest release?

Yes: https://github.com/golang/go/blob/8fd0f83552d3ef9ca38c031bec93a36b189e3e11/src/crypto/tls/conn.go#L1361

### What operating system and processor architecture are you using (`go env`)?

All

### What did you do?

<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->

Set a write deadline of my liking, close a TLS connection.


### What did you expect to see?

The close to block for only the user specified deadline.

### What did you see instead?

The close blocks for 5 seconds.

The library should not override the user write deadline, or add a field in `tls.Config`. See comments on existing issue: https://github.com/golang/go/issues/31224#issuecomment-801513064
Repository: vscode
Issue: Debug: inline breakpoints are not stable
Labels: debug,polish,papercut :drop_of_blood:

I think we should allow to remove but then add back an inline breakpoint:

![recording (1)](https://user-images.githubusercontent.com/900690/112027848-e23c5900-8b37-11eb-8001-34ca38cd4365.gif)
Repository: vscode
Issue: Debug: current stopped line should indicate better?
Labels: debug,ux,under-discussion

Especially when you enable to show values like here:

![image](https://user-images.githubusercontent.com/900690/112028630-aa81e100-8b38-11eb-8f5c-5541b7b1a42a.png)

You end up with so many yellow lines that the current line that is stopped becomes harder to track.

Slightly related to: https://github.com/microsoft/vscode/issues/119485
Repository: pytorch
Issue: [JIT] prim::ModuleContainerIndex doesnt work with freezing
Labels: oncall: jit,days

## 🐛 Bug 

prim::ModuleContainerIndex doesn't currently work with freezing. This is because it is hiding a number of IR primitives which freezing understood, and naturally does not work out of the box. When we introduce new abstractions into the IR it would ideal if we made a best effort at working to lower these these abstractions or make them work with optimizations.

cc @gmagogsfm
Repository: flutter
Issue: PlaceholderSpan doesn't provide ability to define content
Labels: framework,d: api docs,d: examples,P2,team-framework,triaged-framework

From `InlineSpan` documentation:
![image](https://user-images.githubusercontent.com/1215187/112030210-b1155600-8b42-11eb-8306-747850d4b510.png)

`To be useful, [PlaceholderSpan] must be extended to define content`

But there is no way to define any content inside of `PlaceholderSpan`.
The best I can do is to extend `build` method and call `ParagraphBuilder.addPlaceholder` or `ParagraphBuilder.addText`.
- `addText` takes text, but it is limited to only text. Also it says `non-text content`
- `addPlaceholder` takes only size, no way to provide any kind of content

You can say to use `WidgetSpan`, but:
1. it clearly states that I can extend `PlaceholderSpan` and provide content myself,
2. it doesn't work with TextField, it throws tons of exception the moment I add it to the TextField.

## My use case
I need to format text in the TextField while user edits it, while replacing text with different symbols, images, etc.

You can also say - use `extended_text_field` library. But I can't - my TextField/Controller has a lot of non-compatible changes.
Repository: flutter
Issue: Support localized strings in a11y
Labels: framework,engine,a: accessibility,a: internationalization,P2,team-engine,triaged-engine

In the code pulled from upstream Chromium, there are references to `ToLocalizedString()`, which take an action enum and returns a string in the user's localized language describing that action. We don't have the notion of localization currently so we just return an English string describing the action instead.

Eventually we will want to localize this.
Repository: flutter
Issue: Support alert targets in Win32 a11y
Labels: engine,a: accessibility,platform-windows,P2,team-engine,triaged-engine

`AXPlatformNodeWin::AddAlertTarget()` and `AXPlatformNodeWin::RemoveAlertTarget()` need to be implemented
Repository: excalidraw
Issue: Pinch to zoom on Safari mac doesn't consider modals
Labels: safari,a11y

## Demo
![Demo](https://media.giphy.com/media/iLNPDuyoKRfmpLqoFI/giphy.gif)
Repository: godot
Issue: No thumbnails on 3D scenes
Labels: bug,topic:editor,needs testing,topic:3d

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
3.2.3 and 3.2.4RC4


**OS/device including version:**
Windows 10 PC. Tested both GLES3 and 2.


**Issue description:**
No matter how many times I save a scene, or even if I delete the cache folder in the Windows temp folder, no thumbnails are generated for 3D scenes. See the image below.

![image](https://user-images.githubusercontent.com/4234276/112041029-ce93f100-8b3d-11eb-8a9b-effc0ede8c6a.png)

Thumbnails should be generated automatically for 3D scenes just as they are for 2D scenes. There's also no preview image when hovering over the scene tab like there is for 2D scenes.


**Steps to reproduce:**
Create any 3D scene with a simple meshinstance node and save it.

**Minimal reproduction project:**
[testthumbnails.zip](https://github.com/godotengine/godot/files/6184604/testthumbnails.zip)
Repository: go
Issue: database/sql: surface `NamedArg` in the documentation of various Query funcs
Labels: Documentation,NeedsInvestigation

<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->

### What version of Go are you using (`go version`)?

<pre>
$ go version

go version go1.16 linux/amd64
</pre>

### Does this issue reproduce with the latest release?

Yes

### What operating system and processor architecture are you using (`go env`)?

Not relevant

### What did you do?

Used the `sql` package for years.

### What did you expect to see?

I would expect the documentation of funcs `sql`.{`Conn`, `DB`, `Stmt`, `Tx`}`.`{`Exec`, `ExecContext`, `Query`, `QueryContext`, `QueryRow`, `QueryRowContext`} to mention that the variadic argument `args ...interface{}` behaves specially when an element has type `sql.NamedArg`.

### What did you see instead?

In the absence of more details in the doc of these 24 funcs, I assumed that the variadic argument `args ...interface{}` was meant to accept only bare values for the formal parameters `?` in the query. 

The doc for `sql.NamedArg` and `sql.Named` does exist, but in years of usage of the `sql` package I had never stumbled upon them and was not aware that they can be valuable as arguments to the 24 funcs in the _Exec_ family.

So on the one hand, `interface{}` is not a self-descriptive type name for these things, and the type name is not really something we can fix here. On the other hand, the funcs documentation should mention that they _also_ accept special types like `sql.NamedArg`, `sql.NullString`, etc. that will be treated differently. This is something we can fix!
Repository: excalidraw
Issue: Reset the canvas doesn't work if the excalidraw is runned in the iframe.
Labels: enhancement,discussion

I am running excalidraw in the vscode iframe. When clicking on the "Reset the canvas" button the error is thrown in the console.
`Ignored call to 'confirm()'. The document is sandboxed, and the 'allow-modals' keyword is not set.`

It seems that I can't set this option 'allow-modals' in vs code iframe as correct approach would be for an embedded application to send message and for a vs code to show this modal.   

Maybe having something like`onResetCanvas` would solve this?
Repository: pytorch
Issue: add tests to cover DDP on mixed dense-sparse models
Labels: oncall: distributed,triaged,module: ddp

## 🚀 Feature
Add a tests to test_c10d.py to explicitly cover DDP on mixed dense-sparse models. 

## Motivation

Currently we have a sparse-only module: https://github.com/pytorch/pytorch/blob/c2c97cd290b81e8cba7022d90c16402d94eb4c4e/test/distributed/test_c10d.py#L2218-L2224

## Pitch

Add a mixed dense-sparse module and tests for the module to the test file.

## Alternatives

<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->

## Additional context

this is an onboarding task.


cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @agolynski @SciPioneer @H-Huang @mrzzd @cbalioglu
Repository: flutter
Issue: Run the framework tests in engine CI
Labels: a: tests,engine,P2,team-engine,triaged-engine

Right now we run some of the framework tests (flutter/flutter tests) on PRs for the engine repo. They run against the web engine specifically.

It would be good to extend this mechanism to also run these tests against the engines for Android, iOS, macOS, Windows, and Linux.

cc @yjbanov who can point to where the tests are run for the web engine.
Repository: godot
Issue: [Bullet] Bouncing vehicle loses velocity
Labels: bug,confirmed,topic:physics,topic:3d

**Godot version:**
3.2.3-stable


**OS/device including version:**
Linux

![image](https://user-images.githubusercontent.com/8739690/112060560-a3b99500-8b5d-11eb-917c-c57fe009afa2.png)

**Issue description:**
A bouncing VehicleBody looses its jump energy after a couple of jumps with dampening set to 0.

**Expected behaviour:**
The vehicle should keep bouncing indefinitely.


**Steps to reproduce:**
1. Open demo project
2. Run the project
3. Observe the vehicle jump and the wheels leave the ground
4. After ~16 jumps the vehicle doesn't have enough energy to leave the ground anymore

**Minimal reproduction project:**
[bouncy_demo.zip](https://github.com/godotengine/godot/files/6185348/bouncy_demo.zip)
Repository: deno
Issue: 🐛 `deno coverage` line and branch counts are incorrect
Labels: bug,testing

I'm getting some broken coverage results.

For the code:

```js
export function f(b: boolean) {
        var result;
        if (b) {
                result = true;
        } else {
                result = false;
        }
        return result;
}
```


as a Deno script (from the repo https://github.com/rivy-t/cover-deno):

```shell
C:>deno test --unstable -A --coverage=coverage && deno coverage --unstable coverage --lcov
...
SF:C:\Users\Roy\OneDrive\Projects\deno\dexter\repo.t-cover-deno\src\mod.ts
FN:2,f
FNDA:4,f
FNF:1
FNH:1
BRDA:4,1,0,2
BRF:1
BRH:1
DA:1,2
DA:2,6
DA:3,6
DA:4,8
DA:5,8
DA:6,8
DA:7,6
DA:8,6
DA:9,2
LH:9
LF:9
end_of_record
```

vs the same code as ESM, using nyc/ava (from https://github.com/rivy-t/cover-esm):

```shell
C:>npm i --silent && npx nyc --silent ava && npx nyc report --reporter=text-lcov
...
TN:
SF:src\esm.js
FN:1,f
FNF:1
FNH:1
FNDA:2,f
DA:3,2
DA:4,1
DA:6,1
DA:8,2
LF:4
LH:4
BRDA:3,0,0,1
BRDA:3,0,1,1
BRF:2
BRH:2
end_of_record
```

Specifically, the Deno branch coverage is incorrect; the line coverage has odd counts, off-by-one's, and, arguably, counts non-executing lines.
Repository: excalidraw
Issue: Show Text Selection across network
Labels: enhancement,discussion

I was just in a job interview using excalidraw and ran into the issue that, being a programmer I'm comfortable highlighting text by selecting it and was doing this out of habit to reference various things but it turns out my selection does not appear for the other user so they have no idea that I'm selecting different pieces of text to highlight what I'm talking about.

It would be nice if somehow my text selection highlighted for the other users

Here is what it looks like now

![N2V1ZZanjM](https://user-images.githubusercontent.com/234804/112073270-19058400-8bb7-11eb-8e57-0ed010769ea4.jpg)

On my side it feels like I'm being totally clear I'm talking about "Issue 2" as I've highlighted it but the other user doesn't see this highlight.
Repository: PowerToys
Issue: Per module theme selection
Labels: Idea-Enhancement,Area-User Interface

@crutkas @niels9001 
we should decide if we want more/all modules to have independent them selection.

Modules that have independent theme selection:

 - Settings app
 - PowerToys Run
 - Shortcut Guide

Modules that use the Windows default theme:
 
- Color Picker
- FancyZones Editor
- Image Resizer
- Keyboard Manager
- OOBE

Modules that currently don't support theming:

 - FancyZones
 - PowerRename

Modules that cannot have independent theming:

 - File Explorer add-ons
Repository: PowerToys
Issue: Allow any app to fullscreen (F11) which then will allow it to hide taskbar
Labels: Idea-New PowerToy

Hide taskbar when a window is in Maximization state and show taskbar when a window is not maximized. Similar feature available in LinuxMint.
Repository: flutter
Issue: Combine NavigationRailDestination and BottomNavigationBarItem.
Labels: framework,f: material design,c: proposal,team-design,triaged-design

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case

<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->
With the new [`NavigationRail`](https://api.flutter.dev/flutter/material/NavigationRail-class.html), we need to provide a `List<`[`NavigationRailDestination`](https://api.flutter.dev/flutter/material/NavigationRailDestination-class.html)`>`, and with [`BottomNavigationBar`](https://api.flutter.dev/flutter/material/BottomNavigationBar-class.html), we need to provide a `List<`[`BottomNavigationBarItem`](https://api.flutter.dev/flutter/widgets/BottomNavigationBarItem-class.html)`>`. 

This means that making an adaptive scaffold is difficult since we need to define our _own_ class, and convert them to the respective item type. 

## Proposal

<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching images showing what you are imagining.

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->
A new class, maybe called `NavigationItem`, that encompasses both and has all the required fields, as well as a `NavigationThemeData`:
```dart
class NavigationItem {
  Widget? activeIcon;  // BottomNavigationBarItem.activeIcon and NavigationRailDestination.selectedIcon
  Widget icon;  // BottomNavigationBarItem.icon and NavigationRailDestination.icon
  String? label;  // BottomNavigationBarItem.label and NavigationRailDestination.label
  String? tooltip;  // BottomNavigationBarItem.tooltip, NavigationRail implies this from [label]
  EdgeInsetsGeometry? padding;  // from NavigationRailDestination only
}

class NavigationThemeData { 
  Color? backgroundColor;  // BottomNavigationBarItem.backgroundColor and NavigationRailThemeData.backgroundColor
  // more theming from NavigationRailThemeData and BottomNavigationBar
}
```