sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: godot
Issue: Add comments why some code is disabled by false statement 
Labels: discussion,topic:core

**Godot version:**
3.2 master

**Issue description:**

- [ ] 1. https://github.com/godotengine/godot/blob/8591691b9b7be784606a367142b0b83ecd5975dd/scene/animation/animation_player.cpp#L317-L321

- [ ] 2. https://github.com/godotengine/godot/blob/b16c309f82c77d606472c3c721a1857e323a09e7/servers/audio/effects/audio_effect_compressor.cpp#L89-L93

- [ ] 3. https://github.com/godotengine/godot/blob/521aad3dca45ccc3d914fa3942bc929f4fb18c7d/editor/editor_file_system.cpp#L608-L612

- [ ] 4. https://github.com/godotengine/godot/blob/2935caa13f3623b80a903f8c3349cea48a417c00/scene/3d/baked_lightmap.cpp#L534-L538
Repository: pytorch
Issue: second derivatives of unfold
Labels: triaged,enhancement,module: derivatives

## 🚀 Feature

Backprop through backprop of `torch.nn.functional.unfold`.

## Motivation

I'm trying to research models where I need to use fancy convolutions (e.g. https://discuss.pytorch.org/t/locally-connected-layers/26979) and be able to take the gradient of the gradients. However, currently trying to do this produces

`RuntimeError: derivative for _thnn_im2col_backward is not implemented`

## Alternatives

A possible alternative in the meantime is to use for loops to perform im2col, but this is probably very inefficient.
Repository: pytorch
Issue: Handle all IntArrayRef expansions in ATen
Labels: module: nn,triaged,enhancement

See #22032 and #20866 for the rationale and #22073 for an example.
Repository: flutter
Issue: `flutter test --start-paused test/material/about_test.dart` will eventually time out
Labels: a: tests,team,tool,P2,c: flake,team-tool,triaged-tool

We should remove the timeout that checks that tests connect to the test harness. For example, just now I ran (in //flutter/packages/flutter):

```
flutter test --start-paused test/material/about_test.dart
```

...and then did something else for 6 minutes and when I got back to it, it had timed out, and I had to restart it. It should have just waited forever.
Repository: flutter
Issue: Enforce platform lifecycle in framework
Labels: platform-android,framework,engine,a: existing-apps,P2,team-android,triaged-android

Enforce platform lifecycle in framework.

Based on #35054 (which contains 2 different bugs), it looks like there may be a number of framework behaviors that do not respect the platform lifecycle. Namely, the platform goes to the "inactive" state, but the framework does not update its state accordingly.

Example 1: text input connection does not clear its client when the platform becomes inactive, but it looks like it should.

Examples 2: PageView page snapping animations pause when the app becomes inactive, but remains paused in that position when the app is resumed.

There may be numerous other places where lifecycle is not effectively considered.
Repository: pytorch
Issue: Box constraints for optimizers
Labels: feature,triaged

## 🚀 Feature

Offer the option to set box constraints for optimizers.

## Motivation

In some applications of reinforcement learning, falling outside of a region correspond to inadmissible actions.

## Alternatives

One can omit the constraints, and hope that the optimal parameters found happen to be within the constraints, without any guarantees.

## Additional context

This was suggested in #938 for torch.optim.lbfgs.

CC @bamos
Repository: godot
Issue: `obj` files are not showing in dependency fix file dialog
Labels: bug,topic:editor,confirmed

Godot 3.1.1
Windows 10 64 bits

I dropped an asset from another project into a new one so I could re-use it. That caused some paths to be wrong, so when I opened the scene Godot asked me to fix dependencies.
However, one of them is an `.obj` model but I wasn't able to pick it, even though it's shown in the file explorer:

![image](https://user-images.githubusercontent.com/1311555/60220818-494bb180-986f-11e9-8c04-199ff3008c9f.png)

And likely other asset types aren't shown given how reduced the extension filter is.

Repro:
[FixDependenciesMissesOBJ.zip](https://github.com/godotengine/godot/files/3332203/FixDependenciesMissesOBJ.zip)

Open `crate.tscn`.
Repository: TypeScript
Issue: Super call of non-method incorrectly allowed if target >= ES6
Labels: Bug

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the *entire* template below.
-->

From https://stackoverflow.com/questions/56775734/error-when-calling-super-method-in-a-typescript-create-react-app-project
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  3.6.0-dev.20190624

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- es5
- super
- arrow method

**Code**

```ts
class Foo {
    public bar = () => { }
}

class SubFoo extends Foo {
    public bar = () => { super.bar(); }
}
```

With `target: "es5"`

**Expected behavior:**
No errors. Call to `super` is allowed. 

**Actual behavior:**
See error on `super.bar()`
```
Only public and protected methods of the base class are accessible via the 'super' keyword.
```

Everything works fine using normal (non-arrow) methods. It also works with `"target": "es6"`

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->

**Related Issues:** <!-- Did you find other bugs that looked similar? -->
Repository: TypeScript
Issue: Support abstract mixin classes.
Labels: Suggestion,In Discussion

## Search Terms

Related, but not completely the same: https://github.com/microsoft/TypeScript/issues/29653

## Suggestion

Allow mixin classes to be abstract.

## Use Cases

For example, by using a mixin, it might require the user to implement a method.

## Examples

```ts
type Constructor<T = any, A extends any[] = any[]> = new (...a: A) => T

function AwesomeMixin<T extends Constructor>(Base: T = Object) {
    return abstract class Awesome extends Base {
        abstract someMethod(): number
    }
}
```

[playground link](http://www.typescriptlang.org/play/#code/C4TwDgpgBAwg9gOwM7AE4FcDGw6oDwAqUAvFAIYIgA0UAglBAB7AQIAmS5lA2gLolcQfAHwCEEAO5QAFADp5ZAFx0AlCVEEAsACgdAM3QJsAS0R0JEJHAC2EALLHGxhIQbNWHWIhQZsuYdIAQmRIEMoEagDeOlCxUKgQwOioCOQARj5k2FCYADYhnLQWVrZuLOycwaFQ0dpx9emZ2SX2iQAWcGzSKsoI6NZpEKgxcQC+OqNAA)

gives:

```
Cannot find name 'abstract'.
```

and

```
Unreachable code detected
```

## Checklist

My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Repository: flutter
Issue: Implement Paint.imageFilter for web
Labels: c: new feature,engine,platform-web,c: rendering,P3,a: gamedev,team-web,triaged-web

See also https://github.com/flutter/flutter/issues/35141 https://github.com/flutter/engine/pull/9508
Repository: godot
Issue: Children of GridContainer have same position as parent
Labels: enhancement,documentation

**Godot version:**
Tested in 3.1 and 3.1.1

**Issue description:**
<!-- What happened, and what was expected. -->
I'm using a GridContainer to arrange nodes in a grid. However, I want to get the world/global position of each child in that container. When I try to do that with get_global_position() I only get the position of their parent node i.e. the container.

The children of the container are TextureRects. TextureRect doesn't have a global_position or position property. You can access rect_position or rect_global_position from Control (which it inherits from), but as I mentioned, that only gives the position/global_position of the parent (i.e. GridContainer), not the position of the TextureRect itself.

I print out the rect_global_position of all children in the GridContainer node and it only gives the position of the GridContainer i.e. (50, 50). This is despite the fact that I can see the TextureRects are actually placed in a grid. I also tried printing rect_position, which just comes out as (0, 0) for all children.

What's really weird about this is if I inspect the nodes during runtime with the remote debug scene the actual values for those nodes' positions are correct.

Can I extract the global position for each child in a GridContainer? Could this be a bug, or am I just misunderstanding how Control and Container nodes work?

The scene tree is:

- Control (scene root)
  - GridContainer
    - TextureRect00
    - ...
    - TextureRect33

**Minimal reproduction project:**
[Control_Container_Bug.zip](https://github.com/godotengine/godot/files/3332813/Control_Container_Bug.zip)
Repository: flutter
Issue: Parent render objects that fail to layout children in perform layout fail too late
Labels: framework,c: rendering,P3,team-framework,triaged-framework

The docs on `performLayout` indicate that parents are _required_ to layout their children in this method, but there are no assertions checking it.

See https://github.com/flutter/flutter/pull/35110, specifically https://github.com/flutter/flutter/pull/35110/commits/4485cdf54cdb894c7fc3fa96ac7db7e85c3c0f7c

We'll catch this if semantics are enabled by default, but maybe there's some way to force render object parents to layout children, e.g. asserting in an `@mustCallSuper` that they've done so.
Repository: three.js
Issue: Feature Suggestion: Support Global Uniforms
Labels: Enhancement

I've been using the Line example in a recent project and I've found the `resolution` uniform on `LineMaterial` a bit difficult to work with. It's per-renderer-specific and must be maintained and updated on every LineMaterial if it changes. I know a [comment mentions that the renderer could eventually set it](https://github.com/mrdoob/three.js/blob/dev/examples/js/lines/LineMaterial.js#L11) but it seems like there could be a general solution to this type of issue.

I'm proposing adding a list of global uniforms to the WebGLRenderer that override a given uniform on all materials being rendered:

```js
renderer.uniforms = {
    resolution: {
        value: new Vector2()
    }
};
```

Other uniforms such as environment maps, time incrementing variables, adn lighting variables could benefit from this pattern, as well. Unity implements something similar using the [Shader.SetGlobalFloat()](https://docs.unity3d.com/ScriptReference/Shader.SetGlobalFloat.html) etc functions.

I think my big open questions in the API design would be:
- How can an individual Material _not_ be affected by a global uniform?
- What should happen if the shape of the uniform values does does not match (Vector3 on global value, Vector2 on material)?
Repository: godot
Issue: High GPU usage in editor with active AnimatedSprites
Labels: bug,topic:editor,confirmed

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
v3.1.1.stable.official


**OS/device including version:**
Windows 10 Pro 1903
Intel HD Graphics 530 (21.20.16.4550)
Nvidia GeForce GTX 960M (430.86)


**Issue description:**
Running Godot on the integrated Intel GPU

1.  I have a simple 2D Scene with some Sprite and one AnimatedSprite (3 frames looping at 5fps), every time I switch to that scene tab my GPU usage goes to 90%, if I disable the "Playing" checkbox of the AnimatedSprite, usage goes to 0%.
Also, if I go from the 2D mode to the Script mode GPU usage on that tab is still at 85%.

2. In Script mode, GPU usage is always between 15% and 25%.


Is that normal for an AnimatedSprite to use 90% of the GPU? 
Is it not possible to disable rendering when in Script mode?
Repository: opencv
Issue: cv2.error: OpenCV(4.1.0) /io/opencv/modules/core/src/persistence.cpp:2046: error: (-215:Assertion failed) isMap() in function 'operator[]'
Labels: category: contrib,needs investigation

![image](https://user-images.githubusercontent.com/42333539/60246163-bd7a6980-98f0-11e9-84dd-b5496d6b0105.png)
i got this error
Repository: godot
Issue: TreeItem add move up/down function
Labels: enhancement,topic:gui

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
<!-- Specify commit hash if non-official. -->
3.1

**Issue description:**
<!-- What happened, and what was expected. -->
Right now TreeItem implements move_to_top() and move_to_bottom() to move the item to the first or last position among its siblings.

I would like the ability to move an Item by an arbitrary amount. I am currently building a modding system ala skyrim, and need to ability to move tree items to arbitrary positions in the list.
Repository: rust
Issue: match guard is lengthening borrow unexpectedly under NLL
Labels: T-compiler,A-NLL,C-bug,NLL-complete,NLL-polonius

Spawned off of  #60914, namely the [regression][cs_review regression] of the [cs_review crate][]

[cs_review regression]: https://crater-reports.s3.amazonaws.com/pr-60914/try%23f45cc3094ee337acd688771b9234318046b0572d/gh/198d.cs_review/log.txt
[cs_review crate]: https://github.com/198d/cs_review

I was looking for examples of soundness issues fixed by NLL for a blog post that I'm working on, and the first crate I looked at stymied me.

Maybe I'm forgetting something crucial, but I would think we might be able to accept this code ([play](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2015&gist=e7323ca65897ebe873e8154a70457dcc)):

```rust
struct Node(String, Option<Box<Node>>, Option<Box<Node>>);

fn main() {
    let mut data = Some(Box::new(Node("input1".to_string(), None, None)));
    let mut input1 = &mut data;
    loop {
        match {input1} { // the `{ }` fool AST-borrowck into accepting w/o NLL
            
            &mut Some(ref mut n) if {true} => { input1 = &mut n.1; }
        //            ~~~~~~~~~  ~~~~~~~~~ combo of 1. borrow, 2. guard, ... 

            _other => { break; }
        //  ~~~~~~                         ... and 3. move cause NLL to reject

        // Why does guard cause borrow last longer than it would otherwise here?
        }
    }
}
```

Note: I don't think we're going to hit this "regression" too often, because it critically depends on some bug in AST-borrowck where I believe AST-borrowck mishandled `{ ... }` around the match input. Since I do not think that is a common pattern in match inputs, we probably can get away with not addressing this for a while.
Repository: rust
Issue: Incorrect unused lifetime warning after import failure
Labels: A-lints,A-lifetimes,T-compiler,C-bug,E-needs-mcve

When building [this commit](https://github.com/RalfJung/rust/commit/9b317bad57f48cf18a921e0655ab05e59fc19c4d) with `./x.py build --stage 0 src/librustc_mir`, I get the following output:
```
error[E0432]: unresolved import `crate::interpret::InterpretCx`
  --> src/librustc_mir/const_eval.rs:25:59
   |
25 |     InterpResult, InterpErrorInfo, InterpError, GlobalId, InterpretCx, StackPopCleanup,
   |                                                           ^^^^^^^^^^^
   |                                                           |
   |                                                           no `InterpretCx` in `interpret`
   |                                                           help: a similar name exists in the module: `InterpCx`

error[E0432]: unresolved import `crate::interpret::InterpretCx`
  --> src/librustc_mir/transform/const_prop.rs:26:11
   |
26 |     self, InterpretCx, ScalarMaybeUndef, Immediate, OpTy,
   |           ^^^^^^^^^^^
   |           |
   |           no `InterpretCx` in `interpret`
   |           help: a similar name exists in the module: `InterpCx`

error[E0392]: parameter `'mir` is never used
  --> src/librustc_mir/interpret/intern.rs:23:27
   |
23 | struct InternVisitor<'rt, 'mir, 'tcx> {
   |                           ^^^^ unused parameter
   |
   = help: consider removing `'mir` or using a marker such as `std::marker::PhantomData`

error: aborting due to 3 previous errors
```
The first two are expected, that's a mistake I made. The last one is wrong though, `'mir` is used:
```rust
struct InternVisitor<'rt, 'mir, 'tcx> {
    /// previously encountered safe references
    ref_tracking: &'rt mut RefTracking<(MPlaceTy<'tcx>, Mutability, InternMode)>,
    ecx: &'rt mut CompileTimeEvalContext<'mir, 'tcx>, // <-- used here!
    /* ... */
}
```
The thing is, it gets used as argument to `CompileTimeEvalContext`, which is defined in `const_eval.rs`, which had an import failure.

So it looks like the "unused lifetime" lint is a bit too aggressive here and considers a lifetime unused because the way it got used referred to a type that was in a failing module -- or so. I tried to minimize this but failed, [here's my last attempt](https://play.rust-lang.org/?version=beta&mode=debug&edition=2018&gist=4f36d638f5b8b39c215b6c2f4c9164a1). But anyway I think this is a bug -- we want the user to look at the actual failure, not at spurious warnings that were caused by the failure.
Repository: kubernetes
Issue: [Tracking Issue] Pain points in using OpenAPIv2 schema 
Labels: sig/api-machinery,kind/feature,lifecycle/frozen

/kind feature
/sig api-machinery

@sttts @roycaihw @kubernetes/sig-api-machinery-misc 

- Multi-types support:
  - (https://github.com/kubernetes-client/java/issues/86) Delete calls returns actual objects in the response (e.g. when there's remaining finalizers) while the v2 spec says it's returning a status object.
  - (https://github.com/kubernetes-client/python/issues/322, https://github.com/kubernetes/kubernetes/issues/62329) IntOrString cannot be correctly described in the v2 spec.
- Enum support
  - (https://github.com/kubernetes/kubernetes/issues/60937#issuecomment-394487896) The v2 spec doesn't say about the allowed values for fields like ImagePullPolicy.
- Model inheritance
  - make `metav1.TypeMeta` or `metav1.Object` a parent model for the openapi clients
Repository: TypeScript
Issue: Result of `Object.create(null)` may be passed to template literal
Labels: Suggestion,Awaiting More Feedback

**TypeScript Version:**  3.5.1

**Search Terms:** template string, template literal, Object.create(null)

**Code**

```ts
`${Object.create(null)}`
```

**Expected behavior:** `TypeError`, as the object passed to the template string has no `toString` method in the prototype chain (as it has no prototype chain at all).

**Actual behavior:** Everything goes well in the compiler, but JavaScript reports runtime error (ex. `TypeError: Cannot convert object to primitive value` in Chrome).

**Playground Link:** https://www.typescriptlang.org/play/index.html#code/AYEg3g8gRgVgpgYwC4DoECc4EMlwBQB2ArgDYkCUAvsEA

**Related Issues:**
https://github.com/microsoft/TypeScript/issues/30239
https://github.com/microsoft/TypeScript/issues/1108
Repository: flutter
Issue: `TextField` should receive the callbacks from `TextSelectionGestureDetector`
Labels: a: text input,c: new feature,framework,f: material design,P3,team-design,triaged-design

Currently, the `TextField` only receives the callback `onTap`, which is called after the `_TextFieldState` handles `onSingleTapUp` from its `TextSelectionGestureDetector`. The lack of other callbacks bothers, though.

Besides supporting all the callbacks from `TextSelectionGestureDetector`, the details (e.g. `TapDownDetails`) should also be forwarded, which is not the case with the currently implemented `onTap` callback.
Repository: go
Issue: x/tools/go/analysis/passes/nilness: detect wrapping of nil errors
Labels: NeedsInvestigation,Tools,Analysis

As of `4874f863`, the `nilness` check doesn't seem to trigger on `fmt.Errorf` calls with an error that is proven nil. Example:

```go
func f() error {
	exists, err := g()
	if err != nil {
		return errors.Wrap(err, "error1")
	}

	if !exists {
		return fmt.Errorf("nothing: %w", err)
	}

	return nil
}
```

Same with the `%v` verb. I feel like most people would not want to actually produce a `nothing: <nil>` or a `nothing: %!w(<nil>)` message here.

Inspired by https://github.com/dominikh/go-tools/issues/529.
Repository: rust
Issue: Self::call constrains lifetime covariance and/or inference unexpectedly under NLL
Labels: T-compiler,A-NLL

Spawned off of #60914, namely the [regression][vc regression] of the version-compare crate

[vc regression]: https://crater-reports.s3.amazonaws.com/pr-60914/try%23f45cc3094ee337acd688771b9234318046b0572d/gh/timvisee.version-compare/log.txt

Look at this ([play](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=fd8854c0740e05659404819920bd0474)):

```rust
use std::slice::Iter;

pub struct Version<'a> {
    parts: Vec<&'a str>,
}

impl<'a> Version<'a> {
    pub fn compare(&self, other: &Version) {
        Self::compare_iter(self.parts.iter(),  other.parts.iter())
    }
    
    fn compare_iter(_: Iter<&'a str>, _: Iter<&'a str>) { }
}
```

we get an NLL migration error for it.
 * (The use of `Self::compare_iter` is important on line 9; if you replace that with `Version::compare_iter`, then NLL will accept the input.)
 * ((Likewise, the input is accepted if you get rid of the `'a`'s in the formal parameters to `fn compare_iter`, but that is perhaps less surprising.))

Why? I'm not sure; at first I thought it made sense, since I assumed that the call to `Self::compare_iter` would force the two arguments to have the same lifetime `'a` that is also attached to the `self` parameter.

But after reflecting on the matter further, I do not understand why we would not have a reborrow here that would allow the call to `compare_iter` to use a shorter lifetime that both inputs can satisfy.
 * (Or, wait: Is `std::slice::Iter<T>` not covariant with respect to `T`? I guess I'll need to check that.)

Anyway, this is either a soundness fix of AST borrow-check (which would be great news), or it is an NLL-complete bug for MIR borrow-check.

I just didn't want it to get lost in the shuffle of a blog post I am currently working on.
Repository: flutter
Issue: PageController properties should be more developer-friendly
Labels: framework,d: api docs,c: proposal,P2,team-framework,triaged-framework

In https://github.com/flutter/flutter/issues/32639, the developer was having a difficult time trying to configure PageController to their own use case, as PageController.page is difficult to use without diving into its implementation details. 

Hence, we should probably improve the PageController API to be more usable by developers and have improved documentation to help. At the very least, `PageController.page` can have improved instructions/documentation.