Repository: pytorch
Issue: _register_as_effectful_op_temporarily in torch/_ops.py appears to remove any previously registered effects
Labels: triaged,module: custom-operators,oncall: pt2,module: higher order operators,module: pt2-dispatcher

### 🐛 Describe the bug

I don't have simple reproduction steps for this problem but I'm trying to use a C++ custom op with a custom C++ class type argument (`torch._C.ScriptObject`) with the inductor.

I run into this assert initially:
```
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <torch._higher_order_ops.effects.WithEffects object at 0x73dffa0f3bb0>
token = FakeTensor(..., size=(0,), dtype=torch.bool), op = <OpOverload(op='_C.gptq_marlin_24_gemm', overload='default')>
args = (FakeTensor(..., device='cuda:0', size=(1, 128), dtype=torch.float16), FakeTensor(..., device='cuda:0', size=(4, 1024)..., size=(256,), dtype=torch.int32), <torch._library.fake_class_registry.FakeScriptObject object at 0x73dfd8cbda50>, ...)
kwargs = {}

    def __call__(
        self,
        token,
        op: OpType,
        *args: Tuple[Any, ...],
        **kwargs: Dict[str, Any],
    ) -> Tuple[Any, ...]:
        assert isinstance(op, (torch._ops.HigherOrderOperator, torch._ops.OpOverload))
        assert not has_aliasing(op), "Ops with aliasing is not supported"
>       assert has_effects(op, args, kwargs)
E       AssertionError: While executing %with_effects : [num_users=2] = call_function[target=torch.ops.higher_order.with_effects](args = (%_make_token_default, _C.gptq_marlin_24_gemm.default, %arg1_1, %arg6_1, %arg5_1, %arg4_1, %arg3_1, %arg2_1, 1, 512, 128), kwargs = {})
E       Original traceback:
E         File "/home/bnell/nm-vllm-new/tests/kernels/test_marlin_gemm.py", line 267, in marlin_24_gemm_tester
E           return ops.gptq_marlin_24_gemm(
E         File "/home/bnell/nm-vllm-new/vllm/_custom_ops.py", line 34, in wrapper
E           return fn(*args, **kwargs)
E         File "/home/bnell/nm-vllm-new/vllm/_custom_ops.py", line 297, in gptq_marlin_24_gemm
E           return torch.ops._C.gptq_marlin_24_gemm(a, b_q_weight, b_meta, b_scales,

../pt24/lib/python3.10/site-packages/torch/_higher_order_ops/effects.py:80: AssertionError
```

While debugging, I noticed that `has_effects()` returns `True` for this op until `_register_as_effectful_op_temporarily` is called on it at some point.  It also appears calling `has_effects()` can modify `SIDE_EFFECTS` via `get_effect_key()`.

Looking at the code for that function, it looks like it always removes op from the `SIDE_EFFECTS` dict even if it might have been in there before calling `_register_as_effectful_op_temporarily`.  If I hack `_register_as_effectful_op_temporarily` to keep pre-existing entries in the `SIDE_EFFECTS` dict I get past the error above and die later on in the inductor.

```
    @contextlib.contextmanager
    def _register_as_effectful_op_temporarily(self):
        from torch._higher_order_ops.effects import (
            _EffectType,
            _register_effectful_op,
            SIDE_EFFECTS,
        )

        try:
            if self not in SIDE_EFFECTS:
                _register_effectful_op(self, _EffectType.ORDERED)
            yield
        finally:
            if self in SIDE_EFFECTS:    <--- this seems to delete self even if it was registered already?
                del SIDE_EFFECTS[self]
```

cc @ezyang @chauhang @penguinwu @zou3519 @ydwu4 @bdhirsh @yf225 @laithsakka , @zou3519 

### Versions

Collecting environment information...
PyTorch version: 2.5.0+cu124
Is debug build: False
CUDA used to build PyTorch: 12.4
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.4 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.30.1
Libc version: glibc-2.35

Python version: 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-6.5.0-35-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.5.82
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA H100 80GB HBM3
GPU 1: NVIDIA H100 80GB HBM3
GPU 2: NVIDIA H100 80GB HBM3
GPU 3: NVIDIA H100 80GB HBM3
GPU 4: NVIDIA H100 80GB HBM3
GPU 5: NVIDIA H100 80GB HBM3
GPU 6: NVIDIA H100 80GB HBM3
GPU 7: NVIDIA H100 80GB HBM3

Nvidia driver version: 555.42.02
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 57 bits virtual
Byte Order: Little Endian
CPU(s): 128
On-line CPU(s) list: 0-127
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8462Y+
CPU family: 6
Model: 143
Thread(s) per core: 2
Core(s) per socket: 32
Socket(s): 2
Stepping: 8
CPU max MHz: 4100.0000
CPU min MHz: 800.0000
BogoMIPS: 5600.00
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cat_l2 cdp_l3 invpcid_single intel_ppin cdp_l2 ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local split_lock_detect avx_vnni avx512_bf16 wbnoinvd dtherm ida arat pln pts hfi vnmi avx512vbmi umip pku ospke waitpkg avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq la57 rdpid bus_lock_detect cldemote movdiri movdir64b enqcmd fsrm md_clear serialize tsxldtrk pconfig arch_lbr ibt amx_bf16 avx512_fp16 amx_tile amx_int8 flush_l1d arch_capabilities
Virtualization: VT-x
L1d cache: 3 MiB (64 instances)
L1i cache: 2 MiB (64 instances)
L2 cache: 128 MiB (64 instances)
L3 cache: 120 MiB (2 instances)
NUMA node(s): 2
NUMA node0 CPU(s): 0-31,64-95
NUMA node1 CPU(s): 32-63,96-127
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Enhanced / Automatic IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI BHI_DIS_S
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Versions of relevant libraries:
[pip3] flashinfer==0.0.9+cu121torch2.3
[pip3] mypy==1.9.0
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.4
[pip3] onnx==1.14.1
[pip3] onnxruntime==1.18.1
[pip3] pytorch-triton==3.1.0+5fe38ffd73
[pip3] torch==2.5.0+cu124
[pip3] torchaudio==2.5.0.dev20240919+cu121
[pip3] torchvision==0.20.0.dev20240919+cu121
[pip3] triton==3.0.0
[conda] Could not collect