sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: node
Issue: Undeprecate _stream_wrap
Labels: stream

**Is your feature request related to a problem? Please describe.**

_stream_wrap was [recently deprecated](https://github.com/nodejs/node/pull/26245) because it "doesn't have a reasonable use outside of node".

I think I have two reasonable use cases, and I'd really like this to be undeprecated. As far as I can tell it's going to exist internally anyway, since the underlying [JSStreamSocket](https://github.com/nodejs/node/blob/master/lib/internal/js_stream_socket.js) implementation is actively used by TLSSocket, it works perfectly, and it already supports my use cases, so this is purely a question of whether it should be accessible externally.

My use cases:

1. I'm trying to sniff packets to detect HTTP/2 before the http2 server takes over, as described in #17132 (in my case: because I want to support HTTP/1, HTTP/2, HTTPS/1 and HTTPS/2 all on the same port). As described in that issue that's not normally possible, understandably, because sockets are tightly integrated with the stream internals in a way that disallows these kinds of interactions, and changing that has performance implications for the common case. However, this is possible if you provide some psuedo-socket, backed by a separate stream, such as `_stream_wrap`.

    There are other users with this use case, including the original author of that issue, and every user of [httpolyglot](https://www.npmjs.com/package/httpolyglot), which does this for HTTP/1 (but which can't HTTP/2 using the native http2 module because of this issue). Issues like #20999 exist because this isn't available, so people have to implement it externally for themselves.

2. I'm trying to tunnel HTTP connections through a stream (in this case, an Http2Stream). I'm building a mitm proxy, which accepts h2 CONNECT requests and then locally handles them. That means after the CONNECT I get an h2 stream, which I need to treat as a fresh net.Socket connection. `_stream_wrap` does this perfectly.

    This is less common, afaik, but it's an example of wanting the networking APIs to be generally more composeable, so that socket-based code can fully interoperate with streams or stream transformations.

**Describe the solution you'd like**

Make `_stream_wrap` a public API again, removing the deprecations.

Maybe even remove the underscore too, and make it a 1st class API with docs etc?

**Describe alternatives you've considered**

The alternative I can see is to reimplement `_stream_wrap` from scratch externally.

That's not really straightforward, as implementation here requires native code (https://github.com/nodejs/node/blob/master/src/js_stream.cc), which I'd also need to duplicate, and my pipeline to usefully build & distribute all this ends up being pretty complicated, especially to get it working across node versions. 

It would also be far less reliable (I'd much rather use the real & well-maintained version of this, especially since it touches lots of node internals), and it's annoying to have to do all this when a fully working implementation is shipping within node anyway.
Repository: godot
Issue: Option button giving false item count C#
Labels: topic:dotnet,topic:gui

3.2.2

I have created an OptionButton and added 3 items in the editor.
I run the program and us a FOR loop to change the text of each item.
I will get the following 12 errors:

```
E 0:00:16.906   get_item_text: Index p_idx = 3 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 4 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 5 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 6 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 7 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 8 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 9 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 10 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 11 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 12 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 13 is out of bounds (items.size() = 3).
E 0:00:16.906   get_item_text: Index p_idx = 14 is out of bounds (items.size() = 3).
```

When I check what the extra items are, it gives me the other properties of each item.  For instance, it is counting the item ID and the Enabled property as individual items
Repository: opencv
Issue: Stitcher generates panorama smaller than input
Labels: category: stitching,needs reproducer

OpenCV 4.3.0

I am currently trying the OpenCV Stitcher on very degraded images just to check for the limits of mosaicing.
For the algorithm not to hang, I have to set the bundleAdjuster to NoBundleAdjuster,

I also set WaveCorrection to false because it is not a linear travelling

Is it expected behaviour that the pano of two images can be smaller than input ?
For two 640x480 images, the resulting pano is 279x257. (with status being OK, not an error like ERR_NEED_MORE_IMGS)

Since the compositionResol is at -1 (ORIG_RESOL), I do not understand how it can happen.

Is there anything else to tune to force the resulting pano to be at least the size of the largest input ?

[edit]
The two images are almost identical (the camera did not move yet, only lighting and noise changed a little)
I tried with different bundle adjusters, and still the same : the pano is smaller, while it should have matched the two images almost perfectly
Repository: go
Issue: x/build/cmd/gopherbot, x/build/maintner: "close stale WaitingForInfo" task failing on non-existing issue
Labels: Builders,NeedsInvestigation

From `gopherbot` logs:

```
2020/07/10 13:33:30 close stale WaitingForInfo: POST https://api.github.com/repos/golang/go/issues/39453/comments: 422 Validation Failed [{Resource:IssueComment Field:data Code:unprocessable Message:Could not resolve to a node with the global id of 'MDU6SXNzdWU2MzM4NzY4NTM='.}]
2020/07/10 13:33:30 gopherbot ran in 9.88987365s
```

Issue https://github.com/golang/go/issues/39453 is 404. `gopherbot` should handle this situation as a non-error. Treating it as an error adds an unnecessary sleep:

```
2020/07/10 13:33:30 sleeping 30s after previous error.
```

It's possible this is a bug or unexpected behavior on the GitHub API side (might be worth reporting it to them), but if it persists, we should just update `gopherbot` to handle it.

It's also worth investigating if this is an issue that can and is better to fix in maintner, rather than gopherbot.

/cc @golang/osp-team
Repository: opencv
Issue: opencv build error, could NOT find python2. Is this something I should be worried about?
Labels: category: build/install,future

- OpenCV = latest version
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2019
--
Compiled opencv with cmake, is this error something to worry about, or can I ignore it?
Help Required
I downloaded opencv today from the master brand and I am using python 3.7.7. I have cmake 3.18.0 and I am on windows 10. I got this error after building opencv:

CMake Warning at cmake/OpenCVDetectPython.cmake:81 (message):
CMake's 'find_host_package(PythonInterp 2.7)' found wrong Python version:

PYTHON_EXECUTABLE=C:/Python37/python.exe

PYTHON_VERSION_STRING=3.7.7

Consider providing the 'PYTHON2_EXECUTABLE' variable via CMake command line
or environment variables

Call Stack (most recent call first):
cmake/OpenCVDetectPython.cmake:271 (find_python)
CMakeLists.txt:599 (include)

Could NOT find Python2 (missing: Python2_EXECUTABLE Interpreter)

Reason given by package:

Interpreter: Wrong major version for the interpreter "C:/Python37/python.exe"

Do I have to use a different version of python? I plan on using opencv with the darknet framework/yolov4.
Repository: pytorch
Issue: Add nn.functional.swish alias for nn.functional.silu
Labels: module: nn,triaged

SiLU activation function added here https://github.com/pytorch/pytorch/pull/41034 is also known as Swish (see https://github.com/pytorch/pytorch/pull/41034#issuecomment-654496698 for a discussion about it).

To help users find the function we should add an alias for SiLU by the name of Swish once the aliasing system @mruberry is working on is complete.

cc @albanD @mruberry
Repository: rust
Issue: rustdoc generates broken "Read more" links when the destination crate doesn't have a URL
Labels: T-rustdoc,C-bug,A-cross-crate-reexports,A-rustdoc-ui

I tried this code:

`foo.rs`:

```rust
#![crate_type = "rlib"]
pub struct FooStruct;
pub trait FooTrait {
    /// docs
    ///
    /// more docs
    fn foo_method();
}
impl FooTrait for FooStruct {
    fn foo_method() {}
}
```

`bar.rs`:

```rust
extern crate foo;
pub use foo::FooStruct;
```

running `rustc foo.rs && rustdoc -L . bar.rs` so only `bar` is documented.

I expected to see this happen:

When the docs for `bar` are documented the page for `FooStruct` shouldn't contain any broken "Read more" links.

Instead, this happened:

The "Read more" link for `foo_method` on the page for `FooStruct` points to `#tymethod.foo_method` which doesn't go anywhere. It should point to the documentation for `FooTrait` but as that page doesn't exist the "Read more" link shouldn't exist at all. The link works fine if docs for `foo` are also generated or `pub use foo::FooTrait;` is added to `bar.rs`.

### Meta

`rustc --version --verbose`:
```
rustc 1.46.0-nightly (5db778aff 2020-07-09)
binary: rustc
commit-hash: 5db778affee7c6600c8e7a177c48282dab3f6292
commit-date: 2020-07-09
host: x86_64-pc-windows-msvc
release: 1.46.0-nightly
LLVM version: 10.0
```
Repository: flutter
Issue: [flutter_tools] IDE plugin validators should be deprecated
Labels: tool,c: proposal,P2,team-tool,triaged-tool

Supporting the filepaths to the android studio plugins is a moving target, that has proven difficult to keep up to date. In addition, the warning makes Flutter users think that the SDK will not function properly, when this is a completely informational warning; in other words, **Flutter does not directly use the IDE plugins, so doctor failing to detect them does not affect any behavior** (it's just annoying).
Repository: excalidraw
Issue: It's not clear that the Library auto-expands or that a placeholder is empty
Labels: enhancement

(1) If I open the library initially, nothing indicates that there isn't a component to re-use. Perhaps hide empty ones while nothing is selected? If it's completely empty, it's good to keep a single placeholder with a flashing + button, perhaps with a tooltip.

![image](https://user-images.githubusercontent.com/620099/87183966-1ecf6980-c2b5-11ea-8aaf-7115b645468d.png)

(2) After adding three elements, it's unclear that the library will auto-expand if I selected another element:

![image](https://user-images.githubusercontent.com/620099/87184059-4de5db00-c2b5-11ea-971f-acc253dfb94e.png)


It could be covered by always showing one empty placeholder with a visible + button, at least after adding Nth element while the Library is still open.

Thanks!
Repository: vscode
Issue: Open remote settings GUI when extension executes workbench.action.openSettings with query in remote session
Labels: feature-request,settings-editor,confirmation-pending

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.47.0
- OS Version: Windows_NT x64 10.0.18363

Steps to Reproduce:

I work on the Python extension. Currently, in a remote session, the 'Preferences: Open Settings (UI)' command correctly opens the settings GUI with the Remote setting tab selected.

However, in a remote session (WSL and Remote-SSH), `vscode.commands.executeCommand('workbench.action.openSettings', 'query string')` opens the GUI with the User tab, instead of the Remote setting tab, selected. This behavior is unexpected for the user, as described here: https://github.com/microsoft/vscode-python/issues/12862.

Our use case is that we'd like to direct the user to a filtered view of the settings GUI, as described in #84355, which happens when a query string is provided with `workbench.action.openSettings`. It would be great if `workbench.action.openSettings` could detect that it's being executed in a remote environment and open the GUI with the Remote settings tab selected as well.
Repository: vscode
Issue: encodedSemanticClassifications-full does not request cancellation when completions are requested
Labels: typescript,javascript,debt,perf,keep

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version:
- OS Version:

Steps to Reproduce:

1.
2.

<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No

Found this while investigating https://github.com/microsoft/TypeScript/issues/35364 which turns out that semantic colorization takes approximately 10s but completions are quick with or without that request but seem to take longer as colorization is not cancelled.
Repository: go
Issue: path/filepath: clarify VolumeName returns a path not a name
Labels: NeedsInvestigation

### What version of Go are you using (`go version`)?

<pre>
$ go version
1..14.4
</pre>

### Does this issue reproduce with the latest release?
Yes.

### What operating system and processor architecture are you using (`go env`)?
Operating system and architecture independent.

### What did you do?
Read the docs.

### What did you expect to see?
```
func VolumeRoot(path string) string
```
or something similar that reflects what `VolumeName` actually returns.

-or-

Documentation to the effect that `VolumeName` in fact returns a volume name.

A volume name on Windows is also known as a volume label.

### What did you see instead?
The function certainly does not return a volume name, hence either the name or its behavior and documentation are wrong.

Having `VolumeName("C:\A")` return "C:" is confusing and inconsistent. It could also be considered wrong, since "C:" is a relative path which would resolve to `%CD%` or `C:.` and `Abs` is also documented to never return `C:` for probably this reason. However this issue is about the function returning a path, not a name, as one would not be overly unjustified expect.
Repository: go
Issue: x/crypto/acme: Retry on LetsEncrypt rate limit
Labels: NeedsInvestigation

### What version of Go are you using?
<pre>
go version go1.14 darwin/amd64
</pre>

### What did you do?
I called `acme.Client.AuthorizeOrder` when the renewal rate limit for the desired domain has been exceeded.

See: https://letsencrypt.org/docs/rate-limits/

### What did you expect to see?
I expected the call to fail quickly and return the rate limit error. There is no value in retrying for a rate limit failure.

### What did you see instead?
The acme HTTP client code will retry for 429 errors.

<pre>
acme/http.go

func isRetriable(code int) bool {
	return code <= 399 || code >= 500 || code == http.StatusTooManyRequests
}
</pre>

 In the case of a LetsEncrypt rate violation LetsEncrypt returns 429. For example:

<pre>
429 urn:ietf:params:acme:error:rateLimited: Error creating new order :: too many certificates already issued for exact set of domains: example.com: see https://letsencrypt.org/docs/rate-limits/
</pre>


This results in the retry code executing until the context timeout is reached. If the context has no timeout then the code will make calls to LetsEncrypt forever.
Repository: terminal
Issue: New icons for UI elements
Labels: Issue-Feature,Area-UserInterface,Product-Terminal

<!-- 
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed!
-->

# Description of the new feature/enhancement
We need some new iconography for some of our UI elements, specifically the command palette and settings UI. Below are the requested icons:

| Command / Title | Icon proposal |
| --------------- | ------------- |
| Launch (SUI)    | Rocket ship   |
| Split horizontally | Window with horizontal pane split |
| Split vertically | Window with vertical pane split |

<!-- 
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->

# Proposed technical implementation details (optional)

<!-- 
A clear and concise description of what you want to happen.
-->
Repository: pytorch
Issue: [docs] Strange arg names of torch.bmm/mm and tensor.bmm/mm
Labels: module: docs,triaged,enhancement

https://pytorch.org/docs/master/generated/torch.bmm.html#torch.bmm:
`torch.bmm(input, mat2, deterministic=False, out=None) → Tensor`

`mat2` is quite strange

https://pytorch.org/docs/master/tensors.html?highlight=bmm#torch.Tensor.bmm:
`bmm(batch2) → Tensor`

`batch2` is strange as well (and does not even match torch.bmm)

It seems that it's a remnant of torch.addbmm, there batch1/batch2 make more sense. But combinations input/mat2 and self/batch2 don't make much sense

Same for torch.mm/tensor.mm

cc @jlin27
Repository: pytorch
Issue: add a reparameterized version of inverse Gaussian distribution
Labels: module: distributions,triaged,enhancement

## 🚀 Feature
<!-- A clear and concise description of the feature proposal -->
Like the gamma distribution, the inverse Gaussian distribution is also implicitly re-parameterizable.
 

## Motivation
This distribution can be used in variational inference such as Pyro. Moreover, inverse Gaussian is usually more numerically stable than gamma.

<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->

## Pitch

<!-- A clear and concise description of what you want to happen. -->
The `autograd` implementation including some test cases is available at `https://github.com/yorkerlin/iBayesLRule/blob/master/inverse_gauss/inv_gauss_sampler.py`

The writeup can be found at
Appendix H.1 (page 27) of `https://arxiv.org/pdf/2002.10060.pdf` (to appear at ICML 2020)

An efficient natural-gradient variational inference for mixture of full Gaussians (MoG) is also discussed in our paper. 

@fritzo 

## Alternatives

<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->

## Additional context

<!-- Add any other context or screenshots about the feature request here. -->


cc @vincentqb @fritzo @neerajprad @alicanb @vishwakftw
Repository: pytorch
Issue: List[Any] support in TorchScript
Labels: high priority,triage review,oncall: jit,weeks

Forwarded from internal post

> Why is returning [1] for List[Any] not ok, while returning 1 for Any is fine?

```
To work around this, I had to use
        untyped_output: List[Any] = []
        for i in range(self.output_size):
            untyped_output.append(output[i])
```

cc @ezyang @gchanan @zou3519 @suo @gmagogsfm
Repository: pytorch
Issue: Return list of tuples from custom operator
Labels: oncall: jit

Forwarded from internal post

> Not having the ability to return List<Tuple<something, something>> from a custom operator means we have to return Tuple<List<something>, List<something>>, and convert on the torchscript side, which I think is expensive. Whereas, if we could just return the list of tuples, we could directly just use the result.

Adding a custom operator that returns a list of tuples is not supported. I'm using c10::List<std::tuple<at::Tensor, at::Tensor>> and getting Tried to use undefined class as output.

There is a workaround, namely returning a tuple of two lists.

cc @suo @gmagogsfm
Repository: rust
Issue: Array of tuples containing functions trip on type inference?
Labels: T-compiler,A-inference,C-bug

<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->

Consider the following code:

```rust
fn foo(_s: &mut [u8]) {}

fn bar(_s: &mut [u8]) {}

fn main() {
    let _works = [foo, bar];
    //let _doesnt_work = [(foo,), (bar,)];
    let _explicit_works: [(fn(&mut[u8]),);2] = [(foo,), (bar,)];
}
```

I expected the second assignment to be equivalent to the third.

Instead, compilation fails with:
```
error[E0308]: mismatched types
 --> src/main.rs:7:34
  |
7 |     let _doesnt_work = [(foo,), (bar,)];
  |                                  ^^^ expected fn item, found a different fn item
  |
  = note: expected fn item `for<'r> fn(&'r mut [u8]) {foo}`
             found fn item `for<'r> fn(&'r mut [u8]) {bar}`
```

Nightly has a better error message:
```
  = note: expected fn item `for<'r> fn(&'r mut [u8]) {foo}`
             found fn item `for<'r> fn(&'r mut [u8]) {bar}`
  = note: different `fn` items always have unique types, even if their signatures are the same
  = help: change the expected type to be function pointer `for<'r> fn(&'r mut [u8])`
  = help: if the expected type is due to type inference, cast the expected `fn` to a function pointer: `foo as for<'r> fn(&'r mut [u8])`
```

But with that clarification, I'd actually expect the first assignement to fail with the same error, but it doesn't.