sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: x/tools/cmd/stringer: replicate build tags in output file
Labels: NeedsDecision,FeatureRequest,Tools

We use stringer in some platform-specific code. In order to keep the code compiling, we need the code that stringer outputs to be protected by a build tag.

I propose that `stringer` replicates into its output any build tags present in the file in which the type is defined. The type will only be defined when those build tags are present, so not doing this replication generates broken code.

We are currently manually editing the code after generation, which breaks our attempt to have CI check that go generate has been run. We put in this CI check after failure to run `go generate` caused bugs. Alas, not all code generation is amenable to [tricks making such a CI check unnecessary](https://commaok.xyz/post/safer-generated-code/).

Alternatives to this suggestion:

* Add a `-header` flag that accepts text to be used. (Maybe also a `-headerfile` flag?) This would be useful for build tags as well as license header injection, but it requires manual maintenance.
* Write a separate utility to inject headers. `go generate` doesn't define the order in which the generate commands run, and `go generate` supports running only a subset of generation commands, so for best effect this would have to be a single generate line, like `//go:generate injectheader -header "some build tag" -run stringer -type=T`, which is a bit of a mouthful.

These alternatives might be independently useful, but it seems to me that getting build tags right automatically is a good place to start.

cc @robpike @bradfitz
Repository: youtube-dl
Issue: An option to filter videos by availability (public/unlisted/private)
Labels: request

<!--

######################################################################
  WARNING!
  IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################

-->


## Checklist

<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2021.06.06. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->

- [x] I'm reporting a feature request
- [x] I've verified that I'm running youtube-dl version **2021.06.06**
- [x] I've searched the bugtracker for similar feature requests including closed ones


## Description

<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->

I am trying to download all the "unlisted" videos from a playlist, as YouTube will be making all unlisted videos from before 2017 private in 10 days. I don't want to download the publicly available ones, just the unlisted. I think the easiest way to implement this would be to add a field to the output template so that `--match-filter` can be used to only download the unlisted results.

Thanks!
Repository: flutter
Issue: Support llvm source-based coverage in the Engine unittests
Labels: engine,P2,team-engine,triaged-engine

It'd be great to be able to support source-based coverage reporting for our unit test suites. LLVM supports this and documentation is at https://clang.llvm.org/docs/SourceBasedCodeCoverage.html

This requires the following:

~~- Add the coverage GN configs to buildroot~~
~~- Update engine gn script to add a coverage flag to enable the config~~
~~- Apply the coverage GN config to Engine files being built~~
~~- Add a coverage script that generates the coverage reports~~

- Modify the existing run-tests script to optionally output the coverage profile data when running the test suites
- Modify CI recipes to call the coverage script and upload the reports somewhere
Repository: godot
Issue: Light2d combined with overlapping tiles is mixing underneath part of tile
Labels: bug,topic:rendering,topic:2d

![grafik](https://user-images.githubusercontent.com/6300068/125535496-c38d807a-ca98-4b1a-93ef-261f8a7285b7.png)
### Godot version

3.3.2.stable, 3.4-beta1

### System information

Windows 10, GLES 3, Nvidia GTX 970 471.11

### Issue description

My Godot project has a Tilemap and a Light2d. 
Some tiles do overlap (as like it is common when using isometric tiles). 
As light texture I'm a using a radial gradient. When the Light2d Energy is set to st. other then 1, e.g. 0.2 the overlapping part of the underneath tile "shines through" (is mixed using the set mode). Setting "Y Sort" to "On" for the Tilemap does change the behavior a little bit, but there's still an shadow of the underneath overlapping part of the tile.
Note: It seems that the problem does not occur at the beginning. I've played a bit with the parameters and light size. It's more visible within the darker areas of the light texture.
See also: https://stackoverflow.com/questions/68367367/godot-engine-light2d-combined-with-overlapping-tiles-mixing-underneath-part

### Steps to reproduce

- Create a new 2d project with a Tilemap and a Light2d. 
- Add two different tiles to the tilemap
- make the tiles size of the tilemap smaller then the sprite texures used
- let 2 tiles overlapp
- I'm usig a radial gradient texture as light
- Play with changing the Light2d's mode (e.g. Mix)
- Play with the Light2d's energy (e.E. 0.2 )
- Set Y-Sort for the Tilemap to on (or off to see the difference)


### Minimal reproduction project

[BugTest.zip](https://github.com/godotengine/godot/files/6812402/BugTest.zip)
Repository: TypeScript
Issue: @see for property ref in __type__  reference
Labels: Suggestion,Awaiting More Feedback,Domain: JSDoc,Experimentation Needed

# Suggestion

<!--
  Please fill in each section completely. Thank you!
-->

## 🔍 Search Terms



<!--
  💡 Did you know? TypeScript has over 2,000 open suggestions!
  🔎 Please search thoroughly before logging new feature requests as most common ideas already have a proposal in progress.
  The "Common Feature Requests" section of the FAQ lists many popular requests: https://github.com/Microsoft/TypeScript/wiki/FAQ#common-feature-requests

  Replace the text below:
-->

jsdoc tsdoc `@see` `@link` docs types

## ✅ Viability Checklist

<!--
   Suggestions that don't meet all these criteria are very, very unlikely to be accepted.
   We always recommend reviewing the TypeScript design goals before investing time writing
   a proposal for ideas outside the scope of the project.
-->
My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).


## ⭐ Suggestion

<!-- A summary of what you'd like to see added or changed -->

## 📃 Motivating Example

```
export type A = {
  /**
   * The import ID from which the re-export was imported from.
   */
  foo: string
}

export namespace A {
  export type Params = {
    /**
     * @see {@link A['foo']}
     */
    foo: string
  }
  
  export const create = (params:Params): A => {
      return 'todo' as any
  }
}

```

Here is the above code (approx) in an interactive VSC setting, note the following:

1. Want to navigate to type alias but it goes to namespace
2. Want to point at a specific property, cannot

![CleanShot 2021-07-13 at 19 44 06](https://user-images.githubusercontent.com/284476/125539252-da3720eb-5894-40a4-83d6-404d0eb27af2.gif)

I do not have a concrete suggestion yet about how to achieve this.

First want to validate the problem with others.

## 💻 Use Cases

<!--
  What do you want to use this for?
  What shortcomings exist with current approaches?
  What workarounds are you using in the meantime?
-->

Want to share the JSDoc between a property on a constructor and a data type.
Repository: pytorch
Issue: Possibly flaky test: TestMultiprocessing.test_fd_sharing
Labels: triaged,module: flaky-tests

## 🐛 Bug

This test failed once on a recent, seemingly unrelated revision.  It might be flaky.  Let's keep an eye on it.

## To Reproduce

https://github.com/pytorch/pytorch/runs/3061650617
Repository: pytorch
Issue: When 'trapezoid' is called with an empty tensor input, it does not produce an output with requires_grad
Labels: module: autograd,triaged

## 🐛 Bug

While working to rename the operator `trapz()` to `trapezoid()`, I discover that when 'trapezoid' is called with an empty tensor input, it does not produce an output with `requires_grad`. I discussed with @mruberry and we don't think this behavior is expected. I suspect the relevant part of the code that is causing the issue is [here](https://github.com/pytorch/pytorch/blob/f2b26009d49e0a6292f933646f74cf8ded0d6284/aten/src/ATen/native/Integration.cpp#L46).



## To Reproduce

Steps to reproduce the behavior:

1. Run the following code snippet

```
y = torch.rand((5,0), requires_grad=True)
x = torch.trapz(y) # soon to be renamed torch.trapzoid()
x.backward()

Traceback (most recent call last):
  File "/.../main.py", line 124, in <module>
    x.backward()
  File "/.../torch/_tensor.py", line 256, in backward
    torch.autograd.backward(self, gradient, retain_graph, create_graph, inputs=inputs)
  File "/.../torch/autograd/__init__.py", line 147, in backward
    Variable._execution_engine.run_backward(
RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn
```

## Expected behavior

I expect that x.backward() should execute properly even when an empty tensor is passed in.

## Environment

PyTorch version: 1.10.0a0+git8fdab25
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: macOS 11.4 (x86_64)
GCC version: Could not collect
Clang version: 12.0.0
CMake version: version 3.19.6
Libc version: N/A

Python version: 3.8.10 (default, May 19 2021, 11:01:55)  [Clang 10.0.0 ] (64-bit runtime)
Python platform: macOS-10.16-x86_64-i386-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] numpy==1.20.2
[pip3] torch==1.10.0a0+git8fdab25
[conda] blas                      1.0                         mkl  
[conda] mkl                       2021.2.0           hecd8cb5_269  
[conda] mkl-include               2021.2.0           hecd8cb5_269  
[conda] mkl-service               2.3.0            py38h9ed2024_1  
[conda] mkl_fft                   1.3.0            py38h4a7008c_2  
[conda] mkl_random                1.2.1            py38hb2f4e1b_2  
[conda] numpy                     1.20.2           py38h4b4dc7a_0  
[conda] numpy-base                1.20.2           py38he0bd621_0  
[conda] torch                     1.10.0a0+git8fdab25          pypi_0    pypi


## Additional context

Note that the function is currently named `trapz()` and I am migrating its name to `trapezoid()`. The behavior should remain the same and matches `numpy.trapz()`.


cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @soulitzer @Lezcano @Varal7
Repository: go
Issue: x/net/idna: Registration.ToASCII() accepts empty TLD label
Labels: NeedsInvestigation

### What did you do?
https://go.dev/play/p/oGhflDafvrL

```
package main

import (
	"fmt"

	"golang.org/x/net/idna"
)

func main() {
	// Returns an error (as expected)
	fmt.Println(idna.Registration.ToASCII("gólang.órg.."))

	// Doesn't return an error
	fmt.Println(idna.Registration.ToASCII("golang.org.."))
}
```

### What did you expect to see?
```
xn--glang-0ta.xn--rg-4ja.. idna: invalid label ""
golang.org.. idna: invalid label ""
```

### What did you see instead?
```
xn--glang-0ta.xn--rg-4ja.. idna: invalid label ""
golang.org.. <nil>
```

It appears if the domain contains an empty TLD label but contains only ASCII characters, then no error is returned. And only for the TLD (empty labels elsewhere return an error as expected).
Repository: create-react-app
Issue: CRA doesn't use `--no-verify` for its initial commit
Labels: issue: proposal,needs triage

### Is your proposal related to a problem?

<!--
  Provide a clear and concise description of what the problem is.
  For example, "I'm always frustrated when..."
-->

The initial git commit from CRA doesn't use `--no-verify`. If a custom template includes a husky pre-commit hook, it can interfere with this initial commit. If the initial commit fails, CRA removes the `.git` directory.

### Describe the solution you'd like

<!--
  Provide a clear and concise description of what you want to happen.
-->

It would be convenient if CRA added `--no-verify` to its initial commit.

### Describe alternatives you've considered

<!--
  Let us know about other solutions you've tried or researched.
-->

My current workaround is to start the pre-commit script with:

```sh
GIT_REV_COUNT=$(git rev-list --all --count)

# HACK: if this is the first commit, do not run the pre-commit hook. The first commit will be the initial commit from create-react-app itself.
if [ "$GIT_REV_COUNT" -lt 1 ]; then
  exit 0
fi
```
Repository: rust
Issue: Tracking issue: deref patterns
Labels: T-lang,C-tracking-issue,needs-rfc,A-patterns,S-tracking-design-concerns,F-deref_patterns

Tracking issue for implementing deref patterns (`#[feature(deref_patterns)]`).

[deref patterns project group repo](https://github.com/rust-lang/project-deref-patterns)
[lang team initiative issue](https://github.com/rust-lang/lang-team/issues/88)

### About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

### Steps
<!--
Include each step required to complete the feature. Typically this is a PR
implementing a feature, followed by a PR that stabilises the feature. However
for larger features an implementation could be broken up into multiple PRs.
-->

- [ ] Implement the feature
  - [x] String -> &str: string_deref_patterns implementation: Minimal implementation of implicit deref patterns for Strings #98914 (stabilization not started)
  - [ ] Deref patterns for other std types
- [ ] Adjust documentation ([see instructions on rustc-dev-guide][doc-guide])
- [ ] Write an RFC
- [ ] Stabilization PR ([see instructions on rustc-dev-guide][stabilization-guide])

[stabilization-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs

### Status

The current implementation uses a placeholder `deref!(<pat>)` syntax and is limited to types in the standard library. See the [design proposal document](https://hackmd.io/4qDDMcvyQ-GDB089IPcHGg) for more details.

We limit to types in the standard library using the unstable trait `DerefPure`  (`#[feature(deref_pure_trait)]`). It is not intended to be stabilized at this stage.
- Supported std types: `Box`, `Rc`, `Arc`, `Vec`, `String`, `Cow`, `Pin`, `ManuallyDrop`, `Ref`, `RefMut`.
- Unstable types that would be eligible : `ThinBox`, `UniqueRc`, `LazyCell`, `LazyLock`, 

There is also a feature gate just for matching string literals on `String`s, under `#[feature(string_deref_patterns)]`.

### Unresolved Questions

None at this stage

```[tasklist]
### Implementation history
- [ ] https://github.com/rust-lang/rust/pull/98914
- [ ] https://github.com/rust-lang/rust/pull/119467
- [ ] https://github.com/rust-lang/rust/pull/122222
- [ ] https://github.com/rust-lang/rust/pull/122793
- [ ] https://github.com/rust-lang/rust/pull/122835
- [ ] https://github.com/rust-lang/rust/pull/123324
- [ ] https://github.com/rust-lang/rust/pull/122598
- [ ] https://github.com/rust-lang/rust/pull/123480
```
Repository: pytorch
Issue: Enhance Distributed `get_future()` docs
Labels: oncall: distributed,triaged,better-engineering,pt_distributed_rampup

## 📚 Documentation

`get_future()` is documented a bit here: https://pytorch.org/docs/stable/distributed.html?highlight=get_future, but does not clarify the future return type which seems to be `list[torch.tensor]`.


cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @agolynski @SciPioneer @H-Huang @mrzzd @cbalioglu @gcramer23
Repository: godot
Issue: Godot doesn't respect `maxPerStageDescriptorSamplers` limit
Labels: bug,topic:rendering,topic:thirdparty,crash

### Godot version

4.0 96a69899d0909291888828205138bbf9def5e6ff

### System information

All

### Issue description

Godot due not respecting `maxPerStageDescriptorSamplers` limit(32), crashes when running on Lavapipe

https://gitlab.freedesktop.org/mesa/mesa/-/issues/3772#note_990084

### Steps to reproduce

Compile and install Mesa
Try to run Godot editor via Lavapipe

### Minimal reproduction project

_No response_
Repository: material-ui
Issue: Allow variant overrides in Card
Labels: new feature,component: card

<!-- Provide a general summary of the feature in the Title above -->

<!--
  Thank you very much for contributing to Material-UI by creating an issue! ❤️
  To avoid duplicate issues we ask you to check off the following list.
-->

<!-- Checked checkbox should look like this: [x] -->

- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.

## Summary 💡

Allow customizing the variants of card, similar to other elements. There is already `CardPropsColorOverrides`, so there should be a `CardPropsVariantOverrides`  as well.

## Motivation 🔦

We use the Card Componente for our product teaser and instead of wrapping the component, we would like directly to style the different variants.
Repository: youtube-dl
Issue: download all videos from user but only MP3
Labels: question

- [x] I'm asking a question
- [x] I've looked through the README and FAQ for similar questions
- [x] I've searched the bugtracker for similar questions including closed ones


## Question


Hello, 

I want to download all the videos from an user, but only the mp3 format, i do not care about the videos themselves, all I want is the music.

I tried with `youtube-dl ytuser:marcou909 --audio-format mp3 --audio-quality 320K ` but this is downloading mp4 files, not mp3. 

I couldn't find by myself, any help would be really appreciate.
Repository: angular
Issue: Add a validator (and directive) for the `step` input attribute
Labels: feature,area: forms,feature: under consideration

### Which @angular/* package(s) are relevant/releated to the feature request?

forms

### Description

The `step` attribute ([spec](https://www.w3.org/TR/html51/sec-forms.html#the-step-attribute)) adds basic HTML validation to an input.
It checks wether the value matches a combination of _base value_ and _step_, and can trigger a [stepMismatch](https://www.w3.org/TR/html51/sec-forms.html#suffer-from-a-step-mismatch) validation error.

Use-case:
The validation could help to enforce integer on inputs, instead of using `pattern="\d*"` (which has already its own validator)

### Proposed solution

We could introduce a validator to check a control's value against a step attribute
<details>
<summary>Draft code</summary>

```
// Inspired by the minValidator
export function stepValidator(step: number | 'any', min: number = 0): ValidatorFn {
    return (control: AbstractControl): ValidationErrors | null => {
        if (isEmptyInputValue(control.value) || isEmptyInputValue(step) || step === 'any') {
            return null;
        }
        const value = parseFloat(control.value);
        return !isNaN(value) && (value - min) % step !== 0 ? { step: { step, actual: control.value } } : null;
    };
}
```
</details>

We could also add an associated directive for at least the `type="number"` input.
```
selector: "input[type=number][step][formControlName],input[type=number][step][formControl],input
[type=number][step][ngModel]"
```
By default, if the attribute is absent, the input still has a _default step_, but in that case the directive would not activate (since no attribute)
However, this can break existing code since `step` should be explicitely given `any` as a value to prevent validation, and I'm not sure most users are aware of this.

### Alternatives considered

Let users implement their own step validation, or use the pattern validator for specific cases (such as integer enforcement).
Repository: storybook
Issue: Height of all items in docs is limited to 100px after upgrading from v5 to v6
Labels: question / support,addon: docs

I've upgraded my storybook from v5.2 to v6.3.4. 

After that, all of my docs are for some reason limited to 100px in height. 

<img width="859" alt="Screenshot 2021-07-14 at 7 26 23 PM" src="https://user-images.githubusercontent.com/10087738/125614683-20567082-f9f9-441c-9ea3-0f53a202ba6a.png">

Why could this happen? 

Package.json:

```
    "@storybook/addon-a11y": "~6.3.4",
    "@storybook/addon-actions": "^6.3.4",
    "@storybook/addon-docs": "~6.3.4",
    "@storybook/addon-knobs": "~6.3.0",
    "@storybook/addon-links": "^6.3.4",
    "@storybook/addon-postcss": "^2.0.0",
    "@storybook/addon-storyshots": "~6.3.4",
    "@storybook/addon-storyshots-puppeteer": "~6.3.4",
    "@storybook/addon-viewport": "~6.3.4",
    "@storybook/addons": "~6.3.4",
    "@storybook/core": "~6.3.4",
    "@storybook/react": "~6.3.4",
    "@storybook/react-native": "^5.3.25",
    "@storybook/theming": "~6.3.4",
```

My config didn't change:

```
    docs: {
      container: DocsContainer,
      page: DocsPage,
    },
```

This is how the HTML code looks like in the docs page, but I can't figure out where it's coming from. Each story looks like this:

```
<div style="width: 100%; height: 100px; ">
  <iframe id="iframe--new-theme-atoms--button" title="Button" src="iframe.html?id=new-theme-atoms--button&amp;viewMode=story" allowfullscreen="" loading="lazy" style="width: 100%;height: 100%;border: 0px none"></iframe>
</div>
```

Note the hardcoded `100px`. I don't have that in my code.