sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: vscode
Issue: Git - `git.requireGitUserConfig` setting has no effect
Labels: bug,git

I set `git.requireGitUserConfig` to `false`, but I still get the error message: Make sure you configure your "user.name" and "user.email" in git.

According to [January 2021 (version 1.53)](https://code.visualstudio.com/updates/v1_53), that setting should allow to disable the requirement of a user name or email address before committing. 

This is related to #114433 and #112294.

- VS Code Version: 1.82.2
- OS Version: Windows 10 Pro
Repository: neovim
Issue: `DiagnosticUnderline*` highlights don't show up when LSP sets `col`/`lnum` and `end_col`/`end_lnum` the same
Labels: bug,diagnostic

### Problem

Consider the following Go code where `foo` takes two parameters

**NOTE**: This is relevant to other LSPs as well.

```go
package main

func main() {
	foo("hello")
	//         ^ There is no way for me to visually recognize that the error is from here
}

func foo(a, b string) {}
```

So I think this is related to the fact that in the output of `vim.diagnostic.get()`, which is included at the bottom of this textbox, `lnum` equals `end_lnum` and `col` equals `end_col`. Therefore the highlighting is omitted.

```
{ {
    bufnr = 1,
    code = "WrongArgCount",
    col = 12,
    end_col = 12,
    end_lnum = 3,
    lnum = 3,
    message = "not enough arguments in call to foo\n\thave (string)\n\twant (string, string)",
    namespace = 7,
    severity = 1,
    source = "compiler",
    user_data = {
      lsp = {
        code = "WrongArgCount",
        codeDescription = {
          href = "https://pkg.go.dev/golang.org/x/tools/internal/typesinternal#WrongArgCount"
        }
      }
    }
  } }
```

### Steps to reproduce

1. Setup a language server with [nvim-lspconfig](https://github.com/neovim/nvim-lspconfig).
2. Make an error that is only applied to a single character (e.g. missing function parameter).

```lua
for name, url in pairs{
  -- ADD PLUGINS _NECESSARY_ TO REPRODUCE THE ISSUE, e.g:
  -- some_plugin = 'https://github.com/author/plugin.nvim'
  lspconfig = "https://github.com/neovim/nvim-lspconfig",
} do
  local install_path = vim.fn.fnamemodify('nvim_issue/'..name, ':p')
  if vim.fn.isdirectory(install_path) == 0 then
    vim.fn.system { 'git', 'clone', '--depth=1', url, install_path }
  end
  vim.opt.runtimepath:append(install_path)
end

-- ADD INIT.LUA SETTINGS THAT IS _NECESSARY_ FOR REPRODUCING THE ISSUE

-- IMPORTANT: you need to have gopls installed
-- NOTE: it is also possible with other language servers
require('lspconfig').gopls.setup({})
```

### Expected behavior

I expect that parenthesis to be highlighted with `DiagnosticUnderlineError` like other LSP errors.

### Neovim version (nvim -v)

v0.10.0-dev+1187-g5331d5772

### Vim (not Nvim) behaves the same?

vim does not have diagnostics

### Operating system/version

Fedora Linux 38 (Workstation Edition)

### Terminal name/version

kitty 0.29.2

### $TERM environment variable

xterm-kitty

### Installation

agriffis/neovim-nightly dnf copr plugin
Repository: excalidraw
Issue: Feature: Text Casing Conversion🍏🖋️
Labels: enhancement,richtext

**Issue Description:** 🛠️
As a user of this application, I would like to request the addition of a case conversion feature that allows users to convert text between different letter casing styles easily. This feature would be valuable for various use cases such as formatting text or simply for personal preference. The following letter casing styles are commonly used and should be supported:

1. **Sentence Case**: Begin with a capital letter for the first word of a sentence and keep the rest in lowercase.
2. **lowercase**: Adopt a casual, all-lowercase style.
3. **UPPER CASE**: Make a bold statement with uppercase letters.
4. **Capitalized Case**: Elevate text with capitalization for the first letter of each word.
5. **Title Case**: Provide a touch of sophistication by capitalizing significant words while keeping articles, conjunctions, and prepositions in lowercase.
6. **InVeRsE CaSe**: Turn text into a playful and quirky format by flipping uppercase and lowercase letters.

**Use Case Scenario:** 📋
In this scenario, a user engages with a whiteboard or sketch with the aim of refining the text's appearance for clarity or artistic expression. The introduction of this feature would allow users to seamlessly switch between these letter casing styles without the need for manual editing.

**Expected Behavior:** 🤞
The expected behavior is as follows:

- The user should be able to select either a portion or the entire text on the whiteboard or sketch.
- The tool's menu or toolbar should prominently display an option for text casing conversion.
- Upon selecting this option, a dropdown menu or button should present the user with the available casing styles listed above.
- After selecting a style and applying it, the text should transform to match the chosen casing style while maintaining its original context within the whiteboard or sketch.

![UI](https://github.com/excalidraw/excalidraw/assets/38225598/d546e966-ac08-426d-bc2a-975047df9a69)

**Additional Notes:** 📝
For enhanced user efficiency, it's suggested to consider implementing intuitive shortcuts (keyboard shortcuts or stylus gestures) that expedite case conversion, particularly in sketching scenarios. Furthermore, the inclusion of a "Clear Formatting" option would be appreciated to restore the text to its original state while retaining its position and context within the whiteboard or sketch.

**References:** 📚
Similar features can be found in graphics software and text manipulation tools, enhancing user convenience in creative settings.

Thank you for considering this feature request. Implementing it would significantly enhance the functionality and versatility of our Whiteboard & Sketching Tool, catering to both the creative and practical needs of our users.
Repository: vscode
Issue: Changing the setting from boolean to string should be shown as a deprecation and not as an error at least for some grace period
Labels: settings-editor,under-discussion

Testing #194031



![Image](https://github.com/microsoft/vscode/assets/1931590/714926b6-6981-4d9d-a86d-2e76909eb479)


This was happily legal in 1.82.2



![Image](https://github.com/microsoft/vscode/assets/1931590/de311365-7a90-4a42-a2a4-18d8e2227fcc)
Repository: vscode
Issue: Use Code Actions For "Edit" In settings.json
Labels: feature-request,settings-editor

We have this edit feature for settings.json:

![Image](https://github.com/microsoft/vscode/assets/2931520/39476d1c-9aae-4cdd-a516-252056f4dcfa)

It would be very nice if this could be integrated into code actions.
Then I could trigger this menu with my keyboard.
Repository: vscode
Issue: Cannot undo file deletions from a WorkspaceEdit
Labels: bug,workspace-edit,undo-redo

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

To reproduce just delete a file using the `WorkspaceEdit` API - Since the undo stack seems bound to the `TextEditor`, there is no way to undo file deletions. However, file creations/renames can be undone if you undo from the open file... It just seems to be a bit inconsistent especially since the Explorer offers a more versatile undo stack.

Simple example:
```typescript
const we = new vscode.WorkspaceEdit();
we.createFile(fileUri, { ignoreIfExists: true});
await vscode.workspace.applyEdit(we); // This can be undone if you "undo" inside fileUri

const we2 = new vscode.WorkspaceEdit();
we2 .deleteFile(fileUri);
await vscode.workspace.applyEdit(we2); // This can never be undone
```

Is it possible to introduce a way to undo without having the `TextEditor` open?
Repository: vscode
Issue: Notebook goto symbol: improve styling for highlighting symbol
Labels: polish,notebook-toc-outline

Testing #194053

1. Open notebook. Open outline
2. Notice how the yellow rendering is done around the cells.
3. The UI looks bad. The yellow colour should also be applied inside the cell. Same how we do it in the regular editor

![Screenshot 2023-09-26 at 12 13 07](https://github.com/microsoft/vscode/assets/1926584/be8e51f5-0da9-4a87-8344-e01d5faa5637)
Repository: vscode
Issue: Flag, report document selectors that use notebookType and cell-scheme
Labels: debt,extensions,engineering

Testing #194077

While working on GHINB `joh/civic-tahr` I was wondering why my code action provider wasn't ever called. Turns out I had the following selector configured

```
{ scheme: 'vscode-notebook-cell', notebookType: 'github-issues' }
```

This never matches because the notebook-types makes us use the scheme of the notebook file, not its cells. This behaviour is clearly documented (by me 🙊) but I still missed it... We should be nice and somewhere print a clear warning when this happens
Repository: transformers
Issue: How to run Trainer + DeepSpeed + Zero3 + PEFT 
Labels: WIP

### System Info

- `transformers` version: 4.34.0.dev0
- Platform: Linux-5.14.0-284.25.1.el9_2.x86_64-x86_64-with-glibc2.34
- Python version: 3.11.4
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.3
- Accelerate version: 0.24.0.dev0
- Accelerate config:    not found
- PyTorch version (GPU?): 2.0.1+cu117 (True)


### Who can help?

 @ArthurZucker and @younesbelkada and @pacman100 and @muellerzr 

### Information

- [ ] The official example scripts
- [X] My own modified scripts

### Tasks

- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)

### Reproduction

[This script](https://gist.github.com/BramVanroy/f2abb3940111b73ae8923822ef6096dd) is a modification of the official run_clm script. The only additions are the BNB config and PEFT. Yet, I cannot get it to work with a [deepspeed zero3 config](https://github.com/philschmid/deep-learning-pytorch-huggingface/blob/main/training/configs/ds_falcon_180b_z3.json).

Requirements to install:

```
accelerate >= 0.12.0
torch >= 1.3
datasets >= 1.8.0
sentencepiece != 0.1.92
protobuf
evaluate
scikit-learn
trl
peft
bitsandbytes
```

In the past I have had issues with low_cpu_mem_usage but neither a true/false value seem to get this to work:

Command 1:

```sh
deepspeed --include="localhost:0,1" run_clm.py \
   --model_name_or_path facebook/opt-125m\
  --dataset_name wikitext\
  --dataset_config_name wikitext-2-raw-v1\
  --per_device_train_batch_size 2\
  --per_device_eval_batch_size 2\
  --do_train\
  --do_eval\
  --output_dir /tmp/test-clm\
  --deepspeed deepspeed_configs/ds_config_zero3.json\
  --low_cpu_mem_usage true
```
==> `ValueError: DeepSpeed Zero-3 is not compatible with `low_cpu_mem_usage=True` or with passing a `device_map`.`

Command 2:

```sh
deepspeed --include="localhost:0,1" run_clm.py \
   --model_name_or_path facebook/opt-125m\
  --dataset_name wikitext\
  --dataset_config_name wikitext-2-raw-v1\
  --per_device_train_batch_size 2\
  --per_device_eval_batch_size 2\
  --do_train\
  --do_eval\
  --output_dir /tmp/test-clm\
  --deepspeed deepspeed_configs/ds_config_zero3.json\
  --low_cpu_mem_usage false
```

==> `ValueError: weight is on the meta device, we need a `value` to put in on 0.`

### Expected behavior

Any option to make this combination of Trainer + DeepSpeed + Zero3 + PEFT work.
Repository: godot
Issue: Time.get_time_zone_from_system() returns localized timezone name instead of standard abbrev
Labels: discussion,topic:porting

### Godot version

Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated AMD Radeon RX 5700 XT (Advanced Micro Devices, Inc.; 31.0.21001.45002) - Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz (16 Threads)

### System information

Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated AMD Radeon RX 5700 XT (Advanced Micro Devices, Inc.; 31.0.21001.45002) - Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz (16 Threads)

### Issue description

my system locale is simp chinese and timezone is CST(GMT+8) , and Time.get_time_zone_from_system()["name"] returns

"中国标准时间"

instead of "CST"

In my opinion, the localized timezone name is almost useless since it is hard to process, and there is almost no need to show this string to user in games. so it would be better to just provide the abbrev, e.g "CST" ,"PST", "UTC", etc



### Steps to reproduce

print(Time.get_time_zone_from_system()["name"])

### Minimal reproduction project

not needed
Repository: PowerToys
Issue: Keyboard Manager remapping
Labels: Issue-Bug,Product-Keyboard Shortcut Manager,Priority-3

### Microsoft PowerToys version

0.73.0

### Installation method

PowerToys auto-update

### Running as admin

Yes

### Area(s) with issue?

Keyboard Manager

### Steps to reproduce

On a fresh boot/session of Windows (this may be important as this should be related to display scaling and dpi on boot is stored) with a non-100% display scaling setting, use keyboard manager to remap any key (we assume CapsLock for this report) to the control key. While this part of PowerToys is not directly related, it may help. Turn on `Enable Find My Mouse` under Mouse Utilities (preferably with double control as activation) and check that it works.


In Windows start menu, search for `mouse pointer display` and choose `Change mouse pointer display or speed` (alternatively Control Panel > Mouse (pop up) > Pointer Options. On this page, check `Show location of pointer when I press the CTRL key` under Visibility and use the normal control key to see that the pointer is circled when control is pressed.


Press the key remapped (CapsLock) multiple times and see discrepancy between Windows and PowerToys (See Actual Behavior)

Now change Windows display scaling to 100% and see that the problem goes away.

While for this exact problem, I can just turn Windows' indicator off and it is a small problem, it appears that after a remap, display scaling is lost/applied twice (I think the latter), which may affect other keyboard shortcuts and applications launched with them.

Here is a related issue https://github.com/microsoft/PowerToys/issues/11878 that may prevent reproduction when keyboard manager settings are changed (and uses the same windows feature).

### ✔️ Expected Behavior

No discrepancy between PowerToys' indication of the cursor and Windows' indication.

### ❌ Actual Behavior

Now press and also double tap the key remapped (CapsLock) and observe that Windows' internal (control center) marking is off to the bottom right of the pointer while PowerToys' marking is correct. Notice that for different locations of the mouse pointer on the screen, the discrepancy changes with little at top left and the circle off screen bottom right.

After display scaling is changed to 100%, no more problems occur.

### Other Software

_No response_
Repository: bitcoin
Issue: BIP352 tracking issue
Labels: Feature,Wallet

This issue will be updated to reflect the current state of [BIP352](https://github.com/bitcoin/bips/blob/master/bip-0352.mediawiki) integration.

PRs ready for review:

* https://github.com/bitcoin-core/secp256k1/pull/1519

Overall plan:

* Pre-work / Refactors
  - [x] https://github.com/bitcoin/bitcoin/pull/28244
  - [x] https://github.com/bitcoin/bitcoin/pull/28246
  - [x] https://github.com/bitcoin/bitcoin/pull/25273
  - [x] https://github.com/bitcoin/bitcoin/pull/28560
  - [x] https://github.com/bitcoin/bitcoin/pull/30047
  - [x] https://github.com/bitcoin/bitcoin/pull/30048
  - [x] https://github.com/bitcoin/bitcoin/pull/30050
  - [x] https://github.com/bitcoin/bitcoin/pull/30051
* Send and receive support in the Bitcoin Core wallet:
  - [ ] Implement silent payments as a `libsecp` module: https://github.com/bitcoin-core/secp256k1/pull/1519
  - [ ] Base protocol: https://github.com/bitcoin/bitcoin/pull/28122
  - [ ] Sending: https://github.com/bitcoin/bitcoin/pull/28201
  - [ ] Receiving: (not started)

* Light client support:
  - [ ] Index for silent payment tweaks (depends on 28122): https://github.com/bitcoin/bitcoin/pull/28241
  - [ ] New BIP157 filter type for tweak data (not started)
  - [ ] Serve new filter type (not started)

<details>
  <summary>Older stuff</summary>


  <ul>
  <li>Closed / Superseded:
     <ul>
     <li>Tracking PR (superseded by this issue): #27827</li>
     <li>Receiving (superseded by 28453): #28202</li>
      <li>Original draft implementation: #24897</li>
     <li>Original libsecp256k1 module (superseded by 1519): bitcoin-core/secp256k1/pull/1471</li>
     <li> Original receiving PR: https://github.com/bitcoin/bitcoin/pull/28453</li>
      </ul>
  </li>
  </ul>
</details>
Repository: next.js
Issue: Routes with "nested" parallel routes are not correctly rendered
Labels: bug,Parallel & Intercepting Routes

### Link to the code that reproduces this issue

https://github.com/nilshartmann/nextjs-slot-rendering-twice

### To Reproduce

1. Start the application using "npm run dev"
2. Click on "Goto User 1"
  - Page with title "User Details for User with id 1" opens
3. Click on "Goto User 2"
  - The URL changes (last segment switches to `2`)
  - The page still shows user `1`

4. Again click on "Goto User 2"
  - Now the correct page ("User Details for User with id 2") shows up

**Or:**

1. Build the application using `npm run build`
2. See the build output, route `/user/[userId]` is printed more than one time

**With static params:**

- add `generateStaticParams` to `/user/[userId]/page.tsx`
- run `npm run build`
- you will see that for each user id the `/user/[userId]` route is rendered twice


### Current vs. Expected behavior

- Currently the `page.tsx` file inside a "nested" parallel route (`/user/@header/[userId]`) only opens after clicking the link to it twice
- I would expect, that:
  - if I click on a link to the `/user/[userId]` route it immediately opens and shows the slot defined in `/user/@header/[userId]/page.tsx`

Currently the build shows that the route `/user/[userId]` is rendered more than one time
  - I would expect that it is rendered one time as with all other routes



### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 22.6.0: Fri Sep 15 13:41:28 PDT 2023; root:xnu-8796.141.3.700.8~1/RELEASE_ARM64_T6000
Binaries:
  Node: 18.15.0
  npm: 9.5.0
  Yarn: 1.22.19
  pnpm: 8.7.5
Relevant Packages:
  next: 13.5.4-canary.0
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.1.3
Next.js Config:
  output: N/A
```


### Which area(s) are affected? (Select all that apply)

App Router, Routing (next/router, next/navigation, next/link)

### Additional context

I tested against Next.js 13.5.3 and 13.5.4-canary.0
Repository: rust
Issue: `no_std` attribute causes unnecessarily verbose error messages involving `Result` on both stable and nightly
Labels: A-diagnostics,T-compiler,A-suggestion-diagnostics

### Code

```Rust
#![no_std]

struct A;
struct B;
fn test() -> Result<A, B> {
    B
}
```


### Current output

```Shell
error[E0308]: mismatched types
 --> src/lib.rs:5:5
  |
4 | fn test() -> Result<A, B> {
  |              ------------ expected `Result<A, B>` because of return type
5 |     B
  |     ^ expected `Result<A, B>`, found `B`
  |
  = note: expected enum `Result<A, B>`
           found struct `B`
help: try wrapping the expression in `core::prelude::v1::Err`
  |
5 |     core::prelude::v1::Err(B)
  |     +++++++++++++++++++++++ +
```


### Desired output

```Shell
error[E0308]: mismatched types
 --> src/lib.rs:4:5
  |
3 | fn test() -> Result<A, B> {
  |              ------------ expected `Result<A, B>` because of return type
4 |     B
  |     ^ expected `Result<A, B>`, found `B`
  |
  = note: expected enum `Result<A, B>`
           found struct `B`
help: try wrapping the expression in `Err`
  |
4 |     Err(B)
  |     ++++ +
```


### Rationale and extra context

Without `no_std` the output is exactly as expected, without the unnecessarily verbose full path being used in the error message.
Repository: godot
Issue: FileSystem's inline renaming popup can spawn offset from the renamed file
Labels: bug,topic:editor,usability,topic:gui

### Godot version

4.1.1

### System information

linux

### Issue description

This happened randomly. It happened on both items and list view, didn't try with tree view. I had just switched to this project by returning to the project list. Restarting the editor fixed it.
I can't reproduce it.

https://github.com/godotengine/godot/assets/71937306/6809aa21-c15f-48bc-a6e4-cce867f19b70



### Steps to reproduce

no idea

### Minimal reproduction project

idk
Repository: vscode
Issue: Highlight matched words in similar commands
Labels: feature-request,quick-open

Testing #194021

If would be nice if there's some highlighting in the similar commands entries as well. 

My observation is that all the similar commands contain at least one of the search terms
Repository: storybook
Issue: [Bug]: Source code ignores a React component prop when its value is `false`
Labels: bug,react,block: source,sev:S3

### Describe the bug

If I write a story and one of the arguments is a boolean prop set as `false` I am expecting to see it as part of the generated source code.

### Example 
```tsx

// The component
const Button: React.FC<{primary?: boolean}> = ({ primary = true, ...rest}) => {
  const mode = primary
    ? 'storybook-button--primary'
    : 'storybook-button--secondary';

  return  <button className={mode} {...rest} />
}


// Stories
export const Primary: Story = {
  args: {
    primary: true,
    label: 'Button',
  },
};

export const PrimaryIsUndefined: Story = {
  args: {
    label: 'Button',
    primary: undefined
  },
};

export const PrimaryIsFalse: Story = {
  args: {
    label: 'Button',
    primary: false
  },
};

```

### What this generates

<img width="618" alt="Screenshot 2023-09-26 at 15 08 47" src="https://github.com/storybookjs/storybook/assets/30926550/5c2ad3fc-9846-491d-87d4-fd4b16074c69">



### To Reproduce

Here a real reproduction using the default Storybook Button example:
https://stackblitz.com/edit/github-r73xza?file=src%2Fstories%2FButton.stories.ts&preset=node

### System

_No response_

### Additional context

_No response_
Repository: go
Issue: proposal: x/perf/cmd/benchrun: add `-run` and `-count` option
Labels: Proposal

Collecting high quality benchmarks using benchstat is a bit annoying. First you have to run them many times, ideally you want to interleave old and new binaries to make noise less relevant.

---

Add `-run` bool option, if set then the old, new, ... file paths are not outputs of `go test` but `go test -c`, `benchstat` will invoke the files using a Thue-Morse sequence and with options `-test.run=$^` and `-test.bench=` with benchstat's `-filter` option value.
`-count` specify how many invocation of each should happen, each invocation will run with `-test.count=1` (or unset).

---

Expected usage:
 ```console
 > go test -c -o /tmp/new
 > git checkout HEAD~1
 > go test -c -o /tmp/old
 > benchstat -run -count=10 /tmp/{old,new}
 ```