sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: pytorch
Issue: [Caffe2] cmake3 detection error?
Labels: caffe2

cmake 3 is detected however version check fails?

```
$ python setup.py install
Building wheel torch-1.0.0a0+1fe8278
running install
setup.py::run()
running build_deps
setup.py::build_deps::run()
+ SYNC_COMMAND=cp
++ command -v rsync
+ '[' -x /usr/bin/rsync ']'
+ SYNC_COMMAND='rsync -lptgoD'
+ CMAKE_COMMAND=cmake
++ command -v cmake3
+ [[ -x /usr/bin/cmake3 ]]
++ command -v cmake
+ [[ -x /usr/bin/cmake ]]
++ cmake --version
++ grep version
++ awk '{print $3}'
+ CMAKE_VERSION=2.8.12.2
++ cmake3 --version
++ awk '{print $3}'
++ grep version
+ CMAKE3_VERSION=3.12.1
++ /home/apiszcz/p/vx/lib/a3/bin/python -c 'from distutils.version import StrictVersion; print(1 if StrictVersion("2.8.12.2") < StrictVersion("3.5.0") and StrictVersion("3.12.1") > StrictVersion("2.8.12.2") else 0)'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/apiszcz/p/vx/lib/a3/lib/python3.5/distutils/version.py", line 40, in __init__
    self.parse(vstring)
  File "/home/apiszcz/p/vx/lib/a3/lib/python3.5/distutils/version.py", line 137, in parse
    raise ValueError("invalid version number '%s'" % vstring)
ValueError: invalid version number '2.8.12.2'
+ CMAKE3_NEEDED=
Failed to run 'bash ../tools/build_pytorch_libs.sh --use-cuda --use-nnpack --use-qnnpack nccl caffe2'
```
Repository: go
Issue: x/text/number: support formatting of custom types
Labels: NeedsInvestigation,FeatureRequest

<sup>This is based on [a StackOverflow question](https://stackoverflow.com/q/52591678/1892060).</sup>

Package `golang.org/x/text/number` allows locale-specific formatting of numbers à-la `fmt`. Unfortunately, unlike `fmt`, this package doesn't have an interface to let types other than the built-in numeric types tell the package how to format them. Or rather, [the interface](https://godoc.org/golang.org/x/text/internal/number#Converter) is there, but it's in an internal package, so the users can't really implement it.

This wouldn't be bad if `math/big` types or types whose `String()` method produces numbers were supported, but as of now that is [still a TODO](https://github.com/golang/text/blob/d82c1812e304abfeeabd31e995a115a2855bf642/internal/number/decimal.go#L340).
Repository: rust
Issue: libtest: allow for controlling runtime or iterations of benchmarks
Labels: T-libs-api,C-feature-request,A-libtest

There have been instances where it would have been nice to be able to control the minimum number of iterations or the maximum runtime of a set of benchmarks.  Currently looking at libtest it seems these values are hardcoded at [1 minimum iteration](https://github.com/rust-lang/rust/blob/master/src/libtest/lib.rs#L1616) and a max of [3 seconds](https://github.com/rust-lang/rust/blob/master/src/libtest/lib.rs#L1650).  One easy way to change this would be to add --min_iters and --max_secs command line arguments to allow for controlling these two parameters (as well as corresponding arguments in 'cargo bench').

I noticed #50297 but wasn't sure if this sort of functionality would be included in the implementation of that RFC or if it could be implemented independent of it.
Repository: flutter
Issue: Documentation request: Operations not allowed during the build cycle
Labels: framework,d: api docs,c: proposal,P2,team-framework,triaged-framework

There is an interaction between two classes of operations that could be better documented:

1) operations that occur during the widget build cycle. This includes e.g. `build()`, `didChangeDependencies()`, and probably others.

2) operations that are not allowed during the build cycle, but which require a `BuildContext`. This includes e.g. `showDialog`, many `Navigator` methods, and probably others.

Since the build method is one of the most common ways to get access to a `BuildContext`, it's a fairly non-obvious restriction.

Since there are a number of operations in each class, putting a full description of the issue in each one's API docs might be a lot of duplicated explanation. I wonder instead if there could be a deep dive doc in either the "Want to skill up?" or "Specialized topics" sections here: https://flutter.io/docs/. The API docs for each affected operation could then point to this central explanation.

For full context, see the discussion in this thread: https://groups.google.com//forum/#!topic/flutter-dev/V9pCG3FgyMM
Repository: gin
Issue: A new method for parsing form data array type fields
Labels: feature

- go version: 1.9
- gin version (or commit ref): master branch
- operating system: 

## Description
![image](https://user-images.githubusercontent.com/24504247/47624659-c1839b00-db59-11e8-9fbf-6a54da08c7f4.png)

this image is my  http post params .
I'm going to use c.GetPostFormMap to parse processes field, but I didn't get the expected results.
So I wrote a solution myself, as follows：
```
// GetPostFormArrayMap returns a map for a given form key, plus a boolean value
// whether at least one value exists for the given key.
func (c *Context) GetPostFormArrayMap(key string) ([]map[string]string, bool) {
	req := c.Request
	req.ParseForm()
	req.ParseMultipartForm(c.engine.MaxMultipartMemory)
	dicts, exist := c.getArrayMap(req.PostForm, key)
	if !exist && req.MultipartForm != nil && req.MultipartForm.File != nil {
		dicts, exist = c.getArrayMap(req.MultipartForm.Value, key)
	}
	return dicts, exist
}

// get is an internal method and returns a map which satisfy conditions.
func (c *Context) getArrayMap(m map[string][]string, key string) ([]map[string]string, bool) {
	dicts := make(map[string]map[string]string)
	exist := false
	for k, v := range m {
		if i := strings.IndexByte(k, '['); i >= 1 && k[0:i] == key { // 确定name[1]key
			num := ``
			if j := strings.IndexByte(k[i+1:], ']'); j >= 1 {
				num = k[i+1:][:j]
			}
			if j := strings.IndexByte(k[i+1:], '['); j >= 1 {
				exist = true
				field := k[i+1:][j+1 : len(k[i+1:])-1]
				if dict, ok := dicts[num]; ok {
					dict[field] = v[0]
					dicts[num] = dict
				} else {
					dicts[num] = map[string]string{field: v[0]}
				}
			}
		}
	}
	arr := make([]map[string]string, 0)
	for _, value := range dicts {
		arr = append(arr, value)
	}
	return arr, exist
}
```
this image is my parse result .
![image](https://user-images.githubusercontent.com/24504247/47624739-93eb2180-db5a-11e8-99b8-6f39422c8df2.png)



## Screenshots
Repository: pytorch
Issue: torch.utils.checkpoint is not compatible with nn.DataParallel
Labels: module: checkpoint,triaged,module: data parallel

## 🐛 Bug

<!-- A clear and concise description of what the bug is. -->

## To Reproduce

Steps to reproduce the behavior:
```
net = nn.Sequential(
	# somenet
)
from torch.utils.checkpoint import checkpoint_sequential

net = nn.DataParallel(net)
data = torch.randn(1, 3, 224, 224, requires_grad=True)
out = checkpoint_sequential(net, 1, data) # error here
```

## Expected behavior
Checkpoint sequential is expected to work well with nn.DataParallel. 

## Environment
pytorch: 0.4
OS: ubuntu 16.04
Repository: opencv
Issue: fisheye.cpp:line 983 and line 997 cv::Mat(cv::Mat((imageLeft - projected).t()).reshape(1, 1).t()).copyTo(ekk.rowRange(0, 2 * n_points)); the size of imageLeft is [1*54], but the size of projected is [54 * 1]
Labels: category: calib3d,incomplete,needs reproducer

<!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).

Please:

* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.


This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->

##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->

- OpenCV => :grey_question:
- Operating System / Platform => :grey_question:
- Compiler => :grey_question:

##### Detailed description

<!-- your description -->

##### Steps to reproduce

<!-- to add code example fence it with triple backticks and optional file extension
    ```.cpp
    // C++ code example
    ```
 or attach as .txt or .zip file
-->
Repository: godot
Issue: Animation Preview does not work when the process mode is set to Manual
Labels: enhancement,topic:editor,confirmed,usability,topic:animation

**Godot version:**
<!-- Specify commit hash if non-official. -->


**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
`v3.1.alpha.official`

**Issue description:**
<!-- What happened, and what was expected. -->
When the the animation process mode is in `Manual` the animation previews don't work. 

![manual-doesnt-let-you-play](https://user-images.githubusercontent.com/192675/47629784-6e2e3000-dafa-11e8-801b-2317cb32c050.gif)

Although it kind of makes sense why it doesn't play from an implementation stand point, from a useability standpoint it's really confusing. If you would want to have a `Manual` animation then you would have to set it to `Idle` or `Physics` when tweaking the animation, then back to `Manual` when you're done. If this was is intentional there should at least be a ⚠️ to warn the user.
Repository: flutter
Issue: flutter analyze should have option for machine-readable output
Labels: c: new feature,tool,P2,team-tool,triaged-tool

`dartanalyzer` has `--format machine`, and we are using that for processing analysis results with `pana` (and on the pub site). Because `flutter analyze` has no such option, we still fall back to `dartanalyzer`, causing inconsistencies like [the bug last week](https://github.com/dart-lang/pub-dartlang-dart/issues/1728). Providing the same output as `dartanalyzer` gives us would be perfect.
Repository: rust
Issue: Native FreeBSD and OpenBSD testing on CI
Labels: O-openbsd,O-freebsd,T-infra

https://builds.sr.ht/ offers native (no qemu emulation) FreeBSD and OpenBSD CI services. These are currently free and invite only, but invites can be requested at sir@cmpwn.com . They plan to offer these as paid services in the future at $2, $5, and $10 / month price points depending on the plan. 

This is currently how https://github.com/swaywm/wlroots is tested on these platforms.

Maybe we should give these a try.
Repository: go
Issue: cmd/cgo: avoid calls to cgoCheckPointer when debug.cgocheck=0
Labels: Performance,NeedsInvestigation,compiler/runtime

With `DEBUG=cgocheck=0` Go still makes calls to `cgoCheckPointer` which will bail out early in https://github.com/golang/go/blob/8f4fd3f34e8e218cb90435b5a8c6ba9be23a1e1e/src/runtime/cgocall.go#L412. Every such call adds few ns, but funcs with many arguments can end up accumulating a lot of them.

https://golang.org/cl/142884 changes cgo generated code to:

```
defer func() func() {
    _cgo0 := x
    _cgo1 := y
    return func() {
        _cgoCheckPointer(_cgo0)
        _cgoCheckPointer(_cgo1)
        C.f(_cgo0, _cgo1)
    }
}()()
```

I propose, instead of checking `debug.cgocheck=0` inside `cgoCheckPointer` it would check it before calling `cgoCheckPointer`, so cgo would generate:

```
defer func() func() {
    _cgo0 := x
    _cgo1 := y
    return func() {
        if debug.cgocheck != 0 {
            _cgoCheckPointer(_cgo0)
            _cgoCheckPointer(_cgo1)
        }
        C.f(_cgo0, _cgo1)
    }
}()()
```
Repository: neovim
Issue: "tnoremap jk <C-\><C-n>" delay when holding down "j"
Labels: bug,terminal,event-loop,core

<!-- Before reporting: search existing issues and check the FAQ. -->

- `nvim --version`: v0.3.2
- Vim (version: ) behaves differently? yes
- Operating system/version: ubuntu16.04
- Terminal name/version: 
- `$TERM`:

### Steps to reproduce using `nvim -u NORC`

```
1. nvim -u NORC
2. tnoremap jk <C-\><C-n>
3. :term
4. start insert and hold down the key `j`
```

### Actual behaviour
When I hold down the key `j`, it has no echo,
When I release the key `j`, it show as
![image](https://user-images.githubusercontent.com/19503791/47652479-068ee800-dbc1-11e8-9ed3-4d2f4dc47fc7.png)

### Expected behaviour
As same as vim8.1
Repository: TypeScript
Issue: inline comments are striped in emitted declaration files
Labels: Suggestion,Needs Proposal

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  3.1.3

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** inline comments striped

**tsconfig**

```json
{
  "compilerOptions": {
    "moduleResolution": "node",
    "module": "esnext",
    "target": "es5",
    "lib": [
      "dom",
      "es2018"
    ],
    "strict": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "suppressImplicitAnyIndexErrors": true,
    "forceConsistentCasingInFileNames": true,
    "jsx": "react",
    "sourceMap": true,
    "outDir": "dist/esm5",
    "declaration": true,
    "declarationDir": "dist/types",
    "declarationMap": true,
    "stripInternal": true,
    "resolveJsonModule": true,
    "importHelpers": true
  },
  "include": [
    "./src"
  ],
  "compileOnSave": false,
  "buildOnSave": false
}
```

**Code:**

```ts
// I'll be missing after tsc 😭

/**
 * I'll be here after tsc 😎
 */

export const api = () => { /* some code ... */ } 
```


**Expected behavior:**

Keeping both block and inline comments in declaration files in both transpiled files and declaration files

**Actual behavior:**

Inline comments are removed in declaration files
![image](https://user-images.githubusercontent.com/1223799/47649377-6e234400-db7d-11e8-8bb1-85bef3edb025.png)

And correctly kept within transpiled files
![image](https://user-images.githubusercontent.com/1223799/47649543-e5f16e80-db7d-11e8-9988-035da78f6461.png)
Repository: go
Issue: os/exec: race on cmd.Wait() might lead to panic
Labels: NeedsDecision

The current implementation of [cmd.Wait](https://golang.org/pkg/os/exec/#Cmd.Wait) has a race condition: if multiple goroutines call it, it might cause a panic.

In the first part of the method, copied below, two concurrent calls might check `c.finished`, get false, set it to true, invoke `c.Process.Wait()` and close `c.waitDone` before any error checking is performed. `c.waitDone` is a `chan struct{}`, and a double close will cause a panic.
```go
func (c *Cmd) Wait() error {
	if c.Process == nil {
		return errors.New("exec: not started")
	}
	if c.finished {
		return errors.New("exec: Wait was already called")
	}
	c.finished = true

	state, err := c.Process.Wait()
	if c.waitDone != nil {
		close(c.waitDone)
	}
	//[...]
```
Since waiting is a synchronization primitive I'd expect one of the two:
* The **documentation** should state that this is not safe for concurrent use (probably the best approach here)
* Some form of synchronization to **prevent races**. I would either atomically CAS `c.finished` (but I'm not a fan of atomics and would require to change type to some sort of int) or protect `c` with a mutex, which would be my suggested solution for this case

I would happily send in CLs in both cases.
Repository: pytorch
Issue: DataLoader num_workers > 0 causes CPU memory from parent process to be replicated in all worker processes
Labels: high priority,module: dependency bug,module: multiprocessing,module: dataloader,module: molly-guard,module: memory usage,triaged

# Editor note: There is a known workaround further down on this issue, which is to NOT use Python lists, but instead using something else, e.g., torch.tensor directly. See https://github.com/pytorch/pytorch/issues/13246#issuecomment-905703662 . You can use a numpy array, but it only fixes the issue for the `fork` start method. See https://github.com/pytorch/pytorch/issues/13246#issuecomment-1364587359 for more details


## 🐛 Bug

CPU memory will leak if the DataLoader `num_workers > 0`.

## To Reproduce
Run the following snippet:

```
from torch.utils.data import Dataset, DataLoader
from PIL import Image
from torchvision import transforms
import os

class DataIter(Dataset):
    def __init__(self):
        path = "path/to/data"
        self.data = []

        for cls in os.listdir(path):
            for img in os.listdir(os.path.join(path, cls)):
                self.data.append(os.path.join(path, cls, img))

    def __len__(self):
        return len(self.data)

    def __getitem__(self, idx):
        with Image.open(self.data[idx]) as img:
            img = img.convert('RGB')
            return transforms.functional.to_tensor(img)


train_data = DataIter()
train_loader = DataLoader(train_data, batch_size=300,
                          shuffle=True,
                          drop_last=True,
                          pin_memory=False,
                          num_workers=18)

for i, item in enumerate(train_loader):
    if i % 200 == 0:
        print(i)
```
## Expected behavior

CPU memory will gradually start increasing, eventually filling up the whole RAM. E.g., the process starts with around 15GB and fills up the whole 128GB available on the system. 
When the `num_workers=0`, RAM usage is constant.

## Environment

```
PyTorch version: 1.0.0.dev20181028
Is debug build: No
CUDA used to build PyTorch: 9.0.176

OS: Ubuntu 16.04.4 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
CMake version: version 3.5.1

Python version: 3.5
Is CUDA available: Yes
CUDA runtime version: 9.0.176
GPU models and configuration: 
GPU 0: GeForce GTX 1080 Ti
GPU 1: GeForce GTX 1080 Ti
GPU 2: GeForce GTX 1080 Ti

Nvidia driver version: 390.67
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.7.1.4

Versions of relevant libraries:
[pip] Could not collect
[conda] Could not collect

PIL.__version__
'5.3.0'
```

## Additional info
There are around 24 million images in the dataset and all image paths are loaded into a single list as presented in the above code snippet.

I have also tried multiple Pytorch (0.4.0 and 0.4.1) versions and the effect is the same.

cc @ezyang @gchanan @zou3519 @bdhirsh @jbschlosser @anjali411 @SsnL @VitalyFedyunin @ejguan
Repository: flutter
Issue: [Feature Request][CLI] Include setup for Firebase in Flutter CLI
Labels: c: new feature,tool,P3,team-tool,triaged-tool

As developer I want to have the setup for firebase connection automated and baked inside Flutter CLI, something like: 
`flutter firebase`
During that, all steps from Firebase Console in "Add Firebase to your Android/iOS app" will be added automatically to the app.
Repository: neovim
Issue: cannot delete function if a:000 is referenced externally
Labels: vimscript

Given `t-funcref.vim`:

```vim
let s:q = []

function! F1(...)
    call add(s:q, [a:000])
endfunction

" Needs two calls.
call F1({})
call F1({})

" Does not work: Cannot delete function F2: It is being used internally
delfunction F1
q
```

Running `nvim -u t-funcref.vim` results in:

```
Error detected while processing …/t-funcref.vim:
line   12:
Cannot delete function F1: It is being used internally
```

This happens via https://github.com/neovim/neovim/blob/cf93b5e9f9eea1b08ca8d7cb124265867b2f3bf9/src/nvim/eval.c#L21114-L21118, which is not used in Vim.
Adding this check to Vim produces the same error there then.

So this is a problem also in Vim, but it does not make the `delfunction` fail.

The check in Neovim was added early on in 4b98ea1e8 already, and later adjusted/fixed in b7dab423e.

NVIM v0.3.2-755-gcf93b5e9f
Repository: puppeteer
Issue: Web push notification
Labels: feature,chromium,confirmed

How I can subscribe, handle and click on push notification?
Repository: rust
Issue: rustdoc: blanket impls not showing traits with sufficient indirection?
Labels: T-rustdoc,A-synthetic-impls,E-needs-mcve

In the gtk-rs docs, [the page for `Clipboard`](http://gtk-rs.org/docs/gtk/struct.Clipboard.html) doesn't show either the [`ClipboardExt`](http://gtk-rs.org/docs/gtk/trait.ClipboardExt.html) or [`ClipboardExtManual`](http://gtk-rs.org/docs/gtk/prelude/trait.ClipboardExtManual.html) traits, despite both of those traits being available on `Clipboard`.

I *think* this has something to do with the way those traits are implemented. Both extension traits are implemented on `T: IsA<Clipboard>`, where `IsA<T>` is generically implemented for all `<T>`. The `IsA<T>` impl shows up on the `Clipboard` page, but the extension traits do not. Is there a maximum amount of indirection that the trait checker we're using can do? These traits are both usable from regular code.

cc @GuillaumeGomez
Repository: create-react-app
Issue: Errors in IE11 when importing polyfills using es-abstract.
Labels: issue: needs investigation

### Is this a bug report?

Yes

If you import `react-app-polyfill/ie11` before importing any shim/polyfill using `es-abstract` lib, you get an error in IE11 (possibly other browsers as well). Some example polyfills: `object.entries, array-includes, object.values`

Error: `object doesn't support property or method Symbol(Symbol.iterator).9_<some-hash>`
Location: `es-abstract` -> GetIntrinsic.js at line 56.
Workaround: import react-app-polyfill/ie11 after importing all shims/polyfills using `es-abstract`.

### Environment

IE11, presumably anything IE.

### Steps to Reproduce

1. Create new app
2. in index.js, on line 1, `import react-app-polyfill/ie11`
3. in index.js, on line 2, `import objectValues from 'object.values/polyfill'`
4. Open your app in IE11.

### Expected Behavior

App would run.

### Actual Behavior

App crashes.
Repository: vscode
Issue: User needs to be able to control whether or not the issue report seaches duplicates
Labels: feature-request,issue-reporter

Issue Type: <b>Bug</b>

We introduced several settings that allow users to control whether or when VS Code talks to online services. They show when searching for `@tag:usesOnlineServices` in the settings editor.

There is no way to control online service usage for the issue reporter. Neither a checkbox on the issue reporter nor a setting. There should be one since we don't talk to GH directly.

VS Code version: Code - Insiders 1.29.0-insider (4626bc0e1b679d555dd6f034ece35ffc394b3bb7, 2018-10-29T06:11:45.152Z)
OS version: Darwin x64 18.0.0
<!-- generated by issue reporter -->
Repository: vscode
Issue: HTML editing features don't work well in PHP files
Labels: feature-request,php

<!-- Please search existing issues to avoid creating duplicates. --> 
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: Version: 1.28.2 (user setup)
Commit: 7f3ce96ff4729c91352ae6def877e59c561f4850
Date: 2018-10-17T00:23:51.859Z
Electron: 2.0.9
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64
- OS Version: Windows 7

Steps to Reproduce:

1. Create new PHP file
2. Type in div.class, hit tab, hit enter

Current Solution:

Change file type to HTML, and then back to PHP

Proposed solution: 

In a file type where HTML tab-completion works, HTML auto-indenting should also work

<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Quick Google search did not provide clear instructions on how to perform this in Windows.