sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: rust
Issue: Compiler support for Windows TLS destructors
Labels: O-windows,C-enhancement,T-compiler,A-thread-locals

Currently the Windows TLS destructor implementation is held together by hacks in the standard library but it'd be better to have proper compiler support instead. The library implementation is currently in this file: https://github.com/rust-lang/rust/blob/7ab5eb8fe7aee35aea8ed4aed8c34f6abd988cc5/library/std/src/sys/pal/windows/thread_local_key.rs

The short version is that, for `#[cfg(target_thread_local)]` platforms we need the `p_thread_callback` to be associated with `register_keyless_dtor` such that if `register_keyless_dtor` is used in the final binary then `p_thread_callback` will also be included. Currently this is done using a volatile load of the assassinated function but this hack is not recommended.

A similar thing is also necessary for the `#[cfg(not(target_thread_local))]` case. if `register_dtor` is used in the final binary then `p_thread_callback` will also needs including.

In you don't want to go digging around the linked file, here are the relevant definitions:

```rust
`#[cfg(target_thread_local)]`
unsafe fn register_keyless_dtor(t: *mut u8, dtor: unsafe extern "C" fn(*mut u8));
`#[cfg(not(target_thread_local))]`
unsafe fn register_dtor(key: &'static StaticKey);

#[link_section = ".CRT$XLB"]
static p_thread_callback: unsafe extern "system" fn(*mut (), u32, *mut ()) = on_tls_callback;
```

Making sure `p_thread_callback` is included with the register destructor function could be done in a few ways:

## Object file

We could take advantage of object based linkage by writing a single object file containing both symbols. When put in a lib it'll ensure they're both included together. We would of course need some kind of attribute or magic symbol name to tell the compiler how to find these special symbols.

<details><summary>Probably not a good idea</summary>

## COMDAT

The Windows COFF object format has [`IMAGE_COMDAT_SELECT_ASSOCIATIVE `](https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#comdat-sections-object-only) that allows associating one function with another. We could have some rustc attribute that std can use to annotate one symbol as being associated with another and then the compiler would emit the necessary comdat.

This is probably not a good idea because I'm not sure mixing COMDAT sections with special linker sections will work.

</details>
Repository: tensorflow
Issue: `segmentation fault` in `tf.raw_ops.AddManySparseToTensorsMap` when `sparse_indices` and `sparse_values` are empty and `sparse_shape` is too large.
Labels: stat:awaiting tensorflower,type:bug,comp:ops,TF 2.15

### Issue type

Bug

### Have you reproduced the bug with TensorFlow Nightly?

Yes

### Source

binary

### TensorFlow version

tf 2.15

### Custom code

No

### OS platform and distribution

Linux Ubuntu 20.04

### Mobile device

_No response_

### Python version

3.10

### Bazel version

_No response_

### GCC/compiler version

_No response_

### CUDA/cuDNN version

_No response_

### GPU model and memory

_No response_

### Current behavior?

`segmentation fault` in `tf.raw_ops.AddManySparseToTensorsMap` when `sparse_indices` and `sparse_values` are empty and `sparse_shape` is too large, which causes the program to crash. See the colab link below for details.

### Standalone code to reproduce the issue

```shell
https://colab.research.google.com/drive/1KNuiyCMsSo32teT3lNwYyYbQkD9tEBET?usp=sharing
```


### Relevant log output

```shell
segmentation fault (core dumped)
```
Repository: rust
Issue: rustdoc: add dropdowns for the sidebar groups
Labels: T-rustdoc,C-enhancement,A-rustdoc-ui

While reading documentation or viewing a specific module it shows (`Primitive Types`, `Macros` and `Keywords`) on sidebar. It is very overwhelming to scroll up and press `[-]` or to scroll down completely to view `Structs`, `Enums`, `Traits`, `Functions`, etc. Instead they can be placed on the sidebar with dropdowns to navigate easily.
Repository: vscode
Issue: Git - Lose "File History" after Git mv
Labels: feature-request,git,timeline

### Git mv

When you moved a file via `Git mv` you'll lose the complete **File History** in  VSCode.
In the extension **Git Lens** it's still visible.

![image](https://github.com/microsoft/vscode/assets/11474669/77d3e659-3f98-4865-8dff-c55e85b73b59)

\
Git Lense made a **fix** to show (follow) **renamed files** see article:
[https://github.com/gitkraken/vscode-gitlens/issues/2828](https://github.com/gitkraken/vscode-gitlens/issues/2828)

It would be great if VSCode implements this too into to **Filter** of the **File History**.
Repository: yt-dlp
Issue: pre-allocation of disk space
Labels: enhancement,low-priority,core:downloader

### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field

### Checklist

- [X] I'm requesting a feature unrelated to a specific site
- [X] I've looked through the [README](https://github.com/yt-dlp/yt-dlp#readme)
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)

### Provide a description that is worded well enough to be understood

Take youtube for example, `yt-dlp --list-formats`, it shows the size for a specific format, so it's possible to pre-allocate disk space.
BTW, though the size might not be accurate, a workaround is possible.

### Provide verbose output that clearly demonstrates the problem

- [ ] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [ ] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [ ] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below

### Complete Verbose Output

_No response_
Repository: PowerToys
Issue: A rectangular box flashes up for a split second when PowerToys loads...
Labels: Issue-Bug,Product-PowerToys Run,Area-Quality,Priority-3

### Microsoft PowerToys version

0.80.1

### Installation method

PowerToys auto-update

### Running as admin

Yes

### Area(s) with issue?

PowerToys Run

### Steps to reproduce

Lunch PowerTools (e.g. from windows 10 start menu).



### ✔️ Expected Behavior

PowerTools should load and appear in the task tray without any popups.

### ❌ Actual Behavior

A distracting rectangle that flashes up over the desktop background for a split second (see attached screen shot).
![vlc_NC4nrAQkhi](https://github.com/microsoft/PowerToys/assets/166980468/c0572766-a935-4c73-bb45-3a41374b1a87)

I've attached a list of the PowerTools modules I have enabled incase this is relevant.
![powertoys-enabled-modules](https://github.com/microsoft/PowerToys/assets/166980468/30417ce0-ea19-4545-bba3-188615f26b5f)

Looking into the problem a bit further, I think that the 'PowerToys Run' module is causing the issue. The rectangle does not popup when PowerToys is launched with this option is disabled, but it does popup when PowerToys is lauched with the option enabled (and when you just enable the option in PowerTools).

I couldn't find this issue already listed when I searched, so hope it is not a duplicate.

PowerToys is great, thank you for making it. Please could you consider fixing this issue to make it even better?


### Other Software

_No response_
Repository: go
Issue: x/crypto/ssh: allow to change allowed authentication methods
Labels: Proposal,Proposal-Accepted,Proposal-Crypto

### Proposal Details

Now that [CL 516355](https://go-review.googlesource.com/c/crypto/+/516355) has been merged a server can dynamically change allowed authentication methods for a given user by returning a `PartialSuccessError`.

When a `PartialSuccessError` is returned, the "partial success" boolean field in [SSH_MSG_USERAUTH_FAILURE](https://datatracker.ietf.org/doc/html/rfc4252#section-5.1) is set to `true`.

I propose adding a new error that allows to change authentication methods without returning a partial success error

```
// ChangeAuthMethodsError can be returned by any of the [ServerConfig]
// authentication callbacks to change the allowed authentication methods.
type ChangeAuthMethodsError struct {
	Next ServerAuthCallbacks
}

func (e *ChangeAuthMethodsError) Error() string {
	// We return a generic error string.
	return "ssh: authentication failed"
}
```

This is a cleaner approach to allowing modification of authentication methods and will reuse the logic already implemented for `PartialSuccessError`.
Repository: vscode
Issue: Folders cointaining only `.gitignore`d files are sometimes not hidden, disappear only on click
Labels: bug,file-explorer

`coverage.py`'s `htmlcov` output folder contains a `.gitignore` file like this:

```
# Created by coverage.py
*
```

I am using `"explorer.excludeGitIgnore": true`, and so this folder should be hidden. Except, it isn't always, until I click it.

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.88.1
- OS Version: Windows 11 23H2

Steps to Reproduce:

On Windows:
```batch
if exist bug rmdir /s/q bug
mkdir bug
for /l %i in (1,1,20) do (mkdir bug\sub%i && echo *> bug\sub%i\.gitignore)
code.cmd --disable-extensions bug
```

![Code_dOWoC85rl5](https://github.com/microsoft/vscode/assets/12128514/60e72db5-5560-488d-88e2-401deeedb67d)


This issue does not seem to reproduce if I replace `20` with `1` above.
Repository: PowerToys
Issue: Sometimes  the function of ctrl shift tab will be disabled and after I close powertoys(I use keymap but not map it), the key will be activated
Labels: Issue-Bug,Product-Keyboard Shortcut Manager,Needs-Triage

### Microsoft PowerToys version

0.80

### Installation method

Microsoft Store

### Running as admin

No

### Area(s) with issue?

Keyboard Manager

### Steps to reproduce

no

### ✔️ Expected Behavior

ctrl shift tab should back to previous web browser tab.

### ❌ Actual Behavior

sometimes nothing happened

### Other Software

_No response_
Repository: rust
Issue: Reasons for feature removals are not translatable
Labels: A-diagnostics,T-compiler,A-translation

### Code

```Rust
#![feature(box_syntax)]

fn main() {}
```


### Current output

```Shell
error[E0557]: feature has been removed
 --> foo.rs:1:12
  |
1 | #![feature(box_syntax)]
  |            ^^^^^^^^^^ feature has been removed
  |
  = note: replaced with `#[rustc_box]`

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0557`.
```


### Desired output

The note ("replaced with `#[rustc_box]`") should be translatable, rather than hard-coded in `compiler/rustc_feature/src/removed.rs`.


### Rationale and extra context

The `reason` field in `RemovedFeature` cannot simply be replaced with a `DiagMessage` because `rustc_features` cannot depend on `rustc_errors` (cyclic dependency). I don't know how to solve this.

### Other cases

_No response_

### Rust Version

```Shell
rustc 1.79.0-nightly (79424056b 2024-04-12)
binary: rustc
commit-hash: 79424056b05eaa9563d16dfab9b9a0c8f033f220
commit-date: 2024-04-12
host: x86_64-unknown-linux-gnu
release: 1.79.0-nightly
LLVM version: 18.1.3
```


### Anything else?

_No response_
Repository: godot
Issue: PhysicsServer2D `shape_set_data` input format for capsule shapes is inconsistent
Labels: bug,documentation,topic:physics

### Tested versions

- Reproducible in: 4.3.dev5, as well as every other Godot version in the history of the git repository.

### System information

Godot v4.3.dev5 - Ubuntu 22.04.4 LTS 22.04 - X11 - GLES3 (Compatibility) - NVIDIA GeForce RTX 2060 with Max-Q Design - AMD Ryzen 9 4900HS with Radeon Graphics (16 Threads)

### Issue description

The `shape_set_data` method of `PhysicsServer2D` takes a strange input format for capsule shapes:

https://github.com/godotengine/godot/blob/578d937927ea9735aa7a8e0535f57801406b0b82/servers/physics_2d/godot_shape_2d.cpp#L467-L479

That is, it takes either `[height, radius]` or `Vector2(radius, height)`. Probably one of the two was a typo (ever since Godot has been open source). The [documentation of `shape_set_data`](https://docs.godotengine.org/en/latest/classes/class_physicsserver2d.html#class-physicsserver2d-method-shape-set-data) is correct about the array input but incorrect about the vector input. Also, `shape_get_data` will return `Vector2(height, radius)`:

https://github.com/godotengine/godot/blob/578d937927ea9735aa7a8e0535f57801406b0b82/servers/physics_2d/godot_shape_2d.cpp#L485-L487

The [documentation of `shape_get_data`](https://docs.godotengine.org/en/latest/classes/class_physicsserver2d.html#class-physicsserver2d-method-shape-get-data) is incomplete here; it should be more explicit, at least about the cases where it's not clear from the documentation of `shape_set_data`.

### Steps to reproduce

```gdscript
extends Node2D

func _ready() -> void:
	var shape: RID = PhysicsServer2D.capsule_shape_create()
	PhysicsServer2D.shape_set_data(shape, Vector2(10, 50))
	print(PhysicsServer2D.shape_get_data(shape)) # Output: (50, 10)
        PhysicsServer2D.free_rid(shape)
```

### Minimal reproduction project (MRP)

[capsule-convention.zip](https://github.com/godotengine/godot/files/14970459/capsule-convention.zip)
Repository: godot
Issue: When opening a lot of scenes at the same time it can take a lot of time during which the editor will be unresponsive.
Labels: enhancement,topic:editor,performance

### Tested versions

4.3.dev[578d937927ea9735aa7a8e0535f57801406b0b82]

### System information

macOS 13.3.0 - Vulkan (Forward+) - integrated Apple M1 Pro - Apple M1 Pro (8 Threads)

### Issue description

This is similar to #89516. Here it happens when you try to open a lot of scenes at the same time. there is no way to make it go faster so just adding a progress bar would fix it. Same thing happens on closing scenes.

### Steps to reproduce

1. open the MRP
2. select all scenes
3. right click and press "Open Scenes"
4. see the editor being unresponsive
5. right click on one of the scene and select "Close All Tabs"
6. See the editor being unresponsive again

### Minimal reproduction project (MRP)

[LongGroups.zip](https://github.com/godotengine/godot/files/14616584/LongGroups.zip)
this is the mrp from #89516
Repository: transformers
Issue: [i18n-PL] Translating docs to Polish
Labels: WIP

<!--
Note: Please search to see if an issue already exists for the language you are trying to translate.
-->

Hi!

Let's bring the documentation to all the Polish-speaking community 🌐 (currently 0 out of 267 complete)

Who would want to translate? Please follow the 🤗 [TRANSLATING guide](https://github.com/huggingface/transformers/blob/main/docs/TRANSLATING.md). Here is a list of the files ready for translation. Let us know in this issue if you'd like to translate any, and we'll add your name to the list.

Some notes:

* Please translate using an informal tone (imagine you are talking with a friend about transformers 🤗).
* Please translate in a gender-neutral way.
* Add your translations to the folder called `pl` inside the [source folder](https://github.com/huggingface/transformers/tree/main/docs/source).
* Register your translation in `pl/_toctree.yml`; please follow the order of the [English version](https://github.com/huggingface/transformers/blob/main/docs/source/en/_toctree.yml).
* Once you're finished, open a pull request and tag this issue by including #issue-number in the description, where issue-number is the number of this issue. Please ping @stevhliu and @MKhalusova for review.
* 🙋 If you'd like others to help you with the translation, you can also post in the 🤗 [forums](https://discuss.huggingface.co/).

## Get Started section

- [ ] [index.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/index.md)
- [ ] [quicktour.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/quicktour.md)
- [ ] [installation.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/installation.md)

## Tutorial section
- [ ] [pipeline_tutorial.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/pipeline_tutorial.md)
- [ ]  [autoclass_tutorial.md](https://github.com/huggingface/transformers/blob/master/docs/source/autoclass_tutorial.md)
- [ ]  [preprocessing.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/preprocessing.md)
- [ ]  [training.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/training.md)
- [ ]  [accelerate.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/accelerate.md)
- [ ]  [model_sharing.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/model_sharing.md)
- [ ]  [multilingual.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/multilingual.md)

<!--
Keep on adding more as you go 🔥
-->
Repository: go
Issue: proposal: x/crypto/ssh: add NewServerConnContext
Labels: Proposal,Proposal-Crypto

### Proposal Details

It would be useful for `ServerConn` to provide a `NewServerConnContext` method next to `NewServerConn`.

We have to pass `net.Conn` to `NewServerConn` so we can already control deadlines and such externally but I think many of our users just use `NewServerConn` without thinking about it can hang forever. 

```
// NewServerConnContext is like [NewServerConn] but also accepts a context. The
// provided Context must be non-nil. If the context expires before the handshake
// is complete, an error is returned. Once the handshake is completed, any
// expiration of the context will not affect the connection.
func NewServerConnContext(ctx context.Context, c net.Conn, config *ServerConfig) (*ServerConn, <-chan NewChannel, <-chan *Request, error)
```
Repository: rust
Issue: Borrow incorrectly "escapes" function when calling method of blanket impl for `'static` type
Labels: A-diagnostics,T-lang,T-compiler,C-bug,D-incorrect

I tried this code ([playground](https://play.rust-lang.org/?version=nightly&mode=release&edition=2021&gist=d7695998ebe69a0e2eebff79746eebce)):

```rust
trait Trait {
    fn method(&self) {}
}

impl<T: 'static> Trait for T {} // requires 'static blanket impl

fn foo(t: &mut ()) { // requires &mut
    Trait::method(t); // works
    t.method(); // E0521 borrowed data escapes outside of function
}
```

I expected this to compile without error.  Instead, I received E0521:

```text
error[E0521]: borrowed data escapes outside of function
 --> src/lib.rs:9:5
  |
7 | fn foo(t: &mut ()) {
  |        -  - let's call the lifetime of this reference `'1`
  |        |
  |        `t` is a reference that is only valid in the function body
8 |     Trait::method(t); // works
9 |     t.method(); // E0521 borrowed data escapes outside of function
  |     ^^^^^^^^^^
  |     |
  |     `t` escapes the function body here
  |     argument requires that `'1` must outlive `'static`

For more information about this error, try `rustc --explain E0521`.
```

### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->

`rustc --version --verbose`:
```
rustc 1.79.0-nightly (0bf471f33 2024-04-13)
binary: rustc
commit-hash: 0bf471f339837af930ec90ef5e1e9cb232e99f29
commit-date: 2024-04-13
host: aarch64-unknown-linux-gnu
release: 1.79.0-nightly
LLVM version: 18.1.3
```
Repository: flutter
Issue: `AppLifecycleListener` `onHide` and `onInactive` firing at wrong time on iOS
Labels: platform-ios,framework,has reproducible steps,P2,team-ios,triaged-ios,found in release: 3.19,found in release: 3.22

### Steps to reproduce

1. Clone this example repo: https://github.com/mgenware/resign_active_issue
2. Since we need to view native (swift) logs, please run the project in xcode
3. cd ios
4. pod install
5. open and run project in xcode
6. click the "push view controller" button, which presents a `UIDocumentInteractionController`
7. xcode shows the following logs

```
flutter: Flutter inactive
flutter: Flutter hiding
```

The demo also has logs in native `applicationWillResignActive`:

```swift
    override func applicationWillResignActive(_ application: UIApplication) {
        print("Native resignActive")
    }
```

When you pressed the home button, the native `applicationWillResignActive` gets called.

### Expected results

inactive/hide events should not fire when the app is still in foreground.

inactive/hide events should fire when home button is pressed.

the native `applicationWillResignActive` gets called when home button is pressed.

### Actual results

❌ inactive/hide events fired when a new view controller is pushed while the app is still in foreground.

❌ inactive/hide events didn't fire when home button is pressed.

✅ the native `applicationWillResignActive` gets called when home button is pressed.

### Code sample

See repro steps

### Screenshots or Video

<details open>
<summary>Screenshots / Video demonstration</summary>

</details>


### Logs

_No response_

### Flutter Doctor output

<details open><summary>Doctor output</summary>

```console
[✓] Flutter (Channel stable, 3.19.5, on macOS 14.4.1 23E224 darwin-arm64, locale en-CN)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✓] Chrome - develop for the web
[!] Android Studio (not installed)
[✓] VS Code (version 1.88.1)
[✓] Connected device (3 available)
[✓] Network resources
```

</details>