sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: vscode
Issue: Git - Request: don't save document on ranges revert (`git.revertSelectedRanges`)
Labels: git,under-discussion

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

Seems due to this line

https://github.com/microsoft/vscode/blob/eb3625842c55bf30b8f66ac01b20f2a68e5abbd7/extensions/git/src/commands.ts#L1097

Editor is always being saved whenever I run `git.revertSelectedRanges`. And now imagine this case:

(I have `"files.trimTrailingWhitespace": true`)

1. Specific line contains trailing whitespaces.
2. I made change to this line (suppose just replaced one character)
3. I run `git.revertSelectedRanges` and happens the following:
- It actually reverts changes on this line (this is what I wanted)
- Then, save participant for setting above removes trailing whitespaces on the line and line contains changed again

Also, build tool would reload the build whenever I run this command which is also annoying.

I propose the following:

- Replace aforementioned line in source with `await vscode.commands.executeCommand('workbench.action.files.saveWithoutFormatting')`
- Add a setting (or another way) to disable this behavior entirely
Repository: go
Issue: proposal: reflect: reflect.ValueOf(nil).IsNil() panics; let's make it return true
Labels: Proposal,Proposal-Hold

The IsNil method of reflect.Value applies only to typed nils, so this program panics:

```
package main

import	"reflect"

func main() {
	x := reflect.ValueOf(nil)
	x.IsNil()
}

panic: reflect: call of reflect.Value.IsNil on zero Value
```

On the face of it, this is nuts: it says that nil is not nil. (What is this, a NaN? Just joking.) In fact, even asking if nil is nil causes the program to crash!

Every time I dig into uses of reflect, which would be rare except that I "own" several core packages that depend on reflection, I bounce off this. It just sits wrong with me that reflect.ValueOf(nil) gives the zero reflect.Value, but that is "invalid" not nil.

I propose, without thinking through the consequences in nearly enough detail, that either "invalid" becomes different from "value created from literal nil", or that we just change "invalid" to "nil" and allow it to satisfy IsNil.

I'm not sure this can be changed without causing a major ruckus, but I thought I'd at least ask. It might be easy and could clean up a fair bit of code in some places.
Repository: transformers
Issue: Improve EncoderDecoderModel docs
Labels: Good First Issue

## **First good issue**

There have been quite some issues/questions with how to use the Encoder-Decoder model, e.g.: https://github.com/huggingface/transformers/issues/4483 and https://github.com/huggingface/transformers/issues/15479 . The main reason for this is that the model docs are quite outdated and we could need a nice How-to-guide. 

So I think we have two action items here:

1. Improve https://huggingface.co/docs/transformers/v4.17.0/en/model_doc/encoder-decoder#encoder-decoder-models a.k.a.: https://github.com/huggingface/transformers/blob/master/docs/source/model_doc/encoder-decoder.mdx

We should mention here: 
a) How to create a model ? We should show how to use the `from_encoder_decoder_pretrained(...)` and then how to save the model?
b) How to fine-tune this model? We should mention that this model can then be fine-tuned just like any other encoder-decoder model (Bart, T5, ...)
c) Put a big warning that the config values have to be correctly set and how to set them, e.g. read: https://github.com/huggingface/transformers/issues/15479

This should be an `EncoderDecoderModel` specific text and be very concise and short.

In a second step, we should then write a How-to-guide that includes much more details.

More than happy to help someone tackle this first good issue
Repository: flutter
Issue: `Scaffold.of(context).showBottomSheet` crashes
Labels: c: crash,framework,f: material design,team-design,triaged-design

### Steps
1, Show the bottom sheet first
2, Tap the back arrow and the `show bottom sheet` button at the same time
3, Repeat step 2 many times and observe the log output, which can be reproduced with a high probability

### Code
```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Flutter Demo'),
        ),
        body: const MyHomePage(),
      ),
      // home : SizedBox.shrink(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key}) : super(key: key);

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  void bottomSheet() {
    Scaffold.of(context).showBottomSheet((BuildContext context) {
      return const FractionallySizedBox(
        heightFactor: .2,
        child: Center(child: Text('This is a bottom sheet')),
      );
    }, backgroundColor: Colors.amber);
  }

  @override
  Widget build(BuildContext context) {
    return ElevatedButton(
      child: const Text('Show bottom sheet'),
      onPressed: bottomSheet,
    );
  }
}

```

### Crash Log
```dart
E/flutter (22121): [ERROR:flutter/lib/ui/ui_dart_state.cc(198)] Unhandled Exception: 'package:flutter/src/material/scaffold.dart': Failed assertion: line 2366 pos 14: 'bottomSheetKey.currentState != null': is not true.
E/flutter (22121): #0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61)
E/flutter (22121): #1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5)
E/flutter (22121): #2      ScaffoldState._buildBottomSheet._removeCurrentBottomSheet (package:flutter/src/material/scaffold.dart:2366:14)
E/flutter (22121): #3      ScaffoldState._buildBottomSheet.<anonymous closure> (package:flutter/src/material/scaffold.dart:2384:13)
E/flutter (22121): #4      LocalHistoryEntry._notifyRemoved (package:flutter/src/widgets/routes.dart:472:15)
E/flutter (22121): #5      LocalHistoryRoute.didPop (package:flutter/src/widgets/routes.dart:665:13)
E/flutter (22121): #6      _RouteEntry.handlePop (package:flutter/src/widgets/navigator.dart:2896:16)
E/flutter (22121): #7      NavigatorState._flushHistoryUpdates (package:flutter/src/widgets/navigator.dart:3868:22)
E/flutter (22121): #8      NavigatorState.pop (package:flutter/src/widgets/navigator.dart:4910:7)
E/flutter (22121): #9      NavigatorState.maybePop (package:flutter/src/widgets/navigator.dart:4860:9)
E/flutter (22121): <asynchronous suspension>
E/flutter (22121): 
```
Repository: material-ui
Issue: [TextField] `InputLabelProps={{ required: true }}` renders incorrectly
Labels: component: text field,status: expected behavior

### Duplicates

- [X] I have searched the existing issues

### Latest version

- [X] I have tested the latest version

### Current behavior 😯

The asterisk used for required `TextField` components renders differently if using `InputLabelProps={{ required: true }}` to using `required`. The former is useful if you want to roll your own validation.

![image](https://user-images.githubusercontent.com/796702/158166731-ce88c74b-a0e7-4dff-9e35-db0220639ea6.png)

It's subtle but the spacing to the right of the asterisk is missing on the second `TextField`.

So this is OK:

```tsx
<TextField required />
```

This has the missing spacing:

```tsx
<TextField InputLabelProps={{ required: true }} />
```

### Expected behavior 🤔

Using `required` or `InputLabelProps={{ required: true }}` should render the asterisk consistently.

### Steps to reproduce 🕹

https://codesandbox.io/s/clever-frost-fy71ov?file=/src/App.tsx

### Context 🔦

_No response_

### Your environment 🌎

<details>
  <summary>`npx @mui/envinfo`</summary>

```
  System:
    OS: macOS 10.15.7
  Binaries:
    Node: 16.13.2 - ~/.nvm/versions/node/v16.13.2/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.2/bin/yarn
    npm: 8.5.2 - ~/.nvm/versions/node/v16.13.2/bin/npm
  Browsers:
    Chrome: 99.0.4844.51
    Edge: Not Found
    Firefox: 96.0.2
    Safari: 14.1.2
  npmPackages:
    @emotion/react: ^11.8.2 => 11.8.2 
    @emotion/styled: ^11.8.1 => 11.8.1 
    @mui/base:  5.0.0-alpha.71 
    @mui/material: ^5.5.0 => 5.5.0 
    @mui/private-theming:  5.4.4 
    @mui/styled-engine:  5.4.4 
    @mui/system:  5.5.0 
    @mui/types:  7.1.2 
    @mui/utils:  5.4.4 
    @types/react: ^17.0.33 => 17.0.40 
    react: ^17.0.2 => 17.0.2 
    react-dom: ^17.0.2 => 17.0.2 
    typescript: ^4.5.4 => 4.6.2 
```
</details>
Repository: PowerToys
Issue: Fancy Zones Device Emulation Resolution
Labels: Idea-Enhancement,Product-FancyZones,Needs-Triage

### Description of the new feature / enhancement

Include a standard set of device emulation resolutions like most common PC screen sizes, most popular phone resolutions, most popular tablet resolutions. 

### Scenario when this would be used?

These would be great not only for development but also for screen presentations in online meetings.

### Supporting information

https://gs.statcounter.com/screen-resolution-stats
Repository: kubernetes
Issue: client-go: emit warnings for caller of client-go, not client-go itself
Labels: kind/feature,sig/instrumentation,lifecycle/frozen,triage/accepted

### What would you like to be added?

When client-go warns about something, for example a deprecated API, the source code location is warnings.go, the file which calls klog.Warn:
```
W0314 13:55:48.179221  213236 warnings.go:70] storage.k8s.io/v1beta1 CSIStorageCapacity is deprecated in v1.24+, unavailable in v1.27+; use storage.k8s.io/v1 CSIStorageCapacity
```

The corresponding backtrace is:
```
(dlv) bt
 0  0x00000000034d0b12 in k8s.io/client-go/rest.WarningLogger.HandleWarningHeader
    at ./vendor/k8s.io/client-go/rest/warnings.go:70
 1  0x00000000034d2db6 in k8s.io/client-go/rest.(*WarningLogger).HandleWarningHeader
    at <autogenerated>:1
 2  0x00000000034d0df4 in k8s.io/client-go/rest.handleWarnings
    at ./vendor/k8s.io/client-go/rest/warnings.go:144
 3  0x00000000034cb71a in k8s.io/client-go/rest.(*Request).transformResponse
    at ./vendor/k8s.io/client-go/rest/request.go:1081
 4  0x00000000034ca2ab in k8s.io/client-go/rest.(*Request).Do.func1
    at ./vendor/k8s.io/client-go/rest/request.go:966
 5  0x00000000034c9d42 in k8s.io/client-go/rest.(*Request).request.func2.1
    at ./vendor/k8s.io/client-go/rest/request.go:923
 6  0x00000000034c9ae6 in k8s.io/client-go/rest.(*Request).request.func2
    at ./vendor/k8s.io/client-go/rest/request.go:948
 7  0x00000000034c95b9 in k8s.io/client-go/rest.(*Request).request
    at ./vendor/k8s.io/client-go/rest/request.go:950
 8  0x00000000034ca072 in k8s.io/client-go/rest.(*Request).Do
    at ./vendor/k8s.io/client-go/rest/request.go:965
 9  0x000000000396f3c8 in k8s.io/client-go/kubernetes/typed/storage/v1beta1.(*cSIStorageCapacities).Create
    at ./vendor/k8s.io/client-go/kubernetes/typed/storage/v1beta1/csistoragecapacity.go:123
```

It would be nicer if that source code location was the caller of client-go.

### Why is this needed?

Application developers then get a hint about which code they need to change without having to use a debugger or learn about (already deprecated!) klog features like `-log_backtrace_at`.
Repository: go
Issue: x/build: update OpenSSH version on Windows builders
Labels: OS-Windows,Builders,NeedsInvestigation

In the course of looking into #51602, I took a look at the Windows `gomote` configuration.

As best as I can tell (from looking at https://cs.opensource.google/go/x/build/+/master:env/windows/startup.ps1;l=112-124;drc=114c42eb0ee190263854336c7f1e8bc36d53c03f) the builder is running Win32-OpenSSH v0.0.18.0, which was tagged July 19, 2017.

When attempting to reproduce the test failure in #51602 on a local machine, I installed OpenSSH on my machine using the process described in https://docs.microsoft.com/en-us/windows-server/administration/openssh/openssh_install_firstuse#install-openssh-using-windows-settings, and `sshd --version` reports that Windows itself installs `OpenSSH_for_Windows_8.1p1, LibreSSL 3.0.2`. That appears to correspond to [`v8.1.0.0p1-Beta`](https://github.com/PowerShell/Win32-OpenSSH/releases/tag/v8.1.0.0p1-Beta), tagged Dec. 18, 2019.

The most recent Win32-OpenSSH tag at the moment appears to be [`V8.6.0.0p1-Beta`](https://github.com/PowerShell/Win32-OpenSSH/releases/tag/V8.6.0.0p1-Beta), tagged May 27, 2021.

In order to keep the Go project's builders in line with what Go users are likely to actually observe on their deployments — and to help keep up to date with any OpenSSH security fixes that may have been published in the interim — I suggest that we update the OpenSSH install on the Windows builders to at least `v8.1.0.0p1-Beta`.

(CC @golang/release, @golang/security)
Repository: opencv
Issue: Simulator build on iOS is not linked 
Labels: duplicate,question (invalid tracker),category: build/install,platform: ios/osx

I have a custom built opencv library for iOS build with all targets:
opencv2: Mach-O universal binary with 5 architectures: [arm_v7:current ar archive] [arm_v7s] [i386] [x86_64] [arm64]
opencv2 (for architecture armv7):	current ar archive
opencv2 (for architecture armv7s):	current ar archive
opencv2 (for architecture i386):	current ar archive
opencv2 (for architecture x86_64):	current ar archive
opencv2 (for architecture arm64):	current ar archive

It gives me the following error while linking the framework and building for simulator:
<directory>/frameworks/opencv2.framework/opencv2(Point2d.o), building for iOS Simulator, but linking in object file built for iOS, file '<directory>/opencv2.framework/opencv2' for architecture arm64


##### System information (version)

- OpenCV: 4.2
- Operating System / Platform => MacOSX 12.2 (21D49) / apple silicon (this might be my problem)
- Compiler => new build system (clang etc.)

The device build runs correctly, only the simulator build is not linking. Any help is appreciated.
Repository: flutter
Issue: Provide a way to calculate relative BoxConstraints for _ModalBottomSheet 
Labels: c: new feature,framework,f: material design,f: routes,c: proposal,team-design,triaged-design

When using `showModalBottomSheet()` the route that is created can be given a `BoxConstraints`. However these constraints are fixed and are not updated when the `MediaQueryData` changes. This creates a small inconvenience for developers.

## Use case

I needed to show a modal bottom sheet on mobile and web. When resizing the window on web, the modal bottom sheet _itself_ does not react to MediaQueryData changes. This is especially apparent when passing a `minWidth` in the constraints, that is based off the screen width.

## The solution

Implementing my own `PopupRoute` and passing that to `navigator.push()` did the trick for me. I just take the `MediaQueryData` via a Builder and create BoxConstraints from there.

However, most of the code that is needed to create this specific `PopupRoute` (essentially a full copy of `_ModalBottomSheetRoute` and relevant widgets) is *private* in the SDK. The only thing that I actually needed was a small adjustment to the Builder.

## Proposal

Either make the classes that can be reused public _or_ provide a way to compute the BoxConstraints, given the `BuildContext` of the internal builder. I.e. 

```
BoxConstraints? Function(BuildContext)? constraintsBuilder;

Builder(
  builder: (context){
     final boxConstraints = constraintsBuilder?.call(context) ?? constraints;

    // rest of the code
  }
)
```

cc @guidezpl
Repository: create-react-app
Issue: MDX does not work with CRA 5.0.0
Labels: needs triage,issue: bug report

### Describe the bug

The current CRA version cannot load MDX content. It seems to be an issue with the Webpack config in `react-scripts`. Discussion on the MDX GitHub Q&A here:
https://github.com/mdx-js/mdx/discussions/1870

Possible remedy here:
https://github.com/mdx-js/mdx/discussions/1870#discussioncomment-2304871

(It works for me, changing the exclude line mentioned to include `mdx`, but I don't know if there are other considerations.)

### Did you try recovering your dependencies?
N/A

### Which terms did you search for in User Guide?
mdx, webpack

### Environment

Environment Info:

  current version of create-react-app: 5.0.0
  running from ${HOME}/.npm/_npx/c67e74de0542c87c/node_modules/create-react-app

  System:
    OS: macOS 12.2.1
    CPU: (8) arm64 Apple M1 Pro
  Binaries:
    Node: 17.6.0 - ~/.nvm/versions/node/v17.6.0/bin/node
    Yarn: Not Found
    npm: 8.5.1 - ~/.nvm/versions/node/v17.6.0/bin/npm
  Browsers:
    Chrome: 99.0.4844.51
    Edge: Not Found
    Firefox: Not Found
    Safari: 15.3
  npmPackages:
    react: Not Found
    react-dom: Not Found
    react-scripts: Not Found
  npmGlobalPackages:
    create-react-app: Not Found

### Steps to reproduce
https://mdxjs.com/docs/getting-started/#create-react-app-cra

1. `npx create-react-app mdx-example`
2. `cd mdx-example`
3. `npm install @mdx-js/loader`
4. Per the CRA "getting started" instructions from MDX, create a file `src/content.mdx`:
```
# Hello, world!

This is **markdown** with <span style={{color: "red"}}>JSX</span>: MDX!
```
5. Change `src/App.js` to contain:
```
/* eslint-disable import/no-webpack-loader-syntax */
import Content from '!@mdx-js/loader!./content.mdx'

export default function App() {
  return <Content />
}
```
6. `npm run start`

### Expected behavior
Webpage should open with an h1 and p element, as written in the .mdx file.

### Actual behavior

Webpage is blank, and there is an error in the console regarding loading the mdx component:

<img width="1080" alt="Screen Shot 2022-03-14 at 11 37 26 AM" src="https://user-images.githubusercontent.com/2752623/158209225-e5b2d85b-50cb-4ff0-95f6-aa42aad27e0e.png">

### Reproducible demo
https://github.com/zingbretsen/cra-mdx-bug

You should be able to run
```
npm install
npm run start
```
Repository: create-react-app
Issue: Webpack could not deduce aliases from TS / JS config file.
Labels: needs triage,issue: bug report

### Describe the bug

After setting up, and using path mappings in `tsconfig.json` file, webpack gives module resolution error.
```
Module not found: Error: Can't resolve '@module' in '/path/frontend/src/file'
 @ ./src/App.tsx 7:0-46 22:30-42
 @ ./src/index.tsx 7:0-24 11:33-36
```

### Did you try recovering your dependencies?

Yes


### Which terms did you search for in User Guide?

Webpack resolve, alias
Typescript path mappings
Module not found: Error: Can't resolve '@module' in 'path/to/file'


### Environment

Using yarn v1.22.17
Node: v14.17.6
OS: MacOS 12.2.1
CPU: Apple M1


### Steps to reproduce

1. `yarn create react-app frontend --template typescript`
2. Add `baseUrl` and `paths` to `compilerOptions` in `tsconfig.json` file
3. `yarn start`


### Expected behavior

Webpack should get module aliases from `tsconfig.json` file.


### Actual behavior

Webpack gives `Module not found` error.
Repository: tensorflow
Issue: Tracker for TensorFlow-DirectML
Labels: type:others

cc: @PatriceVignola @wchao1115

This issue tracks pending PRs, issues, and possible cherry-picks necessary for TensorFlow-DirectML for each TF release. Please post a comment with new things to track and I will update this post to reflect the changes.

New PRs:
* https://github.com/tensorflow/tensorflow/pull/56707
    * Awaiting internal discussion in the TensorFlow team.
* https://github.com/tensorflow/tensorflow/pull/55677

PRs that need more investigation.
* #55382 [A similar PR broke tests before so this can't go in until the issue is resolved.]
* https://github.com/tensorflow/tensorflow/pull/55381 
    * Reverted because it broke internal tests. 

PRs that made it into TF nightly (post r2.10 branch cut):
* #51759 
* https://github.com/tensorflow/tensorflow/pull/55544 
* https://github.com/tensorflow/tensorflow/pull/55557
* https://github.com/tensorflow/tensorflow/pull/55579
* https://github.com/tensorflow/tensorflow/pull/52157

PRs that made it into TF 2.10:
* https://github.com/tensorflow/tensorflow/pull/55379
    * Resubmitted in https://github.com/tensorflow/tensorflow/pull/55640
* https://github.com/tensorflow/tensorflow/pull/55678
* https://github.com/tensorflow/tensorflow/pull/55645
* https://github.com/tensorflow/tensorflow/pull/55558

PRs that made it into TF 2.9:
* #55173 
* #54468 
* #54139
* #51758
* https://github.com/tensorflow/tensorflow/pull/55384 
* https://github.com/tensorflow/tensorflow/pull/55385 
* https://github.com/tensorflow/tensorflow/pull/55386 
* https://github.com/tensorflow/tensorflow/pull/55387 
* https://github.com/tensorflow/tensorflow/pull/55392
* https://github.com/tensorflow/tensorflow/pull/55393
* https://github.com/tensorflow/tensorflow/pull/54746
* https://github.com/tensorflow/tensorflow/pull/55395

Closed PR:
* #55362
Repository: flutter
Issue: Disable ios screen rotation in device health check
Labels: team-infra,good first issue,P2,infra: device doctor,triaged-infra

The test beds should get quarantined if the screen rotation is enabled. Android check has been available in https://github.com/flutter/cocoon/pull/1532. We need to do the same for ios phones.
Repository: flutter
Issue: Create a splash effect that matches the Material 3 ripple effect without sparkles
Labels: framework,f: material design,team-design,triaged-design

For Android, InkSparkle is the splash factory for material. For all other platforms, a ripple that is like InkSparkle, but does not have sparkles, should be used.

Everything is the same: motion, soft edges, etc. This version is to be used on non-Android platforms that use Material 3 and does _not_ need a custom shader.

The implementation is very close to InkRipple, but the paint needs to aa MaskFiler with BlurStyle.normal for soft edges. The curves and animations are identical to the one's already defined in InkSparkle.
Repository: pytorch
Issue: [DDP] Parallelize initialization collectives
Labels: oncall: distributed,triaged,better-engineering,pt_distributed_rampup,module: ddp

### 🚀 The feature, motivation and pitch

Currently during DDP init, there are 3 collectives that go on now:

1. parameter size verification
2. parameter shape verification
3. parameter broadcast

These are currently implemented seriallly, i.e. we kick off (1), wait for (1), then check for errors, kick off (2), ... etc. See https://github.com/pytorch/pytorch/pull/74113/files#r826105429 for discussion.

We could make these all async, and wait on all three, and register then() callbacks on the first two to raise appropriate errors.

### Alternatives

_No response_

### Additional context

_No response_

cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @SciPioneer @H-Huang