sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: terminal
Issue: Add a setting to display Command Palette ActionMode entries in MRU order
Labels: Area-UserInterface,Area-Settings,Product-Terminal,Issue-Task,Priority-3,Area-CmdPal

Omitted from initial implementation in #6635.

It would be a neat idea to allow display command-palette entries either heavily weighted towards MRU items, or specifically start the empty list with the MRU items, followed by everything else.

We might as well stick this behind a setting.
Repository: go
Issue: x/net/trace: data race when freeing traces
Labels: NeedsInvestigation

This bug is on `go version go1.14.4 linux/amd64` with x/net from master (techincally 627f9648deb96c27737b83199d44bb5c1010cbcf).

There is a race condition between event recycling and trace clearing when the trace has a recycler set with `SetRecycler` and the number of events in tr.events is <= 4 (`len(tr.eventBuf)`).  When a trace is initialized, `tr.events` is set to `tr.eventsBuf[:0]`.  In `unref`, the freeing logic starts a recycling function over each event in a separate goroutine by retaining a reference to the `tr.events` slice, and then calls `freeTrace` and then `reset` to write a zero value to each element of the `eventsBuf` array.  When the number of events added to the trace fits in the space reserved by `tr.eventsBuf`, `tr.events` just aliases that buffer, and so the order of reads and writes is non-deterministic.  The freeing could run first, and thus the recycler function sees the zero-valued events written by `reset`, or the recycling goroutine could run first, in which case the recycling performs as expected.

https://github.com/golang/net/pull/75 (https://go-review.googlesource.com/c/net/+/238302) adds a test and a fix for this.  If you patch in only the test and run "go test -race ." in the trace directory, you'll see that the race detector detects this data race.  My fix makes a copy of `tr.events` if the number of events is less than or equal to the length of `tr.eventsBuf`, so that the recycler can run at its leisure.  Obviously this is not ideal, as the whole point of eventsBuf and the trace pool is to avoid allocations.  However, I get the feeling that people don't actually use event recyclers, or they would have already noticed that events don't get recycled and filed a bug like this ;)

Other options that could be considered are doing the entire free asynchronously (letting the refcount hit 0, doing recycling and freeing in the background, and then pushing the trace into the pool that newTrace draws from), or just doing the recycling synchronously (which probably breaks existing code that did something silly like `tr.SetRecycler(func (e interface{}) { ch <- e }); tr.Finish(); <-ch`).  Let me know which approach you prefer, and I'll update the PR accordingly.
Repository: pytorch
Issue: Print values (but not strings) when STRIP_ERROR_MESSAGES is defined
Labels: module: internals,module: bootcamp,triaged

Currently, to save binary size on mobile builds, we completely remove all error message strings. This can make it difficult to debug problems as some parts of the error output (namely various runtime values which would have been incorporated into the error message string) get suppressed entirely. It is not so convenient to attach gdb to a mobile program.

The idea of this issue is to modify `c10/util/Exception.h` so instead of unconditionally dropping all error messages, we only drop error messages if they are string constants (which could be determined by cross-referencing with the source code) and just retain printing of the actual values in question. One way to do this is by adding a variant of `c10::str` that drops `const char*` arguments but behaves like `c10::str` otherwise, and using it when `STRIP_ERROR_MESSAGES` is defined.

To validate this change, you will need to check two things:
* You will need to run fbcode build size check ("Schedule Android Build Size check" in Utilities in Phabricator) and show that you don't regress build size by too much (one useful experiment to do is eliminate `STRIP_ERROR_MESSAGES` entirely and see how much build size increases). @ljk53 has also developed a script to do a similar analysis in Open Source at https://www.internalfb.com/intern/paste/P134182149/ (FB-only; Jiakai, we should figure out how to clean this up to work in OSS only)
* You should build PyTorch with `STRIP_ERROR_MESSAGES` and verify that the values are being printed out in a reasonable way.  This could be done by editing `CFLAGS` environment variable

cc @ezyang @bhosmer @smessmer @ljk53
Repository: godot
Issue: Label text glitches with resized custom project font
Labels: bug,topic:gui

https://github.com/godotengine/godot/issues/15023 text glitch by creating font during _draw()
https://github.com/godotengine/godot/issues/19309 text glitch by resizing font during _draw()

**Godot version:** 3.2.1.stable


**OS/device including version:** Arch linux

**Issue description:** Label text appears as unreadable blocks when resizing its font.

**Steps to reproduce:**

Set a custom DynamicFont under Settings→Gui→Theme→Custom_Font. Then create a Label and call `$Label.get_font('font').size += 1`. The Label's text will get glitched and show as blocks:
![s](https://user-images.githubusercontent.com/6108978/85447885-61473580-b596-11ea-8e36-990470052c7e.png)

**Minimal reproduction project:**
[label_default_font_resize.zip](https://github.com/godotengine/godot/files/4821421/label_default_font_resize.zip)

**workaround:**

Call either

```gdscript
$Label.get_font('font').connect('changed', $Label, 'update')
```

or

```gdscript
 $Label.add_font_override('font', $Label.get_font('font'))
```

anytime before resizing the font.

I skimmed the source of label.cpp but given the simple workaround and the other issues concerning font caching I didn't dig deeper.
Repository: flutter
Issue: Engine builds for Fuchsia have tons of warnings for icu
Labels: engine,dependency: dart,platform-fuchsia,P2,team-engine,triaged-engine

Multiple icu libraries causing problems for Fuchsia roll.

Repro steps:

From `engine/src` run: `./flutter/tools/gn --fuchsia`.

We get:

```
ninja: warning: multiple rules generate obj/third_party/icu/source/common/icuuc_cr.uvectr32.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]
ninja: warning: multiple rules generate obj/third_party/icu/source/common/icuuc_cr.uvectr64.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]
ninja: warning: multiple rules generate obj/third_party/icu/source/common/icuuc_cr.wintz.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]
ninja: warning: multiple rules generate obj/third_party/icu/source/stubdata/icuuc_cr.stubdata.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]
```

Though these are warnings, they go on to cause problems further down in the roll.

This was the engine roll that introduced the problem: https://github.com/flutter/engine/commit/60a9b85f069abb6386d1f89e0098384236e02d88

This was the roll that introduced the icu changes to dart: https://dart-review.googlesource.com/c/sdk/+/150524

https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2236407 seems to changing the way ICU is built. I wonder if the symbols need to be hidden for `is_fuchsia` as well.


cc: @mkustermann , @a-siva , @chaselatta
Repository: tensorflow
Issue: tf.nn.ctc_beam_search_decoder does not pick path with highest probability at next time step
Labels: stat:awaiting tensorflower,type:bug,comp:apis,TF 2.4

<em>Please make sure that this is a bug. As per our
[GitHub Policy](https://github.com/tensorflow/tensorflow/blob/master/ISSUES.md),
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template</em>

**System information**
- Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Yes
- OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Colab Env (Linux Ubuntu 18.04)
- Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
N/A
- TensorFlow installed from (source or binary):
Binary (I think)
- TensorFlow version (use command below):
v2.2.0-0-g2b96f3662b 2.2.0
- Python version:
3.6.9
- Bazel version (if compiling from source):
N/A
- GCC/Compiler version (if compiling from source):
N/A
- CUDA/cuDNN version:
N/A
- GPU model and memory:
None

You can collect some of this information using our environment capture
[script](https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh)
You can also obtain the TensorFlow version with:
1. TF 1.0: `python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"`
2. TF 2.0: `python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"`


**Describe the current behavior**

The built-in CTC beam search decoder sometimes chooses a less probable path to keep in the beam by default than it could've when expanding a given step. In the Colab example provided below, I give a concrete example of when the path (0,) is retained in the beam instead of (0, 1, 0) despite the latter having a greater log-probability.

**Describe the expected behavior**

(0, 1, 0) should remain in the beam; (0,) should not.

**Standalone code to reproduce the issue**
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.

https://colab.research.google.com/drive/1i9gvj0VN2gMNloohbHW6ad3Ti7eiQQCM?usp=sharing

**Other info / logs** Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

When I was comparing against a simple python version [based off this Medium article](https://towardsdatascience.com/beam-search-decoding-in-ctc-trained-neural-networks-5a889a3d85a7), I noticed that whenever the results diverged, the root problem was always that a path that should've been kept in the beam wasn't. I suspect top-k sorting might be mucking up somewhere.

Thanks,
Sean
Repository: flutter
Issue: web engine: _applyParagraphStyleToElement doesn't always use _effectiveFontFamily
Labels: framework,engine,a: typography,platform-web,c: rendering,e: web_html,P2,team-web,triaged-web

The below doesn't look right and could be a source of unexpected font changes:

```
  if (previousStyle == null) {
    cssStyle.fontFamily = canonicalizeFontFamily(style._effectiveFontFamily);
  } else {
    if (style._fontFamily != previousStyle._fontFamily) {
      cssStyle.fontFamily = canonicalizeFontFamily(style._fontFamily);
    }
  }
```

The `else` case should also use `_effectiveFontFamily` I'd think.
Repository: PowerToys
Issue: [KBM] Exporting and loading Key remap file / presets 
Labels: Idea-Enhancement,Product-Keyboard Shortcut Manager

# Summary of the new feature/enhancement

A feature that allows groups of remapped keys to be activated or deactivated quickly.

# Proposed technical implementation details (optional)

I would like to either have a save and load button that allows me to save the remapped keys to a file and then load them back in.
OR to have several groups of keys that can be remapped and then have those groups be toggleable like this:
![e91d2458c5d48ffc5c6b3be7426314e1](https://user-images.githubusercontent.com/3951049/85465704-f37f1780-b55d-11ea-9040-363f1d2d471a.png)
Repository: flutter
Issue: web engine: review nullness of colorToCssString
Labels: engine,platform-web,has reproducible steps,a: null-safety,P2,found in release: 3.3,found in release: 3.6,team-web,triaged-web

`colorToCssString` currently accents and returns null, but does it really need to? We might want to convert it to non-null.
Repository: pytorch
Issue: jit's default dtype is different in sandcastle and test_jit.py
Labels: oncall: jit,module: tests,triaged

Reproduction: Script and run `torch.full((2, 2), 1.)` in test_jit (discovered in test_save_load.py, in particular) and review the dtype, compare with the dtype in Sandcastle.

cc @suo @gmagogsfm @mruberry
Repository: pytorch
Issue: please add 'tensor.astype(dtype_string)' syntax for numpy interoperability
Labels: triaged,enhancement,module: numpy

## 🚀 Feature
to maximize interoperability with existing numpy code, users can write strings for dtypes `dtype='uint8'`

## Motivation

to make helper function code work as much as possible across numpy and torch, sometimes we have to convert stuff to different dtype. if torch.tensor had `x.astype('float32')` then a huge range of functions can work in both torch and numpy (cuz the rest is just operators) 

here's exactly what I want to do:

```
def rescale(x_min, x_max, y_min, y_max, x):
    x_range = x_max - x_min
    y_range = y_max - y_min
    y = (((x - x_min) * y_range) / x_range) + y_min
    return y
``` 
alas, it doesn't always work if the arguments are integers, they must be cast to float. that simple everyday task requires a special function and extra code (and more tests), if there is no common way to cast stuff to float

## Pitch

just add `astype(self, typestring)` method to the torch.tensor class, and have it take the same strings folks use for numpy, and map them to the corresponding torch types, and then we can always do x.astype('float32') in our helper function and it won't crash if we're using the helper function on a tensor

## Alternatives

we could write a special function to look at a variable and see if it's a ndarray or tensor and invoke the correct method to convert type

```
TORCH_TYPE_LOOKUP = { 'float32': torch.float32 }
def cast(maybe_tensor, typestring):
  if torch.is_tensor(maybe_tensor):
     return maybe_tensor.to(TORCH_TYPE_LOOKUP[typestring])
  return maybe_tensor.astype(typestring)
```
^^ doable, just adds work for everyone

## Additional context

thank you for building pytorch ... the numpy api is huge and obviously i wouldn't expect 1:1 copy of everything, but if we chip away at major stuff then it's gonna be a lot easier to get more done with less code in the long run

cc @mruberry
Repository: angular
Issue: Forms: refactor min/max and minLength/maxLength validators to share the code
Labels: refactoring,area: forms,forms: validators,P4

Currently the min/max and minLength/maxLength validators in the `packages/forms/src/validators.ts` file have their own implementations. We should consider generating these validators using common factory functions (one for min/max and another one for minLength/maxLength). The benefits of this approach: unification of validators and reducing the payload size. One of the problems is that `minLength` and `maxLength` validators are not fully consistent atm, when `minLength` supports optional controls (it has the `isEmptyInputValue` check), when the `maxLength` one does not. Aligning `minLength` and `maxLength` validator's logic (so that this logic can be extracted to a common function) would require a breaking change (i.e. make `maxLength` support optional controls as well).

Pseudo-code to illustrate the proposal:
```
function createLengthValidator(check: 'min'|'max'): (limit: number) => ValidatorFn { ... }

export class Validators {
  ...
  static minLength(minLength: number): ValidatorFn = createLengthValidator('min');
  ...
  static maxLength(minLength: number): ValidatorFn = createLengthValidator('max');
  ...
}
```
Repository: go
Issue: net/http: add support for creating proxied TLS connections
Labels: NeedsInvestigation,FeatureRequest

`DialTLSContext` is [documented](https://github.com/golang/go/blob/9f33108dfa22946622a8a78b5cd3f64cd3e455dd/src/net/http/transport.go#L145-L146) as only being used for non-proxied requests.

This is problematic because it means HTTPS CONNECT requests [always](https://github.com/golang/go/blob/9f33108dfa22946622a8a78b5cd3f64cd3e455dd/src/net/http/transport.go#L1679) use `crypto/tls`. This can violate business requirements and so on. (And can also lead to difficult to debug errors if you, uh, forget that `DialTLSContext` is only for non-proxied requests. Or if the proxy is added later.)

Ideally, `Transport` would have a `Client(net.Conn, ...) net.Conn` field that, if nil, would default to `crypto/tls`.
Repository: pytorch
Issue: torch.autograd.functional.* for models
Labels: module: autograd,triaged,enhancement

## 🚀 Feature
<!-- A clear and concise description of the feature proposal -->

## Motivation

<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->
Sometimes, for some small models, we are interested in computing the Hessian of model parameters. `torch.autograd.functional.*` provides a handy function for that, but only for tensors instead of models (parameters). Although users could manually specify the computation of models the `tensors`, it's not pretty convenient for moderately sophisticated models.

## Pitch

<!-- A clear and concise description of what you want to happen. -->
In addition to the current function signature `torch.autograd.functional.jacobian(func, inputs, create_graph=False, strict=False)`, additionally provide a version where `nn.Module` instead of `inputs` can be used as input, the function will return the Jacobian/Hessian/etc w.r.t. model parameters.

I believe with the current function signature, this is already possible (e.g., by manually specifying the computation graph), but would love to have a cleaner way to do it.

## Alternatives

<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->

## Additional context

<!-- Add any other context or screenshots about the feature request here. -->


cc @ezyang @SsnL @albanD @zou3519 @gqchen
Repository: flutter
Issue: Image.memory retains the Uint8List
Labels: framework,c: performance,customer: google,a: images,perf: memory,P2,team-framework,triaged-framework

Reported by internal user

If you use `Image.memory`, the Uint8List backing the image is retained.

We should probably rework the key structure there so that the Uint8List backing the image is not part of the key.
Repository: flutter
Issue: Trailing whitespace in android/app/src/main/res/values/styles.xml
Labels: tool,a: quality,dependency: android,P3,found in release: 1.22,found in release: 1.27,team-tool,triaged-tool

If I do `flutter create blah`, create a git repo, add everything then temporarily move `.git` to parent directory, and run this expression I found on the internet:

~~find . -type f -name "*" -exec perl -p -i -e "s/[ \t]$//g" {} \;~~

EDIT: I'm not sure if that will bork your repo, so maybe this report is safer: 

```
find . -type f -exec egrep -l " +$" {} \;
```

Then I find the following diff:

```diff
% git diff
diff --git a/android/app/src/main/res/values/styles.xml b/android/app/src/main/res/values/styles.xml
index 1f83a33..980728c 100644
--- a/android/app/src/main/res/values/styles.xml
+++ b/android/app/src/main/res/values/styles.xml
@@ -10,7 +10,7 @@
          This theme determines the color of the Android Window while your
          Flutter UI initializes, as well as behind your Flutter UI while its
          running.
-         
+        
          This Theme is only used starting with V2 of Flutter's Android embedding. -->
     <style name="NormalTheme" parent="@android:style/Theme.Black.NoTitleBar">
         <item name="android:windowBackground">@android:color/white</item>
```

Shouldn't the trailing whitespace not be here?
Repository: go
Issue: x/tools/internal/invoke/gocommand: tests are timing out
Labels: OS-Darwin,Builders,NeedsInvestigation,Tools

Seems like a lot of tests are timing out on the builders ([example failure](https://build.golang.org/log/c8c8eee5d06746ddf7f1bc8900be313d051d2b77)). From the logs, my guess is that a serial `go` command invocation isn't returning in a reasonable amount of time, and it is blocking all the other go commands from running. A possible solution (or at least a first step for debugging) would be putting a timeout on a `go` command invocation.

/cc @heschik
Repository: go
Issue: x/tools/gopls: convert 'gofumpt' from formatter to code action provider
Labels: Thinking,FeatureRequest,gopls,Tools

Add an analyzer that produces suggested fixes using https://pkg.go.dev/mvdan.cc/gofumpt/format?tab=doc.
The tricky part is that the dependency will have to live in the `gopls` module, since it's not a `golang.org/x/...` dependency. That means the analyzer will have to be in that module, and we won't be able to have any internal/lsp tests for this behavior until #35880 is resolved.

/cc @joshbaum @mvdan
Repository: excalidraw
Issue: Lines of text change line spacing between OSes
Labels: bug

**Problem Summary/Recreation**
- Chrome 83.0.4103.116 on macOS 10.15.5 Catalina
- Chrome 83.0.4103.116 on Windows 10 v1909

I've been working on a project for a little while, and I switch between the two above computers to do work. One is a Windows OS and the other is macOS. I use a lot of new lines for multi-line text in my diagrams (Shift+Enter).

When I finish and push my changes on Windows, then pull changes and open the same Excalidraw file on the browser on my mac, the line spacing changes.

You can recreate this by opening one of the `*.excalidraw` roadmap files in this repository on a macOS machine and double-clicking one of the bodies of text:
https://github.com/Static-Void-Academy/complete-software-roadmap

I know that Windows / DOS uses both CR-LF vs. *nix which uses just LF. Might that be the issue here?

Edits: Add clarity to reproduce