sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: pytorch
Issue: nccl comm init needs a global barrier.
Labels: module: cuda,triaged,module: nccl

## 🐛 Bug

see https://github.com/NVIDIA/nccl/issues/581

In short, Currently nccl init in PyTorch only guarantees local nccl comm completion, but in some cases this can cause hang (other rank init completed and calls the communication primitive, but the local rank is still in the init phase, which may create a subtle circular dependency). Is there a need for a global sync after the local comm init completed? From my point of view, this should be more about nccl not guaranteeing the semantic correctness of rank init + group end, but adding a double guarantee in PyTorch seems to be an option to consider. The comm init will only happen a few times during the lifetime of the training task and can be traded for a more stable performance with negligible performance overhead. Currently hang is a real pain when training with PyTorch + NCCL, and it is very much hoped that the community will make progress in this topic.



cc @ngimel
Repository: rust
Issue: Converting from Vec<&str> to &[&str] provides little output.
Labels: A-diagnostics,T-compiler

I described this problem on this [StackOverflow question](https://stackoverflow.com/q/69535907/124486). I'm migrating from using `Vec<&str>` to the more generic `&[&str]` on the suggestion of internet peoples. And, I encountered a really horrible diagnostic which sent me down the rabbit hole,

This works fine,

```rust
fn main() { 
  let pos: Vec<String> = vec!["foo".to_owned(), "bar".to_owned(), "baz".to_owned()];
  let pos: Vec<&str> = pos.iter().map(AsRef::as_ref).collect(); 
}
```

However, this raises all kinds of problems,

```rust
fn main() { 
  let pos: Vec<String> = vec!["foo".to_owned(), "bar".to_owned(), "baz".to_owned()];
  let pos: &[&str] = pos.iter().map(AsRef::as_ref).collect(); 
}
```

You can see the invitation to go down the rabbit hole here,

```text
error[E0277]: a value of type `&[&str]` cannot be built from an iterator over elements of type `&_`
 --> bin/seq.rs:3:51
  |
  |     let pos: &[&str] = pos.iter().map(AsRef::as_ref).collect(); 
  |                                                      ^^^^^^^ value of type `&[&str]` cannot be built from `std::iter::Iterator<Item=&_>`
  |
  = help: the trait `FromIterator<&_>` is not implemented for `&[&str]`

For more information about this error, try `rustc --explain E0277`.
```

So in order to solve

> value of type `&[&str]` cannot be built from `std::iter::Iterator<Item=&_>

You need to simply add `.to_slice()`,

```rust
  let pos: Vec<String> = vec!["foo".to_owned(), "bar".to_owned(), "baz".to_owned()];
  let pos: Vec<&str> = pos.iter().map(AsRef::as_ref).collect();
  let pos: &[&str] = pos.as_slice();
```

Or alternatively

```rust
let pos: &[&str] = pos.iter().map(AsRef::as_ref).collect::<Vec<_>>().as_slice();
```
Repository: flutter
Issue: Flutter deep linking does not work from Safari View Controller on real device
Labels: platform-ios,engine,f: routes,customer: google,p: url_launcher,package,has reproducible steps,P2,found in release: 3.10,found in release: 3.11,team-ios,triaged-ios


```
[✓] Flutter (Channel stable, 2.5.2, on macOS 11.6 20G165 darwin-x64, locale en-GB)
```

I enabled deep linking on iOS by this instruction 
https://flutter.dev/docs/development/ui/navigation/deep-linking

It works on Safari and Safari View Controller on emulator.
But when use Safari View Controller on real device (Iphone 12 mini, IOs 15.0.1) this link is not handled by the app.
There are some logs:

This I see when just open a link from the Flutter app via `url_launcher`

```console
> flutter: Uncaught error: PlatformException(Error, Error while launching https://mydomain/auth null, null) #0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:607:7)
> #1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:156:18)
> <asynchronous suspension>
> #2      launch (package:url_launcher/url_launcher.dart:101:23)
> <asynchronous suspension>
```

Then on the page, I have a link with custom url scheme
myapp://myapp.com/authentication_result/test
When I tap on it nothing happens and there is an error in logs

> [VERBOSE-2:FlutterAppDelegate.mm(159)] Timeout waiting for the first frame when launching an URL.

I expect that `onGenerateRoute` will be called and I can handle the link and close web view.

Looks like it is a place from where an error thrown
https://github.com/flutter/engine/blob/master/shell/platform/darwin/ios/framework/Source/FlutterAppDelegate.mm#L149
Repository: vscode
Issue: Consider injected text for guides
Labels: bug,bracket-pair-guides

visibleColumns stay as they are (this is a bug and needs to be fixed, but it is not a regression)
Repository: godot
Issue: Black screen on Android GLES3 (PowerVR GE8320)
Labels: bug,topic:rendering,topic:3d

### Godot version

3.3.4.stable

### System information

Realme C21 RMX3201, Android 10, PowerVR GE8320

### Issue description

there is a possible bug in the GLES3 renderer empty scenes with just a camera work fine (the sky box is rendered correctly) but when i add a mesh instance in the scene and launch the game on the device i get a black screen.
this does not happen when i switch to GLES2 also after testing a empty project with a 2d scene it worked fine without issues on GLES2 or GLES3.

### Steps to reproduce

Make a 3d scene, add a mesh instance or csg instance and finally launch the game on the device.

### Minimal reproduction project

_No response_
Repository: flutter
Issue: video_player_web support for disableRemotePlayback
Labels: c: new feature,platform-web,p: video_player,package,c: proposal,P3,team-web,triaged-web

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case

When using video_player_web for background videos in android browsers you get "chromecast" icon in top corner of video element. This is not visually nice when layering video and graphical elements using flutter stack widget.

<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->

## Proposal
Add  new option to VideoPlayerOptions for disableRemotePlayback (default = false). 
Example usage:
```dart
VideoPlayer(videoController, { VideoPlayerOptions(disableRemotePlayback: true) });
```

If this option is true implementation adds  [disableRemotePlayback](https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/disableRemotePlayback) property to HTMLMediaElement for video. 
```javascript
var obj = document.createElement('video');
obj.disableRemotePlayback = true;
```


As a workaround we can still use deprecated api in web/index.html via css:
```css
video::-internal-media-controls-overlay-cast-button {
      display: none;
    }
```
See deprecation info [here](https://www.chromestatus.com/feature/5714245488476160). 



<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching something showing what you are imagining:
      * images
      * videos
      * code samples

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->
Repository: kubernetes
Issue: Storage e2e tests should allow RWX for block volumes and RWO for filesystem ones
Labels: sig/storage,kind/feature,help wanted,needs-triage

### What would you like to be added?

Right now, our e2e tests and our [external CSI tests](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/external/README.md) allow a test driver to opt-in for RWX testing for both block and filesystem volumes
https://github.com/kubernetes/kubernetes/blob/d9896a23bcec2cdadd398bff0bb967a17ad7893d/test/e2e/storage/framework/testdriver.go#L165

We should allow a separate opt-in for RWX tests on block volumes, testing filesystem volumes only with RWO.


### Why is this needed?

Some (most?) CSI drivers allow a single block volume to be used in multiple nodes in parallel. For example, a single iSCSI volume can be attached to multiple nodes. Similarly, some clouds offer multi-attach too (at least AWS EBS, GCP PD, Azure Disk, possibly all of them). We should have an e2e test for this RWX multi-attach capability.

We can't use filesystem volumes with multi-attach volumes in this case, as ext4 or xfs can be mounted only on a single node as read-write, otherwise the filesystem gets corrupted.
Repository: flutter
Issue: [Proposal] Add ability to customise l10n formatter
Labels: c: new feature,framework,a: internationalization,c: proposal,P3,team-framework,triaged-framework

```json
{
	"helloWorldOn": "Hello World on {date}",
	"@helloWorldOn": {
	  "description": "A message with a date parameter",
	  "placeholders": {
		"date": {
		  "type": "DateTime",
		  "format": "yMd"
		}
	  }
	}
}

```

I think flutter must make formatting of interpolation in l10n easier
How? Having a `formatter` option in `MaterialApp` is an option, we can extend an abstract class and customize formatter

So we can support extra types in l10n, assume we want to localize `Duration` , or `Foo` object
Or want to use a custom formatter for `int` type

We can extend formatter to add additional calendar and formats, like `jyjMjd` for `jalaali` calendar, I passed an `DateTime` as argument and the formatter decides about calendar
Repository: material-ui
Issue: Documentation for extending theme is wrong. Module Augmentation does not work.
Labels: docs

<!-- Provide a general summary of the issue in the Title above -->
In https://mui.com/customization/theming/#custom-variables the docs tell you to use following example to extend typescript type but it is not working:

```
declare module '@mui/material/styles' {
  interface Theme {
    status: {
      danger: string;
    };
  }
  // allow configuration using `createTheme`
  interface ThemeOptions {
    status?: {
      danger?: string;
    };
  }
}
```

- [x] The issue is present in the latest release.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.

## Current Behavior 😯

Current example in docs does not work.

## Expected Behavior 🤔

Example should work.

## Steps to Reproduce 🕹

Follow the docs.

The following type does work instead:
```
declare module "@mui/material/styles/createTheme" {
    interface Theme {
        test: string,
    }
    // allow configuration using `createMuiTheme`
    interface ThemeOptions {
        test?: string;
    }
}
```

## Your Environment 🌎

<!--
  Run `npx @mui/envinfo` and post the results.
  If you encounter issues with TypeScript please include the used tsconfig.
-->
<details>
  <summary>`npx @mui/envinfo`</summary>
  
```
   System:
    OS: Linux 5.10 Ubuntu 20.04.2 LTS (Focal Fossa)
  Binaries:
    Node: 14.17.5 - /usr/bin/node
    Yarn: 1.22.11 - /usr/local/bin/yarn
    npm: 7.24.1 - /usr/bin/npm
```
</details>
Repository: pytorch
Issue: 0INTERNAL ASSERT FAILED, We don't have an op for aten::eq but it isn't a special case
Labels: oncall: jit,triaged

## 🐛 Bug

```
RuntimeError: 0INTERNAL ASSERT FAILED at "/opt/conda/conda-bld/pytorch_1631630742027/work/torch/csrc/jit/ir/alias_analysis.cpp":532, please report a bug to PyTorch. We don't have an op for aten::eq but it isn't a special case.  Argument types: Tensor, bool, 
```

## To Reproduce

minimal repro example:

```
import torch


def crash(logits, mask):
    logits.masked_fill_(mask[:, :, None] == False, float('-inf'))
    return logits


logits = torch.randn((2, 4, 576))
mask = torch.zeros((2, 4), dtype=torch.bool)
torch.jit.trace(crash, (logits, mask))
```

Steps to reproduce the behavior:

```
$ python crash.py 
Traceback (most recent call last):
  File "crash.py", line 11, in <module>
    torch.jit.trace(crash, (logits, mask))
  File "/env/lib/python3.7/site-packages/torch/jit/_trace.py", line 787, in trace
    get_callable_argument_names(func)
RuntimeError: 0INTERNAL ASSERT FAILED at "/opt/conda/conda-bld/pytorch_1631630742027/work/torch/csrc/jit/ir/alias_analysis.cpp":532, please report a bug to PyTorch. We don't have an op for aten::eq but it isn't a special case.  Argument types: Tensor, bool, 
```


## Environment

```
PyTorch version: 1.9.1
Is debug build: False
CUDA used to build PyTorch: 10.2
ROCM used to build PyTorch: N/A

OS: Ubuntu 18.04.5 LTS (x86_64)
GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Clang version: Could not collect
CMake version: version 3.10.2
Libc version: glibc-2.17

Python version: 3.7.10 (default, Jun  4 2021, 14:48:32)  [GCC 7.5.0] (64-bit runtime)
Python platform: Linux-4.14.241-184.433.amzn2.x86_64-x86_64-with-debian-buster-sid
Is CUDA available: False
CUDA runtime version: 10.1.243
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.5
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] mypy==0.812
[pip3] mypy-extensions==0.4.3
[pip3] numpy==1.20.2
[pip3] torch==1.9.1
[conda] blas                      1.0                         mkl  
[conda] cudatoolkit               10.2.89              hfd86e86_1  
[conda] mkl                       2021.3.0           h06a4308_520  
[conda] pytorch                   1.9.1           py3.7_cuda10.2_cudnn7.6.5_0    pytorch
```
Repository: create-react-app
Issue: error when installing react with yarn
Labels: stale


yarn add v1.22.11
[1/4] Resolving packages...
⠂ react@^17.0.2
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
Failed to compile.

./src/reportWebVitals.js
Module not found: Can't resolve 'web-vitals' in 'C:\Users\USER\Desktop\practice\my-app\src'
Repository: vscode
Issue: Feature Request: Bracket Pair Guides - Hover
Labels: feature-request,bracket-pair-guides

It would be quite useful if bracket pair/indentation guides would support mouse interaction.

I can imagine that a hover shows when the mouse is on a guide an ctrl is pressed.

This hover would show the line of the opening and closing bracket. When clicking on the line, the cursor would jump to it.

Maybe something like this could also be supported:

![](https://camo.githubusercontent.com/9bca7c7dc7dfdfb6afdd1b0408e1ac41739abb88cccb198d4c2f922b822dec13/68747470733a2f2f692e736e61672e67792f5432523471622e6a7067)

(from [here](https://github.com/microsoft/vscode/issues/55075#issuecomment-424464684))
Repository: flutter
Issue: [url_launcher] Add `enableJavascript` property to Link Widget 
Labels: c: new feature,p: url_launcher,package,c: proposal,team-ecosystem,P3,triaged-ecosystem

The current [Link Widget implementation](https://github.com/flutter/plugins/blob/c254963c1e2b2badb1910d53d6f9bbe8da9d1f5a/packages/url_launcher/url_launcher/lib/src/link.dart#L115) doesn't allow to enable Javascript.

```dart
if (await canLaunch(urlString)) {
    await launch(
      urlString,
      forceSafariVC: _useWebView,
      forceWebView: _useWebView,
     
     /// by default is set to false
     /// enableJavaScript: false, 
    );
  }
```

The problem is that some websites need Javascript to function properly, see example below that doesn't work if you run it on a mobile device with `LinkTarget.self`.


## Steps to Reproduce

```dart
Link(
  target: LinkTarget.self,
  uri: Uri.parse('https://youtube.com'),
  builder: (context, followLink) => ElevatedButton(
    child: Text('Open YouTube'),
    onPressed: followLink,
  ),
),
```

Here the website YouTube is not working without Javascript. Simply run it inside a mobile Flutter app in a WebView with `target: LinkTarget.self`.
<img src="https://user-images.githubusercontent.com/44921899/136766272-d68ccf94-12c7-4225-9758-194c781b1cfa.png" src="https://gyazo.com/eb5c5741b6a9a16c692170a41a49c858.png" height="300" />

@danagbemava-nc
Repository: vscode
Issue: Trim whitespace when deleting newline
Labels: feature-request,editor-commands

When I delete a newline, I always have to delete the leading whitespace too. Could this whitespace be trimmed automatically?

```
void f() {
    int a = 1
        + 2;    
}
```
If the cursor is after the `1`, I'd like one press of Delete to delete both the newline and the whitespace before the `+`.
Repository: vscode
Issue: [folding] Add `unfold level [number]`
Labels: feature-request,editor-folding

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
Similar to the `fold level [number]` functionality, it would be very convenient to add a `unfold level [number]` functionality.

The `fold level` assumes that the user is viewing the file when it is entirely unfolded.
When viewing a large file I always start out with folding the entire file to get a clear overview of the file.
In this scenario, a `unfold level` would be very useful.
Currently, I use the `unfold` command and manually take the cursor to the next level and unfold again. 

Thank you!
Repository: flutter
Issue: [Camera]:  Proposal to add set path file on startVideoRecording
Labels: c: new feature,platform-android,p: camera,package,c: proposal,P3,team-android,triaged-android

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case
Need set path file on start videorecording
<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->

## Proposal

<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching something showing what you are imagining:
      * images
      * videos
      * code samples

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->
Repository: rust
Issue: Help Diagnostic For `explicit lifetime name needed here`
Labels: A-diagnostics,T-compiler,A-suggestion-diagnostics

Using rustc 1.55.0

Given the following code: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=deaf96d3f30f20986ce469e1b49664ff

```rust
use std::iter::Sum;

fn main() {
    println!("Hello, world!");
}

fn add<T: 'static + Sum<&T>>(values: &[T]) -> T {
    values.iter().sum()
}
```

The current output is:

```
❯ cargo run
   Compiling lifetimes v0.1.0 (/Users/josephlyons/Desktop/lifetimes)
error[E0637]: `&` without an explicit lifetime name cannot be used here
  --> src/main.rs:52:25
   |
52 | fn add<T: 'static + Sum<&T>>(values: &[T]) -> T {
   |                         ^ explicit lifetime name needed here

error[E0621]: explicit lifetime required in the type of `values`
  --> src/main.rs:53:19
   |
53 |     values.iter().sum()
   |                   ^^^ lifetime `'static` required

Some errors have detailed explanations: E0621, E0637.
For more information about an error, try `rustc --explain E0621`.
error: could not compile `lifetimes` due to 2 previous errors
```

Not sure what the proposed output would be, but some sort of help / suggestion could help to make this easier for beginners
Repository: TypeScript
Issue: Vague error message for incorrect tuple type spread as function arguments
Labels: Suggestion,Domain: Error Messages,Experience Enhancement

# Bug Report



### 🔎 Search Terms

tuple arguments parameters error assignable to

### 🕗 Version & Regression Information

- ~This is a crash~
- ~This changed between versions ______ and _______~
- This is the behavior in every version I tried, and I reviewed the FAQ for entries about ... messages?
- ~I was unable to test this on prior versions because _______~

### ⏯ Playground Link

[Playground link with relevant code](https://www.typescriptlang.org/play?#code/GYVwdgxgLglg9mABAGzgcwAoEMYCcAUYWAtgKYBciAzlLjGGgDSIBuWyIFiYIxARqVwBKRAG8AvgFgAUDIgIaiAA45clANo9+g5jToMAuogC8idQEZmAcixWDAbhkzUmVfgB0nlXiGPpAen9EAFFcXDg1RABBXDReUjAoRDhgRCgATyVSRCstAVwrRBgqbjgkrCoqGDQiPmRsqDhlLFwSUihBZNSMrJy9ejQrdyA)

### 💻 Code

<!-- Please post the relevant code sample here as well-->
```ts
function logPair(name: string, value: number) {}

const pair: [number, string] = [1, 'a'];

logPair(...pair);
// Error: Argument of type 'number' is not assignable to parameter of type 'string'.
```

### 🙁 Actual behavior

The error message is the same as if we'd called `logPair(1, 'a')`. 

### 🙂 Expected behavior

Somehow indicate why the tuple is wrong, and to keep the precedence from function argument incompatibilities, perhaps drill down onto the first incorrect one? A rough first stab:

```
Parameters are type '[number, string]' but tuple arguments are type '[string, number]'.
    Parameter 0 is type 'number' but tuple argument [0] is type 'string'.
```
Repository: pytorch
Issue: The uniform operator param names in the C++ impl use python keywords
Labels: triaged,module: numpy

The uniform operator has a param named `from`. This complicates exporting the symbol Onnx. The workaround is passing in kwargs but @ezyang  mentioned we should look into changing the param names to match with what numpy uses.

cc @mruberry @rgommers
Repository: vscode
Issue: Git - Git can be slow to update
Labels: bug,git,perf

There are a lot of issues created which all point to the same underlying problem which is that the git extension is very slow compared to the command line to update its state. This issue will be used to investigate and track the work being done to improve this.