sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: rust
Issue: Put the workspace crates first in the side panel
Labels: T-rustdoc,C-feature-request,A-rustdoc-ui

**Describe the problem you are trying to solve**

I try to document a project with a few crates in a workspace. The issue is that there is a ton of dependencies (that I'd like to browse when needed), and my crates are drowned in the middle of those dependencies in the side panel.

It's impossible to see in a glance which crates are in the project, and thus to browse the project correctly.

**Describe the solution you'd like**

I think that the crates from the workspace should come first if the side panel, and then the dependencies. If there are 2 crates `foo` and `bar` in the workspace, the panel should looks like that:

```
CRATES
---------
bar
foo
---------
all
the
dependencies
```
Repository: go
Issue: cmd/go: "conflicts with" message is too vague when one path is a package and the other is a module
Labels: NeedsInvestigation,modules

From a Slack conversation with @myitcv and @jayconrod:

```
$ go get -d gopher.live/ub8a7a486d202/mod/v2@latest gopher.live/ub8a7a486d202/mod@none
go get: gopher.live/ub8a7a486d202/mod@none conflicts with gopher.live/ub8a7a486d202/mod/v2@latest (v1.0.0)

-- go.mod --
module example.com/m
go 1.17
replace (
        gopher.live/ub8a7a486d202/mod v1.0.0 => ./mod
        gopher.live/ub8a7a486d202/mod/v2 v2.0.0 => ./modv2
)
-- mod/go.mod --
module gopher.live/ub8a7a486d202/mod
go 1.17
-- mod/v2/v2.go --
package v2
-- modv2/go.mod --
module gopher.live/ub8a7a486d202/mod/v2
go 1.17
```

That error message is decidedly suboptimal: it's saying that the constraint `gopher.live/ub8a7a486d202/mod@none` (which is interpreted as a _module_ path) conflicts with `gopher.live/ub8a7a486d202/mod/v2@latest` (which is a _package_ query resolving to the same module at `v1.0.0`).
Repository: pytorch
Issue: CSR: Relaxing constraints to s_addmm_out_sparse_dense_cuda_worker
Labels: module: sparse,triaged,open source

## 🚀 Feature

Given that cusparse APIs support setting ldb (leading dimension of B).

https://github.com/pytorch/pytorch/blob/1bd22e28b318b15cbfe37ee1a112df9423aab328/aten/src/ATen/native/sparse/cuda/SparseCUDATensorMath.cu#L83

The previous condition is too strict condition as `dense.stride(1)` can be larger than `dense.size(0)`.  The first stride `stride(1)` can be `size(0) * s` where `s` is some positive integer.


## Additional context
This function is used  by  `addmm_out_sparse_csr_dense_cuda` (CSR) and `s_addmm_out_sparse_dense_cuda_worker` (COO) tensor's operation. 

Mentioned here:
https://github.com/pytorch/pytorch/pull/59012#discussion_r640390044

cc @aocsa @nikitaved @pearu @cpuhrsch @IvanYashchuk @mruberry
Repository: pytorch
Issue: Use of storage_offset is not needed  in add_out_dense_sparse_csr_cuda
Labels: module: sparse,module: cuda,triaged

## 🚀 Feature

The use of `r.storage_offset()` doesn't look right.  storage_offset, as the name suggests, gives offset of the beginning of the tensor withing the storage. In most cases it's 0. When you are computing index to write to, you should only be using indices and strides, not storage offset.

Context: 

The storage_offset is used to compute the new index

https://github.com/pytorch/pytorch/blob/a7b796c73bd02bc4fe26686d067c48fdd847e679/aten/src/ATen/native/sparse/cuda/SparseCsrTensorMath.cu#L132

And then is used with  `scalar_t* out_ptr = resultBuffer.data_ptr<scalar_t>();` to update the value https://github.com/pytorch/pytorch/blob/a7b796c73bd02bc4fe26686d067c48fdd847e679/aten/src/ATen/native/sparse/cuda/SparseCsrTensorMath.cu#L133

## Additional context
This operation is used by `add_out_dense_sparse_csr_cuda, add_out_dense_sparse_csr_cpu` (CSR) and `add_dense_sparse_worker_cpu` (COO) tensor's operation.



_Originally posted by @aocsa in https://github.com/pytorch/pytorch/pull/59011#discussion_r640255996_

cc @ngimel @aocsa @nikitaved @pearu @cpuhrsch @IvanYashchuk
Repository: pytorch
Issue: Data access pattern in the loop in add_out_dense_sparse_csr_cuda could be pretty bad
Labels: module: sparse,triaged

As it is referenced here: 
 
https://github.com/pytorch/pytorch/blob/a7b796c73bd02bc4fe26686d067c48fdd847e679/aten/src/ATen/native/sparse/cuda/SparseCsrTensorMath.cu#L114

Data access pattern in this loop could be pretty bad. Moreover this could be wildly imbalanced if the sparsity pattern varies a lot between rows.

As a reference here:
https://github.com/pytorch/pytorch/blob/9e60c7dee36f5a4fc3a119d364ab072dac2ce58a/aten/src/ATen/native/sparse/cuda/SparseCUDAApplyUtils.cuh#L66

Neighboring threads are accessing neighboring values, not a single thread loops over all elements in this row. So it can be improved. 

_Originally posted by @ngimel in https://github.com/pytorch/pytorch/pull/59011#discussion_r640886373_

cc @aocsa @nikitaved @pearu @cpuhrsch @IvanYashchuk
Repository: flutter
Issue: [Web] Integration test does not wait for async behavior or animations
Labels: t: flutter driver,platform-web,f: integration_test,P2,team-web,triaged-web

I have a UI with a button at the center of the screen. Tapping the button starts an asynchronous function that waits for 3 seconds and then sends a GET request over the network. While the asynchronous function executes, an animated spinner is displayed at the center of the screen.

When running this behavior in an integration test on **web**, the integration test exits without waiting for the asynchronous behavior to end, and before the animation ends.

If I run this same integration test on Android, iOS, or Mac, the test correctly waits until the animation is gone.

If I run this app as a real app on Android, iOS, web, or Mac, it works as expected.

**Flutter version:**
```
Flutter 2.2.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision b22742018b (13 days ago) • 2021-05-14 19:12:57 -0700
Engine • revision a9d88a4d18
Tools • Dart 2.13.0
```

Here is a repo that demonstrates the issue:

**Test driver:**
https://github.com/matthew-carroll/flutter_bug_async_integration_test/blob/main/test_driver/integration_test_driver.dart

**Integration test:**
https://github.com/matthew-carroll/flutter_bug_async_integration_test/blob/main/integration_test/example_integration_test.dart

**App under test:**
https://github.com/matthew-carroll/flutter_bug_async_integration_test/blob/main/lib/main.dart
Repository: TypeScript
Issue: Infer a tuple type instead of array type when possible
Labels: Suggestion,Awaiting More Feedback

# Suggestion

I'd prefer typescript to be more aggressive about inferring tuple types, instead of always defaulting to Array.

This is related to https://github.com/microsoft/TypeScript/issues/6574. I'd like to open up a discussion about this again since that thread is locked, and conversation stopped after a workaround was provided without completely addressing the general issue.

## 🔍 Search Terms

Typescript, tuple, tuples, map, inference

## ✅ Viability Checklist

My suggestion meets these guidelines:

* [*] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [*] This wouldn't change the runtime behavior of existing JavaScript code
* [*] This could be implemented without emitting different JS based on the types of the expressions
* [*] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
* [*] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).

Existing typescript code could start emitting type errors from this change, so it would make sense to provide this as an option in tsconfig.

## ⭐ Suggestion

Typescript should infer a type to be a tuple instead of an array when it's possible.

## 📃 Motivating Example

The specific example I have in mind is for `Array.prototype.map()`, but there are probably more.

```
const tuple: [number, number, number] = [1, 2, 3];
const result = tuple.map(value => value + 1);
```
Here, typescript infers the type of `result` to be `number[]` rather than `[number, number, number]`. This could result in some wonkiness when trying to access values inside the tuple:
```
const [a, b, c, d] = result; // Typescript doesn't detect an error since result is an Array type.
const e = result[10]; // Typescript doesn't detect an error since result is an Array type.
```
Both of these errors can be caught if Typescript instead inferred `result` to be the tuple type `[number, number, number]`.

## 💻 Use Cases

The above example is a use case. I want typescript to tell me when I make errors in my code.
Repository: PowerToys
Issue: Open quicklaunch shortcuts in Run without "~\"
Labels: Idea-Enhancement,Run-Plugin

Could frequent folders be opened with fewer keypresses?

Present behaviour:
To open the home directory in run type "\~" as this opens the "Folder" plugin.
To get to "Downloads" type "\~\downloads", then arrowdown, return. The arrowdown is required because the "Folder" plugin always stays at the top of the list.

My request is that typing further than "\~" moves down the list past the "Folder" item, or removes the "Folder" returned item, e.g. to open "Downloads" type only "\~\Dow" then return.
Even better would be typing just "Downloads" or "Down" as can be set up in Launchy by adding a shortcut to "Downloads" in one of the catalog directories.
Repository: terminal
Issue: MSIX version tearing causes instability and crashes
Labels: Issue-Bug,Area-TerminalConnection,Area-TerminalControl,Product-Terminal,Tracking-External,Culprit-Centennial

This bug represents a class of issues with the MSIX platform running mixed versions of our package at the same time. This violates fundamental assumptions of our code and causes instability and crashing in a variety of ways.
We are pursuing this issue internally with the MSIX platform, but this main bug will represent any other issues that get root-caused to this situation.
Repository: godot
Issue: AudioStreamPlayer will play upon re-entering tree even if paused
Labels: bug,topic:audio

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
<!-- Specify commit hash if using non-official build. -->
364ea7f / 3.3

**Steps to reproduce:**
1. Add audio stream player (any)
2. Make it `autoplay`
3. Remove it from tree
4. Pause
5. Re-add it to tree
6. It will play even though it should be paused

**Minimal reproduction project:**
<!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. -->
[AudioRepro.zip](https://github.com/godotengine/godot/files/6557201/AudioRepro.zip)
Space to toggle pause
Z to remove player from tree for 1 second
Try pausing while player is outside tree.
Repository: pytorch
Issue: [JIT] OpInfo / Autodiff tests dont seem to actually invoke symbolic backwards 
Labels: oncall: jit

## 🐛 Bug

See: https://github.com/pytorch/pytorch/pull/59069#issuecomment-849977954

cc @gmagogsfm @Krovatkin
Repository: flutter
Issue: [Web] Open developer tab in existing browser session
Labels: c: new feature,tool,platform-web,c: proposal,P3,team-web,triaged-web

## Use case

What happens today is that if you run flutter in chrome, it will open a totally new tab, without your session, cookies, etc. This is a little bit bad because many times you will search things, or use chat applications, or whatever, and changing applications in order to do so might not be the best experience. 

The server behind that tab seems to be running on localhost, and you can open a new tab on the existing browser session and navigate into it. But if you close that first tab, the server will stop. 

## Proposal

Open a new tab, or allow the first tab to be closed.

Thanks
Repository: angular
Issue: CLI builder guide should describe how to build and run the example
Labels: state: in investigation,P2,area: docs

# Docs or angular.io Bug Report

### Description

Follow up to #42371.

CLI builders guide does not describe compiling or running the builder.

* The example is in TypeScript, but builders can only be run as JavaScript. We need to describe the recommended build process for the builder itself.
* We also don't describe how exactly to run a local builder. The doc assumes the builder has been published and mentions `ng run`, but it doesn't actually have a command to run a local builder directly. Considering that the doc is essentially "how to make your first builder", we shouldn't assume the user has (or ever will) publish the builder.

### What's the affected URL?

https://angular.io/guide/cli-builder
Repository: rust
Issue: if Result::is_ok() followed immediately by Result::unwrap() fails to optimize out the second err check
Labels: I-slow,A-codegen,T-compiler

In the following trivial example, LLVM fails to optimize the `unwrap()` away. While its somewhat contrived in the sense that a `match` or `if let` should be preferred, more complicated logic ends up with similar blocks eventually.

```rust
pub fn print_if_some(arg: Result<u64, u32>) {
    if arg.is_ok() {
        let v = arg.unwrap();
        if v == 42 {
            println!("{}", v);
        }
        return;
    }
}
```

Godbolt link for the same is https://godbolt.org/z/xrT1GfG7e you can see the `test` and `jne` for panic'ing.
Repository: youtube-dl
Issue: cameo.com videos
Labels: site-support-request

<!--

######################################################################
  WARNING!
  IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################

-->


## Checklist

<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2021.05.16. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->

- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2021.05.16**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones


## Example URLs

<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->

- Single video: https://www.cameo.com/v/60aadcf491e5e200248ec034?utm_campaign=video_share_to_copy


## Description

<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->

Plays in Firefox.  youtube-dl returns a HTTP Error 403: Forbidden
Repository: rust
Issue: Compiler emits `warning: value assigned is never read` even though it is read
Labels: A-diagnostics,T-compiler,C-bug,D-incorrect

<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->

I tried this code:

```rust
let mut first = true;
for value in some_iterator{
     if first{
          first = !first; //value assigned to `first` is never read
          //some logic
     }else{
          //some other logic
    }
}
```

As you see the value of `first` is read in the if statement and then immediately inverted so that there's different behavior on the first iteration of the loop.

the compiler emits ``warning: value assigned to `first` is never read`` on the line where `first` is inverted, even though it is read.

### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->

The same behavior happens when building with `+nightly`

`rustc --version --verbose`:
```
rustc 1.52.1 (9bc8c42bb 2021-05-09)
binary: rustc
commit-hash: 9bc8c42bb2f19e745a63f3445f1ac248fb015e53
commit-date: 2021-05-09
host: x86_64-unknown-linux-gnu
release: 1.52.1
LLVM version: 12.0.0
```

<!--
Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your
environment. E.g. `RUST_BACKTRACE=1 cargo build`.
-->
<details><summary>Backtrace</summary>
<p>

don't mind the sw warning.

```
❯ RUST_BACKTRACE=1 cargo build
    Blocking waiting for file lock on build directory
   Compiling <confidential> v0.1.0 (<redacted>)
warning: unused variable: `sw`
  --> src/table.rs:22:21
   |
22 |                 let sw = sheet_writer;
   |                     ^^ help: if this is intentional, prefix it with an underscore: `_sw`
   |
   = note: `#[warn(unused_variables)]` on by default

warning: value assigned to `first` is never read
  --> src/table.rs:27:25
   |
27 |                         first = !first;
   |                         ^^^^^
   |
   = note: `#[warn(unused_assignments)]` on by default
   = help: maybe it is overwritten before being read?

warning: 2 warnings emitted

    Finished dev [unoptimized + debuginfo] target(s) in 20.80s
```

</p>
</details>
Repository: pytorch
Issue: [autograd] `fill_` gradgradcheck raises RuntimeError
Labels: module: autograd,triaged

```python
import torch
from torch.autograd import gradgradcheck

x = torch.randn((5, 5, 5), device='cpu', dtype=torch.double, requires_grad=True)
# Issue is with setting required_grad=True on `val`.
# Works if this is `False`.
val = torch.tensor(1.5, device='cpu', dtype=torch.double, requires_grad=True)

def fn(t, v):
    return torch.fill_(t.clone(), v)

gradgradcheck(fn, (x, val))
```

Output
```
Traceback (most recent call last):
  File "test/test_fill.py", line 10, in <module>
    gradgradcheck(fn, (x, val))
  File "/home/kshiteej/.conda/envs/pytorch-cuda-dev/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 1368, in gradgradcheck
    return gradcheck(
  File "/home/kshiteej/.conda/envs/pytorch-cuda-dev/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 1245, in gradcheck
    return _gradcheck_helper(**args)
  File "/home/kshiteej/.conda/envs/pytorch-cuda-dev/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 1258, in _gradcheck_helper
    _gradcheck_real_imag(gradcheck_fn, func, func_out, tupled_inputs, outputs, eps,
  File "/home/kshiteej/.conda/envs/pytorch-cuda-dev/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 930, in _gradcheck_real_imag
    gradcheck_fn(func, func_out, tupled_inputs, outputs, eps,
  File "/home/kshiteej/.conda/envs/pytorch-cuda-dev/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 961, in _slow_gradcheck
    numerical = _transpose(_get_numerical_jacobian(func, tupled_inputs, outputs, eps=eps, is_forward_ad=use_forward_ad))
  File "/home/kshiteej/.conda/envs/pytorch-cuda-dev/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 146, in _get_numerical_jacobian
    jacobians += [get_numerical_jacobian_wrt_specific_input(fn, inp_idx, inputs, outputs, eps,
  File "/home/kshiteej/.conda/envs/pytorch-cuda-dev/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 290, in get_numerical_jacobian_wrt_specific_input
    return _combine_jacobian_cols(jacobian_cols, outputs, input, input.numel())
  File "/home/kshiteej/.conda/envs/pytorch-cuda-dev/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 233, in _combine_jacobian_cols
    jacobian[k] = v[i]
RuntimeError: The expanded size of the tensor (1) must match the existing size (125) at non-singleton dimension 0.  Target sizes: [1].  Tensor sizes: [125]
```

**NOTES**:
There are entries for `fill_` in method_tests,
https://github.com/pytorch/pytorch/blob/41054f2ab5bb39d28a3eb8497f1a65b42385a996/torch/testing/_internal/common_methods_invocations.py#L6791-L6793

But they are not tested for gradcheck and gradgradcheck
https://github.com/pytorch/pytorch/blob/41054f2ab5bb39d28a3eb8497f1a65b42385a996/test/test_autograd.py#L5472

https://github.com/pytorch/pytorch/blob/41054f2ab5bb39d28a3eb8497f1a65b42385a996/test/test_autograd.py#L5497-L5499

cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @soulitzer @Lezcano
Repository: pytorch
Issue: No index type check of torch.tensor in array manner
Labels: module: error checking,triaged,module: advanced indexing

## 🐛 Bug

Hi, I recently found there are no type check of torch.tensor when using array as index. When this happen with a tensor in GPU, sometimes it will cause more trouble since the tensor will just "die" with no useful debug messages such as 

>/pytorch/aten/src/ATen/native/cuda/IndexKernel.cu:84: operator(): block: [0,0,0], thread: [74,0,0] Assertion `index >= -sizes[i] && index < sizes[i] && "index out of bounds"` failed.
> RuntimeError: CUDA error: device-side assert triggered  


## To Reproduce

Steps to reproduce the behavior:


``` python
import torch
a = torch.randn(5,5)
index_x = [1.2, 2.3]
index_y = [1.1, 1.3]
a[index_x, index_y]  # this line will be ok
a[1.2, 1.1] # IndexError: only integers, slices (`:`), ellipsis (`...`), None and long or byte Variables are valid indices (got float)
```


## Expected behavior

I believe torch will try to check the input types of array index, not automatically round it. Maybe this is to improve the speed of vector calculation, but it is not consistent with other index method.

## Environment

 - PyTorch 1.6.0, 1.7.1
 - Ubuntu 18.04
 - How you installed PyTorch (`conda`, `pip`, source): PiP
 - Python version: 3.7
 - CUDA/cuDNN version: As recommend by official
 - GPU models and configuration: 2080Ti


cc @ezyang @gchanan @zou3519 @bdhirsh @jbschlosser @anjali411 @Varal7
Repository: rust
Issue: Semantics of char comparison operations is not clear
Labels: C-enhancement,A-Unicode

This is possibly me being silly.. I'm currently working on something where I have to convert `char`s to `u32`s for storage, and then convert back. My code is only correct if `∀ (c1 : char) (c2 : char) . c1.cmp(c2) == (c1 as u32).cmp(c2 as u32)`. In other words conversion from `char` to `u32` must preserve the ordering relation of values. (there is probably a name given to this notion of relation-preserving mapping, but I don't know what it is.. anyone know?)

Looking at `char` documentation, it says `char` represents "Unicode scalar value"s, but other than that it doesn't say what does conversion to `u32` do, or whether they're represented as `u32` internally, and whether comparison is simple `u32` comparison (i.e. comparison of unicode scalar values) or something more complicated. It's also not easy to learn about this by looking at the source, becuase `PartialOrd` implementation of `char` relies on `>`, `<` etc. implementations ([1], [2]), which are I think hard-coded somewhere in the compiler.

Simple `u32` comparison is probably the only sensible implementation, but that's not entirely clear to me. When I click on the "unicode scalar value" link in the documentation it doesn't say how the values must be compared. Without knowing more about unicode or "unicode scalar value" I'm not sure if e.g. a character can have multiple unicode scalar values but those need to be equal, or something like that.

[1]: https://doc.rust-lang.org/src/core/cmp.rs.html#1307
[2]: https://doc.rust-lang.org/src/core/cmp.rs.html#1207