sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: pytorch
Issue: Unify async_save and sync_save in state_dict_saver from distributed checkpointing 
Labels: oncall: distributed,triaged,enhancement,oncall: distributed checkpointing

### 🚀 The feature, motivation and pitch

Most pytorch methods use a async_op param to do asynchronous operation and return a union of Future or return type. 
EG: 
`def broadcast(tensor, src, group=None, async_op=False):`

But for checkpointing, we use separate methods async_save and save. The signatures are exactly same except for return type. Having one method with async_op makes the api consistent with rest of pytorch methods and reduce cognitive overhead for developers, allow easy discovery of async save capability and reduce boiler plate code duplication in pytorch and for users. 

Most users now have to write something like - 
```
do_async = is_periodic_checkpoint and have_memory 
if do_async:
   result = async_save(
    state_dict=sd,
    *,
    checkpoint_id= cp_id,
    storage_writer= storage_writer_instance,
    planner= planner_instance,
    process_group= pg,
    async_op = do_async
)
    return result      # returning a future or ignore it
else: 
  result = save(
    state_dict=sd,
    *,
    checkpoint_id= cp_id,
    storage_writer= storage_writer_instance,
    planner= planner_instance,
    process_group= pg,
    async_op = do_async
)
  return result  
```

Using one method will allow flexible and simpler code - 

```
do_async = is_periodic_checkpoint and have_memory 
result = save(
    state_dict=sd,
    *,
    checkpoint_id= cp_id,
    storage_writer= storage_writer_instance,
    planner= planner_instance,
    process_group= pg,
    async_op = do_async
)
return result # return 
```
or 
```
do_async = is_periodic_checkpoint and have_memory 

result = save(
    state_dict=sd,
    *,
    checkpoint_id= cp_id,
    storage_writer= storage_writer_instance,
    planner= planner_instance,
    process_group= pg,
    async_op = do_async # or simply use True here
)

return result.wait() if do_async else result # when using async, the user probably returns a future or ignores it or waits on the Future only on shutdown of job.
```

I believe checkpointing should adopt the goal of supporting training at scale as this is critical for internal consolidation of checkpointing and building community around checkpointing. In large scale training, async checkpointing is more widely used and is probably the main API for checkpointing. so consolidating these methods would simplify integration greatly.


### Alternatives

_No response_

### Additional context

_No response_

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k
Repository: transformers
Issue: Add option to only install AutoTokenizer for production environment
Labels: Feature request

### Feature request

Add option to only install AutoTokenizer for production environment, so we can minimize the dependencies and footprint in a production system.

### Motivation

When we deploy LLM models to a Triton inference server, we often convert the model to a optimized engine for a specific backend (ONNX, TensorRT-LLM etc.), these optimized engine does not require the transformers library anymore. 

However, we are still required to install the full transformers library, as we need the AutoTokenizer to handle pre/post processing steps to handle tokenization.

### Your contribution

Not sure
Repository: ollama
Issue: phi-3 small and phi-3 vision missing?
Labels: feature request

Hi,

Where is phi-3 small
https://huggingface.co/microsoft/Phi-3-small-128k-instruct
Small is much better then mini

And where is Phi vision?
https://huggingface.co/microsoft/Phi-3-vision-128k-instruct

![image](https://github.com/ollama/ollama/assets/8308674/752ab4f7-5aa5-4f35-90fd-5ce42306f30c)
Repository: flutter
Issue: [web] JS formatter breaks the templates in the new load API.
Labels: platform-web,has reproducible steps,P3,team-web,triaged-web,found in release: 3.22,found in release: 3.23

### Steps to reproduce

   1. Create a demo Flutter app using the latest bootstrap, using the following flutter_bootstrap.js

```
{{flutter_js}}
{{flutter_build_config}}

_flutter.loader.load();
```


   2. Auto format the code using VS-Code, Javascript, or any other js formatter

   3. Observe the spacing added

```
{ { flutter_js } }
{ { flutter_build_config } }

_flutter.loader.load();
```

   3. Attempt to flutter run
   4. Observe the white screen

### Expected results

The template should be replaced even with spacing added from formatters.
There should be a warning in the documentation at least, which tells that the template must not be formatted somehow.

### Actual results

The app is blank because the templates are not replaced.

### Code sample

(Included above)

### Screenshots or Video

N/A

### Logs

N/A

### Flutter Doctor output

This reproduces in the latest master, and probably has always reproduced since we introduced the new load API.
Repository: node
Issue: TypeError: Missing internal module 'node:crypto'
Labels: crypto,embedding

### Version

v18.20.2

### Platform

win10

### Subsystem

_No response_

### What steps will reproduce the bug?

I am building node with a `vcbuild.bat release x64 static dll` command.
`node.exe <myapp.js>` run as expected, but when I try to do this with the built `libnode.dll`, I receive:
```console
TypeError: Missing internal module 'node:crypto'
```

I don't understand. In shared lib mode the internal modules not loaded automatically?  (I can run 'regular' scripts with the shared lib without problem)

### How often does it reproduce? Is there a required condition?

It happens every time.

### What is the expected behavior? Why is that the expected behavior?

_No response_

### What do you see instead?

The code drops an unhandled exception and stop:

```js
process.on('uncaughtException', function(err) {
  console.log(err);
});
```

->

```console
TypeError: Missing internal module 'node:crypto'
```

### Additional information

_No response_
Repository: node
Issue: Disable `NODE_OPTIONS` via CLI
Labels: feature request,cli

### What is the problem this feature will solve?

Currently, in Node.js, a user can define CLI arguments from the `NODE_OPTIONS` environment variable, but sometimes this can lead to some security concerns, when Node.js is used with arbitrary environment variables.

### What is the feature you are proposing to solve the problem?

I propose a new CLI argument, `--disable-node-options` which will prevent `NODE_OPTIONS` from having any affect on the CLI arguments.

### What alternatives have you considered?

_No response_
Repository: pytorch
Issue: Should `torch.Size` convert np.ndarrays to lists of ints?
Labels: triaged,module: numpy

I've just noticed that
```python
s = torch.Size(np.array([1, 2, 3]))
type(s[0])
```
returns `<class 'numpy.int64'>`
whereas
```python
s = torch.Size(torch.tensor([1, 2, 3]))
type(s[0])
```
gives a `int`.

These two things are not interchangeable, yet it seems `np.ndarrays` are implicitly supported. For instance, if an `array` slips through as a shape this line will break in `broadcast_shape`:
https://github.com/pytorch/pytorch/blob/ee6cb6daa173896f8ea1876266a19775aaa4f610/torch/functional.py#L129

because a type assertion is made

https://github.com/pytorch/pytorch/blob/87f79af24dae87712996c9f135f2912a95bdd029/torch/fx/experimental/symbolic_shapes.py#L247

and the type is broadcast to `np.bool` (not bool).

I guess the question ultimately is: does PyTorch need to support np.ndarray shapes, or either raise a TypeError or convert it to a regular tuple of ints?

cc @mruberry @rgommers @ezyang
Repository: PowerToys
Issue: powertoy report a bug doesn't create a file - says it does
Labels: Issue-Bug,Needs-Triage,Needs-Team-Response,Area-Bug Report Tool

### Microsoft PowerToys version

0.81.0

### Installation method

WinGet

### Running as admin

Yes

### Area(s) with issue?

General

### Steps to reproduce

go to trey bar
![image](https://github.com/microsoft/PowerToys/assets/40741297/7778b9bc-ab48-4f1a-b1f5-bbfdd56904f9)
go to powertoy
![image](https://github.com/microsoft/PowerToys/assets/40741297/82f84a44-c0fb-47dc-b968-3f8f4747b596)
right click it
![image](https://github.com/microsoft/PowerToys/assets/40741297/e61b8d35-c38b-4466-9ace-2758ba648278)
click report a bug and wait - you get this:
![image](https://github.com/microsoft/PowerToys/assets/40741297/c2c3e739-dd47-44e7-8a4e-c26a8eeef300)


### ✔️ Expected Behavior

a file on the desktop

### ❌ Actual Behavior

no file

### Other Software
running with Powershell also doesn't work. the error is unknown

![image](https://github.com/microsoft/PowerToys/assets/40741297/cb8e2aae-2d1c-4678-a9c7-78c46b9408bc)
Repository: pytorch
Issue: torch.topk results differ on CPU and CUDA
Labels: module: cuda,triaged,module: sorting and selection

## 🐛 Describe the bug
I cannot get the same result from `torch.topk` when a tensor with repeated values is passed respectively on CPU and CUDA device.
## To reproduce
```python
import torch

a = torch.tensor([3, 2, 3, 2, 1, 1])
b = torch.tensor([3, 2, 3, 2, 1, 1], device='cuda')
a.topk(k=2)
b.topk(k=2)
```
The return values on my machine are:
```sh
torch.return_types.topk(
values=tensor([3, 3]),
indices=tensor([0, 2]))
torch.return_types.topk(
values=tensor([3, 3], device='cuda:0'),
indices=tensor([2, 0], device='cuda:0'))
```
`torch.sort` provide the parameter `stable=True` to preserve the order of equivalent elements. In default, `sorted` in `torch.topk` is `True`, but it does not point out the method to process equivalent elements.

I wonder whether the different result is a bug or an expected _feature_.

## Versions
PyTorch version: 2.4.0a0+07cecf4168.nv24.05
Is debug build: False
CUDA used to build PyTorch: 12.4

OS: Ubuntu 22.04.4 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0

Python version: 3.10.12

cc @ptrblck @msaroufim
Repository: transformers
Issue: Whether the OutEffHop can support with Transfomers
Labels: Feature request

### Feature request

We request that the option "OutEffHop" be included in the BERT, OPT, and ViT models.

### Motivation

I am the author of OutEffHop and we plan to release our OutEffHop-based model on HuggingFace. However, because we use a different activation function (not softmax) in attention, if we directly use the original structure, the model inference online will show a huge problem.

### Your contribution

We are able to supply the code for OutEffHop and assist with integrating the function into BERT and OPT. Additionally, if necessary, we can also help incorporate OutEffHop into ViT. My initial idea is to add an option in the model configuration that allows the user to choose whether to use OutEffHop. If they opt to use it, they can employ the new activation function.
Repository: angular
Issue: Style Precedence Guide has not be migrated from AIO
Labels: P3,area: docs

### Describe the problem that you experienced

https://angular.dev/guide/templates/class-binding#styling-precedence

It currently seems so empty it almost looks like something failed to render.

<img width="956" alt="image" src="https://github.com/angular/angular/assets/900523/af83b35d-40b0-4a99-91d5-b269ccad3bf8">

The previous angular.io section was very detailed with multiple tables.

@JeanMeche is looking into why the old guide is no longer linkable/resolvable, but it should have worked here:

https://angular.io/guide/style-precedence


### Enter the URL of the topic with the problem

https://angular.dev/guide/templates/class-binding#styling-precedence

### Describe what you were looking for in the documentation

_No response_

### Describe the actions that led you to experience the problem

_No response_

### Describe what you want to experience that would fix the problem

_No response_

### Add a screenshot if that helps illustrate the problem

_No response_

### If this problem caused an exception or error, please paste it here

_No response_

### If the problem is browser-specific, please specify the device, OS, browser, and version

_No response_

### Provide any additional information here in as much as detail as you can

_No response_
Repository: youtube-dl
Issue: Video of software usage
Labels: request

<!--

######################################################################
  WARNING!
  IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################

-->


## Checklist

<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2021.12.17. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->

- [x ] I'm reporting a feature request
- [x ] I've verified that I'm running youtube-dl version **2021.12.17**
- [ x] I've searched the bugtracker for similar feature requests including closed ones


## Description

<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->

I'm suggesting a simple video showing how the software can be used by a standard end user. I'll create the video myself if y'all would like. I think it would be beneficial to everyone.
Repository: rust
Issue: Bootstrap build fails: found crate `serde_derive` compiled by an incompatible version of rustc
Labels: T-bootstrap,T-cargo

I did a `git pull`, fixed the submodules, and now I am trying to run `./x.py check`. However, that fails:
```
$ ./x.py check
Building bootstrap
   Compiling build_helper v0.1.0 (/home/r/src/rust/rustc.3/src/tools/build_helper)
error[E0514]: found crate `serde_derive` compiled by an incompatible version of rustc
 --> /home/r/src/rust/rustc.3/src/tools/build_helper/src/metrics.rs:1:5
  |
1 | use serde_derive::{Deserialize, Serialize};
  |     ^^^^^^^^^^^^
  |
  = note: the following crate versions were found:
          crate `serde_derive` compiled by rustc 1.79.0-beta.1 (6b544f5ff 2024-04-28): /home/r/src/rust/rustc.3/build/bootstrap/debug/deps/libserde_derive-970fa0dc5f1e06a7.so
  = help: please recompile that crate using this compiler (rustc 1.79.0-beta.6 (66eb3e404 2024-05-23)) (consider running `cargo clean` first)

[...]
```
This must b a fairly recent regression, I've never had to manually clean bootstrap before.

Cc @onur-ozkan
Repository: PowerToys
Issue: Scroll language switch for Text Extractor
Labels: Idea-Enhancement,Status-In progress,Product-Text Extractor

### Description of the new feature / enhancement

When the Text Extractor is activated, instead of the user having to click and select the language they want to OCR from the dropdown, just scrolling up or down instantly shows the dropdown and selects the next or previous language that is in the list.

### Scenario when this would be used?

For multilingual users that use screen OCR all the time, one default language isn't handy. They need to constantly switch languages from the dropdown which is a bit time consuming, especially on large monitors. A mouse scroll is a very fast solution.

### Supporting information

_No response_
Repository: excalidraw
Issue: Request for align text justify
Labels: enhancement,richtext

![image](https://github.com/excalidraw/excalidraw/assets/110723341/ab4f1c63-4bb6-4d85-9b16-639eec587745)
Request to add text-align justify so text can be properly spaced within its box
Repository: excalidraw
Issue: Eraser very laggy with big canvas
Labels: performance ⚡️,Eraser tool

When I have a canvas and I draw multiple things on it + add some images and it gets big,  the eraser gets very laggy, like I hold it and swipe to erase and it responds sometimes after 5 seconds.

[Video to showcase the bug](https://drive.google.com/file/d/114qSXUXjmTwiv4SaLwvn7JgchaxuFzQy/view?usp=sharing)
Repository: PowerToys
Issue: Locksmith support network machines
Labels: Idea-Enhancement,Needs-Triage,Product-File Locksmith

### Description of the new feature / enhancement

As a user, I would like to run locksmith in a file that I can't close and see which other machine process has the file opened. 

### Scenario when this would be used?

This is very handy for companies that work with network material that is accessed by multiple users.

### Supporting information

_No response_
Repository: rust
Issue: We should document what external dependencies we assume for our test suites
Labels: C-cleanup,A-testsuite,T-compiler,A-docs,A-compiletest

### Location

The test suites, especially `tests/run-make` and `tests/run-make-fulldeps`.

### Summary

It'd be nice for people to be able to reliably run test suites without necessarily having to rely on Docker environments, or at least know what external dependencies are assumed to be available (and what version/flavor as well) by the test suites. This is also relevant for people trying to work on or maintain new targets if they want to run the test suites. Example dependencies (non-exhaustive, have not fully surveyed):

- Utilities: e.g. `nm`, `grep`.
- C/C++ compilers, e.g. what `cc` points to is a massive pain.
- Python: again, *which python version* is also a massive pain.
- Make and makefiles: we're trying to escape from this
- Shell: `bash`? or what do the various bash scripts assume?

For example, the `run-make` test suite has a bunch of assumed external dependencies (like `nm`) which are not documented AFAICT.
Repository: rust
Issue: Tracking issue for `-Zterminal-urls`
Labels: A-diagnostics,T-compiler,T-cargo,C-tracking-issue,-Zterminal-urls

This is a tracking issue for the MCP "-Zterminal-urls" (https://github.com/rust-lang/compiler-team/issues/587).

### About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.

### Steps

- [x] Implementation:
  - https://github.com/rust-lang/rust/pull/107838
- [ ] Adjust documentation ([see instructions on rustc-dev-guide][doc-guide])
- [ ] Stabilization PR ([see instructions on rustc-dev-guide][stabilization-guide])

[stabilization-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs
[nightly-style-procedure]: https://github.com/rust-lang/style-team/blob/master/nightly-style-procedure.md 
[Style Guide]: https://github.com/rust-lang/rust/tree/master/src/doc/style-guide

### Unresolved Questions
<!--
Include any open questions that need to be answered before the feature can be
stabilised.
-->
- Has T-compiler coordinated with T-cargo on their concerns? https://github.com/rust-lang/compiler-team/issues/587#issuecomment-1850436355
- What should we include links for?
  - Currently, error codes: https://github.com/rust-lang/rust/pull/107838
  - Lints? https://github.com/rust-lang/rust/issues/125528
- Should we allow configuration of link amounts? Is that a non-boolean argument?
- Can we autodetect terminal support? Should we?
Repository: rust
Issue: We should document more clearly env vars used between bootstrap <-> compiletest <-> test suites
Labels: C-cleanup,A-testsuite,T-compiler,T-bootstrap,E-medium,A-docs,A-compiletest,E-tedious

### Location

bootstrap <-> compiletest <-> testsuites

### Summary

In `tests/run-make` (for example, but the lack of docs isn't limited to this particular test suite) we assume a bunch of env vars being available, but AFAIK there isn't any docs on which env vars are assumed available between the bootstrap -> compiletest -> test suites pipeline and for what reasons. It'd be nice to have any kind of docs on them.

The current state is that:

- bootstrap sets up a bunch of env vars, which are made available to compiletest
- compiletest assumes bootstrap-set env vars are available
- compiletest sets up a bunch of env vars, often conditionally available to specific test suites
- tests inside test suites assume compiletest-set env vars are available.
Repository: rust
Issue: Decide which methods to add to new `Range` types
Labels: T-libs-api,C-discussion,F-new_range

There's been discussion on the tracking issue:

- https://github.com/rust-lang/rust/issues/123741

...about which methods to add to the new `Range` types.  Let's continue that here.

@orlp [said](https://github.com/rust-lang/rust/issues/123741#issuecomment-2132207968):

> To see which iterator methods we may want to add to the new ranges, I did an informal search on Github using the following query:
> 
> ```
> language:rust NOT is:fork /\W\s*\(\s*\w*\s*\.\.=?\s*\w*\s*\)\s*.\s*method\s*\(/
> ```
> 
> I matched on anything that looks like `( <> .. <> )` or `( <> ..= <> )` that is not immediately preceded by some identifier character, to avoid matching things like `vec.drain(..).map(_)`.
> 
> Example for `map`: [search](https://github.com/search?type=code&q=language%3Arust+NOT+is%3Afork+%2F%5CW%5Cs*%5C%28%5Cs*%5Cw*%5Cs*%5C.%5C.%3D%3F%5Cs*%5Cw*%5Cs*%5C%29%5Cs*.%5Cs*map%5Cs*%5C%28%2F).
> 
> This isn't perfect but captures a rough amount of usage. Just looking by the number of matches:
> 
> * `map`: 65.8k
> * `rev`: 23.2k
> * `collect`: 9.9k
> * `for_each`: 8.5k
> * `step_by`: 8.3k
> * `filter`: 8.2k
> * `flat_map`: 4.2k
> * `fold`: 3.5k
> * `zip`: 3.4k
> * `filter_map`: 1.6k
> * `find`:  1.5k
> * `chain`: 1.4k
> * `take_while`: 1.1k
> * `all`: 1.1k
> * `cycle`: 0.7k
> * `enumerate`: 0.6k
> * `scan`: 0.4k
> * `product`: 0.4k
> * `find_map`: 0.3k
> * `any`: 0.3k
> * `sum`: 0.2k
> * `take`: 0.2k
> * `skip`: 0.1k
> * `try_*`: 0.1k
> * `min*`: 0.1k
> * `max*`: 0.1k
> * `map_while`: 0.1k
> * `position`: 0.1k
> * `skip_while`: 0.1k
> * `count`: 0.1k
> * `reduce`: 0.1k
> * `nth`: 0.1k
> * `unzip`: 0
> 
> I personally think `filter` is a decent cut-off, which gives the inherent methods `map`, `rev`, `collect`, `for_each`, `step_by`, `filter`.

cc @orlp @pitaj @programmerjake
Repository: flutter
Issue: [Impeller] Latest Vulkan SDK introduces validation failures.
Labels: P2,e: impeller,team-engine,triaged-engine

These don't seem like they are critical but we should attempt to fix these ASAP. Only seems to happen on the latest Vulkan SDK on my machine (1.3.283).

* VUID-VkShaderModuleCreateInfo-pCode-08737
* VUID-VkPipelineShaderStageCreateInfo-pSpecializationInfo-06849