sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: kubernetes
Issue: ValidatingAdmissionPolicy: fixes to metrics
Labels: sig/api-machinery,kind/feature,sig/instrumentation,triage/accepted

### What would you like to be added?

As of 1.3, ValidatingAdmissionPolicy metrics are in alpha stability [1]. Currently the metrics have following problems:
- there is no way to count total errors, the current implementation counts only "error but failurePolicy=Ignore" but not denials caused by errors;
- there is no way to differentiate errors, especially, between transient errors like "params not ready" and persistent errors like runtime errors;
- the current implementation does not record the evaluation duration for acceptance or denial due to errors. This issue makes any analysis of policy performance impossible.

This issue purpose the following enhancements to the metrics:

- [ ] add a label of `error` to `check_total` and `check_duration_seconds`
  - the values are enum'ed with each possible error, namely `RUNTIME`, `PARAMS`, `INTERNAL`. The label can be empty for no errors;
- [ ] add error handling to `ObserveRejection`, to record any denials coming from errors;
- [ ] add error reporting to all places where `ObserveRejection` is called;


References:
1. https://github.com/kubernetes/kubernetes/blob/v1.30.0-beta.0/staging/src/k8s.io/apiserver/pkg/admission/plugin/policy/validating/metrics/metrics.go 

### Why is this needed?

resolve the issues mentioned above.


Let's discuss the beta graduation of the metrics in another issue.
Repository: vscode
Issue: Emmet inconsistent behavior in html for php files 
Labels: bug,php,emmet,confirmation-pending

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No
Yes
<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
Version: 1.87.2 (system setup)
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:20:17.278Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Windows_NT x64 10.0.19045

Steps to Reproduce:

1. In a php file type `table` and tab, does not complete
2. In a php file type `table>tr` and tab, does not complete
3. In a php file type `table>tr>` completes
4. In a php file type `table>tr>td*6`  completes
 
In an html file it seems consistent.  There's probably code hinting for PHP getting in the way. By the time you hit `table>` the php suggestions are gone, but emmet hasn't recognized it.   This is different behavior from previously observed.  
It's not clear whether the editor used to see that it was within PHP scope and doesn't now, or if the php code hinter is overzealously cancelling emmet.
Repository: godot
Issue: TileMap ScenesCollections tiles ignore y-sort origin of layer they are placed in.
Labels: bug,discussion,topic:editor,topic:2d

### Tested versions

-Reproducible in 4.3dev5.

### System information

Windows 11 - Godot v4.3dev5 mono - Vulkan (Forward+)

### Issue description

Scenes used inside a TileMap as a ScenesCollection completely ignore the y_sort_origin set for the layer they are placed in. Their y sorting is only affected by the base node's y position.

It is expected that scenes placed inside of a TileMap would respect the y-sort origin like any other tile. Because their y-sorting cannot be directly accessed in order to sort them correctly their origin and texture offsets would have to be individually modified; however, SceneCollections cannot even have their variables accessed inside of the TileSet so this is impossible (and even then if the TileSet is reused inside multiple layers with different y-sort origins this doesn't even help).

### Steps to reproduce

1. Create a TileMap with y_sort_enabled = true.
2. Create 2 Layers inside of this TileMap with y_sort_enabled = true.
3. Create a Sprite2D scene and give it a texture.
4. Create a TileSet inside of the TileMap that has a grid_size smaller than the sprite scene so tiles will overlap.
5. On one of the layers inside the TileMap change the y_sort_origin to be larger than the grid's y size.
7. Inside the TileSet create a new ScenesCollection tile and add the sprite scene.
8. In the TileMap Editor place the new tile on both layers.
9. Note that tiles inside the layer with a higher y_sort_origin value still appear behind the other layer when placed in the cell above.

### Minimal reproduction project (MRP)

[BugReportMRP.zip](https://github.com/godotengine/godot/files/14764796/BugReportMRP.zip)
Repository: vscode
Issue: File quick open does not match exact file paths in multi-root workspace
Labels: feature-request,search,workbench-multiroot,quick-open

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->

Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->

- VS Code Version: 1.87.2
- OS Version: Darwin arm64 23.4.0

```
Version: 1.87.2
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:20:57.520Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Darwin arm64 23.4.0
```


Steps to Reproduce:

1. clone this [minimal reproduction](https://github.com/andrewhamon/vscode_dir_test/): `git clone git@github.com:andrewhamon/vscode_dir_test.git`
2. launch the vscode workspace: `cd vscode_dir_test && code test.code-workspace`
3. search for `workspace_1/test_file.txt` in the quick-open menu
4. get no matching results:
    <img width="1446" alt="Screenshot 2024-03-26 at 3 11 16 PM" src="https://github.com/andrewhamon/vscode_dir_test/assets/5134584/a140e120-cb65-4e88-98ee-098f683165bc">

This situation happens _all the time_ copying fully qualified paths from, say, github. We have a monorepo with multiple roots defined. I believe multiple roots was necessary to get pylance extension working correctly in each sub-folder.


This feels like a dupe of https://github.com/microsoft/vscode/issues/32444, but that issue is closed and locked so I can not comment/reopen it. But the issue does not seem resolved.
Repository: flutter
Issue: [logging] flutter/flutter_drone recipe module does not support FLUTTER_LOGS_DIR
Labels: team-infra,P2,triaged-infra

The flutter_drone recipe does not provide an option to upload additional logs. FLUTTER_LOGS_DIR need to be defined and its content uploaded to GCS.
Repository: flutter
Issue: metrics.json and test results are hardcoded in recipes
Labels: a: tests,team-infra,P2,triaged-infra

Rather than hardcoding the files in recipes the test runner should copy the files to FLUTTER_LOGS_DIR to be processed in a standardized way.
Repository: flutter
Issue: [test_runner] metrics.json file is overwritten multiple times in the same shard
Labels: a: tests,team-infra,P2,triaged-infra

When running shard tests every execution of `dart test`, `flutter test` try to add their output to the same file in <checkout>/metrics.json causing problems parsing the results and adding garbled content. Instead the files should be generated in a temporary folder.
Repository: flutter
Issue: test.dart should allow to provide shard, subshard, results_file as flags
Labels: a: tests,c: proposal,team-infra,P2,triaged-infra

Inspecting environment variables is useful to pass properties during CI executions but when running locally it is preferable to pass the information as flags to the runner script.
Repository: rust
Issue: Tracking Issue for `tcp_syncnt`
Labels: T-libs-api,C-tracking-issue

Feature gate: `#![feature(tcp_syncnt)]`

This is a tracking issue for bringing a thin wrapper around the Linux's `TCP_SYNCNT` socket option.

When a client tries to connect to a server but the latter does not respond, the former sends a SYN packet.
How much does the client send to the server before giving up is what the feature is about.

### Public API

```rust
pub trait TcpStreamExt: Sealed{
  fn syncnt(&self) -> io::Result<u32>;
  fn set_syncnt(&self, count: u32) -> io::Result<()>;
}
```
Repository: node
Issue: Building 20.12.0 with old GLIBC: `sys/random.h: No such file or directory`
Labels: build

### Version

20.12.0

### Platform

Linux 42c14383a17c 6.7.3-100.fc38.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Feb  1 03:33:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

### Subsystem

CentOS 7

### What steps will reproduce the bug?

Use the `quay.io/pypa/manylinux2014_x86_64` docker image (CentOS 7 based) to build nodejs (`./configure`).

### How often does it reproduce? Is there a required condition?

It can be consistently reproduced.

### What is the expected behavior? Why is that the expected behavior?

It can be successfully built, like 20.11.1.

https://github.com/nodejs/node/blob/94fb85426bac26dd44c777eb666f87ebe1a4f8ea/deps/cares/src/lib/ares_rand.c#L38-L40

These three lines were added by #51385 (upstream: https://github.com/c-ares/c-ares/commit/d8edb76bece36267c4c55355ae9c7009e131a0e0), and I believe that `HAVE_SYS_RANDOM_H` is not correctly set when `sys/random.h` is missing in the old glibc (<2.25).

### What do you see instead?

```
2024-03-26T19:49:01.0021083Z     cc -o /tmp/tmppjl__aad/build/nodejs-prefix/src/nodejs/out/Release/obj.target/cares/deps/cares/src/lib/ares_rand.o ../deps/cares/src/lib/ares_rand.c '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_HAS_QUIC' '-DICU_NO_USER_DATA_OVERRIDE' '-D_DARWIN_USE_64_BIT_INODE=1' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-D_GNU_SOURCE' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DCARES_STATICLIB' '-DHAVE_CONFIG_H' -I../deps/cares/include -I../deps/cares/config/linux  -pthread -Wall -Wextra -Wno-unused-parameter -g -pedantic -Wall -Wextra -Wno-unused-parameter --std=gnu11 -m64 -O3 -fno-omit-frame-pointer  -MMD -MF /tmp/tmppjl__aad/build/nodejs-prefix/src/nodejs/out/Release/.deps//tmp/tmppjl__aad/build/nodejs-prefix/src/nodejs/out/Release/obj.target/cares/deps/cares/src/lib/ares_rand.o.d.raw   -c
2024-03-26T19:49:01.0552754Z   ../deps/cares/src/lib/ares_rand.c:39:12: fatal error: sys/random.h: No such file or directory
2024-03-26T19:49:01.0553982Z      39 | #  include <sys/random.h>
2024-03-26T19:49:01.0554526Z         |            ^~~~~~~~~~~~~~
2024-03-26T19:49:01.0559918Z   compilation terminated.
2024-03-26T19:49:01.0588060Z   make[1]: *** [/tmp/tmppjl__aad/build/nodejs-prefix/src/nodejs/out/Release/obj.target/cares/deps/cares/src/lib/ares_rand.o] Error 1
2024-03-26T19:49:01.0590872Z   make[1]: *** Waiting for unfinished jobs....
2024-03-26T19:49:01.2031508Z   rm 6b3de4dd491ec37fd0646cdb3ef3868d29e0cb21.intermediate
2024-03-26T19:49:01.2232100Z   make[1]: Leaving directory `/tmp/tmppjl__aad/build/nodejs-prefix/src/nodejs/out'
2024-03-26T19:49:01.2253454Z   make: *** [node] Error 2
2024-03-26T19:49:01.2263564Z   FAILED: nodejs-prefix/src/nodejs-stamp/nodejs-build /tmp/tmppjl__aad/build/nodejs-prefix/src/nodejs-stamp/nodejs-build
```

### Additional information

_No response_
Repository: rust
Issue: Rust 1.45+ generates suboptimal control flow for ARMv7 atomic compare exchange
Labels: A-LLVM,I-slow,A-codegen,O-Arm,P-low,T-compiler,regression-from-stable-to-stable,I-heavy,C-optimization

### Code

I tried this code:

https://rust.godbolt.org/z/vP88v5GGc

I expected to see this happen:

A tight loop.

Instead, this happened:

In Rust 1.45 and later, LLVM generates a switch + unconditional branch to a conditional branch. This happens in opt-level=z, s, 1, 2, 3.

In some versions generates a dead branch, e.g.

```
mov r2, #0
cmp r2, #0
bne ... # If this branch is taken, hell has frozen over.
```

### Version it worked on

It most recently worked on: 1.44

### Version with regression

`rustc --version --verbose`: 
```
rustc 1.79.0-nightly (0824b300e 2024-03-24)
binary: rustc
commit-hash: 0824b300eb0dae5d9ed59719d3f2732016683d66
commit-date: 2024-03-24
host: x86_64-unknown-linux-gnu
release: 1.79.0-nightly
LLVM version: 18.1.2
```

@rustbot modify labels: +regression-from-stable-to-stable -regression-untriaged
Repository: vscode
Issue: Multi-selected tree view items all render inline actions
Labels: feature-request,polish

As you can see in the image, all selected items render the "inline" actions

![image](https://github.com/microsoft/vscode/assets/641685/93587546-e39c-4c31-998b-4de3dbc9b8a6)

This differs in behavior to the SCM view, for example, which only renders the "inline" actions on the "focused/active" item and/or if hovered

/cc @alexr00
Repository: pytorch
Issue: [Inductor] `test_mixed_mm_dynamic_shapes_cuda` is broken on multiple architectures
Labels: module: cuda,triaged,module: inductor,matrix multiplication

### 🐛 Describe the bug

observed
`python test/inductor/test_torchinductor_codegen_dynamic_shapes.py -k test_mixed_mm_dynamic_shapes_cuda` failing on A2 (sm86/GA107) and V100 (sm70/GV100), among others.

### Versions

Nightly build as of 3/26.

cc @ptrblck @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire @chauhang
Repository: flutter
Issue: test.dart should use args and command runner
Labels: a: tests,c: proposal,team-infra,P2,triaged-infra

test.dart is doing custom parsing of args passed to main this forces adding new args parsing logic to add new flags and does not take advantage of funtionallity provided by args and command runner like generating help and showing all the available options.

Rather than implementing its own parsing logic test.dart should use:

```
import 'package:args/args.dart';
import 'package:args/command_runner.dart';
```
Repository: flutter
Issue: [webview_flutter] Add support to return `null` in `PlatformWebViewController.setOnJavaScriptTextInputDialog`
Labels: c: new feature,p: webview,team-ecosystem,P2,a: plugins,triaged-ecosystem

The method [WebViewController.setOnJavaScriptTextInputDialog](https://pub.dev/documentation/webview_flutter/latest/webview_flutter/WebViewController/setOnJavaScriptTextInputDialog.html) should be able to return `null`. It currently requires a nonnull `String`.

Based on the documentation for Javascript [prompt](https://developer.mozilla.org/en-US/docs/Web/API/Window/prompt) and [WebChromClient.onJsPrompt](https://developer.android.com/reference/android/webkit/WebChromeClient#onJsPrompt(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20java.lang.String,%20android.webkit.JsPromptResult)), this method should support returning a `null` value for the scenario that a user cancels the operation to enter text.

This would require a change to the platform interface, so it would need to follow https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
Repository: rust
Issue: Tracking Issue for RFC 3543 patchable-function-entry
Labels: B-RFC-approved,T-lang,T-compiler,C-tracking-issue,F-patchable_function_entry

This is a tracking issue for the RFC 3543 patchable-function-entry (rust-lang/rfcs#3543).

The feature gate for the issue is `#![feature(patchable_function_entry)]`.

This is support for `patchable-function-entry` as present in [`clang`](https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-fpatchable-function-entry) and [`gcc`](https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html#index-fpatchable-function-entry). This feature is generally used to allow hotpatching and instrumentation of code.

### About tracking issues

Tracking issues are used to record the overall progress of implementation.  They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.  A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.  Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

### Steps

- [x] Implement the RFC: https://github.com/rust-lang/rust/pull/124741
- [ ] Adjust documentation ([see instructions on rustc-dev-guide][doc-guide])
- [ ] Stabilization PR ([see instructions on rustc-dev-guide][stabilization-guide])

[stabilization-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs

### Unresolved Questions

- Should we use LLVM or gcc/clang style for a per-function attribute? Should we support both styles?
- Should we support a more explicit command line argument style?
- Should we reject linking crates with different default padding configurations?


<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"nebulark"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
Repository: go
Issue: x/pkgsite/internal/middleware: TestCache failures
Labels: NeedsInvestigation

```
#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/middleware" && test == "TestCache"
```

Issue created automatically to collect these failures.

Example ([log](https://build.golang.org/log/64111c61f6bd297b83525c145b6753293640b3b8)):

    2024/03/26 15:37:41 Info: caching response of length 25 for /A
    2024/03/26 15:37:42 Info: cache get("/A"): context timed out
    2024/03/26 15:37:42 Info: caching response of length 25 for /A
    2024/03/26 15:37:42 Debug: serving "/A" from cache
    --- FAIL: TestCache (0.21s)
        caching_test.go:156: [A is cached] GET returned status 403, want 200
        caching_test.go:164: [A is cached] GET returned body 3, want 2
        caching_test.go:182: [A is cached] CacheResultCount diff (-want +got):
              map[bool]int{
            - 	false: 2,
    ...
            + 	true:  1,
              }
        caching_test.go:182: [bypassing the cache] CacheResultCount diff (-want +got):
              map[bool]int{
            - 	false: 3,
            + 	false: 4,
            - 	true:  2,
            + 	true:  1,
              }
    2024/03/26 15:37:42 Error: middleware.Panic: panic!


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: pytorch
Issue: How to reduce memory usage for large matrix calculations？
Labels: triaged


A_ = torch.sigmoid(torch.matmul(x, x.t()))
x is the feature of tens of thousands of nodes, the shape is 700,000*8, 8 is the number of features extracted from each node.
Calculation requires several t of memory. How to reduce memory overhead?
Repository: pytorch
Issue: Throwing more specific errors for CrossEntropyLoss weights being on a different device than the input/target
Labels: module: nn,triaged

### 🚀 The feature, motivation and pitch

While calculating CrossEntropyLoss, both the model_output and target are on the same device (cuda), but the weights were on the cpu.

loss_fn = torch.nn.CrossEntropyLoss(weight=weights)
loss = loss_fn(input=model_output, target=labels)

Currently, we would get the following:
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!

But how? Wasn't both the input and target for the loss_fn on the same device (cuda)?
Answer: Because someone forgets to put the weights on cuda.

This problem becomes significant if the loss_fn were defined somewhere else rather than defining it just before calculating the loss, as it's not so apparent.

Can we please have an explicit error that describes that the **weights** (instance attributes) were on a different device than the **input** and **target** (function arguments)?

### Alternatives

_No response_

### Additional context

_No response_

cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki
Repository: transformers
Issue: LLaVA `torch.compile` implementation
Labels: Feature request,Good Difficult Issue,Compilation

### Feature request

As per #28981, LLaVA is planned to receive `torch.compile` support. Seeing to the fact that LLaVA is composed of a vision tower and a LLM, both of which can be separately compiled with `fullgraph=True` (after support has been added, which is not the case for Mistral), it seems much easier to compile both parts separately as well.

### Motivation

The `_merge_input_ids_with_image_features` function that connects the two parts is difficult to compile as PyTorch has yet to add support for many of the functions used that require dynamic input sizes, which are necessary here as the number of input image tokens is subject to change.

### Your contribution

I'd love to try submitting a PR if possible but I'm not sure what the best way to do so is given the current circumstances.
Repository: pytorch
Issue: this is a bug within maybe_initialize_device for custom device
Labels: triaged,module: inductor

### 🐛 Describe the bug

I am adding `lazy_init`  to our custom device, and a `._lazy_init()` method is defined on our device module.
so we need  to[ add PrivateUse1 device to enable lazy initialization](https://github.com/pytorch/pytorch/blob/f2c1060de3cdddbfefcab11e547211993d0f9cfa/torch/csrc/utils/device_lazy_init.h#L31) in `maybe_initialize_device`.
But torch can't enable lazy initialization for  PrivateUse1 device  in `maybe_initialize_device`.
more details : https://github.com/pytorch/pytorch/pull/121379.



### Versions

branch: main

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire @chauhang
Repository: vscode
Issue: Support cell output toolbar contribution
Labels: feature-request

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

Currently we support contributions to the cell output toolbar from core, it would be great if we can enable extension contributions, which can allow us to explore features like "Explain the output".