sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: vscode
Issue: [folding] Editor expands when a folding provider comes in with delay
Labels: bug,editor-folding

I'm the author of the Dart extension. I had a bug reported that folding regions don't persist correctly at https://github.com/Dart-Code/Dart-Code/issues/4769. I never knew that them persisting was a feature - but I tested with TypeScript and sure enough they do. There's also a comment at https://github.com/microsoft/vscode/issues/60668#issuecomment-429652653 from @aeschli that says:

> The prior state is already persisted (fold some ranges, close editor, reopen editor, ranges are still folded).
If this doesn't work for you, please create a new issue with a sample that shows the problem.

So it seems like the issue may be specific to Dart - but I cannot figure out what's up. If I log the LSP traffic, I see the following request/response for a folding range:

```js
Req: {
	"jsonrpc": "2.0",
	"id": 5,
	"method": "textDocument/foldingRange",
	"params": {
		"textDocument": {
			"uri": "file:///C%3A/Dev/Test%20Projects/dartcode_4769/bin/dartcode_4769.dart"
		}
	},
}
Res: {
	"id": 5,
	"jsonrpc": "2.0",
	"result": [
		{
			"endLine": 4,
			"startLine": 2
		}
	]
}
```

However, when I reload the editor, I see the folded region persist - and then quickly re-open:

https://github.com/microsoft/vscode/assets/1078012/09cdaf1b-9fa2-46af-b188-2234e11b0056

I cannot find any folding-related code in the Dart extension that could be causing this, nor can I find any settings that seem like they might impact this.
Repository: stable-diffusion-webui
Issue: [Feature Request]: Disable model loading on startup.
Labels: enhancement

### Is there an existing issue for this?

- [X] I have searched the existing issues and checked the recent builds/commits

### What would your feature do ?

I want to request a feature to disable model automatic loading, as i also use comfyUI for simpler generations, as i've not figured out img2img properly or controlnet being finnicky, so automatic's works better there and has more features, but as automatic1111 is the only one with a proper "model browser" with images and whatnot, i want to request a setting to disable automatic model loading for us who runs this barebone automatic just for showing models and their names to use in other diffusers.

### Proposed workflow

Go to settings, stable diffusion tab, uncheck "automatically load in last model used/default model"

### Additional information

_No response_
Repository: rust
Issue: Confusing error when passing a closure to a function that expects a reference to a closure.
Labels: A-diagnostics,T-compiler,D-confusing

### Code

```Rust
fn testing<F: Fn(u32)>(function: &F) {
    todo!()
}

fn main() {
    testing(|value|{
        value.to_string();
    })
}
```


### Current output

```Shell
Compiling playground v0.0.1 (/playground)
error[E0282]: type annotations needed
 --> src/main.rs:6:14
  |
6 |     testing(|value|{
  |              ^^^^^
7 |         value.to_string();
  |         ----- type must be known at this point
  |
help: consider giving this closure parameter an explicit type
  |
6 |     testing(|value: /* Type */|{
  |                   ++++++++++++

For more information about this error, try `rustc --explain E0282`.
error: could not compile `playground` (bin "playground") due to previous error
```


### Desired output

```Shell
Compiling playground v0.0.1 (/playground)
error[E0308]: mismatched types
 --> src/main.rs:6:13
  |
6 |       testing(|value|{
  |  _____-------_^
  | |     |
  | |     arguments to this function are incorrect
7 | |         value.to_string();
8 | |     })
  | |_____^ expected `&_`, found closure
  |
  = note: expected reference `&_`
               found closure `{closure@src/main.rs:6:13: 6:25}`
note: function defined here
 --> src/main.rs:1:4
  |
1 | fn testing<F: Fn(u32)>(function: &F) {
  |    ^^^^^^^             ------------
help: consider borrowing here
  |
6 |     testing(&|value|{
  |             +

For more information about this error, try `rustc --explain E0308`.
error: could not compile `playground` (bin "playground") due to previous error
```


### Rationale and extra context

The thing missing for the code to typecheck is not the type of the closure parameter but the reference to the closure.

The "desired output" is taken from what is obtained after adding the type to the parameter. So following the compiler's suggestion does lead to an error message that is actually helpful. This message should likely be shown in the first place.

### Other cases

_No response_

### Anything else?

Tested with :

Nightly channel
Build using the Nightly version: 1.75.0-nightly
(2023-10-03 187b8131d4f760f856b2)

[Playground link](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=931b32de6f575e6d9baa46432d973f3f)
Repository: vscode
Issue: Diff hidden lines doesn't work correctly with workspace search and replace
Labels: bug,diff-editor


Type: <b>Bug</b>

1. Have the diff editor hidden lines setting enabled
2. Use the workspace search and expand it to do a replace

the left side is not aligned with the right side because the left has hidden lines but the right does not

VS Code version: Code 1.82.3 (fdb98833154679dbaa7af67a5a29fe19e55c2b73, 2023-10-02T10:51:22.294Z)
OS version: Windows_NT x64 10.0.23555
Modes:

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 x 2592)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled|
|Load (avg)|undefined|
|Memory (System)|31.75GB (16.20GB free)|
|Process Argv|--folder-uri file:///d%3A/PSSiOpsFeed/PSUtils --crash-reporter-id 50c76677-d175-4d77-87f8-f82b2959c282|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (66)</summary>

Extension|Author (truncated)|Version
---|---|---
better-comments|aar|3.0.2
vscode-opennewinstance|chr|0.0.12
npm-intellisense|chr|1.4.4
path-intellisense|chr|2.8.4
vscode-zonefile|Com|0.0.4
azure-devops-snippets|dam|1.0.6
vscode-markdownlint|Dav|0.52.0
docs-markdown|doc|1.0.3
githistory|don|0.6.20
xml|Dot|2.5.1
gitlens|eam|14.3.0
vscode-nupkg|eri|1.0.1
prettier-vscode|esb|10.1.0
git-project-manager|fel|1.8.2
copilot|Git|1.122.462
copilot-chat|Git|0.7.1
copilot-labs|Git|0.15.1019
remotehub|Git|0.60.0
vscode-codeql|Git|1.9.1
json2ts|Gre|0.0.6
vscode-test-explorer|hbe|2.21.1
rest-client|hum|0.25.1
reg|ion|1.1.0
ts-extension-pack|loi|0.3.0
vscode-swissknife|lui|1.8.1
azure-pipelines|ms-|1.228.0
vscode-azureappservice|ms-|0.25.0
vscode-azureresourcegroups|ms-|0.7.5
vscode-azurevirtualmachines|ms-|0.6.5
vscode-bicep|ms-|0.21.1
vscode-cosmosdb|ms-|0.19.4
csharp|ms-|2.4.4
vscode-dotnet-runtime|ms-|1.8.0
data-workspace-vscode|ms-|0.5.0
mssql|ms-|1.21.0
sql-database-projects-vscode|ms-|1.3.1
azure-account|ms-|0.11.5
azure-repos|ms-|0.36.0
azurecli|ms-|0.5.0
cpptools|ms-|1.17.5
cpptools-extension-pack|ms-|1.3.0
live-server|ms-|0.4.9
powershell|ms-|2023.6.0
remote-repositories|ms-|0.38.1
test-adapter-converter|ms-|0.1.8
vsliveshare|ms-|1.0.5883
azurerm-vscode-tools|msa|0.15.11
material-icon-theme|PKi|4.30.1
material-product-icons|PKi|1.6.0
tsimporter|pmn|2.0.1
vscode-commons|red|0.0.6
vscode-yaml|red|1.14.0
glassit|s-n|0.2.6
arm-snippets|sam|1.4.19
vscode-table-formatter|shu|1.2.1
vscode-zipexplorer|sle|0.3.1
code-spell-checker|str|3.0.1
move-ts|str|1.12.0
pdf|tom|1.2.2
vscode-mermaid-editor|tom|0.19.1
intellicode-api-usage-examples|Vis|0.2.8
vscodeintellicode|Vis|1.2.30
vscode-conventional-commits|viv|1.25.0
vscode-icons|vsc|12.5.0
vscode-typescript-vue-plugin|Vue|1.8.15
markdown-all-in-one|yzh|3.5.1


</details>
<!-- generated by issue reporter -->
Repository: terminal
Issue: Inactive tabs icons are blurry
Labels: Help Wanted,Issue-Bug,Area-UserInterface,Product-Terminal

### Windows Terminal version

1.19.2682.0

### Windows build number

10.0.19045.3448

### Other Software

_No response_

### Steps to reproduce

1. Start WT.
2. Look at the tab icon.
3. Open a new tab.
4. Look at the previous tab icon again.
5. Switch between tabs a few more times.

### Expected Behavior

Pixel-perfect icons everywhere.

### Actual Behavior

Only the active tab icon looks good, the inactive one is blurry:

![blur](https://github.com/microsoft/terminal/assets/11453922/cb7b7241-a4bf-4cd7-bf58-bb82e356d513)

I didn't look into the code, but it could be due to downscaling of inactive tabs by a pixel or so, if the icon gets baked into the tab before this downscaling and not after it:

![image](https://github.com/microsoft/terminal/assets/11453922/b05ecc3a-7a3a-4c99-aaeb-0b92970ec0f3)
Repository: godot
Issue: The next/previous focus element is incorrectly determined in a BoxContainer with negative separation
Labels: bug,topic:gui

### Godot version

v4.1.1.stable.mono.official [bd6af8e0e]

### System information

Godot v4.1.1.stable.mono - macOS 14.0.0 - Vulkan (Mobile) - integrated Apple M2 Pro - Apple M2 Pro (12 Threads)

### Issue description

When using a negative Separation value in an HBoxContainer, the next Focus element is not correctly determined. In this case, ```FindNextValidFocus()``` finds the correct element, but when using the left-right arrows, the focus jumps over one element. When Separation > 0 is set, everything becomes normal. Apparently, the Bounds of the elements are taken into account, and not their sequence inside the BoxContainer.


https://github.com/godotengine/godot/assets/1033758/b863bb6f-04b2-496a-840a-4a77b258a057


https://github.com/godotengine/godot/assets/1033758/e44a55b0-f8b5-436e-a6f6-30a25cd3a86c



### Steps to reproduce

1. Create HBoxContainer
2. Fill it with elements
3. Set negative Separation property

### Minimal reproduction project

Change UIVillageDeck.cs:CARDS_COUNT to repro. 10 to ok. 20 to bug.

This is C# version. Gdscript is not in my arsenal. I'm sorry.

[BoxContainerFocus.zip](https://github.com/godotengine/godot/files/12805755/BoxContainerFocus.zip)
Repository: kubernetes
Issue: Tests that need to be removed/rewritten to support kops
Labels: kind/bug,priority/important-soon,sig/cluster-lifecycle,sig/testing,lifecycle/frozen,needs-triage

Various existing e2e tests are broken when they are ran on clusters that are provisioned by kops. This happens because:
- tests assume a component runs a systemd service when kops deploys it via container
- kubernetes resources have been renamed by upstream component maintainers and kops uses the updated names (an example of this is coredns. CoreDNS deployes kube-dns-autoscaler component with different names but current tests fail as kube-up cluster deploys the addon separately with a different name)
- tests use ssh to run commands on the control plane instance instead of using hostexec(look at https://github.com/kubernetes/kubernetes/pull/103640 for an explanation) 

Broken tests
1. [sig-node] NodeProblemDetector should run without error [sig-node]
    https://testgrid.k8s.io/sig-cluster-lifecycle-kubeup-to-kops#ci-kubernetes-e2e-cos-gce-canary&include-filter-by-regex=NodeProblemDetector 
    The pod name that the test check doesnt match #121007 
1. [sig-autoscaling] DNS horizontal autoscaling kube-dns-autoscaler should scale kube-dns pods in both nonfaulty and faulty scenarios [sig-autoscaling]
    https://testgrid.k8s.io/sig-cluster-lifecycle-kubeup-to-kops#ci-kubernetes-e2e-cos-gce-canary&include-filter-by-regex=kube-dns
    kube-dns-autoscaler Configmap is now called coredns-autoscaler #121422

Tests to be removed:
1.  [sig-network] Firewall rule should have correct firewall rules for e2e cluster https://github.com/kubernetes/kubernetes/pull/120977
2. [sig-cloud-provider-gcp] Addon update should propagate add-on file changes [Slow] https://github.com/kubernetes/kubernetes/pull/120968 

Part of https://github.com/kubernetes/enhancements/issues/4224
Part of https://github.com/kubernetes/enhancements/pull/4250

/sig testing
/sig cluster-lifecycle
/triage accepted
/kind bug
/priority important-soon
Repository: vscode
Issue: Command to open view container doesn't toggle properly
Labels: bug,help wanted,webview

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.82
- OS Version: macOS 13.5

Steps to Reproduce:

1. contribute a sidebar webview via an extension
2. trigger `workbench.view.extension.my-view-container`. this opens the webview
3. trigger `workbench.view.extension.my-view-container` again. this should toggle focus back to the editor, but doesn't

https://github.com/microsoft/vscode/blob/4a0e77678c0295b518151ae2d706436bab96ef4f/src/vs/workbench/browser/parts/views/viewsService.ts#L380-L384

I think it's the `!layoutService.hasFocus(part)` piece that's causing problems. as far as I can tell, `document.activeElement` is the webview's iframe, but the iframe is not actually a child of the sidebar container, so the `hasFocus` (I think) always returns false.
Repository: godot
Issue: ScrollContainer scroll bar when using StyleBoxTexture does not have its detection box expand with the margins of the image.
Labels: bug,usability,topic:gui

### Godot version

v4.1.stable.official [970459615]

### System information

Godot v4.1.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (NVIDIA; 31.0.15.3623) - 12th Gen Intel(R) Core(TM) i9-12900KF (24 Threads)

### Issue description

When using a ScrollContainer, if you make the grabber (Grabber/Grabber Highlight/Grabber Pressed) a StyleBoxTexture, you will need to expand the image via Expand Margins if your grabber image is bigger than the default size of the scroll bar.

The issue is that when you expand the margin, the detection box for the grabber doesn't expand with it, resulting in the mouse cursor needing to meet the original size of the scrollbar in order to grab it despite the texture being bigger.

Adjusting Content Margins doesn't change this behavior.

### Steps to reproduce

Defined in description.

### Minimal reproduction project

N/A
Repository: next.js
Issue: Using useRouter with edge runtime leads to this error: Error: invariant expected app router to be mounted
Labels: bug,Navigation,Runtime

### Link to the code that reproduces this issue

https://github.com/joncoronel/testing-next

### To Reproduce

1. Start the application in a local dev server
2. Load the root page: i.e. http://localhost:3000/
3. Check server logs for error.
4. Open browser dev tools, disable caching, and then reload the page while inspecting the `<html>` element. 

### Current vs. Expected behavior

Using edge runtime on a route/page and then using `useRouter` in a client component within that page should not lead to any error. Currently it causes both an error in the dev server logs and also causes an error in the page html element on initial load or reload: `<html id="__next_error__">`. It disrupts the loading of fonts since they are passed as variable in the html element. 

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
  Platform: win32
  Arch: x64
  Version: Windows 11 Pro
Binaries:
  Node: 20.7.0
  npm: N/A
  Yarn: N/A
  pnpm: N/A
Relevant Packages:
  next: 13.5.5-canary.1
  eslint-config-next: 13.4.4
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.0.4
Next.js Config:
  output: N/A
```


### Which area(s) are affected? (Select all that apply)

App Router, Middleware / Edge (API routes, runtime), Routing (next/router, next/navigation, next/link)

### Additional context

This error has been occurring since next 13.4.8. I tested 13.4.7 and it does not have this error. I also updated to 13.5.4 and the issue is still present as well as the latest canary build. 
This error specifically occurs when using edge runtime and useRouter. Removing either of them removes this error.
Repository: next.js
Issue: Using next dev server module, doesn't respect configuration object
Labels: bug

### Link to the code that reproduces this issue

https://github.com/leimonio/use-nextjs-module-config

### To Reproduce

1. Clone the repo
2. Run `npm run dev:custom` - running the dev server for `next-root`
   Alternatively, run `npm run dev:custom:pages` - running the dev server for `next-root-pages`
3. Open browser at `localhost:9988`
4. Observe `The value of customKey is: ` string is empty without containing any env key.
5. Uncomment the `env` configuration from `next.config.js` and rerun the command in step 2.
6. Observe `The value of customKey is: my-value` string is printing the env key `my-value`.

### Current vs. Expected behavior

**Current Behavior:**

When using Next.js as an imported module `import next from "next";` and running the dev server with providing a configuration object, the configuration object is not respected.

```javascript
import next from "next";
// ...
// ...

next({
  dev: true,
  dir: nextRoot,
  conf: {
    env: {
      customKey: "my-value",
    },
  },
});
```

**Expected Behavior:**

The configuration object provided in the `next` function should be respected.
As result the `The value of customKey is: my-value` should be printed without adding the respective configuration in `next.config.js` in the example above.


### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
  System Version: macOS 13.5.2
  Kernel Version: Darwin 22.6.0
Binaries:
  Node: 16.19.0
  npm: 8.19.3
Relevant Packages:
  next: 13.5.4
  eslint-config-next: 13.5.4
  react: ^18
  react-dom: ^18
  typescript: ^5
Next.js Config:
  output: N/A
```


### Which area(s) are affected? (Select all that apply)

App Router

### Additional context

_No response_
Repository: godot
Issue: SDFGI - Probes all black, no lights reflected in shadow, shadows pitch black
Labels: discussion,topic:rendering,topic:3d

### Godot version

4.1.1.stable.mono.official

### System information

Linux Mint  (GTX 1060 - NVidia driver 535)

### Issue description

The probes from SDFGI stay black and don't reflect any light. No light seems to be reflected.
![image](https://github.com/godotengine/godot/assets/10598991/59ae8a30-6713-4be7-926f-57076ef8a0d1)

Found an old similar issue here:
https://github.com/godotengine/godot/issues/39969

### Steps to reproduce

Open the minimal project in the editor and toggle on SDFGI probes. Also notice the pitch black shadows, and notice no light is beeing reflected by moving inside the house in the scene.

### Minimal reproduction project

Dropbox link:
https://www.dropbox.com/scl/fi/mro6cf8aukwmuglk7c9bq/quasargame.zip?rlkey=bo8ck0nt0vq7q7xkfar3ugcby&dl=0
Repository: next.js
Issue: trailingSlash middleware causes inconsistent redirects with custom server
Labels: bug,Navigation

### Link to the code that reproduces this issue

https://github.com/julesyoungberg/next-trailingslash-reproduction/tree/main

### To Reproduce

The reproduction repo is based on the custom server example, but pages are resolved separately and rendered with `app.render`. By default, the path passed to `app.render` does not include a trailing slash, but it can be included with `?trailingSlash=true`. To reproduce:

1. install deps (npm ci)
2. build next (npm run build)
3. run server (npm run start)
4. navigate to http://localhost:3000/a/ and notice the error `ERR_TOO_MANY_REDIRECTS`. 
5. navigate to http://localhost:3000/a/?trailingSlash=true and notice that it works.
6. navigate to http://localhost:3000/ and notice that it works.
7. navigate to http://localhost:3000/?trailingSlash=true and notice the page 404s.

### Current vs. Expected behavior

Next is redirecting internal paths that are passed to `app.render` without a trailing slash (except for `/index`). 

In Next 13.3, the trailingSlash middleware only applied to the external URL, and if a path was passed to `app.render` with a trailing slash, the page would 404. You can see this behaviour by visiting http://localhost:3000/a/?trailingSlash=true on the `next-13.3.4` branch of the reproduction repo.

Since Next 13.4, internal paths without a trailing slash are redirected, except for `/index`. You can see this behaviour on the `main` and `next-13.4.19` branches of the reproduction repo, as described above.

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
  Platform: linux
  Arch: x64
  Version: #1 SMP Fri Jan 27 02:56:13 UTC 2023
Binaries:
  Node: 18.18.0
  npm: 9.8.1
  Yarn: N/A
  pnpm: N/A
Relevant Packages:
  next: 13.5.5-canary.1
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 4.9.5
Next.js Config:
  output: N/A
```


### Which area(s) are affected? (Select all that apply)

Routing (next/router, next/navigation, next/link)

### Additional context

I work on several applications that resolve the page with an external API, and then pass `/<page>` to `app.render`. We can update our applications to work with this new behaviour, but the inconsistency with `/index` makes it seem like a bug. Furthermore, we did not expect such breaking changes in a minor version upgrade.