sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: kubernetes
Issue: e2epod.DeletePodWithWait{,ByName} does not handle pods that get restarted
Labels: kind/bug,sig/testing,lifecycle/rotten,area/e2e-test-framework,needs-triage

### What happened?

`e2epod.DeletePodWithWaitByName` does (simplified)

```
        err := c.CoreV1().Pods(podNamespace).Delete(ctx, podName, metav1.DeleteOptions{})
        err = WaitForPodNotFoundInNamespace(ctx, c, podName, podNamespace, PodDeleteTimeout)
```

If the pod in question is managed by a controller or operator, then it is possible that it will be restarted in between the Delete and the WaitForPodNotFoundInNamespace, in which case WaitForPodNotFoundInNamespace will wait for the _new_ pod to not be present rather than the old one.

eg, some of the ovn-kubernetes e2e tests use this function to restart ovn-k control-plane pods in various circumstances (the e2e test kills a pod which is managed by a StatefulSet, knowing it will be restarted), and sometimes hits the race condition. eg, [here](https://github.com/ovn-org/ovn-kubernetes/actions/runs/10451772693/job/28939840358?pr=4623):

```
2024-08-19T11:40:56.3501692Z   I0819 11:40:56.349677 79626 delete.go:62] Deleting pod "ovnkube-db-2" in namespace "ovn-kubernetes"
2024-08-19T11:40:56.3606091Z   I0819 11:40:56.360068 79626 delete.go:70] Wait up to 5m0s for pod "ovnkube-db-2" to be fully deleted
...
2024-08-19T11:45:57.4798660Z   [FAILED] failed to delete pod ovnkube-db-2: pod "ovnkube-db-2" was not deleted: expected pod to not be found: Timed out after 300.001s.
2024-08-19T11:45:57.4799987Z   Expected
2024-08-19T11:45:57.4800476Z       <*v1.Pod | 0xc000eba488>: 
2024-08-19T11:45:57.4801044Z           metadata:
2024-08-19T11:45:57.4801863Z             creationTimestamp: "2024-08-19T11:41:00Z"
...
2024-08-19T11:45:57.5299664Z   to be nil
```

note that the `creationTimestamp` of the pod in question is _after_ the deletion.

### What did you expect to happen?

Either

1. DeletePodWithWait{,ByName} checks the `resourceVersion` of the pod before deleting it, and waits specifically for _that_ version of the pod to not exist any more, or
2. DeletePodWithWait{,ByName} are documented as not handling this case

### How can we reproduce it (as minimally and precisely as possible)?

Write an e2e test that deletes a pod that will be recreated automatically (by an `apps` API or by an operator).

### Anything else we need to know?

/sig testing
/area e2e-test-framework

### Kubernetes version

`v1.30.2`


### Cloud provider

N/A


### OS version

_No response_

### Install tools

_No response_

### Container runtime (CRI) and version (if applicable)

_No response_

### Related plugins (CNI, CSI, ...) and versions (if applicable)

_No response_
Repository: rust
Issue: Consider using random keys for incr. comp. hashing
Labels: C-enhancement,T-compiler,A-incr-comp,A-reproducibility

There's been [recent discussion](https://github.com/rust-lang/rust/issues/10389#issuecomment-2250692018) about the problems of using unkeyed SipHash128 in the compiler and if that could be exploited by an attacker.

With respect to incremental compilation, it would be possible to generate random keys and cache them together with the dep-graph. These keys could then affect query result fingerprints and dep-node identifiers. Any new from-scratch compilation session would generate new keys, so finding stable collisions should be impossible.

The only downside is that it would be hard to reproduce an actual collision if we ever found one because the keys have to be known for that. However, reproducing collisions that are due to faulty `HashStable` impls (which is the much more likely case) should be reproducible independent of the keys being used.
Repository: ui
Issue: [bug]: Orders code block does not show anything
Labels: bug

### Describe the bug

When copying or using the orders code block (or almost all of them but that the one I've used) it returns a blank page !
the reason is simply that the component TooltipProvider is not imported nor used and if its not used react will return a blank page for some reason, the issue is fixed by importing TooltipProvider component and simply adding it as a parent component for the other tooltip component, I hope you fix it soon so other users wont get confused and thanks for your wonderful ui library <3

### Affected component/components

Tooltip

### How to reproduce

1 - copy almost any building block's code 
2 - paste and run it, It will return a blank page
the issue is fixed by importing Tooltip provider and using it as a parent component 

### Codesandbox/StackBlitz link

blank page

### Logs

```bash
blank
```


### System Info

```bash
windows 10
chrome browser
nodejs, react with typescript and vite
```


### Before submitting

- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues
Repository: bitcoin
Issue: Control-flow application capabilities for `x86_64-linux-gnu` release binaries
Labels: Linux/Unix,Build system

When building static binaries for `x86_64-linux-gnu`, one can verify that both Control-flow Enforcement Technology (CET) capabilities--indirect branch tracking (IBT) and shadow stack--are enabled by running the following command:
```
$ readelf -n src/bitcoind | grep feature
      Properties: x86 feature: IBT, SHSTK
```
However, that is not the case for the Guix binaries:
```
$ readelf -n bin/bitcoind | grep feature
      Properties: x86 feature used: x86, x87, XMM, YMM, XSAVE
```
Repository: rust
Issue: E0050 emitted unexpectedly on missing `:`
Labels: A-diagnostics,A-parser,T-compiler,D-confusing,D-papercut,D-verbose

### Code

```Rust
use std::fmt;

struct Hello;

impl fmt::Display for Hello {
    fn fmt(&self, f: &fmt:Formatter) -> fmt::Result {
        write!(f, "hello")
    }
}
```


### Current output

```Shell
Compiling playground v0.0.1 (/playground)
error: expected parameter name, found `:`
 --> src/lib.rs:6:26
  |
6 |     fn fmt(&self, f: &fmt:Formatter) -> fmt::Result {
  |                          ^ expected parameter name

error: expected one of `!`, `(`, `)`, `,`, `::`, or `<`, found `:`
 --> src/lib.rs:6:26
  |
6 |     fn fmt(&self, f: &fmt:Formatter) -> fmt::Result {
  |                          ^
  |                          |
  |                          expected one of `!`, `(`, `)`, `,`, `::`, or `<`
  |                          help: missing `,`

error[E0573]: expected type, found module `fmt`
 --> src/lib.rs:6:23
  |
6 |     fn fmt(&self, f: &fmt:Formatter) -> fmt::Result {
  |                       ^^^ not a type

error[E0050]: method `fmt` has 3 parameters but the declaration in trait `std::fmt::Display::fmt` has 2
 --> src/lib.rs:6:12
  |
6 |     fn fmt(&self, f: &fmt:Formatter) -> fmt::Result {
  |            ^^^^^^^^^^^^^^^^^^^^^^^^ expected 2 parameters, found 3
  |
  = note: `fmt` from trait: `fn(&Self, &mut Formatter<'_>) -> Result<(), std::fmt::Error>`

Some errors have detailed explanations: E0050, E0573.
For more information about an error, try `rustc --explain E0050`.
error: could not compile `playground` (lib) due to 4 previous errors
```


### Desired output

```Shell
Compiling playground v0.0.1 (/playground)
error: expected parameter name, found `:`
 --> src/lib.rs:6:26
  |
6 |     fn fmt(&self, f: &fmt:Formatter) -> fmt::Result {
  |                          ^ expected parameter name

error: expected one of `!`, `(`, `)`, `,`, `::`, or `<`, found `:`
 --> src/lib.rs:6:26
  |
6 |     fn fmt(&self, f: &fmt:Formatter) -> fmt::Result {
  |                          ^
  |                          |
  |                          expected one of `!`, `(`, `)`, `,`, `::`, or `<`
  |                          help: missing `,`

error[E0573]: expected type, found module `fmt`
 --> src/lib.rs:6:23
  |
6 |     fn fmt(&self, f: &fmt:Formatter) -> fmt::Result {
  |                       ^^^ not a type

Some errors have detailed explanations: E0050, E0573.
For more information about an error, try `rustc --explain E0050`.
error: could not compile `playground` (lib) due to 4 previous errors
```


### Rationale and extra context

When looking at rust-analyzer output or when just looking at the last few error messages, it's easy to see only the "too many arguments" error, and not the syntax error that points at the exact problem.

### Other cases

_No response_

### Rust Version

```Shell
1.80.1
```


### Anything else?

_No response_
Repository: PowerToys
Issue: File & Folder colorize/highlight
Labels: Needs-Triage

### Description of the new feature / enhancement

Right-click menu with some color options to highlight files and folders. Would be nice if it traveled with the files and folders.

### Scenario when this would be used?

For all projects and files in progress.

### Supporting information

OSX has had this for many years.
Repository: ui
Issue: [feat]: Need to create phone number input component like "React-Phone-Input-2"  
Labels: area: request

### Feature description

Feature Description: Phone Number Input Component
Feature Name: PhoneNumberInput

Category: Form Controls

Description:
The PhoneNumberInput component is designed to allow users to input and format phone numbers in a standardized and user-friendly manner. This component is essential for applications that require phone number input with country code selection, automatic formatting, and validation.

Why It's Needed:
Currently, the Shadcn UI library lacks a specialized phone number input component that handles country code selection, formatting, and validation in one package. Adding this component will enhance the form controls offering, providing developers with a ready-to-use solution for phone number inputs, which are common in many web applications.



### Affected component/components

_No response_

### Additional Context

 <PhoneNumberInput
        label="Phone Number"
        defaultCountry="US"
        required
        onChange={(value) => console.log(value)}
      />
      
      Example like: https://www.npmjs.com/package/react-phone-input-2

### Before submitting

- [x] I've made research efforts and searched the documentation
- [x] I've searched for existing issues and PRs
Repository: pytorch
Issue: Torch Distributed Elastic has no way to address non-retriable errors
Labels: oncall: distributed,triaged

### 🚀 The feature, motivation and pitch

Looking at https://pytorch.org/docs/stable/elastic/errors.html, I don't see any way to avoid restarts when a non-retriable user error has happened. It is often important for user errors to have varieties as well. For instance, user's training module may discover an error at runtime that is non-retriable (say a node level issue that requires an orchestration level restart). There is currently no way to tell elastic agent that the exception should not be retried.  

### Alternatives

Wait until we run out of retries.

### Additional context

None

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
Repository: godot
Issue: AudioStreamPlayer's volume ignored on web when playing it with an AnimationPlayer's audio clips track.
Labels: bug,platform:web,needs testing,topic:audio

### Tested versions

Reproducible with Godot 4.3 Stable. Web export. I'm assuming this happens because of the new (4.3) web audio sample system.

### System information

Windows 10, Web export, Chrome, Godot4.3 Stable, wav format.

### Issue description

AudioStreamPlayer's volume property is not applied, it doesn't affect the actual volume of the played audio when playing it using an AnimatioPlayer's animation that uses an audio clips track to play the audio. Only happens on web. Only when playing the audio using an audio clips track. 


### Steps to reproduce

In the minimal reproduction project I have two AudioStreamPlayers. Both can reproduce the same "footsteps.wav" audio, and both are set to -80 dB, so they should both emit no sound when played if they are applying the volume properly. However, when pressing the second button that plays an AnimationPlayer's animation that uses an audio clips track to reproduce the audio, the volume is ignored in the web so the audio can be heard at normal volume. 

For reference, pressing the first button will play the audio using another AnimationPlayer's animation but with a track that
enables the playing property of the AudioStreamPlayer. Doing it this way, or any other way other than using the audio clips
track, volume (-80) is applied correctly so no sound can be heard. 

Also, both apply the -80dB volume correctly when not in the web.

I don't see any workarround to make it work. Please inform me if you know one. Using the playing property track works but it doesn't let us use the clipping features of the audio clips track, and we would have to remake all the animations audio timing and edit some audios that need to be clipped in an external audio editing program.

### Minimal reproduction project (MRP)

[audio-volume-ignored-on-web.zip](https://github.com/user-attachments/files/16663601/audio-volume-ignored-on-web.zip)
Repository: pytorch
Issue: [dynamo] Dynamo does not support infinite iterators (e.g., `itertools.count()`).
Labels: triaged,oncall: pt2,module: dynamo,dynamo-must-fix

Dynamo's `zip` does not support infinite iterators (e.g., `itertools.count()`).

Dynamo always realizes iterable into list items, which leads to an infinite loop. Also, fetching items from an iterator may have side effects. We should not realize the iterator into the sequence at once.

_Originally posted by @XuehaiPan in https://github.com/pytorch/pytorch/pull/133876#discussion_r1722156380_
            

cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @amjames
Repository: go
Issue: proposal: runtime/local: new package to provide transparent access to Per-P Local Storage
Labels: Proposal

### Proposal Details

This proposal introduces a new package, `runtime/local`, providing an API for per-P local storage in Go. This enables efficient and race-free access to shared yet locally scoped data, like random number generator states or per-P Logger, without the overhead of locks or cas loop.

Several packages within the standard library, including `runtime.fastrand` and `sync.Pool`, already utilize per-P or per-M storage internally for performance optimization. This proposal aims to expose a similar mechanism through a public API, enables developers to leverage this approach for their own concurrency needs.

This proposal introduces the runtime/local package with the following API:

```go
package local

// Key represents a unique identifier for accessing local storage.
type Key uint32

// AllocateKey reserves a new Key for local storage access.
func AllocateKey() Key

// ReleaseKey releases a previously allocated Key.
func ReleaseKey(k Key)

// Storage provides access to the per-P local storage.
type Storage struct {
	// pid represents the logical processor ID associated with this Storage.
	pid int

	// values holds the actual stored data, indexed by Key.
	values []any
}

// ID returns the logical processor ID associated with this Storage.
func (s *Storage) ID() int

// Load retrieves the value associated with the given Key.
// The second return value indicates whether a value was found.
func (s *Storage) Load(k Key) (any, bool)

// Store associates the given value with the specified Key.
// It returns true if the operation was successful, false otherwise.
func (s *Storage) Store(k Key, v any) bool

// OpenFunc executes the provided function f with the Storage
// instance associated with the calling goroutine's current P.
// It returns the logical processor ID associated with the Storage.
func OpenFunc(f func(*Storage)) (id int)
```

----
The proposed package name candidates are following:

- `runtime/local`
- `runtime/threadlocal`
- `runtime/plocal`
- `runtime/tls`

----
Open Issues:

- Released Key Reuse and Storage Reclamation: The proposal should consider how to handle storage associated with released keys.
- Finalizers to flush locally collected data to global storage.
Repository: godot
Issue: Multiple anonymous RefCounted wrapped in Signal/Callable in function argument scope are freed early
Labels: bug,topic:core,needs testing

### Tested versions

- Reproducible in: v4.3.stable.official [77dcf97d8], v4.2.2.stable.official [15073afe3], v4.2.1.stable.official [b09f793f5], v4.1.3.stable.official [f06b6836a] and not checked in other versions.

### System information

Godot v4.3.stable - Windows 10.0.22631

### Issue description

Multiple anonymous RefCounted wrapped in Signal/Callable to be passed as function arguments will be freed early, except for that last one.

### Steps to reproduce

Set the code attached at MRP into the scene node and run it.
Wherever it is executed, the result is the same as following:

```
false
false
true
```

I would expect it all to be `true` (or all to be `false`).

### Minimal reproduction project (MRP)

```gdscript
extends Node

class AnonRef:
	func fun() -> void: pass

static func _receiver(fun1: Callable, fun2: Callable, fun3: Callable) -> void:
	print(fun1.get_object() is not null)
	print(fun2.get_object() is not null)
	print(fun3.get_object() is not null)

func _ready() -> void:
	_receiver(
		AnonRef.new().fun,
		AnonRef.new().fun,
		AnonRef.new().fun)
```
Repository: godot
Issue: c# exported enum arrays get given "GD0102: The type of the exported member is not supported"
Labels: topic:dotnet

### Tested versions

v4.3.stable.mono.official [77dcf97d8]

### System information

Godot v4.3.stable.mono - Arch Linux #1 SMP PREEMPT_DYNAMIC Thu, 15 Aug 2024 00:25:30 +0000 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Ti (nvidia; 555.58.02) - AMD Ryzen 5 7600X 6-Core Processor (12 Threads)

### Issue description

arrays of enums in c# cant be exported, despite the [docs](https://docs.godotengine.org/en/4.3/tutorials/scripting/c_sharp/c_sharp_variant.html#c-sharp-variant-compatible-types) stating "Enums are supported by Godot.Variant since their underlying type is an integer type". so internally the representation should just be an integer array, which is supported

### Steps to reproduce

just put this somewhere in a project script
```cs
enum Test { One, Two, Three };

[Export] Test[] _enums;
```

### Minimal reproduction project (MRP)

N/A
Repository: flutter
Issue: [Release] Exception Encountered During Flutter 3.25 Beta Startup
Labels: team-release

When attempting to start the Flutter 3.25 beta, I encountered the following exception:

```
Exception: Tried to commit with message Update Dart SDK to c5264a1bd1d2ddff6c9a32ff7f99a2813f0ae4f9 but no changes were present
```

### Background
This issue appears to stem from a recent adjustment in our branch alignment process. Specifically, when using the Skia autoroller to generate the Dart-to-Engine roll, the autoroller typically selects Dart dev candidates to roll into the engine.

However, during the alignment for Dart 3.6 beta 1 and Flutter 3.25, a commit landed in Dart that caused a break in the engine. To address this, we implemented a workaround by cherry-picking a revert to Dart and using the beta hash instead of the dev hash, as the dev hash was broken.

This workaround resulted in the engine already containing the candidate Dart hash (`c5264a1bd1d2ddff6c9a32ff7f99a2813f0ae4f9`), leading to the exception.

### Current Behavior
When invoking the conductor without the Dart hash, the process completes successfully but does not generate a pull request (PR) to initiate CI for building and signing artifacts.

### Workaround
To resolve this issue, manually create a PR to the engine branch to kick off the CI process.

CC: @christopherfujino
Repository: go
Issue: cmd/go/internal/modload: TestQueryImport/golang.org_x_text failures
Labels: NeedsInvestigation

```
#!watchflakes
default <- pkg == "cmd/go/internal/modload" && test == "TestQueryImport/golang.org_x_text"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/b/8739169825673976609)):

    === RUN   TestQueryImport/golang.org_x_text
    go: finding module for package golang.org/x/text
        import_test.go:81: queryImport(_, "golang.org/x/text"): cannot find module providing package golang.org/x/text: unrecognized import path "golang.org/x/text": https fetch: Get "https://golang.org/x/text?go-get=1": read tcp [2001:4860:1002:21:f807:5bac:3303:e7e]:62726->[2607:f8b0:4004:c1f::8d]:443: read: operation timed out
    --- FAIL: TestQueryImport/golang.org_x_text (18.09s)


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: go
Issue: x/vulndb: TestLintReports/data/reports/GO-2024-2690.yaml failures
Labels: NeedsInvestigation,vulncheck or vulndb

```
#!watchflakes
default <- pkg == "golang.org/x/vulndb" && test == "TestLintReports/data/reports/GO-2024-2690.yaml"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/b/8739154919140143105)):

    === RUN   TestLintReports/data/reports/GO-2024-2690.yaml
        all_test.go:116: modules[0] "github.com/hashicorp/vault": version &{1.16.0 fixed} does not exist
    --- FAIL: TestLintReports/data/reports/GO-2024-2690.yaml (20.43s)


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: flutter
Issue: If a release PR is opened against main then the merge target "fixed", some targets not appropriately cancelled
Labels: team-infra,P2,triaged-infra

See the PR: https://github.com/flutter/engine/pull/54585

And the issue: https://github.com/flutter/flutter/issues/153612
Repository: vscode
Issue: Diff Editor: in-file search should reveal only a small fragment of unchanged region
Labels: feature-request,diff-editor

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

As discussed in #193834, if we have `hideUnchangedRegions` enabled and a search term occurs inside a currently hidden region, the search tools may reveal a huge fragment of the file in an unexpected way (and it works differently depending on whether we search in the left or right editor). It would be more user-friendly to reveal only `contextLineCount` lines around the term.

See screenshots in https://github.com/microsoft/vscode/issues/193834#issuecomment-2289335872 and [the example in Monaco Playground](https://microsoft.github.io/monaco-editor/playground.html?source=v0.50.0#XQAAAALxEQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscxahHbk_7RaxvTpxkYn3V-u8LX9aoCz6W93JdE-E7gNRYqv4Nj7ofd3sXvMZS3Q7wGKETF2-D42O7I090YntPxQ__nU7ZppDAgCRPFaAjVbn6Dsgc08REFK388tlMPtBfCLR0x19cPb-syrihplIz8m_ed63MK9FH47qVi9VukSPo6IIPihyEOnUrQFF7Ip5Rj_zevWe5zEfzLa3VdAtBoBuUvHkO7u-bfplmwMpG5fR5X09NRagFPV9BxT1xMA8Jkoio0oKUhHd7xlNBWPjCvqRfY25oSsFjaAAcRNavvB6NEMPjAnGW2Q9iPhxm36qPk4YdlLB07NUjeB_uGrVdrX1-Be2QbietkL68IPya1lJZthHNKndkIQddGCBj5O1g7Uajvxsq5Ft2arze4A__pCMAq).

Note that the expected result on the second screenshot can be achieved manually by changing something in the given line in the source or target text and then reverting the change in the editor, which will reset the diff, but keep the fragment visible -- that's how I took the screenshot.