sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: node
Issue: Support loading dynamic addon modules (`.node` files) when embedding the Node.js shared library without needing to link with `node.def`
Labels: feature request

### What is the problem this feature will solve?

Node.js addon modules on Windows current import from the `node.exe` executable, when you build Node.js as a shared library, it reexports all the needed symbols from the node shared library from the executable using a generated `node.def` file.

If you embed the Node.js shared library into a different executable/program, for loading such addon modules to work, that executable will need to be linked with `node.def` to reexport the needed symbols.

node-gyp also adds [win_delay_load_hook.cc](https://github.com/nodejs/node-gyp/blob/f90ce122fe564be68368d0c0dec5dacd9e770233/src/win_delay_load_hook.cc) to addons on Windows to make them work when the Node.js executable is renamed.

### What is the feature you are proposing to solve the problem?

Maybe we can support loading such addon modules without this requirement?

For example, what if the delay load hook looked for an env var (e.g. `NODE_LIBRARY`) that it would then pass to `GetModuleHandle` instead of `NULL` if it is set, and when Node.js is built as a shared library, it would set this env var before dynamically loading a module?

Though I'm not sure what security implications such a mechanism may have...

### What alternatives have you considered?

_No response_
Repository: next.js
Issue: headers() fails to opt route into dynamic rendering if generateStaticParams for all params is defined in layout
Labels: bug

### Link to the code that reproduces this issue

https://github.com/IRelaxxx/reproduction-app

### To Reproduce

1. build the application: next build
2. observe that route b is build static instead of dynamic
3. this can be checked by using next start and visiting /de/b this results in a 500 error 'DYNAMIC_SERVER_USAGE'

### Current vs. Expected behavior

Current:

Route b is rendered statically. Navigating to it results in a 500 error 'DYNAMIC_SERVER_USAGE'

Exprected:

Route b should be rendered dynamic because it uses headers()

### Provide environment information

```bash
Operating System:
  Platform: win32
  Arch: x64
  Version: Windows 11 Pro
  Available memory (MB): 32693
  Available CPU cores: 12
Binaries:
  Node: 20.11.1
  npm: N/A
  Yarn: N/A
  pnpm: 8.15.2
Relevant Packages:
  next: 14.2.0-canary.49 // Latest available version is detected (14.2.0-canary.49).
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.1.3
Next.js Config:
  output: N/A
```


### Which area(s) are affected? (Select all that apply)

App Router

### Which stage(s) are affected? (Select all that apply)

next build (local), next start (local)

### Additional context

This also happens with next@14.1.4

This issue was also observed when using cookies()
Repository: go
Issue: x/oauth2/clientcredentials: Refresh token is never used
Labels: NeedsInvestigation

### Go version

go version go1.22.0 linux/amd64

### Output of `go env` in your module/workspace:

```shell
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/luka/.cache/go-build'
GOENV='/home/luka/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/luka/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/luka/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/lib/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/lib/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.0'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1339062877=/tmp/go-build -gno-record-gcc-switches'
```


### What did you do?

* Create TokenSource by calling `TokenSource` on a `clientcredentials.Config`
* Ask for a new token after a previously acquired one has expired

### What did you see happen?

The function requests an entirely new token with grant_type=client_credentials, even if a refresh token is available to use.

The SoundCloud API has a strict rate limit of 50 tokens every 12 hours for an app, which is why I ran into this problem: https://developers.soundcloud.com/docs/api/guide#authentication

### What did you expect to see?

The function uses the previously acquired refresh token to get a new token, which is the behavior of x/oauth2
Repository: next.js
Issue: Using Link/Router with 'shallow' to navigate from pages to app router, when there is a top-level dynamic route under pages, lands on the dynamic route instead
Labels: bug,Navigation

### Link to the code that reproduces this issue

https://codesandbox.io/p/devbox/boring-paper-hyyt3y?file=%2F.codesandbox%2Ftasks.json

### To Reproduce

1. Create an application with a structure like
```
pages/[topLevelDynamic]/index.tsx
pages/another-page.tsx
app/app-router-page/page.tsx
```
(with simple placeholder pages in these).
2. Use a `Link` from `another-page.tsx` to `/app-router-page` with `shallow` enabled


### Current vs. Expected behavior

**Current behaviour:**
Pages router will take this and land you on `[topLevelDynamic]`, instead of `app-router-page`.
If the pages dynamic page has`getServerSideProps`, this _won't_ run however (which means the page will get undefined SSR props injected).

**Expected behaviour:**
I get routed to the app router page which should take precedence over the dynamic route.

I'm aware you can't actually shallow route between pages to app router (right?) - but if there isn't a dynamic route Next at least "does the right thing".

This isn't too big a deal, but means we need to maintain context of where we are (pages v.s. app router) to know if we can use the shallow tag for a given link.

It seems to work the other direction though (app to pages).

### Provide environment information

```bash
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 23.3.0: Wed Dec 20 21:31:00 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T6020
Binaries:
  Node: 21.7.1
  npm: 9.6.7
  Yarn: N/A
  pnpm: 8.15.4
Relevant Packages:
  next: 14.1.4
  eslint-config-next: 14.1.1
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.3.3
Next.js Config:
  output: N/A


warn  - Latest canary version not detected, detected: "14.1.4", newest: "14.2.0-canary.49".
        Please try the latest canary version (`npm install next@canary`) to confirm the issue still exists before creating a new issue.
        Read more - https://nextjs.org/docs/messages/opening-an-issue
```

(note: i did try on canary on the sandbox above)
```


### Which area(s) are affected? (Select all that apply)

App Router, Routing (next/router, next/navigation, next/link)

### Which stage(s) are affected? (Select all that apply)

next dev (local), next build (local), next start (local), Vercel (Deployed)

### Additional context

We're in the process of migrating so some of our pages, including this top-level dynamic catch-all route, are still in pages router.

We need to keep this dynamic route and this one is tricky to migrate to app router.
Repository: neovim
Issue: Colorcolumn is not displayed above modified background
Labels: bug,needs:discussion,complexity:low,highlight,diff

### Problem

When running neovim in diff mode, the color column is not displayed above the background indicating changes:
with termguicolors:
![image](https://github.com/neovim/neovim/assets/1084979/192b3635-ba26-46db-8dea-fb0793fc7eaa)
with the `vim` color scheme:
![image](https://github.com/neovim/neovim/assets/1084979/ab0a58cf-c8b0-4f8b-9bee-1c214ead537d)

### Steps to reproduce

`nvim --clean -d foo bar`
Then run
`:set textwidth=20 | set colorcolumn=+1 | set termguicolors`
or
`set textwidth=20 | set colorcolumn=+1 | colorscheme vim`


### Expected behavior

vimdiff:
![image](https://github.com/neovim/neovim/assets/1084979/37668b4b-82da-4045-aa53-14970ac9fc83)


### Neovim version (nvim -v)

NVIM v0.10.0-dev-2754+g12240600f

### Vim (not Nvim) behaves the same?

no, VIM - Vi IMproved 9.0  Included patches: 1-841

### Operating system/version

Ubuntu 20.04

### Terminal name/version

st with tmux. Same behavour in xterm

### $TERM environment variable

screen-256color

### Installation

built from repo
Repository: puppeteer
Issue: [Bug]: Final status code changes when request intercept is TRUE
Labels: bug,upstream,confirmed,P2

### Minimal, reproducible example

```TypeScript
            await page.setRequestInterception(true);
            await page.on(PageEmittedEvents.Request, (req) => {
            req.continue();
            });

            const response = await Promise.race([
              page?.goto("https://bit.ly/1gqbFUR", { waitUntil: ['networkidle0'] }),
              page.waitForTimeout(TIMEOUT_MS_SCREENSHOT).then(() => {
                res.status(500).json({ message: TIMEOUT_ERROR_MESSAGE });
              })
            ]);

            console.log(response.status())
```


### Error string

no error

### Bug behavior

- [ ] Flaky
- [ ] PDF

### Background

When i set request interceptor ( even without logic inside ) and i do console log for the destination url status code of websites that has one of the following redirects statuses of 301, 302, 307 or 308 in the redirect chain, it gives me that the final status is either 301, 302, 307, 308 instead of the real destination page status code 200 as shown in my browser network tab for this website: https://bit.ly/1gqbFUR . But when i do remove Request Interceptor, i get the 200 status code.

### Expectation

For this website as an example that has a 301 redirect : "https://bit.ly/1gqbFUR
", result of final url status code should be 200

### Reality

I'm getting 301

### Puppeteer configuration file (if used)

_No response_

### Puppeteer version

21.10.0

### Node version

18.17.0

### Package manager

npm

### Package manager version

9.6.7

### Operating system

macOS
Repository: deno
Issue: Stack trace in awaited thenable object does not include ancestor stack
Labels: upstream

This seems like something in v8 because it happens in node, chrome, and deno.

```js
const obj = {
  then(onfulfilled, onrejected) {
    console.log(new Error().stack); // bad
    return Promise.resolve(1).then(onfulfilled, onrejected);
  }
};

await test();
await new Promise(resolve => {
  console.log(new Error().stack); // good
  resolve();
});

async function test() {
  console.log(new Error().stack); // good
  await obj;
  console.log(new Error().stack); // good
}
```

Output:

```
> deno run main.mjs
Error
    at test (file:///V:/scratch/main.mjs:15:15)
    at file:///V:/scratch/main.mjs:8:7
Error
    at Object.then (file:///V:/scratch/main.mjs:3:17)
Error
    at test (file:///V:/scratch/main.mjs:17:15)
    at async file:///V:/scratch/main.mjs:8:1
Error
    at file:///V:/scratch/main.mjs:10:15
    at new Promise (<anonymous>)
    at file:///V:/scratch/main.mjs:9:7
```

Version: Deno 1.42.0

Edit: Opened https://issues.chromium.org/issues/332083029
Repository: godot
Issue: "Sync namespaces to folder structure" commands do not work with Godot .csproj's in Visual Studio. Specific to Godot .csprojs.
Labels: topic:dotnet

### Tested versions

Reproducible in all .NET 4.1 and 4.2 versions of Godot Engine

### System information

Godot v4.2.1.stable.mono - Windows 10.0.22631 - Vulkan (Mobile) - dedicated AMD Radeon RX 7600S (Advanced Micro Devices, Inc.; 31.0.14003.5001) - AMD Ryzen 7 7735HS with Radeon Graphics (16 Threads)

### Issue description

Godot C# .NET projects do not have the ability to Sync Namespaces to the csproj folder structure (in Visual Studio, right click on csproj in solution explorer -> Sync Namespaces). Anytime this option is selected, the namespaces don't ever actually change even if they are clearly not synced with the folder structure, and always returns the "No namespaces needed updating" response.

Even if a .editorconfig specifies that it is preferred to sync namespaces with folder structure, and if the Analysis and Code Cleanup profile also has namespace syncing as a defined action, namespaces are not updated when moving a class file to different folder in the csproj nor when running Analyze/Code Cleanup. The normal option to auto-sync the namespace to folder structure in the Quick Actions + Refactorings menu also does not come up on right click or Ctrl+

This all is the case even when the .NET project builds and runs fine both in Visual Studio and straight from the Godot editor. I do not have the problem with my other non-Godot project csproj's in my solution, this is specific to any Godot csproj I create

So, pretty much any time when refactoring or reorganizing, it is required to manually update all namespaces. This should have the same behavior as regular c# projects, where namespaces are updated properly according to the preferences in the editor config/cleanup profile

### Steps to reproduce

- Create Godot project
- Create node and scene in godot project and set it as the main scene
- Add C# script to node  
- Open C# script in Visual Studio 
- Create new Debug profile [Executable = "Insert_PathTo_GodotVersion_win64.exe", Command Line Arguments = "--path.--verbose",  WorkingDirectory = ".", Enable native code debugging = checked]
- Build .NET project 
- Run project from both Godot Editor and Visual Studio to verify it can run
- Return to Visual Studio and add arbitrary folder in csproj
- Create new c# script or class outside of folder
- **Move new c# script or class into folder and witness namespace not update**
- Create and include .editor config with "Prefer namespace and folder match structure" to yes
- **Move new c# script or class into different folder and witness namespace not update**
- Configure default code cleanup profile to include syncing namespaces as an action
-  **Run code cleanup profile and witness namespace not update**

### Minimal reproduction project (MRP)

N/A, bug is producible from brand new project.
Repository: godot
Issue: Entire monitor shuts off briefly when moving mouse towards the top or side of the screen with G-Sync enabled
Labels: bug,platform:windows,topic:rendering

### Tested versions

- Reproducible in 4.3.dev5, 4.2.1.stable, 4.2.stable, 4.1.stable, 4.0.stable
- Not Reproducible in 3.5.stable, 3.5.3.stable, 3.6.beta4 (tested with ES 3.0 due to lack of forward+)

### System information

Godot v4.2.1.stable.mono - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4080 (NVIDIA; 31.0.15.5186) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)

### Issue description

All of the functions of the editor work fine, however moving the mouse to the top of left side of the screen causes the entire screen to turn off when using G-Sync.

https://github.com/godotengine/godot/assets/97140451/b2cf677e-0d24-4b42-89b6-9f1c24b4cc38


https://github.com/godotengine/godot/assets/97140451/44e22fae-c7da-4e42-9692-9f5a50db713d



### Steps to reproduce

- Make sure you have a G-Sync capable monitor
- In the Nvidia Control Panel under "Set up G-SYNC", enable G-SYNC for either full screen or windowed and full screen
- Startup a Godot project that uses forward+ rendering
- Verify that Godot is the current active window. This issue doesn't appear if Godot isn't the active window
- Move your mouse towards the left side or top of the screen.

### Minimal reproduction project (MRP)

N/A
Repository: deno
Issue: Showing 3rd party library required permissions when running deno install
Labels: cli,suggestion

Hi developers,
How about displaying necessary permissions when installing a third-party library to enhance secure coding practices?

current `deno install`
```bash
deno install https://deno.land/x/dax/mod.ts
✅ Successfully installed dax
/xxx/deno/1.39.3/.deno/bin/dax
```

suggested `deno install`
```
Required Permissions
- allow-read=/etc
- allow-env=PATH
....
deno install https://deno.land/x/dax/mod.ts
✅ Successfully installed dax
/xxx/deno/1.39.3/.deno/bin/dax
```

If it works well, developers can code more safely.
Repository: neovim
Issue: :terminal does not color underline
Labels: bug,status:blocked-external,terminal

### Problem

`echo -e '\e[4:3m\e[58:2::240:143:104mfoobarbaz\e[59m\e[4:0m\n'`

Outside Neovim:

<img width="584" alt="image" src="https://github.com/neovim/neovim/assets/8050659/90149e15-4f8a-43b1-8b02-c2797dff06f5">

Inside Neovim:

<img width="584" alt="image" src="https://github.com/neovim/neovim/assets/8050659/e7422072-8de3-4b47-90d3-737ed38ef2d9">


### Steps to reproduce

- Open neovim terminal: `nvim --clean -c ':term'`
- Run `echo -e '\e[4:3m\e[58:2::240:143:104mfoobarbaz\e[59m\e[4:0m\n'`

### Expected behavior

Underline should have different color.

### Neovim version (nvim -v)

v0.10.0-dev-2755+ge1ff2c51c-Homebrew

### Vim (not Nvim) behaves the same?

N/A

### Operating system/version

macOS 14.4

### Terminal name/version

Kitty 0.33.1

### $TERM environment variable

xterm-kitty

### Installation

homebrew
Repository: bitcoin
Issue: importaddress failed, Only legacy wallets are supported by this command.
Labels: Wallet,RPC/REST/ZMQ

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I want to import the address or public key into bitcoind because I want to list the unspent utxo based on my bitcoind node and then assemble the transaction on the client side. However, an error will be reported when importing the address and public key.

Error:
```
error code: -4
error message:
Only legacy wallets are supported by this command
```

### Expected behaviour

success and list unspent utxo success.

### Steps to reproduce

`bitcoin-cli importaddress mk4xz7tbbQDcQY68qYehydV9PRBWdVGNw1 "ray"`

```
error code: -4
error message:
Only legacy wallets are supported by this command
```

`bitcoin-cli importpubkey 03f3de8f736a0bff7dfe446138acf98c23199c0710c704416dc9b6338bf37900e9  "ray_pub" true`

```
error code: -4
error message:
Only legacy wallets are supported by this command
```

bitcoind start cmd:
`bitcoind -blocksonly=false -wallet=ray -addresstype=legacy`


### Relevant log output

_No response_

### How did you obtain Bitcoin Core

Pre-built binaries

### What version of Bitcoin Core are you using?

Bitcoin Core version v25.0.0

### Operating system and version

Ubuntu 22.04.3 LTS

### Machine specifications

_No response_
Repository: pytorch
Issue: Alternate algorithm for computing MaxPool2D under specific condition.
Labels: module: performance,module: nn,module: cpu,triaged

### 🚀 The feature, motivation and pitch

When stride is equal to 1, you can represent MaxPool2D of kernel size 5 as 2 MaxPool2D of kernel size 3. Similarly, you can use 3 MaxPool2D to represent kernel size 7 and so on. This approach will reduce the computation for each cell from kernel_size * kernel_size to 3  * 3 * (kernel_size//2). To avoid additional cost during back propagation we should modify MaxPool2D layer directly. Note that this approach should only be faster on CPU.

Testing code:
```python3
import torch
from torch import nn

x = torch.rand((64, 80, 80, 512))

def get_max_pool_layer(kernel):
    return nn.MaxPool2d(kernel_size=kernel, stride=1, padding=kernel//2)

nn1 = get_max_pool_layer(3)
nn2 = get_max_pool_layer(5)
---------------------------------------
# confirm that both approach yield same results
y1 = x.clone()
y2 = x.clone()

with torch.no_grad():
    for _ in range(2):
        y1 = nn1.forward(y1)
    y2 = nn2.forward(y2)

(y1==y2).all() # tensor(True)
---------------------------------------
%%timeit

y1 = x.clone()
with torch.no_grad():
    for _ in range(2):
        y1 = nn1.forward(y1)
# 992 ms ± 31.1 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
---------------------------------------
%%timeit

y2 = x.clone()
with torch.no_grad():
    y2 = nn2.forward(y2)

# 1.25 s ± 74.3 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
---------------------------------------
%%timeit 

y1 = x.clone()
# 111 ms ± 1.7 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)
```

The newer approach took 881 ms as apposed to 1139 ms.
Yielding 1.293 speedup.

### Alternatives

_No response_

### Additional context

Originally from: https://github.com/ultralytics/ultralytics/issues/9421
Inspired by YoloV8 SPPF layer.

cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10
Repository: node
Issue: Please make Node.js embeddable (e.g. libnode)
Labels: feature request,embedding

### What is the problem this feature will solve?

Node.js is prolific throughout the server-side world with many projects wanting to repackage the Node.js runtime and standard library to offer it to customers such that they can reuse their existing tooling/dependencies.

Notable examples of this:
- Rspack
- Esbuild
- Parcel
- Supabase
- AWS Lambda
- etc

Currently, Node.js is not (easily) able to be used as an embedded runtime leading projects to look for solutions with incomplete support - like Deno (which is a great project in its own right, but lacks certain features that would necessitate consumers rewriting project code).

### What is the feature you are proposing to solve the problem?

It would be amazing if Node.js released a `libnode` library that exported Node.js capabilities and enabled napi access to the host context.

Professionally, my organization has a use case that would benefit greatly from the ability to embed Node.js within a Rust based host process - however, practically, no such capability exists.

I'd assume this would be in the form of a c++ library though a Rust crate would be amazing.

### What alternatives have you considered?

- Embedding Deno
- Removing the "Deno" parts of Deno and maintaining a light version with a focus on supporting the Node.js standard library 
- Looking over the Node.js source to understand how difficult it would be to create a Rust create with bindings
Repository: rust
Issue: Inefficient compiler optimization between stable versions on nightly
Labels: A-LLVM,I-slow,P-medium,T-compiler,C-bug,A-mir-opt

I have been recently been working on a logic simulator that requires building on the nightly channel. With the release of Rust 1.77.1, I subsequently updated my version from nightly-2024-02-08 to nightly-2024-03-28 and instantly noticed a drastic performance impact. Upon further investigation, starting from `nightly-2024-02-12` and onwards, the compiler is [no longer able to optimize my multiplexor function](https://godbolt.org/z/nYGohTr1q).

The godbolt link is unintentionally misleading with its versions. Strangely, this regression does not happen on the equivalent stable channel versions (1.76.0 and 1.77.1), and the reason why this happens only on nightly is beyond my current knowledge.

`rustc --version --verbose`: (The first bad version, and I think the dates are shifted because of time zones)
```
rustc 1.78.0-nightly (1a648b397 2024-02-11)
binary: rustc
commit-hash: 1a648b397dedc98ada3dd3360f6d661ec2436c56
commit-date: 2024-02-11
host: aarch64-apple-darwin
release: 1.78.0-nightly
LLVM version: 17.0.6
```

I'm not sure which regression label to mark this issue with, since it's occurred between stable versions but on the nightly channel, so I'll omit one for now.

@rustbot modify labels: -regression-untriaged