sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: material-ui
Issue: [FocusTrap] tabindex order seems to be wrong
Labels: bug 🐛,component: FocusTrap

### Duplicates

- [X] I have searched the existing issues

### Latest version

- [X] I have tested the latest version

### Steps to reproduce 🕹

Link to live example: https://codesandbox.io/s/eager-mopsa-tk86fq?file=/src/App.js

Both MUI's FocusTrap and focus-trap-react are added to the sandbox for ease of reproducing the case.

### Current behavior 😯

Ordering seems to be wrong.

### Expected behavior 🤔

Having multiple focusable elements inside FocusTrap with different tabindeces, when the FocusTrap is focused the order should start from any item which has the index upper than 0, looping till the > 0 items are done and then reach to the items with normal 0 tabindex.

Example is:
```html
<button> normal 1</button>
<button tabindex='3'> indexed 3 </button>
<button tabindex='2'> indexed 2 </button>
<button> normal 2</button>
<button tabindex='1'> indexed 1 </button>
<button> normal 3</button>
```
Focusing order should be:
```
indexed 1
indexed 2
indexed 3
normal 1
normal 2
normal 3
```
But MUI's behavior is:
```
normal 1 
normal 2
normal 3
indexed 1
indexed 2
indexed 3
```

The behavior of [focus-trap](https://github.com/focus-trap/focus-trap) and [focus-trap-react](https://github.com/focus-trap/focus-trap-react) seems to be right.

Possible related line of code:

https://github.com/mui/material-ui/blob/ab2e0574c8180b0af833c3a926873ccf3f50083c/packages/mui-base/src/FocusTrap/FocusTrap.tsx#L113

### Context 🔦

_No response_

### Your environment 🌎

<details>
  <summary><code>npx @mui/envinfo</code></summary>

```
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
```
</details>
Repository: vscode
Issue: Error message complaining about build task
Labels: bug,tasks,confirmed

The Makefile Tools extension creates a task when users want to build their code bases. The task uses "make" executable as command with arguments that we deduce from user settings.
This is how we write the task: [make.ts](https://github.com/microsoft/vscode-makefile-tools/blob/main/src/make.ts).
Around line 340 (task creation, inside function doBuildTarget). Do you spot anything wrong that we do there? So that is the typescript implementation of the Makefile Tools extension.

When we run the extension in VSCode and the user builds their code (which will hit the code I pointed above), the task appears to run fine (as it does for several releases already) but we see his message in "Tasks Output Window" that recently appeared.

```
Error: The task "makefile: Makefile Tools Build Task" has neither a command nor a dependsOn-property. The task will be ignored. Associated definition:
{
    "type": "shell",
    "id": "shell,c:\\amiga-gcc\\bin\\make.exe,all,-j4,DEBUG=1,",
    "problemMatcher": [
        "$gcc",
        "$unknown"
    ],
    "label": "makefile: Makefile Tools Build Task"
}

The problem matcher "{0}" can not be resolved. The matcher will be ignored.
```

Please advise, what can we do so that we don't see this message in the tasks window. Should we use the task API in a different way or this is a bug in your code base?

The bug report in our repository is https://github.com/microsoft/vscode-makefile-tools/issues/423 and there are many more duplicates that recently were signaled.
Repository: vscode
Issue: Translations not getting picked up when extension is loaded via `install extension from location`
Labels: feature-request,l10n-platform

> @TylerLeonhardt I have one other question: I have created a `bundle.l10n.ja.json` file, but when I change my browser's language to Japanese, I'm not seeing the translations from this file appear. It seems to be taking the untranslated string that I pass in (not even the output of the `bundle.l10n.json` file. 
>
> I've configured my l10 property in my package.json appropriately (the `npx @vscode/l10n-dev export -o ./l10n ./src` command does not complain about my outdir not matching). Is there a step I could be missing here?.

_Originally posted by @asr1 in https://github.com/microsoft/vscode/issues/176561#issuecomment-1461082596_
Repository: PowerToys
Issue: I can't find the : in the Keyboard manager
Labels: Issue-Bug,Product-Keyboard Shortcut Manager,Needs-Triage

### Microsoft PowerToys version

0.68.1

### Installation method

GitHub

### Running as admin

No

### Area(s) with issue?

Keyboard Manager

### Steps to reproduce

I enter the application then go to Keyboard Manager, go to Remap Key, go to Physical Key, look for : in the list of keys, there is none, i go to Shortcut Keys, i look for :, nothing.

### ✔️ Expected Behavior

I expect to find : for remap.

### ❌ Actual Behavior

There's only ; for remapping.

### Other Software

_No response_
Repository: godot
Issue: Spurious warning when awaiting method not stating return type: '"await" keyword not needed in this case, because the expression isn't a coroutine nor a signal' (4.0 regression)
Labels: bug,topic:gdscript

### Godot version

v4.0.stable.official [92bee43ad]

### System information

Linux Ubuntu 22.04 with Unity desktop

### Issue description

This is a regression reviving:
- https://github.com/godotengine/godot/issues/54589
- https://github.com/godotengine/godot/issues/56265
- https://github.com/godotengine/godot/issues/57178
- https://github.com/godotengine/godot/issues/59058

When using await with a function not indicate return type, the spurious warning is shown at runtime:

> "await" keyword not needed in this case, because the expression isn't a coroutine nor a signal

Example class causing the issue:

```gd
extends Node2D


@export var timer: Timer


func _ready():
	await wait_for_timeout1()  # issue
	await wait_for_timeout2()  # no issue


func wait_for_timeout1():
	return timer.timeout

func wait_for_timeout2() -> Signal:
	return timer.timeout
```

### Steps to reproduce

1. Open demo scene and run it. Observe the warning
> "await" keyword not needed in this case, because the expression isn't a coroutine nor a signal
2. Double click on warning or check line to see that it only concerns method `wait_for_timeout1` which doesn't indicate return type
3. You can comment out `await wait_for_timeout1()` to see that the warning disappears. Indeed, the remaining `wait_for_timeout2` indicates return type as Signal.

### Minimal reproduction project

[v4.0 - Spurious await warning not needed.zip](https://github.com/godotengine/godot/files/10935466/v4.0.-.Spurious.await.warning.not.needed.zip)
Repository: vscode
Issue: Terminal quick fix for creating PR results in branch name with extra padding
Labels: bug,terminal-quick-fix

I tried using the quick fix to create a PR and got the following link (notice the trailing %20s):
https://github.com/TryGhost/node-sqlite3/compare/master...microsoft:vscode-node-sqlite3:rzhao271/version-bump%20%20%20%20%20%20%20%20?expand=1
Repository: storybook
Issue: [Bug]: StoriesEntry type does not allow for custom implementation with async function
Labels: bug,good first issue,has workaround,core,typescript,sev:S3

### Describe the bug

In the [storybook docs](https://storybook.js.org/docs/react/configure/overview#with-a-custom-implementation), there is an example where you can pass in an async function to `stories` to implement custom logic for loading stories. This works as expected, but if you are using typescript, it gives the error `Type '() => Promise<string[]>' is not assignable to type 'StoriesEntry[]'`.

### To Reproduce

This config will produce the typescript error, although it is a valid way to construct a `stories` configuration, according to the docs.

```ts
import type { StorybookConfig } from '@storybook/react-webpack5';

const stories = Promise.resolve(['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|ts|tsx)'])
const config: StorybookConfig = {
  stories: async () => [...await stories],
  addons: [
    '@storybook/addon-links',
    '@storybook/addon-essentials',
    '@storybook/addon-interactions',
  ],
  framework: {
    name: '@storybook/react-webpack5',
    options: {},
  },
  docs: {
    autodocs: 'tag',
  },
};
export default config;
```

### System

```shell
System:
    OS: macOS 13.2.1
    CPU: (8) arm64 Apple M1 Pro
  Binaries:
    Node: 18.14.2 - ~/.nvm/versions/node/v18.14.2/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.14.2/bin/yarn
    npm: 9.5.0 - ~/.nvm/versions/node/v18.14.2/bin/npm
  Browsers:
    Chrome: 110.0.5481.177
    Firefox: 109.0
    Safari: 16.3
  npmPackages:
    @storybook/addon-essentials: ^7.0.0-beta.64 => 7.0.0-rc.0
    @storybook/addon-interactions: ^7.0.0-beta.64 => 7.0.0-rc.0
    @storybook/addon-links: ^7.0.0-beta.64 => 7.0.0-rc.0
    @storybook/blocks: ^7.0.0-beta.64 => 7.0.0-rc.0
    @storybook/react: ^7.0.0-beta.64 => 7.0.0-rc.0
    @storybook/react-webpack5: ^7.0.0-beta.64 => 7.0.0-rc.0
    @storybook/testing-library: ^0.0.14-next.1 => 0.0.14-next.1
```


### Additional context

I am willing to submit a fix to the `StoriesEntry` type for this.
Repository: next.js
Issue: Error using Emotion component selectors with SWC
Labels: bug,SWC

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
      Platform: darwin
      Arch: x64
      Version: Darwin Kernel Version 22.2.0: Fri Nov 11 02:08:47 PST 2022; root:xnu-8792.61.2~4/RELEASE_X86_64
    Binaries:
      Node: 16.18.1
      npm: 9.1.1
      Yarn: 1.22.19
      pnpm: 7.27.1
    Relevant packages:
      next: 13.1.6
      eslint-config-next: 13.1.6
      react: 18.2.0
      react-dom: 18.2.0
```


### Which area(s) of Next.js are affected? (leave empty if unsure)

SWC transpilation

### Link to the code that reproduces this issue

https://codesandbox.io/p/sandbox/polished-browser-went6z

### To Reproduce

The following is a minimal reproduction (used in the reproduction codesandbox):
```javascript
import styled from "@emotion/styled";

const A = styled.div`
  color: red;
`;

const B = styled.div`
  color: blue;
  ${A} {
    color: green;
  }
`;

export default function Home() {
  return <B><A>A inside B</A></B>;
}
```

No extra steps are required to reproduce. Simply load the codesandbox and observe the resulting error.

### Describe the Bug

I'm getting the error:
> Error: Component selectors can only be used in conjunction with @emotion/babel-plugin, the swc Emotion plugin, or another Emotion-aware compiler transform.

When using component selectors as described in the ["Targeting another emotion component"](https://emotion.sh/docs/styled#targeting-another-emotion-component) section of the emotion docs, I'm getting this error.

### Expected Behavior

Since this reproduction repo uses the swc Emotion plugin, I would not expect this syntax to result in an error.

Given the example above, I would expect green text "Test" when rendering `A` inside `B`.

### Which browser are you using? (if relevant)

_No response_

### How are you deploying your application? (if relevant)

_No response_
Repository: rust
Issue: "correct return type" help shouldn't include `'static`
Labels: A-diagnostics,T-compiler,A-suggestion-diagnostics,D-invalid-suggestion

### Code

```Rust
pub fn foo(x: &str) -> _ {
    (x.is_empty(), x.as_bytes())
}
```


### Current output

```Shell
error[E0121]: the placeholder `_` is not allowed within types on item signatures for return types
 --> src/lib.rs:1:24
  |
1 | pub fn foo(x: &str) -> _ {
  |                        ^
  |                        |
  |                        not allowed in type signatures
  |                        help: replace with the correct return type: `(bool, &'static [u8])`

For more information about this error, try `rustc --explain E0121`.
```


### Desired output

```Shell
error[E0121]: the placeholder `_` is not allowed within types on item signatures for return types
 --> src/lib.rs:1:24
  |
1 | pub fn foo(x: &str) -> _ {
  |                        ^
  |                        |
  |                        not allowed in type signatures
  |                        help: replace with the correct return type: `(bool, &[u8])`

For more information about this error, try `rustc --explain E0121`.
```


### Rationale and extra context

The `'static` here will cause a borrowcheck error later, because it's coming from the argument.
```
error: lifetime may not live long enough
 --> src/lib.rs:2:5
  |
1 | pub fn foo(x: &str) -> (bool, &'static [u8]) {
  |               - let's call the lifetime of this reference `'1`
2 |     (x.is_empty(), x.as_bytes())
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ returning this value requires that `'1` must outlive `'static`
```

I hypothesize that it'd be better to not have the `'static` so that it'll work for lifetime elision cases like this than to only work for literals.  (Or maybe it could attempt to be smart and include `'static` if there's no parameter lifetime, but omit it otherwise?)

### Other cases

_No response_

### Anything else?

Playground repro: <https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=7f65cb9bf760945e44658e468e7d48b0>


<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"ohno418"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
Repository: flutter
Issue: [web] Remove image codecs from CanvasKit Chromium
Labels: engine,a: size,platform-web,a: images,perf: app size,e: web_canvaskit,P2,team-web,triaged-web

**Update:** we had to put back image codecs into CanvasKit Chromium because there are still use cases that need the wasm codecs. See [PR](https://github.com/flutter/engine/pull/40501) for more info.

<hr>
As part of https://github.com/flutter/flutter/issues/113713, let's remove the image codecs from the CanvasKit Chromium variant.

This involves 2 things:

1. Adding the appropriate flags to the [canvaskit_chromium gn target](https://github.com/flutter/engine/blob/4429efe6c83d641141f1df0fbefbc091ed547cd5/third_party/canvaskit/BUILD.gn#L23-L25).
2. Adjusting the [`browserSupportsCanvaskitChromium`](https://github.com/flutter/engine/blob/832298bdd707ceabf6641d67d0550d231ac0acb7/lib/web_ui/lib/src/engine/browser_detection.dart#L271) boolean to check for availability of image codecs too.
Repository: pytorch
Issue: Unable to move torch.jit.load-ed models to XLA devices
Labels: oncall: jit,module: xla

### 🐛 Describe the bug

Here are the steps to reproduce and the error:
```
>>> import torch
>>> import torch_xla.core.xla_model as xm
>>> x = torch.nn.Linear(8, 32)
>>> torch.jit.save(torch.jit.script(x), 'x.pt')
>>> xsr = torch.jit.load('x.pt')
>>> xsr.to(xm.xla_device())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 987, in to
    return self._apply(convert)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 668, in _apply
    assert isinstance(param, Parameter)
AssertionError
```
Here is when it works if I try just scripting (without save&load):
```
>>> x.to(xm.xla_device())
Linear(in_features=8, out_features=32, bias=True)
>>> xs = torch.jit.script(x)
>>> xs.to(xm.xla_device())
RecursiveScriptModule(original_name=Linear)
```
However, the version that's read back into xsr fails:
```
>>> xsr
RecursiveScriptModule(original_name=Linear)
>>> xsr.to(xm.xla_device())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 987, in to
    return self._apply(convert)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 668, in _apply
    assert isinstance(param, Parameter)
AssertionError
```

Let me know if you need any more information or a way to install pytorch/xla.

### Versions

pt-1.13

cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @bdhirsh @yyetim
Repository: go
Issue: x/net/ipv4: TestRawConnReadWriteUnicastICMP failures with `i/o timeout`
Labels: Testing,help wanted,NeedsFix

```
#!watchflakes
post <- pkg == "golang.org/x/net/ipv4" && test == "TestRawConnReadWriteUnicastICMP" && `i/o timeout`
```

Issue created automatically to collect these failures.

Example ([log](https://build.golang.org/log/fd1edc881889f91c14d0865f104a6fdddeb2c7c5)):

    --- FAIL: TestRawConnReadWriteUnicastICMP (0.11s)
        unicast_test.go:249: read ip 0.0.0.0: raw-read ip4 0.0.0.0: i/o timeout


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: flutter
Issue: Update dual scrollbar constructor to support corner space
Labels: c: new feature,framework,f: scrolling,P3,team-framework,triaged-framework

- https://github.com/flutter/flutter/issues/122348 
  - will need to be completed first

---

Part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](flutter.dev/go/2D-Foundation)

https://github.com/flutter/flutter/pull/122349 adds a factory constructor that creates two scrollbars for scrolling in two dimensions. This change is proposed as a lead up to `TwoDimensionalScrollable` etc.

The dual factory constructor works almost perfectly when plugged into `TwoDimensionalScrollable`, except for the small overlap in the joining corner.

![Screenshot 2023-02-09 at 5 00 33 PM](https://user-images.githubusercontent.com/16964204/224186140-59421593-69ca-44d5-91a9-d29f6121cf7a.png)

While investigating this, I found multiple native behaviors. Most common:

Image | Description 
-- | --
![Screenshot 2023-02-09 at 11 38 02 AM (2)](https://user-images.githubusercontent.com/16964204/224186166-addc334c-2a91-4700-a278-3b2d189af382.png) | The scrollbars operate on a first-come-first-serve rule for the corner space. Here the horizontal bar got there first, the vertical is not allowed to overlap. Observed on MacOS as default behavior.
![Screenshot 2023-02-09 at 11 39 17 AM](https://user-images.githubusercontent.com/16964204/224186811-a1f23740-3c54-4580-9a54-44616a908ead.png) | Empty space. No scrollbar enters the corner space.

Both of these should be supported.

I have investigated this a fair bit, and I think the best way for this to work (instead of creating two instances of the scrollbar widget)  is to have the `.dual` constructor instead create two instances of ScrollPainter internal to the single scrollbar widget.

This is because in order to properly avoid overlapping each other, the painters need to know about the state of each other since the scrollbar size and visibility can change based on hovering, dragging, whether or not scrolling is happening, etc.
Repository: kubernetes
Issue: Deployment names can be too long, such that ReplicaSet creation fails
Labels: kind/bug,sig/apps,needs-triage

This Deployment:

```
apiVersion: apps/v1
kind: Deployment
metadata:
  name: use-a-very-long-name-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-12
  namespace: default
spec:
  replicas: 1
  selector:
    matchLabels:
      app: iamyouare
  template:
    metadata:
      labels:
        app: iamyouare
    spec:
      containers:
      - image: thockin/iamyouare
        name: iamyouare
```

...is accepted but always fails:

```
Events:
  Type     Reason                 Age                From                   Message
  ----     ------                 ----               ----                   -------
  Warning  ReplicaSetCreateError  1s (x13 over 22s)  deployment-controller  Failed to create new replica set "use-a-very-long-name-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-12-6bb58d578b": ReplicaSet.apps "use-a-very-long-name-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-12-6bb58d578b" is invalid: metadata.name: Invalid value: "use-a-very-long-name-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-123456789-12-6bb58d578b": must be no more than 253 characters
```

Deployment controller needs to truncate it's own name to make room for the ReplicaSet suffix and eventually the pod suffix.
Repository: flutter
Issue: 2D Follow up: Add dual scrollbar constructors and methods
Labels: c: new feature,framework,f: scrolling,P3,team-framework,triaged-framework

Part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](flutter.dev/go/2D-Foundation)

Also part of this:
- https://github.com/flutter/flutter/issues/122345
- https://github.com/flutter/flutter/issues/122351

The proposal outlines adding a `.dual` constructor to the scrollbar classes in order to support 2D scrolling
- RawScrollbar
- Scrollbar
- CupertinoScrollbar

It also proposes adding a method to scroll behaviors for calling on this in the 2D case. Relying on ScrollBehavior again will also enable other options in 2D scrolling, like if the developer does not want one or both of the scrollbars.
- ScrollBehavior
- MaterialScrollBehavior
- CupertinoScrollBehavior
Repository: flutter
Issue: Update dual scrollbar constructor to support different animation responses
Labels: c: new feature,framework,f: scrolling,P3,team-framework,triaged-framework

- https://github.com/flutter/flutter/issues/122348 
  - will need to be completed first

---

Part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](flutter.dev/go/2D-Foundation)

https://github.com/flutter/flutter/pull/122349 adds a factory constructor that creates two scrollbars for scrolling in two dimensions. This change is proposed as a lead up to `TwoDimensionalScrollable` etc.

Developers may want to configure dual scrollbars so that the fade in animation is always triggered for both scrollbars in response to any scrolling, or just one axis, or none, etc. It is not clear yet how folks may want the animation to behave, but we should follow up on it here when it becomes more clear.