sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: Window geometry is incorrect after switching displays
Labels: e: device-specific,framework,engine,platform-mac,c: rendering,a: desktop,P2,team-macos,triaged-macos

When a flutter app gets moved from a hidpi display to a normal one, the window geometry can get messed up so that the window contents are offset vertically by the difference between the window height, and twice the window height. Or something like that - it's weird.

Here is a video that makes the issue clear:

[flutter_desktop_weirdness.mov.zip](https://github.com/flutter/flutter/files/4034795/flutter_desktop_weirdness.mov.zip)

This was originally reported as part of #37676 which was closed - the crash reported in that bug appears to have been fixed, but the broken geometry has not.

## Steps to Reproduce

1. Create a flutter desktop app.
2. Run it on a Mac laptop with no displays connected.
3. Close the laptop lid.
4. Connect it to a normal external display.

I'm not sure if this happens 100% of the time.

## Logs

There aren't any relevant exceptions or analysis errors.

```
[✓] Flutter (Channel master, v1.13.7-pre.50, on Mac OS X 10.14.4 18E226, locale en-GB)
    • Flutter version 1.13.7-pre.50 at /Users/timh/local/flutter
    • Framework revision 134c2ff076 (14 hours ago), 2020-01-07 12:23:02 -0800
    • Engine revision 3851981b86
    • Dart version 2.8.0 (build 2.8.0-dev.0.0 2f57602411)


[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/timh/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Library/Java/JavaVirtualMachines/jdk1.8.0_152.jdk/Contents/Home/bin/java
    • Java version Java(TM) SE Runtime Environment (build 1.8.0_152-b16)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3, Build version 11C29
    • CocoaPods version 1.7.1

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/setup/#android-setup for detailed instructions).

[✓] VS Code (version 1.41.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.7.1

[✓] Connected device (1 available)
    • macOS • macOS • darwin-x64 • Mac OS X 10.14.4 18E226

! Doctor found issues in 1 category.
```
Repository: godot
Issue: ScollContainer's ScrollBar doesn't interact other than mouse.
Labels: bug,topic:core,confirmed

**Godot version:**
3.1.2

**OS/device including version:**
Windows 10

**Issue description:**
VScrollBarr doesn't get focus when the button inside ScrollContainer/VBoxContainer is focused and action "ui_right" is pressed.
ScrollContainer.get_v_scrollbar( ).value and max_value doesn't represent position or range.
Setting value on VScrollBar doesn't position it correctly - uncertain behavior. Even giving it the max_value it doesn't go past the middle.
There's no other way to position VScrollBar with code. At least the documentation doesn't have ANYTHING about ScrollBar interaction.
What action is triggered when the mouse wheel is moved and scrolls the "page"? There's no action in InputMap that uses a mouse wheel.
P.S.
There's no documentation on how to use separate ScrollBar (where to put and how to interact with it).

**Steps to reproduce:**
Just VBoxContainer that extends more than ScrollContainer allows, so VScrollBarr appears.

**Minimal reproduction project:**
[ScrollContainerBug.zip](https://github.com/godotengine/godot/files/4034826/ScrollContainerBug.zip)
Repository: flutter
Issue: driver.tap based on x,y co-ordinates
Labels: a: tests,c: new feature,framework,d: api docs,t: flutter driver,P3,team-framework,triaged-framework

How to do driver.tap based on x,y coordinates on the device
Repository: godot
Issue: GraphEdit doesn't use the closest ports when dragging
Labels: bug,confirmed,usability,topic:gui

**Godot version:**

8b5992f6658a125f63424a687e15e75ccd36906c

**Issue description:**

When dragging out from a GraphNode it doesn't use the closest port.

**Steps to reproduce:**

Put two GraphNode ports close to another and try dragging out from them until the issue happens.
This can be done in VisualScript.

**Code responsible:**

https://github.com/godotengine/godot/blob/8b5992f6658a125f63424a687e15e75ccd36906c/scene/gui/graph_edit.cpp#L594-L621

When checking if a port is clicked, it just loops over the ports and finds the first one where `is_is_hot_zone` is true.
Repository: opencv
Issue: dnn(permute): reduce permute to reshape (or transpose) whenever possible and work inplace
Labels: optimization,feature,category: dnn

##### System information (version)
- OpenCV => 4.2.0
- Operating System / Platform => Ubuntu 18.04
- Compiler => GCC 7.4

##### Detailed description

Vast majority of permute operations can be reduced to a reshape or a 2d-transpose. The reshape operation can be skipped entirely and the transpose operation can be efficiently performed inplace.

**Stats for single image inference:**

Model                 | Total Permute Layers | Reduced to 2d-transpose | Reduced to reshape
---------------------- | ---------------------------- | ----------------------------- | ---------------------------
MobileNet SSD  | 12                               | 10                                | 2
YOLOv3             | 3                                  | 3                                  | 0
Inception v2 Faster RCNN | 3                   | 2                                 | 1
Inception v2 Mask RCNN | 3                   | 2                                 | 1

Currently, the permute layer operates inplace when the permute order is identity order. This logic can be upgraded to include the logic used here:
1. https://github.com/opencv/opencv/blob/1f2b2c52422813188bc5cbcc5d312c89e41786b2/modules/dnn/src/cuda/permute.cu#L173-L186
2. https://github.com/opencv/opencv/blob/1f2b2c52422813188bc5cbcc5d312c89e41786b2/modules/dnn/src/cuda/permute.cu#L217-L231

This logic would allow the permute operation to be skipped entirely when it reduces to a reshape and perform inplace when it reduces to a 2d-transpose.

The reshape optimization is easier to implement. The logic can be implemented in `getMemoryShapes`. The same logic can be implemented in `op_permute.cpp` for the Vulkan backend. It's fairly easy to implement the same in the CUDA backend. IE nodes created in `BlankLayer` can be used when permute reduces to a reshape (or maybe IE's PermuteLayer/TransposeOp could handle it on its own).

The inplace 2d-transpose optimization (as all backends may not support it) would require inplace to be triggered for specific backends (which I believe the current DNN module doesn't support).
Repository: rust
Issue: Add ability to ignore tests at runtime.
Labels: T-lang,T-dev-tools,C-feature-request,A-libtest

For medium–large scale projects, or projects that have a lot of integrations with third party services. It would nice to be able to ignore tests based on the environment the tests are being run in. One example would be to run tests if an environment variable is present.

You can workaround this with something like the following, however the output of the test is `ok` and not `ignored`, misleading the user that the test was successful.

```rust
#[test]
fn foo() {
    if env::var("FOO").is_none() { return; }
    let foo = env::var("FOO").unwrap();
}
```
Repository: pytorch
Issue: Function request: logerfc, logerfcx special functions
Labels: module: numerical-stability,triaged,module: numpy,function request,module: special

## 🚀 Feature

Implement the `erfcx(x)` special function, which computes `exp(x^2) * erfc(x)` in a numerically stable way. Also for convenience, add `logerfc(x) = log(erfc(x))` and `logerfcx(x) = log(erfcx(x))`.

`erfcx` is available in many numerical packages, such as [Matlab](https://www.mathworks.com/help/matlab/ref/erfcx.html), [Julia](https://juliamath.github.io/SpecialFunctions.jl/latest/functions_list/#SpecialFunctions.erfcx), [SciPy](https://docs.scipy.org/doc/scipy/reference/generated/scipy.special.erfcx.html) [R](https://www.rdocumentation.org/packages/pracma/versions/1.9.9/topics/erf), and others.

From `erfcx` it is easy to obtain `logerfc` and `logerfcx`, but this involves a conditional which can be slow in pure Python code. So I recommend adding `logerfc` and `logerfcx` as well, which can be implemented as:

```
def logerfc(x): 
    if x > 0.0:
        return log(erfcx(x)) - x**2
    else:
        return log(erfc(x))

def logerfcx(x):
    if x < 0.0:
        return log(erfc(x)) + x^2
    else:
        return log(erfcx(x))
```

## Motivation

These special functions are very useful whenever we have to work with truncated normal distributions.

Related: https://github.com/pytorch/pytorch/issues/2129, https://github.com/pytorch/pytorch/issues/32293



cc @mruberry @rgommers @heitorschueroff
Repository: flutter
Issue: [web] Canvas.saveLayer does not work in HTML mode
Labels: engine,platform-web,c: rendering,e: web_html,has reproducible steps,P3,team-web,triaged-web,found in release: 3.13,found in release: 3.17

```dart
canvas.drawRect(...);
canvas.saveLayer(null, Paint()..blendMode = BlendMode.multiply);

canvas.drawRect(...);
canvas.restore();
```

This works fine when running Flutter on Android and looks like this:

[![Screen capture][1]][1]

When running the same code in Flutter Web, it looks like this (`saveLayer` is ignored):

[![Screen capture][2]][2]

When I move the `blendMode` to the `Paint` I pass to the second `drawRect`, it also works on Flutter web.

```
flutter doctor -v
[√] Flutter (Channel master, v1.13.7-pre.41, locale en-US)
    • Flutter version 1.13.7-pre.41 at flutter
    • Framework revision fa337f5922 (2 days ago), 2020-01-06 16:44:12 -0800
    • Engine revision 3851981b86
    • Dart version 2.8.0 (build 2.8.0-dev.0.0 2f57602411)
```

  [2]: https://i.stack.imgur.com/q3In0.png
  [1]: https://i.stack.imgur.com/s84vd.png
Repository: rust
Issue:  `Pin` is unsound due to transitive effects of `CoerceUnsized`
Labels: P-medium,T-lang,I-unsound,C-bug,E-needs-mcve,requires-nightly,F-coerce_unsized

Split out from #66544. It is possible to exploit `Pin` on nightly Rust (but not stable) by creating smart pointers that implement `CoerceUnsized` but have strange behavior. See [the dedicated internals thread](https://internals.rust-lang.org/t/the-pin-unsoundness-and-coerceunsized/11593) for more details -- also, please keep conversation on the thread, and not on the Github issue. ❤️
Repository: godot
Issue: Shadows are bugged with tiles in tilemaps
Labels: bug,topic:rendering,topic:2d

**Godot version:** 3.1.2 stable
**OS:** RebornOS (kernel version: Linux 5.4.2-arch1-1 x86_64)
**Issue description:** Look at picture
![DeepinScreenshot_20200108183708](https://user-images.githubusercontent.com/45467622/72001500-e4bdd600-3245-11ea-8891-249b44bfcbce.png)
I tried to google it but nothing
**Steps to reproduce:** Create 2 scenes, one with tiles, one the main scene
In the tile scene create some tiles and add LightOccluder2D to it and add CounterClockwise
In the main scene add Tilemap with tiles from the previous scene, add something to move with Light2D and enable shadows and use as light the image below
![light](https://user-images.githubusercontent.com/45467622/72001790-6ada1c80-3246-11ea-961d-7e2de170594f.png)
Repository: pytorch
Issue: JIT tests are linked directly into libtorch and register operators even when unused
Labels: oncall: jit,triaged

The two custom classes defined in [test/cpp/jit/test_custom_class.cpp](https://github.com/pytorch/pytorch/blob/7f723cbd8a53c85722af14d8749559de1992cd9b/test/cpp/jit/test_custom_class.cpp#L49-L61) will register new jit operators as soon as the library is loaded.

This lead to different operators being registered if we build the tests or not and that trips the backward compatibility checks.
https://github.com/pytorch/pytorch/pull/31949 is a temporary fix but should be improved.

The possible approaches here are:
- move the cpp tests outside of libtorch to avoid this issue altogether (and that will reduce release binary size!)
- change the test to only register these operators if they are actually used
- permanently whitelist all the `_TorchScriptTesting*` for the backward compatibility checks and ignore this issue.

cc @suo
Repository: PowerToys
Issue: touch/update timestamp for Windows-GUI in file-context-menu
Labels: Idea-New PowerToy

PowerToy-suggestion

scenario:
I move a bunch of files from folder A to folder B (which contains several hundred files). 
From my perspective they're "new" in folder B.  And ordering my files by "date modified" is an important part of my organization.
However "date modified" does not update, if files or folders merely change location, so it fails at sorting by "new".  If I add in twenty new files and they're all at twenty random wrong places in my long list.
However when I just move them in, all of them will still be selected. It would be really convenient, if I could right-click one of the selected files and click "update 'last modified'-timestamp".

why I need that:
I use a graph-based organization tool called "TheBrain 11" to manage all my files, instead of the hierarchical tree-structure. So all my personal files actually "live" in one folder. Each file is linked to a Thought in TheBrain (or to several). However there's still files I haven't added to that folder yet, partly because it's inconvenient to do so, because I can't differentiate in the file-explorer of whether they're in TheBrain already or not.

If there's a tool already out there, that does exactly that, I'd be thankful for any pointers.
Also, this would be good to have for folders as well.
Repository: flutter
Issue: Consider not setting overflow:hidden on text with no max lines
Labels: engine,c: performance,platform-web,c: proposal,perf: speed,e: web_html,P3,team-web,triaged-web

We currently set `overflow:hidden` on all `<p>`, but only those with maxlines need it. In general, clipping is considered an expensive operation, so avoiding it could have performance benefits. It's hard to tell how much cost this incurs in our case, but filing it anyway, so we can measure and fix it, or just blindly fix it on a hunch if performance investigation is not worth the trouble.
Repository: kubernetes
Issue: Improve CRD openapi serving speed
Labels: priority/important-soon,sig/scalability,sig/api-machinery,kind/feature,area/custom-resources,lifecycle/frozen

CustomResourcePublishOpenAPI e2e tests are [flaky](https://github.com/kubernetes/kubernetes/issues/86418) because the time for a given CRD change to get reflected in the openapi spec exceeds the 30s timeout. 

Here is a analysis for the worst case-- assuming three CRD changes were made at the same time (change A&B by tests running in parallel, and change C by the current test), it may take up to three 200OK downloads before the current e2e test sees change C in the openapi spec. The 30s timeout can be reached before the test starts the third 200OK download.  

![Copy of Untitled drawing](https://user-images.githubusercontent.com/6629765/72006696-0cd91500-3205-11ea-9877-7910a0dc70e8.png)

Things that we can improve:
1. [openapi service update](https://github.com/kubernetes/kubernetes/blob/b34c96b62c74c22ac9ac135fc787016786845a69/vendor/k8s.io/kube-openapi/pkg/handler/handler.go#L106-L139) (for both kube-aggregator and CRD) is most expensive. [Adding log](https://github.com/kubernetes/kubernetes/pull/86564) shows both the first [marshaling](https://github.com/kubernetes/kubernetes/blob/b34c96b62c74c22ac9ac135fc787016786845a69/vendor/k8s.io/kube-openapi/pkg/handler/handler.go#L107) and [ToProtoBinary](https://github.com/kubernetes/kubernetes/blob/b34c96b62c74c22ac9ac135fc787016786845a69/vendor/k8s.io/kube-openapi/pkg/handler/handler.go#L115) can cost more that 5s for kube-aggregator. The time spent also varies a lot even though the spec size should be rather stable (due to CPU pressure?). More efficient ways to do the marshaling and generate proto binary would help.
2. although the CRD openapi spec is much smaller compared to kube-aggregator,  openapi service update still costs 0.5~1.5s to apiextensions-apiserver for each CRD change. Since openapi service update requires lock, the time queues up when there are lots of CRD changes at the same time (e.g. three CRD changes in the image above). Solving the previous point also helps here
3. apiextensions-apiserver supports serving openapi spec in PB and gzip, but kube-aggregator downloads and deserializes the spec through JSON (which makes sense for aggregated apiservers). Potentially kube-aggregator can use PB when it's talking to apiextensions-apiserver. 

cc @liggitt @sttts @wojtek-t
Repository: godot
Issue: Array out of bounds in libtheora
Labels: bug,topic:thirdparty

**Godot version:**
Godot 3.2 beta 5
**OS/device including version:**
Ubuntu 19.10
**Issue description:**
Backtrace
```
thirdparty/libtheora/state.c:327:37: runtime error: left shift of 1 by 63 places cannot be represented in type 'long int'
thirdparty/libtheora/state.c:576:19: runtime error: left shift of negative value -800
thirdparty/libtheora/huffdec.c:211:43: runtime error: index 4 out of bounds for type 'oc_huff_node *[2]'
thirdparty/libtheora/huffdec.c:210:56: runtime error: index 4 out of bounds for type 'oc_huff_node *[2]'
thirdparty/libtheora/huffdec.c:329:33: runtime error: index 2 out of bounds for type 'oc_huff_node *[2]'
thirdparty/libtheora/huffdec.c:329:47: runtime error: index 2 out of bounds for type 'oc_huff_node *[2]'
thirdparty/libtheora/huffdec.c:327:51: runtime error: index 4 out of bounds for type 'oc_huff_node *[2]'
thirdparty/libtheora/huffdec.c:327:17: runtime error: index 4 out of bounds for type 'oc_huff_node *[2]'
thirdparty/libtheora/huffdec.c:328:42: runtime error: index 4 out of bounds for type 'oc_huff_node *[2]'
```

**Steps to reproduce:**
1. Compile Godot from https://github.com/qarmin/godot/tree/bb, or apply patch from this commit to your own branch with GCC 9 and Clang 9
2. Run project in editor

**Minimal reproduction project:**
https://github.com/GDQuest/godot-power-pitch
Repository: TypeScript
Issue: Generator prototype ignored
Labels: Suggestion,Awaiting More Feedback

**TypeScript Version:**  3.8.0-dev.20200107

**Search Terms:** generator, iterator, prototype, inherit

**Code**

```ts
function* gen() {
    while (true) {
        yield "something";
    }
}

gen.prototype.test = () => {
    console.log("OK");
};

gen().test();
```

**Expected behavior:** No errors

**Actual behavior:** Error `TS2339: Property 'test' does not exist on type 'Generator<string, void, unknown>'`

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> [Provided](https://www.typescriptlang.org/play/?target=99&ts=3.8.0-dev.20200107#code/GYVwdgxgLglg9mAVAAgOYFMwAoCUyDeAsAFDJnIDuAFjADbrJZQBOI6eRp53AnjOrQAmyAEQBnOAFt0UGmFQiA3CW4BfEuuIkMYAHQAHZnCjGe+9LqjoxUZAF5GeOwD4CK8hAQT6u2nFRYIgDyANIiOMrEqpHamLiW1lC4isgA9KnIAKLMRszIACoAygBMAMylAJwAXMgACkbmzFA8yADkVjatyIJw1shgxsjoAB4wNsgIyM3mbQDimOjMAIYmzAA8Nsww8gA0yABucDCCe+AA1gMUYM6tuipAA)
Repository: terminal
Issue: Remove usages of old safe math
Labels: Product-Conhost,Help Wanted,Product-Conpty,Issue-Task,Area-CodeHealth

There are approximately 79 uses of old safe math. (a.k.a. the `LongAdd`, `ShortAdd`, and friends from `intsafe.h`).

This task represents removing them and transitioning them to an appropriate safe/saturating math function from the chromium safe math library introduced in #4144.

After removing usages of the old safe math functions, also remove the `intsafe.h` header.

Files with old safe math as of this writing:
- TerminalControl: TSFInputControl.cpp
- TerminalCore: TerminalDispatch.cpp
- TerminalCore: TerminalSelection.cpp
- Host: directio.cpp
- RendererGdi: invalidate.cpp
- RendererGdi: math.cpp
- RendererGdi: paint.cpp
- RendererVt: paint.cpp
- TerminalAdapter: adaptDispatch.cpp
- Types: viewport.cpp
- Types: WindowUiaProviderBase.cpp
Repository: kubernetes
Issue: Remove VerifyVolumeAttached for CSI Plugin
Labels: sig/storage,kind/feature,lifecycle/frozen

/cleanup
/assign

VerifyVolumeAttach functionality for CSI is handled by default by the [csi-attacher v2.1+](https://github.com/kubernetes-csi/external-attacher/blob/v2.1.0/CHANGELOG-2.1.md). The in-tree verification is a no-op since it just looks at the `VolumeAttachment.Status.Attached` field which is not an accurate representation of reality when the backend attach status has changed out of band.

/cc @msau42 @saad-ali
Repository: flutter
Issue: InkWell.onLongPress cancels ripple animation
Labels: framework,f: material design,f: gestures,customer: crowd,has reproducible steps,found in release: 3.3,customer: flex,found in release: 3.7,team-design,triaged-design

I am trying to build a button that increments a number when the user taps on it, then continues to increment that number every `x` milliseconds while the user continues to long press the button.

If I try out this code sample, it behaves as expected. The number is incremented one time, and the ripple effect works properly:

```dart
return Material(
  child: InkWell(
    onTap: () { increment(); },
    child: Container(
      width: 30,
      height: 30,
      decoration: BoxDecoration(
        border: Border.all(color: Colors.black),
      ),
    ),
  ),
);
```

If I then try to implement the `onLongPress` callback, even just an empty function will stop the ripple effect immediately:

```dart
return Material(
  child: InkWell(
    onTap: () { increment(); },
    onLongPress: () {}, // this breaks the ripple effect
    child: Container(
      width: 30,
      height: 30,
      decoration: BoxDecoration(
        border: Border.all(color: Colors.black),
      ),
    ),
  ),
);
```

There doesn't seem to be a way to use the `onLongPress` parameter without breaking the ripple effect.
Repository: go
Issue: crypto/tls: Client Side TLS Authentication fails for certs with long fields
Labels: NeedsInvestigation

### What version of Go are you using (`go version`)?

<pre>
go version go1.13.4 linux/amd64
</pre>

### Does this issue reproduce with the latest release?
Yes

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOENV="/home/user/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/user/Revisions/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.13"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.13/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/user/go/src/helm.sh/helm/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build386574731=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### What did you do?

package main

import (
	"crypto/tls"
	"fmt"
)

func main() {
	cert, err := tls.LoadX509KeyPair("./helm-test-crt", "./helm-test.key")
	fmt.Println(cert, err)
}


Test certs:
https://gist.github.com/antevens/a05409165d33bd771e39bc219fe2c6bb/archive/e56cf114dee64a6b367abf08ab1c34a405a62f88.zip

https://github.com/helm/helm/issues/7343

### What did you expect to see?
Client side TLS authentication succeed.

### What did you see instead?
asn1: structure error: base 128 integer too large