sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: kubernetes
Issue: Option for acknowledging terminating Pods in Deployment rolling update
Labels: kind/feature,sig/apps,priority/important-longterm,triage/accepted

### What would you like to be added?

It could make sense to wait for a pod to be terminated before scheduling a new one for the issues mentioned bellow. Even though some issues can be partially mitigated by proper setup of maxUnavailable and maxSurge, it is not applicable for all of them.

I would like to propose a new opt-in behaviour that would solve this. Deployment controller would include Terminating pods in the computation of current running replicas when deciding if the new RS should scale up (or old in case of proportional scaling).

This could be configured for example in `.spec.strategy.rollingUpdate.scalingPolicy` with possible values
1. `IgnoreTerminatingPods` - default and current behaviour
2. `WaitForTerminatingPods`

The disadvantage of this feature is a slower rollout in resource unrestricted environments. So, using this feature would be advised only for similar use cases to the mentioned ones above.

### Why is this needed?

In some cases people are surprised that their deployment can momentarily have more pods during a rollout than described `( replicas - maxUnavailable < availableReplicas < replicas + maxSurge)`. The culprit are Terminating pods that can run in addition to the Running + Starting pods.
Even though Terminating pods are not considered part of a deployment this can cause problems with resource usage and scheduling:

1. Unnecessary autoscaling of nodes in tight environments and driving up cloud costs. This can hurt especially if
    - you rollout multiple deployments at the same time.
    - you have generous termination periods and your pods take a long time to shutdown (example here https://github.com/kubernetes/kubernetes/issues/95498#issuecomment-814048997)
 
    relevant issues:
    - https://github.com/kubernetes/kubernetes/issues/95498
    - https://github.com/kubernetes/kubernetes/issues/99513
    - https://github.com/kubernetes/kubernetes/issues/41596
    - https://github.com/kubernetes/kubernetes/issues/97227
 
2. A problem also arises in contentious environments where pods are fighting for resources. This can bring up exponential backoff for not yet started pods into big numbers and unnecessarily delay start of such pods until they pop from the queue when there are computing resources to run them. This can slow down the deployment considerably.

    relevant issue: https://github.com/kubernetes/kubernetes/issues/98656

    In this issue the resources were limited by a quota, but this can be due to other reasons as well. In our use case we noticed, this can occur also in high availability scenarios where pods are expected to run only on certain nodes and pod anti-affinity forbids to run two pods at the same node.
Repository: pytorch
Issue: `TestCase.assertEqual` has `equal_nan` default to `True`
Labels: module: tests,triaged,module: testing

### 🐛 Describe the bug

While [`torch.testing.assert_close`](https://pytorch.org/docs/stable/testing.html#:~:text=torch.testing.assert_close%28actual%2C%20expected%2C%20%2A%2C%20allow_subclasses%3DTrue%2C%20rtol%3DNone%2C%20atol%3DNone%2C%20equal_nan%3DFalse%2C%20check_device%3DTrue%2C,%5Bsource%5D%20Asserts%20that%20actual%20and%20expected%20are%20close.), [`torch.allclose`](https://pytorch.org/docs/stable/generated/torch.allclose.html), and [`torch.isclose`](https://pytorch.org/docs/stable/generated/torch.isclose.html) have `equal_nan` defaulted to `False`, it is default `True` in [`TestCase.assertEqual`](https://github.com/pytorch/pytorch/blob/2d5296b0e7769b9bd7cda9607c1d14820e9103e4/torch/testing/_internal/common_utils.py#L2075). While likely extremely rare, this default setting has lead to unexpected behavior e.g., (#72157) in the form of bogus comparisons between two `NaN` tensors. Should this default be revisited and the cases where `NaN`s in testing results expected/tolerated explicitly marked?

CC @ptrblck @xwang233 @zasdfgbnm @ngimel 

### Versions

Current upstream

cc @mruberry
Repository: terminal
Issue: The open pane animation background is transparent
Labels: Help Wanted,Issue-Bug,Area-UserInterface,Product-Terminal,Priority-3

### Windows Terminal version

1.13.10321.0

### Windows build number

_No response_

### Steps to reproduce

Split open a pane with pane animations enabled

### Expected Behavior

The background during the pane split animation should not be transparent

### Actual Behavior

The background during the pane split animation is transparent (somehow, the close pane animation background is correct though)
Repository: PowerToys
Issue: FancyZones "Move newly created windows..." makes new WSL2 GUI windows unresponsive
Labels: Issue-Bug,Product-FancyZones,Area-App Compat

### Microsoft PowerToys version

0.55.0

### Running as admin

- [ ] Yes

### Area(s) with issue?

FancyZones

### Steps to reproduce

While this may seem, at first, to be a WSL2 issue, it only happens in combination with PowerToys FancyZones "Move newly created windows to the current active monitor (Experimental)" option. It could be due to WSL2 windows opening on a monitor that is not the "main display", and therefore be a WSL2 issue.

When a WSL2 Linux GUI application is started on a monitor that is not the "main display", the window is unresponsive, including the close button. The application is responsive if started on the main display.

A work-around that might hint towards the true problem: if a different monitor is picked as the "main display" while PowerToys is running, FancyZones will no longer move new WSL2/Linux GUI windows to the current monitor. These windows seem to always be responsive. Note that regular Windows 11 windows will move to the current monitor as expected.

In case this information is useful, my system is a Windows 11 install that is a fresh upgrade from a six month old Windows 10 install. There are 3 monitors attached, and one is set to the "Portrait (flipped)" display orientation. While I was initially suspicious that the monitor rotation might be the issue, it will happen with any monitor that is not set as the main display.

WSL2 was installed on Windows 11 following [these directions](https://docs.microsoft.com/en-us/windows/wsl/install), along with the [Windows Subsystem for Linux Preview from the Microsoft Store](https://www.microsoft.com/store/productId/9P9TQF7MRM4R) and the Ubuntu 20.04 distribution from the Microsoft Store:

Steps to reproduce the problem:

1.  Ensure PowerToys FancyZones "Move newly created windows to the current active monitor (Experimental)" option is turned on
2. Open a WSL2 session on a monitor that is not the main display
3. Start a Linux GUI application
4. Note that the Linux GUI application is unresponsive

Steps to reproduce the work-around noted above:

1. Open the Display Settings / System -> Display
2. Select a monitor that is not the main display
3. Click the "Multiple displays" drop down
4. Check the "Make this my main display" checkbox
5. Open a WSL2 session on a monitor that is not the selected display / the new main display
6. Start a Linux GUI application
7. Note that the Linux GUI application only opens on the new main display, and that it is responsive

[PowerToysReport_2022-02-02-11-43-25.zip](https://github.com/microsoft/PowerToys/files/7989745/PowerToysReport_2022-02-02-11-43-25.zip)



### ✔️ Expected Behavior

I would expect the Linux GUI application's window to be responsive.


### ❌ Actual Behavior

Linux GUI application windows are unresponsive if they open on a monitor that is not the main display.


### Other Software

- WSL2
- Windows Subsystem for Linux Preview from the Microsoft Store
- The Ubuntu 20.04 distribution from the Microsoft Store
Repository: transformers
Issue: Number-specific tokenization changes
Labels: New model

# 🌟 New model addition

## Model description

I wanted to contribute a bunch of number-specific LMs proposed in recent work. Most of these are not architecture changes but simple tokenization tricks such as converting a number `329` to `3.29e2` (scientific; [Zhang et al. 2020](https://aclanthology.org/2020.findings-emnlp.439/)) or `3 2 9` (digit splitting; [Nogueira et al. 2021](https://arxiv.org/abs/2102.13019)) or `e2` (exponent only; [Spokoyny et al. 2020](https://aclanthology.org/2020.emnlp-main.385/) and [Thawani et al. 2021](https://aclanthology.org/2021.emnlp-main.557/)). The motivation is that several industrial applications require number-heavy NLP but struggle with existing models.

I discussed a specific way to do this on team slack with @SaulLu for, say, NumBERT (scientific notation) which involves adding a new model (tokenizer-only) and uploading the pretrained weights to the hub. I wanted to open a broader discussion here about more such number-tokenizer-only methods, some of which may not even have pretrained weights. The hope would be to make some abstract intervention (perhaps at the tokenizer level) to let the user configure GPT or BERT tokenizer as `number_tokenizer=exponent`. 

But perhaps clubbing methods from different papers into one model/tokenizer is against HF's philosophy? If so, I could proceed with trying to simply incorporate them as individual models - is it fine if some of them do not have pretrained weights available?

## Open source status

* [X] the model implementation is available: [T5 fine-tuned on arithmetic, based on HF transformers](https://github.com/castorini/transformers-arithmetic) and [NumBERT/scientific, based on google-bert original code](https://github.com/google-research/google-research/tree/master/numbert)
* [X] the model weights are available: [BERT pretrained with scientific notation](https://console.cloud.google.com/storage/browser/gresearch/numbert)
* [X] who are the authors: @spokoyny @XikunZhang @DeepakRamachandran @iftenney @yanaiela @rodrigonogueira4 @lintool
Repository: flutter
Issue: [cocoon] Move docs in bin/server.dart to class docs
Labels: team-infra,good first issue,P3,triaged-infra

Context in https://github.com/flutter/cocoon/pull/1574#discussion_r797999548
Repository: flutter
Issue: Improvements to estimateMaxScrollOffset
Labels: c: new feature,framework,f: scrolling,d: api docs,d: examples,c: proposal,a: annoyance,a: layout,P3,team-framework,triaged-framework

Chatted with @HansMuller about this the other day.

Currently, Flutter only estimates the maximum scroll offset one way, but taking the average size of the visible children and multiplying it by the number of children:

https://github.com/flutter/flutter/blob/f82c020071667d723017aab328c09ba70617bf7c/packages/flutter/lib/src/widgets/sliver.dart#L1281

This can be a bit unfortunate when the user has a list of dynamically sized items in which the max scroll extent changes as they scroll. 

There seem to be some opportunities for improvement here. Things we might consider:
- Adding more strategies for estimating the max scroll offset for different situations
  - optionally could let the user decide which estimation method they would like used
  - One should be that we cache the metrics as we go, rather than disposing of extent info of children we have scrolled past already
- Better expose an option for users to provide their own estimate
  - could just involve a good example or two showing how to override `estimateMaxScrollOffset` for any SliverChildDelegate, but if there are more approachable options we should explore further
  
Related to https://github.com/flutter/flutter/issues/25652
Repository: TypeScript
Issue: Allow TS formatter to not remove extra spaces after the first non-whitespace character (and before the last).
Labels: Suggestion,Domain: Formatter,Awaiting More Feedback

*TS Template added by @mjbvz*

**TypeScript Version**: 4.6

**Search Terms**
- format
- formatting
- whitespace

---

I often format code like this outside in other projects:

![image](https://user-images.githubusercontent.com/2193314/152174757-a1facf85-88c7-49f3-80f3-f3d1958e3fa4.png)

I've found this particularly useful when dealing with color channel in an array as it makes it much easier to see the differences in the RHS:

```ts
data[i    ] = …;
data[i + 1] = …;
data[i + 2] = …;
data[i + 3] = …;
```

alt+shift+f removes this whitespace, I checked settings and there are a bunch of whitespace related ones but they all seem to be strict around adding a single space. Can we add a setting so we can have these use >=1  instead space?
Repository: PowerToys
Issue: Can't force version checking after update is auto-downloaded (minor)
Labels: Issue-Bug,Product-Settings,Priority-2

### Microsoft PowerToys version

0.53.3

### Running as admin

- [ ] Yes

### Area(s) with issue?

Installer

### Steps to reproduce

So normaly you have this "Check for updates Button", but when an update is auto-downloaded and ready for installation, the button is hidden. 
This is only an issiue when you are more then one version behind and the auto-update-checker hasn't run again so its very minor.


### ✔️ Expected Behavior

Don't hide the "Check for updates" button, although an update is ready for installation

### ❌ Actual Behavior

![grafik](https://user-images.githubusercontent.com/40129767/152246490-ce438cb1-07db-4a64-b5f0-93943796a326.png)
it checked 19:57, 0.55.1 release was 21:47

### Other Software

_No response_
Repository: ant-design
Issue: Form.Item rules validation messages translations don`t work
Labels: help wanted,Inactive

- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.

### Reproduction link
[![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/muddy-worker-44l3l?file=/src/App.jsx)

### Steps to reproduce
1. Type a few characters into the input field
2. Validation message should appear
3. Click on the language dropdown menu and change the language 
4. Type one more character into the input field. Translation changes to the selected one. It looks like rerender for validation rules doesn't run

### What is expected?
Everything that uses i18n should be translated

### What is actually happening?
Everything translates except Ant Design Form.Item rules validation message

| Environment | Info |
|---|---|
| antd | 4.18.5 |
| React | 17.0.2 |
| System | Windows 10 |
| Browser | Chrome 97.0 |

---


<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: flutter
Issue: We could save some KB by reusing the JSON parser in Dart instead of using RapidJSON
Labels: engine,c: performance,dependency: dart,P3,team-engine,triaged-engine

This would require some help from the Dart side to make the code reusable.
Repository: godot
Issue: Children of TileMap instantiated as scene tiles have their _ready function called after their parent
Labels: discussion,topic:core,documentation,topic:2d

### Godot version

v4.0.alpha1.official [31a7ddbf8]

### System information

Windows 10

### Issue description

When using the new scene tiles with a tilemap, those children scenes have their _ready function called after their parent's.

I am unsure if this is the wanted behaviour, but since they are children i would have expected the children's _ready functions to be called before the parent's.



### Steps to reproduce

The reproduction project has a tilemap with three identical children. One as a standard child, two as scene tiles.

Every of those object prints something in their ready functions.

When running the main scene, you can see that one child (the standard one) prints first, then the tilemap, then the scene tiles.


### Minimal reproduction project

[reproduction.zip](https://github.com/godotengine/godot/files/7990630/reproduction.zip)
Repository: deno
Issue: lsp: incremental lint and dependency diagnostic generation
Labels: perf,feat,lsp

Right now, we create lint diagnostics for every open file each time:

https://github.com/denoland/deno/blob/ed3086e4b129843c13a009112cf21dfd05745905/cli/lsp/diagnostics.rs#L451

This means that after you open enough files (say 50), you will start to get a noticable delay when changing only one file.

To improve this, we could store lint diagnostics and only recreate them when the file version changes. This should be ok because lint diagnostics are not dependent on other files. I don't think this would work for things like TypeScript or dependency diagnostics unfortunately.
Repository: deno
Issue: lsp: investigate prioritizing the generation of diagnostics to the last modified or opened file
Labels: perf,feat,lsp

Instead of (1) collecting diagnostics for all open documents and (2) publishing diagnostics. We might want to consider (1) collecting diagnostics for the last modified/opened file, (2) publish these diagnostics, (3) collect diagnostics for the other files, (4) publish these other diagnostics.

This would take longer overall, but my guess would be that it would give the impression that the lsp is faster. To implement, the diagnostic update sent from the `LanguageServer` to `DiagnosticsServer` would include a collection of specifiers to prioritize.

One downside to this, is that it would make the LSP tests more complicated so this would be a largish task to implement. If/when implementing we should create a way to make testing the LSP easier and not as verbose.
Repository: pytorch
Issue: [JIT] Assert that the autodiff implementation of backward() returns the correct number of values
Labels: oncall: jit

### 🚀 The feature, motivation and pitch

Autodiff JIT implementations are given by [symbolic_script.cpp](https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/runtime/symbolic_script.cpp). For example, see this implementation of backward for addmm (from Feb 2nd):

```python3
        def addmm(self,
                  mat1,
                  mat2,
                  *,
                  beta: number,
                  alpha: number):
            result = torch.addmm(self, mat1, mat2, beta=beta, alpha=alpha)
            self_size = torch._size_if_not_equal(self.size(), result.size())
            def backward(grad_output):
                self_grad = (grad_output * beta)._grad_sum_to_size(self_size)
                mat1_grad = grad_output.mm(mat2.t()) * alpha
                mat2_grad = mat1.t().mm(grad_output) * alpha
                return self_grad, mat1_grad, mat2_grad, None, None
            return result, backward
```

Generally, JIT expects the backward() implementation to return a gradient for each of its inputs. In this case, there are self, mat1, mat2, beta, and alpha inputs.

Sometimes, an implementation is wrong (e.g. #67648), or the interface to an op changes (e.g. #71670, where an extra argument is added to addmm) and the number of inputs to the op differs from the number of outputs from the backward() implementation. A runtime error is thrown at [autodiff.cpp:425](https://github.com/pytorch/pytorch/blob/8fef7c09f59c44de1f77abbf5d61d4ec69d1ec15/torch/csrc/jit/runtime/autodiff.cpp#L425).

It would be better if we could error out earlier with an assert, or maybe add a test for symbolic_script.cpp to make these types of errors easier to catch.

### Alternatives

_No response_

### Additional context

_No response_
Repository: PowerToys
Issue: [Always On Top] Respect non-standard window region (set via SetWindowRgn) when drawing border
Labels: Product-Always On Top,Needs-Triage,Needs-Team-Response

### Description of the new feature / enhancement

Realizing this a somewhat niche use-case, but thought I'd ask anyway...

I frequently make use of the [SetWindowRgn function](https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-setwindowrgn) in the Windows API (via Autohotkey's [WinSet, Region](https://www.autohotkey.com/docs/commands/WinSet.htm#Region) feature) to "cut out" parts of a window.

I use this, for example, when video calling and I want to cut out everything except my recipient's video. Then I pin the window to the top and boom, I have a DIY floating pop-out window. I realize that many chat apps have this feature built-in, but arbitrarily "cutting out" any window can be more useful.

When I use PowerToys Always On Top to pin a window I've cut out, the border appears on the original, un-cut window. I would love if PowerToys could check if a window has a custom region set (perhaps via [GetWindowRgn](https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getwindowrgn)) and draw the border around the region only.

Normal, pinned window:
![image](https://user-images.githubusercontent.com/4278123/152261061-27666dc4-ba0f-4b95-aa82-7642e9edd7aa.png)

Cut, unpinned window:
![image](https://user-images.githubusercontent.com/4278123/152261131-4b1a2773-39a1-4761-a7b4-33a31bc6ad5d.png)

Cut, pinned window:
![image](https://user-images.githubusercontent.com/4278123/152261177-8546dd57-df09-4bea-a107-3042feef73b5.png)




### Scenario when this would be used?

The 2 of us who use SetWindowRgn to arbitrarily cut out windows.

### Supporting information

_No response_
Repository: flutter
Issue: [cocoon] Refactor LuciBuildService to generally work
Labels: team-infra,P3,triaged-infra

There's several methods like `rescheduleProdBuild` `rescheduleTryBuild` `scheduleTrybuild` `scheduleProdBuild` that we could have share logic instead of duplicating. This would make it easier to read and change buildbucket related logic.

Ideally, we want a `_scheduleBuild` that these all internal refer to, with minor additions in their respective calls.

Additionally, we want to migrate off the terms try and prod to presubmit and postsubmit to make it clearer.
Repository: react
Issue: [DevTools Bug]: Inconsistent enforcement of using hooks in callbacks
Labels: Type: Bug,Component: ESLint Rules

### Website or app

https://codesandbox.io/s/distracted-chihiro-u1mc2

### Repro steps

The rules-for-hooks linter seems to be applying rules about using hooks in callbacks inconsistently.

Using a hook in this callback is okay
`const useNamed = async () => useQuery();`
And subsequently sending it as a prop is also okay
`<Foo useData={useNamed} />`

However, assigning the anonymous callback directly in the prop triggers the linter rule "React hook cannot be called inside a callback"
`<Foo useData={async () => useQuery()} />`

I'm having trouble understanding the difference. They appear to be equivalent code but with different results from the linter.
In which case is the linter correct?

Sandbox here: https://codesandbox.io/s/distracted-chihiro-u1mc2

### How often does this bug happen?

Every time

### DevTools package (automated)

_No response_

### DevTools version (automated)

_No response_

### Error message (automated)

_No response_

### Error call stack (automated)

_No response_

### Error component stack (automated)

_No response_

### GitHub query string (automated)

_No response_