sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: terminal
Issue: Box drawing characters are not antialiased
Labels: Area-Rendering,Issue-Bug,Product-Terminal,Priority-3

# Environment

```none
Windows build number: Microsoft Windows [Version 10.0.18362.592]
Windows Terminal version (if applicable): Version: 1.0.1401.0
Any other software? No.
```

# Steps to reproduce

1. Install the latest 1.x version of Windows Terminal and open a WSL terminal.
2. Download and display the [UTF-8 Demo Text](https://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-demo.txt), for an example
`$ curl https://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-demo.txt`

# Expected behavior

The box drawings are properly rasterized with antialiasing in similar fashion to the rest of the text. Here is an example from Fluent Terminal using the Inconsolata font:
![image](https://user-images.githubusercontent.com/4991927/82727405-ff738180-9cf2-11ea-8000-c0f82e8d2669.png)

(Note: I'm not necessarily saying this is perfect either, but it's at least _closer_ to what would be an acceptable and more consistent result.)

# Actual behavior

The box drawing glyphs are severely aliased, unlike any other text, with visible pixel gaps in diagonal elements, and generally just look _really_ bad. Rendered in the latest stable Windows Terminal version using the Inconsolata font (size 10pt):
![image](https://user-images.githubusercontent.com/4991927/82727447-58dbb080-9cf3-11ea-9f5b-65debc2ce913.png)

This behavior is not just limited to Inconsolata, but happens with every font, and every size. Here is for an example **Cascadia Mono** in different sizes:
8pt
![image](https://user-images.githubusercontent.com/4991927/82727590-19fa2a80-9cf4-11ea-80ff-9a0b472cb62f.png)

10pt
![image](https://user-images.githubusercontent.com/4991927/82727598-21213880-9cf4-11ea-91c5-7f53135433f2.png)

12pt
![image](https://user-images.githubusercontent.com/4991927/82727599-25e5ec80-9cf4-11ea-9bb0-cbb876431626.png)

This behavior was introduced recently in the RC versions, and I assume `0.11.1333.0` in specific since it included #5743 which altered the way box drawing glyphs were handled. Prior versions had alignment issues with these glyphs that the PR aimed to fix, but at least the glyphs were still rendered nicely individually, with a similar, comparable output to what Fluent Terminal produces.
Repository: rust
Issue: Incorrect error message, “can't call method on ambiguous numeric type `{integer}`”
Labels: C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics,D-papercut

```rust
// use std::ops::AddAssign;

fn foo() {
    1.add_assign(1);
}
```

Uncomment the `use` and it compiles, QED.

([Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=a9ade89e2201a31813f3c3c56ac117a0))

Errors:

```
   Compiling playground v0.0.1 (/playground)
error[E0689]: can't call method `add_assign` on ambiguous numeric type `{integer}`
 --> src/lib.rs:4:7
  |
4 |     1.add_assign(1);
  |       ^^^^^^^^^^
  |
help: you must specify a concrete type for this numeric value, like `i32`
  |
4 |     1_i32.add_assign(1);
  |     ^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0689`.
error: could not compile `playground`.

To learn more, run the command again with --verbose.

```

<hr>

After following the compiler’s hint, we get:
```rust
// use std::ops::AddAssign;

fn foo() {
    1_i32.add_assign(1);
}
```

([Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=120e045f5c7dd1e6025bf9458d3e569a))

Errors:

```
   Compiling playground v0.0.1 (/playground)
error[E0599]: no method named `add_assign` found for type `i32` in the current scope
 --> src/lib.rs:4:11
  |
4 |     1_i32.add_assign(1);
  |           ^^^^^^^^^^ method not found in `i32`
  |
  = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
  |
3 | use std::ops::AddAssign;
  |

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.
error: could not compile `playground`.

To learn more, run the command again with --verbose.

```

So, I suppose, at least 2 steps do currently lead to a compiling program.

@rustbot modify labels: T-compiler, A-diagnostics, D-incorrect, C-bug.
Repository: PowerToys
Issue: Disable "Alt+underlined letter" menu
Labels: Idea-New PowerToy

it's super annoying when i'm using ALL KINDS OF APPLICATIONS (like photoshop,powerpoint etc.),and there is no official way to fix it,maybe we can fix it by PWT 
![批注 2020-05-23 204324](https://user-images.githubusercontent.com/61088063/82730933-138ca280-9d36-11ea-8dba-3e2a94621d64.jpg)

ps: unofficial solution：
https://www.youtube.com/watch?v=vRld4bVFrpU
Repository: godot
Issue: GLES2.0 shader time precision error
Labels: platform:android,topic:shaders

**Godot version:**
3.2.2 Beta 3 Official

**OS/device including version:**
Android (Xiaomi Poccophone)

**Issue description:**
When using time uniform in shaders for trigonometrical functions it will mess up the calculations after a time, even when using modulo to prevent precision errors. This will not happen in the editor or on desktop.
It does look like for example displacement (for water) is having low fps after a time, but the fps of the game are okay, so my guess is, that after a time there are some **precision errors despite using modulo functions**.

**Steps to reproduce:**
I've been using canvas items combined with using a screen texture to calculate some displacement.

Using a simple expression like this, with vector `uv`, scalar `time` input and `uv_out` vector output:
```
float x = sin(mod(time, 6.28318530718));
float y = cos(mod(time, 6.28318530718));
uv_out.xy = uv.xy + vec2(x, y) * 0.0025;
```
is already enough that the time value will start to messing up the shader after a short time (one minute or two is enough for me)


**Minimal reproduction project:**
I will add one lateron.
Repository: godot
Issue: Material UI not responding when updating shader params in tool mode
Labels: bug,topic:editor,topic:shaders

**Godot version:**
3.2.2 Beta 3 Official

**OS/device including version:**
Windows 10

**Issue description:**
Having a `sprite node` with a tool script attached to it:
```
tool
extends Sprite

func _process(delta: float) -> void:
	material["shader_param/Uniform"] = ArbitraryValue
```
And having a material which is using a `VisualShader`, the editor UI for the material shader will not be clickable anymore. This is preventing the shader being opened via the sprites material property panel.

**Steps to reproduce:**
add a sprite to the scene.
add a new material to the sprite with a visual shader.
Add a uniform to the visual shader and use it somehow. (a color uniform for example)
also attach a new script with tool mode in which updates a material uniform in the process function.
Reopen the scene, so that the tool starts processing.
Try opening the Visual script via the sprite's property panels.

**Minimal reproduction project:**
Repository: PowerToys
Issue: [Run] Add option for custom locations, custom commands, workflow
Labels: Idea-Enhancement,Product-PowerToys Run

Hi,

First of all let me say I absolutely love PowerToys and use it on a daily basis.
The new app launcher is great and since it works more smoothly and lag free for me compared to other third-party programs is what attracted me to it. But the only thing, at least in my workflow, is the ability to create custom commands.

For example, a custom command to open a specific file or a folder (which is not within the Users folder, or is hidden), will make a monumental change in my workflow.
Repository: flutter
Issue: [web ]Tab label shows white and text overflows when using long text 
Labels: engine,platform-web,e: web_html,has reproducible steps,customer: web10,P2,customer: june,found in release: 3.3,found in release: 3.6,team-web,triaged-web

## Steps to Reproduce

1. Put a few tabs into a `DefaultTabController` with relatively long labels.
2. Make sure you reduce the width of your browser window so that the tabs have no room to display in full.

**Expected results:**

Correct display.

**Actual results:**

Labels with overflown texts will show an extra white background.

![Annotation 2020-05-23 153856](https://user-images.githubusercontent.com/2234271/82732253-5a65a280-9d0c-11ea-9f07-50f3fec27f02.png)

<details>
  <summary>Doc</summary>

```
[√] Flutter (Channel beta, 1.18.0-11.1.pre, on Microsoft Windows [Version 10.0.18363.836], locale en-US)
    • Flutter version 1.18.0-11.1.pre at E:\Android\flutter-beta
    • Framework revision 2738a1148b (10 days ago), 2020-05-13 15:24:36 -0700
    • Engine revision ef9215ceb2
    • Dart version 2.9.0 (build 2.9.0-8.2.beta)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.1)
    • Android SDK at e:\Android\Sdk
    • Platform android-29, build-tools 29.0.1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • CHROME_EXECUTABLE = e:\Android\chrome.bat

[√] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] Connected device (2 available)
    • Web Server • web-server • web-javascript • Flutter Tools
    • Chrome     • chrome     • web-javascript • Google Chrome 81.0.4044.138

• No issues found!
```

</details>
Repository: pytorch
Issue: fold variation
Labels: feature,module: nn,triaged,function request

current scenario -
the current nn.Fold module adds all the overlalpping values, would it be a good idea to add `mode` to nn.Fold, for example,
```
x = torch.randn(5, 5)
x = x.unfold(0, 3, 1).unfold(1, 3, 1)
x = x.reshape(1, 9, 9)
x
```
gives
```
tensor([[[-0.6498,  0.0957,  0.0787,  0.8407, -2.1366,  0.4104,  1.2258,
           1.3592,  2.0226],
         [ 0.0957,  0.0787, -0.5516, -2.1366,  0.4104,  0.8823,  1.3592,
           2.0226, -2.2944],
         [ 0.0787, -0.5516,  1.2226,  0.4104,  0.8823,  0.5543,  2.0226,
          -2.2944, -1.3409],
         [ 0.8407, -2.1366,  0.4104,  1.2258,  1.3592,  2.0226, -1.6431,
          -0.3634,  0.8279],
         [-2.1366,  0.4104,  0.8823,  1.3592,  2.0226, -2.2944, -0.3634,
           0.8279, -0.0448],
         [ 0.4104,  0.8823,  0.5543,  2.0226, -2.2944, -1.3409,  0.8279,
          -0.0448, -0.0296],
         [ 1.2258,  1.3592,  2.0226, -1.6431, -0.3634,  0.8279,  0.2688,
          -0.4359, -0.9921],
         [ 1.3592,  2.0226, -2.2944, -0.3634,  0.8279, -0.0448, -0.4359,
          -0.9921,  1.3234],
         [ 2.0226, -2.2944, -1.3409,  0.8279, -0.0448, -0.0296, -0.9921,
           1.3234, -0.6501]]])
```
when we do,
```
a = nn.Fold((5, 5), (3))
a(x)
```
then it gives,
```
tensor([[[[ -0.6498,   0.1913,   0.2362,  -1.1031,   1.2226],
          [  1.6814,  -8.5464,   2.4621,   3.5293,   1.1086],
          [  3.6775,   8.1553,  18.2035, -13.7661,  -4.0226],
          [ -3.2862,  -1.4536,   4.9672,  -0.1792,  -0.0592],
          [  0.2688,  -0.8718,  -2.9763,   2.6468,  -0.6501]]]])
```
overlapping values got added, like, ```0.0957*2``` gives ```0.1913```, ```0.0787*3``` gives ```0.2362``` and so on

expected scenario -
there is a mode option in nn.Fold, something like,
```
a = nn.Fold((5, 5), 3, mode='mul/sum/mean')
```
so that these variations of overlapping values could be obtained, or a custom function option, to manipulate overlapping values, for example, if user wants to not do ```mul/sum/mean``` but instead get overlapping value added by 1, or something like that.

cc @albanD @mruberry
Repository: terminal
Issue: Settings might not load correctly if file is saved as ANSI, not UTF-8 (WAS: No background image displayed if set to a path that contains accented chars.)
Labels: Help Wanted,Issue-Bug,Area-TerminalControl,Area-Settings,Product-Terminal,Priority-2

<!-- 
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed!
-->

<!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.

**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue.

If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link.

Please use this form and describe your issue, concisely but precisely, with as much detail as possible.

-->

# Environment

```none
Windows build number: 10.0.18363.836
Windows Terminal version (if applicable): 1.0.1401.0

Any other software? No.
```

# Steps to reproduce

<!-- A description of how to trigger this bug. -->
Set `$.profiles.defaults.backgroundImage` to a path that contains accented chars.
For example `Pictures` in Hungarian is `Képek`, so my path setting is like:
`"backgroundImage": "C:\\Users\\Gabor\\Képek\\picture.png"`

# Expected behavior

<!-- A description of what you're expecting, possibly containing screenshots or reference material. -->
The selected image is expected to be displayed as the background image.

# Actual behavior

<!-- What's actually happening? -->
No background image is dispayed as if I did not set `$.profiles.defaults.backgroundImage`.

**Please note:**
if the same image is in my `Desktop` directory which is `Asztal` in Hungarian (`"backgroundImage": "C:\\Users\\Gabor\\Asztal\\picture.png"`) then the picture is displayed correctly.
Repository: PowerToys
Issue: [KBM] Use Tab or Space as modifier key
Labels: Idea-Enhancement,Product-Keyboard Shortcut Manager

# Use Tab or Space as modifier key

Normally, only Shift, Alt, Ctrl are modifier keys. But if who is a fanboy of AutoHotKey will know the well-known mapping of using Tab or Space as modifier, especially to use Tab + W/A/S/D as arrow keys
Repository: rust
Issue: Audit uses of `skip_binder` in diagnostics code
Labels: C-cleanup,A-diagnostics,A-trait-system,T-compiler,T-types

As discussed in #71618, `skip_binder` is called very often in diagnostics code. In general, this is incorrect for types with late-bound regions, e.g. function pointers. We should audit uses of `skip_binder` and replace them with `no_bound_vars` + early return or `unwrap`. If there are uses of `skip_binder` that are benign, for example debug printing or comparing with a known type, we should abstract this behind a function to minimize the number of calls  to `skip_binder` that need to be checked.
Repository: PowerToys
Issue: [Run][Calculator Plugin] Add functions (bin2dec,hex2dec,oct2dec)
Labels: Idea-Enhancement,Product-PowerToys Run,Run-Plugin

<!--
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue.
-->

# Environment

```
Windows build number: 10.0.18363.836
PowerToys version: 0.18.1
PowerToy module for which you are reporting the bug (if applicable): Microsoft.Plugin.Calculator
```

# Steps to reproduce

<!-- A description of how to trigger this bug. -->

1. Open Launcher (alt+space)
2. write in the windows "hex2dec(20)"


# Expected behavior

<!-- A description of what you're expecting, possibly containing screenshots or reference material. -->
UI should show 32
# Actual behavior

<!-- What's actually happening? -->
UI showing nothing

# Screenshots

<!-- If applicable, add screenshots to help explain your problem. -->
![image](https://user-images.githubusercontent.com/2453522/82738476-81d66280-9d40-11ea-896b-225b597d0133.png)
Repository: excalidraw
Issue: Canvas background color is not synced in collaborative mode
Labels: bug,collaboration

Right now we only sync the elements in the drawing in collaborative mode. We also need to sync the background color from appState or figure out another way to do it.
Repository: rust
Issue: Consider making `cfg(feature = "crt-static")` available *only* for link-time configuration
Labels: A-linkage,C-enhancement,T-lang,T-compiler

`cfg` predicates used for link-time configuration (`#[link(cfg(predicate))]` https://github.com/rust-lang/rust/issues/37406 https://github.com/rust-lang/rust/issues/72059) may want to use data that is available only long after the regular `cfg` expansion happens.

For example,
- whether we are linking an executable or library (that's the case for `crt-static`)
- whether we use dynamic linking (in some sense) (that's the case for https://github.com/rust-lang/rust/issues/72241#issuecomment-633053281)

We can come up with some predicate value during regular `cfg` expansion, but it may be different from the predicate value that we really want at link time.

Is `cfg(feature = "crt-static")` ever used for regular `cfg` expansion?
It was created mostly with link-time configuration in mind.
We probably need to check it with crater.
Repository: rust
Issue: No warning when trait extension fn's conflict with pre-existing fn's
Labels: A-type-system,T-libs-api,C-bug,T-types

When trying to use a trait extension for the Result type, I found that calling code seemed to not be using my implemented methods at all. Turns out, I was defining `or(self, Self) -> Self`, which Result already has an implementation of - so any code calling a.or(b) was calling Result's `or`, not my `or`. I know this is why it's best practice to use a newtype in these situations, but it would be awesome to have a warning message or some sign that your traits impls aren't going to be used.

Repro code:

```rust
pub trait IntResultExt {
    fn or(self, then: Result<i32, ()>) -> Result<i32, ()>;
}

impl IntResultExt for Result<i32, ()> {
    fn or(self, then: Result<i32, ()>) -> Result<i32, ()> {
        match (self, then) {
            (Ok(l), Ok(r)) => Ok(l+r),
            _ => Err(())
        }
    }
}

fn main() {

    let a: Result<i32, ()> = Ok(1);
    let b: Result<i32, ()> = Ok(2);
    println!("{:?}", a.or(b)); // Expected Ok(3), got Ok(1)
}
```

([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=1d0de59cfd6c9ca2caa2b8763eb48306))
Repository: create-react-app
Issue: ES7 features support & export-ns-from support
Labels: tag: underlying tools

Is CRA planning to support this proposal from stage 4?
https://github.com/tc39/proposal-export-ns-from
Repository: TypeScript
Issue: Function parameter that has inferred type has no intellisense in the return , while it has in the rest of the function body
Labels: Bug

**TypeScript Version:**  3.9.2

**Search Terms:** generic , intellisense , infered type

**Code**:
```typescript
/*
This function will be used in javascript projects.
I want its intellisense to work in javascript projects.
*/
function component<T>(p: {
	actions : () => T,
	htmlTemplate: <S extends T>(actions : S) => any
}) {
	return p;
}

component({
	actions : () => ({
		a : (x,y) => x+y
	}),
	htmlTemplate : (actions) => { 
		/*try to dot into the actions and you will get intellisense*/ 
		actions;
		/*but if you dot here you will get no intellisense*/ 
		return actions;
		/*
		Intellisense appears in the `return actions` If I type `x` and `y`.
		Strangely it works if I explicitly type them with `any`
		but it does not work if I they are implicilty typed with `any` .
		How can I have no problem with intellisense with implicit `any`?
		*/
	}
})
```

**Expected behavior:** Implicit `any` should have the same effect on intellisense with explicit `any` .

**Actual behavior:** Implicit `any` is different from explicit `any` .

**Playground Link:** [link](https://www.typescriptlang.org/play?ts=3.9.2#code/PQKgUAKgFglgzgAgGYFcB2BjALjA9mhAdxgBsSEAjAUwRTioBMEYCArAQwDd24MAnGAAcsCQX1ysq2OADowASSLs0ImFkQssVMvCpp6CLLiK4+Aa2ZsuPfkJFiJU9XJDAwqTDnwIMuALaC+HpYADwQAHwAFIIAXAgA3mAAkOzYePoIcZEAlAgAvOEIEAA0yVBYfiQQVAEk7FpxIQDKCFQAHlpoDIgRkaleGXFNuQUIygCeYAC+uYlJfFRYKHwEggDc02BgvgFBKpFz-emIWSOFB8kpmQiRbcXjZwhtANSTSTOlSeWV1bX1NFkjvg4I94ghLqAsHxxoZjAxcKoVMYsFAaECMsomONcCgiKRyABzRaWLQ6ej6KiucFJFJpYEbGmgCgoVRIBDY3HwkSohbsnF4sgIIkiNDGTTaEi6ClUy4LJYrMZ0-QMpKgS7yFQSqUGdiCQRUdh8DQEFE0AAGcuWBHRcDNCHkbMUWHG+oQZradsxbvGZrkNKaUOURJIMLUJnMGkdrTagklGDUIcMLpopr8eJRbomZsuzNUInhVEQopEhFMFhgUdNMMNNBgtRg8ZIzqT+qYxAzZqzCD9SQAErhCD5lPaEFAuDRRaJxBQSDV01ASVryQZ2wu67GG2HO2gfQB+S6uZJTabZIA)
Repository: rust
Issue: Clarify stages of MIR pipeline, and make MIR lints consistent
Labels: C-cleanup,T-compiler,A-MIR

The [`rustc_mir::transform`](https://github.com/rust-lang/rust/blob/master/src/librustc_mir/transform/mod.rs) module defines the pipeline of analysis passes and transformations that  run on the MIR after it is lowered but before it is passed to codegen. However, it's not always clear whether certain invariants apply to each stage of the pipeline. For example, some terminators (`FalseEdges`, `DropAndReplace`) are removed entirely and do not appear beyond a certain point and the `Return` terminator, which initially appears only once in the entire MIR body may appear multiple times after the `generator` transform.

Additionally, it can be hard to find the right place for new error-emitting passes like the lint in #72270 or #71824. Is there a point at which the MIR is no longer meant for analysis but only for codegen? Should these be part of a specific query? Finally, the names of the `mir_*` queries have lost their meaning over time: `mir_const` can probably be removed entirely, and `optimized_mir` and `promoted_mir` should probably be renamed to `mir_optimized` and `mir_promoted_fragments_optimized` respectively.

I've listed quite a few issues above, but to resolve them I think we first need to figure out who the stakeholders are. Is there anyone who "owns" the current structure and has a clear idea of how things should look?
Repository: go
Issue: x/tools/gopls: consider using &S form instead of *S for pointer type struct field autocompletion
Labels: help wanted,NeedsDecision,gopls,Tools

Currently autocompletion for a struct field uses the field's type as the placeholder text. For example, 

```
type F struct {...}
type S struct {
   Field *F
}
```

The autocompletion for the `Field` will return `"newText":"Field: ${1:*F},"`.
`gopls` uses the type info for placeholder text, so I don't think the choice is incorrect nor invalid.

But if the suggestion used `&F` instead, it would be more convenient when users want to use  composite literals. Especially, if the type name is long to type, reusing what's already in the placeholder will save many keystrokes.

(Based on https://github.com/golang/vscode-go/issues/85)