sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: x/tools/gopls: add missing comma before newline in composite literal
Labels: FeatureRequest,gopls,Tools,Refactoring

Whenever it is detected that a comma is missing before a newline in a composite literal, is it possible to add it?

<img width="560" alt="image" src="https://github.com/golang/go/assets/12821762/f349fe4b-57dc-4e86-a307-57aac9737751">

Past issues for vscode-go:

* https://github.com/microsoft/vscode-go/issues/738
* https://github.com/microsoft/vscode-go/issues/818
Repository: go
Issue: proposal: database/sql: export convertAssign as DefaultConvertAssign
Labels: Proposal

As discussed in #24258 and #35697, but I think it would be nicer to have the exposed `sql.convertAssign()` function.
In the previous suggestion, @kardianos said at https://github.com/golang/go/issues/24258#issuecomment-383212538:

> I don't want the extra burden of maintaining convertAssign as a public API. I'm going to ask you either continue using the type assert or copy the one function out of database/sql and check on it every couple of years to see if you need to update it.

and @rsc also said as well at https://github.com/golang/go/issues/35697#issuecomment-572200894, i.e. they suggested doing copy the `sql.convertAssign()` to the user's project.
At the date of the first suggestion, Apr 20, 2018, copying was a good solution because that function hadn't accessed the unexposed value and functions; ref: https://github.com/golang/go/blob/da24c95ce09668a0d977c208e8e610a21b98b019/src/database/sql/convert.go
However, that function touches the unexported items in the current implementation; for example, https://github.com/golang/go/blob/9ac6b00e79312e5ad4665acc063ac7b77becddf8/src/database/sql/convert.go#L319-L347

I suppose this implies users have not been able to copy this function simply so copying would be no longer an effective way to satisfy the demand. Can we have a chance to reboot exposure for this `sql.convertAssign()` function?
Repository: go
Issue: proposal: os,os/user: stop special-casing Android and iOS in UserHomeDir and user.Current
Labels: OS-Android,Proposal,mobile,OS-iOS

The `android` GOOS is generally a special case of `linux`, and the `ios` GOOS is generally a special case of `darwin`.

However, the behavior of `os.UserHomeDir` on `android` and `ios` deviates from the standard behavior for `linux` and `darwin`.
- `android` was special-cased to return `/` in https://go.dev/cl/139717.
   - The commit message and code-review comments do not explain why, as far as I can tell, and no code comment was added explaining it either.
   - Its path was changed to `/sdcard` in https://go.dev/cl/169540 for #31070, to match an existing special case in `os/user`.
      - That special case was added in https://go.dev/cl/37960, with the explanation “return a dummy user instead of failing”. However, it did not explain why failing is not the _correct_ behavior in that configuration, as I would expect it to be — it seems like the code was changed to conform to an erroneous test, instead of changing the test to conform to the previously-correct(?) code.
- `ios` was special-cased to return `/` in https://go.dev/cl/141798.
   - The explanation given was that “The UserHomeDir test succeeds on the builder, but not when run
manually where HOME is set to the host $HOME.”
   - To me, that seems like a bug in the `exec` wrapper, not `os.UserHomeDir` — and, indeed, later (in https://go.dev/cl/167938) the wrapper was changed to avoid propagating `$HOME` to the device.

A month after the two special cases were added, the signature of `UserHomeDir` was changed to include an `error` return value (#28562). It seems to me that the special cases should have been removed at that point, but they weren't, and I think that was an oversight.

I propose that we add a `GODEBUG` guard for those special cases (mostly for a smoother version-based transition per #56986) and default `UserHomeDir` and `os/user.Current` on `android` and `ios` to be consistent with `linux` and `darwin` respectively as of the next Go version.

(CC @golang/android @golang/ios)
Repository: godot
Issue: Threaded resource loading can still cause stutters
Labels: bug,topic:core

### Godot version

4.2 dev3

### System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

### Issue description

I have a title screen with some big animation divided into multiple spritesheets. Only the first spritesheet is loaded with the scene, for other spritesheets I used threaded loading to make loading faster and also avoid stutters. Unfortunately it doesn't seem to help.  `ResourceLoader.load_threaded_get(current_loaded_texture)` specifically causes stutters (I do check for `THREAD_LOAD_LOADED`).

I attached MRP that displays the issue quite clearly. It's best observed in a non-dev build.

I think #79117 is similar, but it mentions `load_threaded_request()` instead.

### Steps to reproduce

1. Open the MRP
2. Run it
3. Notice that the animation (the camera movement) has stutters
4. Press any key to reload the scene. It's best to see it multiple times
5. In the main scene click the root Node and disable `use_textures`
6. Run the project again. `load_threaded_get()` is no longer called and the animation is smooth

### Minimal reproduction project

https://ufile.io/4ndknuqp
(the project was too big for direct upload)
Repository: godot
Issue: Can't export project with custom plugin that includes Firebase for iOS
Labels: bug,topic:thirdparty,topic:export

### Godot version

4.0 beta 12 and higher

### System information

Mac - v4.0-beta12_macos

### Issue description

I'm facing an error that occurres since v4.0-beta12. I created a custom iOS plugin that includes Firebase library. On previous versions of Godot the exporting tries were succesfuly despite of partial failing, logs:

```
ld: warning: Could not find or use auto-linked framework 'FBLPromises'
Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_FIRApp", referenced from:
      objc-class-ref in test.debug.a(godot_plugin.o)
  "_OBJC_CLASS_$_FIRMessaging", referenced from:
      objc-class-ref in test.debug.a(godot_plugin.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

** ARCHIVE FAILED **


The following build commands failed:
	Ld /Users/jakub/Library/Developer/Xcode/DerivedData/Export-dndyljeapgzjkcbrpcvtwfktyqpy/Build/Intermediates.noindex/ArchiveIntermediates/Export/InstallationBuildProductsLocation/Applications/Export.app/Export normal (in target 'Export' from project 'Export')
(1 failure)

xcodebuild (.ipa):
2023-08-19 00:21:36.143 xcodebuild[34375:408852] [MT] IDEDistribution: -[IDEDistributionLogging _createLoggingBundleAtPath:]: Created bundle at path "/var/folders/30/jfnv798n7dz54kfs1kxmbg_00000gn/T/Export_2023-08-19_00-21-36.143.xcdistributionlogs".
Exported Export to: /Users/jakub/GodotProjects/PluginTest/export
** EXPORT SUCCEEDED **
```

This operation was outputing a valid `.ipa` file that I was able to run in Xcode. I had to install required library by `pod`, and app was working as intended.
After version bump to 4.0 beta 12 a change was applied to the exporting script (#71212), that stops exporting on `** ARCHIVE FAILED **` (logs above). I have forked the engine, commented changed lines, compiled and it works like before.

Here is my question, how to handle this situation? Should I commit an update and create pull-request with added a checkbox in project settings like "Force export despite linking failure"? Any other ideas?

### Steps to reproduce

1. Create plugin with link to Firebase library
2. Compile plugin
3. Add plugin to project
4. Export project

### Minimal reproduction project

N/A
Repository: go
Issue: x/website: provide redirects from go.dev to pkg.go.dev for popular repository names
Labels: NeedsInvestigation,FeatureRequest,website

I tried to find the docs for chamber, a CLI tool, by typing "https://go.dev/github.com/segmentio/chamber" in a web browser. This returns a 404 - the URL I was looking for was "https://pkg.go.dev/github.com/segmentio/chamber".

It would be nice if "https://go.dev/github.com" and e.g. bitbucket, gitlab, other popular domains, redirected to https://pkg.go.dev. 

Someone with access to the web analytics should be able to easily verify whether this is a popular mistake or not.

Alternatively, if you don't want to redirect, you could add custom text to the 404 page saying 

> Did you mean https://pkg.go.dev/(your url)
Repository: vscode
Issue: Allow for quickpick section header to have full height without a button
Labels: feature-request,quick-pick


![Image](https://github.com/microsoft/vscode/assets/31675041/70cb199c-f961-4bee-b489-34b1adb7960b)


I would like to have a section header like this, but without the need to have a button. I think that this header stands out more, so it's nice to have (even if you don't have a button for your header).
Repository: next.js
Issue: Client components are not being pre-rendered on the server (With `useSearchParams`) App Router
Labels: bug

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
      Platform: darwin
      Arch: x64
      Version: Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:52 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T8103
    Binaries:
      Node: 18.14.0
      npm: 9.3.1
      Yarn: 1.22.18
      pnpm: N/A
    Relevant Packages:
      next: 13.4.18
      eslint-config-next: 13.4.18
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.6
    Next.js Config:
      output: N/A
```


### Which area(s) of Next.js are affected? (leave empty if unsure)

App Router

### Link to the code that reproduces this issue or a replay of the bug

https://github.com/JuandaGarcia/pre-rendering-bug-nextjs

### To Reproduce

1. Download the code from the repository [https://github.com/JuandaGarcia/pre-rendering-bug-nextjs](https://github.com/JuandaGarcia/pre-rendering-bug-nextjs)
2. Run `npm install`, `npm run build` and `npm start` in the project
3. Go to the browser `http://localhost:3000/`
4. Go to the source code of the page and note that none of the elements have been prerendered

![Group 4](https://github.com/vercel/next.js/assets/39936759/61c2d813-2ae9-4270-83f9-cc4708d87629)


### Describe the Bug

When the application is compiled with `npm run build` and executed with `npm start`, the client components with the `useSearchParams` hook are not being rendered on the server, so all rendering responsibility is delegated to the client. This does not happen in development mode with `npm run dev`

### Expected Behavior

You would expect all elements to be pre-rendered just like you do in development mode with `npm run dev`

![Group 5](https://github.com/vercel/next.js/assets/39936759/b628fd65-b482-4d41-b655-f033c5804d96)

It is also what the documentation promises

![image](https://github.com/vercel/next.js/assets/39936759/09461758-67fa-446a-907d-4830c0c253c2)


### Which browser are you using? (if relevant)

_No response_

### How are you deploying your application? (if relevant)

_No response_
Repository: flutter
Issue: [Shortcuts] Support prefix keys
Labels: c: proposal,P2,team-text-input,triaged-text-input

### Is there an existing issue for this?

- [X] I have searched the [existing issues](https://github.com/flutter/flutter/issues)
- [X] I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)

### Use case

Desktop apps often support keyboard shortcuts "chords" with multiple separate keypresses. Examples:

1. Visual Studio Code: `Ctrl+K` `Ctrl+O` opens a folder
2. Gmail: `g` `i` goes to the inbox

### Proposal

Add a new `ShortcutActivator` to support this. Strawman example:

```dart
// Activated by Ctrl+K followed by Ctrl+O
const openFolderActivator = ChordActivator(
  activators: <ShortcutActivator>[
    SingleActivator(LogicalKeyboardKey.keyK, control: true),
    SingleActivator(LogicalKeyboardKey.keyO, control: true),
  ],
);

return Shortcuts(
  shortcuts: const <ShortcutActivator, Intent>{
    openFolderActivator: OpenFolderIntent(),
  },
  child: ...,
);
```
Repository: TypeScript
Issue: Compiler API: allow retrieving Symbols for anonymous function and classes
Labels: Suggestion,In Discussion

### 🔍 Search Terms

"compiler api anonymous"
"anonymous getSymbolAtLocation"


### ✅ Viability Checklist

- [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
- [X] This wouldn't change the runtime behavior of existing JavaScript code
- [X] This could be implemented without emitting different JS based on the types of the expressions
- [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- [X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

### ⭐ Suggestion

Today when working with AST tree it's convenient to retrieve Symbols of function/classes/variables and use them to represent program "entities". For named function and classes Symbol can be retrieved from a node using `typeChecker.getSymbolAtLocation(node.name)`. Unfortunately for anonymous nodes there doesn't seem to be a way to get Symbol. Even though Symbol is present on the Node object but it's not in public API.

Additionally mentally it's easier to assume that all functions, classes and variables have Symbols.

This is similar to https://github.com/microsoft/TypeScript/issues/26511 

Example using ts-ast-viewer:
![image](https://github.com/microsoft/TypeScript/assets/252053/c8f0efaa-fe8e-456c-b497-b3836b2465c7)


### 📃 Motivating Example

No motivating example really. It's pretty niche compiler API improvement that makes working with Compiler more consistent and helps to avoid implementing workarounds.

### 💻 Use Cases

1. What do you want to use this for?
It's needed for proper implementation of TS indexer in kythe.io.

2. What shortcomings exist with current approaches?
Code indexing is built around having Symbols. Places where Symbol is possible to retrieve using public API (e.g. anonymous functions) require hacks or introducing custom symbol-like entity.

3. What workarounds are you using in the meantime?
Acessing internal `Node.symbol` property.
Repository: flutter
Issue: `TextField` ignores the `buildCounter` arg, if `decoration` is `null`, so why not move the `buildCounter` parm to `InputDecoration`
Labels: a: text input,framework,f: material design,c: proposal,P3,team-design,triaged-design

hi,

From the source code of `TextField`, i discovered the info mentioned in the title.

thanks
Repository: rust
Issue: FCP process: Require 2/3 majority for FCP
Labels: T-lang,T-libs-api,T-release,T-opsem

This issue suggests we accept the PR at https://github.com/rust-lang/rfcbot-rs/pull/315, which fixes https://github.com/rust-lang/rfcbot-rs/issues/293. I propose we do this via FCP of the affected teams.

The summary is that for teams of size 5, currently 3 checkboxes are enough to consider the FCP as passed; the change is to require 4 checkboxes instead. Formally, the requirement for entering the 10-day period changes from "more than half the members" to "at least two thirds of the members" (and at most two outstanding boxes, as before).
Repository: next.js
Issue: generateStaticParams with dynamicParams false does not show not-found page on production
Labels: bug

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 22.5.0: Thu Jun  8 22:22:20 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6000
    Binaries:
      Node: 18.17.0
      npm: 9.6.7
      Yarn: N/A
      pnpm: 8.6.9
    Relevant Packages:
      next: 13.4.19
      eslint-config-next: 13.4.18
      react: undefined
      react-dom: undefined
      typescript: 5.1.6
    Next.js Config:
      output: N/A
```


### Which area(s) of Next.js are affected? (leave empty if unsure)

_No response_

### Link to the code that reproduces this issue or a replay of the bug

https://github.com/smitbarmase/rapp

### To Reproduce

Navigate to `http://localhost:3000/blog/4`, which is not path in generateStaticParams.

### Describe the Bug

On prod, it shows server error in my private repository. On dev, in this repository, it does not render not-found page.

### Expected Behavior

It should render closest not-found in tree.

### Which browser are you using? (if relevant)

Chrome

### How are you deploying your application? (if relevant)

Vercel
Repository: neovim
Issue: Implement `--remote-wait`
Labels: enhancement,remote

### Problem

`:h --remote-wait` says "Not yet supported by Nvim".

### Expected behavior

`--remote-wait` is supported by Nvim.

(Can't use `neovim --remote` as git editor, since the invocation immediately terminates after launching the remote instance, yielding "Aborting commit due to empty commit message.")
Repository: node
Issue: writableStream.destroy() closes the underlying file even when stream is created with {autoClose: false, emitClose: false}
Labels: stream

### Version

v18.17.1, v20.5.1

### Platform

Linux 6.4.10-200.fc38.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Aug 11 12:20:29 UTC 2023 x86_64 GNU/Linux

### Subsystem

fs, stream

### What steps will reproduce the bug?

Minimal program to reproduce.

Create 2 writeStreams from a `FileHandle` with `{autoClose: false, emitClose: false}` options.  Write some data to the first stream and destroy it. Try to write some data to the second stream.

```javascript
import { open } from 'node:fs/promises'
import { pipeline } from 'node:stream/promises'

async function main() {
    const destFile = await open('test.tmp', 'w')
    destFile.truncate(1024)
    const stream0 = destFile.createWriteStream({start: 0, autoClose: false, emitClose: false})
    const stream1 = destFile.createWriteStream({start: 512, autoClose: false, emitClose: false})
    stream0.on('error', (err) => { console.log('stream0 error', err) })
    await pipeline("Hello world from stream0", stream0)
    stream0.destroy(new Error('destroyed'))
    try {
        await pipeline("Hello world from stream1", stream1) // emits ERR_STREAM_WRITE_AFTER_END
    } finally {
        // destFile.fd is -1 here
        destFile.close()
    }
}

await main()
```

### How often does it reproduce? Is there a required condition?

_No response_

### What is the expected behavior? Why is that the expected behavior?

Data is written, FileHandle is not closed up until `close()` call because `emitClose: true` is specified on stream creation.

### What do you see instead?

ERR_STREAM_WRITE_AFTER_END is emmited when trying to write to the `steream1`. `destFile.fd` is set to -1.

### Additional information

_No response_
Repository: three.js
Issue: Generalize instanced attributes
Labels: Suggestion

### Description

Currently there are two instanced attributes which get a special treatment from the engine: `instanceColor` and `instanceMatrix`:

```js
        var geometryAttribute = geometryAttributes(name)
        if (geometryAttribute == undefined) {
          if (name == "instanceMatrix" && `object`.instanceMatrix) geometryAttribute = `object`.instanceMatrix
          if (name == "instanceColor" && `object`.instanceColor) geometryAttribute = `object`.instanceColor
        }
```

I think it would be possible to make this more flexible by allowing any custom attributes present in `InstancedMesh` to get the same treatment.


### Solution

The code above should be changed to:
```js
        var geometryAttribute = geometryAttributes(name)
        if (geometryAttribute == undefined) {
          if (name == "instanceMatrix" && `object`.instanceMatrix) geometryAttribute = `object`.instanceMatrix
          if (name == "instanceColor" && `object`.instanceColor) geometryAttribute = `object`.instanceColor
          if (`object`.attributes.has(name)) geometryAttribute = `object`.attributes.get(name)
        }
```

The member attributes would be added into `InstancedMesh`.

### Alternatives

At the moment one can either abuse `instanceColor` if not needing it for coloring, or provide custom attributes in the geometry, which means for different instancing chains the geometry has to be cloned.

### Additional context

For simplicity I suggest keeping current `instanceMatrix` and `instanceColor` as they are, but perhaps they could also be moved to the `attributes` and the code handling them would become simple:

```js
        var geometryAttribute = geometryAttributes(name)
        if (geometryAttribute == undefined) {
          if (`object`.attributes.has(name)) geometryAttribute = `object`.attributes.get(name)
        }
```

This needs some more though, so that backward compatibility is maintained.
Repository: flutter
Issue: Request to Make Handle Navigation Invocation Method Public for Improved Compatibility
Labels: c: new feature,framework,f: routes,c: proposal,P3,team-framework,triaged-framework

### Is there an existing issue for this?

- [X] I have searched the [existing issues](https://github.com/flutter/flutter/issues)
- [X] I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)

### Use case

Description:
Current method name "_handleNavigationInvocation" in Flutter source code should be updated to "handleNavigationInvocation". This change is necessary to ensure proper compatibility with method reassignment "SystemChannels.navigation.setMethodCallHandler" because it requires the method name to match.

The problem is that it is important to highlight that the SystemChannels.navigation.setMethodCallHandler method plays a critical role in facilitating deep link functionality. It has been determined that the Go Router deep connection feature does not work, especially when the SystemChannels.navigation.setMethodCallHandler method is changed after WidgetBinding init. This highlights the urgent need to maintain unwavering consistency in method call to ensure seamless functionality.

Expected Behavior:
After this change, the method After the SystemChannels handler is changed, it can be changed back to the default handler and this will ensure that the deeplink does not get errors.

Impact:
This change will positively impact Flutter applications that rely on the navigation mechanism, ensuring that they can seamlessly adapt to future changes in the Flutter framework.

### Proposal

Given that the necessary method is currently defined as private within the Flutter source code, packaging this change as a separate package on pub.dev/flutter might not be a feasible option. Private methods are intended for internal use within a specific codebase and are not exposed to external packages.