sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: [web] Remove multi-Surface rendering for Firefox and Safari once they have efficient support for `transferToImageBitmap`/`transferFromImageBitmap`
Labels: c: performance,c: rendering,e: web_canvaskit,browser: safari-macos,browser: firefox,P2,dependency: firefox,browser: safari-ios,e: web_skwasm,team-web,triaged-web

### Use case

Flutter Web has adopted a rendering strategy making use of an `OffscreenCanvas` which acts as a WebGL surface for Skia to render to. The rendering is then displayed to the user by calling `transferToImageBitmap` to create a `BitmapImage` from the contents of the `OffscreenCanvas`, and then by calling `transferFromImageBitmap` on a `bitmaprenderer` canvas in the DOM, which is shown to the user. There may be more than one `bitmaprenderer` canvas (for example, if there are platform views in the Flutter scene which require overlay canvases), but there is only one `OffscreenCanvas` (and therefore only one WebGL context). Having only a single WebGL context allows Flutter Web to eliminate an entire class of bugs arising from improperly copying GL resources between more than one GL context.

Using `transferToImageBitmap`/`transferFromImageBitmap` is very fast on Chrome, since it just uses a texture saved on the GPU to transfer the rendering from the `OffscreenCanvas` to the `bitmaprenderer` canvas. However, on Firefox and Safari, calling `transferToImageBitmap` is significantly slower, because `transferToImageBitmap` incurs a very expensive call to read all of the pixels in the canvas to create the bitmap image. In practice, this made rendering using `transferToImageBitmap` untenable on Firefox and Safari since it caused considerable jank. So, on Firefox and Safari we have to fall back on an old (and bug-prone) rendering strategy using many WebGL-backed canvases.

### Proposal

This issue tracks the bugs in Firefox and Safari, which are aware of the performance issues with `transferToImageBitmap` and working on addressing them.

Firefox issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1788206

Safari issue: https://bugs.webkit.org/show_bug.cgi?id=234920 and https://bugs.webkit.org/show_bug.cgi?id=267291

Once the performance issues are addressed in Firefox and Safari, we can remove the alternate multi-surface rendering strategy and keep only the `OffscreenCanvas`-based strategy.
Repository: rust
Issue: Tracking Issue for `Vec::pop_if`
Labels: T-libs-api,proposed-final-comment-period,C-tracking-issue,disposition-merge

Feature gate: `#![feature(vec_pop_if)]`

This feature adds the `Vec::pop_if` method, which takes a predicate, evaluates it with the last element in the `Vec` if present, and returns the item if the predicate returns `true`. This makes it possible to conditionally remove the last element without the use of `unwrap`.

### Public API

```rust
impl<T> Vec<T> {
    pub fn pop_if(&mut self, f: impl FnOnce(&mut T) -> bool) -> Option<T>;
}
```

### Steps / History

- [X] ACP: https://github.com/rust-lang/libs-team/issues/208
- [x] Implementation: #123107
- [ ] Final comment period (FCP)[^1]
- [ ] Stabilization PR

<!--
Once the feature has gone through a few release cycles and there are no
unresolved questions left, the feature might be ready for stabilization.

If this feature didn't go through the RFC process, a final comment period
(FCP) is always needed before stabilization. This works as follows:

A library API team member can kick off the stabilization process, at which point
the rfcbot will ask all the team members to verify they agree with
stabilization. Once enough members agree and there are no concerns, the final
comment period begins: this issue will be marked as such and will be listed
in the next This Week in Rust newsletter. If no blocking concerns are raised in
that period of 10 days, a stabilization PR can be opened by anyone.
-->

### Unresolved Questions

<!--
Include any open questions that need to be answered before the feature can be
stabilised. If multiple (unrelated) big questions come up, it can be a good idea
to open a separate issue for each, to make it easier to keep track of the
discussions.

It's useful to link any relevant discussions and conclusions (whether on GitHub,
Zulip, or the internals forum) here.
-->

- [X] Do we want a `VecDeque::pop_front_if` and `VecDeque::pop_back_if` API under this as well?
    - Separate tracking issue: https://github.com/rust-lang/rust/issues/135889

[^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html
Repository: rust
Issue: Tracking Issue for `Vec::peek_mut`
Labels: T-libs-api,C-tracking-issue

<!--
Thank you for creating a tracking issue!

Tracking issues are for tracking a feature from implementation to stabilization.

Make sure to include the relevant RFC for the feature if it has one.

If the new feature is small, it may be fine to skip the RFC process. In that
case, you can use `issue = "none"` in your initial implementation PR. The
reviewer will ask you to open a tracking issue if they agree your feature can be
added without an RFC.
-->

Feature gate: `#![feature(vec_peek_mut)]`

This feature adds `Vec::peek_mut`, which returns a `PeekMut` struct. It is analogous to `[BinaryHeap::peek_mut]` and enables users to conditionally modify and remove the last element of a `Vec` without having to call `unwrap`.

[BinaryHeap::peek_mut]: https://doc.rust-lang.org/std/collections/struct.BinaryHeap.html#method.peek_mut

### Public API

```rust
impl<T> Vec<T> {
    pub fn peek_mut(&mut self) -> Option<PeekMut<'_, T>>;
}

pub struct PeekMut<'a, T>;

impl<'a, T> PeekMut<'a, T> {
    pub fn pop(self) -> T;
}

// impl `Deref`/`DerefMut` for `PeekMut`
```

### Steps / History

<!--
For larger features, more steps might be involved.
If the feature is changed later, please add those PRs here as well.
-->

- [X] ACP: https://github.com/rust-lang/libs-team/issues/208
- [ ] Implementation: pending
- [ ] Final comment period (FCP)[^1]
- [ ] Stabilization PR

<!--
Once the feature has gone through a few release cycles and there are no
unresolved questions left, the feature might be ready for stabilization.

If this feature didn't go through the RFC process, a final comment period
(FCP) is always needed before stabilization. This works as follows:

A library API team member can kick off the stabilization process, at which point
the rfcbot will ask all the team members to verify they agree with
stabilization. Once enough members agree and there are no concerns, the final
comment period begins: this issue will be marked as such and will be listed
in the next This Week in Rust newsletter. If no blocking concerns are raised in
that period of 10 days, a stabilization PR can be opened by anyone.
-->

### Unresolved Questions

- Should this be named `peek` or `peek_mut`?

[^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html
Repository: stable-diffusion-webui
Issue: [Bug]: New Gallery icons (refresh, tree view, folder with magnifying lens, ...) are not present in offline mode
Labels: bug-report

### Checklist

- [X] The issue exists after disabling all extensions
- [X] The issue exists on a clean installation of webui
- [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
- [X] The issue exists in the current version of the webui
- [X] The issue has not been reported before recently
- [ ] The issue has been reported before but has not been fixed yet

### What happened?

The new Gallery icons (refresh, tree view, folder with magnifying lens, ...) don't show up in offline mode. Buttons are empty, they still work.

(nice improvement btw, the tree view keep shutting down if you move out from the tab but I guess it is still WIP)

### Steps to reproduce the problem

offline mode

### What should have happened?

icons should be visible

### What browsers do you use to access the UI ?

Other

### Sysinfo

1

### Console logs

```Shell
1
```


### Additional information

_No response_
Repository: pytorch
Issue: support QAT fusion for conv transpose + bn + relu
Labels: oncall: quantization

### 🚀 The feature, motivation and pitch

support QAT fusion for conv transpose + bn + relu

### Alternatives

_No response_

### Additional context

_No response_

cc @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel
Repository: vscode
Issue: [linked rename] HTML doesn't rename or auto-fill non-ASCII tags
Labels: bug,editor-synced-region

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.87.2
- OS Version: Windows 11

Steps to Reproduce:

1.  Define a HTML tag with a non-ascii character in CSS 
```html
<html>
   <head>
	<style>
        cliché { /* é is non-ASCII*/
            font-size: 100PX;
            font-family: monospace;
        }
	</style>
    </head>
	<body>
		<cliché>Looks illegal but itꞌs valid</clich> <!-- clich is autofilled instead of cliché -->
	</body>
</html>
```
2.  Type `<cliché>`, you get `<cliché>Text</clich>`.
Repository: rust
Issue: Unable to see through associated type with where clause on GAT
Labels: A-trait-system,A-associated-items,T-compiler,C-bug,fixed-by-next-solver,A-GATs

Ran into an issue when using GATs with a where clause. I wasn't able to find an existing issue, although I swear I've seen something similar reported before - apologies if this is a duplicate.

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=84875b21dcdc81ddc2e1526c2e9b6cc5

It looks like the `Self::Output` type isn't realized early enough? Ran with latest stable and nightly. This does work with the next trait solver. I feel like this can be reduced further, but I was unable to do so.
Repository: pytorch
Issue: [Inductor][Triton] test_mixed_mm2_cuda fails on Hopper
Labels: needs reproduction,triaged,bug,oncall: pt2,module: inductor,upstream triton

### 🐛 Describe the bug

We are seeing some segfault failures on Hopper GPUs on all Triton 3.0.0 versions:

`pytorch_triton-3.0.0+989adb9a29`:
```python
python test/inductor/test_torchinductor.py -v -k test_mixed_mm2_cuda
test_mixed_mm2_cuda (__main__.GPUTests) ... python: /source/llvm-project/mlir/lib/IR/TypeRange.cpp:20: mlir::TypeRange::TypeRange(ArrayRef<mlir::Type>): Assertion `llvm::all_of(types, [](Type t) { return t; }) && "attempting to construct a TypeRange with null types"' failed.
```

`pytorch_triton-3.0.0+a9bc1a3647`:
```python
python test/inductor/test_torchinductor.py -v -k test_mixed_mm2_cuda
test_mixed_mm2_cuda (__main__.GPUTests) ... [d8aa2091f3fe:962  :0:962] Caught signal 11 (Segmentation fault: Sent by the kernel at address (nil))
```

`pytorch_triton-3.0.0+901819d2b6`
```python
python test/inductor/test_torchinductor.py -v -k test_mixed_mm2_cuda
test_mixed_mm2_cuda (__main__.GPUTests) ... [d8aa2091f3fe:1275 :0:1275] Caught signal 11 (Segmentation fault: invalid permissions for mapped object at address 0x7f745aeec067)
```

### Versions

PyTorch version: 2.4.0a0+git0d845f7b
NVIDIA H100 80GB

cc @ezyang @msaroufim @bdhirsh @anijain2305 @zou3519 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire
Repository: ui
Issue: [Bug]: input-otp trigger only number keypad with chars pattern included
Labels: bug

### Describe the bug

though patterns included with chars  as prop for the input otp component,in mobile devices only number keypad is triggered not the char key board 

### Affected component/components

input-otp

### How to reproduce

1. Include input-otp component 
2. run the code using simulators for mobile devices
3. we observe that num keypad is triggered

### Codesandbox/StackBlitz link

_No response_

### Logs

_No response_

### System Info

```bash
It will be a issues in all browsers
```


### Before submitting

- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues
Repository: next.js
Issue: Auto scroll to Page content on Link click when Layout content takes up full height of viewport
Labels: bug

### Link to the code that reproduces this issue

https://github.com/xvvvyz/scroll-bug-repro

### To Reproduce

0. Clone repro repo
1. Click on auto-scroll link

https://github.com/vercel/next.js/assets/2367158/8aec2d49-3dfc-43b2-8569-dd9095a01455

### Current vs. Expected behavior

I expect the "Auto-scroll" link to behave like the "No auto-scroll" link when clicked.

### Provide environment information

```bash
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 23.4.0: Wed Feb 21 21:44:06 PST 2024; root:xnu-10063.101.15~2/RELEASE_ARM64_T8103
  Available memory (MB): 8192
  Available CPU cores: 8
Binaries:
  Node: 20.11.1
  npm: 10.2.4
  Yarn: N/A
  pnpm: N/A
Relevant Packages:
  next: 14.2.0-canary.31 // Latest available version is detected (14.2.0-canary.31).
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.1.3
Next.js Config:
  output: N/A
```


### Which area(s) are affected? (Select all that apply)

App Router

### Which stage(s) are affected? (Select all that apply)

next dev (local), next build (local), next start (local), Vercel (Deployed)

### Additional context

_No response_
Repository: godot
Issue: Unused parameters show underscore prefix in documentation
Labels: discussion,topic:gdscript,topic:editor,documentation

### Tested versions

v4.3.dev5.official

### System information

Windows 11, v4.3.dev5.official

### Issue description

When creating a virtual function in a base class, Godot creates a warning that parameters are unused and suggests prefixing them with `_`. However in the class' documentation the parameters include those underscores, which doesn't follow convention.

### Steps to reproduce

Add this function to any class:
```gdscript
func _my_virtual_function(_unused: int) -> void:
	pass
```
Check the class' documentation and see the parameter is named `_unused`.

### Minimal reproduction project (MRP)

N/A
Repository: stable-diffusion-webui
Issue: [Bug]: can't find the preprocess Tab
Labels: bug-report

### Checklist

- [ ] The issue exists after disabling all extensions
- [x] The issue exists on a clean installation of webui
- [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
- [x] The issue exists in the current version of the webui
- [x] The issue has not been reported before recently
- [ ] The issue has been reported before but has not been fixed yet

### What happened?

I wanted to Train an embedding after having pulled the newest version, but I can't find the preprocess tab.
I made a new install and the issue is still there.
![a](https://github.com/AUTOMATIC1111/stable-diffusion-webui/assets/83953324/15306daa-f9e3-4d3d-a22c-605aee709c01)



### Steps to reproduce the problem

I don't know.

### What should have happened?

I should have been able to find it.

### What browsers do you use to access the UI ?

Mozilla Firefox

### Sysinfo

[sysinfo-2024-03-19-21-50.json](https://github.com/AUTOMATIC1111/stable-diffusion-webui/files/14657230/sysinfo-2024-03-19-21-50.json)


### Console logs

```Shell
I don't have one
```


### Additional information

_No response_
Repository: flutter
Issue: Add the `shared_preferences_tools` extension to the `shared_preferences` package
Labels: c: new feature,p: shared_preferences,package,c: proposal,team-ecosystem,P2,triaged-ecosystem

A DevTools extension for the `shared_preferences` package has been published as `package:shared_preferences_tools`: https://pub.dev/packages/shared_preferences_tools.

To bring the most value to users of the `shared_preferences` package, we should consider moving this extension into the package it is intended to be used with (`package:shared_preferences`).

Accompanying issue on the `shared_preferences_tools` repo: https://github.com/adsonpleal/shared_preferences_tools/issues/2
Repository: flutter
Issue: Tappable/clickable semantic nodes should have reasonable fallback role
Labels: framework,a: accessibility,P2,team-framework,triaged-framework

Some framework widgets, such as [ExpansionTile](https://github.com/flutter/flutter/issues/143852) and `Tab` (via [InkWell](https://github.com/flutter/flutter/blob/5c54509ad90ae7d9242a7baa1a43e6eeed9eaa75/packages/flutter/lib/src/material/ink_well.dart#L1327)), and widgets authored by developers, would add a tap action to their respective semantics node, but would not pick a concrete role for the node, such as button, checkbox, radiobox, text field, combobox, link, etc.

On the web this translates to an element with a `click` event listener but without an ARIA `role` attribute. Some screen readers would look for the listener and say "double-tap to activate" (or whatever is appropriate for the form factor of the device). Some will not communicate that the node is interactive (https://github.com/flutter/flutter/issues/143852), prompting custom solutions such as [this](https://github.com/flutter/flutter/blob/4d5e675253f21e6405bc325e17cca5221c1d654b/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart#L7642).

## Proposal

When a tap action is present the framework always assigns a role to the node. If the developer does not specify one, the framework fallback to the most reasonable default (e.g. "button"). For the cases where it's preferable to communicate the role using a custom hint (like in the `ExpansionTile` case) we introduce a special role for that, in which case the engine would know that the role is communicated using means other than the ARIA role.

Taking this proposal to extreme, perhaps we should introduce a formal concept of "role" in the semantics tree. Currently the role is described using various flags that the engine pattern-matches on to assign it a formal role internally. [Here's how the web engine does it](https://github.com/flutter/engine/blob/dce639a4c453bc5682a630918b7606567243059e/lib/web_ui/lib/src/engine/semantics/semantics.dart#L1577). A formal role enum could improve the following:

- Remove the guesswork from the engine.
- All engine implementations would be in agreement about what role a particular semantics node plays.
- Enable better validation/testing of nodes. For example, should a checkbox have the `paste` action?
- Allow the engine to pick the best fallback when there platform does not directly support a role. Let's say we want to have a special role for `Tab`. ARIA does not define a formal "tab" role. However, there might be a combination of ARIA attributes that approximate it quite well. Right now, there's no way to tell if something is a tab, and the web engine just falls back to `GenericRole` that's also used for paragraphs of static text (which also doesn't have a role, and is pattern-matched onto "leaf node with a label").
Repository: godot
Issue: Sprite2d Inspector Animation frame flickering
Labels: bug,topic:rendering,topic:editor,topic:animation

### Tested versions

- Reproduceable in 4.2.1

### System information

Windows 10 - Godot 4.2.1

### Issue description

Using 4.2.1 Godot and downloaded tutorial https://github.com/ChrisTutorials/SidescrollerQuickstart-StateMachine-AnimationTree

Tried following the tutorial and it did the same thing. Initially I thought it was cause it's a different version but even following it had the same issue despite being able to have everything the same on latest version. 

Sprite2d > Inspector > Animation frame fields flickering

### Steps to reproduce

Download github tutorial and view Sprite2d > Inspector > Animation frame fields flickering

https://jmp.sh/s/ZqwlgPKZrgvSk3GAMRLU

### Minimal reproduction project (MRP)

https://github.com/ChrisTutorials/SidescrollerQuickstart-StateMachine-AnimationTree
Repository: transformers
Issue: Add option to not re-load the model when resuming from checkpoint.
Labels: trainer,Feature request

### Feature request


I'd like to have the option to get the trainer to resume_from_checkpoint *without* reloading the model.

I propose adding a boolean option parameter:  `without_checkpoint_model: bool = False`.

Starting from a checkpoint with this parameter set to True would require that the model was supplied to the Trainer constructor (pretty standard practice anyway) and would simply skip this line of code in the Trainer:
`self._load_from_checkpoint(resume_from_checkpoint)`



@muellerzr , @pacman100, @amyeroberts 


### Motivation

When Trainer.train(resume_from_checkpoint=my_checkpoint) is called, the Trainer will attempt to re-load the model in the my_checkpoint directory during the resumption process.

This is kind of wasteful but no big tragedy if the model in question in fully supported by Trainer.
Right now, Trainer needs to know how to reload a model before it can be used with resume_from_checkpoint.

This was (and may be still) a big problem for QLoRA model users who had to spend quite some time waiting for Trainer to be modified to specifically support re-loading QLoRA models.  One could train these models from scratch just fine by loading them first and supplying them to the Trainer constructor, it was just impossible to resume_from_checkpoint with them.

It looks like there is supposed support for resuming with QLoRA added very recently but then some folks complaining that it does not actually work in practice:

- https://github.com/huggingface/transformers/issues/29607
- https://github.com/huggingface/transformers/issues/29383

But even if QLoRA reloading does work today or will soon, there is a wider problem.

In general, whenever there is a new model type that the Trainer does not explicitly know how to load, it will be impossible to resume_from_checkpoint for that kind of model until support is added to Trainer for loading that type of model.
Lots of new kinds of quantization and LoRA initialization methods are being invented all the time (e.g LoftQ).  Do we really want to prevent their adoption because it takes time to adapt Trainer to intrinsically know how to load every kind of model under the sun?

We might do well to just provide folks a way to work around that without having to fork transformers and then use their patched fork (like I've been doing).

Really, since the Trainer can be instantiated with the fully restored checkpoint, there is no reason why the train() call should force re-loading the model from the checkpoint.


### Your contribution

I've already got a POC implementation in my fork which I've pretty thoroughly integration tested, having resumed  QLoRA training from checkpoint with it dozens of times.

https://github.com/stevemadere/transformers/commit/5c2a1c8200392abfb268fc7407121de605fc7a33

PR incoming.