Repository: vscode
Issue: "Check for Update" does not behave as expected
Labels: feature-request


Issue Type: <b>Bug</b>

Checking for updates does not behave as expected.

Set Preferences -> Settings -> Application -> Update to Manual. After restarting (WHY?) a new menu item appears, Code -> Check for Upates... . Selecting this, one expects the app to check for updates and reporrt whether an update is available -- "check for updates." But instead, if an update is available, it immediately starts downloading. The user should be given an option to begin the download only after learning if an update is available--maybe the user doesn't want to do the update immediately. A further problem, there is no indication when the update is finished downloading other than checking the menu again--there should be an alert dialog to communicate this fact.

VS Code version: Code 1.62.0 (b3318bc0524af3d74034b8bb8a64df0ccf35549a, 2021-11-03T15:24:41.297Z)
OS version: Darwin x64 15.6.0
Restricted Mode: No

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM)2 Duo CPU     P8600  @ 2.40GHz (2 x 2400)|
|GPU Status|2d_canvas: unavailable_software<br>gpu_compositing: disabled_software<br>metal: disabled_off<br>multiple_raster_threads: disabled_off<br>oop_rasterization: disabled_off<br>opengl: disabled_off<br>rasterization: disabled_software<br>skia_renderer: disabled_off_ok<br>video_decode: disabled_software<br>webgl: unavailable_software<br>webgl2: unavailable_software|
|Load (avg)|30, 11, 6|
|Memory (System)|8.00GB (0.04GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (50)</summary>

Extension|Author (truncated)|Version
---|---|---
lua-debug|act|1.50.1
ada|Ada|23.0.1
Bookmarks|ale|13.2.2
pascal|ale|9.3.0
pascal-formatter|ale|2.5.0
project-manager|ale|12.4.0
rtf|ale|2.4.0
octave-hacking|apj|0.2.12
vscode-svgviewer|css|2.0.0
vscode-mac-color-picker|dae|1.0.2
textpad-icon-theme|dam|1.19.21
vscode-markdownlint|Dav|0.45.0
vscode-great-icons|emm|2.1.79
ada-snippets|Ent|0.3.0
vscode-faust|gle|1.1.0
vscode-lyx|gyt|0.0.4
fortran-ls|han|0.6.2
latex-workshop|Jam|8.22.0
svn-scm|joh|2.15.0
language-julia|jul|1.5.4
keen-neutral-icon-theme|kee|1.0.8
linter-gfortran|krv|2.6.0
octave|lea|0.1.1
eps-preview|mkv|0.1.0
python|ms-|2021.11.1422169775
vscode-pylance|ms-|2021.11.1
jupyter|ms-|2021.10.1101450599
jupyter-keymap|ms-|1.0.0
jupyter-renderers|ms-|1.0.3
cpptools|ms-|1.7.1
cpptools-extension-pack|ms-|1.1.0
postscript|mxs|1.0.1
vscode-json-editor|nic|0.3.0
vsc-octave-debugger|pau|0.4.23
bib|phr|0.3.0
seti-icons|qin|0.1.3
ipf|qms|1.0.1
lualint|sat|0.0.5
bash-beautify|sha|0.1.1
markdown-preview-enhanced|shd|0.6.1
html-preview-vscode|tht|0.2.5
octave|toa|0.0.3
pdf|tom|1.1.0
vscode-lua|tri|0.12.4
vscode-icons|vsc|11.7.0
vscode-icons-mac|way|7.25.3
debug|web|0.25.1
txt-syntax|xsh|0.2.0
markdown-all-in-one|yzh|3.4.0
json|Zai|2.0.2

(5 theme extensions excluded)

</details><details>
<summary>A/B Experiments</summary>

```
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30391933
pythonvspyt187:30373474
vsqsis300:30386381
vsaa593:30376534
vssld246cf:30386378
vscexrecpromptt3:30400063

```

</details>

<!-- generated by issue reporter -->