sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: spec: language change review meeting minutes
Labels: NeedsInvestigation,umbrella,LanguageChangeReview

The Go 2 proposal review group meets monthly (every first Wednesday of a month) to review pending Go 2 proposal issues and move them along in the [proposal process](https://golang.org/s/proposal).

Review consists primarily of checking that discussion is ongoing, commenting on issues to move discussion along, summarizing long discussions, CC’ing experts, and accepting or closing proposals when the discussion on the GitHub issue has reached a clear consensus about the outcome.

Review also includes closing proposals that are untenable (for example, because the changes are sufficiently backwards-incompatible even after allowing for significant changes to the language as part of the Go 2 effort, or violate key design goals of the language or packages).

**This meta-issue records minutes of the Go 2 proposal review meetings as issue comments, so that they can be cross-linked easily with the relevant issues. This meta-issue is for minutes only; comments that are not meeting minutes will be deleted.**

(See also #33502 which records the minutes of non-Go 2 proposals review meetings).
Repository: flutter
Issue: Extend the inspector selection changed api to indicate which client triggered the selection changed.
Labels: framework,f: inspector,c: proposal,P2,team-framework,triaged-framework

Extend the inspector selection changed api to indicate which client triggered the selection changed.

Currently clients have to track whether they triggered the selection changed event to disambiguate how the selection changed.
This case only matters if the inspector selection is changed very rapidly in which case a client may receive a selection changed event after it has already changed the selection to something else.
Repository: godot
Issue: texelFetch() not behaving properly
Labels: bug,topic:rendering,confirmed

___

***Bugsquad note:** This issue has been confirmed several times already. No need to confirm it further.*

___

**Godot version:**
3.1.1 stable


**OS/device including version:**
Ubuntu 18.04.3 LTS


**Issue description:**
I was using the *texelFetch* method from GLSL for a shader when I suddenly noticed that the fetched pixels' colors were not identical to the original ones from the texture. Testing with a simple LUT image, most of the colors were being fetched darker than they really were (below are 2 images for comparison).

After some struggle, I noticed that the same shader is working as expected in both Windows and Mac. It might have something to do with Linux drivers or even updates, since it was working some days ago.

![Screenshot from 2019-08-28 00-16-27](https://user-images.githubusercontent.com/8457973/63823677-0e2b3480-c92b-11e9-9300-caa0acf65345.png)
*Original Image*

![Screenshot from 2019-08-28 00-24-58](https://user-images.githubusercontent.com/8457973/63823683-12efe880-c92b-11e9-94f6-10fddea4c13c.png)
*TexelFetched Image*

**Steps to reproduce:**
- Open the reproduction project below and run the main scene
- Toggle the 'TexelFetchImage' node's visible property to true/false. It should be equal to the "OriginalImage" node's colors.
    - Windows/Mac: Both images are equal
    - Linux: the 'TexelFetchImage' node renders a darker image


**Minimal reproduction project:**
[repro_texelfetch.zip](https://github.com/godotengine/godot/files/3547054/repro_texelfetch.zip)
Repository: create-react-app
Issue: Add Ethereum name or address to package.json
Labels: issue: proposal,needs triage

### Is your proposal related to a problem?

<!--
  Provide a clear and concise description of what the problem is.
  For example, "I'm always frustrated when..."
-->

I can't donate to your project using Sustainus, and there is no canonical Ethereum address associated with this project and easily retrievable from the package.json

### Describe the solution you'd like

<!--
  Provide a clear and concise description of what you want to happen.
-->

I would like to see an Ethereum name or address added to the ethereum field of the package.json file. This will allow consumers of the project to know a cannonical address to send funds to. For example, I'm building an application that will allow developers to automatically donate ETH to all of their npm dependencies that have Ethereum addresses in their package.json files: https://sustainus.io

### Describe alternatives you've considered

<!--
  Let us know about other solutions you've tried or researched.
-->

I could just donate through traditional means, but I'd rather donate through my own tool that automatically donates to all verified projects on my machine.

### Additional context

<!--
  Is there anything else you can add about the proposal?
  You might want to link to related issues here, if you haven't already.
-->

If we can remove the marginal friction of donating to projects, we might be able to take open source donations truly mainstream
Repository: go
Issue: cmd/go: support -buildmode=c-shared on openbsd/amd64
Labels: help wanted,OS-OpenBSD,NeedsInvestigation,FeatureRequest,GoCommand,compiler/runtime

### What version of Go are you using (`go version`)?

<pre>
$ go version
1.12.8 openbsd/amd64
</pre>

### Does this issue reproduce with the latest release?

Yes

### What operating system and processor architecture are you using (`go env`)?

OpenBSD/amd64

```
go build -o libr2pm.so -buildmode=c-shared ./lib
-buildmode=c-shared not supported on openbsd/amd64
gmake: *** [Makefile:20: libr2pm.so] Error 1
```

See similar (fixed) bug for FreeBSD: https://github.com/golang/go/issues/22078
Repository: TypeScript
Issue: Node module dependencies that use a triple-slash directive to reference libs poison the global scope
Labels: Suggestion,In Discussion

**TypeScript Version:**  2.x, 3.x

**Search Terms:** lib.dom.d.ts pollutes global scope, `name` is defined as never, `event` is defined as `Event | undefined`

See: https://github.com/AaronFriel/is-test/blob/4e235decffdfd3c137ea066f8462d57d2fc8d0f2/src/index.ts at the commit hash linked.

**Expected behavior:**

Given a `tsconfig.json` with `lib: []`, I would expect the following code to fail to build due to `$variable not defined` errors:

```ts
import is from '@sindresorhus/is';

function main() {
  console.log(name);
  console.log(event);
  console.log(caches);
  console.log(applicationCache);
  console.log(parent);
}
```

**Actual behavior:**

See: https://github.com/AaronFriel/is-test/blob/master/src/index.ts for a **particularly egregious** example of this. It builds without any type errors. When running `npm run start`, it will throw a runtime error on the first `console.log`. If you remove that line, the next one fails, and so on, for the next 700+ lines.

General purpose libraries often need to be written to handle multiple versions of ES (ES5, ES6, ES7...) and multiple host environments (e.g.: DOM, ScriptHost, WebWorker). But right now they are faced with a choice:

A: Use a triple slash directive to import types that they use, and poison the user's global scope, causing *nearly one thousand variable names* to be silently accepted as defined without any type checker errors.

B: Remove the triple slash directives and require that users use the `--skipLibCheck` option or equivalent in their config file or include the required libs in their compiler options. Otherwise the library will fail to type check.

This is a choice that library authors would quite reasonably not want to make.

**Potential solutions:**

1. Triple slash directives should import types only in dependencies. 
  
   This seems tricky to implement, I think.
2. There should be a types-only version of the major lib files, so that general-purpose utility packages can reference those instead.

   This seems less tricky: extract all the types from the `dom` lib a new `dom-types` lib, and use a directive to reference the types. Then, library authors can triple-slash reference `dom-types` and get only the types. Has the advantage of not causing any compatibility issues, and library authors can opt in to the types-only package.

3. ???
Repository: pytorch
Issue: torch.as_tensor(bytearray(...)) seems to leak memory
Labels: module: dataloader,module: cuda,module: memory usage,triaged

In my multi-threaded data loader I'm calling `sox` to do some data augmentation (because torchaudio SoxEffectsChain [seems to corrupt memory](https://github.com/pytorch/pytorch/issues/25147)). Somehow I get GPU memory leak. Both these lines do not use any GPU, so it's very strange.

```python
effect = ['pitch', 400]
audio_path = 'some audio path'

# memory leaks on GPU in a few dozen of batches, despite the fact it does not use any GPU
signal, sample_rate_ = torch.as_tensor(bytearray(subprocess.check_output(['sox', '-V0', audio_path, '-b', '16', '-e', 'signed', '--endian', 'little', '-r', str(sample_rate), '-c', '1', '-t', 'raw', '-']  + ([effect[0], str(effect[1])] if effect else []))), dtype = torch.int16), sample_rate

# works without issues
signal, sample_rate_ = torch.from_numpy(np.frombuffer(subprocess.check_output(['sox', '-V0', audio_path, '-b', '16', '-e', 'signed', '--endian', 'little', '-r', str(sample_rate), '-c', '1', '-t', 'raw', '-']  + ([effect[0], str(effect[1])] if effect else [])), dtype = np.int16)).to(torch.float32), sample_rate
```

Of course these signal objects only live till in the data loader, and later are thrown away just after STFT.

cc @SsnL
Repository: flutter
Issue: flutter webview VerticalDragGestureRecognizer get no callback but only onDown and onCancel
Labels: a: quality,f: gestures,a: platform-views,p: webview,package,team-ecosystem,has reproducible steps,P2,found in release: 3.10,found in release: 3.11,triaged-ecosystem

I have a webview with `VerticalDragGestureRecognizer` gestures, try to detect the webview scrolling up or down.
but I only get `onDown` and `onCancel` callback in iOS simulator/device.
the 'onStart' , `onUpdate` never get called during scrolling the webview.

using [flutter_webview 0.3.13](https://pub.dev/packages/webview_flutter)

below is code: 

```dart

class TestWebView extends StatefulWidget {
  @override
  _TestWebViewState createState() => _TestWebViewState();
}

class _TestWebViewState extends State<TestWebView> {
  @override
  Widget build(BuildContext context) {
    return WebView(
        initialUrl: "https://google.com",
        gestureRecognizers: Set()
          ..add(Factory<VerticalDragGestureRecognizer>(() {
            return VerticalDragGestureRecognizer()
              ..onStart = (DragStartDetails details) {
                print("darg start");
              }
              ..onUpdate = (DragUpdateDetails details) {
                print("Drag update: $details");
              }
              ..onDown = (DragDownDetails details) {
                print("Drag down: $details");
              }
              ..onCancel = () {
                print("Drag cacel");
              }
              ..onEnd = (DragEndDetails details) {
                print("Drag end");
              };
          })));
  }
}
```

logs
```
flutter: Drag down: DragDownDetails(Offset(286.0, 626.5))
flutter: Drag cacel
flutter: Drag down: DragDownDetails(Offset(216.5, 513.5))
flutter: Drag cacel
flutter: Drag down: DragDownDetails(Offset(194.5, 394.0))
flutter: Drag cacel
```


Flutter doctor:
```
[✓] Flutter (Channel stable, v1.7.8+hotfix.4, on Mac OS X 10.14.6 18G87, locale
    zh-Hant-TW)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from:
      https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK
      components.
      (or visit https://flutter.dev/setup/#android-setup for detailed
      instructions).
      If the Android SDK has been installed to a custom location, set
      ANDROID_HOME to that location.
      You may also want to add it to your PATH environment variable.

[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
[✓] iOS tools - develop for iOS devices
[!] Android Studio (not installed)
[✓] Connected device (1 available)
```


thanks for any helps!
Repository: flutter
Issue: [Error message]Add a better debug message, when a child definition is missing
Labels: framework,c: proposal,a: error message,P3,team-framework,triaged-framework

## Use case

During development, sometimes very nice debug messages pop up saying something like "Either this is ... or we should provide a better error message".

Therefore I would like to propose to add some information for a scenario that I encounter very often, which is forgetting to define the "child" key.

E.g. when I write:
```dart
body: Column(
    children: <Widget>[
        RaisedButton(
            Text('Button Text');
        )
    ]
)
```
the error
`too many positional arguments: 0 allowed, but found 1. Try removing the extra positional Arguments.`
pops up.

IMO, this is not at all helpful for a beginner. (And if I recall correctly, 'positional arguments' is a rarely if at all used term in the documentation - but I might be wrong, haven't read the whole thing yet, but a lot, and it is not a term that is in my mind...)

I have a feeling that this error most often will pop up, when the "child" key was not mentioned (this is even mentioned as a possible reason on one of the Flutter videos on Youtube by a core dev).

## Proposal

Therefore I would like to suggest to add a bit more text to that error message that mentions the possibility that the child key was not found, too. I could think of a short text like this:
```
Error: too many positional [...] arguments. Or did you simply forget to add a "child" key?
```
Since I personally like the friendly style of the error messages in some places ver much, simply because it is a very motivating style of informing the dev that something is wrong, it would be great, if this style of addressing a possible error could be used.

But maybe a missing "child" key is even something that can be tested separately, so that in case of a missing "child" key a separate error message could be thrown?

This is just a suggestion and subject to discussion, of course. Thank you!
Repository: flutter
Issue: Draggable widget does not update feedback when dragging
Labels: framework,has reproducible steps,P2,team-framework,triaged-framework,found in release: 3.27,found in release: 3.28

Updates are rendered to the childWhenDragging widget but not to the feedback widget.

## Steps to Reproduce

https://gist.github.com/mannfeldt/e33e2f8324b783a8fd5b5252f7eedc1b

1. Drag the container.
2. Click the button while still dragging.
Repository: pytorch
Issue: Handling of packed_sequence by activation functions and linear layers
Labels: module: nn,module: rnn,triaged

## 🚀 Feature
It would be absolutely great, more efficient and simplify usage of batched processing of variable length-input, if activations functions and linear layer could handle packed_sequences.

## Motivation

I noticed that it is not possible to feed ```packed_sequences``` to things like activation functions or linear layers. With NLP applications in mind, it forces me to design models having a forward method like :

```
    def forward(self, input, lengths, hidden = None):
        input = nn.utils.rnn.pack_padded_sequence(input, lengths, batch_first = True, enforce_sorted = False)
        out, hidden = self.lstm(input,hidden)
        out = nn.utils.rnn.pad_packed_sequence(out, batch_first = True, padding_value= -100)[0]
        out = self.drop_layer(self.sigmoid(out))
        out = self.softmax(self.linear_layer(out))
``` 

Where I have to unpack the ```packed_sequence``` directly after the passing through ```LSTM```, and later need to filter it before loss calculation. if I don't, I received an error message : 
``` 
TypeError: sigmoid(): argument 'input' (position 1) must be Tensor, not PackedSequence
```
This seem highly inefficient since a lot of the calculations done by the activations functions and linear layers will have to be thrown away afterwards.

There might be an explanation as to why this is not already implemented, but I could not find a reason for it anywhere.




cc @zou3519
Repository: TypeScript
Issue: Arrow function generics are resolved
Labels: Needs Investigation

**TypeScript Version:**  3.5.3

**Search Terms:** arrow function generic

**Code**

```ts
export const foo = <T extends keyof HTMLElementEventMap>(t: T): T => t;
export function bar<T extends keyof HTMLElementEventMap>(t: T): T {
  return t;
}
```

**Expected behavior:**

The `d.ts` file contains unresolved types for a list of strings for arrow function generics.

```ts
export declare const foo: <T extends keyof HTMLElementEventMap>(t: T) => T;
export declare function bar<T extends keyof HTMLElementEventMap>(t: T): T;
```

**Actual behavior:**

The `d.ts` file contains resolved types for a list of strings for arrow function generics.

```ts
export declare const foo: <T extends "waiting" | "error" | "abort" | "cancel" | "progress" | "ended" | "change" | "input" | "select" | "fullscreenchange" | "fullscreenerror" | "animationcancel" | "animationend" | "animationiteration" | "animationstart" | "auxclick" | "blur" | "canplay" | "canplaythrough" | "click" | "close" | "contextmenu" | "cuechange" | "dblclick" | "drag" | "dragend" | "dragenter" | "dragexit" | "dragleave" | "dragover" | "dragstart" | "drop" | "durationchange" | "emptied" | "focus" | "gotpointercapture" | "invalid" | "keydown" | "keypress" | "keyup" | "load" | "loadeddata" | "loadedmetadata" | "loadend" | "loadstart" | "lostpointercapture" | "mousedown" | "mouseenter" | "mouseleave" | "mousemove" | "mouseout" | "mouseover" | "mouseup" | "pause" | "play" | "playing" | "pointercancel" | "pointerdown" | "pointerenter" | "pointerleave" | "pointermove" | "pointerout" | "pointerover" | "pointerup" | "ratechange" | "reset" | "resize" | "scroll" | "securitypolicyviolation" | "seeked" | "seeking" | "selectionchange" | "selectstart" | "stalled" | "submit" | "suspend" | "timeupdate" | "toggle" | "touchcancel" | "touchend" | "touchmove" | "touchstart" | "transitioncancel" | "transitionend" | "transitionrun" | "transitionstart" | "volumechange" | "wheel" | "copy" | "cut" | "paste">(t: T) => T;
export declare function bar<T extends keyof HTMLElementEventMap>(t: T): T;
```

**Playground Link:** N/A — The issue exists in the d.ts file output.

**Related Issues:**
Repository: pytorch
Issue: ConstQuantizerPtr is misnamed
Labels: oncall: quantization,triaged

I saw this in TensorMethods.h

```
// This is temporary typedef to enable Quantizer in aten native function API
// we'll remove them when we are actually exposing Quantizer class
// to frontend
using ConstQuantizerPtr = const c10::intrusive_ptr<Quantizer>&;
```

By standard C const precedence rules, "ConstQuantizerPtr" implies "const Quantizer*" but this is in fact NOT what you have here, which is effectively a "Quantizer * const" (because const binds more tightly to quantizer, so you have `const Quantizer`). Importantly, `ConstQuantizerPtr` doesn't stop you from mutating a quantizer, because you can "cast" away the constness.

Additionally, the type in question isn't even a pointer, it's a reference!

If Quantizer is the target of an intrusive pointer, I'd expect to actually see the naming as `struct QuantizerImpl` and then `using Quantizer = intrusive_ptr<QuantizerImpl>`. Then you could validly name the typedef above as `ConstQuantizerRef` although it would be a lot clearer to just not having the typedef at all.

cc @jerryzh168 @jianyuh @dzhulgakov @raghuramank100
Repository: TypeScript
Issue: Type guard does not narrow the same as if-statement
Labels: Suggestion,Awaiting More Feedback

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the *entire* template below.
-->

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  3.5.1

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**

+ Type guard function
+ If-statement guard
+ Narrow
+ Discriminated union

**Code**

```ts
enum E1 {
    element0 = "element0",
    element1 = "element1",
    element2 = "element2",
}
enum E2 {
    element3 = "element3",
    element4 = "element4",
    element5 = "element5",
}

declare const obj : (
    | {
        type : E1,
        data : {
            object : {
                x : "e1"
            }
        }
    }
    | {
        type : E2,
        data : {
            object : {
                x : "e2"
            }
        }
    }
);

if (obj.type == E1.element0) {
    //OK
    const type : "element0" = obj.type;
    //OK
    const x : "e1" = obj.data.object.x;
}

if (
    obj.type == E1.element0 ||
    obj.type == E1.element1 ||
    obj.type == E1.element2
) {
    //OK
    const type : "element0"|"element1"|"element2" = obj.type;
    //OK
    const x : "e1" = obj.data.object.x;
}

declare function isE1 (mixed : unknown) : mixed is E1;

if (isE1(obj.type)) {
    //OK
    const type : "element0"|"element1"|"element2" = obj.type;
    //Expected : OK
    //Actual : Error; Type '"e1" | "e2"' is not assignable to type '"e1"'.
    const x : "e1" = obj.data.object.x;
}
```

**Expected behavior:**

2nd and 3rd examples should both work.

**Actual behavior:**

2nd example works.
3rd example does not work.

**Playground Link:** 

[Playground](http://www.typescriptlang.org/play/#code/KYOwrgtgBAogjFA3gKCmqwA2wKgC4AMUAvFAERY74FkA0q6luIeCpF2zrdDaT+AJhLl+LATwC+yUJFhCU6DJ3wBmYRyosVPRaLwAWdXv07GylgFYj5vBcnJkAE2ABjTAEMATsCguA9iAAznhQfgBGAFZQAFxQABS8UAA+SImKeACeAA4+sfD0ioqO7njuMamFlaGRriGxClWNAB7lFHBkaVVSjd3ovWgpDZWZOeUwAgVVxaXlQ43VEbWznfNQLbEU4iuF-TuJUgCUANwOAJYAZvHhEQB0Iz7EpPA3egQHFegA9J8A8gDSiX8QRC91arzIwmud2ywBOim+-0BAWCazB7UhkRu03cN2utRuTROUmQF3iiShoMesDgLxsRCSSXJmMpTxpegQDKZtxZ1NpmjwAmQ7zmCIBiiBKNBG3BSQ0XHasr04gx3JhcK+vzF6AlIXWInRpCh2NxNRceAJRIczjcXh85zAIDNpwCUFOgXg8QgpyawEc5QdAGsQH4AO4gd6xL0+v1u6knEmXOJu+BxCkwg7CxKipHAqBSkR0siKmwKuWCCGG5lqrOfGBNHJm33lRHwz4AQTNYHcmDGnk8fk8RygABUYVAAORtCEpTZkceuwJQYMhdyBQKnADmIHcYWweb8ebHk+A7XHNxzKL1U5VWJKOLxZotyAkQA)

**Related Issues:** <!-- Did you find other bugs that looked similar? -->
Repository: TypeScript
Issue: JS: Type reference not resolved, but gives type to variable
Labels: Bug,Domain: Quick Info

From HeapSnapshot.js in chrome-devtools-frontend:

```js
var H = {}
H.Edge = class {
    /** @return {H.Edge/*1*/} */
    clone() {
        return new H.Edge()
    }
}

/** @type {H.Edge/*2*/} */
var x;
x.clone
```

Expected: goto-def at `/*1*/` and `/*2*/` should work. 

Actual: not resolved and just says "any" for quickinfo.

Oddly, `x: H.Edge`, and `x.clone: () => Edge` which are both correct.