sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: terminal
Issue: Feature Request - Live Share support
Labels: Issue-Feature,Area-UserInterface,Area-Extensibility,Product-Terminal

<!-- 
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed!
-->

# Description of the new feature/enhancement
It would be nice if there was a live share style system were you could click a link and share it to allow a remote user to interact in the same terminal as you have open.

# Proposed technical implementation details (optional)
I was thinking maybe a link in the tab or a right click menu with the option to create a live share session of the tab.

Once connected I'd expect icons in the title bar of the users connected (highlight to bring up a card with more details + commands, i.e. kick user).

Or maybe a circle with a number indicating the number of users connected, hover and more details appear in the terminal window (cards or something similar).
Repository: TypeScript
Issue: ES6 module immediately exported var clash with local "exports" variable
Labels: Bug,Help Wanted

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.5.1 (playground), 3.5.3

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
es6 module exports object scope declare declaration overwrite

**Code**

```ts
export const a = 1
function b () {
    const exports = 2
    console.log(a)
}
b()
```

**Expected behavior:**
output from babel with es2015 preset
https://babeljs.io/repl#?babili=false&browsers=&build=&builtIns=false&spec=false&loose=false&code_lz=KYDwDg9gTgLgBAYwgOwM7wIZwLxwIwBQAZgK7IIwCWKcARnABQCUcA3gXJ4iunKJLFQ44AJg5ckaCABtgAOmkQA5gwxMCAXwK1mQA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=false&timeTravel=false&sourceType=module&lineWrap=false&presets=es2015&prettier=false&targets=&version=7.5.5&externalPlugins=

```javascript
"use strict";

Object.defineProperty(exports, "__esModule", {
  value: true
});
exports.a = void 0;
var a = 1;
exports.a = a;

function b() {
  var exports = 2;
  console.log(a);
}

b();
```

**Actual behavior:**
console.log is referencing the local `exports.a` instead of the global const `a`

```javascript
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.a = 1;
function b() {
    var exports = 2;
    console.log(exports.a);
}
b();
```

However, if I split the `export const` into two, it will work.
```javascript
const a = 1
export { a }
```

**Playground Link:**
http://www.typescriptlang.org/play/?target=1#code/KYDwDg9gTgLgBAYwgOwM7wIZwLxwIwCwAUAGYCuyCMAlinAEZwAUAlHAN7FzeIrpyhIsVDjgAmLjyRoIAG2AA6WRADmTDC2IBfYvVZA

**Related Issues:** can't find
Repository: pytorch
Issue: JavaScript (Web Assembly) target for trained models
Labels: triaged,enhancement

## 🚀 Feature
A compiler that converts the trained model to a [WASM](https://developer.mozilla.org/en-US/docs/WebAssembly) binary where they could be accessed via a JavaScript function.

## Motivation

I hope to deploy models in web browsers.

## Pitch

Be able to compile a trained model to WASM.

## Alternatives

[ONNX.js](https://github.com/microsoft/onnxjs), though development seems stalled and last time that I tried a simple but big enough model, the performance was lacking. Compiling to WASM would mean there would be no need to be compliant with a standard, also could potentially be much faster e.g. if it's written in [Rust](https://www.rust-lang.org/) and then compiled to WASM.

## Additional context

From #494, I noticed the policy towards features outside the scope of the core team is to defer. Would like to know if there are any suggestion or advice on a starting point, I might be able to put some time on this myself.
Repository: pytorch
Issue: No way to correctly reset weights of a model with spectral norm
Labels: module: nn,triaged,has workaround

I didn't find any similar issue (with spectral norm), so excuse me if I file a duplicate.

## 🐛 Bug
There is no way to fully reset the weights (buffers?) of a model with spectral norm. When I reuse my model I get good looking samples almost instantly on any full MNIST 30-epoch training run other than the first, which I presume is caused by how the spectral norm is implemented. There is no reset_parameters for spectral norm (as it even isn't implemented as a layer). Removing and adding using remove_spectral_norm and spectral_norm does not work as a workaround, as I get:
```
RuntimeError: Unexpected key in metadata['spectral_norm']: weight.version
```
I know I should create a new model as it isn't that costly for each run, but this should be possible without copying.

## To Reproduce

Steps to reproduce the behavior:

1. Use a simple GAN model with SN in both the discriminator and generator.
2. Train this model, save images while training.
3. Reset weights / Apply init on the model.
4. Train this model again, save images while training.

My init function:
```
def init_weights(m):
    if hasattr(m, 'reset_parameters'):
        m.reset_parameters()
    if isinstance(m, nn.ConvTranspose2d) or isinstance(m, nn.Conv2d):
        m.weight.data.normal_(0.0, 0.02)
        if m.bias is not None:
            m.bias.data.fill_(0)
    elif isinstance(m, nn.BatchNorm2d):
        m.weight.data.normal_(1.0, 0.02)
        m.bias.data.fill_(0)
    elif isinstance(m, nn.Linear):
        m.weight.data.normal_(0.0, 0.1)
        if m.bias is not None:
            m.bias.data.fill_(0)
```

## Expected behavior

I would expect my model to be fully reset. Especially if that is the "recommended" way: https://discuss.pytorch.org/t/cross-validation-model-reset/21176

## Environment

PyTorch version: 1.2.0
Is debug build: No
CUDA used to build PyTorch: 10.0.130

OS: Ubuntu 16.04.5 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609
CMake version: version 3.5.1

Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: GeForce RTX 2080 Ti
GPU 1: GeForce RTX 2080 Ti

Nvidia driver version: 430.34
cuDNN version: Could not collect

Versions of relevant libraries:
[pip] numpy==1.16.4
[pip] torch==1.2.0
[pip] torchvision==0.4.0
[conda] blas                      1.0                         mkl
[conda] mkl                       2019.4                      243
[conda] mkl_fft                   1.0.12           py37ha843d7b_0
[conda] mkl_random                1.0.2            py37hd81dba3_0
[conda] torch                     1.2.0                    pypi_0    pypi
[conda] torchvision               0.4.0                    pypi_0    pypi

cc @ezyang @gchanan @SsnL
Repository: opencv
Issue: OpenCV tries and fails to build disabled tests
Labels: category: build/install

##### System information (version)
- OpenCV => 4.1.1
- Operating System / Platform => Haiku 64 Bit
- Compiler => GCC 8.3.0

##### Detailed description

Compiling OpenCV with disabled test still tries to compile test files and fails.

##### Steps to reproduce

Compiling OpenCV like:
```
	cmake .. \
		-DWITH_GDAL=ON \
		-DWITH_IPP=OFF \
		-DWITH_OPENGL=OFF \
		-DWITH_QT=ON \
		-DWITH_EIGEN=ON \
		-DWITH_OPENCL=ON \
		-DCMAKE_BUILD_TYPE=Release \
		-DCMAKE_SKIP_RPATH=ON \
		-DENABLE_PIC=OFF \
		-DCMAKE_INSTALL_PREFIX:PATH="$prefix" \
		-DOPENCV_OTHER_INSTALL_PATH:PATH="$dataDir" \
		-DOpenBLAS_INCLUDE_DIR="$portPackageLinksDir/openblas${secondaryArchSuffix}_devel/develop/headers/$ARCH_SUBDIR" \
		-DOpenBLAS_LIB="$portPackageLinksDir/openblas${secondaryArchSuffix}_devel/develop/lib/$ARCH_SUBDIR" \
		-DOPENCV_INCLUDE_INSTALL_PATH="$includeDir/opencv4" \
		-DOPENCV_LICENSES_INSTALL_PATH="$dataDir/licenses/opencv4" \
		-DOPENCV_3P_LIB_INSTALL_PATH="$developLibDir/opencv4/3rdparty" \
		-DOPENCV_GENERATE_PKGCONFIG=ON
```
fails:

```
In file included from <command-line>:
/sources/opencv-4.1.1/build_haiku/modules/dnn/test_precomp.hpp:50:10: fatal error: test_common.hpp: No such file or directory
 #include "test_common.hpp"
          ^~~~~~~~~~~~~~~~~
compilation terminated.
```
Repository: godot
Issue: Light2D does not use AtlasTexture correctly
Labels: bug,topic:rendering,confirmed

**Godot version:**
v3.1.stable.official

**OS/device including version:**
Windows 10 Enterprise Version 10.0.17134 Build 17134

**Issue description:**
When I assign an atlas texture to the light it either removes the light completely no matter what region I set or uses the previously assigned texture.

**Steps to reproduce:**
Create an atlas texture, add the icon png as an atlas, set the region to whatever you want as long as the size is bigger then 0, add an icon sprite, add a light using the atlas texture and see that it doesn't do anything.
Repository: go
Issue: mime/multipart: encode non-US-ASCII characters in Content-Disposition
Labels: NeedsDecision

I am coming here from CL https://go-review.googlesource.com/c/go/+/190217 where @pascaldekloe has submitted a change that makes *mime/multipart.Writer generate a "Content-Disposition" value after invoking mime.FormatMediaType instead of using a quote escaper.

In a comment https://go-review.googlesource.com/c/go/+/190217/1#message-b06f1016c7862f1d35ef7a12dc95fc4426a48178
@mattn asks
```
I don't have strong opinion. Just for the note. This make forcibly the filename encode
with rfc 6266. So older browser will not work after this change. Do we need to leave
a way to output raw-filenames?
```

This issue is to have a discussion, but I'll also loop in some security folks @mikesamuel @empijei, to help evaluate or just beware of the update.
Repository: flutter
Issue: [in_app_purchase] Improved error messages / codes for IAPError
Labels: c: new feature,p: in_app_purchase,package,a: error message,team-ecosystem,P3,triaged-ecosystem

I'm using the `in_app_purchase` plugin version `0.2.1`, and i noticed the `IAPError` error message gave me the string `BillingResponse.itemAlreadyOwned` on Android. I would like the string `Item already owned` or similar, and preferably localised in my current locale.  This happened when i tried to buy an `non-consumable` that i'd already bought.

I also notice the error code is `purchase_error`,  should this rather not be the number `7`, as described in the `Server Response Codes` in the [In-app Billing Reference](http://www.androiddocs.com/google/play/billing/billing_reference.html)?

I suspect this is similar on iOS, but i had some problems getting the same error responses.

Any plans on improving the error messages / codes for IAP?

```
flutter doctor -v
[✓] Flutter (Channel stable, v1.7.8+hotfix.4, on Mac OS X 10.14.6 18G87, locale en-NO)
    • Flutter version 1.7.8+hotfix.4 at /Users/erlend/flutter
    • Framework revision 20e59316b8 (5 weeks ago), 2019-07-18 20:04:33 -0700
    • Engine revision fee001c93f
    • Dart version 2.4.0

 
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/erlend/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.3, Build version 10G8
    • CocoaPods version 1.7.5

[✓] iOS tools - develop for iOS devices
    • ios-deploy 1.9.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 38.2.3
    • Dart plugin version 191.8405
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (1 available)
    • MotoG3 • ZY22346NVZ • android-arm • Android 6.0.1 (API 23)

• No issues found!
```
Repository: youtube-dl
Issue: marilyn.ca can be supported with very minor adjustment of [9c9media]
Labels: site-support-request

<!--

######################################################################
  WARNING!
  IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################

-->


## Checklist

<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.08.13. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->

- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2019.08.13**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones


## Example URLs

<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->

- Single video: https://www.marilyn.ca/Celebrity/video/Greys-Anatomy-Giacomo-Gianniotti-shares-has-the-ultimate-Hollywood-success-story-vid1736881
- Playlist: https://www.marilyn.ca/api/curatedfilter/byfilter/17a24c9e-faee-4e30-ae23-a24d727e9f5f/16/8
- Playlist: https://www.marilyn.ca/api/curatedfilter/byfilter/17a24c9e-faee-4e30-ae23-a24d727e9f5f/1/8


## Description

<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->

Adding support for this site merely requires a minor adjustment to the [9c9media] extractor, which already works for ctv.ca and tsn.ca. For instance, the video https://www.marilyn.ca/Celebrity/video/Greys-Anatomy-Giacomo-Gianniotti-shares-has-the-ultimate-Hollywood-success-story-vid1736881
corresponds to
http://capi.9c9media.com/destinations/ctv_marilyn_web/platforms/desktop/contents?$include=[authentication,contentpackages]&id=[1736881]&callback=jQuery17006378412764016894_1446003488577
Repository: go
Issue: runtime: make `GOMAXPROCS` cfs-aware on `GOOS=linux`
Labels: NeedsInvestigation,compiler/runtime

### Problem

The default setting of `runtime.GOMAXPROCS()` (to be the number of os-apparent processors) can be greatly misaligned with container cpu quota (e.g. as implemented through [cfs bandwidth control][cfs_bwc] by docker).

This can lead to large latency artifacts in programs, especially under peak load, or when saturating all processors during background GC phases.

The smaller the container / larger the machine = the worse this effect becomes: let's say you deploy a fleet of micro service workers, each container having a cpu quota of 4, on a fleet of 32 processor[1] machines.

To understand why, you really have to understand the CFS quota mechanism; [this blog post][ln_jvm_cfs_pauses] does well (with pictures); this [kubernetes issue][k8_bobrik_issue] further explores the topic (especially as it relates to a recently resolved kernel cpu accounting bug). But to summarize it briefly for this issue:
- there is a quota `period`, say 100ms
- and there is then a `quota`, say 400ms to affect a 4-processor quota
- within any `period`, once the process group exceeds its `quota` it is throttled

Running an application workload at a reasonable level of cpu efficiency makes it _quite_ _likely_ that you'll be spiking up to your full quota and getting throttled.

Background waste workload, like concurrent GC[2], is _especially_ _likely_ to cause quota exhaustion.

I hesitate to even call this a "tail latency" problem; the artifacts are visible in the main body of and can shift the entire latency distribution.

### Solution

If you care about latency, reliability, predictability (... insert more *ilities to taste), then the correct thing to do is to never exceed your cpu quota, by setting `GOMAXPROCS=max(1, floor(cpu_quota))`.

Using this as a default for GOMAXPROCS makes the world safe again, which is why we use [uber-go/automaxprocs](https://github.com/uber-go/automaxprocs) in _all_ of our microservices.

### NOTEs

1. intentionally avoiding use of the word "core"; the matter of hyper-threading and virtual-vs-physical cores is another topic
2. /digression: can't not mention userspace scheduler pressure induced by background GC; where are we at with goroutine preemption again?

[k8_bobrik_issue]: https://github.com/kubernetes/kubernetes/issues/67577
[ln_jvm_cfs_pauses]: https://engineering.linkedin.com/blog/2016/11/application-pauses-when-running-jvm-inside-linux-control-groups

[cfs_bwc]: https://www.kernel.org/doc/Documentation/scheduler/sched-bwc.txt
Repository: pytorch
Issue: [FR] Dropout modules/functions should take in generator=
Labels: module: nn,triaged,enhancement,module: random

To be consistent with all other random functions.

cc @SsnL
Repository: TypeScript
Issue: Ability to only check specific errors
Labels: Suggestion,Awaiting More Feedback

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ

-->

## Search Terms

<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
specific errors ignore whitelist enable only

## Suggestion

<!-- A summary of what you'd like to see added or changed -->
Ability to specify what errors you would like to see caught in the tsconfig.json. Errors not in the whitelist would be ignored.

## Use Cases

<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
Migrating large projects to Typescript. If the migration is done in a by-error-type approach you can't turn type-checking on in CI until _all_ problems are fixed, which can take a long time when there is other work to do.

## Examples

<!-- Show how this would be used and what the behavior would be -->

```json
{
  "whitelistErrors": [7017, 2322, 2344]
}
```

Errors other than TS7017, TS2322, TS2344 would be ignored.

This suggestion is the inverse of https://github.com/microsoft/TypeScript/issues/29950

You can see an example of the opposite (blacklist errors) here: https://github.com/evolution-gaming/tsc-silent

[Pytype](https://google.github.io/pytype/), google's type-checker for python, also has the ability to blacklist specific errors.

```
# Comma separated list of error names to ignore.
disable =
    attribute-error
```

## Checklist

My suggestion meets these guidelines:

* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).

---

Note that this might lead to bad practice where developers lazily only check for certain errors rather than fixing their broken types. Using this feature should be discouraged unless used as a temporary measure for migrating from JS projects.
Repository: go
Issue: x/website/_content/doc: Channels example in Effective Go leaks goroutines
Labels: Documentation,NeedsInvestigation,website

The [final example](https://github.com/golang/go/blob/master/doc/effective_go.html#L3085) in Effective Go's [Channels](https://golang.org/doc/effective_go.html#channels) section leaks goroutines. Here's a solution that preserves the original semantics of `Serve`, and is closest to a similar example presented in [Tour](https://tour.golang.org/concurrency/5):

```go
func Serve(clientRequests chan *Request, quit chan bool) {
    reqs := make(chan *Request) // Dispatch queue for handlers.
    defer close(reqs) // Ensures handler goroutines complete.

    // Start handlers
    for i := 0; i < MaxOutstanding; i++ {
        go handle(reqs)
    }

    for {
        select {
        case req := <-clientRequests:
            reqs <-req
        case <-quit: // Wait to be told to exit.
            return
        }
    }
}
Repository: kubernetes
Issue: Improve handling of readonly volume expansion
Labels: kind/bug,sig/storage,triage/accepted

Volumes that are attached as readonly or is mounted as readonly needs to be handled different for CSI. For CSI in particular - the decision of whether to expand the volume or not should be off loaded to CSI storage provider rather than kubernetes making the decision for them. 

Fixing this for good will require a spec change in CSI I think and we will pursue this before making CSI expansion GA.

/sig storage
/assign

cc @bswartz
Repository: flutter
Issue: dart binary fails to execute while building flutter tool (windows)
Labels: c: crash,tool,dependency: dart,platform-windows,a: first hour,P2,team-tool,triaged-tool

OS: `Windows 10 (1903 - 18956.1000)`
Flutter: master and stable

I've tried a bunch of different ways to install on Windows and keep getting the same error. I've tried `stable` and `master`.

```
Checking Dart SDK version...
Downloading Dart SDK from Flutter engine 975a8aa5752e5774ffcd342a6f987d61bd5d84a5...
Unzipping Dart SDK...
Building flutter tool...
Running pub upgrade...
'"<path to flutter>\bin\cache\dart-sdk\bin\dart"' is not recognized as an internal or external command,
operable program or batch file.
Error (9009): Unable to 'pub upgrade' flutter tool. Retrying in five seconds... (9 tries left)
```

Running `<path to flutter>\bin\cache\dart-sdk\bin\dart` works and my path is correctly set up.