sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: godot
Issue: `_draw()` can be triggered more than once per frame
Labels: bug,topic:core,topic:rendering,topic:2d

### Godot version

v4.0.rc2.official [d2699dc7a]

### Issue description

tl;dr: the `_draw` queue is being flushed after `_process` _and_ `_physics_process`, rather than just after `_process`.

Longer version: `queue_redraw` queues `_draw` to be called, however that queue is flushed even after physics frames. While this isn't typically a major issue, there could conceivably be situations where physics frames are occurring more frequently than rendering frames, or for both `_physics_process` and `_process` to call `queue_redraw`, which would lead to redundant calls to `_draw` before rendering actually takes place after `_process` is done. Ideally the queue should be flushed only once, after process, prior to rendering.

### Steps to reproduce

This is easiest to observe by sticking a call to queue_redraw inside a _physics_process, clamping the FPS in the project settings to something like 10, and printing out any calls to _process, _physics_process, and _draw.

### Minimal reproduction project

[draw.zip](https://github.com/godotengine/godot/files/10741530/draw.zip)

Alternatively, the following script stuck on any Node2D on a new project:
```GDScript
extends Node2D

func _process(delta):
	queue_redraw()

func _physics_process(delta):
	queue_redraw()

func _draw():
	print("_draw is running on frame %s" % [Engine.get_frames_drawn()])
```
Repository: vscode
Issue: Add an option to show a watermark in the editor
Labels: feature-request,editor-theming

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
# Use Case
As a business we use vscode to edit different repositories of different clients. It would be nice to have a watermark in the background of the editor that clearly identifies the current repo so we don't mix them up. 

Yes, the name of workspace is visible in the window title, but some users need a more prominent visual hint ;)

Example borrowed from an Visual Studio extension:
![image](https://user-images.githubusercontent.com/4013009/218963108-dc890592-279e-4490-903a-7b1d22c10f48.png)

# Proposal
Add settings for the `content`, `opacity` and `position` of one watermark per editor.
Content could be an image or text, then font options are required, too.
This could be achieved via CSS styles.

## Example settings
```JSON
{
  "editor.watermark": {
    "content": "My Client",
    "right": "10px",
    "bottom": "10px",
    "opacity": 0.4
  },
  // Just another example
  "[json]": {
    "editor.watermark": {
        "background": "url('https://freesvg.org/img/Developers-Openclipart-has-a-JSON-API.png')"
    }
  }
}
```

### Open Questions
- Is positioning via `top`, `left`, `right` and `bottom` enough? What if I want it centered horizontaly and verticaly?
- Do embedded editors (like terminals) support this, too? One could imagine, that the terminal type (bash, powershell, ...) would be desirable to be shown as watermark. Example borrowed from Windows Terminal: 
![image](https://user-images.githubusercontent.com/4013009/218963185-8a4a1e7e-9acd-4a1c-8dda-9326e2ba8da1.png)
Repository: deno
Issue: hello_runtime.rs failed to operate as expected !
Labels: bug,runtime,custom runtime

`deno / runtime / examples / hello_runtime.rs` Unable to execute snapshot();

repo: [hello_runtime.rs](https://github.com/lifegit/deno/blob/fixbug/runtime/examples/hello_runtime.rs)


error:
```<unknown>:10: Uncaught TypeError: Cannot read properties of undefined (reading 'ops')
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', core/runtime.rs:986:64
stack backtrace:
   0: rust_begin_unwind
             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/core/src/panicking.rs:64:14
   2: core::panicking::panic
             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/core/src/panicking.rs:111:5
   3: core::option::Option<T>::unwrap
             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/core/src/option.rs:778:21
   4: deno_core::runtime::JsRuntime::snapshot
             at ./core/runtime.rs:986:15
   5: intervals_mod3::main::{{closure}}
             at ./runtime/examples/intervals_mod3.rs:80:18
   6: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /Users/workspace/.cargo/registry/src/mirrors.ustc.edu.cn-61ef6e0cd06fb9b8/tokio-1.24.2/src/runtime/park.rs:283:63
   7: tokio::runtime::coop::with_budget
             at /Users/workspace/.cargo/registry/src/mirrors.ustc.edu.cn-61ef6e0cd06fb9b8/tokio-1.24.2/src/runtime/coop.rs:102:5
   8: tokio::runtime::coop::budget
             at /Users/workspace/.cargo/registry/src/mirrors.ustc.edu.cn-61ef6e0cd06fb9b8/tokio-1.24.2/src/runtime/coop.rs:68:5
   9: tokio::runtime::park::CachedParkThread::block_on
             at /Users/workspace/.cargo/registry/src/mirrors.ustc.edu.cn-61ef6e0cd06fb9b8/tokio-1.24.2/src/runtime/park.rs:283:31
  10: tokio::runtime::context::BlockingRegionGuard::block_on
             at /Users/workspace/.cargo/registry/src/mirrors.ustc.edu.cn-61ef6e0cd06fb9b8/tokio-1.24.2/src/runtime/context.rs:315:13
  11: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
             at /Users/workspace/.cargo/registry/src/mirrors.ustc.edu.cn-61ef6e0cd06fb9b8/tokio-1.24.2/src/runtime/scheduler/multi_thread/mod.rs:66:9
  12: tokio::runtime::runtime::Runtime::block_on
             at /Users/workspace/.cargo/registry/src/mirrors.ustc.edu.cn-61ef6e0cd06fb9b8/tokio-1.24.2/src/runtime/runtime.rs:284:45
  13: intervals_mod3::main
             at ./runtime/examples/intervals_mod3.rs:81:3
  14: core::ops::function::FnOnce::call_once
             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/core/src/ops/function.rs:507:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
```
Repository: storybook
Issue: Controls: Add textarea control option 
Labels: feature request,addon: controls

### Is your feature request related to a problem? Please describe

Currently there is a `text` control, that has the following options:

https://github.com/storybookjs/storybook/blob/next/code/ui/blocks/src/controls/types.ts#L68-L70

This creates a single-line text input. However, it would be nice to support a textarea control which makes it easier to support longer text strings.

### Describe the solution you'd like

We could add the following option:

```
export interface TextConfig {
  maxLength?: number;
  rows?: number;
}
```

If set, it would pass the rows to the underlying `Form.Textarea` component here:

https://github.com/storybookjs/storybook/blob/next/code/ui/blocks/src/controls/Text.tsx#L51

### Describe alternatives you've considered

We could also create a new control type. But I think adding an option is lighter weight/cleaner.

### Are you able to assist to bring the feature to reality?

yes, I can

### Additional context

_No response_
Repository: material-ui
Issue: In the theme, allow for width and height to take part in a breakpoint definition 
Labels: new feature,package: system,customization: theme

### Summary 💡

We can already define custom breakpoints, like:
```
    const theme = createTheme({
      breakpoints: {
        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
        //@ts-ignore
        values: {
          mobile: 0,
          tablet: 640,
          laptop: 1024,
          desktop: 1280,
        },
      },
    });
```
that works ok when devices are in portrait. But what if people rotate their phones?
They would suddenly get the tablet-designs, since now width > 640 for most modern phones but we still might not want to show the tablet-designs on mobile phones.

I would love if we could define mobile as:

`@media (max-width: 600px), (max-height: 600px)` so phones in both landscape and portrait are under the mobile breakpoint.


### Examples 🌈

With the `<Grid>` component for example we can do:
```
              <Grid item xs={12} sm={3}>
```
now, I would like this grid to not change, when going from Portrait to Landscape on iPhones.

### Motivation 🔦

Keeping designs consistent between landscape and portrait on mobile phones.
Repository: vscode
Issue: Hover API does not match LSP specification: Strange Horizontal Line rendering
Labels: bug,markdown,editor-hover

The LSP spec defines the [return type of the hover](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#hover):
```typescript
/**
 * The result of a hover request.
 */
export interface Hover {
	/**
	 * The hover's content
	 */
	contents: MarkedString | MarkedString[] | MarkupContent;

	/**
	 * An optional range is a range inside a text document
	 * that is used to visualize a hover, e.g. by changing the background color.
	 */
	range?: Range;
}
```

While VS Code uses arrays everywhere:
```typescript
export class Hover {
	contents: Array<MarkdownString | MarkedString>;
...
}
```

`MarkedString` is deprecated so it is recommended to use `MarkupContent`. However, using `MarkupContent` content (with `---` to separate content) in VS Code results in very small line heights. Compared to sending an array of `MarkedString`:

Returning an array of `MarkedString` (deprecated):
![image](https://user-images.githubusercontent.com/12927950/218995840-22b24f2b-31eb-453e-921d-89ad3b3b9659.png)

Returning a single `MarkupContent`:
![image](https://user-images.githubusercontent.com/12927950/218996078-970a1b07-c7ea-4e48-95bb-37395b164782.png)

Given that we can only return a single `MarkupContent`, how can we separate content like in the deprecated way above? (We currently use `---` to add a horizontal line)? 

Note: The issue only happens if using the markdown separators, if we remove the `---` we get this, which looks good but still needs the separators:
![image](https://user-images.githubusercontent.com/12927950/218999176-98043f89-b3da-4c20-9d9f-5437a19ef148.png)

The API is relevant here because an array can be used to separate content but that is not in the (non-deprecated) LSP spec, so we have to use a horizontal line for it work as expected...
Repository: godot
Issue: SpinBox doesn't respect focus neighbor settings
Labels: bug,topic:gui

### Godot version

3.5.2.rc, 4.0-latest

### System information

Arch Linux

### Issue description

Setting focus neighbor properties on SpinBox nodes doesn't work. Writing a hack to manually add focus neighbors to internal LineEdit nodes does work:
```gdscript
func _ready():
	var neighbor := focus_neighbour_bottom
	var neighbor_line_edit = get_node(neighbor).get_line_edit().get_name()
	var raw_path := ".."
	for i in range(neighbor.get_name_count()):
		raw_path += "/" + neighbor.get_name(i)
	raw_path += "/" + neighbor_line_edit
	print(raw_path)
	get_line_edit().focus_neighbour_bottom = NodePath(raw_path)
```

Because SpinBox uses an internal LineEdit, there are other issues similar issues regarding focus which are confusing to users (#71305, #43338).

### Steps to reproduce

- Create two SpinBox nodes (`SpinBox1` and `SpinBox2`)
- Set them apart horizontally, such that automatic vertical focus detection won't work
![image](https://user-images.githubusercontent.com/6501975/219016855-437e731a-b582-4193-a085-6536bfd47035.png)
- Set bottom neighbor for `SpinBox1` to `SpinBox2`
- Set top neighbor for `SpinBox2` to `SpinBox1`
- Run scene and try keys up/down on both boxes to switch focus. It won't work
    - A similar setup done with `LineEdit` instead will work.

### Minimal reproduction project

[repro.zip](https://github.com/godotengine/godot/files/10742512/repro.zip)
(SpinBox1 has the hack script to set it's bottom neighbor, SpinBox2 doesn't)
Repository: tauri
Issue: [bug] AppImage does not get renamed after automatic update
Labels: type: bug,platform: Linux,status: needs triage

### Describe the bug

When I update an AppImage on Ubuntu 22.04 the update gets successfully installed but the AppImage file keeps the old version number in its filename. I tested that the filename is not affected at all by an update since it also does not change after two subsequent updates.



### Reproduction

1. Make an app with updater via static JSON file and release it on github using tauri-actions
2. Update the app on Ubuntu 22.04 (AppImage)

Repository to reproduce the behavior: https://github.com/matthme/updater-test

### Expected behavior

I think I would expect the filename of the `.AppImage` to be adapted to the new version number.

I see that the user could in principle have renamed the file manually earlier and thus it might also cause weird behavior when the updater "renames it back" to the original filename but with the new version number. I think however that a version number is an important thing to be able to identify by an end-user in some cases and having the wrong version number in the file is dangerously misleading.

### Platform and versions

Ubuntu 22.04

### Stack trace

_No response_

### Additional context

The version number in the `.AppImage` file is automatically generated via tauri-action in the release workflow.

The problem is not there with the `.app.tar.gz` files for macOS because for some reason they don't get a version number injected into their filename by tauri-actions.
Repository: puppeteer
Issue: how can i Intercept custom URL schemes request?
Labels: feature

```     
 await page.setRequestInterception(true);   
  page.on('request', async req => {  
    console.log(req.url(), 6666)  
    req.continue();  
  });  
```
when url like 'fb://profile' and 'fb://friends', it not works.
Repository: flutter
Issue: [macOS] Tap gestures not working properly with magic mouse
Labels: platform-mac,f: gestures,a: desktop,P2,team-macos,triaged-macos

Code:

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: GestureDetector(
          behavior: HitTestBehavior.opaque,
          onPanStart: (details) => {
            print('onPanStart'),
          },
          child: GestureDetector(
            behavior: HitTestBehavior.opaque,
            onTapUp: (e) {
              print('onTapUp');
            },
          ),
        ),
      ),
    );
  }
}
```

To reproduce:
1. Scroll with left finger
2. After scrolling, try clicking with left finger (without lifting it off the mouse)

After that clicking with left finger will not report the *tap up* gesture until user lifts the left finger.

I think the problem here is that in this case macOS reports the pan zoom event in parallel with mouse down/up events, which is something the framework is not prepared to handle. The pan gesture recognizer always wins until the gesture event with NSEventPhaseEnded is dispatched, which happens after left finger lift.

cc @moffatman, @Piinks
Repository: godot
Issue: When a file has syntax errors and is preloaded, the project gives strange errors from the editor
Labels: discussion,topic:gdscript

### Godot version

v4.0.beta14.official [28a24639c]

### System information

Mac

### Issue description

When I have a syntax error such as `mixing tabs and spaces` in any given file.

When I then run the project from a terminal instead of the `godot` editor.

I see strange errors:

`SCRIPT ERROR: Parse Error: Could not preload resource script "res://addons/cs-some/something.gd".`

I must then open this file in the Godot editor to figure out exactly on which line the error occurs.

### Steps to reproduce

1. Add an extra `:` somewhere in any file
2. Try to run your project from the terminal

### Minimal reproduction project

See above
Repository: go
Issue: testing,runtime: calling `t.Helper()` in a goroutine logs asm file names, not the one from the call site
Labels: NeedsInvestigation,compiler/runtime

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.20.1 darwin/arm64
</pre>

### Does this issue reproduce with the latest release?

1.20.1 is the latest release at the moment.

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/USER/Library/Caches/go-build"
GOENV="/Users/USER/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/USER/.gvm/pkgsets/go1.20.1/global/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/USER/.gvm/pkgsets/go1.20.1/global"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/USER/.gvm/gos/go1.20.1"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/USER/.gvm/gos/go1.20.1/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.20.1"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/0m/_63w01516tgf3cftmp9h7ylm0000gn/T/go-build1387756731=/tmp/go-build -gno-record-gcc-switches -fno-common"

</pre></details>

### What did you do?

Calling `t.Helper()` in helper that spawns a goroutine that calls `t.Log()` in that goroutine doesn't account for the `t.Helper()` call - that is expected, not the same `func`.

Calling `t.Helper()` and `t.Log()` inside the goroutine spawned in a function logs asm related file name - unexpected.

```go
package thelper

import (
	"sync"
	"testing"
)

func Test(t *testing.T) {
	t.Log("calling helper")
	helper(t)
}

func helper(t *testing.T) {
	t.Helper()
	t.Log("in helper")

	var wg sync.WaitGroup
	wg.Add(1)
	go func(t *testing.T) {
		defer wg.Done()
		t.Helper()
		t.Log("in helper's goroutine")
	}(t)
	wg.Wait()
}

```

### What did you expect to see?

```
=== RUN   Test
    main_test.go:9: calling helper
    main_test.go:10: in helper
    main_test.go:10: in helper's goroutine
--- PASS: Test (0.00s)
PASS
ok      thelper 0.004s
```

### What did you see instead?

```
=== RUN   Test
    main_test.go:9: calling helper
    main_test.go:10: in helper
    asm_arm64.s:1172: in helper's goroutine
--- PASS: Test (0.00s)
PASS
ok      thelper 0.004s
```
Repository: bitcoin
Issue: Disallow duplicate leaves inside `tr()` descriptors
Labels: Descriptors

While working on adapting Miniscript to Tapscript, i [noticed](https://gist.github.com/sipa/06c5c844df155d4e5044c2c8cac9c05e?permalink_comment_id=4434770#gistcomment-4434770) signatures in Tapscript only commit to the leaf (i previously assumed they committed to the whole branch). It's been discussed lately on the mailing list as well ([1](https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2023-February/021452.html), [2](https://github.com/bitcoin-inquisition/bitcoin/issues/19)).  This means if the same script is used in two different leaves, a signature for one can be rebound to the other.

If one signed a transaction it shouldn't matter what script path it used as long as the transaction itself didn't change [0]. However, the possibility to change the script path used may cause two issues:
1. It messes up with Miniscript's malleability analysis (and is a malleability vector in itself).
2. It allows to potentially hinder the confirmation of a transaction if the two leaves aren't at the same height ([h/t aj](https://gist.github.com/sipa/06c5c844df155d4e5044c2c8cac9c05e?permalink_comment_id=4434792#gistcomment-4434792)).

I don't think 1. is a valid point. Miniscript's analysis is about malleability from a third party that only gets to see a single satisfaction. The composition of the tree would not be known to the third party here, therefore they wouldn't be able to malleate.

This leaves 2. which is more important in the context of presigned transactions, and in this case we'd expect protocol designers to take great care when designing the descriptors used so it would most likely not be an issue.

On the other hand it really is inexpensive to check, and AFAICT it serves no purpose to duplicate a leaf. So we could avoid a potential future footgun we didn't anticipate for cheap?

@sipa @achow101 @apoelstra @sanket1729 thoughts?

[0] Some may argue this doesn't always hold, while it may be valid it's imo out of scope here.
Repository: godot
Issue: Tileset heavily drops frames while panning or zooming if mouse cursor is over the active area.
Labels: enhancement,topic:editor,topic:2d,performance

### Godot version

4.0 Beta RC2

### System information

Windows 10, Nvidia GTX 1660Ti, Vulkan

### Issue description

When you add atlas texture and make tiles from it and try to pan around the tileset or zoom in/out, or just move cursor over the tiles watching where the active (white border) currently is, if your mouse cursor is over the active area (base tiles area) as in the video the FPS drop heavily. If mouse cursor never gets over the active area everything seems to be reasonably smooth.

https://youtu.be/ICz9zsGkg_w

### Steps to reproduce

Add TileMap
Add TileSet
Add Atlas
Add texture to the atlas
Pan around with mouse (middle mouse button) or try to zoom in/out when your cursor is over the base tiles area and when outside.

### Minimal reproduction project

[TilesetFPSdrop.zip](https://github.com/godotengine/godot/files/10743913/TilesetFPSdrop.zip)
Repository: angular
Issue: Add an ability to change SAFE_URL_PATTERN for app/service/component
Labels: area: security,core: sanitization

### Which @angular/* package(s) are relevant/related to the feature request?

core

### Description

Here we have limited safe protocols.
https://github.com/angular/angular/blob/main/packages/core/src/sanitization/url_sanitizer.ts#L37

For example, my backend returned HTML-layout (some article, for example) with links for Telegram or Steam client, them have own protocol - `tg://` and `steam://`. And I want to make it safe, but without calling the `bypassSecurityTrustHtml` that force doing all protocols are safe.

### Proposed solution

Ideally for me it should be DI config, where I can set my safeUrlPatterns.
For example:
```ts
@Component({
  selector: 'app-my-article',
  standalone: true,
  imports: [
    SanitizerModule.forRoot({
      // Flexible but not user friendly options
      safeUrlPatterns: /^(?:(?:ts|steam):|[^&:/?#]*(?:[/?#]|$))/gi,
      // Or just define protocols
      safeUrlProtocols: ['tg', 'steam'],
    }),
  ],
})
```

### Alternatives considered

For now I should call the `bypassSecurityTrustHtml` method that make more than I want, and it's not safe for this task.

Relative issues:
https://github.com/angular/angular/issues/12840#issuecomment-261026830
Here described how to work just with the src attribute on the element.
But my question is about full html article that we getting from backend. It can contain any layout and tags by WYSISYG, including links.

https://github.com/angular/angular/issues/31462
Here author just adding some protocols. It's good for standarts supporting, but not provide flexible controls on the sanitizer rules.