sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: pytorch
Issue: DPP training incompatibility with checkpoint and detach
Labels: oncall: distributed,triaged,module: ddp

### 🐛 Describe the bug

I am using pytorch ddp to train my model. Turns out if I use ddp, then I can not use checkpoint or detach gradient. The incompatibility is a big problem, because these techniques are important for my use.

My model consists of two part roughly, a language model for generate representation,  where weights are detached, another part of the model is trained  with gradients. 

the code of the language model:
```python
if exists(config.msa_bert.msa_bert_config.model_weight) and not config.msa_bert.skip_load_msa_bert:
                self.bert_model = load_pretrain(self.bert_model, config.msa_bert.msa_bert_config.model_weight)

if config.msa_bert.msa_bert_config.freeze:
    print('    frezze pretrained msa transformer')
    for param in self.bert_model.parameters():
        param.detach_()
    self.bert_model.eval()

```
Note in the other part of my model, there are recycles with detach.
```python
for i in range(n_recycle):
            msa_fea, pair_fea = self.feat_extractor(msa_fea, pair_fea)
            msa_fea, pair_fea = msa_fea.detach_(), pair_fea.detach_()
```
When using ddp, I have to turn on the `find_unused_parameters=True `, otherwise a error would be raised: `RuntimeError: Expected to have finished reduction in the prior iteration before starting a new one. `
Seems like if you have a model with detached params, you have to turn on this.
Here comes the problem, if I keep `find_unused_parameters=True ` and enable checkpoint, an error would be raised because a variable is marked twice.
I conjecture that during forward, those detached parameters are marked as ready because of  `find_unused_parameters=True `, and somehow they are marked ready again and causes this error.

I am wondering in what cases  a param would be marked as ready again?
And, what does it means for a param to be marked as ready? I think it is something to do with the autograd and the gradient compute map.

I accidentally find a solution that turn off the recycle ( i.e.,  turn off detach) and checkpoint while keep  `find_unused_parameters=True `, the ddp training works.
However, the problem is I can not turn off them as they are important for the efficiency. Without checkpoint, the gpu memory would explode.




### Versions

python3.8

cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @SciPioneer @H-Huang @kwen2501 @ezyang
Repository: PowerToys
Issue: I really like the "Window Switching" feature that's in FancyZones, but don't like that the windows have to occupy the exact same regions
Labels: Idea-Enhancement,FancyZones-Hotkeys

### Description of the new feature / enhancement

This feature would be a lot more useful if they switched between ANY windows that shared ANY of the same regions. Right now, the Window Switching shortcuts only work if two or more windows share the exact same region, or group of regions. 

### Scenario when this would be used?

For example, I have a small window in a quadrant hidden underneath a window that's taking up a half. I'd like the Window Switching shortcuts to switch between bringing the quadrant on top and the half on top, making it much more flexible. It would enable "window discovery" with the keyboard as well instead of having to alt-tab to find things that are hidden. 

### Supporting information

_No response_
Repository: rust
Issue: The list of `target_feature` attributes is missing values such as `rdpid`.
Labels: A-docs,A-target-feature

The list of `target_feature` attributes is missing values such as `rdpid`, and does not make clear if the list is definitive or tied to the version of LLVM.

See <https://doc.rust-lang.org/reference/attributes/codegen.html#the-target_feature-attribute>.
Repository: vscode
Issue: Memoize the edit sessions displayed in the edit sessions view
Labels: debt,cloud-changes

There are currently a lot of duplicated network requests for edit sessions contents, we should memoize them to reduce network pressure.
Repository: pytorch
Issue: [CI] Split up periodic.yml into forward-fixable.yml and periodic.yml
Labels: module: ci,triaged

We want to move toward a future where we do not revert people based on periodic failures (and instead opt for forward fixing). To get there, we should:

1. Split up periodic.yml into two parts. Both should be periodic, but we should start creating a distinction between forward-fixable periodic tests and ones that we will revert devs for. Eventually, we want to move the second portion of tests to trunk/land validation.
2. forward-fixable should thus neither be included in our reliability stats nor block viable/strict upgrades

cc @seemethere @malfet @pytorch/pytorch-dev-infra
Repository: pytorch
Issue: [CI] Create periodic fuzzy testing for PyTorch build flags
Labels: module: ci,triaged

We should have CI to test flag compatibility for PyTorch. 

Proposal: add a periodic job that randomly pick flags to enable + tries building.

The key blocker here is that we would need to make sure we have an owner to forward fix when the flags are incompatible.

cc @seemethere @malfet @pytorch/pytorch-dev-infra
Repository: TypeScript
Issue: Support inlay hint text edits
Labels: Suggestion,Awaiting More Feedback

## Search terms
- inlay hint

# Feature request

VS Code allows inlay hints to define a text edit that is applied when the hint is double clicked:

https://github.com/microsoft/vscode/blob/d949bdfb48025dd1b0e22b05501860b8f9fb6cb8/src/vscode-dts/vscode.d.ts#L4936


For JS/TS, we should support this on the type style inlay hinds, such as those for inferred types. In these cases, double clicking should add the explicit typings to the file 


This edit can be resolved lazily too if computing it in the original request is too expensive
Repository: go
Issue: Research how to automate follow-up on which cherry-pick items have a CL that haven't been reviewed (is stagnant).
Labels: NeedsInvestigation

Research how to automate follow-up on which cherry-pick items have a CL that haven't been reviewed (is stagnant).
Repository: vscode
Issue: Allow Command Center to center over editor
Labels: feature-request,quick-pick,command-center

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
Previously, the command center was centered over the the file editor. I prefer this as I split the window across multiple monitors. In release 1.70.0, it is now centering across the entire window. This is not ideal in my multiple monitor setup. Could this be a settings item?

![image](https://user-images.githubusercontent.com/56938681/183747385-f4507e62-65b7-45f8-94df-b0dc72a3a770.png)

Thanks,
- Nolan
Repository: TypeScript
Issue: Contextual 'this' parameter in JSDoc doesn't show correct completions after property assignment on `this` in function-valued object literal property
Labels: Bug,Help Wanted

# Bug Report

### 🔎 Search Terms

- js this type
- js this function property
- function property this type

### 🕗 Version & Regression Information

- This is the behavior in every version I tried, and I reviewed the FAQ for entries about "Functions"

### ⏯ Playground Link

N/A - involves JS code which cant be emulated in playground at the moment

### 💻 Code

<!-- Please post the relevant code sample here as well-->

Below are some examples of the issue including the tsconfig.json and the code. The code comments describe what suggestions the intellisense provide, and here is what is expected, ie the types showing up on `this` as defined in the ts file:

![image](https://user-images.githubusercontent.com/13420359/183746918-3525135c-be30-4615-881f-8dec462cd462.png)

The issue is below, where if the function assigns any property to `this` then the intellisense for `this` is limited to those assigned properties and ignores the defined type, e.g.:

![image](https://user-images.githubusercontent.com/13420359/183747128-0c90efbd-67db-48e1-ad12-1b8c76e3f02d.png)

### 🙁 Actual behavior

If the function assigns any property to `this` then the intellisense for `this` is limited to those assigned properties and ignores the defined type.

### 🙂 Expected behavior

The issue above seems to only be for function properties with function declarations ie `{property: function() {...}}` if the function property uses shorthand ie `{property() {...}}` then the expected behaviour occurs regarding the typing of `this`, ie there is intellisense based on the defined type of `this` regardless of what happens in the function (from what I have tried). 

For example:
![image](https://user-images.githubusercontent.com/13420359/183747287-8799f99f-1689-4f9a-b918-566af3aa5c10.png)

From my understanding the function declaration and shorthand notations shouldnt have different behaviour according to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions, so the typing also shouldnt behave differently.

Turning on `checkJs` fixes the issue however it means migrating to TS is more difficult as all the issues need to be fixed before getting any of the benefits e.g. intellisense, and this also limits functionality for large code bases migrating to TS but with a lot of legacy JS code.
Repository: godot
Issue: [3.x] GDScript parser return type not properly determined when using match/continue/wildcard
Labels: bug,discussion,topic:gdscript

### Godot version

3.5 stable

### System information

W10

### Issue description

Hope the title isn't too confusing.

The following code I expect will always return false. The control flow is unusual, but all code paths lead to the same return.

```gdscript
func test(x) -> bool:
	match x:
		0:
			continue
		_:
			return false
```

However, the parser complains:
```
Parse Error: A non-void function must return a value in all possible paths.
```

### Steps to reproduce

See above

### Minimal reproduction project

_No response_
Repository: godot
Issue: Mark built-in resources as embedded in the engine in the editor's Video RAM panel
Labels: enhancement,topic:editor,topic:3d

### Godot version

3.5

### System information

Linux Fedora 35 - CPU AMD Ryzen 3 2200 G - GLES2

### Issue description
![test2](https://user-images.githubusercontent.com/40866219/183753160-ebec1698-2800-42df-aa65-cc930da5d3d5.jpg)

I am testing and creating various simple projects to benchmark the Godot Engine.
I created a blank project with only 1 node no script, no images, nothing. And testing this blank project I see a dark window... ok perfect. But in the Video Ram section I see various textures with diferent sizes consuming 1,77MB of RAM.
What I can do to eliminate this textures? Where I can find them?

Even if you export the csv file the path is blank.
If this section is to show the resources consuming RAM, some explanation about this various files need by show in the editor or documentation.

1,77MB for mobile development is a large value. This can not stay without information.

### Steps to reproduce

1- Create a blank project.
2- Add a node
3- Press run button
4- See the Video Ram section in the editor

### Minimal reproduction project

[Test Blank.zip](https://github.com/godotengine/godot/files/9294268/Test.Blank.zip)
Repository: pytorch
Issue: [FSDP] `test_summon_single_param()` is misleading
Labels: triaged,module: fsdp

Code pointer:
https://github.com/pytorch/pytorch/blob/6c60a656b02fbd09661b282bec53940b184db3ca/test/distributed/fsdp/test_fsdp_summon_full_params.py#L269-L288

---

WLOG suppose we have a world size of 2.
- The original parameter (i.e. the linear's weight) is like `[[X]]` where `X` is some initial value and the shape is `[1, 1]`.
- The unpadded unsharded flattened parameter is like `[X]` where the shape is `[1]`.
- The padded unsharded flattened parameter is like `[X, 0]` where the shape is `[2]`. (For larger world sizes, we pad more like `[X, 0, 0, 0]` for world size of 4.)
- After we run on both ranks
    ```
    with torch.no_grad():
        p[0] = self.rank + 2
    ```
    rank 0's local shard is `[2]`, and rank 1's local shard is `[3]`.
- When we run on both ranks
    ```
    with model.summon_full_params(model, writeback=True):
        with torch.no_grad():
           p.copy_(torch.zeros_like(p))
    ```
    `p` is actually the unpadded unsharded flattened parameter on both rank 0 and rank 1. ([code0](https://github.com/pytorch/pytorch/blob/6c60a656b02fbd09661b282bec53940b184db3ca/torch/distributed/fsdp/fully_sharded_data_parallel.py#L2548), [code1](https://github.com/pytorch/pytorch/blob/6c60a656b02fbd09661b282bec53940b184db3ca/torch/distributed/fsdp/fully_sharded_data_parallel.py#L3348)) In other words, if you print `p` in the `summon_full_params()` context, you see `[2]` for both rank 0 and rank 1. This means that the `copy_()` writes to the `0`th element for both ranks. There is not an attempt to zero the `1`st element of the padded unsharded flattened parameter.

We see that this test actually tests whether changes to the padding made before `summon_full_params()` persist after `summon_full_params()`. We could change the `p.copy_(torch.zeros_like(p))` to only run on rank 0, and the test would work just the same.

Personally, I am not sure if FSDP should make any guarantees on persisting writes to the padding. It does not seem like a real use case. 

cc @zhaojuanmao @mrshenli @rohan-varma @ezyang
Repository: vscode
Issue: Outline headers scroll to wrong place
Labels: bug,help wanted,notebook-markdown,notebook-toc-outline

### Applies To

- [X] Notebooks (.ipynb files)
- [ ] Interactive Window and\/or Cell Scripts (.py files with \#%% markers)

### What happened?

When you open a notebook that has headings, there is an outline browser when the Explorer panel is open on the left. 

<img width="1200" alt="image" src="https://user-images.githubusercontent.com/6486256/183557859-dd7011a0-897c-417f-8f97-30c0d0e88dd5.png">

When you click on a markdown header listing, as shown in the screen cap above, it scrolls the heading to like 25% of the window below the top. When you click on a markdown cell listed in the outline, it puts the top of the cell at the top of the window:

<img width="1200" alt="image" src="https://user-images.githubusercontent.com/6486256/183558036-b3f1142e-7c92-49ff-b5a2-c63a942b32bf.png">

I think they both should have the same behavior of scrolling the heading or cell to the top of the window.

[Repro notebook shown above](https://gist.github.com/crazy4pi314/f0b25fb4d57940e436979e34b2e93d72)

### VS Code Version

Version: 1.70.0 (user setup) Commit: da76f93349a72022ca4670c1b84860304616aaa2 Date: 2022-08-04T04:38:16.462Z Electron: 18.3.5 Chromium: 100.0.4896.160 Node.js: 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.22000

### Jupyter Extension Version

v2022.7.1002181843

### Jupyter logs

_No response_

### Coding Language and Runtime Version

Python 3.7.12

### Language Extension Version (if applicable)

v2022.12.0

### Anaconda Version (if applicable)

conda 4.13.0

### Running Jupyter locally or remotely?

Local
Repository: rust
Issue: Tracking Issue for Deprecate target_vendor
Labels: T-lang,C-tracking-issue,S-tracking-impl-incomplete

This is a tracking issue for the MCP "Deprecate target_vendor" (https://github.com/rust-lang/lang-team/issues/102).

### About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

### Steps
<!--
Include each step required to complete the feature. Typically this is a PR
implementing a feature, followed by a PR that stabilises the feature. However
for larger features an implementation could be broken up into multiple PRs.
-->

- [ ] Implement the MCP (cc @rust-lang/lang -- there are solution sketches written out on https://github.com/rust-lang/lang-team/issues/102#issue-936041579)
- [ ] Adjust documentation ([see instructions on rustc-dev-guide][doc-guide])
- [ ] Stabilization PR ([see instructions on rustc-dev-guide][stabilization-guide])

[stabilization-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs

### Unresolved Questions
<!--
Include any open questions that need to be answered before the feature can be
stabilised.
-->

* @scottmcm [asked](https://github.com/rust-lang/lang-team/issues/102#issuecomment-873236073) "What, technically, do you expect "deprecated" to mean here?"
* @thomcc [wondered](https://github.com/rust-lang/lang-team/issues/102#issuecomment-1098231398) if adding more values to `target_family` might be problematic.

### Implementation history

<!--
Include a list of all the PRs that were involved in implementing the feature.
-->
Repository: rust
Issue: Tracking Issue for Interoperability With C++ Destruction Order
Labels: T-lang,C-tracking-issue,S-tracking-impl-incomplete

This is a tracking issue for the MCP "Interoperability With C++ Destruction Order" (https://github.com/rust-lang/lang-team/issues/135).

### About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

### Steps
<!--
Include each step required to complete the feature. Typically this is a PR
implementing a feature, followed by a PR that stabilises the feature. However
for larger features an implementation could be broken up into multiple PRs.
-->

- [ ] Implement the RFC (cc @rust-lang/lang -- can anyone write up mentoring
      instructions?)
- [ ] Adjust documentation ([see instructions on rustc-dev-guide][doc-guide])
- [ ] Stabilization PR ([see instructions on rustc-dev-guide][stabilization-guide])

[stabilization-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs

### Unresolved Questions
<!--
Include any open questions that need to be answered before the feature can be
stabilised.
-->

* What is the right name for the attribute?
* There was much discussion about whether fine-grained control over drop order (e.g., `drop_order(from_end)` and `drop_order(from_start)`) or if even more flexible mechanisms (manually list out order for each field) is warranted here.
* should `#[manually_drop]` suppress destructuring?

### Implementation history

<!--
Include a list of all the PRs that were involved in implementing the feature.
-->
Repository: flutter
Issue: [go_router] use an event emitter instead of a logger
Labels: package,c: proposal,P3,p: go_router,team-go_router,triaged-go_router

# Proposal

use an event stream instead of a logger. 

## cons of logger:
 
 - Adds yet an additional logger library or whatever the logging code that is used, and yet another log format.
 - Cannot be easily intercepted / manipulated
 - Not logged how *I want it to be logged*

## pros of event emitter

- Router events can be reacted to
- Router events can be manipulated / filtered
- Router events can be logged with the application logging system
- Can emit more events / finer grained events, the consumer can filter the result.

If every library did this you would end up with a terminal that is a mess (well they kind of do but two wrongs don't make a right). If the logging was added for being user friendly, `router.listen(log);` isn't really less friendly
Repository: PowerToys
Issue: [Run][Program] Fail to initialize plugins error
Labels: Issue-Bug,Product-PowerToys Run,Needs-Triage,Run-Results (Programs)

### Microsoft PowerToys version

0.61.1

### Running as admin

- [X] Yes

### Area(s) with issue?

General, PowerToys Run

### Steps to reproduce

Open PowerToys either in normal or admin mode, regardless if machine has been restarted or program has been reinstalled (including files being removed).

Below error is shown after launching PowerToys.

![image](https://user-images.githubusercontent.com/96308287/183772910-7263f2d6-0832-4fe7-98b1-0dd0fb41a2b7.png)

Similar case which was deemed as resolved under #11511 where that version 0.55 would fix it, but now since may have come back.

### ✔️ Expected Behavior

PowerToys opens as normal then use features such as being able to search for a program to open.

### ❌ Actual Behavior

Receive an error message stating: "Plugins: Program - fail to load and would be disabled, please contact plugins creator for help"

Additionally unable to search for any programs to launch such as Google Chrome, Edge, File Explorer and Settings.

### Other Software

_No response_
Repository: flutter
Issue: Tests using `toImage` in Firefox fail in headless mode due to no WebGL
Labels: a: tests,platform-web,e: web_canvaskit,browser: firefox,P2,team-web,triaged-web

Tests using `Picture.toImage` do not work in Firefox since we run it in headless mode and headless mode has no WebGL support, which is needed for `toImage` in order to support texture-backed images.

Perhaps it would be better to disable browser image decoding if there is no WebGL support?