sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: kubernetes
Issue: Cannot update HPA objects using object metrics with AverageValue
Labels: kind/bug,sig/autoscaling,triage/accepted

**What happened**:

When attempting to label a HorizontalPodAutoscaler (autoscaling/v2beta2) object that has an object metric using `AverageValue`,  received the following error:

```The HorizontalPodAutoscaler "<hpa-name>" is invalid: spec.metrics[0].object.target.value: Invalid value: resource.Quantity{i:resource.int64Amount{value:0, scale:0}, d:resource.infDecAmount{Dec:(*inf.Dec)(nil)}, s:"0", Format:"DecimalSI"}: must be positive```

**What you expected to happen**:

The `label` command should properly label the HPA object with no errors, since the HPA was able to build and run without errors.

**How to reproduce it (as minimally and precisely as possible)**:

1. Create a hpa.v2beta2.autoscaling object that includes the following metric:
```
  - object:
      describedObject:
        kind: Service
        name: svc-name
      metric:
        name: metric-name:sum 
      target:
        averageValue: 4650
        type: AverageValue
    type: Object
```
Make sure that you're using `AverageValue` and don't have a `Value` set.

2. Run the following command:
```
kubectl label hpa hpa_name -n namespace_name testlabel=test
```

**Anything else we need to know?**:

We were able to build and apply the HPA object without encountering any errors, and it appears to be scaling properly. This error only happens when calling `kubectl label` on the existing HPA object.

**Environment**:
- Kubernetes version (use `kubectl version`): tried in both 1.15.3 and 1.16.4
- Cloud provider or hardware configuration: AWS
- OS (e.g: `cat /etc/os-release`): darwin/amd64
- Kernel (e.g. `uname -a`):  Darwin Kernel Version 17.7.0: Fri Jul  6 19:54:51 PDT 2018; root:xnu-4570.71.3~2/RELEASE_X86_64 x86_64
Repository: TypeScript
Issue: Array method definition revamp: Use case collection
Labels: Suggestion,Needs Proposal,Meta-Issue

We've gotten numerous issue reports and PRs to change the methods of `Array`, particularly `reduce`, `map`, and `filter`. The built-in test suite doesn't cover these very well, and these methods interact with each other and the surrounding contextual type in fairly subtle ways.

@jablko has done a great job at #33645 collecting a variety of issues into a single PR; we need to augment this PR (or something like this) with a proper test suite so we can be sure about what's being changed.

I'd like to create a clearinghouse issue here to collect **self-contained** (I CANNOT POSSIBLY STRESS THIS ENOUGH, **SELF-CONTAINED**, DO NOT IMPORT FROM RXJS OR WHAT HAVE YOU) code samples that make use of the array methods.

Please include with your snippet:
 * Compiler settings
 * Compiler version you were testing with
 * The **expected** behavior (examples that should and should not produce errors are both useful)
 * No imports or exports; snippets need to be self-contained so that we can put them into our test suite without extra complications

Once we've established a critical mass of code snippets, we can start combining the existing PRs into an all-up revamp and assess its impact to real-world code suites to figure out which changes don't result in unacceptable breaking changes.

ｓｅｌｆ－ｃｏｎｔａｉｎｅｄ
Repository: go
Issue: x/pkgsite: provide options for sorting search results by number of imports and stars on GitHub
Labels: NeedsInvestigation,pkgsite,pkgsite/search

As requested on https://blog.golang.org/pkg.go.dev-2020: I have found godoc.org to be the best way to search for _quality_ Go modules, significantly because it defaults to sorting by the number of imports (possibly informed by the number of stars).

Compare: https://pkg.go.dev/search?q=smtp

To: https://godoc.org/?q=smtp

Observe, for instance, that on godoc.org, Brad Fitz's smtpd server comes up early, whereas on pkg.go.dev the front page has several packages of much less importance, and smtpd shows up on page 17 after a lot of inner modules and minor forks and larger projects that just happen to have an "smtp" package. Prioritizing hits at the "top level" of the package is probably a good idea, too; github.com/blah/smtpd is much more likely to be what I'm looking for than github.com/blah/project/go/inner1/inner2/smtp.

I also routinely suggest this to newcomers as a way of locating modules for Go.
Repository: vscode
Issue: Emmet match tag fails when tags contain comments jsx
Labels: bug,emmet

<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
Version: 1.41.1
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-18T15:04:31.999Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.0.0-37-generic snap

Command `"editor.emmet.action.matchTag"`

1. Can't jump to matching tag when the tag has a comment on an attribute. Matching still works with other tags such as the child div.
```js
import React from "react";

const Column = () => {
  return (
   {/* Can Not Jump */}
    <div
      className="parent"
      // onClick={() => {}}
      onAbort={() => {}}
      onAbortCapture={() => {}}
    > 
      <div className="child">title</div> {/* Can Jump */}
    </div>
  );
};

export default Column;
```
2. Inferred Types will disable any tag matching. This example is in a tsx file.
```js
import React, { useRef } from "react";

const Column = () => {
  const ref1 = useRef<HTMLElement>(null); // Inferred Type
  
  return (
   {/* Can Not Jump */}
    <div
      className="parent"
      onClick={() => {}}
      onAbort={() => {}}
      onAbortCapture={() => {}}
    > 
      <div className="child">title</div>{/* Can Not Jump */}
    </div>
  );
};

export default Column;

```
Repository: pytorch
Issue: [RFC] Nested scopes in autograd profiler should support RPC calls properly.
Labels: module: autograd,triaged,module: rpc

## 🚀 Feature
As described in https://github.com/pytorch/pytorch/issues/32517, nested scopes in the autograd profiler do not work if there are RPC calls in the scope, an example is as follows:

```
with torch.autograd.profiler.profile() as foo:
    with torch.autograd.profiler.record_function():
        rpc.rpc_async(...).wait()
```

After a discussion with @pritamdamania87, we'd like to propose the following solution for enabling this to work with nested scopes:

1. Currently, setting and unsetting parent pointers to the current, thread-local active record_function exists inside `RecordFunction::processCallbacks()` (run at the beginning of the function) and `RecordFunction::end()` (run at the end of the function). 

We'd like to change these APIs so that `end()` is separated from the code that sets `thread_local_func_ = parent`, into two separate APIs. Users can still call `end()` to do both at once and that will be the normal use case, but for RPC we will call them separately. The newly introduced APIs will be `RecordFunction::runEndCallbacks()` which will just run the end callbacks and not reset the `thread_local_func_`. Instead, this will be handled by `RecordFunction::resetThreadLocalFunc` (or some other name). This function will ensure that the currently active record function points to the parent RecordFunction so that we handle scopes correctly. 


2. When returning from `rpc.rpc_async()` we will call `RecordFunction::resetThreadLocalFunc` to correctly handle the nested scopes. Note that this isn't the end of the RPC since the future has not been satisfied yet. When the future corresponding to this RPC is satisfied we will call `RecordFunction::runEndCallbacks()` as we currently do to correctly accumulate the profiling information.

3. I filed https://github.com/pytorch/pytorch/issues/32883 to track this more closely, but we'd also like to start a longer term discussion on the behavior for the profiler under multithreaded scenarios. For example, node A could be running the following code in one thread:
```
with torch.autograd.profiler.profile() as prof:
    rpc.rpc_async(nodeB, ...)
```
but this could happen while node A is executing torch ops in a separate thread to respond to an RPC from B. In this case, there may be races where those RPCs show up in the profile output but they should not. 


cc @ezyang @SsnL @albanD @zou3519 @gqchen @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar
Repository: flutter
Issue: Move regression test for assets to build system
Labels: a: tests,tool,a: assets,P3,team-tool,triaged-tool

The test that currently lives in https://github.com/flutter/flutter/blob/e03f439145ba5ab0f63092d71546128df165d221/packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart#L58-L74

should be moved to a build system test, since it really requires the whole build system to run.  It will be removed in #49737 but should be added back to a place that makes sense in the build system.

@jonahwilliams
Repository: vscode
Issue: Tab does not work as a trigger character for 
Labels: suggest,under-discussion

<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.41.1
- OS Version: Mac 10.14.6

Steps to Reproduce:

Register a CompletionProvider with tab (`\t`) as a trigger character:

```js
vscode.languages.registerCompletionItemProvider(
  'yaml', myCompletionItemProvider, ' ', '\n', '\t'
)
```
In the above example, the space and new line characters successfully trigger my completion provider, but not tab. This is the case whether my text editor is using tabs or spaces.
Repository: rust
Issue: static mut bindings don't raise unused_mut diagnostic
Labels: C-enhancement,A-lints,T-lang

```rust
#[deny(unused_mut)]
pub unsafe fn foo() {
    static mut X: std::sync::Once = std::sync::Once::new();
    X.call_once(|| { /**/ });
}
```

... [compiles fine.](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=eb6b3a8bd59dee6e53161934988de3e7) Using `let mut X` does fail as expected.

I can imagine it would be hard to do this for module-scoped `static`s since the mutable access could occur in any scope the value is visible to, but could it be done for function-scoped ones at least?

---

I discovered this in a crate with a bunch of function-scoped `Once`s, and just happened to notice some of them had been created with `static mut` and others with just `static`, indicating the `mut` was unnecessary even though the compiler didn't complain.
Repository: TypeScript
Issue: Performance regression in #33473
Labels: Needs Investigation,Domain: Performance,Rescheduled

The extra work done in #33473 is valuable, but maybe it doesn't need to be so expensive.  In this particular case, there don't seem to be any errors (though there is one `@ts-ignore`).

Setup: 

1. Clone https://github.com/amcasey/material-ui.git
2. Check out Benchmark
3. `yarn` to restore packages
4. `yarn typescript` to prebuild and run some TS tests

Repro

1. `tsc -p docs`

On a random Mac Mini:

- 10-run avg on https://github.com/microsoft/TypeScript/commit/6c2ae12559508b594f7038f8d6165b92ec89c58c: 33,010ms
- 10-run avg on https://github.com/microsoft/TypeScript/commit/26caa3793e310e271ddee8adc1804486e5b0749f: 33,494ms (1% slower)

_Note_: to build old TS commits, you probably need to change `const { default: chalk }` to `const chalk` in `scripts/build/utils.js`.
Repository: node
Issue: doc: Improve docs search engine indexing
Labels: doc,meta

<!--
Thank you for reporting a possible bug in Node.js.

Please fill in as much of the template below as you can.

Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify the affected core module name

If possible, please provide code that demonstrates the problem, keeping it as
simple and free of external dependencies as you can.
-->

### There's no way to access api from search engine in one click.

It's very hard to search node api from search engine. A typical example would be searching `node writefilesync`, the top result points to `https://nodejs.org/api/fs.html` without the heading hash `#fs_fs_writefilesync_file_data_options`. 

![image](https://user-images.githubusercontent.com/1488391/73585987-6aaff400-4475-11ea-86f9-ca07a1a72679.png)


In most cases, it's sth like the following, where there's a `jump to xxx` link to the hashed url `https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#Body`

<img width="794" alt="Screen Shot 2020-01-30 at 2 40 14 PM" src="https://user-images.githubusercontent.com/1488391/73484929-30a8fa00-4370-11ea-9ded-0355951e9e15.png">

I'm not sure what's missing here, a quick search seems to suggest search engine need a unique id in headings like `<h4 id="xxx"></h4>` to tell the heading structure.

Since there's no search bar in the doc, it seems using search engine followed by Ctrl+F is the only way to find an api.


<!-- Please provide more details below this comment. -->
Repository: pytorch
Issue: QNNPACK linear doesn't preserve dimensions
Labels: oncall: mobile

When using linear, in the fbgemm and fp implementations the first matrix can be of any rank, while the second has to be of rank 2. The result is expected to be the same rank as the first matrix. For example:
if multiplying two matrices A and B with these dimensions: 

```
A.shape = [b, m, n]
B.shape = [n, k]
```

The resulting matrix C should have dimensions

```
(C = A @ B).shape = [b, m, k]
```

However in QNNPACK the result is `[b*m, k]`

cc @jerryzh168 @jianyuh @dzhulgakov @raghuramank100 @jamesr66a
Repository: create-react-app
Issue: support rootDirs in typescript
Labels: issue: proposal,needs triage


http://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-0.html#virtual-directories-with-rootdirs

We need rootDirs to put our generated codes.
Repository: godot
Issue: Project settings in the wrong place when undo (Ctrl + Z)
Labels: bug,topic:editor

**Godot version:**
Mono 3.2 stable

**OS/device including version:**
5.4.15-arch1-1

**Issue description:**
When you change project settings and then undo with Ctrl + Z, the settings are on the wrong place then.

**Steps to reproduce:**
Example:
1. Open the project Settings
2. Go to Application > Config
3. Reset the Icon
4. Go to Rendering > Quality
5. Set Anisotropic Filtering Level to 16
6. Exit the Settings Menu
7. Press Ctrl + Z twice
8. The Icon can now be found under Rendering > Quality
![Screenshot_20200201_112507](https://user-images.githubusercontent.com/60042618/73590918-93250600-44e8-11ea-899b-e7652cd0b2fe.png)
Repository: pytorch
Issue: Some questions Concerning Intel's DNNL(MKLDNN) support in Pytorch (adding support for Intel Processors GPUs) by transitioning to DNNL
Labels: triaged,module: mkldnn

## ❓ Questions and Help
[Deep Neural Network Library (DNNL)](https://github.com/intel/mkl-dnn) is an open-source performance library for deep learning applications. The library includes basic building blocks for neural networks optimized for Intel Architecture Processors and Intel Processor **Graphics**.  

DNNL supports systems based on Intel 64 or AMD64 architecture.

The library is optimized for the following CPUs:
-   Intel Atom processor with Intel SSE4.1 support
-   4th, 5th, 6th, 7th, and 8th generation Intel Core(TM) processor
-   Intel Xeon(R) processor E3, E5, and E7 family (formerly Sandy Bridge, Ivy Bridge, Haswell, and Broadwell)
-  Intel Xeon Phi(TM) processor (formerly Knights Landing and Knights Mill)
-  Intel Xeon Scalable processor (formerly Skylake and Cascade Lake)
-  future Intel Xeon Scalable processor (code name Cooper Lake)

and it is also optimized for the following GPUs:

-  Intel HD Graphics
-  Intel UHD Graphics
-  Intel Iris Plus Graphics

Currently The MKLDNN version shipped with Pytorch as of yesterday (last nightly build) is version 0.21.1 which dates back to sep 2019. Since that day, Intel has introduced DNNL instead of MKLDNN.
And since version 1.0, there are breaking changes.  
My Questions thus are : 
1. Do we need a lot of work to transision from MKLDNN 0.21.1 to DNNL 1.2 (which provides a lot of benfits in  terms of supporting accelerated computing using integrated GPUs) ? [here](https://intel.github.io/mkl-dnn/dev_guide_transition_to_dnnl.html)'s a transision guide by the way, which seems to be not that time consuming. (excuse my ignorance if thats not the case)   
2. Knowing that DNNL supports both CPUs and Intel **GPUs** for accelerated computing, this would be a great addition to Pytorch. My question thus is, in case we transition to DNNL, would updating the DNNL library, require recomplition, or would it just work out of the box (specially on Python part) ? 
3. In order to incorporate this into Pytorch, what else is required other than the transition  from mkldnn 0.21.1 to the latest version? are there any complications in this regard? 

Thank you all in advance 
 


cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh
Repository: godot
Issue: Strange shading with WorldEnvironment with sky when using a bright HDRI (GLES3)
Labels: bug,topic:rendering,topic:3d

**Godot version:**
3.2 stable

**OS/device including version:**
Manjaro 18.1.5

**Issue description:**
When using WorldEnvironment with a sky panorama I am getting strange shading.
In 3.1 it looks normal.
With metallic set to 1 in the material, it looks like it looks normal.
![Screenshot from 2020-02-01 12-08-35](https://user-images.githubusercontent.com/8601600/73591199-eb113c00-44eb-11ea-9610-eb8f0905c349.png)
![Screenshot from 2020-02-01 12-10-05](https://user-images.githubusercontent.com/8601600/73591201-efd5f000-44eb-11ea-9db5-ad51412cf348.png)



**Steps to reproduce:**
1. Add a WorldEnvironement
2. Set mode to sky
3. Select a sky panorama
4. Add a MeshInstance to the scene and add a new Sphere to it
5. Add a SpatialMaterial to the MeshInstance


**Minimal reproduction project:**
[godot-test.zip](https://github.com/godotengine/godot/files/4142476/godot-test.zip)
Repository: godot
Issue: Can't delete node group after using "make local"
Labels: bug,topic:editor

**Godot version:**
3.2 stable

**OS/device including version:**
Linux Manjaro

**Issue description:**
I have a node that is an inherited scene, the parent scene has a group called "test". If I drop the child node in a new scene and use the "make local" setting with right-click on it I'm then unable to remove the group that has the parent.

**Steps to reproduce:**
Create a "Parent" scene with a simple node and add a group "Test" to it. Create an inherited scene of "Parent" and call it "Child". Create a new scene and drop in it the "Child" scene, then right-click on it and use "make local". Now try to delete the group "Test" from the "Child" node.
Repository: flutter
Issue: [androidx] v1.12.13+hotfix.7 "The built failed likely due to AndroidX incompatibilities" in release
Labels: c: crash,platform-android,tool,t: gradle,dependency: android,a: build,P2,team-android,triaged-android

```console
[√] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [Version 10.0.18363.592], locale de-DE)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[√] Android Studio (version 3.5)
[!] IntelliJ IDEA Community Edition (version 2017.2)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[√] VS Code (version 1.41.1)
[√] Connected device (2 available)

! Doctor found issues in 1 category.

```
**Error Log**
https://pastebin.com/xD2d0f0P

**Problem:**
Debug mode works fine but Release mode not.. when i try to fix it with the given options (--stacktrace/--info) there is a error that the options dont exist
Repository: godot
Issue: C# VisualServer can't get the correct Texture RID
Labels: bug,topic:dotnet

**Godot version:**
3.2 stable

**OS/device including version:**
Windows 10

**Issue description:**
If you try to use VisualServer and the Texture RID then you will get an error. I wanted to draw a texture using VisualServer.

> E 0:00:01.026   IntPtr Godot.RID.GetPtr(Godot.RID ): System.NullReferenceException: The instance of type RID is null.
>   <C++ Error>   Unhandled exception
>   <C++ Source>  /root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/RID.cs:15 @ IntPtr Godot.RID.GetPtr(Godot.RID )()
>   <Stack Trace> RID.cs:15 @ IntPtr Godot.RID.GetPtr(Godot.RID )()
>                 VisualServer.cs:4683 @ void Godot.VisualServer.CanvasItemAddTextureRect(Godot.RID , Godot.Rect2 , Godot.RID , Boolean , System.Nullable`1[Godot.Color] , Boolean , Godot.RID )()
>                 test.cs:15 @ void test._Ready()()


**Steps to reproduce:**
Just create a new Node2D and assign the script.

**Minimal reproduction project:**


```
using Godot;
using System;

public class test : Node2D {
	[Export]
	public Texture texture;

	[Export]
	public Rect2 rect2;

	public override void _Ready() {
		GD.Print(texture.GetRid());
		RID item = VisualServer.CanvasItemCreate();
		VisualServer.CanvasItemSetParent(item, GetCanvasItem());
		VisualServer.CanvasItemAddTextureRect(item, rect2, texture.GetRid());
	}
}

```
Repository: go
Issue: cmd/compile: escape analysis on interface calls
Labels: Performance,NeedsInvestigation,compiler/runtime

### What version of Go are you using (`go version`)?
1.13.1

### Does this issue reproduce with the latest release?
yes

### What operating system and processor architecture are you using (`go env`)?
on any OS / env

### What did you do?
`type myCtx struct {
    data int
}`

`type interface if {
   Call(ctx *myCtx)
}`

`ctx := myCtx{}`
`i.Call(&ctx)   // i == interface of type 'if'`

### What did you expect to see?
ctx allocated on stack (as Call() method was empty in my case).

### What did you see instead?
ctx allocated on heap as escape analysis doesn't work through interface types. Compiler simply doesn't know the future of the pointer.

### Suggestions
As interfaces are widely used in the language it seems quite important to be able to perform such optimisations.
What if interface run-time type info had escape flag for the method. That would allow to generate code for both escaping interface calls and non-escaping ones.
Repository: pytorch
Issue: Optional seq_len argument to torch.nn.utils.rnn.pad_sequence
Labels: triaged,function request,module: padding

## 🚀 Feature

torch.nn.utils.rnn.pad_sequence should take an optional argument that specifies the padded length of the sequence.

## Motivation

Suppoose I have a batch of sentences of different lengths 1-100, and I want to pad batches to length 100 (because say my model only takes length-100 sequences). You can't currently do that.

## Alternatives

You can hack it by cat-ing an extra tensor onto the end of the padded tensor.