sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: x/tools/gopls: signatureHelp should return position info for signatures
Labels: help wanted,FeatureRequest,gopls,Tools

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version devel +385b2e0cac Fri May 24 21:34:53 2019 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20190521203540-521d6ed310dd
</pre>

### Does this issue reproduce with the latest release?

Yes

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/home/myitcv/gostuff/src/github.com/myitcv/govim/cmd/govim/.bin"
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build579955727=/tmp/go-build -gno-record-gcc-switches"
</pre></details>



The signature help call from client to server (https://github.com/Microsoft/language-server-protocol/blob/gh-pages/specification.md#signature-help-request-leftwards_arrow_with_hook) returns a list of signatures:

```go
type SignatureHelp struct {
	Signatures []SignatureInformation `json:"signatures"`
	ActiveSignature float64 `json:"activeSignature"`
	ActiveParameter float64 `json:"activeParameter"`
}

type SignatureInformation struct {
	Label string `json:"label"`
	Documentation string `json:"documentation,omitempty"` 
	Parameters []ParameterInformation `json:"parameters,omitempty"`
}

type ParameterInformation struct {
	Label string `json:"label"` 
	Documentation string `json:"documentation,omitempty"` 
}
```

But what's strange is that the signature information does not include position information, i.e. the start (and end, where it's valid/available) of where the call signature is valid: think the starting `(` (to the end `)`).

This position information is valuable to my mind because it tells the client where to place, for example, a popup window.



---

cc @stamblerre @ianthehat
Repository: material-ui
Issue: [Chip] Rename onDelete and deleteIcon
Labels: discussion,breaking change,component: chip

Even the docs show `onDelete` and `deleteIcon` used for purposes other than deleting the Chip. I'd imagine it's common to use them for other purposes.

I propose renaming them to `onSecondaryAction` and `secondaryIcon`, or something similar. The current attributes could be aliases for those so as to not be a breaking change, at least for v4.
Repository: flutter
Issue: Make sure the add-to-app include scripts can build for the correct CPU architecture
Labels: platform-android,tool,a: existing-apps,P2,team-android,triaged-android

Make sure include_flutter.groovy+flutter.gradle and podhelper.rb+xcode_backend.sh embed can figure out what architecture the outer project is trying to build and build the appropriate architecture
Repository: youtube-dl
Issue: Site support request: American Archive for Public Broadcasting
Labels: site-support-request

<!--

######################################################################
  WARNING!
  IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################

-->


## Checklist

<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.05.20. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->

- [ x] I'm reporting a new site support request
- [ x] I've verified that I'm running youtube-dl version **2019.05.20**
- [x ] I've checked that all provided URLs are alive and playable in a browser
- [x ] I've checked that none of provided URLs violate any copyrights
- [ x] I've searched the bugtracker for similar site support requests including closed ones


## Example URLs

<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->

Single video: http://americanarchive.org/catalog/cpb-aacip_259-q23qzn4s
Single video: http://americanarchive.org/catalog/cpb-aacip_259-804xkk0v
Single video: http://americanarchive.org/catalog/cpb-aacip_81-48sbchx0
Single video: http://americanarchive.org/catalog/cpb-aacip_37-97kps40n
## Description

<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->

Incredibly valuable website run by the Library of Congress and WGBH Boston designed to house archival material by public media organizations across the United States.
Repository: flutter
Issue: Handle duplicate platform transient dependencies
Labels: tool,customer: alibaba,a: existing-apps,P3,team-tool,triaged-tool

Assume an inner Flutter project uses a firebase plugin which depends on nanopb, the outer platform project also directly depends on nanopb, and another Flutter plugin also depends on nanopb, make sure we can correctly resolve.
Repository: flutter
Issue: Interaction between modals, scrolls, and focuses
Labels: framework,f: material design,a: fidelity,f: scrolling,P2,team-design,triaged-design

## Description

The way Flutter handles the interaction between modals, scrolls and focuses is different from native Android.

Below are two videos recorded on a native Android app:

![1](https://user-images.githubusercontent.com/1596656/59074870-79142480-8882-11e9-94d8-c5f9ccd4e5d8.gif)
Highlight of this video:
- When a dialog pops up, the on-screen keyboard
  - [ ] **a)** does not disappear
  - [ ] **b)** is rendered hidden behind the overlay
- When the dialog disappears, the previously focused widget
  - [ ] **c)** keeps its focus
  - [ ] **d)** is not scrolled into view

![2](https://user-images.githubusercontent.com/1596656/59075246-79adba80-8884-11e9-8a5b-7387f6d585d1.gif)
Highlight of this video:
- [ ] **e)** In addition to c), if the keyboard was not screen before the dialog, resuming focus does not bring it up.

## Related issue
https://github.com/flutter/flutter/pull/33152 tried to make `ModalScope` resume its previous focus when its next route is popped. This PR solved only c), violating everything else, and even broke some tests by violating d).

## Why is this important
**Contenxt menu**. When the user is editing and right clicks the text to bring up a context menu  
- It _requires_ c) so that the text field is not unfocused
- It _prefers_ a), or at least e), so that the screen doesn't go through multiple sudden metric changes.

**Dialog**. In addition to the reasons above,
- It _prefers_ d) so that when the user is editing, scrolls down, and pops up a dialog that's at the bottom of the page, the screen doesn't scroll back to the top when the dialog disappears.

## Suggestion
If we only want to ensure basic support for context menu, it shouldn't be too hard if we add some special management of focus and input connection onto context menu popups, so that a), e), c), and even d) can be fixed for context menu.

In order to fix a) c), d) and e) for all modals including dialogs, we might need to allow focus scopes to manage their own focuses, which will be a much bigger change that might be breaking.

Fixing b) is probably impossible in a single-view Flutter app, and need to be discussed after Flutter supports easy multi-view.
Repository: flutter
Issue: [path_provider] Provide access to asset paths
Labels: c: new feature,p: path_provider,package,c: proposal,team-ecosystem,P3,triaged-ecosystem

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill our the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case

I have a blob asset with custom format, I do not want to read it all at once.
So I try to use File::openRead(start, end), but without an api to get root bundle path.

## Proposal

Can you add an api just like
`Future<Directory> getRootAssetBundleDirectory() async { ... } ` ?
Repository: TypeScript
Issue: Improve TypeScript experience when dependencies are missing.
Labels: Suggestion,Awaiting More Feedback

I was in a project, and forgot that I deleted `node_modules` (or forgot to `npm install`), and in this case I was seeing `any` all over the place, and was jumping myself to conclusions that something was wrong with TypeScript or VS Code.

It could be helpful if VS Code could suggest something like

> Did you forget to install dependencies? Perhaps you should run `npm install`?

or similar.
Repository: vue
Issue: Unnecessary renders on parent update when $attrs is bound
Labels: improvement

### Version
2.6.10

### Reproduction link
[https://codepen.io/anon/pen/zQVRgG?editors=1010](https://codepen.io/anon/pen/zQVRgG?editors=1010)







### Steps to reproduce
Type something into the first field

Uncomment line 8 or 14 then try again

### What is expected?
In console:
```
Render a
```

### What is actually happening?
In console:
```
Render a
Render b
```

<!-- generated by vue-issues. DO NOT REMOVE -->
Repository: terminal
Issue: Feature Request: Support Font Families instead of individual fonts
Labels: Issue-Feature,Area-Rendering,Area-Settings,Product-Terminal

# Summary of the new feature/enhancement

<!-- 
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->

Using more than one fonts, like "Font Family" in VS Code.
It is a useful feature for CJK users.
Repository: pytorch
Issue: `attn_mask` in nn.MultiheadAttention is additive
Labels: module: docs,module: nn,triaged

## 📚 Documentation

It likely should be mentioned that the [`attn_mask`](https://github.com/pytorch/pytorch/blob/master/torch/nn/modules/activation.py#L767) argument of MHA is an additive mask (-inf masks values), rather than the standard multiplicative mask (0 masks values). Perhaps even enforce a value check (all values should be 0 / -inf ?, otherwise print warning?)

cc @brianjo @mruberry @albanD @jbschlosser @zhangguanheng66
Repository: go
Issue: cmd/gofmt: extra indentations when adding comments  
Labels: NeedsFix

I encounter an issue with `gofmt`, where adding a comment to the first line causes extra indentation to the rest of the lines. 

For example, giving this block of code:
```go
func main() {
	t1 := foo.Bar().
		Baz().
		Qux()
}
```
Adding a comment (`//`) after `Bar()` adds extra indentations to the lines below:
```go
func main() {
	t1 := foo.Bar(). //
				Baz().
				Qux()
}
```
[Playground](https://play.golang.org/p/defYUt_Zgmi)

Same for this case:
```go
func main() {
	t1 := foo.Bar(). // bar
				Baz(). // baz
				Qux()  // qux
}
```
[Playground](https://play.golang.org/p/PokqI18xpB3)

Maybe I miss something, but I expect the formatting to be as follow:
```go
func main() {
	t1 := foo.Bar(). // 
		Baz().
		Qux()
}

func main() {
	t1 := foo.Bar(). // bar
		Baz().   // baz
		Qux()    // qux
}
```
Repository: go
Issue: cmd/go: subcommand as git merge tool for go.mod merge conflicts
Labels: NeedsInvestigation,FeatureRequest,GoCommand,modules

I expect merge conflicts in `go.mod` and `go.sum` to be a relatively common occurrence.

Quoting from @bcmills in the Go Slack:
> If you have a merge conflict no `go.mod` or `go.sum`, you can usually just remove the conflict markers (taking the union of the requirements) and then run `go mod tidy`to get back into a consistent state.

https://gophers.slack.com/archives/C9BMAAFFB/p1559923453042900?thread_ts=1559922004.041700&cid=C9BMAAFFB

This doesn't appear terribly burdensome but it does introduce friction in the development process. I'm opening this as an exploratory issue to investigate whether there's anything the tooling can/should do to mitigate the conflict.

My off the cuff question was whether `go mod tidy` could be updated to understand conflicts and automatically resolve them in `go.mod` and `go.sum`. My summary of the resulting conversation is that it's likely possible but it's unclear whether it's desirable.

Some of the reasons against that were brought up:
* Both parsing of the conflicts and resolving them is VCS specific.
* This may be expanding the scope of what tidy is responsible for farther than it should be.

It's possible there's a less invasive approach to mitigating conflicts so I'm including the above suggestion only as one potential option to explore.
Repository: flutter
Issue: [google_maps_flutter] Location Accuracy setting for IOS
Labels: c: new feature,platform-ios,p: maps,package,c: proposal,customer: vroom,P3,team-ios,triaged-ios

## Use case
We'd like to switch the accuracy to a low level when using the google maps plugin so as to not consume battery power. Currently, for Android, you are able to change the location accuracy by changing android.permission.ACCESS_FINE_LOCATION to android.permission.ACCESS_COURSE_LOCATION. However, there is no such option for IOS. 

It is my understanding that IOS has the option to changed the accuracy of the location using CCLocationManager and desiredAccuracy however the current plugin is either not clear on whether it allows this or does not give an easy way to access the location manager and change the property.

## Proposal
Be able to set the accuracy level for both android and ios
Repository: create-react-app
Issue: CSS custom properties are not polyfilled
Labels: tag: underlying tools,issue: needs investigation

### Is this a bug report?

Yes

I have CSS variables (custom properties) in my CSS, which are not supported by IE. The CRA docs state "Support for new CSS features like the all property, break properties, custom properties, and media query ranges are automatically polyfilled to add support for older browsers." However, they are not polyfilled when they are imported from another file.

### Steps to reproduce
```css
// A.css
:root {
  --test: #fff;
}
```

```css
// B.css
@import 'A.css'
body {
  color: var(--test)
}
```



### Expected Behavior

The built CSS file should have the CSS variables processed out and replace the var(--) calls with the proper values


### Actual Behavior

The autoprefixer works as expected, adding vendor prefixes and such, and changing the browserslist settings do alter the outputted CSS in some way. However, no browserslist setting is making the custom properties be post-processed, and as such the CSS will not work on IE. It seems like the variable replacement is happening before the concatenation from imports, and so it doesn't find the property definition from other files.

Note that I also deleted node_modules and package-lock and the issue persists.
Repository: pytorch
Issue: [jit] In pickler, don't memoize if not necessary
Labels: oncall: jit,triaged,jit-backlog

Follow up to #21542, now the pickler works the same as Python's in that it outputs memoization IDs for every object. For improved binary size and faster deserialization we should do a pass over all the `IValue`s to be serialized and only memoize the ones that are actually used more than once (similar to [`pickletools.optimize()`](https://docs.python.org/3/library/pickletools.html#pickletools.optimize)

cc @suo
Repository: rust
Issue: wrong backtrace line for .unwrap() if it is on the next line
Labels: A-debuginfo,T-compiler

meta:
````
rustc 1.37.0-nightly (5eeb567a2 2019-06-06)
binary: rustc
commit-hash: 5eeb567a27eba18420a620ca7d0c007e29d8bc0c
commit-date: 2019-06-06
host: x86_64-unknown-linux-gnu
release: 1.37.0-nightly
LLVM version: 8.0
````

I had a Command::new()....unwrap() and some methods in between that were also unwrapping their arguments.
The panic that I got however was not pointing to any of the unwrap()s but to the first line of the statement (the Command::new()) which is quite confusing.

Here is similar example:
````rust
 fn a(_: i32, _: i16, _: i8, _: i32, _: i16, _: i8) -> i32 {
    4
}

fn main() {
    let X: i32 = a(
        9,
        Some(4)
        .unwrap(),
        Some(7)
        .unwrap(),
        Some(9)
        .unwrap(),
        Some( // backtrace points here
        None
        )
        .unwrap()
        .unwrap(), // should point here
        7,
    );
}
````

the backtrace points to line 15 which contains `Some(` which is very confusing, imo it should point to line 19 which is the panicking `unwrap()`

Can reproduce on stable, beta and nightly.
Playground: https://play.rust-lang.org/?version=beta&mode=debug&edition=2018&gist=be591b1d4dbf5b729c5733a831c823e9
Repository: pytorch
Issue: Feature Request: beta cdf
Labels: module: distributions,feature,triaged

## 🚀 Feature
Please implement the cdf for beta distribution.

## Motivation
The cdf of beta is used quite frequently but it's not implemented.

## Code to reproduce the problem:
~~~~
from torch.distributions.beta import Beta
m = Beta(torch.tensor([0.5]), torch.tensor([0.5]))
m.cdf(0.0029)
~~~~

## Stack Trace
```
File "<stdin>", line 1, in <module>
  File "/home/.virtualenvs/test/lib/python3.6/site-packages/torch/distributions/distribution.py", line 133, in cdf
    raise NotImplementedError
NotImplementedError
```
Repository: pytorch
Issue: Pytorch hangs when dataloader multiprocessing workers are killed
Labels: module: dataloader,triaged

## 🐛 Bug

There are basically 2 issues here:
1) Pytorch does not handle properly when dataloader workers hang. The whole process hangs when a worker hangs if no timeout is specified. When a timeout is specified, the dataloader simply throws an exception without cleaning up its worker processes.
2) Since Pytorch doesn't handle it, we had to handle it ourselves, by forcefully killing the worker processes. This in turn can cause another hang when pin memory thread is used. Because dataloader uses the same "work_result_queue" to send data to the pin memory thread and to notify "done" to the pin memory thread, it's possible that the "done" event can never be read properly from the queue after we kill the worker processes. And because dataloader iterator joins the pin memory thread indefinitely when it self-destructs, the self-destruction can hang forever.

## To Reproduce

Steps to reproduce the behavior:

1. Just create a dummy dataset that sleeps forever when loading.
2. Launch Dataloader with multi-workers and pin_memory=True, timeout=some number.
3. Add exception handler to handle the timeout, and in there kill the workers.

## Expected behavior

The workers are killed. But the main process hangs when it tries to join the pin memory thread indefinitely during dataloader iterator's self-destruction process, while the pin memory thread is still reading the queue indefinitely.
Many times it works without hang. But it indeed occurs fairly often.

## Environment
 - PyTorch Version (e.g., 1.0): 1.0.1 beta2 (1.1 has the same issue from code reading).
 - OS (e.g., Linux): Ubuntu 18.04 LTS
 - Python version: 3.6.7
Repository: flutter
Issue: Flutter Lifecyle onPause and onStop
Labels: c: new feature,platform-android,engine,c: proposal,P3,team-android,triaged-android

## Use case
I'm developing an Alarming App, and Popup up even If the mobile is locked. I need to tweak the FlutterActivity to support this feature.

This is an detail of this [issue](https://stackoverflow.com/questions/25369909/onpause-and-onstop-called-immediately-after-starting-activity):

Below is a lifecycle of App popup when using Keyguard:
**onCreate - onStart - onResume - onPause - onStop**

This will cause flutter engine rendering stuck, when `eventDelegate.onStop` and `eventDelegate.onPause` called.

### solution
The workaround I found was **making custom flutter activity** and **comment out this two lines**, but I don't know If there is any side effect.

## Proposal
Hope there is a way to control Flutter's rendering behavior, I think comments out these two would cause some side effect in the future.
Repository: TypeScript
Issue: Doesn't support rename refactoring with importing from a module (yarn workspaces)
Labels: Bug

Ts 3.5.1

I use yarn workspaces in the project so may

`./package/module` folder is linked and available as `@app/module`

Say I have such file, that imports from the same module `test`
```ts
import { a, b } from '@app/module/test'
import { b } from './packages/module/test'

```

Then I rename file `packages/module/test` to `test2`

and refactoring does change our file to:

```ts
import { a, b } from '@app/module/test' // this is not
import { b } from '@app/module/test2' // this is renamed and put @app instead of `./packages`
```
Expected result would probably be:

```ts
import { a, b } from '@app/module/test2'
import { b } from './packages/module/test2'
```

If there would be importing only `from '@app/module/test'` it would not even suggest rename refactoring.