sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: kubernetes
Issue: ReplicaSet controller continuously creating pods failing due to SysctlForbidden
Labels: kind/bug,priority/important-soon,area/kubelet,sig/scheduling,area/reliability,kind/feature,sig/apps,lifecycle/frozen

**What happened**:

Creating a deployment with a pod spec with an unsafe sysctl not whitelisted results in the pods being rejected by Kubelet with `SysctlForbidden` and the replicatset controller just keeps creating new pods in a tight loop.

**What you expected to happen**:

The replicaset controller should maybe backoff exponentially if the pod it tries creating is getting rejected by Kubelet

**How to reproduce it (as minimally and precisely as possible)**:

Add:

```yaml
securityContext:            
  sysctls:                  
  - name: net.core.somaxconn
    value: '10000'   # This value really does not matter any int works       
```
to a pod spec in a deployment, ensure kubelets in the cluster do not have `allowed-unsafe-sysctls` flag configured.

apply the deployment config and you should see over a 100 pods created under a minute.

**Anything else we need to know?**:

**Environment**:
- Kubernetes version (use `kubectl version`):
```
 kubectl version
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.3", GitCommit:"435f92c719f279a3a67808c80521ea17d5715c66", GitTreeState:"clean", BuildDate:"2018-11-26T12:57:14Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.3", GitCommit:"435f92c719f279a3a67808c80521ea17d5715c66", GitTreeState:"clean", BuildDate:"2018-11-26T12:46:57Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
```
- Cloud provider or hardware configuration: AWS
- OS (e.g. from /etc/os-release): Debian Stretch
- Kernel (e.g. `uname -a`): Linux 4.9

<!-- DO NOT EDIT BELOW THIS LINE -->
/kind bug
Repository: flutter
Issue: Publish iOS fidelity comparison
Labels: platform-ios,framework,a: fidelity,f: cupertino,P3,team-design,triaged-design

Once https://github.com/flutter/flutter/projects/9#column-3989168 is done, publish the results (and as a forcing function, make sure it's good enough to be published :D)
Repository: flutter
Issue: Flutter google maps drag marker
Labels: c: new feature,waiting for PR to land (fixed),p: maps,package,team-ecosystem,P2,triaged-ecosystem

Hey flutter team, 
Any way to drag a marker around the map and get the location from it ?
Repository: flutter
Issue: AnimatedSwitcher should be more customizable
Labels: c: new feature,framework,a: animation,P2,team-framework,triaged-framework

Currently `AnimatedSwitcher` only allows you to play the same animation for both exit and enter, which can only be played simultaneously. If you look at the Material website, the overwhelming majority of transitions fade to white/transparent first, and then fade in the next element.

Working around both these constraints is a bit fiddly, and can be made a lot easier if these options were integrated into the constructor. 

Ideally `AnimatedSwitcher` should support the following options:
- `bool simultaneous` - if `false`, plays the next `child`s animation after the previous, instead of at the same time
- `Duration {enter,exit}Duration` - specifies unique durations for entering and exiting `child`s, respectively
- `Widget {enter,exit}TransitionBuilder` - specifies unique transitions for entering and exiting `child`s, respectively
Repository: go
Issue: net/http: isCookieNameValid in net/http/cookie.go seems overly restrictive
Labels: NeedsDecision

Note: I attempted to post this to the golang nuts list, but my message was rejected twice for unspecified reasons.

### What version of Go are you using (`go version`)?

<pre>
go version go1.10.1 windows/amd64
</pre>

### Does this issue reproduce with the latest release?
 Code in current https://github.com/golang/go/blob/master/src/net/http/cookie.go is the same as my release.


### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\david\AppData\Local\go-build
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=I:\golang
set GORACE=
set GOROOT=I:\Go
set GOTMPDIR=
set GOTOOLDIR=I:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\david\AppData\Local\Temp\go-build742879430=/tmp/go-build -gno-record-gcc-switches

</pre></details>

### What did you do?

- I make a http post call to a server ( happens to be https://www.ealing.gov.uk/site/custom_scripts/waste_collection/waste_collection.aspx )
- I receive this Set-Cookie:  ```Set-Cookie: ISAWPLB{48BCE7DA-ADD0-4237-A5B8-816663CFDD23}={70F05AF6-A2D2-4861-9D98-B73CEF42E642}; HttpOnly; Path=/```





### What did you expect to see?
I expected the http package to tolerate sloppy cookie names that exist in the wild on the internet and are supported by all major browsers. This cookie name works on firefox and chrome latest. I've not tested with anything else, but given my local council is using it, and it's produced by a Microsoft application stack, I suspect it works everywhere.


### What did you see instead?

net/http/client.go attempts to handle the Set-Cookie header by calling net/http/cookie.go readSetCookies() , but fails silently, swallowing the Set-Cookie without any warning, because it deems the cookie name ```ISAWPLB{48BCE7DA-ADD0-4237-A5B8-816663CFDD23}``` invalid because it contains, as far as I can tell, ```{``` and ```}```. 

This actually means that it's impossible for me to use go (without hacking net/http) to communicate properly with this web server, because the stringer on a Cookie returns "" unless the name is valid, which stops the cookie being included with outbound requests. So, even if I manually handled this badly named cookie, the http client will refuse to send it, regardless.
Repository: ant-design
Issue: Unresponsive Slider when setting trigger to onAfterChange 
Labels: Inactive

- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.

### Reproduction link
[![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://z2ppnop8x.codesandbox.io/)

### Steps to reproduce
setting `options.trigger: "onAfterChange"` in `getFieldDecorator` prevents the slider from changing value

### What is expected?
The slider changes value in the same way as when options.trigger is not set. In the example that I provided I would expect the onValuesChange to fire once (at onmouseup) when options.trigger=onAfterChange.

### What is actually happening?
The use cannot change the value on the slider and onValuesChange is never called.

| Environment | Info |
|---|---|
| antd | 3.11.6 |
| React | 16.2.0 |
| System | Xubuntu 18.04 |
| Browser | Chrome 70.0.3538.77 |


<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: TypeScript
Issue: Add ReadonlyDate 
Labels: Suggestion,Domain: lib.d.ts,Awaiting More Feedback

We have `ReadonlyArray`, `ReadonlyMap`, `ReadonlySet`, so we need `ReadonlyDate` :)
Repository: flutter
Issue: Support home and lock screen widgets
Labels: c: new feature,platform-android,platform-ios,framework,engine,customer: crowd,P3,team-engine,triaged-engine

Both Android and iOS have widgets that can be used outside of apps. On Android they are home screen widgets, and on iOS there are lock screen/notification center widgets. Would it be possible to create them using Flutter widgets?
Repository: flutter
Issue: Baseline proper in icon widget to better align some icons for aesthetics
Labels: c: new feature,framework,f: material design,P2,team-design,triaged-design

Some icons look better together when one is slightly offset vertically.

<img src="https://user-images.githubusercontent.com/20849728/50733546-9e253e00-11e3-11e9-8319-4f885d599106.png" width=400 />

The thumb icons in my music application are a great example of this. Right now, there's no easy way to align the icons so the bottoms of the hands are aligned.

It'd be great if we had some sort of "icon baseline" property that we could use to align our icons better.
It's also important for the hitboxes of the icons to still be vertically aligned though.
Repository: pytorch
Issue: Implicit conversion error in caffe2
Labels: caffe2

Hello,

While compiling generated sources(caffe2.pb.cc)  from caffe2.proto we are getting the implicit conversion error
protobuf version=v3.5.2
compiler:
 CC=aarch64-linux-android-clang \
 CXX=aarch64-linux-android-clang++


```
/home/armnn1/armnn-devenv/armnn/src/armnnCaff2Parser/proto/caffe2.pb.cc:2269:9: error: implicit conversion changes signedness: '::google::protobuf::int32' (aka 'int') to
      'google::protobuf::uint32' (aka 'unsigned int') [-Werror,-Wsign-conversion]
        static_cast< ::google::protobuf::int32>(
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/armnn1/armnn-devenv/armnn/src/armnnCaff2Parser/proto/caffe2.pb.cc:2282:9: error: implicit conversion changes signedness: '::google::protobuf::int32' (aka 'int') to
      'google::protobuf::uint32' (aka 'unsigned int') [-Werror,-Wsign-conversion]
        static_cast< ::google::protobuf::int32>(
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/armnn1/armnn-devenv/armnn/src/armnnCaff2Parser/proto/caffe2.pb.cc:2326:9: error: implicit conversion changes signedness: '::google::protobuf::int32' (aka 'int') to
      'google::protobuf::uint32' (aka 'unsigned int') [-Werror,-Wsign-conversion]
        static_cast< ::google::protobuf::int32>(
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/armnn1/armnn-devenv/armnn/src/armnnCaff2Parser/proto/caffe2.pb.cc:2339:9: error: implicit conversion changes signedness: '::google::protobuf::int32' (aka 'int') to
      'google::protobuf::uint32' (aka 'unsigned int') [-Werror,-Wsign-conversion]
        static_cast< ::google::protobuf::int32>(
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/armnn1/armnn-devenv/armnn/src/armnnCaff2Parser/proto/caffe2.pb.cc:3017:9: error: implicit conversion changes signedness: '::google::protobuf::int32' (aka 'int') to
      'google::protobuf::uint32' (aka 'unsigned int') [-Werror,-Wsign-conversion]
        static_cast< ::google::protobuf::int32>(
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Thank you,
Repository: go
Issue: cmd/vet: govet sometimes wrong about whether a context gets cancelled
Labels: help wanted,NeedsInvestigation,Analysis

### What version of Go are you using (`go version`)?

Not sure, it's a toolchain. Most likely 1.11.

### Does this issue reproduce with the latest release?

Yes, as of 1.12beta.

### What operating system and processor architecture are you using (`go env`)?

No idea, govet runs remotely on a language server.

### What did you do?

```Go
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
if true {
  // This makes govet think that the child context never gets cancelled,
  // when, in fact, it is cancelled by the parent's cancel().
  ctx, _ = context.WithTimeout(ctx, time.Second)
}
```

### What did you expect to see?

govet should not claim that the child context leaks. (If it's a style question, it should be in the linter, not govet.)

### What did you see instead?

govet incorrectly thinks the child context does not get cancelled.
Repository: rust
Issue: [NLL] Bad higher ranked subtype error
Labels: A-diagnostics,P-medium,T-compiler,A-NLL,NLL-diagnostics,A-higher-ranked

With the removal of the leak check the MIR type checker is now responsible for reporting higher-ranked lifetime errors in full NLL mode. The error messages are not currently very helpful, since they weren't user visible until now.

The following code ([play](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=d5c8f78908722b83ba0610188ad6b9ef)):

```rust
#![feature(nll)]

fn main() {
    let x: fn(&'static ()) = |_| {};
    let y: for<'a> fn(&'a ()) = x;
}
```

gives the following output

```text
error: higher-ranked subtype error
  --> <source>:19:12
   |
19 |     let x: fn(&'static ()) = |_| {};
   |            ^^^^^^^^^^^^^^^
error: aborting due to previous error
Compiler returned: 1
```

In migrate mode or with AST borrowck the error is much clearer:

```text
error[E0308]: mismatched types
  --> <source>:20:33
   |
20 |     let y: for<'a> fn(&'a ()) = x;
   |                                 ^ one type is more general than the other
   |
   = note: expected type `for<'a> fn(&'a ())`
              found type `fn(&'static ())`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0308`.
Compiler returned: 1
```

cc @rust-lang/wg-compiler-nll
Repository: godot
Issue: Changing a value by dragging floods the output window with "Set <property_name>" messages
Labels: enhancement,topic:editor,confirmed

**Godot version:**
3.1 Alpha 5


**OS/device including version:**
Kubuntu 18.10

**Issue description:**
Changing a number value in the property editor by dragging (using the mouse) leaves a "Set <property_name>" message on every frame 
It would be nice to have a way to turn it off or only leave a message _after_ changing the value (letting go of the mouse button)

**Steps to reproduce:**
* On any project, Click on a node (With numbered values, like a node2d) to reveal its properties.
* Click and drag on a numbered value to change its value.
* Watch how the output window starts outputting a lot of the same message.

**Minimal reproduction project:**
(None needed)

In my opinion it's quite annoying because it makes scrolling through the output window unnecessarily harder.

Edit: output window, not the debug window
Repository: rust
Issue: DerefMut borrow method call is too long with Deref arguments
Labels: P-medium,T-compiler,A-NLL,NLL-complete

Currently with Rust 2018, this code does not compile.

```rust
fn main() {
    let mut v = vec![1, 2, 3];
    v.swap(0, v.len() - 1);
    assert_eq!(v, &[3, 2, 1]);
}
```

```
error[E0502]: cannot borrow `v` as immutable because it is also borrowed as mutable
  |
3 |     v.swap(0, v.len() - 1);
  |     - ----    ^ immutable borrow occurs here
  |     | |
  |     | mutable borrow later used by call
  |     mutable borrow occurs here
```

It seems that the compiler desugars the method call like this:

```rust
let v0 = &*v;
let v1 = &mut *v;
let arg0 = 0;
let arg1 = v0.len() - 1; // v1 is still alive here
v1.swap(arg0, arg1);
```

But I think the `DerefMut` should be deferred, or use only `DerefMut` reference without any `Deref`.

```rust
let v0 = &*v;
let arg0 = 0;
let arg1 = v0.len() - 1; // no mutable borrows here

let v1 = &mut *v;
v1.swap(arg0, arg1);
```

```rust
let v0 = &mut *v;
let arg0 = 0;
let arg1 = v0.len() - 1;
v0.swap(arg0, arg1);
```
Repository: rust
Issue: Inappropriate `warning: unreachable expression` in `println!`
Labels: C-enhancement,A-lints,A-diagnostics,A-macros,T-compiler

`return` expression in call params of `println!` macro causes inappropriate warning message.

I tried this code (ref: [Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=1c8219aa795635c0717ba3e5a2a10ad3)):

```rust
fn func1() {
    assert_eq!((), return ());
}

fn func2() {
    println!("{}", return ());
}

fn main() {
    func1();
    func2();
}
```

I expected to print `^^^` against an entire statement:

```text
warning: unreachable expression
 --> src/main.rs:2:5
  |
2 |     assert_eq!((), return ());
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: #[warn(unreachable_code)] on by default
  = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

warning: unreachable expression
 --> src/main.rs:2:5
  |
2 |     assert_eq!((), return ());
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

warning: unreachable expression
 --> src/main.rs:6:20
  |
6 |     println!("{}", return ());
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
```

But, it was printed against an expression instead of a sentence:

```text
warning: unreachable expression
 --> src/main.rs:2:5
  |
2 |     assert_eq!((), return ());
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: #[warn(unreachable_code)] on by default
  = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

warning: unreachable expression
 --> src/main.rs:2:5
  |
2 |     assert_eq!((), return ());
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

warning: unreachable expression
 --> src/main.rs:6:20
  |
6 |     println!("{}", return ());
  |                    ^^^^^^^^^
```

## Meta

`rustc --version --verbose`: 1.31.1
Repository: neovim
Issue: Turn neovim into $PAGER
Labels: enhancement,terminal,input,pager

Hello,

I'm author of [page](https://github.com/I60R/page) - a neovim's client similar to neovim-remote but rather focused on redirecting text from one :term buffer and reading it in another. It was created with intention to merge `less` functionality into `neovim` and provide more integrated paging for better terminal experience. The goal achieved pretty well, although currently `page` has some severe limitations that only can be resolved on `neovim` side.

The limitations are:


### 1. Scrollback maximum on :term buffer

`page` uses :term buffer to render ANSI escape sequences. But in neovim :term buffer scrollback is limited to 100000 lines and while it's enough for terminal purposes for pager it's not sufficient. When this maximum is over `page` loses possibly relevant text with some strange effects I60R/page#7. This is the worst of listed issues and having option for unlimited scrollback would be really valuable to resolve it.


### 2. MANPAGER='page -t man' not works (-t provides hint for ftplugin)

Neovim's `man` filetype fails on :term and read-only buffers:

* `page` sets `nomodifiable` and then `ft=man` which produces `E21: Cannot make changes, \'modifiable\' is off:     silent keepjumps 1delete _`
* without `nomodifiable` it produces `E474: Invalid argument: buftype=nofile`

Currently I recommend to use workaround with copy-pasting into non-:term buffer but looks like only some small tweaks required in `man.vim` to resolve this.


### 3. Lack of on-demand text fetching

E.g `less` pager blocks its stdin and reads from it only when required. This prevents from lags and redundant large computations e.g. when reading output of `journalctl` (which is pretty common use case). Current solution is to manually fetch lines on `:Page` command which also should be explicitly enabled with `-q <number_of_lines>` argument.

But it seems to be possible to implement auto-fetching on scrolling by utilizing of `CursorMoved` autocommand. I would like to use it instead, however without auto-fetch on searching and probably in other contexts it would be surprising and inconvenient for users.

Maybe `SearchFound` and `SearchNotFound` autocommands or something like that would help to mimic `less` behavior better? I'm not sure if this is a good idea through, since it might be too complex to implement; it's already possible to override default <number_of_lines> using `:Page <count>` command, so it may be not worth it... 


---


Could you collaborate on that?
Repository: flutter
Issue: Hero should allow specifying a curve and reverseCurve
Labels: c: new feature,framework,f: material design,P2,team-design,triaged-design

Currently in `heroes.dart`:

```dart
  Animation<double> get animation {
    return CurvedAnimation(
      parent: (type == HeroFlightDirection.push) ? toRoute.animation : fromRoute.animation,
      curve: Curves.fastOutSlowIn,
    );
  }
```

`Curves.fastOutSlowIn` looks decent for an entry curve, however when the hero animation is played in reverse when going to the previous route, you get something like the following:

![ezgif-4-8105ac49419e](https://user-images.githubusercontent.com/4211302/50741037-f6623d00-11ef-11e9-898e-2eb1959c7a44.gif)

This could be solved by checking `HeroFlightDirection.push/pull` and flipping the curve if necessary, but IMO it would make more sense to allow the user to specify `curve` and `reverseCurve` like most of the other animation APIs we have. `curve` would naturally be flipped when going backwards if `reverseCurve` isn't specified.

When I was working on improving the animations of `CupertinoPageRoute`, the Hero animation of the title becoming the back button was the one thing I couldn't alter, since there isn't an API to specify a reverse curve. Example (watch the Colors title):

![ezgif-4-1260e8ec0452](https://user-images.githubusercontent.com/4211302/50741148-383fb300-11f1-11e9-8ca8-fdba5b056b98.gif)
Repository: flutter
Issue: Tizen platform support
Labels: c: new feature,engine,customer: crowd,P3,team-engine,triaged-engine

Hi, any plans for [tizen](https://www.tizen.org) support?
Repository: rust
Issue: Tracking issue for duration_constants
Labels: T-libs-api,B-unstable,C-tracking-issue,Libs-Tracked,A-time

Implemented in https://github.com/rust-lang/rust/pull/57375/

> This will make working with durations more ergonomic. Compare:
>
> ```rust
> // Convenient, but deprecated function.
> thread::sleep_ms(2000);
> 
> // The current canonical way to sleep for two seconds.
> thread::sleep(Duration::from_secs(2));
> 
> // Sleeping using one of the new constants.
> thread::sleep(2 * SECOND);
> ```

```rust
impl Duration {
    pub const SECOND: Duration = Duration::from_secs(1);
    pub const MILLISECOND: Duration = Duration::from_millis(1);
    pub const MICROSECOND: Duration = Duration::from_micros(1);
    pub const NANOSECOND: Duration = Duration::from_nanos(1);
    pub const MAX: Duration = ...;
}