sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: pytorch
Issue: Optimizer classes not `dill` picklable after using `torch.compile`
Labels: module: serialization,triaged,oncall: pt2

### 🐛 Describe the bug

To get started:

```console
$ pip install torch dill
```

After you use `torch.compile`, `Optimizer` subclasses stop being `dill` picklable:

```python
import dill
import torch

torch.save(torch.optim.AdamW, "a.pth", pickle_module=dill)  # OK

@torch.compile
def bias_gelu_fused_(inp: torch.Tensor, bias: torch.Tensor) -> torch.Tensor:
    """Bias-GeLU fused"""
    x = inp + bias
    return x * 0.5 * (1.0 + torch.tanh(0.79788456 * x * (1 + 0.044715 * x * x)))

torch.save(torch.optim.AdamW, "fake.txt", pickle_module=dill)  # PicklingError: Can't pickle <built-in function reset_code>: it's not found as torch._C._dynamo.eval_frame.reset_code

```

This seems to be partly the reason:

https://github.com/pytorch/pytorch/blob/8bf9e99cead36db15fb7c09455f2b3fb4f6015f3/torch/_dynamo/eval_frame.py#L1506

I think it boils down to `torch._C._dynamo.eval_frame` not being importable as a package, but as an attribute of `torch._C._dynamo` (like an imported module):

```python
import dill
import torch._C._dynamo

print(torch._C._dynamo.eval_frame)  # <module 'torch._C._dynamo.eval_frame'>
print(torch._C._dynamo.eval_frame._CacheEntry)  # <class 'torch._C._dynamo.eval_frame._CacheEntry'>

torch.save(torch._C._dynamo.eval_frame._CacheEntry, "a.pth", pickle_module=dill)  # PicklingError: Can't pickle <class 'torch._C._dynamo.eval_frame._CacheEntry'>: it's not found as torch._C._dynamo.eval_frame._CacheEntry

import torch._C._dynamo.eval_frame  # ModuleNotFoundError: No module named 'torch._C._dynamo.eval_frame'; 'torch._C._dynamo' is not a package
```

`eval_frame` is defined here:

https://github.com/pytorch/pytorch/blob/556e4ec6c93d4ccfbf84cffe462308340417a95b/torch/csrc/dynamo/init.cpp#L58

Is there some change to `dill` or C++-generated `module`s that solve this?

### Versions

```
[conda] torch                     2.3.0                    pypi_0    pypi
```

cc @mruberry @mikaylagawarecki @msaroufim @ezyang @bdhirsh @anijain2305 @chauhang
Repository: rust
Issue: Can we suppress the `﻿suspicious_double_ref_op` lint if we have successive ﻿`clone` calls?
Labels: A-diagnostics,T-compiler

### Code

```Rust
// rustc code.rs

#[derive(Clone)]
struct S;

fn main() {
    let a = S;
    let b = &&a;
    let _ = b.clone().clone();
}
```


### Current output

```Shell
warning: using `.clone()` on a double reference, which returns `&S` instead of cloning the inner type
  --> ./src/main.rs:20:14
   |
20 |     let _ = b.clone().clone();
   |              ^^^^^^^^
   |
   = note: `#[warn(suspicious_double_ref_op)]` on by default

warning: 1 warning emitted
```


### Desired output

```Shell
No lint issues because we invoked two successive `﻿clone` methods.
```


### Rationale and extra context

_No response_

### Other cases

_No response_

### Rust Version

```Shell
rustc 1.80.0-nightly (ef0027897 2024-05-12)
binary: rustc
commit-hash: ef0027897d2e9014766fb47dce9ddbb925d2f540
commit-date: 2024-05-12
host: aarch64-apple-darwin
release: 1.80.0-nightly
LLVM version: 18.1.4
```


### Anything else?

_No response_
Repository: vscode
Issue: DNS servers lack IPv6 support, DNS recursion fails causing connection timeouts.
Labels: bug,install-update,network

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: No, the functionality used does not exist.

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.89.1
- OS Version: MacOS 14.4.1

Steps to Reproduce:

1. Open a remote location via SSH to a host that only has IPv6 connectivity, including IPv6 DNS resolution
2. Connection hangs for several minutes
3. Debugging shows the host is attempting to resolve Host "update.code.visualstudio.com", which hangs

What's happening is DNS resolution proceeds through several CNAME records:

$ host update.code.visualstudio.com.
update.code.visualstudio.com is an alias for vscode-update-g6gcb6ggdthkctd9.z01.azurefd.net.
vscode-update-g6gcb6ggdthkctd9.z01.azurefd.net is an alias for **star-azurefd-prod.trafficmanager.net.**
star-azurefd-prod.trafficmanager.net is an alias for **shed.dual-low.part-0031.t-0009.t-msedge.net**.
shed.dual-low.part-0031.t-0009.t-msedge.net is an alias for **part-0031.t-0009.t-msedge.net**.
part-0031.t-0009.t-msedge.net has address 13.107.213.59
part-0031.t-0009.t-msedge.net has address 13.107.246.59
part-0031.t-0009.t-msedge.net has IPv6 address 2620:1ec:46::59
part-0031.t-0009.t-msedge.net has IPv6 address 2620:1ec:bdf::59

The DNS servers for visualstudio.net have IPv6, as do the DNS servers for azurefd.net so DNS resolution is successful up to this point. However the DNS servers for "trafficmanager.net" and "t-msedge.net" do not have IPv6, so DNS resolution fails at this point unless your DNS resolver has legacy connectivity. 

Examples:

$ host -t NS t-msedge.net
t-msedge.net name server ns2.t-msedge.net.
t-msedge.net name server ns1.t-msedge.net.
t-msedge.net name server ns4.t-msedge.net.
t-msedge.net name server ns3.t-msedge.net.
$ host ns2.t-msedge.net.
ns2.t-msedge.net has address 13.107.246.2
$ host ns4.t-msedge.net.
ns4.t-msedge.net has address 13.107.213.2
Repository: PowerToys
Issue: Wrong word order in Mouse Without Borders ("Presse-papiers du partage")
Labels: Issue-Bug,Area-Localization,Needs-Triage,Issue-Translation

### Microsoft PowerToys version

0.84.1

### Utility with translation issue

Mouse Without Borders

### 🌐 Language affected

French

### ❌ Actual phrase(s)

"Si le Presse-papiers du partage cesse de fonctionner"
![image](https://github.com/microsoft/PowerToys/assets/34137127/d73f8517-a457-4ce1-86a5-a4de5c501584)

### ✔️ Expected phrase(s)

"Si le partage du presse-papiers cesse de fonctionner"

### ℹ Why is the current translation wrong

The word order is wrong. The current translation means "If the clipboard of the sharing stops working".
The English text isn't very clear to begin with: "If share clipboard stops working".
Maybe it could be reworded as "If clipboard sharing stops working".
Repository: terminal
Issue: Paste with Ctrl removes leading special character in SSH
Labels: Area-VT,Issue-Bug,Needs-Attention,Product-Terminal

### Windows Terminal version

1.20.11271.0

### Windows build number

10.0.22631.0

### Other Software

openssh-client/jammy-security,now 1:8.9p1-3ubuntu0.6

### Steps to reproduce

Connect to remote Linux server via SSH using WSL or Powershell.
Paste a string starting with one of these characters `[]{}` using `Ctrl+Shift+v`, `Ctrl+v` or `Ctrl+ Right Click`.
Example: `[rlkdjf[]{}dt`

### Expected Behavior

Complete String gets pasted into the Shell. 
![image](https://github.com/microsoft/terminal/assets/104909004/fce35d42-3c10-4b94-b270-d21cbe4fddb4)


### Actual Behavior

Leading character and the second character are removed from the String.
![image](https://github.com/microsoft/terminal/assets/104909004/5abf88a1-d69c-495f-b4d8-80a872b26cc5)

Using `Shift+Insert` or `Right Click` does not remove the leading characters.

This has worked until the latest update (winget package). I'm assuming this is form the 1.20 update.
Repository: PowerToys
Issue: PowerToys Run - VSCode Workspaces not appearing
Labels: Issue-Bug,Needs-Triage

### Microsoft PowerToys version

0.80.1

### Installation method

Microsoft Store

### Running as admin

No

### Area(s) with issue?

PowerToys Run

### Steps to reproduce

1. Clear recently opened workspaces/folders in VSCode
2. Open 3 folders and ensure they appear in the `Recently opened` option in VSCode
3. Ensure VSCode is visible in PATH
4. Enable PowerToys run module
5. Enable Visual Studio Code Workspaces
6. Activate PowerToys Shortcut
7. Enter direct activation command `{`
8. Start entering a folder name

### ✔️ Expected Behavior

Folders appear in the PowerToys run dropdown

### ❌ Actual Behavior

No options appear
Report:
[PowerToysReport_2024-05-14-21-08-00.zip](https://github.com/microsoft/PowerToys/files/15307457/PowerToysReport_2024-05-14-21-08-00.zip)

Weirdly enough, on another machine, with the same WSL2, Ubuntu distro & PowerToys version, I don't see any exceptions under Report> PowerTyos Run > Logs > 0.80.1.0 🤷

Have tried uninstall/reinstall, no dice

### Other Software

Location of VSCode folders:
WSL2, Ubuntu 22.04
Repository: vscode
Issue: VSCode Remote (WSL) does not send Ctrl+C when executing windows application
Labels: bug,confirmation-pending,terminal-input

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
(Only WSL enabled in host, no extension enabled in WSL)

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.89.1
- OS Version: 10.0.22631 (Windows 11 23H2)

Steps to Reproduce:

1. connect to any WSL2 with WSL extension
2. run `cargo run --target x86_64-pc-windows-gnu` / `cmd.exe /C tree` / `PING.EXE 1.1.1.1`

```rust
// this file compiled to test.exe in target x86_64-pc-windows-gnu
use std::{thread::sleep, time::Duration};

fn main() {
  println!("hello");
  loop {
    sleep(Duration::from_micros(1000))
  }
}
```

3. press `ctrl+c` after hello

Additional Information:
* This issue is duplicated with #189018
* The same procedure running in `terminal` application works.
* The key is running windows application (.exe) in **WSL** in vscode
* My `terminal.integrated.windowsEnableConpty` is true, so I assume I'm running with conpty.

> This works fine for me running tree/cmd.exe /C tree and interrupting.

I'm not sure what is the first `tree` you run here, it might be `/bin/tree` but not the built-in command in cmd.exe, are you in WSL environment?
Repository: neovim
Issue: `nvim_get_proc_children()` may not return all child processes
Labels: bug,api,platform:linux,system

### Problem

`nvim_get_proc_children()` uses `/proc/pid/task/tid/children` on Linux systems (most of the time) which sometimes does not contain all child processes.

### Steps to reproduce

(In this example `firefox` is used because I couldn't figure out how to create my own binary that would break it)
```
echo "
vim.system{'firefox','-P'}
vim.uv.sleep(1000)
local pid=assert(tonumber(vim.iter(vim.split(vim.system{'pgrep','firefox'}:wait().stdout,'\n',{trimempty=true})):nth(-1)))
vim.print('Child processes: '..vim.inspect(vim._os_proc_children(pid)))
vim.print('nvim_get_proc_children: '..vim.inspect(vim.api.nvim_get_proc_children(pid)))
"|nvim -l -
```

### Expected behavior

Make `nvim_get_proc_children()` return all child processes.

### Neovim version (nvim -v)

v0.10.0-dev-c795835

### Vim (not Nvim) behaves the same?

N/A

### Operating system/version

linux 6.8.9-arch1-2

### Terminal name/version

kitty 0.33.1

### $TERM environment variable

xterm-kitty

### Installation

build from repo
Repository: TypeScript
Issue: Isolated declarations does not handle object getters and setters with different types
Labels: Domain: Declaration Emit,Experience Enhancement,Domain: Isolated Declarations

### 🔎 Search Terms

- isolated declarations
- object getter
- object setter

### 🕗 Version & Regression Information

5.5.0-dev.20240514

### ⏯ Playground Link

https://www.typescriptlang.org/play/?target=99&isolatedDeclarations=true&ts=5.5.0-dev.20240514#code/KYDwDg9gTgLgBAYwgOwM7wIZwLxwN4BQcxcA5sPAEYAUAlAFxzpQCWyp+RJ3UFArlGRwARMK7EAvgBpxTCnBoA3DABtGzNqVqduEghIDcBAjACeYYHADKMVuwCCKlhlQ4mtzUdCRYiFOkQ3Qm5yeAATOkYbO1JHZ1dg7hJeGAEhUVlpWVR5COU1dxjtRMl9I2NvaHgkNHhLXBKyeQAzSMLNHSTiFLSRMV0Zbhz4VvzGZD4AW0pgKGLMsqA

### 💻 Code

```ts
export const a = {
    get b(): string {
        return ""
    },
    set b(val: string) {
    }
};

type StringAlias = string;
export const c = {
    get d(): StringAlias {
        return ""
    },
    set d(val: string) {
    }
};


export const e = {
    get f(): string {
        return ""
    },
    set f(val: number) {
    }
};
```


### 🙁 Actual behavior

TypeScript emits:

```ts
export declare const a: {
    b: string;
};
export declare const c: {
    d: string;
};
export declare const e: {
    get f(): string;
    set f(val: number);
};
```

This is behaviour is not possible to reproduce for isolated declarations emitters, because it requires type comparisons for the types of the setter and getter.

### 🙂 Expected behavior

One of:

**Emit based on syntax, do not collapse a getter/setter pair with the same type to a property**

```ts
export declare const a: {
    get b(): string;
    set b(val: string);
};
export declare const c: {
    get d(): StringAlias;
    set d(val: string);
};
export declare const e: {
    get f(): string;
    set f(val: number);
};
```

OR

**Error on both `c.d` and `e.f` because return type of getter and setter do not match**

### Additional information about the issue

cc @dragomirtitian
Repository: godot
Issue: OpenXR - timing issue with xrEndFrame
Labels: enhancement,topic:xr

### Tested versions

Not reproduced yet

### System information

Windows - Vulkan

### Issue description

This came out of a discussion I had a few days ago, I need to fully test this and am mostly recording this issue so I don't forget.

When we call `xrEndFrame` to hand over our rendered images to the XR Runtime, some runtimes will perform their render logic right there and then, including forcing a sync. This basically result Godot in just sitting there waiting for this.

There is potentially a relatively easy fix here and that is to simply start a worker thread that executes the `xrEndFrame`, all data communicated to XR is already safeguarded.

The part we need to further investigate is whether this has unwanted effects or whether this is something that should be further discussed with OpenXR/Khronos as undesired behavior and thus something that needs to be solved in the XR runtime..

### Steps to reproduce

not available yet

### Minimal reproduction project (MRP)

not available yet
Repository: electron
Issue: [Feature Request]: BrowserWindow.setFullScreen shows window, despite options = { show: false }
Labels: enhancement :sparkles:

### Preflight Checklist

- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.

### Electron Version

30.0.4

### What operating system are you using?

macOS

### Operating System Version

Sonoma 14.4.1

### What arch are you using?

arm64 (including Apple Silicon)

### Last Known Working Electron version

_No response_

### Expected Behavior

Consider the following code:

```javascript
const { app, BrowserWindow } = require("electron");

app.whenReady().then(() => {
  const win1 = new BrowserWindow({ x: 100, y: 100, show: false });
  win1.webContents.loadURL("https://developer.mozilla.org/en-US/docs/Web/API/History").then(() => {
    setTimeout(() => win1.show(), 5000);
  });

  win1.setFullScreen(true);
});
```

This code instantiates a `BrowserWindow` with `{ show: false }`. Five seconds after it loads the given URL, `BrowserWindow.show()` is called to show the window.

Also, immediately after instantiation of the `BrowserWindow`, `BrowserWindow.setFullScreen(true)` is called.

### Actual Behavior

The result is that the window is shown immediately when `BrowserWindow.setFullScreen(true)` is called.

I'm not sure what the expected behavior should be, because `BrowserWindow.setFullScreen(true)` may not make sense on a `BrowserWindow` that is now showing. Therefore, having `BrowserWindow.setFullScreen(true)` have the additional functionality to also show a `BrowserWindow` may be correct.

This is not reflected in [the documentation](https://www.electronjs.org/docs/latest/api/browser-window#winsetfullscreenflag), which begs the question if this functionality is intentional or accidental.

[Here is a comment](https://github.com/electron/electron/issues/10724#issuecomment-335158098) from an old issue touching on this functionality.

### Testcase Gist URL

_No response_

### Additional Information

_No response_
Repository: pytorch
Issue: Context manager for determinism
Labels: triaged,module: determinism

### 🚀 The feature, motivation and pitch

I would like to allow a certain function to always be non deterministic, even if `use_deterministic_algorithms` was set.
In my case, we use `torch.histc()` to compress data strictly for logging purposes. Therefore, allowing this function to run should not effect the end-to-end determinism of the training results.
I'd strongly prefer not to use `warn_only=True` because my console output is already cluttered and additional warnings would likely lead to us missing new occurrences if someone adds a non deterministic function that could break the end-to-end determinism.

Is there currently a way to check if `use_deterministic_algorithms` was set?
That would allow us to toggle the behavior only if it is set. 

I guess the ideal solution would be context manager similar to `with torch.no_grad():` that allows the user to ensure that some operations are always allowed to be non deterministic without having to worry about restoring the previous mode.
Such a context manager could later be extended to allow for example toggling the mode for individual autograd backward functions (#72831). 


### Alternatives

_No response_

### Additional context

_No response_

cc @mruberry @kurtamohler
Repository: tensorflow
Issue: Missing return in error check in mlir::TFTPU
Labels: awaiting review,type:bug,TF 2.16

### Issue type

Bug

### Have you reproduced the bug with TensorFlow Nightly?

No

### Source

source

### TensorFlow version

2.16.1

### Custom code

No

### OS platform and distribution

_No response_

### Mobile device

_No response_

### Python version

_No response_

### Bazel version

_No response_

### GCC/compiler version

_No response_

### CUDA/cuDNN version

_No response_

### GPU model and memory

_No response_

### Current behavior?

Possible null pointer dereference may occur because of missing return in error check:
https://github.com/tensorflow/tensorflow/blob/63bb7339a2bc98af97c61e86eedbbd60c123529c/tensorflow/compiler/mlir/tensorflow/transforms/extract_tpu_copy_with_dynamic_shape_op.cc#L61-L65

### Standalone code to reproduce the issue

```shell
Bug was found with Svace static analyzer
```


### Relevant log output

_No response_
Repository: kubernetes
Issue: image-gc-high-threshold should be lower than value causing hard eviction nodefs.available or imagefs.available
Labels: kind/bug,priority/backlog,sig/node,triage/accepted

### What happened?

when disk fills, it hits the hard eviction threshold, causing node disk pressure in the same moment imagegc spots it should prune something and start acting. this casues node going into disk pressure and evicting pods and not just start imagegc soon enough

### What did you expect to happen?

i expect imagegc spots the filling disk soon enough, to start garbage collection and empty disk before node hits disk pressure.

from current documentation:

https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/

```
--image-gc-high-threshold int32     Default: 85
--image-gc-low-threshold int32     Default: 80
```

and

https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/
```
    "imageGCHighThresholdPercent": 85,
    "imageGCLowThresholdPercent": 80,
```

https://kubernetes.io/docs/concepts/scheduling-eviction/node-pressure-eviction/#hard-eviction-thresholds

vs.

```
nodefs.available<10%
imagefs.available<15%
```

... this does not make sense having the same percentage for imagefs.available (100-15 = 85 :-)

better approach would be having default values a little bit shifted with eqivalent to setting

```
  - "--image-gc-high-threshold=80"  
  - "--image-gc-low-threshold=75"   
```

... after setting this, i almost never get node disk pressure, because garbage collection and pruning disk happens soon enough


### How can we reproduce it (as minimally and precisely as possible)?

fill disk, spot node disk pressure state at the same moment it starts garbage collecting.

### Anything else we need to know?

_No response_

### Kubernetes version

this is not version specific as checked documentation at the moment, its for years the same.

<details>

```console
$ kubectl version
# paste output here
```

</details>


### Cloud provider

none - kubeadm installation
<details>

</details>


### OS version

not relevant

<details>

```console
# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
```

</details>


### Install tools

<details>

</details>


### Container runtime (CRI) and version (if applicable)

<details>

</details>


### Related plugins (CNI, CSI, ...) and versions (if applicable)

<details>

</details>