sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: a11y announcements of fancy text field
Labels: framework,f: material design,a: accessibility,customer: mulligan (g3),from: a11y review,P2,team-design,triaged-design

Internal: b/292548468

![image](https://user-images.githubusercontent.com/1227763/37008104-777c765a-2095-11e8-938e-88fe4865ec3a.png)

What is the a11y behavior of the fancy text fields supposed to be that have a placeholder text, a helper, and a character count? What should be announced how?

Also, what about the text field that has a suffix with "/dozen"??

How should errors be announced?

Needs to be defined for iOS and Android.

@HansMuller
Repository: TypeScript
Issue: JSDoc member documentation not returned by quickInfo
Labels: Bug,Domain: JSDoc,Domain: Quick Info

https://github.com/Microsoft/vscode/issues/40181

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  2.8.0-dev.20180302

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** 

**Code**
For the js:

```ts
/**
 * @param o has a string and a number
 * @param o.s the string
 * @param o.n the number
 */
function f(o: {s: string; n: number }) { return o.s.length + o.n; }

f({s: 'abc', n: 2})
```

hover over `s` to trigger a quickInfo request

**Expected behavior:**

Documentation for `s` is returned.

**Actual behavior:**

No documentation returned:

```
[Trace  - 6:45:58 PM] Response received: quickinfo (38). Request took 10 ms. Success: true 
Result: {
    "kind": "property",
    "kindModifiers": "",
    "start": {
        "line": 8,
        "offset": 4
    },
    "end": {
        "line": 8,
        "offset": 5
    },
    "displayString": "(property) s: string",
    "documentation": "",
    "tags": []
}
```

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> 

**Related Issues:**
Repository: rust
Issue: It's possible to impose generic bounds that later make type inference recurse infinitely
Labels: C-enhancement,A-associated-items,T-lang,A-inference

I wrote this wrapper type (e.g. for integers):
```Rust
struct Wrapped<T> (T);

impl<'a, T> Add for &'a Wrapped<T>
where &'a T: Add<Output = T> {
        type Output = Wrapped<T>; 
                
        fn add(self, other: Self) -> Self::Output {
                Wrapped (&self.0 + &other.0)
        }
}
```

It works fine, but plays *really poorly* with any helper function definitions of this form:
```Rust
fn add<'a, T: 'a>(left: &'a T, right: &'a T) -> T
where &'a T: Add<Output = T> {
        left + right
}
```

The problem doesn't occur until the function is actually used in a way that triggers type inference.  For example:
```
error[E0275]: overflow evaluating the requirement `<&_ as std::ops::Add>::Output`
  --> src/main.rs:16:24
   |
31 |         add(&1, &2);
   |         ^^^
   |
   = help: consider adding a `#![recursion_limit="128"]` attribute to your crate
   = note: required because of the requirements on the impl of `std::ops::Add` for `&Wrapped<_>`
   = note: required because of the requirements on the impl of `std::ops::Add` for `&Wrapped<Wrapped<_>>`
   = note: required because of the requirements on the impl of `std::ops::Add` for `&Wrapped<Wrapped<Wrapped<_>>>`
   = note: required because of the requirements on the impl of `std::ops::Add` for `&Wrapped<Wrapped<Wrapped<Wrapped<_>>>>`
...
   = note: required by `add`
```

Notice that this call site doesn't even make use of the type `Wrapped<T>`: it's just impossible to perform type inference on the `add()` helper function at all.

Interestingly, `add::<i32>(&1, &2)` doesn't generate the error, but even something as simple as `add(&1i32, &2i32)` does.

@gpm helped me investigate the problem and its implications, and noticed that type inference for the function
```Rust
fn add<T, R>(left: T, right: T) -> R
where T: Add<Output = R> {
    left + right
}
```
isn't broken.  But this doesn't help you if some library crate has defined a type with the problematic impl and you now need to define a function that adds by references instead of moves...

```
$ rustc --version --verbose
rustc 1.23.0
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-unknown-linux-gnu
release: 1.23.0
LLVM version: 4.0
```
Repository: opencv
Issue: OE-2 "Maintaining OpenCV 2.x" discussion
Labels: evolution

the feature request about evolution proposal [OE-2](https://github.com/opencv/opencv/wiki/OE-2.-OpenCV-2)
Repository: opencv
Issue: OE-11 "Adding Logging" discussion
Labels: evolution

the feature request about evolution proposal [OE-11](https://github.com/opencv/opencv/wiki/OE-11.-Logging)
Repository: react
Issue: For Controlled Input, step does not work as expected unless initialized with null or "".
Labels: Type: Bug,Component: DOM

*BUG*

**What is the current behavior?**
For input type="number", step does not work as expected if there is an initial value set. Step only seems to get honored if the initial value is "" or null.

Example:
https://codepen.io/anon/pen/MQMBmX

The example uses a controlled input binding value and step. Step is 1/10th of the value. If you edit the value in the textbox to 50000 and increment using the stepper, it will increment to 50100 (i.e. by the initial value and not by the current step).

Edit the code so initial value is "" or null. Edit textbox to 50000 and step up - value goes to 55000 as expected.

**What is the expected behavior?**
It should be possible to render a number input that honors step without having to initialize the input component value to null or "" first.

It seems when there is an initial value provided, it will write a value attribute into the DOM (e.g. value="100").  When initial value is "" or null then just the value attribute is written to DOM with no assignment. e.g. (value).


**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**

16.3.0-alpha.1  (ported to this version to confirm if still an issue)
0.14.7 (originally found in this version)

Seems to affect Chrome only (confirmed windows and mac, versions 59 and 64). Bug does not appear in Safari (on a mac at least).
Repository: rust
Issue: Better unused variable warning
Labels: C-enhancement,A-lints,A-diagnostics,T-compiler

Given the code:

```
fn main() {
    let best = [1, 2, 3]
              .iter()
              .enumerate()
              .min_by_key(|&(i, f)| f);

    println!("{:?}", best);
}
```


The last Nighly rustc gives the warning:

```
warning: unused variable: `i`
--> ...\test.rs:5:31
  |
5 |                .min_by_key(|&(i, f)| f);
  |                              ^ help: consider using `_i` instead
  |
  = note: #[warn(unused_variables)] on by default
```


But I think it's better to suggest the programmer to use write `_` instead of `_i`.
Repository: flutter
Issue: "flutter uninstall" to delete flutter and all related cache files
Labels: c: new feature,tool,P3,team-tool,triaged-tool

Hey
How do you properly uninstall flutter and all flutter dependencies and flutter libraries?
It copies a lot of content in the file system.

I am on ubuntu 16.04.
Repository: opencv
Issue: OE-15 "Bit-exactness" discussion
Labels: evolution

the feature request about evolution proposal [OE-15](https://github.com/opencv/opencv/wiki/OE-15.-Bit-Exactness)
Repository: opencv
Issue: OE-16 "Mini Halide" discussion
Labels: evolution

the feature request about evolution proposal [OE-16](https://github.com/opencv/opencv/wiki/OE-16.-Mini-Halide)
Repository: opencv
Issue: OE-17 "New Filter Engine" discussion
Labels: evolution

the feature request about evolution proposal [OE-17](https://github.com/opencv/opencv/wiki/OE-17.-New-Filter-Engine)
Repository: opencv
Issue: OE-18 "Module OptFlow" discussion
Labels: evolution

the feature request about evolution proposal [OE-18](https://github.com/opencv/opencv/wiki/OE-18.-Module-Optflow)
Repository: opencv
Issue: OE-19 "Stereo Module" discussion
Labels: evolution

the feature request about evolution proposal [OE-19](https://github.com/opencv/opencv/wiki/OE-19.-Module-Stereo)
Repository: opencv
Issue: OE-20 "Calibration Module" discussion
Labels: evolution

the feature request about evolution proposal [OE-20](https://github.com/opencv/opencv/wiki/OE-20.-Module-Calibration)
Repository: opencv
Issue: OE-24 "Revised HighGUI Module" discussion
Labels: evolution

the feature request about evolution proposal [OE-24](https://github.com/opencv/opencv/wiki/OE-24.-Module-HighGUI)
Repository: opencv
Issue: OE-25 "Hardware-accelerated Video I/O Module" discussion
Labels: evolution

the feature request about evolution proposal [OE-25](https://github.com/opencv/opencv/wiki/OE-25.-Fast-VideoIO)
Repository: opencv
Issue: OE-26 "Revise Samples" discussion
Labels: evolution

the feature request about evolution proposal [OE-26](https://github.com/opencv/opencv/wiki/OE-26.-Samples)
Repository: opencv
Issue: OE-27 "Wide Universal Intrinsics" discussion
Labels: evolution

the feature request about evolution proposal [OE-27](https://github.com/opencv/opencv/wiki/OE-27.-Wide-Universal-Intrinsics)
Repository: opencv
Issue: OE-4 "OpenCV 4.0" discussion
Labels: evolution

the feature request about evolution proposal [OE-4](https://github.com/opencv/opencv/wiki/OE-4.-OpenCV-4)
Repository: TypeScript
Issue: Don't offer to infer parameter type if inferred type is 'any'
Labels: Bug,Domain: Quick Fixes

**TypeScript Version:**  2.8.0-dev.20180302

**Code**

```ts
function f(x) {}

function g(x) {
    f(x);
}
```

Click on first `x`.

**Expected behavior:**

No suggestion.

**Actual behavior:**

Suggestion to "infer parameter types from usage", which just adds `: any`.
Repository: create-react-app
Issue: Base configuration file query
Labels: issue: proposal,difficulty: medium

Wouldn't it be better for the default configuration after ejecting to inherit from a base Webpack configuration file and then have the development / production configurations merge off of the base configuration. Looking at the default generated files created by create-react-app after ejecting, I can see that there is a lot of duplication between `webpack.config.dev.js` and `webpack.config.prod.js`. Any reasons why it was written in this manner originally or why we can't move towards a base configuration file?

Apologies if this issue / question has been lodged before. Tried my best to find similar issues!
Repository: go
Issue: cmd/go: test gives go/parser's syntax errors, which are sometimes worse than the compiler's
Labels: NeedsFix

```
$ cat f3.go
package main

func f(x int) int {
        retrun x
}
$ go run f3.go
# command-line-arguments
./f3.go:4:9: syntax error: unexpected x at end of statement
$ gofmt f3.go
f3.go:4:9: expected ';', found x
f3.go:5:3: expected '}', found 'EOF'
```

I would usually not mind if go/parser is worse than the compiler's parser at giving useful errors. However, now that vet always runs with test, it's vet that reports syntax errors to me when I run `go test`. This particular error (the more confusing one) had me scratching my head for a minute, before I realised the typo.

Should this be fixed in go/parser, or should something else be done, such as using the compiler's syntax package to replace go/parser's syntax errors?

/cc @griesemer
Repository: go
Issue: runtime: wrong Unix error code from panic.
Labels: NeedsFix,early-in-cycle,compiler/runtime

Please answer these questions before submitting your issue. Thanks!


### What version of Go are you using (`go version`)?

go version devel +baf3eb1625 Tue Mar 6 01:11:26 2018 +0000 darwin/amd64

```
% cat p.go
package main

func main() {
	panic(3)
}
% ./p
panic: 3

goroutine 1 [running]:
main.main()
	/Users/r/p.go:4 +0x39
% echo $?
2
% 
 ```

Exit code 2 traditionally means 'incorrect arguments', as in flag.Usage.

Panic should be something like 127 or 255 on Unix.

Reported by darren.e.grant@gmail.com on nuts.
Repository: vue
Issue: SFC: Invalid root tag structure should throw error
Labels: improvement

**Moved from**: [vue-loader#1161](https://github.com/vuejs/vue-loader/issues/1161)

### What problem does this feature solve?
In Single File Component, `<script>` tag may or may not closed, so this works:

```html
<template>
  <div class="chicken">
    Chicken: {{ chicken }}
  </div>
</template>

<script>
export default {
  data() { return { chicken: 'fried' } }
}
// (EOF)
```

However, `<style>` isn't; if there's no `</style>`, styles are **simply ignored** without any warning or errors.

```html
<template>
  <div class="chicken">
    Chicken: {{ chicken }}
  </div>
</template>

<script>
export default {
  data() { return { chicken: 'fried' } }
}
</script>

<style scoped>
.chicken { /* super important */
  font-weight: 900;
}
/* (EOF) */
```

### What does the proposed API look like?
Any `<template>`, `<script>`, `<style>` tags should **explicitly**:

* Closed - unclosed tag should throw a warning and refuse to build.
* ~or May not closed - contents should build correctly even it's not closed.~

<!-- generated by vue-issues. DO NOT REMOVE -->
Repository: go
Issue: x/net/dns: invalid assumptions about domain names and character strings
Labels: NeedsFix

### What version of Go are you using (`go version`)?
`go version go1.10 linux/amd64`

### Does this issue reproduce with the latest release?
Yes.

### What did you do?
[Reviewed go cl 37879](https://go-review.googlesource.com/c/go/+/37879#message-f19801f32435469ed7e1ed98732f7bcd02da5aea) and [dns/dnsmessage/message.go as of 2018-03-06](https://github.com/golang/net/blob/22ae77b79946ea320088417e4d50825671d82d57/dns/dnsmessage/message.go).

### What did you expect to see?
Correct handling of DNS data.

### What did you see instead?
* [`func (n *Name) pack`](https://github.com/golang/net/blob/22ae77b79946ea320088417e4d50825671d82d57/dns/dnsmessage/message.go#L1537) incorrectly assumes that terminal dots imply absolute names, falsely accepting names that end with _escaped_ dots (e.g., `example\.`).
* [`func (n *Name) unpack`](https://github.com/golang/net/blob/22ae77b79946ea320088417e4d50825671d82d57/dns/dnsmessage/message.go#L1603) assumes that label contents can be directly copied from wire format to presentation format, and therefore incorrectly converts dots in labels to label-_separating_ dots (e.g., equating the distinct names `a.b.example.` [1 0x61  1 0x62  7 0x65 0x78 0x61 0x6d 0x70 0x6c 0x65  0] and `a\.b.example.` [3 0x61 0x2E 0x62  7 0x65 0x78 0x61 0x6d 0x70 0x6c 0x65  0]) and produces invalid domain names by naïvely including backslashes and control characters.
* [`type TXTResource`](https://github.com/golang/net/blob/22ae77b79946ea320088417e4d50825671d82d57/dns/dnsmessage/message.go#L1954) incorrectly assumes that TXT RDATA is a single string (when it reality it is a _sequence_ of character strings [1], each of which is limited to 255 octets in wire format [2]), making it impossible to differentiate `TXT "" ""` (two empty character strings) from `TXT ""` (one empty character string). The associated pack/unpack code also fails to reject overly-long strings (e.g., "aa-ab-ac-…-az-ba-bb-bc-…-zx-zy-zz"), instead naïvely combining/splitting 255-octet chunks.

[1]: https://tools.ietf.org/html/rfc1035#section-3.3.14
[2]: https://tools.ietf.org/html/rfc1035#section-3.3
Repository: go
Issue: x/net/http2: add ability to specify priority to http2.Transport.RoundTrip
Labels: NeedsDecision,FeatureRequest

Example diff: https://github.com/golang/net/pull/17/files

Use case: I'm implementing an HTTP/2 reverse that would like to pass through the priority that the client sends to the upstream server.
Repository: rust
Issue: Mismatched lifetime in trait function declaration is not detected
Labels: C-enhancement,A-diagnostics,T-compiler,fixed-by-NLL,A-suggestion-diagnostics,D-papercut

Consider the following code:
```rust
pub trait FromStr<'a>: Sized {
    type Err;
    fn from_str(s: &'a str) -> Result<Self, Self::Err>;
}

struct Foo<'a>(&'a str);

impl<'a> FromStr<'a> for Foo<'a> {
    type Err = ();
    fn from_str(s: &str) -> Result<Self, Self::Err> {
        Ok(Foo(s))
    }
}
```

The compiler errors out failing to infer an appropriate lifetime:
```

error[E0495]: cannot infer an appropriate lifetime for lifetime parameter `'a` due to conflicting requirements
  --> src/main.rs:11:12
   |
11 |         Ok(Foo(s))
   |            ^^^
   |
note: first, the lifetime cannot outlive the anonymous lifetime #1 defined on the method body at 10:5...
  --> src/main.rs:10:5
   |
10 | /     fn from_str(s: &str) -> Result<Self, Self::Err> {
11 | |         Ok(Foo(s))
12 | |     }
   | |_____^
note: ...so that reference does not outlive borrowed content
  --> src/main.rs:11:16
   |
11 |         Ok(Foo(s))
   |                ^
note: but, the lifetime must be valid for the lifetime 'a as defined on the impl at 8:1...
  --> src/main.rs:8:1
   |
8  | impl<'a> FromStr<'a> for Foo<'a> {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = note: ...so that the expression is assignable:
           expected std::result::Result<Foo<'a>, _>
              found std::result::Result<Foo<'_>, _>
```

But the most immediate error is that the declaration of `from_str` doesn't match the trait definition, missing the lifetime bound on `&str` to match the lifetime associated with the trait.
Repository: vscode
Issue: Allow a workspace to show individual files from other folders
Labels: feature-request,workbench-workspace,keep

**Update from @bpasero:** this issue was renamed based on the discussion at the end (see https://github.com/microsoft/vscode/issues/45177#issuecomment-1341005532 and above)

**_Original below:_**

<!-- Do you have a question? Please ask it on https://stackoverflow.com/questions/tagged/vscode. -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.20.1
- OS Version: Microsoft Windows [Version 10.0.16299.248]

Steps to Reproduce:

N/A

<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

---

Currently, .code-workspace only contains `folders` field which allows to add folders into workspace. I prefer a way to add single files into workspace for the entire project, such as README or something else.
Repository: TypeScript
Issue: Suggestion: ability to find imports for module
Labels: Suggestion,Awaiting More Feedback

Find references is a very useful feature, however sometimes I need to be able to find all imports of a given module:

- regardless of what they're exporting
- but the module does not have any exports

This is sometimes necessary when a module has side effects, and you want to see which files imported it.

This might also be useful for dynamic imports. In one project we have several dynamic imports (for code splitting) that never explicitly reference the module exports, so if I use find references on those module exports, I will not be shown the dynamic import. For example, here is a dynamic import:

![image](https://user-images.githubusercontent.com/921609/37094649-681f42ba-220b-11e8-9ac1-87311528cd16.png)

When I activate find references on the exports of that module, I am not shown the import:

![image](https://user-images.githubusercontent.com/921609/37094636-5bc57f48-220b-11e8-9b72-719a74291ec4.png)
Repository: vscode
Issue: [json] External schemas referenced from schema not updated
Labels: bug,json

### Issue Type
Bug

### Description

#### Setup
**`color-schema.json`**
```
{
  "$schema": "http://json-schema.org/draft-07/schema#",
  
  "validColors": {
    "enum": ["Red"]
  }
}
```

**`schema.json`**
```
{
  "$schema": "http://json-schema.org/draft-07/schema#",

  "type": "object",
  "properties": {
    "color": { "$ref": "color-schema.json#/validColors" }
  },
  "required": ["color"]
}
```

**`test.json`**
```
{
  "$schema": "./schema.json",
  "color": "Red"
}
```

#### Test 1: Intellisense notices changes in `schema.json`
Rename the property `color` to `colorx` in `schema.json` -> (Desired) error in `test.json`: `Missing property "colorx".`

:heavy_check_mark: That work's!

#### Test 2: Intellisense does not notice changes in `color-schema.json`
Change `Red` to `Yellow` in `color-schema.json` -> no errors!

Restarting VSCode finally gives the desired error in `test.json`: `Value is not accepted. Valid values: "Yellow".`

:x: That doesn't work! (i. e. at least without restarting VSCode after each schema dependency change)


### VS Code Info

VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:31:21.019Z)
OS version: Linux x64 4.13.0-36-generic

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 x 2194)|
|Load (avg)|1, 1, 1|
|Memory (System)|7.71GB (1.54GB free)|
|Process Argv|/usr/share/code/code --unity-launch|
|Screen Reader|no|
|VM|0%|

</details><details><summary>Extensions (6)</summary>

Extension|Author (truncated)|Version
---|---|---
calculate|aca|2.0.0
QML|bbe|1.0.0
Kotlin|mat|1.5.0
cpptools|ms-|0.15.0
vetur|oct|0.11.7
enumerator|swi|0.0.6


</details>
Reproduces without extensions
Repository: TypeScript
Issue: String.replace does not accept string | (string, ...any[]) => string replacer
Labels: Bug,Help Wanted,Domain: lib.d.ts

**TypeScript Version:**  2.7.2

**Search Terms:** String.replace overload union parameter

**Code**

```ts
type ReplacerFn = () => string;
type Replacer = string | ReplacerFn;

function replaceFoo(str: string, replacer: Replacer) {
    return str.replace(new RegExp("foo"), replacer);
}
```

**Expected behavior:**
Compiles successfully.

Perhaps the change is as simple as combining the two overloads into a union, though the implications of that change are possibly unpleasant as far as tooling is concerned.

**Actual behavior:**
`bad.ts(5,43): error TS2345: Argument of type 'Replacer' is not assignable to parameter of type '(substring: string, ...args: any[]) => string'.
  Type 'string' is not assignable to type '(substring: string, ...args: any[]) => string'.`

**Playground Link:** [playground link](https://www.typescriptlang.org/play/#src=type%20ReplacerFn%20%3D%20()%20%3D%3E%20string%3B%0D%0Atype%20Replacer%20%3D%20string%20%7C%20ReplacerFn%3B%0D%0A%0D%0Afunction%20replaceFoo(str%3A%20string%2C%20replacer%3A%20Replacer)%20%7B%0D%0A%20%20%20%20return%20str.replace(new%20RegExp(%22foo%22)%2C%20replacer)%3B%0D%0A%7D)

**Related Issues:**
#20432 (Array.from)
#20215 (new Date)
#14107 (underlying issue)
Repository: rust
Issue: Collect and aggregate timing statistics of CI builders
Labels: C-enhancement,T-bootstrap,T-infra

Currently we only have a little bit of insight into how long all our CI builds are taking with a breakdown of where all that time is going. It's hoped that if we have a historical record of the duration of CI builds which is relatively consistent and granular we can more easily see regressions that happen over time and diagnose otherwise obvious-in-retrospect problems with the build.

The current thinking for how this might be done is to instrument rustbuild to, by default on CI, emit timing information about each step in a structured fashion. The thinking is we could then scrape the logs of all our CI builds to aggregate this structure data. The data needs to include enough information so that it can indeed be easily aggregated. For example we shouldn't have to look at the Travis environment to guess whether it's an OSX/Linux build or which architecture is being assembled.

Once we've got this data we can hopefully set up graphs over time like https://rust-lang-nursery.github.io/rustc-pr-tracking/ to see what time is going where. CI timings are *very* noisy but the hope is that general trends will still be relatively clear.