sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: encoding/json: document Valid allows invalid utf8 
Labels: Documentation,NeedsDecision

<!--
Please answer these questions before submitting your issue. Thanks!
-->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.20 linux/amd64
</pre>

### Does this issue reproduce with the latest release?

Yes.

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/lukeshu/.cache/go-build"
GOENV="/home/lukeshu/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/lukeshu/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/lukeshu/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.20"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/run/user/1000/tmpdir/go-build2160073961=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### What did you do?

I passed a binary garbage wrapped in `"` quotes to `json.Valid`.

```go
package main

import (
	"encoding/json"
	"fmt"
)

func main() {
	jsonStr := "\"0\x85\xcd\xc0\xf3\xcb\xc1\xb3\xf2\xf5\xa4\xc1\xd40\xba\xe9\""
	fmt.Println(json.Valid([]byte(jsonStr)))
}
```

https://go.dev/play/p/rrtmrEL3Ipd

### What did you expect to see?

As JSON is specified to be "a sequence of Unicode code points" (ECMA-404) or "encoded in UTF-8, UTF-16, or UTF-32" (RFC 7159) I would expect that a JSON document containing bytes that cannot be interpreted as Unicode codepoints to not be considered valid.

### What did you see instead?

It considered the document to be valid, even though it contains bytes that cannot be interpreted as Unicode codepoints.
Repository: javascript
Issue: Documentation for 'import/no-extraneous-dependencies' is missing
Labels: pull request wanted,editorial

The rule is set to error in the config:
https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/imports.js#L71

But there's no mention of it in the guide:
https://github.com/airbnb/javascript/blob/master/README.md

This rule should be mentioned under the Modules section.
Repository: storybook
Issue: Codemod to transform CSF JS to TS
Labels: feature request,cli,codemods

This will allow`.stories.mdx` to generate TS CSF

Also, will help with a follow-up task for automatically upgrading to TS4.9 #20836
Repository: vscode
Issue: STOP auto adding space after colon on css properties
Labels: bug,emmet,confirmation-pending

Yes, I know, according to someone's criteria this is more readable.
In our case it is NOT and we have programmed like this for years and we do not want to change it.

If I write, for example "flo", and I press enter to fill the "float" property, visual will put "float: ;" and I want it to write "float:;".

I have to remove space every single time and it's really struggling.

Theoretically with this configuration, it should stop happening:

`"emmet.preferences": {
    "css.valueSeparator": ":",
    "stylus.valueSeparator": "",
},`

BUT it only partly works: If autocompletes including value of property eg: left for float, it does write "float:left". Perfect.
But if autocompletes only with the name of property, it still puts the damn space after the colon "float: ;"

Something is wrog with this autocompletition emmet.

- VS Code Version: 1.75.1
- OS Version: W11

Steps to Reproduce:

1. Configure emmet.preferences.css.valueSeparator as ":"
2.  Write style="" on html
3. Put f inside style and autocomplete it.
Repository: flutter
Issue: MacOS TextField does not work if window style is changed
Labels: a: text input,engine,platform-mac,a: desktop,has reproducible steps,P2,found in release: 3.7,found in release: 3.8,fyi-text-input,team-macos,triaged-macos

![image](https://user-images.githubusercontent.com/63228361/218711157-3a830200-0bd6-48fb-98a3-6bab18b0ebaf.png)

After changing this value to "NO" all TextFields in the app stop working. (When you input anything - nothing happens).

![image](https://user-images.githubusercontent.com/63228361/218711856-9c58df86-3c31-40ca-a456-ebf00a7d86aa.png)

```
  @override
  Widget build(BuildContext context) {
    return SizedBox(
      width: scale(widget.width),
      child: TextField(
        controller: widget.controller,
      ),
    );
  }
```

Platform: MacOS, Flutter: the latest from the stable channel
Repository: PowerToys
Issue: Add Vietnamese language for all of PowerToys
Labels: Idea-New PowerToy,Area-Localization

### Description of the new feature / enhancement

Add Vietnamese to PowerToys

### Scenario when this would be used?

If the language of Windows is Vietnamese, PowerToys will also switch to Vietnamese

### Supporting information

_No response_
Repository: flutter
Issue: MediaQuery > Padding > Top is incorrect on iPhone 14 Pro. 
Labels: e: device-specific,platform-ios,a: fidelity,a: layout,has reproducible steps,P2,found in release: 3.7,found in release: 3.8,team-ios,triaged-ios

Further to closed issue #113665 the padding.top supplied by media query on iPhone 14 Pro is in fact wrong anyway. 

Flutter sets it to 59 pt but the actual value is 54 pt. This can be confirmed from the official iOS design resource and measured directly as done in the the screenshots attached.

Flutter padding is 59 pt.
![Flutter](https://user-images.githubusercontent.com/121443452/218737606-2d543c9a-5326-4342-bab4-9d34c3c7bd97.jpg)

iOS padding is 54 pt
![iOS](https://user-images.githubusercontent.com/121443452/218737618-dbdf5296-1cc9-4f81-a6f6-864f378456e9.jpg)

This test was done using:
- iPhone 14 Pro Simulator running iOS 16.2
- Flutter 3.7.3
- Xcode 14.2

I hope that helps.
R
Repository: godot
Issue: Nested PopupMenu doesn't respect parent position.x + remote lag
Labels: bug,topic:gui

### Godot version

4.0 RC1

### System information

Windows 10, all renderers, Nvidia GTX1060

### Issue description

Creating nested PopupMenu layers beyond the first child resets `position.x` to 0.
The current workaround is to force it when the `about_to_popup` signal is received.

Also, while doing research I going into `Remote` the editor was lagging but the runtime was OK.

### Steps to reproduce

1. Create a nested PopupMenu menu.
2. Traverse through the menu in a running app

### Minimal reproduction project

[PopupMenu position.zip](https://github.com/godotengine/godot/files/10732513/PopupMenu.position.zip)
Repository: vscode
Issue: Diff / Compare does not honor ignore trailing/leading whitespace settings
Labels: diff-editor,regression

Type: <b>Bug</b>

Hi,

In earlier versions of vscode, "ignore leading/trailing whitespace differences" worked.  In this version, it doesn't.  Lines with only leading / trailing white space differences are shown as different.  

Steps:
- compare two files.  A few lines in these files only have leading and trailing whitespace differences

Expected result:
- lines with only leadin/trailing whitespace differences should not be marked as different

Actual result:
- lines with only leading/trailing whitespace differences are marked as different

Note: works as expected after downgrading to the older version 1.74.3

VS Code version: Code 1.75.1 (441438abd1ac652551dbe4d408dfcec8a499b8bf, 2023-02-08T21:32:34.589Z)
OS version: Windows_NT x64 10.0.19043
Modes:
Sandboxed: No
Remote OS version: Linux x64 5.4.0-60-generic

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx   (8 x 2096)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: disabled_off<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_renderer: enabled_on<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: disabled_off|
|Load (avg)|undefined|
|Memory (System)|13.92GB (6.33GB free)|
|Process Argv|--crash-reporter-id 95a035c2-d82b-4389-b0e7-0f165ae091b0|
|Screen Reader|no|
|VM|80%|

|Item|Value|
|---|---|
|Remote|SSH: 207.180.251.250|
|OS|Linux x64 5.4.0-60-generic|
|CPUs|Intel(R) Xeon(R) CPU E5-2630 v4 @ 2.20GHz (6 x 2199)|
|Memory (System)|15.64GB (10.38GB free)|
|VM|67%|
</details><details><summary>Extensions (2)</summary>

Extension|Author (truncated)|Version
---|---|---
remote-ssh|ms-|0.96.0
html-preview-vscode|tht|0.2.5


</details><details>
<summary>A/B Experiments</summary>

```
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vscaat:30438848
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
vsccc:30610678
pyindex848cf:30577861
nodejswelcome1cf:30587006
3biah626:30602489
f6dab269:30613381
pythonsymbol12:30657548
a9j8j154:30646983

```

</details>

<!-- generated by issue reporter -->
Repository: PowerToys
Issue: Mapping key problem
Labels: Issue-Bug,Needs-Triage

### Microsoft PowerToys version

Powertoys v0.67.1

### Installation method

Microsoft Store

### Running as admin

No

### Area(s) with issue?

General

### Steps to reproduce

I have a PC at work that I use for graphics. I use Powertoys to map a macally keyboard. I can swap the Control/Command keys, but I get an error "Warning: The following keys do not have assignments: Alt (Left)" when I try to map the Alt key to the Option key on my keyboard.

### ✔️ Expected Behavior

the Option key would react as the PC Alt key

### ❌ Actual Behavior

the Option key does not work (doesn't 'kern' letters in a sentence, etc).

### Other Software

Powertoys v0.67.1

Admin installed it. Running as a user
![warning](https://user-images.githubusercontent.com/125313334/218754735-c6dbe1e8-b96d-4180-a270-18b59d4e1bb3.jpg)
![warning](https://user-images.githubusercontent.com/125313334/218754801-357014a4-3911-489f-b49c-7654f125bb0d.jpg)
Repository: rust
Issue: rustc should fail CI on `allow(incomplete_features)`
Labels: S-blocked,A-meta

I do not think it is a good idea for rustc to be depending on incomplete features, it doesn't feel particularly fair to people working on said features that when they attempt to make progress on a broken feature they would have to deal with `cfg(bootstrap)` pain and generally fixing rustc itself from usage of the feature. Also just generally depending on broken or unsound features in rustc is probably not good :laughing: 

Recently stumbled on #107937 which attempts to enable `generic_const_expr` a (very) broken/incomplete feature.

As far as I can tell there's only one usage of `allow(incomplete_features)` and that's to enable `adt_const_params` which will likely be moved off of `incomplete_features` soonish
Repository: material-ui
Issue: [docs] Tooltip documentation missing componentProps added in #28679
Labels: docs,component: tooltip

### Duplicates

- [X] I have searched the existing issues

### Related page

https://mui.com/material-ui/api/tooltip/

### Kind of issue

Missing information

### Issue description

Missing and incorrect documentation:

I was looking for a way to use **sx**-prop to edit tooltip popper css and it appears that **componentProps**-prop that was added in [PR 28692](https://github.com/mui/material-ui/pull/28692) is still missing the documentation.

It took me several hours to find the problem and correct issue with the solution to it.

Also the description of the **sx**-prop gives incorrect information about how it works with **Tooltip**-component.


### Context 🔦

_No response_
Repository: next.js
Issue: Prefixing the default locale with Middleware does not work
Labels: examples

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```
Operating System:
      Platform: linux
      Arch: x64
      Version: #156-Ubuntu SMP Fri Jan 20 17:27:18 UTC 2023
    Binaries:
      Node: 16.14.2
      npm: 8.5.0
      Yarn: 3.2.0
      pnpm: N/A
    Relevant packages:
      next: 13.1.7-canary.12
      eslint-config-next: N/A
      react: 18.2.0
      react-dom: 18.2.0
```

### Which example does this report relate to?

 i18n-routing 

### What browser are you using? (if relevant)

Firefox for Linux 109.0.1 (64-bit)

### How are you deploying your application? (if relevant)

Vercel

### Describe the Bug

We have a multi-domain platform and some of the domains support more than 1 locale (`.ch` supports `de-ch`, `fr-ch` and `it-ch`; `.be` supports `nl-be` and `fr-be`) Our configuration file looks like below (excerpt): 

```javascript
const defaultLocale = 'nb-no'
const locales = ['nb-no', 'fr-fr', 'de-ch', 'nl-be', 'fr-ch']
const domains = [{ domain: 'otovo.ch', defaultLocale: 'de-ch', locales: ['de-ch', 'fr-ch', 'it-ch' ...}]

...
return {
  locales,
  defaultLocale,
  domains,
};
```

middleware.ts

```typescript
import { NextRequest, NextResponse } from 'next/server';

const IS_PUBLIC_FILE = /\.(.*)$/;

// ts-prune-ignore-next
export function middleware(request: NextRequest) {
  const url = request.nextUrl.clone();
  const { host, hostname, pathname, locale, search, origin } = url;

  if (pathname.startsWith('/blog/')) {
    url.pathname = '/api/blogProxy';
    url.searchParams.set('host', host);
    url.searchParams.set('hostname', hostname);
    url.searchParams.set('pathname', pathname);
    url.searchParams.set('search', search);
    url.searchParams.set('locale', locale);
    return NextResponse.rewrite(url);
  }

  const shouldHandleLocale =
    !IS_PUBLIC_FILE.test(pathname) &&
    !pathname.includes('/api/') &&
    locale.startsWith('default-');

  if (shouldHandleLocale) {
    return NextResponse.redirect(
      new URL(`${origin}/${locale.replace('default-', '')}`),
    );
  }

  if (pathname === '/new/') {
    url.pathname = '/';
    return NextResponse.redirect(url);
  }

  return NextResponse.next();
}
```

We're using an [official workaround](https://nextjs.org/docs/advanced-features/i18n-routing#prefixing-the-default-locale) from the Nextjs documentation to prefix the default locale to the URL.

Running the application locally works as expected. When deployed to Vercel, the behavior is the following:

- <domain>.ch redirects to <domain>.no (.no is the `defaultLocale`)

### Expected Behavior

We expect <domain>.ch to redirect to <domain>.ch/de-ch

### To Reproduce

![Peek 2023-02-14 15-12](https://user-images.githubusercontent.com/9203090/218763841-f2a947ce-47b7-4491-aca2-38354732b871.gif)

Also, can be observed by visiting https://staging-www.otovo.ch
Repository: pytorch
Issue: grid_sample with relative grid
Labels: feature,module: nn,triaged,actionable,module: interpolation

### 🚀 grid_sample with relative grid, to make code simpler, and optimize speed and accuracy

Currently, "grid_sample" requires a "grid" with (sort of) "absolute" values. Meaning -1 is the left image edge and +1 is the right image edge. That seems fine in theory. However, practically, if we're talking about big images, e.g. 4K video, the pixels become so small that the addressing becomes highly inaccurate when using Float16.

E.g. let's play around with Float16 numbers here:

https://evanw.github.io/float-toy/

Let's say we want to move pixel 0 to the side by 0.5 pixels. So when talking about a 4K image, the "grid" would need to have a value of -1919.5 / 1920 = -0.99973958333. If you enter this number into the float calculator above, due to the limited accuracy of Float16, the number changes to just -0.9996. Now let's multiply by 1920 and we get -1919.232. So instead of the desired pixel shift of 0.5 we actually get a pixel shift of 0.768! You can see how inaccurate this becomes, and that creates very noticeable image quality degradations. Which means that when using a Float16 grid, grid_sample becomes totally unusable because at high image resolutions, Float16 becomes so inaccurate that it's basically utterly broken.

Now we could argue that we should simply create a Float32 grid. It works well. So why not do that? Well, it consumes more RAM, and it's slower. So it would be much nicer if we could use a Float16 grid.

**So here comes my wish**: There should be a grid_sample alternative which accepts a relative grid. With the "grid" all zero, basically input and output images should be identical. If you want to read a pixel from 0.1 pixels from the right, that pixel in the grid would simply have a value of "0.1". Such a relative grid should work perfectly fine with Float16.

Plus, most neural networks (especially convolutional ones) which create a "grid" actually calculate relative values natively, anyway! They don't usually calculate absolute values. So if you look through all the public neural networks which use grid_sample, many (most?) of them painfully convert their internal relative grid to an absolute grid, to make grid_sample happy. Which is a completely useless conversion, which only makes the use of grid_sample more complex, plus it introduces the Float16 accuracy problem explained above.

Practically, in all my neural networks which use grid_sample, if there was a relative addressing version of grid_sample available, my code would be simpler, and I could stick to Float16, which my neural network natively calculates, anyway (due to Automatic Mixed Precision training). So it would also perform better, with no relative -> absolute conversion needed, and no Float16 -> Float32 conversion needed, either.

### Additional context

This feature wish is loosely related to issue # 94733.

cc @albanD @mruberry @jbschlosser @walterddr @saketh-are
Repository: angular
Issue: Custom validation for FormControl dependent on other FormControl states (not cross field validation)
Labels: area: forms

### Which @angular/* package(s) are relevant/related to the feature request?

forms

### Description

**Form validation** is a critical aspect in **FormControl** and **FormGroup** Angular, A **cross-field validator** is a custom validator that compares the values of different fields in a form and we **can use it only in FormGroup**.

**It's a good think if we have the possibility to create a  custom validation in FormControl that depends on the validity and the value of another FormControls.**

For example, suppose we have this form (this is not a real project example): 

    this.fb.group({
      control1:     new FormControl<number>([0, Validators.required,Validators.min(8), Validators.max(16)]),
      control2:     new FormControl<number>([0', Validators.required,Validators.min(10), Validators.max(14)]),
      control3:     new FormControl<number>([0,ourCustomValidator]),
    });

**Control3 will only be considered as valid if both Control1 and Control2 are valid and the sum of their values is less than or equal to 20**

And there is our custom validator:

```
export function ourCustomValidator(): ValidatorFn {
    return (control: AbstractControl): ValidationErrors | null => {
       //Implement custom validator logic here
    };
  }
```

The interface **ValidatorFn** accept only the **formControl** to validate:
interface [ValidatorFn](https://angular.io/api/forms/ValidatorFn) {
  [(control: AbstractControl<any, any>): ValidationErrors | null](https://angular.io/api/forms/ValidatorFn#call)
}





### Proposed solution

Modify the validatorFn to add the list of formControls on which the concerned formControl depends.


```
interface validatorFn {
    (control: AbstractControl<any, any>, controlsDepondsOn?: AbstractControl | AbstractControl[]): ValidationErrors | null
}
```

If any controls in the **'controlsDependsOn'** list are not valid, then our formControl is automatically considered invalid. If the entire list is valid, we can proceed with implementing the custom validator

and the custom validator will be :

```
export function ourCustomValidator(): ValidatorFn {
   
 return (control: AbstractControl,controlsDepondsOn: AbstractControl | AbstractControl[]): ValidationErrors | null => {
      -- We can use the values of the controls here to implement the logic of our custom validator
    };

  }
```

### Alternatives considered

To verify the validity of the dependent FormControls in the custom validator, we can manually perform the necessary checks

```
export function ourCustomValidator(): ValidatorFn {
    return (control: AbstractControl): ValidationErrors | null => {
     
         control.parent?.get('control1').valid && control.parent?.get('control2').valid {
        
        }

    };
  }
```
Repository: flutter
Issue: Use pinned+rolled plugin sources for framework tests
Labels: a: tests,team,framework,package,team-ecosystem,P2,triaged-ecosystem

We have tests that use published 1P plugins as part of testing plugin support, such as [this one](https://github.com/flutter/flutter/blob/778b3fa3226637dc6825bba176a3b84c880c27a0/dev/devicelab/bin/tasks/plugin_lint_mac.dart#L214). Originally they used `any`, but we've (at least mostly) replaced them with pinned versions to avoid issues where the framework tree would have OOB failures due to new plugin versions being published that weren't compatible with the test somehow.

Now we have the problem that the versions being used in tests will just get more and more stale. Since we already have a roller that manages a pinned version of the plugins tree, we should update tests that are using 1P plugins to check out the pinned version, and then use them from source. That way they will stay updated, but not have OOB changes.

(See also https://github.com/flutter/flutter/issues/98599)
Repository: godot
Issue: GDScript scrolling while selecting text
Labels: topic:editor,confirmed,topic:input,topic:gui,performance

### Godot version

4.0 rc1

### System information

Windows 11

### Issue description

When I selected a few lines of code scrolling became choppy and unresponsive
I was scrolling while holding left click as I was selecting the text
![image](https://user-images.githubusercontent.com/85768334/218775666-b7c8e03b-045c-4215-92fc-c163a2ef010f.png)

### Steps to reproduce

Any GDScript file

### Minimal reproduction project

Any GDScript file
Repository: vscode
Issue: Add expand/collapse audio cues
Labels: feature-request,accessibility,accessibility-signal

While meeting with @jooyoungseo, it became clear that audio cues are extremely useful for navigating while keeping the cognitive burden to a minimum. 

Some audio cues he has configured that we should consider building in:
- expand/collapse bread crumb components
- different pitches for header levels in a markdown document

cc @isidorn