sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: TypeScript
Issue: Type checking doesn't work with extra function arguments
Labels: Bug

Extra argument types are inferred correctly but aren't checked. Looks like #17559 is implemented incompletely. And this code also breaks colorization by vscode like the following code.

```ts
function f(): <T extends string>(a: T) => void {
  return (a, b = a) => {
    isFinite(a);
    isFinite(b);
  }
}
```

cc @DanielRosenwasser @RyanCavanaugh 

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  master

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**

**Code**

```ts
const f: () => void = (a = '') => isFinite(a); // should be error
```

**Expected behavior:**

**Actual behavior:**

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->

**Related Issues:** <!-- Did you find other bugs that looked similar? -->
Repository: go
Issue: cmd/go: outer module can provide packages that appear to be in an inner module
Labels: Documentation,NeedsInvestigation,GoCommand,modules

Consider two modules, one of which is nested in the other:
```
modcache/pkg/mod/foo.com
├── outer
│   └── inner@v1.0.0
│       ├── go.mod
│       └── p2
│           └── y.go
└── outer@v1.0.0
    ├── go.mod
    └── inner
        └── p
            └── x.go
```

Module `foo.com/outer/inner` contains `p2`, which would be imported as `foo.com/outer/inner/p2`. Module `foo.com/outer` contains `inner/p`, which would be imported as `foo.com/outer/inner/p`.

I think most people would find this surprising. I certainly did. I had thought that the presence of a nested module "punched a hole" in the containing module, but I guess that's only true if the `go.mod` file is actually present in the source tree of the containing module? So if the two modules are developed on separate branches, as would have happened here, the hole-punching behavior doesn't happen?

Is this a bug, or expected behavior?

@bcmills, @jayconrod
Repository: kubernetes
Issue: Validate/test usage of service account credentials in cloud controller manager
Labels: area/test,area/cloudprovider,kind/feature,lifecycle/frozen,sig/cloud-provider

**What would you like to be added**
We have no coverage for whether bootstrap roles sufficiently cover RBAC with service account credentials for controllers in the cloud-controller-manager. As of today, they should use the same roles as kube-controller-manager. We should have tests/validation in place to ensure that this is covered in CI. 

A good place to start (though not easy) would be to just cover existing E2E tests on clusters with the cloud-controller-manager running (GCE and AWS ideally because we already run E2E tests there). That should validate most of the access the cloud-controller-manager needs (node registration, deletion, service update, etc). 

**Why is this needed**:
Prevent bugs in the CCM, like what happened in https://github.com/kubernetes/kubernetes/pull/72764 

/cc @cheftako @liggitt @mcrute @d-nishi
Repository: vue
Issue: Transition's @appear hook invoked even when appear not specified / falsy
Labels: bug,transition

### Version
2.5.22

### Reproduction link
[https://codepen.io/anon/pen/jXdLGV](https://codepen.io/anon/pen/jXdLGV)







### Steps to reproduce
Open the repro and note that the rendered page says "initial appear".

### What is expected?
The `@appear` hook should not be invoked and the page should just say "initial".

### What is actually happening?
The `@appear` hook is invoked even though the `transition` doesn't have an `appear` attribute, and hence shouldn't be triggering on appear.  The same thing happens if you add `:appear ="false"` to the `transition`.

---
Ran into this when building some custom transition components where `appear` should be user-controlled, but was being invoked all the time instead.

<!-- generated by vue-issues. DO NOT REMOVE -->
Repository: scrcpy
Issue: GUI for Mac would be cool
Labels: feature request

Why not release a interface for this program?
Repository: terminal
Issue: ENABLE_WRAP_AT_EOL_OUTPUT is not working with VT100
Labels: Product-Conhost,Area-Output,Issue-Bug

The cursor doesn't moves to the beginning of the next row when it reaches the end of the current row. It works as intended when VT100 is disabled.

Windows build number: ```Microsoft Windows [Version 10.0.17134.523]```

Code:
```c++
#include <iostream>
#include <string>
#include <Windows.h>

using std::string;
using std::cout;
using std::endl;

int main()
{
    HANDLE stdOut = GetStdHandle(STD_OUTPUT_HANDLE);

    DWORD consoleMode =
        ENABLE_PROCESSED_OUTPUT |
        ENABLE_WRAP_AT_EOL_OUTPUT |
        ENABLE_VIRTUAL_TERMINAL_PROCESSING;

    SetConsoleMode(stdOut, consoleMode);

    CONSOLE_SCREEN_BUFFER_INFO screenBufferInfo;
    GetConsoleScreenBufferInfo(stdOut, &screenBufferInfo);

    SHORT length = screenBufferInfo.dwSize.X;
    string str(length - 1, '.');
    cout << str;

    int before = 0;
    int after = 0;

    GetConsoleScreenBufferInfo(stdOut, &screenBufferInfo);
    before = screenBufferInfo.dwCursorPosition.X;

    cout << 'x';

    GetConsoleScreenBufferInfo(stdOut, &screenBufferInfo);
    after = screenBufferInfo.dwCursorPosition.X;

    cout << endl
        << "before: " << before << endl
        << "after: " << after << endl;
}
```

Output:
```
before: 119
after: 119
```
Repository: go
Issue: os/signal: TestCtrlBreak fails with "exit status 0xc000013a" error
Labels: Testing,OS-Windows,NeedsInvestigation,compiler/runtime

Our windows-arm builder occasionally fails 

https://build.golang.org/log/e345b763b3b62e4efd13bdfd95361fbc6655c3dd

with
```
--- FAIL: TestCtrlBreak (14.29s)
    signal_windows_test.go:102: Program exited with error: exit status -1073741510
FAIL
FAIL	os/signal	25.339s
```

I do not have windows-arm computer to investigate, so @jordanrh1 please investigate.

Strangely there is no output from the child process - only failed exit code.

Also the exit code is -1073741510 = 0xFFFFFFFFC000013A. Maybe C000013A have some meaning - my Google foo failed me.

Thank you

Alex
Repository: godot
Issue: Shader does not seem to work using the [Visual Shader Editor]
Labels: bug,topic:rendering,usability

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
<!-- Specify commit hash if non-official. -->
3.1-beta.1

**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->

- Windows 10
- GTX 1060 _(417.22)_

**Issue description:**

I'm a beginner so it's probably my implementation that is wrong!

The Texture turns white when I expect it to not change:

<!-- What happened, and what was expected. -->
![image](https://user-images.githubusercontent.com/7990765/51176881-62166b00-18be-11e9-98e2-ec8f6ca75940.png)

**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
[test-shaders.zip](https://github.com/godotengine/godot/files/2759369/test-shaders.zip)
Repository: vue
Issue: Modifier to propagate/forward events to parent
Labels: feature request

### What problem does this feature solve?
Currently, and as far as I know, if we want to propagate an event fired by a child component to the parent (the child's grandparent) we need to $emit the event again, and we need to pass all the arguments one more time. This can become a problem, for example, if the event has a variable number of arguments because we need to specify them manually or pass the whole array as a new argument.

The current way would be something like
```
@blur="$emit('blur')"
@create="$emit('create', arguments[0])"
@input="$emit('input', arguments[0], arguments[1])"
```

### What does the proposed API look like?
```
@blur.propagate
@create.propagate
@input.propagate
```
And if we want to both handle the event and propagate it to the parent, we would use
```
@input.propagate="someFunction"
```
----
EDIT: Maybe since .propagate may be confused with the function .stopPropagation(), a better term could be simply .emit

<!-- generated by vue-issues. DO NOT REMOVE -->
Repository: go
Issue: cmd/vet: stdmethods check gets confused if run on a package named "xml"
Labels: NeedsFix,Analysis

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.11.4 darwin/amd64
</pre>

### Does this issue reproduce with the latest release?
yes

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jc/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/jc/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.11.4/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.11.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/pf/_mdvc42j193c4tf6kgfm80gcss_jqd/T/go-build565539251=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>

### What did you do?
For example, if I have the following package:
```
package xml

import (
	"encoding/xml"
	"io"
)

type XMLMap map[string]string

type XMLMapEntry struct {
	XMLName xml.Name
	Value   string `xml:",chardata"`
}

// UnmarshalXML 
func (m *XMLMap) UnmarshalXML(dec *xml.Decoder, start xml.StartElement) error {
	v := XMLMap{}

	for {
		var e XMLMapEntry

		err := dec.Decode(&e)
		if err == io.EOF {
			break
		}

		if err != nil {
			return err
		}

		v[e.XMLName.Local] = e.Value
	}

	*m = v
	return nil
}
```

### What did you expect to see?
```
go vet ./...
< no output>
```


### What did you see instead?
```
$ go vet ./...
./xml.go:16: method UnmarshalXML(dec *xml.Decoder, start xml.StartElement) error should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error
```

even if I try to alias `encoding/xml` import I still get same error.

If instead I have the same code, but rename package:
```
package something
...
<same code as before>
```

```
go vet ./...
< no output>
```

go vet doesn't seem to handle correctly if code is in package also named xml.
Repository: go
Issue: cmd/go: reject 'go generate' on packages in unreplaced module dependencies?
Labels: help wanted,NeedsFix,GoCommand,modules

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.12beta2 linux/amd64
</pre>

### Does this issue reproduce with the latest release?

Testing with the beta pre the 1.12 release.

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPROXY=""
GORACE=""
GOROOT="/home/myitcv/gos"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build968143131=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### What did you do?

Ran [`testscript`](https://github.com/rogpeppe/go-internal/blob/master/cmd/testscript/README.md) on the following:

```
go generate fruit.com/fruit

-- go.mod --
module mod

require fruit.com v1.0.0

-- main.go --
package main

func main() {
}

-- .gomodproxy/fruit.com_v1.0.0/.mod --
module fruit.com

-- .gomodproxy/fruit.com_v1.0.0/.info --
{"Version":"v1.0.0","Time":"2018-10-22T18:45:39Z"}

-- .gomodproxy/fruit.com_v1.0.0/go.mod --
module fruit.com

-- .gomodproxy/fruit.com_v1.0.0/fruit/fruit.go --
package fruit

//go:generate bash -c "echo 'package fruit' > something.go"
```


### What did you expect to see?

A failed run.

### What did you see instead?

```
> go generate fruit.com/fruit
[stderr]
go: finding fruit.com v1.0.0
go: downloading fruit.com v1.0.0
go: extracting fruit.com v1.0.0
go: not generating in packages in dependency modules

PASS
```

It feels like this should be an error instead of a noisy success. Reason being, I've specified the pattern of a non-main module package(s) on the command line; based on the current implementation, that will never succeed (even if there is a `replace` directive).

cc @bcmills.
Repository: rust
Issue: Stack overflow on cloning static boxed value with a generic impl
Labels: C-enhancement,A-lints,T-compiler

Here's a sample program that uses a static HashMap of structs containing boxed values:

```rust
#[macro_use]
extern crate lazy_static;

use std::collections::HashMap;
use std::sync::Mutex;
use std::fmt::Display;

trait Value: Send + Display {
    fn box_clone(&self) -> Box<dyn Value>;
}

impl Value for isize {
    fn box_clone(&self) -> Box<dyn Value> {
        Box::new((*self).clone())
    }
}

impl Value for String {
    fn box_clone(&self) -> Box<dyn Value> {
        Box::new((*self).clone())
    }
}

#[derive(Clone)]
struct S {
    value: Box<dyn Value>
}

impl Clone for Box<dyn Value> {
    fn clone(&self) -> Box<dyn Value> {
        self.box_clone()
    }
}

lazy_static! {
    static ref Registry: Mutex<HashMap<String, S>> = {
        Mutex::new(HashMap::new())
    };
}

impl Registry {
    fn get(&self, key: &str) -> Option<S> {
        self.lock().unwrap().get(&String::from(key)).map(|s| s.clone())
    }

    fn set(&self, key: &str, value: S) -> Option<S> {
        self.lock().unwrap().insert(String::from(key), value)
    }
}

fn main() {
    Registry.set("foo", S { value: Box::new(String::from("hello world")) });
    Registry.set("bar", S { value: Box::new(123) });

    println!("{}", Registry.get("foo").unwrap().value);
    println!("{}", Registry.get("bar").unwrap().value);
}
```

It works as expected but when I replace redundant impl blocks with a generic one like this:

```rust
impl<T: 'static + Send + Clone + Display> Value for T {
    fn box_clone(&self) -> Box<dyn Value> {
        Box::new((*self).clone())
    }
}
```

it fails with stack overflow in runtime:

```
thread 'main' has overflowed its stack
fatal runtime error: stack overflow
[1]    48231 abort      cargo run
```

I'm new to Rust and not sure whether it's a bug. Maybe I just do something wrong. However I found the error strange because I don't explicitly do recursion or something else that potentially can lead to stack overflow here. Also it's weird that the compiler didn't find any problem because generics are compile-time concern.

By the way when I replace static variable with a local one it works fine even with the generic impl.

rustc 1.31.1 (b6c32da9b 2018-12-18), macOS 10.14.2
Repository: material-ui
Issue: [material-ui][docs] Create ADA compliance documentation
Labels: docs,accessibility

It would go a long way to help pitch Material UI as a solution if I could link to documentation covering the library's support for ADA compliance.

I know Material UI does have at least some support for ADA/WCAG compliance, for instance through the use of "aria-" and "role" html attributes throughout the codebase to assist screen readers and the support for keyboard navigation such as in the Select component.

Meanwhile, Material Design itself seems to lend itself nicely to following the WCAG guideline, for instance with regards to readability, navigation and high contrast text.

However, without being a core contributor myself, I cannot speak to the library's compliance overall. I searched the material-ui.com website as well as past/present GitHub tickets and could not find a page in the documentation whose sole purpose was to outline what it does and does not do to be ADA compliant. Therefore, I am opening this ticket as a feature request to please create said documentation.
Repository: TypeScript
Issue: Parameter hints do not get dismissed when the cursor moves
Labels: Suggestion,Awaiting More Feedback,Domain: Signature Help

Presently, it appears that the parameter hint window does not get dismissed if it is brought up when invoking a function within the argument list of another function and you move out of the inner function's argument list. The popup changes to reflect its new position, but this is not a generally useful thing and in something like a giant argument list like a call to `webpackMerge` this is incredibly irritating. Couple this with the fact that the Vim extension does not dismiss the param hints when you press escape and it's pretty rough.

It would be really nice if the parameter hints were dismissed when leaving the current argument list. I can see an argument for it remaining open while navigating around the current argument list, but if the cursor leaves that list and goes to an outer list, it should be dismissed.

Thanks!

<!-- Please search existing issues to avoid creating duplicates. --> 
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.27.0 - insiders and 1.26.0
- OS Version: macOS 10.13.6

Steps to Reproduce:

1. Open a new file
2. Change to javascript mode
3. Enter the text:

    ```js
    const path = require('path')

    Array.isArray([
      baz,
  
    ])
    ```
4. Place cursor on line after `baz`
5. Type `Array.apply(`. The parameter hint overlay should appear.
6. Press the up arrow.

Expected:
Parameter hint window is dismissed

Actual: 
Parameter hint window remains covering code


<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

![parameterhints](https://user-images.githubusercontent.com/8588/44206648-5d7f3800-a10f-11e8-82c6-6d499a3bff93.gif)
Repository: flutter
Issue: RenderViewportBase.getOffsetToReveal doesn't work on RenderSlivers when rect is provided
Labels: framework,f: scrolling,P2,team-framework,triaged-framework

This came up while working on https://github.com/flutter/flutter/pull/26598:

If the target parameter of [RenderViewportBase.getOffsetToReveal](https://master-docs.flutter.io/flutter/rendering/RenderViewportBase/getOffsetToReveal.html) is a RenderSliver, then the returned RevealedOffset may include an invalid `rect`.

Similarly, if target is a RenderSliver and a rect is provided to getOffsetToReveal, then the returned RevealedOffset may be completely invalid.
Repository: rust
Issue: Tracking issue for future-incompatbility lint `ambiguous_associated_items`
Labels: A-lints,A-associated-items,T-lang,T-compiler,C-future-incompatibility,C-tracking-issue

#### What is this lint about

With variants being resolved as inherent associated items (https://github.com/rust-lang/rfcs/pull/2338) code like this become ambiguous:
```rust
enum E {
    V
}

trait Tr {
    type V;
    fn f() -> Self::V;
}

impl Tr for E {
    type V = u8;
    fn f() -> Self::V { 0 } // `Self::V` in type namespace may refer to both variant and associated type
}
```

This is not a problem *right now*, because variants cannot be used in type positions, but it may become a problem in the future if https://github.com/rust-lang/rfcs/pull/2593 is accepted.
So this lints warns against cases like this and recommends to rewrite them as `<Self as Tr>::V`.

#### How to fix this warning/error

Explicitly disambiguate in favor of associated types from traits: `<Type as Trait>::Ambiguous`.

#### Current status
- [x] https://github.com/rust-lang/rust/pull/57501 introduces the `ambiguous_associated_items` lint as warn-by-default
- [x] https://github.com/rust-lang/rust/pull/59928 makes the `ambiguous_associated_items` lint deny-by-default
- [ ] PR ? makes the `ambiguous_associated_items` lint a hard error
Repository: kubernetes
Issue: Allow Mutating|ValidatingWebhookConfiguration to use secret for CABundle
Labels: priority/awaiting-more-evidence,sig/api-machinery,kind/feature,area/admission-control,lifecycle/frozen

**What would you like to be added**:
Allow Mutating|ValidatingWebhookConfiguration to reference content of a secret as CABundle.

The following shows the idea. We can use better names than below.
```
type WebhookClientConfig struct {
	URL *string `json:"url,omitempty" protobuf:"bytes,3,opt,name=url"`
	Service *ServiceReference `json:"service,omitempty" protobuf:"bytes,1,opt,name=service"`
	CABundle []byte `json:"caBundle,omitempty" protobuf:"bytes,2,opt,name=caBundle"`

	// Optional field that reference a secret.
	CAFromSecret *CASecret
}

type CASecret struct {
	// the namespace of the secret
	Namespace string
	// the name of the secret
	Name string
	// the key in the secret. e.g. ca.key
	KeyName string
}
```

This can also be applied to CRD conversion webhook

**Why is this needed**:
It will be very useful if the CA is rotated.
Before: An admin or a controller (with permission to update WebhookConfiguration) need to update CABundle field if the CA has changed.
After: The Webhook configuration will automatically pickup the new CA.

EDIT:
From the security PoV, another advantage is that no need to update the CA means we don't need to grant permissions to some controller for Updating the CABundle field in Mutating|ValidatingWebhookConfig. Current k8s authn doesn't support field-wise fine-grain access control. IOW, a compromised controller can modify the service field of MutatingWebhookConfig to point a random service that may inject an arbitrary container to each pod.
Repository: TypeScript
Issue: Suggestion: Sort autocomplete importable items by locality to current file
Labels: Suggestion,In Discussion

I have the "locality bonus" setting turned on. When VS Code suggests symbols in other TypeScript files (that aren't imported yet), I'd like them to be ordered so that symbols in files nearer to the current one are first.

This would be helpful because my project has many interfaces with the same name (`State`) that only apply in particular areas. Most of the time I just want to import the interface defined in the same directory as the current file.
Repository: rust
Issue: Add command-line option to `rustc` for setting default `recursion-limit`
Labels: T-compiler,C-feature-request,A-CLI

This'd be handy for using when many crates being compiled together need a higher recursion limit.