sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: runtime: timeouts in TestSUID
Labels: help wanted,NeedsInvestigation,compiler/runtime

```
#!watchflakes
post <- pkg == "runtime" && test == "TestSUID" && `panic: test timed out`
```

Issue created automatically to collect these failures.

Example ([log](https://build.golang.org/log/61aec6c193aa2b1efeac982137502b852bc389ce)):

    panic: test timed out after 3m0s
    running tests:
    	TestSUID (2m40s)
    
    runtime.gopark(0xc00006fad0?, 0x4740ee?, 0xa0?, 0x9b?, 0xc00006fb60?)
    	/tmp/workdir/go/src/runtime/proc.go:400 +0xce fp=0xc00006fa90 sp=0xc00006fa70 pc=0x43f82e
    runtime.chanrecv(0xc0009806c0, 0xc00006fb88, 0x1)
    	/tmp/workdir/go/src/runtime/chan.go:583 +0x3bf fp=0xc00006fb08 sp=0xc00006fa90 pc=0x4097df
    runtime.chanrecv1(0xc00080d520?, 0x409c40?)
    	/tmp/workdir/go/src/runtime/chan.go:442 +0x12 fp=0xc00006fb30 sp=0xc00006fb08 pc=0x4093f2
    os/exec.(*Cmd).awaitGoroutines(0xc000204840, 0x0)
    	/tmp/workdir/go/src/os/exec/exec.go:948 +0x1fa fp=0xc00006fc00 sp=0xc00006fb30 pc=0x53f4da
    os/exec.(*Cmd).Wait(0xc000204840)
    	/tmp/workdir/go/src/os/exec/exec.go:915 +0x16c fp=0xc00006fc60 sp=0xc00006fc00 pc=0x53f1ac
    os/exec.(*Cmd).Run(0xc000204840)
    	/tmp/workdir/go/src/os/exec/exec.go:607 +0x2d fp=0xc00006fc78 sp=0xc00006fc60 pc=0x53dced
    os/exec.(*Cmd).CombinedOutput(0xc000204840)
    	/tmp/workdir/go/src/os/exec/exec.go:1012 +0x85 fp=0xc00006fca0 sp=0xc00006fc78 pc=0x53f945
    runtime_test.privesc({0x85bf21, 0x5}, {0xc00006fde8?, 0x2, 0x2})
    	/tmp/workdir/go/src/runtime/security_test.go:35 +0x1cb fp=0xc00006fd78 sp=0xc00006fca0 pc=0x7792eb
    runtime_test.setSetuid(0xc0009a6000, {0x85c615, 0x6}, {0xc0004c81e0, 0x30})
    	/tmp/workdir/go/src/runtime/security_test.go:55 +0x1ac fp=0xc00006fe18 sp=0xc00006fd78 pc=0x77952c
    runtime_test.TestSUID(0xc0009a6000)
    	/tmp/workdir/go/src/runtime/security_test.go:95 +0x1b3 fp=0xc00006ff70 sp=0xc00006fe18 pc=0x779813
    testing.tRunner(0xc0009a6000, 0x888a98)


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: go
Issue: cmd/cgo/internal/test.test: build errors due to new C warnings on openbsd builders
Labels: OS-OpenBSD,NeedsInvestigation

```
#!watchflakes
post <- goos == "openbsd" && `warning: rand\(\) may return deterministic values`
```

Issue created automatically to collect these failures.

Example ([log](https://build.golang.org/log/5c18e6d045f3c451f9edac4176fa2db8528904a2)):

    test.go:251 (/_/GOROOT/src/cmd/cgo/internal/test/test.go:251)(/home/gopher/build/tmp/go-link-3434848293/000011.o:(testSendSIG)): warning: rand() may return deterministic values, is that what you want?
    test.go:633 (/_/GOROOT/src/cmd/cgo/internal/test/test.go:633)(/home/gopher/build/tmp/go-link-3434848293/000011.o:(issue12030conv)): warning: sprintf() is often misused, please use snprintf()


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: electron
Issue: [Bug]: Cmd + ` doesn't focus child window when focus is on the parent window
Labels: bug :beetle:,has-repro-gist,12-x-y,27-x-y

### Preflight Checklist

- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.

### Electron Version

27.0.2

### What operating system are you using?

macOS

### Operating System Version

macOS Ventura 13.2.1

### What arch are you using?

arm64 (including Apple Silicon)

### Last Known Working Electron version

_No response_

### Expected Behavior

I expect that I can use Cmd + ` to switch focus between an application's windows

### Actual Behavior

Focus switches from the child window to the parent, but not from the parent to the child

### Testcase Gist URL

https://gist.github.com/pushkin-/b8665db3836981799555e2de1ddad07c

### Additional Information

Can repro as far back as Electron 12. Haven't tried earlier.

1. click Open Window and move window a little out of the way
2. press Cmd+`, notice focus moves from child to parent
3. when focused on parent, press Cmd+`
4. Focus doesn't move
5. this is only an issue for child window. Otherwise, it works fine.
Repository: node
Issue: Proposal: generic key derivation function for crypto
Labels: crypto,feature request

### What is the problem this feature will solve?

The crypto library currently lacks a generic key derivation function similar to [OpenSSL's `EVP_KDF` methods](https://wiki.openssl.org/index.php/EVP_Key_Derivation) and resembling [WebCrypto's `deriveKey`](https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/deriveKey). This proposal aims to introduce a generic key derivation function to the crypto library, enabling developers to derive keys for various cryptographic purposes with simplicity.

The current situation, with separate functions for each supported KDF, can lead to [inconsistencies in the API](https://github.com/nodejs/node/issues/39471). Each KDF function might have its unique set of parameters and usage patterns, making it challenging for developers to work seamlessly with different key derivation methods.

### What is the feature you are proposing to solve the problem?

I propose the addition of a new function named `kdf` to the crypto library. This function will take the following parameters:

- `algorithm`: An object specifying the key derivation algorithm to use. This object should contain information about the algorithm's name, mode, parameters, and any other necessary details, allowing developers to choose from a variety of key derivation algorithms, including those available in OpenSSL 3.0. This object is akin to the first parameter of Web Crypto's `deriveKey`.
- `baseKey`: The base key from which the derived key will be generated (e.g. the password to be hashed). This base key can be of any type supported by the Crypto library, such as an ArrayBuffer, Buffer, or other relevant types.
- `salt`: A Buffer containing the salt to be used in the key derivation process, enhancing the security of the derived key.
- `callback`: An optional function to be run with the key after the derivation is complete. If undefined, run the job synchronously ([as suggested by](https://github.com/nodejs/node/pull/50353#issuecomment-1778705668) @panva).

### Example Usage

Here is an example of how the crypto.kdf function might be used in Node.js:

```js
const { kdf } = require('node:crypto');

const baseKey = 'hunter2';

const algorithm = {
  name: 'scrypt',
  cost: 32768,
};

/** 
 * Using PBKDF2 instead:
 *
 * const algorithm = {
 *   name: 'pbkdf2',
 *   iterations: 100000,
 *   digest: 'sha-512',
 * };
 */

try {
  const derivedKey = kdf(algorithm, baseKey, crypto.randomBytes(16));
  // derivedKey is a Buffer
} catch (err) {
  console.err('An error has occurred!', err);
}
```

### What alternatives have you considered?

It is possible to keep adding functions to the crypto library as new KDF algorithms are supported, but the more options there are, the more duplication there will be as apart from the parameters available, KDF functions are quite similar in interface and behavior: you pass a key and a salt and it returns a hash.
Repository: node
Issue: Discussion: Missing use cases with module customization hooks
Labels: module,esm,loaders

Re https://github.com/nodejs/node/issues/50356#issuecomment-1778690129, what are the use cases that we want to support that are not currently possible via the module customization hooks? The current hooks were designed to satisfy the cases here: https://github.com/nodejs/loaders/blob/main/doc/use-cases.md.

Put another way, if monkey-patching the CommonJS loader were no longer possible, what use cases that we want to support would be no longer possible?

@nodejs/loaders @nodejs/vm @nodejs/performance @nodejs/tsc
Repository: vscode
Issue: Terminal quick fix should go away when a command is run
Labels: bug,terminal-quick-fix

This looks wrong:

![Image](https://github.com/microsoft/vscode/assets/2193314/fb6ec4bf-68a8-4525-b9f6-fb8db578d19b)

Note that we still want to keep the behavior of the quick fix remaining when an empty command is run
Repository: godot
Issue: Godot v4.1.2.stable.official.399c9dc39 on Ubuntu 22.04 crashes when attempting to open a new project using the forward+ renderer
Labels: bug,needs testing,crash

### Godot version

4.1.2.stable.official.399c9dc39

### System information

OS: Ubuntu 22.04
CPU: AMD Phenom(tm) II X4 955 Processor
Graphics:
```
$ lspci -k | grep -EA2 'VGA|3D'
01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Oland GL [FirePro W2100]
	Subsystem: Hewlett-Packard Company Oland GL [FirePro W2100]
	Kernel driver in use: radeon
```

### Issue description

On a fresh install (in fact my first Godot install), I ran it from command line and then I created a new project following the "Your First 2D Game" tutorial instructions. Then I tried to open it, the Godot splashscreen appeared and then the application crashed. This occurs every time I ran the Godot executable without arguments.
[godot_crash_verbose_log.txt](https://github.com/godotengine/godot/files/13167799/godot_crash_verbose_log.txt)

Then I ran it with the following arguments:
`./Godot_v4.1.2-stable_linux.x86_64 --verbose --rendering-driver opengl3`
It showed the UI and seems to be working, but I haven't tried to do anything else until this point.


### Steps to reproduce

- Download Godot 4.1.2.stable.official.399c9dc39 for Ubuntu 22.04
- Run it from a terminal
- Create a project using the forward+ renderer
- Open the project

### Minimal reproduction project

N/A
Repository: pytorch
Issue: dynamo rewrite for allreduce, default group
Labels: oncall: distributed,module: dynamo

### 🚀 The feature, motivation and pitch

motivated by this post
https://discuss.pytorch.org/t/functional-collectives-used-in-torch-compile/190627

TLDR is we currently have dynamo support to rewrite certain forms of non-functional allgather/reducescatter into functional ones, to make the program traceable.

we should probably be able to support the same rewrite for allreduce and possibly also infer the 'default' processgroup in case it is omitted from the arguments to the c10d collective.

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng @voz

### Alternatives

_No response_

### Additional context

_No response_
Repository: pytorch
Issue: DDPWrapper
Labels: oncall: distributed

### 🚀 The feature, motivation and pitch

In my training I use both DDP and FSDP. I often need to access underlying methods and attributes of my underlying unwrapped model. It's a pain to add if statements all over my code to check if the model is wrapped in DDP and if so use model.module. 

My solution is below, but is there a better way of doing this? This also runs into some sharp edges and requires a few if/elses here and there. 

```
class DDPWrapper:
    """
    A simple wrapper so that the forward method of the model can be called directly on the DDP module
    whereas the attributes can be accessed directly on the model.

    This is something frameworks like Fabric do for us usually.
    """

    def __init__(self, ddp_module):
        self.ddp_module = ddp_module

    def __call__(self, *args, **kwargs):
        return self.ddp_module(*args, **kwargs)

    def __getattr__(self, name):
        if hasattr(self.ddp_module, name):
            attr = getattr(self.ddp_module, name)

            #  Make sure to return DDPWrapper instead of directly returning the attribute in case of a callable such as state.model.train()
            if callable(attr):

                def wrapper(*args, **kwargs):
                    result = attr(*args, **kwargs)
                    if result is self.ddp_module:
                        return self
                    return result

                return wrapper
            return attr

        if hasattr(self.ddp_module.module, name):
            return getattr(self.ddp_module.module, name)

        raise AttributeError(
            f"'{type(self).__name__}' object has no attribute '{name}'"
        )
```

### Alternatives

_No response_

### Additional context

_No response_

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu
Repository: flutter
Issue: Cleanup mac cert salt states
Labels: team-infra,P2,infra: device lab,triaged-infra

### Is there an existing issue for this?

- [X] I have searched the [existing infra issues](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Ateam-infra)

### Type of Request

infra task

### Infrastructure Environment

salt, devicelab

### What is happening?

see comments in https://dash-internal-review.git.corp.google.com/c/salt/+/1901 to clean up the verify state.

### Steps to reproduce

Step 1:
Step 2:
..
Step n:


### Expected results

I expect to see X when Y is finished.
Repository: godot
Issue: Reparenting a Node with a PinJoint2D and jointed couple as children creates an offset in the joint.
Labels: topic:physics,needs testing,topic:2d

### Godot version

4.1.1.stable (Also present in 4.1.2 and 4.2.beta3)

### System information

Godot v4.1.1.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 (NVIDIA; 31.0.15.3758) - AMD Ryzen 7 2700X Eight-Core Processor (16 Threads)

### Issue description

Issue/Unexpected behavior:
When a Node2D has a child Pinjoint2D and jointed Node A and Node B PhysicsBodies2D and their parent is reparented
a offset in the constraint between the jointed nodes occurs as if they are not jointed together at the same position.

Expected Behaviour:
No offset should occur between the jointed objects if their parent is reparented

### Steps to reproduce


https://github.com/godotengine/godot/assets/47177904/8e3523d8-e607-4621-82f0-2ffb8cd29e85

Node2D
-> PinJoint2D
-> CharacterBody2D                (Assign as Node A in the PinJoint)
->-> CollisionShape2D
-> RigidBody2D                       (Assign as Node B in the PinJoint)
->->CollisionShape2D


create a script which allows for you to reparent the Node2D to some other nodes during play, in my case I made a script which allows for me to drag around the node with the mouse and just reparented to nodes in an array

==================================

```gdscript
extends Node2D

@export var body : CharacterBody2D
@export var rgb : RigidBody2D
@export var array : Array[Node2D]
var dragging : bool = false
var next_index : int = 0

func _input(_event):
	if(Input.is_action_just_pressed("mouse_left")):
		dragging = true
	if(Input.is_action_just_released("mouse_left")):
		dragging = false
	
	if(Input.is_action_just_pressed("space")):
		reparent(array[next_index])
		next_index += 1

func _physics_process(_delta):
	if dragging:
		global_position = get_global_mouse_position()
```

==========================================



### Minimal reproduction project

[ReparentJointOffset.zip](https://github.com/godotengine/godot/files/13168487/ReparentJointOffset.zip)
Repository: kubernetes
Issue: Add unit tests for `pkg/registry/core/serviceaccount/storage/token.go`
Labels: sig/auth,triage/accepted

> Hm - this entire file does not have any unit tests for token generation logic it seems? I think currently this is all covered by the (quite extensive) integration tests.
> 
> Is this something we want to get done prior to this merging for alpha? Whilst I'd also love to get better coverage here, I am conscious of the code-freeze deadline and the time I have free before then 😅

_Originally posted by @munnerz in https://github.com/kubernetes/kubernetes/pull/120780#discussion_r1369868432_
            
/sig auth
Repository: vscode
Issue: List keys in SecretStorage (context.secret)
Labels: feature-request,secret-storage

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

in reference to;
Clear secrets when extension is uninstalled #123817

<!-- Describe the feature you'd like. -->

Need to be able to return all the keys in the secret store, so extensions can manage key lifecycle and clean up as needed.  Without this, bloat is inevitable.  This also brings the new secret store features a bit closer to the original keytar functionality

@TylerLeonhardt suggested a simple context.secret.keys() function to return all the keys available.  This function is sufficient for this need
Repository: flutter
Issue: Re-load assets when hot-restarting in a web browser
Labels: c: new feature,tool,t: hot reload,a: assets,platform-web,c: proposal,P2,team-web,triaged-web

### Is there an existing issue for this?

- [X] I have searched the [existing issues](https://github.com/flutter/flutter/issues)
- [X] I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)

### Use case

Hot-reload on the web doesn't reload assets.  It would be great if we could improve the development cycle, since it could make working with shaders easier for Flutter web apps. It's probably not as common to edit images but this would be great to support too.

### Steps to reproduce

1. Create a flutter app with an image or shader asset

```yaml
flutter:
  uses-material-design: true
  assets:
    - assets/images/image.jpg
  shaders:
    - assets/shaders/visualizer.frag
```
2. Use the image or shader in `main.dart`:

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(TestApp());
}

class TestApp extends StatelessWidget {
  const TestApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: Image.asset('assets/images/image.jpg'),
        ),
      ),
    );
  }
}
```

3. Run the app in a web browser
4. Replace the image or update the shader
5. Click hot restart in your IDE or press 'r' in the console
6. Observe the image or shader doesn't change.

### Proposal

Re-load assets when when hot-restarting in a web browser
Repository: angular
Issue: HttpClient post unclear encoding
Labels: area: common/http

### Describe the problem that you experienced

I can't find any documentation page explaining how the body parameter of HTTP post requests are encoded. Is it JSON? Multipart? Form-data?

### Enter the URL of the topic with the problem

_No response_

### Describe what you were looking for in the documentation

https://angular.io/api/common/http/HttpClient#post
https://angular.io/guide/understanding-communicating-with-http
"multipart", "form data"

### Describe the actions that led you to experience the problem

I'm trying to implement a back-end for an existing Angular front-end.

### Describe what you want to experience that would fix the problem

A simple mention in `HttpClient` that explains how the `body: any` parameter is going to be sent over the wire.

### Add a screenshot if that helps illustrate the problem

_No response_

### If this problem caused an exception or error, please paste it here

_No response_

### If the problem is browser-specific, please specify the device, OS, browser, and version

_No response_

### Provide any additional information here in as much as detail as you can

_No response_
Repository: go
Issue: doc/godebug: allow carve out for GODEBUGs introduced in security releases
Labels: Security,Proposal,Proposal-Accepted

For backwards compatibility, the [GODEBUG policy](https://go.dev/doc/godebug) states thats when compiling a module which declares a version of Go older than a specific GODEBUG flag, that flag will have its default set such that the new behavior is disabled (i.e. `panicnil` was introduced in 1.21 and defaults to `0`, and setting it to `1` restores the pre-1.21 behavior. In a module which declares `go 1.20`, `panicnil` will be set to `1` by default).

The Security team sometimes needs to fix dangerous behavior which nonetheless some users may rely on, either because the specific dangerous behavior does not apply to them, or because they are able to safely work around the specific behavior in a way we cannot reasonably impose on all users. In these cases we'd like to introduce a new GODEBUG so that we do not break these particular use cases. The current GODEBUG behavior is not conducive to this, as, since we consider the particular behavior inherently dangerous, we never want the flagged behavior to be enabled by default (regardless of the declared Go version in a module).

I propose we allow a specific carve out from the policy for GODEBUG flags introduced specifically in [PRIVATE](https://go.dev/security/policy#private) track security fixes. In these cases the flags would act as if they were introduced in Go 1 (or 1.20, when this new policy was introduced), such that their default is never flipped to enable the old behavior by default. This allows us to require users make an explicit decision to re-enable the dangerous behavior. We expect that the introduction of this class of GODEBUG flags will be extremely rare.

This requires no code changes, and would only require a change in the documented policy.

cc @rsc @golang/security
Repository: pytorch
Issue: AssertionError: graph-captured input #1, of type <class 'torch.Tensor'>, is not among original inputs of types…
Labels: high priority,triaged,export-triage-review,oncall: export

I know we have iterated a bunch on this error message, but still: putting on my user hat, I find this to be really inscrutable.

1. What is a "graph-captured input"? What causes an input to be "graph-captured"?
2. Which input is input 1? What determines the ordering of the inputs?
3. What would cause the graph-captured inputs to be different from the the original inputs?
4. etc.

It's definitely really challenging to come up with a good explanation for wtf is happening here since it's so dependent on implementation details. Ideally we can make it so that this error just…never happens somehow.

cc @ezyang @gchanan @zou3519 @kadeng @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi who I know has been thinking about this recently.
Repository: flutter
Issue: Ensure chromium bots that were upgraded to macOS 13 have `safaridriver` enabled
Labels: team-infra,P2,triaged-infra

### Is there an existing issue for this?

- [X] I have searched the [existing infra issues](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Ateam-infra)

### Type of Request

bug

### Infrastructure Environment

LUCI

### What is happening?

Sometimes [web tests fail on macOS 13](https://github.com/flutter/flutter/issues/136972) and the web team suspect it may be because `safaridriver` needs to be enabled system wide.

I don't think there's a way to check if it's enabled via the command line. It can be check by opening Safari > Develop > Developer Settings and checking if "Allow remote automation" is checked. If the team doesn't have capability to check, than perhaps we can just enable it.

It can be enabled via the command line:
https://developer.apple.com/documentation/webkit/testing_with_webdriver_in_safari?language=objc

macOS 13 bots:
https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=os%3AMac-13&f=device_type%3Anone&k=device_type&s=id

### Steps to reproduce

_No response_

### Expected results

_No response_