sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: transformers
Issue: tokenizer decode decode with timestamp fails for extended vocabulary
Labels: bug

### System Info

python=3.10.13
transformers==4.44.1
torch==2.1.2

### Who can help?

@sanchit-gandhi @ylacombe @eustlb @arthurz

### Information

- [X] The official example scripts
- [ ] My own modified scripts

### Tasks

- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [X] My own task or dataset (give details below)

### Reproduction

Decoding with timestamps produces unexpected results when the vocabulary is extended

```
>>> from transformers import WhisperTokenizer, AddedToken
>>> tokenizer = WhisperTokenizer.from_pretrained('openai/whisper-base', language="English", task="transcribe", predict_timestamps=True)
>>> extended_vocab = ['newword1']
>>> extended_vocab = [AddedToken(t, single_word=True, lstrip=True) for t in extended_vocab]
>>> tokenizer.add_tokens(extended_vocab)
1
>>> print(len(tokenizer))
51866
>>> print(tokenizer.convert_ids_to_tokens(51865))
newword1
>>> tokens = tokenizer('<|0.00|> newword1 <|0.22|>').input_ids
>>> tokens
[50258, 50259, 50359, 50364, 51865, 220, 50375, 50257]
>>> tokenizer.decode(tokens, skip_special_tokens=True)
'newword1 '
>>> tokenizer.decode(tokens, skip_special_tokens=False)
'


newword1 
'
>>> tokenizer.decode(tokens, skip_special_tokens=False, decode_with_timestamps=True)
'


<|0.00|><|30.02|> <|30.24|>
'
>>> tokens = tokenizer('<|0.00|> word <|0.22|>').input_ids # something in the vocabulary
>>> tokenizer.decode(tokens, skip_special_tokens=True)
' word '
>>> tokenizer.decode(tokens, skip_special_tokens=False)
'


 word 
'
>>> tokenizer.decode(tokens, skip_special_tokens=False, decode_with_timestamps=True)
'


<|0.00|> word <|0.22|>
'
```

The problem arises in [https://github.com/huggingface/transformers/blob/9613933b022ddbf085e2c593ed4ceea4c734179a/src/transformers/models/whisper/tokenization_whisper.py#L546]( https://github.com/huggingface/transformers/blob/9613933b022ddbf085e2c593ed4ceea4c734179a/src/transformers/models/whisper/tokenization_whisper.py#L546)

see issue [20225](https://github.com/huggingface/transformers/issues/20225)


### Expected behavior

I would expect the timestamps to remain consistent from tokenizing and decoding.

```
>>> tokens = tokenizer('<|0.00|> newword1 <|0.22|>').input_ids
>>> tokenizer.decode(tokens, skip_special_tokens=False, decode_with_timestamps=True)
'


<|0.00|> newword1<|0.22|>
'
```
Repository: kubernetes
Issue: [Compatibility Version] kube version validation should be moved out of component base
Labels: sig/api-machinery,triage/accepted

xref: https://github.com/kubernetes/kubernetes/pull/128279/files#r1890633759

> is k8s.io/component-base supposed to be agnostic for in-tree or out-of-tree components? trying to make sure the n-3 / 1.31 floor we set here is enforced for ValidateKubeEffectiveVersion but wouldn't break a different component with a different versioning scheme from using this package

ref: https://github.com/kubernetes/kubernetes/pull/128279#discussion_r1890662857

> Can we open an issue to move this logic out of component-base as well? I would expect k8s components (kube-apiserver, ...) to set the limit according to the rules of that component (N-3 for k8s components), but leave it up to 3rd party component owners to decide what the limit should be for their components.
Repository: vscode
Issue: Git - Add "Cherry Pick with No Commit" option to Source Control Graph
Labels: feature-request,git

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
### Description:  
The "Source Control Graph" in Visual Studio Code is an excellent tool for visualizing and managing Git repositories. However, it currently offers only the "Cherry Pick" option, which automatically creates a commit after applying the changes from the selected commit.  

I propose adding a "Cherry Pick with No Commit" option to the Source Control Graph. This feature would allow users to cherry-pick a specific commit without automatically committing the changes. Instead, the changes would be applied to the working directory and staged in the index, giving users the opportunity to:  
- Review the changes  
- Modify them as needed  
- Combine them with other updates before creating a commit  

This addition would significantly improve the flexibility of the cherry-pick operation, making it more useful for workflows that require careful adjustment of changes, such as:  
- Resolving conflicts manually  
- Integrating partial changes  
- Customizing commits from cherry-picked content  

#### Current Limitation:  
As of now, the Source Control Graph only supports a standard "Cherry Pick" operation that automatically creates a new commit. Adding this new option would align VSCode's Git functionality more closely with Git's native capabilities and provide users with greater control over their version control workflows.  

#### Benefits:
- **Greater Flexibility:** Allows users to manage cherry-picked changes before committing.  
- **Improved Workflow Control:** Offers better handling of conflicts and manual adjustments.  
- **Enhanced Usability:** Supports complex Git workflows commonly used in professional development environments.  

This feature would be a valuable enhancement for developers using Visual Studio Code as their primary Git interface.
Repository: flutter
Issue: Use of `flutter update-packages` makes code reviews/merges painful
Labels: team-infra,c: tech-debt

As an example, see https://github.com/flutter/flutter/pull/160354/files.

There are 92 files changed because a new package was added, and to use uniform package versions, `flutter update-packages` was used, which in turn requires updating the entire repository. We should either stop using pinned packages (and move towards workspaces), or further improve our tooling to minimize cascading effects of doing things like adding a single package.
Repository: tauri
Issue: [bug] Invalid scale on linux
Labels: type: bug,status: upstream,platform: Nix/NixOS

### Describe the bug

When i run my application everything is tiny and when i open the devtools my <body> tag has a size of -150000 px by -40000 px which makes it unstably tiny

### Reproduction

1. Create a new project with `bun create tauri-app`
2. Run it on linux on wayland(i haven't tested on xorg)
3. open devtools and see the wrong scale

### Expected behavior

the <body> tag and it's children having appropriate sizes that are not negative and more than 20 times bigger than my actual resolution

### Full `tauri info` output

```text
$ tauri info

[✔] Environment
    - OS: NixOS 25.5.0 x86_64 (X64)
    ✔ webkit2gtk-4.1: 2.46.4
    ✔ rsvg2: 2.58.3
    ✔ rustc: 1.83.0 (90b35a623 2024-11-26)
    ✔ cargo: 1.83.0 (5ffbef321 2024-10-29)
    ✔ rustup: 1.27.1 (1980-01-01)
    ✔ Rust toolchain: stable-x86_64-unknown-linux-gnu (default)
    - node: 20.18.1
    - npm: 10.8.2
    - bun: 1.1.38

[-] Packages
    - tauri 🦀: 2.1.1
    - tauri-build 🦀: 2.0.3
    - wry 🦀: 0.47.2
    - tao 🦀: 0.30.8
    - @tauri-apps/api : 2.1.1
    - @tauri-apps/cli : 2.1.0

[-] Plugins

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../build
    - devUrl: http://localhost:1420/
    - framework: Svelte
    - bundler: Vite
```


### Stack trace

_No response_

### Additional context

I tried using a webkitgtk-based browser(midori) and it didn't have this issue.
Repository: go
Issue: x/build:  improve the container deployment process
Labels: Builders,NeedsFix

I propose changing how services are deployed from the x/build repository. I would like to continue/finalize the migration from building and deploying containers on local machines to doing most of the work on Cloud Build. I propose we:

Current State: Services are built and deployed as containers primarily on local machines.

Create a trigger in Cloud Build for each service, The trigger will take a x/build repo commit hash as input and:
- Checkout the commit from go.googlesource.com.
- Check if a container for the requested commit already exists.
- If a container image for the requested commit does not exist, it will build and push the container image.
- Once the container image exists, it will deploy the service using the container image.

When a service is being deployed, the user can initiate a deployment by running a make target which:
- If the service being deployed is from a published commit (the commit ID is available on the remote Gerrit server) and the local work tree has no uncommitted or staged changes, it will initiate a cloud build trigger with a commit hash (see previously mentioned trigger).
- If the service being deployed contains uncommitted work or staged changes (a dirty commit):
  - A locally defined cloud build job will be initiated (much like many of the services are currently deployed now)
  - It will upload the local cloud build definition and checked out repository.
  -  Cloud build will create the image and publish it. 
  - The XB command will be called to deploy the newly created container.

Additional changes:
- There should be a mechanism for redeploying an existing deployment. Possible solutions include:
  - Each Kubernetes manifest should contain a `GO_IMAGE_DEPLOYMENT_TIMESTAMP` environmental variable that is updated with a timestamp of the requested deployment time. This should ensure that the deployment manifests will always be unique.
  - Deleting the pods for the deployment and waiting for the Kubernetes reconciliation loop to recreate them again.
- The canonical source for cloud build definitions will be stored in the x/build repository. There should be make targets added which will set the locally defined cloud build definitions to the existing cloud build triggers. This models work initiated  by @dmitshur. How and where the the various elements are stored is completely open to discussion. We should use this issue to resolve those questions.
- The deployment make files should share as much logic as possible since most of these jobs will use the same logic.

Possible Benefits:
- A more centralized build and deployment process.
- Reduced reliance on local machines. Which is great for security and reducing errors due to bespoke local machine configurations.

@golang/release
Repository: flutter
Issue: Attempt to execute code removed by Dart AOT compiler (TFA) (crash after updating to 3.27.1 from 3.24.5)
Labels: c: regression,c: crash,tool,dependency: dart,P1,team-tool,triaged-tool,dependency:dart-triaged

### Steps to reproduce

I get this error when launching iOS application with 3.27.1 (on 3.24.5 it works fine)

The stacktrace points to PopupMenuButton but that is not even being used anywhere in the app.

### Expected results

The app should behave exactly like how it works when build with 3.24.5

### Actual results

The app shows blank screen with the above error showing in the console


### Flutter Doctor output

<details open><summary>Doctor output</summary>

```console
[✓] Flutter (Channel stable, 3.27.1, on macOS 15.2 darwin-arm64, locale en-US)
    • Flutter version 3.27.1 on channel stable at x
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 17025dd882 (23 hours ago)
    • Engine revision cb4b5fff73
    • Dart version 3.6.0
    • DevTools version 2.40.2
```

</details>
Repository: go
Issue: proposal: x/net/http3: add HTTP/3 implementation
Labels: Proposal

This is a proposal to add an HTTP/3 client and server implementation in x/net/http3.

Similarly to the accepted form of #58547 (x/net/quic), this proposal is to add an experimental package with an API subject to change during development. Once we have a complete implementation, we will file a separate proposal for API review.

Initial development will be in an internal package (x/net/internal/http3) until the details are firm enough for external testing. We will then move the package to x/net/http3 and (when we have some confidence the API is right) file the API review proposal.
Repository: ui
Issue: [bug]: Sidebar useIsMobile doesn't change when slowly
Labels: bug

### Describe the bug

When I expand the window slowly, the `isMobile` doesn't change to `false`.

Add `console.log(window.innerWidth, e.matches)` get `767 false`, but `MOBILE_BREAKPOINT` is `768`, so setIsMobile is `true`.

Use `event.matches` or `mql.matches` or ~`<=`~?

I find a questions: [html - Media query max-width not working inclusively - Stack Overflow](https://stackoverflow.com/questions/56842906/media-query-max-width-not-working-inclusively). You can see: https://jsfiddle.net/e0hdyqc9/, the `767` is white.

Maybe with `max-width` when the number is even, media match includes the number; when the number is odd, media match doesn't include the number.

### Affected component/components

Sidebar

### How to reproduce

1. Contract the window
2. Slowly enlarge the window
3. isMobile doesn't change

### Codesandbox/StackBlitz link

_No response_

### Logs

_No response_

### System Info

```bash
Windows11, Edge
```


### Before submitting

- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues
Repository: godot
Issue: `sample_baked_with_rotation` in Curve3D gives wrong rotation near first and last points
Labels: bug,topic:3d

### Tested versions

#### Reproducible in
 - 4.4.dev.custom_build.fafc07335
 - 4.3.stable.official.77dcf97d8
 - 4.2.2.stable.official.15073afe3
 
### System information

Godot v4.3.stable - Ubuntu 22.04.5 LTS 22.04 - X11 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3080 (nvidia; 550.120) - Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz (6 Threads)

### Issue description

Curve3D's `sample_baked_with_rotation` returns strange rotation values near the first point and the last point of a curve. 

### Steps to reproduce

1. Construct a Curve3D with at least 3 points.
2. Give the middle point a non-zero in and out vector. 
3. Sample the curve with rotation using `sample_baked_with_rotation` at regular intervals to see that the rotation value veers off in a weird direction as the first and the final points are approached. 

### Minimal reproduction project (MRP)

[mrp_curve3d-edge-rotation.zip](https://github.com/user-attachments/files/18191202/mrp_curve3d-edge-rotation.zip)

The attached MRP is a 3D scene with a Camera3D, a Path3D, and a MeshInstance3D. The Path3D has a script attached to it that draws basis provided by `sample_baked_with_rotation` along the entire length of the Path3D. This is not a tool script, so the project must be ran to see the basis drawn. The Path3D script has some exported parameters to help the user investigate this issue: `count` is the number of samples of the curve taken and drawn in the 3D viewport as basis gizmos, `size` is the length of the vector that represents a basis in a gizmo, and `cubic` changes whether `sample_baked_with_rotation` is called with `cubic = true` or `cubic = false` (the issue behavior does not appear to change based on this). 

#### Examples from MRP
The following is the 3D scene with only 50 samples taken so the basis gizmo can be more easily seen.
![Image](https://github.com/user-attachments/assets/61ca3b94-8949-4e7d-8282-5bc5321613e6)

As the number of samples increases so does the number of problematic rotation samples near the first and last points.
![Image](https://github.com/user-attachments/assets/5e2eeaca-8ddb-4dde-8d15-280ca57b2a3e)

When the middle point has zero in and out vectors, there are only straight lines and this issue does not occur. 
![Image](https://github.com/user-attachments/assets/86cf04c5-18f4-4547-a254-d90d867949f7)
Repository: flutter
Issue: `AnimationStyle` API improvements
Labels: c: new feature,framework,a: animation,c: proposal,P3,team-framework,triaged-framework

- It'd be nice to have `AnimationStyle.merge` (similar to [**TextStyle.merge**](https://main-api.flutter.dev/flutter/painting/TextStyle/merge.html))
- It'd also be nice if the `.lerp()` method was more than just a binary switch, since maybe someone would want to animate the animation style!
- Since it's an immutable configuration class, a `const` constructor would be nice to have as well.
Repository: godot
Issue: LightmapGI: Custom Sky environment does not contribute to ambient light
Labels: bug,topic:rendering,topic:3d

### Tested versions

Reproducible in the Godot v4.4.dev (7f5c46929) build (built from the AUR and currently only a few commits behind)

### System information

Godot v4.4.dev (7f5c46929) - Manjaro Linux #1 SMP PREEMPT_DYNAMIC Mon, 09 Dec 2024 11:58:37 +0000 on Wayland - X11 display driver, Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (nvidia; 565.77) - AMD Ryzen 9 9900X 12-Core Processor (24 threads)

### Issue description

Currently setting the environment mode of the lightmapGI node to custom sky results in completely black bakes (assuming there are no other lights contributing bounces)

This doesn't happen when using the scene sky.

Here's a scene with the lightmapGI node set to use the scene sky:
![Image](https://github.com/user-attachments/assets/ce9c768f-4b38-47c5-a42b-5d15cc94819f)

And here is the same scene when setting the lightmapGI node to use a custom sky (which is identical to the scene sky here so it's even more clear)
![Image](https://github.com/user-attachments/assets/eddeb5e1-7e58-4cc7-992d-49422507b0eb)


### Steps to reproduce

Create an object with UV2, and LightmapGI node. 
Set the environment mode to "Custom Sky" (it doesn't matter what kind of sky material you use here, they're all broken)
Bake lighting
Notice the object is dark and not illuminated by the sky at all. (Which is clear if you change the sky energy to a stupidly high number and the object still doesn't change in brightness.)

### Minimal reproduction project (MRP)
[ambient-light-baking-issue.zip](https://github.com/user-attachments/files/18202507/ambient-light-baking-issue.zip)

This is the same scene as above but with the custom sky already set.
Repository: transformers
Issue: AllAboardBertweetModel
Labels: New model

### Model description

AllAboardBertweetModel used for AllaboardSystem

### Open source status

- [X] The model implementation is available
- [X] The model weights are available

### Provide useful links for the implementation

_No response_
Repository: angular
Issue: Add more ergonomic api to declare server-side services
Labels: area: server

### Which @angular/* package(s) are relevant/related to the feature request?

core, platform-server

### Description

This is regarding the recommended way to declare server only services:
https://github.com/angular/angular/issues/53168#issuecomment-1827805974

At the moment it feels like a lot of boilerplate to create separate services for server and browser contexts. It feels like a step back, adding every single service that has different logic on ssr to the app configuration. Especially if it's a simple noop on the server. 

It would be great if it was possible to define on which platform a service will be injected during the service definition.

### Proposed solution

Without knowing the inner workings of the compiler and being a bit naive, something along these lines would be great:
```ts
@Injectable({
    providedIn: 'root',
})
export class DataServiceService {
  get(id: string): string {
   return 'browser-data';
  }
}

@ServerInjectable({
    overrides: DataServiceService
})
export class DataServiceServiceServer extends DataServiceService {
   get(id: string): string {
    return 'server-data-performed-with-secret-tokens';
   }
}
```

By default, services would be the same for browser and server. Only specific services would be overridden to have different behaviour on the server. This would eliminate the need to then add the services separately to the two app configurations.

### Alternatives considered

Keep it as is
Repository: react-native
Issue: property is not configurable This error is located at: in VirtualizedList (created by FlatList)
Labels: Component: VirtualizedList,Component: FlatList,Needs: Triage :mag:,Newer Patch Available

### Description

I am using React Native 0.76, and whenever I try to use a FlatList, the same TypeError: property is not configurable issue arises. This time, I encountered the same error while using the GooglePlacesAutocomplete component, which internally uses FlatList or VirtualizedList to render suggestions.

### Steps to reproduce

**start React native project version v0.76**
**try to use Flastlist anywhere**


### React Native Version

 0.76.2

### Affected Platforms

Runtime - Android, Runtime - iOS

### Output of `npx react-native info`

```text
PS C:\Users\sofim\Desktop\Spark> npx react-native info
info Fetching system and libraries information...
System:
  OS: Windows 11 10.0.26100
  CPU: (8) x64 11th Gen Intel(R) Core(TM) i5-11300H @ 3.10GHz
  Memory: 9.57 GB / 15.79 GB
Binaries:
  Node:
    version: 18.18.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn: Not Found
  npm:
    version: 9.8.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK: Not Found
IDEs:
  Android Studio: AI-241.18034.62.2412.12266719
  Visual Studio: Not Found
Languages:
  Java: 17.0.10
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli":
    installed: 15.0.1
    wanted: 15.0.1
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.76.2
    wanted: 0.76.2
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

info React Native v0.76.5 is now available (your project is running on v0.76.2).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.76.5
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.76.2&to=0.76.5
info For more info, check out "https://reactnative.dev/docs/upgrading?os=windows".
```


### Stacktrace or Logs

```text
property is not configurable This error is located at: in VirtualizedList (created by FlatList)
```


### Reproducer

https://github.com/manzoorsofi/Spark-App-Yashooda

### Screenshots and Videos

![Screenshot 2024-12-18 145159](https://github.com/user-attachments/assets/fc332b51-19d4-41f2-84ac-5db83052d71d)
Repository: PowerToys
Issue: Launch and Edit option in Workspaces clears all configured the CLI arguments
Labels: Issue-Bug,Resolution-Fix Committed,Product-Workspaces

### Microsoft PowerToys version

0.87.0

### Installation method

Microsoft Store

### Running as admin

None

### Area(s) with issue?

Workspaces

### Steps to reproduce

### Problem Description
Currently when using `Launch & Edit` option in Workspaces, it resets all previously configured CLI arguments.

I hope Everyone set's up workspaces not to just simply open apps, but to open a specific folder or file or URL. Right now that can only be configured by giving CLI arguments. If i wanna add a new app or resize the tabs, it can be only done by clicking `Launch & Edit` option, which btw resets the entire CLI configurations.

It would be much useful if CLI args don't reset!

### Steps to Reproduce
1. Make a new workspace & configure CLI arguments for a few apps.
2. Use the "Launch & Edit" option.
3. It prompts you to capture the screen.
4. Observe that the CLI arguments are no longer preserved.


### ✔️ Expected Behavior

CLI arguments should persist after capturing the "Launch & Edit" screen.

### ❌ Actual Behavior

CLI arguments are cleared upon capturing the "Launch & Edit" screen.

### Other Software

_No response_