sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: x/tools/cmd/present: doesn't work with go in git master (1.16)
Labels: NeedsInvestigation,Tools

<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->

### What version of Go are you using (`go version`)?
go 1.16
<pre>
$ go version
go version devel +95ce805d14 Thu Dec 31 02:24:55 2020 +0000 linux/amd64
</pre>

### Does this issue reproduce with the latest release?

Yes

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
go version devel +95ce805d14 Thu Dec 31 02:24:55 2020 +0000 linux/amd64
ayan@alia:/tmp/y$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/ayan/.cache/go-build"
GOENV="/home/ayan/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/ayan/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/ayan"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/ayan/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/ayan/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel +95ce805d14 Thu Dec 31 02:24:55 2020 +0000"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/tmp/y/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2261444876=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### What did you do?
I installed the present tool using  go get:

<pre>
$ go get golang.org/x/tools/cmd/present
go: downloading golang.org/x/tools v0.0.0-20201230224404-63754364767c
go: downloading golang.org/x/net v0.0.0-20201021035429-f5854403a974
go: downloading github.com/yuin/goldmark v1.2.1
</pre>

That error occurs because go didn't place the source for the present tool in my $GOPATH.
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->



### What did you expect to see?

<pre>
$ present
2021/01/01 14:19:58 Open your web browser and visit http://127.0.0.1:3999
</pre>

### What did you see instead?

<pre>
$  present
Couldn't find gopresent files: no required module provides package golang.org/x/tools/cmd/present: working directory is not part of a module

By default, gopresent locates the slide template files and associated
static content by looking for a "golang.org/x/tools/cmd/present" package
in your Go workspaces (GOPATH).

You may use the -base flag to specify an alternate location.
</pre>

I believe the right thing to do is to embed the static assets and templates in the present tool.  I submitted a PR that appears to work at:

https://github.com/golang/tools/pull/264
Repository: godot
Issue: GDScript clearing function state deletes local variables
Labels: bug,topic:gdscript

**Godot version:**
Godot_v3.2.3-stable_x11.64 


**OS/device including version:**
Kubuntu 20.10 laptop with NVidia graphics (issue is not graphics related.)
<!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. -->


**Issue description:**
Clearing a variable that contains a function state currently executing clears the local variable within the executed function as well.


**Steps to reproduce:**
* Assign function state to Node's variable.
* In the coroutine have some local variables.
* Resume function state.
* From within the resumed function state, set Node's variable to null

Expected: Function state is referenced by the execution and therefore its local variables are not deleted.
Actual behavior: local variables within function state are cleared when null is assigned.


**Minimal reproduction project:**
[testGDScriptExecution.zip](https://github.com/godotengine/godot/files/5759393/testGDScriptExecution.zip)
Repository: puppeteer
Issue: Secure DNS
Labels: feature,confirmed

I'd like to configure Puppeteer to use [Secure DNS](https://blog.chromium.org/2020/05/a-safer-and-more-private-browsing-DoH.html), rather than the operating system's DNS resolver. I cannot find a way to do this. I tried searching [the docs](https://pptr.dev/), using [special command line arguments](https://www.zdnet.com/article/how-to-enable-dns-over-https-doh-in-google-chrome/), and [asking on Stack Overflow](https://stackoverflow.com/questions/65498677/secure-dns-using-puppeteer) - so I've come to the conclusion that this might be a feature request. Thoughts?

Apologies in advance if I've missed something obvious!
Repository: godot
Issue: ViewportTexture.get_data() race condition
Labels: bug,topic:core

**Godot version: 3.2.3 mono**
(Mono is not actually used)


**OS/device including version: Pop! OS 20.04 x64**
GPU: GTX 1080 Mobile
Driver: Nvidia 455
Backend: GLES3

**Issue description:**
When trying to read from a `Viewport` by using its associated `ViewportTexture`, sometimes black image is retrieved.


**Steps to reproduce:**
I could not reproduce it with a small example. 
This happens in a substantial project where I have multiple small viewports in the same world, each with one camera.
Viewport textures are displayed in `TexturedRect` of UI, and texture data are read in scripts for process.
Often times black image is returned.
Forcing update by repeatedly setting `Viewport.UPDATE_ONCE` reduces the number of black images, so I suspect this is a race condition.

A refactor later somehow made the issue disappear, and an attempt to reproduce with small project does not have this issue.
Repository: rust
Issue: Using associated constant incorrectly errors out with incorrect message about generic types
Labels: A-diagnostics,A-associated-items,T-compiler,C-bug

The following code runs afoul of the check for nested functions with definitions contingent on the value of a generic parameter (or generic associated type) from the parent scope, even though the value in question is a) not in a generic struct, b) not in a trait, c) not in an outer function, and d) guaranteed to be the exclusive value ever used in the substitution (as it is a compile-time constant):

```rust
#![crate_type = "rlib"]

struct Foo;
impl Foo {
    const COMPILE_TIME_LEN: usize = 42;

    fn foo() -> u8 {
        type TYPE = [u8; Self::COMPILE_TIME_LEN];
        let foo: TYPE = [0; Self::COMPILE_TIME_LEN];

        foo[0]
    }
}
```

[playground link](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&code=%23!%5Bcrate_type%20%3D%20%22rlib%22%5D%0D%0A%0D%0Astruct%20Foo%3B%0D%0Aimpl%20Foo%20%7B%0D%0A%20%20%20%20const%20COMPILE_TIME_LEN%3A%20usize%20%3D%2042%3B%0D%0A%0D%0A%20%20%20%20fn%20foo()%20-%3E%20u8%20%7B%0D%0A%20%20%20%20%20%20%20%20type%20TYPE%20%3D%20%5Bu8%3B%20Self%3A%3ACOMPILE_TIME_LEN%5D%3B%0D%0A%20%20%20%20%20%20%20%20let%20foo%3A%20TYPE%20%3D%20%5B0%3B%20Self%3A%3ACOMPILE_TIME_LEN%5D%3B%0D%0A%0D%0A%20%20%20%20%20%20%20%20foo%5B0%5D%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A)

Error currently reported with rustc rustc 1.51.0-nightly (2987785df 2020-12-28):

```
error[E0401]: can't use generic parameters from outer function
 --> ./ex3.rs:8:26
  |
4 | impl Foo {
  | ---- `Self` type implicitly declared here, by this `impl`
...
8 |         type TYPE = [u8; Self::COMPILE_TIME_LEN];
  |                          ^^^^^^^^^^^^^^^^^^^^^^
  |                          |
  |                          use of generic parameter from outer function
  |                          use a type here instead

error: aborting due to previous error

For more information about this error, try `rustc --explain E0401`.
```
Repository: rust
Issue: Doc alias not allowed on associated constants and types in trait implementation block
Labels: T-rustdoc,A-trait-system,A-associated-items,C-feature-request,A-doc-alias

<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->

I tried this code:

```rust
pub trait Trait {
    const VALUE: u32;
}

pub struct Struct;

impl Trait for Struct {
    #[doc(alias = "kValue")]
    const VALUE: u32 = 42;
}
```

Similarly, I tried:

```rust
trait Trait {
    type Value;
}

struct Struct;

impl Trait for Struct {
    #[doc(alias = "ValueType")]
    type Value = u32;
}
```

I expected to see this happen: the code to compile and searching `kValue` or `ValueType` in the docs to produce `Struct::VALUE` or `Struct::Value` respectively.

Instead, this happened: These failed to compile with the following errors:

> error: `#[doc(alias = "...")]` isn't allowed on associated constant in trait implementation block

> error: `#[doc(alias = "...")]` isn't allowed on type alias in implementation block

This is very surprising because:

- `#[doc(alias)]` works on `fn` trait members in impl blocks.
- Doc comments are allowed on associated constants and types in impl blocks.

### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->

`rustc --version --verbose`:
```
rustc 1.49.0 (e1884a8e3 2020-12-29)
binary: rustc
commit-hash: e1884a8e3c3e813aada8254edfa120e85bf5ffca
commit-date: 2020-12-29
host: x86_64-apple-darwin
release: 1.49.0
```
Repository: node
Issue: pipeline function verify arguments process clarification
Labels: stream

I am working through [#36674](https://github.com/nodejs/node/issues/36674) and feeling like I need to clarify one thing:
is that ok, that with current `pipeline` function implementation, if invalid argument is encountered during pipe chain build process, all streams that were piped before encounting invalid argument won't be unpiped? maybe `pipeline` function arguments should be verified before pipe chain building? I don't think that going through arguments before building pipeline would harm performance significantly. @ronag
Repository: rust
Issue: `global_asm!` macro causes non-fatal errors to be printed during compilation for some RISC-V extension instructions when targeting the GC extensions
Labels: A-LLVM,A-inline-assembly,O-riscv,F-asm,C-external-bug

I'm currently using the `asm!` macro on the `riscv64gc-unknown-none-elf` target, and have been getting some "errors" for a while about instructions requiring extensions -- except that GC includes the extensions of the instructions I'm using (IMAFDC). So far I've seen errors for F, D, and A instructions, everything else seems to be fine that I've used so far. Despite them being reported as errors, the build still succeeds however. @nbdd0121 suggested this may be an LLVM bug.

Example:
```
error: instruction requires the following: 'D' (Double-Precision Floating-Point)
        fsd f0, 248(sp)
        ^
error: instruction requires the following: 'A' (Atomic Instructions)
        sc.d zero, zero, 0(sp)
        ^
```
Repository: vscode
Issue: Breadcrumbs/selectbox dropdown does not relayout after resizing panel
Labels: bug,breadcrumbs

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: stable and insiders

Steps to Reproduce:

1. Click on a breadcrumb/selectbox so the dropdown shows up
2. Resize panel
3. :bug: Observe the dropdown does not relayout 

![breadcrumbsfloating](https://user-images.githubusercontent.com/25115070/103451019-a1e1e300-4c8c-11eb-90ae-c2466029e713.gif)
![customselectboxfloating](https://user-images.githubusercontent.com/25115070/103474190-55bb9f00-4d6f-11eb-98b2-77fdd40e1ff2.gif)
Repository: ant-design
Issue: [Component][Select] Is it possible to add option value as customizeIconProps when working with menuItemSelectedIcon
Labels: Inactive

- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.

### What problem does this feature solve?
I'm trying working with property `menuItemSelectedIcon` of Select in which I want to bind a onClick handler to the corresponding icon and want to know which Option trigger the handler. Thus I suppose `Option.value` should be including in props of `menuItemSelectedIcon` but `isSelected` only for now.

```javascript
<TransBtn
  className={`${itemPrefixCls}-option-state`}
  customizeIcon={menuItemSelectedIcon}
  customizeIconProps={{ isSelected: selected }}
>
```
*From: https://github.com/react-component/select/blob/master/src/OptionList.tsx#L359*

I don't know there is any way to achive "to know which Option trigger the handler", if there is please let me know thanks.

By the way, as my understanding from the aspect of design, `menuItemSelectedIcon` should belong to "Option" level(although it is decalared in "Select") so I guess it is reasonable to add one more property `value` into `customizeIconProps`, like below:
```Javascript
<TransBtn
  className={`${itemPrefixCls}-option-state`}
  customizeIcon={menuItemSelectedIcon}
  customizeIconProps={{ isSelected: selected, value }}
>
```

### What does the proposed API look like?
```Javascript
function demo(props) {
  const customIcon = (props: { isSelected: boolean; value: string | number }) => {
    const item = getIteamById(value);
    return <EditOutlined onClick={(event) => this.handleItemEdit(event, item)}/>;
  }
  
  return (
    <Select menuItemSelectedIcon={customIcon}>
      {props.list.map(item => (
        <Select.Option key={item.id} value={item.id}>{item.label}</Select.Option>
      ))}
    </Select>
  )
}
```


<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: neovim
Issue: Make the :global command respect the \zs regex atom.
Labels: enhancement

<!-- Before reporting: search existing issues and check the FAQ. -->

(n/a issue template “fields” removed)

### Actual behaviour

When the pattern given to a `:global` command is given a “starting position” (the zero-width `\zs` atom) at some point after a new-line atom (`\n`), the position of the action taken is not that of the beginning of the match (at the `\zs`), but instead at the beginning of the pattern.

e.g. (toy example):
```
first line
second line
```
```vim
:g`first line\n\zssecond line`normal A!!!<1b>
```
```
first line!!!
second line
```

### Expected behaviour

The global command should account for the actual starting position of the match, which is not always the same thing as whatever buffer position matches the beginning of the pattern. The entire purpose of the `\zs` atom is to allow for arbitrarily narrow qualification of a match using the context in which the match appears, *but which is not actually part of it*. Everything before a `\zs` is, conceptually, a wholly separate entity, which by its nature is immediately adjacent, but which may be completely unrelated otherwise.

Back to the “actual behavior” example, the given command should have this result:
```
first line
second line!!!
```

### Possible behavior extension:
Allow for a kind of global command that understands the character-wise position of the match.

e.g. (toy example):
```
one banana
two apples
```
```vim
:g`\v^\k+\s+\zs\a`normal vgU
```
```
one Banana
two Apples
```
Repository: TypeScript
Issue: index.d.ts is not a module
Labels: Needs Investigation

# Bug Report



### 🔎 Search Terms

- index.d.ts
- coc-tsserver
- module

### 🕗 Version & Regression Information

typescript@4.2.0-dev.20210102

- This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________

### ⏯ Playground Link

[Detailed Description](https://github.com/neoclide/coc-tsserver/issues/245)
[Reproduce Steps](https://user-images.githubusercontent.com/33961674/103449549-06f80180-4caa-11eb-9009-35edba28fa7d.gif)

### 💻 Code

https://github.com/fannheyward/coc-rust-analyzer/blob/master/src/index.ts

### 🙁 Actual behavior

https://user-images.githubusercontent.com/33961674/103449549-06f80180-4caa-11eb-9009-35edba28fa7d.gif
The diagnostic is wrong, it reports `index.d.ts` is not a module while the file was just there.

### 🙂 Expected behavior

No wrong diagnostics, continue working
Repository: electron
Issue: Exposing Chromium's Page Freezing (to the BrowserView API?)
Labels: enhancement :sparkles:

Heya and a happy new year!

I was wondering whether there is a shared interest in providing access to [Chromium's Page Freezing](https://chromium.googlesource.com/chromium/src/+/HEAD/chrome/browser/performance_manager/docs/freezing_opt_out_opt_in.md) in Electron? From my understanding it allows non-visible pages to be suspended, thus not eating resources anymore, while also being quick to recover once they come into view again.

If there is interest, I'd be happy to take a stab at creating a PR for this.
Repository: material-ui
Issue: Request for option to have Horizontal Timeline element as well as existing Vertical
Labels: new feature,waiting for 👍,component: timeline

Is it possible to have horizontal timeline elements as well along with vertical ones
Repository: opencv
Issue: Allow to skip unit tests which depend on opencv_extra
Labels: priority: low

##### System information (version)
- OpenCV => 4.5.1

##### Detailed description

The OpenCV test suite has many tests which are self contained, and do not depend on the files from opencv_extra. It would be great to be able to only run these self contained tests. 

This would allow to run the tests as part of a distribution build, to catch any regressions/issues early. See e.g. #19020.

Having a dependency on opencv_extra is problematic, as a) it is large, b) the license of the contained files is not clear (None is specified. Is it redistributable? Under what terms?).
Repository: godot
Issue: Error with Custom User Dir.
Labels: bug,topic:core

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
<!-- Specify commit hash if using non-official build. -->
3.2.3 Stable

**OS/device including version:**
<!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. -->
Windows 10 Home, Version 10.0.19041


**Issue description:**
<!-- What happened, and what was expected. -->
Upon choosing `use_custom_user_dir` in Project Settings, this error is printed the first time the user dir is created:
```
E 0:00:00.012   make_dir_recursive: Method failed. Returning: err
  <C++ Source>  core/os/dir_access.cpp:185 @ make_dir_recursive()
```


**Steps to reproduce:**
- Create a new project.
- Go to project settings, and enable `use_custom_user_dir`.
- Run the project for the first time.
  - You can delete the created folder, or change the `custom_user_dir_name` and the error will reappear.


**Minimal reproduction project:**
<!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. -->
[CustomUserDir.zip](https://github.com/godotengine/godot/files/5760558/CustomUserDir.zip)
Repository: flutter
Issue: Allow _SearchPageRoute shown using 'showSearch' to maintain state
Labels: c: new feature,framework,f: material design,f: routes,c: proposal,P3,team-design,triaged-design

## Use case

I have an application which uses `showSearch`. Once suggestions are loaded, the user can click one of them which directs them to another screen where the user needs to pick something; at this point the route is popped and the user is taken back to the search UI. Once there, the app needs something from the context to execute further logic and finally deliver results. 

Looking things up in the context doesn't work after returning to search since the context is 'stale' and it results in:

```
Looking up a deactivated widget's ancestor is unsafe.
At this point the state of the widget's element tree is no longer stable.
```

Pseudocode (within search UI, `onTap` handler of an item):

```dart
final something = await Navigator.of(context).push(someRoute);
if (something != null) {
  // at this point context is no longer usable, next line fails
  context.read<SomeBloc>().add(SomeEvent());
}
```

The reason seems to be this: https://github.com/flutter/flutter/blob/1.22.5/packages/flutter/lib/src/material/search.dart#L353.

One solution / workaround is to look the bloc up before navigating to the next screen, but this just hides the issue and is dangerous (some new code might try to use the stale context), wasteful (sometimes the user cancels the next screen and there is no point to look up the bloc beforehand) and doesn't 'flow' logically.

## Proposal

Would it be possible, using an optional parameter to `showSearch` defaulting to `false` so that the API and behavior are backwards compatible, for the search route to maintain state? The `_SearchPageRoute` would take it as argument and its `maintainState` would return it. This would keep the context alive.
Repository: vscode
Issue: Disallow navigating away from custom editors when retainContextWhenHidden is false and the backup has yet to run orfailed
Labels: feature-request,custom-editors

Repro 1 (backup not yet run):

1. Create a custom editor extension that uses retainContextWhenHidden: false (the default)
2. Make some change that triggers a `CustomDocumentEditEvent`
3. Switch to another tab immediately (before backup runs)
4. Switch back

Repro 2 (backup failed):

1. Create a custom editor extension that uses retainContextWhenHidden: false (the default)
2. Make some change in the custom editor which caused an error to be thrown in `CustomEditorProvider.backupCustomDocument`
4. Switch to another tab
5. Switch back

The custom editor provider will have no option but to load the last known backup or from disk, which differs from the previous state. Resulting in data loss ☹️ 

For repro 1 https://github.com/microsoft/vscode/issues/113507 would be ideal, but tab switching should be blocked and a `backupCustomDocument` request issued immediately (allow maybe ~1 second for it to compete?). For repro 2, navigating away from the tab should be blocked with a dialog to save, don't save or cancel.