sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: rust
Issue: Some unused_parens suggestions can result in keyword soup (even if technically correct).
Labels: A-lints,A-diagnostics,T-lang,A-control-flow,L-unused_parens

During some testcase minimization, I expanded an `a && b` by hand and ended up with this:
```rust
pub fn if_and_and<T>(a: bool, b: bool, x: T, y: T) -> T {
    if (if a { b } else { false }) {
        x
    } else {
        y
    }
}
```
The parens make it possible to read it as "nested `if`, in `if` condition", but `rustc` is having none of that:
```
warning: unnecessary parentheses around `if` condition
 --> src/lib.rs:2:8
  |
2 |     if (if a { b } else { false }) {
  |        ^                         ^
  |
  = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
  |
2 -     if (if a { b } else { false }) {
2 +     if if a { b } else { false } {
  |
```

I'm guessing this triggers for any combination like `if (match`, `match (match`, `match (if`, `while (if` etc.
Even if it may parse successfully, successful keywords like that is a really bad idea IMO.

Other than the expressions of the form `keyword EXPR {...}`, I also think e.g. `return return` and `break break` would be more readable as `return (return)` and `break (break)` (so pretty much all keyword-introduced expressions, really).

Maybe such expressions can be accidentally typed (or the result of some automated refactor?), so suggesting *adding* parens around them (if we had that capability) could help the user understand what `rustc` is even parsing their keyword soup as - but at least we shouldn't discourage them from adding the parens themselves.

---

Looking at [other `unused_parens` issues](https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+unused_parens) it seems there's even false positive where the lint isn't *even technically correct* (and its suggestions wouldn't parse at all).
Maybe all the false positives should be combined into one issue? (might also help raise visibility)
Repository: storybook
Issue: Narrator is announcing incorrect selection state while navigating to the tab items (Controls, Actions, interactions, Accessibility and performance).[Bug]: 
Labels: bug,good first issue,help wanted,accessibility,sev:S3

### Describe the bug

Narrator is announcing incorrect selection state while navigating to the tab items (Controls, Actions, interactions, Accessibility and performance).
Severity-2
Application: Storybook

### To Reproduce

**Pre-requisites:**
Turn on Narrator (Settings-->Accessibility-->Narrator (Or) Ctrl + win key + enter).

**Repro steps:**
1. Open URL: “[Overview - Docs ⋅ Storybook (windows.net)](https://vivacommonstorybooktest.blob.core.windows.net/$web/index.html?path=/docs/overview--docs)” and sign in with valid credentials. 
2. Select “Common navigation with data transform” in the left navigation and invoke it. 
3. Now navigate to ‘Actions’ tab and observe the narrator announcement whether the narrator is narrating correct state or not.

### System

```shell
Windows: Win11 Enterprise
OS: Version 22H2 (OS Build 22621.1992) 
Edge Version: Version 114.0.1823.51 (Official build) (64-bit) 
URL: Overview - Docs ⋅ Storybook (windows.net)
```


### Additional context

**Expected Result:**
Narrator should announce the proper selection state for all the tab items  (Controls, Actions, interactions, Accessibility and performance).>Narrator should announce as selected only for selected tab item and should announce the information only once.

**Attachments:**
Kindly check the video attachment added.

https://github.com/storybookjs/storybook/assets/93735775/5153cec8-9d09-4d71-8138-846fa1b89ebb

![Ellipsis menu-narrator announcement](https://github.com/storybookjs/storybook/assets/93735775/0936512d-641d-4f1b-bebe-c7803816668a)
Repository: storybook
Issue: Code and the Copy button under Common Navigation with custom bottom slot and Common Navigation with custom mid slot are getting overlapped when browser zoom level set to 400%.[Bug]: 
Labels: bug,good first issue,help wanted,ui,sev:S4

### Describe the bug

Code and the Copy button under Common Navigation with custom bottom slot and Common Navigation with custom mid slot are getting overlapped when browser zoom level set to 400%.

Severity: Usable

### To Reproduce

**Pre- Requisites:** 
Set browser zoom level to 400%

**Repro Steps:** 
1. Open URL: “Overview - Docs ⋅ Storybook (windows.net)” and sign in with valid credentials.
2. Expand Common navigation in left navigation pane and select Common Navigation under it.
3. Now Apply Reflow (400% zoom) for web for the opened page.
4. Verify whether the Code and copy button are overlapping or not.

### System

```shell
Windows: Win11 Enterprise 
OS: Version 22H2 (OS Build 22621.1992) 
Edge Version: Version 114.0.1823.51 (Official build) (64-bit) 
URL: Overview - Docs ⋅ Storybook (windows.net)
```


### Additional context

**Expected Result:**
Code and the Copy button under Common Navigation with custom bottom slot and Common Navigation with custom mid slot should not get overlapped when browser zoom level set to 400%.

Attachment are added:

![Normal mode](https://github.com/storybookjs/storybook/assets/93735775/637d31b6-de0b-4751-82d0-4d37de18112d)


![Zoom-Common Navigation with custom bottom slot](https://github.com/storybookjs/storybook/assets/93735775/2692edc5-1c98-4a88-aafd-fb2e8f0d158e)
Repository: storybook
Issue: Code and the Copy button under Common Navigation with custom bottom slot and Common Navigation with custom mid slot are getting slightly overlapped in orientation-portrait mode. 
Labels: bug,good first issue,help wanted,ui,sev:S4

### Describe the bug

Code and the Copy button under Common Navigation with custom bottom slot and Common Navigation with custom mid slot are getting slightly overlapped in orientation-portrait mode.

Severity: Usable

### To Reproduce

**Pre- Requisites:** 
Settings-->Display-->Display orientation-->Portrait.

**Repro Steps:** 
Open URL: “[Overview - Docs ⋅ Storybook (windows.net)](https://vivacommonstorybooktest.blob.core.windows.net/$web/index.html?path=/docs/overview--docs)” and sign in with valid credentials. 
In left navigation select “components button for Common Navigation Drop Down select Common Navigation” and invoke it.  
Now Apply Orientation in portrait mode and observe the page.
Verify whether the code and copy button are overlapping slightly or not.

### System

```shell
Environmental details:  
Windows: Win11 Enterprise
OS: Version 22H2 (OS Build 22621.1992) 
Edge Version: Version 114.0.1823.51 (Official build) (64-bit) 
URL: Overview - Docs ⋅ Storybook (windows.net)
```


### Additional context

Expected Result:
Code and the Copy button under Common Navigation with custom bottom slot and Common Navigation with custom mid slot should not get overlapped in orientation-portrait mode.

Attachments are added
Normal mode:
![Normal mode (1)](https://github.com/storybookjs/storybook/assets/93735775/bccc18ec-d6f7-48f4-b61b-b0182f8fb953)

After applying orientation:
![Orienation mode](https://github.com/storybookjs/storybook/assets/93735775/8acf69b6-6460-4923-b0dd-e8797b18684b)
Repository: ant-design
Issue: In a Table tree, when text is wrapping it goes under the   icon
Labels: 🐛 Bug,Inactive

### Reproduction link

[![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/tree-data-antd-5-7-3-forked-grhfnk?file=/demo.tsx)

### Steps to reproduce

Make the first column data be a long text.

### What is expected?

The text should wrap but be indented so that it appears in column.

### What is actually happening?

The text is wrapped under the   icon.

| Environment | Info |
| --- | --- |
| antd | 5.7.3 |
| React | 18 |
| System | Any |
| Browser | Any |

---
I solved it by hacking in css and by making the td flex row, the button display block and wrap my text in a div. This is a hack and I think a proper solution in ant-design should be done.

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: go
Issue: x/tools/gopls: feature: CLI syntax for renaming by identifier, not position (like cmd/gorename)
Labels: FeatureRequest,gopls,Tools

Such as:
```
  "encoding/json".Decoder.Decode        method of package-level named type                                                                                                                                                                     
  (*"encoding/json".Decoder).Decode     ditto, alternative syntax                                                                                                                                                                              
  "encoding/json".Decoder.buf           field of package-level named struct type                                                                                                                                                               
  "encoding/json".HTMLEscape            package member (const, func, var, type)                                                                                                                                                                
  "encoding/json".Decoder.Decode::x     local object x within a method                                                                                                                                                                         
  "encoding/json".HTMLEscape::x         local object x within a function                                                                                                                                                                       
  "encoding/json"::x                    object x anywhere within a package                                                                                                                                                                     
  json.go::x                            object x within file json.go  
```
Repository: vscode
Issue: [themes] Theme is getting switched on switching profiles
Labels: bug,themes,user-profiles

From @amunger 

- Have a profile with a custom theme. Eg: GitHub Light Default theme from GitHub.github-vscode-theme extension
- Switch to default profile and set a different theme - builtin theme is enough
- Make the theme setting apply to all profiles
- Switch to the first profile

🐛 Theme is getting reset to default dark
Repository: react-native
Issue: [New Architecture] LayoutAnimation Breaking
Labels: Issue: Author Provided Repro,API: LayoutAnimation,Bug,Type: New Architecture

### Description

After migrating to new architecture, the animation configured with LayoutAnimation are behaving differently, we can observe a kind of jerk in the animation. Attached the videos and repo for reproduction of the issue.

Also check in slow motion with simulator, eventually the views are not adopting the slow animation and breaking. 

### React Native Version

0.72.3

### Output of `npx react-native info`

System:
  OS: macOS 13.4.1
  CPU: (12) arm64 Apple M2 Pro
  Memory: 312.44 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 16.20.0
    path: /usr/local/bin/node
  Yarn:
    version: 1.22.19
    path: /opt/homebrew/bin/yarn
  npm:
    version: 8.19.4
    path: /usr/local/bin/npm
  Watchman:
    version: 2023.06.26.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.12.1
    path: /Users/ravindragupta/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.4
      - iOS 16.4
      - macOS 13.3
      - tvOS 16.4
      - watchOS 9.4
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.2 AI-222.4459.24.2221.10121639
  Xcode:
    version: 14.3.1/14E300c
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 11.0.19
    path: /usr/bin/javac
  Ruby:
    version: 3.0.4
    path: /Users/ravindragupta/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: ^18.2.0
  react-native:
    installed: 0.72.3
    wanted: 0.72.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: false
  newArchEnabled: true
iOS:
  hermesEnabled: false
  newArchEnabled: true

### Steps to reproduce

Use LayoutAnimation with New Architecture (Fabric) and observe issues with animation.

### Snack, code example, screenshot, or link to a repository

Reproducible Demo App: https://github.com/ravindraguptacapgemini/reproducer-react-native-maps-events/tree/layout-animation-issue

Videos and Screenshot:


https://github.com/facebook/react-native/assets/97147467/d9e66cc5-0fd5-4881-91d9-dd9b684aba97


https://github.com/facebook/react-native/assets/97147467/b5b752b5-7d02-412d-a61d-7a8a82e6dbd2

<img width="387" alt="New Architecture Animation Breaking" src="https://github.com/facebook/react-native/assets/97147467/4bc8df11-c370-4b59-af3f-1761ee7b599f">
Repository: godot
Issue: Semaphore.post() not working from inside Thread when await is used
Labels: bug,topic:gdscript

### Godot version

v4.1.stable.official [970459615]

### System information

Windows 11 Pro, Version 22H2, Build 22621.1778 - v4.1.stable.official [970459615] - Vulkan (Forward +)

### Issue description

Using await inside a Thread seems to prevent Semaphore.post() to function correctly.

### Steps to reproduce

```
func _ready():
	var semaphore = Semaphore.new()
	semaphore.post()

	var task = func(index):
		semaphore.wait()
		print("%s" % index)
		await get_tree().process_frame
		semaphore.post()

	var task_id = WorkerThreadPool.add_group_task(task, 2)
	WorkerThreadPool.wait_for_group_task_completion(task_id)
	get_tree().quit()
```

In the code above, the await seems to prevent the semaphore.post(). With the `await get_tree().process_frame` statement, the program just hangs. When I comment `await get_tree().process_frame` out, then I get the expected output
```
0
1
```

### Minimal reproduction project

N/A
Repository: go
Issue: proposal: syscall: extend the interface definition of RawConn to support non-blocking operations
Labels: Proposal

Related:
https://github.com/golang/go/issues/15735

I think it will be more useful to provide these non-blocking methods by RawConn rather than TCPConn.

These new metheds and the new definition would be like(see the OnRead/OnWrite/EnablePollWrite:
```golang
// A RawConn is a raw network connection.
type RawConn interface {
	// Control invokes f on the underlying connection's file
	// descriptor or handle.
	// The file descriptor fd is guaranteed to remain valid while
	// f executes but not after f returns.
	Control(f func(fd uintptr)) error

	// Read invokes f on the underlying connection's file
	// descriptor or handle; f is expected to try to read from the
	// file descriptor.
	// If f returns true, Read returns. Otherwise Read blocks
	// waiting for the connection to be ready for reading and
	// tries again repeatedly.
	// The file descriptor is guaranteed to remain valid while f
	// executes but not after f returns.
	Read(f func(fd uintptr) (done bool)) error

	// Write is like Read but for writing.
	Write(f func(fd uintptr) (done bool)) error

	// This is a new method.
	// OnRead registers a callback to handle the reading event.
	// If this callback is registered, users don't need to use
	// one goroutine for each conn and read it in a for-loop.
	OnRead(func(fd uintptr))

	// This is a new method.
	// OnWrite registers a callback to handle the writing event.
	OnWrite(func(fd uintptr))

	// This is a new method.
	// EnablePollWrite enables write event on the poller.
	// Users should cache the data unsent and call EnablePollWrite(true)
	// to enable the write event when Write fails, then the OnWrite 
	// callback will be called when the fd is writable;
	// Users should  call EnablePollWrite(false) to cancel the write
	// event after cached data has been sent.
	EnablePollWrite(enable bool)
}
```

After providing these new methods, users will be able to choose how to handle Fd's IO:
1. Using blocking Read/Write as before
2. Get RawConn by conn.SyscallConn(), and use RawConn.OnRead/OnWrite/EnablePollWrite to handle IO in a non-blocking way

The old issue https://github.com/golang/go/issues/15735 was only for TCPConn, and still no solution to solve the problem of saving goroutines and blocking methods, so I open this new issue.
Repository: kubernetes
Issue: previous node taint is wiped when kubelet restarts
Labels: kind/bug,sig/node,triage/accepted

### What happened?

I have a k8s cluster(v1.27.2) containing one node. I set `evictionHard: nodefs.available: 90%` and write a large amount of data to kubelet rootdir（used 8GB / total 10GB ） to trigger eviction. `node.kubernetes.io/disk-pressure` taint was added to this node. But when kubelet restarted, previous disk-pressure taint was wiped weirdly. And pending pod is normally scheduled to run on the current node. Then I checked the kubelet logs and found:

kubelet restart:
```
I0727 11:09:05.782733 3813426 flags.go:64] FLAG: --tls-private-key-file=""
I0727 11:09:05.782737 3813426 flags.go:64] FLAG: --topology-manager-policy="none"
I0727 11:09:05.782741 3813426 flags.go:64] FLAG: --topology-manager-scope="container"
I0727 11:09:05.782745 3813426 flags.go:64] FLAG: --v="8"
I0727 11:09:05.782749 3813426 flags.go:64] FLAG: --version="false"
I0727 11:09:05.782754 3813426 flags.go:64] FLAG: --vmodule=""
I0727 11:09:05.782757 3813426 flags.go:64] FLAG: --volume-plugin-dir="/usr/libexec/kubernetes/kubelet-plugins/volume/exec/"
I0727 11:09:05.782761 3813426 flags.go:64] FLAG: --volume-stats-agg-period="1m0s"
I0727 11:09:05.796690 3813426 mount_linux.go:222] Detected OS with systemd
```
update node status **NodeHasNoDiskPressure**
``` 
I0727 11:09:10.858628 3813426 kubelet_node_status.go:632] "Recording event message for node" node="192.168.2.107" event="NodeHasNoDiskPressure"
I0727 11:09:10.858640 3813426 kubelet_node_status.go:762] "Setting node status condition code" position=9 node="192.168.2.107"
```
eviction manager  start to synchronize 
```
I0727 11:09:13.373393 3813426 eviction_manager.go:292] "Eviction manager: synchronize housekeeping"
```

Q: Why does kubelet report **NodeHasNoDiskPressure** ?
A: Eviction manager has not yet executed the synchronize method


> Normally, a node that was previously marked with taints should retain after reboot otherwise it doesn't make sense. Maybe we need to make sure that taints can't be deleted when kubelet restarts?


### What did you expect to happen?

previous node taint is not wiped 

### How can we reproduce it (as minimally and precisely as possible)?

Restart kubelet repeatedly after the disk pressure eviction is triggered. Observe `node.spec.taints`

### Anything else we need to know?

_No response_

### Kubernetes version

1.27.2

### Cloud provider

<details>

</details>


### OS version

<details>

```console
# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
```

</details>


### Install tools

<details>

</details>


### Container runtime (CRI) and version (if applicable)

<details>

</details>


### Related plugins (CNI, CSI, ...) and versions (if applicable)

<details>

</details>
Repository: flutter
Issue: Docs state nested Scaffolds should be avoided, hence the official examples do nest Scaffolds
Labels: f: material design,d: api docs,c: proposal,P3,team-design,triaged-design

### Is there an existing issue for this?

- [X] I have searched the [existing issues](https://github.com/flutter/flutter/issues)
- [X] I have read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)

### Steps to reproduce

1. Go to: https://api.flutter.dev/flutter/material/Scaffold-class.html
2. Read "Troubleshooting" -> "Nested Scaffolds":
> It is **typically not necessary to nest Scaffolds**. For example, in a tabbed UI, where the [bottomNavigationBar](https://api.flutter.dev/flutter/material/Scaffold/bottomNavigationBar.html) is a [TabBar](https://api.flutter.dev/flutter/material/TabBar-class.html) and the body is a [TabBarView](https://api.flutter.dev/flutter/material/TabBarView-class.html), you might be tempted to make each tab bar view a scaffold with a differently titled AppBar. Rather, it would be better to add a listener to the [TabController](https://api.flutter.dev/flutter/material/TabController-class.html) that updates the AppBar
> Although there are some use cases, like a presentation app that shows embedded flutter content, where nested scaffolds are appropriate, it's **best to avoid nesting scaffolds**.

3. Go to the official sample for StatefulShellRoute: https://github.com/flutter/packages/blob/main/packages/go_router/example/lib/stateful_shell_route.dart
4. Take a look at the code and see nested scaffolds being used.

![image](https://github.com/flutter/flutter/assets/740791/7369c68d-c87e-4ab0-9124-63ccfaadef0d)


### Expected results

Either better documentation which scenarios are appropriate for nested Scaffolds or better examples that do not use nested Scaffolds. 

As a beginner, the correct approach is confusing when the official resources are inconsistent and/or missing documentation for appropriate use cases.

### Actual results

Either example or documentation needs more love.

### Code sample

<details><summary>Code sample</summary>

Official sample: https://github.com/flutter/packages/blob/main/packages/go_router/example/lib/stateful_shell_route.dart

</details>


### Screenshots or Video

<details>
<summary>Screenshots / Video demonstration</summary>

[Upload media here]

</details>


### Logs

<details><summary>Logs</summary>

Not needed. 

</details>


### Flutter Doctor output

<details><summary>Doctor output</summary>

Not needed. 

</details>
Repository: angular
Issue: No way to declare `Input` `transform` and `static ngAcceptInputType_` at the same time
Labels: area: core,core: inputs / outputs

### Which @angular/* package(s) are the source of the bug?

core

### Is this a regression?

Yes

### Description

When using `Input` `transform` feature, the input's type become `unknown`, and I'd like to allow certain type only like `boolean | ''`

```ts
import { booleanAttribute, Component, Input } from '@angular/core';

@Component({
  selector: 'app-test',
  template: `Disabled {{ disabled | json }}`,
})
export class TestComponent {
  @Input({ transform: booleanAttribute })
  disabled?: boolean;

  static ngAcceptInputType_disabled: boolean | '';
}
```

### Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/stackblitz-starters-zji3lf

### Please provide the exception or error you saw

```true
Class cannot have both a transform function on Input disabled and a static member called ngAcceptInputType_disabled
```


### Please provide the environment you discovered this bug in (run `ng version`)

_No response_

### Anything else?

_No response_