sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: vscode
Issue: Search Marketplace button for missing notebook renderer doesn't work as expected
Labels: feature-request,marketplace,notebook-output

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.68-insider
- OS Version: Windows 11

Steps to Reproduce:

1. Uninstall the Microsoft notebook renderers extension
2. Open https://insiders.vscode.dev/github/greazer/covid-19-data/blob/master/SampleNbsAndScripts/myanalysis_plotly.ipynb#C15
3. Click on the Search Marketplace button
4. :bug: no results for the query specified
5. However, if I install the Microsoft notebook renderers extension and reload the page, that same cell output now renders correctly, so that extension should have appeared in the search results 
![image](https://user-images.githubusercontent.com/30305945/171746689-d58a73e1-7493-4489-97f6-d542ee50053f.png)
Repository: pytorch
Issue: [FSDP] Customizable gradient pre-divide for mixed precision training
Labels: oncall: distributed,triaged,module: fsdp

### 🚀 The feature, motivation and pitch

When training FSDP with mixed precision and fp16, we need to be aware of the reduced range and avoid over/underflow. If we sum all gradients for a large world size and then divide, this might overflow the fp16 range and cause issues, while if we divide first and then sum, we may risk underflow. One possible solution is to divide by sqrt(N), run allreduce, and then divide the result again by sqrt(N) which is equivalent to a N = world size divide. As a result, allreduce only increases the magnitude by sqrt(N=world size), which is less likely to cause overflow.

### Alternatives

_No response_

### Additional context

_No response_

cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @SciPioneer @H-Huang @kwen2501
Repository: flutter
Issue: `.flutter`, `.flutter-devtools`, `.pub-cache` and `bin/cache` in incorrect places
Labels: c: new feature,platform-mac,a: fidelity,c: proposal,P2,team-tool,triaged-tool

On macOS, Flutter stores `.flutter` and `.flutter-devtools` in the home folder. This is unconventional and contributes to a mess where app files are scattered everywhere, and the home folder gets cluttered.

Additionally `flutter/.pub-cache` and `flutter/bin/cache` are stored inside the Flutter folder. This results in users' backups being filled up with cache files without realizing.

Proper paths like `~/Library/Application Support`, `~/Library/Caches` and `~/Library/Preferences` should be used for this.
Repository: neovim
Issue: EOL whitespace highlight
Labels: enhancement,documentation,highlight

### Feature already in Vim?

No

### Feature description

If we want to highlight EOL whitespaces, we currently have to rely on magic incantations such as:

```vim
highlight WhitespaceEOL ctermbg=red
match WhitespaceEOL /\\\@<!\s\+\%#\@<!$/
augroup winenter_whitespaceeol
    autocmd!
    autocmd WinEnter * match WhiteSpaceEOL /\\\@<!\s\+\%#\@<!$/
augroup END
```

The `list` option kind of helps but it's often not really visible and it doesn't seem there is any way of customizing the `listchars` color.

In C, there is `c_space_errors` setting that helps but it's C only so it has a very limited use.

I'm not sure about which solution to pick between adding the ability to set color codes in `listchars`, adding a global option or something else. But the quoted blob is not exactly a solution for most users.
Repository: go
Issue: cmd/dist: per-developer scheduling of tests based on past failure rate
Labels: NeedsInvestigation,FeatureRequest

I don't regularly run `go tool dist test` (or run.bash or all.bash), because usually either (1) I've broken cmd/compile so badly even hello world will explode, or (2) I've broken something really subtle that's only going to be caught by a few packages / tests, which are really late in the test order. Instead, I keep a test script that I constantly and manually revise based on which failures I'm currently running into during development.

However, I think it would be nice if cmd/dist could track this automatically. E.g., I often break test/run.go and go/importer, so it would be nice if `go tool dist test` ran those tests earlier.

--

As a strawman proposal to kick things off, I'd suggest adding a `-history filename` flag to cmd/dist.

A cmd/dist history file is a list of (TestName string, FailureRate float64) pairs. Simplest format would be just line-oriented; e.g., `go_test:go/importer 0.75`.

If the `-history` flag is specified, at startup the history file is read in. After the list of tests to run are determined, they're sorted in order of decreasing failure rate.

After running tests is finished, the `FailureRate` is updated: the new score is `0.8*old` if the test passed, and `0.8*old + 0.2` if the test failed. (I.e., exponentially-weighted moving average, with 80% as the weight.) If the test was skipped, then the score is unchanged.

Finally, the history file gets replaced with the new list of failure rates.
Repository: flutter
Issue: Error for mixmatch local engine and run configuration is obtuse
Labels: c: new feature,team,platform-ios,tool,engine,platform-mac,P3,team-ios,triaged-ios

## steps to reproduce
1) `flutter --local-engine-src-path ~/dev/engine/src --local-engine=ios_debug_unopt run`
1) quit the app
1) `open ios/Runner.xcworkspace`
1) Run the app with the "Profile" configuration

Notice the app doesn't run and produces an error.

## error log
```
2022-06-02 16:22:09.504086-0700 Runner[18776:17645791] Failed to find snapshot: /private/var/containers/Bundle/Application/48E14B1E-8A58-45C6-A839-A7D1EF7A5AD0/Runner.app/Frameworks/App.framework/flutter_assets/kernel_blob.bin
2022-06-02 16:22:09.504564-0700 Runner[18776:17645791] Metal API Validation Enabled
2022-06-02 16:22:09.720688-0700 Runner[18776:17645791] [VERBOSE-2:isolate_configuration.cc(217)] application_kernel_asset or application_kernel_list_asset must be set
2022-06-02 16:22:09.720873-0700 Runner[18776:17646043] [VERBOSE-2:engine.cc(200)] Engine run configuration was invalid.
2022-06-02 16:22:09.720917-0700 Runner[18776:17646043] [VERBOSE-2:shell.cc(604)] Could not launch engine with configuration.
2022-06-02 16:22:09.725540-0700 Runner[18776:17645791] [VERBOSE-2:shell.cc(921)] Embedding reported invalid ViewportMetrics, ignoring update.
physical_width: 0
physical_height: 0
device_pixel_ratio: 1
2022-06-02 16:22:09.758302-0700 Runner[18776:17646057] flutter: The Dart VM service is listening on http://127.0.0.1:62363/QckwsW82XUw=/
2022-06-02 16:22:09.766171-0700 Runner[18776:17645791] [VERBOSE-2:FlutterObservatoryPublisher.mm(138)] Could not register as server for FlutterObservatoryPublisher, permission denied. Check your 'Local Network' permissions for this app in the Privacy section of the system Settings.
```

## doctor
```
[✓] Flutter (Channel unknown, 3.1.0-0.0.pre.1072, on macOS 12.4 21F79 darwin-x64, locale en-US)
    • Flutter version 3.1.0-0.0.pre.1072 at /Users/aaclarke/dev/flutter
    • Upstream repository unknown
    • Framework revision ff110fb958 (3 hours ago), 2022-06-02 13:11:28 -0700
    • Engine revision 00a64bf4f2
    • Dart version 2.18.0 (build 2.18.0-163.0.dev)
    • DevTools version 2.13.1
```

## Expected output
I expect the error to say something about using a local engine with an incompatible configuration.

cc @jmagman since she'll probably have an idea where we could detect this setup and print out something better.
Repository: TypeScript
Issue: `@internal` in JavaScript / TypeScript JSDoc comments
Labels: Suggestion,Awaiting More Feedback

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
### Description
When people are writing a multiline comment, we may mark it as `@internal`. when the classes or functions marked as `internal` are exported and used outside of their own files, there will render a strikethrough on the text (Just like how `@deprecated` works), saying this class/function is marked as internal and not supposed to be used directly in other modules.

![image](https://user-images.githubusercontent.com/38385498/171753569-f19ee6c3-f750-43a3-84fe-6bac50759f73.png)
![image](https://user-images.githubusercontent.com/38385498/171753551-3ab3e12c-4bfb-4aa9-9169-d848bddf55de.png)

### Reason
The reason I have to export these functions or classes is that I need to write unit tests for them. They are not intended to be used directly. 

When I am reading the source code of VSCode, I also realized some exported classes have comments such as `DO NOT USE DIRECTLY` because these are used for unit testing, which having the same reason that I have.

I think this may decrease the chances for other programmers that accidentally use them.
Repository: rust
Issue: Sporadic errors with armhf-gnu CI remote test runs
Labels: A-spurious,T-infra,A-CI

The `armhf-gnu` CI runner has been having sporadic errors while running remote tests. The errors typically look something like:

```
---- [ui] src/test/ui/modules/mod_dir_implicit.rs stdout ----

error: test run failed!
status: exit status: 101
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/modules/mod_dir_implicit/a"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/modules/mod_dir_implicit/a", waiting for result
------------------------------------------
--- stderr -------------------------------
thread 'main' panicked at 'client.read_exact(&mut header) failed with Connection reset by peer (os error 104)', src/tools/remote-test-client/src/main.rs:310:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
------------------------------------------
```

There's not much to go on here, as we can't really see the qemu server side.

I don't see a pattern in which tests are failing, so it could be just a general issue with the qemu setup?

* 2021-11-21T00:49:48 https://github.com/rust-lang-ci/rust/actions/runs/1485716983: `ui/simd/intrinsic/inlining-issue67557.rs`
* 2021-11-25T12:01:07 https://github.com/rust-lang-ci/rust/actions/runs/1503586127: `ui/modules/mod-view-items.rs`
* 2022-01-23T05:35:55 https://github.com/rust-lang-ci/rust/actions/runs/1735092010: `ui/generics/generic-fn-infer.rs`
* 2022-02-16T17:19:17 https://github.com/rust-lang-ci/rust/actions/runs/1854221995: `ui/issues/issue-42210.rs`
* 2022-03-03T09:44:04 https://github.com/rust-lang-ci/rust/actions/runs/1927255833: `ui/modules/mod_dir_implicit.rs`
* 2022-03-23T08:23:38 https://github.com/rust-lang-ci/rust/actions/runs/2027186581: `ui/imports/glob-use-std.rs`
* 2022-03-24T05:38:15 https://github.com/rust-lang-ci/rust/actions/runs/2032465233: `ui/numbers-arithmetic/next-power-of-two-overflow-debug.rs`
* 2022-05-19T11:55:23 https://github.com/rust-lang-ci/rust/actions/runs/2351785646: `src/test/ui/binding/match-pattern-lit.rs`
* 2022-05-29T10:43:44 https://github.com/rust-lang-ci/rust/actions/runs/2404024881: `src/test/ui/generic-associated-types/const-generics-gat-in-trait-return-type-2.rs`
* 2022-06-01T14:15:07 https://github.com/rust-lang-ci/rust/actions/runs/2422184056: `src/test/ui/modules/mod_dir_implicit.rs`
Repository: pytorch
Issue: Deprecate hardtanh type promotion behavior.
Labels: module: nn,triaged,module: primTorch

### 🚀 The feature, motivation and pitch

There's no clear reason that `hardtanh` should exist - however, it currently has its own kernel and its own `hardtanh_backward`.

See discussion here: https://github.com/pytorch/pytorch/pull/78689/files/618a28c397fbc66433de7b16e5a86a413fd8bf2b#diff-93c7b95139f636278cc494028e322a2c3c3c9ba1e83b2adb35d54ccabed5b47a

cc: @mruberry @ngim

### Alternatives

N/A

### Additional context

N/A

cc @albanD @mruberry @jbschlosser @walterddr @kshitij12345 @ezyang @ngimel
Repository: PowerToys
Issue: QR Code Generator
Labels: Idea-New PowerToy

### Description of the new feature / enhancement

This feature would generate a QR Code based on the information provided inside Power Toys Run.  Either a Text QR or a URL QR.

The tags that could be used for Power Toys Run:
qrt: <text data> 
qru: <url>

### Scenario when this would be used?

This would be great when you need to quickly transmit data from your PC to a phone near by, such as a URL or a Text that sending it from other services would take too long.

### Supporting information

_No response_
Repository: node
Issue: FATAL ERROR: v8::FromJust Maybe value is Nothing
Labels: lib / src

### Version

v16.14.0

### Platform

Darwin 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:37 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T6000 arm64

### Subsystem

_No response_

### What steps will reproduce the bug?

Running yarn test in debug console in visual studio code

### How often does it reproduce? Is there a required condition?

Everytime

### What is the expected behavior?

_No response_

### What do you see instead?

```
FATAL ERROR: v8::FromJust Maybe value is Nothing.
 1: 0x10415a260 node::Abort() [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
 2: 0x10415a3e8 node::errors::TryCatchScope::~TryCatchScope() [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
 3: 0x1042aabc8 v8::V8::FromJustIsNothing() [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
 4: 0x104203174 node::ReportWritesToJSStreamListener::OnStreamAfterReqFinished(node::StreamReq*, int) [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
 5: 0x1042031d0 node::ShutdownWrap::OnDone(int) [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
 6: 0x104207640 node::LibuvStreamWrap::AfterUvShutdown(uv_shutdown_s*, int) [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
 7: 0x1049d53e8 uv__stream_io [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
 8: 0x1049dcf70 uv__io_poll [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
 9: 0x1049cb688 uv_run [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
10: 0x1040a7ccc node::SpinEventLoop(node::Environment*) [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
11: 0x1041ec598 node::worker::Worker::Run() [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
12: 0x1041ef7c0 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/rai/.nvm/versions/node/v16.14.0/bin/node]
13: 0x18afec26c _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
14: 0x18afe708c thread_start [/usr/lib/system/libsystem_pthread.dylib]
```

### Additional information

_No response_
Repository: TypeScript
Issue: Improve error message when accidentally spreading an array into an object instead of using the property shorthand
Labels: Suggestion,Awaiting More Feedback

# Suggestion

<!--
  Please fill in each section completely. Thank you!
-->

## 🔍 Search Terms

<!--
  💡 Did you know? TypeScript has over 2,000 open suggestions!
  🔎 Please search thoroughly before logging new feature requests as most common ideas already have a proposal in progress.
  The "Common Feature Requests" section of the FAQ lists many popular requests: https://github.com/Microsoft/TypeScript/wiki/FAQ#common-feature-requests

  Replace the text below:
-->
array property spread shorthand error message

## ✅ Viability Checklist

<!--
   Suggestions that don't meet all these criteria are very, very unlikely to be accepted.
   We always recommend reviewing the TypeScript design goals before investing time writing
   a proposal for ideas outside the scope of the project.
-->
My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).


## ⭐ Suggestion

I am aware that this might be a too specific use case, but I just stumbled across an intimidating error message for a pretty simple error.

## 📃 Motivating Example

```ts
interface Result {
    values: number;
}

function foo(): Result {
    const values: number[] = [];
    return {
        ...values,
        // ^ This should just be values, not ...values
    }
}
```

I accidentally spread the `values` array here, instead of using the object shorthand. The resulting error message was nasty:
```
Type '{ [n: number]: number; length: number; toString(): string; toLocaleString(): string; pop(): number | undefined; push(...items: number[]): number; concat(...items: ConcatArray<number>[]): number[]; concat(...items: (number | ConcatArray<...>)[]): number[]; ... 25 more ...; [Symbol.unscopables](): { ...; }; }' is not assignable to type 'Result'.
  Types of property 'values' are incompatible.
    Type '() => IterableIterator<number>' is not assignable to type 'number'.(2322)
```

It could have been something like this:
```
The result of spreading 'values' is not assignable to type 'Result', but a property 'values' exists. Did you mean to use the object shorthand 'values' instead?
```

## 💻 Use Cases

Simplify TS error messages for less-experienced users.
Repository: rust
Issue: “closure references itself” error when it’s not
Labels: A-lifetimes,A-closures,T-compiler,A-inference,C-bug,T-types

I tried this code ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=56b506623c60a91aa4280d8a4a6c0e58)):

```rust
use std::future::Future;

fn hrc<
    R,
    F: for<'a> AsyncClosure<'a, (), R>
        + for<'a> Fn(&'a ()) -> <F as AsyncClosure<'a, (), R>>::Fut,
>(
    f: F,
) -> F {
    f
}

fn main() {
    hrc(|x| async { });
}

trait AsyncClosure<'a, I, R>: Fn(&'a I) -> Self::Fut
where
    I: 'a,
{
    type Fut: Future<Output = R> + Send + 'a;
}

impl<'a, I, R, Fut, F> AsyncClosure<'a, I, R> for F
where
    I: 'a,
    F: Fn(&'a I) -> Fut,
    Fut: Future<Output = R> + Send + 'a,
{
    type Fut = Fut;
}
```

Trying to compile it produces the following error:
```
error[[E0644]](https://doc.rust-lang.org/stable/error-index.html#E0644): closure/generator type that references itself
  --> src/main.rs:14:9
   |
14 |     hrc(|x| async { });
   |         ^^^^^^^^^^^^^ cyclic type of infinite size
   |
   = note: closures cannot capture themselves or take themselves as argument;
           this error may be the result of a recent compiler bug-fix,
           see issue #46062 <https://github.com/rust-lang/rust/issues/46062>
           for more information
```

I’m not sure if it should compile, but the diagnostic is misleading either way: this closure doesn’t have infinite size (in fact, it’s zero-sized), doesn’t capture itself (it captures nothing) and doesn’t take itself as argument (it only takes `()`).

I don’t see a reason why it shouldn’t compile though, since all the types are known without evaluating the recursive bound on `hrc()`.

### Meta

This bug is reproducible on playground on stable, beta and nightly (1.61.0, 1.62.0-beta3 and 1.63.0-nightly (2022-06-02 e71440575c930dcecac2) respectively)

### Links
* #46062 is mentioned in the error description
* The code is trying to work around #70263 for async closures
Repository: transformers
Issue: TFRemBertModelTest.test_resize_token_embeddings not working
Labels: WIP,bug

### System Info

```shell
- `transformers` version: 4.20.0.dev0
- Platform: Windows-10-10.0.22000-SP0
- Python version: 3.9.11
- Huggingface_hub version: 0.5.1
- PyTorch version (GPU?): 1.11.0+cu113 (True)
- Tensorflow version (GPU?): 2.8.0 (True)
- Flax version (CPU?/GPU?/TPU?): not installed (NA)
- Jax version: not installed
- JaxLib version: not installed
- Using GPU in script?: No
- Using distributed or parallel set-up in script?: No
```


### Who can help?

@gante @Rocketknight1 

### Reproduction

`TFRemBertModelTest.test_resize_token_embeddings` has CI failed [here](https://github.com/huggingface/transformers/runs/6682139350?check_suite_focus=true)

This method (called during `resize_token_embeddings`)
https://github.com/huggingface/transformers/blob/028d4b7c8be2c2fc1146fcc1e9bd253c1a7ea346/src/transformers/modeling_tf_utils.py#L1449
assumes that `word_embedding_weight` has the same shape as `old_lm_head_decoder`, but this is not the case for `TFRemBertModel`, as it has `input_embedding_size` and `output_embedding_size` in config.

An PR #17511 was opened, but we decided to not merge it. Instead, a cleaning up of  TF embeddings should be done first.

### Expected behavior

```shell
`resize_token_embeddings` should work for `TFRemBertModelTest`
```