sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: godot
Issue: vslider _gui_input(event: InputEvent) reports old value
Labels: discussion,documentation,topic:gui

**Godot version:**
Godot Engine v3.2.4.rc4.official - https://godotengine.org
OpenGL ES 3.0 Renderer: NVIDIA GeForce GT 650M OpenGL Engine
OpenGL ES Batching: ON
Mac OS X Catalina 10.15.7

**Issue description:**
VSlider reports old value of slider in `_gui_input(event: InputEvent)`  signal

**Steps to reproduce:**

- Open New Scene
- Add a `VSlider` Control
- Add an empty script
- Click on VSlider control and select the Inspector Node Tab
- Connect the _gui_input)_ and _value_changed(() signals to the methods below.
- modify script signal methods as below.
- Run scene

```gdscript
extends VSlider

#This signal is called 1st
func _on_VSlider_gui_input(event: InputEvent) -> void:
	if (event.is_pressed() and event.button_index == BUTTON_LEFT):	
		print("\nClicked")
		print("_gui_input: ",value) # Reports the old slider value

#This signal is called 2nd
func _on_VSlider_value_changed(value: float) -> void:
	print("_value_changed: ",value) # Correctly reports the current slider value

```

When `VSlider` is clicked  `_gui_input()` method reports the original old value, while `_value_changed() `reports the correct new value.  

Example Output:
```
Clicked
_gui_input: 0
_value_changed: 6

Clicked
_gui_input: 6
_value_changed: 1

Clicked
_gui_input: 1
_value_changed: 9
```



Makes the _gui_input() not as useful.

Thanks!
Repository: godot
Issue: [Workflow] Selecting Export Templates close Export Project Window
Labels: topic:editor

**Godot version:**
3.3 RC6

**OS/device including version:**
Win 10 x64

**Issue description:**
When you dont have export templates loaded, and do that from export project window, it closes the export window after loading export templates.

**Steps to reproduce:**


https://user-images.githubusercontent.com/58845030/112329433-f4cca480-8c95-11eb-9015-6eb10d777df2.mp4



after selecting the tpz file, the export window closes:
Repository: terminal
Issue: Epic: Battery Saver Mode
Labels: Help Wanted,Product-Terminal,Area-Quality,Issue-Scenario

_written by @carlos-zamora_

It'd be cool if Windows Terminal could be smart about battery consumption when in Low Power Mode or running on a battery (as opposed to a desktop being plugged in). Here's some ideas on what behavior could change:

- Acrylic ideas:
  - Replace acrylic with mica
  - Disable acrylic / fall back to HostBackdropAcrylic when in low power mode
  - See also #7158 - disable that fix when in battery saver mode
  - also #11092
- Renderer: reduce refresh rate
- [ ] #5318 Cursor: blink less often or don't blink at all 



### Battery saving optimizations we should just do regardless
- [ ] #12706 
- [ ] #1989

Put your ideas below!
Repository: go
Issue: x/build/maintner: doesn't pick the same Change-Id line as Gerrit when a CL commit message contains more than one such line
Labels: help wanted,Builders,NeedsFix

In CL 301589 patch set 3, there were 2 Change-Id lines.

```
[...]
Change-Id: Ia979f971b9bf581b230d7d240ad4068e594eefe0
[...]
Change-Id: I5e1cd3357a5ae202a902060935b99fd1a821ba59
```

In that particular case, Gerrit uses the second one, while maintner picks the first one.

There's a TODO in the code:

```
// TODO: git footers are treated as multimaps. Account for this.
```

It's rare for a CL to have more than one Change-Id line with different IDs, so this doesn't come up often.

CC @golang/release.
Repository: pytorch
Issue: Various issues in derivatives.yaml
Labels: module: autograd,triaged,actionable

While browsing derivatives.yaml to implement forward AD, I found quite a few surprising things there.
We should look into these in detail and update/fix them:

  - [x] remove link to Functions.cpp in derivatives.yaml
  - [x] cummin dedup + extra arg
  - [x] hypot  doc?
  - [x] matrix_exp doc?
  - [x] norm(p=inf) with equal values fw and bw mode
  - [x] renorm backward uses detach??
  - [x] trilinear_backward unroll_dim (https://github.com/pytorch/pytorch/pull/60673)
  - [x] check_no_requires_grad should not run in NoGrad mode (https://github.com/pytorch/pytorch/pull/60740)
  - [x] index.Tensor indices differentiability
  - [ ] native_layer_norm contiguous handling (updated by side effect by #50467 )
  - [x] doc for backward should say vector jacobian (fixed by #60614)

Changes with large blast radius:
  - [ ] Fix the detection of input that should not require grad for missing formulas: [here](https://github.com/pytorch/pytorch/blob/b5b42d4ce2284f6ac6de08f510f92f90bcdd9de7/tools/autograd/gen_variable_type.py#L447) we should return an empty list. A quick check shows that this is breaking A LOT of things.
  - [ ] zeros_like that should not be there according to comment! In particular, we should make distributions return outputs with requires_grad=False consistently 



cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @soulitzer
Repository: vscode
Issue: Notebooks: Clicking empty space should clear selection
Labels: under-discussion,notebook-layout

1. Open a Notebook
2. <kbd>Ctrl A</kbd> to select all rows
3. Click empty space below last row

🐛 Nothing happens

@rebornix Since I can't repro this in other lists, let me know if this is an issue with the list, or whether you're doing some custom click handling.
Repository: pytorch
Issue: Multiple refinement with `isinstance` doesn't work
Labels: oncall: jit,TSRootCause:TypeRefinement

## 🐛 Description

We can use `isinstance` to refine a type like `Any` or `Optional`, which allows us to do schema matching. Although logic for multiple type refinement seems to exist in IR Emitter (example [here](https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/frontend/ir_emitter.cpp#L1682)), it doesn't work in practice.


## Examples

### PASS (single refinement)

```python
import torch
from typing import Any

@torch.jit.script
def fn(x: Any, y: int):
    if isinstance(x, int):
        return x + y
    else:
        return y + y
```

### FAIL (multiple refinement with tuple type)

```python
import torch
from typing import Any

@torch.jit.script
def fn(x: Any, y: int):
    if isinstance(x, (int, float)):
        return x + y
    else:
        return y + y
```

### FAIL (multiple refinement with logical operator)

```python
import torch
from typing import Any

@torch.jit.script
def fn(x: Any, y: int):
    if isinstance(x, int) or isinstance(x, float):
        return x + y
    else:
        return y + y
```

cc @gmagogsfm
Repository: pytorch
Issue: Type refinement with `isinstance` only works with generics
Labels: oncall: jit,TSRootCause:TypeRefinement

## 🐛 Bug

In TorchScript, we can't use `list`, `dict`, etc., but instead have to use `typing.List`, `typing.Dict`, etc. This is more of a problem than it seems, because Python disallows subscripted generics with class and instance checks (in other words, Python ONLY allows `list`, `dict`, etc.).

##  Examples

### TORCHSCRIPT PASS (using `typing.List`)

```python
import torch
from typing import List, Optional

@torch.jit.script
def fn(l: Optional[List[int]]):
    if isinstance(l, List[int]):
        l.append(1)
    return l
```

### PYTHON FAIL (using `typing.List`)
```python
def fn(l: Optional[List[int]]):
    if isinstance(l, list):
        l.append(1)
    return l

print(fn([1, 2]))
```

### TORCHSCRIPT FAIL (using `list`)

```python
import torch
from typing import List, Optional

@torch.jit.script
def fn(l: Optional[List[int]]):
    if isinstance(l, list):
        l.append(1)
    return l
```

##  Note
Using `torch.jit.isinstance` instead of `isinstance` doesn't seem to solve anything

cc @gmagogsfm
Repository: pytorch
Issue: Better documentation for `torch.jit.isinstance`
Labels: oncall: jit,module: docs,docs-hackathon

## 📚 Documentation

Specifically, why should we use [torch.jit.isinstance](https://pytorch.org/docs/master/generated/torch.jit.isinstance.html) instead of Python's `isinstance`? I played around with `torch.jit.isinstance` as part of [another issue I opened](https://github.com/pytorch/pytorch/issues/54598), and it didn't seem to make any difference. I also pulled the example code from the documentation and changed all the `torch.jit.isinstance`s to `isinstance`s; it didn't seem to have an effect there either

cc @brianjo @mruberry @gmagogsfm
Repository: flutter
Issue: popAndPushNamed changes value of widget offset when used with different PageRoute's
Labels: framework,f: routes,has reproducible steps,P2,found in release: 3.7,found in release: 3.10,team-framework,triaged-framework

### Description
I am trying to calculate the position of a widget that is displayed on the screen. I navigate to this screen using `Navigator.popAndPushNamed` method and use a page route such as MaterialPageRoute, CupertinoPageRoute or a PageRouteBuilder inside ``MaterialApp(onGenerateRoute: ...)``

## Steps to reproduce
1. Run the sample from [here](https://github.com/rohansohonee/popAndPushNamed)
2. Tap the buttons for each case i.e popAndPushNamed with MaterialPageRoute, CupertinoPageRoute & PageRouteBuilder
3. Observe and note the offset printed on screen for each case

**Expected results:** The offsets must not differ when using a different page route.
**Actual result:** The offset changes when using different page route.

<details>
<summary>Logs</summary>

```
[√] Flutter (Channel dev, 2.1.0-12.1.pre, on Microsoft Windows [Version 10.0.18363.1443], locale en-IN)
    • Flutter version 2.1.0-12.1.pre at C:\src\flutter
    • Framework revision 8264cb3e8a (2 weeks ago), 2021-03-10 12:37:57 -0800
    • Engine revision 711ab3fda0
    • Dart version 2.13.0 (build 2.13.0-116.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Rohan Sohonee\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (3 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 89.0.4389.90
    • Edge (web)                  • edge          • web-javascript • Microsoft Edge 89.0.774.54

• No issues found!
```

</details>

## Screenshots
<img src="https://user-images.githubusercontent.com/20875177/112348950-50c31780-8cee-11eb-8a6c-094a4065fd3f.png" width=360 height=640/>
<img src="https://user-images.githubusercontent.com/20875177/112348954-51f44480-8cee-11eb-8fcb-c25c5f342965.png" width=360 height=640/>
<img src="https://user-images.githubusercontent.com/20875177/112348956-528cdb00-8cee-11eb-86ee-65b7c8f0d0b6.png" width=360 height=640/>

> NOTE:
The PageRouteBuilder seems to give the correct offset value.
Repository: neovim
Issue: Request new enter event VimEnterPre or VimPluginPost for configuring plugins before buffers are loaded
Labels: enhancement,events


- `nvim --version`: NVIM v0.5.0-dev  (nightly from about a week ago)
- `vim -u DEFAULTS` (version: ) behaves differently? nope
- Operating system/version: NixOS with kernel 5.10
- Terminal name/version: Kitty
- `$TERM`: xterm-kitty

### Actual behaviour
I've recently switched over to Nvim (tried it once before, but this time I think it has stuck), and I've been taking advantage of a number of lua plugins.

A very common pattern in lua plugins is to require configuration by calling a function (e.g. setup()).  In vimrc plugins, configuration is often done be way of a global variable, which isn't great, but doesn't require plugins to be loaded at the time of vim initialization scripts.

Now, the workaround is to just bundle some code that happens on VimEnter, but since VimEnter happens after buffer load, a large number of plugins fail to initialize the initial buffer, requiring additional workarounds (like attaching a colorizer to the current buffer with norcalli/nvim-colorizer.lua, or re-triggering file detection for neovim/nvim-lspconfig).

vim-plug triggers the User event after all plugins are loaded, so this might be useful builtin behavour, or perhaps we could standardize on a place for plugin configuration with a specific event.
Repository: pytorch
Issue: if cannot be symbolically traced
Labels: triaged,module: fx

## 🐛 Bug

`if` conditional cannot be symbolically traced. Related to #44901

## To Reproduce

Steps to reproduce the behavior:

```
import torch

# Simple module for demonstration
class MyModule(torch.nn.Module):
    def __init__(self):
        super().__init__()
        self.param = torch.nn.Parameter(torch.rand(3, 4))
        self.linear = torch.nn.Linear(4, 5)

    def forward(self, batch_idx=None):
        if batch_idx:
            self.randomize(seed=batch_idx)
        return T(0.0)


module = MyModule()

from torch.fx import symbolic_trace

# Symbolic tracing frontend - captures the semantics of the module
symbolic_traced: torch.fx.GraphModule = symbolic_trace(module)

# High-level intermediate representation (IR) - Graph representation
print(symbolic_traced.graph)
```

```
Traceback (most recent call last):
  File "example.py", line 21, in <module>
    symbolic_traced: torch.fx.GraphModule = symbolic_trace(module)
  File "/Users/joseph/opt/miniconda3/lib/python3.8/site-packages/torch/fx/symbolic_trace.py", line 606, in symbolic_trace
    graph = tracer.trace(root, concrete_args)
  File "/Users/joseph/opt/miniconda3/lib/python3.8/site-packages/torch/fx/symbolic_trace.py", line 355, in trace
    self.create_node('output', 'output', (self.create_arg(fn(*args)),), {},
  File "example.py", line 11, in forward
    if batch_idx:
  File "/Users/joseph/opt/miniconda3/lib/python3.8/site-packages/torch/fx/proxy.py", line 164, in __bool__
    return self.tracer.to_bool(self)
  File "/Users/joseph/opt/miniconda3/lib/python3.8/site-packages/torch/fx/proxy.py", line 94, in to_bool
    raise TraceError('symbolically traced variables cannot be used as inputs to control flow')
torch.fx.proxy.TraceError: symbolically traced variables cannot be used as inputs to control flow
```

## Expected behavior

FX graph is printed.

## Environment

 - PyTorch Version (e.g., 1.0): 1.8.0
 - OS (e.g., Linux): OSX
 - How you installed PyTorch (`conda`, `pip`, source): pip3
 - Build command you used (if compiling from source):
 - Python version: 3.8
 - CUDA/cuDNN version: n/a
 - GPU models and configuration: n/a
 - Any other relevant information:


cc @ezyang
Repository: vscode
Issue: when clause contexts for emmet editing
Labels: emmet,under-discussion

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

Emmet commands are often nicer than some of the similar functionality than VSCode's editing, so sometimes you want those keybindings to override the default behavior of VSCode, however those keybindings are useless in files that don't utilize Emmet. eg: Emmet's comment vs vscode's comment.

It would be nice to have a when clause context that can identify when the cursor is in a language supported by emmet. `editorLangId` doesn't accomplish this because it cannot differentiate the cursor being in the HTML section or JS/PHP/etc. section of a Vue/PHP/etc. file. The context could have a boolean to specify if the current code context falls under the `emmet.includeLanguages` and could evaluate to the context.

I could also see a context that specifies the underlying type of the current code being edited could be useful for other cases, though I'm not sure what that would mean. I'd guess it'd be the lowest language-in-a-language for syntax highlighting.
Repository: create-react-app
Issue: [TypeScript] Absolute imports inside symlinked folder doesn't work when consumed in client folder
Labels: needs triage

hello! i have a shared project folder that is symlinked in my client project folder. both project folders have typescript files but the shared project folder doesn't have "transpiled" ts files. (i don't know if that makes sense). Now, I am importing the "untranspiled" .ts/tsx files from the shared project folder to my client folder using `craco` and `ts-loader` to allow imports of "untranspiled" files outside the client's `src` folder. The structure is like this:
```
shared/
  services/
    authentication/
      index.ts
  store/
    authentication/
      index.ts
```
```ts
// shared/store/authentication/index.ts

import { loginWithEmailAndPassword } from "services/authentication";
```
Now, in my client folder, I am receiving this error:
```
Module not found: Can't resolve 'services/authentication' in '/Users/<username>/shared/store/authentication'
```
But if I use relative import inside my `shared/store/authentication/index.ts`, like this:
```ts
// shared/store/authentication/index.ts

import { loginWithEmailAndPassword } from "../../services/authentication";
```
it works just fine.

I think it is because my client project folder thinks that the `services/authentication` is in `node_modules` not in `node_modules/shared/`

Anyone knows how to fix this? Thanks!
Repository: pytorch
Issue: Exceptions thrown in JIT interpreter always are translated into RuntimeError
Labels: oncall: jit

The cause of this is this code in `torch/csrc/jit/runtime/interpreter.cpp`:

```

  void handleError(const ExceptionMessage& msg, bool is_jit_exception) {
    std::ostringstream ss;
    ss << "The following operation failed in the TorchScript interpreter.\n";
    formatStackTrace(ss);
    ss << "RuntimeError: " << msg << "\n";
    if (future_) {
      future_->setError(std::make_exception_ptr(Future::FutureError(ss.str())));
    } else if (is_jit_exception) {
      throw JITException(ss.str());
    } else {
      throw std::runtime_error(ss.str());
    }
  }
```

The rethrowing as a fresh `std::runtime_error` means that you lose c10::Error subclassness, and therefore lose any extra information about which exception should be thrown. I think this can probably be fixed by taking advantage of the context field in c10::Error objects, though maybe without wobbling the error reporting format.

cc @gmagogsfm
Repository: pytorch
Issue: Dispatcher TLS to bypass loads of dispatch key from tensor arguments
Labels: module: performance,triaged,enhancement,module: dispatch

@ailzhang recently wrote in https://github.com/pytorch/rfcs/pull/17 about how, after the introduction of InplaceOrView key, we are tantalizingly close to removing the Autograd key from tensors with `requires_grad=False`. However, the main problem is this:

> If requires_grad=False skips VariableType kernel, functional ops won't be able to go through AutoDispatchBelowInplaceOrView guard which suppresses both autograd and InplaceOrView keys in TLS excluded. Not suppressing InplaceOrView key means unnecessary calls to as_view/increment_version if any view/inplace ops are used in the kernel implementation which adds a lot of overhead. To avoid overhead, instead of fallthrough kerenl being backend fallback, we'll want to use a real kernel that suppresses InplaceOrView key. But compared to the current implementation which only adds an extra dispatch for view/inplace ops, it forces all functional ops to have an extra dispatch as well. That's why it's blocked.

I was thinking about ways around this problem and realized that an old proposal (that I am on the record as not liking--sorry, I don't remember who first proposed it, perhaps it was @bhosmer) could help solve this problem.

The proposal was that once you get to a "backend" kernel, you probably only want to ever stay dispatching in that kernel (for example, you don't want to skip back to InplaceOrView). So there should be some TLS flag that, when set, bypasses argument checking; instead, we always dispatch to the dispatch key stored in the TLS. This flag would be set on entry to backend kernels (via the code generated wrappers that also take care of things like device guard). This now solves Ailing's problem as we now can bypass those view/increment_version operations.

One thing that I'm still a little uncomfortable about is that we have to be *absolutely absolutely* certain that we're never going to want to pop out somewhere else inside a backend implementation; it would be pretty awkward if occasionally this is something we needed to do. And of course, the other downside is we're adding an extra unconditional branch on the dispatcher path (I'm not even sure the branch is easy to predict).

cc @VitalyFedyunin @ngimel
Repository: flutter
Issue: No option to unload already loaded fonts using FontLoader class
Labels: c: new feature,framework,engine,a: typography,P3,team-engine,triaged-engine

FontLoader has only method to load fonts. There is no option to unload already loaded fonts.
Repository: bitcoin
Issue: Use sigstore software transparency for releases
Labels: Brainstorming,Build system

[Sigstore](https://sigstore.dev/what_is_sigstore/) is an initiative by the Linux Foundation for software supply chain security. The goal is to be able to verify the origin of binaries as well as to ensure software transparency, so to be able to verify that you downloaded the same binary as everyone else. Of course we already sign our releases, but the latter seems important.

The implementation is under development and available as open source. However the system is not live yet (as of 2021-03-24, there is a [public instance](https://github.com/sigstore/rekor#public-instance) test server but they warn it will get wiped).

But I think as soon as it does go into production use, we should try to use it for our releases.
Repository: go
Issue: x/tools/go/packages: Unexpected package creation during export data loading
Labels: NeedsInvestigation,Tools

### What version of Go are you using (`go version`)?

<pre>
go version go1.16.2 darwin/amd64
</pre>

### Does this issue reproduce with the latest release?

Yes.  Both on v0.1.0 and on master.

### What did you do?

Load types for a package that has gc export data available.  `runtime` is such a package on my system:

```packages.Load(&packages.Config{Mode: packages.NeedTypes}, "runtime")```

https://play.golang.org/p/ObXs_fKb0A2

### What did you expect to see?

Nothing, success.

### What did you see instead?

A fatal error is logged: `Unexpected package creation during export data loading`

I debugged the error and found a workaround:  Include `packages.NeedImports` in `Config.Mode`.