sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: x/build/app/appengine: make leftmost column fixed & not scroll horizontally
Labels: help wanted,Builders,NeedsFix,FeatureRequest

I'd like the https://build.golang.org leftmost column to stay on the screen when I scroll the page horizontally.

It's hard to see what broke something when you're scrolling far to the right...
<img width="1185" alt="Screen Shot 2019-05-23 at 10 22 48 AM" src="https://user-images.githubusercontent.com/2621/58273130-e08b8980-7d44-11e9-977c-a5c062c5f446.png">

...

<img width="1191" alt="Screen Shot 2019-05-23 at 10 22 57 AM" src="https://user-images.githubusercontent.com/2621/58273139-e4b7a700-7d44-11e9-8f97-95ed904e833b.png">

/cc @andybons @dmitshur
Repository: terminal
Issue: Some warnings aren't turned on
Labels: Help Wanted,Product-Meta,Issue-Task,Area-CodeHealth

It looks like there's some warnings that are [turned off by default](https://docs.microsoft.com/en-us/cpp/preprocessor/compiler-warnings-that-are-off-by-default?view=vs-2019). We should enable these and fix any instances of the warnings triggering as necessary.
Repository: flutter
Issue: flutter_tools/test/src/context.dart has non-mock "Mock*" classes
Labels: a: tests,team,tool,P3,team-tool,triaged-tool

There are various classes in context.dart that are called `Mock*` but are not actually mocks. It seems random, and possibly just an oversight. For instance:
  `class MockXcodeProjectInterpreter implements XcodeProjectInterpreter`
but
  `class MockIOSSimulatorUtils extends Mock implements IOSSimulatorUtils`
This is bug number 1.

It looks like they are intended for use in the default `testUsingContext`, but are public (I would argue that being public is bug number 2).

Taking the `MockXcodeProjectInterpreter` example, test files that actually want to mock that class have:
`class MockXcodeProjectInterpreter extends Mock implements XcodeProjectInterpreter {}`
This shadows the version in context.dart (bug number 3).

When you put all this together, you end up with the very surprising behavior that if you take a working test using a local `MockXcodeProjectInterpreter` and move it to a new file, but neglect to add a local override in that new file, everything compiles just fine and you get mysterious `Mock method was not called within 'when()'` errors and waste a lot of time trying to figure out what's going on.

I would argue that at a minimum
1) Classes named `Mock*` need to be `Mock` objects.
2) context.dart shouldn't be vending objects that are being silently shadowed in test files.
Repository: TypeScript
Issue: Generic interface callback return type validation issue
Labels: Needs Investigation

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the *entire* template below.
-->

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->

**TypeScript Version:** Version 3.5.0-dev.20190523

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->

**Search Terms:**

union callback function flatMap overload

**Code**

```ts
interface I<A> {
  foo<B>(f: (a: A) => B | I<B>): I<B>;
}

class C<A> implements I<A> {
  constructor(readonly a: A) {}

  public foo<B>(f: (a: A) => B | C<B>): C<B> {
    const b: B | C<B> = f(this.a);
    if (b instanceof C) {
      return b;
    }

    return new C(b);
  }
}
```

**Expected behavior:**

I expect that the example passes the type check without any errors based on the following assumptions: `C<A>` implements `I<A>` thus the return of `C<A>.foo` including `f: (a: A) => B | C<B>` matches the types declared in `I<A>.foo`.

Side Note: The interface of `foo` is similar to `Array.flatMap`.

**Actual behavior:**

I get the following type error for `C<A>.foo`:

```text
  Property 'foo' in type 'C<A>' is not assignable to the same property in base type 'I<A>'.
  Type '<B>(f: (a: A) => B | C<B>) => C<B>' is not assignable to type '<B>(f: (a: A) => B | I<B>) => I<B>'.
    Type 'C<B | I<B>>' is not assignable to type 'I<B>'.
      Types of property 'foo' are incompatible.
        Type '<B>(f: (a: B | I<B>) => B | C<B>) => C<B>' is not assignable to type '<B>(f: (a: B) => B | I<B>) => I<B>'.
          Types of parameters 'f' and 'f' are incompatible.
            Types of parameters 'a' and 'a' are incompatible.
              Type 'B | I<B>' is not assignable to type 'B'.
                Type 'I<B>' is not assignable to type 'B'.ts(2416)
```

I don

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->

https://codesandbox.io/s/hopeful-kirch-571v7?fontsize=14&module=%2Fsrc%2Findex.ts&view=editor

**Related Issues:** <!-- Did you find other bugs that looked similar? -->

**Workaround:**

One can workaround this issue using function overloading instead of a union return for the callback.

```ts
interface I<A> {
  foo<B>(f: (a: A) => B): I<B>;
  foo<B>(f: (a: A) => I<B>): I<B>;
}
```
Repository: vscode
Issue: Add "type" to textDocument/references results (icon, filtering)
Labels: feature-request,api,editor-symbols

The C/C++ extension wants to be able to send back references of different types that users can determine what "type" of reference it is and filter out unwanted types -- in order to provide functionality equivalent to Visual Studio 2019. The types are

1. Confirmed reference (i.e. passes semantic checking): reference icon
2. Not a reference (i.e. has the same name, but fails semantic checking): cancel icon
3. Reference in a comment: comment icon
4. Reference in a string: string icon
5. Reference in an inactive (preprocessor) region: ? icon (or a better one, since it conflicts with 7)
6. Possible reference (Confirmation in progress): progress icon?
7. Possible reference (Confirmation canceled): ? icon (or a better one, since it conflicts with 5 and 7) -- this "type" doesn't exist in VS, but it seems like it should (at least for us).
8. Cannot confirm reference (due to some bug or "by design" limitation): ? icon

This is the screenshot from VS:

![image](https://user-images.githubusercontent.com/19859882/58290846-02e6cc80-7d70-11e9-817a-073adcc50bfb.png)

Our current "workaround" is to only send back Confirmed References (number 1), although we also plan to have some progress UI with a button that allows users to view the Confirmation in progress (number 6 items, merged in with number 1 items). We're currently implementing this for June: https://github.com/microsoft/vscode-cpptools/issues/15 .

The relevant LSP that would need to be changed is at
https://microsoft.github.io/language-server-protocol/specification#textDocument_references
Repository: TypeScript
Issue: Encapsulate type refactoring
Labels: Suggestion,Awaiting More Feedback,Domain: Refactorings

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.

-->

## Search Terms
- refactoring
- encapsulate
- return, function

## Suggestion
Add a refactoring that encapsulates a given instance of a type and updates uses of it. Encapsulating would wrap the type in an object type that has a single property of that type.

## Use cases
My original use case would be to convert a single returned type to an object that can return multiple values:

1.  Start
    ```ts
    function foo(): number { return Date.now(); }
    const z = foo(); 
    ```
1. Select `number` and run `encapsulate`
1. Result
    ```ts
    function foo(): { value: number } { return { value: Date.now() }; }
    const z = foo().value; 
    ```

This could also be used for individual parameters in a function:

1. Start
    ```ts
    function foo(x: number) { return x * 2; }
    foo(1);
    ```
1. Select `number` and run `encapsulate`
1. Result
    ```ts
    function foo(x: { value: number }) { return x.value * 2; }
    foo({ value: 1 });
    ```

This may fall under some larger class of refactoring, I'm just not sure what to call it
Repository: go
Issue: cmd/link: TestDWARF*/testprog is flaky on darwin/amd64
Labels: Testing,OS-Darwin,NeedsInvestigation

At b84e0bc61a, on darwin/amd64:

```
$ go test -run=TestDWARF/testprog -count=10 cmd/link
--- FAIL: TestDWARFiOS (0.53s)
    --- FAIL: TestDWARFiOS/testprog#03 (2.03s)
        dwarf_test.go:96: exit status 255
--- FAIL: TestDWARFiOS (0.50s)
    --- FAIL: TestDWARFiOS/testprog#03 (1.78s)
        dwarf_test.go:96: exit status 255
--- FAIL: TestDWARFiOS (0.52s)
    --- FAIL: TestDWARFiOS/testprog#03 (1.96s)
        dwarf_test.go:96: exit status 255
--- FAIL: TestDWARFiOS (0.54s)
    --- FAIL: TestDWARFiOS/testprog#03 (1.83s)
        dwarf_test.go:96: exit status 255
--- FAIL: TestDWARFiOS (0.53s)
    --- FAIL: TestDWARFiOS/testprog#03 (1.98s)
        dwarf_test.go:96: exit status 255
--- FAIL: TestDWARFiOS (0.54s)
    --- FAIL: TestDWARFiOS/testprog#02 (1.99s)
        dwarf_test.go:96: exit status 255
FAIL
FAIL	cmd/link	47.577s
FAIL
```

I've also seen

```
--- FAIL: TestDWARF (0.22s)
    --- FAIL: TestDWARF/testprog (3.00s)
        dwarf_test.go:96: exit status 255
FAIL
```

The failures are intermittent.

cc @dr2chase
Repository: flutter
Issue: Create a bug report mechanism for add-to-app
Labels: tool,a: existing-apps,a: triage improvements,P3,team-tool,triaged-tool

Potentially interesting to dump logcat/console and file structure of the projects. Gradle, xcodeproj, Podfile etc.
Repository: three.js
Issue: THREE.FBXLoader: 3dsMax|maps|texmap_diffuse map is not supported in three.js, skipping texture
Labels: Loaders

##### Description of the problem

When attempting to load the FBX file contained within the example below, we are seeing the following error:

` 
THREE.FBXLoader: 3dsMax|maps|texmap_diffuse map is not supported in three.js, skipping texture
`
`THREE.FBXLoader: unknown material type "unknown". Defaulting to MeshPhongMaterial`

Causing Mapping Failure。


##### Three.js version

- [ ] Dev
- [x] r105
- [ ] ...

##### Browser

- [ ] All of them
- [x] Chrome
- [ ] Firefox
- [ ] Internet Explorer

##### OS

- [ ] All of them
- [ ] Windows
- [x] macOS
- [ ] Linux
- [ ] Android
- [ ] iOS

##### Hardware Requirements (graphics card, VR Device, ...)
Repository: go
Issue: cmd/pprof: proportionally account CPU time spent in GC to the allocating frames
Labels: NeedsInvestigation,FeatureRequest,compiler/runtime

When troubleshooting CPU usage of production services it would be useful to have an **_option_**, at least in the flamegraph/dot visualization, to proportionally assign the CPU time spent in GC to the frames that cause heap allocations.

Currently the way I do is take both CPU and memory allocation profiles, and then "mentally account" proportional GC CPU time based on which frames are actually causing allocations.

If pprof were to offer this option, such a proportional assignment would not have to be extremely precise: for my purposes, it would be OK even if it was based on an estimation of the amount of memory that is allocated.

Similarly, it would not be required to show how time is spent *inside* the runtime when this option is enabled. The rationale for this is that when I'm tracking down excessive GC CPU usage, I normally don't expect to be hitting a GC bug, but rather excessive allocations in my code. Also, I guess, it would make the implementation of this option much easier.

The way I imagine this could work in the flamegraph would be by having an additional "virtual" single-level stack frame as a child of each one of the frames that are performing heap allocations; the virtual stack frame would be called something like "GC (estimated)". In the graphviz output there would be a single virtual GC node, with its CPU time proportionally assigned to the incoming edges coming from frames that allocate.

I don't have strong opinions about whether GC assist time (if any) should be included in the virtual GC stack-frame, or kept separate.
Repository: go
Issue: cmd/pprof: account CPU and allocations of goroutines to the frame where they are created
Labels: NeedsInvestigation,FeatureRequest,compiler/runtime

When troubleshooting CPU usage of production services it would be useful to have an **_option_**, at least in the flamegraph visualization, to account the CPU time and memory allocations of a goroutine to the frame that created the goroutine.

Currently, the way I do this is take a CPU or memory profile, and then go through the code to reconstruct where goroutines were created, so that I can then proceed to identify the full stacktrace that lead to excessive CPU or memory usage.

The way I imagine this could work in the flamegraph would be by considering stack traces to include not just the the stack of the goroutine, but also the transitive stacks of the goroutines that created the current goroutine (up to a maximum limit that - if reached - would cause the option to be disabled).

Currently AFAIK this would be hard to do as described as we only record the PC of where the goroutine is created. I am not knowledgeable enough to know if there are some other ways to do (now, or in the future) what I described above; if such a way existed it would make profiling much more effective and easier to use when dealing with large codebases that are `go`-happy.
Repository: terminal
Issue: adjust associative containers to support heterogeneous lookup
Labels: Help Wanted,Product-Terminal,Issue-Task,Area-CodeHealth

[Heterogeneous lookup](https://en.wikipedia.org/wiki/C%2B%2B14#Heterogeneous_lookup_in_associative_containers) has been supported since C++14. To quote the linked article,

>C++14 allows the lookup to be done via an arbitrary type, so long as the comparison operator can compare that type with the actual key type. This would allow a map from `std::string` to some value to compare against a `const char*` or any other type for which an `operator<` overload is available. It is also useful for indexing composite objects in a `std::set` by the value of a single member without forcing the user of `find` to create a dummy object (for example creating an entire `struct Person` to find a person by name). 

Now, it's _magic_ in that you enable it by specifying `std::less<>` as the third template argument to an associative container; that is:

```c++
std::map<std::string, std::string             > map1;
std::map<std::string, std::string, std::less<>> map2;
```

`map2` supports heterogeneous lookup, whereas `map1` does not.
Repository: angular
Issue: ngmodelOptions.updateon: 'blur' and input onblur event updating model value only for the first time
Labels: type: bug/fix,freq3: high,area: forms,state: confirmed,forms: ngModel,P3

I have a textbox which has ngModel, ngModelOptions(updateOn: 'blur') and it has onblur event handler. Now i am validating input value on blur event callback and if the value is less than 100 i will show error message and i will empty the text box value.

Issue: If I enter the value lessthan 100 then the textbox value is clearing properly only for the first time. From second time onwards the value is not emptied.

for example: enter 12 in input box and blur the input box we are getting the error message and it is lessthan 100 so value is set to empty(""). Now, i remove the 12 in input box and entered 55 this time the error message is showing up but the value is not clearing. It is showing the previous value.

Note: I tried to trigger angular change detection(detechChanges()) on blur event(after setting value to empty) even though the value is not clearing second time onwards.

can you please have a look at the stackblitz link(https://stackblitz.com/edit/angular-oyzcf8?file=src/app/app.component.ts) and let me know if there is anything I am missing here. Thanks
Repository: TypeScript
Issue: Allow identifying readonly properties in mapped types
Labels: Suggestion,Awaiting More Feedback

## Search Terms

Pretty much the ones in the title...

## Suggestion

Any TypeScript modifier should be allowed to be easily identified in mapped types. In particular, `readonly` should, but possibly others too, such as `?`.

## Use Cases

Define mapped types where the values depend on whether the property is readonly or not. At the moment, the following madness is necessary for this:

```ts
 type Or<A extends boolean, B extends boolean> = A extends true
    ? true
    : B extends true
        ? true
        : false

type Equals<X, Y> =
    (<T> () => T extends X ? 1 : 2) extends
        (<T> () => T extends Y ? 1 : 2)
            ? true
            : false

type IsReadonly<O extends Record<any, any>, P extends keyof O> =
    Not<Equals<{[_ in P]: O[P]}, {-readonly [_ in P]: O[P]}>>
```

I would like to see some syntactic sugar similar to (not intended to be a full implementation):

```ts
type Writable<T> = {
    [P in keyof T]: isreadonly T[P] ? never : T[P]
}
```

In my case, I would like to define a hyperscript-style function which accepts a series of attributes for the creation of HTML elements. For this, I reuse the interfaces that TypeScript defines, such as `HTMLAnchorElement`, but obviously readonly properties (among others) need to be excluded.

Other people seem to have similar use cases, e.g. https://stackoverflow.com/questions/52443276/how-to-exclude-getter-only-properties-from-type-in-typescript

## Checklist

My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Repository: rust
Issue: Some tests fail when built with debuginfo
Labels: A-testsuite,A-debuginfo,A-codegen,T-compiler

Discovered while working on https://github.com/rust-lang/rust/pull/60568.

The lists of failing tests are below, testing was done on `x86_64-pc-windows-gnu` target.
Repository: flutter
Issue: Some suggestions on Texture Widget.
Labels: c: new feature,framework,a: video,c: proposal,P3,team-framework,triaged-framework

Hello!When I use texture widget to implement video rendering, I found that flutter native framework only provide `copyPixelBuffer` to receive CVPixelBuffer on iOS.

When the texture widget 's aspect radio is not equal to the CVPixelBuffer 's aspect radio, The image in the texture will be extend.So, I hope that flutter native api could provide a new api to control its fit, such as input view's width , view's height and rendering mode(scale to fill, scale to fit or extend). 

About rendering mode:
1. scale to fill: The aspect ratio of the image is adjusted to the aspect ratio of the view by scaling and cropping

2.scale to fit: The aspect ratio of the image is adjusted to the aspect ratio of the view by filling in the black edges

3. extend: No special operations.
Repository: create-react-app
Issue: Chrome Framework Fund Proposal Umbrella
Labels: issue: proposal

This issue is part of our application for the Chrome Framework Fund: https://docs.google.com/forms/d/e/1FAIpQLSdwM-2Xw-HXa5fqT8MsGW7AsMv9KC1VEoprJtXxrwdH9_Q1_Q/viewform

There are a number of performance related improvements we can make in Create React App. We'll collect them here and add to this list as we think of more.

## Proposed Improvements
* Modern build mode with module/nomodule - #4964
* Better performance budget reporting
* Encourage/demonstrate route-based code splitting in default template
* Upgrade to webpack 5
* Improve service worker and other PWA features (possibly by creating a dedicated template for PWAs)
Repository: terminal
Issue: Validate that VT adapter tests cover all mock possibilities
Labels: Product-Conhost,Help Wanted,Area-VT,Issue-Task,Area-CodeHealth

All of the various mock definitions don't seem to be in use. When I stood up the original parser years ago and wrote the mock, every mock was checked somehow. Over time, it probably decayed and the only thing left is that the mock has to be implemented to satisfy compilation of the interface. 

_Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/891/review_comment/create_


The goal here would be to run through all the tests and ensure that the mocks are involved somehow in each operation to validate that we're getting what we expect back through the adapter interface for all potential results.
Repository: go
Issue: cmd/go: automatically tidy go.sum
Labels: NeedsInvestigation,modules

Now that we can authenticate new entries in go.sum,
there is less concern about keeping old ones around
that are not part of the current module graph.
If we update go.mod from v0.1.0 to v0.2.0 of a module
and v0.1.0 is no longer referenced in the build graph,
we should probably drop v0.1.0 from the go.sum.

Not sure about Go 1.13 vs Go 1.14.
Depends on how much work it is.
Repository: terminal
Issue: Panes should be resizable with the mouse
Labels: Help Wanted,Area-UserInterface,Product-Terminal,Issue-Task,In-PR,Priority-2

Probably depends on #991 getting done first

Drag a separator to (recursively) resize the panes that are separated by that separator.
Repository: flutter
Issue: flutter tool should output subprocess stdout/stderr on command failure
Labels: tool,c: proposal,P3,team-tool,triaged-tool

If installing an app on iOS fails, this is what you currently see:

```
Launching catalog/app/lib/main.dart on iphone_7plus in debug mode...
Error launching application on iphone_7plus.
```

User would need to know to run the command with `-v` to get the full trace output to see the actual error message from the installer.

Could we look at the RunResult and print the process output if the command was not successful? (or at the very least, print a message to tell the user to run the command with `-v` to see failures). https://github.com/flutter/flutter/blob/a30ffb60adf2d33f930bc3d5bcdfb3647f8349aa/packages/flutter_tools/lib/src/base/process.dart#L238
Repository: rust
Issue: no method named `join` found for type `&[std::ffi::OsString]`
Labels: A-FFI,T-libs-api,C-feature-request

I think join should be implemented for arrays of OsString.

@alexcrichton implements something similar here:
https://github.com/alexcrichton/cc-rs/blob/master/src/lib.rs#L2269

Would be nice if that code would be just `self.args.join(' ')`
Repository: pytorch
Issue: torch.full_like missing documentation for out input variable
Labels: module: docs,triaged

## 📚 Documentation
https://pytorch.org/docs/stable/torch.html#torch.full_like

The behavior when the out tensor does not match type or device of input tensor is not obvious.