sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: kubernetes
Issue: Deduplicate Sync type delta in DeltaFIFO
Labels: sig/api-machinery,kind/feature,triage/accepted

### What would you like to be added?

# purpose
Currently, there is only deletions will be deduplicated in DeltaFIFO.

Here, we propose that `sync deltas` should also be deduplicated in DeltaFIFO. 

Following is the example of current & desired impl:

# current impl
In DeltaFIFO Items, for ObjA, there are two scenarios (suppose that there is no Delata with ObjA in Items before)：
1. if `Update delta` arrived after resync process finished, then:
```
Items
key: objA-key | Deltas: <Sync, objA1>,<Updated,objA2>
```
2. but if `Update delta` arrived just before resync process, then there is:
```
Items
key: objA-key | Deltas: <Updated,objA2>
```
Since, if there is already corresponding Obj in DeltaFIFO(Items), then during this resync process, the <Sync,Obj> Delta will not be put into Deltas.

# Desired impl
For above two scenarios, no matter that `Updated Delta` is arrived before or after `Sync Delta`, as long as the two deltas are adjacent, the final processing result should be:
 ```
Items
key: objA-key | Deltas: <Updated,objA2>
```

# All the case
For following cases, the sync delta will be deduplicated.
```
Items
1. key: objA-key | Deltas: <Sync, objA1>,<Updated,objA2>
2. key: objA-key | Deltas: <Sync, objA1>,<Deleted,objA2>
3. key: objA-key | Deltas: <Sync, objA1>,<Replaced,objA2>
4. key: objA-key | Deltas: <Sync, objA1>,<Sync,objA2>
```
above cases will be deduplicated like:
 ```
Items
key: objA-key | Deltas: <Updated,objA2>
key: objA-key | Deltas: <Deleted,objA2>
key: objA-key | Deltas: <Replaced,objA2>
key: objA-key | Deltas: <Sync,objA2>
```

Note: 
1. there is no chance that `Added Delta` shows just after `Sync Delta`, if it is, then there must be a `Deleted Delta` between them 
2. There are two `Sync Delta` adjacent, since maybe the process of relist happened right after resync process.  

### Why is this needed?

The goal why we propose this idea is reducing the meaningless delta in DeltaFIFO, which could reduce the times that `HandleDeltas` propagates the delta to all the listeners.

For the
Repository: rust
Issue: Printing of types expands type aliases, but does not avoid naming collisions of lifetimes that can thus occur in HRTs
Labels: A-diagnostics,T-compiler

Follow-up to #101280, which has been fixed in #101996, but that issue only explicitly addressed the case when the name was *chosen by the compiler*.

We can also get cases where all names are user-provided. E.g.
```rs
use std::cell::Cell;
type Ty1 = for<'r> fn(Cell<(&'r i32, &'r i32)>);
type Ty2<'a> = for<'r> fn(Cell<(&'a i32, &'r i32)>);
fn f<'r>(f: Ty1) -> Ty2<'r> {
    f
}
```
```
error[E0308]: mismatched types
 --> src/main.rs:9:5
  |
8 | fn f<'r>(f: Ty1) -> Ty2<'r> {
  |                     ------- expected `for<'r> fn(Cell<(&'r i32, &'r i32)>)` because of return type
9 |     f
  |     ^ one type is more general than the other
  |
  = note: expected fn pointer `for<'r> fn(Cell<(&'r i32, &'r i32)>)`
             found fn pointer `for<'r> fn(Cell<(&'r i32, &'r i32)>)`
```

---

I would expect the compiler to rename the bound variable in this case, e.g.
```
8 | fn f<'r>(f: Ty1) -> Ty2<'r> {
  |                     ------- expected `for<'r1> fn(Cell<(&'r i32, &'r1 i32)>)` because of return type
```
```
  = note: expected fn pointer `for<'r1> fn(Cell<(&'r i32, &'r1 i32)>)`
             found fn pointer `for<'r1> fn(Cell<(&'r1 i32, &'r1 i32)>)`
```

It might make sense to conservatively do such renaming in *all cases* where a lifetime of the same name is in scope, in the spirit of why [using such a HRT *directly*](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9efa149642abb5b988a83e7c9facdc0e) (without type alias) is [a compilation error](https://doc.rust-lang.org/nightly/error_codes/E0496.html). This is why in the suggested fix for the concrete error message above, the type `for<'r1> fn(Cell<(&'r1 i32, &'r1 i32)>)` has had its bound lifetime renamed, too.

It also seems reasonable to base the new name on the old one in some manner, as user-chosen names can be conveying useful information. Adding trailing numbers seems reasonable, but other approaches might be good, too. Of course, the idea when adding a number is that if a name `'r1` was already in scope, too, then `'r2` or `'r3`, etc… would be chosen. I’m not sure if there’s precedent of choosing new names based on existing ones in the compiler. If the approach of adding a trailing number is chosen, then there’s the case to consider where the name already has a trailing number, in which case, either an *additional* number could be added, perhaps with underscore separation, or the existing number could be incremented. E.g. if the user named the lifetime `'r42`, a new name could be `'r42_1` or `'r_43` or `'r1` (provided it’s still available).

---

cc @b-naber

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"b-naber"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
Repository: PowerToys
Issue: PowerToys Run - Code Workspaces for other IDEs
Labels: Needs-Triage

### Description of the new feature / enhancement

I really like the feature to open a project with VS Code, however i do not use VS Code as my primary ide. 

I propose a feature where you can define a command, "Direct activation command" and "context option", like "Project folder", eg.
Command: rider .
Direct activation command: }
context option: Project folder

If i type "} dotnet Test app", PowerToys Run will run the command ```cd "c:\source\dotnet Test app"; rider .``` 

I am not a native English speaker, if you need clarification i will happily answer 

### Scenario when this would be used?

Open projects in other IDEs than VS Code  

### Supporting information

_No response_
Repository: storybook
Issue: ERR! SassError: expected "{"
Labels: bug,theming

I am getting the following error when I do `nx build-storybook @my-project-name`:

```
ERR! => Failed to build the preview
ERR! Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
ERR! SassError: expected "{".
ERR!   ╷
ERR! 2 │       import API from "!../../../../../node_modules/@nrwl/web/node_modules/style-loader/dist/runtime/injectStylesIntoStyleTag.js";
```

I am working with `nx` on the [default storybook configuration](https://nx.dev/packages/storybook) for workspace. 
This started to happen when we imported some global `.scss`

My `.storybook/main.js`
```
module.exports = {
  stories: [],
  addons: ['@storybook/addon-essentials', "@storybook/preset-scss"]
}
```

My `frontend/<my-project-name>/.storybook/main.js`
```
const rootMain = require('../../../.storybook/main')

module.exports = {
  ...rootMain,

  core: { ...rootMain.core, builder: 'webpack5' },

  stories: [
    ...rootMain.stories,
    '../../<my-project-name>/lib/**/*.stories.mdx',
    '../../<my-project-name>/lib/**/*.stories.@(js|jsx|ts|tsx)'
  ],
  addons: [...rootMain.addons, '@nrwl/react/plugins/storybook']
}
```

My nx report
```
   Node : 16.14.2
   OS   : darwin x64
   yarn : 1.22.19
   
   nx : 14.5.2
   @nrwl/angular : Not Found
   @nrwl/cypress : 14.5.2
   @nrwl/detox : Not Found
   @nrwl/devkit : 14.5.2
   @nrwl/eslint-plugin-nx : 14.5.2
   @nrwl/express : Not Found
   @nrwl/jest : 14.5.2
   @nrwl/js : 14.5.2
   @nrwl/linter : 14.5.2
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : 14.3.0
   @nrwl/nx-plugin : Not Found
   @nrwl/react : 14.5.2
   @nrwl/react-native : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : 14.5.2
   @nrwl/web : 14.5.2
   @nrwl/workspace : 14.5.2
   typescript : 4.4.2
   ---------------------------------------

```
This repo https://github.com/mandarini/sb-scss-bug has been created to showcase a similar issue.
Note. This issue was initially posted [here](https://github.com/nrwl/nx/issues/12175).

Can you please give suggestions / support?

Thanks.
Repository: vscode
Issue: SCM - Add action to collapse all resource groups for a repository
Labels: feature-request,scm

When all changed files are available under source control, if the user chooses to "View as Tree" a collapse all button should be available for the user to collapse all the tree directory structures, same as provided in explorer to collapse all the tree structures in the view.

Request to make available collapse all button here:
<img width="419" alt="image" src="https://user-images.githubusercontent.com/68489729/192488519-140ab9e6-9d7d-4a78-9a20-95b785f9b34b.png">

Example collapse all button available under explorer:
<img width="442" alt="image" src="https://user-images.githubusercontent.com/68489729/192488791-ab1a8fa1-b7c5-4a09-afbd-f1747aa82d24.png">
Repository: node
Issue: Error running tests on HEAD
Labels: net,test

### Version

v19.0.0-pre, ref-parse HEAD: 87b9a77290cd8727936ef15ea7f460519f8d91f5 

### Platform

Linux xavier-laptop 5.15.0-48-generic #54-Ubuntu SMP Fri Aug 26 13:26:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

### Subsystem

tests

### What steps will reproduce the bug?

I simply forked node, cloned it and then followed the BUILDING.md, respectively:
```
$ sudo apt-get install python3 g++ make python3-pip
$ ./configure
$ make -j4
drink coffee
$ make test-only
```

### How often does it reproduce? Is there a required condition?

Always

### What is the expected behavior?

All tests should be successfull

### What do you see instead?

Some annoying failed tests, logs can be seen here: https://pastebin.com/101XRfEZ

### Additional information
My `/etc/hosts` contains a line for localhost:
```
127.0.0.1	localhost
```

I tought that the `ENOTFOUND` was caused by network condition for some reason, but the failed tests are persisting through company network, home network and mobile network, so...

The error is not related to batch-execution of tests as if I run it directly with the command, it fails anyway:
```
out/Release/node /data/xavier/contribs/node/test/parallel/test-net-socket-connect-without-cb.js
```
I assume it's the case for other failing tests.
Repository: godot
Issue: No exit crossfade for one shot animation when using state machine as shot
Labels: bug,topic:animation

### Godot version

4.0 beta

### System information

Vulkan

### Issue description

When playing an animation for `animation tree` - `one shot` node with `state machine` plugged into `shot` input, it will not have smooth transition on exit, animation will jump instantly to previous state without crossfade, no matter how the fade setting on one `shot node` is set. It's no present when plugging the `animation` alone to `one shot`.
Setting the fade time on `End` node didn't help, it only introduced additional issue with playback starting.

One shot with alone node:

https://user-images.githubusercontent.com/45795134/192518443-a5ea0048-b2df-48c8-9cbe-a9a3df208c0b.mp4

One shot with state machine:

https://user-images.githubusercontent.com/45795134/192518458-a0dfb192-5a38-4e30-aef6-cbcfe63e856a.mp4



### Steps to reproduce

- Create animation blend tree for the character
- Add default state and one shot after it
- Add a state machine for the one shot node
![image](https://user-images.githubusercontent.com/45795134/192518789-642844b5-496a-4afe-a032-a31e9dbeb51c.png)
- In game - enable the default state animation and play one shot animation, with enabling the one shot and enabling the state machine


### Minimal reproduction project

_No response_
Repository: angular
Issue: feat(matCheckbox): set indeterminate state from reactive from
Labels: feature,area: forms,feature: insufficient votes,needs triage

### Feature Description

When a matCheckbox is controlled by a reactive form control, it is currently not possible to put the checkbox in indeterminate state.

undefined could be used to represent indeterminate state in the formcontrol.

formControl.setValue(undefined) would result in the checkbox beeing in indeterminate state.

### Use Case

set indeterminate state programmatically
Repository: vscode
Issue: Popup blocked opening the codespace
Labels: bug,debt,continue-working-on

Testing #161875

Source: insiders.vscode.dev
Target: GH Codespace

The CS was not opened due to popup blocking:

![image](https://user-images.githubusercontent.com/900690/192528115-23d1d9c7-efb6-43d1-88e6-75d6f191bc6e.png)
Repository: create-react-app
Issue: we should deprecate cra 
Labels: issue: proposal,needs triage

### Is your proposal related to a problem?

<!--
  Provide a clear and concise description of what the problem is.
  For example, "I'm always frustrated when..."
-->

(Write your answer here.)
I 'm always frustrated when create react app take years to restart server 
### Describe the solution you'd like

<!--
  Provide a clear and concise description of what you want to happen.
-->
just delete this github repo

(Describe your proposed solution here.)

### Describe alternatives you've considered

<!--
  Let us know about other solutions you've tried or researched.
-->

(Write your answer here.)
I use vite or next js 
### Additional context

<!--
  Is there anything else you can add about the proposal?
  You might want to link to related issues here, if you haven't already.
-->

(Write your answer here.)
Repository: vscode
Issue: Merge UI: Show Accept code lenses in result
Labels: under-discussion,merge-editor

Testing #161834

The result first shows 'No Changes  Accepted'. I wonder if it would resonate more with users when it would show `Accept Input 1`, `Accept Both`, `Accept Input 2`.

Accepting input 1 could then update the code lenses in the result to `Remove Input 1`, `Accept Input 2`?
Repository: deno
Issue: `typeof import(...)` strips `.ts` extension in vscode property tooltip
Labels: bug,lsp

In certain cases using `typeof import('https://deno.land/blablahblah.ts')` will display the type as `typeof import('https://deno.land/blablahblah')` in vscode. Functionally everything seems to work, but it is a bit confusing.

MOV:

https://user-images.githubusercontent.com/2141050/192545258-cee9c7be-50ce-45dd-9c46-355935967e8a.mov




Repro Repo: https://github.com/curtislarson/deno-typeof-import-repro
Repository: terminal
Issue: Terminal "badge" like function similar to iTerm2
Labels: Issue-Feature,Area-VT,Product-Terminal

<!-- 
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed!
-->

# Description of the new feature/enhancement

Something akin to the "badge" functionality in iTerm2. This creates a configurable "badge" in the background of a terminal that can be used to denote whatever is wished. I personally use this feature when working with multiple cloud environments to differentiate between the different terminals

# Proposed technical implementation details (optional)

As for how to implement this, I am unsure but perhaps they could be added as a function to Terminal's improving theming?
At present this feature is called from a function within my .zshrc file(below)

```
set_badge () {
printf "\033]1337:SetBadgeFormat=%s\007" $(echo $1 | base64)
```
This can then be set by using 
```
set_badge $VAR
``` 
or 
```
set_badge "something with whitespace"
```

Example 
<img width="2048" alt="Screenshot 2022-09-27 at 14 55 26" src="https://user-images.githubusercontent.com/37657888/192548252-dbf028ba-d339-4ac1-be50-200dde07a0d9.png">
Repository: vscode
Issue: Merge UI: Cannot click to select removed text field
Labels: bug,merge-editor

Testing #161834

E.g., clicking in the upper right orange rectangle does not select that conflict, only clicking in the upper left orange rectangle does:
<img width="2046" alt="image" src="https://user-images.githubusercontent.com/9205389/192549326-b4f0adfc-9162-4374-9c63-a5bc74153d99.png">
Repository: vscode
Issue: Merge UI: Show annotations under scrollbar
Labels: bug,merge-editor

Testing #161834

The old UI shows annotations under the scrollbar for unresolved conflicts, these are helpful for navigation and to get an idea of how much work there is:
<img width="1350" alt="image" src="https://user-images.githubusercontent.com/9205389/192551011-3e8726fa-9933-42f2-8c0f-1bf925fb2492.png">
Repository: go
Issue: encoding/json: custom type marshaling doesn't work for map values 
Labels: NeedsDecision

<!--
Please answer these questions before submitting your issue. Thanks!
-->

### What version of Go are you using (`go version`)?

<pre>
$ go version 1.16

</pre>

### Does this issue reproduce with the latest release?

Yes

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/matt/.cache/go-build"
GOENV="/home/matt/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/matt/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/matt/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/matt/sdk/go1.19.1"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/matt/sdk/go1.19.1/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/matt/GitHub/relay_common/smm_api/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2596506419=/tmp/go-build -gno-record-gcc-switches"

</pre></details>

### What did you do?

<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on go.dev/play is best.
-->

If you define custom marshaling/unmarshaling functions for a type, `json.Marshal` doesn't use them when the custom type is used as value in a map.

https://go.dev/play/p/uggz6OAQo_J


### What did you expect to see?

I expect the custom type marshaling functions to be respected even when the custom type is a value in a map

### What did you see instead?

JSON reverts to a default marshaling/unmarshaling function
Repository: vscode
Issue: WorkspaceEdit: confirmation preview does not reflect the create content
Labels: bug,workspace-edit

Testing #161809

```
	let disposable = vscode.commands.registerCommand('workspaceedit-test.helloWorld', () => {
		const edit: vscode.WorkspaceEdit = new vscode.WorkspaceEdit();

		const folders = vscode.workspace.workspaceFolders;
		if (!folders || folders.length === 0) {
			vscode.window.showInformationMessage('Open a folder first');
			return;
		}
		const newFile = vscode.Uri.joinPath(folders[0].uri, 'foo.txt');
		edit.createFile(newFile, 
			{ overwrite: true, contents: new TextEncoder().encode("Hello World\nOne more line") }, 
			{ label: 'New text', needsConfirmation: true }
		);

		const range = new vscode.Range(0, 0, 0, 5);
		const snippetString = new vscode.SnippetString('Rocket');
		snippetString.appendChoice(['A', 'B', 'C'], 1);
		const newSnippetEdit = new vscode.SnippetTextEdit(range, snippetString);
		edit.set(newFile, [newSnippetEdit]);

		vscode.workspace.applyEdit(edit);
	});
```
- create a new file `foo.txt` with a new content
- applies a snippet string
- requires confirmation
- run the first time: 
![image](https://user-images.githubusercontent.com/6461412/192562681-3e745f6d-5a8b-4ad7-9447-44b8b720114c.png)
- run the second time, after accepting the first 
![image](https://user-images.githubusercontent.com/6461412/192562888-9dc6afbb-7190-4a23-8837-cf11fda8c81b.png)


:bug: the confirmation preview shows the previous file content, not the new file content (`Hello`)
Repository: godot
Issue: Visual artifact when using Vulkan driver with Intel iGPU
Labels: bug,platform:linuxbsd,topic:rendering,needs testing

### Godot version

4.0.beta1-official

### System information

OS: Arch Linux x86_64 5.19.10-zen1-1-zen
GPU: Intel WhiskeyLake-U GT2 [UHD Graphics 620]
Vulkan Driver: vulkan-intel 22.1.7-1

### Issue description

Visual artifact, a black bar that glitches at the lower end of the window. Only happens with the vulkan driver enabled in Godot 4. Even happens in scenes without any additional graphics. When using OpenGL3 driver, the issue is non existent.

### Steps to reproduce

1. Open Godot
2. Open any 2D Project
3. Use Vulkan Driver in Project Settings
4. Run Project
5. Observe artifact

### Minimal reproduction project

Was able to reproduce with the Godot-CPP project and a few of my own 2D projects, so I wont add one immediately.
Repository: next.js
Issue: script tag in next/head avoids loading of google tag manager
Labels: bug,Script (next/script),Metadata

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

    Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 21.6.0: Wed Aug 10 14:28:23 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_T6000
    Binaries:
      Node: 16.13.2
      npm: 8.1.2
      Yarn: 1.22.17
      pnpm: 7.0.1
    Relevant packages:
      next: 12.3.2-canary.10
      eslint-config-next: 12.3.1
      react: 18.2.0
      react-dom: 18.2.0


### What browser are you using? (if relevant)

Chrome 105.0.5195.125

### How are you deploying your application? (if relevant)

_No response_

### Describe the Bug

I followed the [example](https://github.com/vercel/next.js/tree/canary/examples/with-google-tag-manager) of how to add the google tag manager to a nextjs application. This works, but when I add a custom script tag via `next/head` the google tag manager is no longer added and the `<meta charset="utf-8">` is duplicated.

### Expected Behavior

The custom script and the google tag manager are in the head and no meta tags are duplicated.

### Link to reproduction

https://github.com/nadinetetz/nextjs-gtm-issue

### To Reproduce

- checkout the reproduction
- `yarn && yarn dev`
- inspect the html head
Repository: godot
Issue: Steam Controller is only partially working
Labels: bug,confirmed,topic:input

### Godot version

3.5.stable.official

### System information

Linux (Manjaro)

### Issue description

Comparison of what Godot reports and what jstest-gtk detects (the reality):

https://user-images.githubusercontent.com/1975567/192562873-1ef661dd-c556-49cd-87a5-db08e108e288.mp4

Triggers (buttons nor axis) and right "stick" press are not registered at all, d-pad sometimes gets stuck and state is reported inverted (pressed when released and released when pressed). Maybe I am missing something, it should all be in the video. I think it used to work correctly few versions back. Vibration also doesn't work. Actions don't work when bind to those not working raw buttons/axis from above.

### Steps to reproduce

Use Steam Controller in Godot 3.5.

### Minimal reproduction project

Run https://github.com/godotengine/godot-demo-projects/tree/master/misc/joypads and use Steam Controller (without Steam running).