sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: [image_picker] Allow custom transitions for opening the gallery/camera
Labels: c: new feature,f: routes,p: image_picker,package,c: proposal,team-ecosystem,P3,triaged-ecosystem

## Use case
<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->
The app I am working in has some specific page route transitions that I'd like to apply when opening/closing the gallery/camera via the image_picker plugin.

## Proposal

<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching images showing what you are imagining.

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->
I would like if we (API users) were able to specify a custom route to the image_picker opening/closing pages, so we can have custom transitions other than the default one.
Repository: terminal
Issue: Add `startupActions` to Settings UI
Labels: Product-Terminal,Issue-Task,In-PR,Area-SettingsUI

Similar to #8755. These are settings that were added to v1.6 that need to be added to the Settings UI (or include reasoning for why not add them):

| Setting | Required? | Notes |
|--|--|--|
| `startupActions` | ✔ | #8770 |

~This may not be a comprehensive list. @cinnamon-msft is verifying if any are missing and will update this issue accordingly.~
EDIT: verified that `startupActions` is the only one. Updating the issue title appropriately.

Resources:
- [Documentation for adding a setting](https://github.com/microsoft/terminal/blob/main/doc/cascadia/AddASetting.md)
Repository: godot
Issue: HTML5 build crashes when using SurfaceTool 
Labels: bug,platform:web,topic:core

**Godot version:**
3.2.3

**OS/device including version:**
MacOS 10.15.5
Intel Iris Pro 1536 MB
GLE3

**Issue description:**

The following code causes a crash in an HTML5 build. (A MacOS build works fine.)

```
func _ready():
  var result = MeshInstance.new()
  var st = SurfaceTool.new()
  
  st.begin(Mesh.PRIMITIVE_TRIANGLES)
  st.add_color(Color.red)
  st.add_uv(Vector2(0, 0))
  st.add_vertex(Vector3(-10, -10, -50.0))
  st.add_uv(Vector2(0.5, 1))
  st.add_vertex(Vector3(0.0, 10.0, -50.0))
  st.add_uv(Vector2(1, 0))
  st.add_vertex(Vector3(10.0, -10.0, -50.0))
  st.generate_normals()
  st.index()
  
  result.mesh = st.commit()
  add_child(result)
```

Building an HTML5 project with this code and then opening it in Chrome crashes the tab - it locks up and then Chrome actually destroys it after 10-20 seconds. 

In Firefox, the browser doesn't crash, but the game never loads either.

**Steps to reproduce:**

1. Build an HTML5 build of the provided repo.
2. Open in Chrome.

**Minimal reproduction project:**

https://github.com/johnfn/GodotExportCrashExample
Repository: storybook
Issue: Forgiving handling of refs in Storybook Composition instead of build time assigned type making stories.json required
Labels: feature request,has workaround,composition

We are working on libraries of UI components for multiple frameworks (React, Angular, Vue) in a mono-repo. Each variant has its own storybook built as static site for publishing, then they are served on a single web server.

The challenge we are running into is that Storybook performs build time check of the refs https://github.com/storybookjs/storybook/blob/4f5ab9fe9e590da7b841ec37cb1bed8d6327ea4b/lib/api/src/modules/refs.ts#L137, but the refs in this case are relative URLs and not resolvable at build time. This causes the refs to be assigned type of 'unknown' (implicit assumption of 'private' storybook served in Chromatic?) and stories.json is required at runtime.

Currently we are using a manager webpack config customization to work around this.

**Describe the solution you'd like**
I think Composition being more forgiving would be a fine solution
1. Try stories.json
2. Try index.html (static site)
3. Indicate ref is inaccessible

The docs could be a bit clearer around assumptions; i.e. ref is a site (CHP 0) that is accessible at build time or private and provides stories.json (CHP 1).

**Describe alternatives you've considered**
It's my understanding that Composition is the recommend way to create a storybook with multiple frameworks and I think that's a reasonable option. In this particular scenario, we don't need the distinct sites and a build that could package multiple storybooks into a single static site would fit the need more directly.
Repository: next.js
Issue: i18n with multiple domains exposes a lot of urls that shouldn't be available
Labels: Internationalization (i18n)

**What version of Next.js are you using?**

10.0.5

**What version of Node.js are you using?**

15.6.0

**What browser are you using?**

n/a

**What operating system are you using?**

n/a

**How are you deploying your application?**

next build  && next start

**Describe the Bug**

According to the docs, for the following i18n config:

```js
  i18n: {
    locales: ['en', 'pl'],
    defaultLocale: 'en',
    domains: [
      {
        domain: 'example.com',
        defaultLocale: 'en'
      },
      {
        domain: 'example.pl',
        defaultLocale: 'pl'
      }
    ]
  }
```

and `pages/index.js` & `pages/about.js` files only the following urls should be available:

* https://example.com
* https://example.com/about
* https://example.pl/
* https://example.pl/about

That's not the case, there are others that are accessible too:
* https://example.com/en
* https://example.com/en/about
* https://example.com/pl
* https://example.com/pl/about
* https://example.pl/en
* https://example.pl/en/about
* https://example.pl/pl
* https://example.pl/pl/about

**Expected Behavior**

These extra urls should correctly display 404 or at least redirect to the correct domain with the locale prefix stripped

**To Reproduce**

.
Repository: go
Issue: html/template: JS context breaks after a quoted </script>
Labels: NeedsInvestigation

<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.15.6 darwin/amd64
</pre>

### Does this issue reproduce with the latest release?

Yes

### What operating system and processor architecture are you using (`go env`)?

darwin/amd64

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/mariano/Library/Caches/go-build"
GOENV="/Users/mariano/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/mariano/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/mariano/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.15.6/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.15.6/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/6g/rqtbx_fd6ljgvql610mhh7sr0000gn/T/go-build388033793=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>

### What did you do?

The existence of a tag `</script>` inside a Javascript string breaks the context and can cause code injection. 

In the following example, the first variable is properly quoted, but the variables after `"</script>"`, are not treated as Javascript string, and the go representation is displayed

https://play.golang.org/p/_XqZ3NtXYVE

### What did you expect to see?

```html
<script>var b = {"foo": "foo", "script": "</script>", "bar": "bar"}</script>
```

### What did you see instead?

```html
<script>var b = {"foo": "foo", "script": "</script>", "bar": bar}</script>
```
Repository: pytorch
Issue: Discourage slow gradchecks
Labels: module: autograd,module: tests,triaged

It is very easy to make very slow gradcheck calls if one is not careful about the input/output sizes.

We should add a check that will fail for inputs/outputs that are too large and have a new flag "allow_slow_checks" (name to be decided) that can be used to disable the error.

We can set this flag to true for the tests that do require slow gradcheck.

cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @soulitzer @mruberry @VitalyFedyunin @walterddr
Repository: pytorch
Issue: Use unified type for distributions.constraint API
Labels: module: distributions,triaged

## 🚀 Feature
Currently, the API of `torch.constraints` exposes a mix of singleton `Constraint` instances and `Constraint` classes. e.g.

```python
>>> type(constraints.real)
torch.distributions.constraints._Real

>>> type(constraints.interval)
type
```

The ask is to uniformly return the more flexible class in the public API, e.g. instead of exposing `real = _Real()`, we should instead expose `real = _Real`. 

## Motivation
The motivation for this is that the current API makes checking for constraint type awkward, e.g. to check if a constraint is an interval or a real constraint, we need to do:

```python
constraint is constraints.real or isinstance(constraint, constraints.interval)
```

, which requires figuring out which constraint is a type vs an actual instance, instead of more simply:

```python
isinstance(constraint, (constraints.real, constraints.interval))
```

Note that this will be a breaking change and we may need to go through a round of deprecation to support this.

## Alternative

Alternatively, we can instead do `isinstance` checks on the non-public classes, e.g. `isinstance(constraint, (constraints._Real, constraints._Interval)`, but I am not sure if we have strong reasons to not expose these classes publicly.

Another option is to provide a backward compatible utility function:

```python
def _unwrap(constraint):
    if isinstance(constraint, constraints.independent):
        return _unwrap(constraint.base_constraint)
    return constraint if isinstance(constraint, type) else constraint.__class__


def constraint_type_eq(constraint1, constraint2):
    return _unwrap(constraint1) == _unwrap(constraint2)
```

cc @fritzo @neerajprad @alicanb @vishwakftw @nikitaved @fehiepsi
Repository: go
Issue: cmd/go: resolve local paths to modules in subdirectory replacements
Labels: NeedsInvestigation,GoCommand,modules

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.16beta1 darwin/amd64
</pre>

### Does this issue reproduce with the latest release?

yes

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayconrod/Library/Caches/go-build"
GOENV="/Users/jayconrod/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/jayconrod/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayconrod/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/go/installed"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/go/installed/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16beta1"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayconrod/Code/test3/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build3849412287=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>

### What did you do?

Run `go list` or any other module-aware command on an absolute or relative path (starting with `./`) that points to a subdirectory inside a separate module which provides a replacement.

```
go list ./sub
go list $(pwd)/sub

-- go.mod --
module example.com/m

go 1.16

require example.com/m/sub v0.0.0

replace example.com/m/sub v0.0.0 => ./sub
-- sub/go.mod --
module example.com/m/sub

go 1.16
-- sub/sub.go --
package sub
```

### What did you expect to see?

`go list` should succeed and print the package path. In the example above, it should print `example.com/m/sub`.

### What did you see instead?

`go list` fails with:

```
main module (example.com/m) does not contain package example.com/m/sub
```

It looks like the `go` command resolves the path argument to a directory within the module before checking whether it might be part of a replacement module in another directory.

### Other notes

This issue is related to the thread [`go list` across multiple modules](https://groups.google.com/g/golang-nuts/c/B-gvL92b2Vo) on golang-nuts.
Repository: rust
Issue: Error message improvement: Manual reborrowing with `&mut *variable`
Labels: A-diagnostics,T-compiler

In this testcase, I wanted to reborrow `outer`, but accidentally wrote `&mut outer` instead of `&mut *outer`. However, the error's suggestion was ```try removing `&mut` here``` which wouldn't have worked.
It would be better to have the suggestion ```try adding `*` here``` in this particular scenario.

```rust
fn test(outer: &mut Option<i32>) {
    match (&mut outer, 23) {
        (Some(inner), _) => {
            *inner = 17;
        },
        _ => {
            *outer = Some(2);
        },
    }
}
```

```
   Compiling playground v0.0.1 (/playground)
error[E0596]: cannot borrow `outer` as mutable, as it is not declared as mutable
 --> src/lib.rs:2:12
  |
2 |     match (&mut outer, 23) {
  |            ^^^^^^^^^^
  |            |
  |            cannot borrow as mutable
  |            try removing `&mut` here

error: aborting due to previous error
```
Repository: go
Issue: x/tools/gopls: enable -rpc.trace logging to a file by default
Labels: gopls,Tools

This has been discussed frequently, but I don't believe there is an issue tracking the fix. We should enable logging by default, to a file, so that users can have an easier time sharing logs with us (and don't lose them if they restart their editors). Care needs to be taken that we don't fill up temp directories with large files.

/cc @heschik @findleyr @hyangah
Repository: pytorch
Issue: Training slowdown from 1.6 to 1.7.1
Labels: module: performance,triaged,module: __torch_function__

## 🐛 Bug

We saw a training slowdown with Pytorch going from 1.6 to 1.7.1 on the [Nvidia BERT](https://github.com/NVIDIA/DeepLearningExamples/tree/master/PyTorch/LanguageModeling/BERT) repo. We were able to narrow down the slowdown to `has_torch_function` and param `grad` method (in optimizer), which is slower in 1.7.1 (probably due to https://github.com/pytorch/pytorch/pull/37091).

Below, is a simple reproducer.
Please let us know if this performance hit is expected going from 1.6 to 1.7.1

## To Reproduce

```
import torch.optim as optim
import torch.nn as nn
import torch.nn.functional as F


class Net(nn.Module):
    def __init__(self):
        super(Net, self).__init__()
        self.conv1 = nn.Conv2d(3, 6, 5)
        self.pool = nn.MaxPool2d(2, 2)
        self.conv2 = nn.Conv2d(6, 16, 5)
        self.fc1 = nn.Linear(16 * 5 * 5, 120)
        self.fc2 = nn.Linear(120, 84)
        self.fc3 = nn.Linear(84, 10)

    def forward(self, x):
        x = self.pool(F.relu(self.conv1(x)))
        x = self.pool(F.relu(self.conv2(x)))
        x = x.view(-1, 16 * 5 * 5)
        x = F.relu(self.fc1(x))
        x = F.relu(self.fc2(x))
        x = self.fc3(x)
        return x


net = Net()

optimizer = optim.SGD(net.parameters(), lr=0.001, momentum=0.9)
%timeit -n 1000 optimizer.step()

```

1.6:
```
11.4 µs ± 105 ns per loop (mean ± std. dev. of 7 runs, 1000 loops each)
```

1.7.1:
```
46.3 µs ± 629 ns per loop (mean ± std. dev. of 7 runs, 1000 loops each)
```
## Environment

```
Collecting environment information...
PyTorch version: 1.7.1
Is debug build: False
CUDA used to build PyTorch: 11.0
ROCM used to build PyTorch: N/A

OS: Ubuntu 18.04.5 LTS (x86_64)
GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Clang version: Could not collect
CMake version: version 3.18.2

Python version: 3.6 (64-bit runtime)
Is CUDA available: True
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: Tesla V100-SXM2-16GB
GPU 1: Tesla V100-SXM2-16GB
GPU 2: Tesla V100-SXM2-16GB
GPU 3: Tesla V100-SXM2-16GB
GPU 4: Tesla V100-SXM2-16GB
GPU 5: Tesla V100-SXM2-16GB
GPU 6: Tesla V100-SXM2-16GB
GPU 7: Tesla V100-SXM2-16GB

Nvidia driver version: 450.80.02
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.0.4
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.0.4
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.0.4
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.0.4
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.0.4
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.0.4
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.0.4
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] numpy==1.19.1
[pip3] sagemaker-pytorch-training==2.3.1.dev0
[pip3] torch==1.7.1
[pip3] torchfile==0.1.0
[pip3] torchnet==0.0.4
[pip3] torchvision==0.8.2+cu110
[conda] Could not collect
```

cc @hameerabbasi @rgommers @VitalyFedyunin @ngimel
Repository: TypeScript
Issue: "Rename Symbol" (F2) doesn't ignore node_modules
Labels: Bug,Help Wanted,Domain: Refactorings

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: Version: 1.52.1
Commit: ea3859d4ba2f3e577a159bc91e3074c5d85c0523
Date: 2020-12-16T16:32:10.090Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
- OS Version: Linux x64 5.4.0-62-generic (Linux Mint 19 Cinnamon 64-bit)


Steps to Reproduce:

1. Create a NodeJS project:
```bash
npm init
npm i uuid # probably any lib
code newfile.js
```
2. Type:
```javascript
import * as uuid from 'uuid'
uuid.v4()
```
3. Select the `v4` function call, press `F2` to rename it, type `oops`, press `Enter`
4. A new tab will be opened, showing an `index.d.ts` file whose `v4` string was replaced with `oops`

There should be an exception for node_modules, probably some warning or blocking, since you shouldn't just rename stuff from there.

<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
Repository: godot
Issue: _exit_tree()/tree_exiting() isn't called when hitting the "Stop" button in the editor
Labels: enhancement,topic:editor,documentation

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
<!-- Specify commit hash if using non-official build. -->
Godot v3.2.3 stable

**OS/device including version:**
<!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. -->
Windows 10

**Issue description:**
<!-- What happened, and what was expected. -->
`_exit_tree()`/`tree_exiting()` isn't called when hitting the "Stop" (F8) button in the editor. It works fine when calling `get_tree().quit()` and when hitting the close window button. It's possible this isn't a bug, but it at least seems counterintuitive to me.

**Steps to reproduce:**
Read above and see the reproduction project.

**Minimal reproduction project:**
<!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. -->
[ReproductionProject.zip](https://github.com/godotengine/godot/files/5823608/ReproductionProject.zip)
Repository: flutter
Issue: Slider.label documentation should be clearer about behavior with continuous sliders
Labels: framework,f: material design,d: api docs,team-design,triaged-design

The [documentation for `Slider.label`](https://api.flutter.dev/flutter/material/Slider/label.html) says:

> A label to show above the slider when the slider is active.
>
> It is used to display the value of a discrete slider, and it is displayed as part of the value indicator shape.

While it says that the label is used with discrete sliders, it doesn't actually say anything about continuous sliders.  The implication from omission is that labels won't be shown for continuous sliders (which I verified is the case), but it would be much clearer to explicitly say so, in the same way that the documentation later says:

> Ignored if this slider is created with Slider.adaptive.

Also, why is the label limited only to discrete sliders anyway?