sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: bitcoin
Issue: `-maxtxfee` is used as a fee and a feerate
Labels: Wallet

The `-maxtxfee` (which is put into `m_default_max_tx_fee`) is documented as "the maximum total fees to use in a single wallet transaction"
https://github.com/bitcoin/bitcoin/blob/632a2bb731804dffe52bd4cbd90bfee352d25ede/src/wallet/init.cpp#L63

This seems true in many instances when we look at the code:
https://github.com/bitcoin/bitcoin/blob/632a2bb731804dffe52bd4cbd90bfee352d25ede/src/wallet/spend.cpp#L1293-L1295
https://github.com/bitcoin/bitcoin/blob/632a2bb731804dffe52bd4cbd90bfee352d25ede/src/wallet/feebumper.cpp#L114-L119
https://github.com/bitcoin/bitcoin/blob/632a2bb731804dffe52bd4cbd90bfee352d25ede/src/node/transaction.cpp#L71-L79

But there are also places where this value is used as a feerate per KvB:
https://github.com/bitcoin/bitcoin/blob/632a2bb731804dffe52bd4cbd90bfee352d25ede/src/wallet/wallet.cpp#L3061-L3064
https://github.com/bitcoin/bitcoin/blob/632a2bb731804dffe52bd4cbd90bfee352d25ede/src/wallet/rpc/spend.cpp#L433

I don't think these instances of conversions to feerate result in anything very problematic, but it doesn't make sense to just convert this fee to a feerate because not every tx is the same size. I can see why a wallet user might want a maximum fee and maximum feerate. So my suggested solution is to have both: add a `-maxfeerate` and put those checks under the new value.
Repository: material-ui
Issue: [docs-infra] Ability to make all installation code blocks use the same package manager
Labels: new feature,scope: docs-infra

### Duplicates

- [X] I have searched the existing issues

### Summary

I strongly suggest updating all the command line instructions when switching the package manager. For instance, in my current project, I'm using yarn as the package manager, and I need to install Material-UI for my project.

I would like to switch all the following commands based on the package manager I choose (automatically - not manual) 🙏

<img width="909" alt="Screenshot 2024-01-10 at 18 52 16" src="https://github.com/mui/material-ui/assets/55950527/406e4336-2286-4e7c-9f60-98e5ac1273f8">


### Examples

_No response_

### Motivation

_No response_

**Search keywords**:
Repository: flutter
Issue: [flutter_tools] flutter create -t skeleton creates build/.last_build_id in wrong directory
Labels: tool,P2,team-tool,triaged-tool

See https://github.com/flutter/flutter/pull/141233#discussion_r1447432528

When running `flutter create --template=skeleton testing_pr` two directories are created.
- `testing_pr`: as expected
- `build`: contains only one file called .last_build_id

Only the directory with the created project should be created
Repository: flutter
Issue: Support for floating point textures
Labels: c: new feature,engine,P3,team-engine,triaged-engine

### Use case

This is an extension to #136025.

Fragment shaders sometimes need lookup tables, for example for color transformations. These tables usually use floating point, since that's the natural way math works on GPUs. GLSL handles this transparently, and APIs like OpenGL have support for this via floating point textures (`GL_RGBA32F`, `GL_R32F`, etc).

### Proposal

If Flutter adds support for sync texture construction, this should also allow supplying a floating point texture to enable these kinds of operations in fragment shaders.
Repository: godot
Issue: Android keyboard doesn't show up in emulator
Labels: bug,platform:android,topic:porting

### Tested versions

Reproducible in 4.2.1
Not reproducible in 4.1.1

### System information

Godot v4.2.1.stable - Manjaro Linux #1 SMP PREEMPT_DYNAMIC Thu Dec 21 16:21:45 UTC 2023 - X11 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3060 Laptop GPU () - AMD Ryzen 5 5600H with Radeon Graphics (12 Threads)

### Issue description

Clicking on a text input node such as LineEdit should raise the virtual keyboard in Android. On emulators, it does not.
It works on my physical device.

### Steps to reproduce

Click on text input node such as LineEdit in an Android emulator.
Virtual keyboard fails to show up.

### Minimal reproduction project (MRP)

[Keyboard test 4.1.1.tar.gz](https://github.com/godotengine/godot/files/13891307/Keyboard.test.4.1.1.tar.gz)
[Keyboard test 4.2.1.tar.gz](https://github.com/godotengine/godot/files/13891310/Keyboard.test.4.2.1.tar.gz)
Repository: rust
Issue: const functions can assert! but cannot assert_eq!
Labels: A-trait-system,T-libs-api,C-feature-request,A-const-eval

This is probably a well-known limitation, but I couldn't find any other issues for it with a quick search. Apologies if it's a duplicate.

```rust
// compiles
pub const fn foo() {
    assert!(1 == 1);
}

// does not compile
pub const fn bar() {
    assert_eq!(1, 1);
}
```

```
error[E0015]: cannot call non-const fn `core::panicking::assert_failed::<i32, i32>` in constant functions
 --> src/lib.rs:6:5
  |
6 |     assert_eq!(1, 1);
  |     ^^^^^^^^^^^^^^^^
  |
```

[Playground link](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=b0862852c785570e2dfe8d41a3767729)

Can `core::panicking::assert_failed` be made `const`?
Repository: flutter
Issue: Update the Android Emulators Module
Labels: team-infra,P2,triaged-infra

### Type of Request

bug/feature request

### Infrastructure Environment

Recipes

### What is happening?

While looking into the code and discussing this with several teams outside of infra I have noticed that we could be doing a better job of making the emulator creation, setup, and cleanup better and more robust.

Rather than spending more time looking for trends on the failures (there really is not one that I can see), I am going to cleanup the recipe module and make it more hermetic.

There is some functionality within the emulator avd.py script that we do not use and I believe that we are also not leaving a clean environment on exit of the testing. Since more and more tests want to use emulators this will absolutely be needed as we move forward. 

The existing emulator module was created to support a single recipe but has grown to support multiple repositories and test methods.

- [x] Build in smarter detection of sys properties since they differ by version.
- [x] Add an uninstall method to remove all of the previous files and config. https://flutter-review.googlesource.com/c/recipes/+/53903
- [x] Determine if the is a way to stop the emulator rather than killing the emulator process.
        * Does this affect the uninstall of the files?
        * Currently the only way to stop the emulator is to kill the process (odd). Looking through the avd.py code there is not actual stop method only the uninstall. So leaving the kill method with the uninstall should help.
- [ ] (Optional) is the shell script needed or should that functionality be moved into the python module?
- [ ] Add support to check for supported platforms as we may want to add emulators to windows and Mac as well.
- [x] Add retry to the start emulator step. 
        * Emulator shows pid even though the hang occurs with a message saying that it has died. There may be a way to retry this step to get the emulator to start.
        * Need to look for 'X connection to :99 broken (explicit kill or server shutdown)' and raise on that to force a retry.
- [ ] Add support to run this locally an emulator in docker locally for testing purposes.

### Steps to reproduce

NA

### Expected results

Hopefully no failures moving forward or at least limiting the flakiness of the test runs.
Repository: pytorch
Issue: Disable bot spamming
Labels: triaged,module: devx

In https://github.com/pytorch/pytorch/issues/116842, Disable bot spammed messages saying "Another case of trunk flakiness has been found [here](https://github.com/pytorch/pytorch/runs/20348718368). The list of platforms [dynamo] appears to contain all the recently affected platforms [dynamo]. Either the change didn't propogate fast enough or disable bot might be broken."

The last sentence implies something is wrong, but it's unclear what (is disable bot broken?). Is something actually wrong, or do we just need to update the error message?

cc @ZainRizvi @kit1980 @huydhn @clee2000 @pytorch/pytorch-dev-infra
Repository: vscode
Issue: Notebook Code Action inconsistency
Labels: feature-request,notebook-code-actions

Playing the notebook level code actions with @karthiknadig and ran into following issues:

```json
{
    "[python]": {
        "editor.codeActionsOnSave": {
            "source.organizeImports": "always",
            "notebook.source.organizeImports": "always" // not working?
        }
    },
    "notebook.codeActionsOnSave": {
        "notebook.source.organizeImports": "explicit"
    }
}
```

* We thought `notebook.source.organizeImports` in the `editor.codeActionsOnSave` could work.
* `notebook.codeActionsOnSave` doesn't support `always`
Repository: vscode
Issue: Notebook/Cell code actions not available in editor context menu
Labels: feature-request,notebook-code-actions

I installed ruff extension and also enabled the notebook level source code action

```
"notebook.codeActionsOnSave": {
        "notebook.source.organizeImports.ruff": "explicit"
}
```

It works great when I save the notebook. `source.organizeImports.ruff` also works fine. However, when I right click on a cell editor and pick "Source Action...", I didn't get any action.

<img width="565" alt="image" src="https://github.com/microsoft/vscode/assets/876920/fceb1dc4-258a-4a08-a791-5a717efda6ca">

There is also no "Source Action" entry in the notebook editor's context menu. With both issues, this feature is not accessible to users.
Repository: next.js
Issue: App directory cannot have node internals import in "use client" code
Labels: bug,linear: next

### Link to the code that reproduces this issue

https://github.com/samijaber/nextjs-monorepo/commit/bacddaca5429320444ccdc9724ee958b267ad550

### To Reproduce

- add the following file to your nextjs app:


```js
"use client";
import { createRequire } from "node:module";

let safeDynamicRequire: any = () => {};
try {
  safeDynamicRequire = createRequire(__dirname);
} catch (e) {
  safeDynamicRequire = eval("require");
}

const add = safeDynamicRequire("lodash/add");

export const add3 = () => {
  return add(1, 2);
};
```
(ignore the weirdness around `eval` and `createRequire`. The main idea is that the import can't even be processed by webpack)


- try to import `add3` and use it in an app directory

### Current vs. Expected behavior

expected: it works

current:

```
node:module
Module build failed: UnhandledSchemeError: Reading from "node:module" is not handled by plugins (Unhandled scheme).
Webpack supports "data:" and "file:" URIs by default.
You may need an additional plugin to handle "node:" URIs.
```


NOTE: removing `"use client"` from the top of the file fixes this.

### Verify canary release

- [X] I verified that the issue exists in the latest Next.js canary release

### Provide environment information

```bash
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000
Binaries:
  Node: 20.10.0
  npm: 10.2.3
  Yarn: 1.22.19
  pnpm: 8.10.2
Relevant Packages:
  next: 14.0.5-canary.49
  eslint-config-next: 14.0.4
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.3.3
Next.js Config:
  output: N/A
```


### Which area(s) are affected? (Select all that apply)

App Router

### Which stage(s) are affected? (Select all that apply)

next dev (local), next build (local), next start (local), Vercel (Deployed)

### Additional context

_No response_
Repository: flutter
Issue: [Impeller] Generate a UUID for runtime stage shaders to use as a unique key for that shader
Labels: engine,P3,c: tech-debt,e: impeller,team-engine,triaged-engine

As of https://github.com/flutter/engine/pull/49543 we'll use the generated entrypoint name, which should be unique enough. However, it would be better/more reliable to use a UUID and encode it into the IPLR fbs file, and then plumb it through when caching the pipeline for the runtime effect contents.

See https://github.com/flutter/engine/pull/49543#discussion_r1447922257
Repository: flutter
Issue: [web] Consider using `setPointerCapture` method for pointer handling.
Labels: engine,platform-web,P2,team-web,triaged-web

### Use case

The current web engine uses global event listeners to handle events that might "get out" of Flutter's hostElement.

### Proposal

Consider using `setPointerCapture` on Flutter's `hostElement` so events stay targeted to the Flutter host element even when drags happen outside of flutter. See docs:

* [MDN > Element: `setPointerCapture()` method](https://developer.mozilla.org/en-US/docs/Web/API/Element/setPointerCapture)

### Related

* https://github.com/flutter/flutter/issues/134652 (framework-level request)
Repository: svelte
Issue: [svelte-check] Issue with attributes added to HTMLElement with action
Labels: a11y

### Describe the bug

`svelte-check` expects an `alt` attribute for `img` Elements.
But when adding the `alt` attribute with an action `svelte-check` still complains, that the `alt` attribute is needed.
The action has an `ActionReturn<undefined, { alt: string }>` type telling `svelte-check` that the `alt` attribute is added when this action is used.

Am I using the `ActionReturn` type wrongly? Since I am also getting another TypeScript error


### Reproduction

```svelte
<script lang="ts">
  import { type ActionReturn } from "svelte/action";

  function action(
    node: HTMLImageElement,
  ): ActionReturn<undefined, { alt: string; src: string }> {
    node.src = "file://image";
    node.alt = "local file";
    return {};
  }
</script>

<img use:action />
```

### Logs

```shell
debug.svelte:13:1
Warn: A11y: <img> element should have an alt attribute (svelte)

<img use:action />


debug.svelte:13:4
Error: Argument of type '{}' is not assignable to parameter of type 'Omit<HTMLImgAttributes, never> & HTMLAttributes<any> & { alt: string; src: string; }'.
  Type '{}' is missing the following properties from type '{ alt: string; src: string; }': alt, src (ts)

<img use:action />
```


### System Info

```shell
System:
    OS: Linux 6.5 Fedora Linux 39 (Container Image)
    CPU: (16) x64 AMD Ryzen 7 7840U w/ Radeon  780M Graphics
    Memory: 17.35 GB / 30.53 GB
    Container: Yes
    Shell: 5.2.21 - /bin/bash
  Binaries:
    Node: 20.10.0 - /usr/bin/node
    npm: 10.2.3 - /usr/bin/npm
  npmPackages:
    svelte: * => 4.2.8
```


### Severity

annoyance
Repository: pytorch
Issue: If error is raised in distributed setting, top level exception formatting should include rank
Labels: oncall: distributed,ezyang's list

### 🐛 Describe the bug

Per https://fb.workplace.com/groups/mast.users/posts/1443857702864955/ our internal logging infrastructure sucks and one consequence of this is if you raise a Python exception, you don't actually get to find out what rank it's associated with.

There are a few ways to deal with this:

1. We could override sys.excepthook to prefix all of the backtrace with rank prefix
2. We could force an exception logging message so that you get the rank there

(1) is a bit tricky to do by default since you don't want to clobber user excepthook. (2) might be doable capturing all exceptions escaping from our compile product.

### Versions

main

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225
Repository: svelte
Issue: DOM lib types are leaking into global scope
Labels: types / typescript,blocked by upstream

### Describe the bug

This bug is about global _type_ scope pollution, but I wasn't sure if I should open the issue here, or in the svelte repo, or in the svelte-check repo, or in the svelte language-tools repo (svelte-check? svelte-vscode?), so I apologize if this is not the correct place.

In my project, I have some files that will only be executed in a backend environment (Node JS). I can let SvelteKit know about that by either using the `lib/server` folder or a `.svelte.ts` file. I then setup some typescript projects for the different environments (using different default libraries) to also let Typescript know about it and check the code accordingly, but I realized it wasn't working as I expected. As an example, I was using the Worker class in a server file without importing it, which should trigger an error, but it wasn't, since Worker is global in the browser and the DOM lib types were leaking in the server files. The result is an uncaught runtime error.

The problem is in this line:
https://github.com/sveltejs/svelte/blob/05f99d20f9030f56b4991d0a07c3919be5f529ee/packages/svelte/svelte-html.d.ts#L1

The triple-slash reference makes the DOM types available globally if this file is included in a project.

The type error is suppressed (and it should NOT) if I check my code with svelte-check or in VSCode with the svelte vscode extension, but not when I'm running the tsc command in the command line, which leads me to believe that some of the toolings around the framework are directly or indirectly including that file.

### Reproduction

I've put a small app together[here](https://stackblitz.com/edit/stackblitz-starters-qq9wnm?file=src%2Flib%2Fserver%2Findex.ts) to try to demonstrate the issue, where I toggle the triple-slash reference in the file above on or off, and show the difference in the output of tsc and svelte-check.

### Logs

_No response_

### System Info

```Shell
System:
  OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
  CPU: (2) x64 Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz
  Memory: 453.38 MB / 3.83 GB
  Container: Yes
  Shell: 5.0.17 - /bin/bash
Binaries:
  Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
  npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
npmPackages:
  @sveltejs/adapter-auto: 3.1.0 => 3.1.0
  @sveltejs/kit: 2.2.0 => 2.2.0
  @sveltejs/vite-plugin-svelte: 3.0.1 => 3.0.1
  svelte: 4.2.8 => 4.2.8
  vite: 5.0.11 => 5.0.11
```


### Severity

annoyance

### Additional Information

Related to:

* [TS issue 33901](https://github.com/microsoft/TypeScript/issues/33901)
* [TS Strict Env Proposal](https://gist.github.com/RyanCavanaugh/702ebd1ca2fc060e58e634b4e30c1c1c)
Repository: PowerToys
Issue: [Power Rename] Folder tree like in Explorer with auto-fold function
Labels: Idea-Enhancement,Product-PowerRename,Needs-Triage

### Description of the new feature / enhancement

Folder tree like in Explorer with auto-fold function

### Scenario when this would be used?

I have multiple folders that I need to rename and I don't care about the contents.
But I can't hide contents of the folders, making it annoying to scroll through.

### Supporting information

_No response_
Repository: vscode
Issue: Minimising a Maximised Window and bringing it back up causes the window to appear stretched
Labels: bug,help wanted,upstream,windows,electron,multi-monitor

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: Version: 1.85.1 (user setup)
- OS Version: Windows_NT x64 10.0.22621 (Windows 11 23H2)

I have three monitors arranged:
1080p 23" left
1080p 23" centre
4k 15.6" laptop right

In Windows they appear like this:
![image](https://github.com/microsoft/vscode/assets/2286713/04b85432-5b9d-4374-bf96-6cc88b2feafd)

However obviously the 4k screen is physically smaller (but higher resolution) so it's the other way round physically to what's shown.

Steps to Reproduce:

1. Have a Maximised window and minimise it
2. Bring the window back up
3. The window will be stretched wide across the centre and right hand monitor:

Before:
![image](https://github.com/microsoft/vscode/assets/2286713/28f26f0f-3959-4750-b869-5b3f8ccbfebb)

After:
![image](https://github.com/microsoft/vscode/assets/2286713/e40bdd3f-6ede-40ec-801e-a88514d86f9d)
Repository: TypeScript
Issue: Crash when defining `Array` type via `[]` syntax
Labels: Bug,Help Wanted,Has Repro

### 🔎 Search Terms

Array type define crash

### 🕗 Version & Regression Information

- This is a crash

### ⏯ Playground Link

https://www.typescriptlang.org/dev/bug-workbench/?noLib=true#code/PTAEAEDsHsBkEsBGAuUAXATgVwKYCg0BPABx1AEEMMBDQgHgBUA+UAXlAYG0BdAbjyA

### 💻 Code

```ts
// @noLib: true
type Array<T> = T[];
```


### 🙁 Actual behavior

Typescript crashes:
```
createDeferredTypeReference@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:52280:42
getTypeFromArrayOrTupleTypeNode@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:52908:93
getTypeFromTypeNodeWorker@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:54875:20
getTypeFromTypeNode@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:54828:45
getDeclaredTypeOfTypeAlias@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:49869:33
tryGetDeclaredTypeOfSymbol@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:49955:18
getDeclaredTypeOfSymbol@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:49948:16
getTypeOfGlobalSymbol@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:52644:45
getGlobalType@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:52678:42
initializeTypeChecker@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:75719:27
createTypeChecker@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:42674:7
getTypeChecker@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:101959:46
synchronizeHostDataWorker@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:121935:17
synchronizeHostData@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:121830:11
getProgram@https://typescript.azureedge.net/cdn/5.4.0-dev.20240110/monaco/dev/vs/language/typescript/tsWorker.js:121997:9
updateFile@https://www.typescriptlang.org/17821066377c4486a980330106160c805ea5b4a9-5466acbcf54af90f679c.js:1:25348
G@https://www.typescriptlang.org/17821066377c4486a980330106160c805ea5b4a9-5466acbcf54af90f679c.js:1:17599
F@https://www.typescriptlang.org/17821066377c4486a980330106160c805ea5b4a9-5466acbcf54af90f679c.js:1:17638
A@https://www.typescriptlang.org/component---src-pages-dev-bug-workbench-tsx-6a9bdea3e00be7d97087.js:1:40663
9796/M/
```

### 🙂 Expected behavior

I expect an error message.

### Additional information about the issue

_No response_