sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: TypeScript
Issue: strictNullCheck False Posivitve when access propery on created object.
Labels: Suggestion,Experience Enhancement,Domain: Control Flow

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the *entire* template below.
-->

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  3.5.0-dev.20190501

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
strict false positive object

**Code**

```ts
import * as azure from "@azure/storage-blob";

interface ISaveBlobOptions {
    blobName: string;
    contentDisposition?: {
        fileName: string;
        type: "inline" | "attachment";
    };

    contentType: string;

    fileData: Buffer;
}

const saveBlobBase = async (input: ISaveBlobOptions): Promise<void> => {
    this.validateSaveBlobBase(input);

    await this.createStorage();

    const options: azure.IBlockBlobUploadOptions = {
        blobHTTPHeaders: {
            blobContentType: input.contentType
        }
    };

    if(input.contentDisposition) {
        // Getting Object is possibly 'undefined'.
        options.blobHTTPHeaders.blobContentDisposition = `${input.contentDisposition.type}; filename="${input.contentDisposition.fileName}"`;
    }

    if (input.fileData instanceof Buffer) {
        await this.saveBlobBuffer(input.blobName, input.fileData, options);
    } else if(this.isMulterFile(input.fileData)) {
        await this.saveBlobMulterFile(input.blobName, input.fileData, options);
    } else {
        throw new Error("Unknown type for param file");
    }
}

saveBlobBase({
    blobName: "myBlobName",
    contentDisposition: {
        fileName: "foo.bar",
        type: "inline"
    },
    contentType: "text/plain",
    fileData: Buffer.from("SOME TEXT")
});
```

tsconfig
```json
{
	"compilerOptions": {
		"target": "es2017",
		"module": "commonjs",
		"sourceMap": true,
		"strictPropertyInitialization": true,
		"strictNullChecks": true
	}
}
```

**Expected behavior:**

since when the creating the ```options``` variable the property ```blobHTTPHeaders``` is also defined. I would expect that accessing properties off of ```blobHTTPHeaders``` should not throw a "Object is possibly 'undefined'."

**Actual behavior:**

Getting Object is possibly 'undefined'.

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->

**Related Issues:** <!-- Did you find other bugs that looked similar? -->
Repository: godot
Issue: GIProbe based GI is wrong for child scene
Labels: discussion,topic:rendering,topic:3d

**Godot version:**
Godot master (#25670)

**OS/device including version:**
Windows 10 (up to date)

**Issue description:**
GI of GIProbe of child scene is used incorrectly for lighting
https://youtu.be/r5ANEgKRu40

**Steps to reproduce:**
* build a scene with a GIprobe and some geometry
* bake GIprobe
* save scene
* create a scene which references the scene from above
* add script to rate it at the node
* run

(see demo project)

**Minimal reproduction project:**
[testTranslatedGi0.zip](https://github.com/godotengine/godot/files/3135757/testTranslatedGi0.zip)
Repository: rust
Issue: Use of unknown feature gates should be a deny-by-default lint
Labels: A-lints,T-lang,T-compiler

#52644 made it an error to specify a `#![feature(...)]` that the compiler doesn't know about. It could be a deny-by-default lint instead. @varkor in https://github.com/rust-lang/rust/pull/52644#issuecomment-488445125:

> I don't see a strong reason not to make the unknown feature error a deny-by-default lint instead, which would allow you to silence it.
Repository: flutter
Issue: Add the ability to programmatically change mouse cursors.
Labels: c: new feature,framework,customer: crowd,a: desktop,customer: octopod,customer: webeap,customer: web10,P3,team-framework,triaged-framework

On desktop platforms with a mouse or trackpad, the pointer cursor typically changes in response to context.

This isn't yet possible on Flutter, and it should be possible.

The types of cursors and detectors that are needed for this feature are:
 - [x] "pointing finger" 👆cursors for controls and detectors for controls
 - [x]  I-beam cursors for text fields and detectors for text fields
 - [x] Resize cursors for handles and detectors for resize handles.
 - [x] "Processing" spinner cursors and detectors.
 - [ ] Custom cursors (including an "empty" cursor for hiding). 

----

Progression tracker:

- [x] Basic mouse cursor framework (https://github.com/flutter/flutter/pull/54171)
- Basic mouse cursor engines
  - [x] Android (https://github.com/flutter/engine/pull/18569)
  - [x] macOS (https://github.com/flutter/engine/pull/18131)
  - [ ] GLFW (very low priority)
  - [x] Windows (https://github.com/flutter/engine/pull/19459)
  - [x] Web (https://github.com/flutter/engine/pull/17718)
  - [x] GTK (https://github.com/flutter/engine/pull/18888)
- [x] Support all system mouse cursors (https://github.com/flutter/flutter/issues/60641)
  - [ ] Add the last cursor `IDC_UPARROW` (Low priority; suggestion appreciated https://github.com/flutter/flutter/issues/61397)
- Add mouse cursor API to widgets
  - [x] Phase 1: https://github.com/flutter/flutter/pull/57628
  - [ ] Remaining: https://github.com/flutter/flutter/issues/58192
- [ ] Image cursor framework https://github.com/flutter/flutter/issues/89351
- iPadOS support: See https://github.com/flutter/flutter/issues/55809
Repository: rust
Issue: Refactor away `TraitRef::trait_def_id`
Labels: C-enhancement,A-diagnostics,T-compiler,E-medium

The function

https://github.com/rust-lang/rust/blob/9b67bd42b7cbf97f72d039afcba02f5177d0d68c/src/librustc/hir/mod.rs#L2150-L2155

can abort compilation in case of errors. We're trying to eliminate as many (if not all) early aborts, so this needs to go. I haven't looked into how to fix this yet at all.

Originally reported in https://github.com/rust-lang/rust/pull/60462/files#r280262620

cc @estebank
Repository: youtube-dl
Issue: Download to MKV Direct instead of MP4 without muxing process after download.
Labels: question

<!--

######################################################################
  WARNING!
  IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################

-->


## Checklist

<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- Look through the README (http://yt-dl.org/readme) and FAQ (http://yt-dl.org/faq) for similar questions
- Search the bugtracker for similar questions: http://yt-dl.org/search-issues
- Finally, put x into all relevant boxes (like this [x])
-->

- [x] I'm asking a question
- [x] I've looked through the README and FAQ for similar questions
- [x] I've searched the bugtracker for similar questions including closed ones


## Question

<!--
Ask your question in an arbitrary form. Please make sure it's worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient.
-->

Download to MKV Direct instead of MP4 without muxing process after download. The videos I download are in a TS container but when use --fixup "never" the download completes and always is in a mp4 container which is great.

Today many videos are not malformed audio but have timestamps errors all the way through from many broadcaster services. If take the mp4 video and do mp4 > mkv then back to mp4 everything is fixed and playable without errors. These errors have been present for over a year now and mkv is the only fix I know of so far.

So what I need is instead of TS to mp4 is TS to mkv with using also the --fixup "never" command and have no aac malformed audio or any muxing after download not happen.

To download as is now instead but of mp4 video we have option to have mkv. Without any post processing to do this.
Repository: godot
Issue: Crashed thread give wrong flag for is_active true until call wait to finish.
Labels: bug,topic:core,confirmed

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:** 3.1 stable GDSCRIPT
<!-- Specify commit hash if non-official. -->


**OS/device including version:** ubuntu windows10 android.
<!-- Specify GPU model and drivers if graphics-related. -->


**Issue description:**
<!-- What happened, and what was expected. -->


**Steps to reproduce:** just crash a thread an call is_active but always return true. until you call wait to finish then it return false. i think this is so broken.


**Minimal reproduction project:** -
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
Repository: flutter
Issue: Allow any Route to be offstage for an undetermined period of time
Labels: framework,f: routes,c: proposal,P3,team-framework,triaged-framework

Note: I plan on implementing this feature myself, but it will likely require a breaking change, and the change is not trivial. 

## Use case

A package I'm working on needs to act as a man in the middle between a `Navigator.push` and the appearance of the route on the screen.

The idea is, a `NavigatorObserver` may force pushed routes to be in an offstage state similarly to how `Hero` works. But that offstage status may last for a lot longer than one frame. In the meantime, the previous route should stay visible and interactive.

Currently, doing so leads to a black screen.


## Proposal

- move `offstage` property from `ModalRoute` to `Route`.
- `offstage` routes do not make the previous route invisible even if they are `opaque`.
- `offstage` routes don't capture clicks.
- going from offstage to onstage must not destroy the `Route` state.
- a route that was never rendered as onstage before should correctly start its transition animation from 0 when it appears
- routes may be popped when offstage

Misc: 

- HeroController may mess up with the `opaque` variable.
- We'll probably want to move the "animation should start only when the route becomes onstage" out of `HeroController` and into `Route` itself.
Repository: godot
Issue: 3D Different Lightning Rendering OSX != Windows output
Labels: bug,topic:rendering,confirmed

**Godot version:**
3.1.1


**OS/device including version:**
OSX Macbook Version 10.14.4 
Intel Iris Plus Graphics 640



**Issue description:**
Actually I updated my project from 3.0.6 stable to 3.1.1 stable. Everything worked fine! The issue I encounter now is that my rendering scene is looking different on OSX and Windows and this shouldn't be the case by same configuration / objects etc. The Windows one is how it should look like

Windows look: https://ibb.co/S362T7C
![image](https://user-images.githubusercontent.com/8281454/57073785-22647980-6d1d-11e9-9789-d49848440b37.png)

OSX look: https://ibb.co/t2C5qc0
![image](https://user-images.githubusercontent.com/8281454/57073795-285a5a80-6d1d-11e9-95d5-12b42cab1787.png)


It seems like it is missing some light information or something. I deleted the .import folder and reimported everything still same issue. Maybe some one has a clue?
Repository: pytorch
Issue: Implement noise_shape keyword for Dropout layers
Labels: feature,module: nn,triaged

## 🚀 Feature
Tensorflow has a noise_shape keyword for tf.nn.dropout, which specifies which dimensions should have dropout masks calculated independently and which dimensions should have shared dropout masks. PyTorch should have a similar feature too.

## Motivation

This is a very useful feature to have (for example, if we process the same example multiple times, we may want to tie dropout masks for each time we see that example), and while easy to implement independently, would be good to have common functionality for.

## Pitch

Include extra kwarg to torch.nn.Dropout called ``noise_shape``, with the same functionality as tf.nn.dropout.

## Alternatives

Fairly easy to implement independently, but would save hassle for many people if there was a core implementation.
Repository: godot
Issue: Refactor code editors
Labels: enhancement,topic:editor,topic:codestyle

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
3.1.x

**Steps to reproduce:**
script_text_editor.cpp
shader_editor_plugin.cpp
text_editor.cpp

What these 3 files have in common is that they implement literally the same thing 3 times. Some examples:

Same set of enums:
https://github.com/godotengine/godot/blob/21e2419e24b9b868fe5da2735784f31366bd1629/editor/plugins/script_text_editor.h#L99-L104
https://github.com/godotengine/godot/blob/21e2419e24b9b868fe5da2735784f31366bd1629/editor/plugins/shader_editor_plugin.h#L72-L77
https://github.com/godotengine/godot/blob/21e2419e24b9b868fe5da2735784f31366bd1629/editor/plugins/text_editor.h#L64-L69

Same edit menu:
https://github.com/godotengine/godot/blob/21e2419e24b9b868fe5da2735784f31366bd1629/editor/plugins/shader_editor_plugin.cpp#L502-L508
https://github.com/godotengine/godot/blob/21e2419e24b9b868fe5da2735784f31366bd1629/editor/plugins/text_editor.cpp#L577-L584
https://github.com/godotengine/godot/blob/21e2419e24b9b868fe5da2735784f31366bd1629/editor/plugins/script_text_editor.cpp#L1581-L1587

Same menu actions:
https://github.com/godotengine/godot/blob/21e2419e24b9b868fe5da2735784f31366bd1629/editor/plugins/shader_editor_plugin.cpp#L245-L250
https://github.com/godotengine/godot/blob/21e2419e24b9b868fe5da2735784f31366bd1629/editor/plugins/text_editor.cpp#L358-L365
https://github.com/godotengine/godot/blob/21e2419e24b9b868fe5da2735784f31366bd1629/editor/plugins/script_text_editor.cpp#L924-L931

There's muuuch more of it. And the worst part is when you want to add some feature to code editor. You basically need to repeat the code 3 times.

IMO the editors should be refactored to cut the repetitions as much as possible. There are differences here and there, but I bet it's possible to rewrite them in a way that doesn't repeat 80% of lines 3 times.
Repository: rust
Issue: Tracking issue for "Lazy normalization"
Labels: A-type-system,A-trait-system,T-compiler,C-tracking-issue,A-const-generics,A-lazy-normalization,T-types

# What is this?

"Lazy normalization" is a change to how we handle associated types (and constants) so that we wait until we have to equate an associated type (or constant) has to be equated or processed to normalize it (i.e., figure out if there is an impl we can use to find its definition), rather than doing so eagerly. This has a number of advantages, and in particular for const generics it can prevent a large number of cyclic errors.

# Subissues

* https://github.com/rust-lang/rust/issues/72219 -- Lazy normalization for constants

# Further background reading

## What is this "lazy normalization"? (see https://github.com/rust-lang/rust/issues/60471#issuecomment-523394151)

> @Aaron1011 Normalization is replacing "projections" (such as `<T as Trait>::AssocType` or unevaluated constant expressions - a better name than "projection" might be "expression" or "call" - something that only says how to get to a final "value", not what it is) with what they resolve/evaluate to.
> E.g. `&<Rc<str> as Deref>::Target` becomes `&str`, and `[T; {1+1}]` becomes `[T; 2]`.
> 
> Right now all of this is done "eagerly", i.e. as soon as possible, and always (during typeck, or whenever there is enough information to normalize further), but that causes some issues:
> 
> * for associated types it's HRTB-related (IIRC)
> 
> * for type-level constants it's cyclic dependencies between the constant and the parent definition it's found in, which is why we can't fix #43408 (it's a one-line change, but then not even libcore compiles anymore)
> 
> 
> Lazy normalization would simply defer the work of resolving/evaluating such type-level constructs until the very moment they are needed (such as when requiring that two types are the same, or when computing the low-level layout of a type for miri/codegen).
> The associated type problem is more subtle (at least from what I've heard), but for constant expressions in types, it will simply break the cyclic dependencies because definitions will no longer force the evaluation of constant expressions they contain.
Repository: flutter
Issue: Gaining/losing focus and opening/closing the keyboard must not be strongly coupled
Labels: a: text input,c: new feature,framework,customer: crowd,c: proposal,f: focus,P3,team-framework,triaged-framework

As of now, gaining/losing focus and opening/closing the keyboard are strongly coupled, and they shouldn't be. Please see: https://github.com/flutter/flutter/issues/16863. 

One good solution is a change in `FocusNode`. It could have a few more methods besides `unfocus` (https://github.com/flutter/flutter/issues/7247). to maintain backwards compatibility I suggest:

-  `closeKeyboard()` which would close the keyboard without removing focus from the TextField. 
-  `openKeyboard()` which would open the keyboard and connect it to the textField even if the TextField previously had focus already (please note `focus` doesn't open the keyboard if the keyboard already has focus). 
- `shouldOpenKeyboard` is a mutable field which is `true` by default. When the `TextField` gains focus by the user tapping it, or by the calling of `FocusScope.of(context).requestFocus(focusNode);` it would check this field to decide if it should open the keyboard or not.
Repository: flutter
Issue: Exception in debugFillProperties causes Flutter tool to exit
Labels: tool,d: api docs,a: error message,P3,team-tool,triaged-tool

Steps to reproduce:

```dart
import 'package:flutter/foundation.dart';
import 'package:flutter/widgets.dart';

void main() => runApp(MyWidget());

class MyWidget extends StatelessWidget {
  List<int> aList;

  @override
  Widget build(BuildContext context) => Placeholder();

  @override
  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
    super.debugFillProperties(properties);

    properties.add(IntProperty('name', aList[0]));
  }
}
```

Do `flutter run`, press `w` to print the widget hierarchy.

Result:
```
I/flutter ( 5395): WidgetsFlutterBinding - CHECKED MODE                         
I/flutter ( 5395): ══╡ EXCEPTION CAUGHT BY FLUTTER FRAMEWORK ╞══════════════════
═══════════════════════════════════════
I/flutter ( 5395): The following NoSuchMethodError was thrown during a service extension callback for
I/flutter ( 5395): "ext.flutter.debugDumpApp":
I/flutter ( 5395): The method '[]' was called on null.
I/flutter ( 5395): Receiver: null
I/flutter ( 5395): Tried calling: [](0)
I/flutter ( 5395):
I/flutter ( 5395): When the exception was thrown, this was the stack:
...
Error -32000 received from application: Server error
JSON-RPC error -32000: Server error
package:json_rpc_2/src/client.dart 110:64              Client.sendRequest
package:json_rpc_2/src/peer.dart 79:15                 Peer.sendRequest
...
Application finished.
```

Can we handle this better?

(As an aside, I ran into this because I had a `debugFillProperties` implementation on a `State`-derived class that accidentally accessed something that hadn't been set yet.  I wonder if maybe we should consider making debug builds automatically call `debugFillProperties()` whenever calling `State.build` (or perhaps recommend that people do it)?)
Repository: vscode
Issue: Regex pattern to clear all problems of a task owner
Labels: feature-request,tasks

Some compilers or build pipelines (e.g. create-react-app) emit different output if there are no errors vs. if there are 1+ errors or warnings.  This makes it difficult to build problem matchers because start/end patterns need to have both a "errors" and a "no errors" version inside the same regex.

It would be better if there were a new pattern in task config (e.g. `clearAllPattern`) that, if found, would clear all existing problems from the current owner.  

For non-background tasks this would be straightforward-- if the pattern is matched, then clear all problems from the owner and ignore all problems from the currently-executing task until the task exits.

For background tasks, it'd be a little more complicated: 
1) clear all problems from the owner
2) reset the state if it's currently after a `beginsPattern` but before an `endsPattern`
3) wait until the next `beginsPattern` before logging more problems.

As a side effect, this feature would provide an escape hatch for users who want to clear problems by running a task (#50448), because you could create a task with a `clearAllPattern` that always matches.
Repository: flutter
Issue: [platform_views] VirtualDisplay need only be the worst case size of the screen
Labels: framework,a: platform-views,c: proposal,P2,team-framework,triaged-framework

We should be able to pass in the offset and other information from the framework to composit only the visible part of the platform view in Android.

see: https://github.com/flutter/flutter/issues/28978 for an example use case.
Repository: rust
Issue: Compiler-internal lint for public libcore items not reexported in libstd
Labels: C-enhancement,A-lints,P-medium,T-compiler

Inspired by #60185.
Repository: flutter
Issue: RenderPointerListener should send onExit before it is detached
Labels: framework,f: gestures,c: proposal,P2,team-framework,triaged-framework

Right now, when the `RenderPointerListener` is detached, it notifies the `MouseTracker` that it needs to detach an annotation.  This is correct behavior, since the `onExit` for the annotation needs to be called whenever the annotation is removed, but because it's being called from `detach`, it is possible that the `onExit` will call a `setState` for a widget during the wrong build phase.

It's not clear what the fix for this is: the only idea I had was to introduce a "preDetach" pass that lets everything that is about to be detached know that it will shortly be detached, and then the `MouseTracker` can invoke the `onExit` during that phase instead. It seems like an oversize hammer for this problem, though.
Repository: rust
Issue: rustdoc type-based search appears to not support searching by built-in types
Labels: T-rustdoc,C-bug,A-type-based-search

You can search for functions that appear to satisfy some sort of a shape/type as such `input -> output`, however that will not work for more complicated searches involving built-in types, including:

* slices `[T] -> *`;
* pointers `*mut T -> *`;
* tuples `(*, *)`;
    * and similarly multiple arguments
* probably more.

Instead of attempting to guess a what kind of search this is based on `->` I propose that we add another "type" indicating that this is a signature we’re looking for and take a type of the function pointer as an argument, so something like this would work:

* `sig:fn([T]) -> *`
* `sig:fn(*mut T) -> T`
* `sig:(A, B)
* `sig:...`
Repository: go
Issue: net/http: have DefaultTransport support all_proxy (SOCKS5) by default
Labels: NeedsInvestigation,FeatureRequest

Now that https://go-review.googlesource.com/c/net/+/168921 is in, we have good context support for doing SOCKS5 dials in x/net/proxy.

We should use it from net/http.DefaultTransport so the $ALL_PROXY (and $all_proxy) environment variable lets users configure SOCKS5.