sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: rust
Issue: Tracking Issue for "More Qualified Paths"
Labels: A-parser,A-associated-items,T-lang,C-tracking-issue,S-tracking-ready-to-stabilize,F-more_qualified_paths

<!--
NOTE: For library features, please use the "Library Tracking Issue" template instead.

Thank you for creating a tracking issue! 📜 Tracking issues are for tracking a
feature from implementation to stabilisation. Make sure to include the relevant
RFC for the feature if it has one. Otherwise provide a short summary of the
feature and link any relevant PRs or issues, and remove any sections that are
not relevant to the feature.

Remember to add team labels to the tracking issue.
For a language team feature, this would e.g., be `T-lang`.
Such a feature should also be labeled with e.g., `F-my_feature`.
This label is used to associate issues (e.g., bugs and design questions) to the feature.
-->

This is a tracking issue for the "more qualified paths" feature. This feature originally grew out of a bug report https://github.com/rust-lang/rust/issues/79658 where structs with qualified paths could not be constructed or used in patterns. 

For instance:

```rust
fn main() {
    let <Foo as MyTrait>::Assoc { a} = <Foo as MyTrait>::Assoc { a: 2 };
    // The above would previously not parse.
    assert!(a == 2);
}

struct StructStruct {
    a: i8,
}

trait MyTrait {
    type Assoc;
}

struct Foo;

impl MyTrait for Foo {
    type Assoc = StructStruct;
}
```

See the implementation PR [#80080](https://github.com/rust-lang/rust/pull/80080) for more detailed discussion. 

The feature gate for the issue is `#![feature(more_qualified_paths)]`.

### About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

### Steps
<!--
Include each step required to complete the feature. Typically this is a PR
implementing a feature, followed by a PR that stabilises the feature. However
for larger features an implementation could be broken up into multiple PRs.
-->

- [x] Implement the feature https://github.com/rust-lang/rust/pull/80080
- [ ] Adjust documentation ([see instructions on rustc-dev-guide][doc-guide])
- [ ] Stabilization PR ([see instructions on rustc-dev-guide][stabilization-guide])

[stabilization-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs

### Unresolved Questions

### Implementation history

https://github.com/rust-lang/rust/pull/80080
Repository: react-native
Issue: Host environment: Blob and File objects don't have the right string tag
Labels: Needs: Triage :mag:,Never gets stale

## Description
If I apply `toString` to a `Blob` or `File` object, the result is not `[object Blob]` or `[object File]` as one would expect, but `[object Object]`.

This leads to issues for example using Axios, that uses this method to check if what gets passed to it as data is a particular type: https://github.com/axios/axios/blob/e9965bfafc82d8b42765705061b9ebe2d5532493/lib/utils.js#L148

As a workaround I put those two lines in `index.js` before everything else:
```javascript
Blob.prototype[Symbol.toStringTag] = 'Blob'
File.prototype[Symbol.toStringTag] = 'File'
```

## React Native version:
```
info Fetching system and libraries information...
System:
    OS: macOS 11.4
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 19.95 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.16.1 - /usr/local/bin/node
    Yarn: 1.22.10 - ~/.npm/packages/bin/yarn
    npm: 6.14.12 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK: Not Found
    Android SDK:
      API Levels: 28, 29, 30
      Build Tools: 28.0.3, 29.0.2, 30.0.3
      System Images: android-22 | Google APIs Intel x86 Atom, android-29 | Intel x86 Atom_64, android-30 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.8743.12.41.7042882
    Xcode: /undefined - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_282 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1 
    react-native: 0.64.2 => 0.64.2 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found
```

## Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

1. Render this in a component: `toString.apply(new Blob())`
2. It shows as `[object Object]`

## Expected Results
The result should be `[object Blob]`

## Snack, code example, screenshot, or link to a repository:
https://snack.expo.io/VdqTTyUBn

Works fine in Web, the error shows in Android.
Repository: go
Issue: x/time/rate: Limiter.Wait waits too long
Labels: NeedsInvestigation

### What version of Go are you using (`go version`)?

<pre>
$ go version

1.16.5
</pre>

### Does this issue reproduce with the latest release?
yes, tested on 1.17beta1 as well.

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/root/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/root/sdk/go1.16.5"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/root/sdk/go1.16.5/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.5"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/user/go-rate-limiter-bug/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2983600181=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### What did you do?

I created a reproduction case: https://github.com/beanieboi/go-rate-limiter-bug/blob/main/main_test.go
```
func TestRateLimiter(t *testing.T) {
	ctx := context.Background()
	numItems := 300000

	endTime := time.Now().Add(10 * time.Second)
	timeRemaining := time.Until(endTime)
	dispatchInterval := time.Duration(int64(timeRemaining) / int64(numItems))
	limiter := rate.NewLimiter(rate.Every(dispatchInterval), 1)

	loopStart := time.Now()
	for i := 0; i < numItems; i++ {
		err := limiter.Wait(ctx)
		if err != nil {
			t.Errorf("error waiting: %v", err)
		}
		// do actual dispatching
	}
	duration := time.Since(loopStart)

	if duration > 15*time.Second {
		t.Errorf("expected execution time of less than 15, got: %v", duration)
	}
}
```
in short. we are using the time `rate.NewLimiter()` with `limiter.Wait(ctx)` and see much longer wait times than on 1.15.7

<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->



### What did you expect to see?
the same behaviour as on 1.15.7, the tests linked above should finish within ~15s

### What did you see instead?
the limiter is waiting too long and the whole test takes ~160s instead of ~15s
Repository: terminal
Issue: Weird text overwriting in WPF control in VS2019
Labels: Issue-Bug,Product-Terminal,Priority-2,Area-WPFControl


Here's Visual Studio 2019:

![PSReadLine bug](https://user-images.githubusercontent.com/9283914/123458157-03a05b80-d5e5-11eb-8360-53d93805af6d.gif)

_Originally posted by @SetTrend in https://github.com/microsoft/terminal/issues/10332#issuecomment-868693082_
Repository: material-ui
Issue: [icons] Document what and why icons are included/excluded
Labels: new feature,package: icons

HI, I want to ask what is the reason for adding icons to blacklist? On Google icons [website](https://fonts.google.com/icons) I see that they are licences under Apache license 2.0, which basically means Open Source.

I've found [this](https://github.com/mui-org/material-ui/pull/22186) issue which says something about irrelevant icons, but what is considered irrelevant and why?

I've been using both of those icons, but now they are not available anymore. Should I add them myself if I really need them?
'VerticalDistribute', // Advanced text editor
'HorizontalDistribute', // Advanced text editor

- [ x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.

Thank you,
Vladimir
Repository: terminal
Issue: Relatively "more bold" discussion
Labels: Area-Rendering,Product-Terminal,Issue-Task

A follow up to #10498.

If the user already has a bold font selected, should we make the font for bold text **even more bold**?

Options:
* when the user has a bold font, leave intense text just **bold**
* increase the font weight **EVEN MORE**, so bold text becomes extra bold (up to a sensible max)
  * how does this play when the user's default font weight is something like extra-light? does extra-light -> light -> normal -> bold -> extra-bold?
* possible have a setting to switch between the above behaviors? (might be overkill)
* Allow the user to specify a custom "bold text font weight", so they could have extra-bold text by default, and "bold" text we could render as extra-light (if you're a crazy person) (also overkill)

Relevant comments:

> https://github.com/microsoft/terminal/issues/109#issuecomment-743929268 is probably the comment you're looking for?

> Just multiply by 1.75, cap it at 1000, and call it a day, perhaps. I run font weight 450 locally ("Retina" weight) rather than 400, so this would come out closer to Extra Bold than Bold, which seems reasonable to me. If the font doesn't support variable-width, let DirectWrite work out which weight instance to pick.
> 
> If it's helpful, CSS defines [its own transformation for bold](https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight#meaning_of_relative_weights), but that doesn't allow for variable-weight fonts, it relies on their [font rounding calculation](https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight#fallback_weights) to pick a "named" weight first, then enbolden it. I would expect `DirectWrite` to do that for us.


et al in https://github.com/microsoft/terminal/pull/10498/files#r657675585.
Repository: godot
Issue: Tree node doesn't emit the empty_rmb signal when the root item is hidden
Labels: bug,topic:gui

### Godot version

v3.3.2.stable.official

### System information

Windows 10

### Issue description

If you have a `Tree` node and connect to the `empty_rmb` signal, the signal will not be emitted if the root item is hidden, which is different to the `empty_tree__rmb_selected` signal which explictly check whether the root item is hidden

https://github.com/godotengine/godot/blob/56d712686496845cab3bfd6a6ed67e4efc2c39d5/scene/gui/tree.cpp#L2528-L2530

vs

https://github.com/godotengine/godot/blob/56d712686496845cab3bfd6a6ed67e4efc2c39d5/scene/gui/tree.cpp#L3183-L3188

### Steps to reproduce

```
extends Tree


func _ready():
	create_item()
	hide_root = true
	connect("empty_tree_rmb_selected", self, "tree_empty_tree_rmb_selected")
	connect("empty_rmb", self, "tree_empty_rmb")

func tree_empty_rmb(position):
	print("empty rmb")

func tree_empty_tree_rmb_selected(position):
	print("empty tree rmb selected")

```

### Minimal reproduction project

[TreeEmptyRmb.zip](https://github.com/godotengine/godot/files/6778882/TreeEmptyRmb.zip)
Repository: ant-design
Issue: Rate element has very poor rendering performance
Labels: help wanted,Inactive,⚡️ Performance

- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.

### Reproduction link
[![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/half-star-antd4166-forked-p2klk?file=/index.js)

### Steps to reproduce
Create a page with dozens of Rate elements.

### What is expected?
The rendering is fast, those are just star images.

### What is actually happening?
The rendering is very slow.

| Environment | Info |
|---|---|
| antd | 4.16.6 |
| React | 16.14 |
| System | Windows 10 |
| Browser | Chrome 91 |

---
I created a page with a catalog, each item with a Rate. The page loading is very slow, and I tracked it down to the Rate element. Since I believe that it's a common use case for Rate to be present for multiple items on a page, I think that it's important to address.

On the test page, you can see that I created 100 Rate elements, which is not too many, and the rendering time is several seconds!


<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: storybook
Issue: Addon-docs: Support CSF3 play function
Labels: feature request,addon: docs,csf3

> As a user, I'd like to see stories that use `play` functions to achieve interactions the same on the Docs page as how it appears on the Storybook Canvas.

Storybook CSF3 adds a `play` function for scripted interaction with components after a story has rendered. This currently does not work in the docs tab. We need to make it work:

* [ ] For iframe stories
* [ ] For inline stories

There are a few different issues to deal with around dueling `play` functions and dueling focus.

## Dueling play functions

Two `play` functions can't run at the same time: their events will clobber one another, especially if they require focus, e.g. keyboard events.

One way to deal with this is to run play functions sequentially. This can be problematic for long-running play functions.

Another way to deal with it is to not run `play` functions on the Docs page at all, and have UI by which the user can run a `play` function.

## Dueling focus

A related issue is dueling Focus. Even if a `play` function finishes instantaneously, if story `A` shows element `A` focused, and story `B` shows element `B` focused, then at most one of those stories can show correctly on the Docs page.

The sequential approach above won't fix this. Only the `play` function UI, would work for this.

## Proposal

Since the `play` function UI works for all cases, that's a relatively simple solution.

## Alternative

A more complex solution would be to make it configurable with a parameter, e.g.

```js
parameters: {
  docs: {
    playFunction: true,
  }
}
```

And then sequentially play all stories with `playFunction` true. This way the CSF author has control and can set `playFunction` to false for long-running stories.


┆Issue is synchronized with this [Asana task](https://app.asana.com/0/1200510412866230/1200575273570648) by [Unito](https://www.unito.io)
Repository: TypeScript
Issue: JSDoc param tag's default value parsing should support non-TS expressions
Labels: Suggestion,Needs Proposal

# Suggestion

probably related to #44930 but a different use case. default values on `@param`: https://jsdoc.app/tags-param.html
<!--
  Please fill in each section completely. Thank you!
-->

## 🔍 Search Terms
`jsdoc param default value`

## ⭐ Suggestion

Please allow for default value params parsing
```
/**
 * @param {string} [somebody=John Doe] - Somebody's name.
 */
export function sayHello(somebody) {
}
```
currently parses to tags:
```
[
  {
    name: "param",
    text: [
      {
        text: "somebody",
        kind: "parameterName"
      },
      {
        text: " ",
        kind: "space"
      },
      {
        text: "Doe] - Somebody's name.",
        kind: "text"
      }
    ]
  }
]
```
possibly add a new node
```
{
    text: "John Doe",
    kind: "defaultValue"
  },
```
and clean up the description from
```
{
  text: "Doe] - Somebody's name.",
  kind: "text"
}
```
to 
```
{
  text: "- Somebody's name.",
  kind: "text"
}
```

p.s. it mighy also be worth in general to clean up parameter descriptions `text` from the leading hyphen
Repository: vscode
Issue: Native Notebooks - Keyboard shortcut for navigating in/out of notebook
Labels: bug,ux,notebook-commands

Reporting on behalf of customer: 

Steps to Reproduce:

1. Put focus on cell editor
2. Press escape twice
3. Focus ends up...somewhere? 
4. Pressing tab brings focus back into notebook but into a different cell completely 

Should tab be returning to the same cell in the notebook? 
If not is there another shortcut that could help navigate back? 

![esc behavior](https://user-images.githubusercontent.com/19276747/124814764-41717e00-df1b-11eb-88b2-6af033f6934e.gif)
Repository: go
Issue: cmd/go: bad error message for local imports in module mode
Labels: NeedsInvestigation,GoCommand,modules

In module mode, if an `import` statement refers to a relative path it is currently supposed to fail with `relative import not supported`:
https://github.com/golang/go/blob/600a2a4ffb9a273a3a1635b60120ffc768741aa9/src/cmd/go/internal/modload/import.go#L245-L247

However, we seem to be missing test coverage for that error message, and the actual error that is printed for that case is substantially different:

```
$ go version
go version devel go1.17-912f07504 Fri Jul 2 21:06:08 2021 +0000 linux/amd64

$ go build .
main.go:4:2: local import "./foo" in non-local package

-- foo/foo.go --
package foo
-- go.mod --
module example.com/m

go 1.17
-- main.go --
package main

import (
	_ "./foo"
)

func main() {}
```

<details><summary><code>$ go env</code></summary>

```
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/bcmills/.cache/go-build"
GOENV="/usr/local/google/home/bcmills/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/tmp/tmp.8tQ48Pjrac/.gopath/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/tmp/tmp.8tQ48Pjrac/.gopath"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/google/home/bcmills/sdk/gotip"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/google/home/bcmills/sdk/gotip/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel go1.17-912f07504 Fri Jul 2 21:06:08 2021 +0000"
GCCGO="/usr/local/google/home/bcmills/bin/gccgo"
AR="ar"
CC="gcc"
CXX="c++"
CGO_ENABLED="1"
GOMOD="/tmp/tmp.8tQ48Pjrac/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build181655066=/tmp/go-build -gno-record-gcc-switches"
```

</details>

That error message comes from here:
https://github.com/golang/go/blob/600a2a4ffb9a273a3a1635b60120ffc768741aa9/src/cmd/go/internal/load/pkg.go#L758

which implies that the error returned by `importFromModules` is either not produced or not propagated as we expect.

Discovered via https://stackoverflow.com/q/68261085.

CC @matloob @jayconrod
Repository: go
Issue: cmd/compile, go/types, types2: rename 'imported and not used' error to 'imported but not used'
Labels: help wanted,NeedsFix

Commit 449b6ab has reworded, in Go 1.14, the "declared **and** not used" error message as "declared **but** not used". I propose to do the same for the "imported and not used" error message.

If an imported package is not used, instead of

```
imported and not used: "fmt"
```

the error message would be

```
imported but not used: "fmt"
```
Repository: rust
Issue: Unnecessary parentheses warning for (A | B) as :pat in 2018 edition
Labels: A-diagnostics,P-medium,T-compiler,C-bug,L-unused_parens

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=30f392098326a970e468c3125f7c5413
```rust
macro_rules! mac {
    ($expr:expr, $pat:pat) => {
        match $expr {
            $pat => {},
            _ => panic!(),
        }
    };
}

fn main() {
    mac!('a', ('a' | 'A'));
}
```

The current output is:

```
   Compiling playground v0.0.1 (/playground)
warning: unnecessary parentheses around pattern
  --> src/main.rs:12:15
   |
12 |     mac!('a', ('a' | 'A'));
   |               ^^^^^^^^^^^ help: remove these parentheses
   |
   = note: `#[warn(unused_parens)]` on by default

warning: 1 warning emitted
```

While it would be true that these parentheses are unnecessary in 2021 edition, (and also of course in the macro expanded output as well, which is *why* the warning occurs), they are required here in 2018 edition because `:pat` cannot match `'a' | 'A'` in this edition, making the warning a nuisance.
Repository: pytorch
Issue: Merge fork of upload-artifact-s3 to a single commit
Labels: triaged,better-engineering

We have a few versions of this action laying around from a fork I created (mostly to add some extra features quickly and enable custom paths):

```
$ ag --hidden upload-artifact-s3 | awk '{for (i=2; i<=NF; i++) print $i}' | grep upload | sort | uni
driazati/upload-artifact-s3@21c31d0a7bcb056ca50bd6ce197ba6507c26a1be
driazati/upload-artifact-s3@50adbe4ef0b6d9221df25c18c5fc528dfcb7c3f8
seemethere/upload-artifact-s3@9d7ceb0ab39c2c88d93ef7792b27425b27d59162
```

We should merge these all into a single GitHub action and have only a single hash for it in the codebase. It's a little tricky since the different hashes are all computing the path in S3 differently, but we could probably decide the path entirely with GitHub Action's interpolation before the values even get to the action.
Repository: node
Issue: doc: mark String decoder as legacy
Labels: doc,string_decoder

# 📗 API Reference Docs Problem

https://nodejs.org/docs/latest-v16.x/api/string_decoder.html

## Description

Like with util inherit and querystring can you also mark string_decoder as legacy and say something in terms of:

> The String decoder is considered Legacy. While it is still maintained, new code should use the `TextDecoder` API instead.

Would be best for cross platform coding... Maybe even possible deprecate it?

- [ ] I would like to work on this issue and submit a pull request.
Repository: flutter
Issue: 'flutter devices --machine' can print upgrade banner
Labels: tool,P3,team-tool,triaged-tool

See https://github.com/flutter/flutter/issues/86052

`--machine` should suppress that and any similar banner.