sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: pytorch
Issue: AdamW is CPU-bottlenecked with FSDP2, with slow foreach kernels
Labels: module: optimizer,triaged,module: fsdp

### 🐛 Describe the bug

This is an image model, with many small weights. Notice the large white gaps in the GPU section, corresponding to the CPU launchers taking a very long time.
![Screenshot 2024-08-21 at 7 00 26 PM](https://github.com/user-attachments/assets/8dff643e-011f-4999-9391-612aa18e277f)
The perf impact is moderate: AdamW is 2.5% of the total step time with FSDP1, and 7.5% of the step time with FSDP2.

The slowdown was observed with both `fused=True` and `fused=False`. I did not test with torch.compile, since Eren says it doesn't work with changing image dimensions. (Other people have said it should work with dynamic shapes, but I will defer that to later.)

(EDIT: thinking about it for 5 more seconds, I can compile the optimizer separately, so I'll try that next.)

### Versions

2.4.0. [collect_env_result.txt](https://github.com/user-attachments/files/16703051/collect_env_result.txt)


cc @vincentqb @jbschlosser @albanD @janeyx99 @crcrpar @zhaojuanmao @mrshenli @rohan-varma @awgu @fegin @kwen2501 @chauhang
Repository: material-ui
Issue: [joy-ui][Circular Progress] Svg progress bar is misaligned and its length changes when zoomed in Safari
Labels: on hold,component: CircularProgress,package: joy-ui,enhancement

### Steps to reproduce

Link to live example: https://mui.com/joy-ui/react-circular-progress/#introduction

Steps:
1. Open link on Safari.
2. Zoom in or zoom out.


### Current behavior

1. Progress bar is misaligned 
2. The progress has changed.

<img width="304" alt="스크린샷 2024-08-22 11 21 23" src="https://github.com/user-attachments/assets/18199a32-9928-4524-bc86-05a5761e2b27">


### Expected behavior

1. Progress bar should be centered.
2. The progress should not change.

### Context

I think the misalignment issue is caused by Safari miscalculating the transform and transform origin when zooming.

How about adding the animation to the top layer, like [material-ui's Progress](https://mui.com/material-ui/react-progress)?
I think it would be possible to apply the rotation transform to the parent svg element instead of the circle element, or to split the Progress and Track into two svg elements.

### Your environment

<details>
  <summary><code>npx @mui/envinfo</code></summary>

```
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
```
</details>


**Search keywords**: Circular Progress align
Repository: tensorflow
Issue: Proposal for Enhancing Neural Network Training: Unified Gradient Direction for Faster Convergence and Improved Accuracy
Labels: stat:awaiting tensorflower,type:feature,type:performance

### Issue type

Performance

### Have you reproduced the bug with TensorFlow Nightly?

Yes

### Source

source

### TensorFlow version

ALL

### Custom code

Yes

### OS platform and distribution

_No response_

### Mobile device

_No response_

### Python version

_No response_

### Bazel version

_No response_

### GCC/compiler version

_No response_

### CUDA/cuDNN version

_No response_

### GPU model and memory

_No response_

### Current behavior?

In the current implementation of neural network training within TensorFlow, gradient descent typically relies on the average of gradients during the optimization process. While this approach is effective, there may be potential to enhance training efficiency and accuracy by exploring alternative methods for determining the direction of gradient updates.

I have developed a method that identifies a unified direction rather than merely averaging the gradients, and preliminary experiments suggest that this approach leads to faster convergence and improved model accuracy. I believe this could be a valuable addition to TensorFlow's optimization techniques.

I would appreciate the TensorFlow Development Team's feedback on this idea and am happy to provide further details or collaborate on its implementation.

### Standalone code to reproduce the issue

```shell
https://github.com/TingjiaInFuture/UnionGradientDescent
```


### Relevant log output

_No response_
Repository: vscode
Issue: bug: cursor undo after update activeEditor text
Labels: info-needed,snippets

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 
- OS Version: 

Steps to Reproduce:

1. use api `activeTextEditor.insertSnippet` add some snippet
2. and use `ctrl + -`, will not cursor back before

expect: after updated, still back true position, or have some way to update `cursorundo`
Repository: pytorch
Issue: Python310 trying to run GFPGAN comes: ImportError: cannot import name 'sym_float' from 'torch' (unknown location)
Labels: triaged

### 🐛 Describe the bug

Windows 11
Python310 trying to run GFPGAN ( python inference_gfpgan.py -i inputs/whole_imgs -o results -v 1.3 -s 2) 
whatever I try it comes: 

" from torch import sym_float, sym_int, sym_max
ImportError: cannot import name 'sym_float' from 'torch' (unknown location)"


### Versions

Any remedy?
Repository: rust
Issue: Tracking Issue for `new_zeroed_alloc`
Labels: T-libs-api,C-tracking-issue

Feature gate: `#![feature(new_zeroed_alloc)]`

Split-out from https://github.com/rust-lang/rust/issues/63291 as a result of stabilizing most of its API! It's zeroed instead of uninit constructors, nothing too complicated!


### Public API

It's `new_zeroed` and `new_zeroed_slice` on every major allocation type like Box, Rc, Arc.

```rust
impl<T> Box<T> { pub fn new_zeroed() -> Box<MaybeUninit<T>> {…} }
impl<T> Arc<T> { pub fn new_zeroed() -> Arc<MaybeUninit<T>> {…} }
impl<T> Rc<T> { pub fn new_zeroed() -> Rc<MaybeUninit<T>> {…} }

impl<[T]> Box<T> { pub fn new_zeroed_slice() -> Box<MaybeUninit<[T]>> {…} }
impl<[T]> Arc<T> { pub fn new_zeroed_slice() -> Arc<MaybeUninit<[T]>> {…} }
impl<[T]> Rc<T> { pub fn new_zeroed_slice() -> Rc<MaybeUninit<[T]>> {…} }
```

### Steps / History

- Implementation: #...
  - added in https://github.com/rust-lang/rust/pull/66128
  - other API was added in https://github.com/rust-lang/rust/issues/63291
- [ ] Final comment period (FCP)[^1]
- [ ] Stabilization PR


### Unresolved Questions

- idk lol

[^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html
Repository: rust
Issue: Tracking Issue for `box_uninit_write`
Labels: T-libs-api,C-tracking-issue,F-box_uninit_write

Feature gate: `#![feature(box_uninit_write)]`

Split-out from https://github.com/rust-lang/rust/issues/63291 as a result of stabilizing most of its API! It's a way to write to the MaybeUninit on the Box and thus initialize it!

### Public API

```rust
impl<T, A> Box<MaybeUninit<T>, A> {
    pub fn write(mut boxed: Self, value: T) -> Box<T, A>;
}
```

### Steps / History

- Implementation: #...
  - honestly have no idea
  - related API was added in https://github.com/rust-lang/rust/issues/63291
- [ ] Final comment period (FCP)[^1]
- [ ] Stabilization PR


### Unresolved Questions

- idk lol

[^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html
Repository: ollama
Issue: Request official guidelines
Labels: feature request

Dear team,

I would like to request two official guidelines:

1. Version control of Ollama models, especially different versions of models under the same tag.
2. Import Hugging Face models to Ollama.

Sincerely,
Zhangcheng Qiang
Repository: tensorflow
Issue: `tf.keras.Sequential` not a `tf.Module` since 2.16?
Labels: type:support,comp:keras,TF 2.16

### Issue type

Support

### Have you reproduced the bug with TensorFlow Nightly?

No

### Source

binary

### TensorFlow version

2.16

### Custom code

Yes

### OS platform and distribution

google colab

### Mobile device

_No response_

### Python version

_No response_

### Bazel version

_No response_

### GCC/compiler version

_No response_

### CUDA/cuDNN version

_No response_

### GPU model and memory

_No response_

### Current behavior?

I noticed that my custom module `.variables` attribute doesn't work properly in the newest versions of TF (since 2.16). That is, it doesn't contain the parameters of a `tf.keras.Sequential` model that is assigned to an attribute of my model in `__init__` (see MRE below).

Is this an intended change? What's the proper way to use a `tf.keras.Model` inside a `tf.Module` now?

### Standalone code to reproduce the issue

```python
import tensorflow as tf

print(f"{tf.__version__=}")

class X(tf.Module):
    def __init__(self):
        super().__init__()
        self.xxx = tf.keras.Sequential([tf.keras.layers.Dense(4)])
    def __call__(self, X):
        tf.print(self, "called")
        return self.xxx(X)

x=X()
x(tf.random.normal(shape=(2, 3)))
print(f"{x.variables=}")
print(f"{list(x.submodules)=}")
print(f"{isinstance(x.xxx, tf.Module)=}")
```

Output in tf 2.15.1:
```
tf.__version__='2.15.1'
<__main__.X object at 0x7cde2c935db0> called
x.variables=(<tf.Variable 'dense/kernel:0' shape=(3, 4) dtype=float32, numpy=
array([[-0.28077292,  0.2326845 ,  0.7107136 , -0.17309707],
       [ 0.5492227 , -0.37808335,  0.27558255, -0.5152782 ],
       [ 0.69788885, -0.5949336 ,  0.63280034,  0.08288908]],
      dtype=float32)>, <tf.Variable 'dense/bias:0' shape=(4,) dtype=float32, numpy=array([0., 0., 0., 0.], dtype=float32)>)
list(x.submodules)=[<keras.src.engine.sequential.Sequential object at 0x7cdd9f3fb460>, <keras.src.engine.input_layer.InputLayer object at 0x7cdd9eac41f0>, <keras.src.layers.core.dense.Dense object at 0x7cdda7323910>]
isinstance(x.xxx, tf.Module)=True
```

Output in tf 2.16.1:
```
tf.__version__='2.16.1'
<__main__.X object at 0x7e7297de1f00> called
x.variables=()
list(x.submodules)=[]
isinstance(x.xxx, tf.Module)=False
```

Output in tf 2.17.0:
```
tf.__version__='2.17.0'
<__main__.X object at 0x783c2818d690> called
x.variables=()
list(x.submodules)=[]
isinstance(x.xxx, tf.Module)=False
```



### Relevant log output

_No response_
Repository: material-ui
Issue: [core] typescript-next pipeline runs out of memory
Labels: typescript,core,scope: infra

We run TypeScript tests against `typescript@next` nightly. The pipeline (`typescript-next`) fails in the "Tests TypeScript definitions" step with the following error:

```
FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
```

Example failure: https://app.circleci.com/pipelines/github/mui/material-ui/136928/workflows/414a50d8-8d10-4e80-b16e-bd1dbc7c6660/jobs/738223?invite=true#step-107-200

Context: the pipeline is all green because we intentionally ignore failures. See https://github.com/mui/material-ui/blob/next/.circleci/config.yml#L363-L371

**Search keywords**: TypeScript, ci, test
Repository: TypeScript
Issue: wrong behavior about type parameters of `as` clause in a mapped type
Labels: Help Wanted,Possible Improvement

### 🔎 Search Terms

type parameter as mapped type 

### 🕗 Version & Regression Information

5.7.0-dev.20240821

### ⏯ Playground Link

https://www.typescriptlang.org/play/?ts=5.7.0-dev.20240821#code/C4TwDgpgBAkgzgZWAJwJYDsDmAeAKgPigF4pcBtAXSggA9gJ0ATOKOFDTSqAfihQFdoALigAzAIYAbOBABQoSFADyAW1TAkaLAGkIIPNToNmUAPYAjAFYQAxsEIkA3rKiuoZbVAxQA1ntOipFDiLPCaHHgeFIS09EwsAtC86BAAbhDIItoUIuTZsgC+srKi-Oh2qKboYnj4ABTAuQCUIo5QjOLA4rlQBVDObnzg0ACCxLCI7Fi1UAD0s+0QohnIEIwubgrQAELjY7HGCciCPHzHwmJSMnMLjEsraxuuW1AAwuNhUziOHV25BWQAOS-cSA6I3RbLZCrdaDVbAfjIaqOPohZRqDRfXT6NognoFQjzKAAAxBxK8LFMGPo6yKQA

### 💻 Code

```ts
type IsString<T> = T[] extends string[] ? true : false
type OmitStringKey<T extends object> = {
    [K in keyof T as IsString<T[K]> extends true ? never: K]: T[K]
}

function f<T>(t: T): { data: T } {
    type A = IsString<T> // deferred
    type B = A extends true ? true : false // deferred
    type C = IsString<{data: T}['data']> // deferred
    return {} as OmitStringKey<{ data: T }> // `data` is omitted
}
```


### 🙁 Actual behavior

`OmitStringKey<{ data: T }>` omit `data` property. That means `IsString<T> extends true` in the `as` clause is `true`, while `T` is not decided yet.

### 🙂 Expected behavior

type evaluation should be deferred

### Additional information about the issue

_No response_
Repository: electron
Issue: [Bug]: Spellchecker language change only takes effect after editing a text
Labels: bug :beetle:,platform/all,status/confirmed,has-repro-gist,32-x-y,33-x-y

### Preflight Checklist

- [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.

### Electron Version

32.0.1

### What operating system(s) are you using?

Windows

### Operating System Version

Window 11 23H2

### What arch are you using?

x64

### Last Known Working Electron version

_No response_

### Expected Behavior

Hi there,

we allow the user to change the application language at runtime, and want the spellchecker to sync with the selected language.
The expected behavior would be that all text inputs are re-checked immediately when the spellchecker languages are changed.

### Actual Behavior

While changing the spellchecker language dynamically works in principle, we noticed that there seems to be some kind of cache involved that re-checks a text only after is has been edited, so changing the spellchecker languages will not take effect until the user types in the input.

In the fiddle, I created a minimal reproduction that changes the spellchecker language after 5 seconds.

Thanks for looking into it!

### Testcase Gist URL

https://gist.github.com/kryops/fbba516034134fc9051138b05ce0a5aa

### Additional Information

_No response_
Repository: godot
Issue: 2D physics interpolation ghosted sprite2d
Labels: documentation,topic:physics,topic:2d

### Tested versions

4.3 official


### System information

win10

### Issue description

Enable physical interpolation
![1](https://github.com/user-attachments/assets/5e59bb93-296d-40b2-856b-bb8e69803e3c)

Turn off physical interpolation
![2](https://github.com/user-attachments/assets/b766d1c3-99b9-427e-9303-45f635a9098e)

note:put the input response code into the _input and the ghost disappears.

### Steps to reproduce

See example project

### Minimal reproduction project (MRP)

[t.zip](https://github.com/user-attachments/files/16707007/t.zip)
Repository: rust
Issue: wasip2 uses wasi:random/random to generate hashmap_random_keys
Labels: O-wasm,O-wasi

wasip2 currently still uses (all?) wasip1 implementations internally. The generation of `hashmap_random_keys` for wasip1 is implemented here:
https://github.com/rust-lang/rust/blob/a32d4a0e822a29a6682e08b75a8df4c29c7fa9f1/library/std/src/sys/pal/wasi/helpers.rs#L109-L117
using the wasi::random_get (https://github.com/WebAssembly/WASI/blob/main/legacy/preview1/docs.md#-random_getbuf-pointeru8-buf_len-size---result-errno) general-purpose function. With the popular wasi-preview1-component adapter crate (https://github.com/bytecodealliance/wasmtime/tree/main/crates/wasi-preview1-component-adapter), this call is mapped to the wasi:random/random wasip2 interface, which must be backed by a secure random source. This is unfortunate as wasip2 Rust code which only uses randomness in hashmaps now required a secure random source when an insecure one would suffice.

In wasip2, there is the separate wasi:random/insecure-seed interface, which is specifically designed to provide DoS protection when initialising a hash map. When the wasip2 implementation is fleshed out, perhaps the `hashmap_random_keys` function could be implemented with a pseudo-RNG that is seeded with one call to wasi:random/insecure-seed's insecure-seed()?

cc @alexcrichton
Repository: go
Issue: cmd/go: TestScript/mod_tidy_convergence_loop failures
Labels: NeedsInvestigation

```
#!watchflakes
default <- pkg == "cmd/go" && test == "TestScript/mod_tidy_convergence_loop"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/b/8738976142232330241)):

    === RUN   TestScript/mod_tidy_convergence_loop
    === PAUSE TestScript/mod_tidy_convergence_loop
    === CONT  TestScript/mod_tidy_convergence_loop
        script_test.go:135: 2024-08-21T19:50:51Z
        script_test.go:137: $WORK=/home/swarming/.swarming/w/ir/x/t/cmd-go-test-3420655505/tmpdir432322072/mod_tidy_convergence_loop2580139455
        script_test.go:159: 
            PATH=/home/swarming/.swarming/w/ir/x/t/cmd-go-test-3420655505/tmpdir432322072/testbin:/home/swarming/.swarming/w/ir/x/w/goroot/bin:/home/swarming/.swarming/w/ir/x/w/goroot/bin:/home/swarming/.swarming/w/ir/x/w/goroot/bin:/home/swarming/.swarming/w/ir/cache/tools/bin:/home/swarming/.swarming/w/ir/bbagent_utility_packages:/home/swarming/.swarming/w/ir/bbagent_utility_packages/bin:/home/swarming/.swarming/w/ir/cipd_bin_packages:/home/swarming/.swarming/w/ir/cipd_bin_packages/bin:/home/swarming/.swarming/w/ir/cache/cipd_client:/home/swarming/.swarming/w/ir/cache/cipd_client/bin:/home/swarming/.swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin
            HOME=/no-home
            CCACHE_DISABLE=1
            GOARCH=riscv64
    ...
            > cp go.mod go.mod.orig
            # 'go mod tidy' without -e should fail without modifying go.mod,
            # because it cannot resolve x, y, and z simultaneously. (0.043s)
            > ! go mod tidy
            [signal: segmentation fault]
            > cmp go.mod go.mod.orig
            > stderr '^go: finding module for package example\.net/w$'
        script_test.go:159: FAIL: testdata/script/mod_tidy_convergence_loop.txt:47: stderr '^go: finding module for package example\.net/w$': no match for `(?m)^go: finding module for package example\.net/w$` in stderr
        script_test.go:401: go was invoked but no counters were incremented
    --- FAIL: TestScript/mod_tidy_convergence_loop (0.10s)


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: pytorch
Issue: [DSD] Test could fail in test_fsdp_dsd.py
Labels: oncall: distributed,triaged

### 🐛 Describe the bug

In `test_fsdp_dsd.py`, the test `test_save_with_fsdp2_tp_and_load_with_tp` could fail if the model is not fully tensor parallelized. For example, if commented out some lines in `tp_parallelize_plan`, the test will fail.

### Versions

2.5.0.dev20240820

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
Repository: flutter
Issue: Having different `CardTheme`s for all the M3 `Card` variants
Labels: c: new feature,framework,f: material design,c: proposal,P3,team-design,triaged-design,f: theming

### Use case

With the introduction of Material Design 3, now cards have basically three main variants : elevated, filled, outlined (see: https://m3.material.io/components/cards/overview).
They are now all implemented in Flutter with `Card`, `Card.filled`, and `Card.outlined` respectively.

The issue is that we still have a single `CardTheme` that overrides all the variants' defaults in case of a strict definition.

### Proposal

Following what was already done for buttons, we propose to add two new theme classes `FilledCardTheme` and `OutlinedCardTheme`, so that it is possible to have custom themes for all the available card variants.
Repository: godot
Issue: get_debug_mesh doesn't generate any valid surfaces
Labels: documentation,topic:physics,topic:3d

### Tested versions

Reproducible in 4.3

### System information

Godot v4.3.stable - Windows 10.0.19044 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (NVIDIA; 32.0.15.6094) - AMD Ryzen 9 5950X 16-Core Processor (32 Threads)

### Issue description

CollisionShape3D.get_debug_mesh() seems to generate an ArrayMesh that is only useful as a visual reference, i.e. used as the mesh of a MeshInstance3D. It also seems the only straightforward way to extract collision mesh data from a CollisionShape3D generated from any -col's imported from Blender.

However, it doesn't seem to have any surface data of its own accessible via MeshDataTool, and using SurfaceTool generates nonsensical triangles from the debug ArrayMesh.

| debug mesh  | surfacetool mesh |
| ------------- | ------------- |
| ![openseam (DEBUG) 22 Aug 24 1_37_20 PM](https://github.com/user-attachments/assets/a2de9003-1029-4431-8e82-44e3e8245c85) | ![openseam (DEBUG) 22 Aug 24 1_37_34 PM](https://github.com/user-attachments/assets/e855f591-b959-4809-a283-623a05a8ca18) |

Is there a something I'm missing here?
Is there a reason why the edges of get_debug_mesh() aren't plainly accessible?

### Steps to reproduce

1. Open project and play
2. Hit spacebar or left mouse button to see the results of surfacetool overlayed on the results of get_debug_mesh()

### Minimal reproduction project (MRP)

[debug_mrp.zip](https://github.com/user-attachments/files/16707860/debug_mrp.zip)
Repository: ollama
Issue: glm-4v-9b
Labels: model request

GLM4-9b models has added, however GLM-4v-9b is still missing, please also add: https://huggingface.co/THUDM/glm-4v-9b