sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: tailwindcss
Issue: [v4] Usage of `@tailwindcss/postcss^4.0.0-alpha.25` with `svelte-preprocess` for svelte file with style tag: problematic dependency scanning
Labels: v4

## Version

`@tailwindcss/postcss^4.0.0-alpha.25` & `tailwindcss^4.0.0-alpha.25`, i.e all versions of v4 alpha from **25** to **33** (as of this writing).

## Environment

Output of `npx envinfo --system --binaries --browsers --npmPackages "{svelte,@sveltejs/*,vite,tailwindcss,@tailwindcss/postcss}"`:

```
  System:
    OS: Linux 6.6 Arch Linux
    CPU: (4) x64 Intel(R) Core(TM) i5-4590 CPU @ 3.30GHz
    Memory: 6.01 GB / 15.57 GB
    Container: Yes
    Shell: 3.7.1 - /usr/bin/fish
  Binaries:
    Node: 22.11.0 - ~/.volta/tools/image/node/22.11.0/bin/node
    npm: 10.9.0 - ~/.volta/tools/image/node/22.11.0/bin/npm
    pnpm: 9.12.3 - ~/.volta/bin/pnpm
  Browsers:
    Chromium: 130.0.6723.116
  npmPackages:
    @sveltejs/adapter-auto: ^3.0.0 => 3.3.1
    @sveltejs/kit: ^2.0.0 => 2.8.0
    @sveltejs/vite-plugin-svelte: ^4.0.0 => 4.0.0
    @tailwindcss/postcss: 4.0.0-alpha.25 => 4.0.0-alpha.25
    svelte: ^5.0.0 => 5.1.15
    tailwindcss: 4.0.0-alpha.25 => 4.0.0-alpha.25
    vite: ^5.0.3 => 5.4.11
```

## Reproduction

https://github.com/vnphanquang/sveltekit-tailwind-4-reproduction. Please see README for steps.

## Description

> [!NOTE]
> Please note that tailwind is being used as a `postcss` plugin here, reported issue is not observed when using `vite` plugin.

In the reproduction, any `svelte` file with a `style` tag will cause the following two warnings from `svelte-preprocess` during both `dev` and `build`:

```
[vite-plugin-svelte] [...truncated_path...]/*.svelte svelte.preprocess returned this file as a dependency of itself. This can be caused by an invalid configuration or importing generated code that depends on .svelte files (eg. tailwind base css)
```

There have been instances where similar warning was observed: https://github.com/sveltejs/svelte-preprocess/issues/619, https://github.com/sveltejs/svelte-preprocess/issues/346. But I don't exactly know what is causing this now. I'm guessing parsing `style` tags calls for parsing Tailwind entry css, which in turns requires parsing all matching source files 🔄.
 
---

```
[...truncated_path...]/*.svelte svelte.preprocess depends on more than 10 external files which can cause slow builds and poor DX, try to reduce them. Found: [list_of_all_source_files_except_raster_images]
```

Similarly, this is causing a lot of parsing during dev. In our real project with lots of such svelte files, the server quickly crashed with `Maximum Call Stack Size Exceeded`.

## Use case

Hi all thanks for the good work, Tailwind 4 has been really good and I'm trying to test it out on some existing v3 projects with relatively complex setup. In our case we use tailwind as a postcss plugin because we also rely on some other postcss plugins (mixins, custom properties, custom media queries). We tried to use tailwind as vite plugin which works well in dev but the plugins do not apply during production build.
Repository: godot
Issue: AnimationPlayer Inspector never displays correct keyframe data for sub-property keyframe tracks (e.g. position:x, scale:y, modulate:a, etc.)
Labels: bug,topic:editor,topic:animation

### Tested versions

Reproducible in:
- **v4.4.dev5.official [9e6098432]**
- v4.4.dev5.mono.official [9e6098432]
- v4.4.dev4.mono.official [36e6207bb]
- v4.4.dev4.official [36e6207bb]
- **v4.4.dev3.official [f4af8201b]**

Not Reproducible in:
- v4.4.dev2.official [97ef3c837]
- v4.4.dev1.official [28a72fa43]
- v4.3.stable.mono.official [77dcf97d8]

### System information

Godot v4.4.dev5 - Windows 10.0.19045 - Multi-window, 3 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; 32.0.15.6603) - AMD Ryzen 7 5800X 8-Core Processor (16 threads)

### Issue description

## Expected
When setting a keyframe for a sub-property, e.g. `position:x`, its type should be `float`.
**(v4.4.dev2.official [97ef3c837])**
![image](https://github.com/user-attachments/assets/b035ec7a-189a-4384-849a-a8d3d46945f4)

## Problem
The Inspector acts as though the keyframe is still `Vector2`.
This occurs regardless of whether I selected `position:x` through the 'Add Track' menu, or simply edited an existing `position` track name to include `:x`. 
This problem seems to affect **all vector-type properties** (e.g. `scale`, `modulate`, etc.)
**(v4.4.dev3.official [f4af8201b])**
![Image](https://github.com/user-attachments/assets/813a2fa8-7b7a-47ee-a011-416d6d409c7e)
![image](https://github.com/user-attachments/assets/aa478531-e924-41ec-8be3-9560e3ce4ab9)

## Workaround
If you set a `position:x` track, drag the object to a different position in the editor, then set a new keyframe, the animation *will* play without issue. The Inspector is merely **showing** the wrong data; the functionality seems to be unaffected.

### Steps to reproduce

1. Open MRP
2. Examine the two keyframes of the AnimationPlayer in the Inspector.
3. Confirm that the Inspector displays blank `Vector2` data, instead of the correct type: `float`

(The values of the keyframes in the MRP **should** instead be: **419.0**, and **500.0**, respectively.)

### Minimal reproduction project (MRP)

[animation-player-test.zip](https://github.com/user-attachments/files/17715578/animation-player-test.zip)
Repository: vscode
Issue: Enter inserts //
Labels: bug,polish,editor-autoindent

![Image](https://github.com/user-attachments/assets/9a265cd1-89a7-4177-b84b-58e50ac9056c)

```ts
		const obsWorkspace = new FakedObservableWorkspace();
		obsWorkspace.addDocument({ 
			uri: createDocumentUri(URI.parse(`file://test.ts`).toString()), initialValue: '' });

		const originalTextDoc = new StringValue(
			);

		const singleEdit = SingleEdit.insert(11, '3D');
```
Repository: vscode
Issue: Highlight all found text in DEBUG console
Labels: feature-request,debug,debug-console

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->
In the DEBUG console, when searching for text, the messages containing the matches are shown, but the text itself is not highlighted, which makes it hard to find in larger log messages. I'd like to request the text to be highlighted.

![Image](https://github.com/user-attachments/assets/05503332-108e-459f-8da5-32c05c881d28)
Repository: pytorch
Issue: Optional ```clamp_k``` Argument for Handling Out-of-Range Values in ```torch.topk```
Labels: triaged,enhancement,has workaround,module: sorting and selection

### 🚀 The feature, motivation and pitch

 Currently, the ```torch.topk``` function raises an error when the specified ```k``` value exceeds the total number of elements in the input tensor.

### Proposed Solution
Introduce an optional argument, ```clamp_k```, which adjusts ```k``` to the minimum of the specified ```k``` and the actual number of elements. This would prevent runtime errors and offer greater flexibility in usage. The default value would be set to ```clamp_k=False```, preserving the current behaviour of ```torch.topk```.

### Example
```
>>> torch.tensor([1., 2., 3.]).topk(5, clamp_k=True)
```

#### Current output:
```
RuntimeError: selected index k out of range
```
#### Requested output (as if ```k=3```):
```
torch.return_types.topk(
values=tensor([3., 2., 1.]),
indices=tensor([2, 1, 0]))
```
Repository: PowerToys
Issue: Multi Monitor Enhancement
Labels: Needs-Triage

### Description of the new feature / enhancement

A product similar to“ https://github.com/mgth/LittleBigMouse ”It is suggested to add a tool that not only supports the movement trajectory of the mouse according to the actual physical size, but also can unify the size of the Win window when setting different DPI scaling for multiple displays.


### Scenario when this would be used?

This feature is very practical when using multiple monitors.

### Supporting information

_No response_
Repository: svelte
Issue: <svelte:element> hydration is broken in with SvelteKit
Labels: documentation

### Describe the bug

I'm not sure if this should be in Svelte or Kit repo, but since it appeared with Svelte 5, i'm posting it here.

`<svelte:element>` is not properly hydrated when using SSR with SvelteKit.

With the following code, the page should render a `button` once hydrated:
- it does with Svelte 4
- it does not with Svelte 5

```svelte
<script>
	import { browser } from '$app/environment';
	$: t = browser ? 'button' : 'div';
	$: console.log('T', t);
</script>

<svelte:element this={t}>{t}</svelte:element>
```

### Reproduction

https://stackblitz.com/edit/sveltejs-kit-template-default-qcekrk?file=package.json,src%2Froutes%2F%2Bpage.svelte

### Logs

_No response_

### System Info

```shell
System:
    OS: Linux 5.0 undefined
    CPU: (2) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    svelte: ^5.1.15 => 5.1.15
```


### Severity

blocking an upgrade
Repository: ui
Issue: [bug]: fetch() URL is invalid
Labels: bug

### Describe the bug

I am getting the below error when I am initializing shadcn or adding new component
Tried with bun (bunx) and pnpm too

```
✔ Preflight checks.
✔ Verifying framework. Found Next.js.
✔ Validating Tailwind CSS.
✔ Validating import alias.


Something went wrong. Please check the error below for more details.
If the problem persists, please open an issue on GitHub.

fetch() URL is invalid
```



### Affected component/components

CLI

### How to reproduce

In New project:
1. Initialize shadcn with the following command : `bunx --bun shadcn@latest init`
In this case I get the following error:
```
⠧ Creating a new Next.js project. This may take a few minutes.
Something went wrong creating a new Next.js project. Please try again.
```
![image](https://github.com/user-attachments/assets/d6c4ecd0-1001-491f-9665-1a75fdbab49e)


When adding new component:
1. Run the add component command : `bunx --bun shadcn@latest add context-menu`
Here I am getting the following error:
```
⠋ Checking registry.

Something went wrong. Please check the error below for more details.
If the problem persists, please open an issue on GitHub.

fetch() URL is invalid
```
![image](https://github.com/user-attachments/assets/ee39226e-228c-41c5-b47d-0458ad101312)




### Codesandbox/StackBlitz link

_No response_

### Logs

_No response_

### System Info

```bash
Linux Mint 21.3 Virginia
Cinnamon 6.0.4
Kernel: 5.15.0-125-generic x86_64

PM / Runtime - Bun 1.1.34
PNPM - 9.12.3
```


### Before submitting

- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues
Repository: deno
Issue: deno task doesn't handle signals correctly (repro comparison with npm run attached)
Labels: needs info,task runner

Version: Deno 2.0.6

deno tasks doesn't handle signals properly (but npm scripts do). I created a simple repro for issue here:
https://github.com/mo/deno-tasks-signal-issue-repro

./docker-compose.sh and "npm run docker-compose" both exit immediately when CTRL-C is press twice.

However, "deno task docker-compose" will instead exit deno but leave docker compose running for the full 10sec grace period while printing the docker compose progress spinner onto my shell prompt.

Deno task should just work like npm run instead.
Repository: pytorch
Issue: `torch.export` ViT+flex attention:  `Attempting to use FunctionalTensor on its own`
Labels: oncall: pt2,module: higher order operators,oncall: export,module: pt2-dispatcher,module: flex attention

### 🐛 Describe the bug

Exporting a VIT with flexattention I got this error https://github.com/pytorch/pytorch/issues/137759#issuecomment-2470595683

As in that thread It seems that is a distinct issue I've opened this one.

### Versions

nightly

cc @ezyang @chauhang @penguinwu @zou3519 @ydwu4 @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @bdhirsh @yf225 @Chillee @drisspg @yanboliang @BoyuanFeng
Repository: PowerToys
Issue: Accessibility request
Labels: Needs-Triage

### Description of the new feature / enhancement

Simple option to play two sounds:  One when your webcam turns on, and the other when it turns off.

### Scenario when this would be used?

Just an audio alert for blind users notifying them when their camera is in use/off.

### Supporting information

_No response_
Repository: godot
Issue: [Regression] ResourceLoader.LoadThreadedRequest(scenePath) stuck at 0.5, infinite loop.
Labels: bug,topic:core,topic:dotnet,regression

### Tested versions

NOTReproducible in:
v4.3 stable for Windows

Reprodcible in:
v4.3 stable for MacOs
v4.4.dev4.mono.official [36e6207bb] (Windows and MacOS)

For MacOS and Windows

### System information

Godot v4.4.dev4.mono - Windows 10.0.19045 - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Ti (NVIDIA; 32.0.15.6094) - AMD Ryzen 7 3700X 8-Core Processor (16 threads)

### Issue description

When using 
```
ResourceLoader.LoadThreadedRequest(scenePath);
```

This happened before and looks like its still happening:
https://github.com/godotengine/godot/issues/92844#issuecomment-2167849384

NOTE:
I'm calling the render server when loading TileSets, but I'm doing a RenderingServer.ForceSync();


I'm getting stuck at 0.5 progress and the progress never changes, maybe a recursive load? Or a race condition, I don't know, my debugger points here:

![image](https://github.com/user-attachments/assets/504983f5-ffdb-4f7a-a277-8f48f2c21cea)


### Steps to reproduce

I'm loading the instance like this:

In MacOS it doesnt work at all it is always stuck (thats why we did the load in the same thread), on windows there is a race condition, so sometimes it works, sometime it doesnt.


```C#
public partial class Main2 : Node2D
{
    public override void _Ready()
    {
        // Construct the path to the scene file
        var scenePath = $"res://main.tscn";

        var error = ResourceLoader.LoadThreadedRequest(scenePath);
        GD.PrintErr($"Loading scene: {scenePath} {error}");
        var percentageReport = new Godot.Collections.Array();

        double percentage;
        ResourceLoader.ThreadLoadStatus loadingStatus;
        do
        {
            loadingStatus = ResourceLoader.LoadThreadedGetStatus(scenePath, percentageReport);
            if (loadingStatus == ResourceLoader.ThreadLoadStatus.Failed)
            {
                GD.PrintErr($"Failed to load scene at path: {scenePath}");
                return;
            }

            percentage = percentageReport[0].As<double>();
            GD.PrintErr($"Loading scene: loading: {loadingStatus} scene: {scenePath} percentage: {percentage} {percentageReport}");
            RenderingServer.ForceSync();
        } while (loadingStatus == ResourceLoader.ThreadLoadStatus.InProgress);

        GD.PrintErr($"Finished loading scene: {scenePath} {loadingStatus} {percentage}");
    }
}
```
            

### Minimal reproduction project (MRP)

[bug-thread.zip](https://github.com/user-attachments/files/17846554/bug-thread.zip)
Repository: vscode
Issue: The editor could not be opened due to an unexpected error: Unable to resolve text model content for resource vscode-notebook-cell-output
Labels: bug,notebook


Type: <b>Bug</b>

I could not know what is the problem that keeps stopping the running on a specific cell. The cell need to run for 100 epochs, but it stops showing any progress in the epoch 0 after many hours of running to stop in the end with an error I cannot see. I updated json setting file, but also no change. 

{
    "jupyter.jupyterCommandLineArguments": [],
    "interactiveWindow.executeWithShiftEnter": true,
    "jupyter.widgetScriptSources": [
        "jsdelivr.com",
        "unpkg.com"
    ],
    "files.autoSave": "afterDelay",
    "json.schemas": [
        
    ],
    "notebook.output.scrolling": true,
    "notebook.stickyScroll.enabled": true,
    "notebook.output.textLineLimit": 20000,
    "auto_scroll_threshold": 9999
}

VS Code version: Code 1.95.2 (e8653663e8840adaf45af01eab5c627a5af81807, 2024-11-07T11:07:22.054Z)
OS version: Windows_NT x64 10.0.22631
Modes:

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|AMD Ryzen 7 7840HS w/ Radeon 780M Graphics      (16 x 3793)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off|
|Load (avg)|undefined|
|Memory (System)|35.69GB (20.56GB free)|
|Process Argv|--crash-reporter-id 1013f2d0-c5bf-4e17-ae09-cff9e0b7b7b5|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (17)</summary>

Extension|Author (truncated)|Version
---|---|---
my-nbpreviewer|col|1.2.2
remotehub|Git|0.64.0
debugpy|ms-|2024.12.0
python|ms-|2024.18.1
vscode-pylance|ms-|2024.11.1
jupyter|ms-|2024.10.0
jupyter-keymap|ms-|1.1.2
jupyter-renderers|ms-|1.0.21
vscode-jupyter-cell-tags|ms-|0.1.9
vscode-jupyter-slideshow|ms-|0.1.6
azure-repos|ms-|0.40.0
cmake-tools|ms-|1.19.52
cpptools|ms-|1.22.11
cpptools-extension-pack|ms-|1.3.0
remote-repositories|ms-|0.42.0
jupyter-notebook-vscode|sam|0.0.2
cmake|twx|0.0.17

(1 theme extensions excluded)

</details><details>
<summary>A/B Experiments</summary>

```
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
724cj586:31013169
dvdeprecation:31068756
dwnewjupytercf:31046870
impr_priority:31102340
nativerepl2:31139839
refactort:31108082
pythonrstrctxt:31112756
cf971741:31144450
iacca1:31171482
notype1cf:31157160
5fd0e150:31155592
dwcopilot:31170013

```

</details>

<!-- generated by issue reporter -->
Repository: PowerToys
Issue: Can't Uninstall Older Versions of PowerToys on Windows 11
Labels: Issue-Bug,Needs-Triage

### Microsoft PowerToys version

0.74.0 and 0.79.0

### Installation method

Microsoft Store

### Running as admin

None

### Area(s) with issue?

Installer

### Steps to reproduce

I recently have been uninstalling apps I don't use to save memory. 

I found 3 Powertoys apps, which I thought was strange, so I uninstalled the newest version and then tried to uninstall the other 2 older versions (0.74.0 and 0.79.0). 



### ✔️ Expected Behavior

I was expecting the apps to uninstall.

### ❌ Actual Behavior

The newest version had a visible icon, while the others do not. The newest version uninstalled, but the other older versions (0.74.0 and 0.79.0) did not. 

The Windows message after trying to uninstall 0.74.0 is this: 

Windows cannot find 'C:\ProgramData\PackageCache\(96cbcdad...' 

![Image](https://github.com/user-attachments/assets/209bc059-6057-43d9-bc8c-bb0e5994cdbf)


### Other Software

_No response_
Repository: PowerToys
Issue: Automatic Do-Not-Disturb During Zoom / Teams Meetings
Labels: Needs-Triage

### Description of the new feature / enhancement

Currently, there is not an option in Windows to automatically turn on Do Not Disturb during Zoom and Microsoft Teams conference calls. Emails, chats, notifications during conference calls are very disruptive. With many conference calls throughout the day, it's a paint to turn on/off DND

### Scenario when this would be used?

During online meeting / conference calls

### Supporting information

_No response_
Repository: rust
Issue: Tracking Issue for thread spawn hooks
Labels: T-libs-api,A-thread-locals,C-tracking-issue,A-thread

Feature gate: `#![feature(thread_spawn_hook)]`

This is a tracking issue for thread spawn hooks as proposed in https://github.com/rust-lang/rfcs/pull/3642

### Public API

```rust
// std::thread:

pub fn add_spawn_hook<F, G>(hook: F)
where
    F: 'static + Send + Sync + Fn(&Thread) -> G,
    G: 'static + Send + FnOnce();

impl Builder {
    pub fn no_hooks(mut self) -> Builder;
}
```

### Steps / History

- [x] RFC: https://github.com/rust-lang/rfcs/pull/3642
- [x] Implementation: https://github.com/rust-lang/rust/pull/125405
- [ ] Final comment period (FCP)
- [ ] Stabilization PR

### Unresolved Questions

- Should the return value of the hook be an Option, for when the hook does not require any code to be run in the child?
- Should the hook be able to access/configure more information about the child thread? E.g. set its stack size.
Repository: vscode
Issue: Unexpected indentation
Labels: bug,editor-autoindent

There is unexpected indentation on the first comment line:

![Image](https://github.com/user-attachments/assets/71bed137-6a5f-442a-8b84-75a277a44405)

from https://bsky.app/profile/hailey.at/post/3lahndapjdk2j
Repository: langchain
Issue: DOC: Add Detailed Dependency Table to v0.2 Documentation for Better Compatibility
Labels: 🤖:docs

### URL

https://python.langchain.com/docs/versions/v0_2/overview/

### Checklist

- [X] I added a very descriptive title to this issue.
- [X] I included a link to the documentation page I am referring to (if applicable).

### Issue with current documentation:

The current v0.2 LangChain documentation doesn’t include a structured dependency table, like the one in the v0.3 documentation. This makes it challenging for developers who want to keep their applications on v0.2 to understand which dependencies could cause compatibility issues or potential code breaks.

### Idea or request for content:

It would be helpful to include a dependency table in the v0.2 documentation, detailing recommended version constraints for each package. This addition would allow developers to manage dependencies more effectively while maintaining compatibility with v0.2.
Repository: rust
Issue: private-intra-doc-links incorrectly shows error for public type alias to private wrapper type
Labels: T-rustdoc,C-bug,A-intra-doc-links

```rust
pub struct WholeNumber(u32);

pub use bar::Integer;
mod foo {
    // This is private
    pub struct Signed<T>(pub T);
}

mod bar {
    /// If you want to do things, try [`Integer::do_thing()`]
    pub type Integer = crate::foo::Signed<crate::WholeNumber>;

    impl Integer {
        pub fn do_thing() {}
    }
}
```


Shows

```
warning: public documentation for `Integer` links to private item `Integer::do_thing`
  --> src/lib.rs:10:41
   |
10 |     /// If you want to do things, try [`Integer::do_thing()`]
   |                                         ^^^^^^^^^^^^^^^^^^^ this item is private
   |
   = note: this link will resolve properly if you pass `--document-private-items`
   = note: `#[warn(rustdoc::private_intra_doc_links)]` on by default
```

under `cargo doc`.

This is (a) incorrect: `Integer::do_thing()` is public and accessible even if `Signed` isn't and (b) misleading: the problem is not the publicness of `do_thing()` but rather the fact that `Signed` is inaccessible. The diagnostic is confusing and doesn't help fix the problem.


I think this should probably be considered a false positive, but either way, the diagnostic ought to be be clearer about what needs to be fixed here.