sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: create-react-app
Issue: Soft introduction of new ESLint rules impossible due to warnings becoming errors in CI
Labels: issue: proposal,needs triage

### Is your proposal related to a problem?

The problem itself is well-known (e.g. https://github.com/facebook/create-react-app/issues/3657, https://github.com/facebook/create-react-app/issues/2453 and probably more). There are many problems with the `CI=true` approach (mostly about unexpected discrepancy between local and remote build for developers who have no intimate knowledge of CI/CD or a particular build system in a project), but in this issue I want to highlight how it's a blocker for gradually introducing changes to project's ESLint rules.

Basically, imagine you'd like to introduce a new rule into your (project- or company-wide) ESLint configuration. What you'd want to do is add the rule, make it visible, but you'd definitely not want the build to fail and you'd also want to avoid fixing all the code at once automatically (code ownership, commit size and other issues) or manually (a lot of work). That's what a warning is for: you add it as an indicator of "things to come", make people aware of a potential problem when they come across a piece of code and hope that gradually the issue will be fixed over time, at which point the rule can be promoted to "error", which indeed would fail the build both locally and in CI.

The issue is that with current system, there is no alternative: setting `CI=false` is bound to break other things that might be dependent on knowing about CI environment (automated UI tests?), fixing every issue as soon as the rule is introduced is not feasible for large projects and might break at some point (if not technically, then socially, since a rule introduction might have been well-intended, but does more damage in the long run), disabling the rule "for now" is the same as not having it at all.

### Describe the solution you'd like

Like in other mentioned issues, a setting (in `package.json`?) disabling upgrading warnings to errors would go a really long way.
Repository: rust
Issue: Moving out of field error should emit resolution suggestions
Labels: A-diagnostics,T-compiler

The current error doesn't help users resolve the problem. Even just including a message that one should try borrowing the field by prepending a `&` would be of help. I don't think it matters that this isn't possible for e.g. `self.foo.consuming_method()`

```rust
struct Foo {
    v: Vec<u32>,
}

impl Foo {
    fn bar(&self) {
        for _ in self.v {
            
        }
    }
}
```

([Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=e0d90406ab93df35dcba4fd8cbe558cc))

Errors:

```
   Compiling playground v0.0.1 (/playground)
error[E0507]: cannot move out of `self.v` which is behind a shared reference
 --> src/lib.rs:7:18
  |
7 |         for _ in self.v {
  |                  ^^^^^^ move occurs because `self.v` has type `std::vec::Vec<u32>`, which does not implement the `Copy` trait

error: aborting due to previous error

For more information about this error, try `rustc --explain E0507`.
error: Could not compile `playground`.

To learn more, run the command again with --verbose.

```
Repository: TypeScript
Issue: @ts-ignore is broken in 3.6 when code line is broken into 2 lines
Labels: Suggestion,Needs Proposal

**Search Terms:**
@ts-ignore
ts-ignore
ignore
multiline
**Code**

```ts
const veryLongStructureNameWithFooInside = {
  foo: (x: number): Promise<number> => {
    return Promise.resolve(x);
  },
};
// @ts-ignore
veryLongStructureNameWithFooInside
  .foo() // Notice the line break here caused by prettier
  .then((result) => {
    console.log(result);
  })
  .catch((err) => {
    console.log(err);
  });
```

**Expected behavior:**

There should be no errors as `@ts-ignore` is set on the function call (works in 3.5.2)

**Actual behavior:**

In next version the following error occurs:
```bash
error TS2554: Expected 1 arguments, but got 0.

   .foo()
      ~~~~~

      foo: (x: number): Promise<number> => {
               ~~~~~~~~~
    An argument for 'x' was not provided.
```

**Playground Link:** 
[playground](https://typescript-play.js.org/?noImplicitAny=false#code/MYewdgzgLgBAbgUwE4E8Ay4DmBlKSCuwU+SCAcgIYC2CA6gJZQAWAYiCAJKT0AmCMAXhgBvAFAwYAM3YAuGAAoAHnLD4qAI2QBKOQAUkIKvQgIAPKo3IAfIJtiJE0sSRgY+w8YQA6UhBAAbRCUtAG5xGABfABpRCLCAeniYAAEoCABaekwwEFJRRFQMMBw8QmdyajpGVnYuCF4EcK9pEHktJuYEMHl5X3x-KC1bEXCJUEgA738QTF6ECH7BsIkI9okvYAooYCYe5CQhgTtRmHG-fymZ+X3Q8NWQoA)
Repository: create-react-app
Issue: Enable and configure svgo usage with svgr
Labels: issue: proposal

As i understood svgr svgo is disabled by default and can't be activated
Is there any chance you could allow activating svgo to optimize the svgs? This way we could use .svgo.yml file to configure it depending on our needs
Repository: godot
Issue: Alt+Numpad is equivalent to deactivating Num Lock
Labels: bug,topic:input

**Godot version:**
3.1.1 stable

**OS/device including version:**
Windows 10, French AZERTY keyboard with a numpad

**Issue description:**
Pressing **Alt+Kp1**, **Alt+Kp3**, **Alt+Kp7**, **Alt+Kp9** is equivalent to pressing End, PgDown, Begin, PgUp.
It is as if the NumLock was off.
![numpad](https://user-images.githubusercontent.com/13215043/64332251-800f1800-cfd4-11e9-8a5b-3e2a86d87d11.png)

Note that:
 - It doesn't affect Alt+Kp0, Alt+Kp., Alt+Kp2, Alt+Kp4, Alt+Kp6, Alt+Kp8 (Ins, Del, Down, Left, Right, Up)
 - The bug is present with NumLock on and off.

Thus, it is impossible to use Alt codes (like Alt+144 to display É), even if you only need 0, 2, 4, 5, 6, 8 (Alt+268 doesn't display anything, while it should display ♀)

I tested my keyboard in other software, that issue does not happen.

**Steps to reproduce:**
You need a keyboard with a Numpad.
I spotted the bug in LineEdit and TextEdit, so you can try within the editor.

Type some text and play with Alt+Kp(1,3,7,9), and try to enter some Alt codes
Repository: opencv
Issue: WITH_LAPACK failed to build with the LAPACK(MKL) 2019.0.4 on Linux
Labels: bug,category: build/install,needs investigation

##### System information (version)
- OpenCV => master
- Operating System / Platform => Linux (CentOS 6.10 x64)
- Compiler => cmake 3.13.4

##### Detailed description
The LAPACK(MKL) library is found,  but the LAPACK check code failed to build. The log is:

-- Found MKL 2019.0.4 at: /opt/intel/compilers_and_libraries_2019.4.243/linux/mkl
-- LAPACK(MKL): LAPACK_LIBRARIES: /opt/intel/compilers_and_libraries_2019.4.243/linux/mkl/lib/intel64/libmkl_intel_lp64.so;/opt/intel/compilers_and_libraries_2019.4.243/linux/mkl/lib/intel64/libmkl_tbb_thread.so;/usr/lib64/libtbb.so;/opt/intel/compilers_and_libraries_2019.4.243/linux/mkl/lib/intel64/libmkl_core.so;-lpthread;-lm;-ldl
-- LAPACK(MKL): Can't build LAPACK check code. This LAPACK version is not supported.


##### Steps to reproduce
CMake build with "-D WITH_IPP=ON -D WITH_OPENMP=ON -D MKL_WITH_OPENMP=ON -D WITH_TBB=ON -D MKL_WITH_TBB=ON -D WITH_LAPACK=ON", and the LAPACK failed.
Repository: scrcpy
Issue: Windows 10 taskbar icon flash orange for notification
Labels: feature request

You know the way Windows 10 handles it when something happens
to a running but minimized-to-taskbar app?
It flashes/turns orange.

Is there any way to make the scrcpy icon on my taskbar
turn or flash orange when a notification comes through?

So I don't have to keep leaning over to look at my phone screen,
or flicking back to the app window to check I've not missed anything.
Repository: flutter
Issue: Asynchonous SearchDelegate
Labels: c: new feature,framework,f: material design,P3,team-design,triaged-design

# Use case

I want to show a list of users, but filtering this list is not _super_ fast, in a custom implementation I was able to use stateful widgets and callbacks (streams might have been better) that update al the widgets when search is changed. all this would be handled outside of a build function and the widgets could call setState().

But with SearchDelegate this is not possible since you only have a synchronous buildSuggestions which is called upon text change but is also inside a build function.
So I have to do all the computation synchronously. Using a ListView.Builder helps in that I can avoid filtering offscreen users, but when you search for the last person it still goes through all the users.

Being able to use a onTextChanged method that is asynchronous instead of the buildSuggestions would allow users of flutter to have statefull widgets to do the computation asynchronously and avoiding high frame times.

## Proposal

Add an onTextChange method, and make it optional and if the onTextChange is not null call that and avoid rebuilding the suggestions. Call the buildSuggestions once for the initial widget.
Repository: PowerToys
Issue: [FancyZones] Create layout from current windows
Labels: Idea-Enhancement,FancyZones-Layouts,Product-FancyZones

Feature to "snapshot" your current windows into a new layout
Repository: PowerToys
Issue: Drag to edge of screen automatically switches virtual desktops
Labels: Idea-Enhancement,Product-Window Manager,Product-Virtual Desktop
Repository: PowerToys
Issue: When remoting in, collapse other monitors to new virtual desktops. Remove VD when connecting locally again
Labels: Idea-New PowerToy,Product-Window Manager,Product-Virtual Desktop
Repository: PowerToys
Issue: Visual updates / flash zones for Win+Arrow 
Labels: Idea-Enhancement,FancyZones-Dragging&UI,Product-FancyZones,Area-User Interface

After the first arrow is pressed, flash then zones while I have the Win key is down so that users can see where to move the window.
Repository: PowerToys
Issue: Merge FancyZones with MTND and include zone moves in the pop-up
Labels: Idea-Enhancement,Product-FancyZones,Product-Virtual Desktop,FancyZones-VirtualDesktop

In addition to moving a window to a new desktop, the MTND pop-up should allow a user to:

 - Move to a different, existing desktop
 - Move to a zone in an existing desktop
 - Move to a new desktop with a specific zone layout
Repository: PowerToys
Issue: [Shortcut Guide] Shortcuts list [tracker]
Labels: Idea-Enhancement,Product-Shortcut Guide,Status-In progress,Tracker

total list from MSFT support: https://support.microsoft.com/en-us/help/12445/windows-keyboard-shortcuts

This list will be added into #890 with v2 of shortcut guide.

Combination | Effect
-- | --
Win + Esc | Close magnification
Win + Enter | Narrator (Below 19h1)
Win + Pause | System Window
Win + PrtScn | Capture screenshot
Win + Space | Switch Keyboard Layout
Win + Tab | Open Timeline
Win + ; | Emoji Keyboard Pop up
Win + . | Emoji Keyboard Pop up
Win + , | Peek at desktop
Win + +/- | Magnifier
---|---
Win + A | Action Center
Win + B | Focus system tray
Win + C | Cortana (doesn't work on 1909)
Win + D | Display & hide desktop
Win + E | File Explorer 
Win + F | Open Feedback Hub
Win + G | Game bar
Win + H | Dictation bar
Win + I | Settings
Win + K | Quick connect
Win + L | Lock PC
Win + M | Minimize windows
Win + N | Notification dialog (Need to verify min version, may be Win11 and up)
Win + Q | Open Search Bar
Win + P | Open Display Mode Selection panel
Win + R | Run Dialog
Win + S | Open Search Bar
Win + T | Navigate between task bar items
Win + U | Ease of access center
Win + V | Open Clipboard History
Win + W | Open Windows Ink Workspace Panel
Win + X | Quick launch menu
Win+Z | Snap Flyout ( win11+)
---|---
Win + Shift + M | Restores windows minimized with Win + M
Win + Shift + S | Screenshot
Win + Shift + T | Navigate between task bar items reversed
Win + Shift + Left/Right Arrow | Move entire active window to different window
---|---
Win + Ctrl + arrow | Switch virtual desktop
Win + Ctrl + Enter | Narrator (19h1 and above)
Win + Ctrl+F4 | Close virtual desktop
Win + Ctrl + D | New virtual desktop
Win + Ctrl + N | Narrator settings
Win + Ctrl + Q | Quick Assist
---|---
Win + Alt+ D | Toggles calendar in taskbar
---|---
Win + Ctrl + Shift + B | Restart Video Driver
---|---
Win + Shift + Ctrl + Alt | emulates the Office key
Repository: pytorch
Issue: Backtrace prints many <unknown function>
Labels: module: build,triaged,better-engineering

Our backtrace code frequently prints out frames with `<unknown function>`, indicating that `backtrace_symbols` was unable to retrieve the symbol for the backtrace. For example:

```
frame #0: std::function<std::string ()>::operator()() const + 0x11 (0x7efd7464fc11 in /data/users/ezyang/pytorch-tmp/torch/lib/libc10.so)
frame #1: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x2a (0x7efd7464f82a in /data/users/ezyang/pytorch-tmp/torch/lib/libc10.so)
frame #2: torch::autograd::VariableType::checked_cast_variable(at::Tensor&, char const*, int) + 0x138 (0x7efd7a777188 in /data/users/ezyang/pytorch-tmp/torch/lib/libtorch.so)
frame #3: torch::autograd::VariableType::unpack(at::Tensor&, char const*, int) + 0x9 (0x7efd7a777459 in /data/users/ezyang/pytorch-tmp/torch/lib/libtorch.so) 
frame #4: torch::autograd::VariableType::copy_(at::Tensor&, at::Tensor const&, bool) + 0xb0 (0x7efd7a778ff0 in /data/users/ezyang/pytorch-tmp/torch/lib/libtorch.so)
frame #5: <unknown function> + 0x6a60c9 (0x7efd970910c9 in /data/users/ezyang/pytorch-tmp/torch/lib/libtorch_python.so)
frame #6: <unknown function> + 0x6a7ee9 (0x7efd97092ee9 in /data/users/ezyang/pytorch-tmp/torch/lib/libtorch_python.so)
frame #7: c10d::ProcessGroupGloo::runLoop(int) + 0x169 (0x7efd97086199 in /data/users/ezyang/pytorch-tmp/torch/lib/libtorch_python.so)
frame #8: <unknown function> + 0xb8678 (0x7efd96962678 in /home/ezyang/Dev/pytorch-tmp-env/lib/libstdc++.so.6)
frame #9: <unknown function> + 0x7dd5 (0x7efdabb6add5 in /lib64/libpthread.so.0)
frame #10: clone + 0x6d (0x7efdab893ead in /lib64/libc.so.6)
```

This occurs even when the library is built with debugging symbols. The reason this occurs is the symbols in question live in an *anonymous* namespace, and thus don't actually have symbols for `backtrace_symbols` to extract:

```
$ gdb /data/users/ezyang/pytorch-tmp/torch/lib/libtorch_python.so
(gdb) info symbol 0x6a7ee9
c10d::(anonymous namespace)::AsyncSparseAllreduceWork::run() + 41 in section .text  
```

To work around this, you can load the library in question in gdb and then ask about the address there (I think we get the symbol name from DWARF in that case). But it would be nice if this just worked out of the box.
Repository: PowerToys
Issue: [FZ Editor] Add unit tests
Labels: Idea-Enhancement,Area-Tests,FancyZones-Editor,Product-FancyZones

# Summary of the new feature/enhancement

The new FZ editor does not have any tests.  We need to fix that.
Repository: go
Issue: x/build: keep test result logs available after success
Labels: Testing,Builders,NeedsFix,FeatureRequest,Community

Currently, the x/build testing infrastructure (both trybots and post-submit builders) generally makes test logs available under two conditions:

- while the test is running, streamed
- after the test completed, if it failed

After tests complete successfully, the test logs immediately become inaccessible.

I don't know the exact rationale for this design, but my guess is that it done to reduce computational and storage resource use. It was likely deemed logs are less useful if tests passed. /cc @bradfitz Is there more context on this?

### Feature Request

This feature request issue is to make them accessible on successful test completion for some amount of time (at least a month). Both on the [build dashboard](https://build.golang.org), and for trybot results.

The reasons for wanting this include:

- it's sometimes helpful to be able to know which tests ran and which tests were skipped, and to be able to confirm a specific test truly passed
- it's sometimes helpful to know which architectures were tested by trybots (and from that, to know which ones weren't), and having trybot result page with logs makes that much easier
- pretty much every CI system keeps test logs accessible regardless if tests succeeded or failed, so it has become a baseline expectation

I think this should be worth doing in order to improve the developer experience for people working on the Go project. Feedback from others is welcome.

/cc @golang/osp-team
Repository: flutter
Issue: [google_sign_in] document resource IDs for play store app submission
Labels: d: api docs,p: google_sign_in,package,team-ecosystem,P3,triaged-ecosystem

The playstore app submission process includes a pre-test routine that supports sign-in automation which allows developers to provide credentials for their apps for use in testing, thereby allowing a more comprehensive pre-submit test.

Unfortunately, it would appear that in addition to providing the username/password, developers must also provide the resource IDs associated with text-entry for the username and password, along with the 'sign-in' button.

https://support.google.com/googleplay/android-developer/answer/7002270#signin

For flutter apps that make use of the google sign-in plugin, it seems that this information is not directly available via the current plugin docs (I'm assuming the plugin leverages the GMS client component):

https://developers.google.com/android/reference/com/google/android/gms/auth/api/signin/GoogleSignInClient

If this information could be provided for use in testing/submission, it would be most helpful.
Thanks!
Repository: terminal
Issue: Feature Request: link generation for files + other data types
Labels: Issue-Feature,Area-Extensibility,Product-Terminal

#2094 Description of the new feature/enhancement

There are a number of scenarios where having a link detected with a meaningful click action would be helpful:

1. File (optional line number):  click action could launch an editor.

2. Directory:  click action can to change to that directory 

3. Git commit:  click action can bring up a description of the commit in the appropriate web page or tool
Repository: rust
Issue: Extend `span_label` to include fallback operation
Labels: C-cleanup,A-diagnostics,T-compiler

There are occassions where `DiagnosticBuilder::span_label` can be called with a `DUMMY
_SP`. The current behavior is we don't show those labels at all in the output. In some cases that is the correct behavior. In others, we proactively look for `DUMMY_SP`s and emit a `note` instead. I assume that the former is the most common behavior right now, although I do not know which behavior is most desired in the general case.

We should add a new method that has the fallback, or make all `span_label`s take an enum argument selecting the fallback behavior.

After extending the API, we should also audit our codebase for the correct behavior throughout all diagnostics.
Repository: terminal
Issue: [Audit] Eliminate raw pointers as begin/end markers in the CharRowCellReference class
Labels: Product-Conhost,Help Wanted,Area-Output,Product-Terminal,Issue-Task,Area-CodeHealth

When turning on audit mode for the output buffer project, I ran into the circumstance where `CharRowCellReference` is using raw pointers as its iterator definitions for begin and end, which makes static analysis very unhappy as it still results in pointer math.

This represents adjusting `CharRowCellReference` to perform iteration in a way that audit finds palatable.
Repository: terminal
Issue: [Audit] Use std::wstring_view for all global strings
Labels: Product-Conhost,Help Wanted,Area-Settings,Product-Terminal,Issue-Task,Area-CodeHealth

I left this behind in the audit mode enable phase.

This is because changing the `DEFAULT_FONT_FACE` to a `std::wstring_view` cascades in a way that is troublesome.

For one, `std::wstring_view` is not guaranteed to be null terminated. Some of the consumers of this value throughout the codebase use the pointer to this memory location as a z-terminated string instead of a counted string. In the context of pointing to a globally allocated string, we can probably feel safe that it is null terminated and could ignore this. But I don't like ignoring things like this as they pop up later when refactoring occurs.

For two, changing the way the font face string works cascades through the entire `FontInfo` and friends classes in a way that touches many, many things. I don't really want to move all of that around without also addressing #602 at the same time because we've already identified that this particular value needs to change in those classes to satisfy that bug and circumstance.'

For three, we haven't even started talking about the cascading effects of doing this to the other three strings.

So for now, I've punted and left this TODO behind.
Repository: flutter
Issue: Explore alternate rendering backends for Windows
Labels: engine,platform-windows,a: desktop,P3,team-windows,triaged-windows

Currently we're using the OpenGL rendering configuration in the embedding API, via ANGLE. Longer term, we should investigate other possibilities:
- Skia has a Vulkan backend; we could potentially wire up Vulkan through the embedding API and use that when available on Windows.
- If Skia were to add some flavor of DirectX backend, we could use that. The specific version would impact how widely it could be used.
Repository: terminal
Issue: [Audit] Unsuppress OuptutCellIterator warning and solve custom construction/destruction warning
Labels: Product-Conhost,Help Wanted,Area-Output,Product-Terminal,Issue-Task,Area-CodeHealth

I suppressed the warning on the `OutputCellIterator` as a part of turning on audit mode because I couldn't figure it out (in a reasonable amount of time for how many other things I was fixing and trying to get turned on).

This represents removing the warning suppression and figuring out what the actual issue is that is causing the warning to flag when the iterator is advanced.
Repository: terminal
Issue: [Audit] Remove suppression on CodepointWidthDetector
Labels: Product-Conhost,Area-Output,Product-Terminal,Issue-Task,Area-CodeHealth

While turning on the audit mode, I ran into a condundrum with the `CodepointWidthDetector` that I didn't really want to dig into at the moment.

The warning is complaining that we have a global object with complex initialization. That is true. But there's some decisions to be made here that equaled "not-a-quick-fix".

The `CodepointWidthDetector` is a class designed to have multiple instances if need be.

However, for the most part, it is used in a single-instance manner inside `conhost` and `wt`.

The class `GlyphWidth.cpp` is mostly a wrapper around `CodepointWidthDetector` to turn it into a singleton that can be accessed by C-style methods in the global namespace.

The decisions here are really around...

Should `CodepointWidthDetector` just be a singleton itself and only hand out a copy of itself on `Instance()`? I know that's fine for `conhost`, but I haven't fully considered it for `wt` yet.

If we get rid of the C-style global namespace methods (by removing the entire `GlyphWidth` class), will that cause a kerfluffle throughout the `conhost` codebase (and maybe `wt` too) because there are a bunch of places that gratuitously grab the global state since it was never encapsulated before?

Anything else I didn't have time to fully consider here?
Repository: TypeScript
Issue: Handle CompileOnSave on projects that contain project references.
Labels: Bug

Came up as TODO from #32028 where we want to see what needs to happen for such projects..