sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: kubernetes
Issue: Ephemeral Containers: Automatically taint pods with ephemeral containers
Labels: area/kubelet,sig/node,kind/feature,priority/important-longterm,lifecycle/frozen,needs-triage

**What would you like to be added**: Automatically adding an annotation to pods in which an ephemeral container has been added.

**Why is this needed**: A common usage pattern for ephemeral containers is to perform some debugging action in a pod that changes its state in some fashion. Since the pod is no longer pristine, it should be marked as such so it could automatically be deleted.
Repository: node
Issue: symlink out/Release/lib.target → out/Release/lib needs to be created manually before “make install”
Labels: build

On my Linux from Scratch system, building node 12.13.0 with `./configure --gdb --enable-lto --ninja --shared --openssl-use-def-ca-store` and python 3 creates the file `out/Release/lib/libnode.so.72` but “make install” looks for the file `out/Release/lib.target/libnode.so.72`.  So I have to create symlink out/Release/lib.target → out/Release/lib.

Moreover, `./configure --ninja` suggests, that after ./configure has finished, one can call `ninja`, but this does not work.  I know the Makefile calls ninja, but running direct `ninja` shall also work.
Repository: rust
Issue: Tracking issue for `vec_into_raw_parts`
Labels: A-collections,T-libs-api,B-unstable,C-tracking-issue,Libs-Tracked,A-raw-pointers

https://github.com/rust-lang/rust/pull/65705 adds:

```rust
impl String {
    pub fn into_raw_parts(self) -> (*mut u8, usize, usize) {…}
}
impl<T> Vec<T> {
    pub fn into_raw_parts(self) -> (*mut T, usize, usize) {…}
}
```

# Things to evaluate before stabilization

- [ ] [Should they return `NonNull<* mut T>`](https://github.com/rust-lang/rust/issues/65816#issuecomment-546405936)?
- [ ] [Should they be associated functions](https://github.com/rust-lang/rust/issues/65816#issuecomment-546448429)?
Repository: pytorch
Issue: Cmake fails due to bad python call
Labels: module: build,triaged

## 🐛 Bug

The call to python on [line 158](https://github.com/pytorch/pytorch/blob/e2125436817504794f5ecebec17adf233137d89c/cmake/Codegen.cmake#L158) in cmake/Codegen.cmake fails due to an undefined `PYTHON_EXECUTABLE` variable.

## To Reproduce

Steps to reproduce the behavior:

1. Clone repo
2. `mkdir build; cd build`
3. `cmake -DBUILD_CUSTOM_PROTOBUF=OFF -DBUILD_TORCH=ON -DBUILD_SHARED_LIBS=ON -DBUILD_PYTHON=OFF -DCMAKE_INSTALL_PREFIX:=/usr/local/ ..`


```
Call Stack (most recent call first):
  CMakeLists.txt:373 (include)


-- Looking for clock_gettime in rt
-- Looking for clock_gettime in rt - found
-- Looking for mmap
-- Looking for mmap - found
-- Looking for shm_open
-- Looking for shm_open - found
-- Looking for shm_unlink
-- Looking for shm_unlink - found
-- Looking for malloc_usable_size
-- Looking for malloc_usable_size - found
-- Performing Test C_HAS_THREAD
-- Performing Test C_HAS_THREAD - Success
-- GCC 7.4.0: Adding gcc and gcc_s libs to link line
-- don't use NUMA
-- Performing Test COMPILER_SUPPORTS_NO_AVX256_SPLIT
-- Performing Test COMPILER_SUPPORTS_NO_AVX256_SPLIT - Success
--
CMake Error at cmake/Codegen.cmake:172 (message):
  Failed to get generated_cpp list
Call Stack (most recent call first):
  caffe2/CMakeLists.txt:2 (include)
```

## Expected behavior

Expect cmake to complete

## Environment

```
Collecting environment information...
PyTorch version: N/A
Is debug build: N/A
CUDA used to build PyTorch: N/A

OS: Linux Mint 19.2 Tina
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.10.2

Python version: 2.7
Is CUDA available: N/A
CUDA runtime version: Could not collect
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: Could not collect

Versions of relevant libraries:
[pip] numpy==1.16.5
[conda] Could not collect
```
## Additional context

Tested on Ubuntu 16, same behavior

```
Collecting environment information...
PyTorch version: N/A
Is debug build: N/A
CUDA used to build PyTorch: N/A

OS: Ubuntu 16.04.6 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609
CMake version: version 3.13.3

Python version: 2.7
Is CUDA available: N/A
CUDA runtime version: Could not collect
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: Could not collect

Versions of relevant libraries:
[pip] numpy==1.13.1
[pip] torch==1.1.0a0+83cf947
[pip] torchvision==0.2.2.post3
[conda] Could not collect
```
Repository: node
Issue: suggested updates to the onboarding doc
Labels: doc,meta

This is a TODO list that I took during the onboarding of legendcas. Opening an issue in case I forget about them - but feel free to pick them up if you are interested to help!

- [ ] Mention this trick `git remote set-url origin --push no_push`
- [ ] Mention nodejs/help (when triaging issues)
- [ ] It’s not necessary to explain everything in the on boarding document. The person doing the onboarding can ask whether the collaborator already knows about each point and skip if they already do. If they have questions, answer them.
- [ ] Mention the new 7 day rule, or just add a link to the collaborator guide about the rules
- [ ] Mention other commonly used CIs
  - [ ] micro benchmark
  - [ ] v8
  - [ ] custom e.g. internet
  - [ ] stress test
  - [ ] citgm
- [ ] Mention how to get a git ref to use in the Jenkins build parameters
- [ ] The `what belongs in Node.js` seems a bit outdated? In general we just open issues and discuss on a case-by-case basis
- [ ] Mention the travis CI
- [ ] Mention the resume build button and the stop button in Jenkins
- [ ] Mention how to report issues to the build team: with the machine id
- [ ] TODO(joyee): Update node-core-utils recording, and just add a link to the recording to quickly demonstrate how to use it
- [ ] Add the github-bot and node-core-utils repo to the "other repos" links, and explain what those are
- [ ] Mention the Collboarator github team discussion page
- [ ] Mention how security bugs are handled (or a link to SECURITY.md)
- [ ] Mention that collaborators can nominate other collaborators (and add a link to GOVERNANCE.md)
Repository: rust
Issue: Using `include_bytes!` on large binary blobs compiles more slowly than expected
Labels: I-compiletime,T-compiler

I've been playing around recently with compiling a crate that simply contains:

```rust
pub const BYTES: &[u8] = include_bytes!("large-binary-blob");
```

and I've been surprised that the compile time of this crate is pretty nontrivial!

For example this crate:

```rust
pub const BYTES: &[u8] = &[];
```

takes 0.060 seconds to compile on nightly for me. If a multi-megabyte binary (such as `cargo` itself) is included:

```rust
pub const BYTES: &[u8] = include_bytes!("/path/to/.cargo/bin/cargo");
```

this crate takes 0.729 seconds to compile!

There appear to be at least two major sources of slowdown:

1. In the [expansion of `include_bytes!`](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/libsyntax_ext/source_util.rs#L171) the [`expr_lit` function](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/libsyntax_expand/build.rs#L322-L325) calls [`from_lit_kind`](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/libsyntax/parse/literal.rs#L215-L217) which calls [`to_lit_token`](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/libsyntax/parse/literal.rs#L145-L149) that runs an operation per-byte, which is pretty expensive for multi-megabyte files.
2. Later in compilation while emitting metadata when we're [processing constants](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/librustc_metadata/encoder.rs#L1074-L1077) we'll end up [pretty printing them](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/librustc_metadata/encoder.rs#L1059) and pretty printing the byte string literal for a multi-megabyte file takes quite some time!

There may be a few other sources of slowdown, but ideally usage of `include_bytes!` and large byte blobs in general should never iterate over the bytes and perform expensive operations, but rather the bytes should just be transferred as a whole in various contexts if absolutely necessary.
Repository: rust
Issue: Footgun with const declarations of type Atomic*
Labels: C-enhancement,A-lints,T-lang,T-compiler,A-const-eval,A-atomic

I just got caught by a footgun where I'd declared a global counter as:
```
const COUNTER: AtomicUsize = AtomicUsize::new(0);
```
and incremented it using `COUNTER.fetch_add(1, Ordering::SeqCst)`. It took me a while to realize why I was always getting `0`! There are checks for `const` declarations not having interior mutability to catch these footguns, but they don't apply to atomics.
Repository: pytorch
Issue: [docs] Unclear input/output format for TransformerEncoderLayer
Labels: module: nn,triaged

https://pytorch.org/docs/master/nn.html?highlight=transformerencoderlayer#torch.nn.TransformerEncoderLayer does not mention the input/output tensor dimension order. Is it B(atch)T(ime)C(hannels)?

Existing docs for torch.nn.GRU explain this more clear.

Also RNNCell uses `nonlinearity` keyword whereas Transformer* uses `activation`. If this difference is not intentional, it would be nice to unify these for consistency.
Repository: flutter
Issue: Make FutureBuilder deliver pending snapshot on entering active lifecycle state
Labels: c: new feature,framework,P3,team-framework,triaged-framework

## Use case

If the future completes after the screen times out, then the screen is turned back on, I would like a build to be triggered to deliver the future upon re-entering the active lifecycle state -- i.e. to ensure that the FutureBuilder does indeed build in the future so that I can show the results of the awaited future.

## Proposal

FutureBuilder already receives notification of the completed future, but can't deliver it while the screen is off. What it could perhaps do instead is treat the delivery as pending, and hook into the lifecycle state callbacks so that on re-entering the active state (or even entering the active state for the first time*), the pending delivery can be triggered with markNeedsRebuild.

Yes, this can be provided by a package on pub.dev, say, ReliableFutureBuilder, but it seems wasteful to have two versions of FutureBuilder.

(*) I noticed this problem occurs if I use "flutter run" to start my app while the screen is turned off. The app uses a FutureBuilder while loading. If the screen is turned on after the future completes, the FutureBuilder holds the data snapshot but does not trigger a rebuild. This scenario is not realistically going to happen in the wild, but it seems correct to handle all cases.
Repository: go
Issue: runtime: fatal error: unknown caller pc (libfuzz)
Labels: NeedsInvestigation,compiler/runtime

### What version of Go are you using (`go version`)?

<pre>
go1.13.3.linux.amd64
</pre>

Compiled through [go-fuzz/libfuzz](https://github.com/klauspost/compress/blob/master/fuzzit.sh#L17)

### Does this issue reproduce with the latest release?

Yes.


### What operating system and processor architecture are you using (`go env`)?

<details>
Fuzz test run on https://fuzzit.dev/

Linux, AMD64 is as much as I know
</details>

### What did you do?

I have 3 crashes crash from "fuzzit.dev" where I am running continuous fuzz testing of my compression packages. Go 1.12.10 was used for 2 builds, Go 1.13.3 for one.

There is no assembly or "unsafe" involved so there shouldn't be any reasonable way for memory corruption. This fuzzing is also strictly running in a single goroutine, so races also seems unlikely.

That said I have no idea about the hardware stability of the servers running the tests.

Also, a lot of new code has just been added here, so there is a chance of something bad, though I don't know how I would be able to trigger this error.

Crash logs: https://gist.github.com/klauspost/d4ec7bd6ecefa1bec56dd8ca4ac8ec39

Go 1.12.10 on top and bottom. Go 1.13.3 in the middle.

It is completely different functions that were pre-empted (`flate.(*fastGen).matchlenLong`) vs. `flate.(*decompressor).Read` - completely different code. All crashes were in `mgcmark.go:711`. Final crash was while executing `bytes.(*Buffer).grow`.

Crashes have not reproduced locally, so this could be a libfuzz specific problem. Build script is here: https://github.com/klauspost/compress/blob/master/fuzzit.sh#L17 - all crashes have been in the same fuzzer (flate), so it seems something in there is triggering it.

### What did you expect to see?

No crash, or more information.

### What did you see instead?

Crash.
Repository: rust
Issue: Attribute macro helper attributes
Labels: A-attributes,A-macros,T-lang,C-feature-request

[The reference](https://doc.rust-lang.org/reference/procedural-macros.html) states that custom derive macros support defined helper attributes:
```rust
#[proc_macro_derive(HelperAttr, attributes(helper))]
pub fn derive_helper_attr(_item: TokenStream) -> TokenStream {
    TokenStream::new()
}
```
However, the same does not appear to apply to `proc_macro_attribute`. Please extend it to do so.

```rust
#[proc_macro_attribute(attributes(helper))]
pub fn my_attribute(attr: TokenStream, item: TokenStream) -> TokenStream { .. }
```

Motivation is limited, but this could provide simpler specification [here](https://github.com/dhardy/kas/blob/master/src/text.rs#L15-L17).

Related: #53012
Repository: flutter
Issue: Make it easier (or document how) to bring your own harfbuzz/ICU
Labels: c: new feature,engine,c: performance,d: api docs,a: typography,a: existing-apps,a: size,perf: app size,P3,team-engine,triaged-engine

See https://github.com/flutter/flutter/issues/40220#issuecomment-546327467 for more context

Some customers would like to bring their own harfbuzz/ICU.  Not clear if that would also require bringing their own freetype2. My own explorations around engine modularization have been more focused on networking and Skia - I'm not as famiilar with what it would take to split out some of the text rendering stack (or whether it would actually help things binary size wise).  

/cc @jason-simmons @GaryQian who know a lot more about this area.
Repository: flutter
Issue: Bottom Navigation Bar Ripple Style
Labels: c: new feature,framework,f: material design,P3,workaround available,team-design,triaged-design

Hello. Overall the material design implementation and ripples are pretty good and smooth, on some places even better than native, but for sure not so good when it comes to bottom bar navigation. The BottomNavigationItem on press ripple is just disgusting and bothers me every time I see it.

It should be bigger (wider) and the ripple effect should be faster and wider too. Native Android bottom navigation ripples look way better, for example Messenger navigation.

Even no ripples (like YouTube did) at all would be better than three current animation.
Repository: flutter
Issue: Animated ClipRRect
Labels: c: new feature,framework,a: animation,P3,team-framework,triaged-framework

Currently, AnimatedContainer is beautiful and has many use cases, however it's children do NOT clip to its boundries (like Container), which would be a suggestion in itself, but the existence of ClipRRect makes me think the decision on this is final. So as a substitute, an AnimatedClipRRect is in order to animate clipping and border clipping of the widget's children.

This would be incredibly useful for many use-cases. In fact, I found myself suggesting this because I needed it as a UI idea to transform a square to a circle when a download button is pressed. I'm sadly going to have to do something different.

I know it's 100% possible to already do this with extrinsic animations, and I already tried it, but it's very bulky and inconvenient to use. It's why AnimatedContainer exists in the first place.

Parameters for AnimatedClipRRect should all be animatable, perhaps even a shape decoration parameter like the one in Container where you can change it's shape from a square to a circle to any other shape you make.
Repository: flutter
Issue: Using an EagerGestureDetector on web doesn't appear to properly pass scroll wheel events
Labels: framework,f: gestures,platform-web,a: desktop,customer: webeap,a: mouse,P2,team-framework,triaged-framework

Sample code:

```dart
class DebuggerScreenBody extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    // Don't build this in const because compile time const evaluation
    // will fail on non-web apps.
    return RawGestureDetector(
      gestures: {
        EagerGestureRecognizer: _EagerGestureFactory(PointerDeviceKind.mouse),
      },
      // ignore:prefer_const_constructors
      child: HtmlElementView(
        viewType: 'DebuggerFlutterPlugin',
      ),
    );
  }
}
```

Mouse scroll events don't seem to be passing properly to the child view.  I have worked around this by telling the plugin code to capture `onWheel` and `onMouseWheel` events, but ideally just the eager gesture detector would be sufficient.

Doctor:

```
$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.10.15-pre.222, on Linux, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 3.4)
[✓] IntelliJ IDEA Community Edition (version 2019.2)
[✓] VS Code (version 1.39.2)
[✓] Connected device (4 available)
```

See https://github.com/flutter/devtools/pull/1255 for more context.
Repository: vue
Issue: Computed properties with getter/setter do not provide expected Typescript type annotation
Labels: typescript

### Version
2.6.10

### Reproduction link
[https://codesandbox.io/s/quiet-glitter-qk7fy?fontsize=14](https://codesandbox.io/s/quiet-glitter-qk7fy?fontsize=14)







### Steps to reproduce
1) Create a computed property in a single file component that is lang="ts" - call it myComputedProp

2) Add a get() and set() method for that computed prop

3) Annotate the get() method (for example get(): string)

4) Annotate the set() method (for example set(myValue: number): void ) 

5) Check the inferred types of myComputedProp - it looks like it will be string | number

### What is expected?
When the get() method of a computed property is annotated with a type, the computed properties type will correspond to that annotation. 

### What is actually happening?
When the get() method of a computed property is annotated with a type (A), and the set() methods parameter has been annotated with a type as well (B), the computed property has a type of A | B

---
This may very well be a user error on our part as well, and perhaps the community or Vue team has some suggestions for how to better handle this. We provide auto generated types from an api client, so having the "or" syntax with the computed annotation in this case means we need to use a type assertion to circumvent this. Thanks a ton! Happy to provide screenshots I took as well.

<!-- generated by vue-issues. DO NOT REMOVE -->
Repository: flutter
Issue: flutter test --platform chrome not generating generated_plugin_registrants.dart
Labels: a: tests,c: new feature,platform-web,customer: webeap,P3,a: plugins,team-web,triaged-web

```
$ flutter test --platform chrome test/
Configuring `build_web_compilers:entrypoint` in target `devtools_app:devtools_app` but this is not a known Builder

Unable to find modules for some sources, this is usually the result of either a
bad import, a missing dependency in a package (or possibly a dev_dependency
needs to move to a real dependency), or a build failure (if importing a
generated file).

Please check the following imports:

`import 'generated_plugin_registrant.dart';` from devtools_app|lib/main_web_entrypoint.dart at 5:1



Unable to find modules for some sources, this is usually the result of either a
bad import, a missing dependency in a package (or possibly a dev_dependency
needs to move to a real dependency), or a build failure (if importing a
generated file).

Please check the following imports:

`import 'generated_plugin_registrant.dart';` from devtools_app|lib/html_main_web_entrypoint.dart at 5:1


Failed after 313ms
Failed to compile tests
```

Doctor:

```
$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.10.15-pre.222, on Linux, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 3.4)
[✓] IntelliJ IDEA Community Edition (version 2019.2)
[✓] VS Code (version 1.39.2)
[✓] Connected device (4 available)
```
Repository: opencv
Issue: Calibrate camera without moving external parameters
Labels: feature,category: calib3d

It is then possible to add a flag to do not move the external parameter during the optimisation in the calibrate camera function?

thanks
Repository: rust
Issue: Tracking issue for future-incompatibility lint `unused_attributes`
Labels: A-attributes,A-lints,T-compiler,C-future-incompatibility,C-tracking-issue

> [!IMPORTANT]
> This description needs to be fleshed out!

Related pull request: https://github.com/rust-lang/rust/pull/65294#issuecomment-545418714.
Repository: pytorch
Issue: [docs] Improve docs of nn.MultiheadAttention
Labels: module: docs,triaged

https://pytorch.org/docs/master/nn.html?highlight=multiheadattention#torch.nn.MultiheadAttention currently looks like this:

- **Note** – if kdim and vdim are None, they will be set to embed_dim such that
- **key, and value have the same number of features.** (*query,*) –

i.e. formatting went badly.

Also docs don't mention that `embed_dim` must be divisible by `nheads` and what's the reason for this requirement (it seems that the module assumes that the projection of the all heads is done prior to this module)
Repository: flutter
Issue: Create plugin for loading Android assets
Labels: platform-android,package,c: proposal,P3,team-android,triaged-android

Create a plugin specifically for loading Android assets in Flutter.

This plugin should include at least a Dart API that reflects Android's `AssetManager`. If desired, it can also include higher level tools, too, such as an `ImageProvider` that works with the Dart version of `AssetManager`.