sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: node
Issue: zlib.gyp is not configured for armv7 builds node V14.17.2
Labels: zlib,build,arm

### Version

14.17.2

### Platform

ARMV7l

### Subsystem

_No response_

### What steps will reproduce the bug?

Cross-compiling from linux for arm-linux with ARMv7-a.

I've been running into issues when compiling zlib in particular:
`In file included from ../deps/zlib/deflate.c:54:0:
../deps/zlib/contrib/optimizations/insert_string.h:39:0: warning: "TARGET_CPU_WITH_CRC" redefined
     #define TARGET_CPU_WITH_CRC __attribute__((target("armv8-a,crc")))`

I might be wrong here but I believe that zlib.gyp is not respecting the arm_version and attempting to optimise using flags that aren't supported in armv7-a.

zlib.gyp has the following condition statement for arm-fpu=="neon":
`
            ['arm_fpu=="neon"', {
              'defines': [
                'ADLER32_SIMD_NEON',
                'INFLATE_CHUNK_SIMD_NEON',
              ],
              'sources': [
                'contrib/optimizations/slide_hash_neon.h',
              ],
              'conditions': [
                ['OS!="ios"', {
                  'defines': [ 'CRC32_ARMV8_CRC32' ],
                  'sources': [
                    'arm_features.c',
                    'arm_features.h',
                    'crc32_simd.c',
                    'crc32_simd.h',
                  ],
                  'conditions': [
                    ['OS=="android"', {
                      'defines': [ 'ARMV8_OS_ANDROID' ],
                    }],
                    ['OS=="linux"', {
                      'defines': [ 'ARMV8_OS_LINUX' ],
                    }],
                    ['OS=="win"', {
                      'defines': [ 'ARMV8_OS_WINDOWS' ],
                    }],
                    ['OS!="android" and OS!="win" and llvm_version=="0.0"', {
                      'cflags': [
                        '-march=armv8-a+crc',
                      ],
                    }],
                  ],
                }],
                ['target_arch=="arm64"', {
                  'defines': [ 'INFLATE_CHUNK_READ_64LE' ],
                }],
              ],
            }],
`

armv7-a doesn't support CRC32_ARMV8_CRC32, ARMV8_OS_LINUX, or setting -march=armv8-a+crc
This causes the build of zlib to fail.

I believe there needs to be a check in here somewhere for arm_version, before trying to optimise for the incorrect architecture.

Unless of course I'm missing an ENV variable declaration somewhere that would avoid this?

Thanks for all you work! 


### How often does it reproduce? Is there a required condition?

Cross compiling for ARMV7-A target.

### What is the expected behavior?

_No response_

### What do you see instead?

_No response_

### Additional information

_No response_
Repository: storybook
Issue: Array argument is transformed in Object after refreshing the page with a pre-defined value set in the URL
Labels: bug,help wanted,args,addon: controls

**Describe the bug**

Given I have a component with an argument "correctAnswers" which is configured as a "string[]"
And in the "Controls" panel I can see that the control value is initially an empty array
And I manually modify the control value via the "Controls" panel adding an element to it ("answer1")
And I see that in the browser URL the control value change is tracked as follows: "&args=correctAnswers[0]:answer1"
When I refresh the page with the updated URL
Then I see that the control value becomes an Object containing a single key with the value I added before ("answer1")
And my component breaks because it receives an Object instead of an Array for the specific control

**To Reproduce**

Reproduction deployed with Chromatic:
https://60e41a0b495b7b003b17750c-mxahjzabca.chromatic.com/?path=/story/bug--bug-case

Please follow the description Gherkin to reproduce the issue.

The reproduction can be cloned from the following repo:
https://github.com/marcodellovo-dcbo/my-storybook-reproduction.git

**System**

```
System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
  Binaries:
    Node: 10.15.1 - ~/.nvm/versions/node/v10.15.1/bin/node
    npm: 7.17.0 - ~/Documents/Docebo/Dev/repos/sdk/training-elements/node_modules/.bin/npm
  Browsers:
    Chrome: 91.0.4472.114
    Firefox: 88.0.1
    Safari: 14.0.3
  npmPackages:
    @storybook/addon-a11y: ~6.3.1 => 6.3.1
    @storybook/addon-actions: ~6.3.1 => 6.3.1
    @storybook/addon-console: ~1.2.3 => 1.2.3
    @storybook/addon-docs: ~6.3.1 => 6.3.1
    @storybook/addon-essentials: ~6.3.1 => 6.3.1
    @storybook/addon-links: ~6.3.1 => 6.3.1
    @storybook/angular: ~6.3.1 => 6.3.1
    @storybook/theming: ~6.3.1 => 6.3.1
```

**Additional context**

There are no errors in the console and I haven't defined any custom configuration for the specific control via "ArgTypes".

**Initial state of the control when there isn't any pre-defined value in the browser URL**

![Screenshot 2021-07-05 at 18 21 15](https://user-images.githubusercontent.com/77811482/124499185-e413ea80-ddbd-11eb-8178-81021c5bbc07.png)

**State of the control when there's a pre-defined value for it in the browser URL**

![Screenshot 2021-07-05 at 18 22 53](https://user-images.githubusercontent.com/77811482/124499312-17567980-ddbe-11eb-8398-8fb7264cab1d.png)
Repository: storybook
Issue: Controls Addon - Web Components - Update property without re-rendering story
Labels: bug,help wanted,has workaround,web-components,args,addon: controls

The Knobs addon has a `disableForceUpdate` option which stops the story re-rendering after a knob value has changed. There is also an event emitted when the knobs change, `storybookjs/knobs/change`.

The Controls addon allows the getting and setting of the control state but I don't think there's a hook point for when the value changes, like described in https://github.com/storybookjs/storybook/pull/9447.

Is such a pattern possible with Controls?
Repository: godot
Issue: Can't get input event for mouse then window losing|regaining focus
Labels: bug,platform:windows,platform:linuxbsd,topic:input

### Godot version

3.3.2

### System information

Linux Manjaro, Win10, any hardware

### Issue description

Working on some software, need to make drag'n'drop feature for files, but need to drop files on specific controls. 
When you switch to Godot window and some mouse button is pressed, there are no Input Events fired for mouse motion|buttons unless you release button (releasing button also not fired). get_global_mouse_position() returns last mouse position before window switching.

### Steps to reproduce

1 Start any app
2 drag'n'drop any file into window, or just press mouse button and then alt-tab to your app
3 As you can see InputEvents will fire only AFTER you release mouse button

### Minimal reproduction project

Small project with label shows mouse global coordinates
[MouseBug.zip](https://github.com/godotengine/godot/files/6765911/MouseBug.zip)
Repository: godot
Issue: Eliminate side effects from godot shading lang, change "if used" side effects to explicit render_types.
Labels: enhancement,breaks compat,topic:shaders

### Godot version

3.3stable, 4.0dev

### System information

All

### Issue description



https://user-images.githubusercontent.com/323868/124510224-98971780-dd90-11eb-91a6-d54bb8c38d51.mov

The above video is really un-intuitive from a design perspective...  I understand it's documented, `Final modulate color. If used, COLOR will not be multiplied by modulate automatically after the fragment function.`, but even so, it's somewhat ambiguous.  What does "if used" mean in this context?  In my example code, MODULATE ends up being unused.

But this example brings up a larger issue with MODULATE and NORMALMAP in canvas item shaders.  We really shouldn't rely on side effects to do stuff that should be explicitly defined in render_types.  If the renderer is going to go ahead and modulate something after my fragment pass, it should explicitly be defined as a render type. say `modulated` render_type for example.   This way, developers can be explicit about what they want, without relying on side-effects that are going to potentially be error prone.  The above video was REALLY un-expected for me :(



### Steps to reproduce

See attached video, but basically read MODULATE (or NORMALMAP ) from any canvas item shader function to a unused variable.



### Minimal reproduction project

_No response_
Repository: go
Issue: encoding/xml: document security guarantees
Labels: Documentation,NeedsInvestigation

The guarantees of encoding/xml are quite unclear.  Presumably it will not panic, use excessive CPU or memory (relative to the input size), or violate memory safety on any input.  Is it guaranteed to be deterministic?
Repository: node
Issue: stream: alternative async generator transform
Labels: stream

Just an idea for discussion:

Currently we support creating transform streams from async generators:

```js
async function* toUpper(source) {
  for await (const chunk of source) {
    yield source.toUpperCase();
  }
}
```

However, after reading through https://github.com/tc39/proposal-function.sent I realize there is an alternative possible syntax:

```js
async function* toUpper() {
  while (!this.signal.aborted) {
    yield this.sent.toUpperCase();
  }
}
```

Which has an advantage of avoiding the extra parameter required in toUpper and could unify the signature of readable and transform generators.

I'm not sure about whether or not this is a good idea. Mostly wanted to raise awareness of the possibility and see what others think.

I believe we could probably achieve a similar syntax pre this proposal by replacing `function.sent` with `this.sent` for use with `pipeline/compose` as a compat. It would have the same value as `function.sent` for forward compatibility.

Example how this could be implemented:

```js
async function* processor() {
  while (true) {
    yield await process(this.sent, { signal: this.signal });
  }
}

async function* src() {
  yield 'hello'
  yield 'world'
}

async function* pump(src, gen) {
  const ac = new AbortController()
  const context = { sent: null, signal: ac.signal }
  const dst = gen.call(context)
  const iterator = dst[Symbol.asyncIterator]()
  try {
    for await (const chunk of src) {
      context.sent = chunk
      const { done, value } = await iterator.next()
      if (done) {
        return
      }
      yield value
    }
  } finally {
    ac.abort()
    iterator.return()
  }
}

for await (const chunk of pump(src(), processor)) {
  console.log(chunk)
}
```
Repository: flutter
Issue: [proposal] Ability to add widget to tooltip
Labels: c: new feature,framework,f: material design,c: proposal,team-design,triaged-design

## A custom tooltip that can accept the custom widget or widgets as input to show custom data in the tooltip.

![image](https://user-images.githubusercontent.com/45857340/124516784-8036f500-ddb0-11eb-859b-8b8f0af5f895.png)

## I was trying to make an info button with the tooltip to show more organized details but as of now, the tooltip accepts String only. There might be someone or many looking like above the above picture.

I tried to do it by customizing the tooltip code and achieved it to create the above demo image. But, the message is also used for accessibility purposes. We can do fix this issue by replacing it with the semanticLabel property like other widgets which offer semanticLabel as a property.

I just submitted the pull request [here](https://github.com/flutter/flutter/pull/85924). can check the code but I could not test it thoroughly because flutter's forked repository was throwing many dependency conflicts which I tried to fix but it resulted in showing more problems for missing code implementations.
Repository: react
Issue: [React 18] Possible Suspense Bug - Thrown error causes corrupted page
Labels: Type: Needs Investigation,React 18

I've found what I think to be a React bug, although it could be something we are doing wrong inside Blitz.js

`React 18.0.0-alpha-ed6c091fe-20210701`

## Basic Explanation

The position of a top level, unneeded `<Suspense>` component next to an `<ErrorBoundary>` causes odd UI rendering or totally corrupted page.

Following are different variations of [this code](https://github.com/flybayer/blitz-react18/blob/main/app/pages/_app.tsx#L15-L22) inside `_app.tsx` (which is the same top level root as Next.js)

This code in `_app.tsx` causes a totally corrupted page (shows content on page that's no longer managed by React):
```tsx
    <Suspense fallback="Loading...">
      <ErrorBoundary FallbackComponent={RootErrorFallback}>
        <Component {...pageProps} />
      </ErrorBoundary>
    </Suspense>
```

This code in `_app.tsx` results in a correct end-result but has janky page transition.

```tsx
    <ErrorBoundary FallbackComponent={RootErrorFallback}>
      <Suspense fallback="Loading...">
        <Component {...pageProps} />
      </Suspense>
    </ErrorBoundary>
```

This code in `_app.tsx` without `<Suspense>` works flawless.

```tsx
    <ErrorBoundary FallbackComponent={RootErrorFallback}>
      <Component {...pageProps} />
    </ErrorBoundary>
```

I feel like this is a React bug because, to my knowledge, position of a `<Suspense>` component should have zero affect on a thrown error or ErrorBoundary.

## Further Explanation

In Blitz.js, we have a feature for restricting access to certain pages based on the user login status. We implement this [by throwing a custom `RedirectError`](https://github.com/blitz-js/blitz/blob/canary/packages/core/src/auth/auth-client.ts#L68-L74). And then inside our `<ErrorBoundary>` component, [we call `router.push()`](https://github.com/blitz-js/blitz/blob/canary/packages/core/src/error-boundary.tsx#L94-L98) when RedirectError is caught. And while the ErrorBoundary is in that temporary in-between state, we [render null](https://github.com/blitz-js/blitz/blob/canary/packages/core/src/error-boundary.tsx#L154-L156). The issue described above occurs when a page transition is initiated via RedirectError.

Please let me know if there's something wrong with this approach or if there's a better way to implement the pattern. 🙏 

## To Reproduce

1. Open this codesandbox: https://codesandbox.io/s/sharp-antonelli-u982e
1. Wait for the deps to install and home page to load (takes a bit)
1. See both the contents of `/protected` and `/` on the same page:
   - React dev tools shows that the `/protected` contents are no longer in the React tree
![image](https://user-images.githubusercontent.com/8813276/124835823-f3c33880-df4f-11eb-9371-e8d0aee570b9.png)
Repository: rust
Issue: E0493 emitted without drop when destructuring
Labels: A-diagnostics,A-destructors,T-compiler,A-const-eval

Given the following code: <!-- Please provide a link to play.rust-lang.org -->

```rust
pub struct Wrap(String);

impl Wrap {
    pub const fn into_inner(self) -> String {
        self.0
    }
}
```

The current output is:

```
error[E0493]: destructors cannot be evaluated at compile-time
 --> src/lib.rs:4:29
  |
4 |     pub const fn into_inner(self) -> String {
  |                             ^^^^ constant functions cannot evaluate destructors
5 |         self.0
6 |     }
  |     - value is dropped here
```

This error is clearly wrong: `self` is not dropped, as it's been moved out of. In fact, no destructors are run, so this _should_ be able to compile. If it shouldn't compile, the error should be changed to not be incorrect.

This seems to be an issue in the drop suppression when moving out field-wise; using e.g. `mem::forget` works to suppress the destructor and allow the function to compile. I was unable to trick the compiler to accept the function with `ManuallyDrop`, as extracting the wrapped value requires manifesting a wrapper again, which triggers E0493 "destructors cannot be evaluated at compile-time".

@rustbot label: +A-const-fn +A-destructors
Repository: terminal
Issue: Option to remove `\r` (carriage return) from copy (only LF, not CRLF)
Labels: Issue-Feature,Area-Extensibility,Product-Terminal

<!-- 
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed!
-->

# Description of the new feature/enhancement

<!-- 
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
When copying from Windows Terminal (and basically any terminal), it copies an entire CRLF opposed to just LF. I am using WSL and sometimes need to copy text into another Linux environment. In doing so, it seems that when copying with CTRL + C, the end of line character is CRLF (`\r\n`), and Linux systems simply use LF (`\n`), so the input either is not parsed correctly or extra lines are added.

It seems all terminals do this on a Windows system, but it would be great if we had the option to disable this for Windows Terminal since it is often the recommended terminal for WSL, and it would be nice to use Linux convention while working in WSL.

The interim workaround I have found is using Autohotkey to write a key binding that copies and then uses regex matching to replace all occurrences of `\r` with the empty string. This is an OK solution but I think a native Windows Terminal solution would be nice.

<!-- 
A clear and concise description of what you want to happen.
-->
Repository: flutter
Issue: Add optional params to disable/edit open/close drawer animation
Labels: c: new feature,framework,f: material design,c: proposal,team-design,triaged-design

## Use case

Animations on web are slow and im hardcoding a width limit the drawer is coming from off screen and looks horrible. Currently there are no examples or ways to disable the animation or control the animation duration, or where the animation starts.

https://github.com/flutter/flutter/issues/16671#issuecomment-382264781  
seems to be the only "work around"
 

https://user-images.githubusercontent.com/17206638/124522500-7bc70800-ddc1-11eb-9da8-8e903f95aa86.mov


## Proposal

Add optional params in scaffold to control the drawer animations
Repository: godot
Issue: Gles2 3d lighting corrupted
Labels: bug,topic:rendering

### Godot version

3.3.2 stable

### System information

Win7, gles2, videocard: intel GMA 3600 series

### Issue description

The lighting in gles2 in 3d makes me my model invisible or destroyed and only need use unshaded to work :(

Also causes my videocard shutdown and bluescreen

### Steps to reproduce

Load a .obj file and put light in the 3d space near the .obj model

### Minimal reproduction project

_No response_
Repository: terminal
Issue: [Performance] vtebench tracking issue
Labels: Issue-Feature,Area-Performance,Product-Meta

This is an attempt to use [vtebench](https://github.com/alacritty/vtebench) by alacritty to measure & establish the performance baseline of Windows Terminal. 

The program itself requires `bash` so we can only test it through WSL and SSH. Still it shows the real-life performance of this product.
Repository: kubernetes
Issue: `kubectl logs` with the `--follow` args, the log loops indefinitely
Labels: kind/bug,sig/node,sig/cli,triage/accepted

<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!

If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->


#### What happened:
Under ARM64 environment, POD log parameter is the wireless cycle of log after Follow
#### What you expected to happen:
Record of normal output log updates
#### How to reproduce it (as minimally and precisely as possible):
It's always been that way
#### Anything else we need to know?:

#### Environment:
- Kubernetes version (use `kubectl version`):
- v1.19.0
- Cloud provider or hardware configuration:
- OS (e.g: `cat /etc/os-release`):
- Kylin Linux Advanced Server V10 (Tercel)
- Kernel (e.g. `uname -a`):
- 4.19.90-23.6.v2101.ky10.aarch64
- Install tools:
- Network plugin and version (if this is a network-related bug):
- Others:
Repository: pytorch
Issue: Incorrect trace with MKLDNN (adding scalar)
Labels: oncall: jit,module: mkldnn

## 🐛 Bug

Preface: MKLDNN does not allow addition with scalars. Hence, to workaround the issue, I first convert to dense. Then I add the scalar 1, then convert back to MKLDNN to continue.

When tracing the model using MKLDNN, the addition of the scalar disappears.

## To Reproduce

Steps to reproduce the behavior:

The following code has the issue:
```Python
class Test(nn.Module):
    def init(self):
        super(Test, self).__init__()
        self.op = SomeOp()
        self.last_block = ResidualBlock(in_channel, out_channel)
    def forward(self, x):
        out = self.op(x)
        if x.is_mkldnn:
            out = out.to_dense()
        out_last = self.last_block(out + 1)
        if x.is_mkldnn:
             out_last = out.to_mkldnn()
```

When the input, `x`, is CPU, it traces correctly with:
```Python
   out0 = torch.add(out0, CONSTANTS.c106)
```
When the input, `x`, is MKLDNN it traces incorrectly with:
```Python
    out0 = torch.to_dense(out)
    input59 = torch.to_mkldnn(out0)
```

Edit:
The following code does not exhibit the issue:
```Python
    def forward(self, x):
        out = self.op(x)
        out2 = out.to_dense() + 1
        out_last = self.last_block(out2.to_mkldnn())
```

## Expected behavior

It was expected that the add scalar would appear like:
```Python
    out0 = torch.to_dense(out)
    out1  = torch.add(out0, CONSTANTS.c106)
    input59 = torch.to_mkldnn(out0)
```

As a workaround, I made the torchscript look like this for the Module to work as expected:
```Python
    out0 = torch.to_dense(out)
    out1  = torch.add(out0, 1)
    input59 = torch.to_mkldnn(out0)
```

## Environment

 - PyTorch Version (e.g., 1.0): 1.10
 - OS (e.g., Linux): Windows
 - How you installed PyTorch (`conda`, `pip`, source): pip
 - Build command you used (if compiling from source): N/A
 - Python version: 3.8
 - CUDA/cuDNN version: N/A
 - GPU models and configuration: N/A
 - Any other relevant information: nightly

## Additional context
Repository: terminal
Issue: [Performance] Replace std::vector with more lightweight structure in `RenderData::GetPatternId`
Labels: Help Wanted,Area-Rendering,Area-Performance,Product-Meta,Issue-Task

This is about the scrolling test in #10563. A simplified repro would be:

```bash
time bash -c 'yes | head -n1000000'
```

which takes 7-8s with windows terminal and 300ms with gnome terminal.

Test case provided by @lhecker.

These lines show up in the hot paths of the trace of `OpenConsole`:

https://github.com/microsoft/terminal/blob/main/src/renderer/base/renderer.cpp#L788

![image](https://user-images.githubusercontent.com/4710575/124551976-7fac6600-de65-11eb-892c-982f5e8ab85b.png)

It appears that simply constructing empty `std::vector` (empty because this is in conhost/OpenConsole) is quite expensive.

CC @PankajBhojwani