Repository: opencv
Issue: Speed optimization of function ICAngles in orb.cpp
Labels: optimization,category: features2d

<!--
If you have a question rather than reporting a bug please go to https://forum.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).

This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->

##### System information (version)
- OpenCV => 4.2
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2017

##### Detailed description
This issue is expalantion of pr #25337 closed for creating new one.

Function ICAngles calculates the centroid of a pixel in the surrounding circular area. Since the process area is symmetric, consider four points: $v_1=a[-x_0,-y_0], \quad v_2=a[x_0,-y_0], \quad v_3=a[-x_0,y_0], \quad  v_4=a[x_0,y_0]$, then opencv now use a for loop iterating x, and process pixel with same absolute y value together:
```
 for (int v = 1; v <= half_k; ++v)
{
    // Proceed over the two lines
    int v_sum = 0;
    int d = u_max[v];
    for (int u = -d; u <= d; ++u)
    {
        int val_plus = center[u + v*step], val_minus = center[u - v*step];
        v_sum += (val_plus - val_minus);
        m_10 += u * (val_plus + val_minus);
    }
    m_01 += v * v_sum;
}
```
which means sum for point 1,3 is $sum_{1,3}=y_0(v_3-v_1)-x_0(v_3+v_1)$, and for point 2,4 is $sum_{2,4}=y_0(v_4-v_2)+x_0(v_4+v_2)$. Now I want to combine sum for these four points as $sum_{1,3}+sum_{2,4}=y_0(v_3-v_1+v_4-v_2)+x_0(v_4+v_2-v_3-v_1)$

total operation nums for these four points:
||mult|add|
|--|:--:|:--:|
|no optimization|8|8|
|opencv now|4|8|
|pr 25337|2|8|

Reduced ratio of operation nums is 1/6, consistent with time test in pr 25337.

Is there any problems? If not, I will make a new pr again.

##### Steps to reproduce

<!-- to add code example fence it with triple backticks and optional file extension
    ```.cpp
    // C++ code example
    ```
 or attach as .txt or .zip file
-->

##### Issue submission checklist

 - [x] I report the issue, it's not a question
   <!--
   OpenCV team works with forum.opencv.org, Stack Overflow and other communities
   to discuss problems. Tickets with questions without a real issue statement will be
   closed.
   -->
 - [x] I checked the problem with documentation, FAQ, open issues,
       forum.opencv.org, Stack Overflow, etc and have not found any solution
   <!--
   Places to check:
   * OpenCV documentation: https://docs.opencv.org
   * FAQ page: https://github.com/opencv/opencv/wiki/FAQ
   * OpenCV forum: https://forum.opencv.org
   * OpenCV issue tracker: https://github.com/opencv/opencv/issues?q=is%3Aissue
   * Stack Overflow branch: https://stackoverflow.com/questions/tagged/opencv
   -->
 - [x] I updated to the latest OpenCV version and the issue is still there
   <!--
   master branch for OpenCV 4.x and 3.4 branch for OpenCV 3.x releases.
   OpenCV team supports only the latest release for each branch.
   The ticket is closed if the problem is not reproduced with the modern version.
   -->
 - [x] There is reproducer code and related data files: videos, images, onnx, etc
   <!--
   The best reproducer -- test case for OpenCV that we can add to the library.
   Recommendations for media files and binary files:
   * Try to reproduce the issue with images and videos in opencv_extra repository
     to reduce attachment size
   * Use PNG for images, if you report some CV related bug, but not image reader
     issue
   * Attach the image as an archive to the ticket, if you report some reader issue.
     Image hosting services compress images and it breaks the repro code.
   * Provide ONNX file for some public model or ONNX file with random weights,
     if you report ONNX parsing or handling issue. Architecture details diagram
     from netron tool can be very useful too. See https://lutzroeder.github.io/netron/
   -->