sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: runtime: de-duplicate bit operations with math/bits
Labels: NeedsDecision,compiler/runtime

For the page allocator rewrite, @mknyszek tried to depend on `math/bits` in the runtime. This *almost* works, but conflicts with `go test -coverpkg=all` (#35461) because that tries to instrument `math/bits` in ways that are incompatible with running inside the runtime. In order to get this working, [CL 206199](https://golang.org/cl/206199) duplicated some `math/bits` functions into the runtime (and [CL 206200](https://golang.org/cl/206200) intrinsified them).

This duplication was expedient, but unfortunate, and for 1.15 I'd like to reconsider this. A few possibilities:

1. `-coverpkg=all` shouldn't apply to anything the runtime depends on. You'd hardly be losing anything if it didn't cover `math/bits` since almost all of those functions are intrinsified anyway.

2. If the cover tool can switch to using compiler-inserted coverage information, rather than source rewriting, it's possible this problem will go away.

/cc @dr2chase @cherrymui @mdempsky
Repository: angular
Issue: Missing space between currency code and value in currency pipe #2
Labels: area: common,area: i18n,P4

# 🐞 bug report

### Affected Package
The issue is caused by package @angular/common


### Is this a regression?
No

### Description
The original bug was closed by a bot before it was solved (see https://github.com/angular/angular/issues/20708).

@ocombe wrote:
> Since CLDR doesn't contain formats for finance currencies, I don't think that we can fix that. They have formats for currency accounting, but it doesn't seem to be that.
> The description for the currency pattern that we use is:
> 
> Used for currency values. A currency symbol (¤) is will be replaced by the appropriate currency symbol for whatever currency is being formatted. The choice of whether to use the international currency symbols (USD, EUR, JAY, RUB,…) or localized symbols ($, €, ¥, руб.,…) is up to the application program that uses CLDR.
> 
> Which seem to point to the fact that we are indeed using the correct pattern.

You are using the correct pattern, but according to the CLDR website (http://cldr.unicode.org/translation/number-patterns) there should be a space between currency code and numbers:

> ¤ | This will be replaced by a currency symbol, such as $ or USD. Note: by default a space is automatically added between letters in a currency symbol and adjacent numbers. So you don't need to add a space between them if your language writes "$12" but "USD 12".
Repository: opencv
Issue: Feature Request: Can we get Subdiv3D (Voronoi for Point3f)?
Labels: feature,effort: few weeks

### System information (version)
- OpenCV => Latest
- Operating System / Platform => Ubuntu 18.04
- Compiler => GCC 7

##### Detailed description

Currently, OpenCV provides `cv::Subdiv2D` and it allows us to construct the Voronoi diagram with `getVoronoiFacetList`, and the OpenCV version runs a lot faster than what I implemented myself.  However, currently, it is only limited to 2d points. I think it would be amazing if there's something like `cv::Subdiv3D` that can construct the Voronoi diagram with 3d points.
Repository: flutter
Issue: Expose TextPainter.computeLineMetrics on RenderParagraph
Labels: c: new feature,engine,a: typography,good first issue,P3,team-engine,triaged-engine

Hi there,

I have a need to access the line metrics of a rendered `Text` widget, and while the information is available on `TextPainter`, `RenderParagraph` doesn't expose it. Can we get a `computeLineMetrics` method on `RenderParagraph`?

Thanks!

cc @GaryQian
Repository: create-react-app
Issue: Why can't I use the homepage parameter?
Labels: issue: proposal


Here is a parameter description https://docs.npmjs.com/files/package.json#homepage

that does not match the description from https://create-react-app.dev/docs/deployment/#step-1-add-homepage-to-packagejson
Repository: pytorch
Issue: [jit] Printing the graph doesn't include function calls
Labels: oncall: jit,triaged

See question 1 here https://discuss.pytorch.org/t/jit-mobile-is-isinstance-supposed-to-work-with-torchscript/60845

cc @suo
Repository: pytorch
Issue: [FR] general nll_loss and cross_entropy along arbitrary dimension
Labels: module: loss,triaged

Currently it is always taken along `dim=1`. Making the dim configurable should be really easy. I'd do it if this sounds reasonable.
Repository: pytorch
Issue: [doc] Tensor.mean: dtype kwarg is not documented
Labels: module: docs,triaged,module: reductions

The following works:
```
>>> torch.__version__
'1.4.0a0+5635a72'

>>> x.mean(dtype=torch.float)
tensor(1.5000)
>>> help(x.mean)

>>> x.mean(dim=1, dtype=torch.float)
tensor([1.6667, 1.3333])

```

Yet the doc doesn't say anything about the `dtype` argument:
```
Help on built-in function mean:

mean(...) method of torch.Tensor instance
    mean(dim=None, keepdim=False) -> Tensor or (Tensor, Tensor)

    See :func:`torch.mean`
```
Repository: go
Issue: x/build/cmd/relui: Windows installation has misconfigured ACL: privilege escalation possible between users
Labels: Security,OS-Windows,Builders,NeedsInvestigation

The Golang msi installer in Windows install by default Go in C:\Go location. 
Files and subfolders of folders created under C:\ by default can be edited, created, deleted.

<pre>
PS C:\Go> icacls .
  BUILTIN\Administrators:(I)(OI)(CI)(F)
  NT AUTHORITY\SYSTEM:(I)(OI)(CI)(F)
  BUILTIN\Users:(I)(OI)(CI)(RX)
  NT AUTHORITY\Authenticated Users:(I)(M)
  NT AUTHORITY\Authenticated Users:(I)(OI)(CI)(IO)(M)
</pre>

This means that in a shared Windows environment, is it possible to exploit this insecure ACL to replace/backdoor go.exe binaries, dll and so on. 

### Scenario Local Privilege Escalation
A Standard User backdoor go.exe, waits for an Administrator to log in and run "go ..." or another component under C:\Go to successfully execute code under the latter elevated context. 

### Scenario Horizontal Privilege Escalation
A Standard User can backdoor/replace any component under C:\Go and wait for another Standard User to login and run Golang environment to achieve code execution in the context of the target user.

### What version of Go are you using (`go version`)?
Up to latest Golang version: 1.13

### Does this issue reproduce with the latest release?
Yes

### What operating system and processor architecture are you using (`go env`)?
<pre>
$ go env
set GOHOSTARCH=amd64
set GOHOSTOS=windows
</pre>

### What did you expect to see?
I was expecting the msi installer to reconfigure after installation the C:\Go default destination folder to have an ACL hardened to allow only Administrators, Administrator, SYSTEM, TrustedInstaller to have modify, write and special permissions over the Golang components.

### What did you see instead?
Authenticated Users have Modify permission over any Golang component, thus local privilege escalation is possible.
Repository: opencv
Issue: Not sure, think calib3d's calibration.cpp broke between 4.1.0 and 4.1.1
Labels: category: calib3d,incomplete

- OpenCV => 4.1.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2019

I've been looking at the code for stereoRectify for a long time. It's returning a lot of nonsense values for some of the calibrated cameras we have. I noticed the code changed from 4.1.0 to 4.1.1, in stereoRectify and it looks like the acos(x) stuff in there is silly and/or doesn't work. If whoever put that code in there really thinks its valid, how about some comments, because what is in there is really weird.

![calibration](https://user-images.githubusercontent.com/15388012/68809595-1b4dea80-0621-11ea-9df9-494284c12666.JPG)
Repository: terminal
Issue: UIA Formatted Text Navigation
Labels: Issue-Feature,Product-Conhost,Area-Accessibility,Product-Terminal,InclusionBacklog,InclusionBacklog-Windows TerminalWin32,A11yMAS,Disability-All

# Description of the new feature/enhancement

Text Ranges can be explored via a number of ways:
- Character
- Format
- Word
- Line
- Paragraph
- Page
- Document

We don't necessarily have to support all of them (refer to #3161 for us adding word navigation). But it would be interesting if we supported "format".

I envision us being able to jump between runs of formatted text. _Today_, the main formatting I can think of is _colored_ text composed of foreground and background color. Maybe we could just see if any have changed and, if that's the case, that would be a breakpoint for formatted text navigation.

# Proposed technical implementation details (optional)

Coincidentally, I just did a little bit of work in the AttrRowIterator. If that's actually taking a look at the text attributes, this would be an integral part of this design.
Repository: vscode
Issue: Enable breadcrumbs for unsaved files
Labels: feature-request,breadcrumbs,workbench-untitled-editors

Right now breadcrumbs for files (json, yaml, etc) only work if the file is saved. If I add a new file (File > New File), and set the language mode, the breadcrumbs should show the file structure without the file path part.
Repository: vscode
Issue: Word navigation in QuickOpen
Labels: feature-request,quick-pick

<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->


- VSCode Version:1.40.1
- OS Version:window10

Steps to Reproduce:

1.By going to file snapshot (CTRL +P),Type the word aaa:BBB:XXX in the open box

2.Then use the shortcut key CTRL + left or right head to move the cursor position

不合理现象:光标不能以冒号(:)为基本单位去移动位置
Unreasonable: the cursor cannot be moved with a colon (:) as the basic unit

<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
Repository: vscode
Issue: Make "move line" command to work contextually
Labels: feature-request,typescript,javascript,editor-autoindent

VSCode "move line" command is a fantastic feature. But it would be way more productive if it works with multiline key-values in objects.

For example imagine the following object declaration:
```js
const someObj = {
  isValid: false,
  position: {
    top: 1,
    bottom: 0,
  },
};
```
if we wanna move `position` including its value one line higher above `isValid`(either we have to select multiple lines or) it only moves the `position: {`.

It would be much more productive and ideal when the cursor is on the `position: {` line, the "move up" command moves the whole `position` key including its value (the nested object declaration) all together.

This would be the ideal result moving the `position` key only by one "move up" command:
```js
const someObj = {
  position: {
    top: 1,
    bottom: 0,
  },
  isValid: false,
};
```
instead of this:
```js
const someObj = {
  position: {
  isValid: false,
    top: 1,
    bottom: 0,
  },
};
```

Of course this could be done as an extension but I thought first brainstorm this with the team.
Repository: rust
Issue: Rustdoc: maybe don't display #[repr(C)] sometimes
Labels: T-rustdoc,A-attributes,C-bug

If a struct has some public fields and some non-public fields, `// some fields omitted` is displayed at the end of the declaration shown by rustdoc. Rustdoc also shows attributes on the declaration, such as `#[repr(C)]`.

This is actively misleading for `#[repr(C)]` types. If a private type is before any public types, then the struct as displayed suggests that the public fields are at the prefix of the struct, and thus have defined offsets smaller than where they actually are.

Example:

```rust
#[repr(C)]
#[derive(Debug, Eq, PartialEq, Hash)]
pub struct ThinData<Head, SliceItem> {
    length: usize,
    pub head: Head,
    pub slice: [SliceItem],
}
```
![image](https://user-images.githubusercontent.com/5992217/68825587-97b7ec00-0668-11ea-802f-09fa71986c99.png)


There are two obvious potential solutions:

- Put `// some fields omitted` in the correct place(s) among public fields for `#[repr(C)]` types, or
- Don't display `#[repr(C)]` for types with some fields omitted.
Repository: pytorch
Issue: android run build_pytorch_android.sh error
Labels: triaged,oncall: mobile

## 🐛 Bug

<!-- A clear and concise description of what the bug is. --> android build_pytorch_android.sh run error

## To Reproduce

Steps to reproduce the behavior:

1.connect android phone
1.compiled the whole code
1.run android/run_test.sh

<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->

## Expected behavior

Welcome to Gradle 5.0!

Here are the highlights of this release:
 - Kotlin DSL 1.0
 - Task timeouts
 - Dependency alignment aka BOM support
 - Interactive `gradle init`

For more details see https://docs.gradle.org/5.0/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* Where:
Build file '/home/Downloads/pytorch/android/libs/fbjni_local/build.gradle' line: 40

* What went wrong:
A problem occurred evaluating project ':fbjni'.
> Could not read script '/home/Downloads/pytorch/android/gradle/release.gradle' as it does not exist.


<!-- A clear and concise description of what you expected to happen. -->

## Environment

Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).

You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
```
Versions of relevant libraries:
[pip3] numpy==1.17.0
[conda] blas                      1.0                         mkl  
[conda] magma-cuda101             2.5.1                         1    pytorch
[conda] mkl                       2019.4                      243  
[conda] mkl-include               2019.4                      243  
[conda] mkl-service               2.3.0            py37he904b0f_0  
[conda] mkl_fft                   1.0.15           py37ha843d7b_0  
[conda] mkl_random                1.1.0            py37hd6b4f25_0  
[conda] torch                     1.4.0a0+104bb57          pypi_0    pypi



 - PyTorch Version (e.g., 1.4):
 - OS (e.g., Linux):
 - How you installed PyTorch (source in conda):
 - Build command you used (if compiling from source):
 - Python version:
 - CUDA/cuDNN version:10.1
 - GPU models and configuration:
 - Any other relevant information:

## Additional context

<!-- Add any other context about the problem here. -->
Repository: pytorch
Issue: unsqueeze has 'out=' option documented but not implemented(?)
Labels: module: docs,triaged

## 📚 Documentation

I think the documentation shouldn't include an _out=_ option,
I don't see any _unsqueeze_out()_ function in ATen..

```
>>> torch.unsqueeze(torch.tensor([1,2.0]),-1,out=r)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: unsqueeze() got an unexpected keyword argument 'out'
```
Repository: TypeScript
Issue: A property descriptor must have keys "enumerable" and "configurable"
Labels: Bug,Domain: lib.d.ts

**TypeScript Version:**  3.7.2

**Expected behavior:** In a property descriptor object, keys `configurable` and `enumerable` should not be optional.

**Actual behavior:** These properties are marked as optional (see [here][1] and [here][2]).

[1]: https://github.com/microsoft/TypeScript/blob/v3.7.2/src/lib/es5.d.ts#L88-L89
[2]: https://github.com/microsoft/TypeScript/blob/v3.7.2/src/lib/es5.d.ts#L1368-L1369
Repository: terminal
Issue: Add a setting to control selection foreground color
Labels: Help Wanted,Area-Rendering,Area-TerminalControl,Product-Terminal,Issue-Task

This is highly related to #3326/#3471 and #3561.

We've added a setting to control what color we use to highlight text with when it's selected in #3471.

However, that doesn't _necessarily_ fix our contrast ratio problems w.r.t. selection, since the configured color might still not have enough difference from the foreground of the highlighted text.

Conhost had an inverting selection, which didn't have this problem. However, we think that might be Hard to implement in the dx renderer. Adding that to the Terminal is being tracked in #3561. 

A selection foreground color 
A: might be more feasible to implement
B: is a good configurable setting to add regardless, to enable further personalization of the terminal.

Implementation might still be tricky though, since the Renderer is only ever told about the selection rects _after_ it has drawn the text. Re-drawing the text seems like a bad idea. I'm not sure we'll be able to re-order things in the Renderer safely without also impacting the GDI and other rendering heads. This is hard, but easier than inverting selection.
Repository: flutter
Issue: [local_auth] sticky set to true does not work
Labels: platform-android,p: local_auth,package,P2,team-android,triaged-android

Hi, I'm using this plugin on my Xiami Redmi Note 5 and I have a problem when app call uthenticate and then goes in background.
When app resume the promp authenticate is not shown and authenticateWithBiometrics return false.
I found out onActivityPaused is not fired.
Thanks!

Logs
```
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.9.1+hotfix.2, on Microsoft Windows [Versione 10.0.16299.1451], locale it-IT)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.1)
[√] Android Studio (version 3.3)
[√] IntelliJ IDEA Community Edition (version 2018.1)
[√] VS Code, 64-bit edition (version 1.23.1)
[√] Proxy Configuration
[√] Connected device (1 available)

• No issues found!_auth
```
Repository: pytorch
Issue: SGD fails on sparse matrix
Labels: module: sparse,module: optimizer,triaged

## 🐛 Bug

One SGD step for optimizing a model with a sparse parameter matrix gives me a RuntimeError


## To Reproduce


```
import torch
from torch import nn

class TrainNet(nn.Module):
    def __init__(self, in_features, out_features):
        super(TrainNet, self).__init__()
        self.in_features = in_features
        self.out_features = out_features
        self.weight = torch.nn.Parameter(torch.randn(out_features, in_features).to_sparse().requires_grad_(True))


    def forward(self, input):
        x = torch.sparse.mm(self.weight, input)
        return x


model = TrainNet(10, 20)
opt = torch.optim.SGD(model.parameters(), 0.01)
inp = torch.ones((10, 30), dtype=torch.float32)
model.train()

model.zero_grad()
out = model(inp)
out.sum().backward()
opt.step()
```

gives me the error 
```
Traceback (most recent call last):
  File "<input>", line 25, in <module>
  File "/Users/antonio/miniconda3/envs/python3_6/lib/python3.6/site-packages/torch/optim/sgd.py", line 106, in step
    p.data.add_(-group['lr'], d_p)
RuntimeError: set_indices_and_values_unsafe is not allowed on a Tensor created from .data or .detach().
If your intent is to change the metadata of a Tensor (such as sizes / strides / storage / storage_offset)
without autograd tracking the change, remove the .data / .detach() call and wrap the change in a `with torch.no_grad():` block.
For example, change:
    x.data.set_(y)
to:
    with torch.no_grad():
        x.set_(y)
```


## Environment
```
PyTorch version: 1.3.1
Is debug build: No
CUDA used to build PyTorch: None

OS: Mac OSX 10.14.6
GCC version: Could not collect
CMake version: version 3.15.4

Python version: 3.6
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA

Versions of relevant libraries:
[pip] numpy==1.17.2
[pip] torch==1.3.1
[pip] torchvision==0.4.2
[conda] _tflow_select             2.3.0                       mkl  
[conda] blas                      1.0                         mkl  
[conda] mkl                       2019.4                      233  
[conda] mkl-service               2.3.0            py36hfbe908c_0  
[conda] mkl_fft                   1.0.14           py36h5e564d8_0  
[conda] mkl_random                1.1.0            py36ha771720_0  
[conda] pytorch                   1.3.1                   py3.6_0    pytorch
[conda] tensorflow                1.14.0          mkl_py36h933f829_0  
[conda] tensorflow-base           1.14.0          mkl_py36h655c25b_0  
[conda] torchvision               0.4.2                  py36_cpu    pytorch
```
## Additional context

Just changing on `sgd.py`:
```
p.data.add_(-group['lr'], d_p)
```
to:
```
with torch.no_grad():
    p.add_(-group['lr'], d_p)
```
seems to fix the problem.


cc @vincentqb
Repository: rust
Issue: Demangle C++ functions in backtraces
Labels: A-runtime,T-libs-api,C-feature-request

I'm modding a C++ game (which contains debug symbols, thanks flibitijibibo!) using Rust. If I panic in a Rust function from my mod, this is what the backtrace looks like:
```
thread '<unnamed>' panicked at 'panic test', src/lib.rs:37:5
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:77                                                                                   
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:61
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1030
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1412
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:65
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:50
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:188
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:205
  10: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:464
  11: std::panicking::begin_panic
             at /rustc/bc0e288ad02ef362b5a6c42aaf61f2901c9b46db/src/libstd/panicking.rs:400
  12: vloader::hook_physfs_init
             at src/lib.rs:37
  13: core::ops::function::Fn::call
             at /rustc/bc0e288ad02ef362b5a6c42aaf61f2901c9b46db/src/libcore/ops/function.rs:69
  14: <alloc::boxed::Box<F> as core::ops::function::Fn<A>>::call
             at /rustc/bc0e288ad02ef362b5a6c42aaf61f2901c9b46db/src/liballoc/boxed.rs:956
  15: vloader::PHYSFS_INIT::__ffi_detour
             at /home/leo60228/vloader/<::detour::macros::static_detour macros>:31
  16: _Z15FILESYSTEM_initPc
             at /home/flibitijibibo/Programming/cppProjects/Contracts/VVVVVV/Src/FileSystemUtils.cpp:39
  17: main
             at /home/flibitijibibo/Programming/cppProjects/Contracts/VVVVVV/Src/main.cpp:39
  18: __libc_start_main
  19: <unknown>
```
This backtrace is almost perfect, except for the ugly mangled C++ symbol. Now that #65646 allows unwinding through C++ code, it would be nice if Rust demangled them. `backtrace-rs` already supports this behind a feature, and I tried enabling it through xargo, but it didn't work. I think this might be because of the way std prints backtraces.