sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: godot
Issue: Godot with mono crashes when opening a project with the name contains a comma
Labels: bug,topic:editor,confirmed,topic:dotnet,crash

**Godot version:**
v3.2.4.beta.mono.custom_build. 639fdefc1


**OS/device including version:**
Windows 10

**Issue description:**
The engine crashes when opening a project with a comma-separated name.

```
Godot Engine v3.2.4.beta.mono.custom_build.639fdefc1 - https://godotengine.org
WinTab context creation failed.
Using GLES2 video driver
OpenGL ES 2.0 Renderer: GeForce GTX 970/PCIe/SSE2
OpenGL ES Batching: ON
        OPTIONS
        max_join_item_commands 16
        colored_vertex_format_threshold 0.25
        batch_buffer_size 16384
        light_scissor_area_threshold 1
        item_reordering_lookahead 4
        light_max_join_items 32
        single_rect_fallback False
        debug_flash False
        diagnose_frame False
WASAPI: wFormatTag = 65534
WASAPI: nChannels = 2
WASAPI: nSamplesPerSec = 48000
WASAPI: nAvgBytesPerSec = 384000
WASAPI: nBlockAlign = 8
WASAPI: wBitsPerSample = 32
WASAPI: cbSize = 22
WASAPI: detected 2 channels
WASAPI: audio buffer frames: 1962 calculated latency: 44ms

Mono: Initializing module...
Mono JIT compiler version 6.12.0 (Visual Studio built mono)
Mono: Log file is: '.../mono/mono_logs/2020_12_03 02.54.51 (5232).txt'
Mono: Runtime initialized
Mono: Loading assembly mscorlib...
Mono: Assembly mscorlib loaded from path: .../mono/4.5/mscorlib.dll
Mono: Loading scripts domain...
Mono: Creating domain 'GodotEngine.Domain.Scripts'...
Mono: INITIALIZED
Mono: Loading assembly GodotSharp...
Mono: Assembly GodotSharp loaded from path: .../One, Two/.mono/assemblies/Debug/GodotSharp.dll
Mono: Loading assembly GodotSharpEditor...
Mono: Assembly GodotSharpEditor loaded from path: .../One ,Two/.mono/assemblies/Debug/GodotSharpEditor.dll
Mono: Loading assembly GodotTools...
Mono: Assembly GodotTools loaded from path: .../GodotSharp/Tools/GodotTools.dll
Mono: Loading assembly GodotTools.ProjectEditor...
Mono: Assembly GodotTools.ProjectEditor loaded from path: .../GodotSharp/Tools/GodotTools.ProjectEditor.dll
Mono: Loading assembly One, Two...
ERROR: GDMonoLog::mono_log_callback: Mono: FATAL ERROR '* Assertion at ..\mono\metadata\appdomain.c:2553, condition `aname != NULL' not met
 (in domain , error)', ABORTING! Logfile: '.../mono/mono_logs/2020_12_03 02.54.51 (5232).txt'.
   At: modules\mono\mono_gd\gd_mono_log.cpp:93
```

But others such as ```!@#$%^&*()_+/*-+./'`}{[];:№?``` do not cause problems (some symbols just replaced by - ).
```
Mono: Loading assembly Accelerometer!@#$%^&-()_+---+.-'`}{[];-№- Magnetometer and Gyro Demo...
```

**Steps to reproduce:**
Create a project with a comma-separated name, such as "One, Two", and open it

**Minimal reproduction project:**
[One, Two.zip](https://github.com/godotengine/godot/files/5632722/One.Two.zip)
Repository: flutter
Issue: debugOnRebuildDirtyWidget and debugPrintRebuildDirtyWidgets don't work reliably for RenderObjectElements
Labels: framework,a: quality,a: debugging,has reproducible steps,P3,found in release: 3.10,found in release: 3.12,team-framework,triaged-framework

For example, if you set debugPrintRebuildDirtyWidgets to true, you'll never see it print that a ColoredBox is being built.
Repository: bitcoin
Issue: addnode RPC call should return success/failure indicator
Labels: Feature

Calling `bitcoin-cli addnode i-am-not-an-address onetry` fails immediately and permanently, but does not give any indication that happened. Having `addnode .. onetry` instead block and return either an error or indicate the peer id of the new connection would probably be better. See also https://github.com/bitcoin/bitcoin/pull/19315#pullrequestreview-528084558
Repository: TypeScript
Issue: [Meta] Refactors of React hooks
Labels: Suggestion,Awaiting More Feedback

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ

-->

## Search Terms
refactor, react, hooks
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->

## Suggestion

Provide a series of refactors about react hooks.


<!-- A summary of what you'd like to see added or changed -->

## Use Cases

In my recently works. I have alway Wrap function, value declarations, expressions into `React.useMemo` or `React.useCallback`.
And I must find all the depends on the selection. And always missing some deps. It's not a good experience.

Could we provide some refactors to wrap something into well-known react hooks? 

I'm not sure where's the **bar** of patterns we are allowed. but we have already had something like 'react-jsx'.

<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->

## Examples


```tsx

const Comp = props => {
  const value = props.a + props.b;

  const handleClick = () => {
    console.log('foo', value)
  }

  return <div onClick={handleClick}><SomeHeavyComponent value={value}/></div>
}

```

- When I select `props.a + props.b`, convert into 

```tsx
React.useMemo(() => props.a + props.b, [props.a, props.b]);
```

- When I select `handleClick ` or the lambda, convert into
```tsx
const handleClick = React.userCallback() => {
  console.log('foo', value)
}, [value])
```
- When I select `<SomeHeavyComponent value={value}/>`, convert into 
```tsx
React.useMemo(() => (<SomeHeavyComponent value={value}/>), [value])
```



<!-- Show how this would be used and what the behavior would be -->

## Checklist

My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Repository: go
Issue: database/sql: shutdown connections gracefully
Labels: NeedsInvestigation

It would be nice to have a way to ask `sql.DB` to shutdown its connections gracefully. There's a `SetMaxIdleConns()` method that can be set to `-1` to clear out all idle connections. However, this does not shutdown any active connections gracefully.

Our use-case is due to database credentials being rotated using Vault or AWS's IAM credentials for RDS. In both instances, we are handed dynamically generated usernames and passwords that will be revoked after a certain amount of time. New credentials are then generated.

In order to update the credentials in a given `sql.DB` instance, we have written a simple wrapper driver that provides the ability to customize the creation of a new connection using the `Connector` interface via a function hook: https://github.com/Boostport/dynamic-database-config

The only thing that's missing is the ability to signal `sql.DB` to shutdown all connections gracefully, that is to allow all current queries to complete, but not allow new ones to be scheduled on the current connections and then closing them once the current queries connect. This would then free up connections and force `sql.DB` to create new connections, which using our driver wrapper would produce connections with the new credentials.
Repository: go
Issue: cmd/go: add global ignore mechanism for Go tooling ecosystem
Labels: Proposal,Proposal-Accepted,GoCommand,modules

UPDATE: The summary of the accepted proposal at: https://github.com/golang/go/issues/42965#issuecomment-1974089649.

- - -


## Problem

For non-trivial (often multi-language) projects it's often desirable to make all the Go tools (including `gopls`) ignore certain directories.

Some of the examples could be the huge amount of files within `node_modules`, or `bazel-*` directories generated by Bazel. This causes many operations with `./...` wildcards taking longer than desired. Also `gopls` often eats up a lot of CPU in VS Code depending on what you are doing.

## Prior Art

This is something that has been discussed in several issues before, but seems like people couldn't get agree on a solution.

- https://github.com/golang/go/issues/30058
- https://github.com/golang/go/issues/35914
- https://github.com/golang/go/issues/42473

Some tools started to have their own solutions which causes fragmentation and is cumbersome.

For example `goimports` have its own machinery for this - `.goimportsignore` file in this case. But it's not working with Go Modules.

Other tools have a hard-coded list of directories to ignore, like `.git` and so on.

It seems like having a global solution that all the Go ecosystem could understand would make sense to solve this kind of problem.

Recently a workaround for this was to place a dummy `go.mod` file in the directories you wanted to ignore. But this is not easily portable between users of the project, because often these directories can be re-created on the user's machine and aren't even checked-in. Asking people to sprinkle some `go.mod` files all around every time is cumbersome.

@robpike was against of creating more dot files (https://github.com/golang/go/issues/30058#issuecomment-475003231).

## Proposed Solution

Here're some of the options that this could be implemented with.

1. ~~Use `go.mod` file for specifying directories to ignore.~~ (Rejected because `go.mod` is not a catch-all config file like `package.json` in NodeJS).
2. ~~Use a separate `.goignore` file.~~ (This would go against Rob's desire to avoid new dot files, and although being in the spirit with other tools: `.dockerignore`, `.gitignore`, `.bazelignore`, etc. is concerning. The concerns are discussed in this thread).
3. Use the `go.work` file that's coming in the next Go 1.18 release.
4. Have a separate `go.ignore` file that would specify directories to ignore.




/cc @tj @stamblerre
Repository: PowerToys
Issue: [Run][New Plugin] Regex line search (full text search)
Labels: Idea-Enhancement,Product-PowerToys Run,Run-Plugin

Could powerrun also search the content of text files, pdfs etc. (Similar to https://github.com/phiresky/ripgrep-all)
Repository: storybook
Issue: Docs addon is not showing story code (No code available) unless you provide an unused variable into the function parameters
Labels: bug,addon: docs,source-loader

**Describe the bug**
The docs addon is showing the error `No code available` if you do not provide a variable into the story function, regardless if the variable is used or not. 

**To Reproduce**
```json
    "@storybook/addon-a11y": "6.1.9",
    "@storybook/addon-actions": "6.1.9",
    "@storybook/addon-backgrounds": "6.1.9",
    "@storybook/addon-controls": "^6.1.9",
    "@storybook/addon-docs": "6.1.9",
    "@storybook/addon-links": "6.1.9",
    "@storybook/addon-storysource": "6.1.9",
    "@storybook/addon-viewport": "6.1.9",
    "@storybook/addons": "6.1.9",
    "@storybook/preset-typescript": "^3.0.0",
    "@storybook/vue": "6.1.9",
```

**Expected behavior**
Both stories, `exampleOne` and `exampleTwo`, should have the ability to view their story code form within the docs addon.

**Screenshots**
Note how the first one does not have code available, whereas the second one does. See the code snippet of the stories from this screenshot.
![image](https://user-images.githubusercontent.com/11144798/100983915-e10ffd80-3541-11eb-9f4f-1299107fc15e.png)

**Code snippets**
```javascript
// .storybook/main.js

const path = require("path");

module.exports = {
	stories: ['../src/components/**/*.stories.ts'],
	addons: [
		"@storybook/addon-actions",
		"@storybook/addon-links",
		"@storybook/preset-typescript",
		"@storybook/addon-a11y/register",
		"@storybook/addon-storysource",
		"@storybook/addon-viewport",
		"@storybook/addon-backgrounds/register",
		"@storybook/addon-docs",
		"@storybook/addon-controls",
	],
	webpackFinal: async (config, { configType }) => {
		config.module.rules.push({
			test: /\.scss$/,
			use: ['style-loader', 'css-loader', 'sass-loader', {
				loader: 'style-resources-loader',
				options: {
					patterns: [path.resolve(__dirname, '../src/styles/global.scss')]
				}
			}]
		});

		config.module.rules.push({
			test: /\.(graphql|gql)?$/,
			loader: 'graphql-tag/loader'
		})

		config.resolve.alias['@'] = path.resolve(__dirname, '../src')

		return config;
  },
};
```

```typescript
// src/components/example.stories.ts

export const exampleOne: () => void = () =>
	defineComponent({
		template: `<div>Hello world - One</div>`,
	});

export const exampleTwo: (args: { [key: string]: string | boolean }) => void = (args) =>
	defineComponent({
		template: `<div>Hello world - Two</div>`,
	});
```

**Additional context**
This was not an issue with version `6.0.27`.
Repository: flutter
Issue: When fullSizeContentView is set, paddings should be exposed through MediaQuery
Labels: c: new feature,framework,engine,platform-mac,a: fidelity,a: quality,a: desktop,P2,team-macos,triaged-macos

When [`fullSizeContentView`](https://developer.apple.com/documentation/appkit/nswindow/stylemask/1644646-fullsizecontentview) is set on the NSWindow's StyleMask, the native title bar is gone and the close/min/max buttons are moved into the content. We should re-expose that value in the MediaQuery padding. Otherwise, the Flutter content will overlap with the native window buttons, like:

![Screen Shot 2020-12-03 at 12 53 55 AM](https://user-images.githubusercontent.com/156888/100986447-0f6de880-3502-11eb-82c2-81cdc293bbca.png)
Repository: TypeScript
Issue: Incorrect any type distilled from extended generic after typeof check
Labels: Bug

**TypeScript Version:**  4.1.2 and 4.2.0-dev.20201202

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** extended generic typeof any

**Code**

```ts
type Identifier = string;

interface Identifiable {
	readonly id: Identifier;
}

class DropdownItem<ID extends Identifier> implements Identifiable {
	public readonly id: ID;
	public readonly name: string;

	public constructor(id: ID, name: string) {
		this.id = id;
		this.name = name;
	}
}

const defaultItemGetCells = (item: Identifiable): string[] => {
	if (item instanceof DropdownItem) {
		return [ item.id, item.name ]; //item.id is incorrectly typed as any
	} else {
		return [ item.id ]; //item.id is correctly typed as string
	}
};
```

**Expected behavior:**
The type of item.id on line 19 is correctly identified as a string (just like on line 21). It should always be at least a string, even is no generic is passed to `DropdownItem` (And I can't pass a generic because it's plain old javascript). If I remove the `name` field from the `DropdownItem`, it infers correctly.

**Actual behavior:**
The type of item.id on line 19 is incorrectly identified as any, this causes our typescript-eslint no any rule to kick in.
![Screenshot 2020-12-03 at 08 58 56](https://user-images.githubusercontent.com/1841343/100987155-6e594f00-354e-11eb-9967-e75689efa484.png)

**Playground Link:** [Example](https://www.typescriptlang.org/play?ts=4.2.0-dev.20201202#code/C4TwDgpgBAkgJhAdsAlgMxRATlAvFAZ2CxUQHMBuAKCtOGzQEMBjaeJVDRgIwBtoA3lQCQWCIzgB7RLxBQUcAFywEydJizUAvjWa9GBAlAAiWSWCkB3RDHoBbADwxjUCAA96iOEfZqM2AD55OzB+Ow4fVU4UHn4oIWEwAFc+FGYoMQlpWXklWGNqRJTeNIzxKRk5REZw5SIScmoRZNT05ml6pOZgSSwACgVlZwAaKGrawmJSMgBKeJFhYAALFAIAOgU8XMLFlfXx6HwDwp0dKnbEIigEJiTeYFsIOwBxCGAAYQheXiN8AfshlF1LEIDM6lNyABtAC6eCCCXQUH+T3kl2AjEQrEkaBMZgskmsjzscwSojeSSwiCgkPk9g2cFGKDpByg0IoUAA9BymU96fIjKR2lgxN0cqBIHAoAYpYgQCItK4foIFmJgBSqTSeXY+WzOdy6ZtVlAhSLgGLwBBJdL6tN5VQtBQgA)

**Related Issues:** I could find nothing that looked similar
Repository: opencv
Issue: GAPI: dangling reference warning in gapi_infer_ie_test.cpp
Labels: category: g-api / gapi

##### System information (version)
<!-- Example
- OpenCV => 4.2
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2017
-->

- OpenCV => master (7a5c2e9df1a208b10d5b6be549b2b28225321ba7)
- Operating System / Platform => mac OS X
- Compiler => AppleClang 12.0.0.12000032

##### Detailed description

<!-- your description -->

##### Steps to reproduce
from [buildbot log](https://pullrequest.opencv.org/buildbot/builders/master_openvino-mac/builds/584/steps/compile%20release/logs/stdio) : 
```
/build/master_openvino-mac/opencv/modules/gapi/test/infer/gapi_infer_ie_test.cpp:68:16: warning: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
    auto &ii = net.getInputsInfo().at("data");
               ^~~~~~~~~~~~~~~~~~~
```

##### Issue submission checklist

 - [x] I report the issue, it's not a question
   <!--
   OpenCV team works with answers.opencv.org, Stack Overflow and other communities
   to discuss problems. Tickets with question without real issue statement will be
   closed.
   -->
 - [x] I checked the problem with documentation, FAQ, open issues,
       answers.opencv.org, Stack Overflow, etc and have not found solution
   <!--
   Places to check:
   * OpenCV documentation: https://docs.opencv.org
   * FAQ page: https://github.com/opencv/opencv/wiki/FAQ
   * OpenCV forum: https://answers.opencv.org
   * OpenCV issue tracker: https://github.com/opencv/opencv/issues?q=is%3Aissue
   * Stack Overflow branch: https://stackoverflow.com/questions/tagged/opencv
   -->
 - [x] I updated to latest OpenCV version and the issue is still there
   <!--
   master branch for OpenCV 4.x and 3.4 branch for OpenCV 3.x releases.
   OpenCV team supports only latest release for each branch.
   The ticket is closed, if the problem is not reproduced with modern version.
   -->
 - [x] There is reproducer code and related data files: videos, images, onnx, etc
   <!--
   The best reproducer -- test case for OpenCV that we can add to the library.
   Recommendations for media files and binary files:
   * Try to reproduce the issue with images and videos in opencv_extra repository
     to reduce attachment size
   * Use PNG for images, if you report some CV related bug, but not image reader
     issue
   * Attach the image as archive to the ticket, if you report some reader issue.
     Image hosting services compress images and it breaks the repro code.
   * Provide ONNX file for some public model or ONNX file with with random weights,
     if you report ONNX parsing or handling issue. Architecture details diagram
     from netron tool can be very useful too. See https://lutzroeder.github.io/netron/
   -->
Repository: react-native
Issue: Transform rotate style property doesn't work properly on ios
Labels: Platform: iOS,Issue: Author Provided Repro

### Description
I use @react-native-community/slider and I needed to rotate the slider.

To do so I used the css property transform, and rotate. It works well on android, but not on ios.
The slider stay to it's original position.
When I change the rotate value while I'm visualizing the slider, it rotates after the automatic assets refresh. But when I leave the screen and go back to it, the slider isn't rotated anymore.

### React Native Version

0.63.4, (also experienced this behavior on 0.63.3).

Infos : 

System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 60.75 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.19.0 - /var/folders/m1/qrp6lm356p5_802qt9vkc9tc0000gn/T/yarn--1606988176529-0.7023249601521031/node
    Yarn: 1.22.10 - /var/folders/m1/qrp6lm356p5_802qt9vkc9tc0000gn/T/yarn--1606988176529-0.7023249601521031/yarn
    npm: 6.14.8 - /usr/local/bin/npm
    Watchman: 20200920.192359.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.2, DriverKit 20.0, macOS 11.0, tvOS 14.2, watchOS 7.1
    Android SDK:
      API Levels: 29, 30
      Build Tools: 29.0.2, 30.0.2
      System Images: android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.8743.12.41.6858069
    Xcode: 12.2/12B45b - /usr/bin/xcodebuild
  Languages:
    Java: javac 15 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1 
    react-native: 0.63.4 => 0.63.4 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

### Steps to reproduce

Rotate an element with transform rotate style properties. 

### Expected result

The rotation is working on both android and ios.

### Snack, code example, screenshot, or link to a repository:

The slider :
`<Slider
                            style={styles.fontSizeSlider}
                            minimumValue={20}
                            maximumValue={50}
                            minimumTrackTintColor="#FFFFFF"
                            maximumTrackTintColor="#000000"
                            thumbTintColor="#FFFFFF"
                            onValueChange={handleValueChange}
                            value={textSize}
                        />`

Associated style : 
`fontSizeSlider: {
        flexBasis: '30%',
        width: 200,
        height: 40,
        transform: [{ rotate: '-90deg' }],
    },`

The slider is under a flex container wich has the following css attributes : 

`inputContainer: {
        top: '50%',
        display: 'flex',
        flexDirection: 'row',
        flexWrap: 'wrap',
        alignContent: 'center',
    },`
Repository: go
Issue: crypto/tls: add support for Certificate Compression (RFC 8879)
Labels: NeedsDecision,FeatureRequest

[RFC 8879](https://www.rfc-editor.org/rfc/rfc8879.html) has recently been published. The RFC describes a way to compress the TLS certificate chain when using TLS 1.3.

Compressing the certificate chain reduces the number of bytes exchanged during the handshake. While sending fewer bytes is always a win for performance, this becomes especially important for QUIC, where due to the lack of the TCP 3-way handshake, the server's first flight (which contains the certificate chain) is limited to 3x the number of bytes that it received from the client, see https://www.fastly.com/es/blog/quic-handshake-tls-compression-certificates-extension-study for real world data.

Since the Certificate message is encrypted in TLS 1.3, it is not possible to implement certificate compression without access to the keys derived during the handshake, i.e. outside of the standard library.

The RFC describes 3 different compression algorithms that TLS endpoints can advertise support for: zlib, zstd and brotli.

Chrome has had support for this extension since version 69 using the brotli algorithm: https://www.chromestatus.com/feature/5696925844111360.

Implementation-wise, there are a few options here:
1. Add support for zlib compression first. zlib is already a part of the standard library, so support could be added without any API changes to crypto/tls and without any changes outside of that package.
2. Also add support for brotli, to get the performance benefits when serving a Chrome client. brotli is not implemented in the standard library though. One could:
    1. include brotli in the standard library (either as an internal package, or an exposed package), then use it in crypto/tls
    2. define a callback for the `tls.Config`: `GetCertificateCompressor(enum int) CertificateCompressor`