sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: bitcoin
Issue: Could the wallet count unconfirmed non-mempool change?
Labels: Brainstorming,Wallet

Just writing down some thoughts on this.

I find it quite counter-intuitive that if you have a 1 BTC output and make a transaction spending 0.01 BTC and sending 0.99 BTC back to yourself in change, that unless that transaction is in your mempool, your balance drops from 1 to 0.   Unconfirmed change in the mempool appears in available balance (assuming we can spend 0-conf change), but if it is not in the mempool it is not reflected at all, but the output spent in the transaction is still spent.

This can occur because walletbroadcast=0 and you're delaying broadcast or using another broadcast method or because the initial transaction was evicted.  In either case though it doesn't make sense to count the entire input as spent but not credit the change output.

I believe it would make sense to include the unconfirmed non-mempool change in the pending balance.

Unfortunately this is non-trivial.  This can best be seen by the example of two transactions in the wallet that spend the same input.  Naively you'd double count the change, which is clearly wrong.  It's non-obvious which change you should count nor how you would go about implementing that if you did have a plan.  One idea would be if you had a mempool package acceptance test (ala @sdaftuar) you could try to add all non-mempooled wallet transactions incrementally in time order, and take the resulting putative mempool state as what would count.  But its starting to get a bit cumbersome.  Another idea would be to check the unconfirmed non-mempool change for potential conflicts and only count the smallest change.

There are other aspects of trickiness such as mixed debit transactions.
Repository: pytorch
Issue: Variable outputs of stochastic functions should never require grad
Labels: module: distributions,triaged

I don't think we should bother to implement reparametrized gradients for Variable functions (`torch.distributions` will have them + I don't think it's possible for bernoulli), and if we keep setting these outputs to `requires_grad=True` and pushing back zeros some people might be confused. Also, this doesn't match the legacy behavior, and can make some in-place checks that passed before fail.

Let's just make them non-differentiable...

cc @vincentqb @fritzo @neerajprad @alicanb @vishwakftw
Repository: kubernetes
Issue: Deployment enters creation hot-loop when rs field is mutated by API server
Labels: kind/bug,priority/important-soon,area/reliability,sig/apps,lifecycle/frozen

/kind bug

### What Happened

A deployment enters create new replicaset hot-loop. 

In deployment's spec.template:
```yaml
      volumes:
      - emptyDir:
          sizeLimit: "0"
        name: foo
```

In its rs's spec.template:
```yaml
      volumes:
      - emptyDir: {}
        name: foo
```

This will happen when you create a Deployment that specifies `volumes.EmptyDir` in 1.7.0 - 1.7.5, and then upgrade the cluster to >= 1.8.0, with LocalStorageCapacityIsolation disabled.

### Root Cause 

Some background information:
1. In pod spec, a new field `volumes.EmptyDir.sizeLimit` was introduced in 1.7.0, it's an optional field, but incorrectly set as `resource.Quantity` type. 
1. To fix the above issue, it's changed to pointer type `*resource.Quantity` later (#50163) in 1.8.0 and backported to 1.7.6. 
1. In 1.8.0, this field is set to `nil` if the LocalStorageCapacityIsolation feature isn’t enabled: 
https://github.com/kubernetes/kubernetes/blob/v1.8.0/pkg/api/pod/util.go#L242 (this fix will soon be cherrypicked to the next 1.7.x release).
1. Deployment creates a new rs by copying its own template to the rs. Deployment finds a new rs by comparing the deployment's template against the replicasets it owns. 

If you create a Deployment that specifies `volumes.EmptyDir` in 1.7.0 - 1.7.5, it will incorrectly set sizeLimit to "0" by default, because of **1** mentioned above. 

```yaml
      volumes:
      - emptyDir:
          sizeLimit: "0"
        name: foo
```

If you then upgrade the cluster to 1.8.0, the `sizeLimit: "0"` in rs will be cleared, because of **3** mentioned above .

Deployment cannot find its new replicaset because of the template change, and continuous creating more new replicasets, which will still have different template after creation. 

### Solution 

A possible solution is to implement `Create()` in dry-run mode, and have deployments to use dry-run created repliaset template (instead of deployment template) to compare and find current replicaset. This is a long term solution. 

A possible short term solution is to implement a hack that clears Deployment's `volumes.EmptyDir.sizeLimit` with ReplicaSets. The code here should do the trick: https://github.com/kubernetes/kubernetes/blob/release-1.8/pkg/registry/extensions/deployment/strategy.go#L90-L91 except that the Deployment needs to be updated to trigger this cleanup code. 

### Workaround 

For someone who hit this issue, updating a deployment will trigger https://github.com/kubernetes/kubernetes/blob/release-1.8/pkg/registry/extensions/deployment/strategy.go#L90-L91 and thus solve the problem automatically. 

@kubernetes/sig-apps-bugs @liggitt
Repository: flutter
Issue: We should expose the locale's preferred baseline
Labels: c: new feature,framework,a: internationalization,a: typography,P3,team-framework,triaged-framework

...once we support multiple baselines, anyway.
Repository: youtube-dl
Issue: Add support for Adobe Pass Auth TV Provider YouTubeTV
Labels: tv-provider-account-needed

---

### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.12.14*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.12.14**

### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones

### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other

---

### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*

---

### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:

Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):

```
you http://watchdisneyxd.go.com/atomic-puppet/video/vdka4074861/01/26-finale-a-finale-b --ap-mso YouTubeTV --ap-username PRIV --ap-password PRIV -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['http://watchdisneyxd.go.com/atomic-puppet/video/vdka4074861/01/26-finale-a-finale-b', '--ap-mso', 'YouTubeTV', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '-v']
Usage: you [OPTIONS] URL [URL...]

you: error: Unsupported TV Provider, use --ap-list-mso to get a list of supported TV Providers
```

---

Would like to request support for YouTubeTV as an Adobe Pass MSO option. Running --ap-mso does not recognize YouTubeTV as an option that can be used. Going by the providers list https://sp.auth.adobe.com/adobe-services/config/ABC it should be able to use the service. If an account is needed, I do have an invite so access can be had.
Repository: kubernetes
Issue: Allow hot disabling of liveness probes
Labels: priority/backlog,sig/node,kind/feature

**Is this a BUG REPORT or FEATURE REQUEST?**:

/kind feature

**What happened**:

From time to time, liveness probes do not behave as expected by the person that configured them and some conditions external to the container may make them fail (e.g. dependency on a database) and provoke endless restart loops.
This makes it hard to debug those containers and/or get the system back to normal.

**What you expected to happen**:

I'd like to be able to disable a liveness probe on a existing pod without replacing it.
Ideally, this would apply to running containers, without waiting them to be restarted.

**How to reproduce it (as minimally and precisely as possible)**:


**Anything else we need to know?**:

This was suggested in the past (without the dynamic part):
> At some point we'll probably want to add an enable/disable boolean, since it's convenient to be able to disable liveness probes without losing the parameter settings, but that's less critical than the above.

cf. https://github.com/kubernetes/kubernetes/issues/12866#issue-101699336
Repository: go
Issue: net/mail: AddressList doesn't decode rfc2047 encoded words inside quotes
Labels: help wanted,NeedsInvestigation

net/mail `AddressList` doesn't decode rfc2047 encoded words if they are inside quotes.

The RFC mentions "An 'encoded-word' MUST NOT appear within a 'quoted-string'."

Now before you close this bug, saying it is working as intended,  let me try to convince you otherwise.

A lot of clients break the rule above, and most services/libraries are programmed to work around it.

For example **Gmail** will happily decode the string even if it is inside quotes.

The way I see it, there are two paths we can follow:

1. Stick to RFC
2. Try to be compatible with the majority of the libraries/services out there.

We can be strict and choose 1, in which case the library will not be of much use, since users of the software will complain.

Or we can be pragmatic and choose 2. There is not much risk in decoding Q encoded words inside quotes. 

I hope you choose (2).

Repro:

https://play.golang.org/p/etkJkTfs3Q


### What version of Go are you using (`go version`)?

1.9

### Does this issue reproduce with the latest release?

Yes

### What operating system and processor architecture are you using (`go env`)?

darwin/amd64

### What did you do?

https://play.golang.org/p/etkJkTfs3Q


### What did you expect to see?

Decoded name

### What did you see instead?

Undecoded name
Repository: kubernetes
Issue: umbrella issue for HA (replicated) API Server
Labels: sig/api-machinery,kind/feature,lifecycle/frozen

API Server relies on etcd for HA. But it also has internal objects/states that need to be initialized based on API objects in etcd. Example of that is CRDs that need a http handler. This issue is to keep track of all states we have in API server and make sure all of them are HA ready. Note that most of them are already HA.

- [ ] CRD http handler: Coordination required between API servers to mark a CRD as ready (#57042)
- [ ] Admission Webhooks: All API servers should became aware of webhooks before they mark as ready. Webhooks should be activated when all API servers are aware of them. (need an issue)
- [ ] Audit api server code for more issues

@kubernetes/sig-api-machinery-misc
Repository: go
Issue: proposal: cmd/vet: detect values assigned but not used
Labels: Proposal,NeedsInvestigation,FeatureRequest,Proposal-Hold,Analysis

Please answer these questions before submitting your issue. Thanks!


### What version of Go are you using (`go version`)?
go1.9 darwin/amd64

### Does this issue reproduce with the latest release?
yes

### What operating system and processor architecture are you using (`go env`)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"

on MacOS X Sierra

### What did you do?

I wrote this code below and then run go vet. err is never used or checked.
```
	defer resp.Body.Close()
	body, err := ioutil.ReadAll(resp.Body)

	return body, resp.StatusCode, nil
}
````


### What did you expect to see?
I expect that when I run $> go vet then I should see some error
notification that this err variable is not used or something.

### What did you see instead?
None.
Repository: TypeScript
Issue: Unhelpful `--strictFunctionTypes` error when first method is `self(): this;`
Labels: Suggestion,In Discussion,Domain: Error Messages

**TypeScript Version:**  2.7.0-dev.20171214

**Code**

```ts
declare class C<T> {
    self(): this;
    covariant(): T;
    contravariant: (t: T) => void;
    m(other: C<{}>): void;
}

new C<number>().m(new C<number>());
```

**Expected behavior:**

Error that `C<number>` isn't `C<{}>` because `C<{}>`'s `contravariant` can accept `(t: {})` but `C<number>` can only accept `(t: number)`.

**Actual behavior:**

```ts
src/a.ts(8,19): error TS2345: Argument of type 'C<number>' is not assignable to parameter of type 'C<{}>'.
  Types of property 'self' are incompatible.
    Type '() => C<number>' is not assignable to type '() => C<{}>'.
      Type 'C<number>' is not assignable to type 'C<{}>'.
```
Repository: vscode
Issue: [Feature] Local Workspace settings
Labels: feature-request,config

I would like to be able to configure settings that are specific to my user and to a particular workspace. So, 'local' workspace settings?

So there would be three locations for settings (for a single-folder workspace):

  * user settings
  * `${workspaceRoot}/.vscode/settings.json`
  * `${workspaceRoot}/.vscode/settings.local.json`

This way, I can add `.vscode/settings.json` to git, and share project settings such as "exclude node_modules" but I can gitignore `.vscode/settings.local.json` and add things specific to that project that I don't want to share, such as git autofetch.

I originally thought to suggest `.vscode/settings.user.json`, similar to how VS Pro handles similar configuration, but that might be confusing.
Repository: pytorch
Issue: Fused RNN refactor plan
Labels: module: cudnn,triaged

This ticket is to track our plan to refactor the fused RNN API (which makes use of the CuDNN implementation of RNNs).

**Why is this difficult?** There are a number of factors which make fused RNNs unusual, compared to most of the other differentiable operations in PyTorch

* It requires an unusually large, structured series of weights. Most differentiable operators have a fixed number of weights, but an RNN for an entire sequence must have weights for every layer of the RNN. To make matters worse, each layer needs not one but two tensors; the weight and the bias. No other operator in PyTorch behaves like this.

* CuDNN requires these weights and inputs to be packed in a particular way.  The required packing operations are frequently reported by users as an extremely confusing aspect of PyTorch.

* Not only do the weights vary depending on the type of RNN, so do the hidden tensors. If you are an LSTM, you have both hx and cx; for other RNNs, only hx is needed.

* RNN with dropout is a stateful API, which requires dropout descriptors to be passed between invocations to handle randomness.

**What do we want to do?** Here are the desired goals of the RNN refactor:

* Make CuDNN RNN available from ATen

**Design ideas.**

* The ATen API will take two tensors, `hx` and `cx`, with `cx` being undefined tensor for non-LSTM networks.

cc @csarofeen @ptrblck
Repository: go
Issue: doc: explain what custom pprof profiles are and why they are useful
Labels: Documentation,help wanted,NeedsFix

[Diagnostics](https://tip.golang.org/doc/diagnostics.html) page is briefly mentioning custom profiles but failing to give any introduction for those who doesn't know why custom profiles are useful. Explain custom profiles and share a few sample use cases.
Repository: vscode
Issue: Feature Request: Enable/disable extensions from config file
Labels: feature-request,extensions

- VSCode Version: 1.18.1
- OS Version: Windows 10 FU

### Explain: 

There are certain extensions that play well together, and it would be useful to be able to set a config file to enable and disable certain extensions in that workspace. This would be a config file, like the extensions recommendations, but with a series of parameters that would allow to enable and disable certain extensions. 

This would be like a config file for the "[Dis]Allow (Workspace)" setting.
Repository: pytorch
Issue: Feature Request: CPU performance optimization with MKL-DNN
Labels: triaged,module: mkldnn

Hi, our team works on DL frameworks performance optimization on CPU.
PyTorch CPU performance can be significantly improved with [MKL-DNN](https://github.com/01org/mkl-dnn), an open source deep neural network library on Intel CPU platform. Currently MKL-DNN supports Conv2d, Relu, BatchNorm, Pooling, Concat, etc. The CPU performance improvement will benefit cloud users as well as HPC researchers who have access to Xeon clusters.
Will PyTorch be interested in the part?




cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @VitalyFedyunin
Repository: go
Issue: x/tools/cmd/goimports: should not propose imports that are shadowed by vendored copies
Labels: Tools

When you format `import` sections, goimports help us out of kindness.
However, it mistakenly mix GOPATH-depended packages with packages under the `vendor` directory.

I expect it should exclude GOPATH-depended one from an `import` section. if I use any vendoring tool.

(It maybe the role of golint, so if you mind, cound you point out?)
Repository: opencv
Issue: cv::VideoCapture::set does not work when using GStreamer
Labels: bug,priority: low,category: videoio

##### System information (version)
- OpenCV => 3.3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015

##### Detailed description

The end of CvCapture_GStreamer::open contains this code:
```
            status_ = gst_element_query_position(pipeline, FORMAT, &value_);
            if (!status_ || value_ != 0 || duration < 0)
            {
                CV_WARN(cv::format("Cannot query video position: status=%d value=%lld duration=%lld\n",
                        (int)status_, (long long int)value_, (long long int)duration).c_str());
                isPosFramesSupported = false;
                isPosFramesEmulated = true;
                emulatedFrameNumber = 0;
            }
            else
                isPosFramesSupported = true;
```
According to [GStreamer reference manual](https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstElement.html#gst-element-query-position), _"this query will usually only work once the pipeline is prerolled (i.e. reached PAUSED or PLAYING state)."_

So based on the documentation, OpenCV's check, if querying the video position is possible, will usually fail, as it is done too early: immediately after opening the video, when the the pipeline is not yet prerolled. In my tests, it always failed, which makes isPosFramesEmulated = true. If later we want to set the video frame index via
`cv::VideoCapture::set(cv::CAP_PROP_POS_FRAMES, frameNumber)`
this call has no effect, because CvCapture_GStreamer::setProperty does not do anything if isPosFramesEmulated==true.

I tried the same using GStreamer directly. With the same videos, gst_element_query_position works without any problems as soon as the video is playing. Unfortunately, because of the flag isPosFramesEmulated OpenCV prevents to set the video frame index at any later time, though it would be perfectly possible.

##### Steps to reproduce

In tutorial project bg_sub, in function processVideo before code line
`        ss << capture.get(CAP_PROP_POS_FRAMES);`
add a line
`capture.set(CAP_PROP_POS_FRAMES,1000);`
Set a breakpoint there and start debugging (passing "-vid testvideo.mpg" at command line). You will see that the subsequent get will return 1, which is not what we expect (it is `CvCapture_GStreamer::emulatedFrameNumber`). As explained above, this is caused by the OpenCV's open method that makes isPosFramesEmulated = true. During open, this is written to stdout:

```
(cpp-tutorial-bg_sub.exe:13676): GStreamer-CRITICAL **: gst_query_set_position: assertion 'format == g_value_get_enum (gst_structure_id_get_value (s, GST_QUARK (FORMAT)))' failed
warning: Cannot query video position: status=1 value=-1 duration=18795
 (C:\opencv\modules\videoio\src\cap_gstreamer.cpp:949)
```

The first warning message is from GStreamer (GST_DEBUG=4), the second the subsequent message from OpenCV (see line 948 of [cap_gstreamer.cpp](https://github.com/opencv/opencv/blob/3.3.1/modules/videoio/src/cap_gstreamer.cpp)).
Repository: opencv
Issue: very slow kdtree
Labels: category: flann

I used `cv::flann::Index` with `cv::flann::KDTreeIndexParams()` and call `knnSearch` for every single point used to build the tree inside a parallel loop. The performance gets extremely slow as the number of points and CPU cores grows. I did a performance profiling, and it seems that all time is spent in calling kernel to allocate and free memory. The culprit seems to be [this](https://github.com/opencv/opencv/blob/6fe1898ab6d2a8a81ff2026e381b692cffe00266/modules/flann/include/opencv2/flann/kdtree_index.h#L448) that is called for every single point several times. It allocates an array of the entire data size, if that can not be avoided, at least should be done once and reused for every point.
Repository: flutter
Issue: Be able to create a new project with prepoluated class names instead of boilerplate project names (MyApp, MyHomePage)
Labels: c: new feature,tool,P2,team-tool,triaged-tool

This is just a feature request.

Using `flutter create myapp` and `File -> New Flutter Project...` in Android Studio/IntelliJ both result in the sample code for MyApp (the increment counter app) being created. Could we please have a way to:

 * instantiate a blank project?
 * or instantiate something without so much code already written (e.g. see below)?
 * or something that can customize the name of the app (i.e. if I named my Flutter Application hello_world, MyApp would be called HelloWorld?

Something like:
```dart
import 'package:flutter/material.dart';

void main() => runApp(new HelloWorld());

class HelloWorld extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return new Container();
  }
}
```

Reasoning:
 * As a regular developer, the stuff in the sample app may not be relevant (classes would be in different files, comments would be removed). There's a bit of a mental overhead to renaming the classes. Chances are, you'd just delete all the code and start from scratch, so it would be great to have this option when creating a new project.
 * As a very new developer, one might be more interested in the just StatelessWidgets first (e.g. just how to do visual layouts), and worry about StatefulWidgets (the logic to the app) later.