sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: x/net/nettest: extend TestConn with optional interface checks
Labels: Proposal,Proposal-Accepted

EDIT: we'll proceed with Option 1.

---

For the same project as discussed in #30984, I'm using `nettest.TestConn` to test a custom `net.Conn` implementation.

Now that I've got the basics covered, I realize it'd be useful to be able to extend the tests to make sure that my `CloseRead`/`CloseWrite` methods that are not a mandatory part of `net.Conn` could also be tested on my type.

I see two options here:

1) Allow `TestConn` to perform a couple of type assertion tests to see if methods such as `CloseRead` and `CloseWrite` are implemented on the `net.Conn` type, and then run additional tests if so.

This has the advantage that anyone who consumes this package and passes a `net.Conn` with these methods will have these tests run. `net.TCPConn`, `net.UnixConn`, and my custom `vsock.Conn` type (as an example) would run these added tests, but `net.UDPConn` would not.

Perhaps it'd also make a sense to have an optional test for `SyscallConn` as well, since it is widely implemented.

2) Export `timeoutWrapper` and `connTester` in some form, to enable callers to create their own local tests in a `nettest.TestConn`-style.

This could be nice to keep the amount of code in this package smaller, but it'd also mean that certain tests such as the `CloseRead`/`CloseWrite` would need to be duplicated between different projects.

With this said, I think option 1 is preferable in order to reduce duplication in the community, but I can understand why one wouldn't want to add additional complexity to this package to test methods that are not a required part of `net.Conn`.

/cc @dsnet @mikioh @acln0
Repository: flutter
Issue: Support better scaling of Android platform views
Labels: platform-android,framework,a: platform-views,c: proposal,P2,team-android,triaged-android

Right now when a scale transform is applied to an AndroidView the texture is drawn scaled without scaling the virtual display and the internal view.

This can be improved by sending the scale factors to the PlatformViewsController and calling [setScaleX](https://developer.android.com/reference/android/view/View.html#setScaleX(float)) and [setScaleY]( https://developer.android.com/reference/android/view/View.html#setScaleY(float)) on the embedded view.

There will still be timing issues when the scale is changes at runtime after the view is visible, but for cases where the scale is always the same this should be a net improvement.
Repository: vue
Issue: TypeScript: Vue types $attrs should be type Record<string, any>
Labels: typescript

### Version
2.6.10

### What is expected?
`Vue.prototype.$attrs` should be type `Record<string, any>` and not `Record<string, string>`.

Since `2.4.0`, `vm.$attrs` has contained extracted bindings not recognized as props. The type of these values is unknown.

### Steps to reproduce
Take the following component:
```javascript
new Vue({
  data: function () {
    return {
      count: 0
    }
  },
  mounted() {
    let someFunc = this.$attrs.someBoundAttr as Function
    // Type 'string' cannot be converted to type 'Function'
  },
  template: `
    <button v-on:click="count++" :someBoundAttr="() => count">
      You clicked me {{ count }} times.
    </button>`
})
```

Notice the error in TypeScript checking:
```
Type 'string' cannot be converted to type 'Function'
```

### What is actually happening?
...


### Reproduction link
[http://www.typescriptlang.org/play/](http://www.typescriptlang.org/play/)


<!-- generated by vue-issues. DO NOT REMOVE -->
Repository: go
Issue: x/net/nettest: add TestListener API
Labels: Proposal,Proposal-Accepted

I'm currently implementing my own `net.Listener` (see also #30984 and #31033), https://godoc.org/github.com/mdlayher/vsock#Listener, and would like to ensure it is in full compliance with the `net.Listener` contract; that is:

- Accept blocks until a connection is receive, or it is interrupted
- Close terminates the listener, but can also unblock Accept
- Maybe: test for SetDeadline method (which is common for `net.Listener`, see #6892) and verify that an expired deadline unblocks Accept as well (this idea is in line with what I propose with #31033)

I've played around with this a bit locally to try to see what makes sense, and I will send a draft CL with my proposed API and a single test. The basic idea is to mirror what `TestConn` is doing, and perhaps the two can share a fair bit of internal code.

/cc @dsnet @mikioh @acln0
Repository: TypeScript
Issue: Enum redeclared as var inside block scope
Labels: Bug

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the *entire* template below.
-->

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  TS Playground as of 2019-03-25

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** enum declarations can only merge, enum block scope, enum redeclaration

**Code**

```ts
{ enum Foo { } var Foo }

enum Bar { } var Bar;
```

**Expected behavior:**
They should both error, or they should be both accepted

**Actual behavior:**
Only `Bar` is an error

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://www.typescriptlang.org/play/index.html#src=%7B%20enum%20Foo%20%7B%20%7D%20var%20Foo%20%7D%0A%0Aenum%20Bar%20%7B%20%7D%20var%20Bar%3B%0A%0A(function%20()%20%7B%20enum%20Baz%20%7B%20%7D%20var%20Baz%20%7D)

**Related Issues:** <!-- Did you find other bugs that looked similar? -->
Found while fixing https://github.com/babel/babel/issues/9763
Repository: vscode
Issue: [json] Provide support for highlighting the source of the error in json files rather than highlighting the entire file
Labels: feature-request,json

In VSCode, I have a RunConfigurationSchema.json file and a runconfig.json file open. When I edit my runconfig.json file and I make an invalid change to a parameter (as seen for the 'framework' parameter in the picture attached); all the lines in the json file are highlighted and underlined with green squiggly lines. It is difficult to decipher where the actual error is stemming from unless the user hovers specifically over the parameter containing the error. Can we instead highlight the line that contains the error only?   

![jsonschema](https://user-images.githubusercontent.com/43390034/54957622-7b681300-4f10-11e9-9013-8da260c9eea3.jpg)
Repository: rust
Issue: Add guidance when unused_imports fires on an item only used in cfg(test)
Labels: C-enhancement,A-lints,T-compiler,A-libtest,A-suggestion-diagnostics,D-confusing,D-newcomer-roadblock

This is a very common source of confusion for new Rust users: They import a module for use in tests, then get an "unused import" warning when building a non-test target. Meanwhile, removing the import breaks their tests. [See here](https://users.rust-lang.org/t/seemingly-invalid-unused-import-warning/21465) for an example.

I think it would be tremendously helpful to people learning the language to provide a hint if the item is actually used in `cfg(test)`. I'm not sure how difficult this would be to implement, however.
Repository: godot
Issue: [3.x] Autocomplete of vars fails unless directly below and also if line previously had error
Labels: bug,topic:gdscript,topic:editor

**Godot version:**
3.1 64-bit


**OS/device including version:**
Windows 10


**Issue description:**
Autocomplete does not work

**Steps to reproduce:**
Hello,
New user here. Two autocomplete bugs that I encountered on using Godot for the first time, hampering my ability to learn and use the editor/language properly...

Autocomplete not working for instances
1. Using latest 64-bit Windows 3.1 version standard edition download the 2D Kinematic demo (or simply use the code below)
2. In the script, move the cursor to directly below line 11 where 'motion' variable is defined as Vector2D
3. Type motion. and auto complete will present the correct list, e.g. find 'normalized()'
4. Move cursor to bottom of script and repeat item 3. All you see are generic 'object' constants and methods and specific methods, e.g. 'normalized()' is not available

I saw a bug report for this from a while ago and said it was fixed, clearly not quite. This bug means you simply cannot use autocomplete and scripting (for new users) is trial and error.

Autocomplete fails to run at all after a fault is found, even after fault is cleared:
1. Using the sample script place the cursor anywhere below the 'var motion=Vector2D()' line
2. Type 'motion. ' then press enter. You will get an error message saying 'expected identifier' and the line turns brown.
3. Go back to this line and remove the '.' then press '.' again and no autocomplete is shown
4. Delete all the text to the start of the line and repeat 'motion.' and still autocomplete is not shown
5. Delete all the line, then delete again to remove the line, and the error disappears and you can type again

i.e. once an error is found, even after you start editing the error, it never goes away and features such as autocomplete continue. 

I have also found sometimes that even after removing a line, and retyping, autocomplete doesn't even give you any hints, you have to remove the line a couple of times and then eventually it works!

Sample code for player.gd is as below:


**Minimal reproduction project:**
```gdscript
extends KinematicBody2D

# This is a demo showing how KinematicBody2D
# move_and_slide works.

# Member variables
const MOTION_SPEED = 160 # Pixels/second


func _physics_process(delta):
	var motion = Vector2()
	
	if Input.is_action_pressed("move_up"):
		motion += Vector2(0, -1)
	if Input.is_action_pressed("move_bottom"):
		motion += Vector2(0, 1)
	if Input.is_action_pressed("move_left"):
		motion += Vector2(-1, 0)
	if Input.is_action_pressed("move_right"):
		motion += Vector2(1, 0)
	
	motion = motion.normalized() * MOTION_SPEED
	

	move_and_slide(motion)
```
Repository: go
Issue: x/review: use alternative remote repository
Labels: NeedsInvestigation

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.12.1 linux/amd64
</pre>

### Does this issue reproduce with the latest release?
yes


### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/user/go"
GOPROXY=""
GORACE=""
GOROOT="/home/user/.local/share/umake/go/go-lang"
GOTMPDIR=""
GOTOOLDIR="/home/user/.local/share/umake/go/go-lang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/user/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build019412724=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### What did you do?
```bash
git codereview mail
```


### What did you expect to see?
```
remote: Processing changes: refs: 1, new: 1, done    
remote: 
remote: SUCCESS
remote: 
remote:   https://go-review.googlesource.com/c/gddo/+/123456 pkg: commit message [NEW]
remote: 
```


### What did you see instead?
```
```

In #9266, this high level issue was identified: `git-codereview` only references the `origin` remote when [pushing changes](https://github.com/golang/review/blob/master/git-codereview/mail.go#L138). While this behavior is probably nice in preventing unnecessary configuration via `git branch --set-upstream-to=`, but it makes having an `origin` that does not point to `go.googlesource.com` impossible. Would it be possible to read the `remote` out of the gitconfig or allow overriding via flags?
Repository: go
Issue: cmd/compile: pack structs containing anonymous fields more tightly
Labels: Performance,NeedsInvestigation,compiler/runtime

I attempted to refactor some common fields (E) out of a struct (T1), yielding (T2). Unfortunately, this changed the packing of the fields, which makes this refactoring infeasible in this case.

```go
type E struct {
	X int
	B uint8
}

type T1 struct {
	X int
	B uint8
	C uint8
}

type T2 struct {
	E
	C uint8
}
```

Observe the Offset of C in this code: https://play.golang.com/p/ac5CCIWIlZS

On a first pass, I don't see anything in the spec that forbids T1 and T2 being laid out identically in memory.
Repository: godot
Issue: [Bullet] Convex Collision Sibling wrong margin with Bullet
Labels: bug,discussion,confirmed,documentation,topic:physics

**Godot version:**
3.1

**OS/device including version:**
Windows 10 x64 / NVIDIA GeForce GTX 1060 6GB / Intel Core i7 4790K


**Issue description:**
When a CollisionShape is created from a mesh using "**Create Convex Collision Sibling**", it's being it is getting away from the bottom cube by the "collision margin" distance (0.04):

![image](https://user-images.githubusercontent.com/11199752/54968027-f274ca00-4f57-11e9-8d83-82547001a56b.png)

This only happens with **ConvexPolygonShape**. 

With **ConcavePolygonShape** or even a BoxShape or other native collision shapes, **this does not occur**.

![image](https://user-images.githubusercontent.com/11199752/54968171-7929a700-4f58-11e9-8625-aaefd92e3f25.png)




**Steps to reproduce:**
1) Run the attached project. It's with a CollisionShape as **ConvexPolygonShape** and you'll see the margin.
2) Change the red cube CollisionShape to BoxShape or generate a ConcavePolygonShape and the margin is not there.

**Minimal reproduction project:**
[testes.zip](https://github.com/godotengine/godot/files/3006314/testes.zip)
Repository: flutter
Issue: Make SnackBarAction's check for Scaffold nullOk
Labels: framework,f: material design,c: proposal,P3,team-design,triaged-design

Currently its not possible to use a SnackBar with a SnackBarAction somewhere other than a Scaffold (like a persistent, global SnackBar) because of the SnackBarAction's attempt to hide the SnackBar through the Scaffold.

It seems all that would have to be changed is _handlePressed in _SnackBarActionState changing the last line:
```dart
Scaffold.of(context).hideCurrentSnackBar(reason: SnackBarClosedReason.action);
```
to
```dart
Scaffold.of(context, nullOk: true)?.hideCurrentSnackBar(reason: SnackBarClosedReason.action);
```
Repository: godot
Issue: RayShape2D Collides with the bottom of one way collision tiles
Labels: bug,confirmed,topic:physics

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
<!-- Specify commit hash if non-official. -->
v3.1.stable.official (Steam)


**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
macOS Mojave 10.14.3 


**Issue description:**
<!-- What happened, and what was expected. -->
If you use RayShape2D with one way collision tiles, it collides with the bottom them.

**Steps to reproduce:**

Create a KinematicBody2D with a RayShape2D:
![Godot 3.1 doc](https://godotengine.org/storage/app/uploads/public/5b4/de1/39c/5b4de139c8635728849121.png)

Create a tilemap with one way collision tiles:
![Tilemap](https://user-images.githubusercontent.com/423381/54973590-4dfe8200-4f6f-11e9-9728-cecad2495b30.png)
![Screen Shot 2019-03-26 at 02 30 57](https://user-images.githubusercontent.com/423381/54973625-6c647d80-4f6f-11e9-8b98-7324e48e72d6.png)

Create a basic jump logic, and then when you jump you will collide with the bottom of the tiles:
![Screen Shot 2019-03-26 at 02 31 11](https://user-images.githubusercontent.com/423381/54973670-9ddd4900-4f6f-11e9-93b4-50759a26e0d1.png)

**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
[rayshape2d_bug.zip](https://github.com/godotengine/godot/files/3006660/rayshape2d_bug.zip)
Repository: vscode
Issue: Debug: Server ready action pattern should have validation
Labels: bug,feature-request,debug

Testing #71074

When I input an invalid regex in the `serverReadyAction.pattern` field, there is no JSON validation or warning on debug start:

![image](https://user-images.githubusercontent.com/22350/54987746-67c2b800-4fb5-11e9-9382-23625ff3cd8e.png)
Repository: angular
Issue: ReactiveForms: FormGroup.removeControl doesn't call control.setParent(null)
Labels: area: forms,P4

# 🐞 bug report

### Affected Package

`@angular/forms`

### Is this a regression?

Most probably no.

### Description

The `FormGroup` class' `removeControl` method does not call `setParent(null)` for the target control. This appears to be an inconsistency in the implementation.

Our expectation is that `removeControl` would call `control.setParent(null)`, to clear the control's parent once detached. This would also make it symmetric with `addControl`.

#### Use case

We have a dynamic form implementation where a class extending `FormGroup` is dynamically attaching/detaching child groups/controls using `addControl`/`removeControl`. The controls can react to their inclusion/exclusion in their `setParent` method (to e.g. subscribe to a parent's `attachedState` observable).

Since we're extending `FormGroup` this is easy to work around by just overriding `removeControl`, but IMHO the inconsistency in the framework should be fixed.

## 🔬 Minimal Reproduction

The call is missing from: https://github.com/angular/angular/blob/master/packages/forms/src/model.ts#L1298 .

## 🔥 Exception or Error

None.

## 🌍  Your Environment

**Angular Version: 7.2.0**
<pre><code>
Angular CLI: 7.3.0
Node: 10.15.3
OS: win32 x64
</code></pre>

**Anything else relevant?**

No.
Repository: flutter
Issue: [tool]Provide better feedback when "Initializing Gradle" 
Labels: tool,t: gradle,a: quality,c: proposal,P3,team-tool,triaged-tool

Take a look at #26077, #25808 and especially #15106, all of which are about the "Initializing Gradle" step taking forever, and all of which have been closed with no changes, despite tons of people having (apparently) the same problem.

There seem to be a number of issues - it downloads 400MB of Gradle (wtf), I get this error: `java.lang.RuntimeException: Timeout of 120000 reached waiting for exclusive access to file: ~/wrapper/dists/gradle-4.10.2-all/9fahxiiecdb76a5g3aw9oi8rv/gradle-4.10.2-all.zip`, and so on.

Clearly this step is not robust enough to have "Initializing Gradle" as the only feedback. It should show more steps - "Downloading Gradle", "Unzipping Gradle", etc.

Btw I am talking about the VSCode extension, and the `flutter run` command line. I suspect it may output more information in Android Studio.
Repository: rust
Issue: compiletest: emit time spent for each test suite
Labels: A-testsuite,C-enhancement,T-bootstrap,E-medium,A-compiletest

Right now we have test suites with thousands of files each. It would be useful for compiletest to indicate how long it takes when it runs each such suite, so that someone reviewing where time is going during testing can know where the bulk of time overall is being spent without having to stare at the output holding a stopwatch.
Repository: create-react-app
Issue: Defer loading of code-split CSS
Labels: issue: needs investigation

I have used code splitting to split my CRA code which is working great. However, I want to be able to delay the loading of certain CSS files. For example, I lazy load my page's footer using reat-lazyload (which loads the component as you scroll down the page) but the CSS is always loaded in on the load of the page by CRA. Is there a way to delay the loading of certain CSS chunks with CRA to remove unnecessary download bandwidth during the critical page load?
Repository: kubernetes
Issue: Separate cacher is created for each version of a resource
Labels: kind/bug,sig/scalability,sig/api-machinery,priority/important-longterm,lifecycle/frozen

This is forked from https://github.com/kubernetes/kubernetes/issues/51825 which was closed without fixing this particular issue.

Currently a separate cacher is created for every version of an API.
That may introduce a significant overhead for both memory (every object is kept in memory) as well as CPU (each cacher is watching separately all changes).

The reason for that is that we're creating registry for each version completely independently from each other.

One example (out of many)
https://github.com/kubernetes/kubernetes/blob/master/pkg/registry/apps/rest/storage_apps.go#L60
We create storage for every version (v1beta1, v1beta2, v1) independently, that internally is calling storage decorator:
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store.go#L1289
and that results in a separate cacher for every single version.

We should finally fix that.

@kubernetes/sig-api-machinery-bugs @kubernetes/sig-scalability-bugs @smarterclayton 

@resouer - can be something that your team may want to look into
Repository: vscode
Issue: No clue that server ready action is running
Labels: feature-request,debug

re https://github.com/Microsoft/vscode/issues/71074

* have a slow vm
* configure service action to open external app
* have firefox as default browser (which likely is slow starting or installing updates on start)
* start debugging
* nothing happens... firefox isn't showing UI, the debug output doesn't hint towards anything

I would expect that the debug output/terminal shows a message like "detected localhost:3000, starting default browser..."
Repository: pytorch
Issue: [CPP] Allow binding config structs into the Python front end
Labels: oncall: jit,module: cpp

## 🚀 Feature
Allow binding config structs into the Python front end.

Like

```

struct config
{
  int x_min, x_max, y_min, y_max;
}
torch::jit::RegisterStruct("config::config", &config)

```
## Motivation

Right now, I have to pass configs into the custom ops by arguments. Which gets really hairy in practice like
```
torch::Tensor my_kernel(torch::Tensor my_actual_tensor, int x_min, int x_max, int y_min, int y_max, int z_min, int z_max, ...other a ton of configs...)
```

Instead, it would be much nicer if it could be:

```
torch::Tensor my_kernel(torch::Tensor my_actual_tensor, config &config)
```


cc @yf225 @glaringlee
Repository: scrcpy
Issue: kudos and compliments!
Labels: wontfix

I just wanted to compliment you on this excellent effort. This is an unbelievably stable and useful project. I couldn't find any other way to compliment this project on github so I thought that amoung the sea of issues and feature requests, that I would drop one that's just a compliment. You can close/delete or do whatever should be done to this issue :-)