sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: vscode
Issue: Builtin support for reading files from their zip archives
Labels: feature-request,file-explorer

Rel: #17271

Note: This is now possible (although non-builtin) using the [ZipFS extension](https://marketplace.visualstudio.com/items?itemName=arcanis.vscode-zipfs#:~:text=This%20extension%20adds%20support%20into,edit%20files%20from%20your%20cache.)

## High-level

It would be useful for VSCode to be able to read files even when they're stored within zip archives. Opening `/foo/bar.zip/package.json` would succeed. Read-only is likely fine, at least for a first iteration.

## Motivation

- This feature isn't unheard of. Both vim and [emacs](https://www.gnu.org/software/emacs/manual/html_node/emacs/File-Archives.html) support reading files from zip archives (they even go a bit farther by allowing to also edit them, but we might not want to have to deal with the UI complexity for now).

- Package managers are experimenting with virtual install folders. Being able to read third-party files from the archives that contain them will be important to provide a good developer experience (particularly for the "ctrl+click on a symbol to go to its definition" workflow). Zip will be used by Yarn because of its good random access properties.

## Suggested Implementation

- The Yarn project ships a [wasm build](https://github.com/yarnpkg/berry/tree/master/packages/berry-libzip) of the libzip as an external package. This would make it easy to use a battle-tested zip library at little cost.

- The size cost would be around ~300KB for the Zip implementation (which could be reused for other purposes - there's a bunch of things that could use Zip support down the road).

- You might actually already have a library able to do that?

## Why not an extension

- I've started working on an extension to help with that ([vscode-zipfs](https://github.com/yarnpkg/berry/tree/master/packages/vscode-zipfs)), but it cannot be integrated as well as I'd like. In particular, it doesn't work with the ctrl+click workflow I mentionned, and running `code /foo/bar.zip/package.json` cannot open the right file. I believe a builtin integration could provide a seamless integration, which would be beneficial to the users.
Repository: create-react-app
Issue: Feedback wanted: New Hot Reloading
Labels: issue: announcement

I’m working on hot reloading again. Got a very raw alpha version working. It preserves state but only for function components. Works with Hooks.

You can try the alpha version (**not production ready, super experimental**):

### Trying in a New Project (NOT FOR PRODUCTION)

```
npx create-react-app demo --scripts-version wonky-scripts
```

### Trying in an Existing Project (NOT FOR PRODUCTION)

1. Replace `react-scripts` dependency with `wonky-scripts@0.0.5`
2. Keep `scripts` the same
3. Delete `node_modules/.cache`
4. Run Yarn/npm
5. Start the project and try editing your React components 

### What It Looks Like

It’s expected that it will work something like on this gif: https://twitter.com/dan_abramov/status/1139876172903395329

### Constraints (Library Authors, Read This!)

If your Hook or Component doesn't work with hot reload, keep in mind that:

* `useMemo` and `useCallback` caches are dropped on every edit (otherwise there wouldn't be a way to edit them 😅). If this breaks your code, consider `useRef` which gives you a semantics guarantee about not getting re-created. Like [here](https://github.com/alexreardon/use-memo-one). Usually there's a way to restructure the code to be more resilient.
* Same goes for `useEffect`. During hot reload, dependency array will be ignored, and even effects with `[]` dependencies will re-run. If this breaks your component or Hook, there's likely a way to restructure it to fix this. As a bonus, this will make it easier for you to later add more dependencies to it if needed.
* However, state and refs get preserved between edits. (As an escape hatch for quickly editing mounting animations and similar, note that users can add `// @hot reset` to the file they're editing, and this will force state reset. This is not a final syntax but we'll document some way to do it.)

If you need help getting your library working, please post in this thread.

### Known issues

- [ ] Hot reload gets stuck if you save a file without changing it
- [ ] Editing a file that declares Context doesn't preserve state, currently you need to move Context definition to another module and import it
- [ ] Errors after hot reload don't always get reported (e.g. try importing a non-existent component and then adding a file without exports)
- [ ] Lint warnings are confusingly duplicated on save
- [ ] Some libraries don't work with it (**please post which ones in this thread**)

### Please Share Feedback!

In this thread I’d love to hear first feedback from the brave folks who are willing to try this version on their projects. (Remember: it’s NOT usable in production, it’s just an experiment. This is why it has a funny name.)

Does it work for you? Can you make a gif of how it feels in your app, assuming it’s not a secret?

Thanks!
Repository: terminal
Issue: Feature Request: Dedicated serial port connection settings
Labels: Issue-Feature,Help Wanted,Area-Extensibility,Product-Terminal

# Summary of the new feature/enhancement
It would be awesome if you could add tabs like ssh connection, Telnet connection and Serial port connection.

For example 
![image](https://user-images.githubusercontent.com/37312505/59552653-799f7000-8f92-11e9-83f9-a67ae6591321.png)
This is the list now on my PC, Imagine 3 new tabs with there 3 new options

Moreover, if you decide to implement the previous request, see if its easy to "remember" past connections, or better to save them with name, to show as tabs with the predefined connection details(of ssh and telnet)

EDIT___

There is a way to make this happen though, but its not solid and easy to implement. You can install openSSH from optional features, and then add a new profile 
![image](https://user-images.githubusercontent.com/37312505/59557647-8d28f600-8fe7-11e9-97c3-65329c5a3b19.png)
![image](https://user-images.githubusercontent.com/37312505/59562346-1b2ace00-9034-11e9-8bdf-fc3895bb94e8.png)

It works... I leave this feature request open in order for you to decide if you want to implement it without the need to add new profile, or add it as a How-To guide if you think that's the best way to do this.
Repository: TypeScript
Issue: Codefix: convert `Type[]` to `readonly Type[]`
Labels: Suggestion,Awaiting More Feedback

## Search Terms

codefix readonlyarray readonly array immutable

## Suggestion

It'd be nice to have a codefix for converting non-readonly arrays to readonly. 

## Use Cases

When converting/refactoring code to be more immutable/`readonly`-friendly, it's a bit of a pain to manually add these annotations.

## Examples

Given this:

```ts
function takesArrays(items: /*| |*/string[], moreItems: /*| |*/string[]) { /* ... */ }
```

...having a codefix to make one or all parameters `readonly` would be useful:

```ts
function takesArrays(items: readonly string[], moreItems: readonly string[]) { /* ... */ }
```


## Checklist

My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Repository: pytorch
Issue: How about add torch::end for slicing in c++ frontend
Labels: module: internals,feature,triaged

## 🚀 Feature
Add static const variable that means end of the tensor.

## Motivation
Reference slice function's definition
https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/core/Tensor.h#L527

In c++ slicing the whole tensor with step 2

```
tensor.slice(/*dim=*/0, /*start=*/0, /*end=*/9223372036854775807, /*step=*/2);
```

If torch::end exists and is set 9223372036854775807.

```
tensor.slice(/*dim=*/0, /*start=*/0, /*end=*/torch::end, /*step=*/2);
```
## Pitch

Improve readability and keep clear intention.
Repository: flutter
Issue: Accessing AsyncSnapshot.data should throw if there's an error
Labels: framework,c: API break,dependency: dart,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-framework,triaged-framework

### Steps to reproduce

Run the following app:

```dart
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  Stream<int> get stream async* {
    throw StateError('error');
  }

  @override
  Widget build(BuildContext context) {
    return Directionality(
      textDirection: TextDirection.ltr,
      child: StreamBuilder<int>(
        stream: stream,
        builder: (BuildContext context, AsyncSnapshot<int> snapshot) {
          return Text('${snapshot.data}');
        },
      ),
    );
  }
}
```

### Expected behavior

You expect the `StateError` to show up in the console logs.

### Actual behavior

The exception is swallowed.
Repository: rust
Issue: Missing diagnostic for non-sized type of `ptr::null_mut`
Labels: A-diagnostics,T-compiler,C-bug

I tried this code:
```rust
trait Trait {}

// Make sure casts between thin-pointer <-> fat pointer obey RFC401
fn main() {
    let a: *mut (dyn Trait + 'static) = 0 as *mut _; //~ ERROR casting
    let x: *mut (dyn Trait + 'static) = std::ptr::null_mut();
}
```

When I ran this on rustc 1.32.0, I got this error message:
```rust
error[E0277]: the size for values of type `(dyn Trait + 'static)` cannot be known at compilation time
 --> src/lib.rs:6:41
  |
6 |     let x: *mut (dyn Trait + 'static) = std::ptr::null_mut();
  |                                         ^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
  |
  = help: the trait `std::marker::Sized` is not implemented for `(dyn Trait + 'static)`
  = note: to learn more, visit <https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
  = note: required by `std::ptr::null_mut`

error[E0606]: casting `usize` as `*mut (dyn Trait + 'static)` is invalid
 --> src/lib.rs:5:41
  |
5 |     let a: *mut (dyn Trait + 'static) = 0 as *mut _; //~ ERROR casting
  |                                         ^^^^^^^^^^^

error: aborting due to 2 previous errors

Some errors occurred: E0277, E0606.
For more information about an error, try `rustc --explain E0277`.
```

But when I ran this on rustc nightly, I got this error message:
```rust
error[E0606]: casting `usize` as `*mut (dyn Trait + 'static)` is invalid
 --> src/lib.rs:5:41
  |
5 |     let a: *mut (dyn Trait + 'static) = 0 as *mut _; //~ ERROR casting
  |                                         ^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0606`.
```

## Meta

```
% rustc +1.32.0 -Vv 
rustc 1.32.0 (9fda7c223 2019-01-16)
binary: rustc
commit-hash: 9fda7c2237db910e41d6a712e9a2139b352e558b
commit-date: 2019-01-16
host: x86_64-unknown-linux-gnu
release: 1.32.0
LLVM version: 8.0
```

```
% rustc +nightly -Vv
rustc 1.37.0-nightly (0e4a56b4b 2019-06-13)
binary: rustc
commit-hash: 0e4a56b4b04ea98bb16caada30cb2418dd06e250
commit-date: 2019-06-13
host: x86_64-unknown-linux-gnu
release: 1.37.0-nightly
LLVM version: 8.0
```
Repository: godot
Issue: RichTextLabel + tag [table] = all bags
Labels: bug,topic:gui

**Godot version: 3.1.1**
**All OS**

![001](https://user-images.githubusercontent.com/11189223/59556667-edf80480-8fce-11e9-9b8f-5fe7c4072edc.png)


In the RichTextLabel component, everything that is between the tags: {table} and {/table} - this is one big bug! What works outside of tags {table} and {/table}, inside tags does not work! 

1. Determining column width does not work correctly. The right edge is uneven. Sometimes letters climb under the scrolbar.
2. The definition of the table length does not work correctly. The vertical scrolbar reaches its lowest point when a few more paragraphs of text remain below.
3. Sometimes when scrolling down, the text simply disappears (completely)!
4. A single carriage return indent above a few lines.
5. Tag: {fill} in the table is processed incorrectly. Compound irregularity of the right paragraph margin.


[Demo.zip](https://github.com/godotengine/godot/files/3293565/Demo.zip)
Repository: opencv
Issue: Implement MoltenVK (enables Vulkan support for Mac OS/iOS)
Labels: feature,priority: low,platform: ios/osx,effort: ∞

##### Detailed description
As Apple already deprecated OpenCL, the only way to use GPU acceleration in the future is either through the Intel OpenVINO (what only supports Intel GPU's) or through Vulkan with help of [MultenVK](https://github.com/KhronosGroup/MoltenVK).

MultenVK can automatically and transparently convert SPIR-V shaders to MSL at runtime with the help of the Runtime Shader Conversion.

[The installation and usage is quite straight forward](https://github.com/KhronosGroup/MoltenVK/blob/master/Docs/MoltenVK_Runtime_UserGuide.md#install)

OpenCV DNN will be the only framework next to Apple's own CoreML framework that can utilize Metal GPU acceleration, while OpenCV will also be compatible with other platforms!

As Vulkan support is still only experimental, I will try to implement MoltenVK and see if things work, if it does it will incentivize people to contribute to Vulkan support as it will also replace OpenCL on Mac.

There are only a [few limitations ](https://github.com/KhronosGroup/MoltenVK/blob/master/Docs/MoltenVK_Runtime_UserGuide.md#known-moltenvk-limitations) with MoltenVK so it should be able to work.
Repository: TypeScript
Issue: Module.exports = {} not recognized by IntelliSense
Labels: Suggestion,Awaiting More Feedback

TypeScript version: 3.5.1

The CommonJS construct `module.exports = {}` does not provide import suggestions in JS files via VSCode IntelliSense. 

IntelliSense provides a *TS error* handle on the `module.exports = {}` construct:

> File is a CommonJS module; it may be converted to an ES6 module.ts(80001)

Pressing the **Quick Fix** option converts the exports to ES6 format. After this, IntelliSense import suggestions work in other scripts.

What also works is formatting the export as follows:

```lang-js
module.exports.showText = showtext;
```

My files are:

**lib.js**

```lang-js
function showText() {
  console.log('Text');
}

module.exports = {
  showText: showText,
}
```

**myCode.js**
```lang-js
showTe...;  // <- no import suggestion provided
```
Project structure:
```
./lib.js
./myCode.js
```
I would like to get the IntelliSense import suggestion without change of the `module.exports = {}` construct (I do not have the authorization to do this for the entire project code base).

I am not using a jsconfig.json file.
Repository: godot
Issue: Editor falls back to GLES2 if GLES3 is not supported, and it's confusing that the dropdown shows "GLES2" when the configured render is still "GLES3" in settings
Labels: enhancement,topic:editor,confirmed,usability

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
3.1.1
<!-- Specify commit hash if non-official. -->


**OS/device including version:**
Windows 7 Ultimate SP1 x64
Acer Aspire 4738, Intel(R) HD Graphics
<!-- Specify GPU model and drivers if graphics-related. -->


**Issue description:**
The game won't run after Godot attempts to use GLES3, though the IDE still says GLES2.
<!-- What happened, and what was expected. -->


**Steps to reproduce:**
Open an GLES3 project in a device that only runs GLES2.


**Minimal reproduction project:**
[Godot GLES bug.zip](https://github.com/godotengine/godot/files/3294017/Godot.GLES.bug.zip) (just a node2D in GLES3)
[Video demonstration](https://vimeo.com/342542032)
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
Repository: TypeScript
Issue: Merge same function signatures for intersection types
Labels: Suggestion,Awaiting More Feedback

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the *entire* template below.
-->

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  3.6.0-dev.20190611

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** function signature merge

**Code**

```ts
interface X { 
    name: string;
    method(): void;
}

interface Y { 
    index: number;
    method(): void;
}

var z: X & Y;

z.method(); // <--- Put your cursor here
```

**Expected behavior:** IntelliSense should ideally show only one signature.

**Actual behavior:** It shows two exactly same signatures. Not harming, but weird.

**Playground Link:** https://www.typescriptlang.org/play/#src=interface%20X%20%7B%20%0D%0A%20%20%20%20name%3A%20string%3B%0D%0A%20%20%20%20method()%3A%20void%3B%0D%0A%7D%0D%0A%0D%0Ainterface%20Y%20%7B%20%0D%0A%20%20%20%20index%3A%20number%3B%0D%0A%20%20%20%20method()%3A%20void%3B%0D%0A%7D%0D%0A%0D%0Avar%20z%3A%20X%20%26%20Y%3B%0D%0A%0D%0Az.method()
Repository: ant-design
Issue: `<Typography>` should offer default styles for `<table>` inside it
Labels: help wanted,💡 Feature Request,Inactive

- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.

### What problem does this feature solve?
Pages of copy (e.g., legal pages) look beautiful, just by using `<Typography>` and standard markup inside, with no custom CSS required.

Except for `<table>` which doesn't get any styling at all and looks lame.

Using the `<Table>` react component is overkill when you just want a table with simple copy inside it, and may be the styling is a bit "too much" for a simple table and will look jarring against the beautiful copy.


### What does the proposed API look like?
No API, just some extra LESS like:

```
.antd-typography table { border: 1px solid @typography-table-border-color; }
.antd-typography table th { font-weight: 700; }
```

^^^ Anyway I just made that CSS up, not real examples I recommend


<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: pytorch
Issue: Logging mode for saying when tensor broadcast occurs
Labels: module: internals,feature,module: molly-guard,triaged

## 🚀 Feature
<!-- A clear and concise description of the feature proposal -->
```python
torch.disable_broadcast()
# raise errors instead of doing broadcast underneath.

```

## Motivation

<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->
Broadcast is very convenient and efficient in many scenarios, but it also introduces extra careless bugs which are hard to locate.
It should be great if I can disable the broadcast mechanism (or force the Tensor size check) at debugging time.

## Pitch

<!-- A clear and concise description of what you want to happen. -->

## Alternatives

<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->

## Additional context

<!-- Add any other context or screenshots about the feature request here. -->
Repository: create-react-app
Issue: Add support for eslint-plugin-jest
Labels: issue: proposal

For typical development while using create-react-app, inevitability there will be a time when developers accidentally commit stuff like `fit` or `fdescribe` - I would like CRA to have built in support for eslint-plugin-jest and set those as warnings so they can be caught as hard errors in CI.
Repository: rust
Issue: `for` loop desugaring treats the loop's trailing expression in unusual way
Labels: T-lang,T-compiler,C-bug

Namely, it's treated as a semicolon-less statement in a middle of the block.
```rust
// Like this:
fn main() {
    { 0 } // <- semicolon-less statement in a middle of the block

    ()
}
```
- "Semicolon-less" means that its type should unify with `()` (https://github.com/rust-lang/rust/pull/61753).
- "In a middle of the block" means that it's not treated as trailing and its lifetime is not extended from the block outwards. That means "does not live long enough" errors like [these](https://github.com/rust-lang/rust/pull/61753#issuecomment-502306283) do not happen (a minimized test case would be appreciated).

This is unusual because
- No other block construction or loop does this.
- The desugared form cannot be written in source code (it will either need a semicolon, or will be considered trailing).

Git blame says that the behavior was introduced by @Zoxc in https://github.com/rust-lang/rust/pull/42265.

We cannot remove this behavior because it appears to be useful and code will break if it's removed.
We can, however, use it in other block constructions for which the block's trailing expression does not represent its result.

| Block construction  | Trailing expression is the result |
| ------------- | ------------- |
| `if cond { ... } [else { ... }]`  | Yes  |
| `if let pat = expr { ... } [else { ... }]`  | Yes  |
| `while cond { ... }`  | No  |
| `while let pat = expr { ... }`  | No  |
| `for pat in expr { ... }`  | No  |
| `loop { ... }`  | No  |
| `[unsafe] { ... }`  | Yes  |
| `async { ... }`  | ???  |
| `try { ... }`  | Yes  |
Repository: youtube-dl
Issue: New option to keep original subtitles file after conversion (or update readme)
Labels: request

<!--

######################################################################
  WARNING!
  IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################

-->

## Checklist

- [X] I'm reporting a feature request
- [X] I've verified that I'm running youtube-dl version **2019.06.08**
- [X] I've searched the bugtracker for similar feature requests including closed ones


## Description

Currently, there is no specific option to keep the original subtitles file after a conversion.  It is deleted by default.  Nonetheless, the original subtitles file can be retained if the "--keep-video" option is used – this doesn't seem to be documented.  However, that will cause the original video file to be kept if remuxing is also specified.  It doesn't seem possible to keep the original video file but not the original subtitles files and vice-versa.

A separate "keep original subtitles file" option would address this.  However, I guess FFmpeg  might not have a separate option for this so, alternatively, the readme.md could be altered to make clear that the original video and subtitles files will be kept.  That is, "--keep-video" will keep the original subtitles file after conversion and/or the original video file after remuxing.