sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: Add splash radius to IconButtonThemeData
Labels: c: new feature,framework,f: material design,c: proposal,good first issue,P3,team-design,triaged-design

<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case
Whenever i want to set `defaultSplashRadius` i need to change that IconButton property one by one

<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->

## Proposal
Can you add `defaultSplashRadius` to become customize?
Since the default size is might large to me
<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching images showing what you are imagining.

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->
Repository: excalidraw
Issue: changelog
Labels: discussion

@lipis and I discussed how we could [notify users of new features](https://github.com/excalidraw/excalidraw/issues/2468). My suggestion was to show changelog in the help dialog.

Whatever we do, I think we should keep a user-facing changelog for excalidraw.com itself, not just the package. Meaning it should contain changes not listed in the `@excalidraw/excalidraw` package changelog.

Moreover, if we want to display a changelog in the UI, each change should stand on its own because unlike in the package, we release each change immediately. Thus, it doesn't make sense to put the changes under sections because it would result in something like this:

```
# feature
- lalala
# fix
- lalala
# feature
- lalala
# feature
- lalala
```

Moreover still, since we'll effectively need 2 separate changelogs, I don't think maintaining (and syncing) both of them manually is feasible.

---

As such, I propose to maintain a machine-readable changelog, where:

1. Each line is one commit to `master`.
2. Each line is qualified with the type of the change (we now do that already by prefixing the commit message with `feat:` etc.) so it can be automatically parsed and sorted under respective section for the user-facing changelogs.

If we employ [Enforce semantic PR title #2531](https://github.com/excalidraw/excalidraw/discussions/2531), this machine readable changelog can be fully automated.

After that, we maintain two (or more) separate, user-facing changelogs. One for the web app, and one for the package.

The web-app changelog will largely be identical to the machine-readable (+ some styling changes so it displays nicely in the UI), while the package changelog will look more or less identical to how the changelog looks now (with sections).

These use-facing changelogs could be automated, as well.
Repository: TypeScript
Issue: Document File name has a '.js' extension - stripping it
Labels: Docs

**TypeScript Version:**  4.2.0-dev.20201211

**Search Terms:** typescript File name has a '.js' extension - stripping it

**Code**

https://github.com/sguillia/ts-repro-III

other.ts

```ts
import * as index from "./index.js"
```

index.ts

```ts
export { }
```

Compile with:

```bash
tsc other.ts --traceResolution
```

**Expected behavior:**

_Does not compile?_

**Actual behavior:**

```bash
$ tsc other.ts --traceResolution
...
File name '/path/to/ts-repro-III/index.js' has a '.js' extension - stripping it.
...
```

This document is very good:
https://www.typescriptlang.org/docs/handbook/module-resolution.html

But it doesn't talk about resolution of modules with their extensions.

The actual behavior is fine but I did not manage to find its documentation

Same issue for jsx

```bash
$ tsc other.ts --traceResolution
...
File name '/path/to/ts-repro-III/index.jsx' has a '.jsx' extension - stripping it.
...
```

Would it be possible to document
- which extension are trimmed?
- what look-ups are performed based on the file name with extension stripped?

**Playground Link:** https://github.com/sguillia/ts-repro-III

**Related Issues:** no
Repository: electron
Issue: Add a way to disable smooth scrolling at runtime
Labels: enhancement :sparkles:

### Preflight Checklist

* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

### Proposed Solution

Add a way to disable and enable smooth scrolling at runtime.

### Alternatives Considered

I can disable smooth scrolling using `app.commandLine.appendSwitch('--disable-smooth-scrolling');`. The thing is that it doesn't work at runtime.
Repository: pytorch
Issue: global_pruning costs memory after model is trained
Labels: module: cuda,module: memory usage,triaged,module: pruning

## 🐛 Bug

Hi, I was working on iteratively pruning with global_pruning method (training --> prune --> training --> prune). However, I found it costs GPU memory after pruning.

With a very big model such as BERT, I ran into OOM issue after some pruning steps. I suspect the problem is due to the model parameters are updated during training since there are no memory costs if we only apply global prune N times. It will be really helpful if we can identify the problem and solve it.
Thank you!

## To Reproduce

Steps to reproduce the behavior:

Here is a mini example in colab: https://colab.research.google.com/drive/14t8E_17NuOY46iOwuB_TDTVUn-SVvh1a?usp=sharing



cc @ngimel @ezyang @bhosmer @smessmer @ljk53 @bdhirsh @ailzhang
Repository: pytorch
Issue: a time series library 
Labels: feature,triaged,needs research

## 🚀 Feature

A deep learning-based time series forecasting library with Pytorch. 

## Motivation
Time series forecasting has broad significance in public health, finance, and engineering. Traditional time series methods from statistics often rely on strong modeling assumptions, or are computationally expensive.  Given the rise of large-scale sensing data and significant advances in deep learning, the goal of the project is to develop an efficient and user-friendly deep learning library that would benefit the entire research community. 

Existing time series analysis libraries include statsmodels,  sktime. However, these libraries only include traditional statistics tools such as ARMA or ARIMA, which do not have state-of-the-art forecasting tools based on deep learning. GluonTS is an open-source time-series library developed by Amazon AWS but is based on MXNet. Pyro is a probabilistic programming framework based on Pytorch, but is not focused on time series forecasting. 

## Pitch

We will integrate some research code from my groups and others and develop a unified interface for time series forecasting.  The library will include both state-of-the-art research and benchmark reports.

## Alternatives

<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->

## Additional context

We have a group of students with diverse expertise, hoping to obtain some guidance from Pytorch team for better design integration.
Repository: pytorch
Issue: [pre-commit hook] fails on `BLK100 Black would make changes.`
Labels: oncall: distributed,triaged

## 🐛 Bug

Using the instructions at:
https://github.com/pytorch/pytorch/blob/master/CONTRIBUTING.md#pre-commit-tidylinting-hook
I enabled the hook, but it fails with:

```
git commit
Running pre-commit flake8
gtorch/distributed/launch.py:151:1: BLK100 Black would make changes.
```

So I can't commit.

This is while doing this PR: https://github.com/pytorch/pytorch/pull/49305

So I had to disable the hook in order to proceed.

Note that if I run `black` on this file - it makes a ton of changes! (none related to the changes proposed in the PR).

I also tried adding `BLK100` to ignores in `.flake8`, but then `flake8` starts emitting a whole bunch of other errors.

```
black --version
black, version 20.8b1
flake8 --version
3.8.4 (black: 0.2.1, mccabe: 0.6.1, pycodestyle: 2.6.0, pyflakes: 2.2.0) CPython 3.8.5 on Linux
```
Thanks.

cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @agolynski @SciPioneer @H-Huang @mrzzd
Repository: kubernetes
Issue: Move negative test cases for volumemode outside of testsuite
Labels: kind/bug,sig/storage,priority/important-longterm,lifecycle/frozen,needs-triage

https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/testsuites/volumemode.go#L193

In the current storage volumemode testsuite, there are some negative test cases which checks if a driver does not support raw block, it should not provision block volume mode PV. This test case should be moved to the csi-sanity testsuite: https://github.com/kubernetes-csi/csi-test/blob/master/pkg/sanity/controller.go

/sig storage
/cc @msau42
Repository: flutter
Issue: Call out expensive layers/widgets in janky frames
Labels: c: new feature,framework,engine,c: performance,d: devtools,perf: speed,P3,team-engine,triaged-engine

This is probably some joint work between the framework and devtools - @jacob314 

In some recent work with an internal customer, we looked at some janky portions of an application. One thing that came up was the use of ClipRRect and Opacity widgets/layers in frames that ended up being expensive on the GPU.

It would be ideal to have some way to call this out to developers at runtime, probably via devtools. For example, if a frame exceeded 16ms, identify if there was a layer that dominated rasterization time (or a build that dominated frame time). If so, see if we can get some idea of what widget(s) were responsible for that layer. This will may require passing some additional metadata in layers so that we can emit that metadata into the timeline, similar to what we do when tying a exception back to an offending widget (/cc @chunhtai @goderbauer who are more familiar with that).

We may also want this to be somewhat configurable, for example allowing periods longer than 16ms when running in debug mode. It would also be nice if this could just capture frames that "took the longest" over the course of a run - particularly for users who are running on higher end devices but want to support lower end hardware without jank.

The end goal is for developers to get early signal about whether changes they are making improve or worsen jank.
Repository: terminal
Issue: Minimize button stays highlighted in minimized-window-preview
Labels: Help Wanted,Issue-Bug,Area-UserInterface,Product-Terminal,Priority-3

<!-- 
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed!
-->

<!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.

**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue.

If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link.

Please use this form and describe your issue, concisely but precisely, with as much detail as possible.

-->

# Environment

```none
Windows build number: Microsoft Windows NT 10.0.19042.662
Windows Terminal version (if applicable): 1.5.3242.0
```

# Steps to reproduce

1. Open Windows Terminal.
2. Click on minimize.
3. Put your cursor on the Terminal icon in the taskbar to get the application's preview.
4. Hover your cursor on the preview. You'll see that the minimize button is displayed as clicked and not released.

# Expected behavior

Minimize button should be displayed normally.

# Actual behavior

Minimize button is being displayed as clicked but not released.
Repository: flutter
Issue: flutter emulators --launch cannot find and launch named iOS simulators
Labels: platform-ios,tool,t: xcode,P3,team-ios,triaged-ios

No emulator found that matches 'iPhone 12'.
```
$ flutter emulator --launch "iPhone 12"   
No emulator found that matches 'iPhone 12'.
```

Only `$ flutter emulator --launch apple_ios_simulator` "works" but it just launches the Simulator app, not a particular simulator.

This code should be swapped to `xcrun simctl boot` to launch particular simulators by ID instead of just launching the app:
https://github.com/flutter/flutter/blob/537cf33a21773e4ec6a4bd620a08e9fe9cfdfe99/packages/flutter_tools/lib/src/ios/ios_emulators.dart#L70-L76

https://github.com/flutter/flutter/blob/537cf33a21773e4ec6a4bd620a08e9fe9cfdfe99/packages/flutter_tools/lib/src/ios/ios_emulators.dart#L42-L48
Repository: godot
Issue: Named Tiles, In The TileSet Editor, Rename Themselves Constantly
Labels: bug,topic:editor

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:**
<!-- Specify commit hash if using non-official build. -->
3.2.3 Stable 64-bit Standard


**OS/device including version:**
<!-- Specify GPU model, drivers, and the backend (GLES2, GLES3, Vulkan) if graphics-related. -->
Windows 10 Education 64-Bit (10.0 Build 19041)
RTX 2080 Super
GLES3


**Issue description:**
<!-- What happened, and what was expected. -->
I was creating several tiles through the tileset editor, which Godot names them automatically based on the resources filename, this works fine. However, as I started to name them each I encountered a bug where previously user-named tiles would have their name overwritten to a completely different user-named tile. 

For example, I have a couple grass tiles (grass1, grass2, grass3 etc) and a couple rock tiles. If I am currently on the rock tile and click back to one of the grass tiles then that specific grass tile would have its' name automatically changed to the rock tiles name I was previously on. Sometimes the name just changes to a random user-named tile instead, grass1 becomes grass 4 while the original grass4 stays as grass4. Renaming them doesn't do anything, I rename the affected tile, again, click to a different tile and back again to the previously affected tile and the name would change to another random user-named tile or go back to the incorrect name as if my renaming it did nothing at all.

**Steps to reproduce:**
Through the Tileset Editor create a few single tiles.
Name each one
Click on each user-named tile, eventually the naming error occurs.

**Minimal reproduction project:**
<!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. -->
[Tile Name Error.zip](https://github.com/godotengine/godot/files/5691906/Tile.Name.Error.zip)
Repository: pytorch
Issue: PyEval_SaveThread: the function must be called with the GIL held, but the GIL is released
Labels: triaged,module: pybind

## 🐛 Bug

```python
import torch
import torch.nn as nn

model = nn.Sequential(*(nn.Linear(512, 512) for i in range(100)))
inp = torch.rand(32, 512)
out = model(inp)
out.backward(torch.ones_like(out))
```

error

```
Fatal Python error: PyEval_SaveThread: the function must be called with the GIL held, but the GIL is released (the current Python thread state is NULL)
Python runtime state: finalizing (tstate=0x55b20f634420)

Aborted (core dumped)
```

## Environment

```
Collecting environment information...
PyTorch version: 1.8.0a0+9dca055
Is debug build: False
CUDA used to build PyTorch: 11.1
ROCM used to build PyTorch: N/A

OS: Arch Linux (x86_64)
GCC version: (GCC) 10.2.0
Clang version: 11.0.0
CMake version: version 3.19.1

Python version: 3.9 (64-bit runtime)
Is CUDA available: True
CUDA runtime version: Could not collect
GPU models and configuration: 
GPU 0: GeForce RTX 3090
GPU 1: GeForce RTX 2080 Ti

Nvidia driver version: 455.45.01
cuDNN version: Probably one of the following:
/usr/lib/libcudnn.so.8.0.5
/usr/lib/libcudnn_adv_infer.so.8.0.5
/usr/lib/libcudnn_adv_train.so.8.0.5
/usr/lib/libcudnn_cnn_infer.so.8.0.5
/usr/lib/libcudnn_cnn_train.so.8.0.5
/usr/lib/libcudnn_ops_infer.so.8.0.5
/usr/lib/libcudnn_ops_train.so.8.0.5
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] numpy==1.19.4
[pip3] torch==1.8.0a0
[conda] Could not collect
```
Repository: pytorch
Issue: [jit] Support `torch.Tensor.numel()` and `torch.Size.numel()` properly in tracing
Labels: oncall: jit

## 🚀 Feature
[jit] Support `torch.Tensor.numel()` and `torch.Size.numel()`  properly in tracing.

## Motivation
Currently, tracing `x.numel()` causes the number of elements of `x` to be statically recorded in the JIT code. This can break programs that expect tensors with dynamic shape. For example, tracing the following function:

```py
def avg(x):
    return x.sum()/x.numel()
```

results in the following JIT program code:

```
def avg(x: Tensor) -> Tensor:
  _0 = torch.div(torch.sum(x, dtype=None), CONSTANTS.c0)
  return _0
```

which breaks the following code:

```py
avg_jit = trace(avg, torch.empty(2,4,5))
print(avg_jit(torch.ones(2,3,5)))  # 0.75, should be 1. instead
```

## Pitch
When tracing calls to `torch.Tensor.numel()` or `torch.Size.numel()`, the function should always return the number of elements of the corresponding tensor instead of the number of elements of example tensor.

cc @gmagogsfm
Repository: pytorch
Issue: [JIT-DEBUG] Suppress GRAPH dump in profile-graph-executor
Labels: oncall: jit

## 🚀 Feature
<!-- A clear and concise description of the feature proposal -->
Improve JIT's IR-transformation log by skipping graph dump if a transformation does not change any IR in `profiling_graph_executor_impl.cpp`

## Motivation

`PYTORCH_JIT_LOG_LEVEL` is a primary tool for JIT developers to debug problems during IR transformation. One issue identified is that too much information is dumped when enabling the `GRAPH_DEBUG` dump in `profiling_graph_executor_impl.cpp` because it currently dumps the graph after each transformation listed in the transformation pipeline, regardless of whether a transformation made any changes to the IR. Below shows the fragment of the output for a simple test, where the dump is very convoluted. 

```
DEBUG profiling_...] Before inlining (beginning of runProfilingInsensitiveOptimizations)
[DEBUG profiling_...] graph(%x : Tensor):
[DEBUG profiling_...]   %1 : Tensor = aten::frac(%x) # test/test_jit_fuser_te.py:1216:0
[DEBUG profiling_...]   return (%1)
[DEBUG profiling_...] After inlining, before ClearProfilingInformation
[DEBUG profiling_...] graph(%x : Tensor):
[DEBUG profiling_...]   %1 : Tensor = aten::frac(%x) # test/test_jit_fuser_te.py:1216:0
[DEBUG profiling_...]   return (%1)
[DEBUG profiling_...] After ClearProfilingInformation, before LowerGradOf
[DEBUG profiling_...] graph(%x : Tensor):
[DEBUG profiling_...]   %1 : Tensor = aten::frac(%x) # test/test_jit_fuser_te.py:1216:0
[DEBUG profiling_...]   return (%1)
[DEBUG profiling_...] After LowerGradOf, before ClearUndefinedness
[DEBUG profiling_...] graph(%x : Tensor):
[DEBUG profiling_...]   %1 : Tensor = aten::frac(%x) # test/test_jit_fuser_te.py:1216:0
[DEBUG profiling_...]   return (%1)
```

This issue will enhance the dump output by only dump the graph after a transformation if any changes are made to the graph. We are breaking debugging info enhancement to several steps, and this is the first one in the series.

In this issue, we try to add utilities to detect Graph IR changes either after the fact or let IR-mutating transformations to set a flag.  Sanitization of graph IR dump will be added to `profile_graph_executor_imp` first as it suffers the problem the most, and then add to other places where `GRAPH/DEBUG_DUMP` macros are used.


cc @gmagogsfm
Repository: TypeScript
Issue: comment is incorrectly clickable
Labels: Bug

*TS Template added by @mjbvz*

**TypeScript Version**: 4.1.2

**Search Terms**
- definitionAndBoundSpan
- go to definition
- f12

---

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: Version: 1.53.0-insider
- OS Version: macOS Big Sur 11.1 Beta (20C5048k)

Steps to Reproduce:

1. Considering the following sample code:

```ts
import * as _ from "lodash";

const groupedRegions = _.chain(regions)
    // Group the elements of Array based on `color` property
    .groupBy("area")
    // `key` is group's name (color), `value` is the array of objects
    .map((value, key) => ({ groupName: key, regions: value }))
    .value();
```

2. hold <kbd>⌥</kbd> and hover on any of the comment the whole chain is highlighted and clickable

screenshot:

![image](https://user-images.githubusercontent.com/3783096/102084843-b894d700-3e50-11eb-9339-34eef42752e9.png)


<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes