Repository: create-react-app
Issue: Incorrect glob pattern in webpack config
Labels: needs triage,issue: bug report

<!--
    Please note that your issue will be fixed much faster if you spend about
    half an hour preparing it, including the exact reproduction steps and a demo.

    If you're in a hurry or don't feel confident, it's fine to report bugs with
    less details, but this makes it less likely they'll get fixed soon.

    In either case, please use this template and fill in as many fields below as you can.

    Note that we don't provide help for webpack questions after ejecting.
    You can find webpack docs at https://webpack.js.org/.
-->

### Describe the bug

After updating to `react-scripts` v5.0.1 our builds starting failing as they were now including test files that relied on dev dependencies that had not been installed for the production build. I would not expect those test files to be included in the build.

The issue seems to be an incorrect glob pattern in the Webpack config for TypeScript files. There is already an open PR – https://github.com/facebook/create-react-app/pull/11875 – for this issue but it has been in review for a while and I could not find any related open issues so I'm opening one in the hope of getting the existing PR merged. 

### Did you try recovering your dependencies?

<!--
  Your module tree might be corrupted, and that might be causing the issues.
  Let's try to recover it. First, delete these files and folders in your project:

    * node_modules
    * package-lock.json
    * yarn.lock

  Then you need to decide which package manager you prefer to use.
  We support both npm (https://npmjs.com) and yarn (https://yarnpkg.com/).
  However, **they can't be used together in one project** so you need to pick one.

  If you decided to use npm, run this in your project directory:

    npm install -g npm@latest
    npm install

  This should fix your project.

  If you decided to use yarn, update it first (https://yarnpkg.com/en/docs/install).
  Then run in your project directory:

    yarn

  This should fix your project.

  Importantly, **if you decided to use yarn, you should never run `npm install` in the project**.
  For example, yarn users should run `yarn add <library>` instead of `npm install <library>`.
  Otherwise your project will break again.

  Have you done all these steps and still see the issue?
  Please paste the output of `npm --version` and/or `yarn --version` to confirm.
-->

Yes, it did not fix the issue.
```
❯ npm -v
8.11.0
```

### Which terms did you search for in User Guide?

<!--
  There are a few common documented problems, such as watcher not detecting changes, or build failing.
  They are described in the Troubleshooting section of the User Guide:

  https://facebook.github.io/create-react-app/docs/troubleshooting

  Please scan these few sections for common problems.
  Additionally, you can search the User Guide itself for something you're having issues with:

  https://facebook.github.io/create-react-app/

  If you didn't find the solution, please share which words you searched for.
  This helps us improve documentation for future readers who might encounter the same problem.
-->

"typescript", "typescript webpack", "devdependencies"

### Environment

<!--
  To help identify if a problem is specific to a platform, browser, or module version, information about your environment is required.
  This enables the maintainers quickly reproduce the issue and give feedback.

  Run the following command in your React app's folder in terminal.
  Note: The result is copied to your clipboard directly.

  `npx create-react-app --info`

  Paste the output of the command in the section below.
-->

```
❯ npx create-react-app --info

Environment Info:

  current version of create-react-app: 5.0.1
  running from /Users/xxx/.npm/_npx/c67e74de0542c87c/node_modules/create-react-app

  System:
    OS: macOS 12.3.1
    CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
  Binaries:
    Node: 16.13.2 - ~/.nvm/versions/node/v16.13.2/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 8.11.0 - ~/Projects/cra-bug-example/node_modules/.bin/npm
  Browsers:
    Chrome: 102.0.5005.61
    Edge: 102.0.1245.30
    Firefox: 93.0
    Safari: 15.4
  npmPackages:
    react: ^18.1.0 => 18.1.0 
    react-dom: ^18.1.0 => 18.1.0 
    react-scripts: 5.0.1 => 5.0.1 
  npmGlobalPackages:
    create-react-app: Not Found
```

### Steps to reproduce

<!--
  How would you describe your issue to someone who doesn’t know you or your project?
  Try to write a sequence of steps that anybody can repeat to see the issue.
-->
I've included a link to a demo below which was created using these steps

1. Create a new React app with TypeScript using `npx create-react-app my-app --template typescript`
2. `cd my-app`
3. Add `msw` as a dev dependency using `npm install -D msw`
4. Add the following code to `src/App.test.tsx`
``` ts
import { setupWorker } from "msw";

const worker = setupWorker();
```
5. Install only production dependencies using `npm install --omit=dev`
6. Run `npm run build` which should fail with `TS2307: Cannot find module 'msw' or its corresponding type declarations.`

You can test this was not an issue before v5 by downgrading to `react-scripts` v4.0.3 and running step 5 & 6 again. This time the build should succeed.

### Expected behavior

<!--
  How did you expect the tool to behave?
  It’s fine if you’re not sure your understanding is correct.
  Just write down what you thought would happen.
-->

The build would succeed as it would not include test files.

### Actual behavior

<!--
  Did something go wrong?
  Is something broken, or not behaving as you expected?
  Please attach screenshots if possible! They are extremely helpful for diagnosing issues.
-->

Build failed because it could not find dependency imported in a test file.
![Screenshot 2022-06-01 at 17 16 36](https://user-images.githubusercontent.com/38754228/171439381-5e0d53a6-aea1-4715-b106-ced96f517f3a.png)

### Reproducible demo
<!--
  If you can, please share a project that reproduces the issue.
  This is the single most effective way to get an issue fixed soon.

  There are two ways to do it:

    * Create a new app and try to reproduce the issue in it.
      This is useful if you roughly know where the problem is, or can’t share the real code.

    * Or, copy your app and remove things until you’re left with the minimal reproducible demo.
      This is useful for finding the root cause. You may then optionally create a new project.

  This is a good guide to creating bug demos: https://stackoverflow.com/help/mcve
  Once you’re done, push the project to GitHub and paste the link to it below:
-->

This demo was created following the steps in the "Steps to reproduce" section.

https://github.com/heuperman/cra-bug-example

To reproduce the bug, take the following steps:
1. Clone the repo
2. Install only production dependencies using `npm install --omit=dev`
3. Run `npm run build` which should fail with `TS2307: Cannot find module 'msw' or its corresponding type declarations.`

I hope this is enough information to review the issue. As I mentioned above there is already a PR with a fix here: https://github.com/facebook/create-react-app/pull/11875. Please let me know if I can provide anything else to help.

<!--
  What happens if you skip this step?

  We will try to help you, but in many cases it is impossible because crucial
  information is missing. In that case we'll tag an issue as having a low priority,
  and eventually close it if there is no clear direction.

  We still appreciate the report though, as eventually somebody else might
  create a reproducible example for it.

  Thanks for helping us help you!
-->