sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: TypeScript
Issue: API: make 'isExternalOrCommonJsModule' public
Labels: Suggestion,In Discussion

# Suggestion

<!--
  Please fill in each section completely. Thank you!
-->

## 🔍 Search Terms

<!--
  💡 Did you know? TypeScript has over 2,000 open suggestions!
  🔎 Please search thoroughly before logging new feature requests as most common ideas already have a proposal in progress.
  The "Common Feature Requests" section of the FAQ lists many popular requests: https://github.com/Microsoft/TypeScript/wiki/FAQ#common-feature-requests

  Replace the text below:
-->

isExternalOrCommonJsModule, commonJsModuleIndicator

## ✅ Viability Checklist

<!--
   Suggestions that don't meet all these criteria are very, very unlikely to be accepted.
   We always recommend reviewing the TypeScript design goals before investing time writing
   a proposal for ideas outside the scope of the project.
-->
My suggestion meets these guidelines:

* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).


## ⭐ Suggestion

Make the existing utility function `ts.isExternalOrCommonJsModule` public by moving it from `utilities.ts` to `utilitiesPublic.ts`

## 📃 Motivating Example

TypeScript treats commonJS modules similar to external modules. But currently there's no way for an API user to know whether TypeScript considers a file as commonJS module. `SourceFile#commonJsModuleIndicator` is not exposed in the public API and there's no `ts.isCommonJsModule` as pendant to `ts.isExternalModule`.

## 💻 Use Cases

My current use case is to determine whether a file (or top-level declaration inside of it) contributes to the global scope. Currently I can only handle external modules, which doesn't match what TypeScript does internally.
Repository: vscode
Issue: Git - Add more fields and sort options
Labels: feature-request,git

Issue Type: <b>Feature Request</b>

When preparing to commit, I like to see the files I've changed sorted by Last Modified date, so I can see what I changed most recently. I also like being able to view and sort by Status, Lines Added, and Lines Removed. These columns and sort options are all available in TortoiseGit, and it would be really awesome to have them in VS Code.

VS Code version: Code 1.53.2 (622cb03f7e070a9670c94bae1a45d78d7181fbd4, 2021-02-11T11:48:04.245Z)
OS version: Windows_NT x64 10.0.19041


<!-- generated by issue reporter -->
Repository: svelte
Issue: Ability to get reference of current component
Labels: temp-stale

**Is your feature request related to a problem? Please describe.**
Add ability to get reference of current component. Something like bind:this, but bind:this works only for child component

Use case:  
I need to register active component to global handler. I have global menu, there is eg. command "Refresh" and this command should call "export function refresh() {}"  of current component

**Describe the solution you'd like**
Probably the best way would be some API, like getCurrentComponent(), similar to getContext() API. 

**Describe alternatives you've considered**
There are two workarounds:
Bind in parent component and pass down in prop:
```svelte
<script>
  let activeComponent;
</script>

<Child instance={activeComponent} bind:this={activeComponent} />
```
Or a bit tricky solution using svelte:self  
See this REPL: https://svelte.dev/repl/3b32cfb5331843b286f02e2bb28a294a?version=3.33.0

**How important is this feature to you?**
There are workarounds, but if would be nice to be able to do this directly
Repository: flutter
Issue: [web]: PathRef.getRRect() could be simpler, faster, and more precise
Labels: engine,c: performance,platform-web,e: web_html,P3,team-web,triaged-web

Current `PathRef.getRRect()` reconstructs the RRect from the verbs. However, at the time the path is constructed we already have the `RRect` object, and we record that the path is an RRect using the `fIsRRect` field. We destroy this information and rebuild it again later in `_getRRect()`. Instead, we could store the original `RRect` and use it both as the "path is rrect" signal and as a fast way to get the RRect object. Pseudo-code (the devil's in the detail):

BEFORE:

```
  // Field
  bool fIsRRect = false;

  // Check if RRect
  if (fIsRRect)

  // Declare that the path is no a simple RRect
  fIsRRect = false;

  // Declare the the path is a simple RRect
  fIsRRect = true;
```

AFTER:

```
// Field
RRect? asRRect;

// Check if RRect
if (asRRect != null)

// Declare that the path is no a simple RRect
asRRect = null;

// Declare the the path is a simple RRect
asRRect = rrectPassedToPathAddRRect;
```

Then `PathRef._getRRect()` can be removed entirely, or used for detection of RRects created using lower-level path operations rather than `addRRect`.
Repository: go
Issue: cmd/cgo: building c-archive with function pointer works with Go 1.14, but not 1.15 and beyond
Labels: help wanted,NeedsFix,compiler/runtime

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.15 darwin/amd64
</pre>

### Does this issue reproduce with the latest release?
Yes.

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/willie/Library/Caches/go-build"
GOENV="/Users/willie/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/willie/pkg/mod"
GONOPROXY="github.com/vitalsource/*"
GONOSUMDB="github.com/vitalsource/*"
GOOS="darwin"
GOPATH="/Users/willie"
GOPRIVATE="github.com/vitalsource/*"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/willie/.asdf/installs/golang/1.15/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/willie/.asdf/installs/golang/1.15/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/willie/willie/cgotest/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4z/2t7q40b14znb__08yd_p_znw0000gn/T/go-build009670235=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>

### What did you do?
I build a Go c-archive static library to use in several C/C++ programs. Building c-archives with cgo broke in a way that I don't understand in Go 1.15 and later. Building with Go 1.14 works fine. I put together a simple example here: https://github.com/willie/cgotest

### What did you expect to see?
I expected to be able to build a c-archive static library with no errors.

### What did you see instead?
<pre>
# command-line-arguments
_cgo_export.c:29:3: error: unknown type name 'writeFunc'
</pre>
Repository: kubernetes
Issue: In-tree plugin deprecation plan for non CSI migration support vendors
Labels: sig/storage,kind/feature,lifecycle/rotten,triage/accepted

<!-- Please only use this template for submitting enhancement requests -->

#### What would you like to be added:
sig-storage should come up with a plan to deprecate in-tree plugins that do not support CSI migration. And eventually, remove the code from core k8s codebase.

#### Why is this needed:
CSI Migration has been in Beta since v1.17, and it is planning to go GA around 1.23-1.24.
Currently, there are a lot of [in-tree plugins](https://kubernetes.io/docs/concepts/storage/volumes/#volume-types), while only a subset of them supports CSI Migration. So for the plugin that does not support CSI Migration, the plan is to let the plugin deprecate itself and eventually block the usage and remove the in-tree code. Users who want to use these plugins can switch to their corresponding CSI drivers and get better support and more advanced features.

We should come up with a timeline to communicate with all the external storage plugins about their deprecation timeline and start deprecation.

/sig storage
/cc @msau42 @jsafrane @saad-ali @xing-yang
Repository: flutter
Issue: PointerScrollEvent is not consistent between platforms (Desktop/Web)
Labels: platform-mac,platform-windows,platform-web,has reproducible steps,P2,found in release: 2.10,found in release: 2.13,team-linux,triaged-linux

PointerScrollEvent.scrollDelta.y, we're seeing values of 100 on web, and 20 on Desktop. 

Reproduction: Use the middle-mouse scrollwheel with code like:
```
Listener(
      onPointerSignal: (signal) {
        if (signal is PointerScrollEvent) {
          print("${signal.scrollDelta.dy}"); //  returns 100 on Web, 20 on Windows
        }
      },
```

[√] Flutter (Channel dev, 1.27.0-8.0.pre, on Microsoft Windows [Version 10.0.19042.685], locale en-US)
    • Flutter version 1.27.0-8.0.pre at C:\_dev\sdks\flutter
    • Framework revision b7d4806243 (7 days ago), 2021-02-19 09:22:45 -0800
    • Engine revision 6993cb229b
    • Dart version 2.13.0 (build 2.13.0-30.0.dev)
Repository: TypeScript
Issue: `${number}` template literal type does not allow "NaN" or "Infinity"
Labels: Suggestion,Awaiting More Feedback

# Bug Report

<!--
  Please fill in each section completely. Thank you!
-->

### 🔎 Search Terms

<!--
  What search terms did you use when trying to find an existing bug report?
  List them here so people in the future can find this one more easily.
-->
NaN Infinity template literal types
### 🕗 Version & Regression Information
4.3.0-dev.20210226
### ⏯ Playground Link

<!--
  A link to a TypeScript Playground "Share" link which shows this behavior

  The TypeScript Workbench can be used for more complex setups, try
  https://www.typescriptlang.org/dev/bug-workbench/

  As a last resort, you can link to a repo, but these will be slower for us to investigate.
-->
[Playground link with relevant code](https://www.typescriptlang.org/play?ts=4.3.0-dev.20210226#code/MYewdgzgLgBAhgLhmArgWwEYFMBOMC8MAcnETAPTlggy44g4CwAUKJLBkgAYAkA3qky4AvlwIwA5CSISK5ACoBPAA5ZJAImnrZASwjIQsOBAg6A5mDgYANmqg0oKtRN4D02HKIkA6FizbQMMBIgh7iAJJgAGY6YDqOctS0OPRMrOCBACbc-KEiYoQSkTFxjrKUSqoaxbHxitowegZGJuaWNnYOTpKueZ5cEkA)

### 💻 Code

<!-- Please post the relevant code sample here as well-->
```ts
const a: number = NaN //no error
const b: `${number}` = 'NaN' //Type '"NaN"' is not assignable to type '`${number}`'.

const c: number = Infinity //no error
const d: `${number}` = 'Infinity' //Type '"Infinity"' is not assignable to type '`${number}`'
```

### 🙁 Actual behavior
<!-- What happened, and why it was wrong -->
compile errors
### 🙂 Expected behavior

<!-- What you expected to happen instead, and why -->
the strings `"NaN"` and `"Infinity"` should be valid `` `${number}` ``s because `NaN` and `Infinity` are valid `number`s
Repository: flutter
Issue: Improve documentation for keyboard scrolling using Shortcuts
Labels: f: scrolling,d: api docs,d: examples,d: stackoverflow,platform-web,c: proposal,a: desktop,P3,team-framework,triaged-framework

Scrolling without keyboard support is useless for Web and Desktop.
This feature is not mentioned in https://github.com/flutter/flutter/issues/70866.
Maybe it is waiting for https://github.com/flutter/flutter/issues/44918?
Repository: opencv
Issue: iOS imwrite crash
Labels: category: imgcodecs,platform: ios/osx,incomplete,category: 3rdparty

<!--
If you have a question rather than reporting a bug please go to https://forum.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).

This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->

##### System information (version)
<!-- Example
- OpenCV => 4.2
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2017
-->

- OpenCV => 4.1.2
- Operating System / Platform => iOS 14.1
- Compiler => opencv2.framework download from opencv.org
- 
##### Detailed description

imread(string) is succ.
but call imwrite(string,mat)  crash. 
![image](https://user-images.githubusercontent.com/17610041/109382640-ab9a6680-791c-11eb-9d93-82a40bd7e237.png)

And no crash msg occur. 
How can i fix this?
thanks you.
Repository: godot
Issue: VisualScriptPropertySet\GET ignores or malforms the nodepath of exported properties
Labels: bug,topic:visualscript

**v3.2.4.rc3.official**

**Windows 10 PRO; Radeon RX 570 8GB; Driver 20.12.1; GLES3**

**VisualScriptPropertySet\GET ignores or malforms the nodepath of exported properties**
If you drag an exported property from the inspector to the visual script scene graph everything functions fine. If you for whatever reason need to use the ASSIGN feature to get the node it will not function properly.

If you make a built in VisualScript and look at the .tscn you will see that the paths are diffrent.
```
# This one works
[sub_resource type="VisualScriptPropertySet" id=1]
_default_input_values = [ "sample text" ]
set_mode = 1
base_type = "Spatial"
type_cache = {
"class_name": "",
"hint": 0,
"hint_string": "",
"name": "scripted_node_variable",
"type": 4,
"usage": 8199
}
node_path = NodePath("../scripted_node")
property = "scripted_node_variable"

# this one does not work
[sub_resource type="VisualScriptPropertySet" id=2]
set_mode = 1
type_cache = {
"class_name": "",
"hint": 0,
"hint_string": "",
"name": "",
"type": 0,
"usage": 7
}
node_path = NodePath("scripted_node")
```

**Minimal reproduction project:**

[visual_script_set_nodepath_malformed.zip](https://github.com/godotengine/godot/files/6054037/visual_script_set_nodepath_malformed.zip)
Repository: ant-design
Issue: Select自适应时火狐有滚动条后长度较长项出现省略号
Labels: help wanted,Inactive

- [ ] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.

### Reproduction link
[![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/dreamy-silence-3ydnz)

### Steps to reproduce
    <Select defaultValue="lucy" dropdownMatchSelectWidth={false}>
      <Option value="jack">Jack</Option>
      <Option value="lucy1123">Jack</Option>
      <Option value="lucy">Jack</Option>
      <Option value="lucy10">Lucy1111112</Option>
      <Option value="lucy1">Jack</Option>
      <Option value="lucy2">Jack</Option>
      <Option value="lucy3">Jack</Option>
      <Option value="lucy4">Jack</Option>
      <Option value="lucy5">Jack</Option>
      <Option value="lucy6">Jack</Option>
      <Option value="lucy7">Jack</Option>
      <Option value="lucy8">Jack</Option>
      <Option value="lucy9">Jack</Option>
      <Option value="disabled" disabled>
        Disabled
      </Option>
      <Option value="Yiminghe">yiminghe</Option>
    </Select>

### What is expected?
chrome正常，Firefox的Lucy1111112有省略号

### What is actually happening?
自适应时，无省略号

| Environment | Info |
|---|---|
| antd | 4.12.3 |
| React | 17最新 |
| System | windows10 |
| Browser | Firefox最新 |


<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: vscode
Issue: [product icon themes] theme icons support for vscode.show(Information|Warning|Error)Message
Labels: feature-request,themes,dialogs

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

The methods `vscode.show(Information|Warning|Error)Message` do not support theme icons `$(<name>)`-syntax, although the notification box shows a theme icon in front of the message.
Repository: pytorch
Issue: Wrong link in readme for the android nightly version
Labels: module: docs,module: android,oncall: mobile

In the file `readme.md`:
https://github.com/pytorch/pytorch/tree/master/android#nightly

The following dependencies are given

```
repositories {
    maven {
        url "https://oss.sonatype.org/content/repositories/snapshots"
    }
}

dependencies {
    ...
    implementation 'org.pytorch:pytorch_android:1.9.0-SNAPSHOT'
    implementation 'org.pytorch:pytorch_android_torchvision:1.9.0-SNAPSHOT'
    ...
}
```

These dependencies are only working for`pytorch_android:1.8.0` instead of `1.9.0`.
Is the 1.9.0 available somewhere?

cc @brianjo @mruberry
Repository: rust
Issue: std::fs::write is not atomic - document it explicitly or make it atomic
Labels: T-libs-api,A-io

By not being atomic, `std::fs::write()` may be a footgun for people trying to create correct/secure code.
As an example, nodejs has a function with same behavior that led to [a security risk](https://github.com/Ride-The-Lightning/RTL/issues/610). In that case creation of the secret token file succeeded but writing to it failed leaving an empty token file which caused application to accept empty authentication token later.

The documentation currently kind of describes the behavior but the implications may not be obvious to people. Adding a note about the risk of empty/corrupted file being left in case of failure could help people avoid issues.

If atomic behavior is undesired due to compatibility reasons, then maybe add another `atomic_write()` function and suggest it in `write()` doc. This could be done in a crate obviously but maybe the security/robustness benefits are a good reason to put it into `std`.

I'm willing to make a PR regardless of the conclusion.
Repository: go
Issue: x/crypto/ssh/knownhosts: fails to find key when port = "ssh"
Labels: NeedsInvestigation

<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->

### What version of Go are you using (`go version`)?

<pre>
go version go1.16 darwin/amd64
</pre>

### Does this issue reproduce with the latest release?

Yes

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jack/Library/Caches/go-build"
GOENV="/Users/jack/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/jack/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jack/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.16/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.16/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jack/dev/ccsalespro/isoamp/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/49/sq09r9hs3mlgyzk8r18zswfw0000gn/T/go-build464070472=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>

### What did you do?

net.Dial and ssh.Dial allow specifying ports by name. e.g. `host.example.com:ssh`. This fails in combination with `knownhosts`.

```go
	sshConfig := &ssh.ClientConfig{
		// ...
	}

	if homeDir, err := os.UserHomeDir(); err == nil {
		if hostKeyCallback, err := knownhosts.New(fmt.Sprintf("%s/.ssh/known_hosts", homeDir)); err == nil {
			sshConfig.HostKeyCallback = hostKeyCallback
		}
	}

	return ssh.Dial("tcp", "host.example.com:ssh", sshConfig)
```

### What did you expect to see?

I expect for the knownhost entry for host.example.com to be found.

### What did you see instead?

`ssh: handshake failed: knownhosts: key is unknown`

If the port is specified numerically it succeeds. e.g. `host.example.com:22`
Repository: pytorch
Issue: Add numerically stable methods to torch.distributions (e.g. logcdf)
Labels: module: distributions,triaged

## 🚀 Feature
Expose additional methods on (mainly continuous) probability distributions. Examples are `logcdf`, `logsf` (survival function), hazard ratio, etc. 

## Motivation
These methods are useful for scientific computing and ML (e.g. information-based methods). While they can obviously be derived from some of the basic methods (`cdf(x).log()`), those computations are often less accurate and frequently result in numerical issues. Other packages expose many of these already: 
Scipy: https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.norm.html#scipy.stats.norm
Jax: https://jax.readthedocs.io/en/latest/jax.scipy.html#module-jax.scipy.stats.norm
Tensorflow: https://www.tensorflow.org/probability/api_docs/python/tfp/distributions/Normal#log_cdf

## Pitch
Implement the most commonly used methods. `logcdf` and `logsf` would be a good start.  

## Alternatives
Use the base methods and somehow deal with numerical issues.


cc @fritzo @neerajprad @alicanb @vishwakftw @nikitaved
Repository: godot
Issue: Godot 4: No default environment
Labels: topic:rendering,topic:editor,documentation,topic:3d

**Godot version:**
godot-4-dev


**OS/device including version:**
Kubuntu, Vulkan. Graphics Card: RX 580X


**Issue description:**
When running the project, the window only displays objects, lights, etc. but not the environment.


**Steps to reproduce:**
1. Make a new project
2. Run said project

**Minimal reproduction project:**
[GodotTest.zip](https://github.com/godotengine/godot/files/6055038/GodotTest.zip)

If you have any questions, let me know and i will answer them.