sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: godot
Issue: Usability issues with AudioStreamPlayer3D attenuation model
Labels: enhancement,discussion,topic:editor,usability

From the few times I had to use `AudioStreamPlayer3D`, I faced several annoyances that I believe could get improvements, in particular with the attenuation model.

In frameworks and engines I used in the past, the attenuation model of a 3D sound has the following features:
- A minimum radius under which no attenuation is performed, in addition to the maximum radius above which the sound gets out of range
- Spheres are drawn in the 3D viewport to get an idea of the min/max distances
- Nice curves in the inspector showing how attenuation actually looks like over distance

On the other hand, in Godot:
- There is no minimum radius, and sound gets ALWAYS attenuated and muffled at any range, more or less. There is no way to decide "I want no low-pass attenuation within this distance, only start beyond it".
- There is no visualization of attenuation min/max radius in the main viewport
- There is no curves either, only numbers. Tweaking `Unit Size` to adapt the model to the distances in your game is counter-intuitive. For example it defaults to 1 (whatever that means), and all sounds get too muffled to my taste. I bumped it to 50 and it's still too muffled...
- There is no way to disable attenuation low-pass, other than forcing the cutoff frequency to 20500 Hz, which is also counter-intuitive.

Here are extra things that could enhance usability:
- When you get an attenuation model that suits you for one `AudioStreamPlayer3D`, you have to do it again for every single sound you want to play. A way to re-use models could be handy.
- Ability to have an attenuation-driven high-pass filter in addition to the low-pass filter. I came up with this need from experience, I've been creating audio series for a long time and when a character voice gets far from the "camera" it often sounds better when part of its low frequencies get cut off rather than its high frequencies (especially outside).
- From the same experience, I sometimes have to cross-fade two effect buses (one for `near`, one for `far`) for a sound that moves from near to really far away, but in Godot you can only output to one bus. How are we expected to do this without creating a bus for every sound? Do we always have to create two `AudioStreamPlayer3D` and play them both?
- On a stretch goal, Unity3D allows to configure the attenuation model very precisely, even allowing custom curves for each variable of the attenuation effect (volume, lowpass, highpass...). See https://docs.unity3d.com/Manual/class-AudioSource.html

I know some of this can be eventually scripted, but please at least give some consideration to the first part :)
Repository: opencv
Issue: HoughCircles: Unknown exception
Labels: priority: low,category: java bindings,incomplete,needs reproducer,needs investigation

I'm using [`4.0.0-beta`](https://opencv.org/releases.html) using the Java bindings. A user has reported the following exception when using the `HoughCircles` method:

```
Caused by: java.lang.Exception: unknown exception
	at org.opencv.imgproc.Imgproc.HoughCircles_0(Native Method)
	at org.opencv.imgproc.Imgproc.HoughCircles(Imgproc.java:1422)
        ...
```

This is the first and only time it happened so it's probably not reproducible since my code using Hough circles generally works:
```
public static Mat detectCircles(String imageFilePath, boolean showImage) throws InvocationTargetException, InterruptedException
{
	val sourceImage = imread(imageFilePath, IMREAD_COLOR);

	// Convert the image to gray
	val gray = new Mat();
	cvtColor(sourceImage, gray, COLOR_BGR2GRAY);

	// Apply a median blur to reduce noise and avoid false circle detection
	medianBlur(gray, gray, 5);

	val circles = getCircles(gray);
	drawRedCircles(sourceImage, circles);

	if (showImage)
	{
		invokeAndWait(() -> imshow("Detected Circles", sourceImage));
		waitKey();
	}

	return circles;
}

private static void drawRedCircles(Mat sourceImage, Mat circles)
{
	for (var columnIndex = 0; columnIndex < circles.cols(); columnIndex++)
	{
		val rectangles = circles.get(0, columnIndex);
		val center = new Point(round(rectangles[0]), round(rectangles[1]));

		// circle center
		circle(sourceImage, center, 1, new Scalar(0, 100, 100), 3, 8, 0);

		// circle outline
		val radius = (int) round(rectangles[2]);
		circle(sourceImage, center, radius, new Scalar(255, 0, 255), 3, 8, 0);
	}
}

private static Mat getCircles(Mat image)
{
	val circles = new Mat();
	HoughCircles(image, circles, HOUGH_GRADIENT, 1.0,
			(double) image.rows() / 16,
			100.0, 30.0, 10, 30);
	return circles;
}
```

The platform is `Windows 10 64-bit`.

Can someone tell me more about this issue and if it's a bug which could be fixed?
Thank you!
Repository: go
Issue: proposal: cmd/go: add module repository health check tool
Labels: Proposal,GoCommand,modules

<!-- Please answer these questions before submitting your issue. Thanks! -->

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version go1.11.1 linux/amd64
</pre>

### Does this issue reproduce with the latest release?

n/a

### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPROXY=""
GORACE=""
GOROOT="/home/myitcv/gos"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build925002674=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### Details

A number of issues and Slack and go-nuts questions boil down to a VCS repository being in some way "invalid" as far as modules are concerned. An incomplete list includes:

* `go.mod` for a `v >= 2` module not having a `/v2` suffix
* tags that are not semver compatible
* `go.mod` incomplete (i.e. the result of `go mod tidy` not committed)
* transitive dependencies leaking through to the main module because a dependency's `go.mod` is not complete
* Whether a version is compatible with Go pre 1.9.7 or 1.10.3
* ...

I think it might be useful to develop a tool that can be run against an arbitrary (remote) VCS repository that catches these sorts of problems, but also provides a summary of what is valid. A health check if you will. 

This would be a tool for authors as well as consumers, because indicating (perhaps via one of those GitHub README badges) that your repository is module-safe is a good state and signal. Indeed in time this might be something that would sit well on godoc.org/similar, but in the short term a command line tool would have significant value.

These checks could of course be heavily cached (somewhere central).

This is a very rough idea, so just posting for thoughts/feedback:

```
$ modanalyse https://github.com/myitcv/terrible
Results for https://github.com/myitcv/terrible:

Semver issues:
    0.0.1 is not compatible with Go modules; should be v0.0.1
    0.0.1alpha is not a valid pre-release

Module completeness:
    v0.0.3 is missing a go.sum
    v0.0.4 has an incomplete go.mod

Invalid releases:
    v2.0.0 invalid because go.mod does not end with /v2

Valid releases:
    v0.0.2
    v1.0.0
    v2.0.1
```

cc @rsc @bcmills @thepudds @rogpeppe @mvdan
Repository: go
Issue: proposal: spec: language: make slices of constant strings constant if the indexes are constant
Labels: LanguageChange,Proposal,LanguageChangeReview

This will probably be assigned a Go2 label, although I think that it could be done during Go 1.

Consider multiline string constants:

```go
const multiline = `
This is a long text
that spans multiple lines
and then ends.
`
```

If you feed this text to a parser and it finds a problem on the first line ("This is a long text"), it will actually report that the error is on the *second* line because of the leading newline. One might think that this is easily solved by slicing the string:

```go
const multiline = `
This is a long text
that spans multiple lines
and then ends.
`[1:]
```

But this won't compile. The [Spec](https://golang.org/ref/spec#Slice_expressions) currently says:

>(…) For untyped string operands the result is a non-constant value of type string. (…)

Why not make it constant? After all, `len(multiline)` is constant.

* * *

There are other solutions to this. One could just use `multiline[1:]` everywhere where one doesn't want the leading newline. Or start "This is a long text" on the first line, but that hurts readability and "editability". Another solution is to make `multiline` a variable. The use case is pretty obscure and there isn't an immediate need for this, so this proposal is more about a question, why are slices (and indexing!) of constant strings not constant in the first place?
Repository: vscode
Issue: [scss] rename not working for placeholder selectors
Labels: feature-request,css-less-scss

<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.28.2
- OS Version: Windows 10

## Note: this only happens for `.scss` file types, as `.sass` is not supported by VSCode without extensions.

Steps to Reproduce:

1. Place cursor over sass placeholder selector
2. Initiate "Rename Symbol" command (through command palette, keyboard shortcuts, etc.)
3. Attempt to rename

After completion, the text editor will have renamed the variable throughout the document but removed the leading percent sign in the process. Even this can be dealt with by including a leading percent sign while renaming, it should be considered an issue because when the user does not take the effort to work around this quirk, the behavior of the selector is changed.

Example:
```sass
%foo {
	...
}

.bar {
	@extends %foo;
}
```

Attempting to rename `foo` to `foobar` results with this:

```sass
foobar {
	...
}

.bar {
	@extends foobar;
}
```

Rather than expected:

```sass
%foobar {
	...
}

.bar {
	@extends %foobar;
}
```
Does this issue occur when all extensions are disabled?: Yes
Repository: TypeScript
Issue: Changing single-line JSDoc comments to multiline requires unnecessary edits
Labels: Suggestion,In Discussion,Domain: TSServer

<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:**  3.1.3

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** jsdoc multiline

**Code**

```ts
/** |Foo */
```
1. Press <kbd>Enter</kbd> at the |
```ts
/**
 * Foo |*/
```
2. Press <kbd>Enter</kbd> at the |

**Expected behavior:**
```ts
/**
 * Foo
 */
```
**Actual behavior:**
```ts
/**
 * Foo
 * */
```
The leading `* `&nbsp;has to be deleted now.

Empty JSDoc-Comments work:
```ts
/**| */
```
Press <kbd>Enter</kbd> at the |
```ts
/**
 *
 */
```
Repository: flutter
Issue: [google_maps_flutter] How to customize infoWindowText in marker
Labels: c: new feature,customer: crowd,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem

I'm making a google maps for my android apps with custom infoWindowText.
I want to change the color, border, or add an image in the infoWindowText.
please help me
Repository: react
Issue: useCallback() invalidates too often in practice
Labels: Component: Hooks,React Core Team

This is related to https://github.com/facebook/react/issues/14092, https://github.com/facebook/react/issues/14066, https://github.com/reactjs/rfcs/issues/83, and some other issues.

The problem is that we often want to avoid invalidating a callback (e.g. to preserve shallow equality below or to avoid re-subscriptions in the effects). But if it depends on props or state, it's likely it'll invalidate too often. See https://github.com/facebook/react/issues/14092#issuecomment-435907249 for current workarounds.

`useReducer` doesn't suffer from this because the reducer is evaluated directly in the render phase. @sebmarkbage had an idea about giving `useCallback` similar semantics but it'll likely require complex implementation work. Seems like we'd have to do _something_ like this though.

I'm filing this just to acknowledge the issue exists, and to track further work on this.
Repository: godot
Issue: File browser type icon should be bigger on files that do not support a preview
Labels: enhancement,topic:editor,usability

**Godot version:**
3.1 alpha


**Issue description:**
The type icon for the files in the inspector is generally small. This is good for files that support a preview ( scripts, tscn, models) but for other type of files (saved animations) it is very small and requires more effort to be seen

**Proposal:**
When a file format does not support a preview, make the file type icon big and in the middle of the file icon.
![image](https://user-images.githubusercontent.com/7917475/48008768-96311b00-e11a-11e8-9370-f937da73e476.png)
Repository: go
Issue: cmd/compile: can't break on inlined function
Labels: NeedsInvestigation,compiler/runtime

### What version of Go are you using (`go version`)?

<pre>
$ go version
go version devel +e72595ee0f Mon Nov 5 19:10:33 2018 +0000 linux/amd64
</pre>
(latest master)

### Does this issue reproduce with the latest release?
Yes.


### What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/austin/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/austin/r/go"
GOPROXY=""
GORACE=""
GOROOT="/home/austin/go.dev"
GOTMPDIR=""
GOTOOLDIR="/home/austin/go.dev/pkg/tool/linux_amd64"
GCCGO="/usr/bin/gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build704555549=/tmp/go-build -gno-record-gcc-switches"
</pre></details>

### What did you do?
Attempt to set a breakpoint on an inlined function.

E.g., paste https://play.golang.org/p/rDXmoTUZKJb in to `bp.go` and run

```sh
go build bp.go
gdb ./bp
(gdb) br 'main.f'
Function "main.f" not defined.
(gdb) br 'main.main'
Breakpoint 1 at 0x455660: file /home/austin/go.dev/austin/bp.go, line 5.
```


### What did you expect to see?
I expected to be able to set a breakpoint on `main.f` like I could on `main.main`. In C/C++, this would cause gdb to set a breakpoint on every location the function was inlined to.


### What did you see instead?
`main.f` is completely missing from the debug info, so GDB is unable to set the breakpoint.


/cc @randall77 @thanm
Repository: TypeScript
Issue: Report `noImplicitThis` errors as suggestions when `noImplicitThis` is off
Labels: Suggestion,Committed,Domain: Error Messages

Title. Inspired by [this comment.](https://github.com/Microsoft/TypeScript/pull/28299#discussion_r230537698)
Repository: flutter
Issue: Support creation of add-to-app modules in Swift
Labels: platform-ios,tool,a: existing-apps,P3,team-ios,triaged-ios

`flutter create -t module` templates are missing the following:

- [x] The profile build configuration has an incorrect unique identifier reference to `Release.xcconfig` - copy paste issue.
- [ ] Swift language support.  The templates currently only create ObjC variants, even if `-i swift` is passed on the command line.  This is important when invoking the `make-host-app-editable` workflow.

/cc @matthew-carroll  @mit-mit @xster
Repository: scrcpy
Issue: Ctrl+Key shortcuts not working (Linux)
Labels: input events,shortcuts

Just built from scrcpy-9999.ebuild. Ctrl+Key shortcuts not working, instead it acting like plain key is pressed (i.e. `Ctrl+V` entering **v** letter in input field).
Repository: angular
Issue: ActivatedRoute data loaded from other route when using same component for multiple lazy routes
Labels: type: bug/fix,freq2: medium,area: router,state: confirmed,router: lazy loading,router: guards/resolvers,P3

# 🐞 bug report

### Affected Package
This issue happens with latest @angular/angular

### Is this a regression?

No

### Description

When I use the same component in multiple lazy-loaded routes, the `data` is loaded from the wrong route definition. Please see the stackblitz.

## 🔬 Minimal Reproduction
https://stackblitz.com/edit/angular-issue-repro2-iiuvra?file=src%2Findex.html

## 🌍  Your Environment

**Angular Version:**
<pre><code>
Angular CLI: 7.0.4
Node: 8.12.0
OS: linux x64
Angular: 7.0.2
... animations, cdk, common, compiler, compiler-cli, core, forms
... http, language-service, material, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.10.4
@angular-devkit/build-angular     0.10.4
@angular-devkit/build-optimizer   0.10.4
@angular-devkit/build-webpack     0.10.4
@angular-devkit/core              7.0.4
@angular-devkit/schematics        7.0.4
@angular/cli                      7.0.4
@ngtools/webpack                  7.0.4
@schematics/angular               7.0.4
@schematics/update                0.10.4
rxjs                              6.3.3
typescript                        3.1.6
webpack                           4.19.1
</code></pre>

**Anything else relevant?**

This also happens if I define `data` only on the second route, so the `data` returned is empty (`{}`)

[ActivatedRoute docs](https://angular.io/api/router/ActivatedRoute) says:

> Property | Description
> -- | --
> data: Observable<Data> | An observable of the static and resolved data of this route.

In my understanding, the `data` is for the current route, not for any other routes.
Repository: kubernetes
Issue: Allow forcing a put even when metadata.resourceVersion mismatches
Labels: sig/api-machinery,lifecycle/frozen

atm when the resourceVersion mismatches kubectl pulls the latest and then retries, which is pointless since it just does the same request after
our usecase is similar, using the api to PUT the expected state, not caring for what the cluster thinks it is ... but we still get `metadata.resourceVersion: Invalid value` errors which is annoying and means we have to do a round-trip to get the latest version which might fail again if someone else updated the resource

... so support `?force=true` or `?noResourceVersion` to disable this
Repository: TypeScript
Issue: React function-returning-component regression
Labels: Bug,Domain: JSX/TSX

**TypeScript Version:**  3.2.0-dev.20181103

**Code**

```ts
import React = require("react");
declare function F(): C;
class C extends React.Component<{ title?: string }> {}
<F title="My Title" />
```

**Expected behavior:**

No error, as in ts3.1.

**Actual behavior:**

```
src/a.tsx:4:2 - error TS2322: Type '{ title: string; }' is not assignable to type 'IntrinsicAttributes'.
  Property 'title' does not exist on type 'IntrinsicAttributes'.

4 <F title="My Title" />
   ~


Found 1 error.
```

Discovered in `react-helmet/v4` and `react-flag-icon-css` on DefinitelyTyped. The `react-flag-icon-css` variation is more like:
```ts
import React = require("react");
declare class C extends React.PureComponent<{}> {}
declare const F: (props: {}) => C;
<C />; // OK
<F />; // Error
```
Repository: TypeScript
Issue: [1.28.2] Refactor renaming class-method not renaming bind(this) assignments (Javascript)
Labels: Bug,Domain: Refactorings

- VSCode Version: 1.28.2
- OS Version: Windows 10

Steps to Reproduce:
![bind-this-binding-rename-issue](https://user-images.githubusercontent.com/3089978/47986550-631c6680-e0dd-11e8-91ea-2185f9a482b0.gif)

1. Refactor-rename class method (by hitting F2 to rename)
2. VS Code has not renamed the first methodname in this format:
`this.method = this.method.bind(this);`

Does this issue occur when all extensions are disabled?: Yes
Repository: TypeScript
Issue: TypeScript doesn't allow event : CustomEvent in addEventListener
Labels: Domain: lib.d.ts,Needs Investigation

I'm using Visual Studio Code - Insiders v 1.29.0-insider

In my TypeScript project, I'm trying to write the following code:

    buttonEl.addEventListener( 'myCustomEvent', ( event : CustomEvent ) => {
      //do something
    } );

The problem is that the CustomEvent type gives me the error shown below.  If I replace CustomEvent with Event, then there is no error, but then I have difficulty getting event.detail out of the event listener.

	"resource": "/c:/Users/me/Documents/app/file.ts",
	"owner": "typescript",
	"code": "2345",
	"severity": 8,
	"message": "Argument of type '(event: CustomEvent<any>) => void' is not assignable to parameter of type 'EventListenerOrEventListenerObject'.\n  Type '(event: CustomEvent<any>) => void' is not assignable to type 'EventListener'.\n    Types of parameters 'event' and 'evt' are incompatible.\n      Type 'Event' is not assignable to type 'CustomEvent<any>'.\n        Property 'detail' is missing in type 'Event'.",
	"source": "ts",
	"startLineNumber": 86,
	"startColumn": 44,
	"endLineNumber": 86,
	"endColumn": 72
}
Repository: TypeScript
Issue: The 'Convert to ES6 Module' in the TS language support has an aftereffect.
Labels: Suggestion,Awaiting More Feedback

Issue Type: <b>Bug</b>

I chose the IntelliSense 'Convert to ES6 Module' at the import statement, then I generated it, but failed. If I don't convert, it runs fine. I think the convert of IntelliSense should be equivalent, at least the result should not cause a error.

```javascript
var commandExists = require("command-exists").sync
console.log(commandExists('C://MinGW//bin//g++.exe'))
```


VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.17134

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 x 2195)|
|GPU Status|2d_canvas: enabled<br>checker_imaging: disabled_off<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: disabled_software<br>rasterization: enabled<br>video_decode: enabled<br>video_encode: enabled<br>webgl: enabled<br>webgl2: enabled|
|Memory (System)|3.92GB (0.59GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|

</details>Extensions: none
<!-- generated by issue reporter -->
Repository: TypeScript
Issue: Error message on JSX in .ts file should suggest using .tsx
Labels: Suggestion,Domain: Error Messages,Experience Enhancement

**TypeScript Version:**  3.2.0-dev.20181103

**Code**

```ts
<div></div>;
```

**Expected behavior:**

Error message tells me to change the file extension to `.tsx`.

**Actual behavior:**

Error message says `Cannot find name 'div'.`, which makes me think I have to install `@types/div` or something.
Repository: flutter
Issue: Can't determine the location of a long/double tap
Labels: c: new feature,framework,f: gestures,c: proposal,P2,team-framework,triaged-framework

If a `DoubleTapGestureRecognizer` won in the gesture arena, there's no equivalent of a forced flushing of a `onTapDown` like for `TapGestureRecognizer` to get the location of the double tap.

Similarly, `LongPressGestureRecognizer`'s `onLongPressUp` doesn't provide a location like `TapGestureRecognizer.onTapUp`