sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: go
Issue: image/jpeg: encoding with RGB profile causing loss of image saturation
Labels: NeedsInvestigation

Please answer these questions before submitting your issue. Thanks!

### What version of Go are you using (`go version`)?
1.9.2

### Does this issue reproduce with the latest release?
yes

### What operating system and processor architecture are you using (`go env`)?
windows 10

### What did you do?
I encoding a JPEG file with RGB profile, some how the encoding result look like not correct, I using gimp and it compress correctly, the output result show a bit darker then the original image.

here the [code ](https://play.golang.org/p/duRhfwmMl3t) from go playground

Original image

![de5639288c6fdd52367180fdcbd7a79672dbdf1d84e11bf2a497114397070bbb](https://user-images.githubusercontent.com/174617/36415709-cbacf7c4-1661-11e8-8a5a-8f26ce8228b3.jpg)

After encode

![out](https://user-images.githubusercontent.com/174617/36415971-ae875530-1662-11e8-841d-b400ab547558.jpg)

The images diff

![download](https://user-images.githubusercontent.com/174617/36415159-cc2fc6ec-165f-11e8-9867-448b42c7815e.png)




### What did you expect to see?

![berry_gimp](https://user-images.githubusercontent.com/174617/36414977-2ced2480-165f-11e8-81e2-94ad1cbea29b.jpg)

### What did you see instead?

![lanczos3](https://user-images.githubusercontent.com/174617/36414995-394e12fc-165f-11e8-80f9-be90c1af2dc5.jpg)
Repository: flutter
Issue: Camera plugin should use FLT prefix for all Objective-C types
Labels: platform-ios,p: camera,package,good first issue,P3,team-ios,triaged-ios

The main `CameraPlugin` type has no prefix (possibly others too). ~To make that work with Flutter tooling, an `iosPrefix` clause must be added to the `pubspec.yaml` file~:
```yaml
flutter:
  plugin:
    androidPackage: io.flutter.plugins.camera
    iosPrefix: FLT
    pluginClass: CameraPlugin
```

Edit: For current versions, the `pubspec.yaml` change is just to change `CameraPlugin` to `FLTCameraPlugin`.
Repository: vscode
Issue: [theming] customize file icons in settings
Labels: feature-request,themes

<!-- Do you have a question? Please ask it on https://stackoverflow.com/questions/tagged/vscode. -->

<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: all
- OS Version: all

Can't there be a quick way to customize file extension icon instead of having to create a whole extension for a custom theme as explained here https://github.com/Microsoft/vscode/issues/10804?

It's really daunting to have to learn the whole system of extension just for this tiny need. 

<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No
Repository: go
Issue: os: TestChtimes failure on OSX with Go 1.10: AccessTime didn't go backwards
Labels: help wanted,OS-Darwin,NeedsInvestigation

Please answer these questions before submitting your issue. Thanks!


### What version of Go are you using (`go version`)?
`go version go1.10 darwin/amd64`

### Does this issue reproduce with the latest release?
Yes

### What operating system and processor architecture are you using (`go env`)?
```GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/me/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/me/go"
GORACE=""
GOROOT="/Users/me/opt/go"
GOTMPDIR=""
GOTOOLDIR="/Users/me/opt/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/cf/y_tt0zms6nx39x08k23y5zsr0000gn/T/go-build648291915=/tmp/go-build -gno-record-gcc-switches -fno-common"
```

### What did you do?
`$ GOROOT_BOOTSTRAP=~/opt/go-bootstrap ./all.bash`

### What did you expect to see?
(tests pass)

### What did you see instead?
```
--- FAIL: TestChtimes (0.00s)
        os_test.go:1200: AccessTime didn't go backwards; was=2018-02-20 14:13:29.321904999 +0200 EET, after=2018-02-20 14:13:29.322166175 +0200 EET
FAIL
FAIL    os      0.759s
```
Repository: TypeScript
Issue: Tagged union types aren't narrowed in for/while loop
Labels: Bug

**TypeScript Version:**  2.7.0-dev.20180220

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** 

**Code**

```ts
const enum Types {
  Array,
  Node,
}
declare const obj:
  | { type: Types.Array, value: never[], }
  | { type: Types.Node, value: {}, };
for (; ;) {
  switch (obj.type) {
    case Types.Node:
      void obj.value;
      break;
    case Types.Array:
      void obj.value.push;
      break;
  }
}
```

These work correctly.

```ts
const enum Types {
  Array,
  Node,
}
declare const obj:
  | { type: Types.Array, value: never[], }
  | { type: Types.Node, value: {}, };
for (; ;) {
  switch (obj.type) {
    case Types.Node:
      void obj.value;
      break;
    case Types.Array:
      void obj.value.push;
      break;
  }
}
```

```ts
const enum Types {
  Array,
  Node,
}
declare const obj:
  | { type: Types.Array, value: never[], }
  | { type: Types.Node, value: {}, };
switch (obj.type) {
    case Types.Node:
      void obj.value;
      break;
    case Types.Array:
      void obj.value.push;
      break;
}
```

**Expected behavior:**

pass

**Actual behavior:**

`obj.value` type in the second case-clause is `{}` but popup type info is `never[]`.

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> 

**Related Issues:**
Repository: rust
Issue: Slower performance caused only by using LTO
Labels: I-slow,C-enhancement,T-compiler

[The Computer Language Benchmarks Game](https://benchmarksgame.alioth.debian.org/) was on the Rust subreddit recently and while I checked out the numbers for Rust, I noticed that the Rust solution for the [fasta benchmark](https://benchmarksgame.alioth.debian.org/u64q/fasta.html) is much slower than the C version, although they work fairly similarly, the multithreading in the C version is based on the Rust version. It turned out that the Rust benchmarks are compiled with LTO by default, and when I tested the code on my machine without LTO (both stable and nightly), it was almost as fast as the C version. I tried to find an existing issue, but most of them are about slow compilation, not slow runtime.

The interesting thing is that on the CPU monitor graph it's clearly visible that during the last part of the benchmark all CPU cores are only on 70% usage (so it's like a mutex is locked for too long). I also checked the binary size, it went down from 4.4 MB to 3.1 MB with LTO.

EDIT: I also tested it with the Mutex from `parking_lot`, it's still slow with LTO, but without it's a tiny bit faster than the C version.
Repository: godot
Issue: Pressing any accent before Escape makes Escape fire two "pressed" events
Labels: bug,platform:windows,confirmed,topic:input

**Godot version:**
tested in 3.0 stable and 2.1.4 stable


**OS/device including version:**
Windows 10 64bit (desktop build), including Fall Creators' Update


**Issue description:**
While listening for input, when you press the Circumflex accent before pressing Escape, you'll get two key press events for the Escape key, both as InputEvents and as Actions.
Pressing other keys like Space or A after Circumflex does not exhibit that behaviour.

This is a mild inconvenience on German keyboards and possibly others, where the Circumflex key is located below Escape (sometimes directly, like on this here Laptop).

Also happens with other accent keys like accent acute or accent grave (the tick / backtick characters), although these are in a different spot so it's less easy to fat-finger them.

Debug print from Godot 2:

> Circumflex + ESC
> Device 0 ID 722 Event: Key Unicode:  Scan: 92 Echo: False PressedTrue Mod:
> Device 0 ID 723 Event: Key Unicode:  Scan: 92 Echo: False PressedFalse Mod:
> Device 0 ID 726 Event: Key Unicode: ^ Scan: 16777217 Echo: False PressedTrue Mod:
> Device 0 ID 727 Event: Key Unicode:  Scan: 16777217 Echo: False PressedTrue Mod:
> Device 0 ID 728 Event: Key Unicode:  Scan: 16777217 Echo: False PressedFalse Mod:
> 
> Circumflex + A:
> Device 0 ID 774 Event: Key Unicode:  Scan: 92 Echo: False PressedTrue Mod:
> Device 0 ID 775 Event: Key Unicode:  Scan: 92 Echo: False PressedFalse Mod:
> Device 0 ID 777 Event: Key Unicode: â Scan: 65 Echo: False PressedTrue Mod:
> Device 0 ID 778 Event: Key Unicode:  Scan: 65 Echo: False PressedFalse Mod:

The attached minimal project shows the behaviour in Godot 3 using var2str on the event; circumflex produces 2 events, the Escape key again produces 3.

The workaround on my end will be to discard Escape key events with the Circumflex char in their unicode property, will have to see if using actions still remains functional or if I'll have to rely on InputEventKey.


**Steps to reproduce:**
- any Node must have an _input(event) function
- with the default keybindings, Escape is bound to the action "ui_cancel"
- have _input react to either event.is_action_pressed("ui_cancel") or check for InputEventKey and the correct Scancode, then for example print anything to the console
- press circumflex, then escape
- the print will happen twice; if you print the key events, you'll get 2 for the accent and 3 for escape


**Minimal reproduction project:**
[Circumflex.zip](https://github.com/godotengine/godot/files/1740551/Circumflex.zip)
Repository: vscode
Issue: When A grammar injects to B, grammars embedding B should get A's injection
Labels: feature-request,grammar

A real world example: https://github.com/vuejs/vetur/issues/701

GraphQL is injecting to `source.js`.
Vetur is embedding `source.js`.

However the Vue grammar is not getting any injections from GraphQL.
Repository: go
Issue: cmd/compile: use runtime.zeroVal for small zero-valued readonly static vars
Labels: Performance,compiler/runtime

Split out from #23929. No reason to have lots of different zero-valued readonly symbols when we can re-use runtime.zeroVal.
Repository: TypeScript
Issue: this any typed in some JS object literals 
Labels: Bug,VS Code Tracked,Domain: JavaScript,Has Repro

From https://github.com/Microsoft/vscode/issues/43930

**TypeScript Version:**  2.8.0.insiders-20180211

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** 
- this
- object literal

**Code**
For the js:
 
```js
console.log({
    a: 1,
    b() {
        this
  }
});
```

Hover over `this` in `b`

**Bug**
`this` has `any` type

`this` is properly typed in cases like:

```js
const z = {
    a: 1,
    b() {
        this
  }
}
```

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> 

**Related Issues:**
- https://github.com/Microsoft/TypeScript/issues/11072
Repository: TypeScript
Issue: Suggestion: Type annotations and interfaces for function declarations
Labels: Suggestion,In Discussion,Has Repro

Currently in TypeScript, function declarations cannot be typed in the same way as function expressions, e.g. this function can implement the `React.FC` interface:

    interface TestProps {
        message: string
    }

    const Test: React.FC<TestProps> = ({ message }) => {
        return <div>{message}</div>
    }

But this function can't, at least not directly:

    function Test({ message }: TestProps) {
        return <div>{message}</div>
    }

This becomes more of an issue if you try to add properties to the function object:

    Test.defaultProps = {
        message: 'hi'
    }

It seems that currently the only way to specify the type for the function object in the second example is to create a new variable:

    const AliasForTest: React.FC<TestProps> = Test
    AliasForTest.defaultProps = {
        message: 'hi'
    }

This seems like kind of an ugly workaround, so it seems that the current idiom is to just prefer arrow functions for cases like this. But this leads to inconsistency on teams that generally prefer function declarations over const expressions for top-level functions. Personally I find it more readable to see the word "function" for top-level functions rather than seeing "const", which is generally already all over the place in the code. There is even an ESLint rule for teams that share my preference (although I don't think it's been ported to TSLint yet): https://eslint.org/docs/rules/func-style. In any case, I have seen others express similar views and other codebases (including some from Facebook and Apollo, for example) that still prefer the "function" keyword for top-level functions.

However, stylistically it's also a problem if top-level functions are declared some places as declarations (using `function`) and in other places as expressions (using `const`). But for those who desire consistency, TypeScript is basically forcing the use of expressions, due to the issues described above.

This is far from being a top priority of course, but I was surprised to see that TypeScript didn't provide some equivalent typing syntax for function declarations. It would be great if this could be considered for a future version (even if far in the future). Thanks for reading!
Repository: rust
Issue: rustdoc: Strip empty line(s) above and/or below hidden code in Rust code blocks
Labels: T-rustdoc,C-feature-request,A-rustdoc-ui,T-rustdoc-frontend

Consider the following code:

```rs
//! Top-level documentation.
//!
//! ```rust
//! // ... some Rust code ...
//!
//! # // ... hidden boilerplate-y Rust code ...
//!
//! // ... some Rust code ...
//! ```
```

Currently (last checked: 2024), rustdoc renders two empty lines in between the first & the last comment (quite reasonably so). However, it might be nice to essentially collapse them into a single line since the author likely didn't intend to have extra lines in the rendered output but only in the *source code* for legibility (since there the `#`-prefixed code is obviously visible).

The "workaround" / user fix for this is to manually hide the "blank" lines with `#`:

```rs
//! Top-level documentation.
//!
//! ```rust
//! // ... some Rust code ...
//! #
//! # // ... hidden boilerplate-y Rust code ...
//!
//! // ... some Rust code ...
//! ```
```

An argument could be made that this is less "esthetically pleasing" and a bit annoying.

<details><summary>Original issue description from 2018 for context</summary>

Basically, I want:

```text
rust code

# secret boilerplatey rust code

more rust code
```

to render the same as:

```text
rust code
#
# secret boilerplatey rust code

more rust code
```

</details>
Repository: go
Issue: x/build/cmd/gerritbot: Gerrit Bot should not be the owner of all imported changes
Labels: Builders,NeedsFix

Gerrit bug: https://bugs.chromium.org/p/gerrit/issues/detail?id=8296
Repository: godot
Issue: C# CallDeferred() won't take function names in pascal case
Labels: enhancement,topic:dotnet

**Godot version:**
3.0

**Issue description:**
<!-- What happened, and what was expected. -->
CallDeferred doesn't accept the pascal case method name in C#.
While using C# scripting you must pass in the 'snake case' function name same as GDScript.
I think that this causes confusion when all other names are changed to pascal case in C#.
It caused me quite a bit of confusion. Perhaps if it is not an issue changing the function could throw an error if the function name passed in is not recognized?

**Steps to reproduce:**
call CallDeferred and pass in a function name in pascal case e.g. "AddChild" and watch it not work.
Repository: flutter
Issue: FadeInImage support for crossfading between images
Labels: c: new feature,framework,a: animation,P3,team-framework,triaged-framework

Right now it is only possible to have a FadeInImage fade out to white and then fade in to the desired loaded image. It would be great if I can just crossfade between them if I wanted to.

https://material.io/guidelines/patterns/loading-images.html#loading-images-usage

Material guidelines state that the images can also transition.
Repository: pytorch
Issue: TestMultiprocessing.test_fd_sharing hangs with ASAN
Labels: module: tests,triaged

Sample build https://ci.pytorch.org/jenkins/job/pytorch-builds/job/pytorch-linux-xenial-cuda9-cudnn7-py3-test/3486/console

cc @mruberry @VitalyFedyunin
Repository: neovim
Issue: API: Ability to set the size of the editable area
Labels: enhancement,api,ui,ui-extensibility

How can a client set a Neovim's instance editable area to 80 columns and 40 rows excluding the sign column, numbers column, etc?
In the process of developing the Qt Creator client I need to set Neovim's editable area as exact same size as of Qt Creator's editable area. Qt Creator has its own number/sign/fold column and its size is not to be the same as Neovim's. I need to set the size of the editable area in order to make `wrap`ing lines work the same in Neovim and QtCreator (aka `gj` and `gk` work correctly.)
I couldn't find a way to set this size, I even asked it here: https://vi.stackexchange.com/questions/15269/how-to-set-get-size-of-editable-area-in-a-neovim-client
How can I achieve this?
Repository: vue
Issue: extended components fall back to global component definition. (instead of local one in "super/parent")
Labels: improvement

### Version
2.5.13

### Reproduction link
[https://codepen.io/dasdeck/pen/NyMvjQ](https://codepen.io/dasdeck/pen/NyMvjQ)

### Steps to reproduce
The codepen shows the bug on opening.

### What is expected?
I'd expect "extComp" to behave exactly like "baseComp" since it is extended.

### What is actually happening?
"extComp" uses the global "my-comp" definition instead of the one in the super/parent component

---
This might be expected/intended behavior, however, all people I asked agree that this is counter intuitive and feels more like a bug than a feature.

Cheer!

JM

<!-- generated by vue-issues. DO NOT REMOVE -->
Repository: vscode
Issue: [json] schema fileMatch for all *.json files in root folder
Labels: help wanted,feature-request,json

- VSCode Version: 1.20.1
- OS Version: Win 10
Does this issue occur when all extensions are disabled?: Yes

I've tried asking this on stackoverflow and gitter without success. I have a project with (among other things) lots of .json files. This is the `.vscode/settings.json` file:

``` json
{
    "json.schemas": [
        {
            "fileMatch": [
                "*.json"
            ],
            "url": "https://path/to/schema.json"
        }
    ]
}
```

The problem is that this matches all .json files in the project, but I need it to match **only \*.json files in the root directory**. What can I put in `fileMatch` to enable this, or can this not be done with the file matching?
Repository: kubernetes
Issue: kubectl cp fails on large files 
Labels: kind/bug,sig/node,sig/cli,triage/accepted

<!-- This form is for bug reports and feature requests ONLY! 

If you're looking for help check [Stack Overflow](https://stackoverflow.com/questions/tagged/kubernetes) and the [troubleshooting guide](https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/).
-->

**Is this a BUG REPORT or FEATURE REQUEST?**:

/kind bug

**What happened**:
Copying either a large file, or a large directory from a container via `kubectl cp` results in the error of `error: unexpected EOF` and a failure to transfer.  In my case, the file is 1.7G.

I executed the following command

```bash
kubectl cp infra-cassandra-global-0:cassandra.tar.gz infra-cassandra-global-0-cassandra.tar.gz
```

The command executes, however the terminal will print the error below after 10-14 seconds of execution, and no file is copied. 

```bash
error: unexpected EOF
```


**What you expected to happen**:

The large file to be downloaded from the container.

**How to reproduce it (as minimally and precisely as possible)**:

Add a large file >= 1.7G to any location in the pod.  I was able to re-create this will the file on a PV, or locally on the image file system. 

Execute `kubectl cp` to download the large file.  It will fail.

**Anything else we need to know?**:

**Environment**:
- Kubernetes version (use `kubectl version`): v1.8.6, client v1.8.5
- Cloud provider or hardware configuration: AWS
- OS (e.g. from /etc/os-release): k8s-1.8-debian-jessie-amd64-hvm-ebs-2017-12-02 (ami-06a57e7e)
- Kernel (e.g. `uname -a`):
- Install tools: Kops
- Others:
Repository: three.js
Issue: VTKLoader: Add support for more dataset format
Labels: Enhancement,Loaders

I would like to ask for advice because of I have one use case where I need to load VTK file which is a BINARY DATASET STRUCTURED POINTS, which represents a segmented image.
```
# vtk DataFile Version 3.0
VTK File Generated by Insight Segmentation and Registration Toolkit (ITK)
BINARY
DATASET STRUCTURED_POINTS
DIMENSIONS 1040 1040 1
SPACING 2.6455026988983699e-01 2.6455026988983699e-01 1.0000000000000000e+00
ORIGIN 0.0000000000000000e+00 0.0000000000000000e+00 0.0000000000000000e+00
POINT_DATA 1081600
SCALARS scalars unsigned_short 1
LOOKUP_TABLE default

Binary data
```
Thank you for your help.
Repository: rust
Issue: parser: modulesubpath defined with path macro needs to replace pathseperator to the default pathseperator
Labels: C-enhancement,A-diagnostics,A-parser,T-compiler

When trying out rustfmt on windows I got an error on my code that compiles. I have defined cross platform modules as such:
```
#[cfg(target_os = "linux")]
#[path = "proxyimpl/linux.rs"]
pub mod proxyimpl;
#[cfg(not(target_os = "linux"))]
#[path = "proxyimpl/nonlinux.rs"]
pub mod proxyimpl;
```

When running rustfmt on windows I get the following error
```
rustfmt .\main.rs
error: couldn't read "\\\\?\\C:\\Users\\<snip>\\Source\\irondragon\\src\\gpioaccess\\proxyimpl/linux.rs": The filename, directory name, or volume label syntax is incorrect. (os error 123)
  --> \\?\C:\Users\<snip>\Source\irondragon\src\gpioaccess\mod.rs:68:9
   |
68 | pub mod proxyimpl;
   |         ^^^^^^^^^

thread 'main' panicked at 'Box<Any>', src\libsyntax\parse\mod.rs:215:29
stack backtrace:
   0: <std::sync::condvar::WaitTimeoutResult as core::fmt::Debug>::fmt
   1: <std::time::SystemTimeError as core::fmt::Display>::fmt
   2: std::panicking::Location::column
   3: std::panicking::Location::column
   4: std::panicking::rust_panic_with_hook
   5: <syntax::ext::tt::macro_rules::TokenSet as core::fmt::Debug>::fmt
   6: syntax::parse::new_parser_from_tts
   7: syntax::parse::parser::Parser::default_submod_path
   8: syntax::parse::parser::Parser::parse_item
   9: syntax::parse::parser::Parser::parse_visibility
  10: syntax::parse::parser::Parser::default_submod_path
  11: syntax::parse::parser::Parser::parse_item
  12: syntax::parse::parser::Parser::parse_visibility
  13: syntax::parse::parser::Parser::parse_crate_mod
  14: <unknown>
  15: <unknown>
  16: <unknown>
  17: <unknown>
  18: <unknown>
  19: std::panicking::update_panic_count
  20: _rust_maybe_catch_panic
  21: std::rt::lang_start_internal
  22: <unknown>
  23: <unknown>
  24: BaseThreadInitThunk
```

Changing it to 
```
#[cfg(target_os = "linux")]
#[path = "proxyimpl\\linux.rs"]
pub mod proxyimpl;
#[cfg(not(target_os = "linux"))]
#[path = "proxyimpl\\nonlinux.rs"]
pub mod proxyimpl;
```
I can run rustfmt on windows, but my travisci build (linux) fails.
Repository: go
Issue: x/build: run ssacheck mode for all architectures, not just amd64
Labels: help wanted,Builders

We have an amd64 ssacheck builder. That builder should compile std+cmd for all architectures, not just native. That would have prevented or at least caught #24014.