sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: opencv
Issue: Fixed outlier ratio in LMeDS estimation
Labels: feature,category: calib3d,future

<!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).

This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->

##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->

- OpenCV => master


##### Detailed description
[class LMeDSPointSetRegistrator][1] uses
a fixed outlier ratio to determine the maximum
number of iterations required, see the code [here][2]

```.cpp
const double outlierRatio = 0.45;
```

Why `0.45` is chosen? Should it be passed as a parameter?

[2]: https://github.com/opencv/opencv/blob/master/modules/calib3d/src/ptsetreg.cpp#L279
[1]: https://github.com/opencv/opencv/blob/master/modules/calib3d/src/ptsetreg.cpp#L270

<!-- your description -->



<!-- to add code example fence it with triple backticks and optional file extension
    ```.cpp
    // C++ code example
    ```
 or attach as .txt or .zip file
-->
Repository: create-react-app
Issue: Option not to include hash to file names
Labels: issue: proposal

First of all thanks for this tool! It was really helpful for me to get started. I read all available how-to's and materials and really understand the purpose of this tool BUT... If this app is agnostic of the backend, and just produces static HTML/JS/CSS bundles there should be an option to leave filenames as is, as some ECM/CMS and other host systems has their own caching/versioning realization. Having different file names after each build mean need for manually deal with file published previously.
Repository: go
Issue: x/perf/cmd/benchstat: tips or quickstart for newcomers
Labels: Documentation,NeedsInvestigation

`benchstat` is a very useful tool, but if you're not familiar with what it does, it can be very confusing to use for the first time.

One such example is "how many times should my benchmarks run". If one has used `benchcmp` before, running each benchmark before and after exactly once, trying to use `benchstat` will result in something confusing like:

```
name                old time/op    new time/op    delta
Decode-4               2.20s ± 0%     1.54s ± 0%   ~     (p=1.000 n=1+1)
```

The answer here is that the user should be running the benchmark more times - at least 3 or 4 to get p-values low enough for a result.

However, neither `benchstat -h` nor the godoc page are very clear on this, nor do they have a "quickstart" guide. The godoc page does show an example input with many runs, and does talk about "a number of runs" and p-values, but it's not very clear if you're not familiar with statistics and benchmarking.

I believe that a quick guide would greatly improve the usability of the tool - for example:

```
$ go test -bench=. -count 5 >old.txt
$ <apply source changes>
$ go test -bench=. -count 5 >new.txt
$ benchstat old.txt new.txt
```

I think it should also introduce other best practices, such as:

* Using higher `-count` values if the benchmark numbers aren't stable
* Usingn `-benchmem` to also get stats on allocated objects and space
* Running the benchmarks on an idle machine not running on battery (and with power management off?)
* Adding `-run='$^'` or `-run=-` to each `go test` command to avoid running the tests too

I realise that some of these tips are more about benchmarking than `benchstat` itself. But I think it's fine to have it all there, as in general you're going to be using that tool anyway.

/cc @rsc @ALTree @aclements @AlekSi
Repository: rust
Issue: Type inference do not take bounds from `impl` into account
Labels: C-enhancement,T-lang,T-compiler,A-inference

In the example below I get the following error.

```
error[E0284]: type annotations required: cannot resolve `<_ as Stream>::Item == char`
  --> src/main.rs:60:49
   |
60 |     let _: (char, &str) = satisfy(|c| c != 'a').map(|c| c).parse("").unwrap();
   |                                                 ^^^
   |
   = note: required because of the requirements on the impl of `Parser<_>` for `Satisfy<[closure@src/main.rs:60:35: 60:47]>`
```

Perhaps this is intended but I couldn't find anything stating that, feel free to close if that is the case.

```rust

#[derive(Clone)]
pub struct Satisfy<P> {
    predicate: P,
}

trait Stream {
    type Item;
}

impl<I, P> Parser<I> for Satisfy<P>
where
    I: Stream,
    P: FnMut(I::Item) -> bool,
{
    type Output = I::Item;
}

pub fn satisfy<P, C>(predicate: P) -> Satisfy<P>
where
    P: FnMut(C) -> bool,
{
    Satisfy { predicate }
}

pub struct Map<P, F>(P, F);
impl<I, B, P, F> Parser<I> for Map<P, F>
where
    I: Stream,
    P: Parser<I>,
    F: FnMut(P::Output) -> B,
{
    type Output = B;
}

impl<'a> Stream for &'a str {
    type Item = char;
}

pub trait Parser<Input>
where
    Input: Stream,
{
    type Output;

    fn parse(&mut self, input: Input) -> Result<(Self::Output, Input), ()> {
        unimplemented!()
    }

    fn map<F, B>(self, f: F) -> Map<Self, F>
    where
        F: FnMut(Self::Output) -> B,
        Self: Sized,
    {
        Map(self, f)
    }
}

fn main() {
    let _: (char, &str) = satisfy(|c| c != 'a').map(|c| c).parse("").unwrap();
}

```
Repository: create-react-app
Issue: Document Babel macros support and common uses
Labels: contributions: up for grabs!,tag: documentation,difficulty: medium

Need to keep track:

* Relay https://github.com/facebook/relay/pull/2171
* Apollo https://github.com/facebookincubator/create-react-app/issues/3856#issuecomment-358696916
* Css-in-js like Emotion
* Maybe some i18n libs?
* SVG https://github.com/facebookincubator/create-react-app/issues/3856#issuecomment-358696916
* Maybe make one for idx? https://github.com/dralletje/idx.macro
Repository: pytorch
Issue: Consider disallowing Variables that require grad in NCCL/comm functions
Labels: module: autograd,triaged,module: nccl,actionable

The NCCL bindings and torch.cuda.comm functions now operate on Tensors or Variables, but they're not differentiable functions. We may want to raise an exception if the arguments require grad and `torch.is_grad_enabled()` is `True`.

See #4730

cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @soulitzer @SsnL
Repository: rust
Issue: Performance regressions of compiled code over the last year
Labels: A-LLVM,I-slow,C-enhancement,P-medium,T-compiler,regression-from-stable-to-stable,A-libtest

Started on an update to https://github.com/Marwes/combine after it being dormant for a while. When I ran the benchmarks to check that my changes hadn't regressed the performance I noticed that performance had regressed by ~28% (~116% with incremental compilation!) since the last time ran benchmarks (somewhere around September 2016).

I ran the benchmarks again against an old version of the library to be able to compile it with older rustc's but the regression is the same in the master branch as well.

## `cargo bench --bench http` against https://github.com/Marwes/combine/tree/v2.3.2

### cargo-0.18.0-nightly (a73a665 2017-02-14)
```
test http_requests_large ... bench:     439,961 ns/iter (+/- 30,684)
test http_requests_small ... bench:      87,508 ns/iter (+/- 5,173)
```

### rustc 1.19.0-nightly (554c685b0 2017-06-14)
```
test http_requests_large ... bench:     475,989 ns/iter (+/- 10,477)
test http_requests_small ... bench:      95,175 ns/iter (+/- 23,751)
```

### rustc 1.22.0-nightly (368122087 2017-09-06)
```
test http_requests_large ... bench:     494,088 ns/iter (+/- 27,462)
test http_requests_small ... bench:     102,798 ns/iter (+/- 67,446)
```

### rustc 1.25.0-nightly (6828cf901 2018-01-06) (CARGO_INCREMENTAL=0)
```
test http_requests_large ... bench:     551,065 ns/iter (+/- 420,621)
test http_requests_small ... bench:     112,375 ns/iter (+/- 2,098)
```

### rustc 1.25.0-nightly (6828cf901 2018-01-06) (CARGO_INCREMENTAL=1)
```
test http_requests_large ... bench:   1,001,847 ns/iter (+/- 40,639)
test http_requests_small ... bench:     188,091 ns/iter (+/- 1,958)
```

I'd like to bisect this further but the two tools I found for this do not appear to work in this case, is there any other tool that can be used for this?

https://github.com/kamalmarhubi/rust-bisect (Outdated)
https://github.com/Mark-Simulacrum/bisect-rust/tree/master/src (Only last 90 days)
Repository: rust
Issue: rustc hangs when compiling a certain broken codebase, rather than emit an error message
Labels: A-diagnostics,T-compiler,C-bug,I-hang

Let my start by saying that I'm NOT asking for help with my project, and I KNOW my code is broken. I just want rustc to give me an error message instead of deadlocking. :)

I found this while trying to make a version of Servo without JavaScript. I started by deleting all references to mozjs from .toml files and deleting all "use js::*" lines from .rs files. That *should* cause the compile to fail almost right away with compile errors. Instead, rustc just hangs when it reaches the "script" crate.

**OS and RustC version**
This is 64-bit Linux Mint 18, corresponding to Ubuntu 16.04. My rustc version is rustc 1.23.0 (766bd11c8 2018-01-01).

**To Reproduce**

- Check out this branch of Servo: https://github.com/Max-E/servo/tree/stripped_out
- compile with "./mach build -rv"

**Expected Results**
Compilation should fail as soon as it hits the "script" crate with a huge number of error messages.

**Actual Results**
rustc just hangs. Instead of the expected CPU utilization (8 threads going full blast) there is only one thread. When I attach gdb to the rustc process, I see only two threads. One thread is stuck on a pthread_join, and another thread is in a loop that seems to call memcmp a lot.

**A Second Opinion**
A very kind bystander on IRC was able to reproduce the same problem using both the stable and nightly versions of rustc.

**An Apology**
I wish I could narrow down the problem instead of just dumping this huge codebase on you, but I frankly am not sure how to even begin doing that.
Repository: vue
Issue: Double value appear in textarea when using render function to create in .vue file.
Labels: browser quirks

### Version
2.5.13

### Reproduction link
[https://jsfiddle.net/SunnyLyu/ntoboxev/](https://jsfiddle.net/SunnyLyu/ntoboxev/)

### Steps to reproduce
1. sorry for things that it could not use .vue file definition in jsfiddle, please follow the steps below.

2. to create a textarea component like this: 

    export default {
        props: {
           value: {
              type: String
           }
        },
        render: function(h) {
  	    var _this = this;
            return h('textarea', {
               'on': {
                  'input': function(e){
                      _this.$emit('update:value', e.target.value);
                  }
               }
            }) 
         }
      };

3. import into a .vue file and use as a Vue component:
<!-- ta means the component defined above -->
<ta id="main" :value.sync="msg"></ta>

4. run all these codes

### What is expected?
Type '1' in textarea once, a character '1' would appear in the textarea, in IE11.

### What is actually happening?
Type '1' in textarea once, 2 characters '11' would appear in the textarea at the same time, in IE11.

---
1. Just use the component definition in HTML, everything goes well in both IE and Chrome (like the example running in jsfiddle).

2. Once when using the definition in .vue file, after compiled would get wrong in IE11, but still ok in Safari and Chrome.

<!-- generated by vue-issues. DO NOT REMOVE -->
Repository: rust
Issue: False positive: "struct is never used", but it is used via associated constant from a trait
Labels: C-enhancement,A-lints,T-compiler

```Rust
trait X {
  const X: usize;
}

struct A;
struct B;

impl X for A {
  const X: usize = 0;
}

impl X for B {
  const X: usize = 1;
}

fn main() {
  let x = 1;
  match x {
    A::X => println!("A"),
    B::X => println!("B"),
    _ => println!("?"),
  }
}
```

```
λ rustc main.rs                                                                                                                     ~/trash
warning: struct is never used: `A`
 --> main.rs:5:1
  |
5 | struct A;
  | ^^^^^^^^^
  |
  = note: #[warn(dead_code)] on by default

warning: struct is never used: `B`
 --> main.rs:6:1
  |
6 | struct B;
```

Looks like a false positive?
Repository: vscode
Issue: Allow to "Scope to this" in explorer
Labels: feature-request,file-explorer

I'd like to have the "scope" feature in the tree view to "isolate" a directory in order to have a "cleaner" view. For example, if my project root directory has 2 main sub-directories: "public" and "admin":

      main-dir

          \___ admin

          \___ public


 and I want to work only to the "public" directory I'd right-click the "public" directory in the tree view and choose "Scope to this" and then the tree view would show only the "public" directory.
Repository: kubernetes
Issue: Improve kubectl cp, so it doesn't require the tar binary in the container
Labels: sig/node,kind/feature,sig/cli,lifecycle/frozen

> Uncomment only one, leave it on its own line: 

> /kind feature


**What happened**:
Kubectl cp currently requires the container we're copying into to include the tar binary. This is problematic when the container image is minimal and only includes the main binary run in the container and nothing else. 

**What you expected to happen**:
Docker now has `docker cp`, which can copy files into a running container without any prerequisites on the container itself. Kubectl cp could use that mechanism. Obviously, this will require introducing a new feature into CRI, so it's not a small task.

**Why we need this**:
This will enable users to debug an existing (running) container, which is based on the `scratch` image and contains nothing else but the main app binary. Users would be able to get any binary they need into the container. An alternative solution could be to mount an additional volume (possibly from another container image) into a running pod (if that feature is ever implemented).
Repository: go
Issue: x/net/html: Parse() adds duplicate elements
Labels: NeedsInvestigation

### What version of Go are you using (`go version`)?
go version go1.9.2 darwin/amd64

### Does this issue reproduce with the latest release?
yes

### What operating system and processor architecture are you using (`go env`)?
GOARCH="amd64"
GOOS="darwin"

### What did you do?
https://play.golang.org/p/M3PUK90dQhM

### What did you expect to see?
```
<html><head></head><body><strong someAttr=""><a href="some_link"><strong><strong><strong><strong></strong></strong></strong></strong> </a></strong></body></html>
```

### What did you see instead?
```
<html><head></head><body><strong someattr=""><a href="some_link"><strong><strong><strong><strong></strong></strong></strong></strong></a></strong><a href="some_link"> </a></body></html>
```
Notice the duplicate `<a href="some_link"></a>`
From what I understand https://github.com/golang/net/blob/master/html/parse.go#L347 removes identical opening element and before it has a chance to remove respective closing element, reconstructActiveFormattingElements() "fixes" the "broken" structure
Repository: flutter
Issue: CocoaPods might not work if there are multiple targets or the target name changed
Labels: tool,platform-mac,customer: posse (eap),P3,a: plugins,team-tool,triaged-tool

https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/ios/xcodeproj.dart#L67
is hardcoded. 

Discover all the target names and dynamically insert them all into Generated.xcconfig
Repository: rust
Issue: who tests the tester?
Labels: A-testsuite,E-hard,C-enhancement,T-compiler,T-bootstrap,T-infra,A-compiletest,E-needs-design

So, by and large, compiletest is untested, as far as I know. That is -- there are no 'self tests' to make sure that it's acting as it should, invoking revisions the way we expect, and so forth. This could be a bit of a tricky thing to do, but it's definitely worth the effort.

For example, an early version of https://github.com/rust-lang/rust/pull/47605 had a subtle bug where it *appeared* to be working, but in fact was not passing the revision info through to the final test. I don't think this would have bothered travis one bit, as that would have happily run the same revision over and over.

cc @spastorino @oli-obk ... we need like a compiletest team, don't why? :)
Repository: rust
Issue: Poor error message when user forgets derive that has attributes
Labels: C-enhancement,A-diagnostics,A-macros,T-compiler,D-newcomer-roadblock,A-proc-macros

```rust
#[macro_use]
extern crate serde_derive;

#[serde(untagged)]
enum CellIndex {
    Auto,
    Index(u32),
}
```

```
error[E0658]: The attribute `serde` is currently unknown to the compiler and may have meaning added to it in the future (see issue #29642)
 --> src/main.rs:4:1
  |
4 | #[serde(untagged)]
  | ^^^^^^^^^^^^^^^^^^
  |
  = help: add #![feature(custom_attribute)] to the crate attributes to enable
```

The error and suggestion are super misleading and I have seen this a few times in #serde. It should be possible for the compiler to observe that there are derive macros in scope with `serde` declared as an attribute, and suggest using those.

```rust
// These are in scope
#[proc_macro_derive(Serialize, attributes(serde))]
#[proc_macro_derive(Deserialize, attributes(serde))]
```

A better message would not have the part about the compiler adding meaning to `#[serde]` in the future and would recommend using `#[derive(Serialize)]` or `#[derive(Deserialize)]` on the struct containing the attribute.
Repository: vscode
Issue: Provide API to access and change editor tab labels
Labels: feature-request,api,workbench-tabs

Feature Request

The Atom has the ability to customize the tabs, it's so powerful for some requirements. For example, there is an extension [nice-index](https://github.com/joshwcomeau/nice-index) in Atom that could be able to rename tabs of many opened editors have same name `index.js`, rename them to the names of their parent folder.

![image](https://user-images.githubusercontent.com/10795207/35185156-a959e6b2-fe3a-11e7-9e33-70b541dc4e14.png)

![image](https://user-images.githubusercontent.com/10795207/35185159-b852ce68-fe3a-11e7-8fda-6c4a41fff04a.png)

It's very useful that if we could do so. 

@bpasero I got it that the feature requested by #32836 will not be considered in the first half year of 2018. I think my feature request is very similar with that, so may I ask you when the ability to customize tabs in VSC would be added into the roadmap ?

I was excited when I start to think how can I implement a extension like `nice-index` in VSC, but after I involved in the documents about customizing a VSC extension, I just found that I can not achieve this. I hope that you could consider this feature request, thanks for all of your great works ~ 🙏
Repository: angular
Issue: Bug (?) - ReactiveForms > FormArray, trackBy index > removeAt & subscriptions 
Labels: freq2: medium,area: forms,type: confusing,forms: Controls API,P3,core: control flow

Hi Angular,

I think i found a [x] bug, but I'm not sure.

I have a large Reactive Form, with a FormArray.. and I trackBy index. Each FormGroup in the array has subscriptions like:

```
  // get the rides so we can iterate over them
  get myRides(): FormArray {
    return this.ridesForm.get('rides') as FormArray;
  };
```

```
  trackByFn(index, item) {
    return index; // or item.id
  }
```

```
 // each ride that is added has subscriptions
  subscribeChanges(ride: FormGroup){

    ride['dateSub$'] = ride.get('date').valueChanges.subscribe(val => {
     });
    
    ride['distanceSub$'] = ride.get('distance').valueChanges.subscribe(val => {
    });

    ride['startCountSub$'] = ride.get('start_count').valueChanges.subscribe(val => {
    });

    ride['endCountSub$'] = ride.get('end_count').valueChanges.subscribe(val => {
    });
  }
```

now.. you can also delete FormGroup's using:

```
  // deletes a single ride
  public deleteRide(ride: FormGroup, i: number): void{
        this.unsubscribeChanges(ride);
       this.myRides.removeAt(i)
}
  unsubscribeChanges(ride: FormGroup){
    ride['dateSub$'].unsubscribe();
    ride['distanceSub$'].unsubscribe();
    ride['startCountSub$'].unsubscribe();
    ride['endCountSub$'].unsubscribe();
  }
````

but it seems that the tracking of objects goes wrong.. So let's delete a FormGroup at index 3 of 6 FormGroups....The subscriptions on the index of your removed FormGroup - and below that - do not fire anymore. As if their binding is still on a 'old' index. 

Is it not allowed to put your Subs$ on a FormGroup? Or is there a bug in the tracking / refreshing of FormGroup's in the array?
Repository: godot
Issue: RID::is_valid missing from GDNative C API
Labels: enhancement,topic:gdextension

Godot 3.0 master

As I progress porting my module, I found that `godot_rid_is_valid()` is missing from the C API of RID.
Should it be added?
Repository: pytorch
Issue: Clang color diagnostics don't work with ninja
Labels: module: build,triaged

We seem to be hit by this problem: https://github.com/ninja-build/ninja/issues/174

Workaround: add `CFLAGS="-Xclang -fcolor-diagnostics"` to your environment.

cc @malfet
Repository: create-react-app
Issue: Reduce installed size in 2.x
Labels: tag: enhancement

I noticed 2.x has regressed on the installed size

Before:

* 109,142,603 bytes (172.7 MB on disk) for 23,707 items

After:

* 135,452,954 bytes (216.4 MB on disk) for 29,913 items

You can check by creating a project with 2.0 alpha: https://github.com/facebookincubator/create-react-app/issues/3815.

@wtgtybhertgeghgtwtg Is this something you could look into?
Repository: go
Issue: cmd/gofmt: extend column alignment to include assignments and declarations
Labels: NeedsFix

Please answer these questions before submitting your issue. Thanks!


### What version of Go are you using (`go version`)?

Should apply to any version of go.

### Does this issue reproduce with the latest release?

Yep.  It's a formatting enhancement.  

### What operating system and processor architecture are you using (`go env`)?

Should happen in any environment.

### What did you do?

Type the following and  run it through gofmt:

```go
  a.b.c = 123
  a.d = "def"
  a.e.f.g = 456
  h, i = 7, 8

  j := 123
  k.l := "def"
  k.m.n.o := 456
  p, q := 7, 8

  var r = "abc"
  var t, u = 1, 2
  var v int = 3
```

and nothing would change with the formatting

### What did you expect to see?

I would like to see are the same rules gofmt currently applies to structs and maps to be more uniformly applied.  Specifically to sequential assignments, sequential declarations with := and sequential declaration withs =.  

So I'd like to see:

```go
  a.b.c   = 123
  a.d     = "def"
  a.e.f.g = 456
  h, i    = 7, 8

  j       := 123
  k.l     := "def"
  k.m.n.o := 456
  p, q    := 7, 8

  var r     = "abc"
  var t, u  = 1, 2
  var v int = 3
```

### What did you see instead?

Saw the original code.
Repository: godot
Issue: Cannot register enums and constants with GDNative
Labels: enhancement,topic:core

Godot 3.0 master RC2

You can register classes, tool classes, signals, properties, methods, but no enums and no constants. I need them so I'm not forced to write raw numbers when an enum is expected.