sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: TypeScript
Issue: Convert to ES2015 class do not recognize inheritance
Labels: Suggestion,Awaiting More Feedback


Issue Type: <b>Bug</b>

```js
function Derived() {
  Base.call(this, /*some base args*/);
  /* some other constructor work */
};
Derived.prototype = new Base();
Derived.prototype.constructor = Derived;
```
must be converted to
```js
class Derived extends Base {
  constructor() {
    super(/*some base args*/);
    /* some other constructor work */
  }
}
```
Right now it converted to
```js
class Derived {
  constructor() {
    Base.call(this, /*some base args*/);
    /* some other constructor work */
  }
}
;
Derived.prototype = new Base();
Derived.prototype.constructor = Derived;
```

VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:59:35.033Z)
OS version: Windows_NT x64 10.0.17134

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1992)|
|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: disabled_software<br>oop_rasterization: disabled_off<br>protected_video_decode: enabled<br>rasterization: enabled<br>skia_deferred_display_list: disabled_off<br>skia_renderer: disabled_off<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>viz_display_compositor: disabled_off<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|7.89GB (2.36GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (14)</summary>

Extension|Author (truncated)|Version
---|---|---
search-crates-io|bel|1.2.1
better-toml|bun|0.3.2
bracket-pair-colorizer-2|Coe|0.0.28
pegjs-syntax|fut|0.1.1
nwscript|glo|0.0.2
restructuredtext|lex|112.0.0
hg|mrc|1.3.0
vscode-language-pack-ru|MS-|1.36.2
rust|rus|0.6.1
crates|ser|0.4.3
vscode-hexdump|sle|1.7.2
code-spell-checker|str|1.7.17
code-spell-checker-russian|str|0.2.2
sort-lines|Tyr|1.8.0


</details>
<!-- generated by issue reporter -->
Repository: TypeScript
Issue: Feature Request: Split out JsDoc comments for constructor function when convert function to ES2015 class
Labels: Suggestion,Awaiting More Feedback,Domain: Refactorings

Add ability to convert JsDoc comments in following situation:
```js
/**
 * @class
 * Some constructor description.
 * @classdesc
 * Some class description
 */
function Class() {}
```
must be converted to
```js
/**
 * Some class description
 */
class Class {
  /**
   * Some constructor description.
   */
  constructor() {}
}
```
Right now you get following result:
```js
/**
 * @class
 * Some constructor description.
 * @classdesc
 * Some class description
 */
class Class {
  constructor() {}
}
```
Repository: godot
Issue: Why is _ptr in cowdata.h mutable?
Labels: discussion,topic:core

I tried compiling without the keyword and it compiles just fine...is there any use cases where this is necessary?

https://github.com/godotengine/godot/blob/e44041ae41c6b76678f52f772abb5e4834ed40a1/core/cowdata.h#L56
Repository: godot
Issue: Confusing EditorPlugin.forward_*_gui_input Behavior
Labels: discussion,topic:plugin,topic:input

<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->

**Godot version:** 3.1.1
<!-- Specify commit hash if non-official. -->


**OS/device including version:** Solus Gnome 4.0
<!-- Specify GPU model and drivers if graphics-related. -->


**Issue description:**
<!-- What happened, and what was expected. -->
`EditorPlugin.forward_canvas_gui_input` and `EditorPlugin.forward_spatial_gui_input` `return` value is confusing with the method's signature. Let me explain.

Reading the method name we may think that it will forward an `InputEvent` to other classes if it `return true`, right? Because if we question ourselves "Will the `InputEvent` be forwarded?" we can check what the method returns.

But it turns out to be the opposite, it forwards the `InputEvent` to other classes when the method `return false` and it consumes and prevents the `InputEvent` to reach other classes if `return true`.

**Steps to reproduce:**
1. Create a dummy plugin
2. Implement EditorPlugin.handles method
3. Implement EditorPlugin.forward_canvas_gui_input
4. Add the following:

```
func forward_canvas_gui_input(event):
    var forward = true
    print(event)
    return forward
```
Then try the following:
1. Add a `Node2D` to a scene
2. Try to move it

You will see that the [InputEventMouseMotion] is printed but your `Node2D` doesn't move, try to set `forward = false` instead and repeat, now it moves.

**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
[dummy_plugin.zip](https://github.com/godotengine/godot/files/3413621/dummy_plugin.zip)
Repository: rust
Issue: Provide From<E> for Box<dyn Error + Send> and Box<dyn Error + Sync>
Labels: T-libs-api,C-feature-request

[As explained in the Rust User forum](https://users.rust-lang.org/t/impl-e-error-from-e-for-box-dyn-error-send/30507), I noticed that the following impls are not available:
```rust
impl<'a, E: Error + Send + 'a> From<E> for Box<dyn Error + Send + 'a> {}
impl<'a, E: Error + Sync + 'a> From<E> for Box<dyn Error + Sync + 'a> {}
```
The first one is pretty useful when working with [rayon](https://crates.io/crates/rayon) and errors, which only need to be `Send` to be passed across threads. In theory, a stateful error with a `Cell` or a `RefCell` is a possible example of `dyn Error + Send + !Sync`.

The second impl is mainly for coherence and symmetry, I still do not have in mind a possible realistic situation.

In any case, IMHO this feature should not require a RFC. In that case I can create a PR and follow these steps:
- [ ] Implement the two impls
- [ ] Adjust the docs

It is the first time I contribute to Rust, and I am not sure if this feature should require a stabilization process. In this case just let me know, and I will update this document in order to include the addition of a feature gate and everything needed.

Any feedback is appreciated to make me do things nicely and your review less painful.
Repository: rust
Issue: Library load disallowed by System Policy on macOS 10.15 beta 4
Labels: O-macos

On macOS 10.15 beta 4 (19A512f), when I try to run `rustc` (or invoke it through a command like `cargo build`) I get the following message:

```
dyld: Library not loaded: @rpath/librustc_fs_util-e4dabb5766b9af43.dylib
  Referenced from: /Users/soren/.rustup/toolchains/stable-x86_64-apple-darwin/bin/rustc
  Reason: no suitable image found.  Did find:
	/Users/soren/.rustup/toolchains/stable-x86_64-apple-darwin/bin/../lib/librustc_fs_util-e4dabb5766b9af43.dylib: code signature in (/Users/soren/.rustup/toolchains/stable-x86_64-apple-darwin/bin/../lib/librustc_fs_util-e4dabb5766b9af43.dylib) not valid for use in process using Library Validation: Library load disallowed by System Policy
	/Users/soren/.rustup/toolchains/stable-x86_64-apple-darwin/bin/../lib/librustc_fs_util-e4dabb5766b9af43.dylib: stat() failed with errno=1
	/Users/soren/.rustup/toolchains/stable-x86_64-apple-darwin/lib/librustc_fs_util-e4dabb5766b9af43.dylib: code signature in (/Users/soren/.rustup/toolchains/stable-x86_64-apple-darwin/lib/librustc_fs_util-e4dabb5766b9af43.dylib) not valid for use in process using Library Validation: Library load disallowed by System Policy
	/Users/soren/.rustup/toolchains/stable-x86_64-apple-darwin/lib/librustc_fs_util-e4dabb5766b9af43.dylib: stat() failed with errno=1
fish: 'rustc' terminated by signal SIGABRT (Abort)
```

This happens even if I give all of the binaries in `~/.rustup/toolchains/nightly-x86_64-apple-darwin/bin` Developer Tools permission in System Preferences.

I would tell you what version of `rustc` I have installed, but I can't run it to check.
Repository: rust
Issue: MaybeUninit<T> could be Copy for all T
Labels: C-enhancement,T-lang,T-libs-api

At the moment it only implements `Copy` when `T: Copy`, but there's no memory-safety reason for it not to always be `Copy`.
Repository: node
Issue: Memory leak with debugger running.
Labels: memory,inspector

* **Version**: v11.15.0
* **Platform**: Linux

**Edit:** Removed information about https://github.com/nodejs/node/issues/28786 making this hard to debug, as it has been fixed in ``v12.7.0``.

This bug might also be the same as, or related to, [this bug](https://github.com/nodejs/node/issues/28420), but because I'm unsure whether it's the same and because this one contains a minimal example, I've filed a separate issue.

Run this with ``node --inspect script.js`` and attach chrome:

```js
// edit: simplified example

async function noop() {}

async function run() {
    while (true) {
        await noop();
    }
}

run();
```

You can see memory usage getting out of hand as soon as you attach google chrome:

![5454](https://user-images.githubusercontent.com/1431530/61583677-8ab44180-ab3b-11e9-8a10-701ad53b4783.png)
*Before connecting with Chrome's debugger.*

![5455](https://user-images.githubusercontent.com/1431530/61583678-8ee05f00-ab3b-11e9-9b6c-b59b0e99be5f.png)
*A few seconds after connecting with Chrome's debugger.*

This is what you see if you manage to grab a heapdump before it crashes:
![5468](https://user-images.githubusercontent.com/1431530/61990329-b0ab7b80-b03e-11e9-957a-dbcc67b32e00.png)

The eventual crash when it runs out of memory is in a comment below.
Repository: create-react-app
Issue: Support optimizations for clsx, classnames and similar libraries
Labels: issue: proposal

### Is your proposal related to a problem?

No. Proposing supporting this in the babel plugin config https://github.com/merceyz/babel-plugin-optimize-clsx

### Describe the solution you'd like

This plugin just adds optimizations if the existing project is using classnames or clsx. Not sure how to test performance of this change.
Repository: go
Issue: proposal: spec: add Posit data type
Labels: LanguageChange,Proposal,LanguageChangeReview

[Posits](https://posithub.org/conga/2019/docs/13/1430-John-Introductory.pdf) are gaining [traction](https://posithub.org/conga/2019/programme) as a replacement and clean improvement over [IEEE 754](https://en.wikipedia.org/wiki/IEEE_754). They offer reasonable dynamic ranges with better accuracy / energy efficiency / speed on many applications. They will probably replace IEEE floats in 5 to 10 years in cpus / gpus / tpus. They have an official [standard](https://posithub.org/docs/posit_standard.pdf).

Adding (experimental) support for posits will position Go 2 in a better place for developers' consideration who want to get better results out of their mathematical calculations in AI, ML, HPC, weather forecasting, astrophysics etc. areas in addition to typical backend programming that Go is already good at. This will possibly enable Go's penetration into scientific computing.

At the moment there is no hw architecture that supports posits, but there are many sw and fpga [implementations](https://posithub.org/docs/PDS/PositEffortsSurvey.html). Initially it could start like [soft-floats](https://gitlab.com/cerlane/SoftPosit). As hw support becomes available, people will reap the benefits. Most floating-point code is readily convertable to posits: just rename data types.

Adding posits is non-trivial and a BIG step. It has to be done incrementally. Also there will possibly be a transition period where hw platforms will have IEEE floats and / or posits.

These are the (incomplete) steps of this proposal:
- add posit8, posit16, posit32, posit64 data types as per the standard
- add conversions from/to other data types
- add "printing/scanning posits" functionality to fmt library
- add math/posit standard library with standard Sine/Tan etc. (posit32)
- add cxposit32, cxposit64, cxposit128 complex number data types
- add math/cmplx/cxposit standard library (cxposit64)

There is a lot to do, so when hw support arrives, Go 2 will be ready to deliver ;)
Repository: godot
Issue: Boot splash issue
Labels: bug,topic:core

**Godot version:**
3.1

**OS/device:**
Windows 8, Toshiba Satellite

**Issue description:**
Custom animated splash screens instanced as main scenes (for example, a `CanvasLayer` using an `AnimationPlayer` to play some default animation) will start playing during the built-in Godot boot splash. This means the custom splash will already be in progress by the time the Godot boot splash ends. This is ugly.

It would be nice if the built-in boot splash emitted some kind of signal so you could tell custom splash screens to start animating _after_ the built-in boot splash.

I tried setting the boot splash image to a transparent texture, and also set the bg color to transparent, but `application/boot_splash_bg_color` seems to ignore the alpha setting.

If there's a workaround in the meantime, please let me know.

**Steps to reproduce:**
1. Create a `CanvasLayer` scene with some kind of animation and set this as your main scene.
2. Run the project and notice that the animation is in progress after the the Godot boot splash finishes.

**See also:**
https://godotengine.org/qa/32784/is-there-a-signal-for-splash-screen
Repository: angular
Issue: isStable, behavior of zone-patch-rxjs?
Labels: type: bug/fix,area: zones,state: confirmed,P4

If I create a new Angular application with `ng new <name>` and just inject ApplicationRef as follow:

```typescript
import { ..., ApplicationRef } from '@angular/core';
export class AppComponent implements OnInit {
    constructor(private appRef: ApplicationRef) {}

    ngOnInit() {
        this.appRef.isStable.subscribe(console.log);
    }
}
```
I will get the emitted values [false, true] after app has been initialized, nothing strange.

But, if I then add `import 'zone.js/dist/zone-patch-rxjs'` in polyfills.ts or app.module.ts, previous code will get caught in infinite loop (toggle between emitted values true and false back and forth) and everything will eventually freeze. Is this the expected behavior? I am quite unsure myself
Repository: angular
Issue: Potential bug when used with webextension-polyfill
Labels: area: zones,state: needs more investigation,P4

Hi everyone,

I use Angular 7 to develop a web extension for Firefox and Chrome.

It seems that **ZoneAwarePromise** is causing a weird behavior in Firefox preventing Mozilla **webextension-polyfill** to do it's task. 

developer @rpl provided a cause:

> Firefox requires that the `promise `returned by `runtime.onMessage` listener to be a native Promise.

Without Angular, everything works as expected.

You can see the initial issue opened at webextension-polyfill:
https://github.com/mozilla/webextension-polyfill/issues/172

Without webextension-polyfill, it's a nightmare to develop extensions for different browsers.
Without Angular, it's a pain to develop in javascript. I hope I can keep both.

Can someone please help me figure out a solution to this problem, or at least provide some insight?

Steps to reproduce:
**Firefox:**
1. Open "about:debugging"
2. Enable add-on debugging
3. Click "Load temporary Add-on"
4. Select the extension folder
5. Click "Debug"
6. Click on the popup action button in the toolbar
Observed behavior: console immediately shows: "handleResponse undefined"
**Behavior NOT OK**

**Chrome:**
1. Go to extensions
2. "Load unpacked extension"
3. Select the extension folder
4. right click on the popup action button in the toolbar -> "inspect pop-up"
Observed behavior: after 2s console shows: "handleResponse async response from background script"
**Behavior OK**

I attached both the generated extension that you can import in Chrome/Firefox and observe the behavior, as well as the full Angular 7 example project if you need to take a look into the source code.

[dist_ff_promise_bug.zip](https://github.com/angular/zone.js/files/2792843/dist_ff_promise_bug.zip)
[project-ff-bug.zip](https://github.com/angular/zone.js/files/2792846/project-ff-bug.zip)

To generate the extension, you just need to:
```
yarn install
ng build --aot
```
This will generate the **dist** folder ready for import in Chrome/Firefox as an extension.
Repository: angular
Issue: Attempting to change configurable attribute of unconfigurable property
Labels: type: bug/fix,area: zones,state: confirmed,P4

Using iOS' WKWebView in a Cordova app, I get this exception:

> TypeError: Attempting to change configurable attribute of unconfigurable property.

The exception is thrown here:
https://github.com/angular/zone.js/blob/afa1363eb9ae3be506442311a18723a112f9ef8b/lib/browser/property-descriptor.ts#L362

The strange thing is that the exception only occurs once in a while and I don't know how to reproduce it. I assume that there is other code that overwrites the `onreadystatechange` attribute of `XMLHttpRequest.prototype`. At least I'm sure that the property is not configurable when the error occurs. To proof this I set a break point on that line and retrieved the value of `xhrDesc`

```
Object {enumerable: false, configurable: false, get: function, set: function}
```

My suggestion is to either check whether the property is configurable or/and wrap the overwriting code in a try/catch. If it's not or if an exception is thrown, `canPatchViaPropertyDescriptor` could return `false`.
Repository: angular
Issue: Support for history.pushState()
Labels: area: zones,state: needs more investigation,P4

I just found out that history.pushState() is not patched.

I would have expected it to be patched because it's most natural to expect the Angular router to pick up changes to the url from outside of Angular just as well. 

For tracking purposes:
In this issue from 2014, btford already outlined History API to be supported by Zone.js: https://github.com/angular/zone.js/issues/9
Repository: flutter
Issue: What do each of the colors in ThemeData and ColorScheme() do?
Labels: framework,f: material design,d: api docs,customer: crowd,a: annoyance,P2,team-design,triaged-design,f: theming

I'm using `ColorScheme()` to theme my app and set some colors. Here's my code for the theme:

```
colorScheme: ColorScheme(
  primary: Colors.red,
  onPrimary: Colors.black,
  primaryVariant: Colors.orange,

  background: Colors.red,
  onBackground: Colors.black,

  secondary: Colors.red,
  onSecondary: Colors.white,
  secondaryVariant: Colors.deepOrange,

  error: Colors.black,
  onError: Colors.white,

  surface: Colors.white,
  onSurface: Colors.black,

  brightness: Brightness.light,
),

// this is the only code in ThemeData.light().copyWith()
```

Here's the relevant documentation: [ColorScheme class](https://api.flutter.dev/flutter/material/ColorScheme-class.html)

**So what do these properties change the color of? Is there a list of which colors affect which widgets?** 

By looking at the source of a FAB, I found out that `colorScheme.secondary` changes its background color, and that `colorScheme.onSecondary` should change the icon color, although it's not (what's up with that?). Here's what I found:

```
// floating_action_button.dart
final Color foregroundColor = this.foregroundColor  // <-- colorScheme.onSecondary does NOT change FAB icon color
  ?? floatingActionButtonTheme.foregroundColor
  ?? theme.accentIconTheme.color
  ?? theme.colorScheme.onSecondary;
final Color backgroundColor = this.backgroundColor  // <-- colorScheme.secondary changes FAB background color
  ?? floatingActionButtonTheme.backgroundColor
  ?? theme.colorScheme.secondary;
```
Repository: angular
Issue: regression: jasmine.clock() inside fakeAsync() doesn't work anymore since 0.8.21
Labels: area: zones,state: needs more investigation,P3

This happens in an Angular application.

Simple steps to reproduce

 - install Angular CLI
 - generate a project with `ng new`
 - write the following clock.spec.ts test
 
```
import { fakeAsync } from '@angular/core/testing';

fdescribe('clock test', () => {

  afterEach(() => jasmine.clock().uninstall());

  it('should fake the clock in fakeAsync', fakeAsync(() => {
    const fakeTime = 12345678;
    jasmine.clock().mockDate(new Date(fakeTime));

    expect(new Date().getTime()).toBe(fakeTime);
  }));
});
```

Run `ng test` to execute the test. It fails when zone.js version 0.8.21 is being used (default dependency to zone.js in package.json is `^0.8.19`, which now resolves to 0.8.21. If you change it to `0.8.20` and execute `npm install`or `yarn install` to make sure the previous version of zone.js is used, the test passes.
Repository: node
Issue: Improve ERR_INVALID_CHAR error info
Labels: http

**Is your feature request related to a problem? Please describe.**
Recently, I have debug a error with http header 
```console
(node:17863) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_CHAR]: Invalid character in header content ["cookie"]
    at ClientRequest.setHeader (_http_outgoing.js:458:3)
    at new ClientRequest (_http_client.js:221:14)
    at Object.request (http.js:44:10)
```

I take a very long time to find the invalid character (the root cause is because I put `\n` in the string end, so it failed).

**Describe the solution you'd like**
The error provide more information

**Describe alternatives you've considered**
Hopefully we can change something here to return more info
https://github.com/nodejs/node/blob/ba565a37349e81c9d2402b0c8ef05ab39dca8968/lib/_http_common.js#L227-L230