sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: vscode
Issue: Product Icon Theme crash on Linux
Labels: bug,freeze-slow-crash-leak,confirmation-pending


Type: <b>Bug</b>

When I try to change the product icon theme in VS Code then the VS Code application crashes.

Actual:
Repro: 'File->Preferences->Theme->Product Icon Theme'  and then click on Browse Aditional Product Item Theme.

Expected:
Search list for product icon themes to download from.

VS Code version: Code 1.96.0 (138f619c86f1199955d53b4166bef66ef252935c, 2024-12-11T02:29:09.626Z)
OS version: Linux x64 6.11.11-300.fc41.x86_64
Modes:

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|AMD Ryzen 7 5800X 8-Core Processor (16 x 550)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: disabled_software<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: disabled_off<br>webnn: disabled_off|
|Load (avg)|2, 1, 1|
|Memory (System)|31.24GB (26.78GB free)|
|Process Argv|--crash-reporter-id 4a182290-c3cc-476a-816e-f9a8160655d8|
|Screen Reader|no|
|VM|0%|
|DESKTOP_SESSION|gnome|
|XDG_CURRENT_DESKTOP|GNOME|
|XDG_SESSION_DESKTOP|gnome|
|XDG_SESSION_TYPE|wayland|
</details><details><summary>Extensions (17)</summary>

Extension|Author (truncated)|Version
---|---|---
blazor-snippet-pack|adr|2.6.1
gitignore|cod|0.9.0
githistory|don|0.6.20
git-graph|mhu|1.30.0
vscode-docker|ms-|1.29.3
csdevkit|ms-|1.15.13
csharp|ms-|2.60.26
dotnet-interactive-vscode|ms-|1.0.5568010
vscode-dotnet-runtime|ms-|2.2.3
data-workspace-vscode|ms-|0.5.0
mssql|ms-|1.26.0
jupyter|ms-|2024.11.0
jupyter-keymap|ms-|1.1.2
jupyter-renderers|ms-|1.0.21
vscode-jupyter-cell-tags|ms-|0.1.9
vscode-jupyter-slideshow|ms-|0.1.6
remote-containers|ms-|0.394.0


</details><details>
<summary>A/B Experiments</summary>

```
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
vscrp:30673768
962ge761:30959799
pythonnoceb:30805159
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupytercf:31046870
nativerepl1:31139838
pythonrstrctxt:31112756
nativeloc1:31192215
cf971741:31144450
iacca1:31171482
notype1cf:31157160
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530

```

</details>

<!-- generated by issue reporter -->
Repository: go
Issue: math/big: update to math/rand/v2
Labels: NeedsInvestigation

### Go version

go version 1.23

### Output of `go env` in your module/workspace:

```shell
N/A
```


### What did you do?

I wanted to update robpike.io/ivy to math/rand/v2, but was inconvenienced by math/big/Int.Rand using the old random number generator. The type in the signature precludes using v2.

Compatibility of output aside, it should be easy to update, and also a good idea to keep the library consistent. math/rand/v2 is the right one to use.

### What did you see happen?

Sadness and pain.

### What did you expect to see?

Joy and clear skies.
Repository: vscode
Issue: Ctrl+a not selecting all cell contents
Labels: bug,notebook-commands

This happened shortly after navigating up and down cells with the keyboard. Seems to have messed up context keys as it's trying to select the output:

![Image](https://github.com/user-attachments/assets/66501844-14d5-4c26-b7bd-808cbb33cacc)
Repository: vscode
Issue: Git Diff Viewer Fails After Updating Images in Markdown Cells
Labels: bug,notebook-diff


## Environment data

-   VS Code Version: 1.95.3 (Universal)
-   Jupyter Extension version (available under the Extensions sidebar): v2024.10.0
-   Python Extension version (available under the Extensions sidebar): v2024.20.0
-   OS (Windows | Mac | Linux distro) and version: MacOS, latest 
-   Python and/or Anaconda version: 3.12
-   Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv

## Expected behaviour

By pasting images into markdown cells, I can embed them.
Here is an example notebook with an embedded image:
https://gist.github.com/kolibril13/6042e1105a6ff415a002aa23f1bd7348

When I replace that image with a new image, that works without problems while editing the notebook in VS Code.
However, as soon as I enter the git diff view, it starts loading the diff forever.
I did not manage to display the proper diff, even after waiting for minutes for the diff.
My assumption is, that VS Code is diffing the actual image string from the metadata:
`"image/png": "iVBORw0KGgoAAAANSUhEUgAAA/oAAAJyCAYAAAB0crugAAAMTmlDQ1BJQ0...`
and not the image itself.

## Actual behaviour

When I replace embedded images, the git diff won't crash.

## Steps to reproduce:

1. add an image (e.g. screenshot, that will be in a .png format). 
2. Make a commit. 
3. Exchange the image.
4.  Go to the diff viewer.
Here's a video of this bug:

https://github.com/user-attachments/assets/fa50556e-51f3-4506-9d1e-a1095debcc0b
Repository: vscode
Issue: Save Jupyter notebook failed if the .ipynb extension was removed in the save filename dialog box
Labels: bug,notebook-workbench-integration

### Applies To

- [ ] Notebooks (.ipynb files)
- [ ] Interactive Window and\/or Cell Scripts (.py files with \#%% markers)

### What happened?

When saving the Jupyter notebook for the very first time, if the default filename Untitled.ipynb was erased and then input a new filename without adding the .ipynb, the save notebook function will failed with the following error message.

![Image](https://github.com/user-attachments/assets/493b7dac-53df-46f5-abca-c229c032eb2d)

The save notebook function only works when the word Untitled was removed and only left the .ipynb extension in the save filename dialog box.

![Image](https://github.com/user-attachments/assets/cfd0500d-cc1a-46ea-9f22-0feb70338e83)

### VS Code Version

1.95.3

### Jupyter Extension Version

v2024.10.0

### Jupyter logs

```shell

```

### Coding Language and Runtime Version

Python v3.13.0

### Language Extension Version (if applicable)

_No response_

### Anaconda Version (if applicable)

_No response_

### Running Jupyter locally or remotely?

Local
Repository: flutter
Issue: Change `integrationDriver(...)` calls to use `exitCode = 0|1` not `exit(0|1)`
Labels: f: integration_test,P2,c: tech-debt,team-framework,triaged-framework

Calls to `exit(...)` hide process leaks or other background isolates that should be terminated instead. 

I am hoping that this is not a breaking change and we don't need to put this behind some sort of flag.
Repository: pytorch
Issue: PyTorch depends on custom actions stored in contributor personal repos
Labels: module: ci,triaged

There's a few GitHub actions that PyTorch depends on that appear to be stored in personal repos of some contributors. This is a risk as the team cannot easily update these actions if the contributor is not available for whatever reason. We should standardize on storing any custom actions in a PyTorch controlled repo.

Here's a list of actions that I believe maybe personal repos:

malfet/checkout@silent-checkout
https://github.com/nick-fields/retry/commit/3e91a01664abd3c5cd539100d10d33b9c5b68482
nick-fields/retry@v2.8.2
seemethere/download-artifact-s3
seemethere/upload-artrifact-s3@v5
https://github.com/necojackarc/auto-request-review/commit/e08cdffa277d50854744de3f76230260e61c67f4

cc @seemethere @malfet @pytorch/pytorch-dev-infra
Repository: rust
Issue: unused_allocation lint produces incorrect suggestion for Box comparison
Labels: A-lints,A-diagnostics,T-compiler,D-incorrect,L-unused_allocation

### Code

```Rust
pub fn main() {
    let a = Box::new(42);
    println!("{}", a == Box::new(99));
}
```

### Current output

```Shell
warning: unnecessary allocation, use `&` instead
 --> src/main.rs:3:25
  |
3 |     println!("{}", a == Box::new(99));
  |                         ^^^^^^^^^^^^
  |
```

### Desired output

```Shell
warning: unnecessary allocation, use `*` instead
 --> src/main.rs:3:25
  |
3 |     println!("{}", *a == 99);
  |                    +
  |
```

### Rationale and extra context

It is invalid to insert `&` in front of either value (even with deref coercion). The value should be unboxed instead for the comparison to work.

Extra bad because a `a == 99` comparison results in an error suggesting wrapping the literal in a `Box` (see #129083):

```
error[E0308]: mismatched types
 --> src/main.rs:3:25
  |
3 |     println!("{}", a == 99);
  |                    -    ^^ expected `Box<{integer}>`, found integer
  |                    |
  |                    expected because this is `Box<{integer}>`
  |
  = note: expected struct `Box<{integer}>`
               found type `{integer}`
  = note: for more on the distinction between the stack and the heap, read https://doc.rust-lang.org/book/ch15-01-box.html, https://doc.rust-lang.org/rust-by-example/std/box.html, and https://doc.rust-lang.org/std/boxed/index.html
help: store this in the heap by calling `Box::new`
  |
3 |     println!("{}", a == Box::new(99));
  |                         +++++++++  +
```

### Other cases

```Rust

```

### Rust Version

```Shell
rustc 1.83.0 (90b35a623 2024-11-26)
binary: rustc
commit-hash: 90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf
commit-date: 2024-11-26
host: x86_64-unknown-linux-gnu
release: 1.83.0
LLVM version: 19.1.1
```

### Anything else?

_No response_
Repository: flutter
Issue: Flutter run process exits unexpectedly
Labels: tool

In https://github.com/flutter/devtools/pull/8621/ (which requires https://dart-review.googlesource.com/c/sdk/+/366421), I am adding support for connecting a debug version of DevTools ran with `flutter run` to a locally running instance of the DevTools server.

Without the `--verbose` flag ([here](https://github.com/flutter/devtools/pull/8621/files#diff-ccf962c7d56edb8a392ecdf89859e077dddb3ef0602ed245dabb2d3206b759b7R291)), the `flutterRunProcess` in `devtools/tool/lib/commands/serve.dart` exits unexpectedly with code 255. When I add the `--verbose` flag to the `flutter run` command, the process does not exit as expcted.

Repro steps:
1. Patch https://github.com/flutter/devtools/pull/8621/ and https://dart-review.googlesource.com/c/sdk/+/366421
2. From anywhere in the DevTools repo, run `dt serve --run-app`.
Repository: bitcoin
Issue: Potential crash (assert) rescanning wallet
Labels: Wallet

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Preface: This whole analysis was made using Elements Core, not Bitcoin Core, but the code and the conditions should line up in a way that makes this likely in Bitcoin too.

There's an assert crash in `assert(chain_depth >= 0); // coinbase tx should not be conflicted` calling `CWallet::GetTxBlocksToMaturity` because `CWallet::GetTxDepthInMainChain`  returns a negative value for `TxStateConfirmed` txs. The reason for this is that `m_last_block_processed` is set at the beginning of `AttachChain`, but the rescan loop keeps going beyond that point, so when `GetTxDepthInMainChain` is called right after the scan is done, m_last_block_processed is lower than the actual block in the latest txs, hence returning a negative value and crashing.

In discussions with @achow101 , it's possible that https://github.com/bitcoin/bitcoin/pull/30221 fixes this issue by calling `SetBestBlock` after the rescan is done. Another approach could be to stop the scan when `m_last_block_processed` is reached with something like this

```diff
@@ -1689,6 +1693,11 @@ CWallet::ScanResult CWallet::ScanForWalletTransactions(const uint256& start_bloc
         if (max_height && block_height >= *max_height) {
             break;
         }
+        if (block_height >= GetLastBlockHeight()) {
+            WalletLogPrintf("Stopping scan. At block %d. Progress=%f\n", block_height, progress_current);
+            break;
+        }
+
         {
             if (!next_block) {
                 // break successfully when rescan has reached the tip, or
```

### Expected behaviour

The wallet data should be consistent to avoid the crash

### Steps to reproduce

This is reproduced using QT

1. Create a chain with many coinbase txs.
2. Attach a wallet (could be read only) with the address of the coinbase txs
3. While the wallet is still being loaded, create many more blocks with coinbase txs to that address
4. Assert happens when the wallet is done loading

### Relevant log output

_No response_

### How did you obtain Bitcoin Core

Compiled from source

### What version of Bitcoin Core are you using?

master@62bd61de110b057cbfd6e31e4d0b727d93119c72

### Operating system and version

Fedora 41

### Machine specifications

_No response_
Repository: PowerToys
Issue: Add shortcut conflict detection
Labels: Idea-Enhancement,Product-Settings,Area-Quality

### Description of the new feature / enhancement

This would be an overall enhancement to PowerToys that detects shortcut conflicts...
- Between PowerToys utilities
- Between utilities and other installed apps
- Between utilities and Windows shortcuts

### Scenario when this would be used?

This is useful for knowing when shortcuts don't work when expected :)

### Supporting information

_No response_
Repository: terminal
Issue: Be able to support clicking on embedded links in the mark mode
Labels: Issue-Feature,Area-Interaction,Product-Terminal,In-PR

### Description of the new feature

Currently from https://github.com/microsoft/terminal/pull/13405 support for keyboard use of hyperlinks is supported but does not work for embedded links. For example, when a link is embedded and or does not have the `https://` prefix it does not work. Here is a screenshot of scenario where the embedded links are not accessible via keyboard. ![Image](https://github.com/user-attachments/assets/894ffecb-d410-4cd2-a557-2c7fd3b3d853)


### Proposed technical implementation details

Make embedded links and links that do not have the https:// in the prefix available to be accessed by the mark mode.
Repository: go
Issue: os/user: TestLookupIdServiceAccount failures
Labels: NeedsInvestigation

```
#!watchflakes
default <- pkg == "os/user" && test == "TestLookupIdServiceAccount"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/b/8728802738778929377)):

    === RUN   TestLookupIdServiceAccount
    === PAUSE TestLookupIdServiceAccount


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: go
Issue: runtime:cpu1: TestLockRankGenerated failures
Labels: NeedsInvestigation,compiler/runtime

```
#!watchflakes
default <- pkg == "runtime:cpu1" && test == "TestLockRankGenerated"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/b/8728801341232778673)):

    === RUN   TestLockRankGenerated
        lockrank_test.go:22: C:\b\s\w\ir\x\w\goroot\bin\go.exe run mklockrank.go: exit status 1
            fork/exec C:\b\s\w\ir\x\w\gocache\2d\2d880d9d593a2ac7e3a0097bd5c02c14293d2fbebb5fa81cd6f30d069ab66557-d\mklockrank.exe: The process cannot access the file because it is being used by another process.
    --- FAIL: TestLockRankGenerated (0.48s)


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: godot
Issue: 4.4-dev6 VisualShader: Error: Parameter "version" is null and then after a while crash
Labels: bug,needs testing,topic:shaders

### Tested versions

- Reproducible in: v4.4.dev6.official [1f47e4c4e]

### System information

Windows 11 - Godot 4.4-dev6 - Forward+ - dedicated NVidia RTX 2070 super

### Issue description

the output console will be filled with 
```
ERROR: Parameter "version" is null.
   at: version_is_valid (servers/rendering/renderer_rd/shader_rd.cpp:659)
```

when clicking the eye icon on certain nodes with certain inputs
it seems like it has to do with inv_view_matrix and the preview from the eye icons in the visual shader

### Steps to reproduce

make a visual shader

connect [input: inv_view_matrix] and [input: vertex] into [TransformVectorMult: A x B]
connect the [TransformVectorMult AxB] into [Texture2D: SamplerPort: UV]
connect [Texture2D: SamplerPort: Color] into [Output: Albedo]

now whenever you click the eye icon on the output of either the [TransformVectorMult: A x B] or [Texture2D: SamplerPort: Color]
the output console will be filled with 
```
ERROR: Parameter "version" is null.
   at: version_is_valid (servers/rendering/renderer_rd/shader_rd.cpp:659)
```
and then eventually crash

### Minimal reproduction project (MRP)

N/A
Repository: neovim
Issue: conceal characters should inherit background color of concealed text
Labels: highlight,conceal

### Problem

Conceal characters do not inherit the background of the text they conceal (not applicable when the conceal character highlight group has its own background color, of course)

### Steps to reproduce

```lua
-- minimal.lua
vim.treesitter.query.set(
  'markdown',
  'highlights',
  [[((list_marker_star) @conceal
    (#offset! @conceal 0 0 0 -1)
    (#set! @conceal conceal "◦"))

  (section) @test
  ]]
)
vim.treesitter.highlighter.new(vim.treesitter.get_parser(0, 'markdown'))
vim.wo.conceallevel = 2
vim.wo.concealcursor = 'v'
vim.bo.ft = 'markdown'

-- Regular highlight background not respected
vim.api.nvim_set_hl(0, '@test', { link = 'IncSearch' })

vim.api.nvim_buf_set_lines(0, 0, -1, true, {
  '* Test  ',
  '  * Test',
  '  * Test',
  '  * Test',
})

-- Visual highlight background not respected
vim.cmd.norm('Vj')

-- Same with `hl-Folded`, etc.
```
then `nvim --clean -u minimal.lua`

### Expected behavior

The conceal characters should inherit the background of the characters they conceal

### Nvim version (nvim -v)

Nightly (442d338cb50e4cf08c58cb82b6d33b6d5df9fb1b)

### Vim (not Nvim) behaves the same?

yes, 9.1

### Operating system/version

NixOS 24.05, Linux 6.12.1

### Terminal name/version

kitty 0.37.0

### $TERM environment variable

xterm-kitty

### Installation

neovim-nightly-overlay (nix)
Repository: vscode
Issue: show the installed exts while searching for network error, that will make the search experience uniform
Labels: feature-request,extensions

> Another question: could it be possible to show the installed exts while searching for network error, that will make the search experience uniform
> 
> - network OK
>   same as now
> - network error
>   1. show the error msg
>   2. and show the installed exts below
>  ![Image](https://github.com/user-attachments/assets/81bbab40-d8eb-4bc4-a3a8-5c6ec151c6d1)
>  

 _Originally posted by @heartacker in [#232991](https://github.com/microsoft/vscode/issues/232991#issuecomment-2537583211)_
Repository: vscode
Issue: tab is not aligned for 2 bytes languages like Korean, Chinese, Japanese
Labels: feature-request,editor-core

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.96.0
- OS Version: win 11 pro 24h2

Steps to Reproduce:

1. tabs are not aligned when there's different characters entered before tab.

line 70 - 75 Korean
line 76 - 81 Chinese
line 82 - 87 Japanese

![Image](https://github.com/user-attachments/assets/926cd15f-d446-4223-bb72-af7da4a87590)

here is actual text i used

테				-
테스				-
테스트			-
테스트테			-
테스트테스		-
테스트테스트		-
漢 				-
漢漢				-
漢漢漢			-
漢漢漢漢			-
漢漢漢漢漢		-
漢漢漢漢漢漢		-
す				-
すす				-
すすす			-
すすすす			-
すすすすす		-
すすすすすす		-
Repository: rust
Issue: Invalid suggestion on anonymous lifetime parameter in precise capturing list if there are no input lifetimes
Labels: A-diagnostics,P-low,T-compiler,A-suggestion-diagnostics,D-invalid-suggestion,D-verbose,F-precise_capturing

Reproducer:

```rs
fn f() -> impl Sized + use<'_> {}
```

Current output:

```
error[E0106]: missing lifetime specifier
 --> src/lib.rs:1:28
  |
1 | fn f() -> impl Sized + use<'_> {}
  |                            ^^ expected named lifetime parameter
  |
  = help: this function's return type contains a borrowed value, but there is no value for it to be borrowed from
help: consider using the `'static` lifetime, but this is uncommon unless you're returning a borrowed value from a `const` or a `static`, or if you will only have owned values
  |
1 | fn f() -> impl Sized + use<'static> {}
  |                            ~~~~~~~

error: expected lifetime parameter in `use<...>` precise captures list, found `'_`
 --> src/lib.rs:1:28
  |
1 | fn f() -> impl Sized + use<'_> {}
  |                            ^^
```

Expected:

1. Don't suggest `use<'static>` which is invalid
2. One diagnostic instead of two (while keeping the good hint *this function's return type contains a borrowed value, but there is no value for it to be borrowed from*)