sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: Need a line/word breaker for custom text rendering
Labels: c: new feature,framework,engine,a: internationalization,a: typography,c: proposal,P2,team-engine,triaged-engine

This is a more specific issue that is a part of #35994. For doing custom text rendering on non-rectangular or non-rtl/ltr surfaces, developers need to measure the text that can fit in each line. In order to measure the text, developers need to know appropriate locations in the text where line breaks can occur. This functionality already exists in LibTxt at the Flutter Engine layer, but it is not exposed at the Dart layer.

## Use cases

Anywhere that non-rectangular or non-rtl/ltr text rendering needs to be done (that is, anywhere that the Flutter `Paragraph` cannot be used to render the entire text directly):

### Example 1: Vertical CJK and Mongolian

![vertical CJK and Mongolian](https://user-images.githubusercontent.com/10300220/73817672-8aa13800-4826-11ea-90bc-65ff48030876.png)

Image adapted from [here](https://www.w3.org/International/articles/vertical-text/).

### Example 2: Filling a non-rectangular shape with text

![Text filled shape](https://user-images.githubusercontent.com/10300220/73818110-96d9c500-4827-11ea-8c88-e936664d24cd.png)

[Image source](https://www.raywenderlich.com/5960-text-kit-tutorial-getting-started)

### Example 3: Text around exclusion paths

![Text around exclusion paths](https://user-images.githubusercontent.com/10300220/73818222-dbfdf700-4827-11ea-8865-6ef14c8dbdfb.png)

[Image source](https://developer.apple.com/library/archive/documentation/StringsTextFonts/Conceptual/TextAndWebiPhoneOS/CustomTextProcessing/CustomTextProcessing.html)

## Problem

Given a long string, how does one know where appropriate places to line wrap are?

If the words in the string are separated by spaces like this

```
final myString = 'This is a long string in which each word is separated by spaces.';
```

Then it is easy to find break locations. Any letter with a space before it is fine. However, there are lots of other situations that are not so easy. Here is one example:

```
final myString = 'This-is_a,long.string(in)-which{each}word[is]NOT~separated#by+spaces.';
```

Writing the logic to find the breaks becomes much more complex, especially if [Unicode conformance](https://unicode.org/reports/tr14/) is required.

## Proposal

In order not to require developers to reinvent the wheel when the solution already exists in the Flutter engine, I propose that Flutter expose the LibTxt Line/Word breaker functionality at the Dart level.
Repository: go
Issue: x/review/git-codereview: package documentation for multi-commit branch workflow does not match behavior
Labels: Documentation,help wanted,NeedsFix

The package documentation for `git-codereview` [says](https://godoc.org/golang.org/x/review/git-codereview#hdr-Multiple_Commit_Work_Branches):

> The 'git codereview change' command amends the top commit in the stack (HEAD).

However, [CL 20049](https://golang.org/cl/20049) appears to have removed this behavior, instead stating that some combination `git commit --amend` and `git rebase` should be used instead.

I'd appreciate it if these docs were updated to better explain the current behavior (potentially with an example).

I'm working on a multi-change contribution, and am finding this a little bit confusing to figure out.
Repository: godot
Issue: ColorRect flickers when shown by mouse_entered signal
Labels: discussion,regression,topic:gui

**Godot version:**
3.2 Stable

**OS/device including version:**
macOS Catalina 10.15.3 / MacBookPro11,1

**Issue description:**
When calling show() inside a function on a ColorRect node, from mouse_entered signals, the ColorRect node flickers.

**Steps to reproduce:**
Use the Godot 3.2 project attached.

**Minimal reproduction project:**
[Godot 3.2.zip](https://github.com/godotengine/godot/files/4158725/Godot.3.2.zip)

Video:
[mouse_entered_flicker.mov.zip](https://github.com/godotengine/godot/files/4158730/mouse_entered_flicker.mov.zip)
Repository: rust
Issue: Improve diagnostics for serializing 'static type from Deserialize<'de>
Labels: C-enhancement,A-diagnostics,A-lifetimes,T-compiler,D-confusing,D-newcomer-roadblock

With this code:

```rust
use serde_json;
use serde::Deserialize;

fn foo<'de, D>(b: Vec<u8>) where D: Deserialize<'de> {
    let _ = serde_json::from_slice::<D>(b.as_ref()).unwrap();
}
```

We get this error message:

```rust
error[E0597]: `b` does not live long enough
 --> src/lib.rs:5:41
  |
4 | fn foo<'de, D>(b: Vec<u8>) where D: Deserialize<'de> {
  |        --- lifetime `'de` defined here
5 |     let _ = serde_json::from_slice::<D>(b.as_ref()).unwrap();
  |             ----------------------------^----------
  |             |                           |
  |             |                           borrowed value does not live long enough
  |             argument requires that `b` is borrowed for `'de`
6 | }
  | - `b` dropped here while still borrowed
```

([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=707cd7c8bdd48c7f2f79ffe4fa211416).)

My colleague came to me yesterday asking me to explain this error/help fix the problem. Eventually, I figured out that method call tries to propagate the lifetime bound and fails because the target doesn't have any lifetime bounds. I solved it by applying a HRTB (`D: for<'de> Deserialize<'de>`), which worked out okay.

The errors here are kind of misleading, because the borrowed value does actually live long enough, and in this example `b` is not actually still borrowed at the end of the function.

cc @estebank
Repository: flutter
Issue: Add FloatingActionButton to the end of FlexibleSpaceBar
Labels: c: new feature,framework,f: material design,d: stackoverflow,c: proposal,P3,team-design,triaged-design

<!-- Thank you for using Flutter!

     Please check out our documentation first:
      * https://flutter.dev/
      * https://api.flutter.dev/

     If you can't find the answer there, please consider asking a question on
     the Stack Overflow Web site:
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     Please don't file a GitHub issue for support requests. GitHub issues are
     for tracking defects in the product. If you file a bug asking for help, we
     will consider this a request for a documentation update.

-->
I'm using SliverAppBar with FlexibleSpaceBar as 'flexibleSpace' in my Flutter-app. I want to add FloatingActionButton to the end of FlexibleSpaceBar just like in native android development like on  the screenshot below. The problem is that I don't know how to do it. I haven't found solution in docs.

![4](https://user-images.githubusercontent.com/38351048/73845595-081f7500-4834-11ea-8f49-54c6a5c04783.jpg)
Repository: pytorch
Issue: matmul: no warning when contracting differently named dimensions
Labels: triaged,module: named tensor

## 🐛 Bug
According to [documentation](https://pytorch.org/docs/stable/named_tensor.html) named tensors "use names to automatically check that APIs are being used correctly at runtime, providing extra safety". However, `matmul` does not warn when the dimensions that are being contracted have different names.

## To Reproduce
Steps to reproduce the behavior:

```python
a = torch.randn((2, 3), names=('B', 'X'))
b = torch.randn((3, 5), names=('C', 'E'))
torch.matmul(a, b)
```

This executes without any warning.

## Expected behavior
A warning about non-matching dimensions might be useful

## Environment
PyTorch version: 1.4.0
Is debug build: No
CUDA used to build PyTorch: 10.1

OS: Ubuntu 18.04.3 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.12.0

Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.0.130
GPU models and configuration: GPU 0: Tesla T4
Nvidia driver version: 418.67
cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.5

Versions of relevant libraries:
[pip3] numpy==1.17.5
[pip3] torch==1.4.0
[pip3] torchsummary==1.5.1
[pip3] torchtext==0.3.1
[pip3] torchvision==0.5.0
[conda] Could not collect



cc @zou3519
Repository: go
Issue: net: consider rejecting null byte in LookupHost (and similar) on all platforms consistently
Labels: NeedsInvestigation

This is a followup to issues #31597 and #37031.

It is my current understanding that no valid host can contain the null byte ('\x00'), so any such string input is not valid.

`net.LookupHost` currently operates differently when given an input that contains a null byte. For example, for `net.LookupHost("foo\x00bar")`:

- in Go 1.13, on Windows, it caused a panic (#31597)
- in Go 1.14, on Windows, it returns an error (see [here](https://github.com/golang/go/blob/go1.14beta1/src/net/lookup_windows.go#L107))
- on macOS with cgo DNS resolver, it does the equivalent of `net.LookupHost("foo")`
- on macOS with pure Go DNS resolver, it does something different

It seems that the `getaddrinfo` C API used on many platforms accepts a null-terminated C-style string and cannot be given a string containing null bytes.

As @ianlancetaylor points out, in the `syscall` package we reject strings with embedded null bytes, since they won't work with system calls that expect C strings, see [`syscall.ByteSliceFromString`](https://github.com/golang/go/blob/go1.13.7/src/syscall/syscall.go#L44-L56).

Perhaps this is an opportunity to make Go operate more consistently on such inputs on all platforms by reporting an error when the `name` string contains a null byte. There may be more functions in `net` that could benefit from this input validation, but to be able to make this change, we need to be confident that this change won't break correct Go programs.

/cc @FiloSottile @ianlancetaylor @mikioh @bradfitz
Repository: TypeScript
Issue: JSDoc @param does not work for function variables
Labels: Needs Investigation

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the *entire* template below.
-->

<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:**  3.5.1, 3.7.5

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** jsdoc, param, variable, function

**Code**

```ts
function makeFoo() {
    return (x : number) => {}
}

/**
 * @param x - Comment
 */
const foo = makeFoo();
foo(/* No comment in hover */);

/**
 * @param x - Comment
 */
function foo2(x: number) {
    
}
foo2(/* Comment in hover */)
```

**Expected behavior:**
![image](https://user-images.githubusercontent.com/5655961/73850988-c45c4980-47fa-11ea-9b98-0a1fda8aa913.png)

**Actual behavior:**
![image](https://user-images.githubusercontent.com/5655961/73851011-cd4d1b00-47fa-11ea-98c1-b8728fe61d9f.png)

**Playground Link:** [Playground](http://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=17&pc=29#code/GYVwdgxgLglg9mABAWwIYGsCmAxOcAUAlIgN4CwAUItYgE6ZQi1L4AeiAXImCMgEaZaxALwA+UgF9KUipQD0AKgWVECxAAEADqlqpkidgFpEAYTjJkmMFBUK5lCAgDOURMDyJhKDDjxEA3JTuBIqIAHJwiI4WVq4wSAAWcABugqpyhIGyFIrKVGpaOnoGiMZmMda29hSgkLAIbngATGxcPPyCxORUNNJBzfih5ZbWiPGISam06YRAA)

**Related Issues:** Couldn't find any

-----

For my use case, I use factories to make functions a lot.
```ts
export const lPad = makeOperator3<string, bigint, string, string>(/*args*/);
export const rPad = makeOperator3<string, bigint, string, string>(/*args*/);
export const lTrim = makeOperator1<string, string>(/*args*/);
export const rTrim = makeOperator1<string, string>(/*args*/);
```

And I'd like to add JSDoc to these variables, because the parameter names aren't very descriptive, by themselves (`left, mid, right, arg, etc.`). But it seems like the JSDoc for `@param` does not show up in hover on VS Code and the Playground.
Repository: go
Issue: all: builders and TryBots should check documentation for broken links
Labels: Testing,Documentation,help wanted,Builders,NeedsInvestigation

We occasionally end up with broken or outdated links in documentation (see #46545, https://github.com/golang/go/issues/37042#issuecomment-582448476, #27860, #21951, #19244).

Testing for broken links would not be entirely trivial, but nonetheless pretty straightforward to implement: we have an HTML parser in `golang.org/x/net/html`, and it is easy enough to issue a `HEAD` request for link targets to see if they resolve. (For links with anchors, we would probably want to also check the `Content-Type` header and then parse the actual linked HTML to ensure that the anchor exists.)

CC @golang/osp-team
Repository: kubernetes
Issue: Reevaluate flushing unschedulable pods into activeQ
Labels: sig/scheduling,lifecycle/frozen,needs-triage

/sig scheduling

#72122 suggested the addition of flushing unschedulable pods into the active queue, to mitigate against unknown race conditions that would keep pods in the unschedulable queue forever. The scenario I can think of is that an event that makes the pod more schedulable comes while we are still in its scheduling cycle. But this should have been addressed with #73078.

In any case, as seen in #86373, flushing indistinctively can produce starvation if there are too many unschedulable pods with high-priority, or if scheduling takes too long due to the use of advanced features (like extenders).

So I suggest any of these 2 options:

- [Extreme] Get rid of the flush, since we don't have evidence that it's actually helping more than #73078.
- Limit the number of pods we flush back. We would always flush the oldest ones. Either a (configurable?) hard limit (always flush X) or a dynamic limit (stop once the activeQ is past a threshold). This should be low risk and easy to do.
Repository: flutter
Issue: Web: Cache-able code splitting, Tree Shaking and Routes grouping
Labels: c: new feature,framework,c: performance,dependency: dart,f: routes,customer: crowd,platform-web,c: proposal,a: build,P2,team-web,triaged-web

Currently Flutter for web build command generates a big single Javascript file in release mode. 

It is proposed that new routing APIs should allow groping of related routes and then the build command should generate separate Javascript files for each group of routes these files can than be pre-fetched separately. This will help to improve Time to Interactive TTI score and defer or remove unnecessary JavaScript work that occurs during initial page load.
Repository: go
Issue: x/tools/go/analysis/analysistest: support modules
Labels: help wanted,NeedsInvestigation,Tools,Analysis

Currently the analysistest helper only supports a GOPATH like tree. This is fine for stand alone analyses, but does not help much for analyses designed to run against a particular module. For example, you have an analysis that checks all code in your module correctly/safely interacts with a specific package in your module. Ideally you would be able to write an analysis test with a stub file that is able to load other packages/dependencies of the current module.

/cc @matloob @heschik
Repository: flutter
Issue: RefreshIndicator hidden behind AppBar with `extendBodyBehindAppBar: true`
Labels: framework,f: material design,has reproducible steps,P2,found in release: 3.3,workaround available,found in release: 3.7,team-design,triaged-design

I found this issue that the `RefreshIndicator` doesn't work properly combined with the Scaffold property `extendBodyBehindAppBar: true`.

Here is the code snippet that causes the error. In total the RefreshIndicator is pulled down from above the status bar and therefore the indicator has a long way till being dragged down to the visible body part. If the user drags only half the way the indicator can also be behind the app bar which is for sure not an intended behaviour.
```
Scaffold(
        extendBodyBehindAppBar: true, // true causes a layout error
        appBar: AppBar(...),
        body: RefreshIndicator( 
          onRefresh: () {
            // some logic
          },
          child: ListView(
            children: <Widget>[
```
Repository: storybook
Issue: Add support for Vue SFC syntax to stories
Labels: feature request,vue,addon: docs

**Is your feature request related to a problem? Please describe.**
When writing a story for Vue components inside mdx files, it differs from the way one would write the code inside a .vue file.

Also when reading the story source inside storybook, the code differs from the code one would normally put inside a .vue file.

So there is this mental switch developers have to do, when using storybook as their component documentation. This is especially troublesome for new developers, which in many teams are the main target group of the documentation.

**Describe the solution you'd like**
In addition to writing a Vue story like this:

```mdx
<Story name='basic' height='400px'>{{
  components: { InfoButton },
  template: '<info-button label="I\'m a button!"/>',
}}</Story>
```

It would be nice to add support for stories in this format:

```mdx
<Story name='basic' height='400px'>
<template>
  <info-button label="I\'m a button!"/>
</template>
<script>
  export default {
    components: { InfoButton },
  }
</script>
</Story>
```

**Are you able to assist bring the feature to reality?**
yes
Repository: godot
Issue: Import TextureAtlas as Mesh is not working properly
Labels: bug,topic:core,topic:rendering,confirmed,topic:2d

**Godot version:**
3.2 stable

**OS/device including version:**
Windows10 x64 1809

**Issue description:**
Not sure that issues are the same: #32869 , #35756
Importing TextureAtlas as mesh gives an incorrect results when used in the Sprite and in the AnimatedSprite. The texture is shifted (1) and some frames are distorted and skipped when animation is playing. AnimationFrame panel looks wrong (2)
![atlas](https://user-images.githubusercontent.com/22263042/73872896-252f6480-4883-11ea-91cc-9c6d41f17754.png)

**Output**:  
` drivers/gles3/rasterizer_storage_gles3.cpp:3376 - Condition "!(p_format & VisualServer::ARRAY_FORMAT_VERTEX)" is true.`

**Debugger:**
`mesh_add_surface: Condition "!(p_format & VisualServer::ARRAY_FORMAT_VERTEX)" is true.`

**Steps to reproduce:**
- Import TextureAtlas as mesh
- Use imported textures with Sprite node or AnimatedSprite node as AnimationFrames

**Minimal reproduction project:**
Launch Scene.tscn and switch between the correct AnimatedSprite_texture node (frames imported as textures) and the AnimatedSprite_atlas_mesh node to see the difference:
[atlas.zip](https://github.com/godotengine/godot/files/4161524/atlas.zip)
Repository: TypeScript
Issue: Ensure generated `.d.ts` files compile with no errors under `noImplicitAny`
Labels: Bug,Infrastructure

We recently just had https://github.com/microsoft/TypeScript/issues/36630 opened up on us. This is just a few weeks after #36216. 

I'm pretty sure we already check that our generated `.d.ts` files are valid when the input was valid, but apparently we're not checking under `noImplicitAny`. We would've avoided these bugs if we'd checked with `noImplicitAny`.
Repository: flutter
Issue: Configured font weights do not align with custom font
Labels: framework,d: api docs,a: assets,a: typography,P2,team-framework,triaged-framework

I have a typeface with multiple weights I want access to, and font files for each of these weights. I've configured `pubspec.yaml` with those weights, but they are not used when the identical `FontWeight` is used in a `TextStyle`.

pubspec:

```
  fonts:
    - family: Chivo
      fonts:
        - asset: assets/fonts/Chivo-Regular.ttf
        - asset: assets/fonts/Chivo-Italic.ttf
          style: italic
        - asset: assets/fonts/Chivo-Light.ttf
          weight: 200
        - asset: assets/fonts/Chivo-LightItalic.ttf
          weight: 200
          style: italic
        - asset: assets/fonts/Chivo-Bold.ttf
          weight: 700
        - asset: assets/fonts/Chivo-BoldItalic.ttf
          style: italic
          weight: 700
        - asset: assets/fonts/Chivo-Black.ttf
          weight: 900
        - asset: assets/fonts/Chivo-BlackItalic.ttf
          weight: 900
          style: italic
```

If I then used `FontWeight.bold` in a `TextStyle`, the 900 weight is used instead. This does not line up with the documentation on using custom fonts here: https://flutter.dev/docs/cookbook/design/fonts#pubspecyaml-option-definitions

Should the documentation be updated, or is this an issue that should be fixed in the framework?

There is a workaround: two fonts. I configured one font with the "common" weights (400/700), and a second with the "extreme" weights (200/900), treated as 400/700:

```
  fonts:
    - family: Chivo
      fonts:
        - asset: assets/fonts/Chivo-Regular.ttf
        - asset: assets/fonts/Chivo-Italic.ttf
          style: italic
        - asset: assets/fonts/Chivo-Bold.ttf
          weight: 700
        - asset: assets/fonts/Chivo-BoldItalic.ttf
          style: italic
          weight: 700
    - family: 'Chivo Extreme'
      fonts:
        - asset: assets/fonts/Chivo-Light.ttf
        - asset: assets/fonts/Chivo-LightItalic.ttf
          style: italic
        - asset: assets/fonts/Chivo-Black.ttf
          weight: 700
        - asset: assets/fonts/Chivo-BlackItalic.ttf
          weight: 700
          style: italic
```
Repository: terminal
Issue: closePane vs. closeTab differences?
Labels: Help Wanted,Product-Conpty,Area-Server,Issue-Bug,Priority-2

# Environment

```none
Windows build number: 10.0.18362.592
Windows Terminal version (if applicable): 0.8.10261.0

Any other software?
WSL 2 (Debian 10)
bash 5.0.3
OpenSSH_7.9p1 Debian-10+deb10u1, OpenSSL 1.1.1c
```

Not entirely sure where this lies, but starting here since I can't recreate it elsewhere (putty, cmd.exe)

When closing a WSL session by either middle mouse clicking the tab (NOT the X) or by running the "closeTab" command via a hotkey, my ssh session will terminate and the application that's running receives a SIGHUP.

When closing a WSL session by clicking the X on a tab or by running the "closePane" command via a hotkey, my ssh session will terminate and the application that's running receives both SIGUSR1 (first) and SIGHUP.

This isn't an issue per se, but I'm trying to track down a bug in our own application and part of it seems to be related to how the application was terminated. Our end users don't use Windows Terminal, but in trying to understand how to create this scenario I've been working through different SSH clients.

**What does Windows Terminal do differently when closing a tab using "closePane" versus "closeTab"?**