sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: Inconsistency in the documentation about MainActivity content for v2 embedding enabled
Labels: platform-android,engine,d: wiki,P2,team-android,triaged-android

The documentation seems inconsistency about the content of the `MainActivity` class of a app created with android embedding v2 enabled (default).

1. https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects say to replace the `onCreate` method with a `configureFlutterEngine` method
2. https://flutter.dev/docs/development/packages-and-plugins/plugin-api-migration say to keep the class empty because plugins are registered automatically

The default template when creating app with v2 enabled (the default) is to have the `configureFlutterEngine`  method present. That seems to generate this kind of issues : https://github.com/FirebaseExtended/flutterfire/issues/1669 because plugin are registered twice. Keep class empty seems to fix that
Is `configureFlutterEngine` useful ?
Repository: pytorch
Issue: Batched torch.eig() and gradient of torch.eig() for real eigenvalues
Labels: module: autograd,triaged,module: batching,module: linear algebra

## 🚀 Feature

I propose myself to implement the batched and gradient calculation (backward) for `torch.eig` if the eigenvalues are all real.

## Motivation

The cases where the matrix is real non-symmetric and has real eigenvalues can have quite a lot of applications, for example, for a real invertible matrix `P` and a symmetric matrix `A`, the following matrix `B=PAP^(-1)` should still have real eigenvalues and eigenvectors.
Also, it seems that the `torch.eig` is not as developed as its cousin, `torch.symeig` in terms of the features.

## Pitch

<!-- A clear and concise description of what you want to happen. -->
`torch.eig()` should work as it is now, and it should be able to propagate the gradient if all the eigenvalues are real.
If there is a complex eigenvalue, then it should raise a `RuntimeError`, just like what it does with `.backward()` at the moment.

## Alternatives

<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->

## Additional context

<!-- Add any other context or screenshots about the feature request here. -->
I have a rough implementation of the differentiable `eig` function for real eigenvalues here:
https://gist.github.com/mfkasim1/60e1c1a7b599f163c594dd183c3d4507

cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @vincentqb @vishwakftw @jianyuh @mruberry @heitorschueroff @SsnL
Repository: rust
Issue: Compile error in main code when doc-testing a crate that has the same name as a module
Labels: T-rustdoc,C-bug,A-doctests

In a crate that has the same name as a top-level module, exporting a name from this module causes rustdoc (and only rustdoc) to error when it is ran.

```rust
// Crate name: `this_crate`.
mod this_crate { pub struct Item; }

pub use this_crate::Item;
```

<details>
<summary>error[E0659]: `this_crate` is ambiguous</summary>
<pre>
> cargo test --doc
    Finished test [unoptimized + debuginfo] target(s) in 0.00s
   Doc-tests this_crate
error[E0659]: `this_crate` is ambiguous (name vs any other name during import resolution)
 --> /tmp/test_dir/no-alloc/src/lib.rs:7:9
  |
7 | pub use this_crate::Item;
  |         ^^^^^^^^^^ ambiguous name
  |
  = note: `this_crate` could refer to a crate passed with `--extern`
  = help: use `::this_crate` to refer to this crate unambiguously
note: `this_crate` could also refer to the module defined here
 --> /tmp/test_dir/no-alloc/src/lib.rs:1:1
  |
1 | mod this_crate { pub struct Item; }
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  = help: use `crate::this_crate` to refer to this module unambiguously

error: aborting due to previous error

For more information about this error, try `rustc --explain E0659`.

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
&gt; echo $?
0
</pre>
</details>
Repository: react
Issue: Bug: styles object using css variables and both a shorthand and a specific property renders incorrectly
Labels: Component: DOM,Type: Discussion

React does not produce the correct css inline styles when using css variables for both the shorthand property and another specific one (like `padding` and `paddingRight`).

The styles object:

```js
{
  padding: "calc(var(--spacing) * 1)",
  paddingRight: "calc(var(--spacing) * 3)",
  paddingBottom: "calc(var(--spacing) * 4)"
};
```
produces the following styles:

![image](https://user-images.githubusercontent.com/23476208/72995030-1d39e400-3df0-11ea-9235-0e6ad00718b2.png)

and the following html:
```html
<span style="padding-top: ; padding-right: calc(var(--spacing) * 3); padding-bottom: calc(var(--spacing) * 4); padding-left: ;">App</span>
```

even though the computed properties tab of the dev-tools appear to be correct and the padding is properly rendered in the screen:

![image](https://user-images.githubusercontent.com/23476208/72995225-6e49d800-3df0-11ea-9770-98f062008ca3.png)

If I remove the css-variable, everything works as expected.

**React version**: From v15.0.0 to 16.12.0

_Note_: Below v15.0.0 the styles are correctly produced:

```html
<span style="padding:calc(var(--spacing) * 1);padding-right:calc(var(--spacing) * 3);padding-bottom:calc(var(--spacing) * 4);">App</span>
```


## Steps To Reproduce

1. Add a style object to a component that has both a property shorthand and a specific one (like `padding` and `paddingRight`) and uses a css variable (like `var(--spacing)`.
2. Render that component and inspect using dev-tools.

Link to code example: https://codesandbox.io/s/heuristic-wood-bjr1y

styles object:
```js
{
  padding: "calc(var(--spacing) * 1)",
  paddingRight: "calc(var(--spacing) * 3)",
  paddingBottom: "calc(var(--spacing) * 4)"
};
```
## The current behavior

React does not produces the correct css inline styles when using css variables for both the shorthand property and another specific one:

```html
<span style="padding-top: ; padding-right: calc(var(--spacing) * 3); padding-bottom: calc(var(--spacing) * 4); padding-left: ;">App</span>
```

## The expected behavior

Inline styles using css variables that have both a shorthand and a specific one should produce the correct styles.
```html
<span style="padding: calc(var(--spacing) * 1); padding-right: calc(var(--spacing) * 3); padding-bottom: calc(var(--spacing) * 4);">App</span>
```
Repository: godot
Issue: viewport texture transparency glitch if use panorama_sky from this viewport.
Labels: bug,topic:rendering,confirmed

**Godot version:**
3.2 rc2. 
3.1.2 work correctly.
**OS/device including version:**
win10 64

**Issue description:**
If i use viewport for panorama_sky in node WorldEnvinronment, and use this viewport for sprite texture, then with the change in the size of the sprite, its transparency changes. It should not be like that.
**Steps to reproduce:**
on video, https://youtu.be/Ff2rcxoZLZ8
you can comment/uncomment first string of script and change sprite size in editor.


**Minimal reproduction project:**
in attach. [error.zip](https://github.com/godotengine/godot/files/4104037/error.zip)
Repository: create-react-app
Issue: Option to override Chrome when starting dev server
Labels: issue: proposal,needs triage

### Is your proposal related to a problem?

From the docs:

> By default, Create React App will open the default system browser, favoring Chrome on macOS.

This doesn't _really_ make sense; it either opens the default browser or it doesn't. For example, if:

1. I have Firefox and Chrome open
2. Firefox is my default browser
3. I run `npm start`
4. CRA will open the app in Chrome

### Describe the solution you'd like

I think what `openChrome.applescript` does is amazing for people who use Chrome. It's logical that this should be the default.

What I propose is allowing the user to bypass the `openChrome.applescript` with a environment variable similar to what y'all are doing with `BROWSER=none`. I already have working changes that I could submit as a PR. It:

1. Allows users to specify `BROWSER=default` in `.env`
2. Sets `shouldTryOpenChromeWithAppleScript` to false if `BROWSER` is `default`
3. Returns `BROWSER` to `undefined` so the rest of `openBroswer.js` can do its thing (opening in the default browser)

### Describe alternatives you've considered

I thought about changing `openChrome.applescript` to make it do the same thing with Firefox as it does with Chrome, unfortunately FF doesn't have as good of support as Chrome for AppleScripts.

The only other thought I had was to modify `shouldTryOpenChromeWithAppleScript` to check what the OS default browser is, but I'm not sure if that's possible.

I figure my suggestion would be the least invasive, allowing people to opt-in to this behavior.

### Additional context

Not really sure if there's anything else. Let me know if you'd like me to submit this as a PR.
Repository: flutter
Issue: [camera] give computeBestCaptureSize option
Labels: c: new feature,p: camera,package,c: proposal,team-ecosystem,P3,triaged-ecosystem

I have been trying to take photos with maximum resolution with the flutter camera plugin. however, the resolution of the captured images does never have the best capture size available through Camera2 API, independently of the ResolutionPreset parameter.

Looking at the code I found that the capture size is always using the best CamcorderProfile for ResolutionPreset

[
packages/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java](https://github.com/flutter/plugins/blob/master/packages/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java)

```java
recordingProfile = CameraUtils.getBestAvailableCamcorderProfileForResolutionPreset(cameraName, preset);
captureSize = new Size(recordingProfile.videoFrameWidth, recordingProfile.videoFrameHeight);
previewSize = computeBestPreviewSize(cameraName, preset);
```

The capture size should be the best available resolution for capturing image, like this:
```java
captureSize = CameraUtils.computeBestCaptureSize(streamConfigurationMap);
```
Or give the plugin an option to select a resolution for the capture. Actually, the "computeBestCaptureSize" is implemented but never used in the current version of camera plugin.
Repository: flutter
Issue: Flutter dev server breaks seekTo() in video_player when playing from assets.
Labels: c: new feature,tool,a: video,platform-web,p: video_player,package,P3,team-web,triaged-web

When testing an audio only (MP3) file, VideoPlayerController seekTo(Duration position) always resets the current position to zero when targeting web and using a Chrome client.  It works correctly with an AVD.
Repository: TypeScript
Issue: Jsdoc @this show incorrect type  in inherited method
Labels: Bug

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:
  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the *entire* template below.
-->

<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:**  3.7.3

<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
@this Jsdoc factory

**Code**

```ts
// ts
class Base {
  constructor(obj = {}) {}

  static create<T extends typeof Base> (this: T, obj = {}): InstanceType<T> {
    return Reflect.construct(this, [obj])
  }
}

class Extended extends Base {
  constructor(obj) {
    super(obj)
  }
}

const b = Base.create()
const e = Extended.create()

// js with jsdoc

class Base {
  constructor(obj = {}) {}

  /**
   * @template {typeof Base} T
   * @this T
   * @param {any} obj
   * @returns {InstanceType<T>}
   */
  static create(obj) {
    return Reflect.construct(this, [obj])
  }
}

class Extended extends Base {
  constructor(obj) {
    super(obj)
  }
}

const b = Base.create()
const e = Extended.create()

```

**Expected behavior:**
 The b and e const type should be Base and Extended
**Actual behavior:**
When jsdoc @this is used in the javascript version b  and e are of type Base. The ts version show correct types.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->

**Related Issues:** <!-- Did you find other bugs that looked similar? -->
Repository: pytorch
Issue: [jit] Use `typing.get_type_hints` instead of parsing types manually
Labels: oncall: jit,triaged

This is an weird case but it illustrates the problem (copied from #16492):

```python
import torch
import typing
from typing import List, Tuple

Tuple = {torch.Tensor : int}

def g() -> Tuple[torch.Tensor]:
    return 2

print(typing.get_type_hints(g))
g = torch.jit.script(g)
print(g.graph)
```

The problem is we're parsing types manually instead of using Python to resolve the types. #29623 kind of fixes this in that it calls out to Python to resolve types, but we shouldn't even be parsing types in the first place, since it leads to many paths to resolve types that can be complicated to reason about (e.g. special cases in `script_type_parser.cpp` and `annotations.py`)


This has been brought up before in #29094

cc @suo
Repository: godot
Issue: Editing values inside a sub-inspector cannot be undone if the sub-inspector gets hidden
Labels: bug,topic:editor,confirmed

Godot 3.2 rc1

I was editing a Theme, then unfolded a StyleBox inside it, from which I modified a few `expand_margin_*` properties. Then I wanted to undo what I've done, but Ctrl+Z had no effect.
This might be reproducible with any nested inspector.

1) Open this `theme.tres` in the inspector: [theme.zip](https://github.com/godotengine/godot/files/4105047/theme.zip)
2) Open the `panel` style, set Expand Margin Left to 4
3) Edit another resource
4) Click on the Previous button of the inspector (or double-click again on the theme)
5) Use Ctrl+Z: it does nothing.

Step variants:

3') Close the `panel` style by clicking on it, which folds it.
4') Click again on the `panel` style to unfold it

It used to be a more immediate issue in https://github.com/godotengine/godot/issues/23231, which was fixed, but as soon as you edit something else or even just fold the nested inspector, history is lost again.

That said, I would understand that using Ctrl+Z to undo something you can't see might be confusing, so maybe it could re-show the resource when doing so.

Note: my original use case was to revert the theme (or parts of it) to its *saved values* (and not default values the circle arrows do) because I was just fiddling with it to test a few things. However I could not find a way to do this without restarting the whole editor.
Repository: pytorch
Issue: "Tried to register multiple operators with the same name and the same overload name" error is confusing
Labels: triaged,module: dispatch,better-engineering

I wrote this registration:

```
    auto registry2 = torch::RegisterOperators()
      // Some operations need to be transformed to their batched versions
      .op("aten::mv", torch::RegisterOperators::options()
          .kernel(VMapModeKey, [] (const Tensor& a, const Tensor& b) -> Tensor {
            return at::matmul(a, b.unsqueeze(2)).squeeze(2);
          }))
      ;
```

and it errored with:

```
Tried to register multiple operators with the same name and the same overload name but different schemas: aten::mv(Tensor _0, Tensor _1) -> (Tensor _0) vs aten::mv(Tensor self, Tensor vec) -> (Tensor) (findOrRegisterSchema_ at ../aten/src/ATen/core/dispatch/Dispatcher.cpp:64)
```

I am pretty familiar with this code, but I have no idea what to do. The schemas look the same to me!
Repository: go
Issue: net/http: wrap more errors?
Labels: NeedsInvestigation

While trying to understand some net/http errors, I found that many net/http errors don't wrap their underlying errors yet (run `grep -R "fmt.Errorf.*%v" net/http` to see some).

@bradfitz are you open to making the default be to wrap errors in net/http? That is, can someone do a somewhat indiscriminate pass through net/http, wrapping errors everywhere they see an opportunity to do so?
Repository: pytorch
Issue: MultivariateNormal.rsample: use eigen-decomposition when Cholesky fails
Labels: module: distributions,triaged,enhancement,module: linear algebra

## 🚀 Feature

Similar to [what BoTorch did here](https://github.com/pytorch/botorch/blob/3d8976f51d3bba0f730557ed61668d343df3ff1f/botorch/sampling/qmc.py#L136-L143), for `MultivariateNormal.rsample`, shall we support [in this line](https://github.com/pytorch/pytorch/blob/master/torch/distributions/multivariate_normal.py#L149) to use the eigen-decomposition when Cholesky decomposition fails, especially when the covariance matrix is near-singular or ill-conditioned?


cc @vincentqb @fritzo @neerajprad @alicanb @vishwakftw @SsnL @jianyuh
Repository: flutter
Issue: Allow users to pass in Xcode build settings as env variables to "flutter build ios-framework" FLUTTER_XCODE_
Labels: platform-ios,tool,a: existing-apps,P3,team-ios,triaged-ios

This was done for all other commands via env variables with the `FLUTTER_XCODE_` prefix (like `FLUTTER_XCODE_CODE_SIGN_STYLE`) with https://github.com/flutter/flutter/pull/43553 but was missed when creating `build ios-framework` command.

Example that should work, but doesn't:
```
$ FLUTTER_XCODE_IPHONEOS_DEPLOYMENT_TARGET="9.0" flutter build ios-framework --output=.`
```
Repository: rust
Issue: Lint missing Copy impl/derive on fully public types.
Labels: A-lints,T-lang,C-feature-request

Any public `enum`/`struct` which has only `pub` fields and isn't `#[non_exhaustive]`, can be "manually copied", i.e. a new value can always be produced by copying out the data fields (of the active variant, in the `enum` case) and passing the values back to the constructor.

Therefore, we might want to lint cases in which such a type doesn't implement `Copy`, because the most likely reasons it doesn't are (assuming no `Drop` impl):
* it would be fine but was forgotten
* the fields weren't actually meant to be publicly accessible
  * this could be hinted at by phrasing the lint to express the fact that anyone can copy all the fields out and make a new value out of them

**EDIT**: @dtolnay (in https://github.com/rust-lang/rust/issues/68497#issuecomment-577955798) also pointed out compile-times as a big reason to *deliberately* skip, or make opt-in, some derives.
A workaround, in the opt-in case, could be, at the crate-level:
```rust
#![cfg_attr(not(feature = "clone-impls"), allow(this_lint))]
```

<hr/>

A good (and bad, at the same time) example is `std::ops::Range<T>`, which can be copied by simply doing `r.start..r.end` (or `Range { start: r.start, end: r.end }`, like any `struct`).

It's a bad example because the current (suboptimal) convention avoids `Copy` on types implementing `Iterator` (and I suppose the lint could take that into account), but if anyone else wrote a similar struct (and it wasn't an iterator), they would probably want it to be `Copy`.

cc @Manishearth @oli-obk
Repository: flutter
Issue: Auto-submit bot should set the commit message of the squashed commit
Labels: team-infra,P2,triaged-infra

This came up in the Flutter Engine weekly about the behavior of the commit queue opted into via the "waiting for the tree to go green" label. @dnfield clarified that only the headline of the primary commit message is kept while the descriptions are discarded. Some commit authors put a [significant](https://github.com/flutter/engine/commit/ad582b5089256e56727b2d7306fb097078a3dcdc) [amount](https://github.com/flutter/engine/commit/c7d0fb787922cb60531c415ed7bf652afbaea552) of [effort](https://github.com/flutter/engine/commit/b454251f03f27ff422b2c197761493a9e3133909) in adding a descriptive commit message and keeping the commit message updated across amendments during the review. These messages are also useful when locally reviewing patches and blames. While linking to the PR certainly works, it is one more step to follow from the commit and it would be preferable to keep things in the Git repo instead of needing GitHub for basic code navigation tasks.

As it stands, this behavior is a hinderance to the adoption of the commit queue.
Repository: pytorch
Issue: Reduce RPC branches for Python/Built-inOp/TorchScript
Labels: oncall: jit,triaged,module: rpc

## 🚀 Improvement

Built-inOp/TorchScript code paths could be packed together.

After #32466 and #30630

Consolidate 
`pyRpcBuiltin` and `rpcTorchscript`.
`pyRemoteBuiltin` and `remoteTorchscript`.

Also, in `rpc/api.py`, `def _invoke_rpc` should have 3 branches and perhaps a better name.

Overall, the goal is to refactor python_functions.h/cpp to remove the python dependencies and extract a C++ API (probably moving the python logic into rpc/init.cpp)? 
rpc_sync, rpc_async or rpc_remote should have a pure C++ API for the JIT to call when binding to JIT.

cc @suo @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar
Repository: TypeScript
Issue: Support a file blacklist in tsserver configuration options
Labels: Suggestion,In Discussion,Domain: TSServer

My scenario is this: suppose I'm working in my editor, and I open a file which, by chance, crashes the language service. Repeatedly. (usually because of it's size or shape). Today, after the service crashes 5 times in short order, the service is disabled by the editor (which if it crashes on load, is what will occur). What I propose is this; if the service crashes after a file open request is issued, and we would shut down the service, instead we automatically add the file to a workspace-local tsserver blacklist config (probably in `.vscode/settings.json`) and reload the language service with the new option. The language service will then refuse to actually load the blacklisted file contents, instead reporting them as empty files/empty modules/empty json documents and potentially issue a warning-type error message in the diagnostics that certain files are blacklisted, which may affect the compilation.

cc @mjbvz do you think this'd be a good idea for a slightly more progressive degradation of experience when the language service has trouble with a file?