sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: kubernetes
Issue: Eviction manager should evict terminated pods before running pods
Labels: kind/bug,sig/node,triage/accepted

### What happened?

Consider two pods are running on the node:
1.  pod with a large image size but in terminated state.
2.  running pod which is utilizing disk space just above the eviction limit.

kubelet's eviction manager will evict the running pod first instead of evicting the terminated pod and cleaning up the image.

### What did you expect to happen?

kubelet should evict terminated pods and clean up images first beforing deciding to evict the running pod.

### How can we reproduce it (as minimally and precisely as possible)?

1. create a pod with large image size and let it run to completion (you can write some data to writable layers if there's no large image).
2. create a pod with different image but it should utilize disk space until eviction limit.
3. watch kubelet evict the running pod first.

### Anything else we need to know?

I think we should modify our node reclaim funcs to prioritize terminated pods first - https://github.com/kubernetes/kubernetes/blob/c9092f69fc0c099062dd23cd6ee226bcd52ec790/pkg/kubelet/eviction/helpers.go#L1222

### Kubernetes version

<details>

```console
$ kubectl version
1.31
```

</details>


### Cloud provider

<details>

</details>


### OS version

<details>

```console
# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
```

</details>


### Install tools

<details>

</details>


### Container runtime (CRI) and version (if applicable)

<details>

</details>


### Related plugins (CNI, CSI, ...) and versions (if applicable)

<details>

</details>
Repository: godot
Issue: Subwindows don't close when emitting close_requested()
Labels: needs testing,topic:gui

### Tested versions

Reproducible in:
- v4.4.dev4.official [36e6207bb] (latest version tested)
- v4.3.stable.official [77dcf97d8]
- v4.2.2.stable.official [15073afe3]
- v4.0.alpha1.official [31a7ddbf8] (oldest version tested)

### System information

Windows 11 Home, Version 23H2, OS build 22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3070 Laptop GPU (NVIDIA; 32.0.15.6603) - 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz (16 Threads)

### Issue description

I'm running a subwindow in a scene. When pressing the subwindow's exit button, this subwindow emits its `close_requested` signal. However, when this signal is emitted, the subwindow does not close. Alternatively when pressing alt+f4 on a multi-windowed subwindow, it also does not close.
In my Project Settings, `application/config/auto_accept_quit` is enabled. This setting works when the main window is targeted. But this setting does not apply to the subwindows of this main window.
I expect this setting to be applied to the subwindows of the main window.

### Steps to reproduce

Enable `application/config/auto_accept_quit` -> add a Window node to any arbitrary scene -> run the program -> click on the exit button
or...
Enable `application/config/auto_accept_quit` -> add a Window node to any arbitrary scene -> disable `display/window/subwindows/embed_subwindows` -> run the program -> bring the subwindow into focus -> press alt+f4

### Minimal reproduction project (MRP)

N/A, reproducible in brand new project.
Repository: terminal
Issue: Learn documentation links
Labels: Issue-Feature,Product-Terminal,Needs-Tag-Fix,Area-Chat

### Description of the new feature

The documentation link refers to docs.microsoft.com but should go to learn.microsoft.com. 
![Image](https://github.com/user-attachments/assets/9a6c0ca4-e841-41ab-aeae-247d43a612fe)

Also, the markdown doesn't render as a selectable link.


### Proposed technical implementation details

_No response_
Repository: vscode
Issue: Editor GPU: Scroll x doesn't get applied when moving the cursor
Labels: bug,editor-gpu

Repro:

1. Enable GPU rendering
2. Open a file with a long line
3. Select a line rendered by GPU
4. Scroll to the right
5. Press home, 🐛 the cursor moves but the editor doesn't scroll to the left to reveal it
 
![Image](https://github.com/user-attachments/assets/72153e30-5930-41eb-a702-c3eb5cbdf1e4)
Repository: pytorch
Issue: Remove tensor variable default method fallthrough
Labels: good first issue,triaged,enhancement,oncall: pt2,module: dynamo

### 🐛 Describe the bug

Today at https://github.com/pytorch/pytorch/blob/51e0996d58e6fa40a8d255a26b767c3f3e035943/torch/_dynamo/variables/tensor.py#L589C1-L596C10

we fallthrough and put an arbitrary method in the graph. This is not desired behavior because if this method returns a non-tensor value we will likely hit issues in torch variable that the output generated from a graph node was not the expected type. We should only put methods in the graph which we know we can handle.

To resolve this we should error in this case, which will likely cause many current tests to fail. We should go through these tests and add explicit handlers in tensor variable where they are expected to resolve these failures. 




### Versions

N/A

cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @amjames
Repository: vscode
Issue: Editor GPU: Lines aren't clipped to the viewport and show under line numbers
Labels: bug,editor-gpu

Repro:

1. Enable GPU rendering
2. Open a file with a line longer than 200 characters (to get the scroll bar to show up currently)
3. Scroll to the right

![Image](https://github.com/user-attachments/assets/ff47aa0e-5118-4b3e-80db-f9238f274655)
Repository: pytorch
Issue: [export][non-strict] Passing in kwargs torch.export fails at non_strict_utils.fakify()
Labels: module: bootcamp,triaged,oncall: pt2,oncall: export,empathy-day

### 🐛 Describe the bug

# Repro
```
import logging
import math
import os

import requests

import torch
from PIL import Image
from torch.nn import functional as F
from transformers import BlipForConditionalGeneration, BlipProcessor

def main():
    processor = BlipProcessor.from_pretrained("Salesforce/blip-image-captioning-large")
    model = BlipForConditionalGeneration.from_pretrained(
        "Salesforce/blip-image-captioning-large"
    ).to("cuda")

    img_url = (
        "https://storage.googleapis.com/sfr-vision-language-research/BLIP/demo.jpg"
    )
    raw_image = Image.open(requests.get(img_url, stream=True).raw).convert("RGB")

    # conditional image captioning
    text = "a photography of"
    inputs = processor(raw_image, text, return_tensors="pt").to("cuda")

    out = model.generate(**inputs)
    print(processor.decode(out[0], skip_special_tokens=True))

    exported = torch.export.export(model, tuple(), inputs, strict=False)
```


# Error
```
Traceback (most recent call last):
  ...
  File "scripts/henrylhtsang/repros/aot.py", line 50, in main
    exported = torch.export.export(model, tuple(), inputs, strict=False)
  File "torch/export/__init__.py", line 368, in export
    return _export(
  File "torch/export/_trace.py", line 1031, in wrapper
    raise e
  File "torch/export/_trace.py", line 1004, in wrapper
    ep = fn(*args, **kwargs)
  File "torch/export/exported_program.py", line 122, in wrapper
    return fn(*args, **kwargs)
  File "torch/export/_trace.py", line 1957, in _export
    export_artifact = export_func(  # type: ignore[operator]
  File "torch/export/_trace.py", line 1707, in _non_strict_export
    ) = make_fake_inputs(
  File "torch/_export/non_strict_utils.py", line 206, in make_fake_inputs
    fake_args, fake_kwargs = tree_map_with_path(
  File "torch/utils/_pytree.py", line 1608, in tree_map_with_path
    return treespec.unflatten(func(*xs) for xs in zip(*all_keypath_leaves))
  File "torch/utils/_pytree.py", line 803, in unflatten
    leaves = list(leaves)
  File "torch/utils/_pytree.py", line 1608, in <genexpr>
    return treespec.unflatten(func(*xs) for xs in zip(*all_keypath_leaves))
  File "torch/_export/non_strict_utils.py", line 207, in <lambda>
    lambda kp, val: fakify(fake_mode, kp, val, t_constraints, sources),
  File "torch/_export/non_strict_utils.py", line 96, in fakify
    raise ValueError(f"Unsupported input type {type(t)}")
ValueError: Unsupported input type <class 'transformers.image_processing_base.BatchFeature'>
```


# Notes
- If using strict=True, then it's fine.
- If using strict=False and args instead of kwargs, then it's fine.
- If using strict=False and use kwargs, then it fails.

### Versions

n/a

cc @ezyang @chauhang @penguinwu @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4
Repository: flutter
Issue: Tools integration tests should always stream output
Labels: tool,P2,c: tech-debt,team-tool

There are [200 instances in 53 files](https://github.com/search?q=repo%3Aflutter%2Fflutter+path%3A%2F%5Epackages%5C%2Fflutter_tools%5C%2Ftest%5C%2F%2F+%2Fmanager%5C.run%2F&type=code) where tests in `flutter_tools` uses `processManager.run`, or some variant of that command, which runs an external process, effectively blocks (sometimes using async, but still halts execution from a test perspective), and then, upon completion, checks if the result was successful.

For example, something like this:
```dart
test('flutter does great things', () async {
  ProcessResult result = processManager.run(flutterBin, ['create', 'foo']);
  expect(result, const ProcessResultMatcher());

  result = processManager.run(flutterBin, ['build', 'apk']);
  expect(result, const ProcessResultMatcher());
});
```

There is an inherit problem with this pattern and timeouts. The `flutter_tools` package insists that [no test take longer than 15 minutes](https://github.com/flutter/flutter/blob/cae3f9acd0d95e61afe2f9561640418d4e220549/packages/flutter_tools/dart_test.yaml#L12), and there are overall timeout commitments at the LUCI and CI level (often between 30m and [60m](https://github.com/flutter/flutter/blob/cae3f9acd0d95e61afe2f9561640418d4e220549/.ci.yaml#L1179)).

In practical terms, that means that if any `processManager.run` goes over either a test or task timeout, the output will appear befuddlingly incomplete, and it will be unclear from a triage perspective if the test shard needs re-sharding, the particular test is just taking too long, or if there is an underlying failure, such as a OOM or crash which does not cause the process to complete as expected.

One such example is https://github.com/flutter/flutter/issues/158560:

```txt
15:26 +87: test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart: (setUpAll)
15:26 +87: test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart: flutter build "linux" succeeds without libraries
15:51 +88: test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart: flutter build "apk" succeeds without libraries
30:54 +88 -1: test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart: flutter build "apk" succeeds without libraries [E]
  TimeoutException after 0:15:00.000000: Test timed out after 15 minutes.
  dart:isolate  _RawReceivePort._handleMessage
```

... there is no way to know what `flutter build apk` was doing (was it making progress? did it crash?).

I made a 1-off adjustment in https://github.com/flutter/flutter/pull/158757, but I'd suggest:

- Integration tests in the tool should always stream process output
- There should be a top-level function for doing so, that does it the right way
- A test should assert that integration tests do not call processManager.run directly
Repository: go
Issue: cmd/internal/testdir: Test/fixedbugs/issue57823.go failures
Labels: NeedsInvestigation

```
#!watchflakes
default <- pkg == "cmd/internal/testdir" && test == "Test/fixedbugs/issue57823.go"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/b/8731358591670897665)):

    === RUN   Test/fixedbugs/issue57823.go
    === PAUSE Test/fixedbugs/issue57823.go
    === CONT  Test/fixedbugs/issue57823.go
        testdir_test.go:147: exit status 2
            panic: never GC'd
            
            goroutine 1 gp=0x9c06128 m=0 mp=0x812f6a0 [running]:
            panic({0x80b7c20, 0x80dac6c})
            	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:806 +0x144 fp=0x9c4e774 sp=0x9c4e720 pc=0x80a7554
            main.str({0x80c01ca, 0x8}, {0x80c0302, 0x9})
    ...
            runtime.gcBgMarkWorker(0x9c20400)
            	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgc.go:1412 +0xfd fp=0x9c7e7e8 sp=0x9c7e78c pc=0x805b44d
            runtime.gcBgMarkStartWorkers.gowrap1()
            	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgc.go:1328 +0x27 fp=0x9c7e7f0 sp=0x9c7e7e8 pc=0x805b337
            runtime.goexit({})
            	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/asm_386.s:1393 +0x1 fp=0x9c7e7f4 sp=0x9c7e7f0 pc=0x80ab531
            created by runtime.gcBgMarkStartWorkers in goroutine 1
            	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgc.go:1328 +0x12c
            
    --- FAIL: Test/fixedbugs/issue57823.go (0.46s)


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: godot
Issue: FPS drops considerably if there are a large number of Skeleton3Ds
Labels: discussion,topic:animation,performance

### Tested versions

Reproducible in: v4.3.stable.official [77dcf97d8]

### System information

Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated AMD Radeon RX 7700 XT (Advanced Micro Devices, Inc.; 32.0.12019.1028) - AMD Ryzen 7 7700 8-Core Processor (16 Threads)

### Issue description

I wanted to create an RTS game similar to BFME, but I ran into the problem that the engine is terribly optimized when using many units with a skeleton and animation based on it. I created the simplest model with the simplest animation and only with them I already get 100 fps with 1k units and below 10 fps with 10k units. In this case, the GPU and CPU are practically not involved. I can't use RenderingServer because I don't see that skeletal animations are implemented there in any way, the documentation seems completely unfinished at this point.

### Steps to reproduce

1. Run scene.

### Minimal reproduction project (MRP)

[reproduction.zip](https://github.com/user-attachments/files/17738473/reproduction.zip)
Repository: flutter
Issue: Unsafe `GlobalKey` subtypes
Labels: framework,a: annoyance,P3,team-framework,triaged-framework

```dart
enum AppKeys implements GlobalKey {
  home,
  search,
  settings;

  GlobalKey get _key => GlobalObjectKey(this);

  @override
  BuildContext? get currentContext => _key.currentContext;

  @override
  State? get currentState => _key.currentState;

  @override
  Widget? get currentWidget => _key.currentWidget;
}
```

This crashes because the `GlobalKey` subtype is missing the private `_currentElement` getter.
Repository: rust
Issue: compiletest: `//@ aux-crate` seems to only actually work for dylibs
Labels: T-bootstrap,C-bug,A-compiletest,E-needs-investigation

... And it seems to never hit staticlibs or rlibs?
Repository: flutter
Issue: [camera_android] Crash CameraDevice was already closed `unlockAutoFocus` > `checkIfCameraClosedOrInError`
Labels: platform-android,p: camera,package,P2,c: flake,team-android,triaged-android

Seeing this in packages CI as Firebase flakes:

```
java.lang.IllegalStateException: CameraDevice was already closed
     FATAL EXCEPTION: CameraBackground
Process: io.flutter.plugins.cameraexample, PID: 23790
java.lang.IllegalStateException: CameraDevice was already closed
	at android.hardware.camera2.impl.CameraDeviceImpl.checkIfCameraClosedOrInError(CameraDeviceImpl.java:2445)
	at android.hardware.camera2.impl.CameraDeviceImpl.submitCaptureRequest(CameraDeviceImpl.java:1237)
	at android.hardware.camera2.impl.CameraDeviceImpl.capture(CameraDeviceImpl.java:1099)
	at android.hardware.camera2.impl.CameraCaptureSessionImpl.capture(CameraCaptureSessionImpl.java:189)
	at io.flutter.plugins.camera.Camera.unlockAutoFocus(Camera.java:807)
	at io.flutter.plugins.camera.Camera$3.onCaptureCompleted(Camera.java:719)
	at android.hardware.camera2.impl.CameraCaptureSessionImpl$1.lambda$onCaptureCompleted$4$android-hardware-camera2-impl-CameraCaptureSessionImpl$1(CameraCaptureSessionImpl.java:708)
	at android.hardware.camera2.impl.CameraCaptureSessionImpl$1$$ExternalSyntheticLambda1.run(Unknown Source:8)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.os.HandlerThread.run(HandlerThread.java:67)
```
See link from https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8731360356815402769/+/u/Run_package_tests/Firebase_Test_Lab/stdout

I see this mentioned in comment  https://github.com/flutter/flutter/issues/92762#issuecomment-1408013677 but I _think_ that issue is tracking something different.
Repository: godot
Issue: Godot internationalization system has an API design error regarding pluralization
Labels: enhancement,discussion,usability,topic:gui

### Tested versions

4.3

### System information

any

### Issue description

The two apis for pluralization in the Godot i18n system (Object.tr_n and TranslationServer.translate_plural) only allow two strings to be passed as arguments (one normal and one plural).

Of course, this api assumes that the game is developed in a language that only has two pluralization cases (I'm guessing this is English). But there are obviously a lot of languages ​​with different cases.

If a game development team chooses a language that uses more than two cases as their dev language, then this api will not work at all!

The correct api design would be to pass an array of pluralization strings here to handle languages ​​with different pluralization rules.

Reference:
[cldr plurals rule](https://github.com/unicode-org/cldr-json/blob/ab05c489c485b9b7a3b90dabb13d612a044a67cb/cldr-json/cldr-core/supplemental/plurals.json)
[GNU gettext plural chapter](https://www.gnu.org/software/gettext/manual/html_node/Plural-forms.html)

### Steps to reproduce

N / A

### Minimal reproduction project (MRP)

N / A
Repository: rust
Issue: "one of the expressions' fields has a method of the same name"'s help suggests adding `0.` instead of `.0`
Labels: A-diagnostics,T-compiler

### Code

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=899783497cf148043b6fe15a5af2efba

```Rust
struct Outer<'a>(&'a str);

fn main() {
    let outer = Outer("hi");
    outer.contains("foo");
}
```

### Current output

```Shell
error[E0599]: no method named `contains` found for struct `Outer` in the current scope
 --> src/main.rs:5:11
  |
1 | struct Outer<'a>(&'a str);
  | ---------------- method `contains` not found for this struct
...
5 |     outer.contains("foo");
  |           ^^^^^^^^ method not found in `Outer<'_>`
  |
  = help: items from traits can only be used if the trait is implemented and in scope
  = note: the following trait defines an item `contains`, perhaps you need to implement it:
          candidate #1: `RangeBounds`
help: one of the expressions' fields has a method of the same name
  |
5 |     outer.0.contains("foo");
  |           ++

For more information about this error, try `rustc --explain E0599`.
error: could not compile `playground` (bin "playground") due to 1 previous error
```

### Desired output

```Shell
error[E0599]: no method named `contains` found for struct `Outer` in the current scope
 --> src/main.rs:5:11
  |
1 | struct Outer<'a>(&'a str);
  | ---------------- method `contains` not found for this struct
...
5 |     outer.contains("foo");
  |           ^^^^^^^^ method not found in `Outer<'_>`
  |
  = help: items from traits can only be used if the trait is implemented and in scope
  = note: the following trait defines an item `contains`, perhaps you need to implement it:
          candidate #1: `RangeBounds`
help: one of the expressions' fields has a method of the same name
  |
5 |     outer.0.contains("foo");
  |          ++

For more information about this error, try `rustc --explain E0599`.
error: could not compile `playground` (bin "playground") due to 1 previous error
```

### Rationale and extra context

This is an incredibly small change but I feel like suggesting `.0` rather than `0.` is more intuitive, as it better represents accessing the inner field rather than `0.`, which feels like an invalid rust snippet.

In Rust analyzer, the suggestion is also a little more confusing:
```
no method named `contains` found for reference `&Purged<'_>` in the current scope
method not found in `&Purged<'_>`rustc Click for full compiler diagnostic
example.rs(487, 48): one of the expressions' fields has a method of the same name: `0.`
```


Ultimately it produces correct code but it's just not as straightforward.

### Other cases

```Rust

```

### Rust Version

```Shell

Build using the Nightly version: 1.84.0-nightly

(2024-11-12 f7273e0044ad8f35ad27)
```

### Anything else?

_No response_
Repository: pytorch
Issue: torch.from_numpy() returns a cpu tensor, even under `with torch.device("meta")`
Labels: triaged,module: numpy,module: meta tensors

repro:
```
import torch
import numpy as np

with torch.device('meta'):
    x = torch.from_numpy(np.ones(3))
    # prints "cpu"
    print(x.device)
```

We've worked pretty hard to get most constructors to work on the device context manager (e.g. `torch.tensor(3)`), so it seems reasonable to get `torch.from_numpy()` to behave similarly.

internal xref: https://fb.workplace.com/groups/1075192433118967/permalink/1543954622909410/

cc @mruberry @rgommers @ezyang @eellison
Repository: pytorch
Issue: Bad error message for malformed args during export
Labels: oncall: pt2,module: dynamo,oncall: export

Found during user empathy day 11-13-24
### 🐛 Describe the bug

The below repro yields a cryptic dynamo error:
`torch._dynamo.exc.Unsupported: Observed exception` 
see full error: https://gist.github.com/mlazos/697b326977dad55c5298d74e8d8df103

This was tricky as I had to guess what the exception is. It looks like we just need to add more information to `ExceptionVariable` to render properly and give more information to the user about which exception was thrown. I was able to guess my way out of this, but our users would definitely be confused by this.

```
from transformers import T5Tokenizer, T5ForConditionalGeneration
import os

tokenizer = T5Tokenizer.from_pretrained("google-t5/t5-small")
model = T5ForConditionalGeneration.from_pretrained("google-t5/t5-small")

input_ids = tokenizer("The <extra_id_0> walks in <extra_id_1> park", return_tensors="pt").input_ids
labels = tokenizer("<extra_id_0> cute dog <extra_id_1> the <extra_id_2>", return_tensors="pt").input_ids

import torch

# exported = torch.export.export(model, (), kwargs={"input_ids": input_ids, "labels": labels}, strict=True)
exported = torch.export.export(model, (input_ids, labels), strict=True)
```



### Versions

e754611d190b323e53c5d17db0dc39a96687513c

cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @amjames @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4