sharjeelyunus/github-issues-dataset huggingface dataset:
Repository: flutter
Issue: Preserve functionality of `ModalRoute.onPopInvoked` to maintain backward compatibility
Labels: framework,f: routes,P2,team-framework,triaged-framework

Hi, I am writing to propose a modification to the ModalRoute class that would help maintain backward compatibility in light of a breaking change introduced in Flutter 3.24 regarding the PopScope widget and related methods.

## Context

I have developed a bottom sheet package called [smooth_sheets](https://github.com/fujidaiti/smooth_sheets) that provides custom modal routes to show modal bottom sheets. This package, like many others, relies on certain behaviors of the Flutter framework that have been affected by recent changes.

## Current Issue

1. The modal route in my package uses `ModalRoute.onPopInvoked` method to invoke `PopScope.onPopInvoked` callback when the user swipes the sheet down to dismiss the modal.
3. Flutter 3.24 has introduced [a breaking change](https://docs.flutter.dev/release/breaking-changes/popscope-with-result) related to the PopScope widget, and `PopScope.onPopInvoked` is now deprecated.
4. Consequently, `ModalRoute.onPopInvoked` is also deprecated and no longer calls `PopScope.onPopInvoked` callback. This is why PopScope doesn't work with my modals in the latest SDK.

The only apparent solution is to replace `Route.onPopInvoked` with `Route.onPopInvokedWithResult`, which was newly added in Flutter 3.24. However, this forces package users to use the latest Flutter version, which is not ideal for maintaining broad compatibility and ease of use.

## Proposed Solution

To address these issues and maintain backward compatibility, I would greatly appreciate if the SDK could revert the following deletion made in [this commit](https://github.com/flutter/flutter/commit/007faa980d10f2412252b0237c0c2daefcce5f5a#diff-748ff41c8eac8d1b2daddbdc16ae69880172e1790662d957824518e1c1c4e47aL1737-L1739), until `Route.onPopInvoked` method is completely deleted:

```diff
// In ModalRoute class
- @override
- void onPopInvoked(bool didPop) {
-  for (final PopEntry popEntry in _popEntries) {
-    popEntry.onPopInvoked?.call(didPop);
-  }
- }
```

Thanks.
Repository: ui
Issue: [feat]: Provide prop to make popover component width dynamic or fit trigger size
Labels: area: request

### Feature description

According to @a1danw's report in issue #3045, components like `Dropdown`, `Popover`, and `Combobox` with fixed widths should be able to expand to match the width of their trigger button.

As suggested in this [comment](https://github.com/shadcn-ui/ui/issues/3045#issuecomment-2005644793), adding the `w-[--radix-popover-trigger-width]` class to the content element of the component resolves this issue.

For example:

```tsx
<Popover>
  <PopoverTrigger>Trigger</PopoverTrigger>
  <PopoverContent className="w-[--radix-popover-trigger-width]">
    Place content for the popover here.
  </PopoverContent>
</Popover>
```

### Output
![popover](https://github.com/user-attachments/assets/73c063a7-b22d-48ab-bfdf-416bc7d2ffb1)

I suggest a prop is exposed to provide this functionality or at least a simple note is added to the docs on the individual components for future users.

### Affected component/components

Dropdown, Popover, Combobox

### Additional Context

None

### Before submitting

- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs
Repository: terminal
Issue: Author a new default color scheme (to replace Campbell)
Labels: Area-Settings,Product-Terminal,Issue-Task

There's been some internal discussions around replacing Campbell as the default scheme.
* There are parts where the contrast isn't great
* The chroma is super inconsistent
* _some other words about colors that Leonard said that sounded smart_ too.

I'm filing this to track that discussion
Repository: vscode
Issue: Rename widget logging
Labels: debt

* do one rename
* enable trace log
* scroll in the editor
* the log is flooded with messages like those ⏬ 


```
2024-08-28 17:37:26.171 [trace] RenameWidget invoking afterRender, position:  null
2024-08-28 17:37:26.171 [trace] RenameWidget invoking cancelInput, caller: afterRender (because position is null), _currentCancelInput: undefined
2024-08-28 17:37:26.189 [trace] RenameWidget invoking afterRender, position:  null
2024-08-28 17:37:26.189 [trace] RenameWidget invoking cancelInput, caller: afterRender (because position is null), _currentCancelInput: undefined
2024-08-28 17:37:26.197 [trace] RenameWidget invoking afterRender, position:  null
2024-08-28 17:37:26.197 [trace] RenameWidget invoking cancelInput, caller: afterRender (because position is null), _currentCancelInput: undefined
2024-08-28 17:37:26.206 [trace] RenameWidget invoking afterRender, position:  null
```
Repository: ant-design
Issue: Sorting on a table with the sticky prop and fixed columns breaks alignment
Labels: 🐛 Bug,Inactive

### Reproduction link

[![Edit on StackBlitz](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/edit/antd-reproduce-5x-cfowqs?file=demo.tsx)

### Steps to reproduce

- Create an Ant Design Table with at 10 or so columns and at least 1 fixed column on the left
- Add the sorter property to all columns
- Set the sticky property on the table
- Using the tab key, navigate to the last column

### What is expected?

The table should focus the last column and move the entire table to the right ensuring the table header columns and row data columns are aligned.

### What is actually happening?

The table header columns move to the right but the row data columns do not causing misalignment.

<img width="732" alt="Screenshot 2024-08-28 at 11 40 11 AM" src="https://github.com/user-attachments/assets/6a9e6683-b3f1-44ec-98d3-983a2bef47a7">

| Environment | Info |
| --- | --- |
| antd | 5.15.4 |
| React | 17.0.2 |
| System | MacOS |
| Browser | Chrome |

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Repository: pytorch
Issue: DISABLED test_transformerencoderlayer_cuda_float32 (__main__.TestNNDeviceTypeCUDA)
Labels: module: rocm,triaged,skipped

Platforms: rocm

Broken by https://github.com/pytorch/pytorch/pull/133331

cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang
Repository: pytorch
Issue: [docs] We should add a lint for bullet points and multiple lines
Labels: module: docs,module: lint,triaged

People (me) commonly get this wrong: https://stackoverflow.com/questions/54677795/python-and-sphinx-bullet-point-list-in-multiline-google-style-docstring

cc @svekars @brycebortree @tstatler
Repository: deno
Issue: Normalize error message grammar (TS/JS)
Labels: feat

 There are a variety of different ways errors in Deno's TS/JS layer are raised. Some are sentence case, others not. Some end with a period, others do not. Some provide the current state of the system, others do not.

Without a standard error guide, it makes it hard for new contributors to determine how to format error message. Furthermore, without a standard error guide, it makes it hard for users to know what to expect.

We just went through the `std` and normalized the errors there. We should do the same with the JavaScript / TypeScript code in the cli / runtime. There is an issue about improving error messages in the cli [1] which is orthogonal to this.

I think we should start with the Error Guide used in the `std` and see if that's a good fit for the JavaScript / TypeScript code in the cli  [2].

[1] https://github.com/denoland/deno/issues/24699
[2] https://github.com/denoland/std/issues/5574
Repository: flutter
Issue: [engine, riscv64] Fuschia LLVM toolchain fails to link
Labels: engine,P3,team-engine,triaged-engine

### Steps to reproduce

```
/home/tcna/workspace-automation/app/engine/src/flutter/buildtools/linux-x64/clang/bin/clang++ --target=riscv64-unknown-linux-gnu --sysroot /home/tcna/workspace-automation/app/riscv64_sysroot -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -pthread -Wl,--undefined-version --sysroot=/home/tcna/workspace-automation/app/riscv64_sysroot  -Wl,-O2 -Wl,--gc-sections -Wl,--as-needed -o ./so.unstripped/libtessellator.so -L/home/tcna/workspace-automation/app/engine/src/flutter/buildtools/linux-x64/clang/lib -Wl,--build-id=sha1 -Wl,-soname=libtessellator.so @./libtessellator.so.rsp && { /home/tcna/workspace-automation/app/engine/src/flutter/buildtools/linux-x64/clang/bin/llvm-readelf -d ./so.unstripped/libtessellator.so | grep SONAME ; /home/tcna/workspace-automation/app/engine/src/flutter/buildtools/linux-x64/clang/bin/llvm-nm -gD -f posix ./so.unstripped/libtessellator.so | cut -f1-2 -d' '; } > ./libtessellator.so.tmp && if ! cmp -s ./libtessellator.so.tmp ./libtessellator.so.TOC; then mv ./libtessellator.so.tmp ./libtessellator.so.TOC; fi && /home/tcna/workspace-automation/app/engine/src/flutter/buildtools/linux-x64/clang/bin/llvm-strip -o ./libtessellator.so ./so.unstripped/libtessellator.so
ld.lld: error: /home/tcna/workspace-automation/app/riscv64_sysroot/usr/lib/riscv64-linux-gnu/libc.so:5: cannot find /lib/riscv64-linux-gnu/libc.so.6 inside /home/tcna/workspace-automation/app/riscv64_sysroot
>>> GROUP ( /lib/riscv64-linux-gnu/libc.so.6 /usr/lib/riscv64-linux-gnu/libc_nonshared.a  AS_NEEDED ( /lib/ld-linux-riscv64-lp64d.so.1 ) )
>>>         ^
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
```

This is a LLVM issue that is resolved in more current LLVM build.

### Expected results

Link without error

### Actual results

```
>>> GROUP ( /lib/riscv64-linux-gnu/libc.so.6 /usr/lib/riscv64-linux-gnu/libc_nonshared.a  AS_NEEDED ( /lib/ld-linux-riscv64-lp64d.so.1 ) )
>>>         ^
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
```

### Code sample

<details open><summary>Code sample</summary>

```dart
[Paste your code here]
```

</details>


### Screenshots or Video

<details open>
<summary>Screenshots / Video demonstration</summary>

[Upload media here]

</details>


### Logs

<details open><summary>Logs</summary>

```console
[Paste your logs here]
```

</details>


### Flutter Doctor output

<details open><summary>Doctor output</summary>

```console
[Paste your output here]
```

</details>
Repository: opencv
Issue: Missing opencv_world4100.dll and opencv_world4100d.dll in Bin Folder during Extraction using GitHub Actions
Labels: bug,category: build/install,platform: win32

### System Information

GitHub Actions Workflow
Windows environment
OpenCV version: 4.10.0

### Detailed description

When extracting the OpenCV 4.10.0 release using GitHub Actions, the opencv_world4100.dll and opencv_world4100d.dll files are missing in the bin directory. However, the corresponding .pdb files (opencv_world4100.pdb and opencv_world4100d.pdb) are present. This issue occurs when extracting the bin folder (opencv\build\x64\vc16\bin) using a PowerShell script.

### Steps to reproduce

1. Set up a GitHub Actions workflow using the following YML commands:
```
- name: Download and Extract OpenCV
  shell: pwsh
  run: |
    curl -L "https://github.com/opencv/opencv/releases/download/4.10.0/opencv-4.10.0-windows.exe" -o opencv_binary.exe
    ./opencv_binary.exe -y -d .
```
2. After running the above script, navigate to the bin folder located at opencv\build\x64\vc16\bin.
3. Observe that the .dll files (opencv_world4100.dll and opencv_world4100d.dll) are missing, while the .pdb files are present.

### Issue submission checklist

- [X] I report the issue, it's not a question
- [X] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution
- [X] I updated to the latest OpenCV version and the issue is still there
- [ ] There is reproducer code and related data files (videos, images, onnx, etc)
Repository: node
Issue: AbortSignal.any() causes memory leak
Labels: memory,abortcontroller

### Version

v22.6.0

### Platform

```text
Microsoft Windows NT 10.0.22631.0 x64
Linux ****** 4.4.0-22621-Microsoft #3672-Microsoft Fri Jan 01 08:00:00 PST 2016 x86_64 x86_64 x86_64 GNU/Linux
```


### Subsystem

https://nodejs.org/api/globals.html#class-abortsignal

### What steps will reproduce the bug?

Run this and watch memory usage. 
 

```javascript
const formatMemoryUsage = (data) => `${Math.round(data / 1024 / 1024 * 100) / 100} MB`;

let memoryData = process.memoryUsage();
console.log('Mem before loop', formatMemoryUsage(memoryData.rss));

for (let i = 0; true; i++) {
    const abortController = new AbortController();
    const signal = abortController.signal;
    const composedSignal = AbortSignal.any([signal]);

    if (i === 1000000) {
        break;
    }
}

memoryData = process.memoryUsage();
console.log('Mem after 1 million iteration', formatMemoryUsage(memoryData.rss));
```

This is what I get on my local machine 
![image](https://github.com/user-attachments/assets/af4db4cd-c1bf-4e51-a0b1-c61e747894f6)

### How often does it reproduce? Is there a required condition?

Always reproducible as far as I can tell

### What is the expected behavior? Why is that the expected behavior?

Memory post loop execution should be fairly equivalent to the first log but somehow the `const composedSignal = AbortSignal.any([signal]);` does not get cleaned up from memory, I would expect this to get cleaned properly or if this is the intended behavior to have a clear warning in the documentation. 

### What do you see instead?

We see a memory leak that will eventually lead to an out of memory error. 

### Additional information

This has been tested on Node 22.6 on different machine and both Windows + Unix versions. Happy to provide more details if needed
Repository: vscode
Issue: Enable trust link in getting started walkthrough does not run the correct command
Labels: bug,workspace-trust,getting-started

1. Open an empty VS Code window.
2. Set `security.workspace.trust.emptyWindow` to false. Reload VS Code if needed.
3. Navigate to the Learn the Fundamentals walkthrough.
4. Click on the step "Safely browse and edit code".
5. Click on "enable trust".
6. :bug: A trusted domains file pops out. Instead, the link should run the command "Workspaces: Manage Workspace Trust"
Repository: PowerToys
Issue: Explorer Add-In to copy file(s) and not the shortcut
Labels: Needs-Triage

### Description of the new feature / enhancement

Just as one can select file(s) for copying allow an option to select a shortcut but copy the target file.

### Scenario when this would be used?

When users have many files stored across multiple folders but use file shortcuts for a unified view this allows copying these files in a simple straight forward way.

### Supporting information

In my research the only way to accomplish this is with scripting and that does not allow for dynamic file selection.
Repository: pytorch
Issue: [c10d][MPI] Attempting to create a new group after MPI causes "RuntimeError: Underlying Non-PrefixStore shouldn't be null"
Labels: oncall: distributed,triaged,module: mpi

### 🐛 Describe the bug

```python
import torch

torch.distributed.init_process_group(backend="mpi")
nccl_group = torch.distributed.new_group(backend="nccl")
```

```
[rank0]: Traceback (most recent call last):
[rank0]:   File "/opt/pytorch/pytorch/repro.py", line 4, in <module>
[rank0]:     nccl_group = torch.distributed.new_group(backend="nccl")
[rank0]:   File "/opt/pytorch/pytorch/torch/distributed/c10d_logger.py", line 97, in wrapper
[rank0]:     func_return = func(*args, **kwargs)
[rank0]:   File "/opt/pytorch/pytorch/torch/distributed/distributed_c10d.py", line 4577, in new_group
[rank0]:     return _new_group_with_tag(
[rank0]:   File "/opt/pytorch/pytorch/torch/distributed/distributed_c10d.py", line 4660, in _new_group_with_tag
[rank0]:     pg, pg_store = _new_process_group_helper(
[rank0]:   File "/opt/pytorch/pytorch/torch/distributed/distributed_c10d.py", line 1783, in _new_process_group_helper
[rank0]:     backend_class = ProcessGroupNCCL(
[rank0]: RuntimeError: Underlying Non-PrefixStore shouldn't be null.
```

### Versions

main

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
Repository: flutter
Issue: [web] unify CkPaint and SwasmPaint classes
Labels: engine,platform-web,c: rendering,e: web_canvaskit,P2,c: tech-debt,e: web_skwasm,team-web,triaged-web

In https://github.com/flutter/engine/pull/54818 `CkPaint` becomes essentially a PODO. It's not backed by the C++ `SkPaint` until the paint is used to draw something. This means the class is almost renderer-agnostic.

We could take it further and make it fully agnostic. This can be done either in the same PR where `SkwasmPaint` moves to the PODO model, or immediately after that.
Repository: flutter
Issue: Warn when Flutter metadata in AndroidManifest.xml is specified in the wrong spot.
Labels: c: new feature,tool,c: proposal,team-tool

Some Flutter metadata keys (like "io.flutter.embedding.android.EnableImpeller"), must be specified under the `<application>` tag while others (like "io.flutter.Entrypoint") under the `<activity>` tag.

We try to document which keys go where but this relies on diligence while [pasting in the values in the XML](https://github.com/flutter/flutter/issues/154252). Other times, [documentation is missing](https://github.com/flutter/engine/pull/54814) and there is some trial and error.

The different places where the keys are read only care about the metadata keys they understand. And so, it is hard for these checks to warn on unexpected keys.

There should ideally be a single registry of all keys Flutter cares about. That way, every instance of a key that is in the wrong place can emit a warning for the user.
Repository: vscode
Issue: context `"inlineChatFocused": true` remains after closing generate cell
Labels: bug,notebook

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 
- OS Version: 

Steps to Reproduce:

1. open a notebook with a code cell
2. click the generate button below the cell
3. ask copilot to create a cell to `print the working directory`
4. press escape to get rid of the generated cell and chat
5. focus the code cell and press `shift+enter`

:bug: cell does not run because `"inlineChatFocused": true`
Repository: pytorch
Issue: [dashboard][aarch64] fp16 is slower than bf16
Labels: module: performance,triaged,module: arm,oncall: pt2

From https://github.com/pytorch/pytorch/pull/134282#issuecomment-2307157197, in the aarch64 dashboard results, if we benchmark with fp16, it is 2x~10x slower than bf16, often causing timeout in cases.

# bfloat16
https://hud.pytorch.org/benchmark/huggingface/inductor_no_cudagraphs?dashboard=torchinductor&startTime=Fri,%2016%20Aug%202024%2013:17:17%20GMT&stopTime=Fri,%2023%20Aug%202024%2013:17:17%20GMT&granularity=hour&mode=inference&dtype=bfloat16&deviceName=cpu%20(aarch64)&lBranch=main&lCommit=ca3f48dd5ba387cdbf1b5106e4050e8b5c2f175c&rBranch=main&rCommit=ca3f48dd5ba387cdbf1b5106e4050e8b5c2f175c

# float16 
https://hud.pytorch.org/benchmark/huggingface/inductor_no_cudagraphs?dashboard=torchinductor&startTime=Fri,%2016%20Aug%202024%2013:12:39%20GMT&stopTime=Fri,%2023%20Aug%202024%2013:12:39%20GMT&granularity=hour&mode=inference&dtype=float16&deviceName=cpu%20(aarch64)&lBranch=desertfire/aarch64_4&lCommit=6078701acfe49369714d45653eb3b662dbe02106&rBranch=desertfire/aarch64_4&rCommit=6078701acfe49369714d45653eb3b662dbe02106

cc @msaroufim @malfet @snadampal @milpuz01 @ezyang @chauhang @penguinwu
Repository: go
Issue: time: TestAfterTick failures
Labels: NeedsInvestigation

```
#!watchflakes
default <- pkg == "time" && test == "TestAfterTick"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/b/8738339611694488129)):

    === RUN   TestAfterTick
    === PAUSE TestAfterTick


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: go
Issue: net/http: http.ReadResponse does not handle 100-continue
Labels: NeedsInvestigation

### Go version

go 1.22.5, but also on go.dev/play on 1.23

### Output of `go env` in your module/workspace:

```shell
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/pivotal/.cache/go-build'
GOENV='/home/pivotal/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/pivotal/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/pivotal/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.5'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3271148184=/tmp/go-build -gno-record-gcc-switches'
```


### What did you do?

Issue two requests with `Expect: 100-continue` headers, to the same server. One using http.DefaultClient.Do(), and the other using raw network connections and parsing the output.  Then examine the returned data.

[Reproduction on go.dev](https://go.dev/play/p/fB2Mtrl0X8S)

### What did you see happen?

The final status code in the response object was 100.

### What did you expect to see?

The final status code returned should be a 405 (method not allowed). There may be other differences in how `http.ReadResponse()` works compared to the `readResponse()` function in transport.go as well. Can the logic for those two functions be shared?
Repository: go
Issue: time: TestIssue5745 failures
Labels: NeedsInvestigation

```
#!watchflakes
default <- pkg == "time" && test == "TestIssue5745"
```

Issue created automatically to collect these failures.

Example ([log](https://ci.chromium.org/b/8738339611694488129)):

    === RUN   TestIssue5745


— [watchflakes](https://go.dev/wiki/Watchflakes)
Repository: go
Issue: x/vulndb: add a lint check for unmerged modules
Labels: vulncheck or vulndb

Add a lint check for vulndb reports to ensure that if modules can be merged (they have the same module and packages, but possibly distinct versions), then they are merged. This will make it less likely for us to submit UNREVIEWED reports that incorrectly mark an entire module as vulnerable.
Repository: vscode
Issue: Support reverse search in tree find
Labels: feature-request,under-discussion,debug-console

Once #225417 is done, the remaining thing that the filter widget has that find does not is reverse search.

If we support that in tree find, it would enable us to remove the debug filter widget, which has some issues currently.