TEDHRLR done. Not working

rosetta_balcanica.py

@@ -17,13 +17,14 @@
 #!/usr/bin/env python
 
 import datasets, logging
+from itertools import permutations
 
 logging.basicConfig(format='[%(name)s] %(levelname)s -> %(message)s')
 logger = logging.getLogger(__name__)
 logger.setLevel(logging.DEBUG)
 
-_SUPPORTED_WB_LANGS = ['ma', 'sh']
-_VALID_LANGUAGE_PAIRS = [('en', wb_lang) for wb_lang in _SUPPORTED_WB_LANGS] 
+_SUPPORTED_WB_LANGS = ['en', 'ma', 'sh']
+_VALID_LANGUAGE_PAIRS = [lang_pair for lang_pair in permutations(_SUPPORTED_WB_LANGS, 2) if lang_pair[0] == 'en' or lang_pair[1] == 'en']
 
 # TODO: Add BibTeX citation
 # Find for instance the citation on arxiv or on the dataset repo/website
@@ -38,104 +39,91 @@ _CITATION="""\
 _DESCRIPTION="""
 Rosetta-Balcanica is a set of evaluation datasets for low resource western Balkan languages manually sourced from articles from OSCE website.
 """
+
 _HOMEPAGE='https://github.com/ebegoli/rosetta-balcanica'  
-URL='https://github.com/ebegoli/rosetta-balcanica/raw/main/rosetta_balcanica.tar.gz'
+_DATA_URL='https://github.com/ebegoli/rosetta-balcanica/raw/main/rosetta_balcanica.tar.gz'
 _VERSION=datasets.Version('1.0.0')
 
 class RosettaBalcanicaConfig(datasets.BuilderConfig):
-  """BuilderConfig for Rosetta Balcanica
+  """BuilderConfig for Rosetta Balcanica for low resource West Balcan languages
   """
 
-  def __init__(self, wb_lang, **kwargs):
-    logger.debug("i'm in config")
+  def __init__(self, lang_pair=(None, None), **kwargs): 
+    assert lang_pair in _VALID_LANGUAGE_PAIRS, (f"Language pair {lang_pair} not supported (yet)")
+    name = f'{lang_pair[0]} to {lang_pair[1]}'
+    desc = f'Translation dataset from {lang_pair[0]} to {lang_pair[1]}'
     super(RosettaBalcanicaConfig, self).__init__(
-      name=f'en-{wb_lang}',
-      description=f'Translation dataset from en to {wb_lang}',
+      name=name,
+      description=desc,
       version=_VERSION,
       **kwargs
     )
 
-    # validate language
-    assert wb_lang in supported_wb, (f"Supported West Balkan languages are {supported_wb}, got {wb_lang}")
-    self.wb_lang = wb_lang
+    self.lang_pair = lang_pair
 
 class RoesettaBalcancia(datasets.GeneratorBasedBuilder):
   logger.debug("i'm in builder")
   BUILDER_CONFIGS = [
     RosettaBalcanicaConfig(
-      wb_lang=wb_lang,
+      lang_pair=lang_pair,
+      versino=_VERSION,
     )
-    for wb_lang in supported_wb
+    for lang_pair in _VALID_LANGUAGE_PAIRS
   ]
 
   def _info(self):
-    source,target = 'en', self.config.wb_lang
-    features = datasets.Features(
-      {
-        'id': datasets.Value('string'),
-        'translation': datasets.features.Translation(languages=(source, target))
-      }
-    )
-
     return datasets.DatasetInfo(
       description=_DESCRIPTION,
-      features=features,
-      supervised_keys=None,
+      features=datasets.Features(
+        {'translation': datasets.features.Translation(languages=self.config.lang_pair)}
+      ),
       homepage=_HOMEPAGE,
+      supervised_keys=self.config.lang_pair,
       citation=_CITATION,
     )
 
   def _split_generators(self, dl_manager):
-      logger.debug("_split_generators")
-      wb_lang = self.config.wb_lang
-      # lang_pair = f'en-{wb_lang}'
-
-      # data_dir = f'~/rosetta_balcanica/{lang_pair}'
-      # files = {}
-      # for split in ('train', 'test'):
-      #   files[split] = {
-      #     'en': f'{data_dir}/{split}_en.txt',
-      #     f'{wb_lang}': f'{data_dir}/{split}_{wb_lang}.txt'
-      #   }
-
-      # return [
-      #   datasets.SplitGenerator(name=datasets.Split.TRAIN, gen_kwargs=files['train']),
-      #   datasets.SplitGenerator(name=datasets.Split.TEST, gen_kwargs=files['test']),
-      # ]
-
-      # train_dls = {
-      #   'en': f'{data_dir}/{lang_pair}/train_en.txt',
-      #   f'{wb_lang}': f'{data_dir}/{lang_pair}/train_{wb_lang}.txt',
-      # }
-      # test_dls = {
-      #   'en': f'{data_dir}/{lang_pair}/test_en.txt',
-      #   f'{wb_lang}': f'{data_dir}/{lang_pair}/test_{wb_lang}.txt',
-      # }
-
-      train_dls = dl_manager.download_and_extract(_URLs[lang_pair]['train'])
-      test_dls = dl_manager.download_and_extract(_URLs[lang_pair]['test'])
-
-
-      return [
-        datasets.SplitGenerator(name=datasets.Split.TRAIN, gen_kwargs={'filepath': train_dls}),
-        datasets.SplitGenerator(name=datasets.Split.TEST, gen_kwargs={'filepath': test_dls}),
-      ]
-
-  def _generate_examples(self, en_path, wb_path):
-    wb_lang = self.config.wb_lang
-    with open(en_path, encoding='utf-8') as f1, open(wb_path, encoding='utf-8') as f2:
-      for sent_counter, (en_sent, wb_sent) in enumerate(zip(f1, f2)):
-        en_sent = en_sent.strip()
-        wb_sent = wb_sent.strip()
-        result = (
-          sent_counter,
-          {
-            'id': str(sent_counter),
-            'translation': {
-              'en': en_sent,
-              f'{wb_lang}': wb_sent
-            }
-          }
-        )
-        yield result
+    archive = dl_manager.download(_DATA_URL)
+    source,target = self.config.lang_pair
+    non_en = source if target == 'en' else target
+    data_dir = f'en-{non_en}'
+
+    return [
+      datasets.SplitGenerator(
+      name=datasets.Split.TRAIN,
+      gen_kwargs={
+        'source_file': f'{data_dir}/train_{source}.txt',
+        'target_file': f'{data_dir}/train_{target}.txt',
+        'files': dl_manager.iter_archive(archive)
+      }
+    ),
+      datasets.SplitGenerator(
+      name=datasets.Split.TEST,
+      gen_kwargs={
+        'source_file':  f'{data_dir}/test_{source}.txt',
+        'target_file': f'{data_dir}/test_{target}.txt',
+        'files': dl_manager.iter_archive(archive)
+      }
+    ),
+    ]
+
+  def _generate_examples(self, source_file, target_file, files):
+    source_sents, target_sents = None, None
+    for path, f in files:
+      if path == source_file:
+        source_sents = f.read().decode('utf-8').split('\n')
+      elif path == target_file:
+        target_sents = f.read().decode('utf-8').split('\n')
+      if source_sents is not None and target_sents is not None:
+        break
+
+    assert len(target_sents) == len(source_sents), (f"Sizes do not match: {len(source_sents) vs len(target_sents)} for {source_file} vs {target_file}")
+
+    source,target = self.config.lang_pair
+    for idx, (l1, l2) in enumerate(zip(source_sents, target_sents)):
+      result = {
+        'translation': {source: l1, target: l2}
+      }
+      if all(result.values()):
+        yield idx, result