Template talk:Asbox

message: I've got a sandbox edit (diff) which moves style attributes to new templatestyles (Template:Asbox/styles.css), and also moves the navbar to prevent it from overlapping text. The navbar is invisible by default, but can be made visible by user CSS. See Template:Asbox/testcases. Please let me know if you see any issues. Matt Fitzpatrick (talk) 15:09, 27 February 2021 (UTC)
thread_title:  Navbar position 

message: This line,
		local tsort, cat = args['tempsort' .. v], mw.ustring.gsub(args['category' .. v], '[^%w%p%s]', )--remove all hidden unicode chars 
is making this module not useful for other wikis where ZWNJ (and maybe ZWJ) is used in category titles which they aren't a part of %w, %p and %s so I had to add ZWNJ to them on fawiki, can you avoid the replace or allow the characters that actually have semantic use at least in other languages? Thanks! −ebrahimtalk 19:03, 22 March 2021 (UTC)
replies: text: This can be applied to fix this. −ebrahimtalk 19:18, 22 March 2021 (UTC)
replies: text: The code is there for a very good reason: see Template talk:Asbox/Archive 4#Obscure errors. Any changes must not cause those problems to recur. --Redrose64 🌹 (talk) 21:53, 22 March 2021 (UTC)
replies: text: Interesting issue. LRM, RLM shouldn't be used at titles of course but ZWNJ is different, running sql fawiki` with `SELECT COUNT(*) FROM page WHERE page_title LIKE '%‌%' AND page_is_redirect = 0 AND page_namespace = 14; (ZWNJ is in between of %%) gives 287200 so there is 287200 categories with ZWNJ on fawiki, there can be a balance here I believe, one can go for eliminating all the non-Latin characters on English Wikipedia and one can allow all the things, I'm not suggesting either at the moment but just to add ZWJ and ZWNJ. −ebrahimtalk 18:31, 23 March 2021 (UTC)

text: Done  I've made a similar change to the last-requested one. Izno (talk) 01:43, 5 June 2021 (UTC)
replies: text: Izno: Would you please add ZWJ and ZWNJ also as the original request? Just allowing that two unicode points wouldn't be hurtful so in future English Wikipedia applies the same logic on other places based on the same reasoning updating Lua module wouldn't have silently failures for us. Thanks −ebrahimtalk 09:25, 5 June 2021 (UTC)
replies: text:  Please make it obvious in  sandbox what it is you want to add. I look at the presented diff from fa.wp and even the en.wp version of the same and do not see a meaningful difference, which is bad. If you're going to use hidden characters in a pattern, use their Unicode references as in Module:Citation/CS1/Configuration (see invisible_chars) so that other users do not a) possibly remove them in the future unintentionally and b) so that the exact characters are trivially inspected for reasonability. Izno (talk) 16:15, 5 June 2021 (UTC)
replies: text: Izno: My bad, sure, I didn't know about how to encode them like that in Lua, thanks for the pointer, https://en.wikipedia.org/?diff=1027068468 −ebrahimtalk 22:39, 5 June 2021 (UTC)

text: As the above discussion please consider applying this change as the same change in Persian Wikipedia resolves our issue and I think it makes sense to keep such code changes upstream so no silent failures happens on module updates. Thanks! −ebrahimtalk 10:00, 11 June 2021 (UTC)
replies: text:  — Martin (MSGJ · talk) 11:07, 21 June 2021 (UTC)
thread_title:  i18n unfriendly normalization 

message: Your recent edit started using sandboxes in the live module. This is of course not good. Could you take care of it? --Trialpears (talk) 11:32, 21 June 2021 (UTC)
replies: text: Thanks for letting me know, fixed — Martin (MSGJ · talk) 11:37, 21 June 2021 (UTC)
thread_title:  Sandboxes in main module