Template talk:WikiProject Military history

message: In Template:WikiProject Military history the parm "TF_14_NESTED = Weaponry" is duplicated, giving an error. The 2nd one should be removed. Davemck (talk) 15:16, 16 December 2023 (UTC)
replies: text: SWinxy (talk) 19:09, 16 December 2023 (UTC)
thread_title:  Template-protected edit request on 16 December 2023 

message: These articles are listed as being incorrectly assessed as articles instead of lists, but class=list. Looks like a problem with the template. Hawkeye7 (discuss) 23:25, 16 January 2024 (UTC)
replies: text: According to the template documentation, |list=yes is required to be added as a parameter in order to apply the list-based assessment criteria. Harryboyles 08:27, 17 January 2024 (UTC)
thread_title:  Category:Military history lists incorrectly assessed as articles 

message: What progress are we making on getting Template:WikiProject Military history to get it to inherit from Template:WikiProject banner shell?  Seems to be a lot of unecessary bot work going on just dealing with this. Hawkeye7 (discuss) 20:15, 17 January 2024 (UTC)
thread_title:  WikiProject banner shell 

message: Looking at Talk:Ironclad warship, the WikiProject Banner Shell is set to C class, but this is not being inherited by the WikiProject Military history banner, which for some bizarre reason is showing the article as Start class, although there is no class parameter. This causes weird effects, with the article being categorised as both C and Start class. Any idea where the start comes from? And how we can get the banner to inherit correctly? Hawkeye7 (discuss) 22:23, 31 March 2024 (UTC)
replies: text: From the template page: WikiProject Military history has opted out of project-independent quality assessments and is using a custom class mask. With the article being recently demoted from A-class, the automatic class rating from the class mask applies. There's no B-Class assessment checklist done (B-Class-1 through B-Class-5 parameters), so the default case of Start-class applies. Wikipedia:WikiProject Military history/Assessment#Criteria lists the criteria required for C-class (The article meets B1 or B2 as well as B3 and B4 and B5 of the B-Class criteria.) and B-class (The article meets all of the B-Class criteria.) Harryboyles 23:03, 31 March 2024 (UTC)
replies: text: If there is no B-Class assessment checklist done, then the article should be in :Category:Military history articles with missing B-Class checklists. The bot will then assess it. I don't know why it is not. The default is for unassessed articles is to be placed in :Category:Unassessed military history articles.  WikiProject Military history has not opted out of quality assessments. I will see if we can get that message corrected. Hawkeye7 (discuss) 23:57, 31 March 2024 (UTC)
replies: text:  Harryboyles didn't say that milhist had opted out of quality assessments; they said , please note the qualifier "project-independent" here. Quality assessments still occur, but need to be set on the milhist banner as well as on the banner shell. --Redrose64 🌹 (talk) 05:57, 1 April 2024 (UTC)
replies: text: The project should inherit the rating from the banner shell where it is set. Hawkeye7 (discuss) 07:03, 1 April 2024 (UTC)

text:  When QUALITY_CRITERIA=='custom' and there is no class set, the module is supposed to "replace class with inherited class". Hawkeye7 (discuss) 07:45, 1 April 2024 (UTC)

text: 
if args.QUALITY_CRITERIA=='custom' then -- project has opted out of standard assessment scale and uses a custom mask
		local custom_mask = banner_name:subPageTitle('class')
		if custom_mask.exists and #custom_mask:getContent()>1 then
			raw_args.demo_page = args.demo_page -- send demo_page to custom mask
			class = mw.text.trim(frame:expandTemplate{
				title = custom_mask.prefixedText,
				args = raw_args
			})
			if class== and article_class and article_class~= then -- if unassessed and article class exists, check if it can be inherited
				local new_arg_table = {}
				for arg, val in pairs(raw_args) do -- construct new argument table to send to custom mask
					new_arg_table[arg] = val
				end
				new_arg_table.class = article_class -- replace class with inherited class
				local article_class_normalised = mw.text.trim(frame:expandTemplate{
					title = custom_mask.prefixedText,
					args = new_arg_table
				})
				if article_class_normalised and article_class_normalised~= then
					class = article_class_normalised -- inherit class from article_class normalised by custom mask
				else
					article_class = nil -- effectively no article_class for this banner
				end
			end
		end
}}
 Hawkeye7 (discuss) 07:45, 1 April 2024 (UTC)

text: Military history articles must never default to start class. Hawkeye7 (discuss) 07:29, 1 April 2024 (UTC)
thread_title:  Anomalous rating