binary mode consumes a lot of RAM, added non binary mode

DUDE_loader.py

@@ -108,21 +108,38 @@ def open_pdf_binary(pdf_file):
         return f.read()
 
 
+class DUDEConfig(datasets.BuilderConfig):
+    """BuilderConfig for DUDE."""
+
+    def __init__(
+        self,
+        binary_mode: bool,
+        **kwargs,
+    ):
+        """BuilderConfig for DUDE.
+        Args:
+          binary_mode: `boolean`, load binary PDFs/OCR or pass along paths on local file system
+          **kwargs: keyword arguments forwarded to super.
+        """
+        BINARY_MODE = False        
+        super(DUDEConfig, self).__init__(description=_DESCRIPTION, **kwargs)
+        self.binary_mode = binary_mode or BINARY_MODE
+
+
 class DUDE(datasets.GeneratorBasedBuilder):
     """DUDE dataset."""
 
+    VERSION = datasets.Version("0.0.1")
+
     BUILDER_CONFIGS = [
-        datasets.BuilderConfig(
-            name="DUDE",
-            version=datasets.Version("0.0.1"),
-            description=_DESCRIPTION,
-        )
+        DUDEConfig(name='DUDE', version=VERSION, binary_mode=False),
+        DUDEConfig(name='DUDE-binary', version=VERSION, binary_mode=True)
     ]
 
-    DEFAULT_CONFIG_NAME = "DUDE"
+    DEFAULT_CONFIG_NAME = "DUDE" #for some reason not working
 
-    def _info(self):
 
+    def _info(self):
         features = datasets.Features(
             {
                 "docId": datasets.Value("string"),
@@ -141,8 +158,8 @@ class DUDE(datasets.GeneratorBasedBuilder):
                 "answers_variants": datasets.Sequence(datasets.Value("string")),
                 "answer_type": datasets.Value("string"),
                 "data_split": datasets.Value("string"),
-                "document": datasets.Value("binary"),
-                "OCR": datasets.Value("binary"),
+                "document": datasets.Value("binary") if self.config.binary_mode else datasets.Value("string"),
+                "OCR": datasets.Value("binary") if self.config.binary_mode else datasets.Value("string"),
             }
         )
 
@@ -190,44 +207,32 @@ class DUDE(datasets.GeneratorBasedBuilder):
     def _generate_examples(self, binary_extraction_path, annotations, split):
         def retrieve_doc(docid):
             extracted_path = os.path.join(binary_extraction_path, "PDF", split, docid + ".pdf")
-            with open(extracted_path, "rb") as f:
-                return f.read()
+            return extracted_path
+
 
         def retrieve_OCR(docid, ocr_engine="Amazon", format="original"):
             extracted_path = os.path.join(
                 binary_extraction_path, "OCR", ocr_engine, docid + f"_{format}.json"
             )
-
-            with open(extracted_path, "rb") as f:
-                return f.read()
+            return extracted_path
 
         question = self.info.features["question"]
         answers = self.info.features["answers"]
 
-        extensions = {"pdf", "PDF"}
-
         annotations = [x for x in annotations if x["data_split"] == split]
 
         for i, a in enumerate(annotations):
             a["data_split"] = split
             if a["docId"] in SKIP_DOC_IDS:
                 continue
-            a["document"] = retrieve_doc(a["docId"])
-            a["OCR"] = retrieve_OCR(a["docId"])
-
             a["answers_page_bounding_boxes"] = parse_bbox(a["answers_page_bounding_boxes"])
-            yield i, a
-
-            """
-            # FIXES for faulty generation
-            # a.pop("answers_page_bounding_boxes")  # fix later
-            if a["answers_page_bounding_boxes"] in [[], [[]]]:
-                a["answers_page_bounding_boxes"] = None
+            docpath = retrieve_doc(a["docId"])
+            ocrpath = retrieve_OCR(a["docId"])
+            if self.config.binary_mode:
+                with open(docpath, "rb") as f, open(ocrpath, "rb") as g:
+                    a["document"] = f.read()
+                    a["OCR"] = g.read()
             else:
-                if isinstance(a["answers_page_bounding_boxes"][0], list):
-                    a["answers_page_bounding_boxes"] = a["answers_page_bounding_boxes"][0]
-            # if i == 2303:
-            try:
-            except Exception as e:
-                print(f"Something wrong in {split}-{i} {e}")
-            """
+                a["document"] = docpath
+                a["OCR"] = ocrpath   
+            yield i, a

test_loader.py

@@ -22,7 +22,7 @@ from codetiming import Timer
 for binding in ["dict_annotations (new)"]: #"dict_PDF", 
     with Timer(name=f"{binding}", text=binding + " Elapsed time: {:.4f} seconds"):
         if binding == "dict_annotations (new)":
-            ds = load_dataset("../DUDE_loader/DUDE_loader.py", data_dir="/home/jordy/Downloads/DUDE_train-val-test_binaries", writer_batch_size=10) #ignore_verifications=True,
+            ds = load_dataset("../DUDE_loader/DUDE_loader.py", 'DUDE', data_dir="/home/jordy/Downloads/DUDE_train-val-test_binaries") #ignore_verifications=True, , writer_batch_size=10
         else:
             ds = load_dataset("jordyvl/DUDE_loader", revision='db20bbf751b14e14e8143170bc201948ef5ac83c')