data_type
large_stringclasses
3 values
source
large_stringclasses
29 values
code
large_stringlengths
98
49.4M
filepath
large_stringlengths
5
161
message
large_stringclasses
234 values
commit
large_stringclasses
234 values
subject
large_stringclasses
418 values
critique
large_stringlengths
101
1.26M
metadata
dict
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
A new field is reserved in vfio_device_feature_dma_buf.flags to request CPU-facing memory type attributes for mmap()s of the buffer. Add a flag VFIO_DEVICE_FEATURE_DMA_BUF_ATTR_WC, which results in WC PTEs for the DMABUF's BAR region. Signed-off-by: Matt Evans <mattev@meta.com> --- drivers/vfio/pci/vfio_pci_dmabuf.c ...
{ "author": "Matt Evans <mattev@meta.com>", "date": "Thu, 26 Feb 2026 12:22:02 -0800", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
A VFIO DMABUF can export a subset of a BAR to userspace by fd; add support for mmap() of this fd. This provides another route for a process to map BARs, except one where the process can only map a specific subset of a BAR represented by the exported DMABUF. mmap() support enables userspace driver designs that safely ...
{ "author": "Matt Evans <mattev@meta.com>", "date": "Thu, 26 Feb 2026 12:21:59 -0800", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
This test exercises VFIO DMABUF mmap() to userspace, including various revocation/shutdown cases (which make the VMA inacessible). This is a TEMPORARY test, just to illustrate a new UAPI and DMABUF/mmap() usage. Since it originates from out-of-tree code, it duplicates some of the VFIO device setup code in .../selftes...
{ "author": "Matt Evans <mattev@meta.com>", "date": "Thu, 26 Feb 2026 12:22:03 -0800", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
Add a new dma-buf ioctl() op, DMA_BUF_IOCTL_REVOKE, connected to a new (optional) dma_buf_ops callback, revoke(). An exporter receiving this will _permanently_ revoke the DMABUF, meaning it can no longer be mapped/attached/mmap()ed. It also guarantees that existing importers have been detached (e.g. via move_notify) ...
{ "author": "Matt Evans <mattev@meta.com>", "date": "Thu, 26 Feb 2026 12:22:00 -0800", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
On 2/26/26 21:22, Matt Evans wrote: Well that means revoking from the importer side. That absolutely doesn't make sense to me. Why would you do that? Regards, Christian.
{ "author": "=?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "date": "Fri, 27 Feb 2026 11:05:24 +0100", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
On 2/26/26 21:21, Matt Evans wrote: In general sounds like a good idea but this approach here doesn't looks good at all. Especially how you call unmap_mapping_range() from your DMA-buf cleanup path looks extremely questionable. ... Let's start with this here, it just looks horrible over complicated. When a DMA-bu...
{ "author": "=?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "date": "Fri, 27 Feb 2026 11:09:31 +0100", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
On Fri, Feb 27, 2026 at 11:09:31AM +0100, Christian König wrote: I actually would like to go the other way and have VFIO always have a DMABUF under the VMA's it mmaps because that will make it easy to finish the type1 emulation which requires finding dmabufs for the VMAs. It isn't that simple, the vm_ops won't have...
{ "author": "Jason Gunthorpe <jgg@nvidia.com>", "date": "Fri, 27 Feb 2026 08:51:09 -0400", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
On Fri, Feb 27, 2026 at 11:05:24AM +0100, Christian König wrote: They are building a "vending process" to wrapper VFIO. They want to send a little bit of MMIO space wrapped in a DMABUF to some other process over a unix FD. At some later point the vending process will want to revoke the MMIO so it will issue this IOCTL...
{ "author": "Jason Gunthorpe <jgg@nvidia.com>", "date": "Fri, 27 Feb 2026 08:56:21 -0400", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
Hi Christian, On 27/02/2026 10:05, Christian König wrote: Well, it's for cleanup, but directed to a specific buffer. Elaborating on the original example, a userspace driver creates a DMABUF for parts of a BAR and then sends its fd to some other client process via SCM_RIGHTS. The client might then do all of: - Proc...
{ "author": "Matt Evans <mattev@meta.com>", "date": "Fri, 27 Feb 2026 13:02:08 +0000", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
Hi Matt, On 2/27/26 14:02, Matt Evans wrote: Yeah that makes it clear, Jasons answer also helped quite a bit to understand what you want to do here. First of all your requirements sound reasonable, but absolutely clear NAK to the way those patches approach of implementing them. You completely mixed up the different ...
{ "author": "=?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "date": "Fri, 27 Feb 2026 16:20:54 +0100", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Document the QMP UFS PHY compatible for the Eliza Platform. It is fully compatible with the PHY implemented in SM8650, so use the SM8650 compatible as fallback. While at it, move the QCS8300 one so that it is sorted correctly by fallback compatible. Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed...
null
null
null
[PATCH v3] dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: document the Eliza QMP UFS PHY
On Mon, 23 Feb 2026 10:19:38 +0200, Abel Vesa wrote: Applied, thanks! [1/1] dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: document the Eliza QMP UFS PHY commit: caf08514bbee0736c31d8d4f406e3415cdf726bb Best regards, -- ~Vinod
{ "author": "Vinod Koul <vkoul@kernel.org>", "date": "Fri, 27 Feb 2026 20:59:37 +0530", "is_openbsd": false, "thread_id": "177220617754.330302.8800181516621926196.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
From: Yufan Chen <ericterminal@gmail.com> hidp_setup_hid() duplicates the report descriptor from userspace based on req->rd_size. hidp_session_dev_init() only checked rd_size > 0, so oversized values were accepted and propagated to memdup_user(). Reject values larger than HID_MAX_DESCRIPTOR_SIZE and return -EINVAL be...
null
null
null
[PATCH] Bluetooth: HIDP: reject oversized report descriptor
Hi Yafan, On Tue, Feb 24, 2026 at 8:35 PM Eric-Terminal <ericterminal@gmail.com> wrote: Well this has the potential to break compatibility if a device misbehaves. So is this causing a real problem or is it just defensive coding? In case of the later, we may just truncate or something, if that is not already truncated...
{ "author": "Luiz Augusto von Dentz <luiz.dentz@gmail.com>", "date": "Fri, 27 Feb 2026 10:04:03 -0500", "is_openbsd": false, "thread_id": "CABBYNZ+9Z8Yd9mRhgz0N9kSSvLR-6euPf9CRA1Sop_D8zV8wqQ@mail.gmail.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
From: Saravana Kannan <saravanak@google.com> This reverts commit 1a50d9403fb90cbe4dea0ec9fd0351d2ecbd8924. While the commit fixed fw_devlink overlay handling for one case, it broke it for another case. So revert it and redo the fix in a separate patch. Fixes: 1a50d9403fb9 ("treewide: Fix probing of devices in DT ove...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:53:58 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
get_dev_from_fwnode() calls get_device() and so it acquires a reference on the device returned. In order to be more obvious that this wrapper is a get_device() variant, rename it to get_device_from_fwnode(). Suggested-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/lkml/CAGETcx97QjnjVR8Z5g0ndLHpK96h...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:53:59 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
From: Saravana Kannan <saravanak@google.com> When an overlay is applied, if the target device has already probed successfully and bound to a device, then some of the fw_devlink logic that ran when the device was probed needs to be rerun. This allows newly created dangling consumers of the overlayed device tree nodes t...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:00 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
During driver removal, the following warning can appear: WARNING: CPU: 1 PID: 139 at drivers/base/core.c:1497 __device_links_no_driver+0xcc/0xfc ... Call trace: __device_links_no_driver+0xcc/0xfc (P) device_links_driver_cleanup+0xa8/0xf0 device_release_driver_internal+0x208/0x23c device_lin...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:01 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
During its probe, the simple-pm-bus driver (simple-pm-bus compatible variant) populates its child devices but it doesn't touch them during its removal. This leads to bus child devices present and bound to drivers whereas the bus itself is unbound. Be consistent and remove child devices when the bus itself is unbound....
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:02 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The simple-pm-bus driver handles several simple busses. When it is used with busses other than a compatible "simple-pm-bus", it doesn't populate its child devices during its probe. This confuses fw_devlink and results in wrong or missing devlinks. Once a driver is bound to a device and the probe() has been called, de...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:03 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
Setting fwnode->dev is specific to fw_devlink. In order to avoid having a direct 'fwnode->dev = dev;' in several place in the kernel, introduce fw_devlink_set_device() helper to perform this operation. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.c...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:04 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The code set directly fwnode->dev field. Use the dedicated fw_devlink_set_device() helper to perform this operation. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/base/core.c | 4 ++...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:05 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The code set directly fwnode->dev field. Use the dedicated fw_devlink_set_device() helper to perform this operation. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 2 +- 1 file changed, 1 insertion...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:06 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The code set directly dev->fwnode. Use the dedicated helper to perform this operation. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> --- tools/testing/cxl/test/cxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/cxl/test/cxl....
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:07 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The code set directly fwnode.dev field. Use the dedicated fw_devlink_set_device() helper to perform this operation. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> --- tools/testing/cxl/test/cxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git ...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:08 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The code set directly fwnode.dev field. Use the dedicated fw_devlink_set_device() helper to perform this operation. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pci/of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff ...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:09 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
Device-tree node can be created when CONFIG_PCI_DYNAMIC_OF_NODES. Those node are created and filled based on PCI core information but the fwnode device field is not set. When later an overlay is applied, this confuses fw_devlink. Indeed, without any device attached to the node, fw_devlink considers that this node will...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:10 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
During the instantiation of devices described by a device-tree overlay applied on a PCI device, devlink displays the following kind of debug messages instead of creating the expected links: 'Not linking xxxx - might never become dev' Without those expected links, the device removal order cannot be correct. Those d...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:11 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The physical device providing an I2C adapter is the device that calls i2c_add_adapter() or variants and i2c_del_adapter(). Most of the time this physical device is the parent of the adapter device. Exceptions exist with i2c muxes. Indeed, in case of i2c muxes, the parent of the mux adapter device points to the adapte...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:12 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
For i2c muxes, the parent of the mux adapter device is the adapter device the mux is connected to. This parent is not the physical device related to the mux adapter. Indeed, the physical device of the mux adapter is the mux device itself. Fill the adap.physdev with the mux device. Signed-off-by: Herve Codina <herve....
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:13 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
When removing an i2c controller device handling an i2c bus where an i2c mux is connected to, the removal process hangs and is stuck in the wait_completion() call done in i2c_del_adapter(). The i2c_del_adapter() tries to removed the i2c adapter related to the i2c controller device and the wait_completion() is waiting f...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:14 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
PCI drivers can use a device-tree overlay to describe the hardware available on the PCI board. This is the case, for instance, of the LAN966x PCI device driver. Adding some more nodes in the device-tree overlay adds some more consumer/supplier relationship between devices instantiated from this overlay. Those fw_node...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:15 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The lan966x clock controller depends on the LAN969x architecture or the LAN966x SoC. This clock controller can be used by the LAN966x PCI device and so it needs to be available when the LAN966x PCI device is enabled. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Acked-by: Stephen Boyd <sboyd@kernel.org> --- ...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:16 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The AT91 I2C driver depends on ARCH_MICROCHIP. This I2C controller can be used by the LAN966x PCI device and so it needs to be available when the LAN966x PCI device is enabled. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Acked-by: Andi Shyti <andi.shyti@kernel.org> --- drivers/i2c/busses/Kconfig | 2 +- 1...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:17 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
Nodes available in the dtso are not ordered by their unit address. Fix that re-ordering them according to their unit address. Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- drivers/misc/lan966x_pci.dtso | 99 +++++++++++++++++------------------ 1 file changed, 49 insertions(+), 50 deletions(-) diff --gi...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:18 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The lan966x_pci.dtso file contains descriptions related to both the LAN966x PCI device chip and the LAN966x PCI device board where the chip is soldered. Split the file in order to have: - lan966x_pci.dtsi The description related to the PCI chip. - lan966x_pci.dtso The description of the PCI board. Signed...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:19 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The lan966x_pci.dtso describes the Microchip EVB-LAN9662-NIC board [0] This PCI board embeds a LAN9962 PCI device chip, part of the LAN966x family. Rename the lan966x_pci.dtso accordingly. Link: https://www.microchip.com/en-us/development-tool/EV53U25A [0] Signed-off-by: Herve Codina <herve.codina@bootlin.com> Revie...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:20 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
Existing code uses the 0x9660 value (LAN9662 PCI Device ID) in several places. Avoid this direct use of the 0x9660 value replacing it by defined PCI Device ID. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/misc/lan966x_pci.c | 2 +- drivers/pci/quirk...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:21 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
Only one device-tree overlay (lan966x_evb_lan9662_nic.dtbo) is handled and this overlay is directly referenced in lan966x_pci_load_overlay(). This avoid to use the code for an other board. In order to be more generic and to allow support for other boards (PCI Vendor/Device IDs), introduce the lan966x_pci_info structu...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:22 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
Add device-tree nodes needed to support SFPs. Those nodes are: - the clock controller - the i2c controller - the i2c mux - the SFPs themselves and their related ports in the switch Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- drivers/misc/lan966x_evb_lan9662_nic.dtso | 96 +++++++++++++++++++++++ dr...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:23 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
The LAN966X Kconfig help section mentions drivers related to devices. Sort this list alphabetically. Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- drivers/misc/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 5cc79d1517af...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:24 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
Recently, new device-tree nodes were added in the overlay to add support for SFPs on LAN966x PCI device. The LAN966X Kconfig help section mentions drivers related to devices added based on the overlay description. Add drivers related to devices described by those new nodes in the already existing driver list. Signed...
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 14:54:25 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
On Fri, Feb 27, 2026 at 2:57 PM Herve Codina <herve.codina@bootlin.com> wrote: Acked-by: Linus Walleij <linusw@kernel.org> Tell me if I should apply this directly to the pinctrl tree, right now I'm under the impression that all patches need to go in together? Yours, Linus Walleij
{ "author": "Linus Walleij <linusw@kernel.org>", "date": "Fri, 27 Feb 2026 15:11:13 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Hi, This series add support for SFPs ports available on the LAN966x PCI device. In order to have the SFPs supported, additional devices are needed such as clock controller and I2C. As a reminder, the LAN966x PCI device driver use a device-tree overlay to describe devices available on the PCI board. Adding support for...
null
null
null
[PATCH v5 00/28] lan966x pci device: Add support for SFPs
Hi Linus, On Fri, 27 Feb 2026 15:11:13 +0100 Linus Walleij <linusw@kernel.org> wrote: This patch depends on patch 7. I think it could make sense to have patches 7 to 12 applied by the same maintainer. Best regards, Hervé
{ "author": "Herve Codina <herve.codina@bootlin.com>", "date": "Fri, 27 Feb 2026 15:22:49 +0100", "is_openbsd": false, "thread_id": "20260227135428.783983-1-herve.codina@bootlin.com.mbox.gz" }
lkml_critique
lkml
Enhance the readability of IOMUXC_SW_PAD_CTL_PAD configuration by using symbolic macros instead of magic values. First patch makes MX8MP_I2C_DEFAULT independent of DS so it can be re-used in multiple places. Second patch makes uses on the macros introduce with: 31ff1060175c458 ("arm64: dts: imx8mp: Add pinctrl config...
null
null
null
[RFC PATCH 0/2] imx8mp-frdm: Enhance code readability
Currently MX8MP_I2C_DEFAULT macro includes a fixed drive strength (MX8MP_DSE_X6) thus limiting its use to only I2C pins that require X6 drive. There are many pinctrl configurations for I2C that use different drive strength while still using the common I2C default configurations (pull-up, Schmitt input, pull enable, SI...
{ "author": "Daniel Baluta <daniel.baluta@nxp.com>", "date": "Fri, 27 Feb 2026 15:02:41 +0200", "is_openbsd": false, "thread_id": "aaGzj11fjemaKLrQ@lizhi-Precision-Tower-5810.mbox.gz" }
lkml_critique
lkml
Enhance the readability of IOMUXC_SW_PAD_CTL_PAD configuration by using symbolic macros instead of magic values. First patch makes MX8MP_I2C_DEFAULT independent of DS so it can be re-used in multiple places. Second patch makes uses on the macros introduce with: 31ff1060175c458 ("arm64: dts: imx8mp: Add pinctrl config...
null
null
null
[RFC PATCH 0/2] imx8mp-frdm: Enhance code readability
Currently, in order to configure IOMUXC_SW_PAD_CTL_PAD a magic raw value is written in this register. This makes code not obvious to read and modify. So, to help with code readability instead of the magic values use symbolic macros. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> --- arch/arm64/boot/dts/freesca...
{ "author": "Daniel Baluta <daniel.baluta@nxp.com>", "date": "Fri, 27 Feb 2026 15:02:42 +0200", "is_openbsd": false, "thread_id": "aaGzj11fjemaKLrQ@lizhi-Precision-Tower-5810.mbox.gz" }
lkml_critique
lkml
Enhance the readability of IOMUXC_SW_PAD_CTL_PAD configuration by using symbolic macros instead of magic values. First patch makes MX8MP_I2C_DEFAULT independent of DS so it can be re-used in multiple places. Second patch makes uses on the macros introduce with: 31ff1060175c458 ("arm64: dts: imx8mp: Add pinctrl config...
null
null
null
[RFC PATCH 0/2] imx8mp-frdm: Enhance code readability
Hi Daniel, Glad to see others using them :) Reviewed-by: Maud Spierings <maudspierings@gocontroll.com> On 2/27/26 14:02, Daniel Baluta wrote:
{ "author": "Maud Spierings <maudspierings@gocontroll.com>", "date": "Fri, 27 Feb 2026 14:31:48 +0100", "is_openbsd": false, "thread_id": "aaGzj11fjemaKLrQ@lizhi-Precision-Tower-5810.mbox.gz" }
lkml_critique
lkml
Enhance the readability of IOMUXC_SW_PAD_CTL_PAD configuration by using symbolic macros instead of magic values. First patch makes MX8MP_I2C_DEFAULT independent of DS so it can be re-used in multiple places. Second patch makes uses on the macros introduce with: 31ff1060175c458 ("arm64: dts: imx8mp: Add pinctrl config...
null
null
null
[RFC PATCH 0/2] imx8mp-frdm: Enhance code readability
Hi Daniel, On 2/27/26 14:02, Daniel Baluta wrote: [snip] Isn't this the same as the USDHC default that is above the i2c one? Kind regards, Maud
{ "author": "Maud Spierings <maudspierings@gocontroll.com>", "date": "Fri, 27 Feb 2026 14:33:37 +0100", "is_openbsd": false, "thread_id": "aaGzj11fjemaKLrQ@lizhi-Precision-Tower-5810.mbox.gz" }
lkml_critique
lkml
Enhance the readability of IOMUXC_SW_PAD_CTL_PAD configuration by using symbolic macros instead of magic values. First patch makes MX8MP_I2C_DEFAULT independent of DS so it can be re-used in multiple places. Second patch makes uses on the macros introduce with: 31ff1060175c458 ("arm64: dts: imx8mp: Add pinctrl config...
null
null
null
[RFC PATCH 0/2] imx8mp-frdm: Enhance code readability
On Fri, Feb 27, 2026 at 03:02:42PM +0200, Daniel Baluta wrote: Use symbolic macros instead of the magic values to improve code readability. ... It is not NAND, should be MX8MP_USDHC_DATA_DEFAULT Frank
{ "author": "Frank Li <Frank.li@nxp.com>", "date": "Fri, 27 Feb 2026 10:09:03 -0500", "is_openbsd": false, "thread_id": "aaGzj11fjemaKLrQ@lizhi-Precision-Tower-5810.mbox.gz" }
lkml_critique
lkml
Minor cleanups I saw when I was working on [1]. Both commits are related to a pattern where two pointers were being initialized and checked after that. [1] https://lore.kernel.org/linux-btrfs/20260223234451.277369-1-mssola@mssola.com/ Miquel Sabaté Solà (2): btrfs: return early if allocations fail on add_block_entr...
null
null
null
[PATCH 0/2] btrfs: return early in allocation failures
In both the recover_sectors() and the recover_scrub_rbio() functions we initialized two pointers by allocating them, and then returned early if either of them failed. But we can simply allocate the first one and do the check, and repeat for the second pointer. This way we return earlier on allocation failures, and we d...
{ "author": "=?UTF-8?q?Miquel=20Sabat=C3=A9=20Sol=C3=A0?= <mssola@mssola.com>", "date": "Fri, 27 Feb 2026 16:17:59 +0100", "is_openbsd": false, "thread_id": "20260227151759.704838-3-mssola@mssola.com.mbox.gz" }
lkml_critique
lkml
Minor cleanups I saw when I was working on [1]. Both commits are related to a pattern where two pointers were being initialized and checked after that. [1] https://lore.kernel.org/linux-btrfs/20260223234451.277369-1-mssola@mssola.com/ Miquel Sabaté Solà (2): btrfs: return early if allocations fail on add_block_entr...
null
null
null
[PATCH 0/2] btrfs: return early in allocation failures
In add_block_entry(), if the allocation of 're' fails, return right away instead of trying to allocate 'be' next. This also removes a useless kfree() call. Signed-off-by: Miquel Sabaté Solà <mssola@mssola.com> --- fs/btrfs/ref-verify.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/...
{ "author": "=?UTF-8?q?Miquel=20Sabat=C3=A9=20Sol=C3=A0?= <mssola@mssola.com>", "date": "Fri, 27 Feb 2026 16:17:58 +0100", "is_openbsd": false, "thread_id": "20260227151759.704838-3-mssola@mssola.com.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
The sensor supports an input clock in the range of 6 to 27 MHz. Currently, the driver only supports a 19.2 MHz clock. Extend the driver so that at least 24 MHz, which is a typical frequency for this sensor, can also be used. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 80 +...
{ "author": "Matthias Fend <matthias.fend@emfend.at>", "date": "Thu, 26 Feb 2026 09:56:04 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
Add YAML bindings for the Omnivision OV08D10 CMOS image sensor. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- .../bindings/media/i2c/ovti,ov08d10.yaml | 101 +++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 102 insertions(+) diff --git a/Docume...
{ "author": "Matthias Fend <matthias.fend@emfend.at>", "date": "Thu, 26 Feb 2026 09:56:01 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
This series provides basic device tree support and handling for power supplies, an optional reset, and the option to use a 24MHz input clock. In addition to a few minor fixes, a major problem with the configuration of the sensor modes has also been resolved. The changes have been tested on an i.MX8MP platform. Origin...
{ "author": "Matthias Fend <matthias.fend@emfend.at>", "date": "Thu, 26 Feb 2026 09:56:00 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
Fix some spelling errors in comments. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/ov08d10.c index fa8d29a62fbfa956dff6b57ccd6c9b7777967731..f5c187d7...
{ "author": "Matthias Fend <matthias.fend@emfend.at>", "date": "Thu, 26 Feb 2026 09:56:07 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
The current settings for the "image vertical start" register appear to be incorrect. While this only results in an incorrect start line for native modes, this faulty setting causes actual problems in binning mode. At least on an i.MX8MP test system, only corrupted frames could be received. To correct this, the recommen...
{ "author": "Matthias Fend <matthias.fend@emfend.at>", "date": "Thu, 26 Feb 2026 09:56:05 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
Add support for the required power supplies as well as the control of an optional sensor reset. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 104 +++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 97 insertions(+), 7 deletions(-) diff --git a/drivers/media/i2c/ov...
{ "author": "Matthias Fend <matthias.fend@emfend.at>", "date": "Thu, 26 Feb 2026 09:56:03 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
The OV08D10 can be used also on embedded designs using device tree so allow the sensor to bind to a device tree node. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/ov08d1...
{ "author": "Matthias Fend <matthias.fend@emfend.at>", "date": "Thu, 26 Feb 2026 09:56:02 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
Add trailing \n to dev_* prints where missing. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/ov08d10.c index f5c187d763c4264...
{ "author": "Matthias Fend <matthias.fend@emfend.at>", "date": "Thu, 26 Feb 2026 09:56:08 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
On Do, 2026-02-26 at 09:56 +0100, Matthias Fend wrote: [...] Please use devm_reset_control_get_optional_exclusive() directly. The commit message does not explain why this comment is dropped. Does this do the correct thing if v4l2_async_register_subdev_sensor() returns -EPROBE_DEFER (for example via privacy led) an...
{ "author": "Philipp Zabel <p.zabel@pengutronix.de>", "date": "Thu, 26 Feb 2026 11:13:34 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
On Do, 2026-02-26 at 09:56 +0100, Matthias Fend wrote: Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
{ "author": "Philipp Zabel <p.zabel@pengutronix.de>", "date": "Thu, 26 Feb 2026 11:15:18 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
Hi Philipp, thanks for your feedback. Am 26.02.2026 um 11:13 schrieb Philipp Zabel: ACK I didn't find the comment particularly helpful and since other sensors manage without it and there's now more than just ACPI, and "turn off" happens later, I thought it was fine to just drop the comment. If you think it shou...
{ "author": "Matthias Fend <matthias.fend@emfend.at>", "date": "Thu, 26 Feb 2026 21:30:08 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
On Thu, Feb 26, 2026 at 09:56:01AM +0100, Matthias Fend wrote: Drop YAML. You add DT bindings, not YAML. No YAML is bound here to anything. So maybe rather powerdown-gpios, see gpio-consumer-common.yaml? Best regards, Krzysztof
{ "author": "Krzysztof Kozlowski <krzk@kernel.org>", "date": "Fri, 27 Feb 2026 11:45:03 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
Register P1:0x33 is written twice with the same value in the 'lane_2_mode_1632x1224' sequence. Remove one unnecessary write access. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/media/i2c/ov08d10.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/...
null
null
null
[PATCH 6/8] media: i2c: ov08d10: remove duplicate register write
Hi Krzysztof, thanks for your comments. Am 27.02.2026 um 11:45 schrieb Krzysztof Kozlowski: ACK As activating the XSHUTDN pin on this sensor works like a reset, I guess it's okay as it is. From what I've seen, it's also common practice for some other Omnivision sensors to designate the XSHUTDN pin as the reset...
{ "author": "Matthias Fend <matthias.fend@emfend.at>", "date": "Fri, 27 Feb 2026 16:10:50 +0100", "is_openbsd": false, "thread_id": "20260226-ov08d10-v1-0-c3a916368123@emfend.at.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:35 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:36 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:37 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: Klara Modin <klarasmodin@gmail.com> Unlike most architectures, arm keeps a struct page pointer to the empty_zero_page and to initialize it requires conversion of a virtual address to page which makes it necessary to have memory map initialized before creating the empty_zero_page. Make empty_zero_page a stataic ...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:38 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:39 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:40 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:41 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:42 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:43 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:44 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:45 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:46 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:47 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:48 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:49 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:50 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:51 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:52 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:53 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:54 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:55 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Move calculations of zone limits to a dedicated arch_zone_limits_init() function. Later MM core will use this function as an architecture specific callback during nodes and zones initialization and thus there won't be a need to call free_area_init() from every archi...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:56 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> To initialize node, zone and memory map data structures every architecture calls free_area_init() during setup_arch() and passes it an array of zone limits. Beside code duplication it creates "interesting" ordering cases between allocation and initialization of huge...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:57 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Every architecture calls sparse_init() during setup_arch() although the data structures created by sparse_init() are not used until the initialization of the core MM. Beside the code duplication, calling sparse_init() from architecture specific code causes ordering ...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:58 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> All three variants of paging_init() on MIPS are wrappers for pagetable_init(). Instead of having three identical wrappers, call pagetable_init() directly from setup_arch() and remove the unnecessary paging_init() functions. Signed-off-by: Mike Rapoport (Microsoft) ...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:20:59 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Commit 665eaf313314 ("x86/setup: call hugetlb_bootmem_alloc early") added an early call to hugetlb_bootmem_alloc() to setup_arch() to allow HVO style pre-initialization of vmemmap on x86. With the ordering of hugetlb reservation vs memory map initialization sorted o...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:21:00 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Every architecture that supports hugetlb_cma command line parameter reserves CMA areas for hugetlb during setup_arch(). This obfuscates the ordering of hugetlb CMA initialization with respect to the rest initialization of the core MM. Introduce arch_hugetlb_cma_ord...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:21:01 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> hugetlb_cma_check() was required when the ordering of hugetlb_cma_reserve() and hugetlb_bootmem_alloc() was architecture depended. Since hugetlb_cma_reserve() is always called before hugetlb_bootmem_alloc() there is no need to check whether hugetlb_cma_reserve() was...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:21:02 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> This reverts commit d58b2498200724e4f8c12d71a5953da03c8c8bdf. hugetlb_bootmem_alloc() is called only once, no need to check if it was called already at its entry. Other checks performed during HVO initialization are also no longer necessary because sparse_init() th...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Sun, 11 Jan 2026 10:21:03 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
On Sun, Jan 11, 2026 at 10:20:51AM +0200, Mike Rapoport wrote: Hi Mike, ... You move initialization of max_zone_pfns[] to a function, name the function arch_zone_limits_init(), but leave the initializatio of max_zone_pfns[] to zeroes outside. Should not it be brought along? Thanks!
{ "author": "Alexander Gordeev <agordeev@linux.ibm.com>", "date": "Mon, 12 Jan 2026 08:02:48 +0100", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
Hi, On Mon, Jan 12, 2026 at 08:02:48AM +0100, Alexander Gordeev wrote: The idea is that is the caller responsibility to initialize max_zone_pfns to zero. After patch 24: "arch, mm: consolidate initialization of SPARSE memory model" there is a single caller of arch_zone_limits_init() and having initialization of max_z...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Mon, 12 Jan 2026 09:34:40 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
On Sun, 11 Jan 2026 10:20:34 +0200 Mike Rapoport <rppt@kernel.org> wrote: updated, thanks. I'll suppress the ensuing email flood. Kalle, can you please retest sometime, see if the BeagleBone Black boot failure was fixed? Seems we haven't heard back from rmk regarding https://lkml.kernel.org/r/aVrUDeSkqqY9ZCtS@shel...
{ "author": "Andrew Morton <akpm@linux-foundation.org>", "date": "Mon, 12 Jan 2026 14:23:23 -0800", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
On 1/13/26 00:23, Andrew Morton wrote: Hello! I will test this v3 patch ASAP and reply results here. Collective sorry for the delay; I have been busy! BR Kalle
{ "author": "Kalle Niemi <kaleposti@gmail.com>", "date": "Tue, 13 Jan 2026 08:50:33 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
On 1/13/26 08:50, Kalle Niemi wrote: Hello! I tried this patch by cloning https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/log/?h=hugetlb-init/v3 Boots succesfully on BeagleBone Black! BR Kalle
{ "author": "Kalle Niemi <kaleposti@gmail.com>", "date": "Tue, 13 Jan 2026 10:40:22 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
On 2026-01-11 09:20, Mike Rapoport wrote: Hi Mike, Thanks for this nice cleanup series. This old initialization of max_zone_pfns[ZONE_NORMAL] should also be removed, right? With that removed it makes the local end_pfn variable set but unused, so could you please also remove that one? I know that this whole code b...
{ "author": "Andreas Larsson <andreas@gaisler.com>", "date": "Tue, 13 Jan 2026 13:28:09 +0100", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
Mike Rapoport <rppt@kernel.org> writes: This v2 looks good to me. I have also done a basic bootup testing using Linux PPC CI. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
{ "author": "Ritesh Harjani (IBM) <ritesh.list@gmail.com>", "date": "Tue, 13 Jan 2026 17:59:49 +0530", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
Hello: This series was applied to riscv/linux.git (fixes) by Andrew Morton <akpm@linux-foundation.org>: On Sun, 11 Jan 2026 10:20:34 +0200 you wrote: Here is the summary with links: - [v3,01/29] alpha: introduce arch_zone_limits_init() https://git.kernel.org/riscv/c/ba1c86874e25 - [v3,02/29] arc: introduce a...
{ "author": "patchwork-bot+linux-riscv@kernel.org", "date": "Fri, 20 Feb 2026 04:10:42 +0000", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
Hi everyone, On Sun, Jan 11, 2026 at 10:20:58AM +0200, Mike Rapoport wrote: This broke the boot on RISC-V 32-bit (rv32_defconfig) for me. Specifically if sparse_init() is *not* called before the following callchain, the kernel dies at that point. start_kernel() setup_arch() apply_boot_alternatives() _ap...
{ "author": "Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>", "date": "Mon, 23 Feb 2026 14:52:45 +0100", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }