data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | Add new API devm_mux_control_get_from_np() to retrieve a mux control from
a specified child device node.
Make devm_mux_control_get() call devm_mux_control_get_from_np() with a NULL
node parameter, which defaults to using the device's own of_node.
Support the following DT schema:
pinctrl@0 {
uart-func {
... | {
"author": "Frank Li <Frank.Li@nxp.com>",
"date": "Wed, 25 Feb 2026 18:55:05 -0500",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | {
"author": "Frank Li <Frank.Li@nxp.com>",
"date": "Wed, 25 Feb 2026 18:55:06 -0500",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | Add an optional .release_mux() callback to the pinmux_ops.
Some devices require releasing resources that were previously acquired in
.set_mux(). Providing a dedicated .release_mux() callback allows drivers to
properly clean up hardware state or associated resources when a mux
function is no longer active.
The callbac... | {
"author": "Frank Li <Frank.Li@nxp.com>",
"date": "Wed, 25 Feb 2026 18:55:07 -0500",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | Many boards use on-board mux chips (often controlled by GPIOs from an I2C
expander) to switch shared signals between peripherals.
Add a generic pinctrl driver built on top of the mux framework to
centralize mux handling and avoid probe ordering issues. Keep board-level
routing out of individual drivers and supports bo... | {
"author": "Frank Li <Frank.Li@nxp.com>",
"date": "Wed, 25 Feb 2026 18:55:08 -0500",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | The board integrates an on-board mux to route shared signals to either
CAN2 or PDM (MICFIL). The mux is controlled by a GPIO.
Add a pinctrl-based multiplexer node to describe this routing and ensure
proper probe ordering of the dependent devices.
Previously, MICFIL operation implicitly depended on the default level o... | {
"author": "Frank Li <Frank.Li@nxp.com>",
"date": "Wed, 25 Feb 2026 18:55:09 -0500",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | Add flexcan2 overlay file, which enable flexcan2 node and disable micfil
node.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm64/boot/dts/freescale/Makefile | 4 ++++
arch/arm64/boot/dts/freescale/imx8mp-evk-flexcan2.dtso | 15 +++++++++++++++
2 files changed, 19 insertions(+)
diff --git a/a... | {
"author": "Frank Li <Frank.Li@nxp.com>",
"date": "Wed, 25 Feb 2026 18:55:10 -0500",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | On Thu, Feb 26, 2026 at 12:55 AM Frank Li <Frank.Li@nxp.com> wrote:
I think this is smart and elegant.
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij | {
"author": "Linus Walleij <linusw@kernel.org>",
"date": "Fri, 27 Feb 2026 10:02:33 +0100",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | On 2/26/26 01:55, Frank Li wrote:
Nit: NXP legal asked us to drop (C) so this should be Copyright 2026 NXP! | {
"author": "Daniel Baluta <daniel.baluta@oss.nxp.com>",
"date": "Fri, 27 Feb 2026 11:09:34 +0200",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | On Thu, Feb 26, 2026 at 12:55 AM Frank Li <Frank.Li@nxp.com> wrote:
Can you explain why you need this custom code for this?
Nominally pin control defines and puts the hardware into a
number of states such as:
"default"
"idle"
"sleep"
"init"
Usually (at least for silicon) what .release_mux() would to
is semantically... | {
"author": "Linus Walleij <linusw@kernel.org>",
"date": "Fri, 27 Feb 2026 10:07:05 +0100",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | Hi Frank,
thanks for your patch!
On Thu, Feb 26, 2026 at 12:55 AM Frank Li <Frank.Li@nxp.com> wrote:
(...)
This is so close to the pinctrl-internal helpers that you better work with
those instead.
Can't you just use pinctrl_generic_pins_function_dt_node_to_map()?
It was added in the last merge window in
commit 43... | {
"author": "Linus Walleij <linusw@kernel.org>",
"date": "Fri, 27 Feb 2026 10:20:14 +0100",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | On Fri, Feb 27, 2026 at 10:20:14AM +0100, Linus Walleij wrote:
As board mux (uart and flexcan) exist, for example, only one of UART and
FlexCAN work.
when modprobe uart.ko, mux_state_select called.
So flexcan driver can't get such mux as expected.
when remmod uart.ko, we need release mux_state, so flexcan driver c... | {
"author": "Frank Li <Frank.li@nxp.com>",
"date": "Fri, 27 Feb 2026 10:22:45 -0500",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Add a generic pinctrl binding for board-level pinmux chips that are
controlled through the multiplexer subsystem.
On some boards, especially development boards, external mux chips are used
to switch SoC signals between different peripherals (e.g. MMC and UART).
The mux select lines are often driven by a GPIO expander ... | null | null | null | [PATCH v2 0/6] pinctrl: Add generic pinctrl for board-level mux
chips | On Fri, Feb 27, 2026 at 10:07:05AM +0100, Linus Walleij wrote:
I am not familiar with pinctrl code. I just need a place to call a callback
which do opposite work at .set_mux() function.
I see pair function pinmux_enable_setting() call .set_mux() and
pinmux_disable_setting() just missing do oppsite work of .set_mux()... | {
"author": "Frank Li <Frank.li@nxp.com>",
"date": "Fri, 27 Feb 2026 10:32:30 -0500",
"is_openbsd": false,
"thread_id": "20260225-pinctrl-mux-v2-0-1436a25fa454@nxp.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | Add a clock operation to help determining the effective rate, closest to
the required one, that a specific clock can support.
Calculation is currently performed kernel side and the logic is taken
directly from the SCMI Clock driver: embedding the determinate rate logic
in the protocol layer enables semplifications in ... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:15 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | Use the Clock protocol layer determine_rate logic to calculate the closest
rate that can be supported by a specific clock.
No functional change.
Cc: Brian Masney <bmasney@redhat.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org
Signed-off-by: Cristi... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:16 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | Move needlessly exposed fields away from scmi_clock_info into the new
internal struct scmi_clock_desc while keeping exposed only the two new
min_rate and max_rate fields for each clock.
No functional change.
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
drivers/firmware/arm_scmi/clock.c | 145 ++++++... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:17 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | Use the new min_rate and max_rate unified properties that provide the
proper values without having to consider the clock type.
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
drivers/clk/cl... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:18 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | Only the unified interface exposing min_rate/max_rate is now used.
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
include/linux/scmi_protocol.h | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h
index 7283302b0c85..d97b4e734744... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:19 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | Leveraging SCMI Clock protocol dynamic discovery capabilities, move away
from the static per-clock rates allocation model in favour of a dynamic
runtime allocation based on effectively discovered resources.
No functional change.
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
drivers/firmware/arm_scmi... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:20 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | Fix clock parents enumeration to account only for effectively discovered
parents during enumeration, avoiding to trust the total number of parents
declared upfront by the platform.
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
drivers/firmware/arm_scmi/clock.c | 18 ++++++++++--------
1 file changed,... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:21 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | Use cleanup handlers to manage iterator data structures.
No functional change.
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
drivers/firmware/arm_scmi/driver.c | 35 +++++++++++++++---------------
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/firmware/arm_scmi/driver.c b/dr... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:22 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | SCMI core stack provides some common helpers to handle in a unified way
multipart message replies: such iterator-helpers, when run, currently
process by default the whole set of discovered resources.
Introduce an alternative way to run the initialized iterator on a limited
range of resources.
Note that the subset of ... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:23 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | Clock rates are guaranteed to be returned in ascending order for SCMI clock
protocol versions greater than 1.0: in such a case, use bounded iterators
to minimize the number of message exchanges needed to discover min and max
rate.
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
drivers/firmware/arm_scm... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:24 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce ... | null | null | null | [PATCH 00/11] SCMI Clock rates discovery rework | Add a clock operation to get the whole set of rates available to a specific
clock: when needed this request could transparently trigger a full rate
discovery enumeration if this specific clock-rates were previously only
lazily enumerated.
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
drivers/firmware... | {
"author": "Cristian Marussi <cristian.marussi@arm.com>",
"date": "Fri, 27 Feb 2026 15:32:25 +0000",
"is_openbsd": false,
"thread_id": "20260227153225.2778358-12-cristian.marussi@arm.com.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | In order to unify all the `Has*` infrastrutures, a generic `HasField`
trait is added along with a derive macro `#[derive(HasField)]` which
allows generate implementation of `HasField` automatically, e.g.
#[derive(HasField)]
struct Base {
a: i32;
b: i32;
#[field]
f1: Field<Base, 1>,
#[field]
f2: Fi... | {
"author": "Boqun Feng <boqun.feng@gmail.com>",
"date": "Wed, 28 Jan 2026 13:53:24 -0800",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | Now all in-tree users of `impl_has_work!()` are converted to use
`#[derive(HasField)]`, hence remove it.
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
rust/kernel/workqueue.rs | 53 ++--------------------------------------
1 file changed, 2 insertions(+), 51 deletions(-)
diff --git a/rust/kernel/workqueue.rs ... | {
"author": "Boqun Feng <boqun.feng@gmail.com>",
"date": "Wed, 28 Jan 2026 13:53:29 -0800",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | `#[derive(HasField)]` offers less code and better ergnomic for defining
a struct with a Work in it. Hence replace the current usage of
`impl_has_work!()`.
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
rust/kernel/sync/completion.rs | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/rus... | {
"author": "Boqun Feng <boqun.feng@gmail.com>",
"date": "Wed, 28 Jan 2026 13:53:28 -0800",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | `#[derive(HasField)]` offers less code and better ergonomic for defining
a struct with a Work in it. Hence replace the current usage of
`impl_has_work!()`.
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
drivers/android/binder/process.rs | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/d... | {
"author": "Boqun Feng <boqun.feng@gmail.com>",
"date": "Wed, 28 Jan 2026 13:53:27 -0800",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | Implement `HasWork` via `HasField` so that manually impl_has_work!() is
no longer needed.
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
rust/kernel/workqueue.rs | 60 +++++++++++++++++++++++++---------------
1 file changed, 38 insertions(+), 22 deletions(-)
diff --git a/rust/kernel/workqueue.rs b/rust/kernel/... | {
"author": "Boqun Feng <boqun.feng@gmail.com>",
"date": "Wed, 28 Jan 2026 13:53:26 -0800",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | This decouples the hrtimer mode part from the `HasField` part of a
`HasHrTimer`, `impl_has_hr_timer` also gets removed, as we can do:
#[has_field]
#[pin]
struct MyStruct {
a: i32,
#[field]
timer: HrTimer<MyStruct>,
}
impl HasHrTimer<MyStruct> for MyStruct {
type TimerMode = ...;
... | {
"author": "Boqun Feng <boqun.feng@gmail.com>",
"date": "Wed, 28 Jan 2026 13:53:25 -0800",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | Currently we have a few similar places where we use a `Has*` trait to
describe that a data structure has some types of field in it so that the
containing type can do something with it. There are also a `impl_has_*!`
macro to help implement the trait. While it's working, but it's less
ergonomic to me, especially conside... | {
"author": "Boqun Feng <boqun.feng@gmail.com>",
"date": "Wed, 28 Jan 2026 13:53:23 -0800",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | On Wed Jan 28, 2026 at 9:53 PM GMT, Boqun Feng wrote:
Hi Boqun,
Thanks for working on this.
You currently divide things into two traits, `Field<T>` which doesn't seem to be
doing anything (actually, why does this need to exist at all?) and
`HasField<T, F>` which defines all the field projection.
For some prior art ... | {
"author": "\"Gary Guo\" <gary@garyguo.net>",
"date": "Wed, 04 Feb 2026 14:20:09 +0000",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | On Wed, Feb 04, 2026 at 02:20:09PM +0000, Gary Guo wrote:
Oh, you're right, I don't need `Field<T>` right now. In a certain point,
it was used to constrain all "field types" must be generic over their
container type. But it's not the case now (see RcuHead).
Yep, I actually have an example PR integrating that into wo... | {
"author": "Boqun Feng <boqun@kernel.org>",
"date": "Thu, 5 Feb 2026 12:47:29 -0800",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | On Wed, 28 Jan 2026 13:53:23 -0800, Boqun Feng wrote:
Hi Boqun,
One naming concern: the #[field] attribute feels ambiguous since in
Rust every struct member is already called a "field." When reading:
#[derive(HasField)]
struct MyStruct {
value: i32,
#[field]
work: Work<MyStruct>,
}
it'... | {
"author": "Joel Fernandes <joelagnelf@nvidia.com>",
"date": "Mon, 16 Feb 2026 20:21:05 -0500",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | In order to support RCU delay free (call_rcu() and kfree_rcu()), the
abstraction of the `rcu_head` is introduced. Types that want to support
RCU delay free can specify a `RcuHead<T>` in it, e.g.
#[derive(HasField)]
struct Foo {
a: i32,
b: i32,
#[field]
rcu_head: RcuHead,
}
A wrapper `Wit... | null | null | null | [RFC PATCH 7/7] rust: sync: rcu: Introduce RcuHead | On Tue Feb 17, 2026 at 1:21 AM GMT, Joel Fernandes wrote:
This is not just for projection, but to establish has-a relation. A struct can
project into any of its fields, but for work/hrtimer use cases, it needs to be
able to find a specific field.
If we want a different name then I'd suggest `#[has]`.
Best,
Gary | {
"author": "\"Gary Guo\" <gary@garyguo.net>",
"date": "Fri, 27 Feb 2026 15:00:48 +0000",
"is_openbsd": false,
"thread_id": "DGPU1OF7TWG0.3EW2BO61C27C6@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Add a
new flag for these type of clocks, and update the clk core so that the
determine_rate() clk op is not required when this flag is set.
Signed-off-by: Brian Masney <bmasney@re... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:45 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | Add two new clk tests related to the CLK_ROUNDING_FW_MANAGED flag:
- Test that clk_hw_register() fails when determine_rate is not set.
- Test that clk_hw_register() succeeds when determine_rate is not set,
and CLK_ROUNDING_FW_MANAGED is set. clk_set_rate() works, and
clk_round_rate() returns the requested rate.
... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:46 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | This clk driver has a noop determine_rate clk op. Drop this empty
function, and enable the CLK_ROUNDING_FW_MANAGED flag.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Andrea della Porta <andrea.porta@suse.com>
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:47 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | This clk driver has a noop determine_rate clk op. Drop this empty
function, and enable the CLK_ROUNDING_FW_MANAGED flag.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Sudeep Holla <sudeep.holla@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Cristian Maru... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:48 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | This clk driver has a noop determine_rate clk op. Drop this empty
function, and enable the CLK_ROUNDING_FW_MANAGED flag.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.o... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:49 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | The init.ops is assigned a default value, however right below it is an
if, else if, and else where all of them also assign a value to init.ops.
Drop the redundant init.ops assignment at the top.
Fixes: 3b9ea606cda53 ("clk: imx: scu: add cpu frequency scaling support")
Signed-off-by: Brian Masney <bmasney@redhat.com>
... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:50 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | This clk driver has a noop determine_rate clk op. Drop this empty
function, and enable the CLK_ROUNDING_FW_MANAGED flag.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Abel Vesa <abelvesa@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
To: Frank Li <Frank.Li@n... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:51 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | This clk driver has a noop determine_rate clk op. Drop this empty
function, and enable the CLK_ROUNDING_FW_MANAGED flag.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Bjorn Andersson <andersson@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:52 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | This clk driver has a noop determine_rate clk op. Drop this empty
function, and enable the CLK_ROUNDING_FW_MANAGED flag.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Bjorn Andersson <andersson@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:53 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | This clk driver has a noop determine_rate clk op. Drop this empty
function, and enable the CLK_ROUNDING_FW_MANAGED flag.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Bjorn Andersson <andersson@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:54 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | This clk driver has a noop determine_rate clk op. Drop this empty
function, and enable the CLK_ROUNDING_FW_MANAGED flag.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Geert Uytterhoeven <geert+renesas@glider.be>
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-r... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:55 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | This clk driver has a noop determine_rate clk op. Drop this empty
function, and enable the CLK_ROUNDING_FW_MANAGED flag.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Chanw... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:56 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | This clk driver has a noop determine_rate clk op. Drop this empty
function, and enable the CLK_ROUNDING_FW_MANAGED flag.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
To: Orson Zhai <orsonzhai@gmail.com>
To: Baolin Wang <baolin... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Thu, 26 Feb 2026 13:16:57 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | On Thu, Feb 26, 2026 at 01:16:52PM -0500, Brian Masney wrote:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry | {
"author": "Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>",
"date": "Fri, 27 Feb 2026 02:07:20 +0200",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | On Thu, Feb 26, 2026 at 01:16:53PM -0500, Brian Masney wrote:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry | {
"author": "Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>",
"date": "Fri, 27 Feb 2026 02:12:57 +0200",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | On Thu, Feb 26, 2026 at 01:16:54PM -0500, Brian Masney wrote:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry | {
"author": "Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>",
"date": "Fri, 27 Feb 2026 02:13:14 +0200",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | On Thu, Feb 26, 2026 at 01:16:50PM -0500, Brian Masney wrote:
Reviewed-by: Peng Fan <peng.fan@nxp.com> | {
"author": "Peng Fan <peng.fan@oss.nxp.com>",
"date": "Fri, 27 Feb 2026 10:02:34 +0800",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | On Thu, Feb 26, 2026 at 01:16:51PM -0500, Brian Masney wrote:
Reviewed-by: Peng Fan <peng.fan@nxp.com> | {
"author": "Peng Fan <peng.fan@oss.nxp.com>",
"date": "Fri, 27 Feb 2026 10:04:22 +0800",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | Hi Brian,
Thanks for your patch!
On Thu, 26 Feb 2026 at 19:17, Brian Masney <bmasney@redhat.com> wrote:
s/hardware/firmware/
You got me totally confused, also/especially in the cover letter! ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert... | {
"author": "Geert Uytterhoeven <geert@linux-m68k.org>",
"date": "Fri, 27 Feb 2026 09:16:57 +0100",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | Hi Brian,
C Biju
On Thu, 26 Feb 2026 at 19:18, Brian Masney <bmasney@redhat.com> wrote:
Thanks for your patch!
Iff this is the Right Thing To Do (TM), it needs a comment, as this
clock is not managed by firmware.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux b... | {
"author": "Geert Uytterhoeven <geert@linux-m68k.org>",
"date": "Fri, 27 Feb 2026 09:20:09 +0100",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | Hi Brain,
Thanks for the patch
After applying patch#11, I get a message as you removed .determine_rate, Also it breaks display.
[ 0.096414] __clk_core_init: .pll5_foutpostdiv must implement .round_rate or .determine_rate in addition to .recalc_rate
Cheers,
Biju | {
"author": "Biju Das <biju.das.jz@bp.renesas.com>",
"date": "Fri, 27 Feb 2026 12:00:55 +0000",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | On Fri, Feb 27, 2026 at 12:00:55PM +0000, Biju Das wrote:
[snip]
Thanks for testing. This happens because rzg2l_cpg_pll_clk_register()
doesn't have the new flag set. I'll fix this, and go through all of the
others again just to make sure I don't miss any others.
Brian | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Fri, 27 Feb 2026 09:44:55 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | On Fri, Feb 27, 2026 at 09:20:09AM +0100, Geert Uytterhoeven wrote:
It needs a better name for the flag. I'll reply on patch 1 where more
people are CCed to see if we can come up with a better idea.
Brian | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Fri, 27 Feb 2026 09:46:38 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | Hi Geert,
On Fri, Feb 27, 2026 at 09:20:09AM +0100, Geert Uytterhoeven wrote:
Before I start a larger discussion on patch 1 with more people about a
name for this flag, help me understand why this provider has a noop
determine rate. Is the hardware eventually programmed with a rate
that's close enough to what was pas... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Fri, 27 Feb 2026 10:01:02 -0500",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | Hi Brian,
On Fri, 27 Feb 2026 at 16:01, Brian Masney <bmasney@redhat.com> wrote:
I'd like to defer to Biju, who added the empty round^Wdetermine rate
function.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversa... | {
"author": "Geert Uytterhoeven <geert@linux-m68k.org>",
"date": "Fri, 27 Feb 2026 16:09:27 +0100",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | Hi Brian/Geert,
PLL is capable of generating any frequency. that is the reason.
But we could, call rzg2l_cpg_get_foutpostdiv_rate() from determine_rate()
as modified rzg2l_cpg_get_foutpostdiv_rate()[1] can return errors
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cl... | {
"author": "Biju Das <biju.das.jz@bp.renesas.com>",
"date": "Fri, 27 Feb 2026 15:23:19 +0000",
"is_openbsd": false,
"thread_id": "20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com.mbox.gz"
} |
lkml_critique | lkml | Add an `active()` method to HrTimer that returns true if the timer is in
the started or running states. This wraps the kernel's hrtimer_active()
function.
Also add documentation clarifying the definition of an active timer.
Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
---
rust/kernel/time/hrtimer.rs | 10 ... | null | null | null | [PATCH] rust: hrtimer: add active() method to query timer state | On Sun, Feb 15, 2026 at 9:30 PM Andreas Hindborg <a.hindborg@kernel.org> wrote:
[`true`]
Since we try to add examples when we add APIs, could we perhaps add
one that inits a timers and asserts it is not active?
Thanks!
Cheers,
Miguel | {
"author": "Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>",
"date": "Sun, 15 Feb 2026 21:59:57 +0100",
"is_openbsd": false,
"thread_id": "DGPT98PHCRJK.24W50V2JKRE8K@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | Add an `active()` method to HrTimer that returns true if the timer is in
the started or running states. This wraps the kernel's hrtimer_active()
function.
Also add documentation clarifying the definition of an active timer.
Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
---
rust/kernel/time/hrtimer.rs | 10 ... | null | null | null | [PATCH] rust: hrtimer: add active() method to query timer state | On Sun Feb 15, 2026 at 8:29 PM GMT, Andreas Hindborg wrote:
This could be `#[inline]`.
Perhaps also mention that this function is safe to call without exclusive
requirement, as this is a common requiremnt for many other hrtimer functions.
Best,
Gary | {
"author": "\"Gary Guo\" <gary@garyguo.net>",
"date": "Fri, 27 Feb 2026 14:23:40 +0000",
"is_openbsd": false,
"thread_id": "DGPT98PHCRJK.24W50V2JKRE8K@garyguo.net.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | In preparation for adding display nodes. No other changes.
Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8167.dtsi | 68 ++++++++++++------------
1 file changed, 34 insertions(+), 34 delet... | {
"author": "Luca Leonardo Scorcia <l.scorcia@gmail.com>",
"date": "Mon, 23 Feb 2026 16:22:45 +0000",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | Add compatibles for various display-related blocks of MediaTek mt8167.
Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/displa... | {
"author": "Luca Leonardo Scorcia <l.scorcia@gmail.com>",
"date": "Mon, 23 Feb 2026 16:22:46 +0000",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | Add support for the MediaTek mt8167 SoC: the DSI PHY found
in this chip is fully compatible with the one found in the mt2701 SoC.
Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlows... | {
"author": "Luca Leonardo Scorcia <l.scorcia@gmail.com>",
"date": "Mon, 23 Feb 2026 16:22:47 +0000",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | Add all the DRM nodes required to get DSI to work on MT8167 SoC.
Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8167.dtsi | 317 +++++++++++++++++++++++
1 file changed, 317 insertions(+)
d... | {
"author": "Luca Leonardo Scorcia <l.scorcia@gmail.com>",
"date": "Mon, 23 Feb 2026 16:22:48 +0000",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | The mt8167 DSI controller is fully compatible with the one found in
mt2701. Device tree documentation is already present upstream.
Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/... | {
"author": "Luca Leonardo Scorcia <l.scorcia@gmail.com>",
"date": "Mon, 23 Feb 2026 16:22:49 +0000",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | From: Val Packett <val@packett.cool>
While this configuration is otherwise identical to mt8173, according
to Android kernel sources, this SoC does need smi_id_en.
Signed-off-by: Val Packett <val@packett.cool>
Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogio... | {
"author": "Luca Leonardo Scorcia <l.scorcia@gmail.com>",
"date": "Mon, 23 Feb 2026 16:22:50 +0000",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | Il 23/02/26 17:22, Luca Leonardo Scorcia ha scritto:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> | {
"author": "AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>",
"date": "Mon, 23 Feb 2026 17:39:49 +0100",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | On Mon, 23 Feb 2026 16:22:44 +0000, Luca Leonardo Scorcia wrote:
Applied to v7.0-next/dts64, thanks!
[1/6] arm64: dts: mt8167: Reorder nodes according to mmio address
commit: d51b7191f2072e11259edd2bff88385891d0ae56
Cheers,
Angelo | {
"author": "AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>",
"date": "Tue, 24 Feb 2026 10:34:01 +0100",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | On Mon, 2026-02-23 at 16:22 +0000, Luca Leonardo Scorcia wrote:
Reviewed-by: CK Hu <ck.hu@mediatek.com> | {
"author": "=?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= <ck.hu@mediatek.com>",
"date": "Wed, 25 Feb 2026 02:23:37 +0000",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | On Mon, 2026-02-23 at 16:22 +0000, Luca Leonardo Scorcia wrote:
If mt8167 DSI is fully compatible with mt2701 DSI, I think the binding document and device tree should be modified.
In device tree,
compatible = "mediatek,mt8167-dsi", "mediatek,mt2701-dsi";
And this patch is not necessary. | {
"author": "=?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= <ck.hu@mediatek.com>",
"date": "Wed, 25 Feb 2026 02:41:03 +0000",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | title:
drm/mediatek: ovl: add specific entry for mt8167
After this modification,
Reviewed-by: CK Hu <ck.hu@mediatek.com>
On Mon, 2026-02-23 at 16:22 +0000, Luca Leonardo Scorcia wrote: | {
"author": "=?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= <ck.hu@mediatek.com>",
"date": "Wed, 25 Feb 2026 02:52:46 +0000",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | Hi, if I understand your review correctly that's what v2 [1] of this
patch did, but the change was rejected during review.
As far as I can see there is no win-win solution here. This tricky
situation derives from the fact that in last year's submissions the
change was only partially merged - the bindings went upstream... | {
"author": "Luca Leonardo Scorcia <l.scorcia@gmail.com>",
"date": "Wed, 25 Feb 2026 09:15:54 +0100",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series adds support for the display blocks on MediaTek mt8167.
Tested on Xiaomi Mi Smart Clock x04g.
The first patch just does some reordering of dts nodes with no other
changes as this makes later patches cleaner and easier to follow.
v3:
- Added mt8167-dsi compatible to driver instead of changing the binding;... | null | null | null | [PATCH v3 0/6] Add support for mt8167 display blocks | On Mon, 23 Feb 2026 16:22:44 +0000, Luca Leonardo Scorcia wrote:
Applied, thanks!
[3/6] dt-bindings: phy: mediatek,dsi-phy: Add support for mt8167
commit: 7df891f2c39442c120fb4f9bfdd7c80e6de84015
Best regards,
--
~Vinod | {
"author": "Vinod Koul <vkoul@kernel.org>",
"date": "Fri, 27 Feb 2026 20:59:17 +0530",
"is_openbsd": false,
"thread_id": "cover.1771863641.git.l.scorcia@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | The current formula for calculating XDP tailroom in mbuf packets works only
if each frag has its own page (if rxq->frag_size is PAGE_SIZE), this
defeats the purpose of the parameter overall and without any indication
leads to negative calculated tailroom on at least half of frags, if shared
pages are used.
There are n... | {
"author": "Larysa Zaremba <larysa.zaremba@intel.com>",
"date": "Tue, 17 Feb 2026 14:24:39 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | rxq->frag_size is basically a step between consecutive strictly aligned
frames. In ZC mode, chunk size fits exactly, but if chunks are unaligned,
there is no safe way to determine accessible space to grow tailroom.
Report frag_size to be zero, if chunks are unaligned, chunk_size otherwise.
Fixes: 24ea50127ecf ("xsk: ... | {
"author": "Larysa Zaremba <larysa.zaremba@intel.com>",
"date": "Tue, 17 Feb 2026 14:24:40 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | XDP RxQ info contains frag_size, which depends on the MTU. This makes the
old way of registering RxQ info before calculating new buffer sizes
invalid. Currently, it leads to frag_size being outdated, making it
sometimes impossible to grow tailroom in a mbuf packet. E.g. fragments are
actually 3K+, but frag size is stil... | {
"author": "Larysa Zaremba <larysa.zaremba@intel.com>",
"date": "Tue, 17 Feb 2026 14:24:41 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | The only user of frag_size field in XDP RxQ info is
bpf_xdp_frags_increase_tail(). It clearly expects whole buff size instead
of DMA write size. Different assumptions in ice driver configuration lead
to negative tailroom.
This allows to trigger kernel panic, when using
XDP_ADJUST_TAIL_GROW_MULTI_BUFF xskxceiver test a... | {
"author": "Larysa Zaremba <larysa.zaremba@intel.com>",
"date": "Tue, 17 Feb 2026 14:24:42 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | Current way of handling XDP RxQ info in i40e has following problems:
* when xsk_buff_pool is detached, memory model is not unregistered before
registering a new one, this leads to a dangling xsk_buff_pool in the
memory model table
* frag_size is not updated when xsk_buff_pool is detached or when MTU is
changed, t... | {
"author": "Larysa Zaremba <larysa.zaremba@intel.com>",
"date": "Tue, 17 Feb 2026 14:24:43 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | The only user of frag_size field in XDP RxQ info is
bpf_xdp_frags_increase_tail(). It clearly expects whole buffer size instead
of DMA write size. Different assumptions in i40e driver configuration lead
to negative tailroom.
Set frag_size to the same value as frame_sz in shared pages mode, use new
helper to set frag_s... | {
"author": "Larysa Zaremba <larysa.zaremba@intel.com>",
"date": "Tue, 17 Feb 2026 14:24:44 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | The only user of frag_size field in XDP RxQ info is
bpf_xdp_frags_increase_tail(). It clearly expects whole buffer size instead
of DMA write size. Different assumptions in idpf driver configuration lead
to negative tailroom.
To make it worse, buffer sizes are not actually uniform in idpf when
splitq is enabled, as the... | {
"author": "Larysa Zaremba <larysa.zaremba@intel.com>",
"date": "Tue, 17 Feb 2026 14:24:45 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | The only user of frag_size field in XDP RxQ info is
bpf_xdp_frags_increase_tail(). It clearly expects truesize instead of DMA
write size. Different assumptions in enetc driver configuration lead to
negative tailroom.
Set frag_size to the same value as frame_sz.
Fixes: 2768b2e2f7d2 ("net: enetc: register XDP RX queues... | {
"author": "Larysa Zaremba <larysa.zaremba@intel.com>",
"date": "Tue, 17 Feb 2026 14:24:46 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | Many ethernet drivers report xdp Rx queue frag size as being the same as
DMA write size. However, the only user of this field, namely
bpf_xdp_frags_increase_tail(), clearly expects a truesize.
Such difference leads to unspecific memory corruption issues under certain
circumstances, e.g. in ixgbevf maximum DMA write si... | {
"author": "Larysa Zaremba <larysa.zaremba@intel.com>",
"date": "Tue, 17 Feb 2026 14:24:47 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | "growing" -> " growing" ?
Otherwise fine
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> | {
"author": "\"Loktionov, Aleksandr\" <aleksandr.loktionov@intel.com>",
"date": "Tue, 17 Feb 2026 15:06:13 +0000",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | From: Zaremba, Larysa <larysa.zaremba@intel.com>
Date: Tue, 17 Feb 2026 14:24:45 +0100
Acked-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Thanks for handling this!
Olek | {
"author": "Alexander Lobakin <aleksander.lobakin@intel.com>",
"date": "Tue, 17 Feb 2026 17:19:07 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | On Tue, Feb 17, 2026 at 02:24:43PM +0100, Larysa Zaremba wrote:
What is 'memory model table' in this context?
I believe you are referring to a case where XDP prog is kept alive on
interface put you close one socket and then bind the other one?
Good catch, i now see that i40e_change_mtu() only does the link flap and... | {
"author": "Maciej Fijalkowski <maciej.fijalkowski@intel.com>",
"date": "Thu, 19 Feb 2026 13:00:05 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | On Tue, Feb 17, 2026 at 02:24:42PM +0100, Larysa Zaremba wrote:
ice_setup_rx_ctx() consumes ring->rx_buf_len. This can't come from
page_pool when you have configured xsk_pool on a given rxq. I believe we
need a setting:
ring->rx_buf_len =
xsk_pool_get_rx_frame_size(ring->xsk_pool); | {
"author": "Maciej Fijalkowski <maciej.fijalkowski@intel.com>",
"date": "Fri, 27 Feb 2026 12:22:41 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Aside from the issue described below, tailroom calculation does not account
for pages being split between frags, e.g. in i40e, enetc and
AF_XDP ZC with smaller chunks. These series address the problem by
calculating modulo (skb_frag_off() % rxq->frag_size) in order to get
data offset within a smaller block of memory. P... | null | null | null | [PATCH bpf v3 0/9] Address XDP frags having negative tailroom | On Tue, Feb 17, 2026 at 02:24:38PM +0100, Larysa Zaremba wrote:
May I ask what was the testing approach against ice on your side? When I
run test_xsk.sh against tree with your series applied, I get a panic shown
below [1]. This comes from a test that modifies descriptor count on rings
and the trick is that it might b... | {
"author": "Maciej Fijalkowski <maciej.fijalkowski@intel.com>",
"date": "Fri, 27 Feb 2026 16:31:27 +0100",
"is_openbsd": false,
"thread_id": "aaG4z7ZIARBAzueO@boxer.mbox.gz"
} |
lkml_critique | lkml | Replace msleep() with fsleep() in rtw_cmd.c to improve delay
precision and follow modern kernel practices.
Specifically, this fixes a checkpatch warning for the 10ms delay
in _rtw_free_evt_priv() and updates the 100ms polling loop in
rtw_chk_hi_queue_hdl() for consistency.
Signed-off-by: Jose A. Perez de Azpillaga <a... | null | null | null | [PATCH] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c | On Wed Feb 25, 2026 at 7:05 PM CST, Jose A. Perez de Azpillaga wrote:
...
It's better to use USEC_PER_MSEC instead of 1000 to avoid magic numbers.
...
Ditto.
Thanks,
ET | {
"author": "\"Ethan Tidmore\" <ethantidmore06@gmail.com>",
"date": "Thu, 26 Feb 2026 20:03:39 -0600",
"is_openbsd": false,
"thread_id": "DGPUF5A1SKXT.3TSUTM6ZCRH3N@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Replace msleep() with fsleep() in rtw_cmd.c to improve delay
precision and follow modern kernel practices.
Specifically, this fixes a checkpatch warning for the 10ms delay
in _rtw_free_evt_priv() and updates the 100ms polling loop in
rtw_chk_hi_queue_hdl() for consistency.
Signed-off-by: Jose A. Perez de Azpillaga <a... | null | null | null | [PATCH] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c | Replace msleep() with fsleep() in rtw_cmd.c to improve delay
precision and follow modern kernel practices.
Specifically, this fixes a checkpatch warning for the 10ms delay
in _rtw_free_evt_priv() and updates the 100ms polling loops in
rtw_chk_hi_queue_hdl() and rtw_free_cmd_priv() for consistency.
Signed-off-by: Jose... | {
"author": "\"Jose A. Perez de Azpillaga\" <azpijr@gmail.com>",
"date": "Fri, 27 Feb 2026 09:46:12 +0100",
"is_openbsd": false,
"thread_id": "DGPUF5A1SKXT.3TSUTM6ZCRH3N@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Replace msleep() with fsleep() in rtw_cmd.c to improve delay
precision and follow modern kernel practices.
Specifically, this fixes a checkpatch warning for the 10ms delay
in _rtw_free_evt_priv() and updates the 100ms polling loop in
rtw_chk_hi_queue_hdl() for consistency.
Signed-off-by: Jose A. Perez de Azpillaga <a... | null | null | null | [PATCH] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c | On Fri Feb 27, 2026 at 2:46 AM CST, Jose A. Perez de Azpillaga wrote:
^^^
Remove this.
Here's Dan Carpenters's resource on making a v2:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Thanks,
ET | {
"author": "\"Ethan Tidmore\" <ethantidmore06@gmail.com>",
"date": "Fri, 27 Feb 2026 09:18:24 -0600",
"is_openbsd": false,
"thread_id": "DGPUF5A1SKXT.3TSUTM6ZCRH3N@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Use dev_err_probe() consistently in the probe path of several ADI IIO
drivers. This simplifies error handling and ensures proper logging of
deferred probes.
Each driver is updated by introducing a local struct device variable to
simplify repeated &spi->dev / &client->dev references, and converting
error paths to use d... | null | null | null | [PATCH v3 0/6] iio: use dev_err_probe in probe path for ADI drivers | Introduce a struct device *dev local variable and replace dev_err() +
return with dev_err_probe() in functions that use devm_ managed
resources. This simplifies error handling and ensures proper logging
of deferred probes.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/dac/ad7293.c | 32 +... | {
"author": "Antoniu Miclaus <antoniu.miclaus@analog.com>",
"date": "Wed, 25 Feb 2026 17:05:51 +0200",
"is_openbsd": false,
"thread_id": "aaGuzkHk6kCkcyiz@ashevche-desk.local.mbox.gz"
} |
lkml_critique | lkml | Use dev_err_probe() consistently in the probe path of several ADI IIO
drivers. This simplifies error handling and ensures proper logging of
deferred probes.
Each driver is updated by introducing a local struct device variable to
simplify repeated &spi->dev / &client->dev references, and converting
error paths to use d... | null | null | null | [PATCH v3 0/6] iio: use dev_err_probe in probe path for ADI drivers | Introduce a struct device *dev local variable and replace dev_err() +
return with dev_err_probe() in functions that use devm_ managed
resources. This simplifies error handling and ensures proper logging
of deferred probes.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/frequency/admv1013.... | {
"author": "Antoniu Miclaus <antoniu.miclaus@analog.com>",
"date": "Wed, 25 Feb 2026 17:05:49 +0200",
"is_openbsd": false,
"thread_id": "aaGuzkHk6kCkcyiz@ashevche-desk.local.mbox.gz"
} |
lkml_critique | lkml | Use dev_err_probe() consistently in the probe path of several ADI IIO
drivers. This simplifies error handling and ensures proper logging of
deferred probes.
Each driver is updated by introducing a local struct device variable to
simplify repeated &spi->dev / &client->dev references, and converting
error paths to use d... | null | null | null | [PATCH v3 0/6] iio: use dev_err_probe in probe path for ADI drivers | Introduce a struct device *dev local variable and replace dev_err() +
return with dev_err_probe() in functions that use devm_ managed
resources. This simplifies error handling and ensures proper logging
of deferred probes.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/frequency/adf4377.c... | {
"author": "Antoniu Miclaus <antoniu.miclaus@analog.com>",
"date": "Wed, 25 Feb 2026 17:05:50 +0200",
"is_openbsd": false,
"thread_id": "aaGuzkHk6kCkcyiz@ashevche-desk.local.mbox.gz"
} |
lkml_critique | lkml | Use dev_err_probe() consistently in the probe path of several ADI IIO
drivers. This simplifies error handling and ensures proper logging of
deferred probes.
Each driver is updated by introducing a local struct device variable to
simplify repeated &spi->dev / &client->dev references, and converting
error paths to use d... | null | null | null | [PATCH v3 0/6] iio: use dev_err_probe in probe path for ADI drivers | Introduce a struct device *dev local variable and replace dev_err() +
return with dev_err_probe() in functions that use devm_ managed
resources. This simplifies error handling and ensures proper logging
of deferred probes.
Drop 'SPI' from error messages since the bus type is evident from
the device hierarchy.
Signed-... | {
"author": "Antoniu Miclaus <antoniu.miclaus@analog.com>",
"date": "Wed, 25 Feb 2026 17:05:48 +0200",
"is_openbsd": false,
"thread_id": "aaGuzkHk6kCkcyiz@ashevche-desk.local.mbox.gz"
} |
lkml_critique | lkml | Use dev_err_probe() consistently in the probe path of several ADI IIO
drivers. This simplifies error handling and ensures proper logging of
deferred probes.
Each driver is updated by introducing a local struct device variable to
simplify repeated &spi->dev / &client->dev references, and converting
error paths to use d... | null | null | null | [PATCH v3 0/6] iio: use dev_err_probe in probe path for ADI drivers | Introduce a struct device *dev local variable and replace dev_err() +
return with dev_err_probe() in functions that use devm_ managed
resources. This simplifies error handling and ensures proper logging
of deferred probes.
Drop 'SPI' from error messages since the bus type is evident from
the device hierarchy.
Signed-... | {
"author": "Antoniu Miclaus <antoniu.miclaus@analog.com>",
"date": "Wed, 25 Feb 2026 17:05:47 +0200",
"is_openbsd": false,
"thread_id": "aaGuzkHk6kCkcyiz@ashevche-desk.local.mbox.gz"
} |
lkml_critique | lkml | Use dev_err_probe() consistently in the probe path of several ADI IIO
drivers. This simplifies error handling and ensures proper logging of
deferred probes.
Each driver is updated by introducing a local struct device variable to
simplify repeated &spi->dev / &client->dev references, and converting
error paths to use d... | null | null | null | [PATCH v3 0/6] iio: use dev_err_probe in probe path for ADI drivers | Introduce a struct device *dev local variable and replace dev_err() +
return with dev_err_probe() in functions that use devm_ managed
resources. This simplifies error handling and ensures proper logging
of deferred probes.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/filter/admv8818.c |... | {
"author": "Antoniu Miclaus <antoniu.miclaus@analog.com>",
"date": "Wed, 25 Feb 2026 17:05:52 +0200",
"is_openbsd": false,
"thread_id": "aaGuzkHk6kCkcyiz@ashevche-desk.local.mbox.gz"
} |
lkml_critique | lkml | Use dev_err_probe() consistently in the probe path of several ADI IIO
drivers. This simplifies error handling and ensures proper logging of
deferred probes.
Each driver is updated by introducing a local struct device variable to
simplify repeated &spi->dev / &client->dev references, and converting
error paths to use d... | null | null | null | [PATCH v3 0/6] iio: use dev_err_probe in probe path for ADI drivers | On Wed, Feb 25, 2026 at 05:05:46PM +0200, Antoniu Miclaus wrote:
Why? Maybe my comment was unclear previous time.
The idea is to convert to short dev the only lines that are not being touched
by the second (dev_err_probe() conversion) patch.
--
With Best Regards,
Andy Shevchenko | {
"author": "Andy Shevchenko <andriy.shevchenko@intel.com>",
"date": "Wed, 25 Feb 2026 18:15:04 +0200",
"is_openbsd": false,
"thread_id": "aaGuzkHk6kCkcyiz@ashevche-desk.local.mbox.gz"
} |
lkml_critique | lkml | Use dev_err_probe() consistently in the probe path of several ADI IIO
drivers. This simplifies error handling and ensures proper logging of
deferred probes.
Each driver is updated by introducing a local struct device variable to
simplify repeated &spi->dev / &client->dev references, and converting
error paths to use d... | null | null | null | [PATCH v3 0/6] iio: use dev_err_probe in probe path for ADI drivers | --
Antoniu Miclu
Sure, so for the function which use dev only for the dev errors I introduce the struct device *dev = &spi->dev; in the dev_error_probe patch? | {
"author": "\"Miclaus, Antoniu\" <Antoniu.Miclaus@analog.com>",
"date": "Fri, 27 Feb 2026 11:23:10 +0000",
"is_openbsd": false,
"thread_id": "aaGuzkHk6kCkcyiz@ashevche-desk.local.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.