data_type
large_stringclasses
3 values
source
large_stringclasses
29 values
code
large_stringlengths
98
49.4M
filepath
large_stringlengths
5
161
message
large_stringclasses
234 values
commit
large_stringclasses
234 values
subject
large_stringclasses
418 values
critique
large_stringlengths
101
1.26M
metadata
dict
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated by introducing a local struct device variable to simplify repeated &spi->dev / &client->dev references, and converting error paths to use d...
null
null
null
[PATCH v3 0/6] iio: use dev_err_probe in probe path for ADI drivers
On Fri, Feb 27, 2026 at 11:23:10AM +0000, Miclaus, Antoniu wrote: Whenever you use it first, there you introduce it. I believe in this case it will in the first patch of each driver subseries. Whatever the first patch is. -- With Best Regards, Andy Shevchenko
{ "author": "Andy Shevchenko <andriy.shevchenko@intel.com>", "date": "Fri, 27 Feb 2026 16:48:46 +0200", "is_openbsd": false, "thread_id": "aaGuzkHk6kCkcyiz@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
The indirection through the resources array is unnecessarily complicated and resuling in using IS_ERR() and PTR_ERR() on a valid address. A local variable for the devm_ioremap_resource() return value is both easier to read and matches expectations when reading code. Reported-by: Dan Carpenter <dan.carpenter@linaro.org...
null
null
null
[PATCH phy-next v2] phy: apple: apple: Use local variable for ioremap return value
On 15.02.26 09:02, Janne Grunau wrote: Reviewed-by: Sven Peter <sven@kernel.org> This is much easier to understand. I missed return PTR_ERR(..) error in the first version and introduced it originally due to the indirection as well. Best, Sven
{ "author": "Sven Peter <sven@kernel.org>", "date": "Sun, 15 Feb 2026 13:07:39 +0100", "is_openbsd": false, "thread_id": "177220616687.330302.14977409521915392205.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
The indirection through the resources array is unnecessarily complicated and resuling in using IS_ERR() and PTR_ERR() on a valid address. A local variable for the devm_ioremap_resource() return value is both easier to read and matches expectations when reading code. Reported-by: Dan Carpenter <dan.carpenter@linaro.org...
null
null
null
[PATCH phy-next v2] phy: apple: apple: Use local variable for ioremap return value
On Sun, Feb 15, 2026 at 09:02:51AM +0100, Janne Grunau wrote: Reviewed-by: Vladimir Oltean <olteanv@gmail.com> I hope this can be picked up for the linux-phy PR.
{ "author": "Vladimir Oltean <olteanv@gmail.com>", "date": "Mon, 16 Feb 2026 11:04:56 +0200", "is_openbsd": false, "thread_id": "177220616687.330302.14977409521915392205.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
The indirection through the resources array is unnecessarily complicated and resuling in using IS_ERR() and PTR_ERR() on a valid address. A local variable for the devm_ioremap_resource() return value is both easier to read and matches expectations when reading code. Reported-by: Dan Carpenter <dan.carpenter@linaro.org...
null
null
null
[PATCH phy-next v2] phy: apple: apple: Use local variable for ioremap return value
On Sun, 15 Feb 2026 09:02:51 +0100, Janne Grunau wrote: Applied, thanks! [1/1] phy: apple: apple: Use local variable for ioremap return value commit: 290a35756aaef85bbe0527eaf451f533a61b5f6c Best regards, -- ~Vinod
{ "author": "Vinod Koul <vkoul@kernel.org>", "date": "Fri, 27 Feb 2026 20:59:26 +0530", "is_openbsd": false, "thread_id": "177220616687.330302.14977409521915392205.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
Add the three namespace lifecycle hooks and make them available to bpf lsm program types. This allows bpf to supervise namespace creation. I'm in the process of adding various "universal truth" bpf programs to systemd that will make use of this. This e.g., allows to lock in a program into a given set of namespaces. Si...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Fri, 20 Feb 2026 01:38:29 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
Add a hook to manage attaching tasks to cgroup. I'm in the process of adding various "universal truth" bpf programs to systemd that will make use of this. This has been a long-standing request (cf. [1] and [2]). It will allow us to enforce cgroup migrations and ensure that services can never escape their cgroups. This...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Fri, 20 Feb 2026 01:38:30 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
Add a BPF LSM selftest that implements a "lock on entry" namespace sandbox policy. Signed-off-by: Christian Brauner <brauner@kernel.org> --- .../testing/selftests/bpf/prog_tests/ns_sandbox.c | 99 ++++++++++++++++++++++ .../testing/selftests/bpf/progs/test_ns_sandbox.c | 91 ++++++++++++++++++++ 2 files changed, 19...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Fri, 20 Feb 2026 01:38:31 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
Signed-off-by: Christian Brauner <brauner@kernel.org> --- .../selftests/bpf/prog_tests/cgroup_attach.c | 362 +++++++++++++++++++++ .../selftests/bpf/progs/test_cgroup_attach.c | 85 +++++ 2 files changed, 447 insertions(+) diff --git a/tools/testing/selftests/bpf/prog_tests/cgroup_attach.c b/tools/testi...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Fri, 20 Feb 2026 01:38:32 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
Hello, On Fri, Feb 20, 2026 at 01:38:30AM +0100, Christian Brauner wrote: dumber would also work. With CLONE_INTO_CGROUP, cgroup migration isn't necessary at all. Would something dumber like a mount option disabling cgroup migrations completely work too or would that be too restrictive? Thanks. -- tejun
{ "author": "Tejun Heo <tj@kernel.org>", "date": "Fri, 20 Feb 2026 05:16:13 -1000", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Fri, Feb 20, 2026 at 05:16:13AM -1000, Tejun Heo wrote: It would be too restrictive. I've played with various policies. For example, a small set of tasks (like PID 1 or the session manager) are allowed to move processes between cgroups (detectable via e.g., xattrs). No other task is allowd. But that's already too r...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Sat, 21 Feb 2026 18:57:24 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Fri, Feb 20, 2026 at 01:38:29AM +0100, Christian Brauner wrote: What's the reason for not adding these new hook points to the generic set of hooks that are currently being exposed directly by the LSM framework? Honestly, it seems a little odd to be providing declarations/definitions for a set of new hook points whi...
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Mon, 23 Feb 2026 10:36:19 +0000", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Mon, Feb 23, 2026 at 10:36:19AM +0000, Matt Bobrowski wrote: The LSM layer is of the opinion that adding new security hooks is only acceptable if an implementation for an in-tree LSM is provided alongside it (cf. [1]). IOW, your bpf lsm needs are not sufficient justification for adding new security hooks. So if you...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Mon, 23 Feb 2026 12:12:28 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On 2/20/26 01:38, Christian Brauner wrote: Thank you Christian, so if this feature is added we will also use it. The commit log says lock in a given set of namespaces where I see only setns path am I right? would it make sense to also have the check around some callers of create_new_namespaces() where appropriate bef...
{ "author": "Djalal Harouni <tixxdz@gmail.com>", "date": "Mon, 23 Feb 2026 13:44:23 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
Hi. On Fri, Feb 20, 2026 at 01:38:30AM +0100, Christian Brauner <brauner@kernel.org> wrote: These two issues are misconfigured/misunderstood PAM configs. I don't think those warrant introduction of another permissions mechanism, furthermore they're relatively old and I estimate many of such configs must have been fix...
{ "author": "Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>", "date": "Mon, 23 Feb 2026 16:47:11 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Mon, Feb 23, 2026 at 12:12:28PM +0100, Christian Brauner wrote: I apologize. I didn't realize that adding these as new generic LSM hooks points had already been proposed and discussed with the LSM maintainers. I just wanted to make sure that we weren't unintentionally side-stepping. Adding these dedicated BPF LSM...
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Tue, 24 Feb 2026 00:15:10 +0000", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Fri, Feb 20, 2026 at 01:38:29AM +0100, Christian Brauner wrote: Is the usage of __bpf_hook_start()/__bpf_hook_end() strictly necessary here? If so, why is that? My understanding was that they're only needed in situations where public function prototypes don't exist (e.g., BPF kfuncs).
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Tue, 24 Feb 2026 01:16:01 +0000", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Fri, Feb 20, 2026 at 01:38:29AM +0100, Christian Brauner wrote: I'm wondering how you foresee this hook functioning in a scenario where the BPF LSM program is attached to this new hook point, although with its attachment type being set to BPF_LSM_CGROUP instead of BPF_LSM_MAC? You probably wouldn't want to utilize ...
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Tue, 24 Feb 2026 13:35:11 +0000", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Thu, Feb 19, 2026 at 4:38 PM Christian Brauner <brauner@kernel.org> wrote: [...] If we change the hook as bpf_lsm_namespace_alloc(ns, inum); We can move it to the beginning of __ns_common_init(). This change allows blocking __ns_common_init() before it makes any changes to the ns. Is this a better approach? T...
{ "author": "Song Liu <song@kernel.org>", "date": "Tue, 24 Feb 2026 15:04:43 -0800", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Tue, Feb 24, 2026 at 03:04:43PM -0800, Song Liu wrote: I don't think it matters tbh. We have no control when exactly __ns_common_init() is called. That's up to the containing namespace. We can't rely on the namespace to have been correctly set up at this time. My main goal was to have struct ns_common to be fully i...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Fri, 27 Feb 2026 11:28:44 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Tue, Feb 24, 2026 at 01:16:01AM +0000, Matt Bobrowski wrote: I don't know. I just went by other sites that added bpf specific functions. Seems like bpf specific functions I'm adding so I used the hook annotation. If unneeded I happily drop it. I just need someone to tell whether that's right and I can't infer from ...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Fri, 27 Feb 2026 11:33:56 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Mon, Feb 23, 2026 at 01:44:23PM +0100, Djalal Harouni wrote: Yes. Yes, I have planned that but we will massage that codepath quite a bit this cycle to deal with some races so I'd rather push this out for this reason and also... ... I need to think about how exactly we should hook into that. Probably when we alre...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Fri, 27 Feb 2026 12:04:25 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Mon, Feb 23, 2026 at 04:47:11PM +0100, Michal Koutný wrote: logind has to allow cgroup migrations but for say Docker this shouldn't be allowed. So calling this misconfiguration is like taking a shortcut by simply pointing to a different destination. But fine, let's say you insist on this not being valid. A bunch ...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Fri, 27 Feb 2026 14:44:27 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
Hey, I'm in the process of adding "universal truths" bpf lsm programs to systemd that implement and enforce core system assumptions. One aspect of this will be advanced namespace management so we can have things like systemd-nsresourced tightly manage namespaces it allocates and implement advanced access policies for...
null
null
null
[PATCH 0/4] bpf: add a few hooks for sandboxing
On Tue, Feb 24, 2026 at 01:35:11PM +0000, Matt Bobrowski wrote: Oh, I very much would like this to be attachable to cgroups. But isn't this then a generic problem? What about: # RCU callbacks security_cred_free security_task_free security_inode_free_security_rcu security_bpf_prog_free security_xfrm_policy_free_secu...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Fri, 27 Feb 2026 15:33:21 +0100", "is_openbsd": false, "thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz" }
lkml_critique
lkml
A disconnect status BIT of USB2 PHY need to be cleared, otherwise it will fail to work properly during next connection when devices connect to roothub directly. Fixes: fe4bc1a08638 ("phy: spacemit: support K1 USB2.0 PHY controller") Signed-off-by: Yixun Lan <dlan@kernel.org> --- To: Vinod Koul <vkoul@kernel.org> To: N...
null
null
null
[PATCH v3] phy: k1-usb: add disconnect function support
On Mon, Feb 16, 2026 at 11:26:53PM +0800, Yixun Lan wrote: Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
{ "author": "Vladimir Oltean <olteanv@gmail.com>", "date": "Tue, 17 Feb 2026 00:12:54 +0200", "is_openbsd": false, "thread_id": "177220591203.320398.3042297469534840289.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
A disconnect status BIT of USB2 PHY need to be cleared, otherwise it will fail to work properly during next connection when devices connect to roothub directly. Fixes: fe4bc1a08638 ("phy: spacemit: support K1 USB2.0 PHY controller") Signed-off-by: Yixun Lan <dlan@kernel.org> --- To: Vinod Koul <vkoul@kernel.org> To: N...
null
null
null
[PATCH v3] phy: k1-usb: add disconnect function support
On Mon, 16 Feb 2026 23:26:53 +0800, Yixun Lan wrote: Applied, thanks! [1/1] phy: k1-usb: add disconnect function support commit: f0cf0a882a02dcf28547f32264f6fd37e9a7b147 Best regards, -- ~Vinod
{ "author": "Vinod Koul <vkoul@kernel.org>", "date": "Fri, 27 Feb 2026 20:55:12 +0530", "is_openbsd": false, "thread_id": "177220591203.320398.3042297469534840289.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v3 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
Convert Atmel system registers binding to YAML format. Signed-off-by: Akhila YS <akhilayalmati@gmail.com> --- .../devicetree/bindings/arm/atmel-sysregs.txt | 5 --- .../bindings/arm/microchip,sama7g5-chipid.yaml | 41 ++++++++++++++++++++++ 2 files changed, 41 insertions(+), 5 deletions(-) diff --git a/Doc...
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Thu, 26 Feb 2026 16:13:33 +0000", "is_openbsd": false, "thread_id": "20260226-arm-microchip-v3-0-0bda15abd922@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v3 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
Convert Atmel Periodic interval timer (PIT) binding to YAML format. Signed-off-by: Akhila YS <akhilayalmati@gmail.com> --- .../bindings/arm/atmel,at91sam9260-pit.yaml | 49 ++++++++++++++++++++++ .../devicetree/bindings/arm/atmel-sysregs.txt | 6 --- 2 files changed, 49 insertions(+), 6 deletions(-) dif...
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Thu, 26 Feb 2026 16:13:34 +0000", "is_openbsd": false, "thread_id": "20260226-arm-microchip-v3-0-0bda15abd922@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v3 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
Convert Atmel Periodic interval timer of 64bit (PIT64b) binding to YAML format. Changes during conversion: - Add missing compatible "microchip,sama7g5-pit64b" along with a fallback compatible "microchip,sam9x60-pit64b". Signed-off-by: Akhila YS <akhilayalmati@gmail.com> --- .../devicetree/bindings/arm/atmel-sysregs.t...
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Thu, 26 Feb 2026 16:13:35 +0000", "is_openbsd": false, "thread_id": "20260226-arm-microchip-v3-0-0bda15abd922@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v3 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
Convert System Timer binding to YAML format. Changes during conversion: - Add "#address-cells" and "#size-cells" to the properties and required as watchdog is defined as a child node to the timer parent node. - Define watchdog as a pattern property along with unit address in examples. Signed-off-by: Akhila YS <akh...
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Thu, 26 Feb 2026 16:13:36 +0000", "is_openbsd": false, "thread_id": "20260226-arm-microchip-v3-0-0bda15abd922@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v3 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
Convert RAMC SDRAM/DDR controller binding to YAML format. Signed-off-by: Akhila YS <akhilayalmati@gmail.com> --- .../bindings/arm/atmel,at91rm9200-sdramc.yaml | 67 ++++++++++++++++++++++ .../devicetree/bindings/arm/atmel-sysregs.txt | 20 ------- 2 files changed, 67 insertions(+), 20 deletions(-) diff --g...
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Thu, 26 Feb 2026 16:13:37 +0000", "is_openbsd": false, "thread_id": "20260226-arm-microchip-v3-0-0bda15abd922@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v3 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
On Thu, Feb 26, 2026 at 04:13:37PM +0000, Akhila YS wrote: Whoops, sorry for not noticing this earlier, but an items list with one entry can be reduced to that one entry. For you here that means that "- items enum:" becomes "- enum:".
{ "author": "Conor Dooley <conor@kernel.org>", "date": "Thu, 26 Feb 2026 18:12:19 +0000", "is_openbsd": false, "thread_id": "20260226-arm-microchip-v3-0-0bda15abd922@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v3 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
On Thu, Feb 26, 2026 at 04:13:32PM +0000, Akhila YS wrote: These first four patches are Acked-by: Conor Dooley <conor.dooley@microchip.com>
{ "author": "Conor Dooley <conor@kernel.org>", "date": "Thu, 26 Feb 2026 18:12:49 +0000", "is_openbsd": false, "thread_id": "20260226-arm-microchip-v3-0-0bda15abd922@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v3 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
On 26-02-2026 23:42, Conor Dooley wrote: Hi, i changed patch as per your suggestion, but i found some errors with  dtbs_check, anyway i sent  a v4 patch. let me know if any  changes required. -- Best Regards, Akhila.
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Fri, 27 Feb 2026 21:06:15 +0530", "is_openbsd": false, "thread_id": "20260226-arm-microchip-v3-0-0bda15abd922@gmail.com.mbox.gz" }
lkml_critique
lkml
When resctrl is unmounted, MPAM components should be reset to default configurations to avoid impacting system performance. However, after a user updates MPAM configuration via mpam_apply_config(), the in_reset_state flag remains true, causing mpam_reset_ris() to skip the actual register restoration on subsequent reset...
null
null
null
[PATCH] arm_mpam: Fix MPAM reset on resctrl unmount by clearing in_reset_state
Hi Zeng, On 2/13/26 07:50, Zeng Heng wrote: nit: MBMIN isn't currently supported in resctrl. I'd just drop the part in brackets. mpam_apply_config() doesn't exist in this commit. I would have expected: Fixes: 09b89d2a72f3 ("arm_mpam: Allow configuration to be applied and restored during cpu online") The change an...
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Tue, 17 Feb 2026 15:59:40 +0000", "is_openbsd": false, "thread_id": "5071eea1-97f6-45d7-aad0-b109080f3032@arm.com.mbox.gz" }
lkml_critique
lkml
When resctrl is unmounted, MPAM components should be reset to default configurations to avoid impacting system performance. However, after a user updates MPAM configuration via mpam_apply_config(), the in_reset_state flag remains true, causing mpam_reset_ris() to skip the actual register restoration on subsequent reset...
null
null
null
[PATCH] arm_mpam: Fix MPAM reset on resctrl unmount by clearing in_reset_state
On 2/17/26 15:59, Ben Horgan wrote: I'll add this on to the start of the current mpam resctrl series as even though this is squashing an existing bug it can't be hit until mpam has a user interface and so doesn't need to go as a fix. Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Fri, 27 Feb 2026 14:16:36 +0000", "is_openbsd": false, "thread_id": "5071eea1-97f6-45d7-aad0-b109080f3032@arm.com.mbox.gz" }
lkml_critique
lkml
Add support for the USB PHY and DWC2 IP which is used by Canaan K230, and made relevant changes to the DTS. This series is based on the initial 100ask K230 DshanPi series [1] which is based on the clock and pinctrl series. Check the details in the link. Link: https://lore.kernel.org/all/20260115060801.16819-1-jiayu.r...
null
null
null
[PATCH v5 0/4] Add USB support for Canaan K230
Add 'canaan,k230-usb' compatible string with 'snps,dwc2' as fallback for the DWC2 IP which is used by Canaan K230. Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Signed-off-by: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn> --- Documentation/devicetree/bindings/usb/dwc2.yaml | 3 +++ 1 file changed, 3 insertions(+) diff ...
{ "author": "Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>", "date": "Wed, 21 Jan 2026 22:55:23 +0800", "is_openbsd": false, "thread_id": "177220615264.330302.188095105582835535.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Add support for the USB PHY and DWC2 IP which is used by Canaan K230, and made relevant changes to the DTS. This series is based on the initial 100ask K230 DshanPi series [1] which is based on the clock and pinctrl series. Check the details in the link. Link: https://lore.kernel.org/all/20260115060801.16819-1-jiayu.r...
null
null
null
[PATCH v5 0/4] Add USB support for Canaan K230
K230 SoC USB PHY requires configuring registers for control and configuration. Add USB phy bindings for K230 SoC. Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Signed-off-by: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn> --- .../bindings/phy/canaan,k230-usb-phy.yaml | 35 +++++++++++++++++++ 1 file changed, 35 inser...
{ "author": "Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>", "date": "Wed, 21 Jan 2026 22:55:22 +0800", "is_openbsd": false, "thread_id": "177220615264.330302.188095105582835535.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Add support for the USB PHY and DWC2 IP which is used by Canaan K230, and made relevant changes to the DTS. This series is based on the initial 100ask K230 DshanPi series [1] which is based on the clock and pinctrl series. Check the details in the link. Link: https://lore.kernel.org/all/20260115060801.16819-1-jiayu.r...
null
null
null
[PATCH v5 0/4] Add USB support for Canaan K230
Add top syscon and USB PHY subdevice nodes, USB0/USB1 dwc2 controller to K230 DTSI, and enable UART0 and USB0/USB1 in DshanPI DT. Signed-off-by: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn> --- .../boot/dts/canaan/k230-canmv-dshanpi.dts | 17 +++++++++ arch/riscv/boot/dts/canaan/k230.dtsi | 35 ++++++++++++++++...
{ "author": "Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>", "date": "Wed, 21 Jan 2026 22:55:25 +0800", "is_openbsd": false, "thread_id": "177220615264.330302.188095105582835535.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Add support for the USB PHY and DWC2 IP which is used by Canaan K230, and made relevant changes to the DTS. This series is based on the initial 100ask K230 DshanPi series [1] which is based on the clock and pinctrl series. Check the details in the link. Link: https://lore.kernel.org/all/20260115060801.16819-1-jiayu.r...
null
null
null
[PATCH v5 0/4] Add USB support for Canaan K230
Add driver for the USB 2.0 PHY in Canaan K230 SoC, which supports PHY initialization and power management. Add Kconfig/Makefile under drivers/phy/canaan/. Signed-off-by: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn> --- drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1 + drivers/phy/canaa...
{ "author": "Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>", "date": "Wed, 21 Jan 2026 22:55:24 +0800", "is_openbsd": false, "thread_id": "177220615264.330302.188095105582835535.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Add support for the USB PHY and DWC2 IP which is used by Canaan K230, and made relevant changes to the DTS. This series is based on the initial 100ask K230 DshanPi series [1] which is based on the clock and pinctrl series. Check the details in the link. Link: https://lore.kernel.org/all/20260115060801.16819-1-jiayu.r...
null
null
null
[PATCH v5 0/4] Add USB support for Canaan K230
On Wed, Jan 21, 2026 at 10:55:21PM +0800, Jiayu Du wrote: Hello Vinod, could you please take a look at this patch? Thank you! Regards, Jiayu Du
{ "author": "Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>", "date": "Mon, 2 Feb 2026 19:31:36 +0800", "is_openbsd": false, "thread_id": "177220615264.330302.188095105582835535.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Add support for the USB PHY and DWC2 IP which is used by Canaan K230, and made relevant changes to the DTS. This series is based on the initial 100ask K230 DshanPi series [1] which is based on the clock and pinctrl series. Check the details in the link. Link: https://lore.kernel.org/all/20260115060801.16819-1-jiayu.r...
null
null
null
[PATCH v5 0/4] Add USB support for Canaan K230
On Mon, Feb 02, 2026 at 07:31:36PM +0800, Jiayu Du wrote: Hi Vinod, will you review this patch? Thank you again! Regards, Jiayu Du
{ "author": "Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>", "date": "Wed, 25 Feb 2026 20:14:46 +0800", "is_openbsd": false, "thread_id": "177220615264.330302.188095105582835535.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Add support for the USB PHY and DWC2 IP which is used by Canaan K230, and made relevant changes to the DTS. This series is based on the initial 100ask K230 DshanPi series [1] which is based on the clock and pinctrl series. Check the details in the link. Link: https://lore.kernel.org/all/20260115060801.16819-1-jiayu.r...
null
null
null
[PATCH v5 0/4] Add USB support for Canaan K230
On Wed, 21 Jan 2026 22:55:21 +0800, Jiayu Du wrote: Applied, thanks! [1/4] dt-bindings: phy: Add Canaan K230 USB PHY commit: 50357e7d7992ba8f02c87ff7a5c4db17918635da [3/4] phy: usb: Add driver for Canaan K230 USB 2.0 PHY commit: 8787fa1da603e9e51efff11841e97b5d374aef34 Best regards, -- ~Vinod
{ "author": "Vinod Koul <vkoul@kernel.org>", "date": "Fri, 27 Feb 2026 20:59:12 +0530", "is_openbsd": false, "thread_id": "177220615264.330302.188095105582835535.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/frequency/adrf6780.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git ...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:31 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/frequency/adrf6780.c | 35 ++++++++++++++++---------------- 1 file changed,...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:30 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/frequency/admv1014.c | 29 ++++++++++++++++------------- 1 file changed, 16...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:32 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/frequency/admv1014.c | 60 +++++++++++++------------------- 1 file changed, 24 insertions(+), 36 deletions(-) diff...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:33 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/frequency/admv1013.c | 29 +++++++++++++++-------------- 1 file changed, 15...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:34 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/frequency/admv1013.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/iio...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:35 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/frequency/adf4377.c | 27 ++++++++++++++------------- 1 file changed, 14 in...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:36 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/frequency/adf4377.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --g...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:37 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/dac/ad7293.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/iio/dac/ad7293.c b...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:39 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/dac/ad7293.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+)...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:38 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Introduce a local struct device pointer in functions that reference &spi->dev for device-managed resource calls and device property reads, improving code readability. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/filter/admv8818.c | 21 +++++++++++---------- 1 file changed, 11 insertions...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:40 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Use dev_err_probe() consistently in the probe path to simplify error handling and ensure deferred probes are logged correctly. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/iio/filter/admv8818.c | 35 ++++++++++++++--------------------- 1 file changed, 14 insertions(+), 21 deletions(-) diff...
{ "author": "Antoniu Miclaus <antoniu.miclaus@analog.com>", "date": "Fri, 27 Feb 2026 16:01:41 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Use dev_err_probe() consistently in the probe path of several ADI IIO drivers. This simplifies error handling and ensures proper logging of deferred probes. Each driver is updated in two patches: first introducing a local struct device *dev variable alongside the existing spi variable to replace &spi->dev references i...
null
null
null
[PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
On Fri, Feb 27, 2026 at 04:01:29PM +0200, Antoniu Miclaus wrote: Thanks, I briefly looked and it looks fine to me, Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> -- With Best Regards, Andy Shevchenko
{ "author": "Andy Shevchenko <andriy.shevchenko@intel.com>", "date": "Fri, 27 Feb 2026 17:03:44 +0200", "is_openbsd": false, "thread_id": "aaGyUMNzk9cNC5LG@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
Axiado AX3000 SoC contains Arasan PHY which provides the interface to the HS200 eMMC controller. This series includes: 1. Add bindings for Axiado AX3000 eMMC PHY 2. Add Axiado AX3000 eMMC phy driver 3. Update MAINTAINERS for the new driver 4. Update Axiado AX3000 device tree Changes in v2: - Fix dt-binding format - F...
null
null
null
[PATCH v2 0/4] Add eMMC PHY support for Axiado AX3000 SoC
From: SriNavmani A <srinavmani@axiado.com> Axiado AX3000 SoC contains Arasan PHY which provides the interface to the HS200 eMMC host controller. Signed-off-by: SriNavmani A <srinavmani@axiado.com> Signed-off-by: Tzu-Hao Wei <twei@axiado.com> --- .../bindings/phy/axiado,ax3000-emmc-phy.yaml | 37 +++++++++++++++...
{ "author": "Tzu-Hao Wei <twei@axiado.com>", "date": "Fri, 06 Feb 2026 16:22:08 +0800", "is_openbsd": false, "thread_id": "20260206-axiado-ax3000-add-emmc-phy-driver-support-v2-0-a2f59e97a92d@axiado.com.mbox.gz" }
lkml_critique
lkml
Axiado AX3000 SoC contains Arasan PHY which provides the interface to the HS200 eMMC controller. This series includes: 1. Add bindings for Axiado AX3000 eMMC PHY 2. Add Axiado AX3000 eMMC phy driver 3. Update MAINTAINERS for the new driver 4. Update Axiado AX3000 device tree Changes in v2: - Fix dt-binding format - F...
null
null
null
[PATCH v2 0/4] Add eMMC PHY support for Axiado AX3000 SoC
Add SriNavmani, Prasad and me as maintainers for Axiado AX3000 eMMC PHY driver Acked-by: Prasad Bolisetty <pbolisetty@axiado.com> Signed-off-by: Tzu-Hao Wei <twei@axiado.com> --- MAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 67db88b04537b431c927b7362499323...
{ "author": "Tzu-Hao Wei <twei@axiado.com>", "date": "Fri, 06 Feb 2026 16:22:10 +0800", "is_openbsd": false, "thread_id": "20260206-axiado-ax3000-add-emmc-phy-driver-support-v2-0-a2f59e97a92d@axiado.com.mbox.gz" }
lkml_critique
lkml
Axiado AX3000 SoC contains Arasan PHY which provides the interface to the HS200 eMMC controller. This series includes: 1. Add bindings for Axiado AX3000 eMMC PHY 2. Add Axiado AX3000 eMMC phy driver 3. Update MAINTAINERS for the new driver 4. Update Axiado AX3000 device tree Changes in v2: - Fix dt-binding format - F...
null
null
null
[PATCH v2 0/4] Add eMMC PHY support for Axiado AX3000 SoC
From: SriNavmani A <srinavmani@axiado.com> Add the eMMC PHY device tree node to the AX3000 SoC DTSI. AX3000 has one eMMC PHY interface. Signed-off-by: SriNavmani A <srinavmani@axiado.com> Signed-off-by: Tzu-Hao Wei <twei@axiado.com> --- arch/arm64/boot/dts/axiado/ax3000.dtsi | 7 +++++++ 1 file changed, 7 insertions...
{ "author": "Tzu-Hao Wei <twei@axiado.com>", "date": "Fri, 06 Feb 2026 16:22:11 +0800", "is_openbsd": false, "thread_id": "20260206-axiado-ax3000-add-emmc-phy-driver-support-v2-0-a2f59e97a92d@axiado.com.mbox.gz" }
lkml_critique
lkml
Axiado AX3000 SoC contains Arasan PHY which provides the interface to the HS200 eMMC controller. This series includes: 1. Add bindings for Axiado AX3000 eMMC PHY 2. Add Axiado AX3000 eMMC phy driver 3. Update MAINTAINERS for the new driver 4. Update Axiado AX3000 device tree Changes in v2: - Fix dt-binding format - F...
null
null
null
[PATCH v2 0/4] Add eMMC PHY support for Axiado AX3000 SoC
From: SriNavmani A <srinavmani@axiado.com> It provides the required configurations for Axiado eMMC PHY driver for HS200 mode. Signed-off-by: SriNavmani A <srinavmani@axiado.com> Co-developed-by: Prasad Bolisetty <pbolisetty@axiado.com> Signed-off-by: Prasad Bolisetty <pbolisetty@axiado.com> Signed-off-by: Tzu-Hao Wei...
{ "author": "Tzu-Hao Wei <twei@axiado.com>", "date": "Fri, 06 Feb 2026 16:22:09 +0800", "is_openbsd": false, "thread_id": "20260206-axiado-ax3000-add-emmc-phy-driver-support-v2-0-a2f59e97a92d@axiado.com.mbox.gz" }
lkml_critique
lkml
Axiado AX3000 SoC contains Arasan PHY which provides the interface to the HS200 eMMC controller. This series includes: 1. Add bindings for Axiado AX3000 eMMC PHY 2. Add Axiado AX3000 eMMC phy driver 3. Update MAINTAINERS for the new driver 4. Update Axiado AX3000 device tree Changes in v2: - Fix dt-binding format - F...
null
null
null
[PATCH v2 0/4] Add eMMC PHY support for Axiado AX3000 SoC
On Fri, 06 Feb 2026 16:22:08 +0800, Tzu-Hao Wei wrote: Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
{ "author": "\"Rob Herring (Arm)\" <robh@kernel.org>", "date": "Mon, 9 Feb 2026 19:30:29 -0600", "is_openbsd": false, "thread_id": "20260206-axiado-ax3000-add-emmc-phy-driver-support-v2-0-a2f59e97a92d@axiado.com.mbox.gz" }
lkml_critique
lkml
Axiado AX3000 SoC contains Arasan PHY which provides the interface to the HS200 eMMC controller. This series includes: 1. Add bindings for Axiado AX3000 eMMC PHY 2. Add Axiado AX3000 eMMC phy driver 3. Update MAINTAINERS for the new driver 4. Update Axiado AX3000 device tree Changes in v2: - Fix dt-binding format - F...
null
null
null
[PATCH v2 0/4] Add eMMC PHY support for Axiado AX3000 SoC
On 06-02-26, 16:22, Tzu-Hao Wei wrote: 2026 smaller hex case please, here and other places The bit define are used only once, why not define the cmd with respective bits here no power_off? -- ~Vinod
{ "author": "Vinod Koul <vkoul@kernel.org>", "date": "Fri, 27 Feb 2026 20:23:18 +0530", "is_openbsd": false, "thread_id": "20260206-axiado-ax3000-add-emmc-phy-driver-support-v2-0-a2f59e97a92d@axiado.com.mbox.gz" }
lkml_critique
lkml
Updates: v9 -> v8: - eswin,eic7700-sata-phy.yaml - Modify the format of the "default" field in the "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning" properties. - phy-eic7700-sata.c - Correct the incorrectly formatted symbol "-" in the comments. - Link to v8: https://lo...
null
null
null
[PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY
Document the SATA PHY on the EIC7700 SoC platform, describing its usage. Signed-off-by: Yulin Lu <luyulin@eswincomputing.com> --- .../bindings/phy/eswin,eic7700-sata-phy.yaml | 92 +++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/eswin,eic7700-sata-phy.ya...
{ "author": "Yulin Lu <luyulin@eswincomputing.com>", "date": "Thu, 5 Feb 2026 16:21:29 +0800", "is_openbsd": false, "thread_id": "177220617042.330302.2707782153123727768.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Updates: v9 -> v8: - eswin,eic7700-sata-phy.yaml - Modify the format of the "default" field in the "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning" properties. - phy-eic7700-sata.c - Correct the incorrectly formatted symbol "-" in the comments. - Link to v8: https://lo...
null
null
null
[PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY
Create the eswin phy driver directory and add support for the SATA PHY driver on the EIC7700 SoC platform. Signed-off-by: Yulin Lu <luyulin@eswincomputing.com> --- drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1 + drivers/phy/eswin/Kconfig | 14 ++ drivers/phy/esw...
{ "author": "Yulin Lu <luyulin@eswincomputing.com>", "date": "Thu, 5 Feb 2026 16:22:19 +0800", "is_openbsd": false, "thread_id": "177220617042.330302.2707782153123727768.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Updates: v9 -> v8: - eswin,eic7700-sata-phy.yaml - Modify the format of the "default" field in the "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning" properties. - phy-eic7700-sata.c - Correct the incorrectly formatted symbol "-" in the comments. - Link to v8: https://lo...
null
null
null
[PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY
On Thu, Feb 05, 2026 at 04:21:29PM +0800, Yulin Lu wrote: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Best regards, Krzysztof
{ "author": "Krzysztof Kozlowski <krzk@kernel.org>", "date": "Thu, 5 Feb 2026 14:41:44 +0100", "is_openbsd": false, "thread_id": "177220617042.330302.2707782153123727768.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Updates: v9 -> v8: - eswin,eic7700-sata-phy.yaml - Modify the format of the "default" field in the "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning" properties. - phy-eic7700-sata.c - Correct the incorrectly formatted symbol "-" in the comments. - Link to v8: https://lo...
null
null
null
[PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY
Hi Vinod, all, In v7, I got driver review comments from Vinod. After fixing and submitting v8, I received yaml comments from Krzysztof. v9 now has Reviewed-by from Krzysztof. So I want to confirm whether there are any further comments on the driver code in v9 and if it meets the requirements for merging. Best regards...
{ "author": "\"Yulin Lu\" <luyulin@eswincomputing.com>", "date": "Fri, 13 Feb 2026 14:20:26 +0800 (GMT+08:00)", "is_openbsd": false, "thread_id": "177220617042.330302.2707782153123727768.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Updates: v9 -> v8: - eswin,eic7700-sata-phy.yaml - Modify the format of the "default" field in the "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning" properties. - phy-eic7700-sata.c - Correct the incorrectly formatted symbol "-" in the comments. - Link to v8: https://lo...
null
null
null
[PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY
On Thu, 05 Feb 2026 16:20:09 +0800, Yulin Lu wrote: Applied, thanks! [1/2] dt-bindings: phy: eswin: Document the EIC7700 SoC SATA PHY commit: 820265f7b666d588bcb7df06f3332265c59e8cea [2/2] phy: eswin: Create eswin directory and add EIC7700 SATA PHY driver commit: 67ee9ccaa34a11c317411bb8e7d305d93d0b4111 ...
{ "author": "Vinod Koul <vkoul@kernel.org>", "date": "Fri, 27 Feb 2026 20:59:30 +0530", "is_openbsd": false, "thread_id": "177220617042.330302.2707782153123727768.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
When a process forks, the child process copies the parent's VMAs but the user_mapped reference count is not incremented. As a result, when both the parent and child processes exit, tracing_buffers_mmap_close() is called twice. On the second call, user_mapped is already 0, causing the function to return -ENODEV and trig...
null
null
null
[PATCH] tracing: Fix WARN_ON in tracing_buffers_mmap_close
On Fri, Feb 27, 2026 at 10:58:42AM +0800, Qing Wang wrote: Hum, not sure this is entirely correct. We do set VM_DONTCOPY when creating the mapping (see __rb_map_vma). So AFAICT ->open() is not called in this situation (see dup_mmap())
{ "author": "Vincent Donnefort <vdonnefort@google.com>", "date": "Fri, 27 Feb 2026 10:02:00 +0000", "is_openbsd": false, "thread_id": "aaG1Yl-HbPG3Buil@google.com.mbox.gz" }
lkml_critique
lkml
When a process forks, the child process copies the parent's VMAs but the user_mapped reference count is not incremented. As a result, when both the parent and child processes exit, tracing_buffers_mmap_close() is called twice. On the second call, user_mapped is already 0, causing the function to return -ENODEV and trig...
null
null
null
[PATCH] tracing: Fix WARN_ON in tracing_buffers_mmap_close
On Fri, Feb 27, 2026 at 10:02:00AM +0000, Vincent Donnefort wrote: Ah right, Syzkaller is using madvise(MADVISE_DOFORK) which resets VM_DONTCOPY.
{ "author": "Vincent Donnefort <vdonnefort@google.com>", "date": "Fri, 27 Feb 2026 10:41:17 +0000", "is_openbsd": false, "thread_id": "aaG1Yl-HbPG3Buil@google.com.mbox.gz" }
lkml_critique
lkml
When a process forks, the child process copies the parent's VMAs but the user_mapped reference count is not incremented. As a result, when both the parent and child processes exit, tracing_buffers_mmap_close() is called twice. On the second call, user_mapped is already 0, causing the function to return -ENODEV and trig...
null
null
null
[PATCH] tracing: Fix WARN_ON in tracing_buffers_mmap_close
On Fri, Feb 27, 2026 at 10:41:17AM +0000, Vincent Donnefort wrote: As we are applying restrictive rules for this mapping, I believe setting VM_IO might be a better fix.
{ "author": "Vincent Donnefort <vdonnefort@google.com>", "date": "Fri, 27 Feb 2026 11:22:22 +0000", "is_openbsd": false, "thread_id": "aaG1Yl-HbPG3Buil@google.com.mbox.gz" }
lkml_critique
lkml
When a process forks, the child process copies the parent's VMAs but the user_mapped reference count is not incremented. As a result, when both the parent and child processes exit, tracing_buffers_mmap_close() is called twice. On the second call, user_mapped is already 0, causing the function to return -ENODEV and trig...
null
null
null
[PATCH] tracing: Fix WARN_ON in tracing_buffers_mmap_close
On Fri, 27 Feb 2026 10:41:17 +0000 Vincent Donnefort <vdonnefort@google.com> wrote: Hmm, So this means user space can override the DONTCOPY? Can this cause bugs elsewhere that DONTCOPY is used? -- Steve
{ "author": "Steven Rostedt <rostedt@goodmis.org>", "date": "Fri, 27 Feb 2026 10:10:02 -0500", "is_openbsd": false, "thread_id": "aaG1Yl-HbPG3Buil@google.com.mbox.gz" }
lkml_critique
lkml
When a process forks, the child process copies the parent's VMAs but the user_mapped reference count is not incremented. As a result, when both the parent and child processes exit, tracing_buffers_mmap_close() is called twice. On the second call, user_mapped is already 0, causing the function to return -ENODEV and trig...
null
null
null
[PATCH] tracing: Fix WARN_ON in tracing_buffers_mmap_close
On Fri, Feb 27, 2026 at 10:10:02AM -0500, Steven Rostedt wrote: Indeed, user space can clear DONTCOPY... unless we also set VM_IO.
{ "author": "Vincent Donnefort <vdonnefort@google.com>", "date": "Fri, 27 Feb 2026 15:16:50 +0000", "is_openbsd": false, "thread_id": "aaG1Yl-HbPG3Buil@google.com.mbox.gz" }
lkml_critique
lkml
When a process forks, the child process copies the parent's VMAs but the user_mapped reference count is not incremented. As a result, when both the parent and child processes exit, tracing_buffers_mmap_close() is called twice. On the second call, user_mapped is already 0, causing the function to return -ENODEV and trig...
null
null
null
[PATCH] tracing: Fix WARN_ON in tracing_buffers_mmap_close
On Fri, 27 Feb 2026 11:22:22 +0000 Vincent Donnefort <vdonnefort@google.com> wrote: Agreed. -- Steve
{ "author": "Steven Rostedt <rostedt@goodmis.org>", "date": "Fri, 27 Feb 2026 10:20:38 -0500", "is_openbsd": false, "thread_id": "aaG1Yl-HbPG3Buil@google.com.mbox.gz" }
lkml_critique
lkml
Add methods to get a reference to the contained value or populate the SetOnce if empty. The new `as_ref_or_populate` method accepts a value directly, while `as_ref_or_populate_with` accepts a fallible closure, allowing for lazy initialization that may fail. Both methods spin-wait if another thread is concurrently initi...
null
null
null
[PATCH] rust: sync: add lazy initialization methods to SetOnce
On Sun Feb 15, 2026 at 9:27 PM CET, Andreas Hindborg wrote: I would name the argument `create`, but not `callable`. Same below. Cheers, Benno
{ "author": "\"Benno Lossin\" <lossin@kernel.org>", "date": "Mon, 16 Feb 2026 00:28:02 +0100", "is_openbsd": false, "thread_id": "DGPTYBO26YBT.3S14I9F5YT1PW@garyguo.net.mbox.gz" }
lkml_critique
lkml
Add methods to get a reference to the contained value or populate the SetOnce if empty. The new `as_ref_or_populate` method accepts a value directly, while `as_ref_or_populate_with` accepts a fallible closure, allowing for lazy initialization that may fail. Both methods spin-wait if another thread is concurrently initi...
null
null
null
[PATCH] rust: sync: add lazy initialization methods to SetOnce
On Sun, Feb 15, 2026 at 09:27:17PM +0100, Andreas Hindborg wrote: We should not be implementing our own spinlocks. Alice
{ "author": "Alice Ryhl <aliceryhl@google.com>", "date": "Mon, 16 Feb 2026 08:46:36 +0000", "is_openbsd": false, "thread_id": "DGPTYBO26YBT.3S14I9F5YT1PW@garyguo.net.mbox.gz" }
lkml_critique
lkml
Add methods to get a reference to the contained value or populate the SetOnce if empty. The new `as_ref_or_populate` method accepts a value directly, while `as_ref_or_populate_with` accepts a fallible closure, allowing for lazy initialization that may fail. Both methods spin-wait if another thread is concurrently initi...
null
null
null
[PATCH] rust: sync: add lazy initialization methods to SetOnce
"Alice Ryhl" <aliceryhl@google.com> writes: That is a great proverb. I'd be happy to receive a suggestion on an alternate approach for this particular context. Best regards, Andreas Hindborg
{ "author": "Andreas Hindborg <a.hindborg@kernel.org>", "date": "Mon, 16 Feb 2026 12:10:16 +0100", "is_openbsd": false, "thread_id": "DGPTYBO26YBT.3S14I9F5YT1PW@garyguo.net.mbox.gz" }
lkml_critique
lkml
Add methods to get a reference to the contained value or populate the SetOnce if empty. The new `as_ref_or_populate` method accepts a value directly, while `as_ref_or_populate_with` accepts a fallible closure, allowing for lazy initialization that may fail. Both methods spin-wait if another thread is concurrently initi...
null
null
null
[PATCH] rust: sync: add lazy initialization methods to SetOnce
On Mon, Feb 16, 2026 at 12:10:16PM +0100, Andreas Hindborg wrote: You can add a spinlock to SetOnce. Like I mentioned previously [1], support for waiting will require the addition of extra fields. I suppose we might be able to use include/linux/bit_spinlock.h here to avoid taking up any additional space. Alice [1]:...
{ "author": "Alice Ryhl <aliceryhl@google.com>", "date": "Mon, 16 Feb 2026 11:26:11 +0000", "is_openbsd": false, "thread_id": "DGPTYBO26YBT.3S14I9F5YT1PW@garyguo.net.mbox.gz" }
lkml_critique
lkml
Add methods to get a reference to the contained value or populate the SetOnce if empty. The new `as_ref_or_populate` method accepts a value directly, while `as_ref_or_populate_with` accepts a fallible closure, allowing for lazy initialization that may fail. Both methods spin-wait if another thread is concurrently initi...
null
null
null
[PATCH] rust: sync: add lazy initialization methods to SetOnce
On Mon, Feb 16, 2026 at 11:26:11AM +0000, Alice Ryhl wrote: By the way, back then I suggested renaming it from OnceLock to SetOnce because you did not support waiting for the value to be populated, and you said you didn't need that. If you add that feature, then we should rename it back to OnceLock, or create a new ty...
{ "author": "Alice Ryhl <aliceryhl@google.com>", "date": "Mon, 16 Feb 2026 11:35:27 +0000", "is_openbsd": false, "thread_id": "DGPTYBO26YBT.3S14I9F5YT1PW@garyguo.net.mbox.gz" }
lkml_critique
lkml
Add methods to get a reference to the contained value or populate the SetOnce if empty. The new `as_ref_or_populate` method accepts a value directly, while `as_ref_or_populate_with` accepts a fallible closure, allowing for lazy initialization that may fail. Both methods spin-wait if another thread is concurrently initi...
null
null
null
[PATCH] rust: sync: add lazy initialization methods to SetOnce
"Alice Ryhl" <aliceryhl@google.com> writes: Thanks, I'll be sure to take a look again. That is fair. This is a different use case than the original one though. I think we should keep this as one type for code reuse, but I am fine with renaming to something that describe the usage better. Best regards, Andreas Hin...
{ "author": "Andreas Hindborg <a.hindborg@kernel.org>", "date": "Mon, 16 Feb 2026 14:32:42 +0100", "is_openbsd": false, "thread_id": "DGPTYBO26YBT.3S14I9F5YT1PW@garyguo.net.mbox.gz" }
lkml_critique
lkml
Add methods to get a reference to the contained value or populate the SetOnce if empty. The new `as_ref_or_populate` method accepts a value directly, while `as_ref_or_populate_with` accepts a fallible closure, allowing for lazy initialization that may fail. Both methods spin-wait if another thread is concurrently initi...
null
null
null
[PATCH] rust: sync: add lazy initialization methods to SetOnce
On Sun Feb 15, 2026 at 8:27 PM GMT, Andreas Hindborg wrote: Hi Andreas, in an earlier call I mentioned that I'm working on getting SetOnce to work with pin-init, the capability of which I think is a superset of you have here. The API I have is impl<T> SetOnce<T> { pub fn init<E>(&self, init: impl Init<T, E>) -> ...
{ "author": "\"Gary Guo\" <gary@garyguo.net>", "date": "Fri, 27 Feb 2026 14:56:25 +0000", "is_openbsd": false, "thread_id": "DGPTYBO26YBT.3S14I9F5YT1PW@garyguo.net.mbox.gz" }
lkml_critique
lkml
The ADE9000_ST_ERROR macro references ADE9000_ST1_ERROR0 through ADE9000_ST1_ERROR3, but the actual defined symbols use the _BIT suffix. Fix the references to use the correct macro names. Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com> --- drivers/iio/adc/ade9000.c | 4 ++-- 1 file changed, 2 ...
null
null
null
[PATCH] iio: adc: ade9000: fix wrong macro names in ADE9000_ST_ERROR
On Fri, Feb 27, 2026 at 02:09:01PM +0400, Giorgi Tchankvetadze wrote: BIT (It's okay to drop "_" as "suffix" implies the position of the "BIT".) What about the current code that uses it? Is it even in use currently? Please, elaborate more in the commit message that we clearly understand that you spent time and inv...
{ "author": "Andy Shevchenko <andriy.shevchenko@intel.com>", "date": "Fri, 27 Feb 2026 12:33:00 +0200", "is_openbsd": false, "thread_id": "aaGt38ePGhonQRmd@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
The ADE9000_ST_ERROR macro references ADE9000_ST1_ERROR0 through ADE9000_ST1_ERROR3, but the actual defined symbols use the _BIT suffix. Fix the references to use the correct macro names. Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com> --- drivers/iio/adc/ade9000.c | 4 ++-- 1 file changed, 2 ...
null
null
null
[PATCH] iio: adc: ade9000: fix wrong macro names in ADE9000_ST_ERROR
On Fri, Feb 27, 2026 at 2:33 PM Andy Shevchenko <andriy.shevchenko@intel.com> wrote: Hi Andy. Thanks for the feedback ! The macro is currently unused in the driver, so this does not cause a build failure. Reference: ADE9000 datasheet (Rev. B, Page 61), STATUS1 register (0x403), bits 28-31 define ERROR0 through ERROR...
{ "author": "Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>", "date": "Fri, 27 Feb 2026 14:52:45 +0400", "is_openbsd": false, "thread_id": "aaGt38ePGhonQRmd@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
The ADE9000_ST_ERROR macro references ADE9000_ST1_ERROR0 through ADE9000_ST1_ERROR3, but the actual defined symbols use the _BIT suffix. Fix the references to use the correct macro names. Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com> --- drivers/iio/adc/ade9000.c | 4 ++-- 1 file changed, 2 ...
null
null
null
[PATCH] iio: adc: ade9000: fix wrong macro names in ADE9000_ST_ERROR
On Fri, Feb 27, 2026 at 02:52:45PM +0400, Giorgi Tchankvetadze wrote: Drop it then? Yes, good, this should be in the commit message. -- With Best Regards, Andy Shevchenko
{ "author": "Andy Shevchenko <andriy.shevchenko@intel.com>", "date": "Fri, 27 Feb 2026 16:44:47 +0200", "is_openbsd": false, "thread_id": "aaGt38ePGhonQRmd@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v18 0/3] Improve proc RSS accuracy
Introduce Kunit tests for hierarchical per-cpu counters. Keep track of two sets of hierarchical counters, each meant to have the same precise sum at any time, but distributed differently across the topology. Keep track of an atomic counter along with each hierarchical counter, for sum validation. Those tests cover: ...
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Fri, 27 Feb 2026 10:37:29 -0500", "is_openbsd": false, "thread_id": "20260227153730.1556542-4-mathieu.desnoyers@efficios.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v18 0/3] Improve proc RSS accuracy
Use hierarchical per-cpu counters for RSS tracking to improve the accuracy of per-mm RSS sum approximation on large many-core systems [1]. This improves the accuracy of the RSS values returned by proc interfaces. Here is a (possibly incomplete) list of the prior approaches that were used or proposed, along with their ...
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Fri, 27 Feb 2026 10:37:30 -0500", "is_openbsd": false, "thread_id": "20260227153730.1556542-4-mathieu.desnoyers@efficios.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v18 0/3] Improve proc RSS accuracy
* Motivation The purpose of this hierarchical split-counter scheme is to: - Minimize contention when incrementing and decrementing counters, - Provide fast access to a sum approximation, - Provide a sum approximation with an acceptable accuracy level when scaling to many-core systems. - Provide approximate and prec...
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Fri, 27 Feb 2026 10:37:28 -0500", "is_openbsd": false, "thread_id": "20260227153730.1556542-4-mathieu.desnoyers@efficios.com.mbox.gz" }
lkml_critique
lkml
Conversion from user_hz to jiffies broke with commit 2dc164a48e6fd ("sysctl: Create converter functions with two new macros") because the old overflow check in do_proc_dointvec_userhz_jiffies_conv() to see if "*u_ptr" was too large got replaced by an unconditional: + if (USER_HZ < HZ) + return -EIN...
null
null
null
[PATCH 1/1] time/jiffies: Fix conversion breakage on systems where USER_HZ < HZ
On Wed, Feb 25, 2026 at 03:37:49PM -0800, Gerd Rausch wrote: The internal kernel conversion itself is unchanged, it is informing user space about this conversion that broke. Right? In other words, you get an error when you read a sysctl file instead of an incorrect converted value. This fix looks good. I'll put it in ...
{ "author": "Joel Granados <joel.granados@kernel.org>", "date": "Fri, 27 Feb 2026 15:31:33 +0100", "is_openbsd": false, "thread_id": "png4vg76rrtjpk3k3es5knfrzelvjoebeeyaqii2lclxv5dcds@ujlxb4eg3lho.mbox.gz" }
lkml_critique
lkml
Conversion from user_hz to jiffies broke with commit 2dc164a48e6fd ("sysctl: Create converter functions with two new macros") because the old overflow check in do_proc_dointvec_userhz_jiffies_conv() to see if "*u_ptr" was too large got replaced by an unconditional: + if (USER_HZ < HZ) + return -EIN...
null
null
null
[PATCH 1/1] time/jiffies: Fix conversion breakage on systems where USER_HZ < HZ
On Wed, Feb 25, 2026 at 03:37:49PM -0800, Gerd Rausch wrote: I changed the message of the patch a bit. You can take a look here [1] Best [1] https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/commit/?h=sysctl-next&id=a17a86da1c90b62866bf2f45560510f2f6f18503 -- Joel Granados
{ "author": "Joel Granados <joel.granados@kernel.org>", "date": "Fri, 27 Feb 2026 16:03:44 +0100", "is_openbsd": false, "thread_id": "png4vg76rrtjpk3k3es5knfrzelvjoebeeyaqii2lclxv5dcds@ujlxb4eg3lho.mbox.gz" }
lkml_critique
lkml
I found the bash issue when running this new test on a SLE12-SP5. There are still other issues that would need to be addressed, but with this change, test-ftrace.sh can run on SLE12-SP5 withou issues. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (2): selftests: livepatch: t...
null
null
null
[PATCH 0/2] kselftests: livepatch: One new test and one fix for older bash
This is basically the inverse case of commit 474eecc882ae ("selftests: livepatch: test if ftrace can trace a livepatched function") but ensuring that livepatch would work on a traced function. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- tools/testing/selftests/livepatch/test-ftrace.sh | 36 +++++++++...
{ "author": "Marcos Paulo de Souza <mpdesouza@suse.com>", "date": "Fri, 20 Feb 2026 11:12:33 -0300", "is_openbsd": false, "thread_id": "42ab207746352197bc11fc9c2eafcb8663cd1362.camel@suse.com.mbox.gz" }
lkml_critique
lkml
I found the bash issue when running this new test on a SLE12-SP5. There are still other issues that would need to be addressed, but with this change, test-ftrace.sh can run on SLE12-SP5 withou issues. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (2): selftests: livepatch: t...
null
null
null
[PATCH 0/2] kselftests: livepatch: One new test and one fix for older bash
When running current selftests on older distributions like SLE12-SP5 that contains an older bash trips over heredoc. Convert it to plain echo calls, which ends up with the same result. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- tools/testing/selftests/livepatch/functions.sh | 6 ++---- 1 file chang...
{ "author": "Marcos Paulo de Souza <mpdesouza@suse.com>", "date": "Fri, 20 Feb 2026 11:12:34 -0300", "is_openbsd": false, "thread_id": "42ab207746352197bc11fc9c2eafcb8663cd1362.camel@suse.com.mbox.gz" }
lkml_critique
lkml
I found the bash issue when running this new test on a SLE12-SP5. There are still other issues that would need to be addressed, but with this change, test-ftrace.sh can run on SLE12-SP5 withou issues. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (2): selftests: livepatch: t...
null
null
null
[PATCH 0/2] kselftests: livepatch: One new test and one fix for older bash
On Fri, Feb 20, 2026 at 11:12:33AM -0300, Marcos Paulo de Souza wrote: nitpick: s/targgeting no/targeting on/ ? Otherwise LGTM, Acked-by: Joe Lawrence <joe.lawrence@redhat.com> -- Joe
{ "author": "Joe Lawrence <joe.lawrence@redhat.com>", "date": "Mon, 23 Feb 2026 10:39:14 -0500", "is_openbsd": false, "thread_id": "42ab207746352197bc11fc9c2eafcb8663cd1362.camel@suse.com.mbox.gz" }
lkml_critique
lkml
I found the bash issue when running this new test on a SLE12-SP5. There are still other issues that would need to be addressed, but with this change, test-ftrace.sh can run on SLE12-SP5 withou issues. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (2): selftests: livepatch: t...
null
null
null
[PATCH 0/2] kselftests: livepatch: One new test and one fix for older bash
On Fri, Feb 20, 2026 at 11:12:34AM -0300, Marcos Paulo de Souza wrote: Acked-by: Joe Lawrence <joe.lawrence@redhat.com> Just curious, what's the bash/heredoc issue? All I could find via google search was perhaps something to do with the temporary file implementation under the hood. -- Joe
{ "author": "Joe Lawrence <joe.lawrence@redhat.com>", "date": "Mon, 23 Feb 2026 10:42:14 -0500", "is_openbsd": false, "thread_id": "42ab207746352197bc11fc9c2eafcb8663cd1362.camel@suse.com.mbox.gz" }
lkml_critique
lkml
I found the bash issue when running this new test on a SLE12-SP5. There are still other issues that would need to be addressed, but with this change, test-ftrace.sh can run on SLE12-SP5 withou issues. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (2): selftests: livepatch: t...
null
null
null
[PATCH 0/2] kselftests: livepatch: One new test and one fix for older bash
On Mon, 2026-02-23 at 10:42 -0500, Joe Lawrence wrote: Thanks for the review Joe! # ./test-ftrace.sh cat: -: No such file or directory TEST: livepatch interaction with ftrace_enabled sysctl ... ^CQEMU: Terminated Somehow it doesn't understand the heredoc, but maybe I'm wrong... either way, the change has the same ...
{ "author": "Marcos Paulo de Souza <mpdesouza@suse.com>", "date": "Mon, 23 Feb 2026 13:21:43 -0300", "is_openbsd": false, "thread_id": "42ab207746352197bc11fc9c2eafcb8663cd1362.camel@suse.com.mbox.gz" }
lkml_critique
lkml
I found the bash issue when running this new test on a SLE12-SP5. There are still other issues that would need to be addressed, but with this change, test-ftrace.sh can run on SLE12-SP5 withou issues. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (2): selftests: livepatch: t...
null
null
null
[PATCH 0/2] kselftests: livepatch: One new test and one fix for older bash
On Fri, 20 Feb 2026 11:12:34 -0300 Marcos Paulo de Souza <mpdesouza@suse.com> wrote: Use printf so you can write both lines in one command. David
{ "author": "David Laight <david.laight.linux@gmail.com>", "date": "Mon, 23 Feb 2026 16:37:33 +0000", "is_openbsd": false, "thread_id": "42ab207746352197bc11fc9c2eafcb8663cd1362.camel@suse.com.mbox.gz" }
lkml_critique
lkml
I found the bash issue when running this new test on a SLE12-SP5. There are still other issues that would need to be addressed, but with this change, test-ftrace.sh can run on SLE12-SP5 withou issues. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (2): selftests: livepatch: t...
null
null
null
[PATCH 0/2] kselftests: livepatch: One new test and one fix for older bash
Hi, On Fri, 20 Feb 2026, Marcos Paulo de Souza wrote: with the typo fix that Joe mentioned Acked-by: Miroslav Benes <mbenes@suse.cz> M
{ "author": "Miroslav Benes <mbenes@suse.cz>", "date": "Thu, 26 Feb 2026 13:14:23 +0100 (CET)", "is_openbsd": false, "thread_id": "42ab207746352197bc11fc9c2eafcb8663cd1362.camel@suse.com.mbox.gz" }
lkml_critique
lkml
I found the bash issue when running this new test on a SLE12-SP5. There are still other issues that would need to be addressed, but with this change, test-ftrace.sh can run on SLE12-SP5 withou issues. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (2): selftests: livepatch: t...
null
null
null
[PATCH 0/2] kselftests: livepatch: One new test and one fix for older bash
Hi, On Mon, 23 Feb 2026, Marcos Paulo de Souza wrote: I cannot reproduce it locally on SLE12-SP5. The patched test-ftrace.sh runs smoothly without 2/2. linux:~/linux/tools/testing/selftests/livepatch # ./test-ftrace.sh TEST: livepatch interaction with ftrace_enabled sysctl ... ok TEST: trace livepatched function ...
{ "author": "Miroslav Benes <mbenes@suse.cz>", "date": "Thu, 26 Feb 2026 13:40:07 +0100 (CET)", "is_openbsd": false, "thread_id": "42ab207746352197bc11fc9c2eafcb8663cd1362.camel@suse.com.mbox.gz" }
lkml_critique
lkml
I found the bash issue when running this new test on a SLE12-SP5. There are still other issues that would need to be addressed, but with this change, test-ftrace.sh can run on SLE12-SP5 withou issues. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (2): selftests: livepatch: t...
null
null
null
[PATCH 0/2] kselftests: livepatch: One new test and one fix for older bash
On Thu, 2026-02-26 at 13:40 +0100, Miroslav Benes wrote: Nope: boot_livepatch:/mnt/tools/testing/selftests/livepatch # ./test-trace.sh + cat cat: -: No such file or directory + set_ftrace_enabled 1 + local can_fail=0 Same version here: GNU bash, version 4.3.48(1...
{ "author": "Marcos Paulo de Souza <mpdesouza@suse.com>", "date": "Thu, 26 Feb 2026 11:34:28 -0300", "is_openbsd": false, "thread_id": "42ab207746352197bc11fc9c2eafcb8663cd1362.camel@suse.com.mbox.gz" }
lkml_critique
lkml
I found the bash issue when running this new test on a SLE12-SP5. There are still other issues that would need to be addressed, but with this change, test-ftrace.sh can run on SLE12-SP5 withou issues. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (2): selftests: livepatch: t...
null
null
null
[PATCH 0/2] kselftests: livepatch: One new test and one fix for older bash
On Thu, 2026-02-26 at 11:34 -0300, Marcos Paulo de Souza wrote: This patch can be skipped. For the record, I discovered that it only happens when vng is called using --rw, making it to fail on older bash since it doesn't create overlays for /tmp. If the overlay is added the issue is gone. So, this patch can be skippe...
{ "author": "Marcos Paulo de Souza <mpdesouza@suse.com>", "date": "Fri, 27 Feb 2026 11:28:37 -0300", "is_openbsd": false, "thread_id": "42ab207746352197bc11fc9c2eafcb8663cd1362.camel@suse.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
On device shutdown, make vfio_pci_core_close_device() call vfio_pci_dma_buf_cleanup() before the function is disabled via vfio_pci_core_disable(). This ensures that any access to DMABUFs is revoked (and importers act on move_notify()) before the function's BARs become inaccessible. This fixes an issue where, if the f...
{ "author": "Matt Evans <mattev@meta.com>", "date": "Thu, 26 Feb 2026 12:21:58 -0800", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
A DMABUF exports access to BAR resources which need to be requested before the DMABUF is handed out. Usually the resources are requested when setting up the barmap when the VFIO device fd is mmap()ed, but there's no guarantee that happens before a DMABUF is created. Set up the barmap (and so request resources) in the...
{ "author": "Matt Evans <mattev@meta.com>", "date": "Thu, 26 Feb 2026 12:21:57 -0800", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }
lkml_critique
lkml
Hi all, There were various suggestions in the September 2025 thread "[TECH TOPIC] vfio, iommufd: Enabling user space drivers to vend more granular access to client processes" [0], and LPC discussions, around improving the situation for multi-process userspace driver designs. This RFC series implements some of these i...
null
null
null
[RFC PATCH 0/7] vfio/pci: Add mmap() for DMABUFs
Expand the VFIO DMABUF revocation state to three states: Not revoked, temporarily revoked, and permanently revoked. The first two are for existing transient revocation, e.g. across a function reset, and the DMABUF is put into the last in response to an ioctl(DMA_BUF_IOCTL_REVOKE) request. When triggered, dynamic impo...
{ "author": "Matt Evans <mattev@meta.com>", "date": "Thu, 26 Feb 2026 12:22:01 -0800", "is_openbsd": false, "thread_id": "a006b938-cd53-4c56-8131-30f557919ec6@amd.com.mbox.gz" }