Include dataset versions - support both "v2" and "v2_1" (default)

qa_srl2018.py

@@ -12,7 +12,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-"""TODO: Add a description here."""
+""" QA-SRL Bank v2 Dataset"""
 
 
 import datasets
@@ -44,26 +44,29 @@ _LICENSE = ""
 
 
 _URLs = {
-    "qasrl_v2.0": "http://qasrl.org/data/qasrl-v2.tar",
-    "qasrl_v2.1": "https://qasrl.org/data/qasrl-v2_1.tar"
+    "qasrl_v2": "http://qasrl.org/data/qasrl-v2.tar",
+    "qasrl_v2_1": "https://qasrl.org/data/qasrl-v2_1.tar"
 }
 
 SpanFeatureType = datasets.Sequence(datasets.Value("int32"), length=2)
 
-# TODO: Name of the dataset usually match the script name with CamelCase instead of snake_case
+# Name of the dataset usually match the script name with CamelCase instead of snake_case
 class QaSrl2018(datasets.GeneratorBasedBuilder):
     """QA-SRL2018: Large-Scale Question-Answer Driven Semantic Role Labeling corpus"""
 
-    VERSION = datasets.Version("1.0.1")
+    VERSION = datasets.Version("1.0.2")
 
     BUILDER_CONFIGS = [
         datasets.BuilderConfig(
-            name="plain_text", version=VERSION, description="This provides WIKIPEDIA dataset for qa_srl corpus"
+            name="v2", version=VERSION, description="This provides WIKIPEDIA dataset for qa_srl corpus (original version from Fitzgerald et. al., 2018)"
+        ),
+        datasets.BuilderConfig(
+            name="v2_1", version=VERSION, description="This provides WIKIPEDIA dataset for qa_srl corpus (version 2.1)"
         ),
     ]
 
     DEFAULT_CONFIG_NAME = (
-        "plain_text"  # It's not mandatory to have a default configuration. Just use one if it make sense.
+        "v2_1"  
     )
 
     def _info(self):
@@ -101,13 +104,10 @@ class QaSrl2018(datasets.GeneratorBasedBuilder):
         """Returns SplitGenerators."""
 
         # iterate the tar file of the corpus
-        
-        # Older version of the corpus (has some format errors):
-        # corpus_base_path = Path(dl_manager.download_and_extract(_URLs["qasrl_v2.0"]))
-        # corpus_orig = corpus_base_path / "qasrl-v2" / "orig"        
-        
-        corpus_base_path = Path(dl_manager.download_and_extract(_URLs["qasrl_v2.1"]))
-        corpus_orig = corpus_base_path / "qasrl-v2_1" / "orig"
+               
+        qasrl_dataset_version = self.config_id
+        corpus_base_path = Path(dl_manager.download_and_extract(_URLs[f"qasrl_{qasrl_dataset_version}"]))
+        corpus_orig = corpus_base_path / f"qasrl-{qasrl_dataset_version}" / "orig"
         
         
         # TODO add optional kwarg for genre (wikinews)