tidy script

early_printed_books_font_detection.py

@@ -13,13 +13,17 @@
 # limitations under the License.
 """Dataset of illustrated and non illustrated 19th Century newspaper ads."""
 
-import os
+import zipfile
 from pathlib import Path
 
 import datasets
 import requests
 from PIL import Image
 
+# Some of the images are large so we set this to avoid Decompression bomb warnings
+
+Image.MAX_IMAGE_PIXELS = None
+
 _CITATION = """\
 @dataset{seuret_mathias_2019_3366686,
   author       = {Seuret, Mathias and
@@ -95,18 +99,17 @@ class EarlyBookFonts(datasets.GeneratorBasedBuilder):
             if file["type"] == "zip"
         )
         *image_urls, label_url = urls
-        config = datasets.DownloadConfig()
-        labels = dl_manager.download_and_extract(label_url)
+        labels = dl_manager.download(label_url)
         images = dl_manager.download_and_extract(image_urls)
 
         return [
             datasets.SplitGenerator(
                 name=datasets.Split.TRAIN,
-                gen_kwargs={"images": images, "labels": os.path.join(labels), "split": "training"},
+                gen_kwargs={"images": images, "labels": labels, "split": "training"},
             ),
             datasets.SplitGenerator(
                 name=datasets.Split.TEST,
-                gen_kwargs={"images": images, "labels": os.path.join(labels), "split": "test"},
+                gen_kwargs={"images": images, "labels": labels, "split": "test"},
             ),
         ]
 
@@ -115,11 +118,14 @@ class EarlyBookFonts(datasets.GeneratorBasedBuilder):
         for directory in images:
             for file in Path(directory).rglob("*"):
                 mapping["/".join(file.parts[-2:])] = file
-        with open(f"labels-{split}.csv", 'r') as label_csv:
-            for id_, row in enumerate(label_csv.readlines()):
-                filename, *labels = row.split(",")
-                labels = [label.strip("\n") for label in labels]
-                labels = [label for label in labels if label != '-']
-                filename = mapping[filename]
-                image = Image.open(filename)
-                yield id_, {"image": image, "labels": labels}
+        with zipfile.ZipFile(labels) as labelzip:
+            with labelzip.open(f"labels-{split}.csv") as label_csv:
+                for id_, row in enumerate(label_csv.readlines()):
+                    row = row.decode("utf-8")
+                    filename, *labels = row.split(",")
+                    labels = [label.strip("\n") for label in labels]
+                    labels = [label for label in labels if label != "-"]
+                    filename = mapping[filename]
+
+                    image = Image.open(filename)
+                    yield id_, {"image": image, "labels": labels}