ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
mentioned happen | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { List < ? > VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( ! VAR_2 . isEmpty ( ) ) { TYPE_2 VAR_3 = <START> VAR_1 . METHOD_3 ( ) ; <END> TYPE_3 method = METHOD_4 ( VAR_3 ) ; METHOD_5 ( method , VAR_2 , VAR_3 . METHOD_6 ( ) ) ; } return super . METHOD_1 ( VAR_1 ) ; } | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { List < ? > VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( ! VAR_2 . isEmpty ( ) ) { TYPE_2 VAR_3 = VAR_1 . METHOD_3 ( ) ; if ( VAR_3 != null ) { TYPE_3 method = METHOD_4 ( VAR_3 ) ; METHOD_5 ( method , VAR_2 , VAR_3 . METHOD_6 ( ) ) ; } } return super . METHOD_1 ( VAR_1 ) ; } |
VAR_3 METHOD_5 ( ) NPE line question t resolve bindings TYPE_1 METHOD_3 ( ) return null especially s plenty errors local METHOD_3 ( ) checks s fine VAR_3 METHOD_5 ( ) fail | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { List < ? > VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( ! VAR_2 . isEmpty ( ) ) { TYPE_2 VAR_3 = <START> VAR_1 . METHOD_3 ( ) ; <END> TYPE_3 method = METHOD_3 ( VAR_3 ) ; METHOD_4 ( method , VAR_2 , VAR_3 . METHOD_5 ( ) ) ; } return super . METHOD_1 ( VAR_1 ) ; } | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { List < ? > VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( ! VAR_2 . isEmpty ( ) ) { TYPE_2 VAR_3 = VAR_1 . METHOD_3 ( ) ; if ( VAR_3 != null ) { TYPE_3 method = METHOD_3 ( VAR_3 ) ; METHOD_4 ( method , VAR_2 , VAR_3 . METHOD_5 ( ) ) ; } } return super . METHOD_1 ( VAR_1 ) ; } |
implementing classes able override method stuff prepare workspace static | public static void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( ) ; Thread . VAR_1 ( ) . METHOD_3 ( STRING_1 ) ; TYPE_4 . VAR_3 = INT_1 ; TYPE_4 . VAR_4 = STRING_2 ; TYPE_2 VAR_5 = new TYPE_2 ( ) ; TYPE_1 . METHOD_4 ( STRING_3 , VAR_5 ) ; <START> METHOD_5 ( ) ; <END> TYPE_3 . METHOD_6 ( ) ; TYPE_1 . METHOD_7 ( VAR_6 ) ; } | public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( ) ; Thread . VAR_1 ( ) . METHOD_3 ( STRING_1 ) ; TYPE_4 . VAR_3 = INT_1 ; TYPE_4 . VAR_4 = STRING_2 ; TYPE_2 VAR_5 = new TYPE_2 ( ) ; TYPE_1 . METHOD_4 ( STRING_3 , VAR_5 ) ; METHOD_5 ( ) ; TYPE_3 . METHOD_6 ( ) ; TYPE_1 . METHOD_7 ( VAR_6 ) ; } |
part move _CODE_ ( ) project deleted test created | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ) ; TYPE_1 . METHOD_3 ( VAR_2 , VAR_1 ) ; <END> } | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) ; } |
inline instead | <START> public static void METHOD_1 ( ) { <END> TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 . METHOD_3 ( ) , VAR_3 ) ; VAR_4 = TYPE_1 . METHOD_4 ( VAR_5 , VAR_2 . getName ( ) ) ; } | public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 . METHOD_3 ( ) , VAR_3 ) ; VAR_4 = TYPE_1 . METHOD_4 ( VAR_5 , VAR_2 . getName ( ) ) ; } |
s - static - private s a function useful line | <START> private static int METHOD_1 ( int VAR_1 , int VAR_2 ) { <END> return ( INT_1 * VAR_1 + VAR_2 - 1 ) / VAR_2 ; } | static int METHOD_1 ( int VAR_1 , int VAR_2 ) { return ( INT_1 * VAR_1 + VAR_2 - 1 ) / VAR_2 ; } |
slightly shorter : ( info VAR_1 = = null ) { info VAR_1 = TYPE_2 VAR_1 ( info method ) ; } return info VAR_1 ; | private boolean METHOD_1 ( TYPE_1 info ) { <START> if ( info . VAR_1 != null ) <END> return info . VAR_1 ; info . VAR_1 = TYPE_2 . METHOD_1 ( info . method ) ; return info . VAR_1 ; } | private boolean METHOD_1 ( TYPE_1 info ) { if ( info . VAR_1 == null ) { info . VAR_1 = TYPE_2 . METHOD_1 ( info . method ) ; } return info . VAR_1 ; } |
case a resource ? weren t previously setting resource input change break existing clients _CODE_ class especially subclasses | protected TYPE_1 METHOD_1 ( Object VAR_1 ) { Object input = VAR_1 ; if ( input instanceof TYPE_2 ) { final TYPE_3 VAR_2 = ( ( TYPE_2 ) input ) . METHOD_2 ( ) ; <START> if ( VAR_2 . METHOD_3 ( ) != null ) { <END> input = VAR_2 . METHOD_3 ( ) ; } else { input = VAR_2 ; } } if ( ! TYPE_1 . class . METHOD_4 ( input ) ) { t... | protected TYPE_1 METHOD_1 ( Object VAR_1 ) { Object input = VAR_1 ; if ( input instanceof TYPE_2 ) { input = ( ( TYPE_2 ) input ) . METHOD_2 ( ) ; } if ( ! TYPE_1 . class . METHOD_4 ( input ) ) { throw new IllegalStateException ( STRING_1 ) ; } return ( TYPE_1 ) input ; } |
static | <START> private org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . TYPE_1 METHOD_1 ( TYPE_1 VAR_6 ) { <END> return new org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . TYPE_1 ( TYPE_2 . create ( VAR_6 . METHOD_2 ( ) ) , VAR_6 . getName ( ) , TYPE_3 . VAR_8 , VAR_6 . METHOD_3 ( ) ? TYPE_3 . VAR_9 : TYPE_3 . NONE ) ; } | private static org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . TYPE_1 METHOD_1 ( TYPE_1 VAR_6 ) { return new org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . TYPE_1 ( TYPE_2 . create ( VAR_6 . METHOD_2 ( ) ) , VAR_6 . getName ( ) , TYPE_3 . VAR_8 , VAR_6 . METHOD_3 ( ) ? TYPE_3 . VAR_9 : TYPE_3 . NONE ) ; } |
loop | private Set < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { final Set < TYPE_1 > VAR_2 = new TYPE_3 < > ( ) ; <START> for ( int <END> i = 0 ; i < VAR_1 . VAR_3 . length ; i ++ ) { final TYPE_4 VAR_4 = VAR_1 . VAR_3 [ i ] ; VAR_4 . METHOD_2 ( VAR_2 ) ; } return VAR_2 ; } | private Set < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { final Set < TYPE_1 > VAR_2 = new TYPE_3 < > ( ) ; for ( final TYPE_4 VAR_4 : VAR_1 . VAR_3 ) { VAR_4 . METHOD_2 ( VAR_2 ) ; } return VAR_2 ; } |
method need return a boolean type returns true | <START> private boolean METHOD_1 ( ) throws IOException { ANNOTATION_1 ( STRING_1 ) TYPE_1 err = new TYPE_1 ( TYPE_1 . VAR_1 , TYPE_1 . VAR_2 , VAR_3 ) ; err . write ( Constants . VAR_4 ( TYPE_2 . get ( ) . VAR_5 ) ) ; err . VAR_6 ( ) ; return true ; } <END> | private void METHOD_1 ( ) throws IOException { ANNOTATION_1 ( STRING_1 ) TYPE_1 err = new TYPE_1 ( TYPE_1 . VAR_1 , TYPE_1 . VAR_2 , VAR_3 ) ; err . write ( Constants . VAR_4 ( TYPE_2 . get ( ) . VAR_5 ) ) ; err . VAR_6 ( ) ; } |
shouldn t pass _CODE_ DEFAULT_EXPERIMENT_TYPE instead | public TYPE_4 ( final Class < ? extends TYPE_1 > type , final String path , final TYPE_2 [ ] VAR_2 , final int VAR_3 , final ANNOTATION_1 TYPE_3 resource ) { METHOD_1 ( type , path , VAR_2 , VAR_3 , resource , <START> null ) ; <END> } | public TYPE_4 ( final Class < ? extends TYPE_1 > type , final String path , final TYPE_2 [ ] VAR_2 , final int VAR_3 , final ANNOTATION_1 TYPE_3 resource ) { METHOD_1 ( type , path , VAR_2 , VAR_3 , resource ) ; } |
special code null ( comparing size size hash map ) | <START> public boolean contains ( Object o ) { <END> return VAR_1 . METHOD_1 ( o ) ; } | public boolean contains ( Object o ) { return ( o == null && size ( ) > VAR_1 . size ( ) ) || VAR_1 . METHOD_1 ( o ) ; } |
else blocks unnecessary write result = VAR_1 | protected void METHOD_1 ( Collection < T > VAR_1 ) { <START> if ( VAR_1 == null ) { <END> result = null ; } else { result = VAR_1 ; } } | protected void METHOD_1 ( Collection < T > VAR_1 ) { result = VAR_1 ; } |
new API I d prefer return java util Optional < T > instead null avoid potential _CODE_ | <START> public T METHOD_1 ( ) { <END> Collection < T > list = METHOD_2 ( ) ; if ( list == null ) { return null ; } Iterator < T > iterator = list . iterator ( ) ; if ( iterator . hasNext ( ) ) { return iterator . next ( ) ; } return null ; } | public Optional < T > METHOD_1 ( ) { Collection < T > list = METHOD_2 ( ) ; Iterator < T > iterator = list . iterator ( ) ; if ( iterator . hasNext ( ) ) { return Optional . of ( iterator . next ( ) ) ; } return Optional . empty ( ) ; } |
simply result = VAR_1 changed _CODE_ ( ) mehtod manage null | protected void METHOD_1 ( Collection < T > VAR_1 ) { <START> if ( VAR_1 == null ) { <END> result = Collections . VAR_2 ( ) ; } else { result = VAR_1 ; } } | protected void METHOD_1 ( Collection < T > VAR_1 ) { if ( VAR_1 == null ) { result = null ; } else { result = VAR_1 ; } } |
simply set result null | protected void METHOD_1 ( T ... VAR_1 ) { if ( VAR_1 == null ) { <START> result = Collections . VAR_2 ( ) ; <END> } else { result = Arrays . asList ( VAR_1 ) ; } } | protected void METHOD_1 ( T ... VAR_1 ) { if ( VAR_1 == null ) { result = null ; } else { result = Arrays . asList ( VAR_1 ) ; } } |
I s move METHOD_2 method ? moment caller ( L360 ) future called else patch won t effective | public boolean METHOD_1 ( ) { if ( VAR_1 == TYPE_1 . VAR_3 ) { METHOD_2 ( ) ; <START> if ( VAR_1 == TYPE_1 . VAR_3 ) { VAR_1 = TYPE_1 . VAR_4 ; } <END> } return VAR_1 == TYPE_1 . VAR_4 ; } | public boolean METHOD_1 ( ) { if ( VAR_1 == TYPE_1 . VAR_3 ) { METHOD_2 ( ) ; } return VAR_1 == TYPE_1 . VAR_4 ; } |
necessary VAR_1 UI thread | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { if ( VAR_1 == null || VAR_1 . METHOD_2 ( ) != VAR_2 ) { return ; } VAR_2 = null ; <START> TYPE_2 r = this : : METHOD_3 ; <END> if ( TYPE_3 . METHOD_4 ( ) == null ) { TYPE_3 d = TYPE_3 . METHOD_5 ( ) ; if ( ! d . VAR_3 ( ) ) { d . VAR_4 ( r ) ; } } else { r . run ( ) ... | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { if ( VAR_1 == null || VAR_1 . METHOD_2 ( ) != VAR_2 ) { return ; } VAR_2 = null ; METHOD_3 ( ) ; } |
TYPE_9 : : new remove local variable VAR_5 altogether | private TYPE_1 [ ] METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( ) { @Override public TYPE_3 METHOD_2 ( TYPE_4 parent , TYPE_5 VAR_2 , TYPE_6 VAR_3 , TYPE_7 VAR_4 ) { return new TYPE_3 ( parent , VAR_2 , VAR_3 , VAR_4 ) ; } @Override public boolean METHOD_3 ( ) { return false ; } } ; TYPE_8 VAR_5 = TYPE_9 : : new ; return... | private TYPE_1 [ ] METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( ) { @Override public TYPE_3 METHOD_2 ( TYPE_4 parent , TYPE_5 VAR_2 , TYPE_6 VAR_3 , TYPE_7 VAR_4 ) { return new TYPE_3 ( parent , VAR_2 , VAR_3 , VAR_4 ) ; } @Override public boolean METHOD_3 ( ) { return false ; } } ; return TYPE_10 . build ( this , repo ,... |
simplydefault : return null ; removing line 129 a bit shorter more regular | private TYPE_1 METHOD_1 ( ANNOTATION_1 String value ) { switch ( value ) { case STRING_1 : return TYPE_1 . VAR_1 ; case STRING_2 : return TYPE_1 . VAR_2 ; case STRING_3 : return TYPE_1 . VAR_3 ; case STRING_4 : return TYPE_1 . VAR_4 ; default : <START> break ; <END> } return null ; } | private TYPE_1 METHOD_1 ( ANNOTATION_1 String value ) { switch ( value ) { case STRING_1 : return TYPE_1 . VAR_1 ; case STRING_2 : return TYPE_1 . VAR_2 ; case STRING_3 : return TYPE_1 . VAR_3 ; case STRING_4 : return TYPE_1 . VAR_4 ; default : return null ; } } |
redundant instanceof check | public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } <START> if ( obj == null ) { return false ; } <END> if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return Arrays . equals ( VAR_2 , VAR_1 . VAR_2 ) && VAR_3 == VAR_1 . VAR_3 ; } | public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return Arrays . equals ( VAR_2 , VAR_1 . VAR_2 ) && VAR_3 == VAR_1 . VAR_3 ; } |
answer question : I don t I legitimate reasons compare type - type template arguments thinking example tricky : template < typename T > void foo ( ) ; / / overload template parameter kind s valid template < int I > void foo ( ) ; template < typename T > auto bar ( ) - > decltype ( foo < T > ( ) ) ; / / declaration matc... | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return VAR_1 . METHOD_2 ( ) && VAR_2 . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) ; <END> } | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_2 . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) ; } |
perform operation custom TYPE_3 METHOD_4 ( ) method instead | public TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ; if ( VAR_2 == null && VAR_1 != null ) { TYPE_2 VAR_3 = <START> TYPE_3 . METHOD_4 ( VAR_1 . METHOD_5 ( ) ) ; <END> if ( VAR_3 == null || VAR_3 . METHOD_6 ( ) == null ) { } else { VAR_2 = TYPE_1 . METHOD_7 ( VAR_3 . METHOD_6 ( ) ... | public TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ; if ( VAR_2 == null && VAR_1 != null ) { TYPE_2 VAR_3 = TYPE_3 . METHOD_4 ( VAR_1 ) ; if ( VAR_3 == null || VAR_3 . METHOD_6 ( ) == null ) { } else { VAR_2 = TYPE_1 . METHOD_7 ( VAR_3 . METHOD_6 ( ) ) ; METHOD_2 ( ) . put ( VAR_... |
perform operation custom TYPE_3 METHOD_2 ( ) method instead | public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = <START> TYPE_3 . METHOD_2 ( VAR_2 . METHOD_3 ( ) ) ; <END> if ( VAR_1 == null || VAR_1 . METHOD_4 ( ) == null ) { return null ; } return TYPE_1 . METHOD_5 ( VAR_1 . METHOD_4 ( ) ) ; } | public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( VAR_2 ) ; if ( VAR_1 == null || VAR_1 . METHOD_4 ( ) == null ) { return null ; } return TYPE_1 . METHOD_5 ( VAR_1 . METHOD_4 ( ) ) ; } |
I thought s a TYPE_1 doesn t a row model ? a TYPE_1 ? cast TYPE_1 | public boolean METHOD_1 ( ) { return VAR_1 instanceof TYPE_1 ? ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( ) : <START> true ; <END> } | public boolean METHOD_1 ( ) { return VAR_1 instanceof TYPE_1 ? ( ( TYPE_1 ) VAR_1 ) . METHOD_2 ( ) : true ; } |
method a simple converter dependent frequency dependent clock offset return VAR_1 * clock _CODE_ ( ) VAR_1 clock null | <START> public long METHOD_1 ( long VAR_1 ) { <END> TYPE_1 trace = VAR_2 ; if ( trace != null ) { return trace . VAR_3 ( VAR_1 - trace . VAR_4 ( ) . METHOD_2 ( ) ) + trace . VAR_5 ( ) ; } return 0 ; } | public long METHOD_1 ( long VAR_1 ) { TYPE_1 trace = VAR_2 ; if ( trace != null ) { return trace . VAR_3 ( VAR_1 ) + trace . VAR_5 ( ) ; } return 0 ; } |
other class d invert condition readability | private void METHOD_1 ( TYPE_1 result , TYPE_2 VAR_1 ) { String value = METHOD_2 ( VAR_1 . METHOD_3 ( STRING_1 ) ) ; <START> if ( null == value ) { <END> return ; } else switch ( value ) { case VAR_2 : result . VAR_3 ( TYPE_4 . VAR_5 ) ; break ; case VAR_6 : result . VAR_3 ( TYPE_4 . VAR_7 ) ; break ; default : throw n... | private void METHOD_1 ( TYPE_1 result , TYPE_2 VAR_1 ) { String value = METHOD_2 ( VAR_1 . METHOD_3 ( STRING_1 ) ) ; if ( value == null ) { return ; } else switch ( value ) { case VAR_2 : result . VAR_3 ( TYPE_4 . VAR_5 ) ; break ; case VAR_6 : result . VAR_3 ( TYPE_4 . VAR_7 ) ; break ; default : throw new TYPE_3 ( ST... |
style : tabs spaces inconsistent surrounding code | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = null ; try { <START> try ( TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( VAR_4 ) ) { <END> VAR_2 . write ( new byte [ 1 ] ) ; } } catch ( TYPE_1 e ) { VAR_1 = e ; } assertThat ( VAR_1 , is ( METHOD_3 ( TYPE_1 . class ) ) ) ; assertThat ( VAR_1 . getStatus ( ) . METHOD_4 ( ... | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = null ; try ( TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( VAR_4 ) ) { VAR_2 . write ( new byte [ 1 ] ) ; } catch ( TYPE_1 e ) { VAR_1 = e ; } assertThat ( VAR_1 , is ( METHOD_3 ( TYPE_1 . class ) ) ) ; assertThat ( VAR_1 . getStatus ( ) . METHOD_4 ( ) , is ( TYPE_1 . VAR_... |
move statement | public static synchronized void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 ; if ( VAR_1 != null ) { TYPE_2 . METHOD_2 ( VAR_1 ) ; VAR_1 . VAR_3 . clear ( ) ; } <START> VAR_2 = null ; <END> } | public static synchronized void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 ; if ( VAR_1 != null ) { TYPE_2 . METHOD_2 ( VAR_1 ) ; VAR_1 . VAR_3 . clear ( ) ; VAR_2 = null ; } } |
shouldn t METHOD_3 VAR_3 step | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { TYPE_3 VAR_3 = METHOD_2 ( VAR_2 ) ; if ( VAR_3 == null ) { return ; } VAR_1 . remove ( VAR_3 ) ; <START> VAR_3 . METHOD_3 ( ) ; <END> METHOD_4 ( VAR_2 , VAR_3 ) ; } | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { TYPE_3 VAR_3 = METHOD_2 ( VAR_2 ) ; if ( VAR_3 == null ) { return ; } VAR_1 . remove ( VAR_3 ) ; METHOD_4 ( VAR_2 , VAR_3 ) ; VAR_3 . METHOD_3 ( ) ; } |
sense assertEquals actual failing case | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 ) ; TYPE_1 VAR_3 = METHOD_3 ( VAR_4 ) ; <START> assertTrue ( VAR_3 . METHOD_4 ( ) == 0 ) ; <END> TYPE_2 VAR_5 = VAR_6 . METHOD_5 ( TYPE_3 . class ) ; VAR_4 . METHOD_6 ( ) . add ( VAR_5 ) ; assertTrue ( VAR_3 . METHOD_4 ( ) == 1 ) ; } | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 ) ; TYPE_1 VAR_3 = METHOD_3 ( VAR_4 ) ; assertEquals ( VAR_3 . METHOD_4 ( ) , 0 ) ; TYPE_2 VAR_5 = VAR_6 . METHOD_5 ( TYPE_3 . class ) ; VAR_4 . METHOD_6 ( ) . add ( VAR_5 ) ; assertEquals ( VAR_3 . METHOD_4 ( ) , 1 ) ; } |
pattern egit sources s code duplication I m a big fan implemented constructor constructor chaining call other constructor please | public TYPE_3 ( TYPE_1 repo , TYPE_2 VAR_2 , boolean VAR_3 ) { <START> this . VAR_2 = VAR_2 ; this . repo = repo ; this . VAR_3 = VAR_3 ; this . VAR_4 = true ; <END> } | public TYPE_3 ( TYPE_1 repo , TYPE_2 VAR_2 , boolean VAR_3 ) { this ( repo , VAR_2 , VAR_3 , true ) ; } |
please invert conditional operator rid negation | public void execute ( TYPE_1 monitor ) throws TYPE_2 { TYPE_3 VAR_1 = TYPE_3 . METHOD_1 ( monitor , 2 ) ; VAR_1 . METHOD_2 ( TYPE_4 . bind ( TYPE_7 . TYPE_6 , VAR_4 . METHOD_3 ( ) ) ) ; TYPE_5 VAR_5 = <START> ! VAR_6 ? VAR_4 . METHOD_4 ( ) : METHOD_5 ( ) ; <END> VAR_1 . METHOD_6 ( 1 ) ; METHOD_7 ( VAR_5 ) ; VAR_1 . MET... | public void execute ( TYPE_1 monitor ) throws TYPE_2 { TYPE_3 VAR_1 = TYPE_3 . METHOD_1 ( monitor , 2 ) ; VAR_1 . METHOD_2 ( TYPE_4 . bind ( TYPE_7 . TYPE_6 , VAR_4 . METHOD_3 ( ) ) ) ; TYPE_5 VAR_5 = VAR_6 ? METHOD_5 ( ) : VAR_4 . METHOD_4 ( ) ; VAR_1 . METHOD_6 ( 1 ) ; METHOD_7 ( VAR_5 ) ; VAR_1 . METHOD_6 ( 1 ) ; } |
exception | public int getInt ( String key ) throws TYPE_1 { String VAR_1 = VAR_2 . get ( key ) ; if ( VAR_1 == null ) { throw new TYPE_1 ( STRING_1 + key + STRING_2 ) ; } <START> return Integer . valueOf ( VAR_1 ) . METHOD_1 ( ) ; <END> } | public int getInt ( String key ) throws TYPE_1 { String VAR_1 = VAR_2 . get ( key ) ; if ( VAR_1 == null ) { throw new TYPE_1 ( STRING_1 + key + STRING_2 ) ; } return Integer . parseInt ( VAR_1 ) ; } |
space catch | private static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws InterruptedException , TYPE_3 { try { if ( VAR_1 != null ) { VAR_1 . run ( VAR_2 ) ; } } catch ( TYPE_3 | InterruptedException | TYPE_4 e ) { throw e ; <START> } catch ( TYPE_5 e ) { <END> throw new InterruptedException ( ) ; } catch ( RuntimeException... | private static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws InterruptedException , TYPE_3 { try { if ( VAR_1 != null ) { VAR_1 . run ( VAR_2 ) ; } } catch ( TYPE_3 | InterruptedException e ) { throw e ; } catch ( TYPE_5 e ) { throw new InterruptedException ( ) ; } catch ( TYPE_4 e ) { throw e ; } catch ( Runtim... |
rename exception | public static boolean METHOD_1 ( String VAR_1 ) { if ( VAR_1 . length ( ) == 0 ) { return false ; } TYPE_1 VAR_2 = null ; try { VAR_2 = new TYPE_1 ( VAR_1 ) ; <START> } catch ( TYPE_2 | IOException VAR_3 ) { <END> return false ; } finally { if ( VAR_2 != null ) { try { VAR_2 . close ( ) ; } catch ( IOException e ) { } ... | public static boolean METHOD_1 ( String VAR_1 ) { if ( VAR_1 . length ( ) == 0 ) { return false ; } TYPE_1 VAR_2 = null ; try { VAR_2 = new TYPE_1 ( VAR_1 ) ; } catch ( TYPE_2 | IOException exception ) { return false ; } finally { if ( VAR_2 != null ) { try { VAR_2 . close ( ) ; } catch ( IOException e ) { } } } return... |
{ } blocks | public TYPE_1 create ( TYPE_2 VAR_1 , TYPE_3 element ) { String name = element . getName ( ) ; <START> if ( name == null ) <END> return null ; switch ( name ) { case TYPE_4 . TAG : return new TYPE_4 ( element ) ; case TYPE_5 . TAG : return new TYPE_5 ( element ) ; case TYPE_6 . TAG : return new TYPE_6 ( element ) ; cas... | public TYPE_1 create ( TYPE_2 VAR_1 , TYPE_3 element ) { String name = element . getName ( ) ; if ( name == null ) { return null ; } switch ( name ) { case TYPE_4 . TAG : return new TYPE_4 ( element ) ; case TYPE_5 . TAG : return new TYPE_5 ( element ) ; case TYPE_6 . TAG : return new TYPE_6 ( element ) ; case TYPE_7 .... |
VAR_3 ( ) | private void METHOD_1 ( File VAR_1 , File VAR_2 ) throws IOException { <START> TYPE_1 VAR_3 ; <END> try ( TYPE_2 VAR_4 = new TYPE_2 ( VAR_1 ) ) { VAR_3 = new TYPE_1 ( VAR_2 ) ; byte [ ] buffer = new byte [ INT_1 ] ; int length ; while ( ( length = VAR_4 . read ( buffer ) ) > 0 ) { VAR_3 . write ( buffer , 0 , length ) ... | private void METHOD_1 ( File VAR_1 , File VAR_2 ) throws IOException { try ( TYPE_1 VAR_3 = new TYPE_1 ( VAR_2 ) ; TYPE_2 VAR_4 = new TYPE_2 ( VAR_1 ) ) { byte [ ] buffer = new byte [ INT_1 ] ; int length ; while ( ( length = VAR_4 . read ( buffer ) ) > 0 ) { VAR_3 . write ( buffer , 0 , length ) ; } } } |
default | public static int METHOD_1 ( int VAR_1 ) { switch ( VAR_1 ) { case SWT . VAR_2 : return VAR_2 ; case SWT . VAR_3 : return VAR_3 ; case SWT . VAR_4 : return VAR_4 ; case SWT . VAR_5 : return VAR_5 ; case SWT . VAR_6 : return <START> VAR_6 ; <END> } return VAR_7 ; } | public static int METHOD_1 ( int VAR_1 ) { switch ( VAR_1 ) { case SWT . VAR_2 : return VAR_2 ; case SWT . VAR_3 : return VAR_3 ; case SWT . VAR_4 : return VAR_4 ; case SWT . VAR_5 : return VAR_5 ; case SWT . VAR_6 : return VAR_6 ; default : return VAR_7 ; } } |
necessary ? tree collapse | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( VAR_2 ) ; <END> super . METHOD_1 ( ) ; } | public void METHOD_1 ( ) { VAR_1 . METHOD_1 ( ) ; super . METHOD_1 ( ) ; } |
I reason compiler error created : uninterned types _CODE_ _CODE_ compared = = / ! = operators discussion safe | public boolean equals ( Object obj ) { if ( obj == this ) { return true ; } if ( obj == null ) { return false ; } if ( obj instanceof TYPE_1 ) { TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return <START> METHOD_1 ( this . VAR_2 , <END> VAR_1 . VAR_2 ) ; } return false ; } | public boolean equals ( Object obj ) { if ( obj == this ) { return true ; } if ( obj instanceof TYPE_1 ) { TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return METHOD_1 ( this . VAR_2 , VAR_1 . VAR_2 ) ; } return false ; } |
rename url variable location simply variable url foreach loop | private boolean contains ( TYPE_1 VAR_1 ) { if ( VAR_1 == null ) return false ; TYPE_2 <START> url = <END> VAR_1 . METHOD_1 ( ) ; if ( url == null ) return false ; for ( TYPE_2 VAR_2 : VAR_3 ) { if ( VAR_2 == url ) { return true ; } } return false ; } | private boolean contains ( TYPE_1 VAR_1 ) { if ( VAR_1 == null ) return false ; TYPE_2 location = VAR_1 . METHOD_1 ( ) ; if ( location == null ) return false ; for ( TYPE_2 url : VAR_3 ) { if ( url == location ) { return true ; } } return false ; } |
rename s string | private void METHOD_1 ( TYPE_1 out , String [ ] list ) throws IOException { if ( list == null ) { out . VAR_1 ( 0 ) ; } else { out . VAR_1 ( list . length ) ; for ( String <START> VAR_2 : <END> list ) { METHOD_2 ( VAR_2 , out ) ; } } } | private void METHOD_1 ( TYPE_1 out , String [ ] list ) throws IOException { if ( list == null ) { out . VAR_1 ( 0 ) ; } else { out . VAR_1 ( list . length ) ; for ( String s : list ) { METHOD_2 ( s , out ) ; } } } |
lars cry TYPE_1 21 century ? ( I copy / paste ) | public String toString ( ) { <START> TYPE_1 buffer <END> = new TYPE_1 ( ) ; for ( int i = 0 ; i < this . size ; i ++ ) { buffer . append ( TYPE_2 . toString ( this . VAR_1 [ i ] ) ) . append ( STRING_1 ) ; } return buffer . toString ( ) ; } | public String toString ( ) { StringBuilder buffer = new StringBuilder ( ) ; for ( int i = 0 ; i < this . size ; i ++ ) { buffer . append ( TYPE_2 . toString ( this . VAR_1 [ i ] ) ) . append ( STRING_1 ) ; } return buffer . toString ( ) ; } |
I start selection wrong I problem caret position part bug fix implementation call METHOD_1 ( false ) | public TYPE_1 <START> METHOD_1 ( ) <END> { return METHOD_2 ( new TYPE_2 < TYPE_1 > ( ) { @Override public TYPE_1 run ( ) { VAR_1 . METHOD_3 ( ) ; int offset = VAR_1 . METHOD_4 ( ) . x ; int line = VAR_1 . METHOD_5 ( ) . METHOD_6 ( offset ) ; int VAR_2 = VAR_1 . METHOD_5 ( ) . METHOD_7 ( line ) ; int column = offset - V... | public TYPE_1 METHOD_1 ( ) { return METHOD_1 ( false ) ; } |
rename conf / config | protected static TYPE_1 METHOD_1 ( String name ) throws TYPE_2 { TYPE_3 VAR_1 = TYPE_4 . METHOD_2 ( ) . METHOD_3 ( ) ; TYPE_1 [ ] VAR_2 = VAR_1 . METHOD_4 ( ) ; for ( TYPE_1 <START> VAR_3 : <END> VAR_2 ) { if ( VAR_3 . getName ( ) . equals ( name ) ) { return VAR_3 ; } } return null ; } | protected static TYPE_1 METHOD_1 ( String name ) throws TYPE_2 { TYPE_3 VAR_1 = TYPE_4 . METHOD_2 ( ) . METHOD_3 ( ) ; TYPE_1 [ ] VAR_2 = VAR_1 . METHOD_4 ( ) ; for ( TYPE_1 config : VAR_2 ) { if ( config . getName ( ) . equals ( name ) ) { return config ; } } return null ; } |
I guess || | public TYPE_1 METHOD_1 ( Object element , int VAR_1 ) { String VAR_2 = ( String ) element ; <START> if ( VAR_2 . equals ( STRING_1 ) | VAR_2 . equals ( STRING_2 ) ) { <END> return TYPE_2 . METHOD_2 ( ) . METHOD_3 ( SWT . VAR_3 ) ; } return null ; } | public TYPE_1 METHOD_1 ( Object element , int VAR_1 ) { String VAR_2 = ( String ) element ; if ( VAR_2 . equals ( STRING_1 ) || VAR_2 . equals ( STRING_2 ) ) { return TYPE_2 . METHOD_2 ( ) . METHOD_3 ( SWT . VAR_3 ) ; } return null ; } |
remove | public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; <START> VAR_1 . METHOD_3 ( ) . METHOD_4 ( this ) ; <END> VAR_1 . METHOD_3 ( ) . METHOD_5 ( this ) ; VAR_1 . METHOD_3 ( ) . METHOD_6 ( this ) ; VAR_2 . METHOD_7 ( VAR_1 . METHOD_3 ( ) ) ; } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; VAR_1 . METHOD_3 ( ) . METHOD_5 ( this ) ; VAR_1 . METHOD_3 ( ) . METHOD_6 ( this ) ; VAR_2 . METHOD_7 ( VAR_1 . METHOD_3 ( ) ) ; } |
remove | public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( ( VAR_1 != null ) && ! VAR_1 . METHOD_3 ( ) ) { <START> VAR_1 . METHOD_4 ( ) . METHOD_5 ( this ) ; <END> VAR_1 . METHOD_4 ( ) . METHOD_6 ( this ) ; VAR_1 . METHOD_4 ( ) . METHOD_7 ( this ) ; VAR_2 . METHOD_8 ( VAR_1 . METHOD_4 ( ) ) ; } } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( ( VAR_1 != null ) && ! VAR_1 . METHOD_3 ( ) ) { VAR_1 . METHOD_4 ( ) . METHOD_6 ( this ) ; VAR_1 . METHOD_4 ( ) . METHOD_7 ( this ) ; VAR_2 . METHOD_8 ( VAR_1 . METHOD_4 ( ) ) ; } } |
case null return empty array | public TYPE_1 [ ] METHOD_1 ( ) { if ( ! METHOD_2 ( ) ) { TYPE_2 VAR_1 = METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; <START> return VAR_1 instanceof TYPE_3 ? ( ( TYPE_3 ) VAR_1 ) . METHOD_1 ( ) <END> : new TYPE_1 [ ] { new TYPE_4 ( VAR_1 ) } ; } return super . METHOD_1 ( ) ; } | public TYPE_1 [ ] METHOD_1 ( ) { if ( ! METHOD_2 ( ) ) { TYPE_2 VAR_1 = METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; return VAR_1 != null ? VAR_1 instanceof TYPE_3 ? ( ( TYPE_3 ) VAR_1 ) . METHOD_1 ( ) : new TYPE_1 [ ] { new TYPE_4 ( VAR_1 ) } : new TYPE_1 [ ] { } ; } return super . METHOD_1 ( ) ; } |
lines 82 86 collapse : String VAR_4 = VAR_2 + VAR_1 METHOD_3 ( ) ; | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { String VAR_2 = METHOD_2 ( ) ; <START> StringBuilder builder = new StringBuilder ( VAR_2 ) ; <END> String VAR_3 = VAR_1 . METHOD_3 ( ) ; builder . append ( VAR_3 ) ; String VAR_4 = builder . toString ( ) ; if ( VAR_4 . contains ( STRING_1 ) ) { VAR_4 = VAR_4 . METHOD_4 ( STRING... | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { String VAR_2 = METHOD_2 ( ) ; String VAR_3 = VAR_1 . METHOD_3 ( ) ; String VAR_4 = VAR_2 + VAR_3 ; if ( VAR_4 . contains ( STRING_1 ) ) { VAR_4 = VAR_4 . METHOD_4 ( STRING_2 , STRING_3 ) ; VAR_4 = VAR_4 . METHOD_5 ( STRING_4 , "" ) ; } File file = new File ( VAR_4 ) ; return f... |
proposed change : METHOD_4 ( VAR_1 = = null ) | public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( ) ; if ( ( VAR_2 & SWT . VAR_3 ) != 0 ) return ; if ( VAR_1 != null && VAR_1 . METHOD_3 ( ) ) error ( SWT . VAR_4 ) ; this . VAR_1 = VAR_1 ; <START> METHOD_4 ( false ) ; <END> OS . TYPE_2 ( VAR_6 , null , true ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( ) ; if ( ( VAR_2 & SWT . VAR_3 ) != 0 ) return ; if ( VAR_1 != null && VAR_1 . METHOD_3 ( ) ) error ( SWT . VAR_4 ) ; this . VAR_1 = VAR_1 ; METHOD_4 ( VAR_1 == null ) ; OS . TYPE_2 ( VAR_6 , null , true ) ; } |
builders want external code create new entries content constructor private protected | <START> public TYPE_1 ( long id , long VAR_2 , String name , long start , long VAR_3 , int VAR_4 ) { <END> super ( id , VAR_2 , name , start , VAR_3 , true ) ; VAR_5 = VAR_4 ; } | protected TYPE_1 ( long id , long VAR_2 , String name , long start , long VAR_3 , int VAR_4 ) { super ( id , VAR_2 , name , start , VAR_3 , true ) ; VAR_5 = VAR_4 ; } |
a method reference | public void METHOD_1 ( final boolean VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_2 = VAR_1 ; if ( VAR_1 ) { <START> METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ( ) - > METHOD_6 ( ) ) ; <END> } else { METHOD_7 ( ) . METHOD_8 ( null ) ; } } | public void METHOD_1 ( final boolean VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_2 = VAR_1 ; if ( VAR_1 ) { METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( this : : METHOD_6 ) ; } else { METHOD_7 ( ) . METHOD_8 ( null ) ; } } |
I don t need TYPE_3 injected _CODE_ | public void METHOD_1 ( ) throws Exception { TYPE_1 context = TYPE_2 . METHOD_2 ( ) ; <START> VAR_1 = context . get ( TYPE_3 . class ) ; <END> VAR_2 = VAR_1 . METHOD_3 ( TYPE_4 . class ) ; VAR_2 . METHOD_4 ( VAR_3 ) ; VAR_2 . METHOD_5 ( ) . add ( STRING_1 ) ; } | public void METHOD_1 ( ) throws Exception { VAR_2 = VAR_1 . METHOD_3 ( TYPE_4 . class ) ; VAR_2 . METHOD_4 ( VAR_3 ) ; VAR_2 . METHOD_5 ( ) . add ( STRING_1 ) ; } |
extra parentheses | private String METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 instanceof TYPE_2 ) { return ( ( TYPE_2 ) VAR_1 ) . METHOD_1 ( ) ; } TYPE_3 VAR_2 = <START> TYPE_4 . METHOD_2 ( ( VAR_1 ) , <END> TYPE_3 . class ) ; if ( VAR_2 instanceof TYPE_5 ) { return ( ( TYPE_5 ) VAR_2 ) . getPath ( ) ; } return null ; } | private String METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 instanceof TYPE_2 ) { return ( ( TYPE_2 ) VAR_1 ) . METHOD_1 ( ) ; } TYPE_3 VAR_2 = TYPE_4 . METHOD_2 ( VAR_1 , TYPE_3 . class ) ; if ( VAR_2 instanceof TYPE_5 ) { return ( ( TYPE_5 ) VAR_2 ) . getPath ( ) ; } return null ; } |
method static | <START> private boolean METHOD_1 ( TYPE_1 a , TYPE_1 b ) { <END> return a == b ; } | private static boolean METHOD_1 ( TYPE_1 a , TYPE_1 b ) { return a == b ; } |
add contructor ? List VAR_2 = new ArrayList ( Arrays asList ( VAR_5 METHOD_2 ( VAR_1 ) ) ) ; | private void METHOD_1 ( Object VAR_1 ) { List VAR_2 = new ArrayList ( ) ; <START> VAR_3 . VAR_4 . Collections . addAll ( VAR_2 , VAR_5 . METHOD_2 ( VAR_1 ) ) ; <END> VAR_6 . put ( VAR_1 , VAR_2 ) ; } | private void METHOD_1 ( Object VAR_1 ) { List VAR_2 = new ArrayList ( Arrays . asList ( VAR_5 . METHOD_2 ( VAR_1 ) ) ) ; VAR_6 . put ( VAR_1 , VAR_2 ) ; } |
bug | public TYPE_3 ( TYPE_1 element ) throws TYPE_2 { String VAR_2 = element . VAR_3 ( VAR_4 ) ; METHOD_1 ( VAR_2 . isEmpty ( ) ? <START> VAR_2 : <END> null ) ; String VAR_5 = element . VAR_3 ( VAR_6 ) ; METHOD_2 ( VAR_5 . isEmpty ( ) ? null : VAR_5 ) ; } | public TYPE_3 ( TYPE_1 element ) throws TYPE_2 { String VAR_2 = element . VAR_3 ( VAR_4 ) ; METHOD_1 ( VAR_2 . isEmpty ( ) ? null : VAR_2 ) ; String VAR_5 = element . VAR_3 ( VAR_6 ) ; METHOD_2 ( VAR_5 . isEmpty ( ) ? null : VAR_5 ) ; } |
setting true initially won t effect codan builder added property changes _CODE_ I m impose a big change behavior | public void METHOD_1 ( ) { TYPE_1 node = TYPE_4 . TYPE_5 . METHOD_2 ( TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ) ; <START> node . VAR_1 ( TYPE_6 . VAR_3 , true ) ; <END> node . VAR_1 ( TYPE_6 . VAR_4 , true ) ; node . VAR_1 ( TYPE_6 . VAR_5 , true ) ; } | public void METHOD_1 ( ) { TYPE_1 node = TYPE_4 . TYPE_5 . METHOD_2 ( TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ) ; node . VAR_1 ( TYPE_6 . VAR_3 , false ) ; node . VAR_1 ( TYPE_6 . VAR_4 , true ) ; node . VAR_1 ( TYPE_6 . VAR_5 , true ) ; } |
change neededit create 2 lists array - - list conversion needed | protected void METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 ) { if ( VAR_1 instanceof TYPE_2 ) { TYPE_2 VAR_3 = ( TYPE_2 ) VAR_1 ; <START> METHOD_1 ( new ArrayList < Object > ( Arrays . asList ( VAR_3 . METHOD_2 ( ) ) ) , VAR_2 ) ; <END> } else { super . METHOD_1 ( VAR_1 , VAR_2 ) ; } } | protected void METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 ) { if ( VAR_1 instanceof TYPE_2 ) { TYPE_2 VAR_3 = ( TYPE_2 ) VAR_1 ; METHOD_1 ( Arrays . asList ( VAR_3 . METHOD_2 ( ) ) , VAR_2 ) ; } else { super . METHOD_1 ( VAR_1 , VAR_2 ) ; } } |
10 threads I reproduce bug | public void METHOD_1 ( ) throws Exception { int VAR_1 = INT_1 ; int VAR_2 = <START> 2 ; <END> for ( int i = 0 ; i < VAR_1 ; ++ i ) { METHOD_2 ( VAR_2 ) ; } } | public void METHOD_1 ( ) throws Exception { int VAR_1 = INT_1 ; int VAR_2 = 10 ; for ( int i = 0 ; i < VAR_1 ; ++ i ) { METHOD_2 ( VAR_2 ) ; } } |
rename field | private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; <START> for ( TYPE_2 VAR_3 : VAR_4 ) { <END> VAR_1 . METHOD_3 ( ) . add ( VAR_2 . METHOD_4 ( VAR_3 . getName ( ) ) ) ; } VAR_1 . METHOD_5 ( METHOD_6 ( VAR_5 ) ) ; VAR_1 . METHOD_7 ( VAR_2 . METHOD_4 ( VAR_6 ) ) ; return VAR_1 ; } | private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; for ( TYPE_2 field : VAR_4 ) { VAR_1 . METHOD_3 ( ) . add ( VAR_2 . METHOD_4 ( field . getName ( ) ) ) ; } VAR_1 . METHOD_5 ( METHOD_6 ( VAR_5 ) ) ; VAR_1 . METHOD_7 ( VAR_2 . METHOD_4 ( VAR_6 ) ) ; return VAR_1 ; } |
rename f | private void METHOD_1 ( File file ) { if ( file . VAR_1 ( ) ) { for ( File <START> VAR_2 : <END> file . VAR_3 ( ) ) { METHOD_1 ( VAR_2 ) ; } } file . VAR_4 ( ) ; } | private void METHOD_1 ( File file ) { if ( file . VAR_1 ( ) ) { for ( File f : file . VAR_3 ( ) ) { METHOD_1 ( f ) ; } } file . VAR_4 ( ) ; } |
rename type | private TYPE_1 METHOD_1 ( TYPE_2 [ ] VAR_1 , TYPE_3 [ ] VAR_2 ) throws TYPE_4 { TYPE_1 result = new TYPE_1 ( ) ; TYPE_2 [ ] VAR_3 = METHOD_2 ( VAR_1 ) ; for ( TYPE_3 <START> t : <END> VAR_2 ) { result . VAR_4 ( TYPE_5 . METHOD_3 ( VAR_3 , t ) ) ; } return result ; } | private TYPE_1 METHOD_1 ( TYPE_2 [ ] VAR_1 , TYPE_3 [ ] VAR_2 ) throws TYPE_4 { TYPE_1 result = new TYPE_1 ( ) ; TYPE_2 [ ] VAR_3 = METHOD_2 ( VAR_1 ) ; for ( TYPE_3 type : VAR_2 ) { result . VAR_4 ( TYPE_5 . METHOD_3 ( VAR_3 , type ) ) ; } return result ; } |
rename res | private static void METHOD_1 ( TYPE_1 resource , List < TYPE_1 > VAR_1 ) throws TYPE_2 { if ( resource instanceof TYPE_3 ) { VAR_1 . add ( resource ) ; return ; } if ( resource instanceof TYPE_4 ) { for ( TYPE_1 <START> VAR_2 : <END> ( ( TYPE_4 ) resource ) . METHOD_2 ( ) ) { METHOD_1 ( VAR_2 , VAR_1 ) ; } } } | private static void METHOD_1 ( TYPE_1 resource , List < TYPE_1 > VAR_1 ) throws TYPE_2 { if ( resource instanceof TYPE_3 ) { VAR_1 . add ( resource ) ; return ; } if ( resource instanceof TYPE_4 ) { for ( TYPE_1 res : ( ( TYPE_4 ) resource ) . METHOD_2 ( ) ) { METHOD_1 ( res , VAR_1 ) ; } } } |
String valueOf ( VAR_5 ) equivalent _CODE_ remove a warning | private static String METHOD_1 ( String VAR_1 , String VAR_2 , Boolean VAR_3 ) { String VAR_4 = STRING_1 ; TYPE_1 VAR_5 = new TYPE_1 ( VAR_4 , VAR_4 , VAR_4 ) ; VAR_5 . add ( VAR_1 ) ; String VAR_6 = VAR_3 ? STRING_2 : STRING_3 ; VAR_5 . add ( VAR_6 ) ; VAR_5 . add ( VAR_2 ) ; <START> return VAR_5 . toString ( ) ; <END... | private static String METHOD_1 ( String VAR_1 , String VAR_2 , Boolean VAR_3 ) { String VAR_4 = STRING_1 ; TYPE_1 VAR_5 = new TYPE_1 ( VAR_4 , VAR_4 , VAR_4 ) ; VAR_5 . add ( VAR_1 ) ; String VAR_6 = VAR_3 ? STRING_2 : STRING_3 ; VAR_5 . add ( VAR_6 ) ; VAR_5 . add ( VAR_2 ) ; return String . valueOf ( VAR_5 ) ; } |
instead casting t omit L | public int METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 , TYPE_3 , IOException { int VAR_2 = 0 ; for ( int index = 0 ; index < VAR_3 . length ; index ++ ) { TYPE_4 filter = VAR_3 [ index ] ; if ( filter != null ) { try { boolean VAR_4 = filter . VAR_5 ( VAR_1 ) ; if ( VAR_4 ) <START> VAR_2 |= ( int ) ( INT_1 < < index ) ; <... | public int METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 , TYPE_3 , IOException { int VAR_2 = 0 ; for ( int index = 0 ; index < VAR_3 . length ; index ++ ) { TYPE_4 filter = VAR_3 [ index ] ; if ( filter != null ) { try { boolean VAR_4 = filter . VAR_5 ( VAR_1 ) ; if ( VAR_4 ) VAR_2 |= ( 1 < < index ) ; } catch ( TYPE_5 e ) ... |
called UI I replace threadlocal a simple boolean | public boolean METHOD_1 ( Object element , TYPE_1 context ) { <START> if ( VAR_1 . get ( ) ) { <END> return METHOD_2 ( element , context ) != null ; } return false ; } | public boolean METHOD_1 ( Object element , TYPE_1 context ) { if ( VAR_1 ) { return METHOD_2 ( element , context ) != null ; } return false ; } |
method ref | public void METHOD_1 ( long id , File VAR_1 ) throws TYPE_1 { final File file = VAR_1 ; if ( file == null ) { throw new TYPE_1 ( STRING_1 ) ; } <START> TYPE_2 stream = VAR_2 . METHOD_2 ( id , VAR_3 - > new TYPE_3 ( this ) ) ; <END> if ( stream instanceof TYPE_3 ) { TYPE_3 VAR_4 = ( TYPE_3 ) stream ; VAR_4 . METHOD_3 ( ... | public void METHOD_1 ( long id , File VAR_1 ) throws TYPE_1 { final File file = VAR_1 ; if ( file == null ) { throw new TYPE_1 ( STRING_1 ) ; } TYPE_2 stream = VAR_2 . METHOD_2 ( id , VAR_4 - > new TYPE_3 ( this ) ) ; if ( stream instanceof TYPE_3 ) { TYPE_3 VAR_4 = ( TYPE_3 ) stream ; VAR_4 . METHOD_3 ( new TYPE_4 ( s... |
I suggest invoke ( VAR_2 wight 1 VAR_4 parent ) | public TYPE_3 ( String name , String VAR_2 , int VAR_3 , int VAR_4 , TYPE_1 parent ) { <START> METHOD_1 ( name , VAR_2 ) ; <END> VAR_5 = VAR_3 ; METHOD_2 ( VAR_4 ) ; VAR_6 = false ; VAR_7 = TYPE_2 . getString ( STRING_1 ) ; METHOD_3 ( parent ) ; } | public TYPE_3 ( String name , String VAR_2 , int VAR_3 , int VAR_4 , TYPE_1 parent ) { this ( name , VAR_2 , VAR_3 , 1 , VAR_4 , parent ) ; } |
andrey s question clock sync NFS machine java code runs relevant | public static void METHOD_1 ( Path f ) throws IOException { try ( TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( f , TYPE_5 . VAR_3 , TYPE_5 . VAR_4 , TYPE_5 . VAR_5 ) ) { TYPE_2 . METHOD_3 ( f , <START> TYPE_3 . from ( TYPE_4 . METHOD_4 ( ) ) ) ; <END> } } | public static void METHOD_1 ( Path f ) throws IOException { try ( TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( f , TYPE_5 . VAR_3 , TYPE_5 . VAR_4 , TYPE_5 . VAR_5 ) ) { } TYPE_2 . METHOD_3 ( f , TYPE_3 . from ( TYPE_4 . METHOD_4 ( ) ) ) ; } |
remove line : ) | protected void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( VAR_2 ) ; <START> VAR_1 . METHOD_2 ( VAR_2 ) ; <END> } } | protected void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( VAR_2 ) ; } } |
question : limitation TYPE_5 wanted nad / necessary ? a user other types projects open e g part a research prototype | private static List < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; if ( VAR_1 instanceof TYPE_3 ) { for ( Object element : ( ( TYPE_4 ) VAR_1 ) . METHOD_2 ( ) ) { if <START> ( element instanceof TYPE_5 ) { <END> VAR_2 . add ( ( ( TYPE_5 ) element ) . METHOD_3 ( ) ) ; } } } return... | private static List < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; if ( VAR_1 instanceof TYPE_3 ) { for ( Object element : ( ( TYPE_4 ) VAR_1 ) . METHOD_2 ( ) ) { if ( element instanceof TYPE_5 ) { VAR_2 . add ( ( ( TYPE_5 ) element ) . METHOD_3 ( ) ) ; } else if ( element instan... |
legal : collections VAR_4 returns a - modifiable empty map ( empty map ) invoking put fail maps a single element Collections _CODE_ ( ) return a - modifiable map note highlighting trap java language API | public static boolean METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) { Map < String , Object > VAR_3 = Collections . VAR_4 ( ) ; <START> VAR_3 . put ( VAR_5 , VAR_1 ) ; <END> return METHOD_2 ( VAR_6 , VAR_2 , VAR_3 ) ; } | public static boolean METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) { Map < String , Object > VAR_3 = new HashMap < > ( ) ; VAR_3 . put ( VAR_5 , VAR_1 ) ; return METHOD_2 ( VAR_6 , VAR_2 , VAR_3 ) ; } |
active properties | public int METHOD_1 ( ) { <START> return TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; <END> } | public int METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 , VAR_3 , getValue ( ) ) ; } |
enclosed ( VAR_2 ) method | private boolean METHOD_1 ( Object VAR_1 ) { boolean VAR_2 = VAR_1 != VAR_3 && ! VAR_1 . equals ( VAR_4 ) ; <START> LOG . debug ( STRING_1 , file , VAR_4 , VAR_1 ) ; <END> return VAR_2 ; } | private boolean METHOD_1 ( Object VAR_1 ) { boolean VAR_2 = VAR_1 != VAR_3 && ! VAR_1 . equals ( VAR_4 ) ; if ( VAR_2 ) { LOG . debug ( STRING_1 , file , VAR_4 , VAR_1 ) ; } return VAR_2 ; } |
happen ? check null stop | private void start ( ) { <START> if ( ! VAR_1 . METHOD_1 ( ) ) { <END> if ( VAR_1 instanceof TYPE_1 ) { ( ( TYPE_1 ) VAR_1 ) . METHOD_2 ( this ) ; } else if ( VAR_1 instanceof TYPE_2 ) { ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( this ) ; } } } | private void start ( ) { if ( VAR_1 != null && ! VAR_1 . METHOD_1 ( ) ) { if ( VAR_1 instanceof TYPE_1 ) { ( ( TYPE_1 ) VAR_1 ) . METHOD_2 ( this ) ; } else if ( VAR_1 instanceof TYPE_2 ) { ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( this ) ; } } } |
I suggest reset VAR_3 null | public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( ) ; VAR_1 = null ; } for ( TYPE_1 VAR_2 : VAR_3 ) { VAR_2 . METHOD_1 ( ) ; <START> } <END> super . METHOD_1 ( ) ; } | public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( ) ; VAR_1 = null ; } for ( TYPE_1 VAR_2 : VAR_3 ) { VAR_2 . METHOD_1 ( ) ; } VAR_3 = null ; super . METHOD_1 ( ) ; } |
necessary | private void METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { VAR_2 . METHOD_2 ( false ) ; VAR_2 . METHOD_3 ( false ) ; VAR_3 . METHOD_4 ( ) . METHOD_5 ( true ) ; } else { boolean VAR_4 = VAR_5 . METHOD_6 ( VAR_1 ) ; VAR_2 . METHOD_2 ( VAR_4 ) ; VAR_2 . METHOD_3 ( true ) ; VAR_3 . METHOD_4 ( ) . METHOD_5 ( ! VAR_4 ) ... | private void METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { VAR_2 . METHOD_2 ( false ) ; VAR_2 . METHOD_3 ( false ) ; VAR_3 . METHOD_4 ( ) . METHOD_5 ( true ) ; } else { boolean VAR_4 = VAR_5 . METHOD_6 ( VAR_1 ) ; VAR_2 . METHOD_2 ( VAR_4 ) ; VAR_2 . METHOD_3 ( true ) ; VAR_3 . METHOD_4 ( ) . METHOD_5 ( ! VAR_4 ) ... |
constructor action class | private void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( ) ; <START> VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 ) ; VAR_1 . METHOD_3 ( TYPE_4 . TYPE_3 ) ; <END> VAR_6 . add ( VAR_1 ) ; } | private void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( ) ; VAR_6 . add ( VAR_1 ) ; } |
reason calling super ? I thought calling super METHOD_1 a common practice ( some other code METHOD_1 method requires some fields disposed a call ) | public void METHOD_1 ( ) { <START> super . METHOD_1 ( ) ; <END> for ( TYPE_1 action : this . VAR_1 ) { action . VAR_2 ( listener ) ; } } | public void METHOD_1 ( ) { for ( TYPE_1 action : this . VAR_1 ) { action . VAR_2 ( listener ) ; } super . METHOD_1 ( ) ; } |
foreach | public static Set < String > METHOD_1 ( List < TYPE_1 > VAR_1 , TYPE_2 VAR_2 ) { Set < String > VAR_3 = new HashSet < > ( ) ; for ( int i = 0 ; i < <START> VAR_1 . size ( ) ; <END> i ++ ) { TYPE_1 VAR_4 = VAR_1 . get ( i ) ; if ( VAR_4 == VAR_2 ) { return VAR_3 ; } VAR_3 . add ( CHAR_1 + VAR_4 . getName ( ) . METHOD_2 ... | public static Set < String > METHOD_1 ( List < TYPE_1 > VAR_1 , TYPE_2 VAR_2 ) { Set < String > VAR_3 = new HashSet < > ( ) ; for ( TYPE_1 VAR_4 : VAR_1 ) { if ( VAR_4 == VAR_2 ) { return VAR_3 ; } VAR_3 . add ( CHAR_1 + VAR_4 . getName ( ) . METHOD_2 ( ) + CHAR_2 ) ; } return VAR_3 ; } |
unused | public void METHOD_1 ( ) throws IOException { <START> TYPE_1 id = <END> db . VAR_1 ( STRING_1 ) ; TYPE_2 r = db . VAR_2 ( STRING_1 , STRING_2 ) ; assertEquals ( VAR_3 , r . VAR_4 ( ) ) ; } | public void METHOD_1 ( ) throws IOException { db . VAR_1 ( STRING_1 ) ; TYPE_2 r = db . VAR_2 ( STRING_1 , STRING_2 ) ; assertEquals ( VAR_3 , r . VAR_4 ( ) ) ; } |
remove unthrown exception | private static TYPE_1 METHOD_1 ( byte [ ] ... <START> table ) throws IOException { <END> List < TYPE_2 > VAR_1 = new ArrayList < > ( table . length ) ; for ( byte [ ] b : table ) { VAR_1 . add ( read ( b ) ) ; } return new TYPE_1 ( VAR_1 ) ; } | private static TYPE_1 METHOD_1 ( byte [ ] ... table ) { List < TYPE_2 > VAR_1 = new ArrayList < > ( table . length ) ; for ( byte [ ] b : table ) { VAR_1 . add ( read ( b ) ) ; } return new TYPE_1 ( VAR_1 ) ; } |
change necessary ? breaking s functionality | protected void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) . METHOD_3 ( TYPE_1 . class ) ; <START> TYPE_2 page = new TYPE_2 ( VAR_1 ) ; METHOD_4 ( page ) ; <END> } | protected void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) . METHOD_3 ( TYPE_1 . class ) ; METHOD_4 ( new TYPE_2 ( VAR_1 ) ) ; } |
itthis ( resource ) ; VAR_4 METHOD_3 ( VAR_2 ) ; improve factorization | public TYPE_6 ( TYPE_1 resource , String VAR_2 ) { <START> super ( new TYPE_2 ( new TYPE_3 ( resource ) ) , VAR_3 ) ; <END> TYPE_3 VAR_4 = ( TYPE_3 ) ( ( TYPE_2 ) super . METHOD_1 ( ) ) . METHOD_2 ( ) ; VAR_4 . METHOD_3 ( VAR_2 ) ; METHOD_4 ( TYPE_7 . TYPE_5 ) ; METHOD_5 ( TYPE_7 . TYPE_4 ) ; } | public TYPE_6 ( TYPE_1 resource , String VAR_2 ) { this ( resource ) ; TYPE_3 VAR_4 = ( TYPE_3 ) ( ( TYPE_2 ) super . METHOD_1 ( ) ) . METHOD_2 ( ) ; VAR_4 . METHOD_3 ( VAR_2 ) ; METHOD_4 ( TYPE_7 . TYPE_5 ) ; METHOD_5 ( TYPE_7 . TYPE_4 ) ; } |
don t need repeat lines 67 69 70 invoked ( resource ) : ( ) invokes other constructor need repeat s content | public TYPE_6 ( TYPE_1 resource , String VAR_2 ) { this ( resource ) ; TYPE_2 VAR_3 = ( TYPE_2 ) ( ( TYPE_3 ) super . METHOD_1 ( ) ) . METHOD_2 ( ) ; VAR_3 . METHOD_3 ( VAR_2 ) ; METHOD_4 ( TYPE_7 . TYPE_5 ) ; <START> METHOD_5 ( TYPE_7 . TYPE_4 ) ; <END> } | public TYPE_6 ( TYPE_1 resource , String VAR_2 ) { this ( resource ) ; TYPE_2 VAR_3 = ( TYPE_2 ) ( ( TYPE_3 ) super . METHOD_1 ( ) ) . METHOD_2 ( ) ; VAR_3 . METHOD_3 ( VAR_2 ) ; } |
instead calling 2 setters invoking _CODE_ care fixing button enablement | public void METHOD_1 ( String VAR_1 ) { this . VAR_2 . METHOD_2 ( VAR_1 ) ; super . METHOD_3 ( true ) ; <START> super . METHOD_4 ( true ) ; <END> } | public void METHOD_1 ( String VAR_1 ) { this . VAR_2 . METHOD_2 ( VAR_1 ) ; } |
please don t System production code ; ) | public void METHOD_1 ( String VAR_1 ) { this . VAR_2 . METHOD_2 ( VAR_1 ) ; super . METHOD_3 ( true ) ; super . METHOD_4 ( true ) ; <START> System . out . println ( STRING_1 ) ; <END> } | public void METHOD_1 ( String VAR_1 ) { this . VAR_2 . METHOD_2 ( VAR_1 ) ; super . METHOD_3 ( true ) ; super . METHOD_4 ( true ) ; } |
static added doesn t rely instance class | <START> private <END> TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_1 VAR_2 = VAR_1 ; while ( VAR_2 instanceof TYPE_2 ) { VAR_2 = ( ( TYPE_2 ) VAR_2 ) . METHOD_2 ( ) ; } return VAR_2 ; } | private static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_1 VAR_2 = VAR_1 ; while ( VAR_2 instanceof TYPE_2 ) { VAR_2 = ( ( TYPE_2 ) VAR_2 ) . METHOD_2 ( ) ; } return VAR_2 ; } |
don t want TYPE_9 TYPE_8 want able select version | public boolean METHOD_1 ( ) { <START> try { <END> if ( TYPE_1 . METHOD_2 ( ( TYPE_2 ) METHOD_3 ( ) , TYPE_6 . TYPE_8 , TYPE_7 . TYPE_9 , METHOD_4 ( ) ) ) { METHOD_5 ( ) ; METHOD_6 ( ) ; return true ; } return false ; } catch ( Exception ex ) { TYPE_3 . log ( TYPE_4 . class , TYPE_5 . VAR_6 , ex ) ; } return false ; } | public boolean METHOD_1 ( ) { try { if ( TYPE_1 . METHOD_2 ( ( TYPE_2 ) METHOD_3 ( ) , METHOD_4 ( ) ) ) { METHOD_5 ( ) ; METHOD_6 ( ) ; return true ; } return false ; } catch ( Exception ex ) { TYPE_3 . log ( TYPE_4 . class , TYPE_5 . VAR_6 , ex ) ; } return false ; } |
missing type parameter causing warnings : TYPE_2 Builder < TYPE_1 > builder = new TYPE_2 Builder < > ( VAR_2 size ( ) ) ; | public Map < String , TYPE_1 > METHOD_1 ( String VAR_1 ) throws IOException { List < TYPE_1 > VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; <START> TYPE_2 . Builder builder = new TYPE_2 . Builder ( VAR_2 . size ( ) ) ; <END> for ( TYPE_1 r : VAR_2 ) { builder . add ( r ) ; } return new TYPE_3 ( VAR_1 , builder . VAR_4 ( ) , TYP... | public Map < String , TYPE_1 > METHOD_1 ( String VAR_1 ) throws IOException { List < TYPE_1 > VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; TYPE_2 . Builder < TYPE_1 > builder = new TYPE_2 . Builder < > ( VAR_2 . size ( ) ) ; for ( TYPE_1 r : VAR_2 ) { builder . add ( r ) ; } return new TYPE_3 ( VAR_1 , builder . VAR_4 ( ) , TY... |
hm need a bit more exception handling report config invalid case VAR_1 null I TYPE_3 s message include file | private void METHOD_1 ( boolean value ) { TYPE_1 VAR_1 = null ; try { VAR_1 = TYPE_2 . getInstance ( ) . METHOD_2 ( ) ; METHOD_3 ( VAR_1 , value ) ; } catch ( IOException | TYPE_3 e ) { LOG . error ( TYPE_4 . format ( TYPE_5 . get ( ) . VAR_2 , <START> VAR_1 , e ) ) ; <END> } } | private void METHOD_1 ( boolean value ) { TYPE_1 VAR_1 = null ; try { VAR_1 = TYPE_2 . getInstance ( ) . METHOD_2 ( ) ; METHOD_3 ( VAR_1 , value ) ; } catch ( IOException | TYPE_3 e ) { LOG . error ( e . getMessage ( ) , e ) ; } } |
METHOD_2 ( ) needed anymore need catch RuntimeException | public TYPE_8 ( TYPE_1 uri ) { TYPE_2 VAR_2 = TYPE_3 . getInstance ( ) . METHOD_1 ( ) ; try { <START> VAR_2 . METHOD_2 ( ) ; <END> } catch ( IOException | TYPE_4 e ) { LOG . error ( TYPE_5 . format ( TYPE_6 . get ( ) . VAR_3 , VAR_2 , e ) ) ; METHOD_3 ( new TYPE_7 ( ) , uri ) ; return ; } METHOD_3 ( VAR_2 , uri ) ; } | public TYPE_8 ( TYPE_1 uri ) { TYPE_2 VAR_2 = null ; try { VAR_2 = TYPE_3 . getInstance ( ) . METHOD_1 ( ) ; } catch ( IOException | TYPE_4 e ) { LOG . error ( TYPE_5 . format ( TYPE_6 . get ( ) . VAR_3 , VAR_2 , e ) ) ; METHOD_3 ( new TYPE_7 ( ) , uri ) ; return ; } METHOD_3 ( VAR_2 , uri ) ; } |
I _CODE_ server cache instance static instances a interval cache instance _CODE_ instance new simpler methods _CODE_ ( ) _CODE_ ( ) _CODE_ separate class | <START> public static TYPE_1 getInstance ( ) { <END> return TYPE_2 . get ( ) ; } | public static TYPE_1 getInstance ( ) { return TYPE_2 ; } |
propagate IOE TYPE_2 instead translating RuntimeException ? I m happy translation - - unclear effects propagate checked exceptions caller callers catch IOE TYPE_2 METHOD_3 ( ) | <START> public TYPE_1 METHOD_1 ( ) { <END> if ( VAR_1 . METHOD_2 ( ) ) { try { LOG . debug ( STRING_1 , VAR_1 ) ; VAR_1 . METHOD_3 ( ) ; } catch ( IOException e ) { throw new RuntimeException ( e ) ; } catch ( TYPE_2 e ) { throw new RuntimeException ( TYPE_3 . format ( TYPE_4 . get ( ) . VAR_2 , VAR_1 . METHOD_4 ( ) . ... | public TYPE_1 METHOD_1 ( ) throws IOException , TYPE_2 { if ( VAR_1 . METHOD_2 ( ) ) { try { LOG . debug ( STRING_1 , VAR_1 ) ; VAR_1 . METHOD_3 ( ) ; } catch ( TYPE_2 e ) { LOG . error ( TYPE_3 . format ( TYPE_4 . get ( ) . VAR_2 , VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ) , e ) ; throw e ; } } return VAR_1 ; } |
true thoughtless inlining | private void add ( String ... VAR_1 ) { if ( VAR_1 != null ) { for ( String VAR_2 : VAR_1 ) { if ( VAR_2 == null || VAR_2 . isEmpty ( ) ) { <START> return ; <END> } TYPE_1 node = VAR_3 ; for ( char c : VAR_2 . METHOD_1 ( ) ) { node = node . add ( c ) ; } node . VAR_4 = VAR_2 ; } } } | private void add ( String ... VAR_1 ) { if ( VAR_1 != null ) { for ( String VAR_2 : VAR_1 ) { if ( VAR_2 == null || VAR_2 . isEmpty ( ) ) { continue ; } TYPE_1 node = VAR_3 ; for ( char c : VAR_2 . METHOD_1 ( ) ) { node = node . add ( c ) ; } node . VAR_4 = VAR_2 ; } } } |
put condition ? ( input instanceof TYPE_2 && ( ( TYPE_2 ) input ) METHOD_2 ( ) instanceof TYPE_1 ) | protected TYPE_1 METHOD_1 ( Object input ) { <START> if ( input instanceof TYPE_2 ) { input = ( ( TYPE_2 ) input ) . METHOD_2 ( ) ; } if ( input instanceof TYPE_1 ) { return ( TYPE_1 ) input ; } <END> return null ; } | protected TYPE_1 METHOD_1 ( Object input ) { if ( input instanceof TYPE_2 && ( ( TYPE_2 ) input ) . METHOD_2 ( ) instanceof TYPE_1 ) { return ( TYPE_1 ) input ; } return null ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.