ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
default need public | <START> public TYPE_2 ( TYPE_1 <END> VAR_2 ) { this . VAR_2 = VAR_2 ; } | TYPE_2 ( TYPE_1 VAR_2 ) { this . VAR_2 = VAR_2 ; } |
cast ( Object ) prevent a deprecation warning | public static < T extends org . VAR_1 . VAR_2 . VAR_3 . TYPE_6 > org . VAR_5 . TYPE_5 < T > METHOD_1 ( TYPE_2 . TYPE_3 . String key , TYPE_2 . TYPE_3 . String value ) { return org . VAR_1 . VAR_7 . VAR_2 . VAR_8 . VAR_9 . TYPE_4 . METHOD_1 ( key , <START> value ) ; <END> } | public static < T extends org . VAR_1 . VAR_2 . VAR_3 . TYPE_6 > org . VAR_5 . TYPE_5 < T > METHOD_1 ( TYPE_2 . TYPE_3 . String key , TYPE_2 . TYPE_3 . String value ) { return org . VAR_1 . VAR_7 . VAR_2 . VAR_8 . VAR_9 . TYPE_4 . METHOD_1 ( key , ( Object ) value ) ; } |
consistent METHOD_1 ( key index ) | public TYPE_1 METHOD_1 ( String key , Object value ) { TYPE_2 matcher = METHOD_2 ( METHOD_3 ( TYPE_3 . class ) , METHOD_4 ( key , value ) , METHOD_5 ( SWT . VAR_1 , STRING_1 ) ) ; return new TYPE_1 ( ( TYPE_3 ) METHOD_6 ( matcher ) , matcher ) ; <START> } <END> | public TYPE_1 METHOD_1 ( String key , Object value ) { return METHOD_1 ( key , value , 0 ) ; } |
10 | private void METHOD_1 ( boolean value ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; VAR_1 . put ( TYPE_2 . VAR_3 , value ) ; if ( value ) { VAR_1 . put ( TYPE_2 . VAR_4 , <START> 100 ) ; <END> } else { VAR_1 . put ( TYPE_2 . VAR_4 , 0 ) ; } } | private void METHOD_1 ( boolean value ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; VAR_1 . put ( TYPE_2 . VAR_3 , value ) ; if ( value ) { VAR_1 . put ( TYPE_2 . VAR_4 , 10 ) ; } else { VAR_1 . put ( TYPE_2 . VAR_4 , 0 ) ; } } |
return 0 oids aren t equal ? shouldn t return x case | public int METHOD_1 ( TYPE_1 o ) { int x = METHOD_2 ( ) . METHOD_1 ( o . VAR_1 ( ) ) ; <START> if ( x != 0 ) { <END> return 0 ; } return ( int ) ( METHOD_3 ( ) - o . VAR_2 ( ) ) ; } | public int METHOD_1 ( TYPE_1 o ) { int x = METHOD_2 ( ) . METHOD_1 ( o . VAR_1 ( ) ) ; if ( x != 0 ) { return x ; } return ( int ) ( METHOD_3 ( ) - o . VAR_2 ( ) ) ; } |
reason interface specific TYPE_1 ? TYPE_6 | public static <START> TYPE_1 METHOD_1 ( TYPE_2 <END> db , TYPE_3 VAR_1 ) throws IOException { TYPE_1 buffer = new TYPE_6 . TYPE_1 ( null ) ; TYPE_5 f = new TYPE_5 ( db , VAR_1 , buffer ) ; while ( f . run ( ) != - 1 ) { } return buffer ; } | public static TYPE_6 METHOD_1 ( TYPE_2 db , TYPE_3 VAR_1 ) throws IOException { TYPE_1 buffer = new TYPE_6 . TYPE_1 ( null ) ; TYPE_5 f = new TYPE_5 ( db , VAR_1 , buffer ) ; try { while ( f . run ( ) != - 1 ) { } } catch ( IOException e ) { buffer . close ( ) ; throw e ; } return buffer ; } |
true skipped | public TYPE_1 METHOD_1 ( TYPE_2 repo , TYPE_3 outputStream ) { if <START> ( METHOD_2 ( ) && <END> METHOD_3 ( repo ) ) { return new TYPE_4 ( repo , outputStream ) ; } return null ; } | public TYPE_1 METHOD_1 ( TYPE_2 repo , TYPE_3 outputStream ) { if ( METHOD_3 ( repo ) ) { return new TYPE_4 ( repo , outputStream ) ; } return null ; } |
useful | protected void METHOD_1 ( ) throws Exception { METHOD_2 ( TYPE_2 . VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , <START> VAR_7 ) ; <END> VAR_8 = new TYPE_1 ( VAR_9 , VAR_5 ) ; VAR_10 = VAR_11 . METHOD_3 ( VAR_8 , true ) ; } | protected void METHOD_1 ( ) throws Exception { METHOD_2 ( TYPE_2 . VAR_2 , VAR_3 , VAR_4 , VAR_5 ) ; VAR_8 = new TYPE_1 ( VAR_9 , VAR_5 ) ; VAR_10 = VAR_11 . METHOD_3 ( VAR_8 , true ) ; } |
loop iterates mutable array guarded lock loop guarded fix MT issue need guard inconsistent data array changed synchronized sort * methods entries VAR_2 elements multiple times sorting array easiest fix original issue METHOD_1 ( ) synchronized | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { Map < TYPE_2 , TYPE_3 > VAR_2 = VAR_3 ; if ( VAR_2 == null ) { VAR_2 = new HashMap < > ( ) ; <START> for ( TYPE_3 VAR_4 : VAR_5 ) { <END> TYPE_2 VAR_6 = VAR_4 . METHOD_2 ( ) ; if ( VAR_6 != null ) { VAR_2 . put ( VAR_6 , VAR_4 ) ; } } VAR_3 = VAR_2 ; } if ( VAR_2 . containsKey ... | public synchronized TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_3 == null ) { VAR_3 = new HashMap < > ( ) ; for ( TYPE_3 VAR_4 : VAR_5 ) { TYPE_2 VAR_6 = VAR_4 . METHOD_2 ( ) ; if ( VAR_6 != null ) { VAR_3 . put ( VAR_6 , VAR_4 ) ; } } } if ( VAR_3 . containsKey ( VAR_1 ) ) { return VAR_3 . get ( VAR_1 ) ; } return nul... |
final set start method _CODE_ store wrapper cached usage usages LS attempt retry works | public TYPE_3 ( ANNOTATION_1 TYPE_1 project , ANNOTATION_2 TYPE_2 VAR_2 ) { this . VAR_3 = project ; this . VAR_4 = new HashSet < > ( ) ; this . VAR_2 = VAR_2 ; this . VAR_5 = VAR_2 . METHOD_1 ( ) ; <START> if ( this . VAR_5 == null ) { <END> throw new IllegalStateException ( Messages . TYPE_4 ) ; } this . VAR_7 = new ... | public TYPE_3 ( ANNOTATION_1 TYPE_1 project , ANNOTATION_2 TYPE_2 VAR_2 ) { this . VAR_3 = project ; this . VAR_4 = new HashSet < > ( ) ; this . VAR_2 = VAR_2 ; this . VAR_7 = new HashMap < > ( ) ; } |
ideall super constructor | public TYPE_7 ( TYPE_1 VAR_2 ) { super ( VAR_2 , TYPE_2 . TYPE_4 ) ; <START> VAR_5 = TYPE_2 . TYPE_4 ; <END> VAR_6 = TYPE_2 . TYPE_5 ; VAR_8 = TYPE_2 . TYPE_3 ; VAR_10 = TYPE_2 . TYPE_6 ; METHOD_1 ( ) ; } | public TYPE_7 ( TYPE_1 VAR_2 ) { super ( VAR_2 , TYPE_2 . TYPE_4 , TYPE_2 . TYPE_5 , TYPE_2 . TYPE_3 , TYPE_2 . TYPE_6 ) ; METHOD_1 ( ) ; } |
don t need increment index avoid infinite looping ? avoid VAR_1 VAR_1 ( 0 ) | private String METHOD_1 ( String VAR_1 ) { Integer VAR_2 = VAR_3 . METHOD_2 ( ) . get ( VAR_1 ) ; int index = 0 ; String VAR_4 = VAR_1 ; while ( VAR_2 != null ) <START> { VAR_4 = VAR_1 + CHAR_1 + index + CHAR_2 ; VAR_2 = VAR_3 . METHOD_2 ( ) . get ( VAR_4 ) ; <END> } return VAR_4 ; } | private String METHOD_1 ( String VAR_1 ) { Integer VAR_2 = VAR_3 . METHOD_2 ( ) . get ( VAR_1 ) ; int index = 1 ; String VAR_4 = VAR_1 ; while ( VAR_2 != null ) { VAR_4 = VAR_1 + CHAR_1 + index + CHAR_2 ; VAR_2 = VAR_3 . METHOD_2 ( ) . get ( VAR_4 ) ; index ++ ; } return VAR_4 ; } |
isn t equivalent : _CODE_ = ; _CODE_ = TYPE_1 VAR_7 | public TYPE_2 ( int VAR_2 , char [ ] value , char [ ] VAR_3 ) { VAR_4 = VAR_2 ; <START> METHOD_1 ( VAR_2 , value ) ; <END> VAR_5 = ( VAR_3 == null ) ? TYPE_1 . VAR_7 : VAR_3 ; } | public TYPE_2 ( int VAR_2 , char [ ] value , char [ ] VAR_3 ) { set ( VAR_2 , value ) ; VAR_5 = ( VAR_3 == null ) ? TYPE_1 . VAR_7 : VAR_3 ; } |
unfortunate compiler suffixes supposed change cloned cloning avoided passing compiler suffixes constructor a parameter | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( VAR_3 , this . getValue ( ) ) ; VAR_2 . VAR_4 = <START> VAR_4 . METHOD_2 ( ) ; <END> VAR_2 . VAR_5 = VAR_5 ; VAR_2 . VAR_6 = VAR_6 ; VAR_2 . VAR_7 = VAR_7 ; VAR_2 . VAR_8 = VAR_8 == null ? null : VAR_8 . METHOD_2 ( ) ; return METHOD_1 ( VAR_2 , VAR_1... | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( VAR_3 , this . getValue ( ) , VAR_4 ) ; VAR_2 . VAR_5 = VAR_5 ; VAR_2 . VAR_6 = VAR_6 ; VAR_2 . VAR_7 = VAR_7 ; VAR_2 . VAR_8 = VAR_8 ; return METHOD_1 ( VAR_2 , VAR_1 ) ; } |
s clear : _CODE_ return null means _CODE_ doesn t require resolution METHOD_1 true implementation erroneous caused VAR_1 = = null 2 : future wasn t requested future requested null returned ( resolution required ) I need some more details another state variable class distinguish cases | public boolean METHOD_1 ( ) { <START> return VAR_1 == null || VAR_1 . METHOD_2 ( ) || VAR_2 != null ; <END> } | public boolean METHOD_1 ( ) { return ( VAR_1 != null && VAR_1 . METHOD_2 ( ) ) ; } |
completely useless | public void METHOD_1 ( ) { METHOD_2 ( VAR_1 , TYPE_1 . class ) ; VAR_2 . METHOD_3 ( STRING_1 ) . METHOD_4 ( ) ; TYPE_2 . METHOD_5 ( STRING_2 ) ; try { VAR_2 . METHOD_3 ( STRING_1 ) . METHOD_6 ( ) . METHOD_7 ( STRING_3 , 0 ) . METHOD_8 ( ) . METHOD_9 ( VAR_3 ) ; METHOD_10 ( ) ; } catch ( TYPE_3 e ) { <START> assertTrue ... | public void METHOD_1 ( ) { METHOD_2 ( VAR_1 , TYPE_1 . class ) ; VAR_2 . METHOD_3 ( STRING_1 ) . METHOD_4 ( ) ; TYPE_2 . METHOD_5 ( STRING_2 ) ; try { VAR_2 . METHOD_3 ( STRING_1 ) . METHOD_6 ( ) . METHOD_7 ( STRING_3 , 0 ) . METHOD_8 ( ) . METHOD_9 ( VAR_3 ) ; METHOD_10 ( ) ; } catch ( TYPE_3 e ) { } } |
monitor avoid confusion parameter nameoptional : block a ternary : monitor = monitor ! = null ? monitor : TYPE_2 VAR_2 ; | public void METHOD_1 ( TYPE_1 monitor ) { if ( monitor == null ) { <START> monitor = <END> TYPE_2 . VAR_2 ; } this . monitor = monitor ; } | public void METHOD_1 ( TYPE_1 monitor ) { this . monitor = monitor != null ? monitor : TYPE_2 . VAR_2 ; } |
disposing trace call | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) ; <START> VAR_2 . METHOD_2 ( ) ; TYPE_1 . METHOD_2 ( METHOD_3 ( ) ) ; <END> } | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) ; TYPE_1 . METHOD_2 ( METHOD_3 ( ) ) ; } |
check code : _CODE_ = VAR_1 METHOD_3 ( ) - _CODE_ + 1 ; + 1 missing | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { TYPE_4 VAR_3 = new TYPE_5 ( VAR_2 , VAR_1 . METHOD_2 ( ) , <START> VAR_1 . METHOD_3 ( ) - VAR_1 . METHOD_2 ( ) ) . METHOD_4 ( ) ; <END> if ( VAR_3 != null ) { TYPE_4 VAR_4 = TYPE_6 . METHOD_5 ( VAR_3 , TYPE_4 . VAR_5 ) ; if ( VAR_4 instanceof TYPE_1 ) { r... | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { TYPE_4 VAR_3 = new TYPE_5 ( VAR_2 , VAR_1 . METHOD_2 ( ) , VAR_1 . METHOD_3 ( ) - VAR_1 . METHOD_2 ( ) + 1 ) . METHOD_4 ( ) ; if ( VAR_3 != null ) { TYPE_4 VAR_4 = TYPE_6 . METHOD_5 ( VAR_3 , TYPE_4 . VAR_5 ) ; if ( VAR_4 instanceof TYPE_1 ) { return ( TY... |
docs supposed pass null clear message | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 != null && VAR_1 == null ) { <START> VAR_2 . METHOD_2 ( "" ) ; <END> } VAR_2 = VAR_1 ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 != null && VAR_1 == null ) { VAR_2 . METHOD_2 ( null ) ; } VAR_2 = VAR_1 ; } |
METHOD_3 returns need fetch | public Object METHOD_1 ( String key , Object value ) { if ( METHOD_2 ( ) . containsKey ( key ) ) { <START> final Object VAR_1 = METHOD_2 ( ) . get ( key ) ; <END> METHOD_2 ( ) . METHOD_3 ( key ) ; METHOD_4 ( ) . put ( key , value ) ; return VAR_1 ; } return METHOD_4 ( ) . put ( key , value ) ; } | public Object METHOD_1 ( String key , Object value ) { if ( METHOD_2 ( ) . containsKey ( key ) ) { final Object VAR_1 = METHOD_2 ( ) . METHOD_3 ( key ) ; METHOD_4 ( ) . put ( key , value ) ; return VAR_1 ; } return METHOD_4 ( ) . put ( key , value ) ; } |
move a separate commit | public <START> ANNOTATION_1 String <END> METHOD_1 ( ) { return VAR_1 ; } | public String METHOD_1 ( ) { return VAR_1 ; } |
shouldn t final a 1st iteration - cases need override | <START> public int METHOD_1 ( ) { <END> return VAR_1 ; } | public final int METHOD_1 ( ) { return VAR_1 ; } |
need public ? useful call subclasses protected shouldn t final a 1st iteration - cases need override | <START> public void METHOD_1 ( int VAR_1 ) { <END> this . VAR_1 = VAR_1 ; } | protected final void METHOD_1 ( int VAR_1 ) { this . VAR_1 = VAR_1 ; } |
rename smth _CODE_ | public static synchronized ANNOTATION_1 TYPE_1 <START> create ( TYPE_2 <END> trace , ANNOTATION_1 TYPE_3 VAR_1 ) { if ( VAR_1 == null ) { return null ; } TYPE_1 VAR_2 = TYPE_4 . get ( VAR_1 ) ; if ( VAR_2 != null ) { return VAR_2 ; } if ( VAR_1 instanceof TYPE_5 ) { ( ( TYPE_5 ) VAR_1 ) . METHOD_1 ( ) ; VAR_2 = new TYP... | public static synchronized ANNOTATION_1 TYPE_1 create ( TYPE_2 trace , ANNOTATION_1 TYPE_3 VAR_1 ) { if ( VAR_1 == null ) { return null ; } TYPE_1 VAR_2 = TYPE_4 . get ( VAR_1 ) ; if ( VAR_2 != null ) { return VAR_2 ; } VAR_2 = new TYPE_1 ( trace , VAR_1 ) ; TYPE_4 . put ( VAR_1 , VAR_2 ) ; if ( VAR_1 instanceof TYPE_5... |
removed field type | public void METHOD_1 ( ) { VAR_1 . METHOD_1 ( ) ; if ( VAR_2 != null ) { <START> ( ( TYPE_1 ) VAR_2 ) . METHOD_1 ( ) ; <END> } super . METHOD_1 ( ) ; } | public void METHOD_1 ( ) { VAR_1 . METHOD_1 ( ) ; if ( VAR_2 != null ) { VAR_2 . METHOD_1 ( ) ; } super . METHOD_1 ( ) ; } |
case handled nullname2 ! = null ? - 1 : 0 | public int METHOD_1 ( String VAR_1 , String VAR_2 ) { String VAR_3 = VAR_4 . get ( VAR_1 ) ; String VAR_5 = VAR_4 . get ( VAR_2 ) ; if ( VAR_3 == null ) { return <START> - 1 ; <END> } if ( VAR_5 == null ) { return 1 ; } return TYPE_1 . getInstance ( ) . METHOD_1 ( VAR_3 , VAR_5 ) ; } | public int METHOD_1 ( String VAR_1 , String VAR_2 ) { String VAR_3 = VAR_4 . get ( VAR_1 ) ; String VAR_5 = VAR_4 . get ( VAR_2 ) ; if ( VAR_3 == null ) { return ( VAR_5 != null ) ? - 1 : 0 ; } if ( VAR_5 == null ) { return 1 ; } return TYPE_1 . getInstance ( ) . METHOD_1 ( VAR_3 , VAR_5 ) ; } |
bugs worry file path calling shouldn t able call preload File METHOD_2 | private static void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( TYPE_5 . TYPE_6 . METHOD_3 ( ) ) ; TYPE_1 . METHOD_2 ( TYPE_5 . TYPE_7 . METHOD_3 ( ) ) ; <START> File VAR_1 = TYPE_1 . METHOD_4 ( ) . METHOD_5 ( ) . append ( TYPE_5 . TYPE_7 . METHOD_3 ( ) . getName ( ) ) . METHOD_6 ( ) ; TYPE_1 . METHOD_7 ( VAR_1 ) ; <END> TYPE_4... | private static void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( TYPE_5 . TYPE_6 . METHOD_3 ( ) ) ; TYPE_1 . METHOD_2 ( TYPE_5 . TYPE_7 . METHOD_3 ( ) ) ; TYPE_4 . METHOD_8 ( ) ; } |
STRING_1 equals ( p getValue ( ) ) getValue ( ) yield null | public static int METHOD_1 ( TYPE_1 entry ) { return Arrays . stream ( entry . VAR_1 ( ) ) <START> . METHOD_2 ( p - > p . getName ( ) . equals ( TYPE_2 . VAR_3 ) && p . getValue ( ) . equals ( STRING_1 ) ) <END> ? TYPE_3 . VAR_5 : TYPE_3 . VAR_6 ; } | public static int METHOD_1 ( TYPE_1 entry ) { return Arrays . stream ( entry . VAR_1 ( ) ) . METHOD_2 ( p - > p . getName ( ) . equals ( TYPE_2 . VAR_3 ) && STRING_1 . equals ( p . getValue ( ) ) ) ? TYPE_3 . VAR_5 : TYPE_3 . VAR_6 ; } |
I ll occasion mention kind variable extraction performance hinders readability please avoid ( cluttering performance patches ) simple getters highlighted profilers instrumentation | public boolean METHOD_1 ( TYPE_1 target ) { <START> final TYPE_2 VAR_1 = target . VAR_2 ( ) ; <END> return VAR_1 != null && VAR_1 . METHOD_2 ( ) == TYPE_3 . VAR_4 ; } | public boolean METHOD_1 ( TYPE_1 target ) { return target . VAR_2 ( ) != null && target . VAR_2 ( ) . METHOD_2 ( ) == TYPE_3 . VAR_4 ; } |
TYPE_2 equals safe | public boolean equals ( Object obj ) { if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return <START> TYPE_2 . equals ( VAR_2 , <END> VAR_1 . VAR_2 ) && TYPE_2 . equals ( VAR_3 , VAR_1 . VAR_3 ) ; } | public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return TYPE_2 . equals ( VAR_2 , VAR_1 . VAR_2 ) && TYPE_2 . equals ( VAR_3 , VAR_1 . VAR_3 ) ; } |
missing space shortened : VAR_1 = null && selected ; | protected void METHOD_1 ( ) { boolean VAR_1 = false ; <START> if ( VAR_2 != null ) { <END> VAR_1 = VAR_2 . METHOD_2 ( ) ; } TYPE_1 trace = METHOD_3 ( VAR_3 . METHOD_4 ( ) , VAR_1 ) ; if ( trace == null ) { return ; } METHOD_5 ( new TYPE_1 [ ] { trace } ) ; super . METHOD_1 ( ) ; } | protected void METHOD_1 ( ) { boolean VAR_1 = VAR_2 != null ? VAR_2 . METHOD_2 ( ) : false ; TYPE_1 trace = METHOD_3 ( VAR_3 . METHOD_4 ( ) , VAR_1 ) ; if ( trace == null ) { return ; } METHOD_5 ( new TYPE_1 [ ] { trace } ) ; super . METHOD_1 ( ) ; } |
need | public TYPE_5 ( TYPE_1 trace , long VAR_2 , TYPE_2 field ) { super ( trace , VAR_2 , TYPE_3 . METHOD_1 ( field . VAR_3 ( ) ) , TYPE_4 . get ( field . getName ( ) ) , field . VAR_4 ( ) ) ; VAR_5 = field ; VAR_6 = field . getName ( ) ; <START> VAR_7 = Level . VAR_8 ; <END> VAR_9 = null ; } | public TYPE_5 ( TYPE_1 trace , long VAR_2 , TYPE_2 field ) { super ( trace , VAR_2 , TYPE_3 . METHOD_1 ( field . VAR_3 ( ) ) , TYPE_4 . get ( field . getName ( ) ) , field . VAR_4 ( ) ) ; VAR_5 = field ; VAR_6 = field . getName ( ) ; VAR_9 = null ; } |
METHOD_2 internally copy entire match set case hybrid matching perform expected | public TYPE_1 < TYPE_2 > METHOD_1 ( Object [ ] parameters ) { <START> return METHOD_2 ( parameters , METHOD_3 ( parameters ) ) . stream ( ) ; <END> } | public TYPE_1 < TYPE_2 > METHOD_1 ( Object [ ] parameters ) { return METHOD_2 ( parameters , METHOD_3 ( parameters ) ) ; } |
static | <START> private void <END> METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) ) throw new TYPE_2 ( ) ; } | private static void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) ) throw new TYPE_2 ( ) ; } |
static | <START> private TYPE_1 <END> METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , TYPE_4 < TYPE_5 > VAR_3 ) throws TYPE_6 { TYPE_7 VAR_4 = TYPE_8 . METHOD_2 ( ) ; for ( Iterator < TYPE_5 > VAR_5 = VAR_3 . iterator ( ) ; VAR_5 . hasNext ( ) ; ) { TYPE_5 type = VAR_5 . next ( ) ; VAR_4 . add ( type ) ; } return TYPE_8 . METHOD_3 ( V... | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , TYPE_4 < TYPE_5 > VAR_3 ) throws TYPE_6 { TYPE_7 VAR_4 = TYPE_8 . METHOD_2 ( ) ; for ( Iterator < TYPE_5 > VAR_5 = VAR_3 . iterator ( ) ; VAR_5 . hasNext ( ) ; ) { TYPE_5 type = VAR_5 . next ( ) ; VAR_4 . add ( type ) ; } return TYPE_8 . METHOD_3 ( VAR_4 , ... |
please { } block I code doesn t new code | private static void METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( ) ) <END> throw new TYPE_2 ( ) ; } | private static void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) ) { throw new TYPE_2 ( ) ; } } |
move - catch TYPE_2 METHOD_3 | public TYPE_1 METHOD_1 ( ) { String VAR_1 = VAR_2 . METHOD_2 ( TYPE_4 . TYPE_5 , STRING_1 ) ; <START> try { return TYPE_2 . METHOD_3 ( VAR_1 ) ; } catch ( Exception ex ) { throw new TYPE_3 ( STRING_2 , ex ) ; } <END> } | public TYPE_1 METHOD_1 ( ) { String VAR_1 = VAR_2 . METHOD_2 ( TYPE_4 . TYPE_5 , STRING_1 ) ; return TYPE_2 . METHOD_3 ( VAR_1 ) ; } |
append instead + | private void METHOD_1 ( TYPE_1 VAR_1 ) { String [ ] VAR_2 = VAR_1 . METHOD_2 ( false ) ; if ( VAR_2 . length > 0 ) { <START> StringBuilder msg = new StringBuilder ( STRING_1 + VAR_2 ) ; <END> for ( int i = 0 ; i < VAR_2 . length ; i ++ ) { msg . append ( CHAR_1 + VAR_2 [ i ] ) ; } METHOD_3 ( msg . toString ( ) ) ; } } | private void METHOD_1 ( TYPE_1 VAR_1 ) { String [ ] VAR_2 = VAR_1 . METHOD_2 ( false ) ; if ( VAR_2 . length > 0 ) { StringBuilder msg = new StringBuilder ( STRING_1 ) . append ( VAR_2 ) ; for ( int i = 0 ; i < VAR_2 . length ; i ++ ) { msg . append ( CHAR_1 ) . append ( VAR_2 [ i ] ) ; } METHOD_3 ( msg . toString ( ) ... |
append instead + | public String getName ( ) { StringBuilder name = new StringBuilder ( ) ; for ( int i = 0 ; i < ( input . length - 1 ) ; i ++ ) { <START> name . append ( input [ i ] . getName ( ) + STRING_1 ) ; <END> } name . append ( input [ input . length - 1 ] . getName ( ) ) ; return name . toString ( ) ; } | public String getName ( ) { StringBuilder name = new StringBuilder ( ) ; for ( int i = 0 ; i < ( input . length - 1 ) ; i ++ ) { name . append ( input [ i ] . getName ( ) ) . append ( STRING_1 ) ; } name . append ( input [ input . length - 1 ] . getName ( ) ) ; return name . toString ( ) ; } |
doesn t executed case _CODE_ overrides METHOD_1 ( ) | public boolean METHOD_1 ( Object element , boolean state ) { <START> TYPE_1 VAR_1 = VAR_2 ; <END> if ( VAR_1 != null && VAR_1 . METHOD_1 ( element , state ) ) { METHOD_2 ( element , false ) ; return false ; } METHOD_3 ( element , state ) ; return VAR_3 . METHOD_1 ( element , state ) ; } | public boolean METHOD_1 ( Object element , boolean state ) { METHOD_3 ( element , state ) ; return VAR_3 . METHOD_1 ( element , state ) ; } |
I prefer listener added _CODE_ _CODE_ ( ) listener package TYPE_7 need a _CODE_ ( ) _CODE_ ( ) method | private TYPE_7 ( TYPE_1 parent , TYPE_2 VAR_2 , int VAR_3 , String id ) { super ( parent , VAR_2 . METHOD_1 ( ) ) ; TYPE_3 VAR_4 = VAR_2 . METHOD_1 ( ) ; VAR_4 . METHOD_2 ( VAR_5 ) ; if ( VAR_4 instanceof TYPE_4 ) { ( ( TYPE_4 ) VAR_4 ) . METHOD_3 ( new TYPE_5 ( ) ) ; } VAR_6 = VAR_2 ; VAR_7 = VAR_3 ; VAR_8 = id ; <STA... | private TYPE_7 ( TYPE_1 parent , TYPE_2 VAR_2 , int VAR_3 , String id ) { super ( parent , VAR_2 . METHOD_1 ( ) ) ; TYPE_3 VAR_4 = VAR_2 . METHOD_1 ( ) ; VAR_4 . METHOD_2 ( VAR_5 ) ; if ( VAR_4 instanceof TYPE_4 ) { ( ( TYPE_4 ) VAR_4 ) . METHOD_3 ( new TYPE_5 ( ) ) ; } VAR_6 = VAR_2 ; VAR_7 = VAR_3 ; VAR_8 = id ; } |
public ? extender annotation I don t I need invoke I d expect underlying framework necssary optimizations | <START> public boolean METHOD_1 ( ) { <END> return VAR_1 . METHOD_1 ( this ) ; } | protected boolean METHOD_1 ( ) { return VAR_1 . METHOD_1 ( this ) ; } |
public ? couldn t package visible | <START> public boolean METHOD_1 ( TYPE_1 VAR_1 ) { <END> return VAR_2 . METHOD_1 ( VAR_1 ) ; } | boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_2 . METHOD_1 ( VAR_1 ) ; } |
VAR_1 equals ( VAR_3 - > VAR_3 getName ( ) ) | protected final Collection < TYPE_1 > METHOD_1 ( final String VAR_1 ) { final Collection < TYPE_1 > VAR_2 = <START> TYPE_3 . TYPE_4 . METHOD_2 ( session ) . stream ( ) . filter ( VAR_3 - > VAR_3 . getName ( ) . equals ( VAR_1 ) ) <END> . collect ( Collectors . VAR_4 ( ) ) ; return VAR_2 ; } | protected final List < TYPE_1 > METHOD_1 ( final String VAR_1 ) { final List < TYPE_1 > VAR_2 = TYPE_3 . TYPE_4 . METHOD_2 ( session ) . stream ( ) . filter ( VAR_3 - > VAR_1 . equals ( VAR_3 . getName ( ) ) ) . collect ( Collectors . VAR_4 ( ) ) ; return VAR_2 ; } |
return false : return trace instanceof TYPE_2 && super METHOD_1 ( trace ) ; | public boolean METHOD_1 ( TYPE_1 trace ) { if ( ! ( trace instanceof TYPE_2 ) ) { throw new <START> IllegalStateException ( ) ; <END> } return super . METHOD_1 ( trace ) ; } | public boolean METHOD_1 ( TYPE_1 trace ) { return ( trace instanceof TYPE_2 ) && super . METHOD_1 ( trace ) ; } |
technically null check | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ) ; <END> } | public void METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 . METHOD_2 ( ) ; } } |
unnecessary nested block | public static TYPE_1 METHOD_1 ( final File VAR_1 ) throws IOException { try ( TYPE_2 VAR_2 = new TYPE_2 ( VAR_1 ) ) { <START> try { <END> return read ( VAR_2 ) ; } catch ( IOException VAR_3 ) { throw new IOException ( TYPE_3 . format ( TYPE_4 . get ( ) . VAR_4 , VAR_1 . METHOD_2 ( ) ) , VAR_3 ) ; } } } | public static TYPE_1 METHOD_1 ( final File VAR_1 ) throws IOException { try ( TYPE_2 VAR_2 = new TYPE_2 ( VAR_1 ) ) { return read ( VAR_2 ) ; } catch ( IOException VAR_3 ) { throw new IOException ( TYPE_3 . format ( TYPE_4 . get ( ) . VAR_4 , VAR_1 . METHOD_2 ( ) ) , VAR_3 ) ; } } |
remove ternary | public ANNOTATION_1 String METHOD_1 ( String VAR_1 ) { String VAR_2 = <START> null ; <END> if ( VAR_3 != null ) { VAR_2 = VAR_3 . get ( VAR_1 ) ; } if ( VAR_2 == null && VAR_4 != null ) { VAR_2 = VAR_4 . get ( VAR_4 . METHOD_2 ( VAR_1 ) ) ; } return VAR_2 == null ? "" : VAR_2 ; } | public ANNOTATION_1 String METHOD_1 ( String VAR_1 ) { String VAR_2 = VAR_1 ; if ( VAR_3 != null ) { VAR_2 = VAR_3 . get ( VAR_1 ) ; } return VAR_2 == null ? "" : VAR_2 ; } |
long | public <START> int METHOD_1 ( ) <END> { return VAR_1 ; } | public long METHOD_1 ( ) { return VAR_1 ; } |
buffer getString ( ) | private static final TYPE_1 METHOD_1 ( TYPE_2 buffer ) { <START> short VAR_1 = buffer . VAR_2 ( ) ; byte [ ] VAR_3 = new byte [ VAR_1 ] ; buffer . get ( VAR_3 ) ; String host = new String ( VAR_3 , VAR_4 ) ; if ( buffer . get ( ) != 0 ) { throw new IllegalStateException ( STRING_1 ) ; } <END> int VAR_5 = buffer . getIn... | private static final TYPE_1 METHOD_1 ( TYPE_2 buffer ) { String host = buffer . getString ( ) ; int VAR_5 = buffer . getInt ( ) ; return new TYPE_1 ( host , VAR_5 ) ; } |
null ; - ) note text compact assignment | public void METHOD_1 ( ) { TYPE_1 VAR_1 = <START> VAR_2 . METHOD_2 ( ) ; <END> if ( VAR_2 != null && VAR_1 != null && ! VAR_1 . METHOD_3 ( ) ) { VAR_1 . METHOD_1 ( ) ; } } | public void METHOD_1 ( ) { if ( VAR_2 != null ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( VAR_1 != null && ! VAR_1 . METHOD_3 ( ) ) { VAR_1 . METHOD_1 ( ) ; } } } |
a static method = = check | private TYPE_1 METHOD_1 ( Class < ? > VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 . METHOD_2 ( ) ) { if ( VAR_2 . getName ( ) . equals ( STRING_1 ) && ( VAR_2 . METHOD_3 ( ) & TYPE_2 . VAR_4 ) <START> != TYPE_2 . VAR_4 <END> && METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ) { return VAR_2 ; } } return null ; } | private TYPE_1 METHOD_1 ( Class < ? > VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 . METHOD_2 ( ) ) { if ( VAR_2 . getName ( ) . equals ( STRING_1 ) && ( VAR_2 . METHOD_3 ( ) & TYPE_2 . VAR_4 ) == TYPE_2 . VAR_4 && METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ) { return VAR_2 ; } } return null ; } |
getName ( ) VAR_2 ( ) return null anonymous class | default String VAR_1 ( ) { return <START> getClass ( ) . VAR_2 ( ) ; <END> } | default String VAR_1 ( ) { return getClass ( ) . getName ( ) ; } |
id | private static String getPath ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { String <START> VAR_3 = <END> String . valueOf ( VAR_1 . getId ( ) ) ; String VAR_4 = VAR_2 . METHOD_1 ( ) ; if ( METHOD_2 ( VAR_2 ) ) { return VAR_5 + VAR_3 + VAR_6 + VAR_7 + VAR_4 ; } return VAR_5 + VAR_3 + VAR_6 + VAR_4 ; } | private static String getPath ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { String id = String . valueOf ( VAR_1 . getId ( ) ) ; String VAR_4 = VAR_2 . METHOD_1 ( ) ; if ( METHOD_2 ( VAR_2 ) ) { return VAR_5 + id + VAR_6 + VAR_7 + VAR_4 ; } return VAR_5 + id + VAR_6 + VAR_4 ; } |
move test package org eclipse egit core op method doesn t need public | <START> public static boolean METHOD_1 ( String VAR_1 ) { <END> return VAR_1 != null && TYPE_1 . matcher ( VAR_1 ) . METHOD_2 ( ) ; } | static boolean METHOD_1 ( String VAR_1 ) { return VAR_1 != null && TYPE_1 . matcher ( VAR_1 ) . METHOD_2 ( ) ; } |
unnecessary final | public void <START> METHOD_1 ( final boolean <END> VAR_1 ) { this . VAR_2 = Optional . of ( VAR_1 ) ; } | public void METHOD_1 ( final boolean VAR_1 ) { this . VAR_2 = VAR_1 ; } |
variable entrySet unnecessary ? replaced VAR_3 entrySet ( ) loss efficiency clarity | protected void METHOD_1 ( final TYPE_1 VAR_1 ) throws TYPE_2 { TYPE_3 VAR_2 = null ; Set < Entry < TYPE_4 , TYPE_3 > > entrySet = VAR_3 . entrySet ( ) ; <START> for ( Entry < TYPE_4 , TYPE_3 > entry : entrySet ) { <END> TYPE_4 VAR_4 = entry . getKey ( ) ; VAR_2 = entry . getValue ( ) ; if ( VAR_2 != null ) { final TYPE... | protected void METHOD_1 ( final TYPE_1 VAR_1 ) throws TYPE_2 { TYPE_3 VAR_2 = null ; for ( Entry < TYPE_4 , TYPE_3 > entry : VAR_3 . entrySet ( ) ) { TYPE_4 VAR_4 = entry . getKey ( ) ; VAR_2 = entry . getValue ( ) ; if ( VAR_2 != null ) { final TYPE_5 VAR_5 = VAR_2 . METHOD_2 ( true ) ; if ( VAR_5 != null ) VAR_1 . ME... |
please ! string isEmpty ( ) | public void METHOD_1 ( String VAR_1 ) { METHOD_2 ( ) ; VAR_2 = VAR_1 ; if ( VAR_3 != null && VAR_1 != null && <START> VAR_1 . length ( ) > 0 ) { <END> TYPE_1 VAR_4 = TYPE_2 . METHOD_3 ( VAR_3 , TYPE_3 . VAR_6 , TYPE_3 . VAR_7 ) ; VAR_4 . METHOD_4 ( VAR_1 ) ; } else { METHOD_5 ( TYPE_3 . VAR_6 , TYPE_3 . VAR_7 ) ; } } | public void METHOD_1 ( String VAR_1 ) { METHOD_2 ( ) ; VAR_2 = VAR_1 ; if ( VAR_3 != null && VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { TYPE_1 VAR_4 = TYPE_2 . METHOD_3 ( VAR_3 , TYPE_3 . VAR_6 , TYPE_3 . VAR_7 ) ; VAR_4 . METHOD_4 ( VAR_1 ) ; } else { METHOD_5 ( TYPE_3 . VAR_6 , TYPE_3 . VAR_7 ) ; } } |
please ! string isEmpty ( ) | public void METHOD_1 ( String name ) { VAR_1 = name ; if ( VAR_2 != null ) { if ( name != null && <START> name . length ( ) > 0 ) { <END> VAR_2 . METHOD_2 ( TYPE_1 . VAR_4 , name ) ; } else { VAR_2 . METHOD_3 ( TYPE_1 . VAR_4 ) ; } } } | public void METHOD_1 ( String name ) { VAR_1 = name ; if ( VAR_2 != null ) { if ( name != null && ! name . isEmpty ( ) ) { VAR_2 . METHOD_2 ( TYPE_1 . VAR_4 , name ) ; } else { VAR_2 . METHOD_3 ( TYPE_1 . VAR_4 ) ; } } } |
a simple loop ? removing | static void METHOD_1 ( ) { final TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( ) ; <START> for ( ; ; ) { <END> if ( ! VAR_1 . METHOD_3 ( ) ) { break ; } } } | static void METHOD_1 ( ) { final TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( ) ; while ( VAR_1 . METHOD_3 ( ) ) { } } |
refuse trimming trace - trimmable subset trimmable traces operation allowed trimmable ? ! _CODE_ ( ) isEmpty ( ) | private static boolean METHOD_1 ( ANNOTATION_1 Object element ) { if ( element instanceof TYPE_1 ) { return true ; } if ( ! ( element instanceof TYPE_2 ) ) { return false ; } TYPE_2 trace = ( TYPE_2 ) element ; List < TYPE_3 > VAR_1 = trace . VAR_2 ( ) ; if ( VAR_1 . isEmpty ( ) ) { return false ; } for ( TYPE_3 child ... | private static boolean METHOD_1 ( ANNOTATION_1 Object element ) { if ( element instanceof TYPE_1 ) { return true ; } if ( ! ( element instanceof TYPE_2 ) ) { return false ; } TYPE_2 trace = ( TYPE_2 ) element ; if ( trace . VAR_2 ( ) . isEmpty ( ) ) { return false ; } for ( TYPE_3 child : trace . VAR_2 ( ) ) { if ( ! M... |
I good enough s active | private void METHOD_1 ( ) { if ( ! VAR_1 . isEmpty ( ) ) { METHOD_2 ( ) ; <START> } <END> VAR_1 . add ( VAR_2 . METHOD_3 ( VAR_3 ) ) ; } | private void METHOD_1 ( ) { if ( VAR_1 . isEmpty ( ) ) { VAR_1 . add ( VAR_2 . METHOD_3 ( VAR_3 ) ) ; } } |
move ? composite set config | public TYPE_1 build ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( METHOD_1 ( ) , METHOD_2 ( ) , METHOD_3 ( ) , METHOD_4 ( ) , METHOD_5 ( ) , METHOD_6 ( ) ) ; <START> TYPE_2 . METHOD_7 ( VAR_1 , METHOD_4 ( ) . METHOD_8 ( ) ) ; <END> return VAR_1 ; } | public TYPE_1 build ( ) { return new TYPE_1 ( METHOD_1 ( ) , METHOD_2 ( ) , METHOD_3 ( ) , METHOD_4 ( ) , METHOD_5 ( ) , METHOD_6 ( ) ) ; } |
4 ? I don t 25% early startup bundles eclipse expensive obtain front correct number ? undue effort | public void METHOD_1 ( TYPE_1 event ) { int VAR_1 = event . getType ( ) ; synchronized ( this ) { if ( VAR_1 == TYPE_1 . VAR_2 ) { <START> VAR_3 . split ( 4 ) ; <END> String VAR_4 = event . VAR_5 ( ) . METHOD_2 ( ) ; String VAR_6 = TYPE_2 . bind ( TYPE_3 . TYPE_4 , VAR_4 ) ; VAR_3 . METHOD_3 ( VAR_6 ) ; } } } | public void METHOD_1 ( TYPE_1 event ) { int VAR_1 = event . getType ( ) ; if ( VAR_1 == TYPE_1 . VAR_2 ) { VAR_3 . split ( 10 ) ; String VAR_4 = event . VAR_5 ( ) . METHOD_2 ( ) ; String VAR_6 = TYPE_2 . bind ( TYPE_3 . TYPE_4 , VAR_4 ) ; VAR_3 . METHOD_3 ( VAR_6 ) ; } } |
public final | <START> final public TYPE_1 <END> METHOD_1 ( String name ) throws IOException { return METHOD_2 ( ) . METHOD_1 ( name ) ; } | public final TYPE_1 METHOD_1 ( String name ) throws IOException { return METHOD_2 ( ) . METHOD_1 ( name ) ; } |
missing braces | public File METHOD_1 ( File VAR_1 , String name ) { final File VAR_2 = METHOD_2 ( name ) ; <START> if ( VAR_2 . METHOD_3 ( ) ) <END> return VAR_2 ; return METHOD_2 ( VAR_1 , name ) ; } | public File METHOD_1 ( File VAR_1 , String name ) { final File VAR_2 = METHOD_2 ( name ) ; if ( VAR_2 . METHOD_3 ( ) ) { return VAR_2 ; } return METHOD_2 ( VAR_1 , name ) ; } |
4 lines deleted | private static void METHOD_1 ( StringBuilder buffer , TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { StringBuilder VAR_3 = new StringBuilder ( ) ; METHOD_2 ( VAR_3 , VAR_1 ) ; StringBuilder VAR_4 = new StringBuilder ( ) ; <START> METHOD_2 ( VAR_4 , VAR_2 ) ; <END> buffer . append ( STRING_1 ) ; METHOD_2 ( buffer , VAR_1 ) ; buffer . ... | private static void METHOD_1 ( StringBuilder buffer , TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { buffer . append ( STRING_1 ) ; METHOD_2 ( buffer , VAR_1 ) ; buffer . append ( STRING_2 ) ; METHOD_2 ( buffer , VAR_2 ) ; buffer . append ( STRING_3 ) ; } |
calculating character count iteration calculate required size advance | private String METHOD_1 ( ) { StringBuilder b = new StringBuilder ( VAR_1 ) ; b . append ( STRING_1 ) ; String VAR_2 = STRING_2 ; while <START> ( b . length ( ) < <END> VAR_1 ) { b . append ( VAR_2 ) ; } return b . toString ( ) ; } | private String METHOD_1 ( ) { final String VAR_2 = STRING_2 ; StringBuilder b = new StringBuilder ( VAR_1 + VAR_2 . length ( ) ) ; b . append ( STRING_1 ) ; while ( b . length ( ) < VAR_1 ) { b . append ( VAR_2 ) ; } return b . toString ( ) ; } |
call new method null parameter | public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , final TYPE_1 VAR_2 ) { try { <START> if ( METHOD_2 ( VAR_2 , VAR_1 ) ) { <END> return VAR_2 ; } } catch ( final IOException ex ) { TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( new TYPE_4 ( new Status ( TYPE_5 . VAR_4 , TYPE_3 . VAR_5 , ex . getMessage ( ) , ex ) ) ) ;... | public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , final TYPE_1 VAR_2 ) { try { if ( METHOD_2 ( VAR_2 , VAR_1 , null ) ) { return VAR_2 ; } } catch ( final IOException ex ) { TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( new TYPE_4 ( new Status ( TYPE_5 . VAR_4 , TYPE_3 . VAR_5 , ex . getMessage ( ) , ex ) ) ) ; } retu... |
optional : I easier understand reversed _CODE_ more consistent _CODE_ | public static boolean <START> METHOD_1 ( String <END> VAR_1 ) { if ( TYPE_1 . equals ( VAR_1 ) ) { return true ; } if ( ( VAR_2 + TYPE_1 ) . equals ( VAR_1 ) ) { return true ; } return VAR_1 . startsWith ( STRING_1 ) ; } | public static boolean METHOD_1 ( String VAR_1 ) { if ( TYPE_1 . equals ( VAR_1 ) ) { return true ; } return VAR_1 . startsWith ( STRING_1 ) ; } |
I clear map some field null leads code NPE s sooner | protected void METHOD_1 ( ) { VAR_1 = false ; <START> VAR_2 = <END> null ; if ( VAR_3 instanceof TYPE_1 ) { ( ( TYPE_1 ) VAR_3 ) . VAR_4 . METHOD_2 ( ) ; } VAR_3 = null ; } | protected void METHOD_1 ( ) { VAR_1 = false ; VAR_2 . clear ( ) ; if ( VAR_3 instanceof TYPE_1 ) { ( ( TYPE_1 ) VAR_3 ) . VAR_4 . METHOD_2 ( ) ; } VAR_3 = null ; } |
please guard map concurrent access Iterator values ( ) call cry map changed ifrom another thread METHOD_4 ( called threads ) | public TYPE_1 [ ] METHOD_1 ( ) { if ( ! VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ) ; Collection < String > VAR_3 = VAR_2 . METHOD_3 ( ) ; for ( String VAR_4 : VAR_3 ) { METHOD_4 ( VAR_4 ) ; } VAR_1 = true ; } return <START> VAR_5 . values ( ) . METHOD_5 ( <END> new TYPE_1 [ VAR_5 . values ( ) . size ( ) ] ) ; } | public TYPE_1 [ ] METHOD_1 ( ) { if ( ! VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ) ; Collection < String > VAR_3 = VAR_2 . METHOD_3 ( ) ; for ( String VAR_4 : VAR_3 ) { METHOD_4 ( VAR_4 ) ; } VAR_1 = true ; } return VAR_5 . values ( ) . stream ( ) . METHOD_5 ( TYPE_1 [ ] : : new ) ; } |
missing curly braces | public static final int METHOD_1 ( final byte [ ] b , int VAR_1 ) { final int VAR_2 = b . length ; while ( VAR_1 < VAR_2 ) { final byte c = b [ VAR_1 ++ ] ; <START> if ( c == CHAR_1 && ( VAR_1 == VAR_2 || b [ VAR_1 ] != CHAR_2 ) ) <END> return VAR_1 - 1 ; } return VAR_1 - 1 ; } | public static final int METHOD_1 ( final byte [ ] b , int VAR_1 ) { final int VAR_2 = b . length ; while ( VAR_1 < VAR_2 ) { final byte c = b [ VAR_1 ++ ] ; if ( c == CHAR_1 && ( VAR_1 == VAR_2 || b [ VAR_1 ] != CHAR_2 ) ) { return VAR_1 - 1 ; } } return VAR_1 - 1 ; } |
put check config = = null METHOD_2 config = = null METHOD_2 return false | public File METHOD_1 ( String VAR_1 , TYPE_1 config ) { if <START> ( config != null && METHOD_2 ( config ) ) { <END> return new TYPE_2 ( VAR_1 , config ) ; } return new File ( VAR_1 ) ; } | public File METHOD_1 ( String VAR_1 , TYPE_1 config ) { return METHOD_2 ( config ) ? new TYPE_2 ( VAR_1 , config ) : new File ( VAR_1 ) ; } |
necessary ? I remove update line work | private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 , VAR_3 ) ; VAR_1 . METHOD_3 ( SWT . VAR_4 ) ; <START> VAR_1 . update ( ) ; <END> VAR_5 = true ; } | private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 , VAR_3 ) ; VAR_1 . METHOD_3 ( SWT . VAR_4 ) ; VAR_5 = true ; } |
necessary ? I remove update line work | private void METHOD_1 ( ) { if ( VAR_1 ) { TYPE_1 VAR_2 = VAR_3 . METHOD_2 ( ) ; VAR_3 . METHOD_3 ( VAR_4 , null ) ; VAR_3 . METHOD_4 ( SWT . VAR_5 ) ; <START> VAR_3 . update ( ) ; <END> if ( VAR_2 . equals ( VAR_3 . METHOD_2 ( ) ) ) { VAR_3 . METHOD_5 ( null ) ; } VAR_1 = false ; } } | private void METHOD_1 ( ) { if ( VAR_1 ) { TYPE_1 VAR_2 = VAR_3 . METHOD_2 ( ) ; VAR_3 . METHOD_3 ( VAR_4 , null ) ; VAR_3 . METHOD_4 ( SWT . VAR_5 ) ; if ( VAR_2 . equals ( VAR_3 . METHOD_2 ( ) ) ) { VAR_3 . METHOD_5 ( null ) ; } VAR_1 = false ; } } |
return boolean literal statements wrapped - - else simplified noncompliant code exampleif ( expression ) { return true ; } else { return false ; } compliant solutionreturn expression ; | private boolean METHOD_1 ( String VAR_1 , String VAR_2 ) { Collection < TYPE_1 > VAR_3 = METHOD_2 ( VAR_1 , VAR_4 ) ; <START> if ( ! METHOD_3 ( VAR_3 , VAR_2 ) ) { <END> return false ; } return true ; } | private boolean METHOD_1 ( String VAR_1 , String VAR_2 ) { Collection < TYPE_1 > VAR_3 = METHOD_2 ( VAR_1 , VAR_4 ) ; return METHOD_3 ( VAR_3 , VAR_2 ) ; } |
turn ? I guess type check faster a METHOD_2 | private boolean METHOD_1 ( Set < Object > VAR_1 , Set < Object > VAR_2 , int VAR_3 ) { <START> return ! VAR_1 . METHOD_2 ( VAR_2 ) && ( TYPE_1 . VAR_5 == VAR_3 || TYPE_1 . VAR_6 == VAR_3 ) ; <END> } | private boolean METHOD_1 ( Set < Object > VAR_1 , Set < Object > VAR_2 , int VAR_3 ) { return ( TYPE_1 . VAR_5 == VAR_3 || TYPE_1 . VAR_6 == VAR_3 ) && ! VAR_1 . METHOD_2 ( VAR_2 ) ; } |
don t need check actionbar null | protected void METHOD_1 ( TYPE_1 event ) { <START> VAR_1 . METHOD_2 ( ) ; <END> } | protected void METHOD_1 ( TYPE_1 event ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( ) ; } } |
constructors private | <START> TYPE_1 ( ) { <END> } | private TYPE_1 ( ) { } |
need | <START> public Collection < TYPE_1 > METHOD_1 ( ) { <END> return Collections . VAR_1 ( configuration . VAR_2 ( ) ) ; } | protected Collection < TYPE_1 > METHOD_1 ( ) { return Collections . VAR_1 ( configuration . VAR_2 ( ) ) ; } |
public | <START> public void METHOD_1 ( String id , TYPE_1 VAR_1 ) { <END> if ( VAR_2 . containsKey ( id ) ) { throw new IllegalArgumentException ( TYPE_2 . format ( STRING_1 , id ) ) ; } VAR_2 . put ( id , VAR_1 ) ; } | protected void METHOD_1 ( String id , TYPE_1 VAR_1 ) { if ( VAR_2 . containsKey ( id ) ) { throw new IllegalArgumentException ( TYPE_2 . format ( STRING_1 , id ) ) ; } VAR_2 . put ( id , VAR_1 ) ; } |
protected | <START> public TYPE_1 < ? <END> extends TYPE_2 > METHOD_1 ( ) { return VAR_1 ; } | protected TYPE_1 < ? extends TYPE_2 > METHOD_1 ( ) { return VAR_1 ; } |
leaks _CODE_ | public void METHOD_1 ( ) throws Exception { TYPE_1 a = commit ( ) ; TYPE_1 b = commit ( a ) ; METHOD_2 ( b ) ; <START> VAR_1 = METHOD_3 ( ) ; <END> b = VAR_1 . METHOD_4 ( b ) ; METHOD_5 ( b ) ; METHOD_6 ( b , VAR_1 . next ( ) ) ; METHOD_7 ( VAR_1 . next ( ) ) ; } | public void METHOD_1 ( ) throws Exception { TYPE_1 a = commit ( ) ; TYPE_1 b = commit ( a ) ; METHOD_2 ( b ) ; VAR_1 . close ( ) ; VAR_1 = METHOD_3 ( ) ; b = VAR_1 . METHOD_4 ( b ) ; METHOD_5 ( b ) ; METHOD_6 ( b , VAR_1 . next ( ) ) ; METHOD_7 ( VAR_1 . next ( ) ) ; } |
a new issue worth fixing : leaks _CODE_ | private void METHOD_1 ( TYPE_1 ... VAR_1 ) throws IOException { <START> VAR_2 = METHOD_2 ( ) ; <END> StringBuilder builder = new StringBuilder ( ) ; for ( TYPE_1 commit : VAR_1 ) { builder . append ( commit . getName ( ) + STRING_1 ) ; } TYPE_2 . write ( new File ( db . VAR_3 ( ) , STRING_2 ) , builder . toString ( ) )... | private void METHOD_1 ( TYPE_1 ... VAR_1 ) throws IOException { VAR_2 . close ( ) ; VAR_2 = METHOD_2 ( ) ; StringBuilder builder = new StringBuilder ( ) ; for ( TYPE_1 commit : VAR_1 ) { builder . append ( commit . getName ( ) + STRING_1 ) ; } TYPE_2 . write ( new File ( db . VAR_3 ( ) , STRING_2 ) , builder . toString... |
please remove redundant braces | private boolean METHOD_1 ( ) { return <START> ( TYPE_1 . METHOD_2 ( VAR_1 , <END> TYPE_1 . VAR_2 ) >= 0 ) ; } | private boolean METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( VAR_1 , TYPE_1 . VAR_2 ) >= 0 ; } |
null check late : METHOD_2 ( ) returns null call METHOD_3 ( ) previous line throw a _CODE_ | public void METHOD_1 ( TYPE_1 event ) { if ( event . VAR_1 ( ) == VAR_2 && event . getProperty ( ) == TYPE_3 . VAR_4 ) { String VAR_5 = TYPE_2 . METHOD_2 ( ( String ) event . VAR_6 ( ) ) . METHOD_3 ( ) ; <START> if ( VAR_5 != null ) { <END> VAR_7 . METHOD_4 ( VAR_5 ) ; } } } | public void METHOD_1 ( TYPE_1 event ) { if ( event . VAR_1 ( ) == VAR_2 && event . getProperty ( ) == TYPE_3 . VAR_4 ) { File VAR_5 = TYPE_2 . METHOD_2 ( ( String ) event . VAR_6 ( ) ) ; if ( VAR_5 != null ) { VAR_7 . METHOD_4 ( VAR_5 . METHOD_3 ( ) ) ; } } } |
private | <START> public TYPE_2 ( ) <END> { super ( new TYPE_1 [ 0 ] ) ; } | private TYPE_2 ( ) { super ( new TYPE_1 [ 0 ] ) ; } |
call other constructor | public TYPE_2 ( ) { <START> VAR_2 = new TYPE_1 ( ) ; <END> } | public TYPE_2 ( ) { this ( new TYPE_1 ( ) ) ; } |
done _CODE_ therefor needed | public static void METHOD_1 ( ) { VAR_1 = System . getProperty ( STRING_1 , "" ) ; <START> System . VAR_2 ( STRING_1 , STRING_2 ) ; <END> VAR_3 = System . getProperty ( STRING_3 , "" ) ; System . VAR_2 ( STRING_3 , STRING_4 ) ; } | public static void METHOD_1 ( ) { VAR_1 = System . getProperty ( STRING_1 , "" ) ; VAR_3 = System . getProperty ( STRING_3 , "" ) ; } |
method add remove scheme method reflect | public void <START> METHOD_1 ( ) <END> { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 ) ; TYPE_2 VAR_3 = new TYPE_2 ( STRING_1 , STRING_2 , System . getProperty ( STRING_3 ) ) ; VAR_1 . METHOD_2 ( Arrays . asList ( VAR_3 ) , Arrays . asList ( VAR_3 ) ) ; assertEquals ( null , VAR_2 . METHOD_3 ( STRING_1 ) ) ; } | public void METHOD_1 ( ) { TYPE_2 VAR_3 = new TYPE_2 ( STRING_1 , STRING_2 , System . getProperty ( STRING_3 ) ) ; VAR_1 . METHOD_2 ( Arrays . asList ( VAR_3 ) , Arrays . asList ( VAR_3 ) ) ; assertEquals ( null , VAR_2 . METHOD_3 ( STRING_1 ) ) ; } |
remove METHOD_5 call method | public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; TYPE_2 VAR_4 = new TYPE_2 ( ) ; TYPE_3 VAR_5 = VAR_1 . METHOD_3 ( ) . get ( 0 ) ; String VAR_6 = VAR_4 . METHOD_4 ( ( TYPE_4 ) VAR_5 ) ; <START> METHOD_5 ( VAR_6 ) ; <END> VAR_6 = METHOD_6 ( VAR_6 ) ; String VAR_7 = METHOD_6 ( VAR_8 ) ; assertEquals... | public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; TYPE_2 VAR_4 = new TYPE_2 ( ) ; TYPE_3 VAR_5 = VAR_1 . METHOD_3 ( ) . get ( 0 ) ; String VAR_6 = VAR_4 . METHOD_4 ( ( TYPE_4 ) VAR_5 ) ; VAR_6 = METHOD_6 ( VAR_6 ) ; String VAR_7 = METHOD_6 ( VAR_8 ) ; assertEquals ( VAR_7 , VAR_6 ) ; } |
I avoid trace set altogether experiment opened traces collection | public TYPE_1 METHOD_1 ( ) { for ( TYPE_1 trace : TYPE_2 . getInstance ( ) . METHOD_2 ( ) ) { <START> for ( TYPE_1 t : TYPE_2 . METHOD_3 ( trace ) ) { <END> if ( METHOD_4 ( ) . equals ( t . VAR_1 ( ) ) && ( t instanceof TYPE_3 ) ) { return t ; } } } return null ; } | public TYPE_1 METHOD_1 ( ) { for ( TYPE_1 trace : TYPE_2 . getInstance ( ) . METHOD_2 ( ) ) { if ( METHOD_4 ( ) . equals ( trace . VAR_1 ( ) ) && ( trace instanceof TYPE_3 ) ) { return trace ; } } return null ; } |
differ stays suspended testing shouldn t assertTrue | public void METHOD_1 ( ) throws Exception { VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( ) ; VAR_2 . METHOD_4 ( VAR_3 ) ; VAR_2 . METHOD_5 ( VAR_2 . METHOD_6 ( ) ) ; <START> METHOD_7 ( VAR_1 . METHOD_8 ( ) ) ; <END> METHOD_7 ( VAR_1 . METHOD_9 ( ) ) ; } | public void METHOD_1 ( ) throws Exception { VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( ) ; VAR_2 . METHOD_4 ( VAR_3 ) ; VAR_2 . METHOD_5 ( VAR_2 . METHOD_6 ( ) ) ; assertTrue ( VAR_1 . METHOD_8 ( ) ) ; } |
doesn t VAR_1 equals ( VAR_2 ) work | private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { return VAR_1 . METHOD_2 ( ) . equals ( VAR_2 . METHOD_2 ( ) ) <START> && ! METHOD_3 ( VAR_1 . METHOD_4 ( ) , VAR_2 . METHOD_4 ( ) ) <END> && METHOD_5 ( VAR_1 . METHOD_4 ( ) . METHOD_6 ( ) , VAR_2 . METHOD_4 ( ) . METHOD_6 ( ) ) && METHOD_5 ( VAR_2 . METHOD_4 ( ... | private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { return VAR_1 . METHOD_2 ( ) . equals ( VAR_2 . METHOD_2 ( ) ) && ! VAR_1 . equals ( VAR_2 ) && METHOD_5 ( VAR_1 . METHOD_4 ( ) . METHOD_6 ( ) , VAR_2 . METHOD_4 ( ) . METHOD_6 ( ) ) && METHOD_5 ( VAR_2 . METHOD_4 ( ) . METHOD_7 ( ) , VAR_1 . METHOD_4 ( ) . METH... |
sufficient write : METHOD_2 ( VAR_2 ) ; | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { <START> TYPE_2 . this . METHOD_2 ( VAR_2 ) ; <END> } | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { METHOD_2 ( VAR_2 ) ; } |
please add requested offset : throw new TYPE_3 ( Integer toString ( offset ) ) ; | public TYPE_1 METHOD_1 ( int offset ) throws TYPE_2 { if ( offset >= METHOD_2 ( ) ) { METHOD_3 ( TYPE_6 . TYPE_5 , new <START> TYPE_3 ( ) ) ; <END> } return new TYPE_4 ( METHOD_4 ( ) , METHOD_5 ( ) , offset , VAR_3 ) ; } | public TYPE_1 METHOD_1 ( int offset ) throws TYPE_2 { if ( offset >= METHOD_2 ( ) ) { METHOD_3 ( TYPE_6 . TYPE_5 , new TYPE_3 ( Integer . toString ( offset ) ) ) ; } return new TYPE_4 ( METHOD_4 ( ) , METHOD_5 ( ) , offset , VAR_3 ) ; } |
I m distinguishing cases simpler a single function METHOD_1 ( ) checks | <START> protected void METHOD_1 ( ) throws Exception { <END> TYPE_1 value = getValue ( ) ; assertEquals ( value , TYPE_2 . VAR_2 ) ; } | protected void METHOD_1 ( ) throws Exception { TYPE_1 value = getValue ( ) ; assertEquals ( TYPE_2 . VAR_2 , value ) ; } |
method belong _CODE_ global timestamp precision file | <START> public TYPE_1 METHOD_1 ( ) { <END> if ( METHOD_2 ( VAR_1 - 1 ) == INT_1 ) { return TYPE_1 . VAR_2 ; } return TYPE_1 . VAR_3 ; } | public TYPE_1 METHOD_1 ( ) { return TYPE_1 . VAR_2 ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.