Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
I VAR_1 setter instead getter time getValue called evaluate template setter underlined version evaluation
public TYPE_1 getValue ( ) { <START> if ( VAR_1 ) { <END> return VAR_2 . METHOD_1 ( VAR_3 ) ; } return VAR_3 ; }
public TYPE_1 getValue ( ) { return VAR_3 ; }
beif ( ! TYPE_2 METHOD_2 ( VAR_1 ) ) {
private String METHOD_1 ( TYPE_1 uri , String VAR_1 ) { String url = VAR_2 . getString ( STRING_1 , null , STRING_2 ) ; if ( TYPE_2 . METHOD_2 ( url ) ) { url = uri . toString ( ) ; } if ( ! url . VAR_3 ( STRING_3 ) ) { url += STRING_3 ; } <START> if ( TYPE_2 . METHOD_2 ( VAR_1 ) ) { <END> url += STRING_4 + VAR_1 ; } return url ; }
private String METHOD_1 ( TYPE_1 uri , String VAR_1 ) { String url = VAR_2 . getString ( STRING_1 , null , STRING_2 ) ; if ( TYPE_2 . METHOD_2 ( url ) ) { url = uri . toString ( ) ; } if ( ! url . VAR_3 ( STRING_3 ) ) { url += STRING_3 ; } if ( ! TYPE_2 . METHOD_2 ( VAR_1 ) ) { url += STRING_4 + VAR_1 ; } return url ; }
isn t correct item case passed JSR - 352 _CODE_ items current chunk spring batch JSR provide facilities identify item a chunk caused error section 9 2 7 spec more detail
<START> <END> <END> public <END> <END> void <END> <END> METHOD_1 ( <END> TYPE_1 <END> <END> <END> <END> <END> <END> <END> item , <END> Throwable <END> <END> t <END> ) <END> { <END> if <END> ( <END> VAR_1 != null <END> && <END> t instanceof <END> Exception <END> ) <END> <END> { try <END> <END> <END> { <END> VAR_1 . METHOD_2 ( TYPE_3
public void METHOD_1 ( TYPE_1 item , Throwable t ) { if ( VAR_1 != null && t instanceof Exception ) { try { VAR_1 . METHOD_2 ( ( List < Object > ) item , ( Exception ) t ) ; } catch ( Exception e ) { throw new TYPE_2 ( e ) ; } } }
VAR_2 instead VAR_3 [ 0 ] array
private TYPE_1 [ ] METHOD_1 ( TYPE_2 VAR_1 , Path VAR_2 ) { try { <START> return VAR_1 . METHOD_2 ( new Path ( VAR_3 [ 0 ] . getPath ( ) , TYPE_4 . VAR_5 ) ) ; <END> } catch ( TYPE_3 e ) { return new TYPE_1 [ ] { } ; } catch ( IOException e ) { throw new RuntimeException ( e ) ; } }
private TYPE_1 [ ] METHOD_1 ( TYPE_2 VAR_1 , Path VAR_2 ) { try { return VAR_1 . METHOD_2 ( new Path ( VAR_2 , TYPE_4 . VAR_5 ) ) ; } catch ( TYPE_3 e ) { return new TYPE_1 [ ] { } ; } catch ( IOException e ) { throw new RuntimeException ( e ) ; } }
access private
<START> public static boolean METHOD_1 ( ) { <END> return VAR_1 . METHOD_2 ( ) . version ( ) . METHOD_3 ( INT_1 , 2 ) ; }
private static boolean METHOD_1 ( ) { return VAR_1 . METHOD_2 ( ) . version ( ) . METHOD_3 ( INT_1 , 2 ) ; }
interesting times / runs memory spec devices s a good test
public void <START> METHOD_1 ( ) <END> throws IOException { TYPE_2 . TYPE_5 instance = TYPE_2 . getInstance ( ) ; String [ ] VAR_1 = instance . VAR_2 ( ) ; Arrays . VAR_3 ( VAR_1 ) ; for ( String id : VAR_1 ) { TYPE_3 VAR_4 = instance . VAR_5 ( id ) ; TYPE_4 VAR_6 = TYPE_4 . METHOD_2 ( id , VAR_4 , Long . VAR_7 ) ; assertNotNull ( STRING_1 + id + STRING_2 , VAR_6 ) ; assertEquals ( id , VAR_6 . METHOD_3 ( ) ) ; } }
public void METHOD_1 ( ) throws Exception { TYPE_2 . TYPE_5 instance = TYPE_2 . getInstance ( ) ; String [ ] VAR_1 = instance . VAR_2 ( ) ; Arrays . VAR_3 ( VAR_1 ) ; for ( String id : VAR_1 ) { TYPE_3 VAR_4 = instance . VAR_5 ( id ) ; TYPE_4 VAR_6 = TYPE_4 . METHOD_2 ( id , VAR_4 , Long . VAR_7 ) ; assertNotNull ( STRING_1 + id + STRING_2 , VAR_6 ) ; assertEquals ( id , VAR_6 . METHOD_3 ( ) ) ; } }
suggestionpublic int METHOD_1 ( ) {
<START> public Integer METHOD_1 ( ) { <END> return VAR_1 ; }
public int METHOD_1 ( ) { return VAR_1 ; }
package - private
<START> public byte METHOD_1 ( ) <END> { return VAR_1 ; }
byte METHOD_1 ( ) { return VAR_1 ; }
ordering
public TYPE_3 ( ANNOTATION_1 ( STRING_1 ) final Type type , ANNOTATION_1 ( STRING_2 ) final Boolean VAR_2 , ANNOTATION_1 ( STRING_3 ) final String VAR_3 , ANNOTATION_1 ( STRING_4 ) final String VAR_4 , ANNOTATION_1 ( STRING_5 ) final TYPE_1 VAR_5 , ANNOTATION_1 ( STRING_6 ) final TYPE_2 VAR_6 ) { this . type = type ; this . VAR_2 = VAR_2 ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_6 ; <START> this . VAR_3 = VAR_3 ; <END> this . VAR_4 = VAR_4 ; }
public TYPE_3 ( ANNOTATION_1 ( STRING_1 ) final Type type , ANNOTATION_1 ( STRING_2 ) final Boolean VAR_2 , ANNOTATION_1 ( STRING_3 ) final String VAR_3 , ANNOTATION_1 ( STRING_4 ) final String VAR_4 , ANNOTATION_1 ( STRING_5 ) final TYPE_1 VAR_5 , ANNOTATION_1 ( STRING_6 ) final TYPE_2 VAR_6 ) { this . type = type ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_6 ; }
incompatible change : VAR_1 return null s throwing null pointer
public TYPE_1 METHOD_1 ( ) { <START> return VAR_1 . get ( 0 ) ; <END> }
public TYPE_1 METHOD_1 ( ) { return VAR_1 . isEmpty ( ) ? null : VAR_1 . get ( 0 ) ; }
instead don t nest TYPE_1 s
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 == null ) { return ; } <START> while ( VAR_2 instanceof TYPE_1 ) { <END> VAR_2 = ( ( TYPE_1 ) VAR_2 ) . METHOD_2 ( ) ; } TYPE_2 VAR_3 = VAR_4 . apply ( VAR_2 ) ; VAR_1 . METHOD_3 ( VAR_3 ) ; VAR_2 = null ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 == null ) { return ; } if ( VAR_2 instanceof TYPE_1 ) { VAR_2 = ( ( TYPE_1 ) VAR_2 ) . METHOD_2 ( ) ; } TYPE_2 VAR_3 = VAR_4 . apply ( VAR_2 ) ; VAR_1 . METHOD_3 ( VAR_3 ) ; VAR_2 = null ; }
want cumulate a StringBuilder a plain String
public final String METHOD_1 ( ) { if ( this . properties . isEmpty ( ) ) return STRING_1 ; ANNOTATION_1 ( STRING_2 ) TYPE_1 e = this . properties . VAR_1 ( ) ; <START> String response = STRING_3 ; <END> response += STRING_4 + this . VAR_2 + STRING_5 ; while ( e . VAR_3 ( ) ) { String key = ( String ) e . VAR_4 ( ) ; response += STRING_6 + key + STRING_7 + this . properties . getProperty ( key ) + STRING_5 ; } return response ; }
public final String METHOD_1 ( ) { if ( this . properties . isEmpty ( ) ) return STRING_1 ; StringBuilder response = new StringBuilder ( STRING_3 ) ; response . append ( STRING_4 + this . VAR_2 + STRING_5 ) ; for ( Map . Entry < String , String > entry : this . properties . entrySet ( ) ) { response . append ( STRING_6 + entry . getKey ( ) + STRING_7 ) . append ( entry . getValue ( ) + STRING_5 ) ; } return response . toString ( ) ; }
move debug patch ( remove ) I INFO level
public void METHOD_1 ( ) { try { <START> log . info ( STRING_1 ) ; <END> TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 < Integer > getValue ( TYPE_4 . TYPE_5 ) * - 1 ) ; VAR_5 . METHOD_4 ( VAR_1 ) ; log . info ( STRING_2 ) ; } catch ( Throwable t ) { log . error ( STRING_3 , TYPE_2 . METHOD_5 ( t ) ) ; log . debug ( STRING_4 , t ) ; } }
public void METHOD_1 ( ) { try { log . debug ( STRING_1 ) ; TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 < Integer > getValue ( TYPE_4 . TYPE_5 ) * - 1 ) ; VAR_5 . METHOD_4 ( VAR_1 ) ; log . debug ( STRING_2 ) ; } catch ( Throwable t ) { log . error ( STRING_3 , TYPE_2 . METHOD_5 ( t ) ) ; log . debug ( STRING_4 , t ) ; } }
case Optional doesn t give A simple null check exact doesn t allocate a new object heap doesn t require a lambda readable : String node = VAR_2 METHOD_2 ( ) ( id ) ; ( VAR_2 METHOD_2 ( ) ( id ) = = null ) { context VAR_5 ( Collections _CODE_ ( ) ) ; } else { HashMap < String String > map = new HashMap < > ( 2 ) ; map put ( VAR_3 id ) ; map put ( VAR_4 id ) ; context VAR_5 ( map ) ; } more efficient original
public void METHOD_1 ( String id ) { HashMap < String , String > map = new HashMap < > ( ) ; <START> Optional . VAR_1 ( VAR_2 . METHOD_2 ( ) . get ( id ) ) . METHOD_3 ( node - > { <END> map . put ( VAR_3 , id ) ; map . put ( VAR_4 , id ) ; } ) ; context . VAR_5 ( map ) ; }
public void METHOD_1 ( String id ) { HashMap < String , String > map = new HashMap < > ( ) ; if ( VAR_2 . METHOD_2 ( ) . get ( id ) != null ) { map . put ( VAR_3 , id ) ; map . put ( VAR_4 , id ) ; } context . VAR_5 ( map ) ; }
please extract method : protected _CODE_ _CODE_ ( ) reason able write a test mockito ( pockermock / static mocking ) query
protected void METHOD_1 ( ) { <START> METHOD_2 ( ) . METHOD_3 ( TYPE_1 . getInstance ( ) <END> . METHOD_4 ( ) . METHOD_5 ( getParameters ( ) . METHOD_6 ( ) ) ) ; }
protected void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_5 ( getParameters ( ) . METHOD_6 ( ) ) ) ; }
I m understanding patch correctly idea ve reached point infinite crash loop - -
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; <START> TYPE_2 . METHOD_2 ( false ) ; <END> TYPE_3 . METHOD_3 ( this ) ; METHOD_4 ( ) ; METHOD_5 ( ) ; if ( METHOD_6 ( ) != null ) { METHOD_6 ( ) . METHOD_7 ( true ) ; } METHOD_8 ( this ) ; }
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; TYPE_3 . METHOD_3 ( this ) ; METHOD_4 ( ) ; METHOD_5 ( ) ; if ( METHOD_6 ( ) != null ) { METHOD_6 ( ) . METHOD_7 ( true ) ; } METHOD_8 ( this ) ; }
I implement other VAR_2 ( backing store ) : VAR_2 METHOD_1 ( VAR_1 ) ; mirror intent caller invoking METHOD_1 ( VAR_1 ) a subtle issue discarding a potentially large free list bottom stack pushing empty free list top stack weird I mirror caller s intent
void METHOD_1 ( final TYPE_1 VAR_1 ) { <START> VAR_1 . METHOD_1 ( VAR_2 ) ; <END> }
void METHOD_1 ( final TYPE_1 VAR_1 ) { VAR_2 . METHOD_1 ( VAR_1 ) ; }
simplify immediately returning false VAR_1 METHOD_2 ( ) isEmpty ( )
public static boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> boolean VAR_2 = ! VAR_1 . METHOD_2 ( ) . isEmpty ( ) ; <END> if ( VAR_2 ) { if ( TYPE_2 . METHOD_3 ( TYPE_6 . VAR_4 ) ) { VAR_2 = TYPE_3 . exists ( VAR_1 . METHOD_2 ( ) ) ; } else { VAR_2 = VAR_1 . METHOD_4 ( ) . equals ( TYPE_4 . METHOD_5 ( ) ) ; } } return VAR_2 && VAR_5 == TYPE_5 . VAR_7 ; }
public static boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) . isEmpty ( ) || VAR_5 != TYPE_5 . VAR_7 ) { return false ; } if ( TYPE_2 . METHOD_3 ( TYPE_6 . VAR_4 ) ) { return TYPE_3 . exists ( VAR_1 . METHOD_2 ( ) ) ; } else { return VAR_1 . METHOD_4 ( ) . equals ( TYPE_4 . METHOD_5 ( ) ) ; } }
a _CODE_ channel a bad state manually close
public static TYPE_1 create ( TYPE_2 context , TYPE_3 VAR_1 , long id , long length , TYPE_4 type , TYPE_5 options ) throws IOException { long VAR_2 = TYPE_6 . METHOD_1 ( TYPE_8 . VAR_4 ) ; TYPE_7 VAR_5 = context . VAR_6 ( VAR_1 ) ; try { return new TYPE_1 ( context , VAR_1 , id , length , VAR_2 , type , options , VAR_5 ) ; } catch ( Exception e ) { <START> VAR_5 . close ( ) ; <END> context . VAR_7 ( VAR_1 , VAR_5 ) ; throw e ; } }
public static TYPE_1 create ( TYPE_2 context , TYPE_3 VAR_1 , long id , long length , TYPE_4 type , TYPE_5 options ) throws IOException { long VAR_2 = TYPE_6 . METHOD_1 ( TYPE_8 . VAR_4 ) ; TYPE_7 VAR_5 = context . VAR_6 ( VAR_1 ) ; try { return new TYPE_1 ( context , VAR_1 , id , length , VAR_2 , type , options , VAR_5 ) ; } catch ( Exception e ) { context . VAR_7 ( VAR_1 , VAR_5 ) ; throw e ; } }
t equals ( type ) parameterized types satisfy test
public static TYPE_1 of ( Type type , TYPE_2 < ? > VAR_1 ) { <START> return ( t , ctx ) - > t == type <END> ? Optional . of ( VAR_1 ) : Optional . empty ( ) ; }
public static TYPE_1 of ( Type type , TYPE_2 < ? > VAR_1 ) { return ( t , ctx ) - > t . equals ( type ) ? Optional . of ( VAR_1 ) : Optional . empty ( ) ; }
I check METHOD_4 ( ) _CODE_ ( ) instead ( ! METHOD_6 ( ) METHOD_7 ( ) || METHOD_6 ( ) METHOD_5 ( ) ) wish
private void METHOD_1 ( ) { <START> METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_5 ( ) && ( ! METHOD_6 ( ) . METHOD_7 ( ) || METHOD_6 ( ) . METHOD_5 ( ) ) ) ; <END> }
private void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_5 ( ) && METHOD_4 ( ) . METHOD_7 ( ) ) ; }
bug : uncompilable extra )
public boolean VAR_1 ( ) { <START> if ( ! VAR_2 . VAR_3 ( TYPE_1 . VAR_5 ) ) ) { <END> return false ; } if ( VAR_6 . VAR_7 ( ) ) { return true ; } return VAR_2 . VAR_8 ( ) && ( VAR_2 . VAR_9 ( ) . length > 1 || ! VAR_2 . VAR_10 . isEmpty ( ) || TYPE_2 . VAR_12 ( ) ) ; }
public boolean VAR_1 ( ) { return VAR_2 . VAR_3 ( TYPE_1 . VAR_5 ) && VAR_2 . VAR_8 ( ) ; }
avoid time variables
public final void METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; final String user = null ; <START> final String VAR_2 = STRING_1 ; <END> VAR_1 . METHOD_2 ( user , VAR_2 ) ; }
public final void METHOD_1 ( ) throws Exception { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( null , STRING_1 ) ; }
IllegalStateException thrown ( _CODE_ )
public int METHOD_1 ( ) { if ( VAR_1 == null ) { <START> throw new IllegalStateException ( STRING_1 + VAR_2 + STRING_2 + VAR_3 ) ; <END> } return VAR_1 ; }
public long METHOD_1 ( ) { return VAR_1 ; }
interesting method handle nulls VAR_1 _CODE_ NPE exposed a change test class
<START> public Collection < String > METHOD_1 ( ) { <END> if ( VAR_1 != null ) { return TYPE_1 . METHOD_2 ( VAR_1 ) ; } return Collections . VAR_2 ( ) ; }
public Collection < String > METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( VAR_1 ) ; }
please simplify
protected boolean METHOD_1 ( ) { <START> if ( VAR_1 >= VAR_2 ) { <END> return false ; } return true ; }
protected boolean METHOD_1 ( ) { return VAR_1 < VAR_2 ; }
check default null
public void METHOD_1 ( ) { for ( TYPE_1 key : TYPE_1 . METHOD_2 ( ) ) { <START> METHOD_3 ( key . VAR_1 ( ) , "" , String . format ( <END> STRING_1 , key . getName ( ) ) ) ; } }
public void METHOD_1 ( ) { for ( TYPE_1 key : TYPE_1 . METHOD_2 ( ) ) { METHOD_3 ( String . format ( STRING_1 , key . getName ( ) ) , key . VAR_1 ( ) , "" ) ; } }
avoid copy pasting code reuse code other topnresultbuilders
<START> private boolean METHOD_1 ( String VAR_1 ) <END> { final boolean VAR_2 = VAR_3 . size ( ) < this . VAR_4 ; final boolean VAR_5 = VAR_2 || this . VAR_6 . METHOD_2 ( VAR_3 . METHOD_3 ( ) . METHOD_4 ( ) , VAR_1 ) < 0 ; return VAR_5 && VAR_6 . METHOD_2 ( VAR_1 , VAR_7 ) > 0 ; }
private boolean METHOD_1 ( String VAR_1 ) { final boolean VAR_2 = VAR_3 . size ( ) < VAR_4 ; final boolean VAR_5 = VAR_2 || VAR_6 . METHOD_2 ( VAR_3 . METHOD_3 ( ) . METHOD_4 ( ) , VAR_1 ) < 0 ; return VAR_5 && ( VAR_7 == null || VAR_6 . METHOD_2 ( VAR_1 , VAR_7 ) > 0 ) ; }
reason doesn t TYPE_1 METHOD_2 ( ) ? INT_1 instead 37 ? I changing hashcode formula long doesn t violate equals contract
public int METHOD_1 ( ) { int result = TYPE_1 . METHOD_2 ( entity ) ; <START> result = INT_1 * result + Arrays . VAR_1 ( values ) ; <END> return result ; }
public int METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( entity , Arrays . VAR_1 ( values ) ) ; }
don t need throw exceptions - return null
TYPE_1 METHOD_1 ( TYPE_2 id ) throws TYPE_3 { TYPE_4 VAR_1 = VAR_2 . get ( id ) ; if ( VAR_1 == null ) { <START> throw new TYPE_3 ( STRING_1 + id + STRING_2 + VAR_3 , <END> TYPE_7 . TYPE_5 ) ; } if ( ! VAR_1 . METHOD_2 ( ) ) { throw new TYPE_3 ( STRING_3 + id + STRING_2 + VAR_3 + STRING_4 , TYPE_7 . TYPE_6 ) ; } return VAR_1 ; }
TYPE_1 METHOD_1 ( TYPE_2 id ) { TYPE_4 VAR_1 = VAR_2 . get ( id ) ; return ( VAR_1 != null && VAR_1 . METHOD_2 ( ) ) ? VAR_1 : null ; }
apparently date
public static int getValue ( String text ) { if ( text == null || text . isEmpty ( ) || text . equals ( STRING_1 ) ) { return VAR_1 ; } if ( text . equals ( STRING_2 ) ) { return VAR_2 ; } <START> if ( text . equals ( STRING_3 ) ) { <END> return VAR_3 ; } throw new IllegalArgumentException ( STRING_4 + text ) ; }
public static int getValue ( String text ) { if ( text == null || text . isEmpty ( ) || text . equals ( STRING_1 ) ) { return VAR_1 ; } if ( text . equals ( STRING_2 ) ) { return VAR_2 ; } throw new IllegalArgumentException ( STRING_4 + text ) ; }
! VAR_1 isEmpty ( )
public String METHOD_1 ( Object element ) { if ( element instanceof TYPE_1 ) { String VAR_1 = ( ( TYPE_1 ) element ) . METHOD_2 ( ) ; if ( VAR_1 != null && <START> VAR_1 . length ( ) > 0 ) { <END> return VAR_1 ; } } return super . METHOD_1 ( element ) ; }
public String METHOD_1 ( Object element ) { if ( element instanceof TYPE_1 ) { String VAR_1 = ( ( TYPE_1 ) element ) . METHOD_2 ( ) ; if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { return VAR_1 ; } } return super . METHOD_1 ( element ) ; }
reason catch exceptions
public String METHOD_1 ( String name ) throws IOException { if ( METHOD_2 ( ) != null ) { try ( TYPE_1 is = METHOD_3 ( name ) ) { if ( is == null ) { return TYPE_2 . METHOD_4 ( new File ( name ) , VAR_1 ) ; } return TYPE_3 . toString ( is , VAR_1 ) ; <START> } catch ( Exception e ) { <END> } } return null ; }
public String METHOD_1 ( String name ) throws IOException { if ( METHOD_2 ( ) != null ) { try ( TYPE_1 is = METHOD_3 ( name ) ) { if ( is != null ) { return TYPE_3 . toString ( is , VAR_1 ) ; } } } return TYPE_2 . METHOD_4 ( new File ( name ) , VAR_1 ) ; }
dodaj testowanie drugiego levelu moim zdaniem ten test sfailuje dla levelu 1
<START> public void METHOD_1 ( ) throws Exception { <END> assertEquals ( VAR_1 . METHOD_2 ( 0 ) , VAR_2 ) ; METHOD_3 ( VAR_1 . METHOD_2 ( 0 ) , VAR_3 ) ; }
public void METHOD_1 ( ) throws Exception { assertEquals ( VAR_1 . METHOD_2 ( 0 ) , VAR_2 ) ; METHOD_3 ( VAR_1 . METHOD_2 ( 0 ) , VAR_3 ) ; assertEquals ( VAR_1 . METHOD_2 ( 1 ) , VAR_3 ) ; METHOD_3 ( VAR_1 . METHOD_2 ( 1 ) , VAR_2 ) ; }
I test class optinal empty ( ) - avoiding necessity null ; - )
public Optional < TYPE_1 > METHOD_1 ( final double x , final double y ) { <START> return null ; <END> }
public Optional < TYPE_1 > METHOD_1 ( final double x , final double y ) { return Optional . empty ( ) ; }
I check TYPE_4 instead include otherkind breakpoints properties page example a watchpoint _CODE_ trigger code
public void METHOD_1 ( TYPE_1 element ) { <START> if ( element instanceof TYPE_2 ) { <END> VAR_1 = new TYPE_3 ( ( TYPE_4 ) element , null ) ; } else { VAR_1 = element ; } }
public void METHOD_1 ( TYPE_1 element ) { if ( element instanceof TYPE_4 ) { VAR_1 = new TYPE_3 ( ( TYPE_4 ) element , null ) ; } else { VAR_1 = element ; } }
I don t idea managing transactions table class
private boolean METHOD_1 ( ) { <START> if ( ! TYPE_1 . METHOD_2 ( ) ) { <END> VAR_1 . METHOD_3 ( ) . METHOD_4 ( ) . type ( TYPE_2 . VAR_3 ) . build ( ) . METHOD_5 ( ) ; return true ; } return false ; }
private boolean METHOD_1 ( ) { if ( TYPE_1 . METHOD_2 ( ) ) { return false ; } VAR_1 . METHOD_3 ( ) . METHOD_4 ( ) . type ( TYPE_2 . VAR_3 ) . build ( ) . METHOD_5 ( ) ; return true ; }
good enough emails failed ? addition sending exception frist error rest
public TYPE_1 METHOD_1 ( TYPE_2 < ? extends TYPE_3 > VAR_1 , TYPE_4 session ) throws TYPE_5 { TYPE_6 listener = METHOD_2 ( STRING_1 ) ; TYPE_1 VAR_2 = METHOD_3 ( VAR_1 , session , listener ) ; METHOD_4 ( Long . VAR_3 ) ; Iterator < TYPE_7 > VAR_4 = listener . VAR_5 ( ) ; if ( VAR_4 . hasNext ( ) ) { throw new TYPE_5 ( <START> String . format ( STRING_2 , VAR_4 . next ( ) . METHOD_5 ( ) ) ) ; <END> } return VAR_2 ; }
public TYPE_1 METHOD_1 ( TYPE_2 < ? extends TYPE_3 > VAR_1 , TYPE_4 session ) throws TYPE_5 { TYPE_6 listener = METHOD_2 ( STRING_1 ) ; TYPE_1 VAR_2 = METHOD_3 ( VAR_1 , session , listener ) ; METHOD_4 ( Long . VAR_3 ) ; return VAR_2 ; }
submonitor needed method original monitor passed a single method call
public TYPE_6 . TYPE_7 . File METHOD_1 ( int options , TYPE_2 monitor ) throws TYPE_3 { TYPE_4 <START> VAR_1 = <END> TYPE_4 . METHOD_2 ( monitor ) ; if ( options != VAR_2 . VAR_3 ) return null ; return TYPE_5 . METHOD_3 ( ) . cache ( this , VAR_1 ) ; }
public TYPE_6 . TYPE_7 . File METHOD_1 ( int options , TYPE_2 monitor ) throws TYPE_3 { if ( options != VAR_2 . VAR_3 ) return null ; return TYPE_5 . METHOD_3 ( ) . cache ( this , monitor ) ; }
move tasks _CODE_ constructors
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { super ( VAR_2 , VAR_3 ) ; <START> LOG . info ( STRING_1 ) ; <END> METHOD_1 ( ) ; }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { super ( VAR_2 , VAR_3 ) ; }
i reverse - - check access control existing catalogs I access control impl problems - existing catalogs ( & )
private boolean METHOD_1 ( String VAR_1 ) { return VAR_2 . METHOD_2 ( session . VAR_3 ( ) , TYPE_1 . of ( VAR_1 ) ) . contains ( VAR_1 ) <START> && metadata . VAR_4 ( session , VAR_1 ) ; <END> }
private boolean METHOD_1 ( String VAR_1 ) { return metadata . VAR_4 ( session , VAR_1 ) && VAR_2 . METHOD_2 ( session . VAR_3 ( ) , TYPE_1 . of ( VAR_1 ) ) . contains ( VAR_1 ) ; }
System currentTimeMillis ( ) avoid creating Date objects Date objects ( TYPE_2 ) I guess stuck Long preferable
public static void METHOD_1 ( TYPE_1 VAR_1 ) { <START> Date d = new Date ( new Date ( ) . METHOD_2 ( ) - INT_1 ) ; <END> if ( TYPE_2 . METHOD_3 ( VAR_1 ) != null && d . VAR_2 ( TYPE_2 . METHOD_3 ( VAR_1 ) ) ) { return ; } TYPE_2 . map ( VAR_1 ) . remove ( TYPE_2 . VAR_3 ) ; }
public static void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 . map ( VAR_1 ) . remove ( TYPE_2 . VAR_3 ) ; }
I clear previous VAR_1 s listeners current
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; if ( this . VAR_1 != null ) { <START> this . VAR_1 . METHOD_2 ( ) ; <END> this . VAR_1 . METHOD_3 ( this ) ; this . VAR_1 . METHOD_4 ( this ) ; this . VAR_1 . METHOD_5 ( this ) ; } }
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { if ( this . VAR_1 != null ) { this . VAR_1 . METHOD_2 ( ) ; } this . VAR_1 = VAR_1 ; if ( this . VAR_1 != null ) { this . VAR_1 . METHOD_3 ( this ) ; this . VAR_1 . METHOD_4 ( this ) ; this . VAR_1 . METHOD_5 ( this ) ; } }
info log
private void METHOD_1 ( List < String > VAR_1 , String [ ] VAR_2 ) { StringBuilder VAR_3 = new StringBuilder ( ) ; for ( String log : VAR_1 ) { VAR_3 . append ( log ) ; } String VAR_4 = VAR_3 . toString ( ) ; for ( String VAR_5 : VAR_2 ) { <START> LOG . error ( STRING_1 + VAR_5 ) ; <END> assertTrue ( VAR_4 . contains ( VAR_5 ) ) ; } }
private void METHOD_1 ( List < String > VAR_1 , String [ ] VAR_2 ) { StringBuilder VAR_3 = new StringBuilder ( ) ; for ( String log : VAR_1 ) { VAR_3 . append ( log ) ; } String VAR_4 = VAR_3 . toString ( ) ; for ( String VAR_5 : VAR_2 ) { LOG . info ( STRING_1 + VAR_5 ) ; assertTrue ( VAR_4 . contains ( VAR_5 ) ) ; } }
t find extension shouldn t return VAR_1
private String METHOD_1 ( String VAR_1 ) { int VAR_2 = VAR_1 . METHOD_2 ( STRING_1 ) ; if ( VAR_2 >= 0 ) { return VAR_1 . substring ( 0 , VAR_2 ) ; } <START> return null ; <END> }
private String METHOD_1 ( String VAR_1 ) { int VAR_2 = VAR_1 . METHOD_2 ( STRING_1 ) ; if ( VAR_2 >= 0 ) { return VAR_1 . substring ( 0 , VAR_2 ) ; } return VAR_1 ; }
remove
private static TYPE_1 METHOD_1 ( ) throws Throwable { <START> System . out . println ( STRING_1 ) ; <END> return new TYPE_1 ( STRING_2 ) ; }
private static TYPE_1 METHOD_1 ( ) throws Throwable { return new TYPE_1 ( STRING_2 ) ; }
I weird dropping view creating goal assert throws exception assert
public void METHOD_1 ( ) throws TYPE_1 { METHOD_2 ( ) ; try { VAR_1 . METHOD_3 ( STRING_1 ) ; } catch ( final Throwable a ) { <START> } <END> VAR_1 . METHOD_4 ( METHOD_5 ( STRING_1 ) . METHOD_6 ( METHOD_7 ( METHOD_8 ( ) ) . from ( table ( STRING_2 ) ) ) ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; }
public void METHOD_1 ( ) throws TYPE_1 { METHOD_2 ( ) ; VAR_1 . METHOD_4 ( METHOD_5 ( STRING_1 ) . METHOD_6 ( METHOD_7 ( METHOD_8 ( ) ) . from ( table ( STRING_2 ) ) ) ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; }
adjusting private a breaking change - please public replacing sufficient I
<START> private void METHOD_1 ( ) { <END> VAR_1 . METHOD_1 ( VAR_2 . METHOD_2 ( ) , VAR_2 . METHOD_3 ( ) ) ; }
public void METHOD_1 ( ) { VAR_1 . METHOD_1 ( VAR_2 . METHOD_2 ( ) , VAR_2 . METHOD_3 ( ) ) ; }
need return TYPE_2 VAR_3
public < T > TYPE_1 < T > METHOD_1 ( Class < T > type ) { <START> return ( TYPE_1 < T > ) ( File . VAR_1 . equals ( type ) ? TYPE_2 . VAR_3 : null ) ; <END> }
public < T > TYPE_1 < T > METHOD_1 ( Class < T > type ) { return ( TYPE_1 < T > ) TYPE_2 . VAR_3 ; }
string ? defined messages properties ? won t work translated
public TYPE_1 METHOD_1 ( ) { <START> String item = VAR_1 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; <END> return TYPE_1 . valueOf ( item . VAR_2 ( ) ) ; }
public TYPE_1 METHOD_1 ( ) { int index = VAR_1 . METHOD_3 ( ) ; return TYPE_1 . getValue ( index ) ; }
unnecessary called _CODE_ ( ) super METHOD_1 ( )
public int METHOD_1 ( final TYPE_1 resource , final boolean VAR_1 ) { if ( resource == null ) return 0 ; if ( resource . VAR_2 <= 0 ) return 0 ; <START> if ( ! METHOD_2 ( resource ) ) <END> return 0 ; int VAR_3 = super . METHOD_1 ( resource , VAR_1 ) ; if ( VAR_3 != 0 && VAR_4 != null ) VAR_4 . METHOD_3 ( this ) ; return VAR_3 ; }
public int METHOD_1 ( final TYPE_1 resource , final boolean VAR_1 ) { if ( resource == null ) return 0 ; if ( resource . VAR_2 <= 0 ) return 0 ; int VAR_3 = super . METHOD_1 ( resource , VAR_1 ) ; if ( VAR_3 != 0 && VAR_4 != null ) VAR_4 . METHOD_3 ( this ) ; return VAR_3 ; }
replaced method reference i e VAR_1 = TYPE_3 : : METHOD_2
private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 ; boolean VAR_2 = VAR_3 . equalsIgnoreCase ( STRING_1 ) ; if ( VAR_2 || VAR_4 || VAR_5 ) { VAR_1 = new TYPE_2 ( VAR_2 , VAR_4 , VAR_6 , VAR_7 , VAR_8 , VAR_5 , VAR_9 ) ; } else { <START> VAR_1 = ( ) - > TYPE_3 . METHOD_2 ( ) ; <END> } return VAR_1 ; }
private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 ; boolean VAR_2 = VAR_3 . equalsIgnoreCase ( STRING_1 ) ; if ( VAR_2 || VAR_4 || VAR_5 ) { VAR_1 = new TYPE_2 ( VAR_2 , VAR_4 , VAR_6 , VAR_7 , VAR_8 , VAR_5 , VAR_9 ) ; } else { VAR_1 = TYPE_3 : : METHOD_2 ; } return VAR_1 ; }
return String line
public String METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; String VAR_2 = VAR_1 . METHOD_3 ( ) ; <START> return VAR_2 ; <END> }
public String METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; return VAR_1 . METHOD_3 ( ) ; }
shouldn t modify methods I won t need based merge ( )
public TYPE_1 METHOD_1 ( ) { <START> if ( parent != null ) { <END> return parent . VAR_1 ( ) ; } if ( server != null && ( ( TYPE_2 ) server ) . METHOD_2 ( ) ) { TYPE_3 VAR_2 = ( TYPE_3 ) server ; server = ( TYPE_1 ) METHOD_3 ( VAR_2 ) ; if ( server != VAR_2 ) { if ( METHOD_4 ( ) ) { METHOD_5 ( new TYPE_4 ( this , TYPE_6 . VAR_4 , TYPE_5 . VAR_6 , VAR_2 , server ) ) ; } } } return server ; }
public TYPE_1 METHOD_1 ( ) { if ( server != null && ( ( TYPE_2 ) server ) . METHOD_2 ( ) ) { TYPE_3 VAR_2 = ( TYPE_3 ) server ; server = ( TYPE_1 ) METHOD_3 ( VAR_2 ) ; if ( server != VAR_2 ) { if ( METHOD_4 ( ) ) { METHOD_5 ( new TYPE_4 ( this , TYPE_6 . VAR_4 , TYPE_5 . VAR_6 , VAR_2 , server ) ) ; } } } return server ; }
I don t < T extends Object > needed < T > enough
<START> public < T extends Object > boolean contains ( TYPE_1 < T > VAR_1 ) { <END> return contains ( VAR_1 . name ( ) ) ; }
public < T > boolean contains ( TYPE_1 < T > VAR_1 ) { return contains ( VAR_1 . name ( ) ) ; }
return m method equals ( method ) ; instead line
public boolean equals ( Object o ) { if ( ! ( o instanceof TYPE_1 ) ) return false ; TYPE_1 m = ( TYPE_1 ) o ; if ( m . VAR_1 != VAR_1 ) return false ; if ( m . VAR_2 != VAR_2 ) return false ; <START> if ( ! m . method . equals ( method ) ) return false ; <END> return true ; }
public boolean equals ( Object o ) { if ( ! ( o instanceof TYPE_1 ) ) return false ; TYPE_1 m = ( TYPE_1 ) o ; if ( m . VAR_1 != VAR_1 ) return false ; if ( m . VAR_2 != VAR_2 ) return false ; return m . method . equals ( method ) ) ; }
incrementing count main purpose loop s rewrite loop : ( ; VAR_2 hasNext ( ) ; VAR_2 ( ) ) { + + count ; }
private static int METHOD_1 ( TYPE_1 VAR_1 ) throws Exception { TYPE_2 < TYPE_3 > VAR_2 = VAR_1 . METHOD_2 ( ) ; assertNotNull ( VAR_2 ) ; int count = 0 ; <START> for ( ; VAR_2 . hasNext ( ) ; ++ count ) <END> VAR_2 . next ( ) ; return count ; }
private static int METHOD_1 ( TYPE_1 VAR_1 ) throws Exception { TYPE_2 < TYPE_3 > VAR_2 = VAR_1 . METHOD_2 ( ) ; assertNotNull ( VAR_2 ) ; int count = 0 ; for ( ; VAR_2 . hasNext ( ) ; VAR_2 . next ( ) ) ++ count ; return count ; }
call method METHOD_1 ( String domain ) instead
public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> this . VAR_2 . add ( new TYPE_2 ( VAR_1 . METHOD_2 ( ) , VAR_1 . getName ( ) , VAR_1 . getValue ( ) , <END> VAR_1 . getPath ( ) , VAR_1 . METHOD_3 ( ) , VAR_1 . METHOD_4 ( ) ) ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_1 ( VAR_1 . METHOD_2 ( ) , VAR_1 . getName ( ) , VAR_1 . getValue ( ) , VAR_1 . getPath ( ) , VAR_1 . METHOD_3 ( ) , VAR_1 . METHOD_4 ( ) ) ; }
please define row
public void METHOD_1 ( ) throws IOException { <START> String VAR_1 = null ; <END> VAR_1 = TYPE_1 . METHOD_2 ( STRING_1 , "" ) ; assertTrue ( STRING_2 , VAR_1 . equals ( STRING_3 ) ) ; }
public void METHOD_1 ( ) throws IOException { String VAR_1 = TYPE_1 . METHOD_2 ( STRING_1 , "" ) ; assertTrue ( STRING_2 , VAR_1 . equals ( STRING_3 ) ) ; }
remove line
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 ) ; VAR_1 . METHOD_2 ( VAR_3 ) ; VAR_1 . METHOD_3 ( ) ; <START> System . out . println ( VAR_4 . VAR_5 ) ; <END> TYPE_2 VAR_6 = VAR_1 . METHOD_4 ( VAR_1 . METHOD_5 ( ) , VAR_1 . METHOD_5 ( ) ) ; VAR_6 . METHOD_6 ( ) ; }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 ) ; VAR_1 . METHOD_2 ( VAR_3 ) ; VAR_1 . METHOD_3 ( ) ; TYPE_2 VAR_6 = VAR_1 . METHOD_4 ( VAR_1 . METHOD_5 ( ) , VAR_1 . METHOD_5 ( ) ) ; VAR_6 . METHOD_6 ( ) ; }
read ( long VAR_1 ) VAR_4
private void METHOD_1 ( long VAR_1 , ANNOTATION_1 TYPE_1 VAR_2 ) { TYPE_1 VAR_3 ; try { <START> VAR_3 = read ( VAR_1 , VAR_4 ) ; <END> } catch ( TYPE_2 VAR_5 ) { throw new TYPE_3 ( STRING_1 ) ; } if ( ! VAR_3 . equals ( VAR_2 ) ) { throw new TYPE_4 ( TYPE_5 . VAR_7 ) ; } }
private void METHOD_1 ( long VAR_1 , ANNOTATION_1 TYPE_1 VAR_2 ) { TYPE_1 VAR_3 ; try { VAR_3 = read ( VAR_1 ) ; } catch ( TYPE_2 VAR_5 ) { throw new TYPE_3 ( STRING_1 ) ; } if ( ! VAR_3 . equals ( VAR_2 ) ) { throw new TYPE_4 ( TYPE_5 . VAR_7 ) ; } }
suggestionrm METHOD_2 ( STRING_1 VAR_2 VAR_3 ) ; child unused
public void METHOD_1 ( ) { <START> TYPE_1 child = VAR_1 . METHOD_2 ( STRING_1 , VAR_2 , VAR_3 ) ; <END> TYPE_1 VAR_4 = VAR_1 . METHOD_2 ( STRING_2 , VAR_3 , VAR_5 ) ; assertEquals ( VAR_3 , VAR_4 . METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( VAR_3 ) ; assertEquals ( VAR_2 , VAR_4 . METHOD_3 ( ) ) ; }
public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( STRING_1 , VAR_2 , VAR_3 ) ; TYPE_1 VAR_4 = VAR_1 . METHOD_2 ( STRING_2 , VAR_3 , VAR_5 ) ; assertEquals ( VAR_3 , VAR_4 . METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( VAR_3 ) ; assertEquals ( VAR_2 , VAR_4 . METHOD_3 ( ) ) ; }
isn t correct : javaif ( VAR_1 = = VAR_1 ) { VAR_1 = null ; } properly handle replacement
public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> this . VAR_1 = null ; <END> }
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( this . VAR_1 == VAR_1 ) { this . VAR_1 = null ; } }
t assert request count 2 a base class mock tests more requests
public void METHOD_1 ( TYPE_1 server ) { <START> assertEquals ( server . VAR_1 ( ) , 2 ) ; <END> try { assertEquals ( server . VAR_2 ( ) . METHOD_2 ( ) , STRING_1 ) ; } catch ( InterruptedException e ) { TYPE_2 . METHOD_3 ( e ) ; } }
public void METHOD_1 ( TYPE_1 server ) { assertTrue ( server . VAR_1 ( ) >= 1 ) ; try { assertEquals ( server . VAR_2 ( ) . METHOD_2 ( ) , STRING_1 ) ; } catch ( InterruptedException e ) { TYPE_2 . METHOD_3 ( e ) ; } }
s remove blank lines
void METHOD_1 ( ) throws Exception { <START> <END> TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( TYPE_3 . TYPE_2 . VAR_5 , VAR_6 ) ; assertNotNull ( VAR_1 ) ; assertNotNull ( VAR_1 . getId ( ) ) ; log . info ( STRING_1 + VAR_1 . getId ( ) ) ; }
void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( TYPE_3 . TYPE_2 . VAR_5 , VAR_6 ) ; assertNotNull ( VAR_1 ) ; assertNotNull ( VAR_1 . getId ( ) ) ; LOG . info ( STRING_1 + VAR_1 . getId ( ) ) ; }
HashMap enough
public String toString ( ) { <START> Map < String , Object > VAR_1 = new TYPE_1 < String , Object > ( this . values ) ; <END> VAR_1 . remove ( VAR_2 ) ; return VAR_1 . toString ( ) ; }
public String toString ( ) { Map < String , Object > VAR_1 = new HashMap < String , Object > ( this . values ) ; VAR_1 . remove ( VAR_2 ) ; return VAR_1 . toString ( ) ; }
instance variable inlined
public void METHOD_1 ( ) { VAR_1 = TYPE_1 . METHOD_2 ( TYPE_2 . class ) ; writer = new TYPE_3 ( VAR_1 ) ; VAR_2 = TYPE_1 . METHOD_2 ( TYPE_4 . class ) ; result = TYPE_1 . METHOD_2 ( TYPE_5 . class ) ; <START> server = TYPE_6 . METHOD_3 ( ) ; <END> }
public void METHOD_1 ( ) { VAR_1 = TYPE_1 . METHOD_2 ( TYPE_2 . class ) ; writer = new TYPE_3 ( VAR_1 ) ; VAR_2 = TYPE_1 . METHOD_2 ( TYPE_4 . class ) ; result = TYPE_1 . METHOD_2 ( TYPE_5 . class ) ; }
arguments passed proceeded a space line 173 example
void METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 , boolean VAR_3 ) { final TYPE_1 VAR_4 = TYPE_2 . METHOD_2 ( VAR_1 , VAR_5 . METHOD_3 ( ) , VAR_5 . METHOD_4 ( ) , true , VAR_3 ) ; VAR_4 . METHOD_5 ( STRING_1 , STRING_2 ) ; METHOD_6 ( VAR_2 ) ; <START> } <END>
void METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 , boolean VAR_3 ) { final TYPE_1 VAR_4 = TYPE_2 . METHOD_2 ( VAR_1 , VAR_5 . METHOD_3 ( ) , VAR_5 . METHOD_4 ( ) , true , VAR_3 ) ; VAR_4 . METHOD_5 ( STRING_1 , STRING_2 ) ; }
classy code
public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { <START> METHOD_2 ( TYPE_3 . VAR_3 ) . forEach ( VAR_1 ) ; <END> }
public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { METHOD_1 ( VAR_3 , VAR_1 ) ; }
implement _CODE_ methods avoid casts ( ) boxing
public void METHOD_1 ( int VAR_1 , boolean VAR_2 ) { if ( ! VAR_3 && VAR_2 ) { boolean VAR_4 = false ; synchronized ( VAR_5 ) { <START> if ( VAR_5 . contains ( ( Object ) VAR_1 ) ) { <END> VAR_6 . add ( ( Integer ) VAR_1 ) ; if ( VAR_6 . size ( ) == VAR_5 . size ( ) ) { log . VAR_7 ( STRING_1 , VAR_5 ) ; VAR_4 = true ; } } } if ( VAR_4 ) { METHOD_2 ( true ) ; } } }
public void METHOD_1 ( int VAR_1 , boolean VAR_2 ) { if ( ! VAR_3 && VAR_2 ) { boolean VAR_4 = false ; synchronized ( VAR_5 ) { if ( VAR_5 . contains ( VAR_1 ) ) { VAR_6 . add ( VAR_1 ) ; if ( VAR_6 . size ( ) == VAR_5 . size ( ) ) { log . VAR_7 ( STRING_1 , VAR_5 ) ; VAR_4 = true ; } } } if ( VAR_4 ) { METHOD_2 ( true ) ; } } }
unnecessary
public TYPE_1 METHOD_1 ( int j ) { <START> return METHOD_1 ( j , this . factory ) ; <END> }
public TYPE_1 METHOD_1 ( int j ) { return METHOD_1 ( j , factory ) ; }
need async async guard don T bad METHOD_3
void METHOD_1 ( ) { <START> METHOD_2 ( ) . METHOD_3 ( ( ) - > <END> METHOD_4 ( Messages . TYPE_1 ) ) ; METHOD_5 ( ) . METHOD_6 ( this : : METHOD_7 ) ; }
void METHOD_1 ( ) { METHOD_4 ( Messages . TYPE_1 ) ; METHOD_5 ( ) . METHOD_6 ( this : : METHOD_7 ) ; }
( 1 ) code won t function executed threads simultaneously ; ( 2 ) commands ( run stateless vm case ) behaves properly thread interrupted ? I METHOD_2 running tasks trigger a new task previous canceled
public void METHOD_1 ( ) { try { <START> VAR_1 . METHOD_2 ( true ) ; <END> } catch ( Throwable t ) { log . debug ( STRING_1 , TYPE_1 . METHOD_3 ( t ) ) ; } VAR_1 = VAR_2 . METHOD_4 ( this : : METHOD_5 , 0 , VAR_3 , TimeUnit . VAR_4 ) ; }
public void METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( false ) ; } catch ( Throwable t ) { log . debug ( STRING_1 , TYPE_1 . METHOD_3 ( t ) ) ; } VAR_1 = VAR_2 . METHOD_4 ( this : : METHOD_5 , 0 , VAR_3 , TimeUnit . VAR_4 ) ; }
shouldn t receive a RuntimeException anymore
<START> public TYPE_1 METHOD_1 ( ) throws RuntimeException { <END> for ( TYPE_1 trace : TYPE_2 . getInstance ( ) . METHOD_2 ( ) ) { if ( trace . VAR_1 ( ) . equals ( METHOD_3 ( ) ) ) { return trace ; } } return null ; }
public TYPE_1 METHOD_1 ( ) { for ( TYPE_1 trace : TYPE_2 . getInstance ( ) . METHOD_2 ( ) ) { if ( trace . VAR_1 ( ) . equals ( METHOD_3 ( ) ) ) { return trace ; } } return null ; }
minor : I wouldn t static import clarity
private void METHOD_1 ( TYPE_1 ... VAR_1 ) { <START> METHOD_2 ( METHOD_3 ( VAR_1 ) , asList ( VAR_1 ) ) ; <END> }
private void METHOD_1 ( TYPE_1 ... VAR_1 ) { METHOD_2 ( TYPE_1 . METHOD_3 ( VAR_1 ) , asList ( VAR_1 ) ) ; }
obscure reason change ? a slower iterator a List
public void METHOD_1 ( final TYPE_1 column ) throws TYPE_2 { final TYPE_3 VAR_1 = new TYPE_7 . TYPE_8 ( column ) ; for ( int i = 0 ; i < VAR_2 . size ( ) ; i ++ ) { <START> final TYPE_5 VAR_3 = VAR_2 . get ( i ) ; <END> if ( VAR_3 . METHOD_2 ( VAR_1 ) ) { VAR_3 . append ( VAR_1 ) ; break ; } } VAR_4 . METHOD_3 ( new TYPE_6 ( ) ) ; }
public void METHOD_1 ( final TYPE_1 column ) throws TYPE_2 { final TYPE_3 VAR_1 = new TYPE_7 . TYPE_8 ( column ) ; for ( TYPE_5 VAR_3 : VAR_2 ) { if ( VAR_3 . METHOD_2 ( VAR_1 ) ) { VAR_3 . append ( VAR_1 ) ; break ; } } VAR_4 . METHOD_3 ( new TYPE_6 ( ) ) ; }
won t need test nullity VAR_5 METHOD_4 ( ) : javaif ( VAR_2 equals ( VAR_5 METHOD_4 ( ) ) ) { point VAR_2 null
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { Collection < TYPE_4 > VAR_3 = VAR_1 . METHOD_2 ( ) ; if ( VAR_3 != null && VAR_2 != null ) { for ( TYPE_4 VAR_4 : VAR_3 ) { TYPE_1 VAR_5 = VAR_4 . METHOD_3 ( ) ; <START> if ( VAR_5 . METHOD_4 ( ) != null && VAR_5 . METHOD_4 ( ) . equals ( VAR_2 ) ) { <END> return VAR_5 ; } } } return null ; }
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { Collection < TYPE_4 > VAR_3 = VAR_1 . METHOD_2 ( ) ; if ( VAR_3 != null && VAR_2 != null ) { for ( TYPE_4 VAR_4 : VAR_3 ) { TYPE_1 VAR_5 = VAR_4 . METHOD_3 ( ) ; if ( VAR_2 . equals ( VAR_5 . METHOD_4 ( ) ) ) { return VAR_5 ; } } } return null ; }
I don t I understand works clarify ? a unit tests easier understand long string
public void METHOD_1 ( ) { METHOD_2 ( STRING_1 , STRING_2 ) ; METHOD_2 ( STRING_3 , STRING_2 ) ; METHOD_2 ( STRING_4 , STRING_5 ) ; METHOD_2 ( STRING_6 , STRING_5 ) ; <START> METHOD_2 ( STRING_7 , STRING_8 ) ; <END> METHOD_2 ( STRING_9 , STRING_10 ) ; }
public void METHOD_1 ( ) { METHOD_2 ( STRING_1 , STRING_2 ) ; METHOD_2 ( STRING_3 , STRING_2 ) ; METHOD_2 ( STRING_4 , STRING_5 ) ; METHOD_2 ( STRING_6 , STRING_5 ) ; }
return VAR_2 ( VAR_1 ) ;
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> if ( VAR_2 . containsKey ( VAR_1 ) ) { return VAR_2 . get ( VAR_1 ) ; } return null ; <END> }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return VAR_2 . get ( VAR_1 ) ; }
please project formatter { }
protected boolean METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( VAR_2 ) ; if ( Boolean . VAR_3 . equals ( getParameters ( ) . METHOD_3 ( ) ) && ! METHOD_4 ( VAR_1 . METHOD_5 ( METHOD_6 ( ) ) ) ) { return false ; } <START> else return true ; <END> }
protected boolean METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( VAR_2 ) ; if ( Boolean . VAR_3 . equals ( getParameters ( ) . METHOD_3 ( ) ) && ! METHOD_4 ( VAR_1 . METHOD_5 ( METHOD_6 ( ) ) ) ) { return false ; } else { return true ; } }
exception ! = null || response = = null || ! response trim ( ) startsWith ( STRING_1 ) { return ; } catch
private void METHOD_1 ( ) { <START> try { <END> if ( this . response != null && this . response . trim ( ) . startsWith ( STRING_1 ) ) { METHOD_2 ( ) ; } } catch ( Exception e ) { e . VAR_1 ( ) ; if ( this . exception == null ) { this . exception = e ; } } }
private void METHOD_1 ( ) { if ( this . exception != null || this . response == null || ! this . response . trim ( ) . startsWith ( STRING_1 ) ) { return ; } try { METHOD_2 ( ) ; } catch ( Exception e ) { e . VAR_1 ( ) ; if ( this . exception == null ) { this . exception = e ; } } }
don t need = = true s a boolean : - )
private boolean METHOD_1 ( List < Pair < Guid , Boolean > > VAR_1 ) { for ( Pair < Guid , Boolean > VAR_2 : VAR_1 ) { <START> if ( VAR_2 . METHOD_2 ( ) == true ) { <END> return true ; } } return false ; }
private boolean METHOD_1 ( List < Pair < Guid , Boolean > > VAR_1 ) { for ( Pair < Guid , Boolean > VAR_2 : VAR_1 ) { if ( VAR_2 . METHOD_2 ( ) ) { return true ; } } return false ; }
check String empty change default : ( ! VAR_1 isEmpty ( ) )
public String METHOD_1 ( ) { TYPE_1 . METHOD_2 ( VAR_1 , STRING_1 ) ; <START> if ( ! VAR_1 . equals ( STRING_2 ) ) { <END> return String . format ( STRING_3 , VAR_1 , VAR_2 ) ; } return VAR_2 ; }
private String METHOD_1 ( ) { if ( ! VAR_1 . isEmpty ( ) ) { return String . format ( STRING_3 , VAR_1 , VAR_2 ) ; } return VAR_2 ; }
VAR_2 parameter Class ( 8 method declaration ) I suppose add parameter future easier clean
public void METHOD_1 ( final String VAR_1 , <START> final TYPE_1 VAR_2 ) { <END> if ( VAR_1 != null && VAR_1 . trim ( ) . length ( ) > 0 && METHOD_2 ( ) instanceof TYPE_2 ) { final TYPE_2 VAR_3 = ( TYPE_2 ) METHOD_2 ( ) ; VAR_3 . METHOD_3 ( VAR_1 ) ; VAR_3 . METHOD_4 ( ) ; } }
public void METHOD_1 ( final String VAR_1 , final TYPE_1 VAR_2 ) { if ( VAR_1 != null && METHOD_2 ( ) instanceof TYPE_2 ) { final TYPE_2 VAR_3 = ( TYPE_2 ) METHOD_2 ( ) ; VAR_3 . METHOD_3 ( VAR_1 ) ; VAR_3 . METHOD_4 ( ) ; } }
point logs ? flag service processing debug : _CODE_ outputted
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { <START> TYPE_3 . METHOD_2 ( this . getClass ( ) ) ; <END> METHOD_3 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { METHOD_2 ( this . getClass ( ) ) ; METHOD_3 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; }
supposed throw exception ( i guess ) add afail statement stating exception thrown
public void METHOD_1 ( ) { exception . VAR_1 ( IllegalStateException . VAR_2 ) ; TYPE_1 message = METHOD_2 ( TYPE_1 . VAR_2 ) ; when ( message . VAR_3 ( ) ) . METHOD_3 ( VAR_4 ) ; try { <START> VAR_5 . METHOD_4 ( message ) ; <END> } finally { METHOD_5 ( VAR_6 , METHOD_6 ( 0 ) ) . METHOD_7 ( ) ; METHOD_5 ( VAR_6 , METHOD_6 ( 0 ) ) . METHOD_8 ( ) ; METHOD_9 ( VAR_6 ) ; } }
public void METHOD_1 ( ) { TYPE_1 message = METHOD_2 ( TYPE_1 . VAR_2 ) ; when ( message . VAR_3 ( ) ) . METHOD_3 ( VAR_4 ) ; exception . VAR_1 ( IllegalStateException . VAR_2 ) ; try { VAR_5 . METHOD_4 ( message ) ; } finally { METHOD_5 ( VAR_6 , METHOD_6 ( 0 ) ) . METHOD_7 ( ) ; METHOD_5 ( VAR_6 , METHOD_6 ( 0 ) ) . METHOD_8 ( ) ; METHOD_9 ( VAR_6 ) ; } }
need explicitly
public TYPE_1 ( ) { this . VAR_2 = true ; <START> this . VAR_3 = "" ; <END> }
public TYPE_1 ( ) { VAR_2 = true ; VAR_3 = "" ; }
needed
public static void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 instanceof TYPE_2 ) { TYPE_2 VAR_2 = ( TYPE_2 ) VAR_1 ; if ( ! VAR_2 . METHOD_2 ( ) . isEmpty ( ) && VAR_2 . METHOD_3 ( ) . isEmpty ( ) ) { throw new TYPE_3 ( STRING_1 ) ; } } else if ( VAR_1 instanceof TYPE_4 || VAR_1 instanceof TYPE_5 ) { METHOD_1 ( VAR_1 . METHOD_4 ( 0 ) ) ; } else { <START> return ; <END> } }
public static void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 instanceof TYPE_2 ) { TYPE_2 VAR_2 = ( TYPE_2 ) VAR_1 ; if ( ! VAR_2 . METHOD_2 ( ) . isEmpty ( ) && VAR_2 . METHOD_3 ( ) . isEmpty ( ) ) { throw new TYPE_3 ( STRING_1 ) ; } } else if ( VAR_1 instanceof TYPE_4 || VAR_1 instanceof TYPE_5 ) { METHOD_1 ( VAR_1 . METHOD_4 ( 0 ) ) ; } }
method called _CODE_ ( ) METHOD_3 ( ) null - check CDA result a _CODE_ instead ID parameters
protected Map < String , Pair < String , String > > METHOD_1 ( ) { if ( METHOD_2 ( ) ) { <START> return Collections . VAR_1 ( METHOD_3 ( ) . getId ( ) . toString ( ) , TYPE_1 . VAR_3 ) ; <END> } return Collections . VAR_4 ; }
protected Map < String , Pair < String , String > > METHOD_1 ( ) { if ( METHOD_3 ( ) != null && METHOD_2 ( ) ) { return Collections . VAR_1 ( METHOD_3 ( ) . getId ( ) . toString ( ) , TYPE_1 . VAR_3 ) ; } return null ; }
removing explicit initialization : worse
public void run ( ) { <START> TYPE_1 VAR_1 ; <END> TYPE_2 outputStream = null ; try { VAR_1 = VAR_2 . METHOD_1 ( ) ; String response = METHOD_2 ( VAR_1 ) ; outputStream = VAR_1 . METHOD_3 ( ) ; METHOD_4 ( outputStream ) ; write ( response . VAR_3 ( ) , outputStream ) ; outputStream . VAR_4 ( ) ; } catch ( IOException e ) { } finally { TYPE_3 . METHOD_5 ( outputStream ) ; } }
public void run ( ) { TYPE_1 VAR_1 = null ; TYPE_2 outputStream = null ; try { VAR_1 = VAR_2 . METHOD_1 ( ) ; String response = METHOD_2 ( VAR_1 ) ; outputStream = VAR_1 . METHOD_3 ( ) ; METHOD_4 ( outputStream ) ; write ( response . VAR_3 ( ) , outputStream ) ; outputStream . VAR_4 ( ) ; } catch ( IOException e ) { } finally { TYPE_3 . METHOD_5 ( outputStream ) ; } }
delete rule ? IIRC reason ensure smudged entries stayed smudged change smudge logic length based longer sense a source bugs selecting modified files potentially racily clean
public final boolean METHOD_1 ( final int VAR_1 , final int VAR_2 ) { final int VAR_3 = VAR_4 + VAR_5 ; final int VAR_6 = TYPE_1 . METHOD_2 ( info , VAR_3 ) ; <START> if ( VAR_1 < VAR_6 ) <END> return true ; if ( VAR_1 == VAR_6 ) return VAR_2 <= TYPE_1 . METHOD_2 ( info , VAR_3 + 4 ) ; return false ; }
public final boolean METHOD_1 ( final int VAR_1 , final int VAR_2 ) { final int VAR_3 = VAR_4 + VAR_5 ; final int VAR_6 = TYPE_1 . METHOD_2 ( info , VAR_3 ) ; if ( VAR_1 == VAR_6 ) return VAR_2 <= TYPE_1 . METHOD_2 ( info , VAR_3 + 4 ) ; return false ; }
METHOD_1 ( ) called move start ( ) start ( ) stop ( ) symmetrical
<START> private void METHOD_1 ( ) { <END> if ( VAR_1 != null ) { Log . VAR_2 ( TAG , STRING_1 ) ; return ; } VAR_3 = ( TYPE_1 ) METHOD_2 ( Context . VAR_4 ) ; VAR_5 = VAR_3 . METHOD_3 ( TYPE_1 . VAR_6 ) ; VAR_1 = new TYPE_2 ( TYPE_3 . METHOD_4 ( ) , this ) ; VAR_7 = TYPE_4 . METHOD_5 ( ) ; VAR_7 . METHOD_1 ( TYPE_5 . this ) ; }
private void METHOD_1 ( ) { }
please perform VAR_1 calls a finally block _CODE_ released assert fails
public void METHOD_1 ( ) { TYPE_1 buf = TYPE_2 . buffer ( ) ; TYPE_3 . METHOD_2 ( new byte [ ] { } , TYPE_4 . METHOD_3 ( buf ) ) ; <START> buf . VAR_1 ( ) ; <END> }
public void METHOD_1 ( ) { TYPE_1 buf = TYPE_2 . buffer ( ) ; try { TYPE_3 . METHOD_2 ( new byte [ ] { } , TYPE_4 . METHOD_3 ( buf ) ) ; } finally { buf . VAR_1 ( ) ; } }
please add braces expression reformat
public String METHOD_1 ( ) { <START> if ( METHOD_2 ( ) == null ) <END> return "" ; return METHOD_2 ( ) . METHOD_3 ( ) ; }
public String METHOD_1 ( ) { if ( METHOD_2 ( ) == null ) { return "" ; } return METHOD_2 ( ) . METHOD_3 ( ) ; }
calling a method class want drop TYPE_2 prefix
private static boolean METHOD_1 ( TYPE_1 params ) { Boolean VAR_1 = params . VAR_2 ( ) ; return VAR_1 != null ? VAR_1 : <START> TYPE_2 . METHOD_1 ( params . VAR_3 ( ) . getId ( ) ) ; <END> }
private static boolean METHOD_1 ( TYPE_1 params ) { Boolean VAR_1 = params . VAR_2 ( ) ; return ( VAR_1 != null ) ? VAR_1 : METHOD_1 ( params . VAR_3 ( ) . getId ( ) ) ; }
1 Integer VAR_3 a magic number instead ( arguably more logical ) null a lack location fix ? ( need change return type Integer object int primitive ) 2 formatting yuck ! 3 return branch ; else branch return inline instead a VAR_2 variable
private int METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; final int VAR_2 ; if ( VAR_1 == null ) { <START> VAR_2 = Integer . VAR_3 ; } <END> else { final TYPE_2 VAR_4 = TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) ; VAR_2 = VAR_4 . METHOD_5 ( VAR_1 ) ; } return VAR_2 ; }
private Integer METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 != null ) { final TYPE_2 VAR_4 = TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) ; return VAR_4 . METHOD_5 ( VAR_1 ) ; } return null ; }
knew
public void METHOD_1 ( ) { final TYPE_1 VAR_1 = TYPE_2 . create ( 10 , 0 ) ; assertEquals ( VAR_2 , VAR_1 . METHOD_2 ( VAR_3 ) ) ; assertEquals ( VAR_4 , VAR_1 . METHOD_2 ( new TYPE_3 ( 10 ) ) ) ; assertEquals ( VAR_4 , VAR_1 . METHOD_2 ( VAR_1 . METHOD_2 ( VAR_5 ) ) ) ; <START> assertEquals ( VAR_4 , VAR_1 . METHOD_2 ( VAR_1 . METHOD_2 ( VAR_5 ) ) ) ; <END> assertEquals ( VAR_4 , VAR_1 . METHOD_3 ( VAR_1 ) . METHOD_2 ( VAR_5 ) ) ; }
public void METHOD_1 ( ) { final TYPE_1 VAR_1 = TYPE_2 . create ( 10 , 0 ) ; assertEquals ( VAR_2 , VAR_1 . METHOD_2 ( VAR_3 ) ) ; assertEquals ( VAR_4 , VAR_1 . METHOD_2 ( new TYPE_3 ( 10 ) ) ) ; assertEquals ( VAR_4 , VAR_1 . METHOD_2 ( VAR_1 . METHOD_2 ( VAR_5 ) ) ) ; assertEquals ( VAR_4 , VAR_1 . METHOD_3 ( VAR_1 ) . METHOD_2 ( VAR_5 ) ) ; }
worst happen values log message precise
boolean METHOD_1 ( int VAR_1 ) { synchronized ( VAR_2 ) { boolean VAR_3 = ! VAR_4 . METHOD_2 ( ) && VAR_1 > 0 ; boolean VAR_5 = VAR_4 . METHOD_2 ( ) && VAR_1 > ( int ) ( VAR_4 . METHOD_3 ( ) ) ; <START> return VAR_3 || VAR_5 ; <END> } }
private boolean METHOD_1 ( int VAR_1 ) { synchronized ( VAR_2 ) { boolean VAR_3 = ! VAR_4 . METHOD_2 ( ) && VAR_1 > 0 ; boolean VAR_5 = VAR_4 . METHOD_2 ( ) && VAR_1 > ( int ) ( VAR_4 . METHOD_3 ( ) ) ; return VAR_3 || VAR_5 ; } }
preferable create a new method error propagation
public TYPE_1 get ( ) { if ( VAR_1 == null ) { synchronized ( this ) { if ( VAR_1 == null ) { try { METHOD_1 ( ) ; } catch ( IOException e ) { <START> throw new RuntimeException ( e ) ; <END> } } } } return VAR_1 ; }
public TYPE_1 get ( ) { if ( VAR_1 == null ) { synchronized ( this ) { if ( VAR_1 == null ) { METHOD_1 ( ) ; } } } return VAR_1 ; }
private ? private method _CODE_ I place new method _CODE_ I don t _CODE_ ( ) method need a recursive search TYPE_1 _CODE_ _CODE_ extended check case
<START> protected List < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { <END> List < TYPE_1 > result = new ArrayList < > ( ) ; for ( TYPE_3 e : VAR_1 . METHOD_2 ( ) ) { if ( e instanceof TYPE_1 ) { result . add ( ( TYPE_1 ) e ) ; } else if ( e instanceof TYPE_2 ) { result . addAll ( METHOD_1 ( ( TYPE_2 ) e ) ) ; } } return result ; }
private List < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { List < TYPE_1 > result = new ArrayList < > ( ) ; for ( TYPE_3 e : VAR_1 . METHOD_2 ( ) ) { if ( e instanceof TYPE_1 ) { result . add ( ( TYPE_1 ) e ) ; } else if ( e instanceof TYPE_2 ) { result . addAll ( METHOD_1 ( ( TYPE_2 ) e ) ) ; } } return result ; }